labofsahil/github-event-dataset-2012 huggingface dataset:
oh so just removed that thing, I think the answer is actually how to detect the symfony root directory without doing this hack but i just couldnt find another way, as this is temporary before we migrate the phpspec command into console command which is what we are working, it i sjust that we are specking PHPSpecBundle with PHPSpec so it is hard to bring the chicken before the hen
Less code is nice.  It does feel a bit weird that CommandRunner in your patch has this extra cleaning function.
Hi,

Thanks for the notice. This is now fixed : https://github.com/jamoma/JamomaDoc/commit/0621fafb257dca33a00aa2a913e631d08ab488dd

Julien


Le 18 fvr. 2012  09:14, Nils Peters a crit :

> Hi Julien,
> 
> when generating the refpages, the filepath to the pictures is absolute e.g., 
> 
>     <example img='/Users/nilspeters/Documents/gits/Jamoma/Modules/Documentation/Max/refpages/Modular/images/jcom.stats.png'/>
> 
> would it be possible to have a relative path e.g.,  
> 
>     <example img='images/jcom.stats.png'/> 
> 
> ?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/jamoma/JamomaDoc/commit/33fc037a9f3c2966c871369e249334a70656ce9a#commitcomment-980806
Thanks for the pointer, I'll add it!
In this commit you have simply overwritten all the modification to doc/ug/analysis.tex that I have done here: https://github.com/espressomd/espresso/commit/e155d4a924bf246d41b70e83bbba99b440d82f43
The etag should be based on the metadata icontime that is set when a user uploads or crops the avatar.
Don't you think it will be more appropriate to raise an error instead of setting an inappropriate (empty string) `msg` and `title`?
@mpapis you go, man. So glad to see this!
private
 
def loader
@product = Product.find(params[:id])
end
seems weird to redefine `$els` here.
And nope.
Good catch, but I was way too much in python mode when I wrote this.  I don't even free on the normal path.  I just pushed a commit to fix that.
wouldn't it avoid this windows related side effect to simply encapsulate f.mkdirs() inside if (f.exists()) { .. } ?
being public API, maybe some external code expect getRootDir() to create the directory structure, so please don't change the current behavior
You should probably look in my branch for a similar fix to knj_strings::utf8force().
Here is "dash", not "minus" in English version.

Well, we often call "-" "minus" in Chinese.
dregad, in order to be able to reproduce this, the function must be called with a specific version as the first parameter (to set the selected one), and ALL_PROJECTS as the second parameter, or null when 'All projects' is selected.

I've checked, and the function doesn't get called with these parameters from anywhere within the standard Mantis. In order to be able to reproduce this, you'd have to change the code somewhere or find a plugin where this combination of parameters is used.

I encountered this myself in the plugin I'm writing, on the 'resource allocation' page (think I'm going to rename that page though), so you could reproduce it from there. Or do you believe using those two parameters together to be invalid use of the function ?
I think you need to use `extension_loaded()`.
parens on this call
problem is, that the session will be initalized with this request
Oops! This was meant to be "Made splash potions abide by PVP settings."
So the idea here is that we pass in what the user added, and must return what should really be added?  Isn't the majority case to simply "return asset;"?

IMO this may extend the contract here really beyond that of a generic listener / event handler.

I also wonder about the name of both the interface and the method.  Will garner some community feedback.
As of this time nothing is actually pulling this code in.  Changes still have to happen to __init__.py before this can work seamlessly.
Al hacer este cambio desde el lado de los de web, se demuestra un merge con el lado de traduccion, ya que modifican el mismo archivo, en otro punto... (agregando idioma efe)
Shouldn't this be ratio-serializer?
checking if comments in github show up in PT
You say to protect the remove_contact function against a None?
not sure if this fixes this issue, i fixed this locally by adding a try/except block around the getElementsByTagName.
Sounds good! I'll create a new pull request.
You missed one bro. Plz see pull request #1.
In my project I'm using plone.postpublicationhook that depends on ZPublisherEventsBackport, which in turn applies plone.app.linkintegrity's get_module_info patch on purpose. As I understand, patch is done using positional and keywords arguments (*args, **kw) which makes func_defaults equal to None.

When I'm not using plone.postpublicationhook then plone.app.linkintegrity's patch is not installed in testing environment, so no issues encountered then.
Your example really depends on the order of things, and one cannot expect either the file to exist or not if things were happening in parallel without any synchronization.

The prepare_atomic_for_write will return ECANCELED in case it was trying to clone the old object to the shadow object, but found out that the old object is different. In this case we behave as if we removed the old object but there was some other modification that followed.
Hmm I suppose that's a good point. 

We don't use that style internally, at least. Would you like to open an issue with an example page that breaks with this logic? Happy to try and address it (...or accept a pull :) ).


On Feb 29, 2012, at 8:00 PM, Markus Staab wrote:

> should this depend on the css attribute "box-sizing"? e.g. border-box?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/jquery/jquery-mobile/commit/84f1e4f257268b4b8d6132065263702e61074797#commitcomment-1025709
I suggest:

"It is recommended that test methods be written so that they are independent of the order that they are executed."
Hey, use the method  countEntities() in my Level.java https://github.com/Flet/Catacomb-Snatch/blob/master/src/com/mojang/mojam/level/Level.java

Then it should be easy to limit to just Mobs: 

    if(level.countEntities(Mob.class) >= 1000)
I'll check it out, cheers!


On 2 Feb 2012, at 19:36, Christoph Buchner wrote:

> couldn't you just wrap the non-safe code in some `mutex`es or something even smarter (Active objects I read about)? 
> btw, possibly ofLog gets some overhaul soon (due to other issues), so maybe now is the time to pitch in: https://github.com/openframeworks/openFrameworks/issues/858
> No i haven't had any issues with thread safety, yet. Haven't had to deal with it, anyway.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/tgfrerer/ofxPlaylist/commit/90612164074b84f7022760b72b2d7e4cc0b81f51#commitcomment-927538
+INTSERT INTO userRep VALUES (0, kb,pwd);
```cgBase.checkFields()``` is only referenced from a single location and is private debug code, too. And yes, it's not part of this commit. But if you remove private debug code.......
I think we need to involve Neil in this; I think bndtools has this information in-memory (or should have it).
What's the purpose of this change? We do not want to add versioning for the xcode project, as it changes contantly. This is only supposed to be generated in release builds
Thanks, got those issues taken care of this morning.  Any additional
proofing would of course be appreciated!  No hurry though.


On Mon, Jan 16, 2012 at 2:40 AM, jochenberger <
reply@reply.github.com
> wrote:

> Sure, I'll happily do that, but I won't be able to go into detail before
> at least Thursday I'm afraid.
>
> With 42b8385a404554a3e768ed59c3828a914fc62fdb, I get
>
>    jasmine-headless-webkit -j spec/jasmine.yml -c
>
>    Running Jasmine specs...
>    ........................F...................
>    FAIL: 44 tests, 1 failure, 4.588 secs.
>
>
>    Flotr Plots should draw a `Advanced Markers`line graph.
> (Flotr2/spec/Flotr.js:3)
>      TypeError: 'undefined' is not an object
>    make: *** [test] Fehler 1
>
> When using the pre-built library, I get some issues with empty charts with
> mouse tracking enabled, i.e.: series is undefined in flotr.js:5116
>    xaxis = series.xaxis;
>
> Apart from that, everything looks fine upon first glance.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/HumbleSoftware/Flotr2/commit/91752f20dea7a4c727e0c3726d28002b6eacd26c#commitcomment-869918
>
Thanks for the info but this is what php-activerecord uses in other placs. Maybe I'll do a code cleanup for the whole library later.
We're getting rid of these headers as we move stuff over into the overlay.
could you add project for xCode? I'm trying to add hyphenator.h and hyphenator.cpp and get some errors.
//replace 'char' for unicode support
typedef char unichar;
Typedef redefinition with different types ('char' vs 'unsigned short')

and warnings:
while (test_words[word_index]) {
		struct word_hyphenation_t *wh = hyphenate_word(test_words[word_index], plist, marker);
Incompatible pointer types passing 'const char *' to parameter of type 'const unichar *' (aka 'const unsigned short *')

So I don't understand why. Could you help me? Is it possible please make console project.
The asynchronous nature is only relevant if the input to the SAX parser is chunked. Since write() is being called with the whole string, the parser completes and invokes the "end" or "error" callbacks in the same thread of execution. So when parseString() returns we can count on the relevant callback having already been invoked.
FWIW - removed this from database. attr_accessor's only now (payment, verification code).
Hey, it's already supported: https://github.com/netzpirat/guard-rspectacle/commit/4699596064ac4a097b03c749a1985a5c4d630204#L0R36
ah ich stehe drauf
Ah forget what I said then ;)
On Mar 9, 2012 3:28 PM, "Tom Bentley" <
reply@reply.github.com>
wrote:

> But #187 is concerned with what model annotations are generated :
> Specifically it's checking that the `@Ignore` annotation is generated, so
> putting `@nomodel` in the .ceylon would be breaking the test. At least
> that's how I read the #187...
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/ceylon/ceylon-compiler/commit/f79967321cbb1219658083d27265404e7715bd72#commitcomment-1065750
>
And 0.8.1 works? Let me debug
M_PI_F I think it was :)
that should contain a "\n" too but you get the idea
Some context:

Goal of canonical rel is to create a single URL for pages that serve duplicate content. So in the case of pagination if we take the taxon media tab as an example, the following URLs serve the same content:

/pages/:id/media
/pages/:id/media?page=1

Whereas /pages/:id/media?page=2 serves different content to page 1.

So my goal with the regex is to allow page numbers > 1 but if the param is page=1 (or page=01 as you pointed out) the param should be removed from the canonical URL. The use of .* I agree is a bit casual and we could restrict it to integers only. What would be the best way to write regex to allow any integer value greater than 1?

Side note: whether to treat pagination as unique content or make all paginated content point to the first page is a contentious issue. Google appears to advise against it as their intentions for rel canonical are for duplicate content pages, so I'm waiting for further feedback and this regex may be ditched.
That's true. Fixed. Thanks.
Is it really necessary to restrict yourself to minutes (here and in other sections) ? Maybe a more generic time representation would be better.
What's this and why it is verified?
hahaha, you missed the other ones
Yeah, we usually end up discussing `load` in class because we do lots of IRB work, and we want to reload the external file. So this is an artifact of that. JSTwitter (soon to be renamed! heh) is probably late enough that talking about `$:` is a good idea.
Do you want to just expose the main -ks_normalizedURL method and not the individual normalizations? That would streamline the public interface. I don't know how often the individual normalizations would be used by themselves.

ks_ sounds good

I've got tests for the URL normalizations, but I didn't separate them from the main project test file, so they weren't ready to check in. I'll break them out and then add to this repo. How do you like to name the test source files?
Please do not upload IMPSDev/gen/com/imps/R.java ...
Move this class into the MutatorAssembly to make more "production" like. Thar means that you just drop the assembly in the bin folder and it will just work.
I haven't looked at any of your code, but why not super perms only. Im tired of plugins supporting old systems personally.
ctrl + shift + f.  to format the code.
I'm really sorry to keep doing this accidental adding to the master branch guys, will cut it out!
C:\> 프로그램.exe 파일이름

과 같이 실행해야되요. 유닉스 기반에서 작업했기때문에 윈도우 유저들은 힘들 수도 있지만, 열의를 가지고 테스트해보시길
Is this live? On page http://sudweb.fr/2012/orateurs/ the sixth speaker still has two links with identical text but different destinations.
Imo implementing this properly (this is only half implemented, air can't flow between levels for example, nor can you fall down holes) would cause more problems than it is worth, as on the Luna.
Programmer authored!!! That's what I get for checking in from cygwin instead of the git bash shell.  I hate windows...
I guess you are right that it might just be what most are using, not an actual coding standard.
That's really ugly. Why comment out rather than fixing? When the pull request was merged, some of my production code broke.

I'll fix it, but I am a bit surprised that we are merging in master code that breaks existing functionality. Granted, I can't really complain: I should have reviewed the pull request :)
No worries. I always keep an eye on our forks and just wanted to follow up with you :)
Get rid of this error message part - use the form.
For the ones who use the Debian Stable Dovecot deb from repos, modifications recently adopted to the plugin were disfunctional
If we use globals here, `removeEventListener` for `AutoPatchWork.pageloaded` won't work correctly for the current instance.
Hello

That seems to be exactly what I need. The example seems to be straightforward and simple.

I built the program, but now I try to run "python example.py"


python example.py
Traceback (most recent call last):
  File "example.py", line 1, in <module>
    import vjoy, math
ImportError: No module named vjoy

So I need to install the vjoy module somewhere. I have no idea where to. :)
Please indent all this file like the rest of the code (4-space indent).
Ideally, I think Puppet should add the vardir fact. This way the fact will only be present when running puppet and puppet is the authoritative source for its vardir. Doing so would eliminate the need for Facter::Util::PuppetSettings.
this too - libs are built
Not from sniffs, this is just a proc event, the talent is supposed to proc on a critical hit with certain spells, http://www.trinitycore.info/Spell_proc_event_tc2
No, it's a silly typo. Sorry.
I think it should be ~/.fonts. The path is set in fonts.conf (/etc/fonts/fonts.conf in debian):

```
<!-- Font directory list -->
        <dir>/usr/share/fonts</dir>
        <dir>/usr/X11R6/lib/X11/fonts</dir> <dir>/usr/local/share/fonts</dir>
        <dir>~/.fonts</dir>
```

Info: http://www.freedesktop.org/software/fontconfig/fontconfig-user.html
I was thinking about more from the perspective of "there's a normal way of specifying a callback in PHP, let's use that".

Closures/inline functions aren't a code smell, they're just unusual in PHP.  It's one thing to avoid doing things that make us require PHP 5.3, it's another to design the API so as to prevent the use of PHP 5.3 features in project code. ;-)

Admittedly, with `get_template_global_variables` (as it's renamed to in a later commit) being a static method, it's difficult to see a use for an instance variable.  Instance variables would become more useful if template globals were passed in with D.I, as relevant instantiated objects.

We could, for instance, provide a fewer number of TemplateGlobalProviders: either one for all of the default objects, or a couple of them in natural partitions.  It seems inappropriate coupling that SecurityToken needs to know about the template engine.

My thinking: let's mark the API as "experimental", so that we can get away with changing it in 3.1, or before 3.0 stable, if needs be.  It's going to be a fairly hardy developer who is building their own template global providers.
Typo; this is now the last line.
The implementation of MVC I use here is not the standard implementation that you would see from frameworks like Zend, Cake PHP etc.
I have component library which can be used as a based to build an MVC system, it's called CribzLib and you can find it on my github. It is pretty straight forward. For what purpose do you need a MVC system for, sometimes it can be overkill.

Thanks for the interest in my work. Feel free to email me with any question if you need any help: chris@cribznetwork.com
I'm not convinced that all those params are required, once you determine tool(-model) and version any key/value is unique enough; classNames, template identifier, ... shouldn't be required any more here.
Since path isn't set by default, I think this will need to be `path || '/'`. Or path will need to be set to '/' by default. Either way I suspect this may break things if you didn't pass a path along. Thoughts?
ah..  I add this 'wait for ip' section , assuming VM Tools is installed.   In the case VMTools is not installed, we can't get IP using Fog or other vSphere API client, so can't SSH to the VM to do software provisioning automatically.
Hi there, you are right that python's 2to3 takes care of this issue, replacing "basestring" with "str". The only problem I had is that "python3 setup.py test" does not seem to run 2to3 on the code base, so it bails out with "basestring does not exist" kind of error.

The real fix will be to run 2to3 on the code base before invoking the tests then, I guess. Ignore this patch then.
Why `logger.fatal` here, when this is not actually a fatal error? We just go on and ignore the hash, right?
Agreed. I'll switch to `result.push.apply()` and removing the `shallow` will also clear this up.
ImgButton can be inherited from TextButton whose init function calls the init function of TextButton and then create a Image child node
Sure. I'll add the reference so Sonatype too. The link to the zip file I provided is the exact clone of the current codebase in a zip ball. In other words, it'd be exactly as if you cloned the repo through `git clone`.
this asInstanceOf shouldn't be needed, I think that was something added when we had problems with overloaded signatues
default argument with Seq.empty and remove the accept overload?
Doh, of course! (I only use _ as first letter for hidden members, not for method-private fields)
So, deprecate "timerActive_?" and make a new method "isTimerActive" in both FSM and TestFSMRef?

(I'm guessing I can't just rename the method in TestFSMRef because it's also a public interface.)

Also I'll change all references to the deprecated methods in code and docs.

Should I do the deprecating/renaming work in a separate pull request? Otherwise this pull request might get quite noisy.
actually not, second parameter list not used in equals

    scala> case class Foo(s: String)(i: Int)
    defined class Foo

    scala> Foo("aa")(3) == Foo("aa")(2)
    res11: Boolean = true


I have added a check on addressTerminated also.
Just let new do this test.
We tested it with a student here who specializes  on signal processing and DSI. He made a small matrix with some symmetries and checked when you get complex values rather than real ones.  I think it is good idea to add something like that later.
The dictionary is defined after (further down the file than) its usage here, making it hard to read the code.  If we could move things so that they're defined before they're used, that'd be great.
Plugins need three things for the decision:
* The file type (maybe more but a least this)
* Knowledge whether the resource is on the same domain (if the preview depends on that)
* Knowledge whether the proxy is available (see point 2)

So, I think they need the information at both points. The decision and the url. There might be a case where the proxy is disabled and then the resource cannot be previewed.
In my enthusiasm for deletion all the formalchemy stuff has gone too so no controller etc - david was keen for this
Huh? Docstring seems wrong.
I don't want to muck around with actual playback in tests; can't you do this without actually starting mpd?
Yeah, the id is a constant and Card[id] is fast enough anyway
Ah, BUT WHAT DOES IT RETURN!?
Call this `step_num_to_job_log_step_num`? Or something like?
That seems like a more intuitive naming convention.
Check path with manu to sync up with cluster manager prefix?
À supprimer.
Sobrou aqui ainda o teu token :)
This is fine, again as long as we manage the collection correctly.
Corrected that locally, thanks! If you're fine with both changes, I'll make a new commit.
Isn't "enabled" a part of SSLSettings?
The logic in here still needs to be refactored to use Core Text. See the `CTLine` documentation.
This could be condensed a good deal by using a one-line ternary statement. No need to duplicate so much code.
Why would you need a category to use `NSInvocation`? And, I like `NSInvocation`, but it's seriously unlikely that it will make this look friendlier.
This statement body should be on its own line and within braces.
This is for loop stop correctly. If remove exit, the loop repeat some 
sometime.

  Some sugestion?


Em 03-07-2012 14:31, Dickson S. Guedes escreveu:
>> +			echo -e "Removing all Postgres installed by PGVM!\n"
>> +			echo -e "$VERSIONS"
>> +			rm -rf $pgvm_home/environments/*
>> +			exit 0
>> +		elif [ $TARGET == "--purge" ]
>> +		then
>> +			echo -e "Removing all Postgres installed and source by PGVM!\n"
>> +			echo -e "$VERSIONS"
>> +			rm -rf $pgvm_home/environments/*
>> +			rm -rf $pgvm_home/src/*
>> +			exit 0
>> +		elif [ -z $TARGET ]
>> +			 then
>> +				echo -n -e "Choice Postgres version to remove or the options.\n"
>> +				usage
>> +				exit 0
>
> Shouldn't we `exit` with error here?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/guedes/pgvm/pull/11/files#r1094550

-- 
Fernando Ike
http://midstorm.org/~fike/weblog
yes you're right
done!
nit: This `for` loop (and the one below it) need a space after the keyword :)
Já myslím, že je to 3. pád, procházející komu/čemu. 7. pád je s kým / čím.
I think you should use [`has_cached_counter?`](https://github.com/matthewrobertson/rails/blob/d81c1d8b5054f575cbc8de04d764498578579aa2/activerecord/lib/active_record/associations/has_many_association.rb#L74) for this check.
`val.is_a?(String)`
```ruby
class MyLib::Bar
  deprecate :foo => "this is very old method", :deprecator => MyLib.deprecator
end
```
Yes, sometimes the `arel` is actually a `String`.

Without the check `QueryCacheTest#test_cache_does_not_wrap_string_results_in_arrays` was failing.
Add a space between `{` and `|r|`.
So inherited is called multiple times ?
-> it has to be cleared via a ActionDispatch callback hook ?
@jeremy I've just added fractional seconds to time.
I believe we should retain the `Ordering` evidence here. If we decide that we need to compare elements for some reason later during a minor release, we can then do so without changing the signature of this method.
That "H" is now the only big boy letter among all the phase names.
Good call there!  I wasn't quite sure how much interaction this will have.  

For number 3, do you mean something like:

    class C[X](x: AnyRef)(implicit val tt: TypeTag[X]) extends A[X]
    object x extends C[String]({ object y extends A[String]; y })

?
The problem comes about in the skew and ans can be single valued arrays.  

>>> skew = np.array(0)
>>> mask = abs(skew) < 0.000016
>>> mask
True

In this case True would set ans[1] (which doesn't exists and would throw an IndexError) and False would set ans[0] which would work - but not be 'correct'.

I would like a cleaner solution than the one that I came up with, but I couldn't figure our how to handle the situation cleanly of a singular value for skew.
I thought I tried that, but that was early on when I was just figuring things out.  Will take a look.
> I don't think you can rely on the result of ```python --version```:
Just start the tests with the "no hash randomization" flag. A try
except that warns the user may be nice.
instead of a note should we just start with `a**2*(A*B*A**-1)**2` on the lhs?
By writing `[BlockMatrix]`, do you mean that the only argument of the function is of the type "list" of `BlockMatrix`?  If so, I'd recommend mentioning it somewhere; say, the first time you use this notation.
> Not really. `Point` does save internally some coordinate information, however on the outside it behaves completely independent of coordinate systems. And I am not sure why the clash is a problem when they are in different namespaces.

I agree.
What functionality requires a reentrant lock?
But... I like stack traces...
This should be adjusted according to the change os the response listener service.
Should these consts be used in ConsoleReader?  Instead of:

  consoleKeys.setKeys (consoleKeys.getKeyMaps().get ("vi-move"));
AF_INET || AF_INET6, same for SOCK_DGRAM.
Is this an current TODO?
Calculating the oplog time from the output of rs.status() is non-obvious & non-trivial.  (Go ahead, try to do it!)  I'd suggest removing this section: either use MMS or rs.printSlaveReplicationInfo()
this line is coming from the current existing wiki
http://www.mongodb.org/display/DOCS/Optimizing+Object+IDs
Hmm, I suspect this might also fix [bug 763501](https://bugzilla.mozilla.org/show_bug.cgi?id=763501).
Ah, I see that now. In that case, good to merge if you're still happy with it.
J'ai enleve les div utilises comme separateurs a l'exception de une div sous la barre de navigation. La raison pour ca est que je voulais une marge qui delimite la barre de navigation ainsi que de l'espace blanc en dessous de la barre. Je voulais aussi que cet aspect se repete sur toutes les pages qui heritent de main.

Je n'ai pas trouve d'alternative au div vide dans ce cas mais c'est l'exception plutot que la regle.
All functions in all search backends should gain access control specifiers. This change can be done in a subsequent PR if it requires code changes elsewhere.
`in them in`
Or consider running just one iteration.
TOPICS_TABLE is not used as a constant here.

I have a feeling you never really tested this piece of code. ;-) & :-P
`$n` should be renamed to something more describing.
http://area51.phpbb.com/docs/31x/coding-guidelines.html#namingvars
Not sure I agree with the logic here. If you are doing this as the process is exiting, don't bother and everything should be just fine anyway (unless the child detached). Otherwise you can kill processes that are meant to continue running.

Keeping track of what you launched and only killing that sounds like a saner approach.
d2131b4 fixed.
No it doesn't- any suggestions?
What is 6?
why do you first pack and then unpack that?
@dmorilha Is there a particular reason for using freeze? According to http://jsperf.com/freeze-vs-seal-vs-normal/3 frozen/sealed objects are a lot slower handled by v8 than "normal" objects.
Since we know these YUI modules are javascript files, can we hardcode the MIME type and charset?
Should be `APP_ABI := all`
Ok, correcting that.
Hmmm. For development this is actually quite useful. Is the ```DebugString``` class still defined somewhere?
Agreed, with the change to cartopy `map_setup` is now an unwanted "appendix". I'd rather remove it in a separate PR though.
Typo with trailing space. Should it have gone _after_ the carriage return?
Do we need to duplicate all of this?
This is adapted from other code I have written to handle this task. In my experience it is possible that due to representation error the pole values (-90,90) can be slightly smaller/larger than their desired exact value. In this case the cosine of latitude will be less than 0, which is not desirable. This gets worse when taking the square-root as a ``RuntimeError`` will be raised.

I initially thought about raising an error for out of range values. For those users whose latitudes look like they are in the correct range but are actually represented as something out of range, I felt it would cause unnecessary alarm and extra work for them to correct the values...

Of course, the way I have done this will hide errors from obviously out of range latitude values, but how likely are those? I don't know...
Why 41 instead of 40?
Don't catch -- just throw through.
check if working correctly
Use Named mixin?
please remove the underscore. This naming convention comes from the PHP 4 time when there was no visibility in PHP (everything was puoblic), and Doctrine does not use it anymore for new code (and older code using it is renamed little by little)
``array(`` should be on the previous line
pjax_rails hides this complexity from us:  https://github.com/rails/pjax_rails/blob/master/lib/pjax.rb#L5
While to `.` happens to be legal here, it's more consistent if we use `$`, like we do everywhere else.
`if( name in` => `if ( name in`
Just curious, are we sure we don't have an implementation that will understand `\xA0` as being a whitespace but not `\uFEFF`? Seems like a hell of an inference here.

We could probably use something like `( "\xA0\uFEFF".replace( core_rnotwhite, "" ) === "" )` to make sure (provided we make `core_rnotwhite` a global regexp). It's not perfect, but it protects us from false negatives (so to speak).
This was internal on purpose.  It was only here so that the MonoGame platform code for Android could clear all touch locations on orientation changes.  Calling this on other platforms at the wrong time can lead to crashes and missed events.
Ah, you don't timestamp all buffers, just the first one after seek. ``buffer_.duration = num_frames * gst.SECOND / sample_rate`` and then you can keep updating the timestamp with a ``+=`` instead of just tracking the next one.
Ah, makes sense for the case where you need to have spotify assign a url. It might be simpler API wise to have saving a playlist without an uri behave like create, but delegating to the right backend becomes an issue. So just leaving it as is might be easiest.
This should be "email addresses are".
>How many external formulas are there?

That's the point. Who knows? And don't forget about historical formulae that are usable by `brew versions`. These will be broken as well.

That's why we can't change this. `MacOS.xcode_version` has been exposed as "fair game" to use in formulae.

Adding `MacOS.clt_version` or something is perfectly fine, using `pkgutil` instead of compiler versions inside of `MacOS.xcode_version` is fine, but returning `nil` (or an empty string) is simply not an option at this time.

Now can we discuss something constructive?
the code should work with the stable released version
Can we do the check for whether the main app gear is started here and fix that defect at the same time?  We should be able to authoritatively tell the user if the gear is stopped, and if it is, tell them to 'rhc .... start ... foo' so they can port forward.
No idea what SMSSync does with normalization. Will re-read docs. Passing through `vumi.utils.normalize_msisdn` seems like a good plan though.
Hmm. This logic is duplicated a bit between `txriak_manager` and `riak_manager`. Will think a bit about whether there is a way to fix that.
`data_recvd` is a bit ambiguous -- I'd expect it to contain the actual data rather than the length. Maybe `bytes_recvd` or `recvd_len` or something would be better?
I think it should be

``` ruby
Ariane.dynamic_breadcrumb.should be_false
```
Heh.  Woops.
I thought you said you were changing this to use
    assertEquals(set("string1", "string2"), ep.strings);
for ID,  see how other IQ requests work
I think this should also be a function (`isDirty()`) to keep the model API consistent.
It's 800px everywhere else this is used, to account for oddly-shaped Android tablets we may eventually support.
It is an optional attribute in the spec, so yes.
`themes/_mixins.scss` are only related to the toura theme, but this is more globally useful.
It might help to clarify with a comment that this ``runs`` block executes after the ``waitsForDone`` above.
Is there a way to access the attribute data, get the first attribute in the list, store it in a variable, then use that for comparison?
This tooltip is used to instruct users. Not sure whether this will mislead user to click on lightning bolt icon to save the file.
I don't know exactly either, but it's the way codemirror requires non-command key bindings. If it is a character you need to do it that way. I saw that from here: http://codemirror.net//demo/closetag.html
why not add the id in the apf element
I made a layout change when there are no trips--the left column gets hidden and the form gets centered.  That text just felt like placeholder to fill the empty column space. If you think its necessary I think we could add something back above the form. But my feeling is that there's only one action to take on the site and we dont need to tell the user what do to. What might be more helpful is saying that the site only tracks regional rail.
Why did you change these from symbols to strings?
I actually didn't see, since that's below the diff. Since this was just a style edit, I thought maybe you left something out. No worries.
Agreed but this parameter name is actually from netty code so I'll change it there.
Please ignore, I was using Ubuntu 11.10.
old doc tags !
Rename firstLimit to max so it's more clear.
The other validation classes fail on a single param and don't send a list. In my opinion i'd bail out as soon as you find an invalid param and avoid the list.
That gives 10 seconds. Is that on purpose ?
We need to add it to both.

And remove it from play after it is run, because it is a one time thing.
why did this go from being multi lined to a single line? Looks like it should be split still.
Changing this signature is a tiny bit dangerous. There's a bug in your patch as a result of this change that prevents you from editing TrackEvents. `editTrackEvent` uses the `openData` parameter to pass in a TrackEvent to the trackevent-editor. `forceTrayOpen` looks relatively useless now, so replacing it with `persist` is probably good enough.
is this right, with no unit?
Please don't use `undefined` to empty objects/arrays. `delete` or `null` work better depending on the situation.
Typo (Hheart-beating...)?
`createLoopMock` should be good enough
I don't want to save the deployment object because all the callback will be called:

    before_save :set_initial_status, :save_deployed_data, :save_iq_file, :update_databag, :cname_load_balancer

I'd have to either stub them out, (you already recommend not to do that in the class you're testing) or Add more global configurations like ```config.feature_merge_medistrano_pir_with_agi_iq_is_enable```. I guess the later is the way of go
Uneeded String.valueOf() in arguments to String.format()
了解しました。
本家の挙動の勘違いしていました。indexは 0から返していたんですね。1からだと思ってました。
Tady si použil "Zobrazení", standardně se minimálně na Windows používá výhradně "Zobrazit".
Interesting. I needed to change the file on my mac to get mysql working but I never committed that change and just merged it with the master.
Anyway  I just reverted the file to the last version before my commit and it should be fine now.

I'm really happy it is going into the master ;)
Looks good. But I see no directories inside `Classes`, so the wildcards shouldn't be necessary.
Can this be outside the loop?
@ehelms immediate function definition?  What you're proposing is an anonymous function, but he is not defining an anonymous function. And I agree, a var should be placed in front.
whitespace alert
Should  we use here _() as well?
New tests in 1467b25
please use the same coding standards than the other parts of the library: separate property declarations.

And why making some properties protected and another one private ?
Hey All; I've modified to suit and added notes to composer.json as well as
updated readme

Hope thats in line now.

regards
Ross


On Fri, Nov 30, 2012 at 4:23 PM, Christophe Coevoet <
notifications@github.com> wrote:

> In src/Monolog/Handler/PusherHandler.php:
>
> > +     * @param bool          $bubble       Whether the messages that are handled can bubble up the stack or not
> > +     */
> > +    public function __construct(\Pusher $pusher, $level = Logger::INFO, $bubble = true)
> > +    {
> > +        $this->pusher = $pusher;
> > +
> > +        parent::__construct($level, $bubble);
> > +    }
> > +
> > +    /**
> > +     * {@inheritDoc}
> > +     */
> > +    protected function write(array $record)
> > +    {
> > +        if  (!isset($record['context']['channel'])) {
> > +            throw new \InvalidArgumentException('"channel" must be defined in $record["context"]');
>
> indeed, using the Monolog channel looks a good fit here
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Seldaek/monolog/pull/132/files#r2278860>.
>
>
Note to self: Move to beginning of block (although va_arg(,,,) isn't a function call)
Can we use keyword arguments here? I don't understand, what is `''` here.
should I just make a note that they may not be available?
Can you include checkqueue.h in ``bitcoin-qt.pro``, to be visible in the Qt IDE.
ssp-buffer-size is irrelevant with -all, because ALL functions are protected.

See http://stackoverflow.com/questions/1629685/when-and-how-to-use-gccs-stack-protection-feature
"...at a size of 0/1, it is the same as stack-protector-all."
socket() returns -1 in case of error, and the constant INVALID_SOCKET reflects this. Not sure if it's related.
What use has this line?
Just amend the commit and force push your patch branch. The PR will be automatically updated.
right, missed that, thx
With the discussion on the mailing list done, I'll merge this in now.
null is also part of the strings set


On Fri, Nov 30, 2012 at 1:12 PM, Mark <notifications@github.com> wrote:

> In lib/Cake/View/View.php:
>
> >  		}
> > +		return '';
>
> So its not needed to strictly respect the "return string" return type?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cakephp/cakephp/pull/994/files#r2277316>.
>
>
$model is not defined in this scope, that is why I removed it.
Shouldn't be a c2c copyright ?
api_ => api
HEREDOC
did not double check this one, just reformated.
We shouldn't include a key at all if we don't want to pass a value.
I'm a bit unsure about this. The thing is, the JSON-LD values are not generally encoded this way, only "links" to other entities. So e.g. if you have something like dcterms:title, the value will be "title", but if you have something like "xyz:parent", then the value will be "<http://some_url/some_indentifier>". Does the function account for that in some way or is it automatically only called for link properties?
Lastname *
Another thing you could try...

```
return GetTfsRemotes().Values.Tap(remotes =>
    foreach(var remote in remotes)
        remote.EnsureTfsAuthenticated());
```

I'm not sure if I like it better, but I did want to advertise the `Tap` method.
Nice. I don't have experience with the DjangoRole, yet, but let me know if you need help with that anyway. :-)
None of these are actually enums - they should be `List` and `Unicode`.
is this safe to call in ctor?  is it the right place to call this? generally, we shouldn't be calling things like this in ctors.  move this logic to PostConstruct init method
Should it really ignore null, without telling the caller or logging anything? Would NPE or IllegalArgumentException be more appropriate?
This  breaks all the Push API. The `PULL_URI` is used at the `pull` method but the `PUSH_URI` is no used anywhere.
Since `git_repository_index` will have already set an error message explaining the reason why it did not successfully open the index, I think it's probably better not to override the error it here in the higher level function.

Additionally, the way this function is structured, instead of preserving the error code generated by the lower level function, it is always being replaced with -1.  This pattern actually bit me while trying to debug problems in `git_stash` when working on the update to checkout. The pattern of:

```c
    error = -1;
    if (function1() < 0)
        goto cleanup;
    if (function2() < 0)
        goto cleanup;
    error = 0;
cleanup:
    return error;
```

hides the actual error code that was returned. To me, personally, it doesn't feel cleaner than:

```c
    if ((error = function1()) < 0)
        goto cleanup;
    if ((error = function2()) < 0)
        goto cleanup;
cleanup:
    return error;
```

which preserves the underlying error code. I realize there might be a few cases where the underlying error code would be confusing, but for me, there is generally more confusion from hiding the underlying error than from preserving it.

Philosophically, this is related to the idea of allowing the lower level `giterr_set()` message to stand instead of overriding it at the higher level.

/cc @vmg
@cgjones @michaelwu Hey, what's the status of this pull request? I don't mind we take a loooong time to figure out what's right for production phones, but right now people are dogfooding Otoro phones without proper Settings database. I am told by @gregorwagner that this line is the right way to fix the situation, and I have been telling QAs to flash settings databases after every `./flash.sh`.

Can this be fixed soon?
@jlongster yeah, I am not 100% sure how to handle this inside bedrock. This feed will not be generated by a script, it is simply a static resource that will be updated by someone maybe once or twice a year. Do I add this to urls.py the same way as any other of the HTML views?
Actually I don't think this page is intended for translation so we shouldn't add translation markers in the first place.
Yay, I was hoping there would would be something like this, but I didn't find it in the Django docs, so I gave up.
This comment isn't entirely accurate. Environments aren't set in the session, the environment is actually part of the URL of the runtests page (thus env_id is passed in as an argument to the view function). So this isn't really checking whether an environment has been set in the session, it's checking whether the given combination of run_id and env_id is valid. We could just give a 404 for this, except that the run may have had its environments changed since someone accessed it, so they could have a saved link with a combo that used to be valid and no longer is, thus its friendlier if we redirect them to pick a different environment.
I have no idea how the heck this happened but fixing it now. This is the code from test_products.py
@nddrylliog How much levels would I have to remove to make this acceptable? :P
Ändrade till denna färg http://www.colorhexa.com/4b5138
I wasn't getting any errors - this is done though. Is that a versional PHP thing?
$records seems undefined :)

How are expired records handled by lookup() and CachedExecutor ? (will CachedExecutor return expired records if RecordCache#expire was not called ?)
Ahh, cool.  I was just curious why you didn't go with something built in like `Digest::SHA1.hexdigest` rather than implementing base62 in the app.

Cool :ship:
+1 
 I'm starting to use phpunit massively, I like it ;-)
There is no need to create a temp variable.
shouldn't you typehint the interface here ?
```testCloseMethodAlwaysReturnTrue``` ?
That's not right. openssl works fine on windows these days, it was failing in the early 5.3 builds, but at least in 5.4 it seems to work very well, and I'd guess in 5.3.8+ or something also. Also the `defined('PHP_WINDOWS_VERSION_BUILD')` test is probably better than stripos.
I removed this commit and opened a seperate PR for it.
Just made a commit to fix this, i.e. favour getters over properties
logging before throwing would probably duplicate the log message as exceptions are logged too
all admins. (add period/full stop)
I consider this check redundant here, I would let it fail if no block was given, otherwise the method would do nothing.
I need to change this. Doing so now.
You've duplicated 'test string' in setup and assertion phases.

Did you mean `body.should == @test_ivar`?
Ok, I can drop that change from the commit before integrating.

Thanks for the heads up.

On Tue, May 29, 2012 at 7:49 PM, dkarbayev <
reply@reply.github.com
> wrote:

> > -                             selectedItemChanged: undefined
> > -                     };
> > -
> > -                     $(function () {
> > -                             $("div.metro-pivot").metroPivot(defaults);
> > -
> > -
> > -                             $(".tile").each(addTileTilt);
> > -
> > -                     });
> > -
> > -
> > -
> > -             </script>
> > -     </body>
> > +<!DOCTYPE html>
>
> Nope, I dunno why git highlighted index.html as changed file. I've only
> changed pivot.less and jquery.metro.js files. In 1st file I've added
> overflow:hidden property and slightly changed pivot's behavior in js.
>
> ó Õ×ÁÖÅÎÉÅÍ,
> äÁÎÉÑÒ ëÁÒÂÁÅ×
>
>
>
> 2012/5/29 Brendan Forster <
> reply@reply.github.com
> >
>
> > > -                             selectedItemChanged: undefined
> > > -                     };
> > > -
> > > -                     $(function () {
> > > -
> $("div.metro-pivot").metroPivot(defaults);
> > > -
> > > -
> > > -                             $(".tile").each(addTileTilt);
> > > -
> > > -                     });
> > > -
> > > -
> > > -
> > > -             </script>
> > > -     </body>
> > > +<!DOCTYPE html>
> >
> > The line endings seem to be different now.
> >
> > Is it just the <script> tag which has been updated?
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> > https://github.com/Code52/metro.css/pull/27/files#r890622
> >
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Code52/metro.css/pull/27/files#r891249
>
indeed thank...
Same - we could simplify
@ncharles what do you thing about naming that table "RudderProperties" and having two table "name" (or property name ?) and "value" (or propertyValue) ?
What's up with the random new lines in some place? (Formatting complex) :p
把这个console.log拿掉吧
Tu peux enlever cette gem, on ne s'en sert pas.
I tried to, but this would require importing modules at runtime which requires configuring settings and this clashes with settings configuring in the single test.
I'll try anyway
It's from underscore.js  

My understand is that it takes the dictionary of arguments and binds them to the class

e..g new X({foo: bar})

would result in this.foo = bar when you call bindAll  

--  
David Cramer

twitter.com/zeeg
disqus.com/zeeg



On Saturday, October 20, 2012 at 11:14 PM, Burak Yiğit Kaya wrote:

> In src/sentry/static/sentry/coffee/collections.coffee:
> > @@ -0,0 +1,13 @@ > +window.app = app = app || {} > + > +jQuery -> > + > + app.ScoredList = class ScoredList extends Backbone.Collection > + > + initialize: -> > + _.bindAll(@)  
> What is this bindAll method?
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/getsentry/sentry/pull/629/files#r1898191).  
>  
>  
>
probably it would make sense to exclude any file or dir starting by /.
this would include /.svn  /.git  /.hg ...

And it would be nicer to have this <file_rule> just before the <option line 
this way, it is global for any cluster
This is a bad idea as it means that the example does not run with the latest version added in the gh-pages branch (which is currently more recent than the 0.9.8 release IIRC)
all of the set up with current views is now in one function for each module, to be called when app view is first created, and also called when we set a model to be the current one.
I would normally fail on this extra line.
document.body instead a querySelector?
Uh, I see you pass the name already...why not use it?
`onreturn` is being called here.
If you switch to `getBoundingClientRect()` then you don't need `parseInt`
please bear with me. that will be fixed later on subsequent PRs or on an specific one for that.
6rem ?