labofsahil/github-event-dataset-2012 huggingface dataset:
Is anyone aware of any areas in which this might cause regressions that I can test for?
Why do you need !important?
You can move this variable into if (element) statement. (Although it's a very rare chance that element doesn't not exist)
( why we need a special busyTimeInit)
Are we doing this to add a custom header? Seems a bit wonky, like there might be a more tastypie way to do it.
I didn't see it use new options(and lot of them). Can you explain them?

The 60/90 was quite easy to manage, this one is more... huge :p
this looks like a syntax error
FYI: I made this change in 67fb915.
connectResume must now explicitly run the finalizers when appropriate.
また、いくつかのオプションはオプショナルになり他は必須になります。

→

    また、いくつかのオプションの入力は任意であり、それ以外は必須になります。
deleted the date and currency formats from the file
I know that you just used what was already there, but does it make sense to keep those buttons as divs and manually add standard functionality like `disabled` to them? seems like a lot of overhead ( also in the views `@get 'disabled`)
The properties above should be checking >=, not >
So I think you want to change this to `beGreaterThanOrCloseTo` (or check `beGreaterThan || beCloseTo`, but I guess this is redundant if the > check is approximate)

Also, I'm confused by the middle condition: `(math.abs(a - b) > -1 * eps)` Should this be `a > b - eps`?
Leaflet style of doing this is using `L.Util.bind(fn, this)` on the anonymous function instead of `self` or `that` variables.
Using img tag for dummy element instead of script tag.
Avoids parsing error thrown by console.
Is it possible to put this somewhere other than the package root?
This file is unrelated, right?  (not that it matters..)
What's the current philosophy for making db columns i18n-safe?
I'd be wary of that until Twisted made it explicit in the API docs that it was OK.  At any rate, the issue here is the call to `reactor.stop` when anything goes wrong in `startService`, and `MemoryReactor` doesn't even implement `stop` (or `callLater`, or much of anything else)
It reported that it couldn't find 'v110_xp',
Is "v110_xp" only valid on windows xp?
rather:
    preq_quote($token)
```php
$dirContent = /* ... */ ;

return empty($dirContent);
```
Why do we need to check this right here?
Ah, I see, fixed :)
where exactly? grep'ed whole gitolite source and didn't saw it...
Can you point me to some docs on qwery-mobile? Can't find much info on ded's Github.
No it's checking if `orig_height` is **less** than `$width * 2`.

`10` isn't less than `0 * 2`.

For example if original image is 100 x 100 and you asked for a 60 x 60 thumb the if statement will be

````
if ( 100 < 60 * 2 || 100 < 60 * 2 )
````

Which will return true, IE the original isn't big enough.
ROS messages, services and actions without underscore
Sure.  I went with single since the `add_dependency` calls were all single... but I can change it.
Maybe just include jqueryui in this code? I was thinking of using another library anyway as my original code was a messy (handling events sloppily, etc). I'd be open to that if you're willing to do it. :)
Hi, Sorry for the late response. You are right, we can do it with one write.
No, they aren't necessarily buttons. They can also be text links. I'll point that out.
Any standard JS way of doing, like this:
```
function Listener(defer) {

  return {
    onInstallEnded: function () {
      ... defer.resolve  ...
    },
    ...
  };
}
```
Or with prototype.
Could you explain it a bit more? What do you mean with "some add-ons may get broken by this"?
well, only in the self.pk is None when doing special operations on save and all...  ok, random mention of something trivial, I admin...  ;)
Why can't this be 'Components'? Is there no way to overlay the global variable?
そうですね。了解です。
@jeffweiss will do
There are used in Puppet::DSL::Context when using export method with block.
Wouldn't it be nicer to avoid creating an extra proc here, and just have the context handle the source code as a string instead?
why is this one read and the other is open?
Is there a situation where these could come back 'nil'? the error would read pretty oddly if so.
done

On Tue, Nov 13, 2012 at 8:18 AM, Evan Phoenix <notifications@github.com>wrote:

> In lib/rubygems/dependency.rb:
>
> > @@ -245,10 +245,10 @@ def merge other
> >    # DOC: this method needs either documented or :nodoc'd
> >
> >    def matching_specs platform_only = false
> > -    matches = Gem::Specification.find_all { |spec|
> > -      self.name === spec.name and # TODO: == instead of ===
> > -        requirement.satisfied_by? spec.version
> > -    }
> > +    matches = Gem::Specification.stubs.map { |name, version, file|
> > +      next unless self.name == name and requirement.satisfied_by? version
> > +      Gem::Specification.load(file)
> > +    }.compact
>
> Please don't use .map + .compact, just use .each and append to a local.
> The array in question could be very big and then we'd just turn around and
> make it smaller again. Better to just do it right the first time.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rubygems/rubygems/pull/396/files#r2111612>.
>
>
I think you have the wording backward here. If `n` is what's available, and `m` is what's passed to `read_nonblock`, then here `m > n` because 1 byte is available and 2 are requested. In this case `n` bytes should be read.
Apparently it was too late and I was misreading the logic statement.  Thanks for the clarification.
How about `response.body.fetch('error', false)`
Maybe `show help` ?
Can do. Thanks!
IMHO It's not neccesary cast the argument always. compute() already do the cast
Actually the indentation is not possible here because we I used some white spaces to indent the XSLT output.
This is a general XLST file to convert a docBook structure in reStructuredText format.
I used the XSLT syntax + the special template php:function() using the XSLTProcessor::registerPHPFunctions.
This will throw if Description is null on the model coming out of EF. Maybe `.ToStringSafe().Split()` instead? Or wrap it in a `IsNull` check like we do with release notes?
Put a file into `lithium\tests\mocks\analysis`. That eval isn't even dynamic (it's always the same).
->

```js

var result = [],
    key;

for ( key in this.data ) {
```

var at the top of a function scope
Don't think GoSquared is popular enough to end up in the README directly. the "etc." contains all the other tools IMO.
my bad. ignore.
Why is the section on "How to Apply These Terms to Your New Programs" included in the extension? Seems kinda meaningless to me?
probably don't want the `\` here.
Static? Really?
You do this a couple times. It should probably be a before filter.
I know that this restricts edits to the user who created it and only for 5 minutes after creation, but I have to think to figure this out -- I hate thinking.  I would move this to a method on `User` with an appropriate name.
Remove two empty lines.?
`if (transformFunctionNames.length)` is sufficient here.
Why the spacing addition?
Oh ok, I see now. Maybe just a comment would be nice.
We need to use the StringBuilder, this will help in reducing the overhead.
this will remove the '/b' for every base_url no mater what the arguments or markers are 
I suggest: 
<code>if item.config.option.nonbedrock or 'nonbedrock' in item.keywords:</code>
item.config.option.nonbedrock => if ue use the command line argument
 'nonbedrock' in item.keywords => if we use the mark
No, because I think it was the responsible for the unwanted pushes (syncing
files).

On Wed, Sep 26, 2012 at 12:31 AM, Zaiste! <notifications@github.com> wrote:

> In .sparkleshare:
>
> > @@ -1 +0,0 @@
> > -69ce402f86963a6128becc68163ec1fdce61083e
>
> Yes + entry in the .gitignore Are you still using sparkeshare ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/nukomeet/coworfing/pull/192/files#r1690452>.
>
>
Somehow, this code was indented with tabs.
Is there anyway for this to be abstracted given the surrounding bits are focused related to generic interstitial?
"the angle vertical" rather than "an angle".  While there are more ways to name this angle, there is only one angle vertical to any given angle.
we don't need the `tmp_clone` temporary variable anymore since the `clone` function will return a cached result after each subsequent function call
It may even matter for circular apertures (e.g., for ACS, the plate scale is on the order of 10% different in two different directions (iirc). A circle in one frame is an ellipse in the the other.

Offhand, I would think physically, one wants fixed apertures in world coordinates. E.g., that's where we want the constant angular area.
Semi-colons after closing brackets, please.
btw, this is simply wrong. As you use ``InputOption::VALUE_NONE``, ``$input->getOption('filter')`` will always be a boolean (``true`` if ``--filter`` was used and ``false`` otherwise)
Error.stack isn't supported in IE, but we're going to report this error to the user somewhere upstream, anyway, right?
Right. Should be better to use ezdebugsettings..
The following logic had to change entirely since the gutter no longer receives mouse events directly (the scroller is in front of the gutter). So I look to see if the mouse position is over where the gutter should be.
PEP8: Separate these imports with a blank newline
Oh, I see. Right. Nevermind.
Just a question I've been wondering about, but what's the difference between coffeescript's `for model in collection` and underscore's `_.each(collection, function() )`? Is one faster than the other?
Don't think it's necessary to refetch the group here if it is being given back by `GroupAPI.canManage`
The sort variable is meant to determine how the documents are sorted (by default, I guess). Certainly shouldn't be dumped into the global scope, good catch.
Turns out it only does this when paging a query, not when doing select *. I fixed up the paging queries.
That's a lot for a profile picture, should we consider bringing this down to 2 or even 1?
I think we need another interface for the factory which has this method.
This varies from previous version is it correct?
`ORM::find_all` returns a `Database_Result` object so you need to call `as_array()` after `find_all()` in order to return an array. 

Also, the `if` block can be shortened to:

    $buckets = ORM::factory('Bucket')
        ->where('id', 'IN', $ids)
        ->find_all();
I would use a library for auth - they will always do it better :) I recommend devise
Not quite true.  You increase the file size, which increases disk i/o, as well as the memory required by file caching systems.  All take place prior to PHP stripping comments and parsing your files, no?  So you don't slow down code execution, but you are increasing load on the server with bloated files.  

Now extrapolate a sample like:

```/**
 *
 * Path of cache files (if file-based cache)
 * 
 * @var string
 */```

to every file in CodeIgniter and every class property.  What's your new ratio of code to comments?

But come on, just scrolling past those headers looking at all of a classes properties becomes a chore.  It almost necessitates using whatever the doc generator outputs instead of just quickly browsing the code.  Can you  honestly tell me that you find it more pleasant?
Комментарии останутся, просто будут свернуты как outdated.
Если в дальнейшем понадобится использовать размер массива - его вполне можно получить через вызов [DNA count];
Так что свойство countDNA в данном случае лишнее (имхо)
Ну, собственно, так и поменять, строго X процентов. В случае 9 ячеек менять придётся (9*73/100) ячеек, что при различном подходе (использованию округления или без него) будет означать, что нужно заменить либо 7, либо 6 ячеек.
Возможно так и сделаю после того как просмотрю модуль о Foundation в 3-й лекции, в котором, как я понимаю, описываются коллекции. Пока же я коллекций не знаю, да и задание не по 3-й а по второй лекции - стоит ли бежать впереди паровоза?..
Каким образом это можно сделать? заного залить?
+1 on that of course. ;)
Да сам сделаю, не горит же.
Use a if and raise PluginError instead of using assert.
Is wrapper_dom_id a method provided by Rails or a helper of your own?
I think method should be before iir_params. I would say "iir'  will use IIR filtering with the filter parameters defined in iir_params" (not necessarily butterworth.

Also, it would be good to explain the filtering options and the supported filter types in the docstring, maybe with some examples. This would make iir_params less scary for new users.
why not 'eq_list' instead of args --- you would save the passing from args to eq_list then.
does this produce real zeros due to numerical precision? it seems less stable. Can you test what's the order of magnitude in numerical errors? As the end you want to test with shrink == 0.
Maybe ValueError is more adapted but whatever...
I was thinking that all the connectivity plot functions could start with "plot_con", or "plot_connectivity", like that the connectivity functions would show up together in autocomplete etc.
The `event` object argument will have a property called `track`, which is a reference to the `TrackEvent` object created by that plugin for the calling Popcorn instance.
I don't understand you probably.  Passing ```nil``` to ```raw``` ends with empty string.

```ruby
def raw(stringish)
  stringish.to_s.html_safe
end
```
https://github.com/rails/rails/blob/1814298d7590988d354955efdb0bc495b359293b/actionpack/lib/action_view/helpers/output_safety_helper.rb#L15
@arnaud-lb You must specified that this feature is new in Symfony2.2
This should be kept IMO
why the unused options?
There is only ruby-ntlm-0.0.1, so the dependency should be just `'~> 0.0'`
I did this intentionally so we can do things like `sign_in_as create(:user, :admin => true)` or other types of users. What are your thoughts, could it be abused as a public interface?
Open a ticket
i start to worry if it is a good idea to return string here. the problem is that for the integration with jackrabbit, we will need an integer, and it will be impossible to have the same user in java and php if we convert the string hash to some int hash.

so maybe we should say int here and when we implement the interfaces provide a helper in phpcr-utils similar to this java helper http://www.javapractices.com/topic/TopicAction.do?Id=28

its a bit more painful to use (and also to debug in storage) but would better integrate with jackrabbit/jcr. what do you think?
typo unless
Не, я бы на твоем месте изменял `Command2Action_` в этом месте. Чтобы потом не было свитчей, как на строках 1156-1166 и так далее.
>Потому что не стоит пихать рефы везде воо6ще. Здесь семантика другая.

Чем плох реф именно в данном контексте? Ты нормально обяснить можешь? -_-
Could you add this feature to other source too ?

If it's only used by the route generate by the ActionColumn, why don't you call the method something like setRouteIdParameters() ?

Maybe I don't really understand but why this feature is implemented on the source ?
Every rowAction will have the same parameters for the route.
I think more logic to implement this feature on a rowAction.

```
$myRowAction = new RowAction('More Info', 'books_more', false, '_self', array('class' => 'show'));
myRowAction->setRouteIdParameters(array('id','author_id'));
$grid->addRowAction($myRowAction); 
```
Yay! Thanks :)
It checks against whatever table and column you specify in the database.

So it's going to make sure that the email is unique and the username is unique in the database. Pretty nifty.
you should not wrap your return value in parenthesis
cool just making sure.
Sorry, I was just hustling through these and forgot about @krisk 's suggestion. Any way we can make that change ex post facto?
see "an"
nit: extra whitespace
Can you add a custom message with the name of the suite that it is trying to assert is present? This will help debug failures.
remove - unused
I have to agree with Matt's note 2 here.  Sending an HTTP request is a Command.  It should be a Command object, not a method.  Vis, you create a Request/Client/Whatever object, configure it with whatever methods in whatever order you want, then execute()/send()/whatever().  And get back a Response.  That gives maximum flexibility to users, as well as allows for specific implementers to add additional methods if needs be without breaking the interface.
Yeah, again, this stuff is taken care of later.  We will use the docstring via `"` in order to get it into the codox site.  I deal with this much later.
Add spaces above.
Can we combine the `else if` here?
I think the 'textProperty' example needs more attention, took me a while to get it. Maybe just an inline PHP comment on that line `// value automatically set on all new instances` ?
Sorry, how do you mean? GitHub also uses VERIFY_NONE?
Actually, I was suggesting '>' '=" 4.5.0 (i.e. upgrading to any version greater than or equal to 4.5.0).
I don't believe any "\r" should ever appear, so just deleting "\n" should be sufficient (I think).
Are you sure ``$value`` has the correct type as ``*`` is not a sub-type of ``array``?
Because WAMP is language agnostic there are a few places to find help, such as their [mailing list](https://groups.google.com/forum/?fromgroups#!forum/wampws).  I do plan on writing a WAMP tutorial, but it's a ways down a long list of todo's.
Agree… Sorry, old habits die hard… Certainly no longer makes sense with the granular diffs and issue details either on the same screen or one click away.
Do you want me to fix or will you merge and fix?

From: Jake Ginnivan [mailto:notifications@github.com]
Sent: Monday, 10 December 2012 11:52 PM
To: funnelweblog/FunnelWeb
Cc: George Doubinski
Subject: Re: [FunnelWeb] A number of rendering fixes related to bundling and prettifying (#32)


In src/FunnelWeb.Web/App_Start/BundleConfig.cs:

> @@ -22,12 +22,15 @@ public static void RegisterBundles(BundleCollection bundles)

>              bundles.Add(new ScriptBundle("~/bundles/jsdate").Include("~/Scripts/jsdate.js"));

>              bundles.Add(new ScriptBundle("~/bundles/showdown").Include("~/Scripts/showdown.js"));

>              bundles.Add(new ScriptBundle("~/bundles/taggy").Include("~/Scripts/taggy.js"));

> -            bundles.Add(new ScriptBundle("~/bundles/prettify").Include("~/Scripts/Prettify/prettify.js", "~/Scripts/Prettify/lang-*"));

> +            // Issue #30. Prettify.js + lang-*.js are already minified

Id prefer not to have these comments in the code, I don't think they add any value

—
Reply to this email directly or view it on GitHub<https://github.com/funnelweblog/FunnelWeb/pull/32/files#r2363127>.


________________________________
George Doubinski | Microsoft Dynamics CRM MVP
+61 416 279 845 | @georgedude
george.doubinski@alexanders.net.au<mailto:george.doubinski@alexanders.net.au> | blog<http://crm.georged.id.au>
It seems, that `next_tick` is always executed before any signal processing, so that *timer signal* could not wakeup that thread before `next_tick`. So that, imho it will be application error, not `EM::Synchrony`, if something goes wrong here.
Doesn't seem necessary to keep this function, the two lines below should suffice
`pauseSelfScanning();`
`mHandler.postDelayed(mScanRunnable, Math.round(1.5 * TeclaApp.persistence.getScanDelay()));`
No, that's not intentional. I'll fix and resubmit.  I hadn't noticed that, sorry. :)
or 

``` js
result.chartAt(0) == '#'
```
Same here:

```
{% block extrahead %}<meta name="robots" content="NONE,NOARCHIVE" />{% endblock %}
````
Any better idea for this: http://slovenskenovice.si/lifestyle/astro/oven??
Does node also have a value if a user comes to our page when not connected to one of the wireless nodes?
Still race condition.
`(!notification.read)`?
Is there a way to get this from user's locale? If not, add TODO that this should be user-configurable.
Мы вроде русские, а для стороннего люда  в наших комментах ниче интересного нет, так что давай эту ветку по русски. 

Если убрать `smarty`, то тогда исчезает подсветка сиснтаксиса, так что ты уверен что парсер не поддерживает smarty? 

И если добавить  строку между элементом списка и блоком кода, то блок кода окажется НЕ вложенным в список, а я собственно добивался обратного результата. Ведь код прикреплен к этому элементу и должен быть вложен в него.
Confused:

in 3.0.3-130 in /public_html/administrator/components/com_fabrik/language/en-GB/en-GB.com_fabrik.ini there is:

COM_FABRIK_FIELD_RECORD_IN_DATABASE_DESC="Should we store the submitted forms data to a database view?"

COM_FABRIK_FIELD_RECORD_IN_DATABASE_LABEL="Record in database"

which is referenced in /public_html/administrator/components/com_fabrik/models/forms/form.xml with:

<fieldset name="formprocessing">

		<field name="record_in_database" 

			type="radio" default="1" 

			label="COM_FABRIK_FIELD_RECORD_IN_DATABASE_LABEL" 

			description="COM_FABRIK_FIELD_RECORD_IN_DATABASE_DESC">

				<option value="0">JNO</option>

				<option value="1">JYES</option>

		</field>

And yes, i agree that LABEL is completely accurate in that context. 

The instance i think i was wanting to change was the first field called 'ID' in the list edit page.  

That seems to be referenced in /public_html/administrator/components/com_fabrik/models/forms/list.xml with:

<fieldset name="main" addfieldpath="/administrator/components/com_fabrik/models/fields">

		<field name="id" 

			type="text" 

			default="0" 

			required="true"

			readonly="true" class="readonly"

			label="JGLOBAL_FIELD_ID_LABEL" 	

			description ="JGLOBAL_FIELD_ID_DESC" />

So perhaps i edited the wrong file and line then!  And possibly the error was made because ID's DESC 'Record number in the database' is similar to the other fields LABEL 'Record in database'.  Woops!  

But, in the latest unzipped version (3.0.3-130) i cannot find where 'JGLOBAL_FIELD_ID_DESC' is defined.  The DESC is outputting as "Record number in the database' and i can't find that when searching either!  But this DESC seems to be the same for form and list edit pages (as seen in form.xml and list.xml) so maybe better to leave untouched!
Probably don't really want to change the guid
Have an idea for the new sentence ?
cleanup code is not blizz
The whole `getMemberTemplate` method can be removed.
no - none of this should be here. you just need the void:inDataset to make it work.
by OCD do you mean "tireless attention to detail"? <3
Won't this change leak Kiji instances if the thread is interrupted before it can be put into the queue?
why not patching the local ioloop import instead ? reload() seems like a bad idea as we don't know for sure the side effects of it (it wipes out global variables etc)
Extra newline & can skip braces
That'd be even better. The other will see POLLHUP/EPOLLHUP or EPIPE when it tries to write.
Never mind, just read further down - you're calling this from inside templated stuff and having the variations here vastly simplifies that.
That is a a big space :) can you reduce it to a single tab (4 spaces)?
getSlot will never be null.  JAXB auto-create.
These new properties are replaced as part of resource filtering - the smtp.agent.config can't be loaded with relative paths.  In practice the direct configuration will require these be replaced with specific keystore(s) for direct which is what we're doing in our testing.
Why is this logic gone?  Do you know for sure that sTargetHomeCommunityId is unprefixed at this point?
How could figure out the email? Is it somewhere in the code?
That looks a lot like 15.  Recommend using lan5 instead.
I agree w/ not shearing, shifting, etc.  But is silently ignoring such requests a good idea?  Seems like it would be prudent to raise a warning (not exception).
Don't want "echo 1", "echo 2", etc in the production code.
Do we need to close the producer and consumer's channel/connection?
agree, worth tidying when we've got all the functionality we want in.  ability to update a history list, and/or collect warns/errors, would be handy.
What happened to the htmlescape package?
I think that `var a = [true]; _.uniq(a) === a` would be rather surprising.  It should probably be `array.slice()` right?
This line prevents the unit tests from running on a machine without nrpe.cfg, which we discovered with the syslog provider too (particularly syslog.conf vs rsyslog.conf).  Until we have a better way, please remove it and then machines without it will simply error when they come to open the file.
Additional field `blurb` is a functional requirement I suppose - Feels more logical to have it !
Tell me what do you think ?
I appreciate your effort in improving this app. however, new columns in the initial migration are not backward compatible. 

someone who is already using this app can't take these changes w/o dropping their tables.
This conflicts with what's documented in the `add_cc` method

 > As of publication, CC is NOT supported by either the SMTP or Web API
Yup, I see them. Actually, looking at other magic commands, I think this line should be replaced by the overview of the arguments, like `%history [-o -p -t -n] [-f filename] [range | -g pattern | -l number]`
Let me think about it. Reading over the error handling code, I recognized that this contains(...) stuff is some of the oddest crap that I've written.

I think that `git_buf` with append-truncate-append is going to be pretty fast since the initial append has already guaranteed that the memory is allocated and probably in cache, so the cost of separating this into separate contains() and append() steps is probably low. With the existing error handling code, this is a little ugly, but with your new error handling style, it should actually be pretty clean. Let me tweak it in this branch and we can see...
Done. I used Matt's example. Thanks!
This was part of the default code that came with the module to display the results of the search. I think this will be a whole other project in itself.
You forgot to comment out the honker weapons, too.
same issues here than for the extensions
May i suggest to use curl instead of wget because curl is included in msysgit package.
Nope it was totally new so I will take the one from /LicenseTemplate.txt
Looking at the cloudbuilders devstack scripts seems to confirm that:
https://github.com/cloudbuilders/devstack/blob/d22dd9c06c01dd8dedfe45642021c0fd25f59adc/lib/cinder
И в где usage?
Где try..finally
А зачем эта сортировка?
Well there are no such functions as volumeControl.slide() or volumeControl.slidechange()
I think that is why bind() was there on the first place.

You cannot do something like this
volumeControl.slide(function () {
....
});
This should not be necessary as ValueEquals function in the next line performs a case-insensitive comparison.
fixed login -> log in in comment, not gonna try to refactor all code that way.
fixed paypal -> PayPal in comments, but not code
Remove pls? Or put in a `settings.DEBUG` statement.
I may just be confused, but why do you need to create a new array $ret?  Couldn't you just calculated the total points, stick that in $arry and then return $arry?
I'll have a look at how performance critical this is. I would imagine it depends a lot on the ``n_samples / n_components`` ratio.
Since both arguments to `intersect1d` are the result of `unique`, passing `assume_unique=True` should speed this up (according to `intersect1d`'s docstring).
estimated params should end with an ``_``
check that X is csc
j'ai pas envie
This seems like duplicated effort. Won't ThrowException display the error in the log?
Doesn't `watchr` pull this in itself?
Agreed. I'll remove the implementation specific notation.
I think it should be "denormalization" as one word?
Depends on whether you believe that a dictionary is a special form of dataset...

Can you suggest a name you would prefer?
You can't do this allocate in the performSort - there is likely to be no memory available to do the allocation - it needs to be preallocated.

All the sort functions need to be able to allocate without allocating any memory from the memory manager.
There are really 3 forms:

1. skip - discard the error and return an empty dataset
2. FAIL(errormessage) - provide a more useful error message 
3. ONFAIL(transform) - return a single record 

(there is also catch(expression) for non-dataset values)
>Have you verified the size is what you expect?

Yes.
Only after, initially not having pack, and having lookup fail, because of random padding being hashed.
I'm still concerned.  For instance whilst reviewing this code I though of an improvement - but if the code is duplicated that is likely to not be duplicated if we're not careful.  Possibly a helper function could do it.
I think so, yes.

I plan to slot in group impl. after this commit is merged
Hmm I removed this class yesterday, but we can do it again :)
По всему файлу всякая мистика с отступами, надо быть добрее к читающим :-0
it looks like currentStatus could change because of [session connect:url]
I am not familiar with that. I understand the basic idea, but need to practice someplace where I can cause no harm!
This was a misunderstanding. We actually want to get errors/exceptions if IV values weren't stored with the keys. Properly encrypted values are the only ones we want to support.
Probably. Although by the time this request was opened up, the requirements shifted. Instead of returning a mash up of all the sites, they now want a way to return only a specific category: Fall 2012. It probably is safe to presume that CLE hybrid won't return multiples for a single category, though the minute Jon wants another pony (can we support multiple categories), this logic will probably have to be slipped back in. I was hoping hybrid had some nice implementation to just return the specific category but alas, no: http://source.sakaiproject.org/release/hybrid/1.2.0-a01/sakai-hybrid/servlets/SitesServlet.html
menuOrder not menu_order. We're talking about the exposed API , not the underlying API.
You have this method defined twice. I suspect the version earlier shouldn't exist?
@jvazquez-r7 It may be worthwhile the Metasploit API webpage being updated as it may save you time in the long run - Post::File is missing a lot of the implemented methods etc. (I know you can generate the docs locally.)

http://dev.metasploit.com/documents/api/classes/Msf/Post/File.html
"windows authentification" - Capitalize the "W", please.  Better as "Windows".
But that's the thing, if it's connected = false it'll never be connected. I think @nmonkee wanted this to be a boolean true (or else nothing would move forward.

````ruby
"false" == true
````
Formatting: I think this parameter should be moved to the previous line and the subsequent parameters aligned with that.
I think most declarations of new instances use `cls`. Since it's pretty standard (much like `self`), it's probably best to stick with the convention. Also, since it is very similar similar to `self` it probably isn't necessary to have this in the docstring.

I guess both these comments relate to the original `Image` class implementation, not your changes, but I think they're worth updating.
If what is going on here is considered idempotent by your standards I'll change this to `PUT`.
Indentation should be one space less here, yeah?
Did this use to take a `Cartesian`?  Why change it?  To save a potential allocation?  Virtually no one will call this constructor at all, let alone in a performance critical spot.  Don't we take `Cartesian` a bunch of other places, and shouldn't we be consistent with them?
I know you copy and pasted this, but, despite my preference, we generally use `height` everywhere, not `altitude`.
See my other comment on the first instance of nesting.
没这个属性
range、offset没Load到啊……
I understand what is what, but that is not how stuff gets released. The way you see it in quality is the way it works best as many people (especially on the public torrent sites) just release it with a weird tag.
... I hate it when the `$sql =` is not in the transaction, but the execute is.
I know and I didn't wrote that line.
While I recognized the timing issues of open() calls, I'm not sure why this is the correct behavior. The current behavior would prevent user from opening a tabgroup, close it, and do something else (since the application will exit). We do have "exitOnClose" property that enables end-developer to exit the app as they please, but forcing the app to exit every time we close a tabgroup that is opened on the root window doesn't seem correct imo.
Also, there is parity with the current behavior. While tabGroup.close() exits the application, the native "back button" doesn't - it only closes the tabGroup.
data will most likely be undefined, and not null... so you may just want to check for a 'truthy' value like :

if ( data && typeof data == "object")
Is the headerView always guaranteed to have children?
use isDef
rather than hard coding values, we should follow the same format used in other places throughout the platform.  See TabGroupProxy ln: 47-54 for an example
Logical format is different from `seekForward` - they should probably be organized the same way.
text => texture
Small note: overriding the default strictness level set in filetools need to be done early, hence the moved of the code block above to the top of the `main` function.
should this be a stub?
Let me know if you think we should cut object support for the incr and decr family of commands. I think the syntactic sugar is cool, but it shouldn't over-complicate our implementation. Make the judgement call and modify the source and docs accordingly.
Please don't comment out code. If you don't need the code anymore, delete it. Git always makes it possible to restore it, if needed.
Addressed in the new set of commits
Как насчёт безличностного комментария на английском?
record all should be record none, or record new episodes
It brought *more* complexity to an already complex function. I wanted to prioritize publishing something that worked first.

The problem with your example above though, is that each individual field *also* needs to be emplaced. This means redundant calls to initialize for each sub-field etc... Not sure if even worth it in plains terms of run-time either...

My previous version left a note about the possibility of doing this, and implemented it, but left it commented.
Strange, I think one of my commits didn't pass through: The entire point was to *not* save haystack. The fact that the call to save is still there was definitely *not* the intention. Fixing.
Oops! I will look at that later this weekend. Thanks for pointing that out.
I'm curious are these files in red not needed or did they get moved?
Well it's tested in get, but not in create. I'll add a test for that.
Let's not translate API features such as 'WebWorkers' or 'Geolocation'. It's not easy to keep consistency, for example 'CSS3 Animation' could make better sense when translated but it actually is API, so it should be translated if we follow the rule above.
Personally, I prefer breaking consistency for 'CSS3 Animation' in this case.
refactor to DeletedFormHistoryColumns. Alternatively, we could file a bug to change BrowserContract.DeletedColumns to an abstract class instead of an interface, because DeletedFormHistoryColumns and DeletedPasswordsColumns will be the same.
@erikfrerejean it happens... occasionally
Cuidado com a indentação do código
The following exception is thrown if `services` is used in `config.yml`:
`InvalidConfigurationException: Unrecognized options "services" under "fos_user"`

https://github.com/FriendsOfSymfony/FOSUserBundle/blob/master/DependencyInjection/Configuration.php#L218 and https://github.com/FriendsOfSymfony/FOSUserBundle/blob/master/DependencyInjection/FOSUserExtension.php#L39-L43 both refer to `service`
i think i am 8 lines below
ah, here syou now say it's on signin :)
No, no names and descriptions were provided.
We need a way to mark weak purity explicitly. Plain `pure` doesn't do that.
We should change this to: (including Spring message-driven POJOs and Spring Integration's Inbound Gateway)...
I think it would be better to set storedProcedureNameToUse here instead of duplicating this code in two places.
Add an assertion that the group actually contains message(s) - the bug caused empty message groups to be returned by the iterator.
Just to confirm, that missing IF check was the actual issue. Now *that* infamous test does not have a single timeout once the consumer's timeout is increased.

This however brings an interesting question for which I have yet to have an answer. Here is what I am thinking:
Do we even need any extra flag on CCF or current 'cacheConsumers' should do. (basically undo what we asked about a while back, since the problem should have been addressed in JOG). Here are couple of scenarios:

1. If in the future CCF the user sets 'cacheConsumers' to true and is using TemporaryQueue for the reply, forgot to set the correlation-key attribute:
-  We can either throw an exception o startup or reset the 'cachingConsumers' attribute of the CCF to 'false' since we know what will happen if consumers are cached (perf degradation and most definite OOM)

2. If in the future CCF the user sets 'cacheConsumers' to false or doesn't set it at all and is using TemporaryQueue for the reply, and set correlation-key attribute, thus choosing optimized performance.
 - this one we can just let go with the early warning message since there is no harm other then performance, so the warning message would simply suggest "consider caching consumers"

The bottom line is I am stil struggling with wether to consider our current behavior as "it is what it is" or a bug with regard to caching consumers when relying in MessageId-based selector? I know currently this problem only exists for named reply queue, but it will not make its way to temporary as well.
Feels this might be better as a resource. Later on there probably will be RUD operations for User profile of CRUD. Check with Matias.
The class does still exist at https://github.com/doctrine/mongodb-odm/blob/master/lib/Doctrine/ODM/MongoDB/Mapping/Annotations/DoctrineAnnotations.php#L28 .
The problem is, it cannot be autoloaded via psr-0 autoloader. the `AnnotationRegistry::registerFile($libFile)` call does that.
Are you getting exceptions? Which ones?
Can you split this test into separate smaller tests?

You can also use @expectedException then.
В случае стандартного load infile (без буфера), последовательность становиться 
```
mysql_thread_init();
mysql_set_local_infile_default(conn);
mysql_thread_end(); //чтобы не было memory leak  если в libuv в пуле потоков  какой то закроется
```
в случае наличия буфера последовательность  
```
mysql_set_local_infile_handler(...) 
// не зависит от mysql_thread_init
mysql_set_local_infile_default(conn); 
// в принципе не очень хорошо, так как стандартная реализация зависит от
// mysql_thread_init(), но не очень и плохо, так как в следующем запросе, 
// в случае надобности будет вызван mysql_thread_init
```
Add a space after the equals sign.
Hmm, I'm not sure what went wrong there. This was supposed to go into the showEmptyView, to check whether we don't render the emptyview multiple times:

My local monkeypatch looks like this:


```
Backbone.Marionette.CollectionView.prototype.showEmptyView = function(){
  var EmptyView = this.options.emptyView || this.emptyView;
  if (EmptyView && !this.showingEmptyView){
    this.showingEmptyView = true;
    var model = new Backbone.Model();
    this.addItemView(model, EmptyView, 0);
  }
};
```

Because as far as I can see, currently calling showEmptyView multiple times will render the emptyview multiple times, right?
`result[+!fn item]`
@apex13 As discussed on IM, just removed the label here and added it to the heading
Well I can make it support both.
yes. I think we can just pass in the image and compare against the RawFormat of the image. 
ie.. image.RawFormat.Equals(System.Drawing.Imaging.ImageFormat.Jpeg). It's slower, but since we're already loading the image it doesn't matter. I think it's the most reliable way of comparing.
In this project we use the symfony2 [coding standard](http://symfony.com/doc/2.0/contributing/code/standards.html).
字段名不要有下划线
Yeah, but the init that isn't is on the road to becoming this one.
Not everyone uses vim so this should really go in ~/.gitignore not the project
something like if isBinary(data), then isBinary = true else, isBinary = false and the content to be rendered out as a PDF is a view/layout combination string.
what is this icon-envelope? I dont see it anywhere else in the commit...
added changeViewsOfInternalModels here so that the user profile would show the most recent list of their corpora if they hit sync and they were logged into another computer where they added a corpus.
+1
Trocar a ordem das coisas: 
de "in a short stay during San Francisco" ==> "during a short stay in San Francisco"
**Error:** Expected "foreach (...) {\n"; found "foreach(...) {\n"
> I agree that `TfidfVectorizer` (to stay consistent with `TfidfTransformer`) would be a better name. Would this API change be the right moment to rename the `Vectorizer`?

+1
hence probably
A, right I made the example before adding the overloaded filter() method.
I'm talking about the line below. I'll give it a try and see if I can find the root cause.
I realize it's commented out, but I think that'll be confusing ultimately.
Add trailing slashes to namespace `Application\\` is a good optimization for reduce the number of stat operations
Can you expand on what "resource" means here? This is specifically for Android compiled resources that are traditionally accessed via a resource ID (either from the application resource bundle, or Android's internal resource bundle)
make two when() calls for this
I am wondering whether many people will not understand what 

```scala
class C2 private
```

actually is. Do you think

```scala
class C2 private()
```

or even

```scala
private class C1()
class C2 private()
```

would be clearer? Or would that rather be encouraging questionable Scala style?
```
private SharedPreferences getGlobalPrefs() {
  return mContext.getSharedPreferences("sync.prefs.global", SHARED_PREFERENCES_MODE);
}
```

because we do this in two places so far…
added `monitoring.rst`
Your analysis looks correct, even though it doesn't happen in our production servers (they have virtually the same setup).
So, do you think that adding a test for possible PK conflict and not updating :oldid if :newid is already taken, would be a better approach?
you should use res.isWorseThan(Result.SUCCESS) instead.

http://javadoc.jenkins-ci.org/hudson/model/Result.html#isWorseThan(hudson.model.Result)
this file should be removed.
Martin@MARTIN-PC /D/workspace/phpBB-Social-Network (track_fix)
$ git pull upstream develop
From git://github.com/Kamahl19/phpBB-Social-Network
 * branch            develop    -> FETCH_HEAD
Already up-to-date.

Martin@MARTIN-PC /D/workspace/phpBB-Social-Network (track_fix)
$ git push origin track_fix
Everything up-to-date

nothing has happend. once again, why does this happen? i dont understand
Good point, but isn't this already a problem, since max_chunk_size is global?
According to the Twig CS, you need to keep the space between the filter name and the closing of the echo tag
Makes sense to me. I'd need help to do it, though. My PHP is weak.

Johnny
what kind of value are you substred ?