labofsahil/github-event-dataset-2012 huggingface dataset:
Should we not define specs for aliased methods?
But looks same as Array#[], Array#slice.

* [Array#slice](https://github.com/rubinius/rubinius/blob/04616454bfef4b5c1f230bffbc60597debcc649f/spec/ruby/core/array/slice_spec.rb#L164-166)
* [Array#[]](https://github.com/rubinius/rubinius/blob/04616454bfef4b5c1f230bffbc60597debcc649f/spec/ruby/core/array/element_reference_spec.rb#L5-7)
* [aliased](https://github.com/rubinius/rubinius/blob/04616454bfef4b5c1f230bffbc60597debcc649f/kernel/common/array.rb#L175)
I notice `iurls` isn't used anywhere.  Why add it?
@mickhansen is sometimes a bit lazy, so this allows him to write ````.find({id: 12})```` instead of  ````.find({where: {id: 12}})````
For me the private visibility is enough since forbid "unauthorized" modifications in extended classes
Take a look to the rest of the refactored tests to see how to remove this dependency.
So you won't need to define the getOptions. I agree this may not be the best way but this is how it works in Form elements, basically the base setOptions copy the array to $options property.

In your classes that extend Input, you only need to define setOptions.
Can you submit this fix in a different PR for merge it early?
`@param bool $shouldCreateTemplate`
Should be one line of } else { instead of two.
No need for that. It's private method, and it's not returning anything in other cases, so this one is correct.
I'm assuming this guy is thread safe and we don't need to do bother about locking etc
I would call it warnUser since it's a method.
this function is neat and could potentially be useful in dimagi-utils
@white
I'm confused? It won't allow you to put a closing tag of the parent element inside a virtual knockout tag. It just outright refuses.
Missing line break between param and return
should be an ``elseif`` .. ?
v_tmpcnidscheme is allocated (strdup), but never freed.
What about 

~~~~
remove = not nohelp in [opt.help for opt in optgrp/option_list]
~~~~

? Seems more readable to me, at least
Is that dictated by PEP8? I don't think we do that anywhere (well, I don't)...
It's better/nicer to use a list comprehension here, but OK to merge in.
Yes indeed, the confusion with putenv was not necessary.
If you require `'vc-hooks`, I think you can use `(vc-find-root file-name "CVS")` to get the same effect.
`new ApplicationLayout {@title}`
According to the README we should drop priority for ESR10 or release-mozilla-esr(LAST) to 600+
Nit: whitespace diffs are a little annoying. But, when I experimented with making git auto-correct that sort of thing, that was even more painful.
Store a reference to the container
s/leises/kurzes/
Yeah. It's not really documented anywhere and I didn't go back to change all plugins as the functionality isn't used widely. The idea was to do it when updating them ;-)
Yes, this should work!
Use `part.indexOf('/') !== -1` here. It'll be faster and is easier to read.
I hope you don't mind additional content: I added Windows ockSize() implementation to the pull request.
oldDataSerialized = (null != coordinateData) ? "" : coordinateData.serialize();
This should probably be a union of the flags (`File::FNM_DOTMATCH | File::FNM_CASEFOLD`) and not an array? (See CI [details](https://travis-ci.org/#!/CocoaPods/CocoaPods/builds/2829879).)

When I apply this change the tests [fail for me](https://gist.github.com/3907773). Can you confirm if that change still works for you?
Thor provides #say for more control over how you output to the terminal.

https://github.com/wycats/thor/wiki/Actions
Why require it in the `<head>`? Also, if you're going to require it in the head then I'd prefer full HTML.
Also remember to add semicolons
could we save the lookup in case the uid is empty? (like set in line 59)
Yeah, so I'm saying just a Refresh icon, no text.

--------------------
http://anildash.com +1 646 833 8659

On Jul 17, 2012, at 8:53 PM, Gina Trapani <reply@reply.github.com> wrote:

>> -ThinkUp is capturing your social data. The log below lists the technical details of what's going on.
>> -This could take a while. Leave this page open until it's complete.
>> -     </p>
>> - </div> 
>> -<br />
>> -<iframe width="850" height="500" src="run.php{if $log == 'full'}?log=full{/if}" style="border:solid black 1px">
>> -</iframe>
>> -<br /><br />
>> -    {include file="_usermessage.tpl"}    </div>
>> +<div class="row">
>> +
>> +    <div class="span3">
>> +          <div class="sidebar-nav">
>> +            <ul class="nav nav-list">
>> +              <li class="">
>> +                Update ThinkUp Data
> 
> But having 2 buttons, "Upgrade ThinkUp" and "Update ThinkUp", both in the status bar, is too confusing. Remember the mailing list thread about this?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ginatrapani/ThinkUp/pull/1361/files#r1184674
и где direction используется?
Add in linting of all non-vendor JS
Normally this would look bad doing `param == false` and `param == true`, but I want to actually compare the values to booleans. This avoids a case where nil would be evaluated to false if it wasn't explicit.
This is more of a question than code review... but... this is here for future use, right?  Meaning that if it gets called right now, we want it to fail because we haven't implemented this yet.  If I'm reading the docs for condp correctly, that's what will happen here because you didn't specify any clauses for it to try to match against.  Right?  Or should we explicitly add a "default" case here that throws something akin to a NotImplementedException?
We might want to make the timeout on these signed link slightly longer. I can imagine that comparing revisions can easily take longer than 5 mins.
Please update JSDocs.
The fact that all of these external functions all provide true is a good indication that it shouldn't be on the public function.
It feels like the global admin should not go into the config-aggregator.
> What is the race condition? Or mean lost updates?

Isn't a lost update a form of race condition?

Anyway, the problem I have with this is that ``ScalaDebugger.currentThread`` is accessed from ``ScalaDebugModelPresentation`` and ``ScalaCollectionLogicalStructureType``. And , to my understanding, this will work correctly iff ``currentThread`` is accessed in the UI Thread.
Yes, typo error.
Add documentation strings using doxygen syntax like those in the rest of the codebase. common/Router.h is a good example.

Each doc comment is the line before the construct it is documenting, and begins with "///".
zal deze nog even aanpassen *WORKING ON IT*
You don't use `$sub` outside the `for()` loop, so put it there:

    for ($sub = '', $seg = 0; $seg < $seg_ct; ++$seg)
Use only tabs as separators - no spaces (between 'string' and '$url' + although followed by a tab, you have spaces after both `@param` and `@return`).
Additionally, for the sake of consistency there should be an empty *description* line between 228 & 229.
если есть static, то значит во всех единицах компиляции (объектниках) будет своя копия этой константы! Потери, конечно, не значительные. если без static - то будет либо множественное определение либо ещё что-то (лень проверять), я бы сделал:
extern const int a - в хедере (обещание, что где то есть определение)
const int a = 5 - в одной единственной имплементации (само определение и единственное)
Как считаешь?
на счёт define - вариант для констант, но таки да, лучше таки константы.
Соглашусь.

Вообще, как всегда говорю я, программист - лицо ленивое, поэтому должен стараться писать всё так, чтобы для исправления ошибок/внесения изменений требовалось минимум усилий. Это относится, во-первых, к каким-то значениям, которые используются повсеместно в программе (имею в виду, одни и те же значения, разумеется), а во-вторых, к кускам кода, которые так же используются как минимум в двух местах - лучше такой кусок сделать отдельным методом/функцией, тогда вносить правки нужно будет только в одно место.
Свойство лучше объявить только для чтения.
Do I have to do the work in production and test files too ?
I guess so but just to be sure...
create_user_and_sig_in

поправь плиз опечаточку (вижу что не твоя, но раз уж здесь :) )
You can look for a library with a function that's only present on PI using check_lib(). I guess -lbcm_host is only present on PI?
ClassMetadataInfo has far more methods than the interface from Common (all the ODM-specific logic). So this allows having IDE completion for all the additional methods (i.e. most of the methods used in this class)
Style: explicit `nil` comparison.
This looks like an empty catch block. What type of error are you expecting?
Not 100% certain on what the formatting of the help for keys is going to be like, they can be retrofitted once formatting is done.
I don't beleive this is correct - entry corresponds to a git_config_entry * on the native side, but we GitConfigEntry is a struct on the managed side. So, what we are really getting here is a pointer to a git_config_entry (and not the git_config_entry) structure itself.

I think you could either:
1) Take an IntPtr here and marshal the structure manually
2) Declare GitConfigEntry as a class

I would prefer to keep the Interop as a struct and manaully marshal the structure.
This change was caused by the commit I added to `testrepo_wd`. I couldn't figure out a way to fix `1/branch_file.txt`'s mode without having to change this test too.
@cspurk Even if the variable is not used, the created object manageruser is used later, for instance in the function "test_deleted_manager_group_is_removed_from_all_relevant_users".  It is required to make the user on a user manager.
This will change the `os.environ` for subsequent processes. 

``` python
git_env = os.environ
git_env['LANG'] = 'de_DE'
os.environ['LANG']
# 'de_DE'
```

Doing `git_env = os.environ.copy()` will not modify the existing values.
you could have also used

if isinstance(reject, dict):
how did you come up with this number?
On the other hand, i think it's fine since relationshipType.name isn't a persistent property
style: day to day should be day-to-day
in fact, you can also use it with a then part if you want by omitting the closure as argument: ``->always()->thenInvalid()``
Usually here I just put a very short message about this being new. For example:

>
The numeric node (float and integer) nodes are new in 2.2

Then, in a normal paragraph, I start to explain them (e.g. talk about `min` and `max).
where is log level set now?
Just a cosmetic note: could we not perhaps shorten the name to ArchiveClearingResponseStrategy. I think it will still be clear from the context that the archive will always be cleared.
val will always be a list, so this is not necessary.
Actually it should have been !=.

On Sun, Jan 15, 2012 at 8:50 AM, Christopher Smith
<reply@reply.github.com>
wrote:
>> @@ -467,3 +467,8 @@ def _eval_derivative(self, s):
>>      expr = MyExpr(x,y,z)
>>      assert diff(expr,x,y,f(x),z) == Derivative(expr,f(x),z)
>>      assert diff(expr,f(x),x) == Derivative(expr,f(x),x)
>> +
>> +@XFAIL
>> +def test_issue_1612() :
>> +   x= Symbol("x")
>> +   assert Symbol('f')(x) != Function('f')(x)
>
> the `!=` here should be `==`
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/sympy/sympy/pull/973/files#r353929
this should not be `static` but a private property of the class `private $_userHostAddress;` to fit the style this kind of caching is done in yii.
М, лучше это обрамить в `IF (NOT WIN32)`, подобно нижеследующему y7.
Quizá también deberías mostrar las Excepcions acá.
¿Este lo podemos considerar hecho? Si es así, lo quitaría del backlog.
This should be declared as a constant
holy crap are we really returning US-ASCII not utf-8?
Using `iterator()` prevents the queryset cache from being populated during the iteration. Since we aren't going to iterate over it more than once and this is potentially a "large" queryset that should result in better memory usage. It's a bit of an early optimization so I'm happy to remove it if it seems unnecessary.
I'd rather not change this to use the graph interface for two reasons:
  * It currently implements the Clustering interface, which is really nice and portable
  * This provides an alternative implementation with slightly different guarantees as described in the paper.

If we want cross compatibility, we could easily write wrappers between graphs and matrices, but that should be in a separate change.
Do you mean: class Root(MySQLUser)?
Testit eivät mene läpi, mm. rekursion pohjatapaus on väärä.
Need to change XmlFileParsingTest as well, it's failing now.
show_package will run navigation_bar.add_with_id with the same package name again,
but a additional navigation tab will not be created: as the documentation for add_with_id explains,
"If there is the same id already, replace the existing one with the new one".
It's merged so it doesn't matter, but in future we are trying to standardise the code base towards PEP8 which recommends spaces between operators (and after commas).

I'm not worried about getting this sorted (it will get picked up eventually by an automatable tool).

Cheers,
I am a new core developer, so I'm really not the best person to ask here. One of the other developers probably has more insight. I defer to @efiring, @mdboom or @WeatherGod.
I have added https://github.com/mozilla/gaia-ui-tests/blob/master/gaiatest/gaia_test.py#L191 which returns `true` when headphones are plugged in; we should make use of the data layer API. Alternatively, you can also use http://dxr.mozilla.org/mozilla-central/dom/system/gonk/nsIAudioChannelManager.idl.html
А это каким боком?
The problem previously was that translate3d only works fine if it is set on all overlapping elements. This is why it is now set on the viewPortDiv and all of its children. I didn't notice any performance problems on my old 500Mhz CPU Android 2.3 mobile, but it might make sense to do more testing on other devices.
Might want to put a comment here about where and when the stream IS disposed.
minLength would be better as minlen - more consistent with rest of the codebase
Updated the SDK, thanks for pointing that out James.
Do we need the dataType here? Since you request a JSON format in the URL $.ajax will be intelligent enough to determine JSON is coming back.
@jsloane Can we remove `addToContactsResponse` completely, both in the HTML and JavaScript?
Missing space `){`
please use

type* w

so float64_t* w

etc
yep but when i wrote this i was dealing with odm so there is orm and odm. does it make sense to change it? it's not part of any api
Now "==" is used consistently.
I couldn't find any problems with the implicit casts. Maybe it's just because I've never seen them used in this way.
Since I can't find reasons against them, I've merged it.
If we get problems with them in future, we could remove them anytime.
Are you sure you want to override the parameter ``$date``? This often makes code less readable.
Are you sure ``$notEmptyMock`` has the correct type as ``object<PHPUnit_Framework_MockObject_MockObject>`` is not a sub-type of ``object<Zend\Validator\ValidatorInterface>``?
This line seems to be repeated, once inside the readcallback function and here.  Is this intended?
What a fuck !
Well, a Chinese way of expressing the idea.
please use 4 spaces per level for the indentation (you did it in some places in this file but not everywhere)
@eddiejau - 

I didn't replace any of the JExceptions since those will end up changing the API (I believe). I put a question on list asking how you wanted to handle those. (The only change I made for the JExceptions was to simply replace the JText.)

I'll change this to InvalidArgumentException, just wanted to make you aware of the bigger question I have.
That is not exactly equal to the source code. Anyway, I will do as you suggest and re-pull request.
This example shows streaming unpacking.
This for loop should be in while block.
Ordered and separated.
You should configure jQuery (globally, in `common.js`) to use [traditional type of serialization](http://api.jquery.com/jQuery.param/).
We write in third person singular.
So move this to a class. And then `request_mark` could be a class attribute.
Use more spaces, for example, around `,`.
Yes, the CERN Root project is using some other documentation generation. Doxygen will not pick up or generate anything here.
perharps
"
While the Opera spec specifies a default of 1, this code
code will default to the maximum of 9 to minimise sending failures.
"
all this deletions were added by resharper..Just formatting issues..
also would use [0,15]
I believe the time is parsed by django template engine.
I just deployed, so you might not be crazy, you might have just seen your code live ;)
same comment as before

To do different paragraphs in POD you need an empty line between the blocs. A good way to verify if your documentation is correct is to test it with perldoc. Something like: `perldoc lib/pf/SNMP/Brocade.pm`
Was curious; Is there any way to programmatically inject into PigServer instance a relation (DataBag) you build manually, without having to invoke a LoadFunc?
Also, `options` is an ill-chosen name as it does not describe options. Perhaps `args`?
I'd add here that for playdoh projects, generating the .pot can be done with `manage.py extract`, while generating the .po files for each locale can be achieved by running `manage.py merge`.  That `msginit` command looks scary and you have to run it once for every locale. `merge` takes care of that.
Whynut? It's THE feature.
We may change the bootstrap stuff, the same with backbone.js in the future, at this point we can do it.
These comments refer to 

def get_margeff

The line numbers changed while I was adding comments.
Ditto the above. You probably want methods that do plotting to be preceded by a plot_, so plot_contour here might work? plot_mean_var_contour is a handful to type.
are the version linked together? Is it safe to check for the 2.3 version of the Common lib?
Sorry for the delay.  I meant that this line does not match the indentation style of the rest of the file.
Yeah, it's weird that this could be none. Quirk of django!
We recently went and removed all the cxf-servlet.xml files.  Should we do the same here?
Problem with CS
In the Kelvinator code i chose to use this idiom:

  where = getattr(settings, 'AWS_ACCESS_KEY_ID', 'local') 
        if where == 'local':

Your way is probably more robust.  I'll probably switch over to that too.
Perhaps we should guard against getting back null, so can throw exception with the missing name rather than just an NPE.
what is this for?  doesn't seem to be used.
On Thu, Nov 08, 2012 at 11:34:12PM -0800, Jeanneret Cedric wrote:
> > @@ -0,0 +1,52 @@
> > +# file managed by puppet
> > +<VirtualHost<% ports.each do |port| -%> <%= port %><% end -%>>
> > +  ServerName <%= name %>
> > +
> > +<% aliases.each do |serveralias| -%>
> > +  ServerAlias <%= serveralias %>
> > +<% end -%>
> > +
> > +  RewriteEngine On
> > +  RewriteRule /(.*) https://%{HTTP_HOST}/$1 [R=302]
> 
> hmmm nope, $name is not what we want. If we provide aliases, they *have
> to* be in the certificate. They are in the generated CSR.
> In our usage, $name is something like project_name, while aliases are correct URLs.
> Using $name will break most of our projects, break deploy method and so on. bad idea then.

%{HTTP_HOST} is something completely random. Imagine the user has put an
unusual "search" line in /etc/resolv.conf or something unexpected in his
/etc/hosts. In this case, the redirect could point to a hostname not
included in the SSL cert.

As we have the full list of names included in the certificate, why not
directly redirect to a valid one ?

> OK for port number, I'll have a look at that.

Cool, thanks !
There are a few untested property getter/setter methods in here:

 - allow
 - allow_ip
 - authenticated
Is this file valid? This line should have a comma before `#{@res...`
you need to check if we actually have a value there first..
Indeed, looks like to much copy and replace! And yes, this test is difficult to make work everywhere - I do think it's important to test this though. Would you have any good idea to do that? For now, I think we should just commit it and think about this problem hardly.
The overlay?
Alright, I see your point. Thanks for changing it.
I think this hard-coded mark-up should be removed until we have the back-end functionality to go with it.
I think this is an opportunity to "pretty up" our routes - how about just "standings"
Same comment as above on returning `null` and exceptions.
I winced a little after hitting merge and realizing I approved something that had the word 'sexy' in it.
I would argue this is invalid.  A serial connection doesn't have a board type.  Neither does PipX (it has two boards really, the remove and local one).  Because there isn't a unique map from VID/PID -> board type I can't think of a reason to use this method except to make a bug ;-).  Plus it isn't used.
The "elseif" should be brought down to the next line and the space removed between else & if so that it is one word. http://drupal.org/coding-standards#controlstruct
perhaps we name it to 'pipe()' ?
How about an intention-revealing name for a method which explains it?
Это не исправлено до сих пор?
I was thinking: `openForCurrentTab(window)` or `openForCurrentTab(gBrowser)`… or maybe `openForCurrentTab(gBrowser.selectedTab)`
They were related in that they both tossed up warnings in brew audit, but if it's really an issue, I can split them.
Sorry, Fixed on master.
given that this method gives the app the path of the file on the test machine, not the path of the file on the remote machine running the browser, i was pretty much expecting it to fail...it didn't. i find this suspicious. watching the test didn't really clear it up for me (partly because the elements being interacted with were half-on half-off the screen).
i thought he was talking just about making the variable name "app_details_page".
same as the other comment at line 89
このように

と

    次のように

でぶれている箇所が幾つかある？
Here is a note
Any chances, to get a quick docstring there?
Somehow it feels to me as if this could be expressed more simply as a list comprehension / vectorized.
<untested code>
```python
norm = np.sum(weight[:n_estimators], axis=0)
proba = [est.predict_proba(X) * weight for weight, est in zip(self.weights_, self.estimators_)[:n_estimators]]
return proba / norm
```
</untested code>

or even
```python
prob = np.array([est.predict_proba(X) for est in self.estimators_[:n_estimators]]
weights = np.array(self.weights_[:n_estimators])
return np.dot(prob, weights) / weights.sum()
```
If `X` is in COO, CSR or CSC sparse format, you can also pass `X.data`.
I am wondering if an __inline__ function wouldn't be useful here to avoid so much copy and paste.

The problem is that I usually do this in C with a macro. I am not sure if it is possible to do it with a function...
I'd really push for having the data generation code rather than the data file itself. I frown on adding data to the scikit, especially if they are not standard reference data widely used in the machine learning community.
Le 24/10/2012 23:38, serge-sans-paille a écrit :
>
> In pythran/pythran.h:
>
> > +    };
> > +
> > +template<class K,class V>
> > +    struct assignable<pythonic::core::dict<K,V> >{
> > +        typedef pythonic::core::dict<typename assignable<K>::type,typename assignable<V>::type > type;
> > +    };
> > +
> > +template<class T>
> > +    struct assignable<pythonic::core::list<T> >{
> > +        typedef pythonic::core::list<typename assignable<T>::type > type;
> > +    };
> > +
> > +template<class T, class U>
> > +    struct assignable<__gmp_expr<T,U> >{
> > +        typedef mpz_class type;
> > +    };
> >
>
> ce dernier template (tout comme le #include gmp...) devraient être 
> dans un fichier pythran-gpl.h qui serait inclus dans interface.py (je 
> crois)
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/serge-sans-paille/pythran/pull/21/files#r1934679>.
>
C'est exactement ce que je suis en train de faire en ce moment. J'ai 
trouvé un moyen "plutôt" élégant pour traiter le no_gpl. Je te tiens au 
courant ;-)
same as above, remove unneeded configparser
yep, I also had 'didAppendScreen' -> also think its more readable
OT: In past, Andrei talked about `is(var == ref)` to test whether the `var` is really ref variable or not. It seems to me that is a kind issue bug 1673. If we try to implement it (and its families, e.g. `== pure`, `== nothrow`, `== @safe`, `== @property`, ...), we would be able to use the same mechanism.
need to return and throw an exception if this happens. also need to check the bounds for sourceOffset/length
Actually that is not array. Changed casting into object instead of array.
change to
if (height_ != NULL)
Retourne les informations d'un document enregistré dans Phraseanet
Ookay. :)
Doesn't this get leaked?
Too late. This needs to happen *before* the url variable is created.
this is done in `setUp()`
It's not, we're going to need to redirect this to the old site until the correlations stuff is redone.
I would not call this BUF, not even UIP_IPUDPH_BUF! It's the UDP header of the IP packet and not a buffer.
So forget about my comment from yesterday. Declare a local pointer variable pointing to the UDP header,
give it a self-speaking name,  and use this to access the header members.
My bad, I thought it was inherit from `Worker` – that do not have this check. I will add similar validation then!
Shouldn't this be:

"if (!isset($path[1]) || $path[1] !== '~') {"

?
ah, i see :-) il fix it.
yeah that makes sense, fixed
I'm a bit worried about this sorta goofy/confusing code. Not sure how to make it more clear.

If `current_manifest` either doesn't have they keys in `original_manifest` or the same value for a key, they are found. When found returns with a value, that means there are differences. When found is `nil`, that means there were no differences so return true.
You might add that the threshold can be disabled with `t=False`
Why are they ignored?
this is a place holder while the work flow to define this for selection is properly defined
This probably is necessary. BIDPOM will switch back to the main window after signing in, so it probably does make sense to wait for the page to reload. It really depends on the app, some might want to wait for a 'Logout' link to be visible.
I'm not sure how comfortable I am about using QDir to do this, as afair it's somewhat expensive to create... but I suppose we don't have much option to do otherwise, and compared to the scaling, it's probably not that slow.
if it was safe to remove it you may remove it for good :)
If it needs to be revoked it's easy through the source code management
Indeed. I've made the correction.
```verbose``` arg appears unused.
Performance and buffering, this matches every other udp scanning module (and agree these should be standardized, but not with this pull)
elsif res and res.code == 401
```client.session_host``` would probably be better here.
No, it isn't because you want the filter function to return the "exact" result as `dobule` values.
yes but then you still have an exception. If you are using something like airbrake/hoptoad or custom notification system you will have an exception every day or even more exceptions per day. This is why was trying to avoid this. A 404 as you mentioned would be more suitable I think. 
Because after all, the product the user or google is trying to send via email doesn't exist.
nacheck ko pala wala naman yugn feature-org sa repo. anyway ginawa ko na din assets
Меняется в скрипте, в зависимости от архитектуры, на которую билдим
Am I understanding this right?  On each `update`, we iterate through all labels?  So if the labels didn't change - or more precisely don't require a glyph rebind or reposition - we still pay for iterating over each one?  So if we're rendering labels for say all the zip codes in the United States, we burn a ton of CPU doing nothing?  Please tell me I am reading this wrong.
`xOffset` and `yOffset` default to zero.
I was way more excited than I should have been when I found this ;)
Probably put this in a separate spec (my style is very fine-grained so when a spec fails, we know exactly what).  Or at least change the description to say "near or far."
Is it worth dropping `Cartesian` from `getValueRangeCartesian` since `Cartesian` is the standard in Cesium?  Or are there other similiarly named functions that return things other than positions?
Rename `imageID` to `imageIndex` since it is more specific; an ID can be anything.
Also, the parameters are getting ugly enough that we should consider replacing them with an object literal.  It could have mutually exclusive `images` and `image` members for the strangely common case of creating an atlas with a single image.
Right, that function is backwards.  Don't worry about it for this pull request; I'll fix it.
How about `ego`?
gem 'bubble-wrap', :require => ['bubble-wrap', 'bubble-wrap/all']

これが正しいようです。
Fair point. Updated.
getNativeView() may return null here..
This has not been a problem to date but is part of a larger locking evaluation task and outside the scope of this bug and PR.
Getting rid of the bridge should be fine, but it looks like you've already submitted a PR for this.
please add a comment to .h file that tab is now assign(non-retain) ivar.
I think you can delete this blank line.
Agreed. There are three functions and on instance variables. However, the class does act as a sort of namespace, and it matches the other examples. I think I'll leave it.
Do we have any arrays or objects? If it's just plain key-value pairs, you can do the same in much less code.
okay for "is None".

What this line is supposed to do is to let the environment in the same state it was when entering the test.
Because the test sets an environment variable, we are deleting it if it wasn't set at the beginning of the test.
Would be more concise as:

```javascript
var jasmineEnv = jasmine.getEnv(),
       htmlReporter = new jasmine.HtmlReporter();            
```
Excellent points, I will fix these right away.
Heya Eduardo,
This stuff should go into the _styled/extras.css like so:
```
.portlet-document-library, .portlet-dynamic-data-mapping {
	.lfr-ddm-small-image-preview {
		@include box-shadow(0 1px 3px #ccc);
	}
}
```
Fixed the other issues, but not sure what to do about this. FileReflector already extends PHPParser_NodeVisitorAbstract, but BaseReflector doesn't extend anything. So FileReflector cannot also extend a new ReflectionAbstract.

ReflectionAbstract could extend PHPParser_NodeVisitorAbstract itself, but this doesn't seem to make sense. Or (better) FileReflector can extend ReflectionAbstract and implement PHPParser_NodeVisitor then add dummy implementations for leaveNode() and afterTraverse().
тут правильнее всего реализовать конструкторы перемещения.
I hate to ask for a change at this point, but adding explicitly the imports seems to be unnecessarily complicated. I think we can simplify this by e.g. assuming all examples in std.xyz import std.xyz. Also, any other imports should be visible in the example.
use the simpler syntax for the constraint, `auto opSlice(size_t a, size_t b) if (hasSlicing!Range)`
The same for `c3` or any other local variable that's never going to change. In the case of `p` though, it would probably have to be `const`, since it's a pointer. In general, prefer `immutable` and `const` if a variable doesn't ever need to be mutated. It'll reduce bugs and help the optimizer out.
In my opinion, your latter point is precisely why we should go for for upper case. It's returns a template, it's upper case. Simple as that.
Is there really ever such a case? core.bitop isn't versioned in any way shape or form with regards to `bsr`. As far as I can determine, `bsr` is always defined.
I've rather meant `->setProduct(ProductInterface $product = null);`.
Done :)
On 7 Dec 2012, at 17:22, Jens Timmerman wrote:

> In easybuild/easyblocks/c/cufflinks.py:
> 
> > +# Date::      $Date$
> > +
> > +import fileinput
> > +import glob
> > +import re
> > +import os
> > +import shutil
> > +import sys
> > +
> > +from easybuild.easyblocks.generic.configuremake import ConfigureMake
> > +
> > +class EB_Cufflinks(ConfigureMake):
> > +    """
> > +    Support for building cufflinks (Transcript assembly, differential expression, and differential regulation for RNA-Seq)
> > +    """
> > +    def patch_step(self):
> 
> Your docstring still isn't :-p
> 
> —
> Reply to this email directly or view it on GitHub.
> 
> 

Cedric Laczny,
PhD Student
 
UNIVERSITÉ DU LUXEMBOURG
 
LUXEMBOURG CENTRE FOR SYSTEMS BIOMEDICINE
Campus Belval | House of Biomedicine
7, avenue des Hauts-Fourneaux
L-4362 Esch-sur-Alzette
T +352 46 66 44 6398
F +352 46 66 44 6949
cedric.laczny@uni.lu     http://lcsb.uni.lu
 

-----
This message is confidential and may contain privileged information. It is intended for the named recipient only. If you receive it in error please notify me and permanently delete the original message and any copies.
-----
Seems like there's a shortcut here, rather than computing the whole set… if a `KeyBundle` implements `equals`, you can probably just rely on `Map.equals`. That'll short-circuit on size etc.
But we will need to track failures eventually…
I have added details to the comment. If the string cannot be deserialized into a supported json value, we store it as a regular string.
Totally. I didn't know we had this (or that you could do that)
I actually took this from OpenOffice formats. They put the minus in front of the currency symbol. 

I suppose MS-Excel uses the same format. 

It is quite common I suppose.

Yep, I confirmed. ms-excel is the same:

http://www.techonthenet.com/excel/cells/images/format2011_003.gif
http://www.accountingweb.co.uk/sites/default/files/siftmedia-accountingweb/u176381/excel1.jpg
this feels Java-like :-) Python methods are usually verbs. if this really needs to be a method, maybe call it `.record_new_case()` or something, but even that feels weird if you aren't recording anything about the case. If it's really just incrementing a counter, just increment the counter directly. In Python, data members can be a direct part of the public API of a class, it doesn't all have to go through methods. Part of what makes this workable is that you can always use properties to replace a data attribute with something that looks exactly like a data attribute to the outside world but has more logic behind it, if/when you need that.
Just assert about the tags, nothing else.
MINOR: Refers to logging_entry_modifiers_tests.h instead of log_entry_modifiers_tests.h in comments.
String in - string out
Rename to CREATE_MESSAGE_GROUP
``$cmd`` is undefined
> Still, I don't know if this is the right solution to the invalid UTF-8. :(
> 
> I mean, I agree with the idea and the code, but I wonder if there's a
> better way to solve this? Like, why do we have invalid UTF-8? If we're
> really processing binary or ASCII data, we should set the encoding to ASCII
> or BINARY, I think? Hmm...

In my case, invalid utf-8 log lines were product of user input being logged directly without proper treatment by the logging source.

If I can understand the following explanation correctly:
http://blog.grayproductions.net/articles/ruby_19s_three_default_encodings

If you're getting strings through IO from the outside world into ruby 1.9 and are using some sort of UTF-8 locale (as I am), you will get utf-8 strings in ruby. As long as you're getting your data from an untrusted source (can we assume grok input is untrusted?) you can get invalid utf-8 data, and have to deal with it. If your locale is set to some ASCII type, you will get ascii strings in ruby and this utf-8 bug may never happen.

That said, I don't know the best way to solve this.  Here are some ideas, but I don't know how they affect performance:
http://stackoverflow.com/questions/2982677/ruby-1-9-invalid-byte-sequence-in-utf-8
ups, float that is. its a double precision floating point value in java.
`singleton_class` is defined in `ActiveSupport`; if you don't have a dependency on it, and don't want to add a dependency on it, you can do this instead:

```ruby
(class << self; self; end).class_eval { attr_reader cattr }
```
Yeah, sorry. I tried explaining in my todo that we should check for an instance of a backbone view.

This check should be updated to be:
```
if (_.isFunction(itemView) 
    && !itemView instanceof Backbone.View
) {
  // ...
}
```
missing 2 spaces here
- teleport_on_this_node |= (point_Idx == path.size() -1 ? !never_teleport : false);
+ teleport_on_this_node |= (node_Idx == path.size() -1 ? !never_teleport : false);
It might be good to have a generate `Utility.ParseBoolean` function that encapsulates this simple logic but makes the code more reasonable.  It wasn't clear to be what was going on here until I checked the KML referenced guide.
IMHO decoding is only necessary when the data comes from the controller. You could also create a thread object programmatically and then you probably wouldn't pass an encoded permalink to the new object but a "clean" one. That's why I put it there.
I think error checking and writing the header row should happen here (bail out immediately if the file can't be created, and don't make any api calls.
You saw nothing!
i prefer your solution. created #47 for this
but what about the children of children?
*NOT* -> `*not*`?
This is a nitpick, but, I don't think that modules are the only conceivable use for this tool;  therefore I wonder if we should use a more generic directory name.
like that its useless.. maybe notch brainfart?
The reply wouldn't be a SchedulerMessage would it? A message meant for the controller should be of the type ControllerMessage, which doesn't have the id field.
Is there a reason to make this change, in something that's going to run from the command line?
cool, its good know, I could have used this a few places. Thanks good to know
To be fair, you do get immediate feedback if you're passing something wrong in a query: the query fails. But QueryBuilder has helped me virtually eliminate query errors in SFiPad, so having it throw errors seems at odds with my main reason for writing and contributing it in the first place.
autoescape is used as a bool, so default should probably be False
Ask Gavin... he should know. Oh, wait...
hay que poner algo así como un "delta_time" de python. o en el peor de los casos un text, y se le hace pickle al delta_time de django...
es una cantidad de tiempo (en dias, horas, minutos y/o segundos). no es una fecha ni un horario.
I believe the spec calls for the case of the encoding to not matter.  The canonical list of the encodings uses lower-case, however, and I was being a bit paranoid while I was trying to figure out what was wrong here.  The main change in this hunk here is that cp949 is not a legal encoding, and windows-949 has to be the name we use instead.

I think most  of the problem may just have been with the shim interacting with the native implementation...
Is there a reason this check is not in the caller?  If you are trying to keep fullSync opaque, it makes sense, but I would think that 'updated' is something ActiveSync will use too?
yes mario, you need to reuse reports in Sonar, so that it does not try to re instrument your code. (+ add the emma plugin in Sonar)
Changed because we develop on CentOS.
If this is just for testing, add a read-only accessor (and use it throughout).

If it's not for testing, you need synchronization.
Mettre *un autre titre* ici
add a validation step here to make sure the incoming patient is not null and there is exactly one null person (A or B) in each relationship.
you should not put your name here. If you want your name somewhere, add it to the doc block of the class itself.
you should not encourage people to create services using the alias of the bundle. they should use the naming convention of their own bundle
nahh lets keep it separate its fine.
once you create a separate extension for pps you can make this extension dependent on the pps extension using the dependencies attribute. which takes in the folder name and not namepsace name :)
présentées
distribués