labofsahil/github-event-dataset-2012 huggingface dataset:
Hrm; there's an obstacle to doing so.  The worker config includes a default process-by, but the minion never sees it; the config is encapsulated inside the worker.  And the minion and worker are instantiated separately by the boss.  Possible solutions i see:

* remove the ability for Workers to have individually configured defaults for process-by
* have the Minion get the default from the Worker every time (seems a little dirty; breaks encapsulation)
* have the Boss instantiate the Minion and the Minion instantiate the Worker (instead of the Boss instantiating both separately)

#2 is probably the easiest.  #3 is probably the cleanest.  Most all of the code inside the workerCount loop on line #226 could be moved inside the Minion.  You could then remove the requirement that the kestrel client and the worker be passed to the constructor.  Also, I'd make the connection to kestrel inside of the Minion thread rather than in the Boss.  I don't know that that part is functionally different, but it seems cleaner.
Every strings looks better after getting parsed by walrus, even empty ones.
*add to the path

On Tuesday, February 28, 2012, Moses Nakamura wrote:

> Trevor, please only use Scaml unless you really can't do it with Scaml.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/mnn2104/Beer-Battle/commit/56e8abf3bbe50e4858e71ef79565b646f0780cc9#commitcomment-1021744
>
I get an error here when running the engine's tests. By adding "Controller" to the end fixed it.

`if Refinery::<%= namespacing %>::Admin::<%= class_name.pluralize %>Controller.pageable?`
You don't check whether the user is allowed to post Broadcasts / Announcements / etc. It's very easy to add arbitrary parameters to the POST request. 

Needs additional checks in editor TPL. I'd include that ASAP and set the flag to true as long as you don't check for user privileges. You should do this for every privilege depending feature, just to make sure you won't forget the checks.
Not possible to compile after this rev, maybe you know it.
Yes, exactly -_-. *Shakes fist impotently*.
Change 'outputtracts' from an Enum trait to a Bool trait - so now when outputracts = True the command line call will include the flag 'outputtracts', but not followed by the 'raw' / 'voxels' / 'oogl' string. 

Changed it because I was getting errors like

   "WARNING: WARNING: couldn't parse arg 7: 'raw' 
   Mar 2, 2012 6:25:29 PM apps.ProcessStreamlines execute "

The modification also fits with the description of 'outputtracts' in the procstreamlines entry in the camino manual

http://web4.cs.ucl.ac.uk/research/medic/camino/pmwiki/pmwiki.php?n=Man.Procstreamlines
Know, but GCC gives a warning if I don't use it.
A form label instead of a table heading? It's not really HTML spec compliant.
file permissions :). From rw/r/r to rwx/rx/rx.
It was better before.
every function must have a comment block that looks like this:

```
/**
 * Custom Favicon
 */
```
This sounds like https://processing-js.lighthouseapp.com/projects/41284/tickets/1778-make-pshape-and-pshapesvg-global-unaware . Care to comment in that bug with your sketches?
Deze code breekt het ophalen van de gedetaileerde lijst van actoren en geeft volgende PHP warning:

Parameter 1 to _cnapi_parse_actor() expected to be a reference, value  [warning]
given cnapi.parsers.inc:78

Waarom call_user_func() gebruiken hier ipv de methoden rechtstreeks aan te roepen?
Mostly covered in email. I just meant something that uses the code so this isn't just sitting here unused.
Understood. I mainly put this in due to my own negligence, where I used a couple different addresses before I settled on one.

I suppose I could take the "+"-based normalization out and just keep the command-line based remapping in place, and use that as needed.

That would be a simpler solution long term, methinks. Thoughts?
Are you sure about this? I saw that it says "Thank you" both on wowhead and on some quest vids.
Mike you can't translate variables, so using `__()` here is useless.
Put the actual unexpected type in the failure message. That will be easier when / if this happens.
changes look fine to me.reviewed.
Well, you could use a static one, but (and I wouldn't be surprised if i'm wrong) but if you start it up on a 10.2.something.whatever address and it tries to use a 192.168 address, it wouldn't work, correct?
what about the localisation in those creature_texts tables ?
not fix
[  5%] [  5%] Building CXX object src/server/game/CMakeFiles/game_pch_dephelp.dir/game_pch_dephelp.cxx.o
Building CXX object dep/g3dlite/CMakeFiles/g3dlib.dir/source/BinaryOutput.cpp.o
In file included from /home/data/!WORK/TrinityCore/src/server/game/Entities/Object/Updates/UpdateData.h:22,
                 from /home/data/!WORK/TrinityCore/src/server/game/Entities/Object/Object.h:24,
                 from /home/data/!WORK/TrinityCore/src/server/game/Grids/GridStates.h:23,
                 from /home/data/!WORK/TrinityCore/src/server/game/Maps/MapManager.h:27,
                 from /home/data/!WORK/TrinityCore/src/server/game/PrecompiledHeaders/gamePCH.h:7,
                 from /home/data/!WORK/TrinityCore/build/src/server/game/game_pch_dephelp.cxx:1:
/home/data/!WORK/TrinityCore/src/server/shared/Packets/ByteBuffer.h:37: error: pure-specifier on function-definition
[  5%] Building CXX object dep/gsoap/CMakeFiles/gsoap.dir/soapC.cpp.o
[  5%] Building CXX object dep/g3dlite/CMakeFiles/g3dlib.dir/source/Box.cpp.o
Linking CXX static library libgsoap.a
[  5%] Built target gsoap
Scanning dependencies of target collision_pch_dephelp
[  5%] [  5%] Building CXX object dep/g3dlite/CMakeFiles/g3dlib.dir/source/Capsule.cpp.o
Building CXX object src/server/collision/CMakeFiles/collision_pch_dephelp.dir/collision_pch_dephelp.cxx.o
[  5%] Building CXX object dep/g3dlite/CMakeFiles/g3dlib.dir/source/CollisionDetection.cpp.o
Linking CXX static library libcollision_pch_dephelp.a
[  5%] Built target collision_pch_dephelp
make[2]: *** [src/server/game/CMakeFiles/game_pch_dephelp.dir/game_pch_dephelp.cxx.o] Error 1
make[1]: *** [src/server/game/CMakeFiles/game_pch_dephelp.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  5%] Scanning dependencies of target authserver_pch_dephelp
@yashirotcm Fully working and with some minor problem that probaly soon going to  be fixed (it detects only minor addons and Parental control that seems kinda useless..)
The ``Configuration#addFilter()``
just in case you got negative average itemlevel, like just a few white or green items
Sorry about that! I must not have had all of your latest changes when I looked at this. That's great!
Resources for text searching using MySQL

http://dev.mysql.com/doc/refman/5.5/en/fulltext-boolean.html
 http://devzone.zend.com/26/using-mysql-full-text-searching/
 http://www.joedolson.com/Search-Engine-in-PHP-MySQL.php
 http://www.devarticles.com/c/a/MySQL/Developing-A-Site-Search-Engine-With-PHP-And-MySQL/4/
 http://en.wikipedia.org/wiki/Inverted_index
 http://en.wikipedia.org/wiki/Index_(search_engine)
 http://www.designplace.org/scripts.php?page=1&c_id=25
#52 shows why we want to do this... Do you really need your own catch-all? Maybe you can use something like get_object_or_404 for what you are trying to achieve?
you have done the sql Raydeon?
This doesn't work, and even if it did, the implementation doesn't account for a whole bunch of use cases. The test isn't what's described in the added "documentation," and the one "test" is not nearly sufficient! :(
Tell that to Mister_Fox on IRC, he's the one that sent them to me.
Agree. I was really confused when I saw it.

Sucks submit_button() isn't enough for the purposes you're going for it.
One more general question about where some COMMANDS belong. I was scratching my head for example when I was adding the DB_* commands. Do they belong in the Server or in the Db?

I just want to get a 2nd opinion on this.

I see a lot of inconsistency when it comes to DB_* commands. Some need a database name, some don't. Of course I tried to unify this and exported all of them through the Db class.

Noe about DATACLUSTER and DATASEGMENT ones. Are they server commands or are they database commands? Or, are data segments and clusters per database or per server? I do not understand orient that good so far, so that's why I'm asking.

Thanks!
For little things like this, would you prefer to receive a line note?
I think tinyMCE.settings will affect other tinyMCE fields created afterthat
Unless you have any particular reasons for keeping them, other than for posterity or future API considerations, could you remove the cpp, python2 and 3 folders, since they aren't relevant to this project?
Are you talking about the ceph_mdsc_put_request() call?  Why would you
need to hold a lock for that?  It is just the request that would be released,
and it has already been disassociated from the ceph inode's unsafe list.

And I believe it's the inode mutex that would protect concurrent calls,
blocking the second while the first does its processing.
should call kill() instead or rows.kill().
Sorry about the paste in the code. I couldn't get rid of it directly so I just committed.
Yeah I realized this later. Didn't mean to sound like an ass.
I think these routes should probably be `/user/:display_name/diary/comments` which then means you can look at comments left by any user, not just the logged in user. It also leaves open the option of using `/diary/comments` for a general feed of comments.

That will obviously mean some changes to the controller to pickup the right user from the parameters, and probably also the addition of a link to the user page to allow people to view comments left by that user.
Haklsnz hocam. Yorum yazsak iyi olurmu. Bu ksmda binary search
yaplarak, distance a gre servisler sralanyor.

On Wed, Jan 18, 2012 at 7:20 PM, uskudarli <
reply@reply.github.com
> wrote:

> Source code should have some comments.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/SWE574-2011F-Group1/Project-0/commit/a62619761d84c1c94ee0663e053c0a90aea70076#commitcomment-878872
>
I hear some rumor, cyanogenmod ics rom is supporting for qualcomm hdmi, may be is more easy to get works, and workaround edit boardconfig file.
I'm watching the VT football game tonight but I'll take a look at it in the
morning. I should be able to upgrade or add new Regex's to support those
forms. Do you think those are the only forms we need to cover?

On Mon, Jan 2, 2012 at 10:13 PM, Sean Durham <
reply@reply.github.com
> wrote:

> Thanks for taking the time to do this.
>
> I noticed three problems and have one question.
> Let's talk about them before I accept the pull.
>
>  1) Functions declared outside of an object hash aren't picked up.
>      I expect 'greet' to show up in the navigator.
>
>    greet = (name) ->
>      console.log("Hello, #{name}")
>
>  2) Functions declared without parens aren't picked up.
>      I expect 'meow' to show up in the navigator.
>
>    class Cat
>      meow: ->
>        console.log 'mew'
>
>  3) Namespaced classes show the wrong class name in the navigator.
>      I expect "ApplicationView" rather than "sd" to show up in the
> navigator.
>
>    class sd.Views.ApplicationView
>      render: ->
>        # ... do rendering things
>
>   4) Question: What is the blocks tag doing?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/lmaccherone/CoffeeScript.mode/commit/19bf062572dd52bf5b72fea00324cd15a6942a3a#commitcomment-832666
>
@tbranyen, this was the other solution I had found. So either the selector could be a[href] or you could check for "undefined"... Thanks! :)
If you want active_scaffold_colors processed with sass you have to use @import active_scaffold instead of require line
I added that hacky line to avoid forcing to use sass. If you aren't using sass in your app, import active_scaffold_colors tries to load active_scaffold_colors.scss and a exception is raised. But I don't get any error about active_scaffold_colors in rails 3.2
Anyway, as it's causing so many issues I will force to use sass and removing that hacky line.

I missed link_color line, thanks

PS. I can't found AS_default.css.scss~ or other files ending in ~
it has English and Thai terms defined so I figured it shouldn't.

On Tue, Feb 14, 2012 at 9:13 AM, Rintze M. Zelle
<reply@reply.github.com>
wrote:
> Should this style have a default-locale?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/citation-style-language/styles/commit/64ff7f4fced83bea38640ec3d826bcc5e99480d9#commitcomment-965152



-- 
------
Sebastian Karcher
Ph.D. Candidate
Department of Political Science
Northwestern University
`self.view.allowed_methods` doesn't work with a standard Django view (that's why I had made it a simple function in `utils`)
Small formatting error here on line 37.
Looks good.  I assume that the main point here is that flash and images are inserted with the same toolbar button.
var j, i = 300000;
	while(i--) { j = i*3 };
	Log('while(i--) { j = i*3 };')
	i = 300000;
	while((i -= 3) >= 0) {};
	Log('while((i -= 3) >= 0) {};')

result:
while(i--) { j = i*3 };: 14ms
while((i -= 3) >= 0) {};: 4ms

Зачот, хулъ.
Agree re. doing escaping as late as possible, `esc_url` should be moved into the input value attribute.

I do think text_url would be useful though, as the url is sanitized (`http://` is prepended) and the input has `class="code"` which is inline with the WordPress style for inputs that accept a url.
"has used with great success in to" ?
What are valid values for the parameters?
also here I’d just remove the cause, since it was never used
On 2012/06/07 10:59 AM, patriknw wrote:
>> +   * Construct a SSLHandler which can be inserted into a Netty server/client pipeline
>> +   */
>> +  def apply(settings: NettySettings, log: LoggingAdapter, isClient: Boolean): SslHandler = {
>> +    if (isClient) initialiseClientSSL(settings, log)
>> +    else initialiseServerSSL(settings, log)
>> +  }
>> +
>> +  private def initialiseCustomSecureRandom(settings: NettySettings, log: LoggingAdapter): SecureRandom = {
>> +    /**
>> +     * According to this bug report: http://bugs.sun.com/view_bug.do;jsessionid=ff625daf459fdffffffffcd54f1c775299e0?bug_id=6202721
>> +     * Using /dev/./urandom is only necessary when using SHA1PRNG on Linux
>> +     * <quote>Use 'new SecureRandom()' instead of 'SecureRandom.getInstance("SHA1PRNG")'</quote> to avoid having problems
>> +     */
>> +    settings.SSLRandomSource match {
>> +      case Some(path) ⇒ System.setProperty("java.security.egd", path)
>> +      case None       ⇒
> great that you have fixed ways around the SHA1PRNG issue, just to make sure I understand, what is the default if user doesn't configure anything? if default will still use the broken SHA1PRNG I think we should log warning (on Linux)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/akka/akka/pull/476/files#r942223
No, the default is what I had it as previously. It uses the internal
Java SecureRandom algorithm, not SHA1PRNG as the quote states.
Are these intended to be public?
DRY suggests we need something for them.  Renames may be a good idea, but the only other option is to actually repeat this code each time it occurs.
same, this is not a widget, need to be rephrased.
why not GradientTable as originally discussed?
Hi Satra,

> @alexis-roche: how deep can the multi-resolution go? two levels or more?

As many as you want.

Cheers,

Alexis
I think we could use id given this is always resource id. I'd be happy for this to be in a separate patch though -- we can stick with this for this pull request then open a new ticket for this renaming if we want to do it (I'm easy either way - I like pure "id" but it is a change)
The descriptions here should be wrapped in the gettext "_()" function.
Why remove the epydocs?
It's not clear to me why you added this.
You could also write a testcase for your pre-calculated pool option, and then define a tests/test_pool.py, and refer to it in your docstrings
Might make sense to mention the constraint about how much data boto can get out of EMR about your past usage.

Might also make sense to mention that reserved instances are purchased on a yearly basis a little earlier, so that it makes sense why we need to extrapolate predictions.
Thanks for the links, I agree with what you did, looks good to me!
I'd choose an `Ext.Panel` with `layout: 'fit'` instead.
A po co w ogóle ten else i postawianie łańcucha znaków 'false' pod $serverTime?
private Schedule getSchedule(String tableFullName) {
  Schedule schdl = (indexConfigurations.get(tableFullName);
  return schdl == null ? new Schedule() : schdl;
}
During review/testing I found that gestures are currently not rendering in IE10. Is there something more that needs to be done to support MSGestures?
Good call, although I didn't write these! :P I'll work that out.
Yep – if you open the inspector on the right side while a header is selected, you should see checkboxes for each target, as well as a drop-down indicating whether the header is public or private. Make sure the checkbox is checked, and select "Public" for anything that should be accessible to users.
This style matches our [coding guidelines](https://github.com/github/objective-c-conventions#control-structures).  If you don't agree with the style feel free to start a discussion on that repository.  But be prepared to argue the case :smile:
This shouldn't be in this pull request.
I left them as ivars because transformers were a recent addition, but I do prefer properties, so that'll be in the next commit!
Thanks.I fixed it and force updated the commit. Please review it again.
Neměly by ty errory být v nějakém divu s .row? Budou ty errory stejně široké jako obsah stránky? Pokud jo, tak to klidně můžeme nechat takhle.
да, отлажено. просто я видел кучу таких комментариев в коде, который в qreal/master
последнюю запятую на следующую строчку
Hey anj, you can update this pull request pushing new commits to your branch.
I thought it might be more clear to do one thing at a time, but this doesn't really matter.
I'm never quite sure if this kind of thing counts as 'cosmetic' or not. Generally we just try to fix whitespace in the part of the code you're actually changing. I'm not sure what the Official Policy is about this weird middle case.
one-liner is clearer
It would be nice to hit higher generality but as long as these are private classes I don't think we should worry about it overmuch.
The mystery method comes from the extmethods phase itself. It seems not to be using the return type of the overriden method correctly.

```scala
package <empty> {
  abstract trait T extends scala.Any {
    def x: Any
  };
  final class StringOps extends scala.AnyVal with T {
    <paramaccessor> private[this] val repr0: String = _;
    <stable> <accessor> <paramaccessor> def repr0: String = StringOps.this.repr0;
    def <init>(repr0: String): StringOps = {
      StringOps.super.<init>();
      ()
    };
    def x: Unit = StringOps.extension$x(StringOps.this);
    override <synthetic> def hashCode(): Int = StringOps.extension#Code(StringOps.this)();
    override <synthetic> def equals(x$1: Any): Boolean = StringOps.extension=uals(StringOps.this)(x$1)
  };
  <synthetic> object StringOps extends AnyRef {
    def <init>(): StringOps.type = {
      StringOps.super.<init>();
      ()
    };
    final def extension$x($this: StringOps): Unit = ();
    final <synthetic> def extension#Code($this: StringOps)(): Int = $this.repr0.hashCode();
    final <synthetic> def extension=uals($this: StringOps)(x$1: Any): Boolean = x$1.isInstanceOf[StringOps].&&({
      <synthetic> val StringOps$1: StringOps = x$1.asInstanceOf[StringOps];
      $this.repr0.==(StringOps$1.repr0)
    })
  }
}
```
I don't know about `seedvalue`. I haven't analyzed its usages and made it protected just in case. I can revert this change.
What's definitely dangerous and broken is public `addEntry` & `removeEntry` methods.
Please do not add whitespace such as this to the tests.
ret is a AxesImage object, it returns extactly the same as plt.imshow() [the ret syntax is the same as well as the insides of pyplot.imshow()]
Do we want to talk about IDL in the doc string? Surely the place for that is in guides and the like?
I think that ```Basic.__eq__``` checks for equality of args. If your class is standard sympy style this should be sufficient.
@hazelnusse Do you know what the conventions are on using unicode in python docstrings? We could opt for using unicode superscripts, subscripts, etc. Then we can write readable text based simple math equations.
I have made sure a blank line is at the end of file.  

I have also changed the name of the test to test_dual and references to the method to dual instead of dual_matrix. I have also defined a new matrix Fd and then use it in the assert line just after. This way the original too-long line is fixed and the assert statement line is shorter and thus more easily read.
I think so.  I'll check.  Putting the modules in here makes them be imported with `from sympy.unity import *`, which doesn't make much sense (`import *` should import functions and classes, not modules).
@mrocklin, I am sorry, I have never noticed this comment. This function is not a permanent solution in any way. All the constant simplification routines should simply be rewritten because with or without this pull request they fail on symbols like `Conductance`. However this function permits isolating the problem to within the single equation solver.
sorry for that, i corrected the mistake
dateString'in değeri varsayılan değer olan 'GG/AA/YY' ise input alanının boş olması gerekiyor.
Sorry I dont got that. What should I do?
This should be "Not registered yet?".  Also, please wrap this with a `<span i18n:translate="">` to make it translatable.  The same goes for `It's free.` below.  All of these strings need to be wrapped separately for translation to work correctly.

You may want to run message extraction to see if you marked all strings correctly.  (There should be no HTML tags in the PO file.)
OK, but i'd prefer a number of some kind.
I'm not sure, but this url is also used if a user does not have enough credential for the asked ressource.
@staabm IMO, you should remove all notifications. Like in symfony, twig, silex ...
I'm hesitant to include this because I don't like virtualenvs in my working dir, so I won't use or maintain it.
max_size mismatch? It's set to `sizeof(struct kinfo_proc)` but `kvm_getproc2()` returns a `struct kinfo_proc2`.
I'd remove the prototype and move everything to the constructor:

    function Exception(code, msg, data) {
      this.code = code;
      ..
    }
Use the dot accessor: `errorCodes.missing`.
Is this dependency still required?
this should be "with the excception of regular expresion"
which commands? 

consider the possibility that people might start reading this document at the "considerations" header.
Bien sûr que les `textarea` sont responsives (fluide). C'est juste que tu as fixé la largeur explicitement dans ton css à la [ligne 167](https://github.com/ooda/website/blob/cdeeab272fdffeffad50c0b3d6d7f83c37dea961/website/static/css/web.css#L170). Utilise un pourcentage plutôt et tu auras l'effet désiré.
Honestly, would rather have two variables here: cookbook_order, and cookbook_order_uniq, or something along those lines. Splatting '.uniq' on the end of the block is easy to miss and it's an important semantic here.
I meant a code comment.
`$phpbb_root_path` is a string, not "mixed"
Could be more clearly said like:
"Style inheritance tree, in order from most specific style to top-most parent."
The file cache is a data cache. As such only data should be tested and thus this shouldn't be a `phpbb_database_test_case`.
I think it's a slight overkill to use that gravatarlib. I think it'll be best if the URL is built in a function. The size that is determined with the `s=` parameter is actually the biggest size value of the avatar, so either the width or the height.
You can review jquery code to see how they call the parameter, and use that name instead of options.

As to why do it this way, lists of positional parameters cannot be altered without breaking all client code ever written.

Your why I don't understand. If you want to scope the name locally, scope it locally.
Are we talking phpbb_controller_exception or phpbb_controller_not_found_exception (in other words, one exception that can be used for all of the RuntimeException uses in this file, or a new exception for each of them?)
I know we wanted to use dependency injection instead of globals, but I'm not sure what that would look like here.
This file is provided by Plupload.
There should certainly not be any casts in postgres as it ought to behave in a sensible manner at all times.
let's use the logging API here for this.
fixed in rebase.
I looked through redis-rb, and it has some built-in hiredis support, but it requires the user to explicitly require the hiredis connection driver.  It doesn't automatically use it just because the gem is installed.

Also, in general, I'm a huge fan of making libraries have as minimalistic set of dependencies as possible.  I want libraries to be as maximally flexible with whatever environment or project users are working in.

Rubygems doesn't have an optional dependency API in the gemspec.  There's basically three routes you can go:

* Add it as a normal dependency; that way it will be automatically installed for the user.  Provide a means at runtime for the user to configure your library to use the optional dependency.
* Don't add it as a dependency at all; at runtime, if the user configures your library to use the optional dependency, run a `require` statement, and if it's not available, it'll fail with a pretty clear error message.
* Make a separate extension gem that depends on your core gem plus the extra optional dependency. Instruct users to install that when they want to use your gem w/ the optional dependency.

I tend to favor the second approach.  The first approach is fine if the optional dependency is used by users the vast majority of the time.  That last works great as well but takes more effort on the part of the maintainer to maintain two separate gems.

BTW, my VCR gem has tons of optional dependencies (a good 10 or so, since it integrates with multiple HTTP clients, HTTP stubbing libraries and test frameworks) and I chose the 2nd approach.  I've never gotten any complaints from end users.
recommend for less redundancy: model.dispensemodel -> model.dispense
It's already apparent it's a model from the path filepath and includepath
Would be nice to keep it in for now.  Agree with long run view.
I'm not very familiar with the netCDF4 python module, but I don't think that a call to ```netCDF4.Dataset(filename)``` can return something that evaluates as False. I could easily be wrong about this, but I think it succeeds or raises an exception. Furthermore,  line 772 already uses the dataset object prior to this ```if``` statement. And one more thing, if dataset could be False and was, the ```CFReader``` instance would be useless and an exception should be raised, rather than just skipping these methods. To conclude, I'm not sure what this ```if``` adds so I'm removing it.
My third grade teacher always was proud...
不要用 === true的方式。直接if (d.data('click'))即可
return this.getLoc(name, 'city');
проглядел
What's the last "true" being appended here?
If this is the fraction of single vs. multi - then call it 'spratio'.  Based on the name, mpratio' I expected 1.0 to be 100% MP.
Use the compiled regular expression.
also add a failing POST form
== '_log_error' or in ('_log_error',)
please remove trailing whitespaces. Empty lines should be really empty
This variable should be named `booleanValueTransformer` (no initial uppercase). `URLValueTransformer` is capitalized simply because "URL" is an acronym.
Can we rely on this on all platforms? Wouldn't it be better to use a git option to specify the directory where the repo is?
It's just following the pattern from the target element.
It's late and I apologize if I've missed something, but I just read through that ticket and I don't see any evidence to support creating new API surface. Please point me in the right direction...
Since we are building the abstract layer, I am mentioning this. Local names like "oldClientMinMessages" does not seem to make sense for SQL, a case-insensitive language.
yes, it is a typo,done. thanks.
int32_t seems small here. I'll check.
module imports instead?
The sorting is to make sure the mount `foo` is added to the exported object before `foo.bar`, so that the second object is added as an attr to the first.
Updated this to be more correct and also tweaked the formatting so it's reST/Sphinx.
I had been using the `depends_on 'gperf'` for some reason it work as expected as well as `depends_on 'homebrew/dupes/gperf'`.  I did pull request to have `gperf` on core but per your suggestion I moved it to dupes.
next time I will, will this still be an issue?

On Thu, Aug 9, 2012 at 10:48 AM, Charlie Sharpsteen <
notifications@github.com> wrote:

> In Library/Formula/darkstat.rb:
>
> > @@ -0,0 +1,17 @@
> > +require 'formula'
> > +
> > +
> > +class Darkstat < Formula
> > +  homepage 'http://unix4lyfe.org/darkstat/'
> > +  url 'http://unix4lyfe.org/darkstat/darkstat-3.0.715.tar.bz2'
> > +  sha1 'e635f7ae0c6dfe3a7d1fac3855ca733187163973'
> > +
> > +  def install
> > +    system "./configure", "--disable-debug", "--prefix=#{prefix}"
> > +    system "make install"
> > +  end
> > +
> > +  def test
> > +    system "sudo #{sbin}/darkstat -i en0 -p 8000"
>
> Root permissions are not necessary to bind to ports over 1024.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mxcl/homebrew/pull/13557/files#r1343640>.
>
>
Don't download stuff into `/tmp`; use

```rb
mktemp do
  # test code
end
```

which will clean up the temp directory afterwards.
Looks like there are still a few parts of the template left over here. Does this require ENV.x11?
Same comment about exit code.
Asserts in code that make extra rest calls concern me a bit more.  Unit tests in the broker and the cli rest code should cover the  second assert.  The first assert is an error condition that the server has unit tests around.  I don't hate asserts, but it's not really ruby style (extensive tests are supposed to cover that) and it increases size of code that has to be tested/ validated
We should be using our new logging funcitons.
Writing this in terms of "the user" seems a bit odd. Maybe just keep it to the actions that the object can take.

"An object that extends from Savable indicates that it can be saved and unsaved in the context of a logged in user."
Fair enough. Will change. Also, I just realized that this method doesn't get rid of the attribute lock, and should. Will fix both.
The word 'offensive' is pretty strong.  Someone who finds 'simply' offensive is pretty darned sensitive.  It is, however, an opinion, and I'll remove it from the text.
What happens if m_position = 0 and you do a read? Won't you get a underflow?
I tried disabling it and I didn't see any difference. The video is still not showing up, but at least it is being loaded. I'm not sure if we can fix the actual video, but this might fix embedding of objects on other pages.
stop instead of ttop
can you try ```empty?``` if it does not work ... oh well BLANK
typo: bock
Since the File API is pretty ugly, maybe we should mention ``utils/FileUtils`` early. The util methods avoid this callback hell. :)
@GarthDB 's original prototype didn't have this, but I felt that the spinner looked off-center without it.
It feels really weird to have the Menu & MenuItem constructor be up at the top of the file but have their prototype methods assigned down here, with a bunch of other code in between.  It looks like this code only depends on a handful of utility methods like _getHTMLMenuItem().  Could we move just the simple utils up to the top of the file, then have the Menu/MenuItem full declarations (constructor & methods contiguous), followed by the standalone public functions after that?
Yikes, very good point!  Looks like there might even conceivably be edge cases where this could cause bugs in status bar updating.  Will fix.
oh...JSLint. I hate these sequencing issues. If it's not ugly, try it out. Don't spend a ton of time on it though.
JSLint nit: need a space after the parens.
My fix for that bug you found is a little different: doing this in the isSidebarClosed case of _setWidth() rather than just the else will fix it without needing to modify toggleSidebar() (since it calls _setWidth()).
One other data point: TextEdit (a slightly older, but once-popular Win editor) uses Save ALL = Ctrl+Shift+S; Save AS = F12
@nightwing Yes, sounds good to me, it seems out of place here, can you look into that?
Can you get rid of this top level declaration of variables? This is a C (pre C99) thing, and is rather difficult to read.
:-) my first thought was come out with the regulare expression, it seems better than regex here.
There's really a documentation problem, in my opinion...
Perform the `free` before calling `rugged_exception_check` so the ODB doesn't leak if we raise an exception.
Please move each variable definition into a separate line.
If you're not pushing/popping/referencing `__googleFonts`, there's no point in initializing as an array first, right? How about just declaring `__googleFonts` and then performing simple checks for it when it's used (here, and https://github.com/mozilla/butter/pull/757/files#L1R320)?
Not sure this declaration is needed at all. tabzilla has its own css, right? Do we conflict with it without this?
You missed this one, unless there is a reason you are keeping this one here.
Absolutely. Fix pushed for all comments up to this point.
Oups !
j'avais mis cela pour vérifier que ça (semble) marcher vu l'absence de tests unitaire.
Je supprime, commit et push !
Carrier return above the `_merge` call.
rewrite和prefix的处理好像也有一部分重复代码，能合并吗？
Remove this block and put the Apache header in the file
Could be a `Redis::Namespace` amongst other things. Should probably trust that the user can pass something in that conforms to the redis-rb API..
Still need to work this out. Could you revert this line and file a new issue for the error you get when you `load("bigint.jl")` (or `dlopen("libgmp_wrapper")`) from the REPL?
Right :-) Wrong place, fixed. The thing is - we already require db_printenv that requires those, but theoretically printev could be run a minute ago and puppet could (I believe) restart tomcat for example in between. Just for case. I want to be sure. Thanks.
@jlsherrill , Sure will update.
else if now handles this
Please change the name of this method.
hack for what?
nit: no need for false, this is the default argument
Made a separate issue for the inheritance diagram rendering:  https://github.com/astropy/astropy/issues/490
Might as well use a decorator for this?  Also what about _set_format?  Or did you decide that it shouldn't be settable?
There should be a one-sentence summary of the class at the top of the docstring (important for the summary tables).
Adding this `case` was not necessary. The `try` statement behaves like a `case` here:

```
try riak_core_vnode_master:command_return_vnode(...) of
    {ok, VnodePid} ->
        ...success block...;
    {error, timeout} ->
        {error, {vnode_proxy_timeout, {Index, Node}}}
catch exit:... ->
    ...catch block...
end
```
What's with the leading colon? This syntax is foreign to me.
You could use assertSame and assertNotSame to more simply test that they are different instances. That would remove the need to modify any properties to break `==`.
This is quite the conditional stack.  Is there anyway you could reduce the complexity here?
Couldn't this be done only once?
our convention has been to just put in the actual integer timestamps in test results, but I'd probably be okay with this... if it were using api.parse_ts
This forces the use of at least one argument. I believe this is a good, since otherwise, an errant automated process might manage to invoke Image(None)
Does log.warn write to the terminal that wrote the process and print to the actual frontend ?
But you can't check values with List and Unicode.  I'd use Constant if there is such trait.  But Constant is a special version of Enum, so I thought Enum is fine.  But I think using List and Unicode is fine.  The test will be weaker, though.
could use singleton enum strategy
it would be more clear to base64 the claims you are referring to
Personally, I think that for computationally-expensive input checks, it is fine to ignore this recommendation, which is targeted at simple contractual violations such as null pointers.
You have a type here in `$scolumns`. Also, Laravel always has braces on a new line.
makeDisposition is from Symfony HttpFoundation component. It quite pointless to change every method in a vendor library.
Same here: In case, value was given as NULL, this if leaves `esc_value` uninitialized, though it is used in `config_write` and `git__free` below
I'd probably prefer the `ResourceManager` to run this timer by itself, though it doesn't really matter.
I thought parenthesis were required for string concatenation in this style, but apparently not?
I think we should use reverse here for building these urls. It would be the django reverse instead of our locale url reverse. So something like:

```
from django.core.urlresolvers import reverse

reverse('users.login')
```
Indentation is weird here. You can just do 4 spaces in from the line above. Also, you can kill the trailing comma and put the parens on this line. I think that is closer to what we normally do.
I can remove 2-4 here. It just makes it slightly backwards compatible with an old installation, but in our case those old passwords will be disabled by now.
Since we're getting better and better with pep8. Just FYI, the latest version of pep8 says that indentation like this should match the block indentation which is 4 spaces.
This could be moved to the previous line
This code looks very similar to def complete_evaluation, and is not very DRY. 

I had hoped that this implementation would improve the code readability of the existing code base, not make it harder to maintain. 

The original code successful did edit / update, right? So then the main change would be just calling it more often. I see that the control flow is different. Was there a bug with the original control flow? 

Or maybe I understand this better, your new code is just updating for one text box? 

My long term goal for peer evaluation is to refactor it into the model, however, that doesn't need to be done today.
CS: space after `@`.
Please, add a docblock for this method.
could this test be nested in the following if ? (to have only 1 test in the working case)
Does it trigger autoloading? If so it would make HttpFoundation a required dependency. But the condition can be switched, so it isn't.
- couldn't this be used to erase a collection (not protected) ?
- what if children are added dynamically ?
the requirement is PHP 5.3.2 so this comment must be removed
After looking at it a second my suspicion is that whoever wrote the PrivateMessenger class was trying to make it work like the UserMailer. This actually makes a lot of sense because if the public facing api is the same we can inject whichever is appropriate. Somewhere along the way the params on the instance methods in the PrivateMessenger got refactored into the constructor and the two classes no longer shared a public interface. At that point the method chaining in this class really didn't serve any purpose any longer. As I move forward with the email refactor it might make sense to move back to the original architecture, but for now we should be able to combine the setup and delivery steps and tap won't be necessary.
This seemed like too minor a change and didn't lead to more readable tests in my opinion, so I skipped it. If i'm going to be road blocked until I change it I'll make the change.
Agree. Patching.
These methods look the same. How about one private method like:

```ruby
def message_body(name)
  ERB.new(File.read("#{PRIVATE_MESSAGES_PATH}/#{name}.erb")).result.binding
end
```
beshe ke dige azin irada azat nagir ali !!
只多了一个点，是故意为之的么？
Two booleans in parameters almost always look bad because it's difficult to read such code. It's better to provide static constructors like ReplaceCallFix.toDotCall(), ReplaceCallFix.toQuestionMarkCall(), ReplaceCallFix.toExclamationCall(). Another alternative is to create and pass as parameter some enumeration.
ReplaceCallFix is used for replacing !!. now. I will rename UnnecessaryNonNullAssertionFix to PostfixNonNullAssertionFix and will implement removing of a!! postfix operation. Additionally I will try to implement introducing of !! postfix operation.
The main reason is just numerical accuracy. When one of the level weights is really tiny, it can throw off the balance such that the product of everything doesn't add up to 1 anymore (causing channels that were solid 1 to become different that 1).
I *think* this filtering is OK, but I wonder if 2-point lines are a symptom of a deeper problem.... or not. Hmm...
What's that? It sounds like a useful thing... maybe a method on this class?
Because I was lazy, and when I deleted GetRandomConfs.py I didn't readjust them.
Formatting, tabs!
Wouldn't `crashReporter:didCatchException:` be a more standard name for the delegate method? Most delegate methods start with the sender, like `tableView:didClickTableColumn:`.
This doesn't look right. The add handlers are supposed to work on the "model" rather than the "operation". The current version of this *KeyGeneratorAdd itself looks incorrect (like line 55) since it's working on the operation. It's probably OK to do this but I'm not 100% sure that it's not going to introduce any issues. I'll ask Brian or Kabir for their input.
Only because you use focusable together with disabling, right? If there's something accidentally removing the class, it should be reported there.
"eachother" -> "each other", "will detected and removed" -> "will detect and remove"
Oops, I missed that. I changed this revision.
I checked the type of contact.name and it return object, not string.
`]{` -> `] {`
In which cases the element is not display: none? (could be some part of the css I don't see here)
I think andreas is taking a hard-line about uses of __proto__, even though I think this is pretty harmless.  You have a getter, so it's probably somewhat annoying to change, but I have discharged my duty in warning you about it.
(for what it worth this can be discussed on the mailing list if you want and there is no need to do that in this pull request)
There is a lot of comments in this block that can be removed
nit: herf -> href
There is no good reason for not doing it. I have wondered that myself too.
Sorry, I don't get it. Why not?
It is there. But I would prefer to land the current code now and later fix the code with loc issue. WDYT?

https://github.com/mozilla-b2g/gaia/issues/3108
I'm not using id in next commit, just value. And the reason to use the DB id in here is to make it easier the deletion process. In next commit I'll try to modify also this value when we change a message from 'pending' to 'sent'
That would be semantically incorrect: http://peter.sh/2010/06/thoughts-on-the-html5-hidden-attribute/

I intend to replace the `display` rule by a CSS class anyway, in order to be able to apply transitions.
this is elasticutils, will look
I assume you need to do this because accessing a regular resource path with primary key wasn't working?
IMO the existing and the new code are not correct.
for some reason a ```'``` is replaced by ```'\''``` and a ```"``` is replaced by ```"\""```

It should probably look more like:
```ruby
str.gsub("'", "\\\\'").gsub('"', '\\\\"')
```
Doesn't everything else use UtcNow?
コマンドラインツール → `run` コマンドラインツール
of course this was just a test, if you bastards look at it at all! :wink:
thanks, this actually revealed a small bug in my code ;-)
`.*` is a bit overkill no ? We might want to use something more strict instead as * is greedy.
In GitHub's API, when you request tickets from a repository, it returns a list of dictionaries that hold the information for each individual ticket, but if there was an error in the request (such as "Bad authentication" or similar), GitHub instead returns a dictionary with a key "message" that holds the error message. Since the only time GitHub ever returns a dictionary instead of a list indicates that there was an error in the request, I thought checking the type of the returned object to see if it was a dictionary would be a decent method for checking if GitHub had an error in obtaining the tickets requested.

`if not r_op.json:` would not work because `r_op.json` would still contain something (the error message) if GitHub had an error in obtaining the tickets.

There might be a better way to do this, but checking the types was just the first solution I came up with.
Thanks, fixed, I'll push it when I finish unittests.
Yeah, need to update codes logical. thanks.
I'm not sure I understand the change to these three lines.  Mostly, I don't understand what they were doing in the first place...
``repository`` here got separated from its index entry, and `workdir` has no index entry..
Now we don't use macro to control lua related codes. Is it only used here?
Pretty long, hard to read line :wink:
you should `import os.path` and use `os.path.join` to remain os-independent and keep Windows users happy :)
Do not feel ashamed, just write a test case covering this scenario. :-)
(ditto here)
Are you sure it should be written to ```subdomains/www/php```? I never saw any html files written there. Should we just remove this script from source control, and you can keep a copy of it in case you need it later?
Perhaps this should be ```ssl->ssl_head == to_find``` to match the comparisons below?
into -> in a
Do you happen to receive event with another window?
If yes a comment would be helpfull.
I could remove that return undefined, eh?
@lloyd complete_reverify is never used since the add email and reverify email got collapsed into "confirm".  The confirm page calls /wsapi/complete_email_addition.
I thought I saw discussion that this field should be called "disabled: true". Now, I prefer staying away from double negatives and doing what this code does, I just want to make sure we're in agreement on what that should be.
It worked before with `self.source = source`. 

Perhaps we should do:
```python
if not isinstance(source, collections.Mapping):
    source = DotDict(source)
self.source = source
```
Should create_key have its own test? If any of the above asserts, which are for content on the profile page, fail, it won't get tested.
This looks like a 1:1 copy from the source. Please make sure to format the code accordingly to our styles. Also please separate out `getAddonsByTypes` so it can be read and understood easier.
triple-operator please and spaces around it.
removing entirely - this logging approach feels dirty
Replaced previous regex with a better one, and used a capture to preserve whitespace in 5f607bb.
No, I think you convinced me.  It seemed like a pluralized name for a "multiple value" slot was reasonable, but those are good examples to compare it to.
should just do this as an object literal:

```js
keymap = { up: 38, … }
```
I'd prefer this change not be in a pull request to my master branch
Ok understood, i fix that in the day.
I don't know if the newline is part of the line or whether it amounts to the writer (BC in this case) at the semantic level. This requires doing the same work (add newline) in the writers who will use the SimpleFormatter.
Noted for changing on my side.
As EdGruberman said, you can make this a 1-line change by adding it to the if-statement (`if (ignoreBedDistance && ((...) || (..) ...))`).
I think it probably makes sense to not execute typeOf() twice, is there? It's the hot path that both get executed.
-> ember.js + require.js • TodoMVC
Why did this guy need to change? I'd rather keep things non-user-specific
Persisters are currently unable to be extended anyway. It cannot be classified as a BC break. =)
ok, removing them from now on.