labofsahil/github-event-dataset-2012 huggingface dataset:
Also, I vaguely remember a pull request before where the person said we should switch to pip, but I balked because I'm pretty sure we have a bunch of stuff that doesn't work with pip.

Have these changes been tested with all the parts of kitsune? I'm pretty sure at least the sphinx stuff is hard coded to use /usr/bin/python26.
`is_default` should only be true for one and we want it to be win7
Nit: this comment should describe *removing* a folder.
I notice this has lost the `abbr` tag. This might be ok, but I thought I'd ask. Since hovering the label shows the tooltip now (right?) I'd imagine this is fine.
This is marketplace CSS... is that needed to fix AMO?
I guess this is alright, but in the future, it'd be better (and presumably easier) to have a second test that does the setup and teardown so each type of submission is tested individually.

Add a docstring to this test explaining that you're testing both branches and you've got my r+.
Oops.. sorry.. that was debugging :-1: -1:
the property is already part of the parent class
This needs changed levers on the ground need to be able to be triggered
вони є тільки в PageBundle. встав тут пустий блок metatags. перевизнач лейаут для StfalconPageBundle в app/Resources і виведи в ньому ці метатеги.
The code deleted here is the copy-paste of the code just before
You're right... i keep it in mind for a future cleanup.
use a ``/`` in the path, to be consistent with all other places in Symfony. As of PHP 5.3, ``/`` works in paths on windows too.
you should use ``!empty`` instead of ``count``. We don't bother about the number of elements here but only about the fact it is not empty
This is not the right way to ensure that ``log.context.type`` is defined. You should use ``log.context.type|default(log.priorityName)`` instead
looks like it pops on failed validation
How about calling the user() only once?
I copied the pattern of the others that were NSString.  Maybe they all should be changed.
you'll have to do a `set -e` at some point to make the script fail when something fails and thus get captured by this `trap`. You'll have to check to make none of the commands in this script will return a non-zero response because otherwise it will just think everything failed. If there is something that might return a non-zero but is okay to continue on, just to a `set +e` before the command and `set -e` again after you're done.

Some more on `set -e` in here: http://www.davidpashley.com/articles/writing-robust-shell-scripts.html
Just for the record (as I already said to you on IM) I have some reservations about baking histogram_draw and histogram_text into the behaviour of action_histogram.  We'll need to discuss this on the mailing list I suspect since it involves deciding on some basic oiiotool API stuff.
Das ist das originale Template aus dem FOSUserBundle mit dem Unterschied, dass das {% extends %} fehlt. Denn wir wollen ja keine komplette Seite inklusive <head> etc. rendern, sondern nur eine Form.
This should be private static (reuse the same instance vs create a new one for each get)
When I finish refactoring the work_restart code, it will allow longpolls to interrupt without waiting for the 0.1 second timeout, and in fact without any timeout except the "scan done" one (ie, we can set the timeout to 11 seconds).
@jmikola You are right, i missed that.
you can just go `require('../..')`
"listing" is misspelled.
call to 'cleanup' now on its own line
ah sorry missed this, one var per line.
That also means L236 can be removed.
white space below all `blank;`
Sounds fine to me, please fill an item in bugzilla for such feature.
EDIT: forget it, I just saw the media_storage.js file. Nevermind.
Cool idea. 
One thing I wonder is contextmenu and activitymenu are both derived from listmenu module, so this may look strange if the same menu UI show twice.
I will fix the indentation
Yeah. Could do that. Doesn't matter to me. For some reason I had the impression that this would be easier for the translators to deal with. I could be wrong.
Do not need this for loop (don't need to set explcit durn in children)
The method takes a repositoryName param, and here you come up with a repoName. That feels wrong. Why does it need to be passed in at all if it's inferred from the URL?
I'm not sure you always want to expose the actual error here. Information disclosure and all.
Good call - leftovers from early hacking.
I just fucking hate abbreviations :rage3:
So this is a bit funky, because there's already a pre-existing behavior in the goggles (around line 95) where we call `persistence.loadHistoryFromDOM()` in an attempt to find serialized undo history in the DOM and restore it. This is useful for when the user has either turned off the goggles on a page and wants to turn them back on again, or when the user activates the goggles on a published hack (in which case we're letting them go "back in time" through the hack author's edits).

So, given that context, the call to `commandManager.canUndo()` here is basically checking to see if any history was deserialized. A less obfuscated way of doing this might be to change `persistence.loadHistoryFromDOM()` to return a boolean indicating whether any history was restored, and then change line 95 to be:

    var wasHistoryRestored = persistence.loadHistoryFromDOM();

and then change line 101 to be:

    if (!wasHistoryRestored)
I like this. What about adding an additional function to go from ```toBytes: (U) => Array[Byte]``` and not make this private.

In hyperLogLog/approxUniques, you have: 
```scala
toBytes = { (in: CTuples) => in.toString.getBytes("UTF-8") }
```
Move `pnames` down to where you actually use it.
We should always avoid breaking sentences like this and instead use string that contains variable:

    COM_KUNENA_A_CATEGORY_CREATE_TITLE="Create New Category"
    COM_KUNENA_A_CATEGORY_EDIT_TITLE="Edit Category %s"

Usage:
    echo JText::sprintf('COM_KUNENA_A_CATEGORY_EDIT_TITLE', $this->escape ( $this->category->name ));

I really want to get all those fixed and this just creates more work for me.
The io statements should be updated to use the new logging macros.
I assume the `_v2` is going away before this gets merged?
Still a potentially-confusing comment here..
I guess that make sense although it might limit what you can add in the future.
Source says you smelled this right, will change that.
``rm -rf`` does not work on windows
Sure, there will be one the moment we have a 2.10 final ;-)
This will cause array filtering to happen on each and every field retrieval. Why do you have to filter again on every owls request?
See my question above. Can this somehow be derived from the pinning or ist this something the user must manually set ?
Isn't it better to do this kind of things in setup/teardown?
see previously with percpu(per_core_llbooter)
I'm trying to reconcile this code with the `spds[i].ncaps = MAX_STATIC_CAP;` line above in `spd_init_all`.  This line here makes sense to me, whereas the previous does not.  Is this an inconsistency in the code, or am I missing something?
why 120?
why 2 labels?
The best part is how the grammar is now worse than when it was slang.
I see. Still, `getUpdates` could be used for this purpose. I guess that would be a separate RFE.
That was like a beginner's mistake ... A new commit should solve this.
You could do:

```C
ssl->ssl_tail = to_insert;
```
at this point instead of in each block.
Aren't the models provided by *Backbone* and the views provided by Bootstrap?
also some more cases below.
Shouldn't we request a removal function in platform to avoid that?
Or force a GC on window destroy?
`addWeakPrivacyTransitionObserver` using weak ref without offering removal method seems to have been made on purpose.
I guess `b.length - a.length` would be a correct way to do this.
We should probably match NodeJS here.
So there is only three occasions where `model` or  `pbService` is being touched:

1. https://github.com/mozilla/addon-sdk/pull/517/files#L4R31 no real use here and `pbService` is accessed anyway. Also if such notification is dispatched I would expect `pbService` to exist.
2. https://github.com/mozilla/addon-sdk/pull/517/files#L4R53 No issues here as `pbService` is checked for existence.
3. https://github.com/mozilla/addon-sdk/pull/517/files#L4R67 Here model is used but `pbService ? pbService.privateBrowsingEnabled : false` could be used instead.

With that I still believe getting rid of `model` will simplify code and it's worth it.
I would also prefer to introduce variable to store a global state in a future we will need it.
while I don't like have `else` on a new line, this commit breaks the style of all the rest of the `else if` clauses. It should also have a space between `if` and `(path`.

```js
}
else if (path ...
```
How is caching implemented on ```provisioning_api.js``` and ```authentication_api.js```?  Are these etag only?  If there are updates, will changes be propagated out to users?
same here, `getParentSchema()`
Stylistically, those can collapse to:
<pre>
scope = mock 'scope', :nil? => true, :known_resource_types => nil
# ...or stub 'scope' if you don't care about them being called
</pre>
I think this refers to the gem-prelude hacks, maybe deal with those in a
separate step and get this merged first :)

On Mon, Nov 12, 2012 at 8:46 AM, Luis Lavena <notifications@github.com>wrote:

> In lib/rubygems/core_ext/kernel_gem.rb:
>
> > @@ -0,0 +1,53 @@
> > +module Kernel
> > +
> > +  # REFACTOR: This should be pulled out into some kind of hacks file.
> > +  remove_method :gem if 'method' == defined? gem # from gem_prelude.rb on 1.9
>
> Perhaps can we remove this REFACTOR legend now that the modification is
> in a separate file? /cc @drbrain <https://github.com/drbrain> @evanphx<https://github.com/evanphx>
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rubygems/rubygems/pull/395/files#r2099331>.
>
>
This last set of changes to pasting looks good. Can you submit this as a separate fix (for #117)?
That part is a string for humans and don't for the Composer's internals
The FirePHP writer/formatter was created less than a month ago in 53723adf96954cd42125d429bfc60226119ae654, so I don't understand the comment about legacy behavior. If it was a general comment, are there really any plans to restructure writers and formatters between this release candidate and the 2.0 release (apart from this PR, which resulted from a post I made on the mailing list)?

> Do you have test some writers like Db and ZendMonitor with your BC?

Please read the PR message body. I mentioned that I had questions about both the DB and ZendMonitor writers.
http://php.net/manual/datetime.gettimestamp.php
Then either fix the behaviour or the docs :)
Throughout the file:

- Remove any spaces between the function name and the opening paren
- Remove spaces after the opening paren of an argument list
- Remove spaces before the closing paren of an argument list
Where's the ending comment?
but if (isset(...) && ... != "" should work right ?
Ah, learned something new :)

Fixed.

Thanks, Dan

-----Original Message-----
From: Nate Abele [mailto:reply@reply.github.com] 
Sent: Friday, July 20, 2012 9:45 AM
To: Dan Fellars
Subject: Re: [lithium] modified curl to support options (#590)

> @@ -59,6 +60,9 @@ public function open(array $options = array()) {
>  		parent::open($options);
>  		$config = $this->_config;
>  
> +		if (!empty($config['options'])){

There should be a space between `)` and `{`. Looks good otherwise.

---
Reply to this email directly or view it on GitHub:
https://github.com/UnionOfRAD/lithium/pull/590/files#r1206445
use b.wiki.vg

On Sun, Oct 21, 2012 at 8:09 PM, greatman <notifications@github.com> wrote:

> In src/main/java/org/spout/vanilla/VanillaPlugin.java:
>
> > @@ -93,7 +93,8 @@
> >
> >  public class VanillaPlugin extends CommonPlugin {
> >  	private static final int LOADER_THREAD_COUNT = 16;
> > -	public static final int MINECRAFT_PROTOCOL_ID = 45;
> > +	public static final int MINECRAFT_PROTOCOL_ID = 46;
>
> Looks like http://www.wiki.vg/Pre-release_protocol is not updated then.
> Says 46 over there
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/VanillaDev/Vanilla/pull/335/files#r1899917>.
>
>
Any reason you can't do that now?
This is the default LICENSE file as distributed with all software under this license. You should -not- modify the license text. See this mirror of the original license text for a reference: http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt
The `as e` is not necessary, since you don't use it.
I'm not talking about the fact you do a check (which is fine) but about that you only pass ``gettype($document)`` as exception message, which does not tell the end user that the expected type was an object until he reads the source
I agree they can be handy, but the way it is done is imho wrong, so hence why I would like to remove it now and introduce it when/if services becomes decoupled from repository.
It would create war with name like as7-quickstart-wicket-ear-1.0.0.war, which is then used as JNDI indentifier, and would change with every version.
You've made a lot of changes to the root POM.xml that are uncessary. You simply need to add your new quickstart. Revert changes to the file.
TODO for myself:  `transforms` isn't the clearest name for this variable.  I'm going to change it to something like `vendorTransforms` after I merge this Pull Request.
I think it would make more sense to iterate only over `CanvasActor`s. I'm working on something that I will commit soon.
Even in Firefox, the difference between `==` and `===` is in the tens of millions vs. thousands of millions—and this line is only executed once (not a hot code path by any means). There are far more significant performance bottlenecks (function invocations, for instance) in `es5-shim` than equality operators.
Why?  Please explain, since this works manually, and this isn't a redirect test:

[10:50:15.814] GET http://www-dev.allizom.org/firefox/security [HTTP/1.1 301 Moved Permanently 127ms]
[10:50:15.950] GET http://www-dev.allizom.org/en-US/firefox/security/ [HTTP/1.1 200 OK 13997ms]
+1 for wrapping fields up. My impression from aakash is that he's going to want at most 4 or 5 different options. This isn't inteded to be a 1:1 mapping of fields to privacy bits.
Off by one (same as below)
no need to add the extra spaces before the comma, they are just there to get them to line up but since this one is so long, don't bother, it's not important to make them line up and the extra spaces don't do anything else.
What"s the rationale for having two separate helper modules, Utils and Stdlib?
Sorry, I forgot to reply to that.

gem() method is provided by Bundler.

You can check that from your console itself. Try `bundle exec irb`, then do `method(:gem).source_location`. That'll give you the location of the definition.

As per my bundler version, it's from - method(:gem).source_location

I also did a code search of rubygems/rubygems repo on Github to verify my facts <https://github.com/search?q=repo%3Arubygems%2Frubygems+kernel&repo=&langOverride=&start_value=1&type=Code&language=>

And it turned out that Rubygems doesn't provide a global gem() method.
Guess this isn't needed then since the event is passed through
Urgh, this is why you don't attempt to use auto-indentation. Fixed now.
〜JavaScriptにおいて、false、null、0、""、undefined、そしてNaNはfalse値を振る舞います。
will this detect escaped quotes properly ?
Just writing a comment on the line ...
See https://github.com/phpseclib/phpseclib/pull/5#discussion_r954298
We should only publish the data that is relevant. That way we don't need to do a split in the pubsub listeners
I don't think we need to create a new piece of content here. We can just cary on with the private one.
Does this stop us from being able to post a JSON body? Was there something wrong with using the `bodyParser` before this change was made?
Same thing about the canonical resource reference for this URL end point.

`request.del(...'/api/tenant/:port'...`
Memberships is probably a better word for this.
Moved to init.js.
It looks like there is some tension between using this approach and for (var in). We probably want to discuss this during tomorrow's stand-up. I don't like either of them, so would be happy to go with _.each
Boolean is inconsistent with the other types. It should probably be 'boolean'.
I tried it on large files, but the biggest gains came from removing quadratic behavior. It's hard to test this, since I don't know when is the indexer up to date, and when not.

However, it seems to me that I would never want to wait for the indexer when asking for completions. Note that in this case we'd be waiting for types that are *not* imported, but happen to be on the classpath.
i would say it's not mandatory but a nice to have ;-)
Nitpick : `supports()` fits better :smiley:
And you should check if the key `status` is set.
No, see https://github.com/Yelp/mrjob/blob/master/mrjob/job.py#L475
Ещё раз: вам говорят о том, что вы не проверяете x на возможные значения. Скажите, что будет, если я передам в метод число x=150?
@lilumi разве в этом методе я так говорил? Вроде как говорили о методе mutate, нет?
Ну вот допустим у нас 90 элементов в массиве ДНК. И нас просят заменить 65% 
Если посчитать в вещественных числах — получается 90*65/100 = 58,5, округлив — получаем что надо заменить 59 элементов
В вашем же случае — целочисельная арифметика даст 58.

Я просто сделал вот так:
NSUInteger needToMutate = lround(percent/100.0 * DNA_SIZE);
Да, действительно
В постановке задачи указано "6. Создайте категорию mutator класса Cell. ..." . Или я не о том?
```python
if (xy[0] in range(forest1[0][0], forest1[1][0]) and xy[1] in range(forest1[0][1],f orest1[1][1])):
    Fforest1(xy)
```
$query may be an empty string but you're not checking for it below.  Should make last pattern match required until we support some concept of dumping a previously made query.
@markhealy 
In your image, the URL you enter is surrounded by back-tick quotes (i.e. `http://localhost:8080/sharepoint/`). Is that correct? That doesn't seem right. Shouldn't the user enter http://localhost:8080/sharepoint/ ?

You image does not show in the generated HTML. The name of the image file you reference (i.e. office-path.png) in the markdown does not match the name of the file office_path.png. Notice, you used an '-' in the markdown, but a '_' in the file's name. As a rule of thumb, please use '-' to separate words in these image file names.
+1 having these forward slashes is a nice trick to probe if there are any windows users out there ;-)
I have think about it for a short moment. Maybe there is a way to harmonize plot, get and find sources based on scores....
If we do something like what you propose it should be consistent.
> Crap! Sorry about that -- I'll be more careful about it. Before merging those offending changes, I ran nosetests -x, but I didn't run make test-doc.

this really means that we need more tests… That's weird that this
issue was not flagged by a test.
you can just do += if you like, it turns out.
Change the literal block `::` to a code block, by removing one colon here, and adding like so:

```
.. code-block:: c
  int ...{
  }
```

This can also be applied to line 42 above - `.. code-block:: bash` should be used.
+1 on Q not sure many people use jquery-deferred in nodejs land.
We can't really test the `get_oath_token` then.  How do we stub commands?
You should change the previous 3 lines into:

    List of directories scanned::
This code doesn't seem very clean, but it may be used when you specify a custom file geometry parser, as tested in thumbnail_test.rb#252.
I have fixed these errors after I checked the rules for other languages (particularly the Urdu one).
Stock isn't assigned to incomplete orders so leaving the the original order intact is acceptable from a stock perspective. (stock levels only get affected with an order is completed).

When we had the old order merge feature it used to delete the old order contents and it caused a lot of problems when diagnosing issues. I much prefer leaving the old order as it was.
Эммм, так нулевой айди — это ок или неок? В мапе с аккаунтами ключ 0 будет присутствовать.
(typeKeys :system-package-name "blur")

'typeKeys' command used to send keystroke events. Here it actually enabling the "Add/remove" button after setting the text by setText. I'm passing any random text "blur" because in this case typeKeys doesn't give any visual effect with this value 'blur".  

I'll change this to 'items' for better code readability.
I'm sure there are, but it's recommended to use the "Package installer" to install packages,   perhaps i'll put a reference to the package manager
please add a @cover anotation
nope... rowCount is not safe on select.
anyway since found_rows is only mysql, whole thing changed to use count(*)
Move this into the `for` loop.
Shouldn't the ClearCommand check be outside? If the tx doesn't remove any entry (e.g. because the local cache didn't have any entry), I don't think the commitEntryIfNeeded method will be called at all.
I agree that an interface is the best way to go here. That's actually how I started implementing it initially, but the MBean was having trouble invoking the getters and setters on the implementation class and I ended up moving the functionality into the interceptor. I'll revisit that approach and see if I can fix the MBean issue.
I was just calling it what libgit2 does… I couldn't come up with a better way of distinguishing the 2.
`pip install` doesn't reinstall packages without the `--upgrade` option.
Having a span floating around in a `<ul>` but not in a `<li>` is invalid HTML.  Stick that bad boy in the button's `<li>` or after the `<ul>`.
my general (speedup) comment here is that you don't need to call get_kernel_matrix() above but can just do:

```
sigma-=kernel->kernel(j,i)*m_alpha[j];
```

and probably precompute the kernel diagonal by just adding a function to CKernel like

```
SGVector<float64_t> CKernel::get_diagonal()
```
and then access things here with diagonal[i] instead of A.matrix[i+i*n] ...
but rather:

```foat64_t time=timer->start();```
could you please put all multiclass strategies into separate files? it is better to see them all separately - thanks!
" please document these paramters - what is l? what itr? "
Done..!

yes C is 1/l but in matlab code it wasn't used anywhere so i didnt include that in my code, Now i have included C as well
Retried. Still can't get it to work. Might be using it wrong?
Hmm, yeah. I don't see why this is needed. It's just making things unnecessarily complicated.
I'm having a problem documenting this is a clear way.

    int $order Base joins, such as scaffolded inheritance JOINs, are using an $order of 10 so they will be listed before the default $order of 20
Nevím, jestli je výraz "start time" úplně intuitivně nejlepší. Původně jsem to pochopil jako že je tu uložen čas, kdy byl timer spuštěn (ve smyslu čas volání timer_start), ale po chvíli zkoumání kódu timeru mi to přišlo divný, jestli to dobře chápu, to má asi znamenat čas, kdy má timer doběhnout, tedy spustit handler. - je-li tomu tak, přišlo by mi lepší místo "start" použít třeba spíš "fire", "raise", "signal" nebo "callback".
Please use explicit conditions on your code.
Was the original license wrongly typed?
I agree, and I don't mind writing it differently either way; This pull request isn't even complete (I'd consider adding a test maybe). I wanted to first get feedback about the pull request in general.
It's available and not avaliable.
should you make sure that shortMessage.length() <= MAX_SHORT_MESSAGE_LENGTH?
I'd like a developers opinion on this (no insult). While I agree that it would make the code for maintainable, I think that it would creat an unreadable and ugly block of code.
it says only if needed "If you are working with a proxy...". Not sure what you mean
UserMapper вроде есть, почему здесь его не использовать?
Creio que deveríamos ter em atenção a excepção dos workshops, que sabemos não serem recurrentes, apenas prolongados. Já faço um commit e push.
Think we're better off writing a proper XUL dialog for this, so it can be made a bit friendlier - usual information icon (or a Firefox Shield icon), etc.
Add a test?

<%= conteng_tag params[:whyyy],  "your mom" %>
<%= conteng_tag @user.preferred_markup, "your mom" %>

:sunglasses:
... Here ...
why /8?
I decided to return only published posts when request or request.user aren't available.
I thought that the problem is in [this dummy queryset](https://github.com/mitar/django-tastypie-mongoengine/blob/master/tastypie_mongoengine/resources.py#L23). So it is not a problem there?

But this is not a problem. Python is dynamic language, so you can define `.query` anywhere. For example, maybe it will useful to do [it here](https://github.com/mitar/django-tastypie-mongoengine/blob/master/tastypie_mongoengine/resources.py#L152):

```
meta.queryset.query = Query()
```
For those string, check why they are not needed anymore and if there is no error (like somebody forgot to mark strings as translatable), remove them.
*If for some reason the input box below is empty, paste in the token manually.*

Comma, dot at the end.
If you are adding new session keys, you should extend also `flush_session` function, and also check elsewhere if there is something similar to add too.
*404 Ne obstaja*
Where is this template file used?
I thought delete was working?
$localModel->set($this->getProperty()->getName(), $targetModel);
Is this the s dot log in page?  If not, should the user be redirected to s dot login page instead?
no need at bossAI
Add CURRENCIES SETTINGS in SECTION INDEX
I guess this needs to be relocated to line 207.
Unfortunately, while 'step' is nice and clean, and this does make tests pass upstream, it also causes things to fails running, for example on fedora 16 with system ruby/rpmified gems.  This appears to be because the step method did not exist in the older version.  Much as I want cukes passing upstream, I do not want it to be at the price of them passing for our platform/distro users.
Might be good to just add the decode to all the other endpoint URIs?
Kapiere ich nicht ganz... Könnte man das noch in einem Kommentar dokumentieren?
Sequence is out context. "Add to article model `has_translations :title, :text`:" is better
Symfony does not align them, and to be honest, I don't like this rule much as it forces to do big diffs when you add a longer variable name.
And btw, this bundle does not apply the rule in other places either.
Lets give them this: 
res.writeHead(200, {'Content-Type': 'text/plain'});
Ok, I didn't see it like that but it's ok for me.
Code duplication from RHEL package spec. It should *at least* be referring each other in a comment.
jQuery actually does this as an IIFE -- otherwise, the code inside the function won't run, and `window.jQuery` won't get defined.
Don't understand these to fixme. We MUST manage a special case for th PK field, as it is not a real index, and with a PK in filters, we can largely optimize the query, as it's done here.
If there is no way to cancel a reservation manually, then my comment doesn't matter.  But, if there is/will be a way to manually cancel the reservation, then you'll need to ask the "business" if they care about the difference.
Do we actually need the new solution? The only parts that rely on the tools being installed would also be part of this no azure solution.
nm, that is features convention
Maybe use the generated `ThreadStarted` class?
This function looks like it could be templated to avoid duplication with create_loc_conf below.
As previous comment.
I guess `onClick` should be documented as optional.
:+1: for LCC
I'm sure what you mean by "reset df_model in fit."  I tried re-setting it all over the place.  Nothing seems to work.  The place that makes sense is inside L1BinaryResults and L1MultinomialResults.   However, if I try in either place (using the @cache_readonly decorator) I get the warning "the attribute 'df_model' cannot be overwritten" (and then tests fail).
same as above iteration on results instance
Paragraphs used for padding. What next, spacer.gif?
I don't particularly like this syntax.  This is a case where I think the operator overloading isn't terribly clear.  I'd rather get a verb in there.  Maybe:

```
noise.applyTo(img)
```
Would it be clearer if noise didn't have a type at all?  So the pure Gaussian for BD1 would look like:
```
image :
    noise : 
        read_noise : 30  # ADU / pixel
````
The pure Poisson for BD2 would look like:
```
image:
    noise :
        sky_level : 2.5e4  # ADU / arcsec^2
````
And the full CCDNoise for this one would be the same at it is currently, but without the type line:
```
image :
    noise :
        sky_level : 2.5e4  # ADU / arcsec^2
        gain : 1.7  # e- / ADU
        read_noise : 0.3  # ADU / pixel
```
OK.  I reworked the doc string for getShear a bit to explain both kinds of functionality.
you mean should switch back to  :test right?
Ok, I can change to Java - there aren't many Groovy idioms used, mostly syntactic sugar. Are there any wrinkes that I should be aware of?
Should this be ciel instead of floor (now that we're not doing `currentSize-...`)?
If desiredSize is 1.5, then should set it to 2.
Perhaps startInBackground and destoryInBackground should return a Future (or a ListenableFuture)?
Both these approaches limits the check to only own properties of the source.  Given you're restricting to a named set of properties anyway, what does it matter if they are defined in a prototype?  I can think of plenty of cases where that would be unintuitive, especially since a main use-case is for restricting properties of objects that your code doesn't control construction of.
I could put "empty" or "nothing" instead of putting nothing there.
It's pretty much saying that the desired state is to have nothing.
On Wed, 5 Dec 2012, Hannes Magnusson wrote:

> >  REPLSET FINE: sorting servers: done
> >  REPLSET FINE: selecting near servers
> > -REPLSET FINE: selecting near servers: nearest is 0ms
> > -REPLSET FINE: - connection: type: STANDALONE, socket: 3, ping: 0, hash: %s:%d;-;X;%d
> > +REPLSET FINE: selecting near servers: nearest is %2ms
> 
> What is %2?

THought that I had fixed that one already. Anyway, I've done that now.
There's also a jetty-cygwin.sh here for Windows, should we detect the host OS and select the appropriate script?
Maybe we should add a comment:

    // this is how you can render a view calling render() method

Just to avoid improvements by the next smart guy.
Это неправильно.
Здесь создается не `Part`, а `part = params[:type].constantize`. То есть, формой отдается тип `Part`, который затем переопределяется как константа и он создается.
woot much better, thanks!
This doc string for index and slice was the key to me finally understanding this whole thing. I wonder if some of this should be promoted to the class level doc string.
No * please
Ok. I'll take a look. Thanks!
Erm... are you sure?
ive added a short comment. i ran across that problem when trying to capture PWM on the full featured timers 1 and 8 which require two interrupts to get CC als well as UP.
Es liegt in der Natur der Sache dass der AlarmWorkflow-Service (der von Fax, SMS und E-Mail getriggert wird) eine Laufzeit mitbringt. Und dann kommt nochmal eine Verzögerung von dem Mechanismus hier obendrauf. Die Konkurrenz kenne ich nicht.

Bitte verstehe Kritik doch nicht immer gleich als Angriff! Wie sollen wir als Team denn dann so zusammenarbeiten?
Why is this needed?  I'd rather leave out deform's CSS completely as it's ugly as hell.
@return comments.
I don't think it's required. But probably good to have since django keeps complaining!
This is a bit awkward as first it's checking an element is present and then it's changing the locator.. then assuming False.

Firstly it's much safer to retain the polarity of the bool value you are returning.. just in case this is used in a test somewhere else and you have missed the reference.

Secondly, as it's an input element can you not just check the is_enabled property of the element?
E       AssertionError: Expected page title: Test App (whateer1979) | Mozilla Marketplace. Actual page title: Test App (whateer1979) | Search | Mozilla Marketplace
aren't you now missing an entry for the lib?
データベースなしにテストが行えるという意味では最適な方法です。
について、
データベースを必要とせず、テストに集中できるという意味では最適な方法です。

のようにDB設定がいらんというよりは、やりたいことに集中できることにフォーカスした訳にしてはいかがでしょうか。
I've removed these hard coded paths in the build event.
"you'll have to" could be removed or replaced with "simply"
This link is repeating the link above; is it necessary?
sorry, my apologies. no problem
I know you worked on this for awhile.  Did this end up being the best way to do this?
found_violators sounds like a boolean flag. It should be something like kkt_violators being a list or a set and no violators is equilavent to len(kkt_violators) == 0
imported but unused
@kuantkid: could you also add the new estimator to the
plot_lle_digits.py example (that is nowadays very poorly named) and add
the resulting figure to the narrative docs.
You mean, check the expectations? I had the same idea but didn't do it since I thought it would require lots of samples to reach close enough values. I will try if I have time though.
Not sure about the pattern as I said above.
But you are right. I should downcast all of these.
@yebblies: I would have to do this in many places though. For example if I change `StaticAssert::semantic2` to use an `oldExp` one error will be:

```
Fix7420.d(5): Error: variable y cannot be read at compile time
Error: cannot cast _error_ to ubyte[]
```

9rnsr's solution works better in this case.

But why are there at least two ways of flagging errors in DMD? :)
Actually, you're first comment was correct. The second data set in `provideInvalidIsIndexableCallbacks()` makes this redundant and I just forgot to clean this up.
Updated all except IP_ADDRESS, it is mandatory to run on device/simulator
Seems not. Removed
We'll want to this to be patch-4
I think the code implemented in `EBeanHolder.parseClass()` should rather be implemented here :) .
it's a triple S ressource ! must be important..
Surround by quotes ('), ensure that any special characters within them are quoted correctly e.g., \r \n \0.

Try value()->generateECL()
My next patch is going to clean this up
No, that is a remnant comment/placeholder from when this was a draft.
That could have been removed, it is a comment so will not render in any published document.
Only exists in source. It can be removed.
Should I edit the source and then commit/push changes?



From: Richard Chapman [mailto:notifications@github.com]
Sent: Tuesday, October 30, 2012 4:27 AM
To: hpcc-systems/HPCC-Platform
Cc: Panagiotatos, Greg (RIS-BCT)
Subject: Re: [HPCC-Platform] HPCC-8155 Add ECLScheduler XML document (#3596)


In docs/ECLScheduler/ECLSched-Mods/ECLSchedComp.xml:

> +      <para>To access the ECL Scheduler interface in ECL Watch, click on the

> +      Scheduler link in the menu on the left hand side. The Scheduler

> +      interface displays and you can see the scheduled workunits, if any. The

> +      list of scheduled workunits has two significant columns, the <emphasis

> +      role="bold">EventName </emphasis>and the <emphasis

> +      role="bold">EventText</emphasis>.</para>

> +

> +      <para><figure>

> +          <title>ECL Scheduler Interface</title>

> +

> +          <mediaobject>

> +            <imageobject>

> +              <imagedata fileref="../images/ESCHed01.jpg" />

> +            </imageobject>

> +          </mediaobject>

> +        </figure><!--COMMENT: INSERT INTERFACE DOCU HERE... WRKUNIT USE THOR!

Is there something still missing here?

—
Reply to this email directly or view it on GitHub<https://github.com/hpcc-systems/HPCC-Platform/pull/3596/files#r1976041>.
The code below this is a mess... Not really this patch, but I think adding this line above will only make it worse... Shouldn't be hard to re-write the few lines below in this patch, though.
Since we're changing these interfaces now would be the time to common up usage of PackageMap vs. PackageMapName.
This decision makes much sense, hence being just a note that might be discarded :)
I thought I did. Probably TextMate on plain text just use softwrap instead my usual settings. I'll check.
Patch submitted for bug 616640!
Looks like C-convention. You can easily use `let` in front of each variable.
Yes, but it will be, to store the actual structure of information for outside use. Just decided to go with the message only for now, to make this available to users ASAP
@ochameau I'm fine with doing some event emitter unification in follow up patch & if that would be possible / make sense.
short editable text
Thanks for sending this. Could you possibly check for an existing connection before calling cancel? At least check to make sure image connection has been set. Please re-submit once you've made this change.
Don't leave commented out code.
Given that details_urls are relatively simple to calculate on the client, you could save space by only passing back the keys and reconstructing the URLs from a pattern in Javascript.
not sure how this improves, no change made (yet)
i'm assuming that proper docs on what this stuff is, and how to use it, will happen sometime
"sends a request to a an http/https..."  -- you have an extra "a" in there. Also, I believe you should capitalize HTTP and HTTPS?
Why are you doing a foreach here only to grab the dirs and store them in a variable only to do another .each call down below? This is redundant and makes no sense
Let's do that.
Maybe rename to `kind_a` so that it doesn't shadow the variable in the outer scope.
Could you add further details in a Notes section of the docstring? About some techniques resulting in voxels having different sizes for in-plane or out-of-plane dimension. Since I'm not familiar with such techniques, I had a hard time understanding what this correction factor was for. And what do you mean by slice-thickness? Is it the out-of-plane voxel dimension?
Why are we doing that?
Put this and the others back as mentioned earlier.
Can we just remove ?
It's annoying to switch between different programming styles and different projects... ;-)
Indentation is tweaked. Looks like you have tabs instead of spaces.
This would read better as 

```python
self.is_initialized = False if instance is None else True
```
Ooops.  Silly typo.  Fix coming up in just a moment.
Should probably test that it returns a 404 here.
Sorry. In td-logger style, following code is better:

```ruby
unless conf
  @disable = true
  return
end
```
/me votes no space for ``functions()`` but one space for language constructs, like ``for (blah) {``
maybe rename this message to just TIMESTAMP, since it can then be used for other stuff as well, not just for openlog
I would define a helper just for the `!is_hidden` called `is_visible?` just to make this code a little more obvious.
getEncodedCode
Seems a bit unmotivated – if you don't want to use the first random value given for some reason, maybe add an explanatory comment?
Not clear on the context, but shouldn't this be while?
It's a hard and fast rule to not have templates in druntime. We shouldn't use it as a restriction for how we need to approach things.
There are some talks on the boards about `auto ref`: Any plan to have that work with `foreach` ?

As is, it is painful to see that it is un-useable even for such a simple (simplest?) iteration scheme.
I didn't deliberatly to emphasise the pairing of the methods.
No need to use an image cache. Go ahead and just use a module-level variable that's private to this file 

```lua
local image = love.graphics.newImage('images/pot.png')
```
I'd drop that line, since you list the example in the following two lines anyway.
this changes the default logging to debug. Can you make this configurable?
Hi Kevin,

Sorry for bugging you again.
I was just wondering when my plugin is going to be available for all
Sublime users.
Please, let me know if there is anything else needs to be done by me.

Thanks,

-- 
*Henry Demirchian*
(818) 624-7657
henry@demirchian.com

On Thu, Nov 1, 2012 at 7:17 AM, Henry <henry@demirchian.com> wrote:

> Hi Kevin,
>
> Sorry about that.
> I fixed that issue as well.
>
> Thanks
>
>
> --
> *Henry Demirchian*
> (818) 624-7657
> henry@demirchian.com
>
> On Tue, Oct 30, 2012 at 5:42 PM, Kevin Yank <notifications@github.com>wrote:
>
>> In repositories.json:
>>
>> > @@ -1,6 +1,7 @@
>> >  {
>> >  	"schema_version": "1.2",
>> >  	"repositories": [
>> > +		"https://github.com/hdemirchian/CSSFormat",
>>
>> You have the correct URL now, but this line should still be placed in
>> alphabetical order, rather than at the very top of the list of repositories.
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/wbond/package_control_channel/pull/717/files#r1987051>.
>>
>>
>
>
>
>
If I recall correctly, `COUNT(field)` doesn't always have the same behavior across different database platforms, even if it's supported by all of them.

Also, the backtick as an escape character is deffinately not universal, use `$this->protect_identifiers('numrows')` (as passed by `count_all_results()` for that. This brings me to another thought ... do we really need to add an additional parameter to `_compile_select()`? It's not going to be used by anything else than `count_all_results()` and we can achieve the same effect with the following expression:

    `$select_override === $this->_count_string.$this->protect_identifiers('numrows')`
This doesn't exist, throws an exception.
Should this be named or stored somewhere for use somewhere else?  I'm actually asking... not being passive.
Evtl existiert diese Korrektur schon!
Wenn der Proofreader zwei solche uploaded, bevor er diese Commitet...

Ich glaube der Check muss folgender sein....
$correction = $this->correctionRepo->getRecentCorrection($order);
if( $correction != null && $correction->getVersion() == $order->getIteration()){
    //UPDATE
}
else{
    //NEW
}
:+1:

I believe that it's always avoidable, as it could be refactored into a static method of a `FooUtils` class, for example.
All of these `<a>` tags should be `<button>` tags
missing a space between `)` and `{`
Why do we need the `|eat` here?
It is leftovers. I will remove it
On Jul 18, 2012, at 10:57 AM, Uri Cohen wrote:

>> @@ -0,0 +1,8 @@
>> +import org.cloudifysource.dsl.context.ServiceContextFactory
>> +import java.util.concurrent.TimeUnit
>> +
>> +println "data_start.groovy: BigInsights data node is about to start"
>> +
>> +sleep 7200000
> 
> What is this sleep used for?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/CloudifySource/cloudify-recipes/pull/9/files#r1185772
>
I'd prefer using:

    static assert(false, "FIXME: This is horribly broken. [...]");

That way it will not get overlooked.
Fair enough. Then I don't think there's anything keeping this from being merged?
JDBC allows you to specify the region...

````java

	/**
	 * A unique grouping identifier for all messages persisted with this store. Using multiple regions allows the store
	 * to be partitioned (if necessary) for different purposes. Defaults to <code>DEFAULT</code>.
	 * 
	 * @param region the region name to set
	 */
	public void setRegion(String region) {
		this.region = region;
	}
````
the ``@author`` annotation should be in the phpdoc of the class, not in the license header
> 
> Can you please  clean the commit to keep only relevant changes? Thanks!

Whoops. I had converted whitespace to spaces, but they were tabs before. I have changed it back to tabs.

--
Fb
Somehow the white space got goofy here. Tabs vs. spaces maybe?
何かコメントが変な風に整形されてませんか?
to have this populated for sure, you need to make the document referenceable.
All instances of "current release" in the documentation will be outdated as soon as the documentation is released.  It would perhaps be better to use "this release".  Or, even better, to not mention the version number at all unless strictly necessary; while it's fine here, is it adding anything of value?  The version number associated with the build is embedded in the "breadcrumbs" at the top of each page, so most of the references to the current version throughout the text are redundant, and could be removed in most places.
You also need to add a extra empty line after the ``code-block:: php`` line ...
@stof This issue was fixed in #945.
"Unknown platform.." on Linux is a bit too harsh. ;-) How about something like "Default platform settings"?
Reword to make this less awkward: The ID of the `<see cref="Series"/>`.  I think this is worse, but you could also do: The `<see cref="Series">Series's</see> ID.
Why not 'apnssettings'?
Issue logged: #498
I don't know what these magic numbers mean
Use self.timeout instead of hard-coded values.
Bad indentation (9 spaces instead of 8) (And line 30)
At any rate, it's an unrelated change, so consider omitting the change.
This needs to be de-indentize like the other css files.
are we doing 4 or 2 for indentation? this is 2.

jamesladd?
One use case I can think of is to index stuff that are about to be deleted for raw lucene querying.
Should just remove this if it's not needed.
Should this run KCD.clean instead of just removing the lockfile?
I really have to fix this abstraction sometime. *sigh*
This should be in a `try…finally` in case the abort or the log fails.
ZF1 1.12 is the latest stable. why are we locked in to 1.11.x-dev? i am successfully using the container with ZF1 1.12.0 in production.
I can't have it exactly like before, because each function to handle a feature calls processParamsObj. I can move the init() function to just after the processParamObj function if you want.
Add this to the managers project.