labofsahil/github-event-dataset-2012 huggingface dataset:
So, this is actually incorrect, but you are not detecting that because you have carefully stubbed things in the tests - and proved that, absolutely, your code calls things you call.

The name of the custom function `notice` on the scope is `function_notice`.  You need to recognise that here and:
1. enforce that *only* `function_*` messages are sent.
2. ensure that the name is mangled from `*` to `function_*` before you send to the scope.
As before, the CA behaves differently with different run modes.  Aside from anything else, the agent vs master certificates and keys are referenced.
I think there's value in knowing that everything requires a user.

Is it valuable to have a `visitor_changes_password_spec.rb`, or is that just a failure case in `user_changes_password`? At what point does it get extracted to another file?
Oh, yes, fair enough.
Run tests/ZendTest/Soap/ClientTest.php. Don't forget active ob_start() in bootstrap.php to not skip the test !
We should probably mark this one to not share by default, since there may be multiple filters of the same type with different options.
@lingboli this is what misaligns the search button with the search box. Is it working correctly with this line in chrome/osx?
-> `<input class="edit" value="{{title}}">`
agree, done...
this seems to break the extension
You're grabbing same element 2 times. One for isset and the second for fromClassName.
You could try to simplify your logic by moving the fromClassName outside of IF scope and doing the isset out too. That would also allow you to inline the control structure.

```php
$fromClassName = isset($AST->fromClause->identificationVariableDeclarations[0]->rangeVariableDeclaration->abstractSchemaName)
    ? $AST->fromClause->identificationVariableDeclarations[0]->rangeVariableDeclaration->abstractSchemaName
    : null;

if (strpos($className, '\\') === false && ! class_exists($className) && $fromClassName) {
```
This is all good, but I don't think you make it obvious that it mixes media as well. Including Youtube using the canPlayType you explained above.
use `self.log.error` instead?
Probably I swap the order of this  - Build & Deploy and then Build Only.
TXBRIDGE_DEMO_SERVICE_ARCHIVE define as "../service/target/txbridge-demo-service"
at org.apache.catalina.core.ContainerBase.getLogger(ContainerBase.java:409) which get logName as following
org.apache.catalina.core.ContainerBase.[jboss.web].[default-host].[/../service/target/txbridge-demo-service] which I use byteman script to print.

at org.jboss.logmanager.LoggerNode.getOrCreate(LoggerNode.java:154) 
there is ".." in the logName which cause problem when parsing this string.
Isn't a lot of this duplicated in your management command? Sounds like a util method to me.
Nit, but `#ccc` is shorter. (And an extreme nit is either use all lowercase or all uppercase in CSS -- I think I've been using lowercase.)
over indented.
What's the logic behind not calling update if the start or end is changed? It seems completely arbitrary.
What's the reason to store this state data here, rather than accessing it directly?

I wonder if it's possible to get the state data stored here out of sync with the actual state of the html5 media, perhaps by interacting with the media controls directly?
This line doesn't work properly, it needs a *
I'd use a little more descriptive name here. `_` and `N_` are standard gettext names, but `C_` can be confusing. What about `ugettext_countries`?
Ajustado para levandar um CannotValidate
should we location/orgs to trends as well?
_addChild(foo) { this.once('ready', foo.trigger('ready') }

this.trigger('ready') { exec(once ready); each(children) { child.trigger('ready'} } }
At a minimum, we should at least report a test failure in the logs, that way we can diagnose the problem effectively to know that tear down failed.

Not sure what we can do if tear down fails to ensure that we always run in a clean state. Do we have any options?
please don't bump the version
New line and horizontal rule should not be used here - the website is responsible for the formatting (and there is plenty of padding under the titles already)
static не очень клевая идея.
Should use integrity/integrity.
The util file included above has its own stop_app function that's generally used.  Should it handle both the hot and cold use cases instead?
Actually, this API only needs the isManager property. I've updated the comment.
* unit tests: TRACE

:)
github hates me and my links..

https://github.com/sakaiproject/Hilary/pull/126/files    #L4R65
I doubt it as that checks if `Array.isArray` exists and if so uses it. (Otherwise it performs `toString.call(obj) == '[object Array]'`)
``behaviors = behaviors push newBehavior``!!!! Would anyone mind if I use a ``mutable`` stack, to me is so much more error prone to use an immutable data structure when you actually do want mutation to happen. Anyone against?
s/declaration/declarations (that was my mistake, but would be good to fix the typo)
labels are linked to their inputs using the `for` attribute of the label and the `id` attribute of the field. Not the `name` attribute
If parsing fails here, the compiler ignores this line and continues parsing the remaining file.
When using command it errors out telling desc
This does not follow the style guide, it should be:

    if ( ! is_array($colors))
    {

This will also need to be noted in the user guide and the changelog.
Put that on the previous line, looks weird.
Дядя Вася попросил вас написать программу, у которой будет метод mutate, что будет модифицировать исходную последовательность на X %. Дядя Вася не дурак, и решил проверить, что вы ему подсунули. Вывел на экран содержимое ДНК, вызвал метод mutate:100, что должно было полностью обновить ДНК, но этого не произойдёт, так как в вашей реализации ячейка может быть заменена на саму себя, что в конечном счёте ни коим образом не сойдет за замену, ведь окажется, что заменено не строго 100%. 

Ну и алгоритм несколько не оптимальный - чем больше нужно изменить элементов, тем больше итераций нужно будет сделать (так как вероятность выпадения того же самого индекса, что уже был, вырастает с ростом количества элементов на замену).
По Вашей логике программа не удовлетворяет условию заменять СТРОГО Х процентов. Она заменяет СТРОГО Х элементов. Никто не заставляет писать идеальный код, но выполнять условия желательно.
Считаю инициализировать переменную каждый раз не хорошо
Если можно, объясните пожалуйста, как их сделать константами или статическими переменными, но честно говоря я не вижу ничего зазорного в том, что эти данные хранятся в свойствах.
Теперь понятно. Смутило совпадение количества элементов ДНК по условию задачи с числом процентов. Исправил в bug fix 2.
Missing implementation? ``liveBrowserMgr->Shutdown()``
I assume "entity" in the property name is due to it being defined in the base class?
Just for the record, both BSD and GNU date support `date -u`, so it should work on most, if not all platforms.
We were attempting to stick with the convention laid out in Processor, where we have Raven::Processor::Processor as the base, though I can see how that can be confusing.

Perhaps it'd be better to go with the convention in Interfaces, where it's Raven::Interfaces::Interface as the base class. I'd rather not introduce a third convention of Raven::Transport::BaseTransport. Thoughts?
That's a loose end I believe. Removed it :)
What is getting released as "tvrip"?
That makes sense. I kind of lost track of all the things we talked about so I figured I'd get us moving :)

I'll boot that out of the Epochs instance tomorrow morning (along with dealing with other feedback).
Hmmm, this seems to introduce a new dependency, and is hardcoded to the root.

Any chance this can be made relative?  i.e. src="socket.io/socket.io.js"
ok. This is just for the demo. Other I will put beneath it.
responsive design for featurette. port this to the responsive stylesheet.
Spring won't be able to instantiate it if you don't have a non-arg constructor. I'd try with @Autowired public HibernateOpenmrsMetadataDAO(SessionFactory sessionFactory). You should be able to use TypeToken to determine mapped class.
Perhaps it would be worth setting the default value of the record to `false` here?
Function's been removed.
Yeah, since it wasn't here before :+1: for not including it now.
$ rake app:refinery:uncrudify controller=refinery/admin/pages action=update

```ruby
def update
  if @page.update_attributes(params[:page])
    flash.notice = t(
      'refinery.crudify.updated',
      :what => "'#{@page.title}'"
    )

    unless from_dialog?
      unless params[:continue_editing] =~ /true|on|1/
        redirect_back_or_default(refinery.admin_pages_path)
      else
        unless request.xhr?
          redirect_to :back
        else
          render :partial => '/refinery/message', :locals => {
            :new_url => refinery.admin_page_path(@#{singular_name}.uncached_nested_url) 
          }
        end
      end
    else
      self.index
      @dialog_successful = true
      render :index
    end
  else
    unless request.xhr?
      render :action => 'edit'
    else
      render :partial => '/refinery/admin/error_messages', :locals => {
               :object => @page,
               :include_object_name => true
             }
    end
  end
end
```
It's not meant to close over anything; it's here just to reduce mental overhead for people reading the class. There's never a reason to override it (that I can think of).
As the method is already there, it will not invoke the `add` of map directly . So this works other than the `map` , so yes may be `getMap` itself sounds good.
is this really needed as we already have the link to the php doc in the previous paragraph when talking about it ?
You should place this semicolon on the previous line.
Shouldn't we go with JDK7 Files?
http://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#newDirectoryStream%28java.nio.file.Path%29

or are we still undecided on dropping JDK6?
It is two different kind of Node. 
* The Node value you are talking about is for VectorClock.Node with is only a glorified typed identifier. Should be the Address string.
* The comparison is for Node.Member e.g. the different nodes in the cluster. The comparison is for maintaining a SortedSet for the ordering of the nodes in the node ring.
Strongly discouraged
Пару точно не вариант. Максимум одну - GetPostOptions
Пробел после `>`.
Хардкод цветов — отстой, да.
Касты-кастики, неймспейсы-неймспейсики.
You could use PropertiesConfiguration.PropertiesReader functions to match on prop delimiters.
It seems you could simple use 
```php
$controllers->before(function($app) {
```
refactor call to $request->get('lst', '') & $request->get('ssttid', '') as they already have been called
Why assigning `temp` in two lines?
Oh, i tought that the limit for flips was also 20%. Thanks for the clarification.
Not at all. vol_enabled means we support optionally having volumes in RDL, while must_have_vol means its required.
Oikeansorttinen idea, mutta joku toteutuksessa mättää, sillä yksi testi ei mene läpi. Ei pisteitä tästä, mutta korjata toki saat yrittää.
Yeah, that could work too. I'll have a look...
RebalanceConfirmationCollector, not RebalanceInfo.
`hist2d` takes advantage of the fact that when an element in array is set to `None` the bin representing the value is white out which looks nice. From my little test, log1p dies on `None`. You may want to take care of  `None` properly. Try this:
```python
x = randn(100)
y = randn(100)
hist2d(x,y,cmin=1)
```
Let's open a bug report for that one. Maybe you can tag it 'easyfix' for some newbie (like me) to work on?
can we remove this comments
Here for example you can save the element found at step 39 and then wait for that element to have disappeared from the DOM.
Is img.scale ever even set with this new pinch code?
Can we add the `total` variable in here as well, we don't need to execute this if there are no results.
I think the title will be helpful to sighted users, specially in the case of icons.  The aural text is needed by screen readers - not all of them will catch the title.
Register.js isn't finished yet. More will follow in the next PR.
Would we ever have a scenario where there's a stringified date coming through? I can't really think of one but maybe we want to catch that here?
Didn't see that it was commented out, all good.
I wouldn't mind moving away from mocha. I think the tests need some rewriting though.
Not 100% true. Variation visibility should be determined by its status (enabled vs disabled). I don't think that extra check it needed.
actually `concat` looks faster in chrome. it's probably not a huge issue anymore.
What size do you suggest? 4kb?
Spaces around = and <.
Well, arguably the current i18n extension doesn't really respect the Twig semantics either by using statement block instead of expressions. ;)

I'll have a look at how difficult this would be using filters and whether it makes sense...
Denne klager litt hos meg, uten at jeg helt skjønner hvorfor. Er det fordi den er inne i en `define`?

`warning: Dynamic lookup of $elastic_package at /tmp/hdo-puppet-rsync/puppet/modules/elasticsearch/manifests/install.pp:9 is deprecated.  Support will be removed in Puppet 2.8.  Use a fully-qualified variable name (e.g., $classname::variable) or parameterized classes.`
I have a feeling the length of this line is just over the limit.
space! :disappointed:
I dont know why, but autocomplete includes a index at end of id.
so in the code stays autocomplete1,autocomplete2 ...


*Thiago MadPin*
*
*
*cel:*             +55 11 96141038
*website:*      http://madpin.net
*email/msn:*  madpin@gmail.com
*skype:*         madpin

[image: facebook_16.png] <http://www.facebook.com/thiago.madpin> [image:
twitter_16.png] <http://twitter.com/madpin> [image:
linkedin_16.png]<http://www.linkedin.com/profile/view?id=88675110&trk=tab_pro>



On Tue, Nov 20, 2012 at 10:03 AM, Christian Leutloff <
notifications@github.com> wrote:

> In jquery.hotkeys.js:
>
> > @@ -43,7 +43,14 @@
> >  			keys = jQuery.map(keys, function(key) { return key.split("."); });
> >
> >  		//no need to modify handler if no keys specified
> > -		if (keys.length === 1 && (keys[0] === "" || keys[0] === "autocomplete")) {
> > +		//Added keys[0].substring(0, 12) to work with jQuery ui 1.9.0
> > +		//Added accordion, tabs and menu, then jquery ui can use keys.
> > +
> > +			if (keys.length === 1 && (keys[0] === "" ||
> > +			keys[0].substring(0, 12) === "autocomplete"  ||
>
> Why are you comparing only the *beginning* of the keys[0]?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/tzuryby/jquery.hotkeys/pull/32/files#r2179630>.
>
>
Please read my comments here:

https://github.com/wlanslovenija/PiplMesh/pull/199/files#r1366928

So the main point is that you should decouple API from frontend. So in the API you just deal with storing data (so storing to list of subscribers is OK). But to send something for frontend (`send_update`) is no go.

So please define and use Django signals. And move the code for frontend to frontend.
Keep the same order of checks, first checking `profile_image`, then conditions to use that.
I am very very sure that it does. ;-) Check how we are doing this elsewhere in our code.
I have not tried it, but I think this does not work OK. So immediately after the first letter of second password input box, error will be displayed, because both will be of non-zero length and non-matching?
omg this is just great!! 
whole site became working =)

before update, I also had to manually remove the billiard folder in python to make things right
No need for precise installation instructions. This they can find when they go to GitHub. No need for two links to GtiHub (here and above).
This is good, but you still shouldn't have the '../'. The `action` value should match what gets checked in the regex in `urls.py` which is just plain 'logout/'
Currency should probably be passed in right in the options hash as well.
@ntalbott You merged this change in, is it really required or could we do the mapping in the Orbital gateway instead? Maybe @jonm-okc would like to take a look as well since they made the change.
Wouldn't we want to check that there is a value as well, not just the key? `@options[:credential1].present?`
yes true, this commit would break the event ai text support, also there still some unneeded references to classes an structs related to script_texts.
we'll want to doc test this eventually - i manually tested for now
Should this link back to the collection i.e. `entity_uri('ting_collection', $entity)` instead of the object?
2 should be $BROCADE::CONTROLAUTO and that constant should be defined in pf::radius::constants
Trollop appears to pass nil for command line options that are specified but not defined.
or maybe both info?
Sorry, i somehow overlooked that.
Move this function below InitRequest()
just a note: this allows only dummy 0-1 encoding, no categorical effects encodings
Thank you for the review! I added unit tests for `linkTextWithEntity` and also fixed a typo.
Where is parser freed?
Why the ? extends AuditContext?
Answering my own query slightly, I do understand that there are additional parameters to be included (e.g. min, max etc.)  But I do think that we should try and bring the nomenclature to be as close as possible wherever possible, whichever side needs to change... (and we did discuss the naming scheme for the random number distributions some way back)
my only quibble is that that's getting kind of long, would ```calcCovarianceSymMatrix``` be okay?  (or maybe it doesn't matter, once it has ```CovarianceSymMatrix``` in it then it's going to be long no matter what)
@AChusuei Sorry I missed this discussion.  

ExternalUserRefId should be on the ConsumerInfo object.

@pmn4 We will consider adding it to the profile methods and bake it fully to the consumer object.
Yes, the slug is not required for my needs, but I was trying to provide something useful to put there, as it tends to be a free-for-all for exercise authors.
same idea : `"expecting:\n<%s>\n to appear only once in:\n<%s>\n but  it did not appear"`
We never specify full paths in exec in our modules. We define defaults for `Exec` for that.
`raw` here again.
액티비티 원으로 바꿀께요.
Shouldn't 2.2 be a string
Actually, this would be a perfect case for rspec/rspec-mocks#183, but we haven't implemented that yet, and this works OK here :).
Yes, it's necessary.  Without it we need to use an absolute URL for the data-main attribute on the requirejs script tag.  That absolute URL breaks FF.

All of the other paths are absolute anyway, so they are unaffected.
Suggest replacing the last three parameters with **kwargs. That way you aren't duplicating signatures or default values.
No, unless it was null from SMS Database API.

Should I add check here? Like `(conversation.body || '').split('\n')` ??
I've never seen the "var foo" style before. Probably better to change it to var/turf/pickup
I created https://github.com/PhoenixPilot/PhoenixPilot/issues/59 to address assigning these uniquely to boards.  The work Edouard is doing https://github.com/PhoenixPilot/PhoenixPilot/issues/38 should hopefully make it easier to add hardware config pages for each.
Hmm, ok. Might be just as good to set as nil...
Comment in another place
Конструктор должен быть публичным.
This wasn't working with the nested urlpattern so I removed it. It's optional and we're not using it so it's ok.
Why was this line removed? It doesn't seem to make a difference for 'time -- event' entries, but for something like 'event at time', it's the difference between 3 hours too early and 1 hour too late. (I'll open an issue on that and we can deal with it later.) Just curious why this is in this commit is all.
On the other hand, if you did use `img_as_float`, you could specify in the docstring that `sigma_color` (or `sigma_value`/`sigma_intensity`, as discussed in another comment) should be between 0 and 1. 

The advantage would be that you could use the same sigma value for an image if, e.g.,  it's float or uint8. In particular, this means we could have a (constant) default value that makes sense for any input image.

The argument against this is that users may pass in a sigma value that they computed based on the original image. In this case, I'd suggest `sigma_color` default to None and then calculate a default sigma (maybe as some fraction of the dtype range or image-intensity range)
You could express the 2D case as 3D with one channel, but the 2D version is optimized and thus much faster.
I see you managed to get rid of my ugly hacks. Great :)
It can be multinomial or Bernoulli, very often binarization helps.  For multinomial, I would expect rectified linear units to work, judging from Hinton's lectures.  However the question is whether RBMs would learn anything meaningful from this kind of data at all.
It should be "Returns" afaik. Otherwise the numpy sphinx-ext will complain.
Isn't y optionally [n_samples, n_targets] now?
BTW I hate method names that are a single letter + underscore. WTF? Python is not matlab... readability counts.
That patch fixed it in the xsd and in the ModClusterService, but left this metadata description behind.

This patch is just step 1; step 2 is AS7-4050. Part of that step will be getting rid of all this ModClusterSubsystemDescriptions stuff so the descriptions will just be generated. The stuff in ModClusterService where the defaults are coded into that class can go as well. The AttributeDefinitions I've introduced in this patch can drive everything. The only thing that can fall out of sync is the xsd vs the AttributeDefinition.

I'm not doing that part today because I have to do some other stuff.
Yeah I didn't change role at all. I think there was a pull I didn't do before I pushed my changes
I agree with @AndrejMitrovic. At some level we must have a "tribal" shared view that goes beyond the written rules, and there will always be a lot that's not caught by the written rules but is silently agreed upon as not good. Our hope with keeping the written rules lax is to make for fewer, not more, discussions like this.
The lines above were taken from the android version, but I put the TODO there to fix things in another patch.
I think we need to log also all unsuccessful cases here and above, you can use Ti_Debug for that purposes
The following 2 line summary gets rendered on one line:

```yaml
    summary: Fired when the value of any column's row is changed.
             For the BlackBerry only 'value' and 'type' properties are supporting.
```

To get the 2 lines split, use the following:

```
    summary: |
            Fired when the value of any column's row is changed.
            For the BlackBerry only 'value' and 'type' properties are supported.
```
More details can be found in https://wiki.appcelerator.org/display/guides2/TDoc+Specification#TDocSpecification-PreservingLineBreaksandInsertingCodeBlocks
You'll have to investigate in the iOS and android code to find answers for that.  It may be a good idea to start by asking vishal where this is done in the code, although it may be easy to find with a grep.

If this is left for another patch, make sure to create another jira task for it and report in here the task number or url.
You could probably use opts.query_len here to figure out when to stop looping.
couldn't / shouldn't you use isAlive() her instead of a 'started' ?
I suspect you should only free the hash table if memory is critically low.
Just a matter of style, but I would've used early exits, like:

    if (retVal < 0)
        throw ...
    if (retVal == 0)
        return 0;
    if (!findfsd(...))
        throw ...
    try {
        ...
    }

And also gave a better explanation to why findfds could have failed, as in "unknown file descriptor in inotify change" or something.
This should probably be debug only.  Release should assert - there shouldn't be any no_selectmap making there way into the generated source.
`input` is a built in keyword in Python. Call it `input_` instead.
This branch is not clean with no vendor issues yet, this bugger refuses to remove itself from the PR ;(
by diablo release, I meant branch. basically, so I can verify that the latest patches out there still work for Diablo and then stop thinking about Diablo (master will start targetting essex)
missing e

Otherwise looks good to merge.
This and the previous case actually should be removed. We can't allow the user to store a GC pointer into non-GC memory.
should be corrected in next commit
I consider this to be an backward incompatible change. The field already is intended to represent the creation time of that object, with respect to the application. There's no telling exactly how applications in the wild are relying on the existence and meaning of this field as is.

That said, I suggest adding a new field, perhaps ``timestamp`` or something more akin to the SendGrid documentation for parity, to represent the time at which the event occurred. This has the added benefit being able to deduce a lag time (from event creation to arrival at the application). This may be useful in analyzing batched events, although not currently supported, which have the same or marginally different ``timestamp`` values -- i.e. a type of sessionization will be inherent in the data itself.
No we probably only want to run it on all artists rather than a subset, so in the controller:

    Artist.with_displayable_art

and in the domain model:

    class Artist
      #[...other stuff...]

      def self.with_displayable_art
        all.reject {|artist| artist.displayable_artwork.empty? }
      end
    end

Although your way would be betetr if we actually have a need to filter different lists of artists. But in that case you would still have a method:

    class Artist
      def self.with_displayable_art
        only_displayable(all)
      end
    end

where `only_displayable` is the same as your `reject_non_displayable` but with a positively-phrased name.
Need real function
The goal here is to parse only "legal" awards? So a new award would fall through the parser? I agree having some structure here is nice, but why not allow "unknown" award types?
```compact!``` ?
This .pyx file is great now.
typo:  `do` -> `to`
Using a Template Method like this doesn't feel natural in the Backbone world of events. I think having a "leave" event to bind to would be more natural.
@dlupu - any thoughts on Mike's comment above? I think that renaming it such that its usage is immediately obvious is a good idea.
Same as the previous list comprehension comment.
Why is this in the profile? Normally it's in the main plugins section.
To add to an already overlong discussion, I note that client code in BillboardCollection already has code like `imageRectangle.x1 - imageRectangle.x0` and `imageRectangle.y1 - imageRectangle.y0` to calculate width and height.  So really, clients need all of topLeftX, topLeftY, bottomRightX, BottomRightY, width, AND height.
I know what this code does (and why), and so do you.  But will anyone else know?  Let's put a comment explaining the temporal coherence.
We should probably say what the default is if `values` is not specified.
Instead of waiting until here to return, just remove the valid variable and return in each of the places you set it.
Is the default 36 hour period random?  Should it just be the next 24 hours?  What is the most sensible default?  How often will the user rely on it.  I assume we use `-0.5` so the user can slide backwards a bit?
I plan to come back to address windows at a later point given the focus for this release is internal use and this will suffice for that.
Instead this could be written as a fast enumeration and use `[measuredBounds appendObject:childRect]`.
It's on a standards track. It's also popular. We should build a sample for it.
These look much nicer.
No, go right ahead.
Thanks.
Source formatting note: We always need a new line after instance.
Please use consistent capitalization. Filenames should all be all lower case. The backend classes are not.
Entendi, só achei que pondo o cálculo fica mais claro o que está sendo feito sobre o dado.
Same here, why commented-out? If it's old then just get rid of it, right?
Actually, I'm not so sure if we should change this in the first place. There is no valid reason whatsoever for a caller to check if a function is `@safe` or `@trusted`. If `@trusted` goes away in the future (i.e. is changed to just annotate the function `@safe` and mark all of its body `@trusted`), this would break `isSafe` and `isTrusted`.
Hm. Well, just drop these lines. The original seems fine. And I certainly did not change that file. Strange.
> I think the step into renaming the implementations of Validatable into MetaData was good indeed. I think it makes the code easier to understand and is consistent.

That's good :)

> Last thing though - do we really need the s in _ParametersMetaData_. 

As you say `ParameterMetaData` is already used for single parameters. Maybe `SignatureMetaData`? Or `ArgumentListMetaData`?
Yeah, I'm using 5.1.1, what do you use? It might also be that the document was last saved with a previous version I guess.
Seems like this code is coming from the past :)
The method registrationManager.updateRegistration waits 30 seconds for the Factory to be available. So no sleep is necesary here.
@normann Oh, now I see what you did there (regarding my previous question about adding conditionals to getStatusFlags()).
What was your reasoning for implemeting getStatusClass() in addition to getStatusFlags(). Given that you have to use the same keys anyway, it seems kind of redundant. Can't we just assume that the returned keys from getStatusFlags() make up the CSS classes? You implicitly assume that anyway from what I can tell. I don't want to litter the base model class with more view code than necessary.
why using an array of options and then doing isset checks when you only need one param ? pass the boolean directly as a property
to be consistent with other places, I would add a line between the param and the return instead of aligning them.
Btw, This should not be a success event here, right? This is broken as this listener needs a "FormEvent"
Updated this and next line.
I'd be more comfortable if this method continued to return a real boolean, maybe
````python
    return pattern.search(changes) is not None
````
I went ahead and fixed this, since I'd made some more updates to the submodules today to fix the MySQL 5.5 problem. Just needed to merge from master again, the submodules conflicted (since they'd been changed in the json-import branch), and I updated them to the latest, marked the conflict resolved, and committed that merge.
Shouldn't this be track `"defunkt"`?
Using variables not passed in to a function in setTimeout is dangerous and should be avoided. If any variable is reassigned during the timeout, that new value will be used. See http://jsfiddle.net/26TBt/ for an example of this.

Also, why do we need the timeout?
shouldn't this be namespaced with .sakaiSkin as well ?
I think this function and the following 3 could be combined?
callback function for result limit block
reimplement in S4
I can't be thinking about some uncompliant brokers, although I won't fight over it.
I don't really care either way.
`this.startViewMode` isn't actually defined anywhere, which results in a completely blank picker when the input is re-focused (effectively, `this.viewMode = undefined`).  The lines in the constructor should probably be `this.viewMode = this.startViewMode = ...`
:P it's just that if you use --driver you don't need --browserver or --platform as they as specific to Grid/Remote
nope, it was just quick enhancement.
Why `(` `)` around?
All right, I'll delete assertions.
`self.` is not required when calling a method defined within the class or its' supers. I find that I seldom use it.
check this [link on stackoverflow for a quick explanation](http://stackoverflow.com/questions/4699687/when-to-use-self-foo-instead-of-foo-in-ruby-methods)
``$this->context instanceof THE_INTERFACE_WHERE_THE_SET_PROPERTY_PATH_IS_DEFINED`` ;)
call this variable Properties ... within it, each will be a Property.   In fact, let's use java.util.Properties instead of Map<String, Object> ... it will address our needs succinctly.
You could also abstract this functionality into a separate function and then construct your list more functionally as well (if you like), maybe a function called ```retrieve_email``` or something?  That way it would be more reusable as well.  Something like this:

```python
def retrieve_email(uid, fields=('subject', 'to', 'from', 'received')):
    """Return a parsed message containing the given fields given a message uid."""
    fetch_args = '(RFC822.SIZE BODY[HEADER.FIELDS (%s)])' % (
        " ".join(field.upper() for field in fields))  # Fetch just desired data
    result, data = mail.uid('fetch', uid, fetch_args)
    raw_email = data[0][1]
    parser = HeaderParser()
    msg = parser.parsestr(raw_email) 
    #return msg  # only if you don't need to remove data
    #or
    return dict((key, value) for key, value in msg.iteritems() if key.lower() in fields)
```

and then to get the emails you want, just write this:
```python
emails = [retrieve_email(uid) for uid in messages]
```
or using map:
```python
emails = map(retrieve_email, messages)
```
Use HttpUtils if possible, if not add generic method there.
This'll move into the if...then... branch
We should use interrupt exceptions rather than a while(flag) thing since its easier to interrupt blocking calls. http://www.roseindia.net/javatutorials/shutting_down_threads_cleanly.shtml
exclamation at end feels like it's insincere.
Yep, this is cleaner - using the class method provided for exactly this.
Et pour moi tu mixes 2 trucs ici.

Tu check si la translation need une update et si le translator est dans cette locale là.

Hors le 2eme point est plus une histoire de permissions. Ce n'est pas parce que le translator n'est pas dans la langue là que la translation ne doit pas être updatée.
Least someone else brought it up otherwise I would of bitched about it =:3
This should not be needed.  Just verified and opening a Jira ticket to address this issue.
It's a tool-registry
- template file cleanup
That name was autogenerated by VS when I told it to implement abstract parent class.
You might want to move `spyOn(fs, "copySync")` to beforeEach if you are doing it in all test cases?
No, it's not. I've corrected it in MDS already. Please update MDS and do clean install.
could you try to do the same for odm ? and for propel ?