labofsahil/github-event-dataset-2012 huggingface dataset:
I'm not sure I'm following the logic here.  I would prefer just

if (osArch.indexOf("64") != -1) {
  osArch = "x86_64";
} else if (osArch.indexOf("86") != -1) {
  osArch = "x86";
}

This doesn't work for architectures like ppc64, but neither does the current version, and besides, we can fix that if it actually turns out to be a problem.
Only put each key if System.getenv(key) is not null
@rhattersley, I don't know masked arrays well, so maybe at this specific place it is OK, but:
```
>>> m = np.ma.masked_greater([[1,2],[3,4], [4,5]], 3)
>>> m2 = m[:,::2]
>>> m2._mask.ravel().base is None # it should be a view on m2._mask?
True
# And also:
>>> m = np.ma.masked_greater(np.array([[1,2],[3,4], [4,5]], order='F'), 3)
>>> m._mask.flags
  C_CONTIGUOUS : False
  F_CONTIGUOUS : True
 ...
```
To be honest, I am not certain that the current code is really perfectly correct in all cases and why exactly `[...]` does not work (I saw the error, but did not try to figure it all out yet). I think I have wondered some other time about masked array finalization which maybe could be done a bit differently to avoid also problems here.
I just pushed in a patch fixing this.
Also, sizeof(s) is always the same, it is a constant operation. It does not depend on anything, just returns size of char * type.
Again, sprintf should not be used. snprintf or spprintf.
Магические числа внезапно. Лучше выделить в константы
Ok, i can change it.  I just thought that the recommended style was to always use strings for actual SQL table names, then the conversion would be redundant.
```params.require(:user)``` should be fine since it shouldn't allow everything (we aren't adding nothing to whitelist)
I believe it's not required to create a new method, you could just change the last argument to default to `nil`, and check if it was given. If it was, is because someone is using the 4th argument and shouldn't be, right? Then you could just toss the deprecation.
It is intended; I think if any additional warning came through from that change, it would point us at a bug (either something is not hidden which should be, or we are generating inconsistent members with respect to specialization.)
This PR intentionally doesn't touch the docs themselves. We'll have a follow-up next week. I'll add your suggestion to the doc meeting google doc. Thanks!
Somebody forget their interpolator...
I think indentation should be changed to make this change and code clearer.
Let's add a few more tests with (at least):

```scala
{
val x = contralLBUB
val x1: Contra[A] = x
}

{
val x = contralLB
val x1: Contra[Any] = x
}
```

(Those variations were working before this patch)
It saw it in payments_spec : https://github.com/spree/spree/blob/master/core/spec/requests/admin/orders/payments_spec.rb#L12
Without it, the test fails.
Yea. sorry. Just thinking out loud :)
It looks good to me, but may be worth adding another note here to explain what's going on, and give an example of it being used.
Perhaps these should be replaced with tests that they don't permute automatically.
I guess so.  I must have thought the comment was useful at the time.
If I hard-code it into 2to3 *with forward slashes* it works:

check_call(["C:/Program Files/Git/bin/git", 'ls-files'])
Make the parameters passed into the function have more descriptive names; perhaps m -> mass, p -> pos_vec.
try laszyDSU_sort as above except you don't have to reverse the order wrt to ops. That will be deterministic and cross-platform independent b/c you break ties with `default_sort_key`
add -> subtract?
`$joinTableName` is then used at line 572.
Oh it's javadoc, lol
Reporter get violation counts reading from the db, but we can make that optional if not using a db at all is a required feature. collect() will already print violations to stderr regardless there is a db or not.
ConditionVariable is defined in lib/thread.rb 
'ref' requires 'thread'
but for clarity
require 'thread' should be explicit
我本地测试用的，忘了删掉而已。
Good to know, I would change it but the mongodb stuff now replaces it anyway.
I don't like how this method is unwrapping the variable only for it to be wrapped again later. Definitely we want to refactor so the SOM-based getMeasurement() functions are "basic" and the variable-based ones are convenience wrappers. Possibly you only need a single SOM-based getter

BasicMeasurement getMeasurement(final StudyOutcomeMeasure<? extends Variable> som, final Arm arm, final WhenTaken wt);

and can keep the rest variable-based (since those will be used by stuff "external" to the study, which is only interested in variables defined globally).

Also, WTH do "dV" and "dA" stand for?
I don't know what is going on this section of code.  Can you please explain?
Is this empy line required?
I find tertiaries generally harder to read and this is duplicating some effort.  Can we just do the lookup once and use if statements?  You can also use the CountingMap or some other data structure that automatically defaults for you.
To increase the accuracy of this representation, create a geohash with more divisions, or a higher number of "bits" (link)
You need two empty lines between the functions
Ok. Any suggestions?
This is for the the list of forums from where the user may view all topics.
Add a comment explaining the choice of these tags. Is this everything that phpbb supports/uses? Minimum needed for the test to work? Specific values need for testing something? Etc.
What I wrote is correct english. Is it a wrong dialect?

search in google for: "supposed not to be"
This class should use proper access modifiers, as php 5.3.2 will be the minimum requirement.
globalization needs to be taken out.
"turn off" means return to previous default. mod_rewrite was never on by default, it should remain off by default unless without it phpbb no longer functions.
Right, yea +1
de3b9dd
DBG or DEBUG... let's pick one for the patch.
This doc should be updated, confusing otherwise.
Rather than asserting there are no redis keys, why not move the `flushdb` call to this before hook?  Then you know the DB will be empty.

Also, I like cleaning up in a before hook rather than an after hook; that way, if there is a test failure and there is some state in redis that would help troubleshoot it, that state will be left around after the test so I can look into it.
This should be `which composer` as when it is globally installed it doesn't have the ext.
well, i'm trying to do the right thing and not throw in a dtor.  is there a better way to handle this?
Catching ``...`` must be done with a lot of care.. As stated [here](http://msdn.microsoft.com/en-us/library/6dekhbbc.aspx):

> Use catch (…) with caution; typically such a catch block is used to log errors and perform any special cleanup prior to stopping program execution. Do  not allow a program to continue unless the catch block knows how to handle the specific exception that is caught.
ahem-hem
Nitpicking #2, add a space after the comma
I wanted this to be global variable.
Simple answer - because it was there in the original ;-)
But it shouldn't be using a modulus - it should just be repeating the first value (as is done for the cube's data).

(Ideally we wouldn't be repeating values at all - it's a hack that only deals with certain cases.)
I suggest we discuss this valid point in a new github issue, as it's not necessary to complete this "user story".
This assert should be moved closer to the scene of the crime in the AdHocPlannedStatement ctor just called
shouldn't we just regexp escape basepath?

Would be good to have a unit test for this.
Keep imports in order.
import standard library libraries first, then empty line, then external libraries, then empty line, then ralph's imports
Why not just have `preflist_siblings` not include the index itself?  It removes this filter case, which confused me the first time I reviewed this code.  It seems to me an index shouldn't be a sibling to itself.
It's not clear to me how these functions are defined in the cases where they are continuous.
This is mutating the external primary sql match functions, that shouldn't be necessary.
End VTT files with newlines, not having them _may_ introduce unexpected errors that you're not testing for, so files that don't end on a newline should really be reserved for overall format tests
I think comment should become part of the docstring at the top of the method. It affects how a user would use this method if they were programming with this API
Since `jQuery.fx.timer()` is a new signature, does anyone have any thoughts about changing it to:

```javascript
jQuery.fx.timer( tick, element, queue, animation )
```

Just thinking for people overriding with their own tick functions, having to extend these properties to hook into `stop` and `:animated`, etc  might not be very intuitive.
hm we do not have 0 as valid id anymore with your shift, right?
@kennethkoontz Meteor's http package can be used on client and server. http://docs.meteor.com/#meteor_http
Why did you remove these assertions?  Since they seem to work for everyone else, it's safer to first assume there's something wrong on your setup, and that we should figure out what that is.
Can this be pulled then?

On 28 September 2012 16:03, Aranda <notifications@github.com> wrote:

> In MonoGame.Framework/Graphics/SpriteBatch.cs:
>
> > @@ -270,8 +270,8 @@ void CheckValid(SpriteFont spriteFont, StringBuilder text)
> >
> >  			item.Set (destinationRectangle.X,
> >  					destinationRectangle.Y,
> > -					-origin.X,
> > -					-origin.Y,
> > +					-origin.X * (float)(destinationRectangle.Z / texture.Width),
> > +					-origin.Y * (float)(destinationRectangle.W / texture.Height),
>
> Hehe, that's what comes of assuming the variable was a Rectangle just
> because it had the word Rectangle in the name :)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mono/MonoGame/pull/817/files#r1718227>.
>
>
Am I missing something here? This line looks to be doing out of bounds access on an ininitialised array!?
I try not to move code for this exact reason. Also try hard not to change indentation of large code blocks. At least when review is in question.
Thanks for teaching me.  Do you want me to add more commits?
It works! I must have screwed something when I was testing it. GitHub closed PR when I pushed empty branch with FD. I have added it back.
please use OC.filePath('unhosted_apps', 'ajax', endpoint) here to ensure it keeps working if the routing changes
Should this check for `is None` here? Is `0` potentially a valid limit?
Not when I run the tests. It might make sense to move this to the constructor, but I was trying to catch any import of the module so that we can safely remove the whole module when there are no more warnings.
`public subreddit description` ?
This is the duplicate tup() definition.  The real one is in r2.lib.utils
extract is better than validate. I like get. Note that 'get' doesn't imply getters/setters. I'm thinking like TimeZone.getTimeZone. All 'get' means is 'returns a value without side effects'.
Wait... this is MembersInjectorTest... did you not want these tests as they are?  Or did you want two sets - one for getInstance, and the other for inject?
Something like, "To demonstrate ... consider a module that provides..."
On 24/05/2012 09:30, uudashr wrote:
>> @@ -219,7 +219,7 @@ public String connectAndBind(String host, int port,
>>   			throw new IOException("Failed connecting");
>>   		}
>>   		
>> -		conn = connFactory.createConnection(host, port);
>> +		conn = connFactory.createConnection(host, port, timeout);
>>   		logger.info("Connected");
>>   		
>>   		conn.setSoTimeout(getEnquireLinkTimer());
> If the case is we set timeout for 6000 millis
> so the total connectAndBind can be more than 6000 millis.. why? because conn.setSoTimeout was set to enquireLinkTimer (of course the value is non 0)
> You get what I mean?
>
> I think the conn.setSoTimeout(...) should be set to the value of the remaining timeout taken by the createConnection... and when the state is bounded then the conn.setSoTimeout(...) should be set to enquireLinkTimer (set the timeout to normal)
>
> So the total connectAndBind would be no longer than 6000 millis
>
> What do you think?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/uudashr/jsmpp/pull/7/files#r873177
>
Hello,

I think that the timeout which is defined in connectAndBind method is 
totally different from those which is used in setSoTimeout.
The first one is for the establishment of the connection and replaces 
the socket default binding timeout.
The second one is used for requests run on this socket.
When looking at the source code, I see that setEnquireLinkTimer is never 
used, so I think that this second timeout is allways the same and is 
independant from the first one.
Therefor, the time spent during the binding doesn't impact the 
setSoTimeout which is allways the same.

That's my mind
This whole function is unnecessary and should be removed. The natural action of fluid.set automatically creates intervening objects.
Can you split out the ```@Test``` annotations in this Enclosing class, too?
This assumes the indices in '_enabledAgents' and 'agents' match perfectly.  So the set of enabled agents must always be grouped in a contiguous block at the top of 'agents.'  Can we guarantee that's always true?
Right. Anywho, this methods should not exist anymore
Oh, and all Rails helpers get mixed into the same context anyway :trollface:

But seriously, a Rails-based resque-web would be nice.
Ha, ok. I just thought here would be maybe an easier place to put them since the partial values are already there (all that needs to be done is to actually check the content of those 8 values). Also the mode controller does not manipulate any partial values.
Then rename (or simply remove the name of) the "frontend" section. So that is confusing then.
... when #2024 lands. :/
Should do:

var _hScrollbar,
       _vScrollbar,
       _droppable;
How does a user close an editor now? They can't manually, really. If they change any attribute in the editor, a save happens, and if they change the map, a save also happens. How else can they change something without a save happening immediately afterward?
This will need to get updated based on Matt's work, maybe we should just fix that now knowing it's coming?
Should we send back an error? What if we just didn't do anything silently?
Why did you change this? It should be `medium` to cover the spectrum of sizes. Note that it says `max-width` and not `min-width` like the others.
Two 'in'
also, i see only "last_page" handler, where is "first_page" ? :)
To be consistent with [PEP-302](http://www.python.org/dev/peps/pep-0302/), this should return a `bytes` object in Python 3.  I suggest we change it to
```py
return "<usage>".encode('utf-8')
```
First, I declared client events in the client, I moved it here thinking it was not nice to declare these events in the client itself
this is pretty crazy IMO, this ends up doing 2 String.format operations.  1 of these can be avoided by using {} properly.
start to insert
Même remarque.
remove all `/src/Acme` folder
Add 

  s.library = 'xml2'
  s.xcconfig = { 'HEADER_SEARCH_PATHS' => '$(SDKROOT)/usr/include/libxml2' }
Could you remove the commented-out line completely, and put in its place

```Julia
# run this with julia -L extras/test.jl -e "tests(\"test/test_test.jl\")"
```
...which will have to do until scripts can determine how they're being loaded.
We do not deploy repos using Puppet by default. This should be moved to katello-repos package but leave this here and just remove it from main pp file. The same way as in Katello.
What is the problem you are trying to solve here with the requirement for permanent ID's? I believe that this will have the effect of causing duplicate object creation when an object created during mapping by the data source is referenced later in the graph. Pending objects cannot be found via a fetch so they must be manually added to the cache by the data source. We could obtain permanent ID's for them when added, but I have concerns about the performance implications… We are running with the code as is in GateGuru and have not had any issues, so I need to better understand what's happening to necessitate the change.
Shouldn't we ensure that connection is always closed in the end, using try-finally here?
On 15/03/2012 19:47, Ben Francis wrote:
>> @@ -380,13 +380,13 @@
>>                    },
>>                    { // wikipedia
>>                      'installOrigin': 'http://www.wikipedia.org/',
>> -                   'origin': '../wikipedia',
>> +                   'origin': 'http://en.m.wikipedia.org/',
> Really pleased to see this, don't know why it was done this way in the first place.

That's was mostly because of the black background you removed last time. 
It was just before the MWC and time was missing to investigate!
add->update
@mdboom ,  I am still not very good with Sphinx. Would be very helpful if you can tell me where in astropy docs to look for example of linking to a different block of docstring.
I think for each of these types, a web reference to the format's specification/definition would be helpful.
@eteq  Not sure what else to say, other than "The numerical value of this quantity."!
恩，那你重写一下合进去吧~
我当时有想过这个问题，没有仔细深入，我觉得可能可以封装成2层，一层是简单的接口，两个Http::post Http::get就够了，甚至连超时也不要让人去考虑，直接给一个我们认为合适的时间就好（比如我们可以判断一下，内网一个，外网一个），这些东西都让外面的人考虑都是很蛋疼的事情。
另外一层是把option都加进去，提供足够强大的各种配置。
Some of those print removals were an attempt to reduce the amount of output for sims.  As it's most likely to be us running it I'll add it back in.
Perhaps adding a flag in the test metadata or checking the project to see if it == "riak_ee"? Then if it is you could include the replication test.
The random_shuffle was deleted here, but I don't see any calls to randomize the coins selected.  A random_shuffle of the result of AvailableCoins should probably be done so coin selection is unpredictable.

A unit test to test randomness  that calls SelectCoins two times to get (say) 5 out of 100 coins, all of the same value/age, and fails if exactly the same coins are selected would also be nifty.
I think i have seen commits doing the opposite of this and adding the variable.
I think that we should ad that in the viewer.js, @elemoine what do you think ?
ipv4 addresses (and hostnames) should only be printed in Log_KEYS level
Why? Isn't it reusable?
No, we can't subclass unittest.TestCase if we want to use test generators, as unittest does not support test generator.
Ah, OK, I see, it's the prefix for the URL, not for the file location. That's tricky, because it means code in the kernel is assuming something about the HTTP server, which runs against loose coupling. That will take more thought.
But that is my point exactly.  Once a utility is useful enough that multiple modules are using it, it should be in utils.  Just grin for `Bunch` over the entire code base and you will see what I mean ;-)
The whole double-space 'debate' is entirely irrelevant to monospace.  Typewriters (and monospaced text in general) are the reason the double-space rule came into being in the first place.  The 'debate' is about applying a practice meant for monospace inappropriately to variable-width type.
It turned out to be a little more complicated than that.  The existing content already has the console escapes converted to HTML.  So it needs to get that as an HTML string, append the new text with console escapes converted to HTML, and set the whole thing back as an HTML string (not as a raw text string).  See the attached commit that seems to resolve this.
> From: Adrian Cole <reply
>
+p-901015-39ecacda0d6171655508465674ccb8c11350fc06-1453210@reply.github.com>
> To: Kenneth Nagin/Haifa/IBM@IBMIL,
> Date: 30/05/2012 06:57 PM
> Subject: Re: [jclouds] Added container handling methods and tests (#654)
>
> > @@ -48,7 +55,9 @@
> >     public static class Builder<B extends Builder<B>> extends
> CDMIObject.Builder<B> {
> >
> >        private Set<String> children = ImmutableSet.of();
> > -      private Map<String, String> metadata = Maps.newHashMap();
> > +//    private Map<String, String> metadata = Maps.newHashMap();
>
> please remove the lines you comment out, as we can always look at
> source history for what it was.
>
Done
-K
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jclouds/jclouds/pull/654/files#r901015
>
Agree. Every transfer object in the Abiquo api contains a link to the parent, children, and to every action that can be performed against the resource in question. That's why use the EndpointLink and binder instead of the Bind annotation. It is very practical, and will keep the *AsyncApi always working even if an endpoint (or mediatype, or similar) changes in the target Api.

The are pros and cons in this approach, and it would be nice to start a discussion for that in the mailing list for 1.6!
Actually, I wrote this to support applying a relative URL to the repo's default origin URL for implementing submodule "add". Realpath is not going to process URLs correctly.

I believe you that there are a lot of corner cases, but this implements a relatively simple in-place path cleanup that seems useful. I can change the name and the doc to make it clear that prettify is almost surely what should be used for any actual file path (even make it not a path.h fn if you like).
Do we have such a function. I thought we did, but then couldn't find it.
all right please check. If it does exist, good. If not, add it to the top somewhere, like on the article.
I can use "newsletter" instead
You'll want to keep this, and keep a b2g folder in the apps subdirectory with an empty models.py and a urls.py that has the redirects in it. That way it's easy for someone tracking down the URLs to look in the b2g app folder and see the redirects.
Change to `kwargs['config']` since it's not OK for that to default to `None` if it's incorrectly applied.
yeah I think we should use numeric constants and store them in the db as such. this way if the name of the login source changes, we're fine. the number will be permanent.
I don't think we need to throw an error - we can just indicate in the docs that you can't skip field name or field type.
auth**o**r_id
`.on()` requires that the element is is acting on exists in the DOM at the time of binding. If that isn't the case, the solution is to use a more broad selector as the element you `.on()` and then provide a filter selector. So, you'd do the following:

```javascript
$('body').on('click', 'some.selector.here', function() {
});
```
I'm not sure it is a good idea because it wouldn't solve the problem when developers use `ObjectIdentity::fromDomainObject` (same with UserSecurityIdentity) or even the constructor and if they don't know about the proxy issue (which is the case of most developers if the number of GH issues means sth).
or this must be $variant
@nomack84 Symfony writes it without space
It seems that that block isn't that *spaceless*. It still renders spaces, and makes tests fail.
@vicb yes, as ``|length`` uses ``count()`` and collection are countable
t.referencesのところは t.belongs_to ってのもありますね
At the end of this method, we return a `User` which doesn't seem used anymore (see [this link](https://github.com/yammer/sched.do/blob/2a4eeba11c876f91723fc13ffe459f5947f00aef/spec/controllers/yammer_group_invitations_controller_spec.rb#L44))
If `macro_arguments` are in the same bucket as all other identifiers, then we're allowing them to appear in expressions outside macros :(
感谢红艳的细致，这块确实是注释写错了。等正式发出前，我们再review下注释。本次code review当然也要关注。
Why wouldn't that fall into the "if it ain't 3 or 4 channel, and has no marked alpha, fail" rule?
Nuking the _cached_path stuff incoming.
(done, in constructor, in coming commit)
Would be good to clean up this constant from the `Headers` module.
Why are we having to pass logger around btw?
@jbrown event listeners are registered in the object meta, witch means it should be cleared automatically on object destroy
In particular:

``` js
'foo' in { foo: undefined } // => true
```
This should default to an empty string.

```javascript
className: '' // custom CSS class for specific miniTip
Actually, at line #91, "end" is now being calculated *after* the initial return from future.await(). So, this would potentially cause a delay of an *additional* timeoutMillis. And if this behavior actually took affect (i.e. lastInteraction <= 0) the "wait" would basically be a CPU consuming loop.

I asked "Why this change?" because I want to understand if there was some observed behavior that this is trying to correct.
When scale factor is < 2 everything is ok, when scale factor is == 2 viewportSize is 0, when scale factor is > 2 viewportSize is negative. Let's make an example to better clarify:

this is a snippet from onScale:

	double newSize = viewportSize*detector.getScaleFactor();
	double diff = newSize-viewportSize;
	viewportStart += diff/2;
	viewportSize -= diff;

now try to put numbers to simulate a real situation with a big zoom factor (fast gesture, scalefactor 4):

	viewportSize = 100
	viewportStart = 10
	getScaleFatctor = 4
	newSize = 100 * 4 -> 400
	diff = 400 - 100 -> 300
	viewportStart += 300/2 -> 10 + 150 -> 160
	viewportSize -= 300 ->  100 - 300 -> -200	viewPortSize is negative, here the problem!

Now an example with a slow gesture (zoom factor 1.5):					
	viewportSize = 100
	ViewportStart = 10
	getScaleFatctor = 1.5
	newSize = 100 * 1.5 -> 150
	diff = 150 - 100 -> 50
	viewportStart += 50/2 -> 10 + 25 -> 35
	viewportSize -= 50 ->  100 - 50 -> 50	in this case viewPortSize is positive, ok!

Hope this clarifies the problem.

I could try to arrange a more elegant solution with the setZoomLimit, changing the viewport calculation within the limits imposed by the developer. Let me know if you agree.

Best regards,
Marco.
I have a feeling I was confused and my comment was about `buttons`, not `position`. Yes, we should deprecate `String` and `Array` values.
also we need a csrf token
If you put a

    if (!gWifiManager.wps)
      return;

before this line, we can land this pull req before Gecko fix. Thanks!
Don't leave dead code with no reason, please add an explanation or remove it.
// Turn off Bluetooth and Wifi. 
      // Data will be turn off automatically since the radio is off.
remove icons/ from this.  The images are just in images/
Apart from containing '*' and/or '#' characters, USSD numbers need to meet a specific format described in [3GPP TS 22.090] specification document:

<pre>
“1, 2 or 3 digits from the set (*, #) followed by 1X(Y), where X=any number 0-4, Y=any number 0-9, then, optionally “* followed by any number of any characters”, and concluding with # SEND”
</pre>

But I guess it is ok for now to check only for * and #.
weird indentation I don't want to cause you more pain by fixing this kind of nit then needing to merge that back into the other repo but I had to say something :)
Maybe this because i added to init method which called only one time.
And then when the event is trigger when I open the browser, and the event listen is called and it remove itself.
But, the code I added create many event listner for appopen
And function is called many time
so i will try to fix it now
Thanks for the fixing~
Hmm, since I kind of came at this sideways, I hadn't yet quite wrapped my head around the class hierarchy. I think I might take a bit more time tonight and see if I can't refactor this into something cleaner. If this adjustment code only lives in week_child, it won't need to detect the classname either.
Sorry I forgot to mention that pause icon is missing in the PSD file, I took a look at the pause icon of video, but seems the image size is different from the one in music. so I will keep the two vertical bars as pause icon and file a bug.
Here it is: https://bugzilla.mozilla.org/show_bug.cgi?id=802019, thanks.
This should have a label, no? And where's the submit button?
It will automatically convert but shouldn't the default be a string such as `'202'`
Remove the this.
Having code in a debug statement that is necessary for the operation of the function is bad: if we make the `debug` option efficient, that code may never execute!
Sure -f is more specific. We could add a check for -r and -s as well. I'll go ahead and add them.
Talked this over in person and opening new issues to port everything over to Python 2.7 after this sprint.
Is this tags handling routine really working on Sina Weibo, or is it just a relict from SHKiOS5Twitter sharer copy, and should be deleted?
Should we play it safe and implement a backend capability approach similar to k/v? Thus, being able to verify the backend is actually async capable. Or perhaps just use `async_fold` here versus `fold` with some try/catch magic. I worry about a non-async search backend happily folding away here and blocking the vnode, just for the fold to return an accumulator that triggers a badmatch against the async tuple.

Related: the ETS backend is not async and will fail here.
this call was actually broken, as the filename is the 3rd argument
This is ambiguous - most tags & event.tags be nonempty?  or must it be tags?
Do we really want to be returning a datetime from the db layer?
This should be calling `config.error` instead of raising `ValueError`
don't worry about using `inlineCallbacks` - I'll make a sweep through the code before 0.8.7 and rewrite any remaining `deferredGenerator` uses.
The new commit explains a bit more in the post-checkout. I'm pretty bad at writing docs, so assistance would be great!
Yes indeed, will fix
It was already doing it before, and yeah I think it's good to report errors early to users if they messed up their config file, since ArrayLoader doesn't report much.
Why explain the pronounciation here? This is not a detailed discussion of the Rete algorithm, which can be found elsewhere.
Assuming you meant IPV4_IN_IPV6_WRONG_IP_VER, yeah :)
Object#send is a ruby method already defined, consider renaming this method to 'publish' ?
That's to avoid yet another kind of strict JS warning speaking about not being allowed to declare functions inside function declaration.
It looks like we are only creating non-existing URLs here.
`resolve(id, { uri: '' }, baseURI)` will return:
resources://modules/chrome
resources://modules/@loader/unload
resources://modules/@loader/options

Is there any usecase of `modules` Loader argument where we are going to generate URL for existing files?
I'd just use invalid URLS instead: chrome, @loader/unload, ...
Do you mean are not localized ? Lost sounds quite brutal.
Are these intended to be there only for development?
shouldn't leave commented-out lines here, uncomment if needed, remove if not
please not jquery - there are better options ...
https://github.com/zalun/newnewtab/blob/4e794fd1203b855728b61b348e3aeaf67eec3b06/lib/marketplace.js#L89
in the callback of fetching categories
Storing these as JSONFields is interesting. bd
Macro?
One of the reasons I'm excited about your PRs for Gemfiles is that it'll make it easier for us to pull in testing deps. Right now, we have too many places that would need to be coordinated for update to pull it in easily.

On Jul 12, 2012, at 2:31 PM, R. Tyler Croy wrote:

>> +      File.open(file, "w") { |f| f.print "}" }
>> +      Facter.expects(:warn)
>> +      lambda { Facter::Util::Parser.parser_for("/some/path/that/doesn't/exist.yaml").results }.should_not raise_error
>> +    end
>> +  end
>> +  
>> +  if Facter.json? 
>> +    describe "json" do
>> +      it "should return a hash of whatever is stored on disk" do
>> +        file = tmpfilename('parser') + ".json"
>> +
>> +        data = {"one" => "two", "three" => "four"}
>> +
>> +        File.open(file, "w") { |f| f.print data.to_json }
>> +
>> +        Facter::Util::Parser.parser_for(file).results.should == data
> 
> You may find the [FakeFS](http://rubygems.org/gems/fakefs) gem useful for some of these kinds of things.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/puppetlabs/facter/pull/244/files#r1154353
@joshcooper right on.  That's what I get for developing on the bus without internet access... 
standby, updating..
@vrthra return nil
I haven't thought about this in depth yet, and I don't really know the context this is called from, but I worry about exposing ourselves to race conditions here.
Do not use `should_not raise_error`. Compute a value and make an expectation on that value or compute a state change and make an expectation on state.
Agree about the separate method. If I understood you correctly, the `updater` method is not supposed to be overriden by the consumer. Is this right? In my case, I added an extra property to the text field called "data-selected-id", but I'm handling it on my consumer code, not inside typeahead.
You must update the test instead of removing ?
Can you undo this. This will fixed in #1054
no space after opening bracket or before closing bracket, check whole file.
This is really vague to me - I have xcode command line utilities, but I wouldn't have known what to answer to this. It should probably at least say "the Xcode command line tools" and maybe "includes gcc".
Nitpicking here, but in the actual function I don't see `name` as a param.
Don't need regex for this: val().trim() instead
For now that's probably okay but very soon now we are going to need to remove them. Exception emails may contain embargoed information that can't be exposed to contractors.
this fixes a bug, since $nodename can obviously be null
yep your right, that seems the most logical place, though its not driver specific. will update.
This really looks like a big mess (too many nested ifs), which means unmaintainable code in the future. Please simplify the code. The first thing to do may be to move the whole thing to a new function.
how about rearranging this entire for loop into:
`[self.options_groups.remove(y) for x in y for y in optgrp.options_list  if not x.htlp == nohelp])`
or something along those lines :-p
remark: in Ruby, Strings that can be interpolated are " " and others are ' '. We could adopt this?
Good idea ;-) I have changed code a bit should be good now =)
I think you can remove the EAP stuff from here, as this is now just a general facility.
Actually, yeah, that would make more sense. Also, I should have done `getHostname()` instead of `getHost()` anyway. Thanks.
Oh, if this is a new variable, we'll need to add it to hook_uninstall :)
These can be more human readable they are for developer eyes only.
nit: indent to align with 'facebook.banners.share'.
`localhost:8000`
`!important` is best avoided, though some of this might be my fault. Can we clean it up?
missing the "_locator" suffix and also add a whitespace after ,
Ok, it should be done... not sure what happend in Travis though.
Committed a fix
The `, 4` here is unnecessary (and confused me because I forget how the second argument to slice works – just `slice(1)` works for chopping off the first element.
Might be better to re-use [ObjectUtils](https://github.com/ModeShape/modeshape/blob/master/modeshape-common/src/main/java/org/modeshape/common/util/ObjectUtil.java)??
You can pass an additional options hash when defining an attribute

```ruby
attribute :vagrant_vm_forward_port, default: Hash.new
```
in order to use pretty_print_dict and to not have problem of concatenation of string
value引数に渡された値がリストのソート済みの順序を保持できるようにインデックスのどの位置に挿入されるべきかをバイナリサーチを利用して測定します。*iterator* が渡された場合、渡した値を含めて、それぞれの値のソート順序を算出します。
Parts it is!
Why always write the full namespace ?
Curious, why did you move these out of the VCR block?
Yep, I think you're right.
OK, changed the main index partial to "badge" so could just "render @badges".

Changed the one from the profile to "player_badge".
The idea of having a client is so that the access_token is stored by the gem itself and the programmer doesn't access other modules directly. So, I think it should be implemented a search method on the Client class, which would call the MercadoPago::Collection.search method.

It would be something like this on the Client class:

```
#
# Docs...
#
def search(hash)
  MercadoPago::Collection.search(@token, hash)
end
```

My suggestion is to implement this method on the client and refactor this test. It would also be nice to add some documentation for this method on the README.md.
The patches to this file are confusing: we are looking for \r\n, so the equality check on buf->data[xxx] should be either on \r or \n, but not both.
Good point by Bebe, in `test_user_accounts` there are explicit tests for each login method so test coverage is focussed there.
why would that help?
i put that there to leave a clue in the output as to why the test is failing. originally i put a
assert not 'My Profile' in menu_text, "ActionChains is being flakey"

it is there because if always-supposed-to-be-there 'My Profile' isn't in the menu, then the ActionChain has returned an empty answer and the method isn't actually capable of saying whether 'My Favorites' is in the menu.
In my opinion, a message is not a success unless the headers and body are correct (i.e. content length matches content size).  So the default should probably be false and set to true upon a good MessageComplete().  Which I leave as abstractly defined, because I'd need to look up the exact case.
Only that my OCaml foo is very weak and I couln't figure out how the get the xml node that you have to pass to that function....
So no real reason, feel free to "fix" this to reuse alt_unit_coef_of_xml
Sure, *now* it won't. Do you trust the future that much?
Should use the commentId.
Is this necessary? Wouldn't the beforeEach function take care of this?
Would the underscore implementation be more robust?
Should be User
It's a fake test (explained in the comment above). I am testing that this class is *not* returned by the test finder. 

It mentions `@Test` in the comment, so search might be tricked by that.
This looks very dangerous and breaks really quickly. Whenever a module adds a new attribute this will fail. I think we need a concept to distinguish between table-data-fileds and aggregated fileds added by modules for programmatic use. I think this belongs into the `Table` class.
Someone should write a comment to broken tips

  http://forum.dokuwiki.org/post/30675
  http://www.dokuwiki.org/tips:pdfexport:htmldoc
Ok I'll see what I can do with the ioloop. I just went with the simplest way to add this feature.
Я не понял фразу "можно не фильтровать exclude на символы в arrayOfChars" — можешь другими словами обьяснить ?
Про побочный эффект я все понял — ты прав. Но только тогда нужно будет название функции придумать другое, которое бы соответствовало двум разным действиям - генерации случайного и замене. Есть варианты, как назвать ?

А чтобы сделать ее функцией класса я должен поставить знак +, так ? И какой профит будет от этого?
я думаю проще и лучше было бы обойтись свойством
Согласен, сократил код в новом коммите
О! 
не знал
для данного проекта - не страшно. Вопрос скорее для меня (нету, блин, mac/xcode), сам, как бы, задумался, что здесь будет возвращаться - каждый раз указатель на новый объект или на какой-то один константный.
не читается красивенько! :)) поубирай тут page, 
    
    it { should have_selector('#edit') }
You are seriously missing some curly braces here. This shouldn't even compile.
curly brace starts on new line for classes, interfaces and function declarations only. `for`, `if`, `while` etc have opening curly brace on the same line after a space:

```php
<?php
if (...) {

}
```

please fix and I'll merge this, thanks!
I.e. Anywhere but in the top level, my vote. Perhaps under geoView/*, because it is strictly used in that. ?? I know, I'm being slightly nitpicky.. :-P
This method was never called. What was it used for?
Stackster prints out the error message, so I don't capture it in simple deploy
Almost - I would suggest one of the following tweaks:
  1) Put the size check before we allocate the byte array. Looking into this more, I suspect that attempting to allocate an array larger than int.MaxValue will throw anyways (at least with default settings).
  2) Keep the int on the method signature (as it the method does not handle anything larger than an int) and force callers to provide an int. I think there is only one caller - the Content property in Blob.cs
I don't have the bug my brain python parser sees it :)

you miss the string formatting argument :)
This is part of the reason I added the array=True argument to compute_morph_matrix (although I think it will be useful in other applications as well), but I'll change it here for clarity...
Capitalize the F in for
default to {} instead of nil, so that you don't have to check for nil later on.
Just leave it verbose then
i think `5.seconds` would be a nice change here.
Done, this title seems to be ok.
Mention here that this option is required
Why this check here?
This needs to be updated to latest master: this(settings: ActorSystem.Settings, config: Config)
What's the logic here?
done.. sorry...

Le 30 avr. 2012 à 15:16, Jacques-Olivier Lachaud a écrit :

>> + *  it under the terms of the GNU Lesser General Public License as
>> + *  published by the Free Software Foundation, either version 3 of the
>> + *  License, or  (at your option) any later version.
>> + *
>> + *  This program is distributed in the hope that it will be useful,
>> + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + *  GNU General Public License for more details.
>> + *
>> + *  You should have received a copy of the GNU General Public License
>> + *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
>> + *
>> + **/
>> +
>> +/**
>> + * @file testNormalVectorEstimatorEmbedder.cpp
> 
> Bad file name.
> Bad group
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/DGtal-team/DGtalTools/pull/2/files#r750479

----------------
David Coeurjolly - Directeur de recherche CNRS
CNRS, LIRIS-UMR 5205
Université de Lyon
Batiment Nautibus
43 boulevard du 11 novembre 1918, 69622 Villeurbanne cedex, France
Tel : (+33) [0]4.72.44.82.40  Fax : (+33) [0]4.72.43.15.36
http://liris.cnrs.fr/david.coeurjolly
Is it possible is use either vms.utilitiles.call_command or vms.utilities.check_command?
:mind-blown:
Or with `and`:
~~~clojure
(and (not (empty? coll))
    (empty? (rest coll)))
~~~
Don't you need to check here if write skew check is enabled?
Can you join these two lines ?
Sanne, Ok.
Was this the real bug?  That you were using hashes.length (== servers2Hash.size()) instead of positions.size() in the original code?
Well, this is an OR'ed together combination of values - is that an issue if you make this a `GTDiffFileFlag` directly? I know that inside libgit2, when we have a typedef'ed enum, we tend to use the type name only if the expectation is that you will just use a single value from the enum. If you are going to use an OR'ed together set of bits, we tend to use an unsigned int of some sort.

In this particular case, it may be moot. These particular flags are mostly just used internally to libgit2. I think you could probably get away with leaving them out of the bindings completely at no significant loss of functionality. (E.g. do you really care whether the file was mmap'ed vs loaded into malloc'ed memory when you are looking at a diff? I suspect not.)
This changes the meaning if the print statement is uncommented. Could just remove the print statement...
@dmcdougall was this ever created?
wouldn't we only want to do this for 'log'?  Also, since bins is a list and the operation is just a simple filter, let's go with that route.

Add a comment for the rationale for the filtering and also for the 0.1 multiplication.
Typo: WiFI/WiFi
on my device the test stops here and nothing happens 
Might be because it's a hacked one
Thanks. The only reason I used `renfoncement` was for want of a better word, and when I checked `indentation` I saw it didn't exist.
I'll use that now.
I don't know but this sounds like a complement :-)
to make the code better readable pack !registrationprocess.Equals(ERegistration.REGISTERED) into isNotRegistered(registrationprocess) method or something similar
According to the DTD, `documentation` is also an array. And the `xml:lang` attribute is optional. So what about using a structure like

    documentation: [{
        lang: 'en',
        textContent: 'foo'
    }]
I think it doesn't hurt and the cotrols should be usable even when added directly to a map and not via a panel.
This does not look like a real cache. It only stores a single graphic, and creating a new image is only avoided if the same graphic is used by subsequent features. Or am I missing something?
There is nothing in the PSRs which limits the casing of Vendor Names. Relevant portions:

> * Each namespace must have a top-level namespace ("Vendor Name"). [PSR-0]
> * Alphabetic characters in vendor names, namespaces, and class names may be of any combination of lower case and upper case. [PSR-0]
> * This means each class is in a file by itself, and is in a namespace of at least one level: a top-level vendor name. [PSR-1]

No PSR after PSR-0 limits the formatting of Vendor Names, so only the qualification of "may be any combination of lower case and upper case" exists. As such, I believe `PSR` is the best Vendor Name for use in PSRs.
There is no mention of acronyms in any PSR; the only thing stated is "Class names MUST be declared in StudlyCaps" (which is never defined). No examples include acronyms.
actually, these lines were fine already
@mgutz Bumping again.
I remove this feature at the moment and when I can I add.
Previously, the group profile was passed into this widget through the event. I'd like to continue doing that instead of reverting back to the global.
@christianv and @bp323 I have resolved the bug.... Now i know the alphabet ;-)
ok, merging
I guess we need to provide another load routine in dense features - but later.
These are some large changes to the way CheckboxField is rendered. It changes a lot, so if we merged it in it'll break people's styling when they upgrade.

Could you explain why this is necessary, considering your pull request is to get 2.4 working on your web server? I don't see how these are related.
What exceptions are we catching here? Are they really Kohana_Exceptions? not just Exceptions? or something else from the DOM classes?
Are you sure ``true`` has the correct type as "Boolean" is not a sub-type of "string"?
Is it possible to define the element type for the returned array (using ``array<SomeType>``, or ``SomeType[]``)?
I'm imagining that it smells like Old Spice
`[asd](optoinal blabla)` is rendered as a broken link.
On 05/22/2012 01:38 PM, Diego Zamboni wrote:
>> +    #  cf-agent -D superdupermop -KIf ./test.cf
>> +    # this reports even when not run but it shouldnt
>> +    # Maybe I am doing something wrong, maybe isvariable doesn't work with module set variables
>> +    "check[check_dummy_DONTRUN][plugin_name]" string =>  "check_dummy";
>> +    "check[check_dummy_DONTRUN][args]" string =>  "0 Test ok";
>> +    "check[check_dummy_DONTRUN][_usebundle_if_ok]" string =>  "bundleifok";
>> +    "check[check_dummy_DONTRUN][_execution_context]" string =>  "superdupermop";
>> +
>> +
>> +    "check[check_dummy_WARN][plugin_name]" string =>  "check_dummy";
>> +    "check[check_dummy_WARN][args]" string =>  "1 Test warn";
>> +    "check[check_dummy_WARN][_usebundle_if_warning]" string =>  "bundleifwarn";
>> +
>> +    "check[check_dummy_CRIT][plugin_name]" string =>  "check_dummy";
>> +    "check[check_dummy_CRIT][args]" string =>  "2 Test critical";
>> +    "check[check_dummy_CRIT][_usebundle_if_critical]" string =>  "bundleifcritical";
>
> I see. Not sure if it would work like this. What could work is to define another element that contains the argument to pass, and then pass it using a technique similar to the one shown here: http://cf-learn.info/code/ch05/unit_method_var2.cf.html, something like this:
>
>      "warning" usebundle =>  $(mycheck[$(check_handle_index)][_usebundle_if_warning])("$(mycheck[$(check_handle_index)][_usebundle_if_warning_arg])"),
>        ifvarclass =>  "$(check_handle_index)__usebundle_if_warning_defined";

Yeah I considered having two different usebundle promises classed 
inversly on the presence of the _usebundle_parameter_if_critical etc .. 
if it was defined but that just seem to complicate things. It can always 
be added. I thought that requiring a parameter for the bundle was a 
little heavy handed.