[EFL] [DRT] media/media-document-audio-repaint.html needs rebaselining after r117326
https://bugs.webkit.org/show_bug.cgi?id=86839

Unreviewed gardening, EFL rebaseline after r117326.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-18

* platform/efl/media/media-document-audio-repaint-expected.png:
* platform/efl/media/media-document-audio-repaint-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Yet another unreviewed build fix on r117572, this time for wk2...

* WebProcess/WebCoreSupport/WebEditorClient.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[V8][Refactoring] Remove V8Proxy::throwError(const char*, ErrorType, v8::Isolate*=0)
https://bugs.webkit.org/show_bug.cgi?id=86802

Reviewed by Adam Barth.

As commented here (https://bugs.webkit.org/show_bug.cgi?id=84074#c5),
I am refactoring a series of confusing throwError()s. This would be
the final patch for the refactoring.

This patch removes V8Proxy::throwError(const char*, ErrorType, v8::Isolate*=0).
Also this patch refactors up a couple of throwError()s that I've forgot to
refactor in the previous patches.

No tests. No change in behavior.

* bindings/v8/V8NodeFilterCondition.cpp:
(WebCore::V8NodeFilterCondition::acceptNode):
* bindings/v8/V8Proxy.h:
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBuffer::constructorCallback):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray):
* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
(WebCore::V8SQLResultSetRowList::itemCallback):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt][WK2] Cleaning skip list. Unskip passing tests.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-18
Reviewed by Csaba Osztrogonác.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: remove unnecessary indirection from profile types
https://bugs.webkit.org/show_bug.cgi?id=86845

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced CSSProfileHeader and CPUProfileHeader, moved view creation from
the type to corresponding profile headers. Removed some inderection and
private fields assigned in random places. Added type annotations.

* inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileType.prototype.createTemporaryProfile):
(WebInspector.CPUProfileType.prototype.createProfile):
(WebInspector.CPUProfileHeader):
(WebInspector.CPUProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.CPUProfileHeader.prototype.createView):
* inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSSelectorProfileType.prototype.stopRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype.createTemporaryProfile):
(WebInspector.CSSSelectorProfileType.prototype.createProfile):
(WebInspector.CSSProfileHeader):
(WebInspector.CSSProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.CSSProfileHeader.prototype.createView):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotProfileType.prototype.createTemporaryProfile):
(WebInspector.HeapSnapshotProfileType.prototype.createProfile):
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.HeapProfileHeader.prototype.createView):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype.saveToFile):
* inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView):
(WebInspector.ProfileLauncherView.prototype.addProfileType):
(WebInspector.ProfileLauncherView.prototype._profileTypeChanged):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileType):
(WebInspector.ProfileHeader):
(WebInspector.ProfileHeader.prototype.profileType):
(WebInspector.ProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.ProfileHeader.prototype.existingView):
(WebInspector.ProfileHeader.prototype.view):
(WebInspector.ProfileHeader.prototype.createView):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
(WebInspector.ProfilesPanel.prototype.showProfile):
(WebInspector.ProfilesPanel.prototype.getProfiles):
(WebInspector.ProfilesPanel.prototype.findTemporaryProfile):
(WebInspector.ProfilesPanel.prototype._searchableViews):
* inspector/front-end/View.js:
(WebInspector.View._assert):

LayoutTests:

* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: exception in console when pressing % button in CPU profile view
https://bugs.webkit.org/show_bug.cgi?id=86849

Reviewed by Pavel Feldman.

Use root node to get children, not DataGrid object.

* inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileView.prototype.refreshVisibleData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Deflaking http/tests/security/contentSecurityPolicy/script-src-redirect.html
https://bugs.webkit.org/show_bug.cgi?id=86433

Patch by Mike West <mkwst@chromium.org> on 2012-05-18
Reviewed by Adam Barth.

As it turns out, this was a straightforward typo on my part. Loading
the wrong JS file is a surefire way to break tests. I've rewritten the
test function to make it more difficult to make such a mistake in the
future, and pushed that change to source-list-parsing-* tests that use
the same methodology.

* http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/resources/source-list-parsing-base.js.
(test):
(finishTesting):
* http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
* http/tests/security/contentSecurityPolicy/script-src-redirect.html:
* http/tests/security/contentSecurityPolicy/source-list-parsing-01.html:
* http/tests/security/contentSecurityPolicy/source-list-parsing-02.html:
* http/tests/security/contentSecurityPolicy/source-list-parsing-03.html:
* http/tests/security/contentSecurityPolicy/source-list-parsing-04.html:
* platform/chromium/test_expectations.txt: Unskipping.
* platform/mac-lion/Skipped: Unskipping.
* platform/gtk/test_expectations.txt: Unskipping.
* platform/efl/test_expectations.txt: Unskipping.
* platform/qt/Skipped: Unskipping.
* platform/mac/Skipped: Unskipping.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Text input events are emitted for nodes that do not allow editing.
https://bugs.webkit.org/show_bug.cgi?id=86836

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-18
Reviewed by Kenneth Rohde Christiansen.

Text input events are not anymore emitted for nodes that do not allow editing.
This can be checked with fast/events/key-events-in-input-button.html test output.

* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::handleEditingKeyboardEvent): Returns false if the node cannot edit.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: live edit resets cursor to 0,0
https://bugs.webkit.org/show_bug.cgi?id=86851

Reviewed by Vsevolod Vlasov.

* inspector/front-end/DebuggerResourceBinding.js:
(WebInspector.DebuggerResourceBinding.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed. Remove console.error() call committed by mistake.

* inspector/front-end/View.js:
(WebInspector.View._assert):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: empty CSS Declaration is generated by clicking the left space of 'user agent stylesheet' on Styles sidebar of Elements panel
https://bugs.webkit.org/show_bug.cgi?id=86850

Reviewed by Yury Semikhatsky.

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype._handleSelectorContainerClick):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Unreviewed gardening, skipped list cleanup.

* platform/qt-4.8/Skipped:
* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Add shortcut to dump Security Origin and Web Database information
https://bugs.webkit.org/show_bug.cgi?id=86521

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-18
Reviewed by Gustavo Noronha Silva.

Added key combination (CTRL+s) to dump information about the
security origin and databases of the main frame. Useful for API
testing and debugging.

* EWebLauncher/main.c:
(on_key_down):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION (r102553): Smart links do not work
https://bugs.webkit.org/show_bug.cgi?id=85463

Source/WebCore: 

Reviewed by NOBODY Ryosuke Niwa.

To fix the regression of smart links, we need to check TextCheckingTypeLink option in
Editor::markAndReplaceFor().

Test: editing/inserting/typing-space-to-trigger-smart-link.html

* editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):

Tools: 

Reviewed by Ryosuke Niwa.

Add LayoutTestController::setAutomaticLinkDetectionEnabled().

* DumpRenderTree/LayoutTestController.cpp:
(setAutomaticLinkDetectionEnabledCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setAutomaticLinkDetectionEnabled): Set automatic link detection enabled.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.

LayoutTests: 

Reviewed by Ryosuke Niwa.

Add a new test for testing the smart link.

* editing/inserting/typing-space-to-trigger-smart-link-expected.txt: Added.
* editing/inserting/typing-space-to-trigger-smart-link.html: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/qt/Skipped:
* platform/qt/test_expectations.txt:
* platform/win/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Unreviewed gardening.

Unskip test after r117218.

* platform/efl/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt][WK2] fast/events/page-visibility-iframe-move-test.html fails
https://bugs.webkit.org/show_bug.cgi?id=86731

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-05-18
Reviewed by Simon Hausmann.

Source/WebKit2:

Set the page visibility on a single page instead of on all pages
from the page group.

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetPageVisibilityState):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setPageVisibilityState):
* WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):

Tools:

Set the page visibility on a single page instead of on all pages
from the page group.

* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setPageVisibility):
(WTR::LayoutTestController::resetPageVisibility):

LayoutTests:

Unskip fast/events/page-visibility-iframe-move-test.html.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Add results for compositing tests dependent on scrollbars thickness.

Reviewed by Csaba Osztrogonác.

Qt's QStyle scrollbar theme has a scrollbar thickness of 16px while
the standard results expect a thickness of 15px.

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Return TRUE for events handled to avoid their propagation.

Reviewed by Gustavo Noronha Silva.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseButtonPressEvent):
(webkitWebViewBaseButtonReleaseEvent):
(webkitWebViewBaseScrollEvent):
(webkitWebViewBaseMotionNotifyEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK] Allow to attach/detach the inspector in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=86823

Reviewed by Gustavo Noronha Silva.

Also rename WebInspectorGtk.cpp as WebInspectorProxyGtk.cpp since
it implements the platform specific methods of WebInspectorProxy.

* GNUmakefile.list.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseContainerAdd): Allow to add a WebView containing
the inspector as an internal child.
(webkitWebViewBaseContainerRemove): Check whether the widget
removed is the inspector web view.
(webkitWebViewBaseContainerForall): When includeInternals is True,
add also the inspector web view if it's present.
(resizeWebKitWebViewBaseFromAllocation): Allocate space for the
inspector web view if it's present.
(webkitWebViewBaseSetInspectorViewHeight): Private function used
by the inspector proxy to set the height of the inspector web
view.
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
* UIProcess/WebInspectorProxy.h:
(WebInspectorProxy): Remove unneeded method windowDestroyed.
* UIProcess/gtk/WebInspectorProxyGtk.cpp: Renamed from Source/WebKit2/UIProcess/gtk/WebInspectorGtk.cpp.
(WebKit::inspectorFilesBasePath):
(WebKit::inspectorWindowClosed): Renamed as inspectorWindowClosed
instead of inspectorWindowDestroyed, since this is called when the
window manager requests to close the window, and not when the
widget is destroyed. Also remove the call to windowDestroyed that
has been removed.
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::createInspectorWindow): Helper
function to create the inspector window and add the inspector
view. Also set the inspector window as transient for the
inspected view toplevel window. And use a weak pointer to make
sure inspector window pointer is NULL when it's destroyed, not
only when the window is closed.
(WebKit::WebInspectorProxy::platformOpen): Call platformAttach if
the inspector is opened attached, or createInspectorWindow
otherwise.
(WebKit::WebInspectorProxy::platformDidClose): Always set the view
inspector pointer to NULL.
(WebKit::WebInspectorProxy::platformBringToFront): Implement it by
showing the toplevel window where the inspector view is contained.
(WebKit::WebInspectorProxy::platformIsFront): Implement it by
checking whether the toplevel window where the inspector view is
contained is active or not.
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Return
early if there's no inspector window.
(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight): Return
the height of the inpected view.
(WebKit::WebInspectorProxy::platformAttach): Remove the view from
the current window if there's one, and insert the inspector view
into the inspected view.
(WebKit::WebInspectorProxy::platformDetach): Remove the inspector
view from the inspected view and create a new window for it if
it's visible.
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): Call
webkitWebViewBaseSetInspectorViewHeight().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
fast/events/mouseup-from-button2.html needs a specific expected file for Qt
https://bugs.webkit.org/show_bug.cgi?id=86783

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-05-18
Reviewed by Csaba Osztrogonác.

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/fast/events/mouseup-from-button2-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117596 268f45cc-cd09-0410-ab3c-d52691b4dbfc