labofsahil/github-event-dataset-2012 huggingface dataset:
Can you make sure this code does not run when the application is on the background? (when it receive a visibilitychanged event with hidden = true)
Same here.

You are welcome to introduce Chinese-specific symbol/alternative layouts as many as you want, but changing the global alternative keyboard requires green light from UX.
zombie code, can be safety removed
only if error is zero always, but I'll add the if  > 0 else nan condition
Same here. Also, more 1.8 hashes. Neither a big deal obviously, just noting.
The result stays DB_LOAD_OK here, so in case of corruptions in non-key/tx records, it silently continues also with the upgrading below at line 458.
Is this desired behavior? 

Or should we set some flag, log a message and show a popup to the user (`uiInterface.ThreadSafeMessageBox`) at the end of the function that recovery has taken place and that some wallet data (such as address book entries) might be corrupt?
source.string().c_str(), etc. if you want to be compatible with older filesystem boost lib.
No, I mean the db headers seem to assume you're using auto tools. Since that's a (previously un-codified) req for building the rest of bitcoin any how I don't see how it hurts to just define it like we do the boost threading defines.
In English both words mean the same, just different spelling
2 blank lines required here :)
this looks like the wrong interface
Awesome.  That is good to know.  It is super handy to be able to make these changes and just watch to see if the tests are still passing (I am behind the times!).  Thanks for reviewing all of this Craig.
Maybe use `!file.exists(Sys.which(git_binary_name))`? Otherwise, will users need to specify the full path?
embedding is assumed
No, in this case it has to go into the constructor, because this one plays a special role: it is the empty placeholder for user-defined magics.  There's only one of those, and we need it to be there from the start so that the registration of user magics is possible.  So I think the constructor is the right place for it.
self.exit(1), I think
This was basically #2269, no?  I'm confused as to why the duplication, since you'd indicated that #2269 should be done first, then I figured you'd base it off that...
Let's call this `hub`.
I don't think the if/else logic is right here.
Well, I think the point is to consider common sense, even when it leads to a bit of variability: as pep8 also says ("A Foolish Consistency is the Hobgoblin of Little Minds"), it's important to be flexible with rules, and to know when it makes sense to break them.  Ithinkwecanallagreethattypingthiswayisnotagoodideaevenifitwouldmakeforveryconsistentposts.  Right?

IPython used to have underscores and in 'the big refactor' I think all new files ended up without underscores.   I was so focused on moving forward with the work at the time, and we had so many bigger fish to fry, that I didn't want to worry about this issue at the time (perhaps I should have).  But I think it's important that we don't become slaves to prescriptive rules: pep8 was explicitly written for a multi-author open source project, and I think it's by and large a good balance of rules and common sense.

In my mind, a reasonable cutoff point is somewhere around 8 letters or so: anything longer than that can probably benefit a lot from a well-placed underscore, a very short two-word filename would be OK.

In summary: I can let this one go, but I won't let go of the notion that common sense should prevail over blind allegiance to rules.
present if server supports the diagnostic command
hmm.. we need to move this to providers/aws-ec2, right?
For parameters that are given back to the callback, the convention is to call that `payload` or `callback_payload`.
Looling at [WCAG guideline 2.4.4](http://www.w3.org/TR/UNDERSTANDING-WCAG20/navigation-mechanisms-refs.html) it might be better to describe the link a bit better, especially when there is multiple links with the same link-text. 
`<a href="..." class="button-sand"><span class="hidden">Icon (circle) template as </span>PSD</a>`
pyflakes kept flagging the "space after =" thing which is a pep-8-ish issue. I cheat here and just stick a ( around it which doesn't do anything, but it does make pyflakes stop whining.
Cool. :satisfied:
I like that test. It's got a nice incremental approach to it.
Factor out into a method somewhere.
that looks like an error to me.  This class should pass the `quit_check_callback` to the parent class, not override it.
true, It will get messy though.Those settings belong to the blog module after all. Where would you suggest writing them?
I think this is very important. The tags mark our public, guaranteed API. It's really important to tell people if we change that API.
Ok. I looked into the CollectionType class. What I actually need is the ResizeFormListener.
Would it be ok to create my own Listener (say, TranslationFormListener) which extends from ResizeFormListener, move my custom logic for PRE_SET_DATA there and extend TranslationCollectionType from AbstractType?
Just my anal-retentive nature. Can be removed if required for merge.
Agreed. I also wonder if it shouldn't just transliterate or ignore those non-ASCII characters when no fallback filename is explicitly provided. Unless the developer does this, it means that every malformatted filename will potentially prevent files from being downloaded.
There is a big difference: storing something in volatile memory is not as dangerous as storing it to disk. This is why every desktop shell implements some form of keyring and this is why Oauth and tokens exist.

I do not consider this a blocker for a merge and you can leave it as it is, however it is bad design. I do agree that we need not preoccupy ourselves with security issues.
what's notify_fifo ?
How about using the local variable "user" defined up there?
set `sharedHandler = nil` in declaration, test for it in `if` and you don't need `initialized` variabel. But this is ok too.
this especially was a big win in responsiveness as the map seems to need to load its tiles before it will push.
I've seen this all over the code base. Why do we always take the last message? What if more than one thing is invalid?
Can do this in one line:
`self.update_attributes(has_logged_in: true)`

Since you made it `default: false` in the model, this works nicely.
man injori zadam va mese mard kar mikone
```
fixed top bottom
region label
Don't do `self.logger.exception('string' % arg)`, but instead `self.logger.exception('string', arg)`. This will still apply `arg` as a formatting argument, but will do so only if the log level is high enough that this exception will ever be logged anywhere; otherwise, it avoids needing to do the formatting operation and is thus faster to run.
Will these end up being used? If not, would you mind removing?
Right, obviously. Fix pushed
I agree with the lack of consistency but I'm not sure about what you mean. 
Do you mean the following actions :

* keep a `$ignoreVisibility` parameter in each `eZTagsObject` method (and add one to the plain `fetch`)
* Set the value according to ini file if parameter is null
* Add the `ignore_visibility` param to each fetch function

Did I get it right ?
Do you know of a specific case where this test is necessary?  We should never be assigning $item to something that's not an Item_Model.  If it's not necessary, drop the conditional
This should be in the css instead of the js.  No real reason to have styling in js.

```css
span.img_expanded {
   max-height: 300px;
   max-width: 300px;
}
```
no newline here, should be `} else {`
я не думаю, что нужно точно следовать maxLength, потому что внезапно окажется `&` преобразуется к `&amp;`  и придется еще их учитывать

подумаешь плюс минус десяток символов
This will conflict with `hidden` attributes. Please use something like:

```css
.block-items li:not([hidden]) {
  display: inline-block;
}
```

(the rest can go in a simple `.block-items li` rule, of course)
If longPress === false, and another tap event for a key that's supposed to play sound comes in within this 100ms, couldn't we cancel the new tap series?  (Users can easily press keys at more than 10Hz.)  Need to address this in a followup.
This code was written for gaia initially, so you guys are really the upstream here.

Metadata from Gecko is tracked in https://bugzilla.mozilla.org/show_bug.cgi?id=763010, hopefully ogg.js may be an acceptable polyfill while waiting for the Gecko implementation to happen.
Somewhere in the project I saw a comment that we shoudn't use 'forEach' because it's much slower than 'while' or 'for', I'm not sure if it's still valid (I personally prefer 'forEach', but I don't use it because of that)
What about this.isDisabledDrop = this.transitioning at the end of the if/else simply?
I am running out of ideas on the variables also :( But the spec does states "LINE 1" and "LINE 2" :P
I was meant to point out that internal `stop` function should be also renamed to `kill`, but I figured out your push here didn't cause that.

Use your own judgement to decide if you want to rename `stop` altogether.
The name i-add does not tell me much. toolbar-add ?(and add a space between add{)
Probably should put brazil here
Hope you don't mind me making a few comments....

Why not `function unlock() {` ?
Ups, sorry, I kind of missed that. Including it... ;-)
I actually like the default error messages from assertContains. There are a few error states, and all this assertion allows you to provide is a prefix to whatever message it'll provide. 

https://docs.djangoproject.com/en/1.3/topics/testing/#django.test.TestCase.assertContains
conf comes before core
Why is this in Portuguese?
writing that as a one-liner `after_create { StatisticsTracker.ghost_created }` seems clearlier to me. I will change that :)
Yep, that's right, I've overdone it a little bit :)
I don't like the name "translation" because that implies (to me at least) that the scratch is a target rather than a source.
what does the g prefix stand for?
The later one is best I think, thanks
friendly semi-colon reminder :)
Yeah I agree that `arr` isn't the best. But I'm worried that `image` might be confusing if we have an `Image` class. How about `data`? On the downside, `data` is a little too general, but on the upside it would mirror the `data` attribute of the image class (which fits well with having e.g., `mask` as an input) hopefully making clear that this input is a simple array, not an object representing many things about the image.
these lines are not unneccesarry to add the gitignore file, you can such ignores to a global ignore
This function is implemented here https://github.com/cocos2d/cocos2d-x/blob/gles20/cocos2dx/platform/ios/CCFileUtils.mm#L180
@minggo Yes, that is correct.
This is explained in the official wiki of OpenGL's website: http://www.opengl.org/wiki/GLAPI/glBlendFuncSeparate#Description
haha, glad you pointed that out. The problem isn't that the variable shouldn't exist, it should be used again in the format.json block, I'll update that with the next commit
Doing a `<%= link_to t('cancel'), root_path, :class => "button" %>` should be enough :)
whitespace inconsistent
I've removed that part. I never meant to include it upstream, as the EMS implementation needs a second USART, which isn't present on NetIO out-of-the-box with its Atmega32 (I'm using an Atmega644p).
Should this not be a map of these strings looping over the render function??

I suppose it's same same, but to me feels cleaner?
Anything we can do about the competition names being in code here? They can change over time as sponsors change.
event.sprintf("%{+YYYY-mm-ddTHH:MM:SSZ}") or something
Why is the model optional here when it is required for other components?

Also, if the optionality of the model parameter is intentional, it should be documented.
why the traceback stuff?
Would [`NetUtils.asyncFetch`](https://developer.mozilla.org/en-US/docs/JavaScript_code_modules/NetUtil.jsm#asyncFetch%28%29) not be more simple?
Is the idea to log the user out if checkEmailIssuer returns null?
I do not like throwing an error here, it is a terrible user experience.  If there is a problem with BigTent, the address should be treated as a secondary.  Right now if the BigTent server is unavailable for any reason (network outage, etc), the user is presented with an ugly error screen instead of gracefully degrading to a secondary.
Mind adding a comment which explains what are doing here? I don't know SM that well, so it's hard for me to read that from the code.
So we need session_start() even though its redirecting,right?
`alsways` => `always`
This needs to go in a fixture file in an appropriate module scope: http://rubyspec.org/style_guide/
Correct, there is no mysql running on the CI server, so these tests fail if executed in CI.
above you change if to have explicit brackets. I think that especially in case where is multiline command it is nice to enclose it also in brackets for better readability
You shouldn't change nothing in Code TestAssets, could change the behavior of the tests
We are not using the global prefix for constants,
Um, Traits? We're not using traits in any core ZF2 functionality. Do you mean Closures?
This was done by php-cs-fixer. My best guess is that it's aligning the variable up with the "next argument" due to the next line: @throws Exception\InvalidArgumentException. 

Looking through the code changes, php-cs-fixer seems to line up all the argument lists.
I don't see the reason for doing this, instead of simply using array callbacks where needed in the code. Can you explain, please?
IIRC this project is not maintained anymore. So till we don't replace it with something this needs to be locked on `beta1`.
I introduce new private method because I was need to avoid copy/pasting. This method also used in another place.
If its important that this inside the div you need to test that.
where's a null coalescing operator when you need one?
So these are all to be handled in `hasField()`?
hm, what does this do anyways? what is the semantics of child without a node name? randomly pick one child, or the first one? maybe we should remove this property?
Try to remember to start class references in phpdoc blocks with \.
extra fancylogger is not needed. (from vsc import fancylogger e.g.)
These strings should actually be defined somewhere publicy in toolkit.py
I added an issue so we remember when it's complete
We don't, but neither does youtube.

http://www.youtube.com/watch?v=nfGV32RNkhw&t=10s -works
http://www.youtube.com/watch?v=nfGV32RNkhw&t=10.5s -does not

I don't think we care. Pretty edge case. Let's not hold this up for what is bound to be another hack to make youtube useful.
With the above change this becomes simply `BasePage`
This is good, but I'd also like to see test cases for missing the first n days and/or last n days, since these are cases with which we've had specific problems.  Also, testing missing n > 1 days in the middle I think is important.
this looks good, would you mind adding the search param to the description?
This is a problem. This caused the ajax exec and consequently the loading events to end immediately after the route change occurred. This behavior needs to remain the same otherwise there will be cases where the loading indicator display is tied to data that is going to be thrown away.
Big note on this test case - the UI for app install is going to change, so we should notify Ben Francis about what we're specifying here to be ready if we need to modify this soon.
This is more a question for @simonster or @dstillman. Is there any advantage to passing relative links instead of complete URLs to doGet, doPost, processDocuments, etc. in terms of proxies, connectors, etc.
This will lead the translator to fail whenever one of the fields isn't present - that's more fragile than necessary. Except for title (which is required by Zotero anyway), it'd be a good idea to first test for the variable as in 
```if (rights) newItem.rights = rights;```

More generally, if you write other translators like this you may find that using the Framework: 
http://www.zotero.org/support/dev/translators/framework
is more convenient (though this is obviously fine).
Well, if the service fails and you get back 400 or not found then you will have completely useless error message and nto helpful error log. Painful troubleshooting follows. That is why I print the entity and headers in the case of the error. Trust me, I have been through it and it's a pain.

But I see you insist so I will do it here your way and it it my way on my projects where my pain is of high concern to me while here I can feel pity for the poor devs that will fall into the trap but it doesn't hurt me personally. /end-of-friday-minirant
Improper documentation syntax.
`became` -> `become`

`thousands` -> `hundreds` or `scores` (there aren't thousands :-D )
Don't use variable names in spanish
It is faster:
```js
if (exports.favicon.substr(0,4)=="http") ...
```
to_return does't work either
You are stuck because here should be ```to_return``` instead of ```with```.
это копипаст от того, что выше. надо избавиться
@davehunt  your query is valid but as we don't have browserid on addon-tests at the moment. The last time we had it on addon-tests this code worked so at the moment we've no reason to doubt it. If they put browserid back onto it and change the code at the same time then that's another problem. This pull is to make the performance improvement not argue about the logic so it would be appreciated to keep it in scope.
you can't use by id, because there is an issue on the paypal frame: two id's with the same name.
I've already logged a bug about this: https://bugzilla.mozilla.org/show_bug.cgi?id=769251
Isn't common.replaceHTMLCodes() enough? Instead of a new convertChar() function.
If you're going to include this gem, we should remove one of the js libraries I included for uploading (`file-upload/jquer.ui.widget.js`).
I think we need it in order to route `/nodes/<node>` directly to the status app, without having to rewrite the URL (because the status app normally expects `/status/nodes/<node>`. I believe when I brought this up last week, you were the one who told me to change /status this way. :)
You are correct on all counts.  This commit series at least disentangles us from the indirector junk that we were relying on before, but I'm not sure I'll get a chance to take it quite as far as you are describing for this release.
So how does this work in practice? Does that mean we won't be able to just ask for results 10-20?
Same thing w/ the caching here
`start` and `limit` can probably be rolled up into an optional parameters object. This is still pending for some other api's as well.
This needs protection to ensure that the path that `uiDirectory+path` points to is still a file under `uiDirectory`. For example, if I specify the path to `../../sensitivefile.txt`, I should not be able to get that.
Can you do something like:
var todo = _.keys(newPermissions)
for (var i = 0; i < todo.length; i++) {

I find that much clearer to read than p.hasOwnProperty plus it cuts down on an extra indent.
Indentation. I will fix so this can be merged.
Does this really need to be done in so many passes? It seems to me it would be more straight forward (and efficient) to traverse the typed tree just once, building whatever data structure is needed to hold the `SymbolInfo`s.

I am a bit worried there might be some non-obvious quadratic behavior hidden in the way `GlobalIndexes` work/are used. It would be really useful if some of its methods had a hint about their cost.
Even though I think this will be going away to use the ioloop, you could combine the two tries without restructuring much.
i wonder if moving this to the end is what actually makes the fatal error go away?
is `rk` aliased elsewhere? I can't seem to find it.
@timw4mail @philsturgeon correct, and iirc the 1/2 and 1/2 came through in a very large pull request that did not get reviewed back on Bitbucket.  I agree they should be consistent.  And the simple, legible class property docs make the most sense.

@philsturgeon can your doc gen method of choice be extended? I'm guessing that if it is that important, we can make it parse CI's code and comment style.
Should always do more specific IF checks than this. For instance, `'0'` will be interpreted as false, even though it's a valid string.
Существует вероятность того, что вы замените символ на тот же самый. Это противоречит ТЗ.
Что это за условие? Объясните алгоритм вашей мутации, пожалуйста.
Ворнинга не будет если напишете
printf("%s",dnaStr);
У вас был ворнинг Format string is not a string literal (potentially insecure). Тоесть нужен format string.
@grishamsc 
1. генерируем массив индексов (от 0 до ...). например, получается [0, 1, 2, 3]
2. перемешиваем этот массив. например, получается [3, 0, 2, 1]
3. проходим по его элементам необходимое число раз, (например, только первые два индекса (50%)) и мутируем соответствующие символы (по индексами 3 и 0) в оригинальном массиве ДНК
Почему бы не использовать простой инкремент: j++
а что здесь self? это же хелпер
That's definitely doable.  Thanks for the suggestion!
It needs to be disposed or we'll just keep watching the file. I'm not sure what you mean about manually.
Maybe the thing to do, instead of duplicating lines, is to make it clearer what each function is doing? I could change variable names and improve comments. Seems to me that would be the clearest thing. Would that work?
use something like this:

https://github.com/mne-tools/mne-python/blob/master/mne/simulation/source.py#L34

for rng
right. thanks.
already learned that but disn't update it here. thanks!

On 19.10.2012, at 20:55, Martin Luessi <notifications@github.com> wrote:

> In mne/artifacts/ica.py:
> 
> > +            # pre_whitener = np.array([std_chan]).T
> > +            data *= pre_whitener
> > +        else:  # pick cov
> > +            ncov = deepcopy(self.noise_cov)
> > +            if ncov.ch_names != self.ch_names:
> > +                ncov['data'] = ncov.data[picks][:, picks]
> > +            assert data.shape[0] == ncov.data.shape[0]
> > +            pre_whitener, _ = compute_whitener(ncov, info, picks)
> > +            data = np.dot(pre_whitener, data)
> > +
> > +        return data, pre_whitener
> > +
> > +    def _get_raw_data(self, raw, picks, start, stop):
> > +        """Helper function"""
> > +        start = 0 if start is None else start
> > +        stop = (raw.last_samp - raw.first_samp) + 1 if stop is None else stop
> not necessary, you can use start stop directly even if they are None (raw[:, None:10] gives the first 10 samples, raw[:, 10:None], all except the first 10, raw[:, None:None] all samples, etc)
> 
> —
> Reply to this email directly or view it on GitHub.
>
That sounds much better. I was puzzling over what to call it, because I didn't want to shadow "type" or repeat numpy's "dtype".
Maybe a link to Salt Globbing and regex documentation http://docs.saltstack.org/en/latest/topics/targeting/globbing.html ?
I'd ditch these last two. That way they get caught by the top one and you get notified of the problem.
转换 =>
Use Akka Serialization Extension for all serialization, that will give you awesomeness for free and streamline things
This gets called like so:

    init_by_array(self.internal_state, <unsigned long *>(obj.data), obj.dimensions[0])

So it looks like npy_intp would be a better type for that.
QList<IAccount*> Core::GetAccounts () const
>
>
Check file extension
where exactly ? the capital S in the "CacheStore" word
Nice line. I think it can be simplified with ```np.sum(histogram * np.arange(len(histogram))**2)```

e.g:

```
>>> a = np.array([0, 3, 2, 4]) 
>>> i = np.arange(len(a))
>>> a
array([0, 3, 2, 4])
>>> i
array([0, 1, 2, 3])
>>> i**2
array([0, 1, 4, 9])
>>> a * i**2
array([ 0,  3,  8, 36])
>>> np.sum(a * i**2)
47
```
On Fri, Oct 5, 2012 at 4:43 PM, Varoquaux <notifications@github.com> wrote:

> In lib/matplotlib/cbook.py:
>
> >
> > -def vector_lengths( X, P=2., axis=None ):
> > +def vector_lengths(X, P=2., axis=None):
>
> I don't think so, but I often use this "trick" to make floats instead of
> integers. Maybe another input would be good on this point.
>
Personally, I have always liked "2.0" versus "2.", but it is such a minor
issue for me.
Is there a reason for not allowing "normed=True"?
Sure. To my eye I'm not fussed. I'm sure there will be fodder from others though. Thanks for being so patient and cooperative with us.
For another PR: The numpy minimum version for mpl 1.2 is 1.4, so we can remove this.
this, to me, looks even less readable than before, how about something like the below instead?
```
return array(
    $path => test_number(
        $path,
        $values,
        false,
        false,
        65535,
        __('Not a valid port number')
    )
);
```
s\must\can?
This change seems unrelated, can you remove it?
Style nit... just remove leading space between var name and values.
What I commented in the wrong commit last time, also applies here, this is a bunch of very magic numbers, could you document them?
@gsilver We should probably remove this + fix the merge conflict.
please have a space between if and condition, i.e., ```if (condition)``
I'd suggest you split this into 2 functions: 1 for getting elements, one for getting attributes
Ohh, you wanted to remove the call since it was actually causing problems. I didn't read your implementation too carefully but would it be difficult to remove that double-tracking behavior? That's a pretty big bug in my eyes.
for tests and examples we should use camel-case, also we dont need to be so verbose,
ideally something descriptive like:

```js
var tobi = { name: 'Tobi' };
var user = { pet: tobi, name: 'TJ' };
user.should.include({ pet: tobi });
```
I abstracted it so both Handlers and Sub-handlers could implement it
Should the type for parameter ``$helpHtml`` not be ``string|null``?
Is it possible to add a ``@param`` annotation for parameter ``$mockConnection`` which defines a more specific range of types; something like ``string|array``, or ``null|MyObject``?
I think this is actually wrong, I will change it. I was thinking of the checkout-- command.  It's meant to be used if you remove a file, so for example, when I removed the clustering things, I had to use rm instead of add. Not sure how to describe that.
this should get the timezone from the CoreExtension to be consistent with the ``|date`` filter
All kinds of pyflakes `imported but unused` up here.
I'd say you should split that into multiple inserts, otherwise it might be a bit heavy
I'll rename this as `putSingleOrDelimited`
i dont see the problem. if you just want to use one or the other .. then simply do so. you can hardcode getIsPublished() to always return true and you can hardcode getPublishDate() to always return null. however if we want to provide some real case useful out of the box experience then we should offer both approaches and the combination of the two imho also has relevant use cases, though isnt super important to me. note the current approach with two fields was the result of a client meeting.

now using a start/end date on the storage level obviously gives us the ability to also end the publication automatically. i assume you are suggesting that the "unpublish flag" use case is covered by simply making the end date smaller than the start date? on the UI level we could still then present a checkbox flag, but it would make the mapping from storage to UI a lot more complex.

as for the naming. i dont think this is an ACL check .. its a workflow .. just a very simple one .. and i can certainly see it become more complex (including more complex rules about who is allowed to see what when). we will have ACL's as part of PHPCR and also with Symfony2's ACL system.
user_id and screen_name get passed in GET response, when I demand access token. Other information is provided after you create a user with  api = tweepy.API(twitter_auth), twitter_user = api.me(). Here is a list of information provided:
http://tkang.blogspot.com/2011/01/tweepytwitter-api-user-object-structure.html
Swap two lines above around. `var unread_notifications_counter = 0;` is part of the for each loop.
`img` -> `image`. Be verbose.
Super. Yes.
And again, `{name: panel.get_layout(columns) or PanelState() for name, panel in self.panels.items()}`.
You can put those two into one line.
OK, I will complicate, because I know you will manage. ;-)

Please name things better. `fb` does not tell anything. *facebook data* neither. (And use underscores.) So function name should clearly tell what it does. You probably have a function which returns Facebook user profile data? Then write that!
<code>{{ user.username|escapejs }}</code>
Like this?
You just include that file. Check the include template tag.
ojects.get()? And use exception if missing?
Also, you should never use inline styles except while playing around.  When committing code, always put this in a .css file (or scss if using SCSS).
Well my thought was that the intended use would be `:test_mode => true` or `:test_mode => false`.  So this supports that, and *also* supports if someone happens to want to use `:test_mode => 'TRUE'` or `:test_mode => 'FALSE'`.  Does that make sense?
Not being used?
Für Zusammengesetzte String gibts eine Methode getString mit Parameter (printf ähnliche Formatierung im String XML). 
Dann ist die Formatierung auch an einem Ort definiert.
Ist hier nicht unbedingt nötig. Nur so als Hinweis. Aber wenns human readable sein soll (Verbposition, Subjektposition) ist das eine coole Sache.
missing 3rd elemnt of returned tuple, 
    return ( gateway_url, "GET", {} )
Then lets get an external call in here would any mvc involved. Can you remove all the mvc ness.
Nope, we can link hydrators docs on ZF2 docs here :)
Haha, OK great. I'll make those trivial changes.

I'd like to include you in a THANKS section, what name should I use ? do you have a webpage?

Cheers,
add an openvz check here looking for /proc/user_beancounters only and only processing the commands if the file does not exist.  should only exist on openvz
You could probably spare yourself a bit of machinations and heartache by always just calling the `e` argument `event` in all the examples here, and then explain that jQuery provides an event object to every handler as the first argument, and you can call this argument whatever you want.
The rationale was that there could eventually be different UUID backends, one written in C, a networked canonical service of some sort, etc and I didn't want to directly use a single back-end but instead use an abstraction layer. That said, the mechanism for switching back ends doesn't exist yet so if this makes your life easier, I can dig it.
Space around "=".
I know.
Flattening the nested return values of these recursively called templates was even more opaque. Ridiculously opaque for what it is.
In this debug code the colour of stars are changed.
hehe good point. You are right :)
It works if you enable extended_glob globally, which can cause havoc elsewhere. The point of the function is to use extended_glob with local_options.
I would change the conditional
if <string>
     ...
elif < callable>    # new option
    ...
else
   <assume array_like>

(in the last case: asarray will raise exception if anything else, sounds ok and doesn't need try exept)
This dependency is required in all cases not only in devel
Please ident propely. All strings in templates should be translatable.
you're using things that are internal to xbmc. which uses other parts of xbmc, like logging methods etc.
a pvr add-on has to be fully self-containing, so all the code it uses has to be linked directly to the add-on.
loadsettings is architected to fire also when the settings are already loaded. It is also optimized. This is the prescribed way to do it. In the future we want to be able to load different settings at runtime.
is it convention to have a space after the if? if (some statement) { ... 

I think keeping the braces on single line statements is a good pattern, even if it's not strictly required.
No, that's a really good point, I'm going to remove those checks.
scanNeeded presumably needs to be volatile if accessing it from unsynchronized methods?
I think I'm still missing something fundamental about who invokes the scanning and when.

I'd have thought "normal" usage would be to connect to some catalog-server that gives back XML-serialized DTOs. The caller then constructs a bunch of CatalogDo instances (is that "domain object"?) for these, which know all the meta-data they require so no need for the caller to do any scanning on this CatalogDo.

If a specific template is chosen to be instantiated, then some classpath setup will be required (e.g. downloading jars that were referenced in the DTO), but that wouldn't require any classpath scanning either.

The use-case for classpath scanning is to build up ones own DTOs (and then CatalogDo instances) to reflect what is on the local classpath. And scanning would also be used if you want to implement a server so you can auto-generate relevant DTOs.

Is that how it works? Or is load/scan being called in other situations as well?
how portable is readlink ?  ie.

`if [ -z "$BROOKLYN_HOME" ] ; then BROOKLYN_HOME=$(cd $(dirname `readlink $0`/.. && pwd) ; fi`

that allows one to make symbolic links to the executable
recall ? repeat plutot non?
wtf? sony and universal are the recording studios. should not even exist? really?
If we would assign a meaning to the value 1 then mongo_process_options() would need to check the return value and rewrite it :]

I have a hard time to imagine other cases.. but you raise a good point, we should probably be setting error_message variable there to send back.
why? Open Genesis cannot have authors?
moved argument decoding out of if so ERR line with unknown command can use the callid
```cpp
if (what) {
  that();
}
```
та сама проблема з айдішкою. я не дуже зрозумів, чому вона в двох місцях винкла, якщо сортування має бути тільки при перегляді проектів по категоріям
The name "ESException" sucks, but I didn't want to spend time thinking about it right now. It'll get fixed in one of the "remove Sphinx" passes.
Seriously, I don't see any useful change to Application.java.
Huh, a single comment added to the source just over two weeks ago - no wonder I wasn't aware of it. I think I assumed this process was a subtype of machinery/atmospherics though? Reverting
What you just wrote sounded rude and thankful to me caelaislinn. If you want to benefit from other developers joining this project you will need to be more careful or you will simply scare everyone away.

That aside I am not at all interested in being an admin on your server. I want to use your software to create my own server and at the same time help improve yours.

It seems to me from the way you guys act that you have published YOUR server on github. In my opinion that is not the best practice. Rather try this github project to be a ss13 server software that anyone could use for their own ss13 and make the server software configurable. Then YOUR server would just be a specific configuration setup of this server software on github.

I was assuming that you were following this best practice I described and thus did not realize you were actually going to use this configuration on YOUR server.
I have never used it, and didn't comment it. I suspect it's been like that for quite some time. I'll nuke it.
Yeah, I thought to do it in separate file. It was easier to do it like that now, for testing, but you are right, much more readable and easy to maintain.
I'll change it.
https://issues.jboss.org/browse/AEROGEAR-651
I think we should get rid of server deciding which color is good and make client the choice. You can never know if server decided to allow some color which is not allowed here.
You could use the -with-transactions BOM here.
Can you put a custom failure message in here, perhaps including the failure message on the page (if appropriate)
Are you actually checking that the section contains applications, or just that it exists?
add a _text here
改行が消えちゃってますね、直します。
_type_ と _phase_　の両方
Блок лучше назвать `combobox`, без префикса. Префикс "bl" расшифровывается как «Blocks Library» либо «BEM Library» и используется для обозначения того, что библиотека как-то причастна к БЭМ-методологии. 

Блоки, входящие в библиотеку можно не обозначать префиксами — и так понятно, откуда «растут ноги».
I'm not satisfied with the current container but using a boolean array makes is expensive to find the active features. 
One needs to loop over the whole array, just  to know that no feature is active, in the extreme case.
how does it feel to have @ogrisel and @agramfort on you back? cool don't you think :)
@agramfort I've copied the data generation from ``plot_gp_regression.py``. There are currently more than 30 examples that use ``np.random.seed``; I think we should adress this in a dedicated PR.
why is this elegant?
you need a deprecation warning for p too
Maybe also marked as %doc ?
Why != 7 ?
Never reference bug tickets in code.
Use the `getIdentifierValues` from the target class' `ClassMetadata` here
Should also use a different variable
IHqExpression * transformList = ds->queryChild(0); 
it isn't a row.
I see what you are saying, you are looking for something like this?
    if (numRows)
    {
        rows = rowsToSort.getBlock(numRows);
        heapsize = numRows;
        for (unsigned i = 0; i < numRows; i++)
        {
            heap.append(i);
            heap_push_up(i, heap.getArray(), rows, compare);
        }
    }
As I said in some other comment, it would be clearer if the new 'capacity' member in RoxieOutputRowArray, was a member that returns the # of rows capacity.
Then +1 would be ok here.
I think it's just your paranoia...

If/when there is a standard and mature library for git access, we can (if/when we feel like it) port this to use it, though at the same time I would probably want to move this code OUT into a dynamically loaded dll so as to avoid adding to the dependencies that are required for the system to be able to load - another advantage of the exec route.
you can simplify by just doing:
```
return self.cleaned_data['product'] or [settings.DEFAULT_PRODUCT]
```
Perhaps briefer to do:

```
{{ params.query and params.query or params.signature }}
```
Correct, but user supplied entity tuplizers need a own call to `BuildInstantiator()` since 2.1.0, this brings component tuplizers in line with them.
If you really don't want this change we could create a `EnsureOptimizerIsSet()` method that is called both in the constructor of `PocoComponentTuplizer` and in `BuildInstantiator()`. Although then the `ClearOptimizerWhenUsingCustomAccessors()` method should also be called at the end of `BuildInstantiator()`, otherwise the optimizer might be set for property accesses which don't support optimized access.
User id's are handled by the feed_relation table
For the graceful handling of non-android, am i correct in assuming that if this is not android, androidVersion would never have been bound and would be null?
I think we should mention that they are not stable and may change.
What about using `openWindow` instead?
The term `open` is common when you start using JS window APIs. (window.open)
And this time the term `Top` sounds unecessary as this module only handle top level window.
You might even call it `open`, but I won't suggest this as you won't trust me about his: https://github.com/mozilla/addon-sdk/pull/353/files#r520552
The only purpose this would serve is validating that it's a FQ class name and not an alias, however we're already checking the instance manager if it has a matching alias, so this is redundant. The locator throws a class not found exception if the class does not exist.
"Initial" seems like an odd choice of word. Surely "Included" would be better?
René, small remark: please replace 'mei' with 'May' so that everything is in English and consistent with the other files.  If this is fixed, we can merge this.
@ctweney I completely agree with you, I just wanted to show how people could use it.
For now we'll probably do a page refresh after the people have modified it.

Would it be possible for you to take over this PR again?
I won't be able to do much work in the next 24 hours.
It just needs commons-io and servlet-api on the classpath.  I could mention that, but not sure I'd want to get into explaining how to set up java projects in general in the README.  I didn't think this was intended to be a utility for them to take and use, but just a pedagogical example.
hm, from/to is available from metadata, but not CCs?
"of"! :100:
Looks good, but a logging statement would be nice.
Missing a ">".  This actually causes the email to look like this when you type 'info' in msfconsole:

	mubix <mubix <mubix <mubix@hak5.org>
So the only reason I do a rescue within each other method is so that I can see which part of the module failed if it did fail that is.  Would it be better if I only handle exceptions in the run method?  I am new to writing for MSF so best practices like this escape me until someone tells me what is the right way.
This is an instance level variable also, it comes from the server and used in the crypto of the authentication.
I'll keep it reverse. You can change this in the separate PR.
Add subclasses for the different transforms... Affine, Similarity, etc.
Let's make all this a template tag (line 18 to line 35). Something like wpsc_user_profile_links( $args ) where $args is an associative array that lets theme devs configure the HTML output through arguments such as:

- before_link_list
- after_link_list
- before_link_item
- after_link_item
- separator
Noted on this, removed suppress annotation.
I gave that a shot...the realFragment.onCreateDialog() method returns null :(

I've seen this idiom around Roboelectric that creates a new instance everytime a method is called...I am not a big fan of it but it works and it is driven by the bool variable.
Os this extra function needed now that you're just setting the z value?  Seems like we can revert this back into the case statement above.
I guess technically this isn't an exception, but we need to document all of our `rejects` in a way that makes it clear they can occur.  @shunter @kristiancalhoun ideas?
Here "cancelBubble" is set if it's not set yet. If data.cancelBubble is already set to false, I don't need to override it. So I only check if it's "null" or "undefined".
I don't consider this bad code.  It is explicit and useful in some scenarios we have discussed before in MV.

This discussion has been had before in MV before the initial approach was signed off in the original driver PR.  I pulled this approach from a highly visible blogger from the node community and there is no consensus among the community on the "best" way to do this as each approach has pros/cons based on personal preference.  

If this style is a problem then it should not have been signed off in the original driver PR and it should be noted in the style guide.  From what I have seen so far, this is undocumented stylistic preference and changing the modules to adopt your preferred style is not something that is going to happen in this PR at the very least without very strong justification.
Edit 2: I'm not sure what you mean by "The default exit when the tab group is the base activity ". When I think of activities I tend to think of layers. In this case, the root activity is layer 1, then tabGroup opened over it, which is layer 2. It seems like we're treating tabGroup like views.
Are any of the params optional? If so they should be surrounded by []'s
Come now, scolding is such a strong word!

Good point on introducing a library, but with tree shaking, is it a big deal?

Let's discuss more in person, should be fun. :)
This is indented strangely.
I don't really see the point of this. Why wouldn't you just do `if (keysAmounts instanceof Array || typeof keysAmounts === "string")` on line 115? You're not using the String version for more than that check anyway.
@jtopjian If we merge it, then we have to be aware of backwards-incompatible changes such as this, since it impacts anyone currently using the module. It would make it easier to merge if `$ssl = true` was left as the default (even though I think it would be more sane to be `false`) and we can make behaviour-changing commits later on.
constants should be decalred before properties according to the Symfony CS
`else` is on the wrong line :)
вот этот файл ближе всего к продакшену на мой взгляд, так что давай свои комментарии по нему скорее
The *existence* of this line, or only with DEBUG enabled? If it's the very existence, that would be somewhat surprising, but I think it would be perfectly fair to remove it. But DEBUG should be off by default -- this is just a quick way to confirm that it's producing sane values without having to hook it up to a renderer.
Again, it messes things!
don't use `l` for symbols
Does this mean it will apply on all #'s?
WDYT about binding checkstyle to the _verify_ phase instead ("run any checks to verify the package is valid and meets quality criteria.")? That way one could do a _mvn package_ a bit quicker.

I'd also suggest that we include the test sources into the check. This would be done via _&lt;includeTestSourceDirectory&gt;true&lt;/includeTestSourceDirectory&gt;_.
```python
self.toolchain.variables['LDFLAGS'].flatten() 
```
returns a 'flattened' list of all things in LDFLAGS (not necessarily what you expect on second thought)

at least change the whole mess into a better regex and split like
```
>>> a='-Lx -Ly'
>>> import re
>>> reg=re.compile('\s*-L')
>>> reg.split(a)
['', 'x', 'y']
>>> ':'.join([x for x in reg.split(a) if len(x) >0])
'x:y'
```
Ah, the openshift one. I initially didn't see the point, but we are trying
to push openshift, aren't we?

On Thu, Aug 2, 2012 at 4:15 PM, Pete Muir <
reply@reply.github.com
> wrote:

> > +            </dependencies>
> > +        </profile>
> > +
> > +        <profile>
> > +            <!-- An optional Arquillian testing profile that executes
> tests in a remote JBoss AS instance -->
> > +            <!-- Run with: mvn clean test -Parq-jbossas-remote -->
> > +            <id>arq-jbossas-remote</id>
> > +            <dependencies>
> > +                <dependency>
> > +                    <groupId>org.jboss.as</groupId>
> > +
>  <artifactId>jboss-as-arquillian-container-remote</artifactId>
> > +                    <scope>test</scope>
> > +                </dependency>
> > +            </dependencies>
> > +        </profile>
> > +        <profile>
>
> I meant the openshift profile :-)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jboss-jdf/jboss-as-quickstart/pull/324/files#r1297983
>



-- 
Jason Porter
http://lightguard-jp.blogspot.com
http://twitter.com/lightguardjp

Software Engineer
Open Source Advocate
Author of Seam Catch - Next Generation Java Exception Handling

PGP key id: 926CCFF5
PGP key available at: keyserver.net, pgp.mit.edu
Why are we caching `selectionsList` at all?  It's just an accessor.  I worry that our cache will be out of date through an `onResume` loop, too.
Rails is actually a runtime dependency, since an engine can't run without it :)
No idea.  I'll fix them.
Is that different than
```
@response = response
```
Change to Gold Stars and Dog Houses if this is a title
Promoted this from User so that the Admin group will also be identified as an administrator.
I think last time, Richard told us to leave out columns that we don't need for the test, so you can probably leave `patient_status` out of this one.
hmm .. well supporting dots too would essentially make the entire filter superfluous. but maybe the best approach for supporting YUI would be a dedicated optional pattern just for YUI.
This would apply to all firewalls, but since it is not enabled by default, I can't think of any negative side-effects that it would have right now.
I don't think that `__construct` is supposed to cover/test anything.
manufacture_year?
normally shouldn't be two blank lines in the middle of a method, unless you feel strongly that it's important for readability for some reason
I copy/pasted it from another call within this class file to it, I also made calls to it and it seems to work as 'warn' does, but I changed both references to warn to remain semantically the same as everywhere else (in the modified pull request)
They don't; we have the same problem whenever we want to deprecate `equals_t`.