labofsahil/github-event-dataset-2012 huggingface dataset:
One thing. The spell Soul Reaper http://www.wowhead.com/spell=69409 triggers http://www.wowhead.com/spell=69410 when done damage. The trigger spell triggers on the LK, not in the target ;).

I have it fixed but i don't know if it's good placed in core.
> o = {};
> o.x = console.log('x');
> o.x = 1;

Creating compilations that skirt `use strict` is definitely a viable strategy. However, I feel like declaring a property or paramater more than once is *usually* a bug. Is that your experience as well?
Hi, chuck!
Ti metto un appunto qui:
Secondo me e' meglio parlare indirettamente/impersonalmente (ed ho fatto così nella parte che ho tradotto io). Con l'inglese questa differenza e' meno marcata ma in Italiano e' + 'pulito/formale' secondo me. Ad esempio, in questo caso, sarebbe "Per creare una classe, si deve passare un oggetto al costruttore...". Che ne pensi?
Here should be `REQUEST_TIME_FLOAT`?
Is this a linear time algorithm by Juha Karkkainen and Peter Sanders?
Wow, I wasn't aware anyone was actually using this. Thanks for the pull request!

I'm pretty sure I've got a version of Browserijade that hasn't been pushed to Github yet. So I'll take a look at what I've got locally first then we'll see about what we need from your pull request.
I did ask about TAB / whitespace settings in vim :-)
You've added a lot of debug to your kernel, which will bloat it more than anything. I'd stick to enabling based on necessity, otherwise you might run out of space in your designated /boot partition.
I'm not sure how that was working for you, the perm['content_type'] by definition is a list, which obviously can't be a dict index.
Bear in mind that this will allow a client record to have a null name or type. Do we have a default type? Does code elsewhere know about it?
I've just noticed this should not be the partial score, but the final score. I'll have to fix this on the next patch.
Ca fix rien du tout, quel skill :trollface:
Derp.  Project*
Yes it appears this is a mistake, I think it was included from when David was doing the changes for Agilefant eclipse integration,
Story : https://soberit.myfant.com/qr.action?q=story:338
It seems slow to load as well.
To make it a bit clearer, how about we create a local variable List<CameraConfig> and assign it the value from Config.getConfig().getCameraConfigs. Then iterative over the local var instead of the method call. might make debugging a little bit easier at least.
Such a great idea!  lol this is kind of confusing...
You little geeks.
There are multiple parts to this commit. http://review.cyanogenmod.com/#change,12006 http://review.cyanogenmod.com/#change,12004 http://review.cyanogenmod.com/#change,12009 and at least the first one needs to be present to allow this to work. Having only the first one will cause errors with market (tested as part of an earlier submission that also included sdcard directories and permissions), and having only the third (this commit) will cause boot error due to missing permissions and/or directories.
You don't sound like a jerk but I did it. Just one thing: does it work for you? If it does I'll check your template app deeply.
It seems to be a more "android-standard" way of handling proprietary files I think, but I am not sure any more...
This is definitely a step up, so I'm good with it merging.

The only place I see this making a big impact is Fog::Compute::Server (ssh, scp, ...) which expect the public_ip_address to be routable, which is not supported by grabbing just any value of addresses['internet'].  But even checking RFC1918-ness wouldn't necessarily fix that, given that you could be talking over a CloudPipe VPN.
Again, this checks only `lis_matrix_assemble()` error.
I'd rather see this warning generated from somewhere in `lib/vcr/library_hooks/fakeweb.rb` so that the warning goes away when we actually remove the fakeweb code :).  Maybe it can go in the [`after_library_hooks_loaded` callback](https://github.com/vcr/vcr/blob/master/lib/vcr/library_hooks/fakeweb.rb#L190)?
I think that defaulting these to `null` or simply leaving them `undefined` would be better. What did you run into where you wanted to use `NaN`?
Using "boolean" as the type is better
These specific to the CAS protocol and shouldn't be here (they are also web-specific)
So we plan to produce javadocs only for releases, not for snapshots. Correct ?
Good point. Do you have a recommendation for a class that might be a good spot to host these?
The parent abstract class should already expose a logger.  Please use that.

https://github.com/Jasig/cas/blob/master/cas-server-core/src/main/java/org/jasig/cas/authentication/handler/support/AbstractPreAndPostProcessingAuthenticationHandler.java
So we rather make the fact that `==` means `is` and implementation detail for `Set`? That makes sense to me.
expensive, why the flatten?
yeah :-)
why not "var initialPatricipants: Int"?
might want to change this to some ObjectStreamException …
this is racy, it's enough with the next awaitCond assert
Fixed and pushed checking on address now instead.
I need to generalize it and put it back, yes.  It moved too, but your are right that we are not doing this filtering now.
If a site really could use this, maybe it should stay and be uncommented, otherwise, let's just remove it, right?

Looking at the whole file, there is also a 'TAGS' pattern, do we use it?  Might we later, or should I remove it?
```(((40 * 2) ^ 2) / 2) ^ 2 = 56.57```

I will explain it in comments.
We should probably keep this and, the spec's style is generally to do this.
Careful, setdefault() is a function call, not optimized as we was doing before.
Testing with "not in" prevent the function call, and prevent to create the python object on the right (string or integer).

It seem nothing, but on my latest optim pass on label, it was reducing a little the time spent in the label creation.
I don't believe on our case to write "readable" code is better, just because it's more CPU consuming, and you feel the difference on mobile phone.

It's also the same for lot of others place, like: "padding = None" instead of (0, 0). In the last case, 3 python object are created, instead of referencing the None. etc.
There are a lot of unnecessary indentation modifications in this file. Could you undo the accidental tab/space conversions?
Happy to remove PL and prefer STY to STYLE - all references to mess such as sandbox and sty are good...
this line breaks in test_package where an empty dict seems to have been added to the tags which looks like .... 'tags': [{}, {'name':'....'}]

Undecided whether to skip missing error or break
Added a comment to the top of the file.

Replaced pyutilib with the latest (and only) version on pypi, seems to work.
BLOCKER: Please edit StatusMixin to remove the capability of passing in a base progress report? It's no longer used and should be cleaned up.
Should probably point out the default if it's not specified. Most people would likely assume enabled, but it's still good to specify.
I think this is so that it doesn't put up the submenu unless there is an 'account' options (i.e. two), but as you say it will be gone soon.

Also, the same test it in another view to set the default attribute.  I think it is broken without adding a permission for the user to see his own account.  I think we just fix it downstream since it is gone/different anyway.
This was pretty ugly and only used once
more mainline c/p, but sure
Hmm, not sure if you need .c_str() here or if EXPECT_EQ() will work instead.
Reverted this.
Cannot be done without major change for class and test that use this class
it's easy to set custom role that string define, but it's not obvious which role to remove as long as role is String type
This should not be added in the bin. The compile script is only needed when using Cilex itself, not when using Cilex as a dependency (and the bin setting is useless for the root package)
Unmask is sort of a misnomer now, we don't mask and unmask, but rather we just scan for all the chunks.  The builds the regular expression, abstractly: this is: (.*?, ungreedy group for anything between chunks)( patterns * '|' ), so we have two groups to start, the between chunk (if any) and the whole match, then all the class matches in sequence.

The loop is also recording the ranges in a hash by chunk class for re_class to use.
This test hangs forever for me with no output...
I think you should add it in the doc. I figured it before your answer thanks to the unit tests, but people reading the doc will not have them :)
We really don't need to be #importing these.
Is there a reason we need to do this dynamic subclassing? Where does `-initializeInternal` get called from?
Indeed. Looks like we do the same in node_zlib.cc though :(

On Monday, March 12, 2012, Ben Noordhuis <
reply@reply.github.com>
wrote:
>> @@ -55,6 +55,7 @@
>>  #endif
>>  #include <errno.h>
>>  #include <sys/types.h>
>> +#include <zlib.h>
>
> This will include the system zlib.h if there is one. Probably not what
you want.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/joyent/node/pull/2896/files#r548538
>
Yeah, if file transfer was not finished we should notify the future with an exception. If channel is closed, `ClosedChannelException`. Otherwise.. I'm not sure.  Maybe `IllegalStateException` with an explanation message?
Bahahaha. Thank you.
this is a double-free in case zend_hash_quick_find returns FAILURE in line 767
No, we definitely need to print the library version information even if git isn't installed. So if git is install, you would print (for example):

```
                QIIME library version:  1.5.0-dev, issue_492@70efd32
```

and if it's not installed you would print
```
                QIIME library version:  1.5.0-dev
```

Does that make sense?
Тут тоже бы на 2 строчки connect разбить
This would make a copy, right? If a use each_with_object(self) I'll have the same problem (modifying the object while iterating over it). I think I'm missing something...
This list is useful to me. I always forget what are the supported methods and I always look this guide.
Remove RTF from here since it doesn't work.
I don't think this actually makes the included methods `private`, does it? I think that's handled by whether they're private inside the module or not.
I have to test it out, but if you set these flags on the base type (Handle) IIRC setting tp_flags to 0 on the inherited types will use those flags as well.
That's the definition of nesting!
Oh, sorry. I missed that it was in scalacheck. 

On 27 Jul 2012, at 21:58, Paul Phillips<reply@reply.github.com> wrote:

>> @@ -1294,7 +1294,7 @@ QUICK BUILD (QUICK)
>>     <scalacfork
>>       destdir="${build-quick.dir}/classes/scalacheck"
>>       compilerpathref="quick.classpath"
>> -      params="${scalac.args.quick}"
>> +      params="${scalac.args.quick} -nowarn"
> 
> The problem is that we don't control scalacheck and I'm not super keen on maintaining local changes just to pacify the warning monster.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/scala/scala/pull/1004/files#r1256034
that's how i test my eclipse-built compiler as well
Should be ``scalar, optional``.
I would recommend lazyDSU_sort here and sort by count-ops, otherwise the "largest" may not be what you think. Here are some sorted results:

```
[(x, _x0), (2**x, _x1)] # I would expect the 2**x to come first
[(asin(x/4), _x0), (acos(x/4), _x3), (sqrt(-x**2 + 16), _x2), (x, _x1)] # I would have expected the sqrt tuple to come first

mapping = lazyDSU_sort(mapping.items, keys=[
lambda x: -(x[0].as_independent(x)[1].count_ops()),
default_sort_key])
```
An empty line should come after the section title and the code example.
allow -> allows?
I think SymPy style is to try not to redefining ```__eq__``` It tends to cause issues. Is there a reason why this is necessary?
I'm not sure. @asmeurer ?
I don't know.  I'm saying if you consider `2*x` and `3*x` to be identical, and then define your conglomeration function to just combine coefficients, it should work.
What does the comment want to say?
Hi Robert,

I don't understand what you mean -- can you provide more info?

Thanks,
-Jim G

On Fri, Apr 6, 2012 at 12:51 PM, Robert Martone
<reply@reply.github.com>
wrote:
>> @@ -6,4 +6,5 @@ styles/css/*.css
>>  bin/
>>  !build/bin/
>>  !styles/css/screen.css
>> -!.gitignore
>
> We make changes to gitignore that are shared - ignore this on your branch will keep it not ignored in the master.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Iheartweb/Lu/pull/69/files#r656490



-- 
jimg at yojimg dot net
Please put this error message on multiple lines so it is easier to read.
This method is invoked every frame, is it possible to optimise this to not keep re-allocating this pointer array? Would it still work if this was created in the setup callback? I think it's pretty cheap to allocate that array these days, but every scrap of performance counts for video playback?

Don't submit a new patch, just interested if you think it is worth optimising that or not.
`gitjub.token` doesn't work anymore.  Do we need it here? I remove that code.
Die nachfolgenden Zeilen stellen sicher, dass ZTal Templates der Endung xhtml lädt. Diese musste ich auskommentieren, da wir ja phtml Files haben. Anstatt dies bei jedem update auszukommentieren, könnten wir unsere Templates einmalig unbenennen.

Ich glaube, das wäre fast sinnvoller....
This override should probably invoke `super` unless there's a good reason not to.
Can we not use lorem ipsum for these at this time?  This will be going up on the official page.  Replace it with "Bio Coming Soon" or something like that.
Use `ngx_queue_split()` so you only have to lock/unlock the mutex once?
One problem: When using `"""..."""` quoting in Python, don't escape double quotes like `\"`. I don't think it will necessarily *break* anything, but it's not necessary. The `"""..."""` quoting allows any character sequence inside without escaping, except for `"""`
If you want to avoid blank lines you can try placing a `-` in the start of the block, like this
`{% for event in events -%}
BEGIN:VEVENT
`

for more see http://jinja.pocoo.org/docs/templates/#whitespace-control
This is almost certainly wrong. You are prohibiting a moderator from moving a topic into a forum where they can approve topics. The correct behavior should be either checking m_approve or allowing the action if post approval in the forum is not needed, which is where f_noapprove check probably comes in. In other words, original code was likely correct.
Color values do not belong in common.css. 

I think you've mixed up code from different branches. This code used to be in prosilver a week ago, but it was removed in branch that you are editing. Same applies to other color entries, see diff for your pull request.
32 seems rather small.
Fixed in 61ed466
should all of these warning and debug statement be prefixed by the checktype string?
I thought we were skipping the statefile?
I'll add a commit.  It will likely say something like "This method is part of how Y.Plugin.Base works.  See documentation for that.".
`useSync` is turned on here, but not turned off elsewhere.  Is that OK?

(Hmmm... I guess we won't know until we do a deeper analysis of where `use()` is being called.  It's OK to do things synchronously while the server is starting up, but after that we should definitely be doing things asynchronously.  That perhaps answers my own question:  set `useSync:false` after the server has started.)
Nope, `YUI.Env` is correct.  It's a result of how Y.Loader works.
Suggest to rename this class. "Custom" is class name seems weird.
No reason to have dropdown, for now, if there's only one category ("all")
Note that https://github.com/Raxa/Raxa-JSS/pull/75/files (#75) also has screener tests, under a different filename. You'll want to make sure these two test files get merged.
Didn't suggest a class, just a function.
Not a problem though, just an suggestion.
Can be done when needed.
Ridiculously long lines!
Please fix: No newline at end of file in both sql files -- is this from some strange vim effect?

Finally, in general,

I'd like to pull this changeset to the branch now just as it is to get jenkins testing started, then get these clean-ups before merging to master.

I am considering putting the CSVLoader change by itself on a branch and pulling that to master on its own.
Intentional change? Not sure what the point of setHasLocalServer is. What does this do?
With this move, you can limit the scope of csvClient to be a local variable in main -- a good idea?
With a similar move of csvReader.close(), that could be local, too -- a good idea?
Reasonable to keep less local variable. Thanks.
``if self.parent and self.parent.model and``
Calling a post_delete signal _pre_delete is misleading.
Переименую в `getDependencies()`, а `getCreateDependencies()` удали
I took this directly from the [commit that fixes ticket #15570](https://github.com/django/django/commit/c260c533e1f1553548fc98f24820805af87f72bf). If this is incorrect, this means that the behavior of the `cycle` templatetag  (in the documentation, the templatetag code, and its associated tests) is actually wrong.
Shouldn't this be 1.23 millions (plural!)?
Is there any explanation for this?
Do we need to keep the `successCount`, `jQuery( document ).ajaxError` etc. for this test? I can make this into a generated group of tests with `jQuery.each` that way, but with just the assertJqXhr inside. What do you think?
Hah, STILL one byte bigger. I think gzip is the real :trollface: here.
`db/migrate/YYYYMMDDHHMMSS_add_details_to_products.rb` is too long to display on one line on mobile Safari. I'd love to do something better, any suggestions?
I will change and resubmit it.
OK. After the modification, we can check it within transition function. Initially, we only check the first run. Actually, we should check the category for each iteration. I will fix this logic error.
SVM regression should also have such limitation.
On Windows, compiling Node.js is quite complicated (Visual Studio build system and so on), so we install and capture it instead.
That was a super helpful comment. :metal:
From the visual aspect, I agree!

From the README of python 2.7.3:
> To find out more about what Python can do for you, point your browser to http://www.python.org/.

"www" might be useful for load-balancing on DNS level?
Juste un petit oublie je suppose
I can understand that. This is not a trivial pull request.
Personal preference: "given" feels a little too informal for my tastes. Other options: supplied, provided, configured with
The problem with that is that the font size is only taken in to account after plt.show() is called, so setting it back to default in that method would result in a plot with the default font size. Maybe setting the font should be left to the user?
mei, es gibt halt ausser dem Umstand das die EXT zu spät kommt nicht wirklich was zu melden.. ein technischer Fehler im Sinne einer z.b. kaputten query ist es ja nicht.. was noch sinnvoll wär in den table title gleich die zu späte EXT rein anstatt einer Zahl.. dann sieht man was sache ist ohne erst die table aufklappen zu müssen..
presence_sendAvailable is still a valid stanza, so to remain accessible I'll make pushname an  optional parameter, if provided then presence_sendAvailableForChat, if not then presence_sendAvailable
Ah, yeah, for the static operator overrloads that is technically possible. Good catch. So indeed we should add that assertion and I'll get the the reference check back in there and return to delegating to it from != as well. Coming right up...
Note that what you have here is my preferred style, but in the JUnit code it's much more common omit the braces if there is only one statement after the "if" (personally, I find that style dangerous)
Does the license need to be in the pom file?  Why?
This line needs capitalisation and a full stop.
Hmm, I have no evidence per se, but I have a suspicion that moving `valid` to a separate variable may make subsequent reads/writes on the array slightly faster than having a custom property on the array.
My client derped whenever I added a @SurpressWarnings and indented the next line..I'll fix next time I'm free
The logic in `_setupAds`/`_setupAdTag` is correct, but I find it kind of hard to follow, and it strikes me as brittle, with the AdMob function taking precedence and then delegating to `_setupAdTag` in its last functional line). The ad setup could be a lot more direct — perhaps with `_setupAds` as a delegating function that picks whether to use ad tags or AdMob and then passing off to `_setupAdTag` or `_setupAdMob`, respectively?
JSLint nit: need spaces around the "-".  Same thing with the last line of this function.
I wonder if technically speaking this should happen before htmlReady(), since it's part of instantiating the HTML.
Seems like you could move createTestEditor() function to SpecRunnerUtils and re-use it in EditorCommandHandlers-test.js and MultiRangeInlineEditor-test.js.
The indentation is good, GitHub somehow thinks it is not.
What about all the subfiles and subfolders?
What if there are items in the work_queue for this db?
Weren't you on the class? We said the whole reason for using object-oriented programming is to reduce copy-pasting. If you have to copy-paste something, there is something very very wrong. This makes things unmaintainable (and unupgradeable).
Removed CUSTOM_USER_MODEL = 'accounts.User'.
I would define API as:

```
from django.contrib.staticfiles.storage import staticfiles_storage

DEFAULT_AVATAR_PATH = 'piplmesh/images/default.png'

def avatar_url(self, size='square', default=staticfiles_storage.url(DEFAULT_AVATAR_PATH)):
```

We do not really need `request` anymore, you just always do secure requests to Facebook or Gravatar.
One empty line too many.
Isn't kind of weird to check `options.background` but apply `backgroundColor`?
I thought that IE9 couldn't load fonts cross-origin?
That's fine, leave it.
Yea I stole the ticket, will review after this
Add a test for a null email as well
each line had one EOL space removed :P
Why do all of these properties have simple accessors? Can they just be properties on `_this` instead? i.e. `_this.id = null;` ... `butter.project.id = 'something';`
okee.
In addition, the logger will log this information in the debug mode anyway when the logging level is logging.DEBUG

http://docs.python.org/library/logging.html#logging.Logger.debug
...což je něco k nahlášení, ne k opravě v překladu.
The `preserve_paths` attribute is for files that should remain, which normally does not include tests of the library etc.
This makes it impossible to run multiple tinydnsbackend-instances (with different cdb files), at least when master-mode is enabled.
I'm not sure my name belongs here at all!
That's not bad, but if the UI was doing this and added a template to a
changset he would have to navigate to a completely different page to
fix the issue.  If it was triggered when adding the package to the
template (like the ui is today) he could fix the mistake right there.

-Justin

On Fri, Jul 20, 2012 at 10:51 AM, Ivan Necas
<reply@reply.github.com>
wrote:
>> @@ -205,20 +205,19 @@ def export_as_tdl
>>
>>
>>    def add_package package_name
>> -    if pack_attrs = Katello::PackageUtils.parse_nvrea_nvre(package_name)
>> -      self.packages.create!(:package_name => pack_attrs[:name], :version => pack_attrs[:version], :release => pack_attrs[:release], :epoch => pack_attrs[:epoch], :arch => pack_attrs[:arch])
>> -    else
>> +    package = Resources::Pulp::Package.name_search(package_name)
>
> what about doing the check when adding the template into a changeset?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Katello/katello/pull/335/files#r1205883
http://guides.rubyonrails.org/active_record_querying.html#passing-in-arguments

"Using a class method is the preferred way to accept arguments for scopes. These methods will still be accessible on the association objects:"
I prefer being explicit and unambiguous about this sort of comparison.
wrong doctype
"Thoroughly inspect" instead of "inspect thoroughly"
Yes, use unicode symbols whenever possible.
typo: nuetrino
再次看到这个名字，还是觉得比较怪异，虽然我还没想到很好的，但是这个却是不好懂。
It's static again, so that is fixed, too.
You are right, I was just asking, if a own strprintf makes sense in that context, as I (but that is a pure feeling) would consider boost functions more safe than own string-handling code. I'm fine with leaving that pull as is anyway :).
I took a look through the Notificator class and it is used as programName in args.append(programName); It this is the case we should perhaps remove the tr() for this and I change it back to lower-case?`@laanwj Can you help here?
This means that `'%s ago'` will not longer be caught by the i18n extract task and any timeAgoFormat will not show up in po files for sites using i18n files.  Why not make the formatting conditional, and remove the default property that has been added.  Either that or set the default property in the constructor so it can properly be translated.
show['encrypted'] == 'true'
i don't think there's ever a reason not to end a file with a newline, doda/ipython@4a6d842  would implement that and simplify the code as a result
This is a fine way to test it but you can also use this method http://chaijs.com/api/assert/#throws-section

````js


assert.throws(function() {
   ICAL.parse(blankLineMidICS);
}, /messageRegex/)

````
I usually  use Assert.state(condition, message) to check class invariants
instead of

if (!condition) {
   throw new IllegalStateException(message);
}

~Volodymyr
2012/10/16 Diego Buthay <notifications@github.com>

> In sensei-core/src/main/java/com/senseidb/conf/SenseiSchema.java:
>
> >
> >  import org.apache.commons.configuration.ConfigurationException;
> >  import org.apache.log4j.Logger;
> >  import org.apache.lucene.document.Field.Index;
> >  import org.apache.lucene.document.Field.Store;
> >  import org.apache.lucene.document.Field.TermVector;
> > +import org.springframework.util.Assert;
>
> are you sure you want spring's Assert here?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/linkedin/sensei/pull/60/files#r1859957>.
>
>
You can remove this file until we write some tests.
Pretend I'm fuzzy on what self.session does. Does it store this data in the cookie or on the server? If by cookie, is the cookie sufficiently encrypted?
I think we want to restart it whether or not it's running right now.
Btw, certifi is hiding in vendor/lib https://github.com/mozilla/zamboni-lib/tree/master/lib/python/certifi so it is there, I just haven't moved it over yet.
And returning the reused array instead of a new boolean[0] each time saves a lot of memory.
Does this compile? I don't think ht is actually available (probably would be called self->ht or something)? Also, RETURN_TRUE and RETURN_FALSE are macro's. I'm not 100% sure if they can be implemented like this. If not, you probably need to turn this into an if/else.
Again, I answered this in the previous comment response. If one is not supposed to use g_system, why is it exposed in system.h? I don't recall any problem doing this before. I wouldn't call this complicated either, since engines set their own palettes all the time.
i was just curious, sorry for that
you should use ``integer`` for consistency with the other parts of the codebase
guessMinLength() should be removed entirely and merged into guessPattern()
It dosent matter if it is valid or not, that is the way it is written in the rest of the phpdoc blocks :)
So, your fear is that people just copy/paste what I've done here?
But it seems that previously this was also available in the config file. Moreover, at the moment it is actually impossible to use this option, because your code overrides it.

Another difference is that previously  `repository` contained `gh_user+'\'+gh_repo` but now you are dividing them up in gh_user and gh_repo.
Hmm, I'm not sure I agree. I find `@{Users.about(member.id)}` cleaner and more readable than `/users/${member.id}`. Both approaches are _eventually_ just as "constant," but I think the former is more modular. I'd like to follow the discipline that the `conf/` directory represents what we can "configure," but using `/users/${member.id}` breaks that capability.
remove second empty line
This name is a bit of a mouthful and "acts as" is unfashionable in modern chic Rails circles.

How about naming this `PerformEmailJob` after the method that gets mixed in?
Yeah it ran ok for me :)
I don't have a test for this (it was part of #101 which was not un-bundlable), so will have to revert the change for now. No great loss at this stage.
Obviously this is a heuristic which is inevitably going to have some problems (for example, the number of pixels that the extent is intended to cover would ideally be taken into consideration). I don't think you need to do anything about that, but it might be worth being explicit in the docstring that this is the case...
i can buy ++j over j++, but not j += 1, weird... docs?
again, I don't think this change is correct here. At the very least not in this pull request!
Wants a docstring.
This changes pyVows VowsAssertionError behavior. It should receive two arguments, not just a message.

For reference, this is VowsAssertionError:

    class VowsAssertionError(AssertionError):
        def __init__(self, *args):
            msg = args[0]
            if not msg.endswith('.'):
                msg += '.'
            self.msg = msg
            self.args = tuple(map(repr, args[1:]))
    
        def __str__(self):
            return self.msg % self.args
    
        def __unicode__(self):
            return self.__str__()
    
        def __repr__(self):
            return "VowsAssertionError('{0!s}',)".format(self)
if any(i is None for i in (o, x, y)):
In this case we'd rather use our utility Evme.Utils.l10n (makes sure the text gets updated after language change)
It also removes the need for "evme" prefix. This is dependant on prefixing the properties files.
use `window.location.protocol`
nit: 

      if (document.mozHidden) {
        return;
      }
We rely on git blame for this information, as it doesn't get out of date.  Please instead comment this file explaining what it does and how it's supposed to be invoked.
Let's filter on something else. If the application does not have an associated icon it can be ignored.
Hmm, why an `<h3>` element here rather than an `<a>` element as everywhere else?

Nothing critical here, but I’d prefer not to use a title element if doable otherwise.
At this point we must have contact.id, if not we are screw :)
Let's add a comment about `showInfo` function.
Just for my own curiosity, why the reorder?
... is it not supposed to be an utf-8 char?
Uff,, having some tiles there, zoom in, out, move, so that other tiles are loaded again (you have to be online)
change to pending, same with the todo
These two translations are in english. Why?
Hm, just saw this. I would argue that the versions where ordering matters should move to FoldOperations.
Add the task you mentioned: provide a simple method to start and stop boss in tests
Make imports alphabetically sorted.
No, if the =encoding is missing, the POD parser will guess so we don't have to. Pod::Simple 3.21 or later will choose between UTF-8 or Latin-1 based on the presence or absence of a valid UTF-8 byte sequence.  This is better than blindly assuming UTF-8 so this decode is no longer necessary.

Also the decode should really only have been applied if no =encoding was specified - not much point attempting to interpret the bytes as UTF-8 (and potentially corrupting them) if the source was explicitly telling us which encoding was used.

Also, calling decode_utf8 transforms a byte string into a character string. However Pod::Simple was only ever designed to accept byte strings - passing it a character string could cause it to crash. You could be forgiven for not knowing that since it was only explicitly documented in release 3.23 but it has been implicit in the design for ever.
Why do we need IContext and Context? it forces this strange cast.
This would then be option 2 (old options were 0 and 1)
>How does that make no sense?

It translates to "The type is the first part of the postID if the second part of the postID is a submenu"

>type
>postID in two parts
>submenu

That makes no sense together.
You mean, a feature? Conf['Archive Link']
This function is much too large. It needs to broken up into multiple functions for clarity. Also, there are no code comments here. You need those.
эти 2 строчки: 
    
    @event.videos.build(params[:video].merge(public: current_user.try(:admin?)))
Good idea, changed it to use that.
This function does not have to take car of the timeout. The one initiatiing the connection should do this job.
The `~` means that the full class path doesn't appear in generated output.  Now that most objects are meant to be referenced from the master, this sort of statement will appear frequently in the docs.  It has nothing to do with the magic method-copying -- you could say the same about `:py:meth:'buildbot.db.changes.ChangeConnectorComponent.addChange'` and `master.db.changes.addChange`.
You should add a comment as to why this is handled later.
Maybe use os.sep instead of hard-coded '/'
duplicated ``$``
you should make it shorter by using the short class name. The solution of the class name will give the right result
the TarDumper uses ``tar``, not ``tarball``
Looks like I'm not the first to run into this puzzling change:  https://github.com/technomancy/leiningen/blob/master/test/leiningen/test/helper.clj#L32
define var per line. And `ret` is the one of the arguments, no need to define again.

```js
var len = arr.length;
```
same deal as admin, can the host be passed in on the command line, defaulting to `http://localhost:9000`
Going to use the heap and my 'max_scan_bytes' config option instead.
I think we better add a separate hdr then, don't want copies like this.
We need a dummy file for the schema version at a minimum, so this one is good to go.  I think the database model in the installer purposely continued to check MySQL for this reason, but it shouldn't matter either way.
So just replacing @kv_keys with kv_keys won't do the trick?
Your example is referencing @container, but the original comment is of @kv_keys.  I gather neither should be instance vars, yes?
But you seem to be using both an instance var and a non instance var in the example.   Can you clarify?
I would say local to the page url, instead of window.
Maybe mention that at the moment external modules need's to be copied manually and be used like local modules, but in a future we'll have a better support for them.
Looks like a debug print to remove.
I added an issue for this: https://github.com/mozilla/browserid/issues/1969

I think the concern that we need to be testing our extraction works right is completely valid.  

I think how we were doing it (using en-US po files in production and having the way our users see our software different from the way the devs do), was broken - evidenced by broken strings making it out to users in issue #1675

I'm the one being the opinionated dogmatic guy about this, so I take responsibility for adding that testing!
My first reaction is that this is fragile and hacky. It's not that bad though.
Why e2? This can perfectly be 'e'
Nit: Space above this.

Nit: Comments around functions are nice ^_^
But where should the xpi.filename property be set if we do not build a release? It cannot be done in build, and earlier is not possible due to the necessary properties aren't set yet. I could completely duplicate release and build and add another target to simply build the xpi.
@jeffweiss The query returns a WIN32OLE object or something like that, that happens to have an `each` method (as opposed to an actual array). The query will return multiple cpus (which may be physical or virtual depending on the exact windows version). I am assuming the processors are symmetric, because the Win32_Processor class represents the OS's view of the processor. In other words, a 32-bit OS running on 64-bit hardware will report the architecture as i686 instead of x64.
If this ends up not finding the line, it will return an empty array, and we'll end up with the same problem that we had before. In the case where the line is not found, it would be better to return an empty string, to avoid the problem with the array and `File.exists?`.

This could be more clearly handled if you split the finding of the line from the returning of the line.
Moved to upstart - should be resolved in 3980db8.
Erm… I think that the error message is not specific enough. Top level scope function calls/resource definitions in Ruby DSL are available only in site.rb and not in any imported ruby manifest (due to different evaluation process of ruby dsl when importing manifests).
"read_ruby_code" is probably a better name, since this does more than just assignment.
Is this always a specific boolean, rather than a generic boolean?
Again, why did you drop the QueuedConnection?
Fixed in 2675d45b8c
It feels to me as what MRI does here is a standard Ruby coercion protocol to Integer. Looks like we need to do that too here, instead of just having a special case for Symbol.
we generally have a convention of having imports in alphabetical order
I don't think so, but maybe I'm overlooking something.  We need to see if the global *starts with* the flag minus %.
Ok i commit the change, ArrayUtils is now with the pull request, sorry.
We don't like '@' operator in ZF2, you should use [this syntax](https://github.com/lowcoders/zf2/blob/52d7535f334661103826b55f15bb192bad12d3e1/library/Zend/Log/Writer/Stream.php#L83-L85).
CS: need a space after "if", and a space before the opening "{".
Sort of...

I've just done a basic copy over of our stuff - the main reason we didn't use ProvidesEvent traits is due to the fact that ProvidesEvent is not neccesarily correct.  It may just need to know about the Event Manager (for example, for adding listeners).  So therefore, EventManagerAwareTrait is more technically correct (although the code should probably be bought in line with ProvidesEvent)
Why split this?
Since params is always set, perhaps it would make more sense to simply check if it's not null? But then again, that is already what this if-clause was doing already, so I am  kinda missing the significance of this PR. Perhaps you can elaborate?
import this classes instead of use FQDN
if you strip line #91 and #92 the effect is the same :)
@ralphschindler I changed the implementation. It's now much faster. Tested various combinations, and this seems to be the fastet.
@cursedcoder query parameters have nothing to do with the QueryBuilder (which is simply a way to build a string).
Should be `/var/www/KnpBundles.com-prod/site` or similar
Is the ToArray() necessary? Also, the comment directly above is unnecessary, since it's fairly obvious what's being done.

The same comments apply to the updateMouseCursor function
Two lines of blank code MAX
Added braces where missing...
@vesak Tässä on virhe. Tsekkaa kyselyn GROUP BY ehdot! Käytännössä yhdelle karhulle voi tulla useamman asiakkaan laskuja.
You're right, it's probably not necessary. I guess I was just afraid of self._status becoming out of date *for some reason...*
This should not be hardcoded since it's perfectly possible to change the prefix in the routing config. Better rely on a custom header.
rename to os_env_re
You should add some comments about this dep.
Did you write this polyfill yourself, or copy it from another project, blog post, etc? If so, please could you put a comment referencing where you got it from and crediting the appropriate order.

Speaking of credit, please can you update the changes at the top of this file, and credit yourself. Version should be 1.10.
Oops, my bad.  I fixed it.
Wait, I'm dumb. I mixed this one up with a different one. You're right. WHOOPS.
2 blank lines required here.
And, putting it in its own function is unnecessary abstraction because we don't use add_profilepic anywhere else
Same here re the tindebox pull.
Would it make more sense to sort at the start of the run() function?
I think the first frame should count as changed...
looks like we need a helper method to return the api version etc
Can you name this variable differently - cnt1 and cnt2 are distinct so I think their names should more accurately represent the values they store.
Why would you ever want to delete an event?
Can we not instead use some sort of flag that if removed, prevents it from appearing on the dashboard.
You can just pass ```null``` in place of nsResolver below.
don't understand the above, why not just sender ! self
Basically for me, I'd like to keep *.module files to only hooks. I didn't really have a place for these functions but I thought that they will be used enough to justify being in the global space.
you can actually write this

```ruby
rescue
  # something
  raise
end
```
a parameter for flux or mag limit of the source might be nice since the fitting will be more accurate on bright objects
Wait, I'm not convinced that this requires a massive rewrite...

I'm looking at the API now and at least at quick glance, there doesn't seem to be anything that would be inconsistent with switching to a `Quantity` or `NDData` subclass. I think the switch would take an afternoon's time.

I also object to naming something `Coordinates` when you in fact mean *a point or points in spherical coordinates*, but you can see my comments on the other pull request about this :)
Please undo your indentation change. Otherwise I can't diff via github. And also breaks blame and so on.
Change made... hopefully doesn't break anything else... ;-)
Maybe we need a `data_file_url` method?
Please format appropriately
Same thing here with the purpose of the function. Return reference to a temp file?
In addition to this, it's probably good to verify that an alias with non-allowed characters cannot be created (e.g., \: )
why not just do `return true  if @chLevel == -1` here instead of the below lines?
I've added this assertion to the refactoring library where the index is created.
The fact that it is placed on bootclasspath is the implementation detail. There must be some reason why it's done this way from the user perspective. I mean there must be code that compiles only if scala-library is on bootclasspath. I don't think we can extract the actual bootclasspath option from sbt, and I don't think we should even try.
This could be inlined in the ``act`` method, as it is not used anywhere else (less code :))
Waarom heeft de spawn point een enemy health reference nodig?
Updated that in a separate commit ... this pull request was never related to that.
Thanks Phil. I don't think this would produce the same result though. Adding $key => $babe on line 240 would result in $key most likely being a numeric index. The two key() calls are there to 1, grab the first key of the $babe array, and 2, grab the first value. 

Instead, I'm going to set key($babe) to a variable and use that twice, instead of key() twice.
Не спорю, так даже строк меньше в коде. В принципе, ваше право, как реализовывать. :)
--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
Указаны неверные границы для цикла из-за чего возникает лишняя итерация замены.
Нужно быть осторожным, так как с объектами оператор сравнения будет работать со ссылками, а не со значением объектов. Если ссылка будет одна и та же, то всё будет замечательно, если нет - то может быть не то, чего вы ожидаете.
у вас неправильное условие
Пофиксил https://github.com/volt0/osx-project-1/commit/ffd33cf7f4affc6394a89c4328766ae2ff562360
не понял, что за m?
но у Вас, разве абсолютная случайность номера получиться?

я то как сделал, 
- берем массив от 0 до 99
- делаем рандом из массива, это элемент это номер который по основному списку надо перерандомить
- после удаляем индекс этот, получится массив номеров с эл-тами от 0 до х-1 и далее от х+1 до 99 к примеру,
- и так далее так нам не надо более делать проверок и мы всегда причем абсолютно всегда получим случайные выборки, причем с первого раза ))
кажется решение очень даже красивое) да и по скорости случайного перебора неплохие результаты)))
Это требование есть в задании к проекту, перечитайте ещё раз. "Не согласен" - в данном случае непонятно с чем.

Заказчик у вас заказал разработку класса, у которого будет метод mutate, что поменяет строго х процентов от исходной последовательности. Когда он получает от вас готовый проект, то первым делом проверит, а не обманываете ли вы его? Проверяется очень и очень банально - выводится последовательность до мутации, мутируется, допустим, на 100% (то есть, новая последовательность должна полностью отличаться от исходной), выводится изменённая последовательность. Заказчик увидит, что изменены не все 100% и назовёт вас обманщиком. =)
Два раза мутируете одну и туже клетку
Added that in the setter for client since we have different places where this option gets set (b398e6e)

This config seems misplaced and I might move it somewhere else in the future
Please fix the indentation. It should be 4 spaces per level, not 8
Thanks, I played with a few syntaxes to pass the block through directly,
they all looked hideous.

This is nice, I'll remember it. Cheers.
On 3 Oct 2012 09:20, "Ben Hoskings" <notifications@github.com> wrote:

> In lib/babushka/parameter.rb:
>
> > @@ -106,6 +106,10 @@ def to_a
> >        value.to_a
> >      end
> >
> > +    def each
> > +      value.each { |i| yield i }
> > +    end
> > +
>
> It doesn't make sense to add #each without also adding the rest of
> Enumerable. I'll look into that.
>
> Also, this would be better written as
>
> def each &block
>   value.each(&block)
> end
>
>  —
> Reply to this email directly or view it on GitHub<https://github.com/benhoskings/babushka/pull/222/files#r1745326>.
>
>
Getting the MAC from an IP already exists with 'arp_get_mac_by_ip' in 'util.inc'.  Or even in the pfSense php module with 'pfSense_ip_to_mac'.
Can you remove this import-package line?
Think so, you did mention earlier that a signal could possibly behave differently depending on the subscriber or track state in the subscription block.
Ah sorry, totes missed that.
Ok, I'll wait your changes and then I'll merge.
Thanks!
同上上，是:else吧？
The advantage of `Data` is that it's automatically serialized, whereas custom properties are not. What about public properties that encapsulate retrieving the code/class from `Data`?
I would call this parameter `endpoint` (in which case the `help` description would be something like "the API endpoint to call").
My mistake. I thought we already had commons-validator :(  I need to check with Joaquin if he wants it to be back ported to 1.9.2. In that case we can't add a new dependency... On the other hand if we are going to add a dependency I'd prefer hibernate-validator instead.

Anyway I'll handle it from here. Thanks Citigo!
I did modify only line 49: changed <code>prog.setName("MDR program")</code> into <code>prog.setName("MDR-TB PROGRAM")</code>.
This was in order to match the program name in the fixture XML file.
I had to change the fixture to make sure program and concept names where matching.

But yes, the rest is line ending oddity, maybe because I use IDEA, not sure.
Cool :)
You just forgot the parenthesis after `run`, but that’s not so important…
Can you squash your commits into a single one?
the class name is broken
You should remove this empty line
每块缓冲区的大小默认等于一个内存页的大小。

每块缓冲区默认等于一个内存页的大小。
thanks for your suggestion.
i want to say so.
I agree we do need to make sure that people use "Examples" instead of "Some Examples" and "Parameters" instead of "Arguments" (for example), but a docstring is and should be more than just an API reference.  Limiting to only API reference specific headers either prevents people from writing useful discussions in the docstrings, or else they will end up all chunked together under one section (the simplify() docstring in its present form suffers from this problem).

So I still say we should fix this.
Should this be called for every recur?
Зачем? Оно дергается по Release в IPLugin
Won't this code be executed even if the user requested a reverse search? I don't think that's what we want?
Here the issue is that it could be confused with File().getName() which would be something different. As the result from File().getPath() is stored I should refactor to FilePath probably.