labofsahil/github-event-dataset-2012 huggingface dataset:
By default the nova.conf does not include the default --ospai_compute_extension flag: 
    --osapi_compute_extension=nova.api.openstack.compute.contrib.standard_extensions

When adding our flag, we need to ensure that this default is not completely overridden -- basically we need to add both flags:
    --osapi_compute_extension=gridcentric.nova.osapi.gridcentric_extension.Gridcentric_extension
    --osapi_compute_extension=nova.api.openstack.compute.contrib.standard_extensions
I thought SKIP_INDEXING doesn't matter, as long as the index object isn't annotated for indexing.
Complained about what? IntelliJ's fine.

I don't see how the duplication thing has anything to do with RemoteExecutable. 

You can for sure extract a single method that receives an annotation class and does the 2 for loops...etc
Yep… I'm aware of the difference. In `diff.h` it was documented as megabits… I doubted whether that was intended but I didn't change it in our docs (for obvious reasons).

@arrbee is the libgit2 documentation incorrect?
I'm inclined to agree. It would break backwards compatibility though, as passing a python ```float``` is currently handled by casting to an ```int```. This approach doesn't break that "feature". Preferences?
OK, I used this wording in f964e67.
Cool. Glad it inspired you! :smile: 

I think we can use your new syntax here now. Thoughts?
Move this into the actual test
I'm not sure how reliable this is given that you are relying on sleep + a time wording change.

Possibly a cleaner way is to remove the above sleep and this and instead do a wait for condition until you see that the current time has hit one second.
Can you make this into a mixin rather than another different stylesheet?
Same `s3d-search-result`
Can you split these up, for readibility?
@dooremont Can you fix this?
@bp323 Can we use `on` instead of `live` here?
please use a new line for {
Seems like putting the `else` in here would break being able to say (e.g.)…

    checkBox.writeAttribute('checked', false);

…and having the `checked` attribute be removed.
doh, yes, right.. sounds like you have a plan!
Unless we serve Helvetica Nueu from typekit, probably shouldn't be here.
``` @custom_fields.map {|e| {:id => e.id,:name => e.name,:show_type => e.show_type}.as_json   }.to_json``` заменить на
```ruby
 @custom_fieldsto_json(:only => [:id, :name, :show_type])
```

Я тебе это тоже говорил когда-то
> Second, how do I package extensions for the test so that they can automatically be added?

I'd assume a special folder within the test frame work for files to be included, and then within the test tell it to copy them into the folder?
异常不能吃掉，传递给外部。
had to do this :poop: . Rotates and flips the HTML5 Cavas in order to get the correct coordinate system. I blame Cocos2d.
It is documented higher up in the pull request. You are all welcome to make your own pull requests based on this one changing as much as you like to whatever you personally deem more useful or intuitive. Personally, my opinion stands as is, and also, I don't plan to have computerized net access for most of the month of December anyway, so little will change here.

That said, I don't believe the repository maintainer has the time or interest in accepting pull requests; this and other good patches have been sitting untouched rather long.

(Yes. The whole pull request is to save myself and others writing this assignment loop and storing away the key:val pairs object outside of $.cookie.)
Good suggestion - i've revised it to be more friendly.
A bounds check here would be good.
I agree with you. But just not yet.
No, it's a string. This needs to be addressed when we look at how to handle the responses better. That will get addressed with error handling code we discussed.
`Array(nil)` returns `[]`. I think you could just as well write `[]` instead of `Array.new`, no?
done, and done
Move this line to the end of previous line.
Uff, am I following - I have to define dependencies and implement api to signal map ready or one or the other?
Don't change text case.
*Foursquare profile data fields are:*

Please use the same way of listing (with `:`) as other backends do.
Use constant strings for keywords. So `type` -> `'type`'.
No, provide link to post object, not post_id.
Hm. Never use inline CSS.

Why you hide by default? You should render only those which are activated anyway?
Use `blocktrans`.
Ok, but get error: 

from piplmesh.panels.horoscope import horoscope
ImportError: cannot import name horoscope
how do you usually test if ES platform will be broken ?
I never used ES in my life and the bot did not worked for me >.<

the above fix is easy but the one in ...DrawElements...
i dont even know the problem,
how do you usually test this sceneraios ?

Thiago Dias Pastor


On Wed, Feb 29, 2012 at 7:20 PM, espes <
reply@reply.github.com
> wrote:

> > @@ -192,11 +191,6 @@ public static void FillMode (RasterizerState state)
> >                               GL.PolygonMode(MaterialFace.FrontAndBack,
> PolygonMode.Line);
> >                               break;
> >                       }
> > -#else
> > -                     if (state.FillMode !=
> Microsoft.Xna.Framework.Graphics.FillMode.Solid) {
> > -                             throw new NotImplementedException();
> > -                     }
> > -#endif
>
> Breaks build on ES platforms
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mono/MonoGame/pull/324/files#r504170
>
`os.walk()` doesn't recurse into directories by default, so this isn't needed.
I'm not sure if it's a good idea to remove the prefixes, because load/save will drop them and QL will not see the tags anymore.
Can we get this as one class per file? I'm probably being picky, but 90% of the time it makes to easier to find a specific class.
I have moved the functions now, and checked the demos.

The 'premultiplyMat44' is moved to Ma44 and is now 'preMultiplyVector'

Thanks
Phil
nitpick: `seconds`.
1) INFO is too high for this. DEBUG would be high enough, but actually I'd remove the logging line altogether.

2) Even if wanting to log this, make sure you don't concatenate strings on the hot path: please use the logger syntax with a placeholder pattern such as ``%1$s`` (see how ``Log`` interface is used in other cases)
this change is correct, but if you hadn't changed the spacing of line 99 the patch would have been smaller
I'm having some difficulty understanding how to provoke those other JoinWalker subclasses into action.

Since my own complaint was more specific, and I don't yet have the understanding needed to tell whether there is a more general problem, I'm wondering whether the preferred approach would be to override #orderBy in AbstractEntityJoinWalker or CriteriaJoinWalker, instead of patching JoinWalker?

Thanks,
Tommy
That's cool. I'd put a warning call also here, so people move to the new style
Do we need visibility qualifier here ?
Seems like you could make it non-static. Static functions in a header don't make much sense to me :/
You'd think so. That would explain why the boxes in modelviewer are wrong. However adding the descender height will (I think) make the text entry box in the sector view too high. I'll look into it further.
Is there a reason you used output args instead of just returning the value?

Actually now I look at it, why is any of this necessary? The templated ones perhaps, but for the basic types? Or is it just to try and make a standard call that works for all types?
Should be on the same line as the else
It would make the code shorter and easier to read if you didn't rename these (I'm also thinking they should just be one argument for mean, not mu1 and mu2), but something like 

```
if mu_min is None:
    mu_min = self.co_mean()[0] # why slice here?
```

Then you're not having multiple names for the same thing.
I don't see anything that indicates that the x in this equation is X_i. Why not just write X_i? I always assumed that x was just some grid that covers the support of f_hat. This is how I interpreted its use elsewhere, e.g., equation 2.2. Does what I'm saying make sense? This is why I assumed that the FFT estimator will be of great benefit because we have to evaluate n full densities, ie., the likelihood of it's entire density over it's entire support. I'll have a look at the original papers and see if it sheds any light on my confusion.
@rmurphey — this is what you had in mind re: the setter, correct?
Worth having a try-catch around this stuff? We risk losing the user's original exception if there is a problem (e.g. flaky cloud or network or whatever) while building this log message.
Unfortunately, @jashkenas disagrees, and I'm not allowed to use that style in the official compiler. It makes me sad.
Might be good to pull a.length out into a var here. Besides making the string code here simpler, it reduces the size of the generated function which increases the chance of inlining.
What is the $70/mo for?
ping_master? It should be last_is_master IMO.
Hannes Magnusson <notifications@github.com> wrote:

> > +#endif
> > +
> > +#ifndef Z_UNSET_ISREF_P
> > +# define Z_UNSET_ISREF_P(pz)      pz->is_ref = 0
> > +#endif
> > +
> > +#ifndef ZVAL_COPY_VALUE
> > +#define ZVAL_COPY_VALUE(z, v) \
> > +    do { \
> > +        (z)->value = (v)->value; \
> > +        Z_TYPE_P(z) = Z_TYPE_P(v); \
> > +    } while (0)
> > +#endif
> > +
> > +#ifndef INIT_PZVAL_COPY
> > +#define INIT_PZVAL_COPY(z, v)                   \
> 
> Are these for realz? I assume this is a PHP5.2 fix, not a windows
> build fix though?

Correct, that was for 5.2. Surprised me it compiled at all in linux.
So, technically, that's a module-level docstring and therefore applies to the module, but you're writing it in the context of user_created.

I think you should tweak it to look like the docs changes you did. Something like this:

    .. data:: user_created

       Signal triggered when the Browser ID authentication backend creates a new user.
       Sender is the function that created the user and user is the new user instance and
       you're a Scottish Lord and I'm Mickey Mouse.
Some of them were, yes.
With an empty basket, going to the shipping method page, for instance, doesn't redirect backwards to the shippng method view, but forwards to the payment details view (shipping is not needed).

Most of these methods test situations where the shipping details were not supplied. An empty basket does not require shipping but this information has  previously been stored in the session in the shipping address view. And the tests do not go through that phase - the behavior was as for a basket that does require shipping. So since no-shipping logic has been introduced those started to test a slightly different cases.
Now that we check this requirement at each stage - the tests started to fail.
Those methods do different (but similar) things - you're right that the method names are misleading:
* ``offer_discounts`` - this returns discounts that apply the basket only (not shipping) 
* ``get_discount_offers`` - this returns offers that apply to both the basket and shipping

I'll rename the methods for clarity.
Nano-point: Two hashes for comments?
this can be a QModelIndex i think, it's not being stored anywhere?
There's nothing wrong with this but one consideration is whether the user of this API will ever need to use it more than once at a time?

If you want to process 1000 walkscores, is it really necessary to create 1000 walkscorefetchers, or would it be better to create one and reuse it throughout your loop?
Thanks @schu. It should be fixed now (I tested on my Linux VM). Can you confirm when you get a moment?
What is the official JSDoc syntax for specifying array types?
I've always seen it as `Array.<string>` similar to Java/C# generics, but that might just be the google superset of JSDoc way. Couldn't find any official docs after a quick google search.
Why do you need to move this ?
Trebuie sa adaugi in doc block ul functiei si parametrii pe care aceasta ii primeste folosind tagul @param. Ex: @param nume_parametru descriere_parametru. Toate tagurile trebuie sa se alinieze. Ex:
@param ceva     Descriu ceva.
@param altceva Descriu altceva
Hai sa scoatem linkul din descriere.
Sorry this shouldn't really have ended up in this request.
Uneeded and hacky check, the aura scan down there does the job already, not to say this one will only check for deadly poison, what if the target has Wound or Crippling poison?
also a lot of classes seem to have exactly the same logic, could be DRY up by using a DSL?
Если класс A содержит класс B, то это корректная ситуация. Надо десериализовывать класс B.
Это вообще компилироваться будет?
Странное условие в for. Но этот цикл вообще не нужен, т.к. значения массива по умолчанию - false.
So Bigtent now respects `NODE_ENV` which can be set to production or development.

This can be changed in local.json with

    ...
    "env": "development",
    ...

The default for this setting is production mode.

In development mode, a page will render links to the original sources.

In production mode, a page will render a link to the minified source. Cache urls will be created to improve performance.
Bebe and I had a chat about it and think it's something we should pursue. It's a bit of a juggling act between native events, aut compatibility and so forth. now we are experimenting with using Aurora instead of nightly which should be a bit more stable.
Bad, do not return null. Return is either one loader or other, there is nothing between. If you get here and have to return null you obviously didn't carry out appropriate checks or you do not trust your code
You need `import email.utils` here.
Is this intended to be moved outside the `<artifactItem>` element? (I don't know much about this, just asking).
Oh yes, obviously. Sorry, my brain hadn't turned on yet, I'm still not done
battling british cold viruses. So in this implementation, we take a
Bernoulli sample for each input vector every time.

In Hinton's class he calls this "hack" mean-field logistic input units and
says it's appropriate for digits and such, but not for real images.
Apparently Gaussian RBM's aren't practical to learn, but instead he makes
the case for stepped sigmoid units, or rather, approximating a sum of
stepped sigmoid units as a linear threshold unit. This shouldn't be
difficult to add to this implementation.

A place where we don't need hacks and the input data is truly binary would
be with vectorized text. Maybe we can make an example out of that. This
also makes me back up @mblondel's comment about making this support sparse
matrices.


On Sun, Dec 30, 2012 at 1:18 PM, Andreas Mueller
<notifications@github.com>wrote:

> In sklearn/neural_networks/tests/test_rbm.py:
>
> > @@ -0,0 +1,39 @@
> > +import numpy as np
> > +
> > +from numpy.testing import assert_almost_equal, assert_array_equal
> > +
> > +from sklearn.base import clone
> > +from sklearn.datasets import load_digits
> > +from sklearn.neural_networks import RestrictedBolzmannMachine
> > +
> > +np.seterr(all='warn')
> > +
> > +Xdigits = load_digits().data
> > +Xdigits -= Xdigits.min()
> > +Xdigits /= Xdigits.max()
>
> You mean about the difference between Gaussian and Bernoulli RBMs?
> Bernoulli RBMs have visible units that are either 0 or 1, Gaussian have any
> continuous value. Actually MNIST and digits are not really binary, but
> using it any way is more of a hack. The distribution of each pixel is
> heavily concentrated at 0 and 255 (or 1 if min-max normalized) still, so
> this can be modelled quite well with a binary distribution.
>
> If you do PCA, you will lose the concentration at 0 and 1 afaik, so you
> need to model real values, i.e. use a Gaussian RBM.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/scikit-learn/scikit-learn/pull/1200/files#r2521235>.
>
>
iter_set should be typed as an nd.array. In general, for fast Cython code, typing as much variables as possible is required.
`self.responses = responses or []` would be more Pythonic, muppet.
All classes will have the following tucked in at the start of it's record
```
class {
  void** _vtbl;
  void* _monitor;
}
```
Both being pointers, they will either be 64bit, or 32bit in size (D does not support 8bit or 16bit pointer systems...) so D_LP64 rules apply here.
This adds a warning
we should iterate through all the containers:
In case if  zIndex is smaller than the previous value, we should put it back (smaller index).
use prefix underscore for static member functions
No need for this to be a QObject.
drop cloudstack.provider prefix and move to ProviderOptions
You should be basing it on the capacity of rows not how many are committed (which I thought was the case).
The capacity will only change when rowsToSort has to expand.
Does this need to be in the xsl/xsd files?
You two are getting me confused...

We have three ways to go now:

1. Change only the temp to 64bit (as it was to begin with) and avoid the overflow without too much change. We can change the rest later, and remove the local cast.
2. Leave as 32bit for now, that will give us about 22bits (4m) rows on a big cluster (up to 1000 nodes), so we can make the complete change later.
3. Make the complete change now, move everything to 64bit and possibly create a new activity ```inlinetable```, as suggested by Gavin.

I would choose 1 or 2, since it's localised and makes it easier to understand change history (and revert changes).
I meant to say I agreed with RKC's summary.
Yes true, I will modify.
This should be called appendOperatorText if it is appending to a private buffer.  

If the builder is split from the import then it will need to be an independent function, and shouldn't then be appending to private buffer.
Do not want this diff in the pull request.
Moved it to the end as apposed to loading JS in the head
Not quite sure what you mean. Is it QueryReferenceExpressionFlattener.FlattenableResultOperactors and ResultOperatorExpressionRewriter.rewrittenTypes (which both contain e.g. the CacheableResultOperator)?
Please add a comment!
See my notes above -- $controllerName may not be an alias in many circumstances.
I generally prefer to use JavaScript over jQuery where possible (JavaScript is probably faster and I don’t like to use third-party libraries when I don’t have to), and I feel that it is cleaner to manipulate the DOM directly rather than mixing JavaScript and HTML.
OK pour l'id Je préférerais un nommage systematique a base de #section-{x}
```css
#section-stickers {
```
Of course! My main test dataset has been a queryset with 24 objects in it, so I didn't notice the default of 25 from the Meta.
sure i can, you think its usefull to run tests for sniffs in older versions as well? easy change
```ExcellentRanking```, see https://github.com/rapid7/metasploit-framework/wiki/Exploit-Ranking
This SAP* default password, in which versions work? Can it be used as default SAP* password for other modules? Lot of them just have username, password and client set tu null
On my test, payload can't be deleted

<pre>
[*] Deleting Payload...
[-] stdapi_fs_delete_file: Operation failed: Access is denied.
</pre>

A warning message, giving to the user the location of the file to manually delete it, if it cannot be deleted automatically, would be really helpful I think :)
I would do:

raise ActiveRecord::RecordNotFound if @object.nil?
Addressed in latest push.
Again, breaks Django's style.
Natanael90; probably so :)
Generally, we - or at least I - don't want tests to depend on external resources.  We'd like them to be able to run on a closed network, and to have the reliability of not depending on third-party - or even our own - servers being up.  What are our options?  Can we mock out the server?
Did we always throw this exception?  Strangely, users love to be able to create polylines with no positions, or remove the positions later.  It can simplify their application logic a bit.
This isn't available on android.
extraneous parenthesis
Should also include a pass, so that Android works.
Is the proxy always guaranteed to have children?
Проблема этой функции в том, что каждый раз при вызове она будет генерировать новый шаблон, а не реиспользовать старый

```javascript
$.template("eventTemplate", "<p>Событие: ${Name}</p><p>Начало: ${Start}</p><p>Конец: ${End}</p><p>Продолжительность: ${Length}</p><p>Рейтинг: ${Rating}</p><p>Место: ${Place}</p><p>Комментарий: ${Comment}</p><p>Сcылка: ${Link}</p><br>");

Event.prototype.createSection = function () {
    $.tmpl("eventTemplate", event_temp).appendTo(el);
}
```
It's possible to reduce the number of getFirstMatch() with getFileHandle(). Call getfileHandle(file => "somewhere") once to open the file and loop on the handler..
The localStorage API throws a ValueError exception if you don't supply the proper number of arguments. Typically, you try/catch read/writes for most resources (like files, for example); hence, throwing an exception feels standard.
Да, есть такое. Надо что-то с этим придумать будет... в новом году.
What happens if the JSON input ends prematurely?  Does that also throw EOFException?
I sometimes had issues with passing a long string to wkhtml, it outputted a blank PDF. A file never failed when I tested that, so just added that option and moved on with my project. It might been specific to my installation, don't know.
support for next in 2.5: edwardgeorge/virtualenv-clone@2884f6494a1532e7d82759a278d11d66bbd55775
and modifying exception handling for 2.5 compatibility: edwardgeorge/virtualenv-clone@7954db6c4d04217c9d4dfe2bdfee4a3f5d341504
Yes, you're right. I thought that in this way it not only deallocates pdata but also calls g_free() for each element.  But by default element free function pointer is NULL.
what else could you think of?
Maybe we should throw a more distinct Exception in the TransformationEngine
maybe "TransformationException" or something more specific
this looks like a bug - two x0s in the else{  statement?
What should your email be replaced with?
Does puppetwinbuilder now contain signtool?
Não precisava desse teste, está igual ao de baixo.
Shouldn't this use `buttion('option', 'showingAlternate', true)``? This reinitializes the button, which is at the least unnecessary performance burden, and might even override previous options on an already initialized button - can you check and fix?
There are also a few library search paths:
```
				LIBRARY_SEARCH_PATHS = (
					"$(inherited)",
					"\"$(SRCROOT)/Airship\"",
					"\"$(SRCROOT)/../../dev-ios-library/Airship\"",
					"\"$(SRCROOT)/../../../Library/Developer/Xcode/DerivedData/AirshipLib-drxxzexkdjzwtzdbobeowgblzgsd/Build/Products/Debug-iphoneos\"",
				);
```
That's the `array(array(1))` which fail, i'm working on it.
but do we actually want to support that?   especially once NelmioApiDoc supports this stuff with the sandbox there are no more excuses to allow POST params via GET
They run as mstest without a UI.  This  should go away with the configuration api.
value -> jasonValue
_activeTokens is designed to be shared, that is how the WrapTokenManager is designed. I recommend you to take a look at the design WrapTokenManager in Java. Thanks!
--Al 

-----Original Message-----
From: Jason Cooke [Microsoft] [mailto:reply@reply.github.com] 
Sent: Monday, June 11, 2012 3:09 PM
To: Albert Cheng
Subject: Re: [azure-sdk-for-php] Strict fixes (#460)

> @@ -117,7 +117,7 @@ public function __construct($wrapUri, $wrapName, $wrapPassword, $builder = null)
>             
>          $this->_wrapRestProxy = WrapService::create($config, $builder);
>          
> -        $this->_activeTokens = array();
> +        WrapTokenManager::$_activeTokens = array();

Ah, yes. That needs to be fixed. Thinking about it more, `$_activeTokens` should be an instance member, as it would be wrong to share these tokens across instances, with potentially different Service Bus services.

---
Reply to this email directly or view it on GitHub:
https://github.com/WindowsAzure/azure-sdk-for-php/pull/460/files#r963376
What is the end-user use case here? How are end-users expected to do this?
Less indentation? Just 4 spaces?
I think as long as there is a `require_tree .` in application.css, these will automatically be pulled in. I will play around with this and make sure.
Have you reviewed all the other annotations? Whether they make sense on methods?
added to #9
``AsseticExtension`` implements ``ConfigurationExtensionInterface``:

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/DependencyInjection/Extension/ConfigurationExtensionInterface.php
I didn't know about this. Thanks for the tip.
Should this instead read:
```
extern (Windows):
nothrow:
```

Saying that though, whitespace is not of a concern... :)
To anyone familiar with atomics, the name `Sync` is probably clear from the name of the members alone. But if we are changing it anyway, would going for something more descriptive make sense? Unfortunately, I don't have a really good suggestion; `MemoryOrder.acq`? `OrderConstraint.acq`?
include jquery datepicker if necessary
The reason why I added a check for internalSolrQuery is that other modules (islandora_solr_views) might want to build solr queries as well, but I don't want them to have to set 'internalSolrQuery' because it's not used in that context. 'internalSolrQuery' is buildQuery() specific.
Sure let me add it.
<emphasis>true</emphasis>
why not keep trying for the case where the receive timeout is < 0? That should indicate an indefinitely blocking receive - so in the case a non-match is received, it should keep looping perpetually until it receives the match
Hi, Gary!
Just take a look into `groovy.lang.Script#println()`, please.

However, thank you for drawing my attention to it again.
Now I change my mind and going do it with this way:
````java
Object bean = null;
			try {
				bean = this.beanFactory.getBean(name);
			}
			catch (NoSuchBeanDefinitionException e) {
				throw new MissingPropertyException(name, this.getClass(), e);
			}
````
In this case I get the exception message:
>org.springframework.beans.factory.NoSuchBeanDefinitionException: No bean named 'out' is defined

It allows to take this class independent from Groovy API as it possible.
There won't be any note about this doubtful **out** ;-)
I see, you basically want a call to be made to IntegrationContextUtils to actually determine IF ICS is registered and if it is use it otherwise use the one provided by BF
wil fix
опечатка, должно быть "представления"
Wouldn't this generate a set of:
"plaintext0" : {hash},
"plaintext1" : {hash},
...
? 
Where we have the same plaintext but with an incrementing suffix?
I don't know if we have these URLs already as variables, but we should centralize that configuraiton.
These properties will just be surfaced via the base class, right?
Okay, my bad. Just thought it was kinda strange to use this tag, as it normally means "italic text". I deleted the other comments.
But we need them to verify that the Gem is working.....tests aren't good enough to verify the Mandrill API is working in production :)

I can always fork the gem, create a branch, etc and add debugging if something breaks.
This method is either deprecated or perhaps no longer exists in puppet 3.x.  Also, it's actually very undesirable in certain circumstances for this to happen; TestHelper is responsible for initializing the settings to the desired state in most cases, and parsing the config file will override / break those.

If certain modules need for this to happen, then we'll need to move this call into a different file and have modules that need it require that file rather than this one, but there definitely needs to be a way for certain projects that require spec helper to *not* trigger this behavior.

Ultimately I think that reading the config file from disk during testing is probably a bad idea.  It provides the opportunity to introduce huge variability between test runs on different systems; ideally we should be mocking everything that would be accomplished by doing this, though I recognize that that may not be easy / possible right away.
checking 3 passes in framework bundle they all do it the same. Whats the better way?
It sounds good to me to do a conditional link! If it's their first time clicking on the lesson, they go straight to dialog_presentation_view, and if it's their second, third, fourth, etc. time going to the lesson, they go to dialog_vocab_exercises_view. Is that okay?
define constants for these 2 account ids... don't just use the number
Currently if you wanted to specify ``layout=nondefault`` you'd do it in settings with a ARMSTRONG_PRESET like::

    'qvga': {'width': 320, 'height': 240, 'layout': 'nondefault'}
This indentation seems weird...
hello, you should use 2.1.5320 since it is the latest version (and also because if you want to use sonar to analyze your coverage, sonar uses 2.1.5320 and refuses to work with code instrumented with 2.0.5312
Would it be possible for this image to be re-uploaded so it's part of the new subreddit image system? Loading images from `*.thumbs.redditmedia.com` rather than `thumbs.reddit.com` helps for two reasons: a) request sizes are smaller since it's not on the cookie-domain, b) the browser can parallelize downloads better.

All it takes to get on the new system is to re-upload from the subreddit image editor and use the new URL.
and this part of the build
Should not be exposed, developers are expected to interact with the layout queue through methods on `TiView` or `TiViewProxy` only.
Hm? I just changed what was previously there to a method call.
Surplus line.
Kill or document.
No need to remove the final `,`. It's optional and doesn't hurt. In fact, it helps prevent the error you corrected on line 27, since you don't have to add the `,` when adding a new property.
ChatBoxes
Yup

From: Eric Pearson [mailto:notifications@github.com]
Sent: Tuesday, November 20, 2012 07:21 PM
To: blackberry-webworks/BB10-WebWorks-Framework <BB10-WebWorks-Framework@noreply.github.com>
Cc: James Keshavarzi
Subject: Re: [BB10-WebWorks-Framework] Localized blackberry.app.name and blackberry.app.description (#277)


In ext/app/client.js:

>      value = readOnlyValues ? readOnlyValues[field] : null;
>      Object.defineProperty(_self, field, {"value": value, "writable": false});
>  }
>
> +function getLocalizedText(data) {
> +    var locale = navigator.language.toLowerCase();
> +
> +    if (data[locale]) {
> +        return data[locale];
> +    } else if (data[locale.split("-")[0]]) {
> +        //Region specific locale [i.e. fr-CA]
> +        return data[locale.split("-")[0]];


this returns fr for fr-CA?

—
Reply to this email directly or view it on GitHub<https://github.com/blackberry-webworks/BB10-WebWorks-Framework/pull/277/files#r2189016>.



---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
I'll be removing this one too. We always quote using `N'` prefixing. Before you ask, should we, yes! There is a long story to this, browse issues if your interested.