labofsahil/github-event-dataset-2012 huggingface dataset:
How much of this should we include in the router documentation? The router and apps are very intertwined, so I realize there will be overlap.

I'm thinking that since the phases themselves are technically an aspect of the router workflow, we should document the phases in topics/router. And we could probably split the documentation up based on the perspective of each function. For example (this is really rough):

Router:

State that the router uses a message processing workflow with a series of phases. The phases are hard-coded and always processed in the same order:

* ``filter`` - short description
* ``parse`` - short description
* ``handle`` - short description
* ``default`` - short description
* ``cleanup`` - short description

Each RapidSMS app can tap into any of these phases. For every phase, each app is provided with an opportunity to interact and possibly take action. Generally speaking, ``handle`` is the most widely used phase, but they're all important. Apps can control the flow and short-circuit the message processing process by returning True in some of these phase. App ordering is important then, so make sure to order apps appropriately in INSTALLED_APPS. Please see the App documentation for more information on interacting with each phase.

Apps:

The intricacies of the return values and short-circuiting are easier to describe from the app perspective. I would probably cut out ``BaseRouter.incoming_phases`` in this section and focus more on "these are the phases that you can use".
I've seen it mixed. [Range#step](https://github.com/rubinius/rubinius/blob/master/kernel/common/range.rb#L324) and [Rational#divmod](https://github.com/rubinius/rubinius/blob/master/kernel/common/rational.rb) use `return` but [Numeric 1.9](https://github.com/rubinius/rubinius/blob/master/kernel/common/numeric19.rb) doesn't. I think it'd be worth asking. @brixen @evanphx, what do you think about using return in the last line of a method?
Because of the deprecation warning. Maybe it was too early
err... false.
Should this be `'space delimited strings'.w()` ?
noaaaasdfa
you could replace last % with , -- should avoid unneeded interpolation right here... not sure if would be of any visible performance boost though ;)
I don't like that this needs to duplicate the injectResponse from PhpRendererStrategy
*Composite
line length > 80
With  $this->assertEquals($client->call('testFunc2', array('WorldSSSS')), 'Hello World!');, it's not equals, normal ... where is the problem ?
is this variable missing or is the @param wrong?
Je trouve la formulation un peu étrange: peut être reformuler comme "une estimation s'en approchant toujours mieux ?"
If this field is True, then we don't make a query on UserProfileTodo at all
if you give string.split() no arguments, it splits 'intuitively', meaning any whitespace characters are delimiters. This is most likely what you want here.
See [here](http://docs.python.org/2/library/string.html#string.split) for more info.
Can you help me understand what I need to replace?  The docs on that function are pretty opaque and its implementation is just an indirection layer, so it's not clear to me what, precisely, is being duplicated.
are we all uniformly rejecting KnpBundlesBundle:Score notation?
I think there was an issue with it resulting in the hurt animation.
Call it: app.css
You seriously should :D
Removed in 0a50194c460bae03447c553993b5ca92f417e6ef.
Already removed this. Was some leftover from the initial prototype.
As you already noted, the copyright appears to be incorrect. CVS ID lines should be removed.
oh, i see. it defaults to false but only allows setting to simple/full. ok like this then. still can we have the two next to each other please?
@dbu I am not sure what is the problem (if any) with the change I made. I just changed what should be changed due to composer changes. If there should be any version I'll add it. But I would like to see phpcr and composer stable with milestones, so we could make proper version for proper features supported.
done, I initially wrote this code against old elixir version without `Keyword.from_enum`
This is actually tricker. Should we return an atom or a module name?

      Module.split Very.Long.Module.Name.And.Even.Longer
      #=> [Very, Long, Module, Name, And, Even, Longer]

Is different than:

      Module.split Very.Long.Module.Name.And.Even.Longer
      #=> [:Very, :Long, :Module, :Name, :And, :Even, :Longer]

Do you have use cases for this feature? I am actually thinking we should
return binaries.
I assume that sorting is done alphabetically, ASC ?
get rid of these. values should come from module constant (s)
Does sensio connect actually require this? I don't see the `response_type` mentioned in the spec when retrieving an access token.
I'm a little concerned about this. Does anyone know if STDOUT just ignores `#close`? I tried it with multiple formatters and it didn't cause any problems, but seemed worth pointing out explicitly.
Why is this needed? The patch makes it so that SANITY_FILE always exists, I think?
Don't use `new Error()` it adds a default "stack" to every object use this instead:

````js
MyErrorSubclass = function() {

};

MyErrorSubclass.prototype = {
  __proto__: Error.prototype
};
````
I agree that the 5 locators are more readable.
On the about page, the _footer_logo_link_locator points to a div, rather than an anchor, which is why the footer_logo_destination is coming up as None (and causing this assert to fail). I am guessing the same is happening on the other pages for which this assert had to be commented out. Looks like some pages will need to have different locators.
Shouldn't be linked it was a booboo i made when attempting something else. Removed
Indented too far? Should be eight spaces.
The closing "`/`" isn't required on an `<hr>`.
I think it should probably be `window.top` and `window.self`.
is this because of the bitwise stuff you were doing?
it is 100% broken, If you write to the socket like 3 messages at the same time (same data event) it will take a wrong path. It needs to be sync.
These were found on some of the Springer pages. E.g. http://www.journalofinequalitiesandapplications.com/content/2011/1/53
Regarding the Gist, I think that both are okay, but what I mean is that `SetTradeLimits` should be part of `Trade` instead of `TradeManager` because it only modifies properties of the `Trade` class. It just makes sense, because you are defining the behavior of `Trade`, not the `TradeManager`.
judging by the way this function works, these parameters are optional and can be specified as `nil`.

If this is the case we prefer the use of an options hash in ruby. Your function signature would look like:

```ruby
def global_settings(options = {})
  options[:upload]
  options[:reset]
end
```
Here missing phpdoc.
Оно хочет, чтобы до неё было объявлено graph::VertexWithUnsortedVector. Самый простой и, на мой взгляд, адекватный в этой ситуации способ - вынести её сюда.
change comes from merge.
Interesting, isn't this the `time` module itself, not the `time.time()` method?
I thought it would be in the header actually because that's what page object it is on. Maybe @klrmn couldn't put it there for some reason.

We can put some comments in there to make it easier to follow too.
Can you make this be `@pytest.mark.nondestructive` thanks :) We want them to be like this from now on.
I uh.. don't think we're testing meegotouchhome-nokia :)
This entire code block is not needed. QAbstractSocket::disconnectFromHost() documentation:
> Attempts to close the socket. If there is pending data waiting to be written, QAbstractSocket will enter ClosingState and wait until all data has been written. Eventually, it will enter UnconnectedState and emit the disconnected() signal.
Perfecto! en breves lo hago :)
Against our style guide. Should have a default value.
This comment is a bit inaccurate.
Please document the err
I think that the full chunk of logic, including the expiry logistics should be encapsulated outside of this model. I can't think of a fantastic place, maybe `api.picture.js` for now until we get more consumers of this security mechanism.
Done.

Setting the download URLs happens in util.js though as the APIs call down to util.getPrincipal and util.getPrincipals
Will there ever be a case where docs contains something that the current user shouldn't be able to see and we accidentally fall back to the default document transformer and thus exposing all that data?
:D I'm honored

Should I also rebase so it isn't a million commits?
There's a method in Static that can convert an item stack to a CArray, use that instead of manually building it.
we could even kill the `|| callback` operation which will be the most common use-case and just add:

```
app.set('jsonp callback name', 'callback');
```

in application.js https://github.com/visionmedia/express/blob/master/lib/application.js#L84

I dont think many people will be changing it
Well, we will see in another issue.
Also, now that it is only going to be triggered over REST, we need a test for it in the functional tests - test/functionals/phenotype_controller_test.rb ; I think it wise to test it for both creating a new one and updating an existing one
Oude code gewoon weghalen. Je kan het altijd terug vinden in de git logs
` ! is_array()` would be better.
Советую изучить вышедшую вчера лекцию 3, где описывался instance method `description` и закрепить полученные знания применением здесь.
Should be `require 'securerandom'`, it got pulled into the Ruby stdlib a while ago.
You can make this more robust by not hardcoding the maximum code value.  (Same applies to other enums) Like this:

public enum Type {
   BANDWIDTH((byte)0),
   ...
   UPTIME_7D((byte)7);

   ..
   private static final int MAX_CODE = Type.values().length;  // <- computed once during class loading time
   ..
   static boolean isValid(byte code) {
         return code >= 0 && code < MAX_CODE;  // <-- strictly <, not <=
   }
   ...
}
I think having its own exception would be appropriate.

DirtyWorkingDirectoryException? DirtyWorkingTreeException? 

Later, when merge support is included, might it be possible that checking out a branch when there are local changes is supported (e.g. is the invisible merge scenario something that we might support?) Maybe the exception should be tailored towards indicating that the local changes will be lost (ConflictingChangesException, CannotMergeChangesException...)
What makes this required?
Doesn't this corrupt the other STI tests by running them with `:class_name`? If we're testing two different behaviors there should be two different object inheritance chains to test.
can you just write subject_HIS_id as subject_his_id for naming conventions?

thx
I don't think that is what's happening here (at least I hope not!)

If you want to do a proper diff check against master, you'd be much better off merging that latest version of master into the module that you are checking before looking at the diff.
Instead of duplicating warden logic, maybe the test could simply call warden.authenticate!() in MyController's before filter passing the strategy?
where does `@gem_forge_project` come from?
I agree with @stof exactly. We should first make a PR against 2.0 with everything you have here *except* for anything that's new in 2.2. I'll then merge that in and then we can rebase this PR after that's been done.

I also agree totally with @stof in #1811, though I think we can either do that right now, or get all of this stuff added and then refactor. @romainneutron, if you're comfortable refactoring into some new sections - *great* :). Otherwise, we'll handle that later.

Thanks!
请求域 => 请求头的<header>User-Agent</header>字段
I did think about doing it this way. The problem is that it moves the exception to the test suite, which potentially makes debugging more difficult. Given that tests should *not* raise an exception, I don't see how that makes things better?

I was actually wrong about the bug being related to multiple axes - that's just what I was doing to trigger it. The problem was actually when the last axis in axes was not the last axis of the array. But clearly, there should also be tests for all the other scenarios as well.
Is now always configured (see above).
put merge on Gossip instead
Already done. Committed to my working branch yesterday :-)
One small QA thing: you should have spaces after the semicolons here.
Estas tareas que deben ser priorizadas, ¿están por encima de la línea de fin de proyecto?
This block here is potentially the same as what you had in `CommonUtils` when you parse the response from server. Could extract out the common elements into a separate method that could be called from both spots.
should be `null`
You can refactor this this way :
Coffee allows complex assignment,
```
talentArray[key] = switch val
  when "." then "0"
  when 0, 1, 2 then val+1
```
it seems that you're collecting first the top N results, to then throw away a potentially large amount of them.
Could we instead work on the _setTopDocs_ invocation which happens just before the _goToFirstResult_ to not collect the results which are not of interest?
These don't need to be cleared.
So simple (to screw everything up)!
Yeah. I was trying to make it work for 16-bit PNGs as well, but the rest of the code won't support that anyway. Changed to int16.
The numpy docs suggest that if you definitely don't want to copy the data you should modify the shape attribute: http://docs.scipy.org/doc/numpy/reference/generated/numpy.reshape.html
These two lines are my biggest concern. Presumably this is so that the CI server has the appropriate setup, but what happens is PIL & numpy already exist on the server? 

Can you easily test with different versions of numpy?
We should delete this print.
That why it throws a NotImplementedException.
Cool man. Do you mean they get done in a future pull request? I know this is super nitty. :)
This actually doesn't do what it says. it converts strings into clojure data structures.
@jsloane displayname in all cases.
@jsloane While I think it is good do have the ability for institutions to be able to do this in config.js, I don't think we should copy/paste these default options in here.
They may add to some confusion: "Why aren't my widget settings working?"

Could you make `WidgetSettings` an empty object: `{}` and explain (in comments) how institutions can use it?
And again, I think this method can be shared across the ContentQueryHandler classes.
Legal, Allison. Então aguardo a remoção dos valores "hard coded" e infra para a coleta dos dados na entrega 3.

Sobre o Redis, eu acho bacana mas se vc puder dar preferência pelo MongoDB seria melhor para a nossa equipe de infra.
Nah, the template is just one specific way of using this CSS, so that's fine. But a sample HTML setup in the CSS comments can help to ensure the styling is understood and used (the whole OOCSS thing, ya know).
i was thinking more about some config file. i know there are some named queries in doctrine but not sure how to use it.
Why did you mark this class as sealed?
@datiecher When reviewing code for Symfony, asking for coding standard changes should be based on the Symfony CS, not on your own personal preferences.
This file can be used via `django-abstract-templates` (https://github.com/tswicegood/django-abstract-templates).
I thought a little more about this and I'm not convinced that my code guarantees good internal state, especially since collecting? vs !collecting? changes the behavior of several methods; I'd like to have a consistency check *somewhere* that might tip us off. Optimally, we'd enumerate all the different state paths to figure out just where things could go wrong but that'd take some time... thoughts?
should have a `use` at the top of the file.
- Are you sure ``$haystack`` has the correct type as "array" is not a sub-type of "array"?
- Are you sure ``$this->strict == self::COMPARE_STRICT ? true : false`` has the correct type as "Boolean" is not a sub-type of "Boolean|null"?
Events and Milestones not used below
Use if BB and delete to remove properties as mentioned above. It should yield less changes and remove the need for the extra properties var.
let's use var here
:D a mistake. Thanks for pointing out
Corrected !!!
Ya, we always felt that self-contained components was a big selling point for x-tags.  Checkout our Leaflet Maps element as an example.  We embed the CloudMade/Leaflet JS mapping library right into the controls JS.
Setting the position to the origin can mean (at least) two different things:
- setting the position of the robot at the origin of the map frame (which means a map->odom transformation inverse to odom->base_link);
- setting the map->odom transform to identity (which means the robot is still away from the origin of the map).
If the second one is meant, the wording could be changed into: "Clear the map and reset the correction between map and odom."
Probably want this to be package access as well. Every other entity constructor is.
no need for parens hurrr
`user.name` вставляется в неотфильтрованном виде, здесь будет XSS-уязвимость на всех страницах где есть аватарка, если сделать имя вроде: `"/><script>alert('XSS!')</script><img alt="`
Use this if you need it. You do relative imports anywhere?
Add docstring with description.
Closers, but still not there! :-)
`apply_async` creates a temporary task just to start all of those tasks. Because we are already in the task, we could just create all tasks here.

So it is important not to wait for tasks to complete in the task (this means we simply blocked one worker from doing useful work). But we can still spawn all those tasks here.

So, `groups(weather_tasks)()`.
Hard-coded as a top-level variable.
i tried the format function to get rid of the tabs in the code and it went south. ill fix those empty lines and newlines, didn't have the time yesterday.
Please order arguments in the same order as they are defined in `authenticate`.
Why the `--foreign`? NOTE I don't know what this does, I'm looking for education. Thanks,
So yeah, this is what you mean?
delete the newline
right, havent thought of this, just copied it from the old place :)
I use PHPStorm and for this IDE shortening the class name is no problem, if a use statement exist. So when it is required to reduce the class name, I do it.
a better subnamespace would be ``Twig``
CommonEnum.named("to")
                  .valued(*sorted(refdata.language.keys()))
                  .using(label="To")
                  .with_properties(value_labels=refdata.language),
this was run when in windowed mode. resolution was not set in fullscreen
should we standardize on full test classname instead of simple name here?
if this is a cosmetic print I guess we can work on sys.stdout directly
Can you give an example? I was following the convention of other watcher defaults which are dictionaries - `stderr_stream` and `stdout_stream`.
dict() is mutable, are we sure this will not lead to side effects ?
I think I'd not speak of an "overlay". Maybe just "Close".
Drop the parens IMO.
> We'll just have to careful not to use no-brace if statements

Google c++ style is already to always use the braces, and we have been, so I think that's ok.
Why this change. This seems unrelated.
given the isregression check, the issystem check looks redundant to me. All we care about is to have the endog, exog keys.
except that isregression would break if sys is not iterable

maybe a try except (KeyError, TypeError) around allnobs.

not now, we can worry later about whether we need other "quacking" objects
This still need to be fixed
Nice improve :trollface:
We $'ed the arg to toggleDismissClue on line 115, so we don't need to in here, do we?
Sorry, will not use in future...

-----Original Message-----
From: Nik Pinski [mailto:reply@reply.github.com] 
Sent: Thursday, March 15, 2012 11:56 PM
To: N. Petkov
Subject: Re: [Scribite] Ticket 49: More support for CKEditor (#50)

> @@ -281,6 +282,10 @@ public function getckeditorBarmodes($args)
>          $barmodes = array();
>          $barmodes['Full'] = 'Full';
>          $barmodes['Basic'] = 'Basic';
> +        $barmodes['adminbar']   = 'adminbar'; # @nikp: have to be defined in custconfig.js (same for bars below)

Wrong Nikp :)

This nikp doesn't much like php ;)

--- 
Reply to this email directly or view it on GitHub:
https://github.com/zikula-modules/Scribite/pull/50/files#r565742
Conemaugh's copyright info has overwritten CONNECT's.
Sorry, just being a moron, been looking at too many docstrings this last week!

--
Barnaby Rowe
Postdoctoral Research Associate

Department of Physics & Astronomy
University College London
Gower Street
London WC1E 6BT
United Kingdom

On 20 Sep 2012, at 17:17, Mike Jarvis wrote:

> In doc/ref/GalSim_Quick_Reference.tex:
> 
> > +   \end{itemize}}
> > +\item[$\circ$]
> > +  \href{http://galsim-developers.github.com/GalSim/classgalsim_1_1base_1_1_g_s_object.html#ad6236e3153f23f1201396369dd67f1c7}{\texttt{obj.applyRotation(theta)}}
> > +  \newline \emph{apply a rotation of \texttt{theta} (positive direction
> > +  anti-clockwise) to the \texttt{GSObject}, where \texttt{theta} is an
> > +  \texttt{Angle} instance (see Section~\ref{sect:angles}).}
> > +\item[$\circ$]
> > +  \href{http://galsim-developers.github.com/GalSim/classgalsim_1_1base_1_1_g_s_object.html#a6b547741eeec4086de9abe227dae9325}{\texttt{obj.applyShift(dx,
> > +      dy)}} \newline \emph{apply a $(dx, dy)$ position shift to the
> > +    \texttt{GSObject} centroid.}
> > +\item[$\circ$]
> > +  \href{http://galsim-developers.github.com/GalSim/classgalsim_1_1base_1_1_g_s_object.html#ae0b346a8b438dedbc7f60a52220869d8}{\texttt{obj.draw(...,
> > +      dx=1)}}
> > +  \newline \emph{draw an image of the \texttt{GSObject}~using Discrete Fourier
> > +  Transforms and interpolation to perform the image rendering.  The
> > +  optional image sample scale \texttt{dx} (default \texttt{dx~=~1})
> I did have one question: what happens if max_extra_noise is 0?
> 
> I'm not sure why this is confusing. It means don't add any extra noise, so use the full number of photons (from either flux or n_photons as appropriate). This is the default behavior.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
I just downloaded a `git clone` new repository and checked this branch out to try and look afresh.  Mike is right, this currently says
```
devel browe$ more credo.txt 
credo.txt: No such file or directory
```
whe I try to look at the `devel/credo.txt`... This is because the devutils credo was simply a soft link to a location that now no longer exists... Sorry!
Also, shouldn't this test also work with each of E and B = 0 (modulo a factor of 2 in the variance)?  Probably worth adding those tests as well rather than only E_power == B_power.
If he implements storing the result internally, which Barney said he would do, then I think we can keep it as a `get` method.  Basically, I feel like the user should not worry about a significant time overhead from repeated calls to a `get` method.  Whereas a `calculate` method implies that the user is responsible for storing the result locally if they want to use it multiple times, since multiple calls to the method are implied to be inefficient.

So if you store the result, every call after the first is trivial, so that fits the efficiency implications of a `get` method.
你妹啊，这测试什么？
could you use === instead of == ?
Inadvertent whitespace.
Hello Rene,
what is going on here? Have you accidentally committed some debugging code?
that's result of js-beautify script...
Yea, IIRC that's what we do for everything else on master.
I wonder if we want CharSequence. For example, a groovy GString is not an instance of String.
I don't think these log lines are useful long-term. If the log message said `"===== Starting verifyHttps test ====="` then it would be more helpful, when looking at console output in jenkins etc.
Good point, now I get what you meant :)
Agreed, I don't have much experience with unit tests, so this is great advice. I'll make a new commit ...
If you put `aproved` in the `attr_accessible` list, any user could approved himself.
Qual o motivo de comentar estas URLs?
sort of. « network.connected » and « wifiManager.connected » **should** work, but they’re buggy at the moment. This should be solved very soon (hopefully), so I left that as a reminder. Will do a proper TODO comment instead.
indentation... man..
i wish there was a better way.. anyway
Ditto here for DataSource
and obj/machinery/atmospherics/pipe/vent/high_volume differs by having no pump and radio control, you don't need to bother making custom controls for it - if used in cycling airlock you'll have to reverse the outer pump mode so they pump air in one generaldirection (one pumping FROM chamber and one pumping INTO station and viceversa) and using simple lattive-based airvent, not compressor-based makes thigs a bit easier. Or you just use air tank which can be stolen and that would forbig engineers from coming back home.
What this file is for?
Зачем здесь toString()?
I suggest you use the locator for the edit link, in case we decide to run tests on locales other than en-US
便利で様々な方法
↓
様々な便利な方法

「様々な」を名詞に近づける文章ってあまりないような・・・。
powerfulなんで「多くの強力な方法」でも良さげ
I think you need to add the apiurls file. Other than that it looks good.
this is one of the awesome things about pull requests. You can easily have a conversation about the patch inline!!!
Please update the pull request.
I assume you mean ```DocumentRepository```?
> This is totally correct because those two lines are separated by more than 10deg

Ahh, that makes sense. I guess the center-of-mass calculation shifts the center a bit so that it's less than 10 degrees---hence the different outputs.

> Imho this is not the same, as this is no symmetric reflection... but maybe I overlooked something here.

I'm probably misreading your loop, but I don't see the difference between the implementations.
I'm getting a failure on this test. Any ideas?


    ======================================================================
    FAIL: Test a scalar uint8 image
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/Library/Python/2.6/site-packages/nose/case.py", line 197, in runTest
        self.test(*self.arg)
      File "/Users/Tony/python/devel/skimage/skimage/exposure/tests/test_exposure.py", line 88, in test_adapthist_scalar
        assert_almost_equal(peak_snr(full_scale, adapted), 28.6262034)
      File "/Users/Tony/python/devel/numpy/numpy/testing/utils.py", line 467, in assert_almost_equal
        raise AssertionError(msg)
    AssertionError: 
    Arrays are not almost equal to 7 decimals
     ACTUAL: 14.307880024819212
     DESIRED: 28.626203400000001
It matches the Liblinear function's name, and we use the phrase "training data" a lot in the docstrings.
Should `fit_grid_point` be a public function?
Okay, so let's keep that name for now.
> The year of the project's inception, specified with 4 digits. This value is used when generating copyright notices as well as being informational.

So yes, you're right, it should be 2001.
persister *FilePersister might be better, otherwise a function is being copied and passed around.
Can you use the PORTD0, PORTD1, PORTD5, PORTD6 defines here?
i feel like we could probably just get away with abstracting this behavior into `_slurp` rather than creating a separate `_slurp_from_kiln` unless you suspect that we'll be extending the extension to work with a non-kiln api that is also hg friendly and follows roughly the same code review creation workflow. 

that's my gut reaction at least, unless you think that _slurp is itself super ambiguous
This enables introducing a new function type based on the return type. This is incorrect, overloading should *never* be based on the return type.
Same here - what's the reason for copying the pointer?
Since this isn’t using the return value of the block, I think it should be using `do...end` rather than brace syntax.
This catches any errors thrown by the adapter here (e.g. if github returned an `error` parameter) so that the calling code can be made aware of this. Now the calling code can do the following to check for errors;

``` javascript
myAuth.authorize(function(error) {
  if (error) {
    // Handle error
  }
  // Handle token
  myAuth.getAccessToken()
});
```
You are testing too much in this test. Just can just rename it `test_clear_with_options` and just assert that something writen is correctly flushed.
I would also use a better option that `fooo`, like `some_option: true` to be more clear
I think the alias turned out to be a good fix.
Agreed, I'm implementing a compromise.  wait=0 happens not to do a reload... but --no-reload option means that users won't have to rely on that internal detail.
I have replaced IObserver with IConfigFileObserver, eliminating the need for a dynamic_cast.
From a usage and design perspective I completely agree that an isA relationship is best.  I was avoiding the complexity of mapping / resolving the ambiguous base class as IHpccPackageMap will be inherited twice (same for IHpccPackage below).  But I've changed it to be isA.
@rhelmer seems to agree with @ossreleasefeed on this, cf. https://github.com/rhelmer/socorro-crashstats/commit/9fbfd1d675b56f02fa2f8b212b333291774db2c5 (part of https://github.com/mozilla/socorro-crashstats/pull/72 )
This is a deepcopy of currentversions, and we don't want that data in the output
This is great! It really only just tests exactly what we're interested in.
This needs support for `attrs` too.
add try catch.
@christianv @shacker you mean, _.sortBy() that we used for the my classes widget?
I think this macro is necessary only for windows and depends probably on a define when building. I think the user should deal with it and add it's own macro here.
store this somewhere (SeasideProxyModel?) as a static, and access it here, instead of storing it seperately in each person - will save you a bunch of memory

or: consider storing sorting order in MGConfItem, so that it's persistant across restarts (and other applications using the plugin) for free?
Try to normalize scale to [0, 1] (perhaps then multiply it by input range, obtained from dtype utils).
I just "pinged" the mailing list.
`if filename`
I meant `msg.strip()` that is done before writing stuff to disk
Dangerous actions shouldn't be reachable from visible URLs, since browsers might pre-fetch the resource and trigger the action accidentally. Use a form with `method="post"` and put `confirm` as a hidden input in the form.
Hello, sorry I am in a heavy development process, so cannot react very quickly.

In your current code (which did not support pk as fk in reverse -engineering) you checked if ONE-TO-ONE assoc consisted just of 1 column, and if yes, you set the property "unique" (which is quite correct) - see above (lines 886-888).

Now in my code, I added one more additional check - if ONE-TO-ONE assoc consists of 1 column AND it is also a primary key, we do not set the unique property, because it is not needed here (PK is always unique). I did not want to have both Id and Unique present for one field.
for all queries that are supported by both implementations, please use a dataProvider to run the test with both of them
Should we fix this and the below test or definitely add a skiptest instead of commenting it out.
`getMaximumTextureFilterAnisotropy` always returned 1 even though the system supported 8, 16, etc.  I assume it is fixed by now.
I'm happy to remove this method, though I'll wait for another person to respond in case there was a good reason to put it there.
fixed in c9e11b0cc4826069d77bcff3824ce9b81b59ff0b
can we rename this to something like scrollingEnabled instead?
Almost all the code inside the harness is platform independent.  Even these differences are more of a connection type issue rather than platform issue (HTTP vs socket).  I would like to avoid breaking out platform specific files when they aren't really needed IMO.  

We could break out connection type files but the code that would exist in them would be so minimal I am not sure it would really be worth it at this time.  I think in this case that logic should be left in place due to no good place IMO for it to go right now.  If we add more connection specific logic then it may make sense to break it out then.

The util.connect() you mention is connect in the socket sense.  A "connectToDriver" method could be created but the util.js file is more for generic functionality (send generic http data, socket data, etc) than something that I consider up a level in that there is awareness of a driver specific message type ("connect").

Thoughts?
We'll need to make a mental note that the theme "titanium" will need to be set in the require config and used here. No action necessary today.
I'd probably put this at the top of the file.
https://github.com/jquery/download.jqueryui.com/issues/66
Don't worry about that. That code is actually not done. That file is just an example and it will be removed once the code is incorporated in the general process of updating the database. I'll tell you when it is done.
@hunner Fair enough. I can change this back to false and then modify the template to check if the ssl_* parameters have values similar to how `ssl_intermediate` is. Would that work?
судя по всему придется глобального пушера создавать :(
I like it better with the line breaks on phrases.  But, I guess I don't really care.
It's your method.

It was a good exercise to break it up while reading the code/docs.
Keep in mind the check is for R*2*: The Needle.

* R1, the *haystack*, can't accept infinite ranges, this is already enforced by the constraint. As you say, it makes no sense trying to count the instance of something inside an infinite ranges
* R2, the *needle*, on the other hand, *can* be infinite. The fun part is that when it is, you statically know you won't find it:

For example: "How many instances of the Fibonacci sequence can you count in [1, 2, 3]?" - " None."

It's cute, but it's correct. The normal implementation supports it, but if you can detect it statically, might as well exploit it.
Your suggestion has exposed a flaw in the logic.

As `take`s functionality relies on a Range R; and isInfinite!R, then it will return [0 .. n].
The input is a Sequence, where the slicing [0 .. n] is not relative Sequence's current position. therefore ignores the drop operation completely.

This would require a change in functionality of Sequence, or a new Range type.
`errorfunc` doesn't exist around here.
I guess it's just your style, since I'm seeing this all over the place in this commit, so I won't comment on it further, but I do think that needlessly adding newlines like this harms code readability. I definitely favor only splitting statements or expressions over multiple lines when they're too long to fit within the 80 - 120 character limit.
I did not know what static meant in this context, so I inquired over at digitalmars.D.learn.

It turns out that it is not clear whether or not the "outer" feature applies for nested structs or not :
it doesn't work, but it could just be "not yet implemented".

May I request your participation?
http://forum.dlang.org/thread/cwohbwozowasyfpkcoim@forum.dlang.org
done, added an assertion for now, this should use logger as well.
You're right, will rename it.
You could do a GetCol instead of GetAll here.
Need to return this. Also, would be good to return the error in the callback.
Hi, seem´s to be a merge with another branch. I didn´t write this, maybe I merge it with someone else ... let´s see if I can clean this :/
surely you mean "callable" ;-) , done
This ties the provider to the FOS propel user and since you can not extend this one using Propel I would have to implement a special UserProvider to support my custom Propel User. Why not check for FOS\UserBundle\Model\UserInterface or make the required class configurable?
( also see FOS\UserBundle\Model\UserManager::refreshUser() )
It is not advisable to mix merge reviews with bug fixes.
`essential` should be `elective`
I don't understand why this is used instead of just calling the the model?
Well, parmetis does something similar, 
we need to build met before doing the parmetis build, 

If they are this tightly coupled they should be built in the same easyblock?
OK, I mangled the explanation. It's not about side effects in general, it's about when error messages are issued.

The issue is that at optimization time, we are speculatively calling RendererServices (or TextureSystem) get_blah functions. It's speculative because we aren't always 100% sure that the code we're folding will execute. Consider something like this:

    if (u < 0.5)
        C = texture ("idontexist.exr", u, v);

What if the file doesn't exist, but the geometry that the shader runs on only has u > 0.5?  I say that optimization shouldn't generate spurious errors that would not have been hit by the unoptimized shader at runtime. So the way we try to do it is to suppress errors while optimizing. But if we fold the failure, there will be no error message issued at runtime when the shader actually executes.

In the specific case of getattribute, however, I think it's probably ok to dictate that the RendererServices side should not do any error handling itself, instead leaving it to the shader. I think that's how we do it in Arnold anyway... it's perfectly legal (from a renderer error point of view) to ask for a nonexistent attribute. That's kind of a different issue than, say, asking for attributes from a texture that doesn't exist.  So I think I can just dictate that getattribute should work that way, and fold the failures as well.
It's up to the renderer, but almost everything (everything in Arnold's case) retrieved by getattribute does not support derivatives.  So generally the RendererServices::get_attribute implementation will just zero out the derivs.

This function is just meant to handle the type conversions.

I'm not sure what you mean by "the actual conversion call would be on the OSL side".  It is -- this is it.  This is the logic for converting the data types.  The conversion code is here, but it needs to be called from the renderer.

I'm not sure what the alternative is.  OSL knows how the type of the shader variable to store the result (the destination), but it doesn't know the type of the attribute until it's looked up by the renderer, if you see what I mean.  So where do the "source" results go?  You can't just return a pointer, because that would preclude the use of an "attribute" that is ephemeral or needs to be computed somehow as opposed to having a static location.
The whole `html_syslog_format()` result isn't going to be able to be escaped with `h()` because `html_syslog_format()` returns HTML. It will be important to ensure that message, etc. is escaped, though.
Makes sense, then.
Ok!
btw, I think you should split it in different handlers: the existing handler aimed at serializing all Doctrine proxies with the same instance, and then another handler aimed at the deserialization, which would need to be registered several times (once for the ORM, another one for the MongoDB ODM and so on). For 2.0, it may be a pain (especially supporting several Mongo managers as there is no registry for the ODM in 2.0) but for Symfony 2.2 and Doctrine Common 2.2, it could be done with the same class for all IMO thanks to our efforts to extract common interfaces to Doctrine Common
Zudem glaube ich, dass ich hier im Service die verschiedenen LogTypen ausprogrammieren würde.
Das heisst:

public function OfferCreated(Order $order){
  $user = $this->getContext()->getUser();
  $comment =  "User [" . $user->getId() . "] received the Order [" . $order->getId() . "] as an offer";
  $log = new OrderLog(OrderLog::OFFER_CREATED, $comment, $order);
  $this->persist($log);
}

oder

public function OfferAccepted(){
  $user = $this->getContext()->getUser();
  $order = $this->getContext()->getOrder();
  $comment = "User [" . $user->getId() . "] accepted the Order [" . $order->getId() . "]";
  $log = new OrderLog(OrderLog::OFFER_ACCEPTED, $comment, $order);
  $this->persist($log);
}


Wenn immer möglich, den Order vom Context nehmen...
Das geht hier immer, ausser der Order wurde gerade neu erstellen (was nur bei [OfferCreated] der fall ist).
Можно уже, кстати, на `std::` переходить ;3
это писалось в то счастливое время, когда их еще не было
That is a British spelling.  I would like to keep the American spelling to be consistent.
Needs to be internationalized
Need a `var` here
Is _count always an integer?
@surangak said only preferred.
Need null and empty string assertions to these new setters
Maybe take the opportunity to factor out some of this code into smaller methods - approaching 100 lines.
The method `FormView::set` is deprecated in Symfony 2.3. See [Changelog](https://github.com/symfony/symfony/commit/310f985b9903f62460e92f4e5d17751c7503758b#L0R1048).

It was fixed in the PR #25 :)
Never realised that. Thanks.
и, видимо, "функционал должен внедряться"
I would remove the homepage and repository since it will eventually be a part of a larger module with its own homepage and repository entries.
That causes tests to fail with:

```
Failure/Error: its(:record)  { should eq user }
     NoMethodError:
       undefined method `record' for #<Proc:0x007fac8da7b958>
```
All lazy-loading listeners are registered through the DIC. Is that a real world use case you are talking about?
This may work for Grapelli, but it doesn't maintain anything for non-Grapelli users. I would suggest keeping the old row1 and row2 classes as well as the grp-row-even grp-row-odd
We should also update the classifiers to be explicit that py3k is supported, the cheesehop needs it. See http://docs.python.org/dev/howto/pyporting.html#universal-bits-of-advice
Do you believe Django is perfect?
I was claiming the other way around.
instantiating in a different way is easier with a property.
Another method might and usually will use the property and will return some/completely different authentications in a subclass while still maintaining normal behavior when needed.
Filtering in a subclass requires calling the base class' get_authentications which produces ugly syntax imo.
Re-read my answer.
SQL Server location should not use the same location as the service location.  It should have its own location parameter in azure mobile create.  I cannot use the CLI for https://commonuxfx-partnerstaging.cloudapp.net since SQL server location can only be NorthWest US for preview environment.
 node azure mobile create xinqiutestPreview1 xinqiutestPreview1-DB MySqlPassword#2 --location "West US"
Creating mobile service: xinqiutestPreview1
info:    Executing command mobile create
+ Creating mobile service
error:   Overall application state: UnHealthy
error:   Mobile service (xinqiutestPreview1) state: ProvisionConfigureFailed
error:   A network-related or instance-specific error occurred while establishin
g a connection to SQL Server. The server was not found or was not accessible. Ve
rify that the instance name is correct and that SQL Server is configured to allo
w remote connections. (provider: Named Pipes Provider, error: 40 - Could not ope
n a connection to SQL Server), If you contact a support representative please in
clude this correlation identifier:
error:   SQL database (xinqiutestPreview1_db) state: Provisioned
error:   SQL server (vukk870vjd) state: ProvisionConfigured
error:   Creation of a mobile service failed.
info:    Error information has been recorded to azure_error
error:   mobile create command failed
Forgot the attribute name
I liked that space.  :(
the issue is not about using several lines but about creating the ``$filename``, ``$contentType`` and ``$options`` variables (btw, I'm not even sure it is valid)
Can the ordering inside the field be toggled off?
Should we make these notices to make the distinction more clear?
1st sentence could be shortened to, "Prepares the window proxy to be added to a UINavigationController."

However, I'm not sure that really tells me what it does.
In the Play case this won't write the response like it does in the Servlet API case. A change of language to blur the action. We're really loading the HttpResponse object with the values it needs to produce the response to the user.
Let's go with <tt>SyncHistoryVisits</tt>.
Yeah that's what I meant - but I'm guessing this code might get triggered a bunch so if there's an easy fix it could be worthwhile.
Should end with `.`
You did not pull-ed from upstream before creation of new branch, right? Please, pull from develop or change this so it will not be part of this PR.
Test the count sql too
A nitpick, but... what if the namespace changes? It seems the point of `getQnxNamespace()` is wasted here (and there is more internal state).
Судя по всему, первый элемент `arr` (`arr[0]`) никогда не обрабатывается. К тому же, по-моему, переменная j - лишняя.