Web Inspector: The 'X' of the close button of Settings view is not centered
https://bugs.webkit.org/show_bug.cgi?id=99008

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-11
Reviewed by Alexander Pavlov.

Fixed text positioning in CSS.

* inspector/front-end/helpScreen.css:
(.help-close-button):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@131028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix committers.py for the names of contributors to appear on webkit.org/team.html
https://bugs.webkit.org/show_bug.cgi?id=99004

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-10-11
Reviewed by Yuta Kitamura

Some of the nicknames in the committers.py file are using the single quotes (')
but while parsing these, JSON throws an error: Single quotes (') are not allowed in JSON
Hence coverting these single quotes to (") so as the contributor names appear properly
on http://www.webkit.org/team.html

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@131029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Introduce Localizer::isRTL, and use it in DateTimeChooserImpl
https://bugs.webkit.org/show_bug.cgi?id=98992

Source/WebCore:

* platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::isRTL): Need to initialize 'status'.

Source/WebKit/chromium:

* tests/LocalizedDateICUTest.cpp:
(TEST_F): Re-enabled isRTL test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@131030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL][WK2] Revisit setting API names and documentation
https://bugs.webkit.org/show_bug.cgi?id=98793

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-11
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Make setting API names to be consistent and revisit the documentation.

* UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_frame_flattening_enabled_set):
(ewk_settings_frame_flattening_enabled_get):
(ewk_settings_dns_prefetching_enabled_set):
(ewk_settings_dns_prefetching_enabled_get):
* UIProcess/API/efl/ewk_settings.h:
* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):

Tools:

Make frame flattening setting APIs to be consistent with others.

* MiniBrowser/efl/main.c:
(window_create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@131031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Final newline (LF or CRLF) in paste buffer is converted to space
https://bugs.webkit.org/show_bug.cgi?id=80838

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-10-11
Reviewed by Ryosuke Niwa.

Source/WebCore:

Currently newline characters are replaced with spaces when pasted
to text input. This behavior was introduced in r37539, with the
intention to follow the FireFox's behavior (see
https://bugs.webkit.org/show_bug.cgi?id=20461). However, FireFox
truncates newlines at the end of pasted text, instead of replacing
them with spaces. So this patch changes TextFieldInputType to cut
trailing newlines of inserted text.

Test: fast/forms/paste-multiline-text-input.html

* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):
Truncates trailing newlines.

LayoutTests:

Verify that trailing newlines are stripped when pasted into text inputs.

* editing/input/paste-text-ending-with-interchange-newline-expected.txt:
Updated the expectation.
* fast/forms/paste-multiline-text-input.html:
Changed to use document.execCommand to mimic pasting, because setting
input.value attribute does not trigger beforeTextInserted event.
Added a test case to test trailing newlines.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@131032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK] It should be possible to disable favicons in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=98885

Reviewed by Carlos Garcia Campos.

Make support for favicons in WebKit2GTK+ disabled by default, and
allow enabling it even after calling webkit_web_context_get_favicon_database(),
by decoupling opening the IconDatabase, which will happen when
setting the path for the database directory, from creating the
instance of WebKitFaviconDatabase from WebKitWebContext.

* UIProcess/API/gtk/WebKitWebContext.cpp:
(_WebKitWebContextPrivate): Renamed faviconDatabasePath to
faviconDatabaseDirectory;
(ensureFaviconDatabase): Makes sure there's an instance of
WebKitFaviconDatabase created and associated to the context.
(webkit_web_context_set_favicon_database_directory): Use the
default path if NULL is passed, or the specified one, creating the
database if needed and opening it by setting it's path. If the
database is already open this method does nothing.
(webkit_web_context_get_favicon_database_directory): Return the
path or NULL if webkit_web_context_set_favicon_database_directory
has not been called yet.
(webkit_web_context_get_favicon_database): Return the instance of
WebKitFaviconDatabase, or create it if it doesn't exist yet, but
never set the path (would cause the icon database to be opened).

* UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:
(testNotInitialized): New test to check that a NOT_INITIALIZED
error is got when using the database before setting its path.
(testSetDirectory): Call set_favicon_database_directory() here
instead of doing it in the constructor of FaviconDatabaseTest.
(beforeAll): Add testNotInitialized() to the test suite.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@131033 268f45cc-cd09-0410-ab3c-d52691b4dbfc