labofsahil/github-event-dataset-2012 huggingface dataset:
On 08/31/2012 10:54 AM, Lars Butler wrote:
> In openquake/calculators/hazard/general.py:
> 
>> @@ -534,6 +535,22 @@ def parameterize_sites(self, site_list):
>>  
>>          return jsite_list
>>  
>> +    def initialize_pr_data(self, **kwargs):
>> +        """
>> +        Record the total/completed number of work items for the classical,
>> +        event-based and uhs calculators.
>> +
>> +        This is needed for the purpose of providing an indication of progress
>> +        to the end user."""
>> +        sites = kwargs.get("sites")
>> +        assert sites, "Invalid 'sites' parameter"
> 
> Would |assert sites is not None| be better? Or is this meant to catch empty lists as well?
the latter
I will remove the trailing semi-colon. that test is to ensure that ampersands are rejected by the parser if they are not escaped.
why do we this line we might as well remove it
Curly brace belongs on this line
To ensure that we don't pull off escaped whitespace (e.g., `"...\\\t"`), we must find a non-backslash character (or start-of-string) followed by any number of backslash-escapes... the trailing whitespace follows that.
[MADLIB-500](http://jira.madlib.net/browse/MADLIB-500)
Yes. I can remove that check.
My first idea was to define a tuple type and `operator<<` instead of `feed`. This operator I would have used for both transition and merge. However, I found working with tuple types less convenient than just having each field as an individual argument of a transition function. Despite the change, I stuck with using the same name for both transition and merge though.

Now for the convex optimization framework, it seems that a tuple type is unavoidable at least before C++11. I wonder what you think about `operator<<` versus `transition` and `merge`.

In any case, a merge function is not really a different concept. It is in fact a transition function during the second-phase aggregation.
It's officially called 'openid' in their APIs but I guess I can rename this variable to be  something like profileResult to avoid the confusion here. :-).
This should be `throw new Error(userInfoContent.msg)`
``_get_backend()`` is probably fine, but I started thinking about either having a property for this, or even just setting it when it changes to avoid having to do any work to get it. This is of course probably pre-mature optimization.
This should use string interpolation, have more data and use single quotes:

```
log.exception('Error while live indexing %s %d: %s', mapping_type, item_id, exc)
```
The calls to self.setup_indexes() and self.refresh() make this hard to make into a class method. I tried making those two methods class methods, but now the tests fail (in particular, no feedback items are show on the dashboard).
Above you use `{{ url('dashboard') }}`, but here you use `/`. Probably want to use the url thing and not hardcode it.
@GaelVaroquaux : pyplot and not pylab as pl ?

On Tue, Jun 26, 2012 at 10:48 AM, Alexandre Abraham
<reply@reply.github.com>
wrote:
>> +# Make processing parallel
>> +# /!\ As each thread will print its progress, this could mess up a little
>> +#     information output.
>> +n_jobs = 2
>> +
>> +score_func = f1_score
>> +
>> +# A cross validation method is needed to measure precision of each voxel
>> +cv = KFold(y.size, k=4)
>> +searchlight = searchlight.SearchLight(mask, process_mask, radius=1.5,
>> +        n_jobs=n_jobs, score_func=score_func, verbose=True, cv=cv)
>> +# scores.scores is an array containing per voxel precision
>> +scores = searchlight.fit(X, y)
>> +
>> +### Unmask the data and display it
>> +pyplot.imshow(np.rot90(scores.scores[..., 26]), interpolation='nearest',
>
> Gaël asked me to use pyplot explicitely and avoid aliases as much as possible (except for numpy -> np)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/nisl/tutorial/pull/20/files#r1049290
Same applies
D'ailleurs, il serait pas mieux ici d'avoir in simple intx,int y en entrée? Ca limiterait l'utilisation de slick dans le serveur non?
Might make more sense just as "Modifies a relationship."
Ah, unless you intentionally want to stop at the first falsey value.
I think we should change this to message.
drop this? 'complete' is a bit misleading because they're not internally complete...
Why don't you make a parameter jailbase which accepts the path to the jailbase?
I believe this check isn't quite what you want. By ORing these together, if the first test fails (the check to ensure there is an options property), we will fall into the second check, which will throw an error ("options is undefined"). As far as I can tell, you want to verify that there is an "options.key" property. && is your friend here.
What the fuck is wrong with you? You do understand that it MATTERS which order the coordinates are input in right? If they are not sorted shit won't work.
Did you mean to add this empty item group? Doesn't really matter, but probably unnecessary
So there's no solution to be had here that's more adaptive to the device?
Good point.  I'll add a comment in main-view.html.
Minor nit: equal signs don't line up.
``{Sort}``
Can we just leave them in for now, and then fix enable/disable later?
To say "choose folder" this would have to be "Выбрать папку". It currently says "choose catalog".
One more thing. I think the team agreed recently to use $("<span/>") instead of document.createElement().
Indeed, I did. I wasn't sure whether this was supposed to test whether exotic characters throw of some part of the process.
I felt this makes the example easier to understand since the user can examine the return value of the Mustache call in the debugger. I renamed the variable to “localizedHTML” to be more clear.

From: Jason San Jose [mailto:notifications@github.com]
Sent: Thursday, August 23, 2012 12:40 PM
To: adobe/brackets
Cc: Ty Voliter
Subject: Re: [brackets] Plugin localization example and documentation (#1424)


In src/extensions/disabled/LocalizationExample/main.js:

> +        alert(Strings.ALERT_MESSAGE);

> +

> +        Dialogs.showModalDialog("sampleLocalizedDialog");

> +    }

> +

> +

> +    // Register the command

> +    // A localized command name is used by passing in Strings.COMMAND_NAME

> +    var myCommandID = "localizationExample.command";

> +    var command = CommandManager.register(Strings.COMMAND_NAME, myCommandID, TestCommand);

> +

> +    var menu = Menus.getMenu(Menus.AppMenuBar.EDIT_MENU);

> +    menu.addMenuItem(myCommandID, null, Menus.AFTER, myCommandID);

> +

> +    // Localize the dialog using Strings as the datasource and insert it into the DOM

> +    var d = $(Mustache.render(browserWrapperHtml, Strings));

No need to create a temp variable for d

—
Reply to this email directly or view it on GitHub<https://github.com/adobe/brackets/pull/1424/files#r1448400>.
I agree that additional parameter to getQueryInfo is a practical solution to your JS hinting. I can think of the following three different cases that CHM calls getQueryInfo of the current provider.
1. When an item is selected by a mouse click and handleSelect method return false to keep the hint list open (used in url hinting). We won't have a last-pressed key in this case.
2. Ctrl-Space is pressed. We don't provide the last-pressed key since it is not a single key pressed.
3. Any key that generates a character in the editor. We provide the last-pressed key as the extra param of the getQueryInfo.
same for options.type somewhere at the top since it's used multiple times
I've been thinking about this for some time.  I want to put a README, CHANGELOG, and docs folders in the repo so that it's easier for others to contribute that information and also helps make sure users have the correct documentation for the version they are using.

I may even get rid of the website and just redirect it to the github README & docs folder after that.
whole function could be replaced with 
return {
    'type': 'nested' if nested else 'object,
    'dynamic': dynamic,
    'properties': set_properties(prop_type)
}
A comment would be good here.
`keys['/']`
Does this need to take in to account repo encoding?  `rb_str_new2` is always going to return strings tagged as ASCII-8BIT.  I can fix this after we merge, but I need to understand the encoding rules for libgit2.
This is ugly. Cannot you above simply do `profile, created = models...`?
there's no need for `begin` if rescue for all function. Like this

```ruby
def fun
  # some code here
rescue => e
  # rescue from error
end
```
will tackle this one tomorrow.
I wonder if you should first make a var to hold `trackEvent.popcornTrackEvent._natives.manifest`, then check if it exists, and then read `options.count.MAX_COUNT`.  This line scares me.
And being a ghost means what?  Needs more info somewhere on the whole "ghost" concept.
Don't see any reason why it's not OK to use i here, but yeah, it is a repurposed element used for icons, since <em> takes over italics.

Couldn't really find an article, but nothing in the docs that indicates i tags can't be styled any differently from anything else:
https://developer.mozilla.org/en/HTML/Element/i
space before opening brace
If we're being particular, the (non-existent) style guide suggests the content of this `{% if ... %}` block should be indented.
This should use shadow() like the other functions so it is only initialized once instead of every time it's called.
Why are all these being included again?
如果更改了动态模块的代码, 期望通过reload来生效, 这里是否会导致总是使用旧的代码?
Indentation gets a bit weird here
Is % and "and" operator priority okay here?
I don't actually think these two functions are needed anymore with the switch over to Runcible.
Typo - directlry
You might want to add yourself to the copyright holders of that file after such large changes.
This should be a non-200.
I think we should specify that a grey strip /without a name/ is another nurse's vacation segment. And then should we be explicitly clear that just because there's a grey stripe doesn't mean that they can't schedule?
Yeah that was just caught in a global search/replace.
s/min/max/
It will be painful. Hmmm...I think I can handle it, though.
This file needs some `gjslint` magic too.
setEncoding is what node has, so yes, I guess adding charsets support will be natural evolution of this method :) But it's out of my scope, at least for now.
Does this wait for handoff to complete? It seems on my slow laptop from the dark ages that the assertion immediately after is the one that fails most.
^^ oops. i am fixing the tests right now
Adding the method in the class without adding it in the interface is useless (you cannot ensure you will receive an ArrayCollection each time). And adding it in the interface is impossible as it would be a BC break
How does that work? i think this is wrong.  i think you need a block here then check that comment.discussion.group_id is in users groups
Looks like sub duplication in the subjects (They all start with "[Loomio: #{@group.full_name}]"). I would extract a method for duplication even if it's that minor.
Again, logging please :-)
I don't see this function used anywhere. Can it be removed?
Typo :) should be sceAtracSetDataAndGetID(int atracID, u32 bufferSize) .
This might be a good time to fix the fact that all these escapes are defined *twice*, once here and once in inputsplitter.  Let's remove the duplication and have these things in a single place...
Silly niggle: use `bool`?
This outputs width: 460px; for the paragraph, which is too wide in the tablet width so text runs into the margin. For tablets this needs another rule to override the desktop width: #sections section p { .span_narrow(6); } or just width:auto
Still haunts us from the old PHP codebase.
Did you rename Types to Utils?
I don't think you need these local variables. You could simply use the class properties that already exist.
Why change this to the french style byte units?
Is this possible to set that pattern to empty string ?
@vicb good to know, thanks!
Is there any compelling reason for making this class final?
Thanks for the input.

So then there would be two options imo: either remove caching for objects or make something like (string) $value.

I don't think the second option is that good so in this case should I just remove caching for objects?

The speed-ups should remain as the example I had doesn't use objects and I think most of the code for forms is in the same situation.

What do you think?
Chiming in.  I personally prefer extend and block as well, more expressive.
You can use `MIN(bottomOffset, offsetTop)` instead of `?:`
I don't see any "Merge pull request" button.  Leo told me that the big green merge button takes certain permissions.  The CR is complete so go ahead and merge.
The jQuery wrapper has a cleaner syntax and is more flexible as far as callbacks go. Sorry, I should have made this clearer in the PR message,
论文中没有那么多自由度的需求，这个不是latex入门文档，只要说需要用的即可，即全部应该是[h!]，甚至都不用介绍是什么含义，那些都是对于论文写作而言没有用的东西，想知道含义的人也会自己去找，不用在说明文档里面说那么多文字描述
Could be the same neigh ?
I'm happy for this little fix to stay here if you like.
`raise GrammarWarning`
Yes - proj.4 works with float64. But that's taken of by https://github.com/rhattersley/cartopy/blob/6b66ee9e0b11e163978f4c8fe70e44d5f8eceabe/lib/cartopy/_crs.pyx#L164
We should be able to get the exact dimensions from the figure at this point?
Ah, I was trying to address a previous comment, *"Hmmm. Some nice exception handling might need to be considered for cartopy in general. It would be very nice to be able to catch this particular exception (rather than the generic ValueError exception)..."*
nit: i think it's more readable to put htis comment inside of the else { block
La faute à Idea 12! :p
Great! I think that's a good option, didn't know it exists.
What remains is `simple_language_changer()` with the deprecation warning there.
You could avoid a function call here by doing `tryable = run.currentRunLoop.end`.
By precedent elsewhere in the module, this should use the compute_etag method, and allow for that method to return None to suppress the generation of an Etag header.
It may be useful to include both the sid and the data in the socks_recv event.
Ca va lancer un "processTweet" qui va renvoyer le tweet aux follower de la personne mentionné, ce qui est (à mon avis) une erreur. Seule la personne mentionnée doit recevoir le tweet.
`} else {` instead of a new line.
Despite it could be a map of objects, please start with a lower case since it is not a constructor.
@jds2501: please attach me to the bug when you'll send it.
nit: unprefix please
This is awesome documentation can you also add a bit here about the APP= option (runs tests for only one app) and the TESTS= option (only runs one test)
I will prefer to have that string inside the empty `<span/>` instead of using a new tag, but i guess that is a nice to have.
r+
And add the reference here.
All applications (and websites!) will be able to install something on the homescreen without asking the user. Not sure this is a good thing. Can you move that out of this PR?
This array is cause we are going to have more than 1 photo?
It was some lines below. Now I've refactored the conditions so it's easy to see the new case that we need.
It's not, it works as you wanted it to.
trailing white space (will generate error in js, not in HTML but please try to avoid it)
Ups sorry, you are right... I was using it "to restore" the status of the USSD/MMI screen but at the end I realized that we could get the same effect "posting" the pending or last posted message... ;-) Thanks! Deleting the argument and its references from the function... ;-)
Just add a helpful string like
`console.log('Dialer recents IndexedDB exception:' + ex.message)`

and remove the todo
`DAYSOFWEEK_DEFAULT`
I think the yard type should be `[#call]`, right?  Since you chose that as the parser interface.  That said, the necessary interface for `uri_parser` is `#parse`, not `#call`, and it would be nice to have these the same.  Then again, the rack method is `#parse_query`, not `#parse`, so maybe `#call` is best.  I'm of a split mind here.
throw new MondrianException(e);
bad indentation for this comment block
実行中のアドホックコマンド
    実行中のコマンド

とした
Don't print this - you're already logging it.
This variable doesn't appear to do anything.
Restore Kunena Menu
Looks to be a mismatch in indentation here (tabs vs. spaces).
There's a `self.master.master_name` that I'd like to tie in with.  Since it's a formulaic thing (rather than a free-form description), I think having a unique identifier for it is helpful.
This should use `self.patch`.
Yep, it looks good.
But a demo to reproduce this issue is better. Therefore i could make sure this change can work.
Could you email the demo to me?
See comment above...don't we want to do this after the read.
here sentence starts with capital M, other places have lowercase start
SCMalloc can fail
Ah no class variables.  Please use class instance variables instead:

```
  def self.validates
    @required_context ||= {}
   end
```
`functools` comes before `os` alphabetically. `nit`.
this can probably be written `if sql =~ /select/i` instead
I would rather expect that json to be written into CWD, also maybea it's should have a cfx to enable this. I don't mind to enable coverage by default, but I do mind writing `.json` files to users machine on each `cfx test`.
We should also make sure that it will work for other possible values too: `attachTo: [ "existing", "top", "frames" ]`, which reads bit awkward to me, but I'm non native so I could be wrong. Also `attachTo` conflicts something else I had in mind for [bug 755963](https://bugzilla.mozilla.org/show_bug.cgi?id=755963) maybe we should decide on naming there as well to make sure we won't run into naming issues again.
Filled: https://bugzilla.mozilla.org/show_bug.cgi?id=772126
This TODO comes from python code. Good candidate for a follow-up!
A default background color should be added for IE8 or else the blurbs are not highlighted from the page.  ![IE8 without highlighting] (https://img.skitch.com/20120618-rqyfrgq9upek51r1ag9qx9p6xs.png)
i added this assertion upstream in order to test the getter that was fixed by the pull that is trying to be merged.
Shouldn't it be `product` not `project` here and in the following lines?
media= might not make sense here, since we don't change anything based on media.
Extra newline isn't needed.
So when does this get updated? What do we do to make sure it is in sync with what gets written to VERSION?
Yes. In practice, they'd be no different. I don't actually remember why I had it written this way in the first place, though. Feel free to change it
Each of these partials needs an ID so we can replace them with the javascript.
Prefer format strings: "blah%s-%d".format(_, _)
This can be simply "Form"
Are you suggesting a BadMethodCallException or LogicException?

In the case of the DB writer, which doesn't support a formatter, it throws an InvalidArgumentException. Is that more sensible here?
remove else because already return early.
Wouldn't named keys be easier? As in:
```
if (isset($priority['operator'])) {
    $operator = $priority['operator'];
}
$priority = isset($priority['priority']) ? $priority['priority'] : null;
```
This would make it easier to understand the arguments, wouldn't rely on position, and could allow usage of non-array but array-like data structures. Additionally, it would make it more consistent with the rest of the framework (in particular, look at validators and filters).

Same comment applies for all other filters that have constructor arguments.
This code can only run if Bundler is loaded, which is not a default dependency of RubyMotion. This should change to something like: `rescue Bundler::GemfileNotFound if defined?(Bundler::GemfileNotFound)`
Possible whitespace issue here?
This should be just `OwnerManager`.
Why do we need to set this platform variable when node[:platform] is available everywhere?
Your else statement is not formatted correctly; needs to be 
```java
if (true) {
    // something
} else {
    // something else
}
```

not

```java
if (true) {
    // something
}
else {
    // something else
}
````
What about implementing the `Zend\EventManager\CollectionInterface`?
In reifyc for the nom-hash constraint, I just reify the constraint if it's relevant to the end result. This is consistent with alphaKanren.

For example, 

    (run* [q]
      (nom-fresh [c d]
         (typo [] ['lam (nom-tie c ['lam (nom-tie d ['var c])])] q)))

would otherwise return

   (([-> _0 [-> _1 _0]] :- <lvar:x5037>#<lvar:xc5049> <nom:b5036>#<lvar:gc5025> <nom:b5036>#_0 <nom:b5036>#[<nom:b5026> <lvar:trand5024>]))

instead of just

  ((-> _0 (-> _1 _0)))

Because the constraints are on vars and noms that are not in the final result, they're just noisy and not interesting to the end user.

Simpler examples. Contrast:

    (is (= (run* [q] (nom-fresh [a b] (nom-hash a q) (nom-hash b q))) '(_0)))
    (is (= (run* [q] (fresh [x]  (nom-fresh [a b] (nom-hash a x) (nom-hash b x) (== [x a b] q))))
          '(([_0 a_1 a_2] :- a_2#_0 a_1#_0))))

For the first case, we don't want:

    ((_0 :- <nom:b5130>#_0 <nom:a5129>#_0))
you could make it simpler by sharing the definition of the cachedReader and the driver and using the if only to create the inner reader.
however, public properties break Doctrine proxies so they should be avoided in tests too IMO (this object will work in the cases used by the tests but they will confuse users looking at it)
What about defaults?
We could probably use `keymember`, which is also a NIF.
Not going to block on this but you should probably just make this "if" statement one line since all its doing is returning a value.
Maybe add available for ES only.
why don't you use  your caching class here?
import at start of file
to a certain extent, createphp already provides code for that in the form of rdfMapper's isEditable() function. I'd have to check whether this is called in the RestHandler right now, but if not, it should probably be added.

But one problem that all these approaches have in common is that there is no way to integrate this with the create.js UI. so if the backend throws an exception, it will just pop up as a long, unreadable notification and fade away after two seconds or so, regardless of whether it was a validation error, permission denied or a hph parse error. This is a problem especially for validation, where you would definitely want to tell the user what exactly went wrong, and in which field (e.g. "start date has to be before end date"). So I think for a proper solution we need to get @bergie involved :-)
I see that too... specifically looking here:

`combineFn(  natives._teardown`

Between "(" and "natives"
This stuff just figures out which parameter names have `*` at the end and promote that to the temporal parameter.
@kellyredding - should be 'this is the equivalent...'
I'm not sure about this change - I don't think the instance field should actually become part of the API. At the moment isTransient() simply returns the field, but this may change (if for example, transient becomes more than a simple boolean check) and if we've exposed mTransient that would be more difficult to change in future...
`Nori` auto snakecased keys, so I had to test on raw xml, pls come up with better solution!?
I suppose we could leave it in if it's faster than running the rest of the lambda?
copy & paste idocy, removed the 2nd argument
This line was updated with some of the recent changes to variable log levels
This isn't a standard Rails entity.  Happy to change it to something else.
nit: Another `<` that should be `&lt;`. I'll stop pointing the rest of them out.
extra space before the `</p>`?
opener = urllib2.Request( url, data=params )
request.add_header( 'Content-Type', content_type )
resource_i_need_to_close = opener.open(request)
raw_response = resource_i_need_to_close.read()
resource_i_need_to_close.close() # This line is all you needed to add.
лучше написать virtual, чтобы было понятно, чо он переопределен
Can you move the keys and passphrases into a spec/support file?
XMLコメントがここで途切れてしまっていたため、修正しました。
In the next pull I'm moving it out of the base page. It shouldn't be in the base page because it's not relevant for every page
As I mentioned last time, please check the XMLNS against `http://www.leica-microsystems.com/scn/2010/10/01` and fail if it doesn't match.

FYI: if you disagree with a review comment I've made, you should post a comment explaining why I'm wrong.  If you disregard comments they're just going to keep coming back.
It's only being used for the counter, so could be extracted to the model to make it more clean/readable.
```ruby
Repo.get_needing_help_counter_for(current_user)
```
camelCase -> `sortedEvents`
should be has_many :organization_subscriptions
The comment lines aren't correct markdown. Should probably be something like:

<code>
;; ## JDBC helper functions
;;
;; *External code should not call any of these functions directly, as they are subject
;; to change without notice.*
</code>

Myself, I run `lein docs` to generate the documentation output, and check that it looks reasonable.
contexts should go first.
This should probably move to the oae-authentication/rest.js file now.
These deps are outdated now that there is authz.
I don't think so, it won't add a value since createdBy will be null already.
Should this be {User[]|Group[]} ?
missing parens (sorry for nitpicking...)
``tpt.symbol`` can trigger side-effects (i.e., lazy typechecking), you should wrap this in a ``askOption``, i.e., replace `` tpe.symbol -> tpe.namePosition :: safeSymbol(qualifier)`` with ``global.askOption(() => (tpe.symbol, tpe.namePosition)).toList ::: safeSymbol(qualifier)``
It no longer looks for the ./lib/ircnode.js but it needs to be changed anyway, as we moved from ./client to ./lib/ircnode.js.
Do you prefer this so (like other providers):

```php
/**
 * @var string
 */
private $apiKey = null;
```
Довольно-таки медленный алгоритм мутации.
Выводить нужно не здесь, ваш метод возвращает какое-то значение, и выводить его нужно там, где этот метод вызывается.
Same thing here (i18n)
This is the only change.
In order to make room in the bottom right for the portrait
Remember to use this.$. I would also recommend you to use input:file or input[type=file].
so this is appending an empty string? I don't get it
damn vim.. how to edit properly md file ?
Can you remove this import-package?
Kan dit niet via config files? Zie http://symfony.com/doc/current/book/service_container.html#importing-configuration-with-imports voor meer info.
The setOption call already takes care of setting the aria-disabled property
I'd prefer to not add this shorthand. Polluting the namespace and whatnot. @mgrigajtis?
no worries.

it's just that I am bit reluctant to touch the inverse code which is pretty
tricky and that has now been widely tested and deployed.

Comments could be useful indeed.
2012/10/29 Alexandre Gramfort <notifications@github.com>

> In mne/artifacts/ica.py:
>
> > +        Returns
> > +        -------
> > +        fig : instance of pyplot.Figure
> > +        """
> > +
> > +        sources = self.get_sources_epochs(epochs)
> > +        fig = plot_ica_panel(sources[epoch_idx], start=start, stop=stop,
> > +                             n_components=n_components, source_idx=source_idx,
> > +                             ncol=ncol, nrow=nrow)
> > +        if show:
> > +            fig.show()
> > +
> > +        return fig
> > +
> > +    def find_sources_raw(self, raw, target, sources=None, score_func=None,
> > +                         start=None, stop=None, sort_func=stats.skew):
>
> it seems indeed that we would need methods: one for scoring and one for
> plotting eventually informed by the order derived from the scores wdyt?
>

I'm afraid the API get's shaken... But yes. So just to draw a tiny
dependency-map of the method relations:

'-->' for left invokes right:

(get_sources, pick_sources) --.> sort_sources

(plot_sources, find sources, pick_sources) --> get_sources



so in depth sort_sources does the default ordering job. get sources gets
the sources (calling sort_sources, internal scoring) and find_sources gets
scores based on comparison with a target vector (external scoring).

How to unify this? I'm a bit -1 for adding more accessing-methods, It would
get confusing at some point. But extending / altering functionality and /
or renaming  would be fine. The candidate I see is sort_sources

We could try to merge sort_sources into find_sources or allow it to return
scores and make it a internal-score version (index based on one input
vecor) of find_sources or something like that. Then the top level functions
could access both scoring functions via keys or so.

However I'm a bit afraid of fumbling around with it. The whole picking
depends on consistent sorting which took some time. Basically you have to
make sure, that pick_sources draws the sources in the same order as your
decision-maker (human, correlation-algorithm via find_sources/ get_sources
/sort_sources)
If you see a quick way +1 for this.

What do you think?

>  —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/165/files#r1966400>.
>
>
It should be List<String>
see my prior comment on the special "id" property.
Hmmm true. I was changing the confirmable_attribute on the initializer config (and not on the model). I`ll make the changes and add more tests. 

Thanks.
@retronym I've tried to, following the [tutorial example](https://github.com/rickynils/scalacheck/wiki/User-Guide) for `Trees`. Here's my best attempt (not working): https://gist.github.com/3217282
Fixed in 2d444455c55b0cf18bab13a9206273b8d2e7ffbc
It no longer looks like Steve's prompt; the description should change.
you should use ``:method:``
right, sorry !
Hmm, yea, practically for the docs, I think we should print out all of the "core" factories here.
@stof and @richardmiller sorry, it was called a *logical name*.
New Feature : 
Allow a player to break or place some item in the dungeon that the
operator can config in the config.yml
oops! Errand Pudding on the loose!
The same issue from the previous comment, just copy & paste the urls, please.
Este commit fue muy bueno.
I'm not sure why this is is here as right now "mount_volume" is only called by prepare. If there are other use cases there should be tests written too, and this code should be part of those pull requests.

This code can still be separated out of MySqlApp. To do it, you'd need to move the logic of this to the host side (formerly called compute manager) and have it make several guest calls, first to stop_sql, then mount the volume and do rsync, and then start_mysql.
doesn't this always signal a programming error? is there any situation in which a non-owner might want to release somebody else's lock? If not we should re-throw the exception here - after all it was going silence that caused the bug in the first place.
@vblagoje I think @danberindei has a good point here, we should document that ThreadPoolExecutor with a CallerRunsPolicy is not an supported thread pool.
If the agent is not in use, shouldn't the size be something that represents that the size cannot be calculated? 1 is a positive value which can be considered a size value, although small.

I'd use a negative value, i.e. -1.
Will be deleted in ISPN-2312, where there is more cleanup in this area.
I know this makes more sense, but the xml still refers to 'loader', so I'd suggest leaving it as it is to avoid confusion.
the library should be added as a dev requirement in the composer.json instead as it supports composer. (it will avoid having to change the phpunit config too)
This is > 79 chars.
Therefore, this line should be
```
if setup.config.plot_working_directory is not None:
```
Latest version has this, why not pull and merge.
this init is not necesary
This is to use one Timer instead of two, which is a useless waste of resources.

The zoom-in feature is already in the bug list
Either prefix both states with "CONNECTOR" or not.
(I prefer not)
Comment on line #L2R34 applies here too.
Should be @requires OpenLayers/Strategy/Cluster**.js**
Yes, I know this causes an extra request.
In the documentation of the converter they do say you can add an user-style-sheet to each page that is loaded.
However, I can't seem to get it working. This is why I added this instead.
Ha, it looks like you can go ahead and remove the comment on line 90 while you're at it.
set_options I guess :^)
Don't think they would work. Through a regex on many classes, I figured out that developers use SGMatrix and SGVector as a referenced instance (not a pointer).  I changed them in the new commit.
Should this be `unapply`? I'm not seeing how we end up with a MIMEType at your line 176 of headers.scala
once enabled/disabled feature gets merged in, I plan for there to be an additional ```experiment.enabled?``` check in the if block (which was my rationale for explicitly writing out the if else statement).
I'd do `record && record["metrics"] && record["metrics"][alternative.to_s]` to prevent NoMethodErrors in case metrics is nil
Apidoc.
FWIW, I find it incredibly confusing to use `unless` with a compound conditional like this.
I haven't bothered to figure out how the crawler works, but if the process is long-lived you may want to move these into `run` (otherwise they are only evaluated when this file is imported - which is fine if it is short lived).
Are you sure ``'foo'`` has the correct type as "string" is not a sub-type of "array"?
Is it possible to define the element type for the array of parameter ``$classes`` (using ``array<SomeType>``, or ``SomeType[]``)? Please also check line 37.
The client has code to prevent this too in PlayerControl.
@stof `localizeddate` is allready in this extension. It's not my add.
Fjern linja helt framfor å kommentere ut.
nice duck punching resque
WFM. What about as a prop of the constructor?

```
Test.statuses = {...};
```
May be somebody wants to re-register behavior.framework (for loading from CDN for examle) , so, let it use his overriding method
user can define his own element , with class , id and stuff
This also should be out of the Directions Class.
This exception should be logged (if the method isn't removed)
This became preprocess_resume
Do we capitalize every word in titles or just the first one? Here you do, bellow you don't. How are we doing elsewhere?
This is funny ;)
I've changed string values with boolean values. Fixed.
Once you have `no`, then `num`. Please make it verbose and consistent.
`twitterLink`? What is this?
I'm not sure I understand the implications of this. If the database on the device isn't the right version, then will Miro treat the device as if it were new, go through the device from scratch and rebuild the database on the device? And that could potentially happen every time I upgrade Miro? That's pretty intense, if true.
Should we check that the file doesn't exist already?
should use if @user.about_me.present?
should be report.output
@bkgomez Please TEST your code before submitting it. This line blows up the dashboard if you go to it with an announcement on the page.
Need to add note about the fact that we extract identifiers instead of serializing entities, which is bad practice
I prefer the alias too, but that's what I was having trouble with. Instance injections seemed to work with the FQCN, and fail with the alias. I'll look through it all again tomorrow with fresh eyes.
Definitely. If not a sub module here, I'll eventually migrate the Mahout-Pig stuff into a sub module of Mahout itself.
r["\W"] is even better :)
if _hostedService is private, how can u set value for it?
Same here, constants makes it easier to read.
The same here, you can remove some bracket layers.
You're right. Leftovers from an earlier attempt, I think. Consider it reverted.
please count the collection only once. For extra lazy collections, counting does a SQL query when they are not initialized
Not sure if that's all too useful. 
I used utf8 as implicit encoding everywhere, so making it configurable is probably quite a bit of work. Node only supports 'utf16le' as other interesting encoding. And as far as I am aware, Vertica only accepts UTF8 anyway. I am not 100% sure of this though.
Should probably remove commented out code.
punt this line.
For consistency in my pedantry, could make these now single line comments use ///.  But I'm not sure if we really need to worry about this.
Set this label to hidden, initially, and only show it if motd.trim() has a length > 0
i dont know , from richard last time.  What I did just converted his .erb to .haml
please use $http->hasPostVariable('definition_id') instead $_POST, just like it's done in confirm.php
presumably overriding this isn't needed if SubTypesScanner is registered, so isn't needed when instantiated with no scanners defined. So maybe just leave as same semantics: if you want to have getSubTypesOf and you're defining custom scanners then you must register SubTypesScanner.

No strong feelings...
Should there be a removeFromBlacklist, for symmetry (given the addToBlacklist is a public method)?
short-syntax: ack

colors in hex: sass ist hier nicht berücksichtigt
This file is also included in PR 5
このメソッド、どこからも使われていないような。
もし不要なら削除をお願いします！
Wouldn't it make more sense to make the loop the otherway around? Now you are creating server_hash of the same server over and over again..
Are these for realz? I assume this is a PHP5.2 fix, not a windows build fix though?
Maybe I'm just used to mock, but I don't find it's argument introspection to be awkward (although I will admit that your use of arg.any() led me to find the ANY utility, which I didn't know about before: http://www.voidspace.org.uk/python/mock/helpers.html#any):

```python
post.return_value = Mock(content='{"status": "ok"}')
verify(assertion, audience)
post.assert_called_with('https://custom.org/verify', verify=True, 
                        proxies=ANY, data=ANY, timeout=1, headers=ANY)
```
Does this list every single author and highlight the current author? Shouldn't it just show the author who actually wrote it? I'm a little confused about this part. If it just showed the current author then we wouldn't need the action whatsoever because we can do this:

```erb
<%= @post.author %>
```
You should remove these whitespace additions.
добре
Oh really?  This was just a fun thing I did for fun :)
That does the exact same as:
```r = rule.act()```
Let's refactor the functionalists for photo  into a different class in controller.
I indeed messed things up... I'm commiting the fixed path.
I agree - you can probably just delete this?
Ditto - full stop
Derp, thanks for that.
Yes, why do you want to remove it? You don't want to have logs?
Надо в finally.
Правильнее использовать FileReader, если потом собираешься его в BufferedReader засовывать.
Полезно писать, что за символ не нравится программе.
Вместо new String() правильнее писать просто "".
This method is horribly long and ripe for refactoring. It is also a bit of a minefield: if you aren't careful about how you handle the conditions, it is easy to accidentally forget to press/release the right buttons at the right time, which can cause the acceptance tests to hang completely.
If you're interested, there's a typo on this line. At the very end it says "rmote servers" which should be "remote servers".
Why are you tracking multiple tokens? We only need one at a time. As this is coded now, when you request /Assets, you'll get a token. Then when you request /Asset/<someid> you'll get a separate token. When you request /Files you'll get a separate token. But the same token is good for everything within their media services account. Result is extra network traffic for nothing.
newline after this
Also here please change the name of the method to featured_section_elements_count()
Remove these comments, the line above is self explanatory.
Imho this is not the same, as this is no symmetric reflection... but maybe I overlooked something here.

> when I run the following example with the current implementation, I get 2 peaks instead of 1

This is totally correct because those two lines are separated by more than 10deg which is the default argument for the `hough_peaks` function. => [-1.50059314  1.46549155] => difference: 0.175507969474rad, 10deg => 0.174532925199rad

But I like the center of mass idea to determine the center of areas with the same peak values.
This hunk seems to be unrelated to this PR.
@GaelVaroquaux I am a little unclear about your point here, what is your concern between making it as a standalone function rather than a method here?
`Lamps_in_flat` should either be `LampsInFlat` or `LAMPS_IN_FLAT` :)
Er. Which is it?
As requested: the ternary has been refactored into an if statement.
We could use the following as a default

i.putExtra("key_language_to", displayLanguage);
`int delegate() ... function()`?!
add this into initialization list as well
Missing return value. It should return an error code if the object type is not N_TYPE_WINDOW.
public **final** HashMap<Integer, JCase> onActivityResultCases = new HashMap<Integer, JCase>();
Comment typo (the repeated)
The old code used to stop the queue by putting a special job on it (which I assume causes any dfuserver running in listener/server mode to terminate when it gets to that job).

I think you have confused two logically separate actions here:

1. 'Pausing the queue' 
2. 'Stopping the process'

The old command dfuserver stop is designed to do the latter - it's designed to be called by the init system when you call (for example) ```service hpcc-init stop``` in order to ensure that the dfuserver is terminated cleanly. It probably should have added the !STOP job at the head rather than the tal of the job queue, but other than that it seems basically sound.

The new feature being requested is the ability to pause and resume the job queue temporarily. The code should live inside eclwatch, and should look very very much like the code that pauses and resumes the thor and hthor queues - simply manipulating the wujobq so that (when paused) jobs are not passed to any process waiting on that queue until the queue is resumed.
yes prob. should be more public (INTERNAL_SCOPE)

So used to create logical files of the form:

~&lt;TMPSCOPE&gt;::&lt;tmpscopetype&gt;::&lt;filename&gt;

e.g.
~temporary::mytemp
or
~paused::mytemp

not creates:

~&lt;INTERNAL_SCOPE&gt;::&lt;username&gt;&lt;tmpscopetype&gt;::&lt;filename&gt;

e.g.
~hpccinternal::jsmith::temporary::mytemp
or
~hpccinternal::jsmith::paused::mytemp


>~&lt;INTERNAL_SCOPE&gt;::&lt;username&gt;

does need to match what is created for the user, I'll move to somewhere common.
> The phpdoc way to document a fluent interface is @return self, not @return $this

Thanks. I will keep in mind.
Current version implements show using toList
awesome :+1:
И почему, если не секрет, весь html "гуляет"? :smile:
any ideas on how this might be handled in a less hacky way?
I don't see any link to this file, is this accessible somewhere?
I'm wondering if we should talk about `id` attribute in this turorial? (mandatory, used to save widget position, should not change over version because of this)
In anycase, if you think we should, wa can do this later on!
This should be moved outside `while` loop.
Please undo this change. It makes the test suite slower to run.

Django's TestCase runs "loaddata" and "flush" on setUp and tearDown, i.e. once per test. Using ``call_command`` on ``setUpClass`` and ``tearDownClass`` loads the fixtures and flushes the database once per test case.
Sorry, I meant to say [definition lists](http://www.htmldog.com/guides/htmlintermediate/definitionlists/).
Hrmm. would it make sense to just turn this into a conditional? Maybe item.isLastIndex = if (i === j-1) ? true : false and then use {{#unless isLastIndex}} , {{/unless}}
Hard coded paths won't work on my setup. Can you just use environment vars or set up a config file?
Is there any specific blog entry or section in this page explaining this technique? I think it would be more suitable as Reference :)
Almost seems like worth logging a different message if we got the master from the znode vs guessed it...
Let's keep _warps for actual warps, and then we can place warp and warp_coords somewhere else (or keep it in geometric).
Sounds good. I'll update along with the next few docstring-related comments.
Couldn't we just skip this here completely and set the border of the resulting image to 0?
This doesn't need to be its own method - the overhead is way more than the benefit.
Yep, it's configurable as a setting -- we can simply add `MITHRIL_CACHE_TIMEOUT` to our `settings.py`.
I don't think it's especially inefficient. But does mean we'd have to re-implement the logic that libcurl already provides of creating intermediate directories.
Actually there is a `TODO` for it:
```
// TODO: remove once multi-frustum/depth testing is implemented
this._renderQueue.sort(function(a, b) {
    return a.zoom - b.zoom;
});
```

If you search the code for "multi-frustum", there are still a few other TODOs:

In CentralBody.js -
```javascript
this._skyCommand.renderState = context.createRenderState({
    cull : {
        enabled : true,
        face : CullFace.FRONT
    }
    // TODO: revisit when multi-frustum/depth test is ready
    /*depthTest : {
        enabled : true
    },
    depthMask : false*/
});
```

In SceneTransitioner.js -
```javascript
// TODO: remove this when multi-frustum is implemented.
camera.frustum.far = d / Math.tan(endFOVy * 0.5) + 10000000.0;
```
Provide the simplest possible `@example` - perhaps a triangle in a triangle.
No, we're in a DOM Image onerror event (or similar).  There's no one to catch or even see the exception.
It's an int, but I always wonder if some broken implementation someplace will ever send in a negative number.  Probably not, but I don't think it hurts to use < 1.
Consider renaming this function to `_findNode` or `_findFreeNode`.  Currently, the name implies that it adds an image, but it doesn't add anything; it finds a node that the image fits in.
Does MobileWeb support up and down?

If not, we should note it in the description.
Does sourceURLs -> source_urls also work?
> jquery классно все запутали :heart: 
Там много классного. Моё любимое — это `map` (который на самом деле `flatMap`) и `each` (который прерывается, если замыкание возвращает false, что очень удобно в кофескрипте, где всё выражение).
As per the current implementation of MarkdownExtraExtended_Parser class, array('pre' => 'prettyprint') has no influence on conversion process
what, @gkoberger?
If this code is correctly dead, don't comment it out, remove it completely.  Additionally, if bug 5625 is fixed, it should be closed.
By the same token, I'd probably make this "This makes it easier to pop elements from the back of a range and then pass it to another function within a single expression, whereas $(D popBackN) would require multiple statements."
That code was "pre-existing", so I did not actually review it my self, but good points. I'll fix it here, and create a new pull `std.algorithm.swap`.
Nice, just noticed this duplicate warning with the new Dart Editor build.
Oh boy, I was not expecting eclipse to set the TERM flag that way, that is strange. I'll merge this in and follow up with the editor folks about it.
No need for these comments. This is all explained in the documentation above
good question. I think we should not terminate in any case --> all exceptions are caught, logged and ignored.
remove vkhauri
Is this necessary?
Is it better to specify `subscribe => undef` if the service isn't running?
If the service is not enabled is subscribing to a File a no-op?
I wanted to change this to remove the != 'false' part but it turned out that the item itself does not contain only boolean values. This is quite confusing but I've left it the way it is now, since the asset publisher works this way intentionally.
Must be public - that's the sole purpose of this method's existence. :)
you should add the newline at the end of file
It seems redundant to specify both `Resources::ATOM_NAMESPACE` and `'atom'`. I would think that you could infer the name from the resource.
This try/catch block will never catch any exceptions because exceptions are only caught from the expression that is prior to the "of" clause.
We don't commit beta versions
Не может быть идентификатора у адреса
Use `.add()`, drop the conditional.