labofsahil/github-event-dataset-2012 huggingface dataset:
I still prefer the `getSecureConnection`, as it makes the code more self explanatory.

@cboden thoughts?
completely wrapping a class in a namespace definition is not standard in symfony. i would not do it this way.
you can use ``$input`` and ``$output`` directly as listener should not be able to replace them.
the question is if this might render an input (`count()` returns 0)
imho `contains` and `notContains` are more understandable
Sure. Will commit the tests tomorrow evening :)
Would it make sense to backport the fix to 2.0 then?
Cool, I didn't know you could do this.  argparse is awesome.
midooni chera khata nagerefte
akhe hanooz ke nib ro be file hat ezafe nakardi
There is a bug here. I fix this in commit 36af2c46d60a7c2438fdbe044e06e30c3af62310 (error of merge)
@remh 

- remove testing code from this module
- imports go in this order

```
#stdlib
import sys

# third party 
import pexpect

# project
from checks import Check
```
Some thought about this one is needed. What should the result look like. We should have a test for the actual result, not just its length.
The notation of the new test cases is copy/pasted from the existing test cases.

I'd prefer a multiline string literal, too, but the already existing test cases always use the notation 
```
    '<foo>'
    '   <bar></bar>'
    '</foo>'
```
this can be protected
again, please instantiate exceptions.
Line 151 has exactly the same effect. pages and ids at this point contain only the pages you can see. "root node" in the change list meaning of the word means "There may be a parent, but it's not being shown". We are in effect running the same check twice but in two completely different ways.
`add_message(request, ERROR, "Could not find a record of the last synchronization time!")`
How does this compare to `cache[key] !== undefined`?
done :), hope this is good enough
I just wondered if it was common when discussing them aloud or in writing. The meaning of -1,0,1 is better described in the `compare` docs:

>  -1 if the first is smaller than the second,
>   0 if both are equal,
>   1 if the first is greater than the second.

Reading the API on the site, I'm not sure people will know what `v` and `w` refer to.

Their use is fine as arguments in the example code, though.
this was an easily avoided typo @mecathcart @hisakonog im not sure who was working on these router functions but you should really copy paste instead of typing.
To further clarify, for JTA there is *NOT* a CORBA dependency.
This 'check' parameter is unused.
Removes these handlers and replaced with standard CacheConfigAddHandler and ReloadRequiredRemoveHandler.
yes of course!! I'm also very busy and if I would do it, maybe in the next half year...
Let's make this a guard clause, too. Less indentation FTW!
как-то длинно, и есть возможность опечататься
Better to use dot notation and stay consistent.
We should probably check with the security team about the need (and content) of the dialog title. (cc@AntonioMA). It is ok for now though.
We can probably just use .hidden at some point, in my ignorance I did this with css classes.
I understand this but we still need to put something as a value for the checkbox... or should we just keep an empty value ?
Could we merge this declarations like:

some css rule,
some css different rule,
another css rule {
  display: none;
}
Yes, what you say is correct! I have changed it, thanks.
This should be in `loadPanel()`
onode -> originNode
tnode -> targetNode
I would love to see this case and the selectList method ready for 'email' or other fields.  But we can do that in a follow up. Up to you
we should access this through the `CallScreen` object
This is a nice feature!  It made me realize, though, that artists and albums are being compared case-sensitively, when they should probably be case-insensitive. I have some random downloaded music on my desktop, and I see upper and lowercase handled separately.  The artist "Chatham County Line" us under "C", but the artist "copperhead" is under "c".

This is a separate bug, but I'm writing about it here so I don't forget. Maybe you can file a bug for it, or fix it in the PR so you can use your existing blocking+ to do it...

One way to fix this is to do a complete enumeration of mediadb, and then sort the results and then display them.

If you want them to be enumerated in case-insensitive alphabetic order, however, you'll probably have to add new fields to the metadata.  Take the artist and album names, convert to lowercase and store in new metadata fields, and create the indexes on those fields, and use them for the enumeration. But then display the artist or album name using the original name that has not been lowercased.
shouldn't be currentAddress['streetAddress'] || '' ?
sim_pin ? sim-pin to stay in sync with others ids.
On 11/27/2012 04:10 AM, steveck-chung wrote:
> My test case is external images just like the mail I forwarded to you. 
> Here is a trick in jQuery : 
> http://css-tricks.com/snippets/jquery/get-an-images-native-width/ . It 
> looks like image size would be accessible after img src set.

That example is relying on the fact that the image is already fully 
loaded elsewhere on the page and that the caching layer probably is able 
to synchronously fast-path the reuse of the existing image data.  Or 
maybe they were using Firefox; our caching layer apparently did and may 
still do a number of synchronous things that it really should not do.  
This might explain what you are seeing, but all of the examples you 
forwarded to me already have explicit sizing information on them that 
Thunderbird understands, so it really should make no difference.

But we definitely have no magic ability to synchronously load the image 
when it is remote (if it is not cached).  So we will need a load handler.

Also, I did check in Thunderbird with DOM inspector on one of the 
examples you sent me and the presence of the "src" attribute does not 
affect whether the layout engine is able to use explicit sizing 
information.  I'll cram the examples you forwarded to me into one of my 
test accounts and see if I can duplicate what you are seeing in terms of 
the resize in case in case we are doing something wrong.
We are thinking on using it to add a phone to an already existing contact from the dialer. What do you think?
Why 'p' ? Can it be more explicit.
nit: this should be a className instead of a inline style.
mock will return an empty iterator by default, the class is mocked
@brunomachado this can be removed.
Doc would be appreciated somewhere, especially as the roles of sources and target are not trivial
コマンド名なので同様に「」ではなく ``
The fewer dependencies and C-extensions the better.
Nitpicking: be consistent about space after comma.
Sure. It would be good to see if toString.getBytes is significantly slower than the approach of serializing the long into a byte array.

If it is, I'm all for adding a better approach.
https://github.com/AppScale/appscale/issues/104
>Put `form` instead of `data`.
yeah... the javadocs needs to be fixed... I caved in because I wanted to use the templating in the chat events, and there I can only use one.. :-)
I personally prefer 'normalNodeIndex', but it's probably best to just stick with 'normalNode'.
The functions and variables start with "_" may more like protect, private should stand for those start with "__"?
You can find the difference from: http://www.python.org/dev/peps/pep-0008/#descriptive-naming-styles
shouldn't you be using the working dir of the ArchiveManager here ?
Some short comments as to what's going on here might be good for future reference
``package``. And it will not replace it. You can register several paths for the same prefix.
you missed some of the extra spaces here
What's the best way to handle an error if file is empty?  Can't see any other possible issues with it.

Ref. var declaration: sure thing.  Is this a style thing or does it have functional implications?
Just copy/pasted from the old `commits.js`, but that is something I can look into
Could this be refactored to a generic message component like .msg , then sub-classed to .msg-site?

Just thinking out loud ;)
Async call is done by Dispatch
The core.edit.own action is missing here, so next line should be: 
<action name="core.edit.own" title="JACTION_EDITOWN" description="JACTION_EDITOWN_COMPONENT_DESC" />
In that's case I'd prefer to remove that. Please get rid of it and feel free to land afterwards ;) r+
I let manual call to console.error here as we aren't in a regular module here.
`content-worker.js` is manually loaded into a Sandbox from `worker.js`
so that we can't use `require` from it :(
https://github.com/mozilla/addon-sdk/blob/master/packages/api-utils/lib/content/worker.js#L154-157
Could you please add `getTabTitle(tab)` function to [tab/utils](https://github.com/mozilla/addon-sdk/blob/master/packages/api-utils/lib/tabs/utils.js) and use that from here ?

P.S.: `tab`  is actual tab node not trait or something alike.
I'm not sure I understand the reason for this change. Won't this break all the existing non-talos clients?
These tests will always fail if the datazilla environment does not have TEST_DB_PREFIX set to 'cam'. Use plsm.project instead.
Oh, cool. You could add a comment if you like... but sounds good if it's the norm.
totally remove this ?
I'm fine with this, actually. The fixture is used in three tests and they still pass (`"foo"` is still the window name so we’re good).
For some reason on my machine the cmd.name is not resolved even though the cmd.isSet. So it wouldn't startup the browsers.  And since the cmd.isSet is only set if the local argument is received, it makes to remove it. Of course it could''ve been changed to cmd.local, so it would make more sense in this context.
Perhaps kill out this `console.log()`
But we already have `NetworkInterfaces::List(string devregex)`, don't we? Please document how this is different. IMHO the key concept is "as seen currently by the kernel, not the persistent configs in /etc/sysconfig/network"
@Freeaqingme What @Maks3w is proposing is you do the assignment and *then* return:
```
$this->request = $request;
return $request;
```
Put $hex in his own line and put braces around.
It would be still invalid as we no depend on full `jquery-ui` but on custom one (only few parts are used).
This line looks like it breaks QA.
def requirements is needed in some particular cases (for instance readthedocs needs it)
The PHYSFS_setWriteDir() above (not visible in this diff) uses PHYSFS_getUserDir() as parameter. I guess you don't want to do this, but to call it with the result of getUserApplicationSupportDirectory() too.
So I suggest you make a variable base_write_dir equal to PHYSFS_getUserDir() or getUserApplicationSupportDirectory() depending on the value of SOLARUS_USE_OSX_INTERFACE. Or better, make a separate function get_base_write_dir() (private to FileTools) to return that string.
After talking with John Hann, it seems this flag has been abandoned. I'll remove it.
@anti yhtiö puuttu joinista!
`#each` >> `for` :smiley:
Where do you use these USEs? I can't find. So it seems this line is unnecessary.
and Flask-Babel depends on Flask, see: https://github.com/mitsuhiko/flask-babel/blob/master/setup.py
I don't think we want Pelican to depend on Flask! ;-)
Maybe we should make HST a variable?
remove launch file from cob_hardware_config and use the ones on cob_bringup
If you rebase this onto master you can use the new `users.tests.user` modelmaker.
This is ultra-picky and not very important but if you go for the parameter indentation style like you do with the `dict(...` line, then make every parameter indented. E.g.

```python
response_ok = self.client.post(
    reverse('manage:event_edit', kwargs={'id': event.id}),
    dict(self.event_base_data, title='Tested event')
)
```
Indeed! You can just merge the code with the normal #initialize method.
I initially didn't know if that line was relavent - it appears beneath the radiogroup, and there is already a section header not too far above it - I've uncommented it for now
Ah, that's how you do that.
This registration is done by Siege.ServiceLocator by default -- it shouldn't be necessary :)
In the near future this wrapper classes should be grouped.
if you're intending to pass this to a couch view do you have to worry about javascript zero-indexing months? or is that addressed elsewhere?
yeah, it should probably be moved to another (private) package
yeah it's not really used I think.  The size for instance (12) is not valid as well. It should read 12px.
You can just do `return selected == 'bold'` :)
Restore this new line. PEP8 specifies that import groups should be separated with a new line. One of these is an external library, the other internal.
You're right.  I can probably make /etc/sysconfig/openshift-cgroups go away.

/etc/stickshift/stickshift-node.conf configures the service as a whole.  It defines file locations and other service variables.
/etc/stickshift/resource_limits.conf defines only tunable values that are used to set limits on individual accounts.
Depends on your operating system. If you're using Windows, it will try to use windows EOL unless Git instructs it otherwise. A lot of standard git configurations normalize to LF, but this ensures for both backwards compatibility as well as non-standard configurations.
Done. It will be undefined but falsy nonetheless.
Should be wrapped in single quotes.
I've also slightly extended this test to show that he could delete a comment before he was removed and could no longer do it after he was removed.
There is a test, ignore this.
That's my mistake I thinking in terms of logic from our own application ;)
I may not have enough context, just looking at this diff, but where is it thrown?
do a showUploads() here... what if i delete all but one upload.... the screen will never update!
As the PR notes say, I was testing my changes, and was unable to test them because the blog settings page doesn't currently work. If I realised this before I started I would have fixed that as a separate PR and branch, then branched and done this one from there.
Without this change I couldnt verify the settings stuff works.
Так этот метод тоже "наружу". Кстати, если я правильно понимаю, метод можно сделать "приватным", если не объявлять его в интерфейсе класса. Надо бы проверить при удобном случае догадку.
магические числа... тут лучше узнавать длины цепочек динамически.
@voleg каждый почему-то видит в задании что-то своё. Я же почему-то вижу там слово "заменить", и мне сразу становится понятно, что имеется в виду "сделать отличным от текущего". "Строго один раз" - значит, что по одному и тому же индексу менять один раз.
если мутация прошла, зачем этот элемент опять мутировать? алгоритм, мягко говоря, несколько запутан
You may want to look at : https://github.com/rails/strong_parameters/  Its the way that rails 4 will deal with parameters.  Wouldn't kill myself to use it but just something to keep in mind.
in which case is Mongoid not defined?
Interesting way of doing the factory pattern.  This makes the most sense, and even allows for mixing in other classes.  Fun times Moose.
This private interface needs documentation.
I see, you can keep the check. just make the other createInputStream() invoke this one.
Docstring should explain what the function does. Also, doc for label parameter is missing.
is FFT by default the best? could the influence of fft vs irr vs mt be illustrated in an example?
ok I see why now with the .average ...
Nit (more of a question): is it possible to serve it directly without having to use a `301Moved Permanently`? /cc @cmcavoy
I don't think it's great to cache boolean variables this way (because false can never be cached), it would have to be more like 

`@confirmation_period_expired = @confirmation_period_expired.nil? ? self.class.expire_confirmation_token_after && (Time.now > self.confirmation_sent_at + self.class.expire_confirmation_token_after  : @confirmation_period_expired`

and that doesn't help readability enough, right?
Last ones seems best.
There is no need for double empty lines.
I think a better place for this is in a `.. tip::` block.
Please expand acronyms on first use.
Sounds great, open a ticket about it also, so it goes into the changelog.
This would go on one line. I tend to use the default vim indentation in these cases which gives you a bit more room for the message.
Good to know! Is there a numpy standards doc I could consult?
Was the security check removal on purpose?
Oh yes. Thanks for pointing that out.
ТУпой вопрос: а после throw код же не продолжает выполняться. А что будет, если у меня исключение вылетит, и не дойдет выполнение до lock.Good () ?
yeah sry, i've tried to check my modifications with the library itself and fix my violations and warnings, could've missed some from the latter also (the lib itself still has some warnings).
Not sure the parameter should ever be `null`. You should either throw back an exception or capture this with an `Assert` call, etc.
+1 to that article
Please remove this debug line
please restore extraline
Concatenate these please.
Hey hey, give that poor operator some room, he can hardly breathe!
`mapcat` would do all this nicely for you:
~~~clojure
(mapcat (fn [[key value]] (repeat value key)) a-map)
~~~
Ooops, fixing in next refresh
why `servers2Hash.values().size()` instead of just `servers2Hash.size()` ?
Right, but this executes exactly when we are rebalancing (see top condition dm.isRehashInProgress()).
Same question about assumed encoding as above.
What if the module from `pylab_setup()[0]` doesn't have a FigureCanvas class. Then the line `return backend_mod.FigureCanvas(self)` would result in an error. So it does with IPython that uses his own backend module but without a `FigureCanvas` class.

The old `def _current_figure_canvas(self)`works because in case it doesn't find the right `FigureCanvas` it returns `None`.
It's fixed !

Thanks,
Sorry @jgerigmeyer I think I misunderstood this. It still works if you pass it a locator tuple.
```php
'firstName' => LightMetaProperty::fill(new LightMetaProperty(), 'firstName', 'first_name', 'mountain of parameters', _('Имя'), _('Имя, которым Вы будете представлены на форуме')),
```
ты про такое? Ой боюсь. Я вот честно не уверен, что это одобрят (это не сгущая красок =)
Should this be configurable?
how about exists()?
The keys should be `USERNAME_NAME` and `USERNAME_NAME_EXPLAIN`
Yeah, that looks good
Add size attribute.
`DataChunk` is serialized by thrift, not Kryo. You're right, we can delete this since they don't exist anymore. I'll do that!
Why the reformat here? This and the next 4 changes look like formatting that could be leave as they were.
Why did you change from "FooterContent" to a "Debug" property? FooterContent seems to me like a much more realistic and easy to understand example of what you might add through SiteConfig. "Debug" is verbose, it can be misunderstood to have a special meaning (which it doesn't).
Right - ok, so I agree with your approach. Although I wouldn't mind starting off with a somewhat bigger buffer.
- removed removed .art-connections code from previous hybrid design
- all .multiple choice (Review Questions) at eoc should be 2 column


On Wed, Dec 5, 2012 at 4:10 PM, Philip Schatz <notifications@github.com>wrote:

> In css/ccap-biology.less:
>
> >    &.art-connections { display: none !important; }
> > +
> > +  &.multiple-choice {
>
> Is this the exercise part of art-connections? "multiple-choice" seems like
> it could apply to any multiple choice question
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Connexions/oer.exports/pull/33/files#r2328049>.
>
>
Should the type for parameter ``$categories`` not be "string|null" instead of "string"?
- Are you sure ``$decimals`` has the correct type as "integer|Boolean|string" is not a sub-type of "string"?
- Are you sure ``$thousands`` has the correct type as "integer|Boolean|string" is not a sub-type of "string"?
Should the type for parameter ``$tableGateway`` not be "null|TableGateway\TableGatewayInterface" instead of "TableGateway\TableGatewayInterface"?
Are you sure ``$charlist`` has the correct type as "null|string" is not a sub-type of "string"?
Should the return type not be "null" instead of "ListenerOptions"?
It seems like ``$lang`` was never initialized. Although not strictly required by PHP, it is generally a good practice to add ``$lang = array();`` before regardless.
} catch (e) { 空格啊哥。
yeah, true, I was trying to specify exactly what err would be - but it's just as good to say 'it will be falsy'. shall update
Thanks for the example.  I originally started down this road for all the DOM-based synonyms, but decided to leave the comment boilerplate in place until I got a better handle on that API.  I've done quite a bit of work in SL3 & 4, but rarely needed much interop with the DOM.

Ref: [SL 4 UI Lib] (http://lucaui.codeplex.com/),  ([Demo](http://www.lucastudios.com/SilverlightDemos/Index/XamlaApp))
looks like this `$this` was for scope referencing?
Jotta päästään eroon kalliista `count`:sta ja `=`:sta
~~~clojure
(empty? (filter (complement pred) a-seq))
~~~
Hmm. Yeah I'm not sure. The instance where you get here is when you attempt to call a method that is not found, right? In which case no method error makes sense. Is there an instance where you would not be doing that?
This makes sense. Fewer actual methods calls.
This pattern of setting `aria-hidden` and `tabindex` gets repeated so often, a helper method would be nice. I'd suggest adding a set of methods with `jQuery.fn.extend()`.
I am extremely curious how you noticed this :P Thanks for pointing it out.
do these really look terrible without smoothing?
You should remove this blank line
This feels awkward. Maybe "Sets the time to wait between running the MapReduce phase on accumulated map values."
No, just forgot to remove part of a template.
Actually; take a look here: https://github.com/subtlecoolness/wormgas/commit/03aeb004a5a18c3aa69d3e38fef3d968630097eb

Unmerged from my unit-test branch. It's much shorter and automatically fixes any missing config entires on the fly whenever wormgas is started up.

I'd prefer that you cherry-pick that change and then add the additional fields below to the dictionary I added in that commit.
I don't think this is still necessary. We will parse URI before searching, then we just execute 'inArray'
With this you can get all posts by the user at the same time as all posts with comments by the user: http://mongoengine-odm.readthedocs.org/en/latest/guide/querying.html#advanced-queries
Not good. You are appending `confirmation_token` manually. See `url` tag to see how you pass this as a parameter so that it is constructed automatically.
Probably already asked ... you cannot do without it?
> But why would I use `with` if it works the way I did it now?

Because `with` removes the variable at the end of the scope. Without `with` you put the variable into the scope until the end of template, with `with` you limit this scope. It means that there is less chance that you overwrite something else and so on.

> So the user profile should work?

Yes. You do not have right version of mongogeneric installed, I bet.
Do it like it is done here:

https://github.com/wlanslovenija/nodewatcher/blob/master/nodewatcher/frontend/templates/registration/activation_email.txt

So move one line up, two empty lines bellow.
I would really like to understand this line before we commit it. Can you point to some page that explains how this check might free memory in IE?
Why would you need to add the returned specimen to a dictionary?
yes, the reason is that otherwise subfolders with that name is also ignored. the problem occured since lib/ was ignored (under the External libs section), and that also caused profiles/lib/ to be ignored. so it seems better to prefix folder names with a slash when we're ignoreing specific folders/files.
Super minor note, s/reqest/request above
Sorry, but a language-specific method doesn't seem like the right way to do this. It's definitely not good to have the german translations hard-coded in the model - That's what `config/locales/de.yml` is for.
Todo arreglado ( al hacer la modificación se ha borrado tu otro comentario :o )
Is there a reason you did it this way?  To me, if there is a session owner it should define the auto close behavior.  But maybe you ran into a practical issue there?

Specifically I would think:
```
if ( isClosed() ) {
    return false;
}
else if ( sessionOwner == null ) {
    return isAutoCloseSessionEnabled();
}
else {
    return sessionOwner.shouldAutoCloseSession();
}
```
>   Can you post your concerns there instead?

I didn't mean to start an argument.  I was just responding to your comment
that backticks are evil.  Sometimes they are needed.  I'll shut up now.  I
know the issue has been debated at length and closed by Jeremy.
Maybe you can have `_before_search` return nothing, and `abort` if necessary?
It doesn't look like you need to pass these arguments
$prop is not pascal cased, it should be named something like $rawProperties.
Consider moving the *Settings classes to either:

* A new folder like Common/Internal/Settings, or
* Into the *\Internal folder, like ServiceBus\Internal\ServiceBusSettings (this would not work for the StorageServiceSettings, tho)
Extra space after nextElementSinling.
Why does __file__ have to end with slash?
You should not add a blank line here.
maybe `reference` would be more accurate?
Just curious I guess, but in the ZSH manual, `==` is listed as a valid operator for `[[`.  Could you explain why you don't like seeing them together?

(http://zsh.sourceforge.net/Doc/Release/Conditional-Expressions.html#Conditional-Expressions)
Why are you changing these?
we should remove the commented out block here
Здесь имеется ввиду {% load uc_crop uc_resize from uploadcare %}
Then use relative imports (to be backwards compatible, you can do on the top of the file also `from __future__ import absolute_imports`.

Because it makes imports easier to maintain and in the code you can easier see where each code comes from (locally our somewhere else). The code is in some way in this way namespaced. And it is also in [Google Python Style Guide](https://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Imports).
Please format comments consistently. Inline comments should have a space after `#` and start with an upper letter (but without dot at the end).
Yes I do. `builder` used to be called `bld` and it looks like I didn't clean up properly.
I just converted the one debug call to a system.out and removed the other two since they seemed extraneous.
why not center tag?
Ah, maybe, I wasn't sure if it would muck things up.  Spurred on, I'll give it a try right now...
Do we really want CorrFunc to be inherited from GSObject?  I think similar to my suggestion to use private inheritance for the C++ layer, it would be clearer to have a GSObject member which does the heavy lifting, which we would call directly.  But I don't think we really want people to think of this as a GSObject.  Those should be reserved for objects in the sky (stars/galaxies).  CorrFunc is something different.
Please maintain the bracing style.
This should cache `object[prop]`.
how about if we make a field, which is fed by a constructor param of ExecutorService.  The default ctor could assign this to  Computer.threadPoolForRemoting, but the fact that we could supply an alternate gives us a chance to do pojo testing
b3 is provided on Denis website - we could also upgrade it to rc1 I guess. which is here: https://github.com/downloads/SiteSupport/gevent/gevent-1.0rc1.tar.gz
Yeah, I'm not a fan of putting this here, but Brad can decide whether this is the right layering. Either way, the implementation looks fine.
I <3 high-level expected behavior explanations.
Wait, why is it commented? Doesn't look right.
The zookeeper map gives us a view of a java set, so it seems easiest to just take that. I guess we could wrap it in a scala set.
meant to do this in local copy only but I'm new to this terrifying world of dev pain you call git
This file is obsolete i think. Next uses FreeRTOS ARM_CM4F instead of ARM_CM4.
Because it's a private method that deals with that matter (registering a Job) and that I don't see any other way to get the StepLocator from a Job with the current code.  Changing this makes the API more clear but on the other hand this is a private method.

At this point, I only see moving the cast back to the caller which I don't like and I don't think it adds anything useful or create a new component that allows me to get the StepLocator from a Job.
why not doing the refactor-friendly version?

```java
Log.e(TheClassIMinto.class, ...)
```
any specific reason for storing the body of the request? this can lead to sensitive data leak, as exceptions can be serialized to logs
you can use `exclude: [:destory]`
For backwards-compatibility, allow resource_dir to be a list, or a single item.
PEP8: base_test.py:70:1: W391 blank line at end of file
Can this and the CMake one below it be turned into proper links?
Certainly happy to change those values to something else - the point is to not throw an exception, so that we can import large floating point images (as per #9732).  I'm not sure that casting the min/max values for Float or Double is going to yield viewable images either, though:

```
$ cat test.bsh && echo "-----" && bsh test.bsh
long floatMin = (long) Float.MIN_VALUE;
long floatMax = (long) Float.MAX_VALUE;
long doubleMin = (long) Double.MIN_VALUE;
long doubleMax = (long) Double.MAX_VALUE;
System.out.println("float min = " + floatMin);
System.out.println("float max = " + floatMax);
System.out.println("double min = " + doubleMin);
System.out.println("double max = " + doubleMax);
-----
float min = 0
float max = 9223372036854775807
double min = 0
double max = 9223372036854775807
```
You're right, and I'm tempted to go further removing `image_t` entirely and change the next line to `coordinates = np.transpose((image > peak_threshold).nonzero())`
I am a bit worried that this changed is going to induce a big slow down.

Indeed, in Cython, iterating over xrange is transform intro a tight C loop, while iterating over an array will kill in the array indexing mechanism, that is not cheap.

I think tha
Same remark here: `nbIterationsDiscretisation`. Usually we have variable such as `n_iter`. In this case you can write:

```
                n_iter += 1
```
Don't do a dot product with a diagonal matrix: this is just equivalent to doing a vector (element-wise) multiplication, which is faster.
In my experience if the graph is not fully connected then the result is not good. The null space of laplacian is not of rank 1, then actually each basis of it could be the top eigenvectors which may not separate the samples well.
The comment and the printed string should be changed.
BTW, I called it `class_prior_` to follow `MultinomialNB`. Do you treat the binary case differently in it?
On pourrait aussi essayé de passer celui ci dans typing. Je dirais qu'en faisant dépendre Types de LocalDeclaration, on peut récupérer toutes les variables local et ainsi lorsque c'est celle ci, on ajoute le assignable. J'ai peur par contre que ça rajoute beaucoup de traitement pour pas grand chose ...
Another thought: What's with `.XAR` files or `.Xar`? Should we also support that and use case-*in*sensitive way of comparing? - see thekid/xp-experiments@b157ecb - this would be:

```sh
$ xpcli Profile EndsWithInsensitive -t 1000000
== Profiling lang.XPClass<EndsWithInsensitive> ==
substr_strtolower: 0.630 seconds for 1000000 calls (1587379 / second)
substr_strncmp: 0.498 seconds for 1000000 calls (2006384 / second)
strripos: 1.218 seconds for 1000000 calls (820966 / second)
substr_compare: 0.539 seconds for 1000000 calls (1856735 / second)
== Memory used: 2023.953 kB / peak: 2298.938 kB ==
```

But not sure if this is really necessary.
I see your point. Will you update the PR with the reset node and user pattern?

Thanks for replying so quickly on an otherwise old PR.
Looks like I reverted when bringing over new changes from CW. We should use your version instead.
>It is how my commits come out flawlessly now 

@alta189 goes to look for flaws
I see no harm in having the populator use both a custom repository method and the `is_indexable_callback` if both were provided.
s/recieved/received/

Also log the class name and method name, so the origin of the log can be found easily. Goes for all logging messages
maxdate goes before min
each get should read as 

    results.get( x );

(add the whitespace)
yes, do/while hang over from prev 'n' limited, will change to a for loop
append will typically allocate extra elements in chunks, in the expectation that if you added one you will probably soon add more.
What about remove?
Why not having a variable in the base class of all REST proxies that initializes the mock server once and then use it? Instead of having this line with each method
There is no guarantee that cluster name will be there. It could be empty. You should use org.elasticsearch.cluster.ClusterName instead.
This is not correct anymore, there are no Zend\Config specific features anymore for XML, the namespace was dropped.
yes, the format is so that the same partial can be rendered in the page context or through json, as its being used here. The other way to get this working is just to delete the html part from the partials name, which I'm not above :-/... I'm not sure I tried the whole name, I'll give that a try.
yes, I didn't think that the result will only be one person (I suppose we don't support wildcards!), so I can optimize that up.
Crap, copy past fail :P
Please not use general reference, only references to the technique used in the module.
Will fix

-Josh

On Aug 6, 2012, at 12:56, jlee-r7 <reply@reply.github.com> wrote:

>> @@ -158,12 +162,16 @@ def initialize(prompt = DefaultPrompt, prompt_char = DefaultPromptChar, opts = {
>>        # Whether or not command passthru should be allowed
>>        self.command_passthru = (opts['AllowCommandPassthru'] == false) ? false : true
>> 
>> +        # Whether or not console command aliases should be allowed
>> +        self.allow_aliases = (opts['AllowCommandAliases'] == false) ? false : true
> 
> This is a confusing idiom. ```!!(foo)``` is much more readable.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/rapid7/metasploit-framework/pull/637/files#r1313963
Oof, you're right. I'll fix it.
Can you add a section on how to compile it?

Also add which GWT and Java version used.
This should come back to the user because we have not casted the compute message yet. I have not tested this but i would think that the user should get back an error on this call as UnprocessableEntity because i convert that in the api action method.
is it faster to update the individual elements in the TypedArrays than to pass in a javascript array in the TypedArray constructor? to precompute the size of the array, you have to loop through the polylines to get the count and then loop through them again to pump the data into the typed array.
The eclipse formatter doesn't like more than one variable per `var` on multiple lines.
Given the assignment to `result.type` above, do we need to check for `undefined`?
For small arrays, copying is faster than slice, however, this code doesn't really have to worry about performance and slice is simpler, so I'll change it.  I use slice elsewhere like this already.
This should definitely not be here. ios doesn't need to kill the adb server (and that may have unintended consequences if an anvil run for android is happening concurrently)
I see...I don't like it (what does "proxy" have to do with "events", which are the only methods exposed), but if the object doesn't behave like a normal JS object, then I guess it's worth documenting. The documentation for Proxy needs to be updated or created to mention the differences between Mobile Web and the other two platforms.
`when the app is in the foreground` phrase repeated twice.
Re: height. Not following. Setting the height worked fine in my testing. Setting the height via style would break the layout algorithm.
Why not just check the length of [newUrl fragment]? That returns the part behind the #, according to RFC 1808 ( https://developer.apple.com/library/ios/documentation/Cocoa/Reference/Foundation/Classes/NSURL_Class/Reference/Reference.html#//apple_ref/doc/uid/20000301-BAJBEIHD )
Done, changes pushed. Good catch.
It might be good to extract "style" as a constant since it's used several times here.  Perhaps PROPERTY_STYLE?
This makes more sense. If an app was launched with a URL and then comes through in a "resumed" state without one, I'm fairly sure that the old URL doesn't get overwritten.

So to prevent stale URLs and still give access to the launch URL to background services, perhaps clear the stale one during "resume"?
the amount of additional work required in this case when adding a platform would be trivial IMO but I agree this can be optimized.  updating
As we say in my country, "D'oh!!"
Indent these just 2 extra spaces. Use " " after ":".
call this `set_list_class`  easier to read, and only used to set the list class for embedded document fields.
I edited _MemberRegistrationTest_ so that the dependency resolution is not longer offline. Now I get 

	13:12:22,785 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-6) MSC00001: Failed to start service jboss.module.service."deployment.criteria.war".main: org.jboss.msc.service.StartException in service jboss.module.service."deployment.criteria.war".main: Failed to load module: deployment.criteria.war:main
		at org.jboss.as.server.moduleservice.ModuleLoadService.start(ModuleLoadService.java:91) [jboss-as-server-7.1.1.Final.jar:7.1.1.Final]
		at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811) [jboss-msc-1.0.2.GA.jar:1.0.2.GA]
		at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746) [jboss-msc-1.0.2.GA.jar:1.0.2.GA]
		at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [classes.jar:1.6.0_31]
		at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [classes.jar:1.6.0_31]
		at java.lang.Thread.run(Thread.java:680) [classes.jar:1.6.0_31]
	Caused by: org.jboss.modules.ModuleNotFoundException: Module org.hibernate:ogm is not found in local module loader @6a3b8b49 (roots: /Users/hardy/work/hibernate/git/ogm/ogm-kitchensink/target/jboss-as-7.1.1.Final/modules)
		at org.jboss.modules.LocalModuleLoader.findModule(LocalModuleLoader.java:126) [jboss-modules.jar:1.1.1.GA]
		at org.jboss.modules.ModuleLoader.loadModuleLocal(ModuleLoader.java:275) [jboss-modules.jar:1.1.1.GA]
		at org.jboss.modules.ModuleLoader.preloadModule(ModuleLoader.java:222) [jboss-modules.jar:1.1.1.GA]
		at org.jboss.modules.LocalModuleLoader.preloadModule(LocalModuleLoader.java:94) [jboss-modules.jar:1.1.1.GA]
		at org.jboss.modules.ModuleLoader.preloadExportedModule(ModuleLoader.java:233) [jboss-modules.jar:1.1.1.GA]
		at org.jboss.modules.ModuleLoader.preloadModule(ModuleLoader.java:246) [jboss-modules.jar:1.1.1.GA]
		at org.jboss.as.server.moduleservice.ServiceModuleLoader.preloadModule(ServiceModuleLoader.java:160) [jboss-as-server-7.1.1.Final.jar:7.1.1.Final]
		at org.jboss.modules.Module.addPaths(Module.java:841) [jboss-modules.jar:1.1.1.GA]
		at org.jboss.modules.Module.link(Module.java:1181) [jboss-modules.jar:1.1.1.GA]
		at org.jboss.modules.Module.relinkIfNecessary(Module.java:1207) [jboss-modules.jar:1.1.1.GA]
		at org.jboss.modules.ModuleLoader.loadModule(ModuleLoader.java:208) [jboss-modules.jar:1.1.1.GA]
		at org.jboss.as.server.moduleservice.ModuleLoadService.start(ModuleLoadService.java:70) [jboss-as-server-7.1.1.Final.jar:7.1.1.Final]
		... 5 more

In this case I have not started my local JBOSS instance and it seems it try to use the one downloaded into the target directory. However, looking at the error message I would think the ogm module is missing. How does this get in there? There is the gmaven goal, but that installs into my local AS installation? Am I supposed to point $JBOSS_HOME to _target/jboss-as-7.1.1.Final_? But where and how to I then run the gmaven goal?
On Thu, Mar 8, 2012 at 10:13 AM, Daniel Pittman
<reply@reply.github.com>
wrote:
>> @@ -0,0 +1,17 @@
>> +module Facter
>> +  module Util
>> +    module PuppetSettings
>> +      class << self
>
> `def self.with_puppet` is generally preferable - because you can clearly identify each function individually.

Should be addressed in https://github.com/puppetlabs/puppetlabs-stdlib/pull/50

-Jeff
This should probably be `if ($this.data('originalTitle'))`. Otherwise the destroy method will create empty title attributes if the user used one the data attributes to populate the tooltip content.
Hard decision. Why don't we just yield all those things inside application.js?
Then I must be daydreaming huh ?
And _where_ is that documented if not in the body of `isBidirectionalRange`? One of my personal problems with `@property` on the whole is that no two people can agree on what should and shouldn't be `@property`. I'm not arguing that `isBidirectionalRange` accepting a  `@property popFront` with `-property` might not be a bug between the intended and implemented design of ranges, just that as a developer external to ranges, etc., the implemented behavior of  `isBidirectionalRange`, etc. is all the documentation I really have to go by.
`j` is used for indexing `mt` and comparing against `n` (which is a `size_t`), so it should be `size_t`, not `int`.
I think the term "perform" is lost here. Do you mind if I refactor a little and keep nc?
there is a double space after *JAX-WS* :-)
Document in wiki, don't include in startapp, perhaps?
Well, if the goal is to document things, provide them commented (as done for the FOSUserBundle skeleton)
is.available() does return 'file_len - cur_pos' for HDFS file. But not for LocalFileSystem. I don't think we should depend on that.
Done, Moved to project VaadinSmartGWT.components
that's fair

On Wed, Sep 26, 2012 at 12:05 PM, Paul Kalupnieks
<notifications@github.com>wrote:

> In app/presenters/woople_theme/content_item.rb:
>
> > @@ -0,0 +1,8 @@
> > +require 'explicit_delegator'
> > +
> > +class WoopleTheme::ContentItem < ExplicitDelegator
>
> Keeps it consistent in style with the rest of the theme.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bigbangtechnology/woople-theme/pull/99/files#r1697196>.
>
>
We iterated the last one up to 0.2.49 so I don't think it's a stretch to assume we'll hit double digits in 0.3.xx.
metavar='UNITTYPE" to specify the blurb that's current "CONSUMERTYPE"
why ``isRequired()`` and a default value at the same time ?
assertExceptionWasThrown
I'm not quite sure what should happen here. It looks like the naming convention of the bundle needs to change if you want to keep this as it was previously.
A comment telling something like "Django.utils.timezone introduced in Django 1.4" or "Backward compatibility for Django < 1.4" may be useful for the ones who read the code.
This docstring should clarify what the ``result`` parameter is expected to be. In general, one of the most important roles of a function docstring is to clarify the expected type(s) for parameters and return values, especially if they are unusual or user-defined types.
Do we need the `if`?

http://code.google.com/p/trimpath/wiki/JavaScriptTemplateSyntax#Loops
OT: There is one question (I'm no expert in inner details or R-T).  What would GC do when it tries to collect the object that was explicitly finalized by user? I'd suspect finalizes it again.
Your thinking #prgama above GPL here?
doctrine/DoctrineORMModule#151 merged, added comments on doctrine/DoctrineORMModule#150

Awesome work so far! Thank you!
These should be puppetlabs/apache with slashes
Mejor que obediente yo diría compatible
Excluir esta linha em branco
Add link to discussion post: https://community.jboss.org/message/772475
日本語で。
put something realistic in this comment
again, compare Result() objects rather than strings.
Capitalize column headers.
Done.

Ok, sounds good will do this from now on.
You tell the command that. It keeps on throwing up w/o it and it tells me I need it. :)

Sent from my digital shackles. 

On Mar 26, 2012, at 11:08 AM, Nirmal Ranganathan<reply@reply.github.com> wrote:

>> @@ -181,6 +181,7 @@ REDDWARF_ROLE=$REDDWARF_ROLE
>>     SERVICE_UUID=`keystone_manage service-list | grep reddwarf | awk '{print $2}'`
>>     if [ -z $SERVICE_UUID ]; then
>>         OS_USERNAME=reddwarf OS_PASSWORD=REDDWARF-PASS \
>> +        OS_AUTH_URL='http://localhost:8779/v0.1/$(tenant_id)s' \
> 
> If you have the endpoint and token you shouldn't need OS_USERNAME/PASSWORD or OS_AUTH_URL
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/hub-cap/reddwarf_lite-integration/pull/22/files#r603824
OK, can you decide for one and make it consistent? :-)
I agree with tallowen here. I like the definition of `failure_url` and `success_url`, but `self.get_success_url()` and the analog for failure should be used in the methods. This allows for greater flexibility for subclasses that may want to programatically decide the success or failure urls based on the request. `get_success_url` should be fine as is, and `get_failure_url` will need to be defined.
I copied the button from the corpus summary. A select with options? Oh I see. I can do that too. In that case I add a class to each option, right? I am guessing I can use the same class name for all options/li items as whichever option/item is chosen, it calls the same function (show the second step), is that correct?
I think ideally it should be possible to do the below:
var fileInfo = new MockFileInfo("z:\\a.txt");
var writer = fileInfo.CreateText();
writer.WriteLine("test");
writer.Close();
https://github.com/jruby/jruby/wiki/CallingJavaFromJRuby
Even this could be rewritten to `$element.data(PLUGIN_NS+'_intouch', val === true);`
Got it - will create the socialcast_review_buddy method. Thanks
The HttpOpener opens a Url and thus depends on a network connection and the server corresponding to the Url.
тут никак не проверяется, что используется правильный gcd. Он мог создать новый и им пользоваться...
и в дополнение тут какой-то полный копипаст. может в одну функцию засунуть...
assume assignOnVertexSegment_
did the line endings change or something? no way I can review this without a clean diff...
is this hash being exposed to the developer?
It definately needs to be outOfProcess or we will not recieve the event that its created or be able to attach the window object properly.
Don't you need to call success() ?
Look at String.format();
should be:

var $container = this;
"it's means "it is"
Should TODO's be in doxygen?
No new lines for brackets
"is inserted to" refers to "the keys", so it should be "are inserted to"
Here I try to make that prepare method tries to connect automatically if the connection is not done yet.