labofsahil/github-event-dataset-2012 huggingface dataset:
travis passing modifications and STANDALONE setup phpunit tests
Beck vincent

Projet fini
Next closure webworks

Initial commit of custom require. It currently only works on the client side (from within webworks.js). Another change is coming to test it on the server side (from within the framework).

This also includes changes to the framework to remove the assumption of
using window.require.

Also includes changes ti ignore and lint setup to allow lint to pass. I
had to turn off the node settings which meant I needed to add some
predefines. I think this is a better approach anyway since we are only
using node for testing.
Added a new error constant for blackberry.push

Added the new error constant SESSION_ALREADY_EXISTS = 10112 to WebWorks.
Ciao

Ciao. vorrei collaborare con te a questo progetto. potresti contattarmi?
Mike
Set device url
Made some fixes to events and store refresh

Hi there! First of all thanks for this repo, saved my day on a project :)
I found out there was a parameter missing (according to the latest ST2 docs) on the itemtap event - the record associated to the item - and easily fixed it for every "item*" event.

Moreover i changed the behaviour of the doRefresh function to reflect the non-buffered-list one. It'll put the scroll right on top now on refresh, to fix an issue with filtering after scrolling: if you scrolled down to "page" X and then filtered the store, getting Y<X total "pages" the buffer would fizzle.
GMail / GAPPS support

hi,

i needed gmail/ google apps support in the plugin and hacked it in, if you think the changes are worth wile to pull back, feel free to pull them :-)

cheers
norbu09
emaiax - pull request
Added missing ";"

There was an mising ";" at the end of private const string AppId = ""
Fixed video stream

Hi,

I fixed this plugin, as up to now, no Stream could be opened (ZDF has changed their file format).
This is working now again.

Btw: How to add this plugin to the Plex App Store (or Plex Online)?

cheers
Barclay
fixes for package renaming and open helper

Some basic package renaming, and one cleanup of how openhelper handles RW vs RO databases.
Classes CDate, Location

J'ai modifié la classe CDate pour commenter les opérateurs <= et >= qui ne compilent pas pour l'instant. On verra si on en a besoin ultérieurement.
La classe Location est là et ça compile.
Internationalization bootstrapping and such

This should be all bootstrapped. Have a look at the layout and let me know if there's anything that needs further tweaking.
improved 'relative' mode positioning

I liked the idea of turning on the 'relative' option, but in my layout at least (a simple jQuery Mobile form) it was pretty broken. I made some changes to improve how the error prompts are positioned. This includes:
* changing the container span to a div so that it uses block positioning and shows up under the field
* inserting the div AFTER the field to improve the layout, not before
* added a relativePadding option that will insert spacing under the prompt that's the height of the prompt window itself, this does disturb the form, but allows it so that the error prompts do not flow over the fields/field labels below them. This option may be turned off to not disturb the form.
* Seems to work fine with promptPosition settings

The results are MUCH better at least for me, see from the images below... (ignore the error prompt text shadow, that was a css bug unrelated to validationengine that I fixed)

firefox 8 on windows 7:
original: http://dl.dropbox.com/u/9719672/validationengineimg/firefox8_orig.png
new: http://dl.dropbox.com/u/9719672/validationengineimg/firefox8_new.png

ios 5.0.1 on iPhone 4:
original: http://dl.dropbox.com/u/9719672/validationengineimg/ios5_orig.pngnew: http://dl.dropbox.com/u/9719672/validationengineimg/ios5_new.png
Add #save method to query class
A new pull request based on your comments about the previous one

I modified SaveException so that it contains two properties: okModels and errors. OkModels is an array of successfully saved models and errors is an array containing instances of a new class Error. This class contains two properties model and errors. Model is the model which failed to save and errors is an array of errors returned by the Client related to that model.

I added SaveException class to the Client and modified Client::checkResult so that it throws a SaveException which contains the results of the Salesforce request.

Mapper::save catches the SaveExceptions thrown by the client and gets the results from the exception. Mapper::checkResult loops through these results and throws it's own SaveException if needed and inserts the model and errors to the Exception.
more flexible find_related() backend

This does not change existing functionality -- Section.items() behaves as it always did. Having a targetModel however gives us the ability to generically search for specific subclass model instances.

Use case assuming a typical Content->Article,Image,Video subclassed Model structure:
* Section.items will grab every Content item.
* If you only want to grab Articles, call Section.limited_items(Article)
* One problem with grabbing every Content item is you may `render_model` templatetag instances that don't have or need a requested template. On a Section page you may only want to render Articles while ignoring Image and Video.
change constant Myapp to Rails3DeviseRspecCucumber

The name of the rails application is Rails3DeviseRspecCucumber not Myapp.
Update Music/Files/res/values-ru/arrays.xml
Update AntiSpam/Files/res/values-ru/strings.xml
Updated README

It was mentioned that current dev version of Backbone is needed. 

However tests depend on backbone 0.5.3.
Support vanilla Jekyll sites as well

Hey Jason,

I factored some of this stuff out in a way that should work for plain Jekyll or Octopress. But I don't currently run octopress. Care to try it out for me?
Allow users to save screenshot by right clicking -> "save file as..."

Updated the extension to create a temporary file called screenshot.png that can be saved with right click -> save file as... 
Removed the dependence on the regular expression match when converting dataURI to blob.
Updated README to explain how to install the crx into Chrome.
Adds all core interfaces to make the extension not rely on an actual RL1 swc anymore

Also: implements enough functionality to support the CafeTownsend demo running without any changes at all, just by swapping SWCs.
build instructions

# mvn -DskipTests package 

to get the jar to be deployed along with the job.
Update to RTM and minor fixes
Pull Req: Fixes issue #11

Fixes GHI #11: where src folder wasn't cleaned when error occurred during building.
Expanding Textarea

Fixed Issue #35.
added support for parameters in echo_trans

adding supoort for parameters in echo_trans, that it's necessary for access to array vars

example

{{ echo_trans("Display all <b>%foo% %bar%</b> results",{ 'foo': 'foo', 'bar': 'bar' }) }}
zh.yml Updated.

zh.yml file updated.
Update overlay/frameworks/base/core/res/res/values/config.xml

Closes #5
Fix example project

Fixing layout, oembed form 

Removed packages folder, added install-packages script
Updated Mummy Mod

I actually tested it in with the Reddit version and realized I'd forgotten some stuff. Should work now.
Switch all links over to dlang.org
All credits to mpgjunky (Michael Mussulis) who provided a patch with this feature request: http://pear.php.net/bugs/bug.php?id=18983

I only slightly changed to make it options you can set, and defaults changed to values that are backwards compatible.
![LTE Y U NO NEWLINE?](http://memegenerator.net/cache/instances/400x/12/12702/13006939.jpg)
Пятый аргумент ("case-permissions") вынесен отдельно, потому что нам бывает нужно рисовать органы управления моделью в отдельном элементе (например, когда идёт вид с моделью, потом пачка видов с зависимыми моделями, а потом уже надо отрисовать кнопочку «сохранить»).
У экранов могут быть аргументы (см. case, чтобы задать id модели), это можно использовать для первоначального заполнения элементов модели при переходе от экрана звонка на кейс. Также можно будет fetchCb вынести в аргументы экрана кейса, чтобы звонку ставить id назначенного кейса, когда он станет известен. Либо сделать это на сервере, чтобы там были такие actions, которые всё сделают.
Could you please give an example of a before/after effect? I just want to understand the original problem better. Thanks.
move qSlicerCoreApplication::createDirectory in qSlicerUtils ?
GJ! =)
Why compression is disabled by default? For most cases it is best solution (because, without compression nginx will take more CPU by stream compression).
anyway, whats the point of suspending @homakov?
Yes my bad, I didn't explain it well :)

About the `sleep 1` I don't really know why but without it does not work.
Hi @codyro , just putting the finishing touches to 0.5 of Hippy, I'll put this in with it.
нет даже простой вариант не работает, завел иссью пока не разрешим
thats the exact same thin fore me only i have a german server ;-). maybe we can put our knowladge together and build somthing big xD
I really wish there was a better way.
`butter` shouldn't exist here since it's not global. This probably only works because `template.js` makes `window.butter = butter` for debugging.

We can do this in `core/media.js` instead, I suppose.
Ah, I get it. Yeah, this is the way to go then.
.highlight code {padding: 0 5px;} results in the first line padding while others are not - which looks lame :(
You know, I don't think this actually works. I will remap this as ,dg and ,dp
Parcequ'un proposition est rattaché à une cadidacy qui lui même est rattaché à une election.
du coup il faut verifier que quand tu ajoutes une proposition via l'API le mec est bien contributeur ou c'est deja fait en fait?
Can we teach oprofile to find the symbols where they currently rest, rather than all this copying?
These both seem relatively straightforward from a developer and user standpoint:

    gunicorn:
        service:
            - managed
            - override: daemontools

This one seems to make the most sense to me. What do you think?

    gunicorn:
        service:
            - managed
            - backend: daemontools

In the above two examples, this would bypass __virtual__ everywhere and use ```daemontools```  to provide the ```service``` module. Is that even vaguely what you're envisioning?
What is the `Max` adding to these function names? Isn't the range range enough already without making it into a maximum range?
No idea if it's related but I just came back to my PC to find bithopper stalled with the following message:

16:58:13|poolblocks: [itzod] Found TXID, owner aready set to itzod
16:58:13|poolblocks: [itzod] parsed 25 blocks, 0 matches
Enter username for realm at ozco.in:

This was before I applied the latest commit though.   I have ozco.in disabled if that makes any difference....
this change makes it possible for boto users to suppress automatic generation of the Content-Type header
а то не буду тебе помогать , а потом Димсону покажешь он в обмарок упадет и будет битсо в конвульсиях
Does this resolve the issue where you are unable to change channels as you get a message about a current subscription?
oops. sorry this wasn't the latest version of the code. At the beginning I thought I would use stop to make it extra clear that I was stopping it.  Apparently it just disables the motor. Anyways the newer code is up.
Group类里面有`Group::nobody()`这个东西，所以不需要这个常量；而且config里面应该是写在部署的时候管理员需要改变的东西，而不是全局常量
`fatherpage_path`改成`parent_path`，用`parent`代替下面的`fatherpage`；这个`wiki_get_father_page`也改成`wiki_get_parent_page`吧
Alright! Can't wait to see this pushed to gem. I'm in the process of revamping a few of my web-services, so it will be nice to be able to upgrade to an official 1.0 release at the same time.

So far I haven't noticed any issues while testing, so hopefully the last few little things are fixed and the push can happen soon.
Suits me fine. =) Updated to reference RFC 2965.
?!?!? Wir wollen es doch laden, wieso dann die Exception?
Wird doch mit einem d geschrieben ;)
like this change
Ну так надо править, что бы не было краша в ватер линии :) Зачем все наперекосяк делать и создавать хаки и проблемы? Это кому то надо?
Yes, you are right. I'll fix the code, commit and push.
this preamble shouldn't be necessary -- so long as you're passing the first arg to declare, it should create the global for you.  you should be able to just do `return declare("davinci.review...`
Nice! I totally agree that this is the way to go.
mejor creature_text
use "we" instead of "I"
Player.cs line 822

For maybe an error in the database where gbid is saved as int and not uint, several values can be < 0, so instead of
    if (gbid > 0)
it is better to use
    if (gbid != -1)
to load every item saved
I approve of the new simplicity :)
sk89q couldn't afford enough letters
I can't explain why he has variable names like "pt" everywhere otherwise :)
I was just giving you 'official' translation :)
> I double-checked original Mirada source and it seems it started there - 16th frame OBJ was almost identical to 1st frame OBJ. Which when played properly resulted in "freeze" discontinuity, so we hacked around by dropping last frame. Everywhere.

o_o
`$options` only contains options passed by the user during creation of a field plus the default values. You cannot override options passed by the user.
Why are you using `listen_to` and `=~` instead of simply using `match`? Same goes for omikuji.rb and time.rb
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Bienvenido al módulo de clientes</title>
<link href="css/estilo_index.css" rel="stylesheet" type="text/css" />

</head>

<body>
<table width="100%" border="0">
  <tr>
    <th bgcolor="#D6D6D6" scope="col">Módulo de Clientes</th>
  </tr>
</table>

<div id="Menu">
  <table width="230" height="191" border="0">
    <tr>
   
      <th width="223" height="57" scope="col"> <a href="CrearUsuarios.php" title="Crear Clientes">Crear Clientes</a></th>
    </tr>
    <tr>
      <th height="48" scope="col"><a href="ver.php" title="Lista de Clientes Activos">Lista de Clientes</a></th>
    </tr>
    <tr>
      <th scope="col"><p><a href="Buscar.php" title="Buscar Clientes ">Buscar Clientes</a></p>
      <p>(Dentro de página Buscar podemos actualizar datos e eliminar usuarios)</p></th>
    </tr>
  </table>
</div>
<p>&nbsp;</p>
</body>
</html>
Ouch, yes, sorry. Thank you for noting.
Few nits WRT correctness. I've not looked on style violations at all (you know Style Guide better then me, anyway).
Constant please.
pogi cucumber nalimutan mo :P
コードはこれから読みますが、コミットログの一行目は#22の概要も書いてくれますか？-no-init-file does not work、くらいでいいので。
Yea, I noticed this after I pushed and immediately fixed it after with a new commit.
By retriman no?
Won't be necessary once you switch to per-method private specifications.
thx .. already merged :)
why this change? given that the directive uses several other attributes for configuration it doesn't looks weird to use class with it. can you revert it?
It looks like forcing SSL was a configuration issue and has since been fixed.

http://support.testflightapp.com/discussions/general-ios-development-problems/708-getting-error-uploading

Do you want to keep the SSL endpoint or revert back to the non SSL one?
1. хорошей практикой является использование let
2. зачем польщоваться FactoryGirl и явно создавать ассоциации ?
Me parece que faltan más cosas, por ejemplo las vistas y eso. Igual yo me ahora voy, no hay apuro.
I like the word "huge" in your commit description! :)
@dannluciano Interesting! I have a personal rule that if there are more than about 6 lines of code, I make it a separate script instead of a zsh function. I find it easier to maintain that way.

But it's definitely possible as a function.
associated Issue #3
the tarball available at https://download.joyent.com/pub/build/SunStudio.tar.bz2 is compressed by bzip2 twice.
because of that the "gtar -jxf -" fails during configure
Confirm its a mmaps compile issue. Movepoint can be set to false to. Use mmap in movepoint or not too
@nddrylliog Most likely because I was also a cup of lamesauce for doing work as root on you know what server ;) Sorry for the mess.
Can you please document that those two constants are deprecated on http://www.dokuwiki.org/devel:releases#deprecation?
Nit: can you use node's commenting style and fix spelling errors, so  `// Get options and args arguments.`
Yes, that's just leftover - should not be there (it has no effect at all).
I was testing for reverse proxy and it seems this should be left as is and the reverse proxy should be configured to set the hostname.  I did this in nginx with:
proxy_set_header   Host $http_host;
most probably rails 3.1 with its changes in update_attributes internals. are you on irc? can you ping me? (same nick as on github)
nice commit! bin meine dotfiles grad am organisieren. terminal rules
not sure if ya'll know about it but GeoJSON is a nice standard for serializing geometries (and it will make your APIs pluggable into many mapping frameworks)

http://geojson.org/geojson-spec.html#examples
Не используется далее, нафига объявлять глобально?
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

07-02-2012 23:05 tarihinde, Fatih Aşıcı yazdı:
> OK. It seems the actual log is in the previous log; but this is not
> good. You should double check your commits before pushing. I mean
> we should not use git just like svn.

Oops, i will take more care on commits, before pushing them back.
Thanks for the warning.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPMhPvAAoJEOnnAJ6Y6Zkw5jYIAJC1nRc6nSWp0n07ewIdM3xZ
yJp0I4M7ByIQ2BGavePtSNRaZZkIbVo12ePFVJi/E2S5M8aEEXPhHygblytnsg/O
lvSggjepqQyu6y8+6EbGl85zd1EIsRdUVWlJbLjB8Z19xsn5/fjFFo7doGWX2vhI
4JFtaA7JrH9M2F4e5ZqYiGPMbuajdawfZKBnlzgu8S0QFHlU2kBznwoRQqj4bbmy
uhzygcmaRRYoKjD/G4OrmAOjpj1HWgyerhszZ1am9bAkhM67/LnbdDHqUj4sMJ4+
R4QI9+tcgDyLydqgNUA5OMqugLJeAgppbkiWN0KEADNwPFa/PpAjPpMFyfPtJ/A=
=6Rox
-----END PGP SIGNATURE-----
Out of curiosity: why not go all the way to API 15? I know several developers who have skipped API levels 11/12/13 since they don't intend to develop for tablets only.
This was undeclared since 289d9d371d729d8fc48ed3a2701ef6aad14d0dbf, to be precise. I just couldn't believe that it's always me who breaks things, so I gave it a closer look :-).
Great use of ul/li for the side bar and menu links
Oh, and for variety have different colors ;-)

(A more advanced version of this could have two or more colored dots and ask the student to count the <color> dots... but for the basic one, all the same color makes sense)
La race est liée à l'User ? WTF ?
Shouldn't this call be removed?
@Betaman2k Why? just ignore it -.-!
rename missing :P 2012_02_26_01_world_spell_script_names.sql -> 2012_02_27_00_world_spell_script_names.sql
It's engrish in a sql file, not a big deal (at all...).
This introduces a cyclic dependency between NodeElementFactory and GraphSvgDisplay. We need to look into finding better ways to separate the interaction, e.g. using the model-view-controller pattern. 

The NodeElementFactory should not deal with interaction - would it be possible to add a SvgNodeEventHandler to a NodeElement later instead?
New design and engine for casualappearance.com
Yes I see how that would have made sense - I'll keep a closer eye on the refuge project in future :)
ImagePredicates.idEquals() would be a bit easier
Forgotten debug code :-)
May i ask... why? one is Battleground group and the other is BattleField group
See the latest release for an implementation of Devise confirmable and invitable.
Detected Problems :
1 - same email with PayPal option
No problem. I forked the repository, committed and fix and sent a pull request for you.

I'd like to add some enhancements to allow the following:
  1) optionally disabling the ttvdb lookup
  2) allowing specifying the output filename (goes hand in hand with 1)
  3) allow specifying the file to cut using basename (e.g. %FILE% from MythTV)

Would you be interested in me feeding those changes back up to your repo? I'll be aiming to conform to your coding standards.


Andy

On 28 Jan 2012, at 20:05, Edward wrote:

> You describe exactly what I realized after actually reading the docs.  I suppose my mistake was the result of improperly researched, hurried, copy-n-paste, coding.
> 
> Thanks for pointing it out, though!
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/edwardhughes/hdpvrcutter.pl/commit/2da6f572fb0a0397f9bb5835283f572aae9bb1dc#commitcomment-911176
I would love to use `//` but I'm not willing to give up on old Perl versions. I do like print to selected handle on void context though. Expect some amount of this in an 0.03 release (the scalar/list context was already in my head).
Now that I think of it, switch these two clauses. The instanceof check will be cheaper.
Nit: since these aren't getter/setter, why get?  We don't have getCollectionURI, for example.
No problem I really should have checked it before I pushed out a new version.. was just late at night and not paying attention :D
With this change, Sparrow fails to find the file if the sd texture is *not* missing but the hd one is - is this the intention? (My understanding was that sparrow should return the @2x resource if it exists, and fallback to the non-2x resource if not)
Not that it's a big deal, but we've started moving away from this syntax.

As @lithium3141 noted a few months ago, due to the underlying implementation, there are basically no negative implications of doing it like you have right now.

```java
builder.append("], Shares: [").append(this.getShares()).append("]}");
```

would be better in my opinion.
This might be the problem with the 1 sometimes showing. The backend returns a 1 but I'm not sure jQuery will take that as an integer. It might be interpreted as a string and your type safe comparison fails?
tass is GT-S5570, gio is GT-S5660 - Why did you change that?
And widly used in wcf1. So I think it's okay right now ;)
Gah, agreed!
I think I might merge in yjwong's repo's, as using cm's current qcom-opensource leaves my build with missing headers and YouTube FCing.
Also to disable the OLD OMXlibs you just need to remove BOARD_USES_QCOM_LIBS from BoardConfig.mk
why did you remove this commit from your repo?
ich hab noch was hinzugefügt im vorherigen Kommentar:

"nutzt du meinen Kernel oder deinen mit liveOC ? - das soll (und der lazy governor ?!) Probleme mit deep idle verursachen"

gut, dann werde ich das mal wieder auf default setzen und es muss eben per NSTools aktiviert werden,

damit scheint es besser zu gehen - evtl. bekomme ich beim Aktivieren dann auch den schwarzen Bildschirm :/


ja, das ist schon komisch wie unterschiedlich die Geräte jeweils auf Tweaks, etc. reagieren
if you long press the homescreen and click Shortcuts this line will add LiquidControl to this main Shortcut menu (confirmed working)

--I also added the line to PropModder but this is just an experiment to see how the app will handle calling fragments without loading the parent views first. I'm guessing it will fail but I thought it would be worth a shot. (unconfirmed)
@J5 ^^
Either assert() or if.
Since this WKT is so simple, why not just create real WKT for the point? It's pretty trivial: `POINT(%s %s) % (self.x, self.y)`

This way, the fake value isn't so fake :P.
I'm  guessing you did the add/pop/insert routine so it would originally be added using the "public" interface, `add_option_group` .  that makes sense, but you still end up breaking the public interface by doing the pop/insert afterwards.   to be pure I think,  we'd restructure things so we added them in order only using 'add_option_group'.
N/M, I should reed the code comments :Ps
`$is_closed = !$page_owner-> isPublicMembership();`

Just push commits to your branch, no need for new PR.
Dit is cool!
Ideally I think _dirty should not be a bool, but an enum, describing:

clean (host and device agree on data)
only exists on host (not yet uploaded to device)
modified on device (needs fetching to host)
modified on host (needs copying to device)

The last option is because the .data property acts a bit like op_fetch_data in the C api.  Before the first par_loop call, the user owns the data.  After a par_loop call, OP2 owns the data /until/ someone does `x = foo.data`.  Now the data might be modified by the user.  So OP2 needs to re-upload it before the next par_loop that uses it.  This is not the case is `x = foo.data` is not called.

Or is this an optimisation not to worry about right now?

Or indeed, do we want to forbid (in the API) users explicitly writing to Dat.data arrays after the Dat has been instantiated.
We had a ticket about migrating to that but V ended up embedding this one, so I guess there is a reason.
Good point, will add back
I would prefer without `_` to make it less fragile for changes.
 `JMX_CLIENT_CLASSPATH="$AKKA_HOME/lib/akka/akka-kernel*"`
I do that in ClusterCoreDaemon, where it matters, this actor is a short lived actor that only calls that a few times. Performance doesn't motivate it, but I can sure do it if you think it's more dry
Need for symlink to pygments style disappeared with 4cd2693340104d6d0bf5675e620924ab59a8afa9. I'll update the docs accordingly.
How about AES128CounterRNGRandomOrg, AES256CounterRNGRandomOrg and AES128CounterRNGSecureRandom?
why not enqueue the InboundPayload objects directly?
Yes, that should be possible, perhaps that already done, when you mention
it. At least for the cluster aware. The ordinary listen to Terminated, and
can only do so.

/Patrik

7 dec 2012 kl. 13:42 skrev Roland Kuhn <notifications@github.com>:

In akka-cluster/src/main/scala/akka/cluster/ClusterEvent.scala:

> -          // publish later, when convergence
> -          leaderChangedState = Some(Left(x))
> -
> -        case ConvergenceChanged(true) =>
> -          // now it's convergence, publish eventual stashed LeaderChanged event
> -          leaderChangedState match {
> -            case Some(Left(x)) =>
> -              leaderChangedState = Some(Right(x))
> -              publish(x)
> -
> -            case _ => // nothing stashed
> -          }
> -          publish(event)
> -
> -        case MemberUnreachable(m) =>
> +        case UnreachableMember(m) =>
>            publish(event)
>            // notify DeathWatch about unreachable node
>            publish(AddressTerminated(m.address))

then the router should monitor the UnreachableMember messages instead (that
should give the same timely feedback, right?)

--
Reply to this email directly or view it on
GitHub<https://github.com/akka/akka/pull/909/files#r2347834>.
So timestamp and startTime is defined to be in millis? I couldn't see that in the scaladoc for those fields.
Ok, but I should change it in my code (NettyConnector), right?
This should probably be an input or a defined constant in datomic.clj
What would the equivalent to this line be in python?
I can't decide if it's

    from hiccup.page-helpers import link-to

or
    
    import hiccup.page-helpers as page
super always calls EventDispather._set_size, which doesn't exist. Removing it is more likely to **fix** stuff :-)
Use ``np.dot`` or ``A.dot(B)`` for clarity
What warning are we catching here?
Yes that's fair enough docstrings can be a menace when they're wrong or out of date, on the other hand no docstrings is a menace as well, so there's a balance to be struck between too many and too few docstrings and comments. Anyway for `ckan/logic/action` functions the docstrings are used for the [API documentation](http://docs.ckan.org/en/latest/apiv3.html#module-ckan.logic.action.get) so it's important to have good ones.
I'd like to just do a simple import even if I started this trend something like
import ckan.lib.plugins as lib_plugins
Also

    function(param=[]):
        ...

is dangerous because of how python handles lists (the same problem happens with dicts too)

consider

    fn(moo=[]):
        moo.append('stuff')
        print moo
    
    >>>fn()
    ['stuff']
    >>>fn()
    ['stuff','stuff']

do

    fn(moo=None):
        if not moo:
            moo = []

in this case we do it differently in the template  as the none is handled already.  But watch for this as bugs caused like this are hard to track down
yeah, I can certainly add the publish tag as well
Can we remove the modified flag and just put the collection.save in the first if block? It doesn't look like it's adding much.
Should be: "token" -> mr.token.toString
Let's review this code together.
Hmm, this one looks like a change in behaviour.  Now, the change in behaviour is quite possibly correct, though I'm not sure that GetSourcesFromType() is guaranteed to return non-NULL.
Not sure I like this. Please do verify prior to committing a next time.
Fixed on commit 01de23f347eae2bb572f4431f20aba359d14afb1.
whoops, forgot to do commit -a to remove these .py files.
А что такое «ключи Танкера»? Это какой-то специфичный проект в Танкере, который нужно выкачивать всем?

Можно ли сделать так, чтобы обращение к этим ключам происходило не через project='tanker', а нативно, через keyset='i-tanker'?
Она ж заполняется только, если пустая была. Все равно не стоит?
Doesn't look like JSON is used anywhere?
locking table no longer optional if I am reading this correctly.
Test for the new capability
This should be `Controller`, not `Controler`.
No, you're right max, methods should avoid property syntax (now if this were C#...)
We should accept purging specific versions too. We could support something like:

pgvm uninstall --purge X.Y.Z
pgvm uninstall --purge --all
i.e.
```
type <- cut(status, c(0, 200, 300, 400, ..), c("information", "ok", "success", ...)
message <- paste(type, " (", status, ") ", sep = "")
list(type = type, message = message)
```
woops ;) thanks for the tip
Ok, this is private api. Originally I haven't this method.

Target is on `Buffer:New(const char*, size_t)`
@FrenkyNet I am aware.  I was just doing it for consistency in the class.  Not how I would normally do it, but want to be consistent.
One other thing: please prefix the scala.* packages with scala.*, because it's clearer for new readers and that's what the rest of the codebase does.
no need to split, gen_fname will take care of it
Ok.  That wasn't clear from the docs for Py_BuildValue.  It looks like it can also handle NULLs correctly, so all the temporaries can just become arguments, as well.
License and copyright need to match the rest of the library.
Hi Rafael,

Thanks for the quick feedback. If you are referring to the rescue value on line 28, yes, ok I see it is not required. I removed it and all tests still pass. I will submit another patch.THank you. 

anj
Small tweak, switch to URL for 5.5
oh man, this one always gets me :sweat: 

It should be fixed now.
No. I think you understood me wrong. We will accept this pull request but we have to add a documentation note telling the people that `:include_blank => false` will not work when you have a required select, with size one and not multiple. So the users will that are trying to set it to false can read the documentation and know what is the reason for the options not work
I started to comply, but stopped when I realized how little of it made sense. Can you maybe reformulate the comment to have some meaning in the context of the build as it is today? Because a) we never use ant's 'exec' task for anything where max command line length could possibly come up and b) ilasm?
I like the idea of moving this out to its own module. :+1:
We should be calling `order.update!` here so that things like applicable promotions are checked and update.d
I like consistency. Let's face it, evaluate is a bad name for it, but that just shows how important it is to come up with a good naming convention from the start.
Much more idiomatic is `for element in d[::2]`
This could all be ```return other.rank - self.rank```
For the moment I will not change this; the rules for commutation should be more detailed; for instance two tensors
can be non commuting but commuting one with the other, so `commuting=None` is not satisfactory in this case.
For instance Cadabra has this feature.
Still, example files should not be scattered in the source of sympy. There is an "example" folder for these.
moved and changed return to use `_new`
It's unfortunate that you have to write this in explicitly. Ideally the mechanics of Basic would take care of it for you. 

Why is this complication necessary? 

Are there any other functions that need to be written because of this complication?
`Yii::app()->charset` should be passed as a second argument.
Another case of an autoreleased string being assigned to the iVar of a retained property. Retain this value so we do not access a destroyed value. 

This retained property also needs its ivar released in dealloc.
what is the true directory for?
pointSize
Most apps I've worked on expect to be migrated up from scracth (that's what cap deploy:cold does...)

Could this not be fixed in this case by just wrapping the data massaging bit in an `if Lender.any?` type conditional?  This way it will only need a user if there's existing data in the database.
Do not use "here : "
Ditto. I'd like this to be in `config/environment.rb` instead.
Many unused import
I think we need to be careful about using the word "inconsistent," which I think most people read as "corrupt," in the case of databases. 

:dbcommand:`copydb` and :dbcommand:`cloneDatabase` do not produce point-in-time snapshots of the source (origin?) database. Write traffic to the origin (or desitination? check?) during the copy process may in databases with different contents.

Also unless you use the --oplog and --oplog replay operations, mongodump and mongorestore have the same behavior.
can that be a truthy? {% if creating %}
Please spell fall back consistently. There is no dash in it in either case.
Yes, this is something I was not too happy with either, but did it this way for now to get things rolling. Anyway, I have an idea on how to address this. (Patch will be slightly delayed by shower, food & trip to philz.)
Changed it to `Y.namespace('Env.Mojito.Handlebars')`
Should be 'javascript code' instead of 'coffee-script code'
у меня нода по дефолту на 1337 поднялась, не стал менять
I'd propose to throw an exception here, so you cant call this by accident, debugging for hours what goes wrong.

throw new \exception('not implemented, yet');
This line breaks the build. Should be:
`return entityIdentifiers.toArray(new EntityIdentifier[entityIdentifiers.size()]);`
why not `function listener` if you need to reference it from within ?
+here...I know it's just accessing an array with no output. Could I be missing something important? Like how Sencha adds to a store?
We can't have spaces in folder names (we use the folder structure directly as URLs)
if 判断必须要用 {} 包括起来。
If arg is already a gof.Variable, then we should not convert it to a tensor
To fix the rejoining and disappearing too fast problem, we need to do the ZK log thing you mentioned. Even with that fix, we still need to do this change so that the coordinator will send work to the sites that received the participant notices. This is a patch to fix the inconsistent view between the initiator and the coordinator problem, which should cover some common cases.
good catch. Thanks
A lot of the VoltDB patches to HSQL contains comments indicating this is voltdb code. That would be nice on the new construction. Also, at the bottom, a general comment that BELOW HERE LIES VOLTDB would be cool.
AFAICT, this new code is a more readable version of the code that it replaced, but functionally equivalent. Was that the intent?
Perhaps it would make sense to put this in a mixin?
why list?
the default value changed, yet it isn't blizzlike?

Could you also elaborate a bit why you changed the default value from 0 to 1 ?
should have curly braces around if body (always is best - but definitely if body is more than one line)
Good suggestion. Something like: "This should be considered as a last resort solution when it is not possible to import a compatible name from django.utils.py3."
Nevermind... I didn't see that you were grabbing it first then setting on top of the already present options.
Isn't array list the default?
I think this should be changed back to `libc`
Wow, thanks for that bench @gibson042! IE6 is just pitiful, but we knew that. Okay, I think we should go ahead and do this thing. It will be a good file size savings and also in-memory usage will be lower since we won't be creating frag cache entries. There's already a ticket for it at http://bugs.jquery.com/ticket/11989 and we can just pull it forward into 1.9.
My tests show that switching it from "div<div>" to "X<div>" shaves off one gzipped byte.  I tried "c<div>" and even "><div>" and got the same number of bytes as "X<div>".  

And actually I appreciate the reminder to think about gzip results.  Byte count, compressed or uncompressed, isn't much of a priority in my day job, so I often overlook it.  The real reason I wanted to replace "div<div>" is that it makes the first "div" look somehow magical, like it needs to be that particular text, when in fact it can be any character at all.
Yep, by one byte. `"."` is a repeated string; `"c"` is not.
Hm, that's nice.  Is this something we should pull separately for this release?
decimal and numeric are identical.
What I did is that I avoided the dependencies on the first tuple by explicitly passing necessary arguments (e.g., numOfCoefficients) as a separate function parameter of the UDA. I found it cleaner, since following the "Anatomy of an iterative MADlib module" (Start(), Initialize(), ...), we are not supposed to read information from the first tuple for Initialize(), but through arguments instead.
Since sitescan is passed into the `save` method, it seems like `self.sitescan` is redundant and unused?
Yup, that's why I've been waiting on this and was hesitant to submit a pull for sdl_sound.
`remove_from_cflags` should touch CXXFLAGS
Yeah it got less user friendly when I generalized it from just install to any arbitrary operation that might need a lock, been thinking about how to phrase it better.
I'd personally rather prefer something like `this.includes = {pre: [], post: []}`, what do you think?
There are a couple of angles here. 

Firstly, we should be treating our JS as a first class code citizen. Meaning it should have its own unit test running in isolation independent of the pages that the code is used in. 

Flowing on from that, its a slippery slope. “Lets just inline it this once” opens the door to having javascript scatter shotted all over the application.  If we move towards centralising our javascript we then have the option to do a little funky JS compression and concatenation etc. to make sure that we are getting the lightest pages possible.

Secondly for the closure, the idea is to get all the functions out of the global namespace and only expose the parts of your API to the page that it needs. Also, encapsulating your API protects it from external factors (ie. I include a new javascript file ahead of yours thats also a bad JS citizen and refine `ping_interval` to be a function... BOOM).
this is not needed (or wrong ;-) )
I have just updated the coding guidelines with a singleton section, so you should take a look at the current way to do it.
Den default kannst du oben direkt in rex_request() reingeben
Bah.  The verbage is ambiguous even then... because the "dependency" can refer to the relationship or the target of the relationship.  Hrm.
Should use fluid.model.transform.setValue here to take account of any outputPrefix which the user has registered
My original intent was to replace the deprecated `CoreMatchers.is(Class)` matcher. However, there is a much simpler way. I added another commit. Please take another look.
ah, good point, missed that.  fixed.
The projects like maven-surefire pay the attention to have thread-safe listeners. Of course it's not the only one user of JUnit.

We are able to freely optimize implementation unless breaking JUnit Javadoc, then the foreign listeners have to be thread safe. For instance the logger. If they are not thread safe because of Date is not thread safe, they still can use `ThreadLocal`, but these are typical issue which are solved that way.

Using `synchronized` as previous, the listerer's constructor could be broken, which we cannot fix anyway.

So sorry but this is not our fault that user uses `ParallelComputer` and his listener is not thread safe because he did not know. I cannot safe all the world, right? 

Again, I should be able to optimize the framework within the range of internal documentation. I think this is correct thinking.
I like the old version
We're using `@changeEvent()` to memoize the value.

Maybe we can save the memoized value to `@_changeEvent`, then we can do something like:

```coffeescript
iterator(object) for object in (@_changeEvent || @changeEvent()).handlers.slice()
```

Maybe this is what you are suggesting, if so, ignore me. lol :smile:
Triple byte probably.  I will have a look this evening at adding a class to SpoutAPI.

Maybe, I could call it "UniquePriorityBlockingQueue".  I could also add the synchronization stuff so it will block properly.
Again, please give a name to the function and a better name to `flag`.
In that case that would become the same as the one where it `should find all the tag attributes before closing the tag`, right? I'll just remove this one then.
Can you change these variable names to something like ``isLineSelection`` and ``isMultipleLine`` to indicate that they are boolean values?
As NJ mentioned above, I think it would be better to keep all keybinding in the KeyBindingManager. To update the key bindings for a menu item you update it through the KeyBindingManager.
I'm a little confused why MultiRangeInlineEditor uses a more complex formula than this.  It looks like they should both yield the same value to me: the width of the gutter plus the full width of the text.  Is MultiRangeInlineEditor's code just overcomplicated?
I don't think it's that much overhead. Let's just go for it. It worked fine on roastly+conan.
this class should not be there any more, I guess it was added by the merge or something
I think these loops can be gameCollection.AddRange(Game.FromDTO)
Please... no star imports...
useless cast again. Same below.
That's an error message in the UI : shouldn't we use I18N here ?
I think this div shouldn't close here...
Why remove `encoding`?
Completely remove `DATABASES` variable.
We could use just
```erlang
[Val] = UniqueValuesList,
```
yep, retains units
These used to be properly camel-cased. Can you make them like that again for conformity's sake?
Actually, this file can just get deleted.
Added some notes on `virtualenv` - if GitHub sorts itself out, that may become self-evident.
I removed the comments
I've been preferring the new stabby lambda `subject.not_if = -> { true }`
Given steps simply declare state, so they are passive-voice.  This would be something like:
`And I am viewing the database's page`
Wouldn't that install into /usr/local/etc ?
Hmmm, good idea!

I'm working on adding some tab completion for tags next, since they are now just a list.
Same comment here as I wrote in CategoryVideosFeed.
This breaks when you input gibberish. Change to redirect_to root_path.
Why not include "/repos"?
No, because katello is installed in disconnected mode, but not configured or even started. Katello.yml is empty, besides default cdn url is not there AFAIK.
@daviddavis - Can you be more specific in thinking of ways to reduce it? This is how Aeolus Conductor does it and this was the suggestion from the engineer who worked on the login area for Alchemy and Conductor.  I'm willing to change it of course, but this is a simple fix for failed automations, not a refactor.
Does this only get called once?
bb10538ddd8ae20696613f2d7e3fd8308d5e1886
That would be helpful, I'm not entirely sure how to set this up...
The issue with this is that this *should* fail if we are not importing at build time. In other sub-packages, we use a global variable ``_ASTROPY_SETUP_``, see e.g https://github.com/astropy/astropy/blob/master/astropy/wcs/__init__.py#L24
yes, as parent::wait is void
Move this under internal.
Not sure why this line is being changed....
Fair enough, though that probably also means you need to decrease your timeouts (also, maybe we should put those pong messages to good use...).
In any case, I would say throw that block at the end of ProcessMessage so that a. it cleans up the diff (no new if statements, and the if/elses become one block again b. as you point out, let the if "version" block complete before running this block.  Finally, make sure you have exchanged version messages with the target node before asking for blocks, and then Id say this looks good to me.
Right, thanks for noticing
You could try. It's good to make event listeners as local as possible, but I don't know if it would work.
This BIP30 test has to happen before any transactions are connected. It is not allowed to create a new transaction whose last output is spent within the same block.
C++11 allows you to specify the underlying type so you should be able to make it unsigned that way.
Why does this need to be here and doesn't it run for every request?
this should be renamed to ``getDocComment``
Will duck-type :)
Well the way you have written it.. 
can [:like, :unlike], Comment, :discussion => { :id => user.discussion_ids }
"I can like a comment, if the comment is in one of my discussions."

To me .. that seems to miss the point.. and depend on behaviour that might change. What If down the track we say that user.discussions only includes discussions that you have participated in?  I think we want to explicity define permission around what groups you belong to, and what permissions the group has around who can participate. 

so:
I can like a comment if the group is open to everyone, or I am a member of the group of the comment.

Is how I would prefer.. but you are welcome to see how it goes. Just discussing :)
Which happens after the permissions check.
I think there is one line missing here:

    $this->$name = $collection;
Why is this public? It looks like it's only used inside this class... can you make it a private field, instead?
Hmm, well, right now a few games crash PPSSPP for me, because "secs" is so high right now that localtime returns NULL.  Probably needs more guards.

1: Sure, but how?  The algorithm I suggested would only cause the number to be smaller, and you're saying it's still too big?

2: I've tested it, the PSP returns the same tick resolution.

3: Yep, that one sounds good.

-[Unknown]
Is this somehow better than  `line = doc.lstrip().splitlines()[0]` ?
This has nothing to do with the -j option, I just found out the docs differ from the implementation here. This is updated to match the implementation.
its a bit faster then `{}` as I understand it
This method should take care of it.

on line : 120 : laravel/database/schema/grammars/mysql.php

protected function length(Table $table, Fluent $column)
	{
		return ($column->length) ? $column->length : 10;
	}
Yuuuup!
Specially here. Why store the error if you're overwritting the message?
How about introducing a  new error code and turning this test into 

```c
cl_assert_equal_i(GIT_EUNMERGED, git_reset(repo, target, GIT_RESET_SOFT));
```

/cc @arrbee
Logically it should live in something like defaults.konf, but the way defaults.konf is templated and evaluated (as part of konf evaluation) makes it weird to  put API config in it. 

It makes the API bits substantially less self-contained as they need to peek in to Mobify.conf.data at conf evaluation time to get their parameters, as opposed to this, where the parameter is exposed and set imperatively here.

I've only named it ".konf" because that's the file extension we use for dusty javascript.
ah yes! will fix all the strings below.
oh, does this mean we were still using sphinx for this part?
good point.  thanks.  fixed.
I love having all the keys there but it's prone to accidental typos. Why not make it a long tuple of *either* string or a tuple. Tuples only when there's a mapping to be done (e.g. startedDateTIme->started_datetime)
匿名方法没必要加空格吧？至少要和node源代码一致啊。
They appeared twice in the array.