labofsahil/github-event-dataset-2012 huggingface dataset:
Would these be better described in [Text Editors 101](http://www.opsschool.org/en/latest/text_editing_101.html) or even [Text Editors 201](http://www.opsschool.org/en/latest/text_editing_201.html) - where they are already mentioned?? 
It seems like a link might be a good idea, but covering the editors over there makes more sense.
Even better would be is if it got this configuration out of `application.conf`, so the user can configure it according to the agents they are expecting, and disable it entirely if necessary.  The default config can go in `resources.conf`.
You could have a reject with no argument. 
e.g. defer.reject(null); or something along those lines
More indent issues. Make sure you have your IDE set up to always uses spaces instead of tabs.
sorry, was my fault. its done: https://github.com/symfony/symfony-docs/pull/1524
wrong FQCN
this code require ```util``` 2 times.  ```require('../util')``` and ```require('util')```.
they are misleading.
```require('util')``` is only used once.
so i write this.
Only running its own client tests by testacular itself is the only e2e test (on your master).

Latest master already runs the stuff in `test/e2e/*` on Travis:
http://travis-ci.org/#!/vojtajina/testacular

We might add e2e test for proxying, just starting static nodejs serve and loading some js file through proxy.
Wouldn't it be possible to drop "blocking" and just check if replyTimeout is > 0?
i could but i wanted to be as clear as i can about what i'm doing because it raises some concerns (as what else we could potentially ignore false-positively). feel free to refactor or if we can reach a better design i could update the pr also.
I wouldn't credit those Code52 guys, they're all jerks! ;)
I decided to use iteration instead of plucking one item out, then counting the items, then grabbing the first non "links" item because iterating them would be slightly faster.

Fair point on not using ".keys()."
NGHUTPR but i would suggest having the name of a method that checks something or only returns True/False to `_is_valid()`. This is something i recall java standards using and not sure if there is anything similar in python.

I'd like to hear what the others think about this.
a branch will always be specified with the route change ([#L0L48](https://github.com/klaussilveira/gitlist/pull/224/files#L0L48)). if the specifed branch is incorrect no affect the results that are returned as empty, however some implementation to check existing names of brach could be required to avoid future errors.
better :]
This sentence is confusing. How about:

> The number of deltas of the given type that are contained in the diff.
It's OK now, but it wasn't when I added my line note.  It was fixed in https://github.com/endolith/matplotlib/commit/e1b17ec1dab7e3fe4eb2b6a44897499e5f0d80b2#diff-7.  I do think it better to explicitly import cm rather than use it from pyplot though, because it will educate users where they should go to look at the module docs and code
So the original problem with your first PR was that, if a user wants to setup a figure using a backend that isn't the one in ```rcParams['backend']``` they will have instantiated two different canvases:

For example, suppose my ```rcParams['backend']``` was ```TkAgg``` and I wanted to create a PDF canvas for my figure, I would have to create the figure instance (which creates a TkAgg canvas instance) before I can tell it to use my own PDFCanvas instance.

I don't use the OO interface all too much (pyplot is fine for me - I use the helpers it gives me and I don't rely on the state machine too much), so I might be completely off the mark with these comments. Please tell me so in no uncertain terms :wink: .

Cheers,
I would probably get all the colormaps with: 
```
import matplotlib.cm as cm
print cm.cmap_d.keys()
```

But having a pyplot function which returns a list of cmap names sounds sensible.
yes, that's right, using axes was [suggested by @pelson here](https://github.com/matplotlib/matplotlib/pull/1462#discussion-diff-2067358). Though now that this is back against master, I will just change this to the new plt.subplot()
Seems like maybe we want this error output to come after the type assertion, since there a many cases other than "nil" which will cause key to be invalid. You can use the "key, ok := msg.Fields["name"].(string)" spelling to explicitly check if the type assertion is valid, preventing a panic which will happen if you don't check the second return value.
Same as above - small cleanup, do this before merging
Ah, it's defined in the Interface, alright.
You take a "request" parameter here, and you shouldn't. Can you remove it and resubmit?
Instead of using images in here, can we use CSS3 gradients and rounded borders?
please don't forget the \n at the end of the error msg
Ahoj, souhlasím, předělám.
You are using the selector here but you have `codeMirrorScrollArea` available.
I'm not sure how resetting the experiment plays into this...? Where is default enabled set? Or will it be returning true because the db entry is nil?
Are you sure ``$class`` has the correct type as ``*`` is not a sub-type of ``string``? Please also check line 101.
Done as suggested
Das ist der automatisch generierte hashcode...
sure, refactored in : 612fab8
Looks like this conditional piece can be taken out, the `!name` check is done in the next line with `nameOk` above
http://munin-monitoring.org/wiki/graph_period

Munin default is 'second'.

The reason I run into this problem is because the current behavior is non-default.
Is it possible to just do this:

    var keys = [];
    for (key in options) {
        keys.push(key);
    }
    expect(keys).toEqual(["where", "onSuccess", "onError"]);

?  Anyway, regardless, the changes look good!
You can just re-use originalDefaultEngine from above.
`(not (empty? ...))` olisi parempi mahdollisesti kalliin `count`:n sijaan.
Gotcha. I'll get that taken care of and pushed back.
Why is JDatabase::getDateFormat() used here? We're not storing anything in the database.
Shouldn't this be removed instead?
We shouldn't require that people using mc (including our future selves) set `STATIC_URL` to a full HTTP path just so that this template works. It's too strange of a requirement.
the problem is that I fixed typo on my version when I was refacotring to ass the message class !
I will close the pull
I think private since we're trying to emulate an enum more or less.
Is it really a good idea to not explicitly match XSL files inside `utilities` and `pages`? What if I'd like to offer XSL template for download on my site that are in a `downloads` folder? That would be restricted with this change, wouldn't it?
Maybe we should always everywhere name it `columns_count`?
I think `verbosity` is already int. Do `> 1`. `1` is default (and should be silent in our case, probably).
Aaa. Why they and you don't tell this sooner?
How can I do that? Should I read DEBUG value in settings.py and wrapped panels.panels_pool.register(DummyPanel4) with if statement?
Aha, this is the test of what it happens if it is invalid form. :-) So it tries to find template to display error with. :-)

Hm, maybe we should not require the field. Then it will work? Because in some way, we could say that not providing the field is disabling it. And empty string is probably the same as not providing it.
Rename `option` to `layer`. You iterate over layers, so each element is a layer, no? Or rename `map_layers` to `map_layers_options`.
`.on` is currently recommended.
String? Static?
This is not good. You should never ever just ignore the exception just so. What then in production? Here should at least be some `if debug` around or something.
Do `arith` and `compare` need to be different functions? Maybe they could be combined into a single `operator` function.
Don't think this is necessary.
DrawRect.Top and DrawRect.Bottom cannot be correct.
Please check or argue.
Is this necessary, since the module.config.php specifies an alias already?
I would strip this empty line. :)
Thanks.
remove hungarian notation

and add _useLOS(useLOS) to constructor
What He's asking is, are you sure that this target type only affects the vehicle seat 0 of the vehicle?
Since this is pet specific, wouldn't it be better to put this in Pet class?
Sorry, I followed existing naming convention.
Sorry about this diff, just realignment. The only change is the addtion of line 28.
ich glaube das sollte zuerst geschehen, bevor du neue daten lädst.
Let's use a stupid example with `sha1` or something like that then...
"scale picker": "Escala",
Why making it private?
I don't think you want the permissions in here. I think that's what was generating all of those tar messages during deploys when we first started
Again, no clue what this `uri` is for.
luckily we're not prone to superlatives ;)
Some of the other Create* APIS return an AsyncResult. Should they all (including this one?)
You replaced github**.**com with github**->**com :)
Yes. It was an early prototype of Resource tree.
Not sure if I should keep it or remove it.
Actually, this is already piped through to filename_prefix()
This seems unnessary.
Let's hope you didn't use that for your email account, lovestory8976@yahoo.com
Fine. I'm not going to argue this point.
I also dropped the threshold for the gamma approximation from 0.05 to 0.01 and added a comment about its accuracy (now 1.e-7).
I'm kinda on the fence on this. A default Nexus installation pretty much works out of the box. I can't really think of any "need to create" repositories that would be a sensible default.
If project is an actual project, then don't use Project.find

If project is a project_id then name it project_id
at debug -- done
no significant changes in this section-- swapping the order of grow-check / shrink-check will never matter.
the stable calculation is slightly better, if we're growing we don't care if we're stable for shrinking, and vice-versa.
and it makes more sense split up like this (at least to me!)
When/why will the entity ever be null? Can we just do `this.enitty = checkNotNull(entity, "entity")`, and fix where null is being passed in?
A better comment would be to not just repeat what `assertThat` does, but to say something like `// Check list of entity types includes one of the defaults`
Should that really be `.isa`? Isn't `OS.class_NSTableView` already declared as `Class`
Can't these be protected?
This is just a convention I've used on the other gems and seen in lots of other places. No strong reason not to use instance_eval
Forget this one ;)
The bang will raise an exception. The correct form to use with `if` is the plain `save`.

```
if @user.save
  ...
```
Thanks. I'll modify to follow original SourceNode behavior.
If these files are now included from `index.html`, they don't need to be injected here anymore.
Unless the cause is known why we get no exception here but do at line 72, seems like this line should also include `to_i`. WDYT?
Esta errado comentei no momento de instabilidade na Rede, vou corrigir.
Definitely want to share this logic w/ PlaylistModel as well. Stuff like .e. g WebResultHintChecker::checkQuery() should only happen in 1 place to minimize future issues.
What does it mean for a view to be read-only, separate from a model being read-only? In what cases would a model be non-read-only but a view would be read-only? Imho this seems to be adding complexity to what's already a pretty complex relation---a view should simply be a view on a model, if a model is read-only, the view should be as well. How would an edit on a non-read-only-view, but read-only model, ever work?
These two icons don't seem to do anything at the moment. What was the thought behind these?
you should use the Process component instead which includes workaround for Windows bugs for instance
What is this directory?
Extra space at the end of this line
Also make sure to keep the project spacing consistent: here it's 4 spaces.
If not present, logback will create the directory "/var/log/rudder/compliance" if not present ( this is the same for the other directories concernend by logfiles generated by logback)
https://github.com/PhoenixPilot/PhoenixPilot/pull/56
Можно сразу задекларировать значение
```javascript
var title = getRandomElement(activities),
    location = getRandomElement(locations);
```
James, I just now saw your recent posts, checking that the response is success might be good enough actually.

Whatever solution you come up with, I think it needs to fail if the code being tested is commented out.
Меня терзают смутные сомнения, что synchronizedMap может привести к деградации производительности
Стоит ли заменять на ConcurrentHashMap?
Array.clear is not const method because Array.clear mutates itself.
ok, i can fix this easily, but no sooner than saturday
you should use ``null === $meta``
Indeed I must have been blind...
> @GaelVaroquaux See 40745ce. More like it?

Yes that's great. You could even combine with Alex's suggestion by hint
at the web page:

...the narrative documentation, :ref:`svm_kernels`, that can be accessed on
the web page.
I moved it to the API section below and also added qda and lda there.  How are you viewing the diffs?
Does not raise any warning or exception with for example``-2``.
True. Will change that later.
немного кривые докблоки
You can probably get rid of this line as well.
From the recent my experience, we should remove `#line 1`. It makes a line number mismatching between error messages and actual code.
To remove confusion, please rename to get_blackberry_ndk
Changed to throw exception
Are these TiXxxObject classes representing the modules?  should we be naming them TiXxxProxy ?  To try to be consistent with their naming scheme?  I'm not sure about this just asking.
What's the intent for this interface? I don't see it referenced anywhere currently and I would expect users to extend one of the two concrete classes provided. Even if one implemented this interface from scratch, what value does it provide over simply implementing ViewResovler?
It's a dummy, required to suppress an assert somewhere but never used as a port number, IIRC
It'll set "rete", so actions won't run, even if it's active.

Not sure this is the best approach, but it works for a long time. ;)
nope, and I only saw that when writing my comment... ;)
Is title used anywhere? Seems it always gets None.
I think this should be in settings/base.py
It's NOT expected that you'll change this. And if we need to append something like "Firefox OS" one day we don't need to send out an alert. 
And the few who do can then use their local.py.

local.py mustn't grow too big.
Hmm... Django (unlike socorro) already has tools to handle timezoned dates. I suggest you look into that first.
certainly seems fine to me
Удалять всё ненужное >:-}
I can't remember.

We went through a few iterations with the unsupported content stuff before we got one that worked right. Issues I remember:

* Multiple loadFinished signals
* No loadFinished signals
* loadFinished signal with a `false` parameter (meaning that it failed)

I don't think there were any race conditions here, so I think you just need to get the tests passing. The commit log may know more.
c# wraps
Does Django blow up with this and Mongo? Can the SQL version not have this anymore?
Thanks for the feedback.

I will implement a utility method to contain the || but it will still be the same number of them.
Talk to rafael, he doesn't like us to use xpath.
@shacker ok, np
@shacker We do need it, otherwise it will be handled by the Angular routeprovider and end up in the `otherwise` method which will result in the 404 page.
The ExitCodeException dies in the class LinuxContainerExecutor. 
I see only IOException. 
I can check message like 
Assert.assertEquals(e.getMessage(), "Linux container executor not configured properly (error=2)"); 
only

Gorshkov Aleksey
IBM Certified
programmer 
Grid Dynamics
 +7 952 203 9796
Skype:aleksgorpsk
www.griddynamics.com
email: agorshkov@griddynamics.com

On 24.10.2012, at 15:27, dennisyv <notifications@github.com> wrote:

> In hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLinuxContainerExecutorExtention.java:
> 
> > +	  executer.init();
> > +	  File tmpFile=new File("--checksetup");
> > +	  List<String> commandLine=FileUtils.readLines(tmpFile);
> > +	  Assert.assertEquals(commandLine.size(), 1);
> > +	  Assert.assertEquals(commandLine.get(0), "--checksetup");
> > +	
> > +  }
> > +
> > +  @Test(expected = IOException.class)
> > +  public void testInitException() throws Exception {
> > +	  Configuration config= new Configuration();
> > +	  config.set("yarn.nodemanager.linux-container-executor.path", "/bin/sh");
> > +	  LinuxContainerExecutor executer= new LinuxContainerExecutor();
> > +	  executer.setConf(config);
> > +	  executer.init();
> > +	// should be born IOException !  
> may be we need to check which exception exactly we receive ?
> for example check that IOException's cause is ExitCodeException and it's exitCode equals to smth
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Just näin.
Please use an instance variable that correctly reflects the method. So this would be better:

    @bitmask_definitions ||= {}
For Debug only : don't forget (me) to remove that comment before merge ;)
@derekhiggins yep, I would prefer start. Also, would you mind submitted a test?
This is an instance level variable also. It is filled during the authentication process.
ok i will
unsigned or signed integers respectively.
Still a bit confusing.  What happens if they're not?
So annoying to have to use ndimage to rotate an image :)
2-D, 5-D
Maybe `display` could be renamed `composite_image` or something similar. (I know: the naming is taken directly from my suggestion, so I'm at fault here :)
And also, same suggestions for `_warp.py`.
Isn't each layer (roughly-speaking) the information lost during subsampling?
Where exactly, copied straight from dinnerbone's version himself.
Okay, I'll change Clock to take an object literal and generate other defaults off of that.
Looks like this will cause a failure in startTest() based on the fact that `currentSuite`/`currentTest` will be `undefined`. May want to return some type of static `responseData` when no test is available indicating an automatic failure, and a standardized message for why (`NO_TEST` or some similar token).
I don't think this will match all the possible URLs. Check out this http://mathiasbynens.be/demo/url-regex
Typo "where where"
For example, this should be:

```ruby
resource = file "/etc/profile.d/#{environment_name}.sh" do
  action :nothing
end

resource.run_action(:delete)
new_resource.updated_by_last_action(true) if resource.updated_by_last_action?
```
Ok, good idea.
The commas after the last elements in hashes are going to be an issue.
Yes, definitely! A README and a Maven site.
ой это случайно вышло. а где ниже?
я бы кнопки назвал Button, а табы Tab, и вместо объединений этих двух сущностей сделал бы их настолько маленькими, что не хочется на них сэкономить
Ditto here and below.
Please keep documentation lines within 80 characters. We have a soft limit of 80 characters and a hard limit of 120 characters for the code, but it's been requested before that the documentation be kept within 80 lines for the few folks who (oddly IMHO) use terminals or editors set to 80 characters, and documentation doesn't generally benefit from being longer like the code can. Not to mention, this line is well beyond 120 characters anyway.
would it be too weird to write:

    new ScriptElement()..text = "$sb"..type = "application/dart"

or perhaps:

    new ScriptElement()..(text = "$sb")..(type = "application/dart")

I think it looks great as is, just doing a thought experiment here about cascade style
That 0 is a requestCode, and is passed to the handler to differentiate between multiple activities that were started with startActivityForResult. It just has to be >= 0, and since we only have one case, I just used 0. It can be made a constant, something like ACTIVITY_SETUP_MANUAL.
What do you mean? Those are just a comment explaining what happens to get to this point in the code. Maybe the comment isn't so clear? I can remove it.
no relative path needed here?
Check if there is CI_Driver_Library OR {prefix}Driver_Library
nice catch; thx
same issue here for the class name
Why the scope openning ?
I think `displayed()` condition could be rather called `isDisplayed()`

It reads better, fluently.
Can refactor.
this restrict it to the ORM as you are using the old Symfony interface instead of the new Doctrine interface used in all Doctrine bundles in 2.1
Скобки лишние.
not too much is quiet about this code, it's actually quite loud.

The next PR will have it organized refactored and better documented. This is a minimalistic approach to accomplishing the goal.
If the build includes tools to do feature selection/query (SelectFeature, WMSGetFeatureInfo) then I wonder if we should also add Popup.
I believe we decided that any new CSS should be written in non-compressed format. Please re-format the CSS affected by this pull request to conform to the style guide. Thanks!
The class was completelly rewritten by me, it take my changes once they'll be available at master.
@andralex wait, what? Why?
They way they deal with this in C (where there's no type inference) is by adding typedefs a la sigset_t etc. We should also define those names as aliases and use them in the definition of the properties. @deadalnix I also think using auto here does more harm than good. Thanks!
Feature not part of this branch. Please wait for <code>ign_log_write</code> which brings support for this.
Maybe you can add some JavaDoc here
need a space between the closing single quote and the word "must"
OK; I give in :-)
Please follow indent standards.
"filter" is the default table? Is there any harm in being explicit and specyfing "--table filter" in each filter rule?
If your book was recommending that syntax then it's old book and I really wouldn't use it to learn Perl. I would use good tutorial like http://perl-begin.org/tutorials/modern-perl/ or http://perl-begin.org/tutorials/perl-for-newbies/.
Is it? I used the spelling under https://www.openmicroscopy.org/site/products/omero
Yes, you are right, but $current should be >= 0, so the fix is somewhat different. $previousLine will, as far as I can see, always be greater than or equal to zero, so I removed that constraint.
I'll open a new pull request for the fix.
blocksize or timeinterval can also be a property used with eventsource. I haven't gotten to the point of switching over to lots of satellites using the cesium viewer and changing the czml to include external links for all the interactive things in it like access.  This is a good starting point and doesn't introduce things that might change as we work to this goal.
不要用$_GET。参数用required_param()获取
Why would the ip address be required and localhost not work? i dont think this would work for my environment currently.
The django way is similar:
https://github.com/django/django/blob/master/django/views/generic/base.py#L155


but to be honest.. its too similar -except the view-name suport- to have an identical APIView Redirect... Would be better to make the django implementation support view-name redirection.. not sure about this anymore

( additionally i would have no idea where to put this documentation.. it doesn't fit into views.md and not really in generic_views.md as well.. it would be better to move the code to mixins.py and have it mixin style.. but well. somehow this all does not satisfy me. 
One alternative: Using Djangos RedirectView and having an ViewNameRedirectMixin -as long as django does not support view names-)

your opinion?
If this only returns the location of the icon, can you name the method accordingly?
Maybe this should say all ESP driven email communication.
I don't see any test associated/added inside this pull request. Was is an old test ? Or did you forget to push something ?
I understand that but responsive sites are general very modern sites and very modern sites generally don't work without javascript because working without javascript means writing a modern site twice or being stuck with a server that can execute the same logic. Same goes for the term but even more so.
should add newline here
click is not triggered when clicking the scrollbar. We'll need to use mousedown
very small thing, but only to reduce lines of code, and improve readability, declare notification here along with the initialization and not above
See 054c94a4
Cool.  I think I like this better for this iOS side too!  (I was using a regex to do the initial parsing.)
you're right, that's useless. removed.
@ptn please drop these tables from your development database. They keep cropping up in your pull requests and I have to manually delete them every time :wink2:

Just run this code in `script/rails dbconsole`

```sql
DROP TABLE projects; DROP TABLE learning_materials;
```
I like how in @erikj54 's version we removed the handler once we had createdWebworksReady. Can we do the same, it seems cleaner to me.
Regex is (local:\/\/)(.+)(\.js).  Group 2 will give you the name.
equals should call compareTo rather than reimplementing the comparison logic
If it's not being used, feel free to remove it.