labofsahil/github-event-dataset-2012 huggingface dataset:
I guessed the link was to let Sphinx know about the Akka documentation style, but maybe it's not even necessary. Do you have an Akka style defined in your system pygments style directory? Maybe now it picks it up from the local akka-docs pygments directory.

Certainly the old link is wrong since the _themes_ directory doesn't seem to exist anymore.

I'll remove my link and see if the docs still build. If they do then we can probably get rid of that line altogether.
that's a looong line
Right, but it has to happen by the point we load this file now.
Probably, but I also likely fixed it downstream.  I did lots more of this same transition in the account_cards branch.  That just keeps moving this same transformation deeper into the code.  There were many places where we still referred to 'user' :user, etc.
Used `System::mkdir` helper method instead PHP `mkdir()`
This comment is confusing saying add something that is already added seems odd.
Thank you, I fixed that!
I prefer that we have the option to specify the Switchboard and not only the number of executor. Cluster should not know about switchborad internals.
Yes it is ! :)
me parece bien esto .... !!!!!!!!!!
Ok looks good.
The endpoint is expecting `candy` to be a string here, so this request should respond with a type mismatch.
The `else` should be in a new line.
removed it for now
Use net_kernel:connect_node/1 instead?
maybe use Preconditions.checkArgument to specify the length must be 240
see above... it should not be necessary to assign to `string_buff` after calling `assign()`
That said like 90% of this is CoreGraphics.
All of these methods need documentation and prefixing.
@bnoordhuis such example do also exist.
two thoughts. 

1. the only reason we have ordereddict is because configparser uses it in 2.7. therefore in 2.6 we don't have this awkwardness. that's why i suggested the change above. what do you think?

2. regarding your changes could you please send a pull-request to my branch. i can include those in.
Will this copy the whole slice of the array to the temp buffer? It seems that if so it would not be in-place.  Also this won't shuffle individual items in the dimensions of the array, only the outer array, is this intended?
I hadn't understood why this was true before, but now I do. I've changed it the specialized functions to do the entire loop.
нужно фигурные скобки
please put a space after the `>=`
we have a `#` in the middle of the line
Drop the parens on your local branch, amend your commit, and force push it up :)
typo: `migrator`
Sure, I wasn't suggesting putting it inside the addDerivedTrees but inside rewrappingWrapperTrees should be fine?
The exact same as 2 lines above.
do you mean `g_min, sdm_ecart_min = ...` (select according to the min ecart value) and then `if sdm_ecart_min > sdm_ecart(h)...`
. -> , but two different composition.
I think you got the indentation wrong. You can't change that `if` block in the way you suggest without changing the logic.
@asmeurer, I think I have done it. As an added bonus, this also solves issue 1739.
@rlamy , @asmeurer , do you think this is a good idea to allow this sort of solving-match or should it fail (as per outdated diff -- I'll paste the link in a second)? I could go either way. I could even be persuaded that the match with a number should fail unless it is a perfect power. And with the `x**r` matching with `y**2`, maybe the 2 should be taken literally. Maybe the only thing that should be able to match is p with 3 or 1/3 and p**e with x**e.
Should this be new s3 method for scales? Maybe `scale_info` which would return a list: major, minor and labels?
I don't think `#include "asprintf.cc"` should be conditional; I think it's better to leave its conditions inside that file.
Aha!  What about `{foo}`, then?  (Chunks can only possibly be filtered from the inside out, so I don't think the order can be ambiguous.)
I guess that the use of `insert_new` versus `insert` is to protect against overwriting a value when there are multiple values for a single moment.  However, `folsom_utils:now_epoch` uses `erlang:now` which guarantees unique values.  I wonder, in general, about the use of `now` versus `os:timestamp` but that is tangental to this PR.

In practice, I'm not sure the use of `insert_new` + `now` hurts anything and I suppose it future-proofs the function for the future if something like `os:timestamp` were to be used.  I just wanted to point this out.  I don't think there is any action to take.
The file don't look as good as before, but those constans where needed, and giving Notices.
Well, that should be a writing on the wall. The contents of this field probably get corrupted somewhere.
We also support MinGW - if that works with automake I'd be fine with it. Otherwise we'll have to keep the old makefile for mingw.
Maybe child_question would make more sense than first_call

Add to the top of file : <% child_question ||= false %>

if first_call becomes unless child_question
It seems weird to me that "rules" is a String.  It should be a proper Java type and the serialization should be handled here rather than requiring the person who passes it in to know how it should be serialized
Sorry, I thought it would be rhetorical: 

     "This will return the documents that are 10 around point [0,0]" 

The units isn't clear. "around" only evokes "radius" in the vaguest sense. I think the better formulation is: 

    "The above operation returns all documents with coordinates that fall within a 10 unit radius of the point `[0,0]`."
``distanceMultiplier`` option to the :dbcommand:`geoSearch`

(or geoNear?)
The EventArgs again should be NS... but also it is lower case in this case.
What is project_type?  Where is it used?
Work around this - you should not be using globals for 3.1.
@var missing here also.
Camel caps.

>>
>>    <div class="indent">
>>        <p><code>$current_user</code> is right, but <code>$currentuser</code> and <code> $currentUser</code> are not.</p>
>>    </div>
>> +
>> +    <p>In JavaScript, variable names should use camel caps:</p>
>
> CamelCaps or CamelCase?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/phpbb/phpbb3/pull/779/files#r773634
I forgot about this… I agree with brunoais now, could this be replaced with some padding on one of the paragraphs?
As the finder has its own tests, there should be no need to test it here. So all of this should either happen with a mock finder or better yet, with a separate provider as is down for other things like cron, which can easily be mocked which takes care of any interaction with the finder in its implementation.
Use commas: "location, name, and URL, which are displayed in the viewonline list"
if ($files_added)
INCLUDEJS appends the <script> tag to the end but this code must come before assets/javascript/plupload.js
It's so based on the other files, I don't want to mess with the 'copyright' claims..... we need to revamp all the lua bindings, we should address these issues then imo.
I can't figure out the magic invocation to require misc.lua into server.lua.
I see...我看看，然后做改进。
What's the -aEN for?   Need it be an option eventually?
забыли ";" в конце строки
Other edge cases: 
- should work with leading whitespace
- should return an empty string in case of a number
I agree closures are useful. They're critical for certain things. As a general case I'd still prefer to organize our code for maximum testing tho. As a framework rather than a single vertical I think erring on the side of testing, instrumentation, etc. is in our long-term best interest.
One thing that has always been a problem is `path = require('path');`.  In this case, it's really hard to use `path` as, say, the path of something.  So it's just a matter of namespacing -- somehow having the libraries available but not having them chew up useful variable names.
Point is that means something's gone wrong...
DatabaseCache
should be mike
bad wrapping
Comment change:
 * "... metadata to ```add``` a ..."
Will do the original action.
However I can't propose said clarification as I believe it's a mistake to deviate from the global standard.
As it stands, the global community can follow the global standard and still comply with our docs.
If them time comes to start asking contributors from the global community to apply to our extra convention
I'll raise this again as inappropriate (we wouldn't want to annoy global contributors with requests for "silly" changes).
@mrocklin thanks for posting the timings. In light of them, I agree with @delallea -- the init to 0 is more Theano-friendly. NaN is another option, but it will cause DebugMode to complain by default, and I suspect it might be slower to write a 4-byte value to a buffer than a 1 byte value.  In C code it is usually faster to re-use previously allocated memory, but in Python code the extra instruction overhead can eat into that advantage.  If you want to experiment with this, you can check to see if out[1][1] already has a suitable buffer, and just write 0 to it instead of allocating a new buffer.
It's not ndim, but rather ndmin which will extend the shape with ones if necessary to match the required minimum of dimensions.

This might be overthinking, but I though it would fit the allow_downcast meaning.
Weird thing at the end of that line.
Why this method returns true every time ?
string interpolation "%s" isn't needed

also get_full_address() should be a method call as I wouldn't expect it to be a property
ah yes. cause I updated the code based on previous feedback, dont know how
I missed it. I will update that asap.

On Mon, Sep 3, 2012 at 3:18 PM, Marc Tamlyn <notifications@github.com>wrote:

> In django/core/management/commands/runserver.py:
>
> > @@ -1,4 +1,6 @@
> >  from optparse import make_option
> > +from datetime import datetime
> > +from time import strftime
>
> This is an unused import - strftime is a method of the datetime instance
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/django/django/pull/236/files#r1518689>.
>
>
Can we get rid of the redundant local variables here? ("function").
It gave me a parse error at (=>) at very big and very small precedences both. It's about "=>" precendence I think if I didn't do something wrong
If you don't need the `Procedure?` primitive, I think it should be removed. The fact that procedure symbols are internally different from other symbols is an implementation artifact I'd like to eventually remove.
Hmmm... could be. That would solve the abort problem more elegantly for sure.
My concern was that I thought all of the issues I've had so far with this patch (issues on my side) led me to believe that it wasn'tt possible for this if branch to be taken in the past (so all tests would still pass, but only because the patch was essentially a no-op). I just want to make sure that the branch can, and is taken when we expect it to be. I'll go ahead and check myself, so don't worry about it.
Then catch what? All the domain errors was checked to return NaN in your code? What else exceptions will throw? Only overflow. But overflow only happens on border conditions in which we must handle ourselves. If we can't handle these border conditions I think it will be a bug.
Florian,

RENAME schema / ALTER EXTENSION SET SCHEMA changes object-schema relationship correctly, but doesn't change procedure source.  For example, logregr is implemented as plpgsql with this source.

```sql
            SELECT
                MADLIB_SCHEMA.$sql$ || fnName || $sql$(_madlib_state) AS result
                FROM _madlib_iterative_alg
                WHERE _madlib_iteration = $sql$ || theIteration || $sql$
            ) subq
```

And invoking this after moving schema fails because the this part points to the old schema name.  The right answer to support relocatable is to remove schema qualifier from everywhere, which seems difficult at the moment.
Huh. Ok. I learn something nwe all the time. I won't nix them in the future then.
As I understand it, the template doesn't change--this is done in JavaScript in the web-page that results from the template. Does that sound right? If so, then this comment should get fixed.
indents are 2sp, not 3.
What's up with this? Just curious.
It didn't work a month ago, it seems to work now.
On Aug 23, 2012 1:35 PM, "Jack Nagel" <notifications@github.com> wrote:

> In Library/Formula/suite-sparse.rb:
>
> > @@ -1,37 +1,34 @@
> >  require 'formula'
> >
> > +def metis?
> > +  build.include? 'with-metis'
> > +end
> > +
>
> Will this even work? build is defined in the context of the class and the
> instance.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mxcl/homebrew/pull/14038/files#r1448940>.
>
>
These locals are in a different scope than the ivars you reference below, so this declaration isn't really doing anything (ivars can be used without being initialized, and are nil by default).
Though it hasn't changed since 2009
might as well add the list_to_binary here as well?
This is great because they get a chance to see their new vocabulary word in practise (the verb "to call")
Die orig impl. Kannste dann in einem vendors verzeichnis ablegen, dann wirds auch net vom autoloader gefunden und ein dev kann nur mit deiner subclass arbeiten
All the versions needs to be propagated to richfaces-root-parent.
The serial number we use is irrelevant. I need something to be predictable so that I can use this in an assertion. It's the `1` in this line:

```
+            assertEquals(Arrays.asList("checkServerTrusted [CN=" + hostName + " 1]"),
+                    trustManager.calls);
```
Add some comments and it is starting to look good :)
I think this should be an else if
This block of test code appears duplicated 3 times. Factor it out into a separate function, and write your test cases as declarative variables at top level rather than inside the test function.
I was slightly wrong; the Object... is only a convenience method for ChatArguments (as Zidane said below) :P
Any idea when this could happen now?  It seems like any change that could make getCurrentRange() return null would be noticed by handleHostDocumentChange() first, closing the editor altogether before we ever get to setColor().
Sorry, I was wrong to say attrName can be empty. It can never be empty if we detect that the user is editing an attribute value. If not in the attribute value but in attribute name, then it is not initialized at all.
To avoid changes that occur from the editor on the remote site to propagate back there, the DOMAgent must not push any changed node values if they have come from there (through the EditAgent).
Should this check selection instead of just cursor? It should have an empty selection here.
typo? ``NOT_FOUND_ERROR``
Was this just a mistake?
should use @example
formatting is weird here (and later in the file). Do a quick Format before committing :-)
Never leave code just so in. Because this really confuses. We have a repository to take care of old code (of course make good commit messages).
This is exactly why I wanted async events in the EventMangerWrapper stuff I did.  By having an async event you solve this issue.  Firefox has gotten into a lot of problem using this hack, see http://blog.mozilla.org/tglek/2012/04/10/argh-at-our-unresponsive-tab-strip-settimeoutfoo-0-can-be-very-harmful/  I think we need to move to async event for this, and drop setTimeout.  That will need #1130 to land, so if you want to file a bug blocked on that, I can fix it later.
No need for any handlers when dragging stops?
the whole file changed?
why do we need to check `newStart` and `newEnd` against null?
You could just have used `entry.slug` here, as you did on (new) line 33.
does the 'checked' attribute not working? https://developer.mozilla.org/en-US/docs/XUL/menuitem#a-checked
Should we not set up a namespace for our vars here opposed to just chucking them into the global namespace? Same comment in the other code below
That should be fine as the only tlsdate-helper that matters is the one with suid bits.
Strictly speaking, you should never have more than one element on the page with the same ID.  The point in the ID is that it uniquely identifies an element.  It would be better to use a class here, I think.
But on that subject, why not support seek since we've read everything into a buffer anyway?
Thx, didn't notice (it started out as a copy, then I just removed all that muck)
so why not use zip?
Should be ApS
I'd actually prefer javadoc style here with a @param expiresAt <desc> so that it shows up properly in generated docs.
I wonder what is the condition that can cause the input layer not to be the one selected in the tree, in other words, is this check really necessary?
no spec tests for this?
Silent heals does not sound good for me, I am for raising an error for sure. And also - if possible to make all the processes as simple as possible.
This is unrelated to formatting ... this is the SimpleDB equivalent of "CREATE TABLE IF NOT EXISTS [tablename]".
The channel is specific to Pusher.. while we could reuse the mentioned channel; it may be that the record['channel'] is different from the pusher channel (other logging handlers for instance)
Why is this firing twice?
What is the precedence, this or the system property?
Should be testing this proc as well as ad-hoc?
Though the distinction between proc and ad hoc only gets interesting when parameters come into play.
Wait, what's the relationship of `rawdict.txt` with ANY OF THE FILES with `PinyinIME` repo? I couldn't find the file.

The goal of the README and Makefile is to provide an easily way to update the data should the upstream changes. Also we need this to verify the claim that the license of the data is compatible to Gaia. This is very important.
not necessary, just a stylistic preference (I prefer to keep the module level as clean as possible out of habit so that imports are faster).  Is there a reason why it should be at module level?
Agreed, using isEmpty is better, and caching the status bar warnings is also better than requesting them twice.
I liked "Client" best. "Bitcoin Core" is more misleading.
This needs:

#ifdef WIN32
#include "shlobj.h"
#include "shlwapi.h"
#endif
I'd say it's not ready to pull until i add the code to check for stuck block downloads. I wasn't sure if a pull request was the correct way to go about soliciting comments or if there was a better way. Stuck code has been written and tested for about a month but not combined with this code yet.

Sent from my Nokia phone
-----Original Message-----
From: Philip Kaufmann
Sent:  17/05/2012 16:41:01
Subject:  Re: [bitcoin] Parallel block download (#1326)

> @@ -2396,6 +2393,21 @@ bool static ProcessMessage(CNode* pfrom, string strCommand, CDataStream& vRecv)
>      }
>  
>  
> +    // Ask a connected node for block updates
> +    if (!pfrom->fClient && !pfrom->fOneShot &&
> +        //(pfrom->nVersion < NOBLKS_VERSION_START ||
> +        // pfrom->nVersion >= NOBLKS_VERSION_END) &&
> +         nAskedForBlocks < 8 && !pfrom->fAskedForBlocks && !CaughtUp()) // TODO - tune
> +    {
> +        nAskedForBlocks++;
> +        pfrom->fAskedForBlocks = true;
> +        printf("initial getblocks to %s\n", pfrom->addr.ToString().c_str());
> +        pfrom->PushGetBlocks(pindexBest, uint256(0));
> +        NodeSummary();
> +    }
> +
> +
> +    if (strCommand == "version") ;

But in the end this pull is not mergable like it is?

---
Reply to this email directly or view it on GitHub:
https://github.com/bitcoin/bitcoin/pull/1326/files#r839082
I was not aware of that mask stuff, update for the pull is on it's way now :).
Bad coding style, IMHO.
ProcessBlock is more visually appealing IMHO.
You and others voted to keep file names suffixes for classes stating its easier to identify files in editors. So I am a bit surprised you are suggesting the opposite here.
Other plugins use the Pyramid route in their docs. It makes sense to me - easier for the integrator. See [this](https://github.com/camptocamp/cgxp/blob/master/core/src/script/CGXP/plugins/FullTextSearch.js#L43) for example.
This should be indented (for jst).
I don't know why stub_model wasn't available, it should be. However, you don't really need it. Just use double("user"). The only time when I don't use the "double" method to create my test doubles (mocks or stubs) is when I need to assign them to an active record association (active record does type checking and doesn't allow mocks) or if I really need an ID method and I'm too lazy to mock it.

Mailer specs are one place where you can be sure that you never ever need a real model. Only ever use mocks in mailer specs. I should write a behavior for rails_best_practices that checks that. :)
Ah yep, you're correct. The new code you have related to this section looks good.
honestly, I don't think it can't, but I was thinking about preventing as many problems as possible for users providing functions, i.e., I didn't want to ever provide a null request to a user-provided function.
Now that I looked at the code a bit more closely, I wonder why we even have to throw an exception here. I mean, if someone managed to call this function with the correct type, why not give him back the object and be done with it?
Seriously? You've been writing too much Java :-)
This change is pretty pointless since riff-raff doesn't really exist at this point.
It's not connected with magenta as a library either
checking for connp->cfg twice here
no worries, no biggie.  Just a tip for the future.
BTW, this means that `fig.set_facecolor('white')` in the previous code is not needed.  I wonder why it is in the function `print_figure` in the first place.  Probably matplotlib changes the spec over time?
If anything, I would prefer the exporter to handle normalization to a name appropriate for the destination.
I would use key names that match the names of the CM modes for clarity.
all these commands have a "net" arg.  Can you change getPortClientForRegion to 

@Path("/networks/{net}")
getPortClientForRegionAndNetwork(... @PathParam("net"))

it will really help disambiguate once you remove networkId from all the PortClient commands.

make sense?
Instead of supporting powerful regex in schema, what if we restrict to to be simple prefixed wildcard? Eg. "en_*" (which is not regex). Would it be enough?
This test changed because "front page" (product landing page) searches will be by product. We don't use tags for this anymore.
Wait, this is wrong. The lock is on the actual document even if it is a translation. (I was unable to steal the lock on the translate page which is how i noticed.)
Text missing why this should fail.
What are you talkign about ? Your MemcachedDriver requires a config array to build the Memcached connection internally in **all** cases, instead of following the DI pattern
The real change is introducing the interface, not moving the phpdoc tag
Agreed. It is much more readable now. Thanks.
this is wrong. FormView has not been added
missing spaces around ``=``
please align the "=>" (same pb below).
Not as constant.
``ArrayNodeBuilder`` does not exist
Rename to ```testUpdateSessionData``` ?
I like where you're going with this, however this breaks the use case of passing in a function as 'input'. Notice that:

```javascript
var test = function () {
  var input = Array.prototype.join.call( arguments, ' ' );
  console.log( typeof( input ) );
};
test( function () {} ); // -> "string" ?!
```

I think it can still work but might require more type checking? (ironically :D)
Newline before this guy
How about a name that references the behavior a bit more, describes less of the implementation? Maybe `normalize_email`?
(Likewise in `variable`, `macro_argument` and `globals_expression` below.)
ina ro chon bug nib boodam injoori zadam :)
Naming suggestion: use `thread_count` instead of `nb_threads`. Also, don't configure an instances number value. We already have that data, we can just get the length of the instances list, and it will never fall out of sync or be misconfigured by a user.
The flags are probably a bitmask, so you should build a string from each bit set (and perhaps specify the bit in hex instead of "UNKNOWN" when one doesn't have a known name).
If it imports matplotlib it should be in the mpl sub directory. It looks like some of these tests don't depend on mpl (which is fantastic!) so they should remain here (two test files is fine).
Which issue?
``cls.__name__`` is already a string. Also since these days Python has list comprehensions, ``return [cls.__name__ for cls in installed_plugins]`` should be faster and more concise.
this comment is pretty much valid for all changes proposed
We had this discussion off-list before. But I'm strongly -1 on defining/limiting potential children of plugins by hard-coding them on the plugin class. This will just bite us in the future.

If anything, this should be ``default_child_classes`` and the docs should be updated to point out that this can be overwritten.
3eb994b
Ouais, ben ça marche pas avec Intellij.... Ca a l'air d'un beau merdier ce truc, non?
You did not remove all the references of recent files :-)
It's a good idea though, maybe something more like "most popular notebook" will be appropriate, and it would be great to be able to make the thumbnails in the cloud !
We `gjslint` our code so you would need to fix this to have it match the style.

You missed out the `break` at the very end.

We also avoid arrow pattern. For example you should do this instead:

      if (!this.shown || evt.keyCode !== evt.DOM_VK_ESCAPE)
        return;

      this.hide();
      evt.preventDefault();
      evt.stopPropagation();

      break;
Shouldn't this string be localized?
The content of this panel seems broken.
It's better to maintain scripts, I think. 
And security team suggest don't do this. (heard from @timdream).
Landing https://github.com/mozilla-b2g/gaia/pull/5680 isn't trivial, we have to take many considerations (I've already written my feedback there) and is not a priority, as there is available code already merged in `/shared/style/`.

Landing this PR(Contacts apply BB), it is a priority, as we need to have as soon as possible design consistency meanwhile we decide the improvements to apply in the stable BB.
Please at least file a bug for this and comment with the bug number so we at least fix this once we know whats up.
Same bug as t'other I guess.
This comment should go above the doctype declaration - doctype should be the first data on the page. (and there is a small spacing issue).
better to use xhr.onload
nit: remove dead code
maybe symbols should remain unquoted, I agree with quoting strings
Why not use a normal JS event listener?
Does this default to localhost or 127.0.0.1 or something?
$this  是绑定ui的一个载体  container是一组list
`order('')` seems unnecessary ...
How about this?

```ruby
@connection.disconnect unless @connection.disconnected?
```
And also for the other string constants below where you see fit.
缩进是2格
```
# prevent errors
 ...
 else
  unless reply.com or reply.file
    err = 'No file selected.'
 threadID = null
```

?
All of these methods need unit tests. They are not hard to write, so I am not sure why you think we should not be doing them - in general I would like to see unit tests for all new code.
This was code that was already here,  I just moved it out of the constructor invocation. I believe that node here refers to the action node and thus your example args tag is the firstChild referenced.
Hi Yiqiao, I think this is the only usecase for this err message and there are only 2 variants, because there are 2 ways (windows and linux). Booth are python and should stay the same in all versions...
This test should also assert how long it took to run the tests. In this case (using `--indenpendent-tests) it should be less then 6 seconds or so.
b and a should be after beta and alpha in the list, to be sure the whole string is matched when it's present.
Should be fixed (see next commit)
you should return early here
`$executes[] =`
Oh, cool, the change wasn't intentional. sorry.
the useJQuery is not magic. jQuery won't include that behavior by default for IE7 or IE8.
I have `removed` `testTearDown` func
entire file: please use indent of 4 spaces
Since i do not know the inner workings of UiaDll, then can't you just retrieve all the data item controls and then perform the matching at Ruby side one by one?
`whenever this one failed`—do you mean `even if it failed`?
This is the only issue I can see here
I think that's the correct way to do it. I was going for speed. :/

I can work to separate the two pieces.
This should be `if version_number >= 16` since systemd was introduced in Fedora 16.
I have discussed naming on IRC `obscure` was suggested by dmc and had most votes. If I have to write `makeNonEnumerableOwnProperties` than I would save keystrokes by just using property descriptor map.
It seems like this assumption ought to be validated by the `run_metric_summary` method, and an error raised (and caught here) if the assumption is not borne out.
Well, truthfully, I forget exactly where these APIs were added, but I'm using 15+ so I went with that. Allow me to check MDN and be more accurate.
why do we have to notify with `null`?
there is an extra whitespace before )
change to ===
The VM might be slower to start since it's heavier. 15 seconds is probably
to much, probably 5 would be ok, but we never really know.


On Thu, Dec 6, 2012 at 10:01 AM, Romain <notifications@github.com> wrote:

> In dynohost/dynocontroller.js:
>
> > @@ -173,7 +174,7 @@ function DynoStateMachine(options) {
> >
> >    self.afterStart = function(){
> >
> > -    setTimeout(timeoutIfNotConnected, 2500);
> > +    setTimeout(timeoutIfNotConnected, 15000);
>
> Is there a reason for this ? The new VM is slower to start ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openruko/dynohost/pull/8/files#r2332308>.
>
>
Instead of removing this, shouldn't the case where both the i18n and the validation behaviors are triggered on the same table be handled? Otherwise it's a regression.
Yah, a double feels even better. +1
getting fancy now, haha
We haven't officially set the zf2 minimum PHP version, but I've been
unofficially suggesting 5.3.3 - which would mean is_a usage would not work.

The proper solution is a scoped container from which controllers are
pulled, and Ralph is working on that in relation to the service
locator/instance manager proposal.

On Saturday, March 31, 2012, Dolf Schimmel wrote:

> > @@ -277,12 +275,31 @@ public function dispatch(MvcEvent $e)
> >              }
> >              goto complete;
> >          }
> > -
> > -        if (!$controller instanceof Dispatchable) {
> > +        $controllerClass=$im->getClassFromAlias($controllerName);
> > +        $reflection = new \ReflectionClass($controllerClass);
> > +
>  if(!$reflection->implementsInterface('Zend\Stdlib\Dispatchable'))
>
> Since 5.3.9 is_a() supports checking strings. Perhaps you could use that
> instead, relying on reflection for earlier versions?
>
> http://nl3.php.net/manual/en/function.is-a.php
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zendframework/zf2/pull/788/files#r629980
>


-- 
Matthew Weier O'Phinney
matthew@weierophinney.net
http://mwop.net/
It should yes, but Color::Black has been coded to 1 already, because of Color::Normal and Color::Reset, hence causing the +1 on all values. Shall I fix this ?
As explained above, this use is unnecessary
I'm thinking that the correct way for test this it's just test that the calls to the external methods and relay the each data to test to the final component.

This test it's testing Zend\Validator\Uri::isValid() so must be placed in ZendTest\Validator and not in Zend\Form

This test should verify that Zend\Validator\Uri::isValid($argument) is called once. You can achieve that using mockups

The complete list of possible values should be in ZendTest\Uri
File needs commenting.
`$filter`, not `$filter`
are you sure you want throw an exception before the loop has completed?
habit from another language: performance matter with the other language, I know it doesn't change anything in js, I'll change that.
Just curious:  why is `:secure => true` the default?

Being able to do a secure delete is useful, but I would imagine for most people, it's the 20% case rather than the 80% case.  Could we change it to `false` and make it an option instead?
this is breaking things when the jQuery fallback is needed. the non-deprecated equivalent is ``decodeURI``, not ``encodeURI``
now split out into individualized service files
check for doubles here
path can already be in $PATH]
Add empty line between imports here
Oops, I will correct it now ! ;)
3 missing `=`.
I just meant `cli.options` as an empty object (since on the next line the _variable_ `options` is set). I don't see it used in the tests, though (sorry if I am missing something!).
we should throw an exception here
Equals is provided by Type
should there be a returnTo field if there is no returnTo right now?
Lol. I've been out all night. Good thing I didn't publish. Revert. More tests needed obviously for this one ;)

Sent from my iPhone

On Jul 6, 2012, at 11:49 PM, Kilian Ciuffolo<reply@reply.github.com> wrote:

>> +NsSocket.prototype._fetchBody = function _fetchBody(chunk) {
>> +  var raw, event, data;
>> +  var chunkLength = chunk.length;
>> +  var bytesLeft = (this._eventLength + this._messageLength) - this._bufferJoiner.length;
>> +
>> +  if (chunkLength >= bytesLeft) {
>> +    raw = this._bufferJoiner.add(chunk.slice(0, bytesLeft)).join();
>> +    event = JSON.parse(raw.slice(0, this._eventLength));
>> +    data = this._messagetype ? raw.slice(this._eventLength) : JSON.parse(raw.slice(this._eventLength).toString());
>> +
>> +    this._eventLength = -1;
>> +    this._messageLength = -1;
>> +    this.emit(['data'].concat(event), data);
>> +
>> +    if (chunkLength - bytesLeft) {
>> +      process.nextTick(this._fetchHeader.bind(this, chunk.slice(bytesLeft)));
> 
> it is 100% broken, If you write to the socket like 3 messages at the same time (same data event) it will take a wrong path. It needs to be sync.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/nodejitsu/nssocket/pull/11/files#r1117918
We dont have a param dict for the slocum data yet. Dummy is fine for now.
It's probably better to move this down a couple of lines, below where we check that the user has been set. Otherwise you'll get a nil error instead of a 404.
Try this: `let channels = (Frame.type_of_kind kind).Frame.audio in`
Added with a vengeance
During ```git azure init```, if a storage account with the specified (or implied) name already exists, I skip the storage account creation step (even if there is a service location mismatch between the existing storage account and the service location specified through parameters). I am not sure if the same logic makes the cut for you for affinity groups, or whether you want to enforce the equality of the affinity group of a pre-existing storage account with what you attempt to set up with ```git azure init```
Since your translator only handles single article pages, you should remove search and I think toc (though I couldn't find a toc page). Could you include test cases for all the other pages?
Not sure if this is bad or not, but this is recursion. I would make a loop to ensure that you never run out of memory in strange error conditions etc. But I might be wrong.
Can you aquire a lock after it has been released() by calling lock()? The semantic should be documented: A lock can be aquired  only once, right?
Okay, I see. Makes sense.
When the Poll updates every 800ms, `OnTradeAddItem` is called when an item is added.  If an item is added in the function, `MyOfferedItems` isn't updated until the next Poll.

What I did was I added [a line to `AddItem`](https://github.com/Jessecar96/SteamBot/blob/master/SteamBot/Trade.cs#L464) (and `RemoveItem`) that added the item that the user added to `MyOfferedItems`; the lines that you commented out updated `MyOfferedItems` to the list that steam has, so that it stays in sync with steam (as the request in `AddItem` or `RemoveItem` could have failed).
I think rather than hard coding these lists, we could have the class call a method to register itself as a valid option, for instance:

```ruby
class GitSource
  valid_options :git, :ref, :tag, :branch

...

end
```

```ruby
class CookbookSource
  def self.valid_options(*args)
    @valid_options.concat args
  end
end
```

We could do the same for location keys, as well.

This keeps relevant functionality encapsulated in the sources rather than bundled in CookbookSource
that's probably my issue then - let me take a look
asdfasdf teset
Is this sarcastic? xD
it is better to close session in separate filter
нужно ввести специальное значение для обозначения отсутствия предка. Завести для него константу с говорящим именем. А не использовать количество вершин. Иначе в месте использования ничего не понятно
That's exactly what the code does. Have a look at execSQL(). If the previous stuff has been committed, it starts a new transaction. All SQL statements will go into that transaction, until eventually commit() gets called when the commit timer fires.
You should add the LSB tag for requirement ( ShouldStart: etc )
not block is rendered => the block is not rendered
In the case of amazon s3, this "unlocks" the ability for someone to temporarily download a file, right? If so, it should be permission protected as well.
What are the tests checking? That the ``ConstantPool`` can parse the binary without throwing exception? Is the ``pool`` local value useful?
I see we have the ``scala.plugin.version`` in the properties, why don't we also have properties for ``maven-clean-plugin``, ``maven-source-plugin`` and ``buildnumber-maven-plugin``? 

It's a good practice to put plugins' versions in the top properties.
The thing is that all those ``Scala`` prefixes really don't help us much, I'm fairly against calling things ``ScalaXXX``. Furthermore, the package already contains ``scala``, so I don't think it would be confusing to simply drop the prefix.
I am very interested in reproducing the memory leak.  This is your stack right
java.nio.channels.ClosedChannelException
at java.nio.channels.spi.AbstractSelectableChannel.register(AbstractSelectableChannel.java:167)
at voldemort.store.socket.clientrequest.ClientRequestExecutorFactory$ClientRequestSelectorManager.processEvents(ClientRequestExecutorFactory.java:341)
at voldemort.utils.SelectorManager.run(SelectorManager.java:172)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)

I am thinking the leak is the interesting piece. To me, it seems like the leak will not be caused by this. But, we should handle this exception within the while loop as we have it, so we don't end up adding other connections in the queue, as a result of one channel register throwing this
Yes IMO

Le 15 nov. 2012 à 08:46, Markus Bachmann <notifications@github.com> a écrit :

> In src/Geocoder/HttpAdapter/SocketHttpAdapter.php:
> 
> > @@ -99,7 +101,8 @@ protected function buildHttpRequest($path, $hostname)
> >      /**
> >       * Given a resource parse the contents into its component parts (headers/contents)
> >       *
> > -     * @param  resource $socketHandle
> > +     * @param resource $socketHandle
> Is resource a valid type?
> 
> —
> Reply to this email directly or view it on GitHub.
>
Will you add the required things pls? Thanks.
Probably about time we start PHP5ing these files. Could you?
по логике, вместимость массива должна быть равна MAX_CELL (нулевой элемент считается). В данном случае это не критично, так как при добавлении элемента с индексом [MAX_CELL-1] NSMutableArray все равно увеличится
Сам разобрался с более простым написанием  дискрипшена после просмотра чужих заданий.

Можно написать в одну строчку:
-(NSString *)description
{
    return [DNA componentsJoinedByString:@""];
}
This should be qualified with `__attribute__((objc_precise_lifetime))` so it lives exactly as long as the autorelease pool block.
On 13.10.2012, at 13:22, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/epochs.py:
> 
> > @@ -576,6 +576,24 @@ def as_data_frame(self, frame=True):
> >  
> >          return out
> >  
> > +    def to_nitime(self):
> > +        """ Export epochs as nitime TimeSeries
> > +
> > +        Retruns
> > +        -------
> > +        isntance of nitime.TimeSeries
> epochs_ts : instance of nitime.TimeSeries
> The Epochs as nitime TimeSeries object
> 
> the reason I am picky on docstring is that they used to format the doc automatically.
> 
thanks for being picky, also the docs should be nice to read :-)

> —
> Reply to this email directly or view it on GitHub.
>
it—your -> either spacing, but like above, better to use a semi-colon or a full stop.
one problem with the syntax is that we don't know which is the class we want to instantiate. Maybe we need a slightly different syntax.
build-repository is not useful here. Actually the correct command is:

`./build publish-local`
What is this for, when oyu already have DiscoveryFailureEvent?
We shouldn't embed tests in the production code. If you can't test this using Jasmine then we should discuss to figure out some other way to test.
use a code block. The indentation does not create one in rST either (this is also MarkDown)
The complete note should be indented by 4 spaces.
this should be:

    (...) your ``symfony/form`` component tests
fixed in symfony/MonologBundle#8
Are you expecting to create many of these? In that case I recommend/strongly suggest that you create an actor that has the ActivationTracers beneath it, since otehrwise it will create a very shallow but broad tree.
>
> I don't understand this change in behavior of separatevars. I guess the
> docstring should be updated to say that no factoring is done?
>

I does no unecessary factoring since that is an expensive step. If the
expression can be separated without factoring, no factoring will be
apparent. As a final resort, however, if the hasn't been separated then
factoring is attempted.
Чтобы показался чекбокс. Он без этого не появится.
Не нужно. Он равне последнему выбранному аккаунту. Выбрал другой - стал номер предыдущего.
¿Creés que por consistencia pudiéramos pasar estos mensajes al usuario al español?
these keys don't match with what we use elsewhere in the codebase - products, packages.  no big deal though
Since this is an eagle project.... I probably would have a method on start_page something like:

```
def add_choice!(choice)
  options << choice
end
```

Or something... Seems like MAYBE there's too much being known about the inner workings of the Choice class outside of it.
Why not:

    $post_errors[] = array('long_message', $modSettings['max_messageLength']);

so you wouldn't even need the exception below:

    if ($post_error == 'long_message')
Hey Jim, I know you're just changing the smallest amount possible, but could you please fix up the couple of lines that are longer than 80 columns in length?

Also, while you're doing that, could you please do a `git pull` to merge in Brian's latest changes to this set of changes? (Least, I think that'll work. ;)
wrong CS :  `for ($i = 0; $i < 24; $i ++ ) {`
I think it could still be helpful to provide the relative path in addition to the `NSURL`, like when we need paths to pass to `git` on the command line.
OK.  I'll make a point of reading and following PEP8.
Not exactly a PEP8 issue, but shouldn't we be using np.hypot() here?  I tend to find that much more readable, plus you gain the benefit of not accidentally overflowing.
How come these got commented out?
Just a thought... are we guaranteed that bins will have a non-zero length?  If not, then it would be a good idea to catch the length-zero case and raise a descriptive exception.
This is not true:

```
$> grep -ir decadeOnly *
Binary file doc/build/doctrees/api/ticker_api.doctree matches
doc/build/html/api/ticker_api.html:<p>if attribute <em>decadeOnly</em> is True, only the decades will be labelled.</p>
lib/matplotlib/ticker.py:    if attribute *decadeOnly* is True, only the decades will be labelled.
lib/matplotlib/ticker.py:        self.decadeOnly = True
```
Generally, you shouldn't rely on the fact that another test was ran - tests should be able to be ran independently of one another. In the music test, I believe @AaronMT took this into account, so I don't see why the video test wouldn't do this.
Well spotted - I didn't mean to do that but as we discussed on IRC , don't think this is an issue, number lengths are often different so let's let this one go for now
Then create additional variables for that, but these "magic strings" need to be in actual constants.
Well I thing for it and comment it tommorow
I think this changes exsting behaviour for non-numeric values. Before any leading/trailing whitespace would be returned, now only the trimmed value would come back. I suggest storing the trimmed value in another variable and return the original value for non-numeric values.
An anchor with a background-image means that resizing an image is not possible. In this case (mobile) I was trying to minimize DOM usage, but I agree there are cases where using an anchor with an image inside would make sense.
@bp323 @apex13 I agree with @apex13 here, this is indeed a critical issue and we're using this in other API functions as well. (e.g. `TemplateRenderer`)
@nicolaasmatthijs Since this is a jQuery object, can we prefix it with `$`?
Looks like you accidentally added an `x` to `sakai:message`.
indention weird here
Why mongo? are we really using it at this point? @petrjasek
You mentioned on IRC that you weren't a fan of this, but I don't mind it--the `PreviewToEditorMapping` function was designed to be a constructor that returned an object like all the other CamelCased functions in Thimble, we just didn't have any methods/properties to put on it until now, since all its functionality was activated by attaching events to its dependencies.
if we only have one publication-result  element, this should be an ID, and there should not be a div.#id, #ids are uniquely identifying already.
this needs to be higher, like 30 seconds.
missed one ===
The Minigun has three different sprites; Recoil, drop, and a special overlay sprite, that must be adjusted accordingly for the Recoil and Drop
So that dragon's like "Fuck that MacGuffin, I'ma fuck some shit up."? If that's it I like that the Main Character didn't know what he really needed when he started out.
```[2.1.0,2.2.0)``` would be more right. It requires the latest 2.1.x build.
echo "<h1>$_SESSION[user_name]</h1>";
hmm i was trying to fit 80 lines width. I presume i need to change this into something like this?

self.__name__ = '.'.join((f.__module__.replace('gearman_jobs.', ''), f.__name__)) ?

if i need to break the line, where to place the next one? under equal sign? or under self.__name__ ?

the ".".join produces a string, so that's why i placed .replace near it :)
You should also create a spec for visitors to ensure no visitor is able to delete your check-ins.
Looks like you have tabs here.
The `$` prompt gets a different color when the current working directory is a Git repository. Is that intentional?

![](http://i.imgur.com/Daf6X.png)
The path is not guaranteed. Shouldn't Sublime Text prompt you to install the binary into `/usr/local/bin`?
Prepare? For what?
This is normal and nice in python, but I hate it in javascript. I find it very ugly. :) But dont worry, I will fix it.
I am not sure why is this in form?
Indentation should be 2sp.
This will be the list of all the consumables' names
Don't use a Hashtable - that's a really old Java class and is only useful now if we really need the synchronization (which we don't here). Use the standard collections framework, e.g. java.util.Map.
what about named parameters (the ORM does not use them, but you can use them when using DBAL directly)
To do different paragraphs in POD you need an empty line between the blocs. A good way to verify if your documentation is correct is to test it with perldoc. Something like: `perldoc lib/pf/SNMP/Brocade.pm`
Missing the switch portion
stubed