Simplify callers of svn_checksum_dup() with a NULL checksum pointer.

* subversion/libsvn_fs_base/tree.c
* subversion/libsvn_fs_fs/tree.c,
* subversion/libsvn_wc/info.c
  (various):
    Since svn_checksum_dup() handles a NULL svn_checksum_t * argument,
    remove code that checks for a NULL argument and always call
    svn_checksum_dup().


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327656 13f79535-47bb-0310-9956-ffa450edef68
Followup to r1327640.

* subversion/libsvn_fs_base/util/fs_skels.c: Add missing include.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327665 13f79535-47bb-0310-9956-ffa450edef68
Whitespace fix.

* subversion/libsvn_wc/deprecated.c:
  Fix indentation.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327681 13f79535-47bb-0310-9956-ffa450edef68
Refactor svn_checksum_create() to avoid two switch statements.

* subversion/libsvn_subr/checksum.c
  (checksum_create):
    New static function that creates a svn_checksum_t * with
    everything set but the contents of the digest.
  (svn_checksum_create):
    Use the existing switch statement to get the digest size without
    needing DIGESTSIZE().  Use checksum_create().


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327695 13f79535-47bb-0310-9956-ffa450edef68
Add and use svn_checksum__from_digest_md5().

This replaces svn_checksum__from_digest() taking a svn_checksum_md5
argument with a new svn_checksum_t constructor function.

* subversion/include/private/svn_subr_private.h,
* subversion/libsvn_subr/checksum.c
  (svn_checksum__from_digest_md5):
    New private function.

* subversion/libsvn_client/commit.c,
* subversion/libsvn_client/export.c,
* subversion/libsvn_client/repos_diff.c,
* subversion/libsvn_fs_base/util/fs_skels.c,
* subversion/libsvn_subr/base64.c,
* subversion/libsvn_wc/deprecated.c,
* subversion/libsvn_wc/diff_editor.c,
* subversion/libsvn_wc/update_editor.c,
* subversion/tests/libsvn_delta/window-test.c
  (various):
    Replace all calls to
      svn_checksum__from_digest(digest, svn_checksum_md5, pool);
    with
      svn_checksum__from_digest_md5(digest, pool);


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327700 13f79535-47bb-0310-9956-ffa450edef68
Add and use svn_checksum__from_digest_sha1().

This replaces svn_checksum__from_digest() taking a svn_checksum_sha1
argument with a new svn_checksum_t constructor function.

* subversion/include/private/svn_subr_private.h,
* subversion/libsvn_subr/checksum.c
  (svn_checksum__from_digest_sha1):
    New private function.

* subversion/libsvn_fs_base/util/fs_skels.c
  (svn_fs_base__parse_representation_skel):
    Replace
      svn_checksum__from_digest(digest, svn_checksum_sha1, pool);
    with
      svn_checksum__from_digest_sha1(digest, pool);


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327703 13f79535-47bb-0310-9956-ffa450edef68
Follow to up to r1327695, switch to C style comments.

Found by: gstein

* subversion/libsvn_subr/checksum.c:
  Switch to C style comments.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327708 13f79535-47bb-0310-9956-ffa450edef68
abort() if svn_checksum_dup() is given an unknown checksum type.

It would be nice if svn_checksum_dup() would return a svn_error_t *,
but that's inconsistent with all other _dup() functions and the
function could claim to use

* subversion/libsvn_subr/checksum.c
  (svn_checksum_dup):
    Call SVN_ERR_MALFUNCTION_NO_RETURN() if an unknown checksum kind
    is given.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327709 13f79535-47bb-0310-9956-ffa450edef68
Reimplement svn_checksum_dup().

* subversion/libsvn_subr/checksum.c
  (svn_checksum_dup):
    Reimplement using checksum_create().


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327711 13f79535-47bb-0310-9956-ffa450edef68
Reimplement svn_checksum_empty_checksum().

* subversion/libsvn_subr/checksum.c
  (svn_checksum_empty_checksum):
    Do not use svn_checksum__from_digest() which would results in two
    checks of the checksum's kind.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327716 13f79535-47bb-0310-9956-ffa450edef68
Delete svn_checksum__from_digest().

There are no more callers of this function.

* subversion/libsvn_subr/checksum.c,
* subversion/include/private/svn_subr_private.h
  (svn_checksum__from_digest):
    Delete.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327717 13f79535-47bb-0310-9956-ffa450edef68
Rename checksum_create() to checksum_create_without_digest().

This is in preparation for a new checksum_create().  The new name is
much clearer that one is getting an incomplete initialization.

Suggested by: gstein

* subversion/libsvn_subr/checksum.c
  (checksum_create_without_digest):
    Renamed from checksum_create_without_digest().  Update all callers.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327747 13f79535-47bb-0310-9956-ffa450edef68
Refactor common checksum creation code into new checksum_create().

Suggested by: gstein

* subversion/libsvn_subr/checksum.c
  (checksum_create):
    New static function that creates a new svn_checksum_t * with its
    kind and digest.
  (svn_checksum__from_digest_md5),
  (svn_checksum__from_digest_sha1),
  (svn_checksum_dup),
  (svn_checksum_empty_checksum):
    Use checksum_create().


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327785 13f79535-47bb-0310-9956-ffa450edef68
Simply svn_checksum_dup() and svn_checksum_empty_checksum().

This removes a bunch of code duplication.

* subversion/libsvn_subr/checksum.c
  (svn_checksum_dup),
  (svn_checksum_empty_checksum):
    Instead of duplicating getting the correct digest size, call the
    correct checksum specific svn_checksum_t constructor function.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327791 13f79535-47bb-0310-9956-ffa450edef68
Start attempting to add some sanity to the editor handling for commit and
import, first by creating the ra_session independently of fetching the
editor.

* subversion/libsvn_client/commit.c
  (get_ra_editor): Sanitize params, and don't fetch an ra_session here.
  (svn_client_import5): Create ra session here, and better handling of
    intermediate path creation.  (More better handling coming soon.)
  (svn_client_commit6): Create RA session here.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327801 13f79535-47bb-0310-9956-ffa450edef68
* subversion/libsvn_client/commit.c
  (svn_client_import5): Move an existence check to a better location.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327803 13f79535-47bb-0310-9956-ffa450edef68
* subversion/libsvn_client/commit.c
  (svn_client_import5): Include the relevant parts of get_ra_editor() inline.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327806 13f79535-47bb-0310-9956-ffa450edef68
* subversion/libsvn_client/commit.c
  (svn_client_commit6): Use the special commit error handling in place of
    an SVN_ERR().


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327808 13f79535-47bb-0310-9956-ffa450edef68
* CHANGES (1.7.5): Update with merges to 1.7.x.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327829 13f79535-47bb-0310-9956-ffa450edef68
* CHANGES (1.7.5: r1295007): Reflect that the files touched might be unused.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1327862 13f79535-47bb-0310-9956-ffa450edef68