labofsahil/github-event-dataset-2012 huggingface dataset:
Right now we do not have a way to manually cancel a reservation. The implemented feature in that workflow deals when a 15 minute timeout occurs. When that expiration occurs, then we issue an additional command (not event) to cancel the seat reservation (which is a different aggregate, and which doesn't distinguish -or doesn't need to distinguish- between expirations or manual cancelations, and is never commanded directly by the end user). With this context, do you still think we should split the naming?
+1 for fuckYouMicrosoftForMakingUsAddingThisFuckingField
but srsly please call it "field" not "filed". That was quite confusing.
and srsly, let's name it "microsoftMadeUsAddThisPointlessField"
I've fixed it, but do we really need a special permission, or ``access content`` is enough?
Move the header name memory copy part before the value?

If you like, you could use the ngx_pstrdup() function.
Can't remember but yeah, it was something like that. This is bad structurally though - SystemBodies should not know about physics objects - they're an abstract concept.
Please remove those 2 lines
Thanks for the references. I don't think these are directly comparable though. The benchmark for the Wand study is not direct summation. It's a multivariate simple binning algorithm mentioned in Scott written in Fortran AFAIK. The reference in Scott for this is "On Frequency Polygons and Average Shifted Histograms in Higher Dimensions" Hjort 1986.

My impression for the product kernels is the same as Josef's, though I'm not as familiar with this paper.  I'm not proposing multivariate gridding, and I could be wrong - these are just impressions right now. Just the way we have it now, we are essentially doing univariate kernel density estimation, which should be easy to speed up, since we'd only do the binning once and then evaluate at the different points with different bandwidths, which should give the speed-ups I mentioned. I just need to figure out how to make this possible.
EPS**(1/2) * x   times x ?
у тебя --dont_ask значит 2 разные вещи
в первом случае у тебя он значит "мне не нужно файл инфо". если файл не сможет залиться, эксцепшн выкинется все равно
во втором случае это "мне плевать на статус загрузки". тут немного другое
> The week started well, @tobin had some good code that was working and scanning well and it wasn't fully featured but it was working, so that's great! .... and then we tested it on @aeoth's scanner.

perhaps reword to

> The week started well, @tobin dived in with functional (even if not fully featured) code... until we tried @aeoth's scanner
Is the rationale for not capitalizing these magic numbers that they are now stored in an `sbp` namespace?  I think I would still vote for capitalizing them for the feelings I describe above.
I think all GSObjects have a flux (or at least they should).  Certainly setFlux can be applied to any of them, so we can at least make it look like they all have a flux.  So I think this should move up to GSObject, rather than merely RadialProfile.
Boy, that was a weird brain fart.  Yes.  "we check" is right.
cool, using minidom
Although plugins are currently not jslinted, you should conform to the jslint style guide, which means that the space between } and ) should be removed.
Delete commented out code?
This is nice, and would be useful to rewrite the `SshSensorAdapter` in pull #24 to extend `FunctionSensorAdapter` as well
Since Rank2Types [is being deprecated](http://comments.gmane.org/gmane.comp.lang.haskell.cabal.devel/9257), let's use `RankNTypes` instead.
Line 78 it was $navbarLinkColorHover, not  $white 

Fraire has removed them in his branch so it's solved
**Error:** Missing class doc comment
This looks like a purely cosmetic change.. so why change all MAXKEY but not all the others?
On Chef 10, node['nagios']['pagerduty_key'] isn't going to be accessible in an attributes file if it is set in a role.

Chef 11 fixes this, but this unfortunately means we can't handle backward compatibility. We have to do this in a recipe.

See https://github.com/opscode-cookbooks/chef/blob/master/recipes/client.rb#L25
Probably, but using DatabaseImpl->dbid() is fine imho
It could, but it is transformed to UTC when ObejectId is created: calendar.timegm(timestamp.timetuple()). This feature is still under review, anyway. But I do not see problems with abuse, it does not have to be exposed over restful api.This is just an API for working with the Datastream class. 

On 03. 10. 12, at 11:25, Mitar <notifications@github.com> wrote:

> In datastream/api.py:
> 
> > @@ -234,7 +279,7 @@ def find_metrics(self, query_tags=None):
> >  
> >          return self.backend.find_metrics(query_tags)
> >  
> > -    def insert(self, metric_id, value):
> > +    def insert(self, metric_id, value, timestamp=None):
> The timestamp attribute does not have any time zone information (tzinfo is None).
> 
> The timestamp attribute as input parameter could have timezone information. (Or are you not allowing datetime objects as timestamp value?)
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
There, those two things are the only things I changed.
will do tomorrow.
Но вы на семинаре показывали именно такое + чем оно не удачно? У нас просто
какой-то недообразец календаря...

2012/10/22 Dmitriy Komanov <notifications@github.com>

> In
> src/ru/fizteh/fivt/students/fedyuninV/calendarExample/CalendarExample.java:
>
> > @@ -69,7 +74,12 @@ private static void parseOptions(String[] args) {
> >                              usageError();
> >                          } else {
> >                              i++;
> > -                            year = Integer.parseInt(args[i]);
> > +                            try {
>
> Можно сделать метод parseOrExit, например.
>
> CalendarExample -- уж совсем неудачное название. Можно, например, сделать
> пакет calendar, а главный класс -- CalendarMain.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/dkomanov/fizteh-java-task/pull/46/files#r1901715>.
>
>



-- 
С Уважением
Федюнин Валерий
МФТИ ФИВТ гр. 195
@shacker Fix>
Some comments would be nice on this file. Take a look at the kitchensink pom.xml for the type and number of comments we suggest including :-)
yeah that makes perfect sense, didn't click when I was looking at it earlier. Thanks!
Need to add unit tests in the `tests/` directory for this function.
I can modify it and overtire the is_the_current_page method.


It is not used in the mobile tests because that is based on the page title
maybe not built-in, but with a custom handler, totally (in fact, the case of ArrayCollection is already implemented by a dedicated handler, except it is defined in the bundle itself)
Moved this from members.js because of race conditions. Probably we want this back in members.js later. We should clean up app.js anyway. Have separate thing for generic functions and routes ??
This image needs to be autoreleased.
> 
> I don't see any use case. It seems contradictory with the previous comment. Looks like a YAGNI case to me.

From the user's POV it's YAGNI but I added it to avoid duplicating code for the X dense Y sparse scenario. Do you have a more elegant idea for this?
alright, so just update the comment to state explain this. Also the fact that `X_squared_norm` can be used as a pre-allocated buffer not makes it a valid use case.
This example doesn't seem to run in the current version of the code. Also, a lot of the tests fail.
it may also very well have been my fault. until just a week or two ago, i hadn't found a way to consistently get python files to use four spaces rather than tabs automatically in textmate (and my horrendous tendency is two spaces as tabs everywhere. yeesh.)
I don't like how github changed the sorting of additional comments so I think you missed this one. I'll repost it:
Please add an assert too and get rid of the `if (owner_)` checks
How is that related to your changes? Moving Scope means breaking package retro compatibility.. of course we already broke it by changing to `org.androidannotations`, but I'd like a clear explanation on this change.
why is 100 not a #define but HTSIZE_LIMIT is? What happens if HTSIZE_LIMIT gets redefined to be > 100 ? Are there any overflow concerns here?
@richardkchapman  Would these files be better off in common\remote?
yes, that helps testing... it's not part of the patch.
Yes, think reasonable logging, even if temp, better to have std. activity context logging
That would be a different function. I have renamed this function to expandHeap, and asserted that it does so.
Nope. The line is now removed.
> Shouldn't this be looking for the super within the transaction?

It is. That's what 'lookupSuperFile' does. Confusing, yes, but for another refactoring (DFSACcess that is)
`$.param({tracks})` is a shortcut for `$.param(tracks: tracks)`
Also, with non-callable arguments (here, string) you can skip the commas :
`appWindow = open appUrl + '?' + $.param({tracks}) 'scPlaylistsApp' 'left=20,top=20,width=600,height=600,toolbar=1,resizable=1'`
Not sure what the github info in here is, is this an example?
Oh, sorry for that, I have fix it...
Actually, maybe I'm confused. Are you removing an existing third party library? Then this is fine.
"potential"
Could you make this context more descriptive? "Searching" doesn't really describe it, maybe "finding documents by an index". Also, this spec will not work against a test server since the memory backend doesn't (yet) support 2I. Better to mock out the interfaces where appropriate.
On Wed, Feb 15, 2012 at 8:53 PM, Daniel Pittman <
reply@reply.github.com
> wrote:

> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/env rspec
> > +#!/usr/bin/env ruby -S rspec
>
> `ruby -S` is used to emulate the #! line on a machine that doesn't support
> it, so it is entirely useless invoked directly on the #! line.
>

That's one use, it actually simply searches for the script along the PATH
which is exactly what I want it to do on every platform.


> If you wanted to use it to support the "we have sh but not #!" mode of
> operation on ... no platform I know of ... then I would consider it, but it
> should be universally applied across the entire suite of tests, not just
> dropped in on one at random.
>

All I want is Vim to treat the spec tests as ruby files and not try to
invoke rspec to synax check them for me.  =)

I'll create a separate patch that replaces all of these troublesome rspec
invocations, I shouldn't be doing these one at a time as I edit rspec files.

-- 
Jeff McCune
Thanks for your suggestions, but the only consistent statement that seems to work on Traversable objects is foreach(). I have updated the unit test to illustrate my point.
Let's add a `Chef::Log.warn` in here saying this is a deprecated feature
This is good, I think I'd stick with quality, crop and upscale then just mention the others comma separated, explain that these come from the image processors and that definitions can be found in the documentation.
It's our responsibility to ensure our code is properly documented for those who work with it afterwards. That documentation includes careful choices of variable names and functions, but it also includes on occasion properly targeted comments. The people downloading this source from GitHub don't have access to the specs; as far as I've seen this chunk of code never had a spec. As such, a comment is the appropriate means to document this special case so that we understand what's going on here six months from now.

It's also part of our job to update comments when we update the code. That's why I try to be very judicious about how many I add. I also live by the adage "code like the person who'll be maintaining it is a psychopath who knows where you live."
Magic Numbers.. please add comment of why you are using this number.. consider making them a constant.
this needs to be a a try catch so that in the cases where it fails it doesn't end your test.
I guess we can allow unknown award types. The reason I'm doing it this way now is because same awards from different years have slightly different names, and we need this structure if we ever want to implement a page that displays all Chairman's winners for a year for example. Thoughts?
This check is the same as in `pair?`.
Use `contains?` to check if a map has a key.

~~~clojure
(contains? author :death-year)
~~~
please extract version numbers into properties
!isEmpty() is probably easier to read.
why would you ever want to search for a space, specifically? these are names: the "content" part of names are not spaces. this is a deliberate decision.
you already have seperate models for filtering purposes, so you wouldn't need that parameter, would you?

so:

PeopleProxyModel { // I hope I remember the name right
    id: favoritesOnly
    // filtered to favorites
}

PeopleProxyModel {
    id: allPeopleList
    // filtered to exclude favorites
}

Text {
    text: "You have " + favortesonly.contactCount() + " friends, and " + allPeopleList.contactCount() + " acquaintances";
}
It's a security field name, not a variable as such. If you'd prefer, we could flesh it out to ``security``.
Done with 07eec53.
If there isn't CVE atm please delete it until it is published
Should this do a ```retry```?  If the packet has not been sent when ENOBUFS gets raised, then this would skip an address, right?
Agree it's pretty useless right now. Is it normal to perform an authentication as part of an exploit check? I'm happy to move it around a little and call do_login as part of the check too but I'd class a login as an intrusive action rather than a check.

If someone calls check multiple times with incorrect details they could lock a valid account. Am I wrong on this point or is there precedent?
if not res or not res.body
Actually, we want 'Version' gone.
ouch, I'll fix that :)
I'd say leave as strings for now. Please use ``[int(result.pk) for result in all_mlt[:5]]`` instead (one pass instead of two).
Wrong bracket style here.
Minor typo here, it's "writable" (http://nodejs.org/docs/latest/api/streams.html#stream.writable) but should this actually be set? This is a read-only stream, no?
The bounding sphere has to be transformed to world coordinates. I guess the clone should happen in the `CompositePrimitive` and the `SensorVolumeCollection` before being transformed?
Only spaces. Eclipse formatted it that way. I guess to differentiate between the end of the condition and the start of the conditional body? I could change it to be on one line or remove the inserted spaces.  I just prefer not to scroll horizontally.
You need to use the static versions of clone here in case the properties are not Cartesian3 instances.  Also, you should be resuing the result properties rather than create new instances.  This code should look something like:
```
result.minimum = Cartesian3.clone(box.minimum, result.minimum);
result.maximum = Cartesian3.clone(box.maximum, result.maximum);
result.center = Cartesian3.clone(box.center, result.center);
```
No, if definition is empty and url not, the new line is still there.
Perhaps, but more complex :

    {{ term.definition|safe }}
    {% if term.url and term.definition %}<br/>{%endif %}
    {{ term.url|urlizetrunc:40 }}
Can you fix the indentation and remove the empty line. Thanks.
we should have debug logging to indicate this method is called at an incompatible API level
Do we care that this would fail on Windows?  (I guess probably not, but isn't there a node-way to remove a directory that would be cross-platform?)
So, @marcrabil I think the way you moved it is better. Let's keep it.
So currently I do it like this:

```
from django.core.cache import cache

# Hack to import settings from Django
import os, sys
basepath = os.path.normpath(os.path.join(os.path.realpath(__file__), '../../../../../'))
sys.path.append(os.path.join(basepath, 'django/src/routemap/'))
os.environ['DJANGO_SETTINGS_MODULE'] = 'common.settings'

...

# Delete all elevation profiles which are stored
        cur = self.db.select_cursor("SELECT id FROM relation_changeset")
        for c in cur:
            print cache.delete(c[0])
```
I have put this into db.py under routemap.hiking

I am thinking that this is not the best place to put it, but from what I can se only osgende know explicitly which relations are changed. So I have to ask the DB directly like above?

Can you comment @lonvia before I commit any code?
member variables should always be prefixed with m:
If that's changed to
```php
$this->contents = iconv($encoding, 'utf-8//IGNORE//TRANSLIT', $this->contents);
```
we won't have to worry about any incompatible charsets.

I'm not sure if this includes unrecognized/bogus charsets. I don't think these can be detected in any way though, unless PHP has some undocumented function I don't know about.

Maybe bite the bullet, and silence this, after which check if it's empty, i.e.
```php
$this->contents = @iconv($encoding, 'utf-8//IGNORE//TRANSLIT', $this->contents);
if (empty($this->contents)) {
    throw new Exception\UnreadableFile(
        'The given file should be a string, should exist on the filesystem and should be readable'
    );
}
````
I know it's nit-picky, but we really only "prefer genisoimage" for recent Debian releases, right? Can we just drop the "; prefer genisoimage" part of this echo output?
Moved setDocumentElement here
Yeah, @phiggins = clever :D
If possible, please mark the function with as close to `@safe pure nothrow` as possible. I expect that `nothrow` won't work because of `decode`, so that probably won't work, and I don't believe that `Appender` can be `pure` yet, so `pure` won't work. And `@safe` probably won't work for the same reason, but you could at least use `@trusted` then.

Actually, we _do_ have a bit of a problem here, because of `Appender`. Right now, `split` can be `pure`, but with these changes, it can't be, so this has the potential to break code. You may have to temporarily remove anything from these changes which results in losing `pure`. And it would be a good idea to make the unittest block `pure` so that that can be tested for (which is something that we don't do enough of).

`Appender` really needs to be able to be `pure`, but I don't think that enough of what it relies on has been changed yet for that to work. Maybe we luck out though, and it'll work now.
> From the viewpoint of dimensionality of static arrays, any type that's not a static array is a scalar with dimension zero.

But there are some major problems with that

1. The language does not consider scalars to be arrays of length `0`. Neither does anything in druntime and Phobos. Both `__traits(isStaticArray, int)` and `isStaticArray!int` will result in `false`.

2. If `int` is equivalent to any kind of static array, it's `int[1]`, not a zero-dimensional array. If an array truly had zero dimensions, then it would have no data, because it would have no storage for it. As such, it can have no type. It's `void`.

I could see some argument for `staticArrayDimensions!int` giving `0` for `int` much as I disagree that it should accept anything other than static arrays, but I don't see how you can argue that `MultidimStaticArrayElementType` should result in anything other than `void` when given a scalar. By definition, a scalar is not an array, and a zero-dimensional array holds no data, so it can't have a type. There's no data there to _have_ a type. So, if this works with scalars, it should result in `void`. And there's precedent for that. That's what `std.range.ElementType` does. ElementType!int` doesn't result in `int`. It results in `void`.
A `@property` also allow `xyz!T` feature. But I will still use templates as I *like* D templates.
Sorry, I misread the constraint.
In these *hard* cases, should we also aim to provide a message? Otherwise we'll end up with something similar to:

```
  1) Failure:
test_that_have_named_badly(BadlyNamedClassTest) [/dir/to/where/the/badly/named/test/lives_test.rb:8]:Failed assertion, no message given.
```
is Map<String, Object> would do the null check
no comma
its
always testXXX
We should remove the expression which are no definition and extract some unit tests.
whitespaces look suspicious here
you should not change the title level as it would break the pages in which it is included
(I think)
How about just call it CopyAsync unless we have/plan to have a CopyFrom method?
This is partly due to the limitation of github -- don't know how to separate a specific commit from the rest in a pull request. Will try to avoid in future... 
--Al 

-----Original Message-----
From: Jason Cooke [Microsoft] [mailto:reply@reply.github.com] 
Sent: Monday, June 18, 2012 4:23 PM
To: Albert Cheng
Subject: Re: [azure-sdk-for-php] Integrate changes from dev fork to servicebus fork. (#494)

> @@ -83,7 +83,7 @@ class BrokeredMessage
>       */
>      public function __construct($body = Resources::EMPTY_STRING)
>      {
> -        Validate::isString($body, 'messageBody');
> +        Validate::isString($body, 'body');

It is not advisable to mix merge reviews with bug fixes.

---
Reply to this email directly or view it on GitHub:
https://github.com/WindowsAzure/azure-sdk-for-php/pull/494/files#r1006364
I messed up here. This should be actually `return new this._cls()`. Please address this as well.
We don't need these format.json blocks. Right now we only need to render json for the `show` action. All the others can be removed.
this changes the default of idle_timeout which would break backwards compatibility.
May I suggest changing to;

    parts = filename.split(self.top_level_split_char, 1)

Then you don't need to rejoin the later parts
Si le traitement des `CONTEXT`s est le même pour les `SIMPLENYM` et `COMPLEXNYM`, regrouper dans un `NYM_CONTEXT` et utiliser `yypushtate` et `yypopstate`.
No need in `static`, really.
Lets get some javadocs on these methods.  I assume this is referencing the hl7_entity column?
change "the_field" for "meta"
Don't you need to add a dependency on jedis in the pom.xml?
Hahaha, fair point!
you already have this defined in the DynamicistToolKit
This will also affect the command line used to run the tests, but we might not want to mention that here.
Can you move this method to the bottom of the class (like all private methods).
Do this outside of your inner loop, having logic based on index is bad form.
I'm assuming that you actually have to create some data_bags to define your specific settings?

How can I find out what these should look like?
コードが重複してます。
・Some, Some
・None, None
・それ以外の3パターンで分けてみてはどうでしょう。
It seems you at least need an empty message (using growl 1.2.2). 
```python
os.system('growlnotify -t "Zope is up and running" -m ""'):
```
How? Explain please...
this method should be removed and used ``getTemplate`` (the getXXXTemplate methods are deprecated)
vezi că backslash-ul nu rămâne în string, pune `r` la începutul string-ului
I'll be honest, I didn't really look at the generated doc and I didn't notice it wasn't exactly the same as the schema.  I'll take a look.
Can we move `->update()` to its own line, indented to the same level as `->field()`? I believe that's the format used throughout the internal code, so it'd be good to keep it in sync with the documentation.
this could just be "res"
onclick= not /
That might be your bug
This de_DE file currently has no values -- just added it to show the direction I was going; how it would work with > locale.
You should add `__DIR__` here too
Listed as `@required` but not documented.
krollObject is literally the "this" object in Javascript parlance, and that should be documented here, i.e.:

`@param krollObject The object that represents <pre>this</pre> in Javascript`
*are* passed in"
Should document this in favor of `toBlob:`.
Align the parameters properly.
I think the license header is missing!
There is no way that I found to set the custom responder globally.  The 
only way is to get Rails to use the custom responder is to point to it 
in every single respond_with.  i.e.

respond_with @template, :responder => ImageManagement::Responder

I wanted to make the fix in one place rather than have this in every 
single controller action.  But now I'm thinking about it, we do not want 
to override Rails classes at all, because with any Rails override it 
affects Rails behaviour for the host as well as the engine.

I will update the patch to include the technique above with a custom 
responder.

Thanks for catching this.

Martyn

On 10/03/2012 10:18 PM, jguiditta wrote:
>
> In app/responders/image_management/responder.rb:
>
> > @@ -0,0 +1,24 @@
>
> I have to say that I don't love overriding the rails class for this. 
> Is there a reason we couldn't just subclass it and point respond_with 
> to our custom responder? If you convince me, I can merge this in 
> tomorrow, it is otherwise a nice improvement
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/aeolus-incubator/image-management-engine/pull/29/files#r1755585>. 
>
>
There should be a new line at the end of file.
I know, that's why I called it extreme :). 

To be honest, you're hardly gonna use two separate machines to run an arquillian test, so you can just create aliases of localhost, so not sure how you could get firewall issues in this case ;).

Indeed, the best though is probably to to present both methods. In Windows creating alias networks is not that easy.
What is 1024 * 1024?
Issue https://github.com/blackberry/BB10-WebWorks-Framework/issues/79 created
Is there a reason why we are using setter functions instead of just having it as a property?
Change to update