labofsahil/github-event-dataset-2012 huggingface dataset:
I guess we're changing this later?
Just the one `database.yml` will be fine.
Thanks for explaining how you did it.
Cherry-picked into libnet/master: couldn't merge, didn't want the unrelated libnet_build_icmpv6_echo().
@Ablu, those gabs have always been there (also in 0.5), though the inventory is reorganized (collapsing gabs) when switching maps. Also, when you pick up the item again before switching maps, it will take the empty space (which I believe indicates that there is also still a gap on the server side, but I'm not sure about this).

@Bertram25, please fix your commit message to talk about the inventory, not the equipment.
alle java errors kunnen worden gesmeten. web.xml vangt die af en stuurt je naar een error page
(lang leve de dynamische error pages)
Had dat dan ff laten weten dan had ik er ook even over na kunnen denken ;)
Dat ga ik dan nu alsnog wel doen
Ah crap, you're right. Other projects coding style :-/
Yay, merging with `master` works!
know what - let me remove the VERSION from the sub programs, and I'll restructure a bit more and we'll need only minimal compilation every time the version changes.

I'll have it soon.
Ah, thanks, I'll have a look and include any optimizations there.
Still it's not correct - Windows needs it this way to work for all versions:

    "JAVA_OPTS=%JAVA_OPTS% -Djboss.modules.lockless=true"

(note the initial quotes position)
呃……我只是把原文是bootscript的全改了……原文写的一样我实在区分不清……烦请指教
I think data need to be sorted along the group. 

Please see this commit. https://github.com/kohske/ggplot2/commit/ae7e66a9340fda9c4d9dc797b5ef493b102b5147
And the SO question: http://stackoverflow.com/questions/9161896/mismatching-colours-on-two-layers-ggplot2-v0-9

Now I have no time to write test case for this ...
The values for IBRD and FBRD where taken
from the fiasco bootstrap. But i'm already
on it to do a more clearly calculation of
them, according to the manuals.

On 01/09/2012 10:19 PM, Christian Helmuth wrote:
> Martin, you use IBRD=13 and FBRD=2 for the PL011. What is the baud rate you try to configure and how did you calculate these values. I've always been curious what would be the best values for 115200 on PBX-A9 - I use 13 and 1 (as u-boot does).
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/m-stein/genode/commit/6c236947964f8e9df682838cfb6931ebe7ab0b68#commitcomment-850995
no reason to use <= 100 when you're adding 2 each time
would be nice if you could save/reuse the same socket address used on line 100, just to make the code easier to change/update
@Th0ar 你先这样写吧：

```ruby
def one_to_org_notification(args)
  one_to_one_notification(args)
end
```

这样，以后加功能方便点，不用改太多调用的地方的东西。因为我相信在不久的将来两种通知可能就不一样了。
Leave a space between this line and the previous.
for example the function should look so, like this example: void DoSomething(int1, int2)
                                                                                     {
                                                                                         DoAnything();
                                                                                     }

not void DoSomething(int1, int2) {
in fact it's all useless without good Core
Codeimpossible's suggestion was to use Stringbuilder.Add and .AddFormat for readability.
I tested this approach instead.  Does it work?
I couldn't make the list comprehension work in the few seconds I dedicated to this. I think there's a couple examples of it around, but I think you'r right that we should add a mem3:lshards(DbName) or similar.
Well, danmar convinced me to add 'using %var%;' removal code, but I won't change the pattern matching in setVarId and getVariableList until you make a good point about disadvantages.
Hebrew*
Help needed here...
Currently on retail these spells ignore LoS.
Also there is a bug on Blade's Edge arena, when Warry in starting room can cast one shout, then hide behind a spike and cast another shout, thereby having 2 different shouts on him and his teammates.
I run my server in debugging mode and i see a lot of error like this : http://pastebin.com/tBNXRkNt
What it the problem ?
I guess the naming of listbuilder handlers in OMP rubbed off on me.  Will shorten.
feel free to send a PR
Arf, bien vu.
C'est normalement corrigé!
udah siap di fetch ni?
@schisamo - I thought that it would be pretty nice to have the example implemented as a simple class that would allow anyone to get started with em-winrm easily.  Thoughts?
Looks good, and has no side-effects for Grim, as far as I can see.
@bentruymen atm it's looking like FlashCanvas is being recommended over other polyfills in a lot of places. Would you prefer for more options to be mentioned or just that we note the limitations?
I also created a new branch for the development of the battery-plugin:
https://github.com/lnxbil/oh-my-zsh/commits/battery-plugin
[The original patch.](https://code.djangoproject.com/attachment/ticket/13323/applabel.diff)
should be Copyright (c) 2011-2012 by Frank Sautter <sautter.com> <= your email address - not just a domain
does this break a test?
mest
the file should be opened here only, in irc_con function. we will be giving the logfile name as <channel_name>-<date>.log. 
So the connection to the IRC server will be made only once, but bot is allowed to join any number of channels after that for logging, so those many files will be created when we connect to different channels.
No pude comentar en el anterior (archivo con el hermoso nombre "errordelorto"), pero en este paso de nuevo lo del git add .
Why `x-element` ?
82 characters!
this is part of a older version of tom's patch, can be removed
Quick note on Netty: These handlers get instantiated per request. If you want a stats map create it in the server factory and pass a reference of it to the class that needs it
Oh wow, my commit message for this is really bad.
<?xml version="1.0" encoding="UTF-8"?>
<feed xml:lang="en-US" xmlns:media="http://search.yahoo.com/mrss/" xmlns="http://www.w3.org/2005/Atom">
  <id>tag:github.com,2008:/amhnews/python-ipy/wiki</id>
  <link type="text/html" rel="alternate" href="/amhnews/python-ipy/wiki"/>
  <link type="application/atom+xml" rel="self" href="https://github.com/amhnews/python-ipy/wiki.atom"/>
  <title>python-ipy: Recent Wiki Updates</title>
</feed>
is_normalized -> normalized?
Indeed, I think you should just check each of these conditions one by one and give the appropriate error message. No need to fit this all into two lines ;-)
すみません、今直してコミットするところでしたが、
ありがとうございました。
Interesting. I hadn't noticed any issues with Emacs 24 (I'm running the snapshot at work) but at first blush the changes looks sensible to me. Any idea why the header has churned?
Har vi några test på denna kod i 2D? Det hade varit intressant att se!
Yeah, sry I forgot about that, I implemented additional dummy parameter in my repo to eliminate compiling problems without mmaps.
Yeah, same thing happened to me. I had to manually remove them from the commit. Weird.
So much delicious, delicious red. Ahhhh!
Hi Julien,

Just a question, why didn't you use the official PHP house-colors?
Landed on 33b7fc250f061af42b595decf6c0edf360c5aae9 thanks.
ㅎㅁㄴㅇㄹ
I also added all the fixes to get host gcc 4.6 to build, that way stock Ubuntu 11.10 toolchain can be used. 

changes in:
build
frameworks/compile/slang

then used 'master' repo from aosp, since they are already in those..
external/gtest
external/mesa3d
external/oprofile
I’m busy this weekend, but I’ll look at this next week.
A few questions:
* Is this a problem? What text in your template is causing munging?
* Why is there no "." after the XML prolog? I’m pretty sure that's not valid code there, if you're intended to prepend the XML prolog
* Does the XML prolog output? This will break browsers and CSS (quirks mode), so would have to be stripped on output
Note that you can use LoggerManager#pushLogListener and LoggerManager#popLogListener to isolate the log in the current thread without having to explicitely depends on logback.

But that's for all log so it depends if you potentially have other log. We could also extend the API to provide a specific class/logger to filter.
It isn't necessary to connect to the database here. The top level file api/index.php will open the connection when the user visits a page, call your code if necessary, and then close the connection when everything is done. All of these functions should assume the database is already taken care of.
Mmmm, fair point.  I think it's worth mentioning, though.  When you have E_ALL turned on, it means you have to do things like declare variables properly, not have unquoted strings, etc.  It catches a whole series of style issues.  Does that make sense?
technically this works now because no input currently has more than one flag (i.e. can't have both "sensitive" and "unready" on same input) but that could change in future. it may be better to say v.member?("unready") to future-proof it
The great debate... only the Buffered versions of IReadFrames and IWriteFrames will need to implement IDisposable. Took the approach where the main interface remains pure, but wonky EnsureDisposed extension method checks if type implements IDisposable and Disposes... would appreciate feedback on which is the lesser of two evils... force IReadFrames/IWriteFrames to implement IDisposable regardless or this...
How about another ([prerelease](http://docs.nuget.org/docs/Reference/Versioning)) upload to Nuget?
`(function($) { ... }(jQuery));` would be jshinit/jslint correct although everybody is using syntax you used above.
and +1 on removing `$.fn.render` at least it should have some more meaningful name, eg. `$.fn.ploneAsyncRender`

does somebody have a bad feeling when he sees javascript code inside python. i'm not talking small bits, but whole functions as here. its impossible to provide tests for them or lint them. i know that this is a problem of plone as a whole, but still new peaces of plone puzzle should be more modern, right?
The namespace was docbook, not d:
  xmlns:docbook="http://docbook.org/ns/docbook"
Ok. Yeah didn't think of that. We need to specify the version in the module and have setup.py import. There is a hack in the mongoengine code base that does this.
It's not really mine either, but Google is a good teacher...
What? Fixed? How? That could be a useful patch!
Oh you mean the missing files.... drat
What's the current status on this?  Is syntax highlighting working or?
Looks good to me. Please see a few minor comments.
I think we *do* want these things to open in overlays, we just don't want the page which is a *result* of action in the overlay to open in the overlay.  IOW, I like having the edit form in the overlay, but when I click save, the saved page shouldn't be loaded in the overlay.
Currently to move the entire tab (rectangle plus arrow) we set the coordinates of the container and it moves both without having to update them individually.  We need the reference to the container so that we can set X and Y attributes.
Doesn't it change the meaning of this test? It looks to me like code before fix would also pass it.
这个办法好～
In constructors, it is usually a good idea to assert that arguments are not null (if they are required), e.g.

assert parser != null;
this.parser = parser;
Ah, it was introduced in 2.3.9. I'll update the gemspec to require that as a minimum.
Could parameter to have shorter name?
Why? Really, R U Yoda? It gives **no** magic performance.
changes because of Box2d 2.2.1
Note to self, using std::string with printf("%s", theString); == Weird characters!
これはすぐ下で==しているので必要無いです。
むしろ、これはない方がよいです。
もし、@terms.sizeが2でここで失敗してしまったら「@termsの数が違った」という情報しか残らなくてどのtermが少なかったかがわかりません。

すぐ下の==で失敗するとどのtermが少なかったかまでわかります。
なので、これはない方がよいと思います。
Thank you, this is wonderful.
This is where the secret sauce happens for XML Parsing. It was a _lot_ of effort to figure it out, it should be pretty copypasta easy to implement this for other methods.
This cannot be done right ... 
Now you will have whitespaces in every enum and struct this is not the right way
Fixed in ef3e8f9
Bob.json? I never heard of that!!!
I like the explicitness of an empty array. When I read through the thing, once I find it and see empty set I can stop reading. Otherwise, I have to read /everything/ to ensure that it does not appear.

But I'm not married to this.
@lucas95 : WTF ??? Lucas t'as fait que supprimer le code de lecture ...
Some know issues:
Running multiple instances of the game at the same time may give save incorrect values. I.e. if the player unlocked achievement 1 in one window and shortly after that unlocked achievement 2 in another, only the unlocking of achievement 2 will be registered.
If the achievement definition change, the save will forget unlocks that are no longer defined.
breaks the delta = 1 => 0 rule (a delta of 1 when there is a history, should be ignored)
I have been writing Erlang for so long that every other language looks like line noise to me. I can get the PHP running on the command line easy enough so I went with that.
remove vib/cap/galaxys/schi500
*currentRound.
This patch wasn't applied to master - is it intentional?
I actually don't know if it makes sense to support decimals at all. If you think we should not support them, feel free to drop that feature from MongoDB Engine.
if successful exec should return child PID
Looks quite beautiful and easy to understand.
Comparing the three I think it works better with the username at the start. I have made that change.
Are you sure this is a bad idea? Or might ping requests be resent?
Thanks for that. Another one I use is git ls-files -d to show me if there are any files in the repo that I haven't yet trashed.
Yeah, I can write up a draft of a post discussing those two posts.
It would probably be sufficient to see if `.keys` and `.values` are present rather than seeing if they inherit from `Mapping`. It would also help in the unlikely event that someone creates a dict-like object that doesn't inherit from `Mapping`.
well, this creates problems with the tablet tweaks softbutton overlay.
they're stretched and way to large now.
What he means is on startup you get this error: 


[ERROR]: In mysql_stmt_prepare() id: 97, sql: "INSERT INTO guild (guildid, name, leaderguid, info, motd, createdate, EmblemStyle, EmblemColor, BorderStyle, BorderColor, BackgroundColor, BankMoney, xp, m_today_xp, m_xp_cap, level) VALUES(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)"
[ERROR]: Unknown column 'xp' in 'field list'
[ERROR]: In mysql_stmt_prepare() id: 130, sql: "UPDATE guild SET xp = ?, m_today_xp= ?, m_xp_cap = ?, level = ? WHERE guildid = ?"
[ERROR]: Unknown column 'xp' in 'field list'
is it possible to not hardcode the version of sl4fj?
Have you tried something like [that](https://github.com/kevinpollet/infinispan/blob/master/cdi/extension/src/test/java/org/infinispan/cdi/test/testutil/Deployments.java#L66).
Prefiro let :)
Views para criação ou Sign_up de Aluno ou Professor, não foram configuradas, não é algo urgente no momento, pelo menos pra mim
I don't own this device and stumbled upon this conversation by accident, but the "#undef COMBO_DEVICE_SUPPORTED" comment actually does make sense.

Line 40:
#define COMBO_DEVICE_SUPPORTED 0

Line 1346:
#ifdef COMBO_DEVICE_SUPPORTED

The "#ifdef" is only checking if the token has been defined - it doesn't matter if it's defined as "0" or "false" - it's still defined. I only noticed this recently when I noticed my unofficial galaxy5/tass ports were using parts of the combo code unexpectedly. 
Line 1346 should really be: "#if COMBO_DEVICE_SUPPORTED".
Stuff marked with the other initial commit in this gingerbread branch are ok anyway.
I may be wrong but I don't this works in CSS files - you'd need to make a separate ie.css and link it from the pages inside this comment in the HTML.
Что делает этот блок кода?
no worries, you're the boss
* The user of the method can be confused about the additional keyword. In my opinion the interface should be as clear as possible.
* The const keyword in the expression ```foo (const size_t i)``` limits the ability to reuse the *copy* of the variable. As a programmer I do not like to be limited if I can not destroy external things. The "accident" has no side effects outside of the function/method.
Ah, yes. It would be better to use whatever VCR uses to check if the
cassette exists before creating a file and writing to it. Could you point
me to the right direction?

I'm basically changing a sleep to be longer if the cassette *does not*
exist (it makes an API call out and waits some time if the thing it's
trying to get isn't ready). The tests are much longer without being able to
check.

On Friday, December 7, 2012, Myron Marston wrote:

> In lib/vcr.rb:
>
> > @@ -172,6 +172,17 @@ def use_cassette(name, options = {}, &block)
> >      end
> >    end
> >
> > +  # Checks if a cassette exists in the cassette library directory.
> > +  #
> > +  # @example
> > +  #   VCR.cassette_exists?('my_cassette_name')
> > +  #
> > +  # @return boolean
> > +  def cassette_exists?(name)
> > +    file_path = File.join(self.configuration.cassette_library_dir, "#{name}.yml")
> > +    File.exists? file_path
> > +  end
>
> This doesn't handle a case like
> VCR.cassette_exists?(an_unsanitized_string). VCR sanitized cassette names<https://github.com/vcr/vcr/blob/master/lib/vcr/cassette/persisters/file_system.rb#L52-L56>before converting them to file names, and I think the same logic should be
> used here.
>
> Maybe it could use this helper method<https://github.com/vcr/vcr/blob/master/lib/vcr/cassette/persisters/file_system.rb#L41-L44>
> ?
>
> I'm also not sure it belongs here off of the top-level VCR object.
> Historically, VCR always persisted cassettes to the file system but 2.2
> added support for swappable persisters, so users could flexibly persist
> cassettes to any medium. Adding another top level method that assumes VCR
> is persisting to the file system goes against that direction a bit. How are
> you using this?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/vcr/vcr/pull/232/files#r2345553>.
>
>


-- 
Ramon Tayag
also, not crazy about passing in a custom selector for every add event function - seems like that would encourage some horrible design. Let's just have the setSelectorEngine method.
I just checked again.  this test passed for me in our current code.  it's only if I also added the fix to create the temp_path that it fails. `ProcResult.assert_no_temp` doesn't do anything if the temp_path doesn't exist.
https://bitbucket.org/ianb/scripttest/src/20b9deb75e97/scripttest/__init__.py#cl-414
Because I am fixing a TOCTOU[0] bug here. If you did a os.path.isdir(path) that would would stil be vulnerable. [0] http://en.wikipedia.org/wiki/Time_of_check_to_time_of_use
I'd like to see this as a method on `pip.tests.test_pip.TestPipEnvironment`
so,  in any  test, you could just do env.get_pkg_version(pkg_name)
the method could raise an exception if the version reported by pkg_resources is not consistent with the egg dirs in the env
`env.site_packages / 'INITools-%s-py%s.egg-info' % (pkg_version, pyversion)`
I'll do whatever we agree on w/r/t code conventions, but I'm -1 on this.  The dictionary definition of override is at odds with the use in an interface or abstract method implementation; there's no existing implementation to override.  Moreover, my IDE displays a visual difference between an implemented interface or abstract method and an overridden method for which there is an existing implementation.
import SupervisorStrategy.{ Stop, Resume } above and use Stop and Resume individually, since that is how we want people to write it
Always place constants in objects and not in classes, it's good style to do so since it doesn't add a field for every instance. (In this case the number of instances will be few/one but it's how we do it)
is this mutable?
The reasoning behind FiniteDuration is that you can then statically be sure that .toMillis will not barf, which is a piece of information which I would like to keep. Unfortunately we have used plain Duration in places where it is not so good, leading to runtime errors for infinite timeouts, for example, but that does not mean that we cannot fix it. In order to do this in a nice way, producers as well as consumers of Duration values need to be changed.
So the code that is removed (or rather the comments) are related to the removed `kill` method (which was commented out) in the `Conductor`. It fills no purpose since we right now can't `kill` a remote node from within the conductor but only tell that JVM to exit nicely.

Maybe it will be added in the future, but right now exit seems to be enough.

What happened was that if you sent a negative exit code it was ignored. Not what you would have expected.
what about re-throwing InterruptedException?
Need to beat the Java/C/C++ remains out of you...
Have you tried this from Java code?
I think there is a surprise when extending a `trait`. In all other places where we have `getInstance` we extend and abstract class (for this reason).
Why a Settings for each FaultTolerantChannelActor?
this would better be done as

    getInt("...") ensuring (_ > 0, "... must be ...")
don't want any of these
The refactored code with this moved above is the same as this.  I think that 'failed_login' does the form, no?  If  you fail a login, it just puts up another login.  What is wrong is that it says "Wrong password" when you first arrive maybe.  We could fix that.
Okay this change the function to binary output. I am happy to do this.
Maybe fmin should be default?  That way one does not have to specify gradients.
Nothing happens. You just pass the data as it is to the fit. Or am I
missing something?


On Wed, Dec 5, 2012 at 11:35 AM, MrBago <notifications@github.com> wrote:

> In dipy/reconst/dti.py:
>
> >
> > +        params_in_mask = self.fit_method(self.design_matrix, data_in_mask,
> > +                                         *self.args, **self.kwargs)
> > +
> > +        dti_params = np.zeros(data.shape[:-1] + (12,))
> > +
> > +        dti_params[mask,:] = params_in_mask
>
> What happens here when mask in None?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/nipy/dipy/pull/96/files#r2325611>.
>
>
the thing with a dict is we would have to do the work for each item, but we could do them as functions and that would work so yeah seems doable.
This file really very helpful in ensuring that people get their datastore database set up securely.  :-)

To make it even easier, I think a  paster command that read the `ckan.datastore_write_url` and `ckan.datastore_read_url` from the config file; and then ran the above SQL with those settings be really useful.  Not having it would not prevent the merge though, just a nice-to-have if there's time.
Is this something you still need to address?
This and the other place we return None feels like a bad state to be in. In _map, it's mapped to ERROR. That might be the way we want to handle it from the user's perspective, but I feel like it's a much more dangerous error than simply the plugin raised an error. Maybe a log message warning that we were in some sort of really awkward state that a task didn't exist so that we're not hiding the fact that this was executing outside of a task and confusing it with a plugin error.
``s/qualifed/qualified``

And where is ``self.qualifedtags`` initialised?
Yes, more readable. I'll change.
Yes, my modified version uses RhinoScriptBuilder. Is there a way to use [CommonJS](http://www.angrycoding.com/2011/09/mozilla-rhino-commonjs-module-support.html) at the moment? Maybe I can try your 1.7R3 branch.
That would be quite handy, but doing that later seems better.
Yes, the debug code was very extensive... and not properly indented.
Compile error...
@is_pending ||= true
Je ne le faisait pas parce que le fichier est dans public et que javascript_include_tag cherche dans assets pour les paths relatifs (sans / au début). 

Dans mon dernier commit, j'ai mis le path absolu et ça marche.
I kept this one because there was some commented in the end of the file. I was not sure if it was going to be used soon or late. :)
Again, move to a macro to perform all free'ing?
Just for curiosity, why the unless check?
The call to error creates an x => Error(x) closure which apparently infers Any somewhere if there is no value.  Since the type is not actually accomplishing anything I threw Any in there.  There may be a better way to suppress the warning - the scalap code is not my favorite to work on.
Definitely. Any suggestions?
fair 'nuff
Just a small note here (I'll fix it up in the commit) but you still say "capture" here when I think you mean "void"
It says return the coset representation of "an element", but there is no argument to specify the element ...
Yes, it 'll be easier to do the final cleanup if we don't have to worry about bitrot.
Put a space after the :
These both need asserts. Also, since these are themselves True, you can drop the ``== True``.
This function is huge and scares me.  Can it be factored down or simplified at all?
I'm actually not sure what should be a @property and what shouldn't.  Maybe @rlamy can comment.  The main thing I know is that they shouldn't have unexpected side effects.  I'm not sure if computation time counts for that, or if so, to what degree.  I do know that seeing `()` after an `.is_` is somewhat unexpected.
the equivalent of html is innerHTML, not appendChild.
I've moved the logic to an event listener now.
The serializer component is not always required. But it is required to execute the test suite of Silex.
Can you please fix the indentation on these lines ([tabs, not spaces](https://github.com/github/objective-c-conventions#whitespace)) and also change this condition to be an [explicit comparison](https://github.com/github/objective-c-conventions#expressions) against `nil`?
Could you move the `@implementation` to where the others are in this file? Cheers.
2 usages. The reason is that I chose to implement two concerns (is something a refinement of another, and apply a refinement to something) in the one class, simply because the two concerns have a lot of natural coupling.  I considered the possibility of refactoring this to maybeApplyRefinement, which explicitly brings the two concerns into one implementation, and would therefore only have one point of interaction between the classes.  For now, I'd prefer to minimise the patch. Thoughts?
file system/operating system dependent.
Also found that this comment must not come before the {% extends %} tag. Gonna fix that, too.
Well, internally they're lists. But, on a QueryDict, [`get` should return a single item and `getlist` should return multiple items](https://docs.djangoproject.com/en/1.2/ref/request-response/#querydict-objects).
I initially developed it to be run when all documents were already migrated, but it was painful to manually migrate the parent docs and child docs and then run --language-rels.

So, --language-rels operates on the docs specified in the other options. --all --language-rels would migrate all docs AND create language relations, but then you can also do --withlanguages=100 --language-rels to do just 100 pages with translations and create the translation relationships.

For a full "real" migration it would be --all --language-rels.

For an incremental migration it would be --recent=50 --language-rels.
More than 80 chars.
Tout non-fluide: excellent. 

Effectivement c'est une question de goût! Et fais-toi en pas, c'est pas parce que je préfère le fluid qu'on doit aller en fluid. C'est toi le boss du site web!
Chef::Resource::File => Chef::ResourceRegistryKey ?
Can't we just use a full class name for the item type and make all of this a whole lot simpler?
It's only an out parameter. The layout is just array('entry1', 'entry2', ...)
> What was module_basename previously?

The empty string

> Why is only ucp_pm changed?

With this change, to make the inbox appear at the top, no other changes are required.
I will disagree with this and especially here. If there is an actual use case this is addressing please spell it out.
should have spaces after the comma (sorry the old code didn't)
first parameter here is confusing. Maybe say the supplied variable name.
@jeanphix any reason why you changed this line from I think ``if len(queue_names) > 1:`` to ``if len(queue_names) > 1:`` in [this commit](https://github.com/jeanphix/django-rq/commit/69b353e90fcbe3c235b26a5f264a929a926401bd)?

We only need to check for different connections when creating a ``Worker`` for multiple queues.
Oh sorry, I didn't see that `getYUIModuleResources()` was returning fake resources.  Yeah, it's fine as is.
I don't believe any of the changes in this file are related to the issue that the pull request addresses?
Unfortunately, it is necessary, as $sourceRoot is not an absolute path.
Ok, I'll try this again.
Though the 'operator after not before' is **not** strictly a PEP8 issue, as far as I can see,
At least, all of these pass the pep8 tester module happily ...
```
test1 = (a and
         b and
         c and
         d)

test2 = (a
         and b
         and c
         and d)

test3 = (a
         and b
         and c
         and d
         )

test4 = (
    a
    and b
    and c and
    d
)
```
The last one being particularly hideous !
*cough* PEP8
:-P
I might be mistaken, but can't we avoid the transpose by making gz the first argument?

ie,
gz_axes = range(gz.ndim-y.ndim+1, gz.ndim)
y_axes = [ ax for ax in xrange(y.ndim) if ax != y.ndim -2 ]
gx = tensordot(gz, y, axes = [ gz_axes, y_axes] )

Did I make a mistake in this derivation?
http://imgur.com/lX16l
I don't get it, ``self.props()`` is an empty tuple. What about ``self.UPLO``, shouldn't it be taken into account in ``__eq__`` / ``__hash__``?
Ordering by ``('last_name', 'first_name')`` will be more intuitive.
Unless I need to match in the function head to differ between clauses, I pull out what I need from on the line below.  This means that when I look at the function clauses, only what is needed for the clause to match is there, and the line is shorter.

eg: if I needed to test if the monitor list was a certain length, the match would be in the head. Since I don't, I went for a shorted function head declaration.
Надо тогда в остальных примерах тоже поправить — я копипастил :)
yup. the idea was to select widely within each zone, and the usorted output of the combination would be complete, with local zones preferred as they're first.
CID 751862 (#1 of 1): Unused pointer value (UNUSED_VALUE)
Pointer "link" returned by "g_list_remove_link(list, link)" is never used
Drop the parens and put this all on one line.
`self.connection` is connected to original database (eg: `myproject`), while here we need to create the extension on the test db ((eg: `test_myproject`), which is a different database.
Yeah, I'm not particularly a fan of it either. We could test to make sure innerHeight exists or something, but at that point we're going all the way around our elbow to get to our pinky. And it still really means the same thing. :/
Use text_to_cstring
We keep checking whether the operation was performed, this waiting times out after 5 seconds. This is necessary to not hang on an "directory is not empty" exception later on. Works quite well!
I just noticed you added this. How does this fix anything? this.NavZone is still null and thus it's still gonna throw the null ref error in the ctor. And even if didn't crash, disconnecting clients isn't really any better than crashing.

I've been running into this error a lot myself though and it's pretty damn annoying, since noone really knows how to fix it I'm gonna put a hack into WorldGenerator that avoids making bad scenes, hopefully without breaking anything else.
I copied it verbatim from kitsune. It's not pretty, but bash generally isn't pretty, so I didn't spend any time tidying it up.
The name change is because if I `import json` and then try and use
`json.dumps`, it tries to call the method `dumps` on the function being
defined, since it is also named `json`. This might just be a case of poor
naming, but I think this name makes the most sense for the template filter.

On Tue, Sep 11, 2012 at 6:48 AM, Will Kahn-Greene
<notifications@github.com>wrote:

> In fjord/base/helpers.py:
>
> > +def json_handle_datetime(obj):
> > +    """Convert a datetime obj to a number of milliseconds since the epoch.
> > +
> > +    This uses milliseconds since this is probably going to be used to feed JS,
> > +    and JS timestamps use milliseconds.
> > +
> > +    """
> > +    try:
> > +        return time.mktime(obj.timetuple()) * 1000
> > +    except AttributeError:
> > +        return obj
> > +
> > +
> > +@register.filter
> > +def json(data):
> > +    return json_dumps(data, default=json_handle_datetime)
>
> I'm not sure why the name change here is helpful. Seems better to just import
> json and then call json.dumps. Amongst other things, someone like me
> doesn't have to look at this and wonder if this is a wrapper or something
> and then have to trace where json_dumps is defined.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mozilla/fjord/pull/24/files#r1576505>.
>
>
This docstring is begging for an example of the returned data structure - it's not obvious
On 10.8+ we don't require X11 just to get libpng, so use the `:libpng` dep here which encapsulates that conditional.
Should use `build.include? 'with-pgm'`.
For Python 3.x I will use this suggestions. 
However, there will be no Python 2.8. It's a dead end.
Should probably be `depends_on :automake` (and `depends_on :autoconf`) so that they aren't installed on Pre-Xcode 4.3 systems that already have autotools
hum, un !contains c'est plus jolie non? :-)
We probably want to rename this to `self.redis`
[Example from Basho](http://docs.basho.com/riak/latest/tutorials/Secondary-Indexes---Examples/) use `", "`. Happy to keep it like that but I'd be surprised if it made a difference.
Ну и перевод :)
1. "Многие разработчики Git-а осуществляют свой рабочий процесс в соответствии с этой идеей"
2. "У них есть другая параллельная ветка с именем develop (разработка) или next (следующая), на основе которой осуществляется разработка, и её же используют для тестирования стабильности"
3. "Её используют для вливания изменений из коротких веток по мере их готовности, чтобы удостовериться, что они успешно проходят все тесты и не вызывают ошибок."
diese neue notation ist super!
I did not think priorities would be useful, or that we should encourage users to rely on contracts priorities.
Especially since for some hooks (pre_process comes into mind) the last contract hooked in is the first one to be executed.
Needs period at end.
[ncrunch](http://www.ncrunch.net/) solution files are of value for those that use ncrunch, much like resharper .dotsettings would be. Other than that, PR looks good to go.
What is 3.8.2 doing here?
I can of course limit the ways when interrupted code. Yes, maybe it's too much.
I did a search for all markStarts and didn't see a case where the addMeasurement wasn't reachable in the same closure.

I see the argument for making this lightweight and having less clutter, but in the end you're still keeping a variable in scope to hold the generated name returned by markStart, so we haven't avoided the clutter issue you mentioned.

Eventually yes, I agree we'll have perf tests that won't be in the same closure and/or module and you'll need some global identifier.

The more I think about it, maybe we shouldn't uses vars like fullPath in our performance markers in the first place. Just thinking out loud, but maybe other uniquely identifying arg can be passed separately.

Anyhow, I won't hold up merging this pull request over this particular issue. There's a few other jslint issues I found though.
You can replace the entire if statement (and else if) with ``s = s.replace(/^(text\/|application\/)/, "");``
The hintProviders object members (indexes?) are modes, so I think this code would be more clear if "providerName" was changed to "modeName".
Can't here
because the `apfhook.js` and `sources.js` are listening to that
Those modules should be decoupled
should this block still be in the js-inline block? (not sure answer is yes, just checking)
I think we can remove `el-get-sanitize` and write the code directly in `el-get`.  The function name `sanitize` is unclear what it is for and the function body itself is quite short.  So I think removing it makes the code cleaner.
I think this should be `lineend = NULL`. While you're at it, could you fix the spacing for `arrow=NULL`?
Do you want all clips to fail together, or would there be a benefit to letting them fail individually? Throwing away the exception altogether isn't normally recommended, either.
Shouldn't `version` always be a version?

For `other.version`, can you double check that `Version.new(Version.new("1.2.3"))` returns the same instance.
Add empty line before and after *load* block.
I checked editor doesn't change the case or returns fields back.
I just want to compare with all the information available. If limit is datetime and value is datetime, then also hours and minutes should be compared. Otherwise only date.
Lint is complaining about this line:
```
src/editor/trackevent-editor.js: line 238, col 6, Missing semicolon.

1 error
```
This is just because there's a border on the top, and I don't want the tab to look cut-off when it's expanded
Do you want to base this off of something else, or make the colour a global somewhere? Seems like something tweakable enough that fishing through LESS/CSS would be a pain.
This can be removed with fixes above.  Also, don't return non-number.
Needs description of what this is looking for.
Undo removing this line.
This is example is off.  Should be `enable-plugin`.  Same for `disable-plugin` above.
Well, I didn't intended to use String, XML, Reflection and other utils as extension methods at the beginning. Extension methods are a little bit away from my style of coding. Anyway, this is a fine addition. When introducing other utils I would think twice about making them extension methods or not.
Please add copyright headers to new source files.
Makes sense.  Although my use case never gives an empty list, I can imagine it's convenient to be able to do so harmlessly.  Fixed on 600fec4.
Fixed in 88e3a8.
I've added d_fd to cdb.hh and closing that. I wanted to get away with not having that integer but there's no point in optimizing and making code unclear to read.
Permission are correct. /var/www/html/ and katello and foreman are symlinks (with 777)
typo - contaion
no, intentional, you have to stir the memory to obtain the megabytes

(sorry, should not submit end of day pull requests)
Either works one works fine; therefore, going to leave 'as is' for now since the code does use the 'opposite' check (unless @next_environment) later in the code and using the same 'unless' construct makes it very obvious the difference in the conditions.
expires = 0
Recreating an ordered list of every request is wasteful. Let's assume the filters are ordered.
But what if I have a catalog of 10^7 sources, is it realistic to cache the transformation?
this sould be ``warning``, not ``warn`` - right now it (ironically) gives a sphinx warning that it doesn't recognize the directive.
nope, both unwise and not allowed except  to collapse package namespaces (e.g., in ``__init__.py`` files). In this case, it didn't matter, because this wasn't actually being used, but I removed it just so no one gets ideas.  

 (@demitri, FYI)
I feel like `current_user.bookmark(@video)` should create a bookmark, not check if one exists.
The "stale trumps RYW" logic would be relevant here as well, right?
Yes, that's right, so I followed the pattern of Window, DockPane, etc.

I copied the name "central widget" from Window, happy to call it something else.
Yeah, got that, but what's the point in calling checkSimulation if there's no simulation?!
Again, maybe `excute_cell_magic` or perhaps `run`.
I think we need a different annotation to make the intention clear.
inattentive commenting, I'll fix this
because the player position depends on the frameset rows.
I guess we could detect the style we need to append but it wouldn't be accurate. That's why we have the ability to pass the style.

Maybe a better solution would be something like this:
1. Detect if were in frame, and the parent has "frameset" element.
2. If the iOS version is lower then iOS 5, add class "framesetFix"

The parent page could set the styling for ".framesetFix" class
What do you think?
you want to reset results back to empty here.
what's with these brackets?
can't you just do:

```python
def new_ooids(self):
     return self.store.iterkeys()
```

I know it doesn't actually matter but you're a generator/iterator geek at heart so you might want the neat pythonic ones in your code.
Makes sense, looks like there is an upgrade method in this file, would that be the best place to do it?  Still relatively new to Pyro and OSS contribs.  I just don't want to make a migration convoluted by trying to implement it somewhere stupid.  Thank you for your feedback, very helpful :)
Can you wrap this with `{` and `{`? If it's a multi-line `if` we like to be explicit.
inline this?
на видалення добавлю ще одну функцію listener preDelete і буду відписувати їх. Так?
no, not necessarily.
why ``echo`` ? the way to output something to the console is to use ``$output``
no, it was just to be sure.

but this should be documented as a deprecated feature then
コメントありがとうございます。
指摘してもらった記述の方が、前提・検証対象・検証と分かりやすいですね。

＞櫻井さん
サイトの紹介ありがとうございます。
見ておきます！
is that resubmission rather than re submission?
the isEqual will return false if that is the case, as per the overriden isEqual method in CPVenue.

if `[VenueInfoViewController onScreenVenueVC]` is nil then its venue will also be nil (I think ... confirming this now).
@chambbj any way to avoid looping over all of the points? This makes the point size update quite slow, wheras this is a quick operation in **master**.
To test what happens if someone is not patient and includes the same changes in multiple pull requests :)
This is my clever attempt at generalizing a sorted HTML construct
putting a number as default value would require changing the way the default is applied, as using ``||`` would forbid forcing ``false`` as value.
So there's both the "list-active-jsf-impls" op and the attribute?
Right, or at least that's what we were trying :)
Makes sense, was thinkging about that since we added an attribute that checks if it's loaded or not.

Will do, thanks!
Why is this a footer?
Done. Thanks for the tip! Now it's more easy to read.
Wow, that's a huge thing .. .still don't know how phone numbers will be stored, or normalized ... :)
no, this is fine I just wanted to clarify that but please remove the node comment.
nit: add a name to your anonymous function (it will appears in the console.log output)
Don't you prefer concatenating with Array?
can't we avoid those Javascript changes with a well placed `pointer-event:none` ?
I would like to not have any specific e.me code lurking in the rest of the js code. I have done a counter proposal here: https://github.com/mozilla-b2g/gaia/pull/5431

The proposal makes all pages to display: none at startup except the current page and Ev.me wait for the first page to be loaded before doing anything else.
What about device orientation changes though, a landscape viewport could accomodate more text than a portrait viewport? A cached width would be wrong then.
Let's move that to the top of the function if it is a webapps-registry-ready event so it is easy to see it.
I am afraid that listening for the `load` event won't work anymore. Apart from loading `this._popup` we need to be sure that the handler of the messages is properly set up before start sending any message. I might try with `DOMContentLoaded` instead, but I would feel more secure having the custom event.
Heh took me a second to get that, I would prefer we didnt couple this directly to the dom of the thumbnail container though, can we just walk back until we find the name, something like

    var node = evt.target;
    var found = false;
    while (!found && node) { 
      if (node.dataset.name) { 
        found = true;
      } else { 
        node = node.parentNode;
      }
    }

anything that will survive us changing the contents of dom.thumbnails
Where do you use this shortcuts? I mean, is stringify necessary ?
For clarity, this is not an indication I want it to be changed now, just re-iterating my dislike. :)
いくつかのオプションはデフォルト値をもち、他はあなたに選択させるでしょう。

→

   いくつかのオプションはデフォルト値をもち、その他については選択肢が表示されます。
I don't think we need to introduce this dependancy to make this patch.

Conformist doesn't depend explicitly on a CSV parsing library, just an array-of-array-like data structure. The less assumptions we make about the way the library is being used, the more widely it can be adopted.

Would you mind reversing this change?
it was broken since the result was something like this:
{struct, [{source, ...}, ... , {struct, [{records ...]}]}.

this meant that struct became the key, instead of records
Yeah I am working on that and making it more "test" friendly basically I pushed it too early ;)
Only 1 of them can exist.

Barring reflection, it is not possible to instantiate BAAOpenInProgress, since the default constructor is private.
just the style in which the message is displayed... hmm
I think here using
``` if not isinstance(parent, QtreeNode): ```
is enough.
Note: Not sure where the above came in from (maybe a rebase).  Need help confirming all the above settings should have been removed.
Does this mean `%(src:revision)s` is OK, or does "omitted" mean "left empty" (so `%(src::revisoin)s`)?
That is why I would propose to have buildernameid, and masternameid to be "identifier strings" that must match regex like "[a-z0-9\-_]+"
It might become idiomatic, in which case yes -- we'll see if it's useful anywhere else.  The stuff in buildbot.data.changes will hopefully go away once some other DB migrations go in, but is otherwise similar.  I'll add something to `README.md`.
I'll look into this. I faintly remember considering and excluding this, but I'll try again since I don't remember exactly.
Using WIN here to call WIN.less in CLI fucntion
I didn't change anything on purpose. These references must have changed somewhere else.

I merged upstream and ran `./composer.phar update` to ensure the latest deps are installed and my tests run – and this is what the update did.

Any idea how to resolve it? (cc @Seldaek )
You might want to wait for the `exit` event before changing `killed` to `true`
I sent a new pull
just one letter!
I just followed steps from https://github.com/holman/feedback/issues/191 .

Must thanks the github guys.
Yes this string is very specific to this slot and only when it's empty, the jey to this is the x55 bit.
I don't like this reuse of fp as it confuses me wrt what the error cases below actually close.
Right, but as soon as it finds one that does not match at all it quits.  If you were doing a `/hello/` and you had the following items in a `Table`:
*  This would match because hello is in it
*  helllllllllo
*  hello2

It would only find the first one (rather than the 1st and the 3rd), correct?  I'm sorry if I'm being obtuse about this, I just didn't know how to get this to check all of them, and not quit once something did not match.
> The main reason to wrap all exposed functions into lambda is described in the comments for lambda function. 

Oops it looks like I forgot to write those comments :) I will make sure to add those.
Maybe we can use either `getTabs` from [tab/utils](https://github.com/mozilla/addon-sdk/blob/master/packages/api-utils/lib/tabs/utils.js#L20) or modify it to be compatible with fennec.
this was manually removed from include.js, because it's the open-ee side of winchan, which is not needed in include.js

it is a hokey way to partially include a different project, but why add it back in this patch?
browser does not exist in this context, _parentWindow is on self at this point. This is causing a silent failure where all of the tests appear to pass but where all the tests continue running on sauce.
Note: We might want to minify this before we ship it.
I would add a custom attribute to each of the elements which support a tooltip instead. Defining a hard-coded list is way hard to maintain.