labofsahil/github-event-dataset-2012 huggingface dataset:
as i said its just a conversion of what was already there. there must be a reason why it was done the way it was done
лучше использовать factory для создания записи в БД
Chop out the convenience methods, and cut v2.0!
the spout manager has a bug: if a material is present, it will delete it, so you have to reconnect to see it. totaly weird.
use git cherry-pick to pick patches & avoid having to edit any code yourself - saves typos.

git remote add john git://github.com/John-Kenney/zte-turies-35.git
git fetch john
git cherry-pick ef1eaa958bd133552a963527dac3165a75818f5c

would add the patch. after you've added it as a remote repo & fetched it, you can just cherry-pick individual patches, or merge to get all of them. 'git status' tells you about any errors.
44545 is entry for heroic mode of 43438 and can not have ScriptName, need to be removed.
fixed in commit 6cfcbfbe58759aeb5f09fc4c0c50c5b601ccf366 thanks for pointing it out ;)
Checked and agree. Reviewed
I'm sure you didn't mean to copy the contents of Assessment360Controller into a fixture. Was that fixture supposed to have fixture content though?
Well actually, it's correct in that sense that it's the content that was "processed by collectstatic". An no, I don't think that "munge" is a nice word for it :P
Alright. For a moment, I was afraid my turning off of explicit C-ordering for sparse arrays had been a bad idea :)
Es ist so, dass man bei Twitter Apps, denen man Lese-/Schreibzugriff auf den eigenen Account einräumt, explizit die Rechte dazu geben muss. Dafür authentifiziert sich jede App eben mit dem Consumer Key und dem passenden Secret. Das ganze nennt sich dann OAuth und weder bin ich Experte, noch gehört das hierhin. Mehr Informationen dazu findet man aber hier: https://dev.twitter.com/docs/auth/oauth
Ich denke, dass jeder der es Nutzen will, sich eh gut genug mit Twitter auskennen muss um bei den Schlagwörtern "Consumer Key" und "Consumer Secret" zu wissen, was einzugeben muss. Eine detailiertere Erklärung kann man sich imho an dieser Stelle sparen, die sollte besser ins Manual. Der Text in der englischen Originalversion ist zwar länger, aber auch nicht wirklich hilfreicher, eher verwirren. Ok?
Yeah, I'll have a think about how best to achieve that - btw, the framework currently doesn't (shouldn't!) mind if a widget changes size each time it updates - I did think about making the "row" be a widget in itself that contains other widgets, then we could have custom rows that can handle "cropping" their contents in different ways.

My changes basically already do two passes - UpdateWidgetPages does the measurement and bucketing, so it wouldn't take much to have a flag in the widget interface to allow for widgets to be told how much space they have, rather than stating their size.
i dont know. possible bug in my f@kin internet. im fix soon.
Heh, since you already reverted it - keep it that way and be VERY careful about messing with it!  :)

I tried making this a user-controllable option - after all "maximizing power management" seems tempting - but it actually caused the wifi chip to wake the CPU all the time, causing major battery drain.
Blended with https://github.com/silverstripe-big-o/sapphire/commit/6433ddcc34e95b0cf92d278ec3ccc6cd838c6cdb commit?
How do I get the count of items that are a many to many child of a resultset??
`os` isn't imported, so this prevents the package from being installed.
That should work.
On Feb 23, 2012 10:34 PM, "danlangridge" <
reply@reply.github.com>
wrote:

> Is it necessary to use a BufferedReader? we are only trying to retrieve
> count bytes and Openfile.read() should store the additional bytes for you
> in buff and return the # of bytes read in.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/paranoiacblack/Obfuscated-OS/commit/aee193f26a8723cab7e90b09404c47675da74e15#commitcomment-1005877
>
Aca puede llegar a haber un bardo si el dia de mañana deciden implementar locks en las funciones. Ponele que no le pongan un lock a filter ya que la función es básicamente una llamada al iterate. Pero dentro del iterate esta llamando al add que ese va a volver a tratar de tomar el lock y va a quedar todo lockeado.
En estas circunstancias quizás la mejor opción es hacer un _list_iterate que no tenga locks y sea llamado por el list_iterate. Y todas las funciones internas de list usen el _list_iterate o a lo mejor solo en los casos donde sea necesario.
BUG: KeyEvent.keyCodeFromString method returns KeyEvent.KEYCODE_UNKNOWN=0 *not* -1, and as a result the last ditch effort in MonkeySourceNetwork.getKeyCode will never be executed.

As a result, IChimpDevice.press(PhysicalButton...) fails for all the DPAD keys: PhysicalButton.DPAD_*.
Leave spacing as-is.
well, i agree with you to some point.

a functional hd preset would definately ease testing possible encoding capabilities.
although, a stuttery preset is not what we should have in mind for the end user; imagine a situation where you want to quickrecord something and accidentially use the (at this point very laggy) hd preset, you would end up having a bad recording which is not fun to view.

what i suggest now, is that we temporary disable the "hd" preset and reset the "high" preset to w800 instead of w720. that way the hd preset could easily be reenabled when true hd recording is possible on leo.

for testing one would only need to copy over another version of media_profiles in which the hd preset is enabled.

i agree that a recording preset labeled "hd" should record at true hd only. but on the other hand a preset should only exist (be selectable), if it is working flawlessly (i.e. no dropped frames).

cheers,
michael
Your post is too perfect to be valid. =invalid!
On Fri, Jan 27, 2012 at 5:53 PM, Sara Kladky <
reply@reply.github.com
> wrote:

> My bad; I'm new to Git and I was just reading/getting familiar with the
> code. I hadn't actually started working yet, and I didn't realize changing
> the indentation would make all those diffs.
>
> K.  Thanks for your input, I'd like to see to see what you add.
Nit: multi-line would be easier to read and clarify the diff.
@bradens @lekksi 
In general you want to check with Jarno what is the resulting version coming out of current iteration when working with migrations. Originally we thought about releasing sprint 1 results as 2.6 so this change should have been added for the next version. Oh how I long for ActiveRecord migrations :)
It might be worth increasing this range to allow users of 1.3.5 and 1.3.6 to use the plugin. Burt Beckwith typically uses 1.3.3 > *
What's with all the whitespace changes to PHPCSHelper.php?
Still does not work :( http://test.thebkkingdom.com:8080/job/TheSocialNetwork/lastFailedBuild/console
i agree with first the commit but i think it would by way better to override StringLengthColumnDefinitionFormat in Postgres dialect ctor than override GetUndefinedColumnDefinition. Can you rework this Stefan ? (also not purge DoesTableExist)
Why is it instructing you to hit return to continue or ctrl c to abort?
You also need to add it to /include/linux/cpufreq.h
And this: scmnr.3590=...git://...{no .git here}
Sounds good. The purpose of this line change was exactly to be able to mock the system call. Thanks for the tip.  ;)
Done. And updated ElastiCache as well.
I would imagine that line could produce voluminous output, and it's arguably of little interest.  I think DEBUG level is a better fit.
exactly, see and believe:

    scala> val i: immutable.IndexedSeq[String] = IndexedSeq.empty[String]
    <console>:30: error: type mismatch;
    found   : IndexedSeq[String]
    required: scala.collection.immutable.IndexedSeq[String]
       val i: immutable.IndexedSeq[String] = IndexedSeq.empty[String]
Fixed in the subsequent commit.
yes, that is much better, I will change to that (and look more carefully what other goodies we have in there)
that was a stupid mistake. thx.
Instead of this I'd recommend just logging the LogRecord as a LogEvent to the system.eventStream, then in your JavaEventHandler, unpack messages that are LogRecords and just use them straight off the bat.
this should probably not be in the general RemoteTransport scala file (I assume it’s needed for the Netty transport)
That is definitely not an improvement.
Is that not covered by the previous sentence in this paragraph?
Currently I am using it to build a p2p voiceChat client.  Outbound lookups to initiate connections are working, and I have been able to send out a stream of Speex encoded voice packets to a remote actor and then play it on the other end.  At the moment I have only tried this inside my own home network, but it is NATed on both ends through my router.
If point #3 didn't work I shouldn't be able to connect, and if #2 didn't work I dont think my voice stream would work.
that's really nitpicking, but this is not a widget :)
I reverted my previous commit (try/except) and added the None default parameter to getattr. Is this an acceptable solution?
If this is already the multi-voxel version, would fa return all the FAs in the right shape?
It's 0002, not 0001.
Would be helpful to document what the "is_update" parameter should be.
The meaning of `set_header` and `set_headers` is very confusing to readers. This feels wrong.

Maybe rename `set_headers` to `apply_header_rules`, and then `set_header` to `set_headers`
looks to me like this will never find anything for integers with the current code, no?
This is a pretty common pattern, don't call the method on nil, so I think worthwhile.  I'm using it where it is useful now.
maybe an
```
else if (!m_art.empty())
  m_art["thumb"] = m_art.begin()->second;
```
as a final fallback?
Also should we check if the URLs of "poster" and "banner" might be empty before assigning them to "thumb"?
safe resource url is for the upnp server's http server. it then used internal filesystem of server for access. so unless i missunderstand, it should be fine.
dependency removed.
I am a little weary about this for two reasons:

Say:
RESERVE = [A, B]
COST = {A:.., B..., C..., D}

are C and D both ON_DEMAND? How will the allocator deal with this? Instead of defining what the "reserved instances" are, we might want to explicitly define what the "on demand" utilization class is, and tread everything that isnt on_demand as a utilization class that is intended to be purchased.

Defining a function that simply checks membership is a little too much. Its just as easy for me to write:
if EC2.is_reserve_type(foo)
as
if foo in EC2.RESERVE_PRIORITIES
It would require changes in implementation. Would you like to work on this?
-h can be confused with "--help".  Perhaps better to use -v (verbose, can of course also be confused with --version), or -p(rint)
Got mixed tabs and spaces here again.
As above, this should be an early return.
needs spaces in between the array entries
Shouldn't this be if (entry != null)?
All these should have links added to them to the appropriate section of the rose CLI reference
This is not the same. If `$matches[1]` is only `/`, then in your implementation it will be `/` instead of nothing as in original code.
Cruft from a debugging session?
Yes, maybe I should rename, or even just remove since its smaller like this and only used in two places. The name is not as informative with that change anyway. `STRIDING_OK` is only used for performance short cutting for `np.array`, the work is done later with this patch.
Spacing in ternary operator still missing. Additionally: I’m not sure if variable length arrays are C89.
Should this be rtax 0.983?
Здесь и далее: если эти айдишники не банальные инты, можно их и по ссылочке
Чего-то с табуляцией
the class_attribute documentation explains it for arrays: https://github.com/rails/rails/blob/master/activesupport/lib/active_support/core_ext/class/attribute.rb#L41
I think is better to use a different name instead use `()`
It's a stretch to say that argss == Nil can convey such a specific sentiment, since every Nil looks like every other Nil. Can you expand this comment to clarify:
- what would it symbolize if argss != Nil?
- If the whole Select part is a dummy placeholder, why does it have to be so large? Is any of "Select(Super(This(tpnme.EMPTY), tpnme.EMPTY), nme.CONSTRUCTOR))" meaningful? By which I mean, are there conditions where the supercall dummy tree differs in any way from that one, and if so, where does it differ and what are the conditions?

My interest is to not drag around this laborious encoding of the supercall. It has been horrible dragging it around starting in the parser; pushing it out of the parser is progress, but not as much as would be a more direct encoding.
```
Failed example:
    split_surds(3*sqrt(3) + sqrt(5)/7 + sqrt(6) + sqrt(10) + sqrt(15))
Expected:
     (sqrt(6) + sqrt(15) + 3*sqrt(3), sqrt(5)/7 + sqrt(10))
Got:
    (sqrt(5)/7 + sqrt(10) + sqrt(15), sqrt(6) + 3*sqrt(3))
```

These two results are both fine; which one comes out depends on the order of the elements in expr.args
Does this the mean that some to-wildify expressions can be contained within another to-wildify expressions?  If so, how can this be useful?
Arguments should always be sympified.
This and several other things are verbatim pieces of the code for ode_nth_linear_constant_coeff_homogeneous().  So far, I've kept them as-is, to preserve the parallelism between the two functions as much as possible.  When I make these changes, do I also need to update ode_nth_linear_constant_coeff_homogeneous()?
Great, thanks for catching that.  The second scenario I plan to handle should take care of this.
If something "is readable", it does not mean it can be removed.
Perhaps it would be better to use <code>is_writable()</code>. Although I am not sure it will be enough.
Лады, на счет ````present?```` беру слова обратно, т.к. это от Rails, а здесь видимо нужен чистый руби
Can you order the imports alphabetically?
You messed up the indentation here.
I would like someone with a FreeBSD system to verify this.
This was necessary because non-gcc compilers error when /* */ blocks contain nested /*.
s/event-loop/event loop/g
It's fine then, change it to on.
Looking further into it, our current code only details what the remote participant sent. In this case, the participant is sending it to us quite directly, so it seems potentially excessive to put this in the explain log.
The available and created counters are per host, so it's not the number of available conns for the whole shard cluster, it's the number available to connect to a specific shard.
It's the $id variable within the revision object. What else would it hold? But okay, I'll rename it.
What type is the object?
Hum.... I'll check that back later
if we're changing this, maybe rather than assuming a particular order we can introduce named keys in $additonal_data so this is simply $additional_data['forum_id'] ?
I can support this, I think.
New member role should not have it as currently captcha is only required for anonymous posting. Only anonymous users should have it by default.

Noaccess, readonly and bot should not post ever. For those roles perhaps f_noapproval can be duplicated into f_nocaptchae.
Cross link: #908
not sure we want to merge this as is, don't want this to be printed on *nix or production releases.
Move this import to the beginning of the file please :)
Сега .. Тука го направих това, защото първо си помислих че от него идва един бъг с времевата зона, или по-точно: времената излизаха с 2 часа разлика от записаното в базата, а в базата всъщност бяха ок. След като го промених и след като добавих в конфига локалната Time зона, вече излизаха както трябва, но не съм сигурна коя точно от двете промени помогна..
Така или иначе, прецених че обема данни не е чак толкова голям за да се извлича наведнъж, нито пък че броят заявки ще е критично голям. И все пак, тук може да се използва който и да е от двата вариянта, без това да промени поведението на кода.
punting, as is a broader issue than this PR.
Cool, thanks. 831469e8ef71cc68277df87420204acfb0d6800c
Style: unless the acronym is very common or needed due to lenght of word, suggest writing full word for clarity.

Examples:
*Agree with use of abbreviation... In the case of INBOX_CHW, CHW is common acronym for "Community Health Worker". Also saying CHW saves a lot of typing :)
*Disagree with use of abbreviation... In the case of ADD_REM, it stands for ADD_REMINDER. REM is not a commonly knowledge shorting of reminder, and only saves 5 letters. Suggest that writing the full word is very helpful in this case, so that someone unfamiliar with the area can easily read the code.

Please consider you use of abbreviations and try to avoid them unless they are both clear and concise.
This explicitly tests the python version of vm with lazy evaluation.  Since it is a supported option, it's good to test it.

Maybe there are other reason too, I'll let @nouiz elaborate.
Could we downgrade this to warning?
я этого не видел:)
When you say things like that, it makes me want to leave it. ;-)
なるほどー。どんどん範囲が広がって行きますね。楽しいです。BackPackにお呼びが掛かったのでそっちが片付いたらまた戻って来ます。
Forgot to discuss that. I think "read" is better because it will have less conflicts with methods using get* and it follows the naming convention that Knockout uses. Happy to discuss.
Then feel free to modify it
Again, I would actually have a "style" header.
I didn't, but I can definitely give it a shot.
I landed this in ca5e06a15c99d5c181aff6e08804ca803424648d, with the quotes flipped around ... not sure why $ is defined now but I missed that!
Agreed, the global state has to be removed. Passing in an additional parameter specifying the texture root directory voa  a FileHandle shouldn't be an issue. Texture file names could be derrived from texturedir.child("texturefile.png").
Thanks to NPM, `node_modules/.bin/` will be added to `PATH` and so `coffee` command in the `Makefile` will refer to the local binary (fallback to global). This make sure `*.coffee` will be compiled with expected version of CS.
Personally I prefer to have the explanation for the reason here as well rather than just a pointer to more source code.   Especially if its only a three line explanation.
ok, I use gevent 0.13.7, gevent-socketio 0.3.5-rc2, gevent-websocket 0.3.6 and greenlet 0.4.0. I tried .start(), but then the webserver doesn't respond anymore if I try to connect. Catch22!
Actually, this is the only place we encode a unicode string and then quote it. In the MPD/tag cache stuff, we typically quote and then decode the result to unicode.
What was the purpose of this change?
Let's add an extra `if build.head?` guard here. No sense dragging in an opus dependency that won't be used if the user mistakenly uses the option on a stable build.
Regarding the value for build, I wasn't sure what the value meant, but I suppose it is the build tag of the clang version that fails? This is 421 on my Xcode installation.

Regarding GCC/CLANG, when I leave out the fails_with block I get the following compilation output, and the line that says 'CC: /usr/bin/clang' suggests to me that clang is actually being used. Or does it go deeper?

$ brew install cntlm
==> Downloading http://sourceforge.net/projects/cntlm/files/cntlm/cntlm%200.92.3/cntlm-0.92.3.tar.bz2
Already downloaded: /Library/Caches/Homebrew/cntlm-0.92.3.tar.bz2
==> ./configure
==> make
Compiling utils.c
Compiling ntlm.c
Compiling xcrypt.c
Compiling config.c
xcrypt.c:1: error: bad value (native) for -march= switch
xcrypt.c:1: error: bad value (native) for -mtune= switch
ntlm.c:1: error: bad value (native) for -march= switch
ntlm.c:1: error: bad value (native) for -mtune= switch
config.c:1: error: bad value (native) for -march= switch
config.c:1: error: bad value (native) for -mtune= switch
make: *** [ntlm.o] Error 1
make: *** Waiting for unfinished jobs....
make: *** [xcrypt.o] Error 1
utils.c:1: error: bad value (native) for -march= switch
utils.c:1: error: bad value (native) for -mtune= switch
make: *** [utils.o] Error 1
make: *** [config.o] Error 1
==> Build Environment
HOMEBREW_VERSION: 0.9.2
HEAD: 5fee2feb7f3e95f8af3981bcc678015a11f77d4b
CPU: quad-core 64-bit arrandale
OS X: 10.8-x86_64
Xcode: 4.4
CLT: 4.4.0.0.1.1249367152
X11: XQuartz 2.7.2 in /opt/X11
CC: /usr/bin/clang
CXX: /usr/bin/clang++ => /usr/bin/clang
LD: /usr/bin/clang
CFLAGS: -Os -w -pipe -march=native -Qunused-arguments -mmacosx-version-min=10.8
CXXFLAGS: -Os -w -pipe -march=native -Qunused-arguments -mmacosx-version-min=10.8
CPPFLAGS: -isystem /usr/local/include
LDFLAGS: -L/usr/local/lib
MACOSX_DEPLOYMENT_TARGET: 10.8
MAKEFLAGS: -j4
PKG_CONFIG_PATH: /usr/local/Library/Homebrew/pkgconfig
Error: Failed executing: make (cntlm.rb:26)
This may help you fix or report the issue if `brew doctor` does not:
    https://github.com/mxcl/homebrew/wiki/bug-fixing-checklist
We don't allow things to depend on git because we support using non-Homebrew git.
I'm think includes is different than pre/post files.
In my experience, includes contains lib, functions, vars and pre/post files who start/stop my test or make some things before/after
Just `this.currentResponse` would suffice
Just for extra safety, let's prefix with sqerl. Also, I think there is some convention of using either all caps or '$' for hidden atoms.  For example `'$end_of_table'` in ets and in public_key:
```
pki_asn1_type() = 'Certificate' | 'RSAPrivateKey'| 'RSAPublicKey'
           'DSAPrivateKey' | 'DSAPublicKey' | 'DHParameter' | 'SubjectPublicKeyInfo'| 'PrivateKeyInfo'
```
Using OC_Filesystem::normalizePath is probably better
Personal preference and habit really. I always tend to have that whitespace inside parentheses while writing stuff, but not code. I suppose it's me having a weird habit on this one, and Iĺl be okay with removing the whitespace.
use toUpperCase(char, Locale.US)
http://elliotth.blogspot.ca/2012/01/beware-convenience-methods.html
Where is that browserModel used? I can't see it used anwhere
It's worth noting that the primary reason is because that's what we get from an explicit @SuiteClasses annotation.  Not the best reason, but offered in the spirit of historical understanding.
I think the standard is to invoke a successful callback with the first parameter as null rather than undefined. null !== undefined
I think the triple int isn't required, since it is local to 1 Region.  It does need to be concurrent though.

But yeah, the .take() method would have to remove the object from the hashset.
This file no longer exists in master. Not sure how we get this file back in this branch.
Even before being that fancy, it seems like we should be able to guarantee that whatever you type in the textfield (if valid), is reflected directly in the code without any reformatting -- just like editing the text directly in the code editor.  Or we could just take the textfield out, of course :-)
I'm not sure how to do this otherwise. Workspace.js needs to tell the client if a command is unsupported or not, and in order to do that it needs to check with npm-runtime first.

What is the better solution?
You shouldn't rely on variables defined outside and especially _below_ the function, in a foor loop. That's really confusing; just move `license` up into the function.
are really need wide arrow here?
Yep, I understood. 
I was taking example on `rugged_reference.c`, for example, the function that return the reference name, which indeed was using `NULL` for the encoding.
I just checked, and if I understand, looking at ruby sources, this mainly means, returning ASCII ...

Is this normal/coherent ? Why not using `rugged_str_ascii` instead of `rugged_str_new2` with NULL for 2 param ? I'm a little bit lost ;)
```
else:
    super(UserBasedLocaleMiddleware, self).proces_request()
```
Why not set title to "logout"? Or "logged out"?
Then language is there, no?
You meant to have this be a global?  If so, you should do `window.googleCallback` to make sure people don't think it was a mistake.
Instead of this, why not just keep 185 the way it was, and use something like `if(_helper){ _helper = _helper.cloneNode(false); }` ?
Shouldn't that be "isn't displayed"?
I actually don't know if the move to the finish function gains you much here, since you need to do things no matter what at this point.
what if someone capitalized it in the manifest? To be safe if we always use `toLowerCase()` we should never run into an issue with this. Could use name but would ultimately have to do the same thing.
Hier besser `static $instances = array();` und unten dann mit `!isset()` prüfen statt `=== null`. Dann muss man die Funktion nicht anpassen, falls Textile mal noch weitere doctypes anbietet..
Yes, it's. The json-formatted responses aren't supported yet. It may or may not work. I don't want to mislead users thinking that agi already support json.
Is it wise to have checks for the production env in the code?
This change is not required
I thought we still had problems with inlining functional arguments, though. Although `dump` probably isn't performance critical.
There was a slight variation in the 2 scenarios; however, they were 90% similar.  I've pulled the common logic on to a separate class method in commit efc12dd235bf9a51f84c5924edd24d53139cd321
we'll stick with bryan's suggestion.
Double checking that this functionality was not broken.  As I wanted to point out that here the "type" was set to button instead of submit due to the difference in behavior that this causes within the HTML and form.  A submit type will auto-submit a form like would expect, whereas setting the input type to button will not auto-submit the form so that JavaScript can be used to pre-process and manually submit.
Did you mean to change away from a form submit here?  If so, I would change the buttons from "submit" type to "button" type.    You also don't need the e.preventDefault() if you do.
I'm curious what the moz calc with no calculation is for? How is this different than just 20% or 100%?
The other event listener functions are named by the action to take rather than the event detected, I think we should name them consistently either way.
Ok, agreed. That's because I ported it from asciitable, which requires it to work without numpy.
Super nit-picky but in looks like at least most of these could fit on one line, or saved in intermediate variables and then do the multiplication on one line.  In cases where multiple operation expressions *are* broken up into multiple lines it's preferable and more readable to use parentheses, for example:

```
return ( ... *
             ... *
             ... )
```
over the less readable explicit line continuations.
这个不是很好吧？ 没有准确的表达要去除“ 和 ‘ 包围的意思。

preg_replace ("|') (.*?) \1,  $2 会不会更好一点？
$(xLDFLAGS) instead of $(LDHARDENING) ?
I was looking at in in the sense of "A password argument wasn't supplied" than "The password had no value".
Ugh, its probably still a good idea to fix the isset() and do type checks on the parameter instead.
**what is the suggestion?**

Use ternary like old times (PHP 5.2)

```php
$this->stdout = $stdout ? $stdout : new ConsoleOutput('php://stdout');
$this->stderr = $stderr ? $stderr : new ConsoleOutput('php://stderr');
$this->stdin = $stdin ? $stdin : new ConsoleInput('php://stdin');
```

Or keep as it is:

```php
$this->stdout = $stdout;
$this->stderr = $stderr;
$this->stdin = $stdin;
if ($this->stdout == null) {
    $this->stdout = new ConsoleOutput('php://stdout');
}
if ($this->stderr == null) {
    $this->stderr = new ConsoleOutput('php://stderr');
}
if ($this->stdin == null) {
    $this->stdin = new ConsoleInput('php://stdin');
}
```


I'd say that ternary it's good in this case
Missing space before `!`.
The code upwards is the new code. Down from here is the actual test which I have not touched.
Copy pasting the dummy import registers it twice. But maybe the logic used there was already wrong. I think this just makes it worse.
After trying out mocks for a while and trying to get our other developers to use them, I'm beginning to think that we should just use real objects for controller tests.

The reason being that a lot of our developers are new to Rails, and trying to teach them to use not only Rspec but also mocks seems to just make TDD too difficult for them. Also, we're running a bit light on integration tests, so using real objects in the controller tests helps ensure coverage over a larger section of the stack.

Just seems like a good compromise for now. Feel free to rip into this logic though. =)
you could make this nicer using an Html widget instead of TextEditor. Use <pre> tags around the code.
No no, not a Qt Signal, an Enaml Signal. Take a look at `enaml.core.signaling`. We have a `Signal` class that will work with any Python object.
indeed this could go wrong. the problem is what i stated here where we use the vocabulary https://github.com/flack/createphp/pull/28/files#r1959772
reading this, i think we really have to do different, as only the node itself can know the right namespace mappings.
By the way, you never use `nameData` here... is it what should be memcpy'd in or is it not needed here?  It looks like you're just looking for a 20-byte-aligned 0 in the list.

-[Unknown]
I think this description could be a bit clearer - how about "append to the file instead of overwriting it."
you're the native speaker...
I would add (image_url != '' && image != '') to be safe.
actually I mean that the property keys for overthere shouldn't directly reference ec2, as for example, I don't plan to use ec2 to test overthere.  You can look at BaseLoadBalancerServiceLiveTest for looking up properties like this.  Don't forget to add this these keys to the surefire section.

ex.
             <test.ssh.compute.provider>aws-ec2</test.ssh.compute.provider>
        <test.ssh.compute.endpoint></test.ssh.compute.endpoint>
        <test.ssh.compute.api-version></test.ssh.compute.api-version>
        <test.ssh.compute.build-version></test.ssh.compute.build-version>
        <test.ssh.compute.identity>${test.aws.identity}</test.ssh.compute.identity>
        <test.ssh.compute.credential>${test.aws.credential}</test.ssh.compute.credential>
        <test.ssh.compute.template></test.ssh.compute.template>
        <test.ssh.compute.windows-template>hardwareId=m1.small,imageId=us-east-1/ami-0cb76d65</test.ssh.compute.windows-template>
This will segfault so hard that your pants will drop off. I think this calls for a very specific function to parse the filename into an OID.
We're fine as far as `freeaddrinfo` goes in this PR.
Not sure if this should get some caching or not. It should be pretty quick to check the first line of a file, but if you guys think that storing the results in memcache for a minute or so might help with load then it can be easily added.
missing the `var `
It's fine to just have 'id'. We pull things out of the index using queries and any queries that are by id filter on the model first (this happens in the tests).

If we switch it to model + id, then this turns the id field into a text field which has different properties than a long does. So, we could do that, but I'm not sure there's a compelling reason to do so right now.
This modal that opens when clicking this can have it's styles tweaked a little to look less crazy.
Also - this allows any user to submit test results and claim they were actually performed by any other user. Should this be allowed? Should it require special permissions on the part of the submitting user? (I would think probably.)
``update_adu`` is already in there, so what is this one?
You should use the mock library instead. It makes it much easier to debug the tests by finding out what it it was called with. Also makes it convenient to make assertions against certain calls being made.
Hmm.. I thought I was covering these in https://github.com/mozilla/zamboni/pull/377/files#L1R102. That checks to see if the flags are set for the review, and that there's an associated reviewflag entry that contains the "URLs" as a note. This would be the success case for a flagged review.

Are those insufficient?
@mperham I might be missing something, but is there a good way to clear a sorted set rather than delete the key entirely?
Get rid of the trailing commas in ForeignKey and DateTimeField. :)
Yes, I wanted something explicit telling me "I want the default here"; 
actually I'll remove it, if you though it was odd someone else will at 
some point too, thanks Dave.

On 30/09/2012 22:14, David Wolever wrote:
>
> In pyconca/templates/index.mako:
>
> > @@ -1,4 +1,7 @@
> >  <%inherit file="base.mako"/>
> > +<%block name="head_title">PyCon.ca - building your Python Canada Community</%block>
> > +<%block name="head_description">${parent.head_description()}</%block>
>
> This line seems unnecessary.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/pyconca/pyconca/pull/51/files#r1725518>.
>


-- 
Daniel Sokolowski
Web Engineer
Danols Web Engineering
http://webdesign.danols.com/
Keep the changes separated in the PRs dude. This one is a whole new field type.
I think this is useful for subsitute cores, so they know what to implement.

In what other place could we put it?
why not just ``return 1`` like in other places ?
The form subscribers are not accessing the FormBuilder but the Form
it should simply be named ``logging`` to be consistent with DoctrineBundle
This should be kept as `app` may not be available when not using the full-stack framework.
you should remove the ``else`` here as the ``if`` return
this is weird. It does not look the same than on the demo. The demo shows the link properly
I've started migrating to the asset pipeline, so I'm half and half at the moment.  From what I could tell in the code, has_asset_pipeline? just checks for the folders length being greater then zero which is true when I didn't expect it to be.  Could we hook into the environment configuration to see if the pipeline is enabled?
Yeah, actually we have an `.env` variable already. I'm going to see if I can streamline these variables.
The second line is the recommended way in ECMAScript 5.1 specification to create a empty object.

I just want to try it.
因为作为编写者，你并不知道别人的论文中是否需要使用这些字体或加粗等命令，所以用户手册只是将模板所支持的命令列出来，并说明没有特殊需求可以不进行字体设置。如果有的人的论文确实需要某个字体而用户文档中又没有说明呢？
所以我的建议是，把模板所支持的那些设置或命令都列出来，供有需要的人选择使用，普通的没特殊需求的就直接无视掉这些都可以。
Der Aufruf muss nicht innerhalb der foreach-Schlaufe stehen. So muss er nur einmal ausgefuehrt werden.
I think I'm going to remove this, it's not needed anyhoo.
This is handled by matplotlib's imshow "origin" keyword", and how all other flippage has been done so far in cartopy. Might be worth doing the same (and figuring out the appropriate architecture to support that...)
(no action required)
Eventually, I imagine urls in comments might become exempt.
Of course. :-)  I've been following Martin's advice on this though and trying to make it explicitly obvious from the code.
cant use class = Title like all the other ones that have title as the text?
À quoi servent ces deux fonctions ? Je ne vois pas où elles sont utilisées.
Yes. With reported there you mean Widget Wiki page?
The question isn't when it is useful. Try removing it and find out how this file is used and why it is, in fact, required.

This file isn't used to include functionality, but used as a data provider. It is referenced in a `require` statement in `init.php`. When a file is required in PHP the target file can act kind of like a function. Its return value will be passed on to the require statement, which can then assign it to a variable.

[`474494b7` inc/init.php#L151](https://github.com/jquery/testswarm/blob/474494b7/inc/init.php#L151)
```php
$localSettings = require $localSettingsPHP;
```
nit: -lil
Ok, I'll check with him. Is it blocking?
This file was missing from the style folder, so I just commented it out for now.
Looks like these if and else clauses confuses you... so I have changed to if > else if > else, I believe this is more clear!
First, thanks for this ;) Now please move it below the <tt>SettingListerner</tt> or above the previous commentaries to keep together the commentaries about the listener with the listener itself.
I would modify it in my PR later.
(Still don't know what this is.)
I'd change this to be '--address <host>:<port>:' and then make a note in the help message that you'd typically use localhost:2828
OK and thanks
Yes, we should probably name it test_launch_entrypoint.
nit: do you really need to spit it? If yes, the indent seems weird.
again, #winning.
I don't think this is required, as we already have a default in the routes
Uppercase String not string
@brunomachado, the title from this page isn't being hidden when the search form is on focus. It's because you're using an `id` instead of `class`. The selector used in the [search form](https://github.com/redu/help-center/pull/6/files#L63R3) is `.hide-title`, a class, not an id!
s/その場限りのコマンド/アドホックコマンド/
s/フィルタリングしたもの/フィルタリングした結果/
s/フィルタは条件にマッチしたノードだけリストアップするというように使う事ができます。/条件にマッチしたノードだけリストアップするというようにフィルタを使う事ができます。/
you know what this is!
Actually, I can use this date for isCurrent and we'll just support one event per day
Some docstring?
The problem is that the double quoting messes up the single quotes when using with the substitution. Might be a Bash bug, but I can confirm this is on Mountain Lion (Bash 3.2.48) and SmartOS (Bash 4.1.0). Consider this:

```bash
#!/bin/bash

gcc47flags="-O2 -fno-tree-dce -fno-optimize-sibling-calls"

if [[ "${rvm_configure_env}" =~ "CCFLAGS=" ]]
then
  rvm_configure_env="${rvm_configure_env/CCFLAGS='/CCFLAGS='${gcc47flags} }"
else
  rvm_configure_env="CCFLAGS='${gcc47flags}' ${rvm_configure_env}"
fi

if [[ "${rvm_configure_env}" =~ "CCFLAGS=" ]]
then
  rvm_configure_env="${rvm_configure_env/CCFLAGS=\'/CCFLAGS=\'-I/opt/local/include }"
else
  rvm_configure_env="CCFLAGS='-I/opt/local/include' ${rvm_configure_env}"
fi

echo "${rvm_configure_env}"
```

The output in both cases will be

```bash
CCFLAGS=\'-I/opt/local/include -O2 -fno-tree-dce -fno-optimize-sibling-calls' 
```

And the escaped single quote makes things fail obviously. Skipping doublequotes on the substitution call helps avoiding this problem. Unless you can suggest a better solution to this.
No need for $output, assign it directly to $block->content.
整个分号。
`form` is *at best* ambiguous - at worst, it's misleading
напр пустой тайтл и дескрипшн
That's actually a good point... I have no clue how that would work on Windows though.

On *nix, we can just check the common paths like `/etc/pki/tls/certs/ca-bundle.crt` and `/usr/share/ssl/certs/ca-bundle.crt` and we have most everyone covered.
because it first validate the schema with the LAX_SCHEMA (i.e. for projects) and then try with the full schema (i.e. for shared packages)
I'll look into it. The problem is that in the PHP doesn't exist sorting function which preserves original order of items.
Fix symbian installation
forgotten :)
Can we just remove this stuff???  Or do we need to add it back (in which case, there should be a FIXME.)
Belongs in common?
If we are not going to commit the fullscreen stuff in this pull can we move to a different branch?
Yeah, that should work. My aim was to get just the URL and that'll stop before the space.
These changes are congruent to  cob_hardware_config/cob3-3/config/sdh.yaml and cob_hardware_config/cob3-6/config/sdh.yaml at least.
(In addition it's hard-coded that way in schunk_sdh anyway)
To clarify, does the HTML file get written to subdomains/prepage? Also, subdomains/prepage isn't in source control. Should it be added?
Indeed, that's what I meant.
I will rename to `observersCopy`, or something such.
@seanmonstar - you can call user.checkAuthentication. If the status is already known (and it should be at this point), no new network request will be made.
so sad to see LOOONG go...
This code should simply be:  new Logger({dir: prefs.get(config.preferences.log_directory, "")});
As talked on IRC, will leave this attribute as is.
If there is a way to control the value of `hidecolumnpicker` programatically then a follow-up issue could be filed.
__whimboo__ commented on other line:
> If we fail in posting ...

You are right, an `onErrorCallback`-like stuff is needed here. Should I rename `onLoadCallback` to `onSuccessCallback` like  in [`OS.File` examples][1]?
Or just merge into `aCallback`, and let the consumer decide what to do when callbacks happen?
I vote for tighting the callbacks to `request` (`onLoadCallback` and `onErrorCallback`). Ok it's still not perfect, because if something fail other than the `request`, then the callbacks aren't called.



[1]: http://dutherenverseauborddelatable.wordpress.com/2012/10/03/asynchronous-file-io-for-the-mozilla-platform/ "Asynchronous file I/O for the Mozilla Platform"
so, we use `boolean` instead of `Boolean`?
As with the `is_ruby_dsl?` function, this should be named to make clear it works on a filename.
This variable is not used in this class, is it?
A boolean flag for whether to simultaneously replay.  Didn't want to clutter up the global namespace, so it's an argument to the Record constructor.
If you use it 'data-phone-number' then you could access directly with 'dataset.isContact' instance of 'getAttribute'
Can't this just be : 

```javascript
items = $.isFunction(window[this.source]) ? window[this.source](this.query, $.proxy(this.process, this)) : this.source
```

It's a bit less readable (really just a big IMO), but we use `$.isFunction` just one.
col mixin here
your code make unterminated request, ok, i will add a unit test soon ;)
Why the hint is removed?
Oops, i will change this :)
Remove implements clause.
No. according to the api I must use it like this.
See http://api.rubyonrails.org/classes/ActiveRecord/NestedAttributes/ClassMethods.html
Using with attr_accessible - near bottom of the page
Okay, was just expecting it to clone to this path.
Same here, do this in a separate commit.
If it's a Angular convention, then ok keep it, but I usually like to stay away from unnecessary abbreviation.
Good point, https://github.com/alphagov/imminence/commit/9ca3a5c5ebd12b94149d39ec8751ede4072ac5ac deals with title changes
according to the Symfony2 CS, it should be written ``if (null !== $max)``
@stof yeah, @beberlei stopped me, I was going to do that :)
removing it is a BC break. You should keep it (empty) and mark it as deprecated instead
i was thinking the same thing. then again it would then lead to different behavior if the data is in memory or not.
Is this duplicative of `created_at`?
add an extra `##` line for consistency
I would rather find a solution that worked across the board. I only found out about the ordinal expectation from MongoDB because the authentication commands were failing. I would assume there are other commands that require to be serialized in the correct key order.
What specifically does this plugin do? I'm not a big fan of having IDE specific things in the repo, unless it is a necessary fix for a known problem.
Drupal wants 80 character long lines for comments. A bunch of the comments in here go way beyond that.
added a commit that maybe fixes this
nit: add spaces around `*`
Seems to me that you could simply do `Math.abs(M) !== 1` here.
You can use `KhanUtil.BACKGROUND` to get the color of the exercise card background instead of hardcoding it here.
My thinking was that it is the polygon that is defined as being 20 degrees on the sky from the position specified (as in, spherical distance). Just to make sure I understand, what other interpretation do you think this could have?
哦，这样啊。
我再看看
Perhaps this would be even better?

```coffeescript
life_modifier: vanguard_modifier /Life Modifier: ([+-]\d+)/
```

This would guarantee that we only match strings that can be coerced into integers.
Modified Row constructor to pass the config down the chain so that it can reference whether or not a row can be selected.
Some new rule(in set/get)? then that's ok...
fixed this section. i'll be checking this moving forward with vps page. if biz hosting page not ideal let's discuss so I know for sure
I don't think this should be a link - semantically this isn't linking to  another page.
See @simong 's comment below. Principal would be the actor (e.g. u:cam:simong") and subjectPrincipal would be the subject (e.g. g:cam:math101)
This should be wrapped in ()
The job to fire off the index document task has been moved into `search.js`.
Some day we need better documentation for this magic.  I plan to cover it in the SBT book.
> Hm, I was following the docs for SubMonitor, and they suggest to never use an IProgressMonitor in new code, but instead convert it to a submonitor first

Oh, I didn't know that! Anyway you can extract the logic so that we can easily re-use it (and the wrapping from IProgressMonitor to SubMonitor happens in one line)
"else if" should be condensed into just elseif
I would try to avoid using the term "EE Only" or anything that sounds like that in our documentation. In general I would like to avoid using terms that sound exclusive. When possible I would avoid the distinction. When not  I would say that it's provided as a service or available to subscribers, etc.
I copy pasted EVERYWHERE :P Mainly as I was not used to your event system yet.
OK. that's right.
Thing is, what if it returns empty information?
Can you rename the method to `testGetGeocodedDataWithRealAddressTwo`?
mee eens.
Overbodige lijn weer
в прототипе и реализации метода лучше придерживаться одинакового названия переменных
ну не придирайтесь) это просто форма записи)
у меня такое ощущение что этот рэндом вернет числа 0, 1, 2 или 3.
А 3 нам не нужна.
Разубедите меня:)
Do you actually want to have generateNewMarker and generateNewMarkerExclude in your public interface since it's Cell's internal subroutine?
It cause no harm but useless for end user of your class.
you can just us Hunt.find(params[:id])
Since this is mainly for UI actions (as far as I understand it), I think we should combine them until we run into a use case like that. I mean, there's also an easy workaround of just exposing a method (in addition to the command) which can be run anytime.
I've fixed this, but there's no way to write a unit test for it. It doesn't seem like this should be a public static method for Repository. Should it go somewhere else, or just leave it without a real unit test?
Ahh sorry, I renamed and tried to get rid of this. apparently the file got
not deleted...

2012/10/11 Alexandre Gramfort <notifications@github.com>

> In examples/export/plot_raw_to_nitime.py:
>
> > +data_path = sample.data_path('..')
> > +raw_fname = data_path + '/MEG/sample/sample_audvis_filt-0-40_raw.fif'
> > +
> > +###############################################################################
> > +# get raw data
> > +raw = Raw(raw_fname)
> > +
> > +# set picks
> > +picks = mne.fiff.pick_types(raw.info, meg=True, eeg=False, eog=False,
> > +                            stim=False, exclude=raw.info['bads'])
> > +
> > +# pick times
> > +start, stop = raw.time_to_index(100, 115)
> > +
> > +# export to nitime using a copy of the data
> > +raw_ts = raw.to_nitime(start=start, stop=stop, picks=picks, copy=True)
>
> isn't it a duplication with export_raw_to_nitime.py?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/142/files#r1818024>.
>
>
Yes, I think we can / should have both versions. Also note that we've got several whitening options now...  our prewhiteners, PCA(whiten=True) and ICA(whiten=True). We should allow the user to select tuple combinations of those (prewhitener and pca, pca and ica, prewhitener and ica). Wdyt?

On 14.11.2012, at 22:24, Alexandre Gramfort <notifications@github.com> wrote:

> In examples/preprocessing/plot_ica_from_raw.py:
> 
> > @@ -39,7 +42,7 @@
> >  
> >  # Sign and order of components is non deterministic.
> >  # setting the random state to 0 makes the solution reproducible.
> > -ica = ICA(noise_cov=None, n_components=25, random_state=0)
> I would keep the n_components there and put max_n_components here too. max_n_components would be set to None by default in init and set to n_picks during decompose
> 
> wdyt?
> 
> —
> Reply to this email directly or view it on GitHub.
>
"need of a routing." - seems like something was left off the sentence?
Oh, so you're running the transmitter and receiver separately but in the same process?
Let's explain it, i think we are all using third person?
remove the then, gives sense of flow?
These validations feel more like they belong in an `Agile` trail than in Product Design - seem more focused on process..

I can't offer better validations, unfortunately, but they must exist.
We need the files to come out in the format that node fs will produce (i.e. on windows with backslashes).  Calling path.normalize safely converts slashes to backslashes on windows.