labofsahil/github-event-dataset-2012 huggingface dataset:
Not needed as a default here anymore.
>
> Shouldn't this go to sympy/core/expr.py ? That's where factor() is defined.
>
>
I can move it there.
You shouldn't need a separate function for this. see my comment on the main discussion of this PR.
This is wrong ! Because if $COLORTERM or $TERM is not presenting, "$COLORTERM" or "$TERM" will be return, not None or False
1 should be a string here, no?
You're right, it's only a parsing issue with JSHint, you can ignore it.
i vote its same either way but i get tim's point for small literals.
You could avoid the `reverse` by using a vector as a accumulator and `conj` instead of `cons`.
Does this test really test the restart itself or the state transfer that happens when the cache is started back up?
This test method does another assertion as well, in order to use `@Test(expected)` I'd have to separate it into another method. And all I wanted was to change the indentation to match the Infinispan code style :)
`new SimpleCallable(true, true)` doesn't communicate very well the fact that you're creating a callable that throws an exception on the first (and only the first invocation). How about adding a new `FailOnceCallable` class instead?
You'll want to put this in an `end` event, in case the data being sent is too large for one message: http://nodejs.org/api/http.html#http_event_end_1
I think the word "descend" here is a bit confusing.  I think the more commonly used term in OO is "inherit".  If there's no objections, since this is already merged, I'll just go ahead and fix this directly on master.
Fixed the bare except clause.

No, I'd expect 2to3 to apply the fix like they do for intern, at which point the try/except block becomes irrelevant.

```patch
--- tmp.py	(original)
+++ tmp.py	(refactored)
@@ -1,6 +1,7 @@
+import sys
 try:
     intern
 except NameError:
     from sys import intern
 
-intern("Hello")
+sys.intern("Hello")
```
So should I put it back ?
2:1 is not supermajority :) But ok, I understand your arguments, especially the line-length argument is very good and I have never considered it myself. However I don't agree that using tabs causes problems with diff, patches, history etc. It's simply not true. So I think the part about this should be removed and replaced with the line-length argument.
I was confused about this - was looking for a tile-seq - but now I remember that we're not binning by tiles anymore.
Why not destroy the loopback for RHEL?
remove extra newline please
Created a ticket: http://open.silverstripe.org/ticket/7679
этот столбец нужно было назвать ```content``` или ```text```
Modifikuj, jak je libo. V tomhle neni zadna veda. Proste abys docilil periodickeho volani nejake funkce, musis v te funkci vzdy naplanovat dalsi expire, tj. zavolat timer_start(). Neboli jedno zavolani timer_start() = jedno zavolani callbacku.

A ja jdu spat. Brou noc!
Hey,

Actually, imageable_id is to hold the id of the imageable object to which it belongs (e.g. the id from a Member or Event object) and is required to allow Rails to figure out things like Event.first.images :)

I think we're on the right track though; store an identifier from the API call that allows us to do a comparison - for some reason, I didn't see a the photo_id attribute returned, so thanks for pointing it out ! I will add a `uid` field into the Images table to store the photo_id returned by the API_call. I already have it working with a URL comparison, so this change should be trivial.

Also, working on this stuff is fun and I'm glad I could help, so cheers :D
Pulling changes :)
Are you sure ``'Zend\\EventManager\\EventManagerInterface'`` has the correct type as ``string`` is not a sub-type of ``string``?
- Are you sure ``$choices instanceof \Traversable ? iterator_to_array($choices, true) : $choices`` has the correct type as "array|array" is not a sub-type of "array"?
- Are you sure ``true`` has the correct type as "Boolean" is not a sub-type of "Boolean|null"?
removed this block. 
Firstly I was adding more functionality for testing in KS code - but than Tatyana suggested now only modify KS to work - and adding more stuff will be done further if needed. so this code now is just removed
Does the hash actually need to be followed by a space? I've seen #TODO(bcwaldon): or #NOTE elsewhere
ha, it alright man
It's a dict comprehension. It basically adds `x-goog-meta-` to the beginning of each key in `metadata`.
I believe this line could be removed.  Setting `this.fragment` won't matter since we're immediately navigating to another location right?
Since we are going to change the previous default behaviour (from minute to second, as default in params.pp) what's the effect of the change?
What's the default provided by the OS packages?
Eventually should we set as default value in params.pp 'minute'?
Why don't you use

    JLoader::register('JsonSerializable', __DIR__ . '/compat/jsonserializable');
Because Java can't distinguish between a different create method, as the type of null is not defined. Explicitly casting null to Map allows Java to pick the right linkage.
this line is really long, i'd rather have something like `var seeOther = 303 == res.statusCode;\n var idempotent = 'HEAD' == this.method || 'GET' == this.method` etc then followed by conditional. Also add a space `if (...` like the rest of the source
все будет норм) будут выводится все теги, включая sport, так как они добавляются в таблицу ```tags``` в ```assign_tags```.
Would be better if for get_list_of_languages(cls) get __init__ methods in each of class and they add languages avtomatic into one dict in parent class?
Hm, wrong line it seems. Submit button should be at the same level as {% comment %}. (You see that with `</diiv>`, that is is on the same level as `</div>`, this cannot be.)
No, you should not change objects in get!
Create another `<div>` with list of footer links, currently only one link is there, contact (later on there will be also about and so on).
BTW, better (cleaner) way to do this is:

```
$('<li/>').text(data.username).appendTo('#userlist');
```
See, there is a difference between REST resource and database object. Here, this is method, which is called, when REST resource wants to create a new database object for it. So it is not called when you create object directly from the code.
O no no. You do not need to hardcode that. You have everything in `carto` URL.
You don't want to use workarounds here because what if this is later on fixed in Django code, for example?
You should not be required to manually create this dict! This should be done by Tastypie! Check how it is done in `send_update_on_new_post`! And do the same. If there are problems, ask.
Any reason why this doesn't try to delete the group in the same fashion as the other code that does this? For me, this doesn't delete my group (since we have to wait a few moments), but the above fix does.
Why is this request a dummy?
I've changed that to be like 'normal'.
At some point I think it was a standard or in the most code there's this type of Yoda condition :)
Actually I intented to have two commits and upgrade the plugin to this version. ;)
But I can create another branch if you wish so.
> To query a NoSQL database is a complex feat, especially as not all NoSQL engines support querying (of the stored data)
Seems to work without doing anything other than moving them out of the constructor and changing names to Heater.prototype.whatever.
This using statement got misplaced
this variable doesn't seem to be used
I tried my best to explain J, y and star in each of the functions without going too much into the theory.  The optimization is done in a round about way since we solve for the Lagrangian multipliers and then compute the weights as a function of a Lagrangian multiplier.  That might be why the names/ of variables/intuition is not immediately clear.  I did however try to replicate Owen's notation as closely as possible.
Can you undo this?  As a response to #8, I'm going to look at making this more configurable.
Maybe it should have been `!!config.enabled` so we are certain that it is a boolean.
It's documented http://nodejs.org/api/url.html:
* search will be used in place of query
* query (object; see querystring) will only be used if search is absent.

I didn't have search field, that's why it worked for me. I think your proposition is better
I agree that it's a good practice to return `true/false` from `?`-methods. This one is for internal use so I was less careful about this rule. Give me a couple of minutes, I'll fix it.
Will end users have access to this file in order to remove this if desired? We should include very clear inline docs about how to do this.
Like @caius said, we've all been there ;)
you missed a couple of other calls with this. e.g. CGUIDialogPVRChannelManager::PersistChannel()
better idea to do it the other way around: default the boolean to true, and set it to false when loading the channel info from the client
I bet you mean:

    if (builder) {
Je viens de regarder rapidement, finalement ce code tel que proposé prend déjà en compte le cas de l'attribut affiliation multi-valué  non ?
Cf le .get(0) de RunnUtils
affiliation = (String)attributes.get("affiliation").get(0)
We should have a comment here that these commands define the LHS as convenient views into the larger image on the RHS, and thus that changes/additions to the array locations on the LHS are likewise matched in the larger image.  A handy, but not totally obvious, part of the syntax.
I don't see how this function will ever return a value.
This was how we did it before, but I guess it conflicts with a2enmod.  I noticed you'd removed on app100.stage, so did the same here to get it working, which now it does.
OK to remove this, since we no long strictly need the patched gdata.  :ok:
@dcadams, I think you need to write copious amounts of comments here regarding the structure and how it's used.  Otherwise it's very difficult to understand.
What if the imported file contains no items (i.e. they chose the wrong file) - would be nice to have an informative error message rather than an error from Linq
Actually a `search_doc()` is a list of `#rpbpair{}` records, one-per-field including `id`.
We need to consider creating CSS file and attaching it on the templates that we need. I think it's much better solution than nesting styles in templates :)
Yes. If you do that, the effect is that you get sent back to the dashboard.
For your other http calls, you check the response code.
Here you're not so you risk throwing a json parse exception rather than reporting underlying problems to the user.
Agreed, originally was for line length purposes.
Can you make it private + friend classes that need to call it? Otherwise it's confusing and likely to be forgotten at some point imho :)
Do you mean, not just when len(new_ids) > 1, but in fact when len(new_ids) + len(trials)  > self.ntrials?   I thought we'd let it go over in this case, ...
but we could cut if off the way that eccv12.py NTrialsBanditAlgo does ... I don't have strong feelings.
might want a MappingModes interface with constants of known mapping modes + @see on the getter
This is incorrect, `auto_start` should be off.
What happened with this file?
Here's where you could add the cache directory config with a default value.
Можно (нужно) обойтись без containsKey:
```(java)
Integer count = myMap.get(key);
if (count != null) {
  myMap.put(key, count + 1);
} ...
```
Правильно ли будет, в invoke у MyInvocationHandler вызов invoke у метода помещать в блок try-catch и там ловить InvocationTargetException, брать от него Cause и кидать уже его?
Ааа, отдельно от операций. Ок.
Can you wrap the splitter and the in a notification box?
mk_api.app_status(mock_app)
We should remain to single quotes here. :)
消しておきます
Nope. This is a description of other sources of money.
Lets talk about this one voice, I am open to changes, and now you point it out, I want to ponder a bit more on it.

-r

On Dec 19, 2012, at 5:28 PM, Bill French wrote:

> In mi/idk/scripts/test_driver.py:
> 
> > @@ -40,6 +62,30 @@ def parseArgs():
> >      #                    help="Launch data file monitor" )
> >      return parser.parse_args()
> >  
> > +def read_buildbot_config():
> Still a little uncomfortable with all of this code here. It really feels like it should live farther down.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Can also be written more directly:

```python
    if any(sp.issparse(X) for X in Xs):
```
where is this heuristic from?
scale_C has mos been removed recently
its late ;)
Hmm, let me check if the html structure also has a name= a tag instead of just the id= li tag

-- 
Yuvi Panda
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)


On Wednesday 21 March 2012 at 2:28 AM, Jon Robson wrote:

> > @@ -295,10 +295,10 @@ window.chrome = function() {
> > 
> > if (href.substr(0, 1) == '#') {
> > // A local hashlink; simulate?
> > - var off = $(href).offset(),
> > 
> 
> 
> technically a hash link #foo could point to an element with name foo e.g.
> 
> <a name="foo">link</a>
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/wikimedia/WikipediaMobile/pull/179/files#r582426
> 
>
see comment on chrome.js
same here

and:

    $tableOptions[] =
No no no!
Getting rid of that *ridiculous* error message was the whole point of the original commit.
The module and package DO NOT HAVE THE SAME NAME.
you fixed it only in once place, making it worse as it is now inconsistent :)
Isn't this just bb::cascades::Color::Black?
changed to int
Ive made All the other changes around these comments, but I havent changed anything with the cacheing yet.  If we are going to create a cache schema object its probably going to redo how  all of this is done so that will hopefully address these concerns.  

Once this pull request gets merged Ill start on that.
Again, it'd be better to use unless here
This doesn't make sense anymore - should just convert it to a text input, as the browserSets are now easily customizable for each instance.
This matches cases where the `code` parameter is not the first. For example;

``` javascript
// Will not match http://example.com/?foo=bar&code=FuBaZ
/\?code=([\w\/\-]+)/;
// But this will;
/[&\?]code=([\w\/\-]+)/;
```

It's generally not safe to assume a parameter is the first. Especially on an ever-changing API.
To elicit a review response ;)
You can put the lookup after starting the transaction, so we don't have to use cached lookups. But this is better done after my change (#3369) gets in.
Not directly related to change, but removed a warning here while at it.
Ok, this is weird. It seems ArrayOf behaves more like a stack with random reads than a substitute for an array with auto-allocation (which I assumed it was, from its name). It also solves the riddle why ArrayOf just uses realloc, rather than cleaning the area and only "adding" an element at a random offset.

I don't think UnsignedArray is what we want here. Something similar to std::vector would be perfect.
I worry that just inserting {{ signature }} might not do the right quotings for URLs. E.g. `"` should become `%22` not `&quot;`.
There should be some `urlquote()` helper or something.
It's not in https://github.com/joomla/joomla-cms/blob/master/administrator/components/com_admin/models/sysinfo.php. It's being added in this pull.
I was always taught to return early... I didn't realize when writing this that I was only going to have one line of code in this listener though, heh.
You could _cast_ the ViewModel to a JsonModel within the JsonRenderer...
great idea! thanks this helped me!
btw... that's what heroku does.
Should this be a `span2` or `span3`?
please replace the admin portal login with the loginmanager login.
Please fix your IDE so it doesn't rearrange imports like this.
@yuhunglin Per discussion, let's do both formats.
'features' instance variable contains only object of subclasses of Feature::Base, which are not comparable
so, Set does nothing (except confusing reader)
This is now fixed in master hopefully. Please check out my changes and test them for your use case..
I did not want to rock the boat so I followed the pattern of the ApkBuilder class. If you would prefer to instantiate first then that is fine with me. Would you prefer to have the constructor call the init method?
PEP8. Could be clearer too.
```OptEnum``` is probably more approrpriate
Prefixing the name of the module on all the "prints" seems a little verbose for me, I'll be asking to other more experience developers if there's any guideline about this
I guess the question is whether this should be an adjustable parameter?
Yes. `CachedWhitelist` is just a proxy for `Whitelist`, but in the form we want to be dealing exclusively with the (database-backed) `Whitelist` model.
I'm not sure about this. I wanted to do it, then I realized in some cases this might take 10-15seconds, and you're sitting there with a spinning web page. It's not so great.  I think a better way would be to do it async on the next page (force an update right after you created the package via JS). Please remove it from this PR so I can merge the rest.
Following a common App Controller pattern, I think this method should be called execute().
Actually, I don't think any space will be wasted. After the resize, the new atlas fits the old atlas into a node that take up a quarter of the new atlas. Images can still be deposited in the old atlas nodes when space runs out of the new nodes.
Did we also cleanup
```
float tsPerturbationRatio = clamp(dot(normalTangentSpace, vec3(0.0, 0.0, 1.0)), 0.0, 1.0);
```
in Water.glsl?
EPSILON1 radians (5-6 degrees) doesn't seem like a very tight tolerance.  Is that the closest it matches?  What if you use a sidereal day (http://en.wikipedia.org/wiki/Sidereal_time) instead of exactly 24 hours?  Also, I think there's an expect(...).toEqualEpsilon that you can use instead of the CesiumMath thing.
This method doesn't seem to throw this exception any longer.  It looks like there's a lot of DOC_TBA in general.  All of the doc needs to be updated before we merge this in, that means making sure all of the @ tags are correct and that all DOC_TBA are gone.
The internal server error doesn't come with inner exception object so there's no error code passed.
The spacing looks a little odd here, are you using whitespace instead of tab indentation by chance?
missed a space after the `=` sign
My point was the validating flag should not effect the customization of the SSL context. If for example I set validates to false but provide my trust managers (which is what your example is doing), the test would be incorrect. Just saying that user specified managers must take precedence over this boolean flag
This can be one big docstring?
This should come somewhere in the docstrings (maybe in __init__.py)
So it will be included in the auto-generated documentation.
This isn't accurate. Mincrby increments a set of keys by their **respective** amounts; this wording makes it sound like you pass in a list of keys and a single amount (as if there's a uniform increment across all keys).

Also break this out into two specs: the second one should exclusively check that mincrby properly sets the values for non-existent keys.
rename comment, nothing to do with I_MPI here
I know I had that name in my previous comment, but maybe we should call this `enforceNotNull` for consistency – opinions?
XD  I probably copied part of the original code when doing things and failed to rename it.
But then you're missing the opportunity to publicly shame them. :smiling_imp:
This line can be removed  since it is added above.
This is the default, no need to specify it :-)
You should return `inserted`.
Rather than `die`, I would suggest you do `throw new \Exception`
As much as I wish `github.rmccue` was a valid site, alas. :)
Here [Ubuntu -- Package Search Results -- libopenssl-ruby](http://packages.ubuntu.com/search?keywords=libopenssl-ruby) you can find that **libopenssl-ruby** in maverick, natty, oneiric and precise is provided by **libruby**
remove `puts` debugging lines
This report seems incomplete, given that you never set up the report definition. What's going on here?
You're actually marking anyone who had a visit scheduled between 0 and 90 days ago as "Missed Appointments", but this is wrong. Do you mean to be looking for people who do have an appointment in the last 90 days, but haven't been seen in that time?

I'm going to comment out this whole calculation code for now and disable the report.
Well, not exactly that the controller takes care of it. It's just that no copying actually needs to happen in my code, because it just auto-populates the form with correct values and lets the makeaclass logic take care of the rest.

Regardless, I removed the function since it was unneeded.
Hey Keith, where did the data come from?

I was doing a quick check and I can't find this mapping in the spreadsheet linked on this page: http://www.boundaries.wa.gov.au/2011/Find-your-Electorate/
I was looking at adding the Facter stubs for old/new `iptables_version` when I noticed something very weird.

`mask_required` appeared to always be true. Placing an rdebug breakpoint on the line after gave:

```
/home/dan/projects/vagrant/fw/puppet/modules/firewall/lib/puppet/type/firewall.rb:501
if mask_required
(rdb:1) p mask_required
"1.4.12"
```

I have no idea why.
Это незначительное неудобство по сравнению с персистентностью настроек.
`add_suite_dicts` or maybe just `add_suites`.

Or you know what, it might be clearer to call it `add_suite_data` and have it accept only a single dict, then put the loop in the calling code instead of in this method.
I'm not 100% sure what this setupDraggable is targeting, but it seems like having the width and height of the entire document for the draggable area is a lot.
Can this just be an image instead of an empty div with a background image?
`Function` should be capitalized
I see no need to change this source file in order to add the URL.
I need a cheatsheet
I vaguely recognized `65001` as well, but not everyone might remember it. Please add a comment, it can't hurt.
It's existing code - I only changed the variable name - didn't really pay much attention.

I don't think it adds any value - I can remove it if you feel strongly about it.
Ugh - after further review, I see a problem with &lt;jms:channel&gt; - it has a _message-driven_ attribute and (obviously) uses a listener container when it is true (default); otherwise, it generates a PollableJmsChannel that uses a JmsTemplate.

Problem is - the selector is ignored when using a PollableJmsChannel.

I guess that should be written up as a separate JIRA, but until that's resolved, perhaps we should document here that it is not used on a non-message-driven channel.

It's not clear to me why we support selectors on jms-channels (given that there's no equivalent on the send() side), but that's water over the dam.
Just so I understand what's going on here - you are setting the reply correlation to null so that the normal ARPMH process of copying the inbound correlation id will correctly reinstate the inbound correlation id?

So, regardless of the origin of the inbound message, the reply will always have the correlation id from the JOG's inbound message - correct?

In other words, you are (by means of the ARPMH) reinstating the inbound correlation id after using a gateway correlation id internally here.

If my assumption is correct (or otherwise), please add a comment to this effect so folks reading the code later can understand what's going on.

I wonder if we need 

````java

	@Override
	protected final boolean shouldCopyRequestHeaders() {
		return super.shouldCopyRequestHeaders();
	}
````

to prevent a subclass from disabling this mechanism?
The original code explicitly sets `this.date` and `this.viewDate` to different `Date` objects, but this new code sets them to the same object.  Since all `Date.set*` methods are reflexive (changing the original date *and* returning a copy [new object] of the new date), I wonder if this will introduce bugs elsewhere.
Yeah np, but I think it's better hard-coded here.
can you tell git to ignore this file and commit again with the file removed?
Stylistic: one could write "message = unicode(parameter[1])" and use message below
This should be documented in the UPGRADE.md ... in a specific project i created my own NodeMenu instance ... when i want to update to this version i need to know the constructor of this has been changed.
Why the toMap call here? Are we making it immutable when we pass it in or what?
Bizarre cette méthode en_value.
Maybe in syncbase and then activesync can copy that across to be its constant too?
What is the purpose of this sleep?  It seems like it will just add unnecessary latency to commands.
This should be String[]
I'm not sure I understand - an assertion is not enough? You mean something else? Same for the comment below.
Any particular reason to use the instancesRespondToSelector: method instead of respondsToSelector: method. Again this might be unnecessary since <4.0 support was dropped post 1.8
Don't calculate `width / 2` twice.
They're URIs, so you're really suggesting `// Normalized comparison?`.
It might be good to add a pseudo-lexicon or otherwise comprehensive sample query to this comment block, to let users/developers know what the parsing expectations are.
Updated punctuation on all param descriptions and return values.
same question as ec2 policy
That prevents a rating being created for a user who hasn't solved a puzzle, but doesn't prevent users from updating other user's ratings. I really don't see this as a big problem, but I think we should use take care not to expose these holes if we can.
I would put your logic in processFeatures. You can probably check if the appropriate permission is also set from there. I believe we write the permissions to widgetConfig.permissions.

From: Matthew D'Andrea [mailto:notifications@github.com]
Sent: Monday, September 10, 2012 07:40 PM
To: blackberry-webworks/BB10-WebWorks-Framework <BB10-WebWorks-Framework@noreply.github.com>
Cc: James Keshavarzi
Subject: Re: [BB10-WebWorks-Framework] Prevent the auto deferring of networking and JavaScript when using run_when_backgrounded and/or the blackberry.push feature. (#164)


In lib/webview.js:

> @@ -60,6 +60,28 @@ webview =
>              _webviewObj.onNetworkResourceRequested = requestObj.networkResourceRequestedHandler;
>              _webviewObj.onUnknownProtocol = requestObj.unknownProtocolHandler;
>
> +            // Check if we should allow the networking and JavaScript engines to be available
> +            // when the app is running in the background
> +            if (config.permissions && config.permissions.indexOf("run_when_backgrounded") >= 0) {


@jkeshavarzi<https://github.com/jkeshavarzi> Hmm, looks like the permission check can maybe go in processPermissionsData. Where would the feature check go? processFeatures?

—
Reply to this email directly or view it on GitHub<https://github.com/blackberry-webworks/BB10-WebWorks-Framework/pull/164/files#r1571918>.



---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
Back in the day, npm didn't come with node. So they might only have node and not npm. Personally, i like explicitly mentioning they need both node and npm, that way they know both are required. Who knows, maybe they corrupted their npm install. By mentioning both, we are explicitly saying we require both to build and they should be in working order etc. My two cents.
I have a custom type extending collection in one of my projects (not the project for which I could use this bundle soon though)
was not aware of that line. very ugly, thanks for cleaning it up!