labofsahil/github-event-dataset-2012 huggingface dataset:
This is my solution https://github.com/przemad/sorcery/commit/8c9c5a8f82a1478f834d5433772c456d01f2633d
I try to prepare pull request in this weekend to fix this. There is no test for this yet :/
I'd prefer not to see these guys in any .cpp files, what made them necessary?
Have you pushed this yet? Can't see this after doing a git pull
Sorry, I intended to move this to clay.hpp in order to make things more pch-friendly but missed committing that file. Should be fixed upstream.
The issue will show up if non ascii characters are in the "comments" field, but as far as I understand choosing cp1250 or iso-8859-1 does not make any difference, right?
Helpers are global in most template languages. It would be pretty confusing to have identically named helpers in different templates.
:heart: :heart: :heart:

Renaming directory spec is missing right? Remember this is why we're doing that :)
Its black text on white background with the day-theme, just like before.
I think it's time to factor up the repetition in all these @receivers. Any reason not to?
Теперь, правда, он похож на новые иконки личкрафтов. Ну нет в жизни щастья.
Hab sie nur Automatisch ladend gemacht...aber man kann immernoch manuell laden (also da lädt man halt doppelt)
All it takes to make me happy is a clean and simple solution. I agree that logically all path handling belongs in clients.
why rename the loop from something that gives context to a generic term?
Finally, [these](https://gist.github.com/1605014) [gists](https://gist.github.com/1607610) and [this thread](http://groups.google.com/group/lokad/browse_thread/thread/903e77258ce4574a) and [this blog post](http://abdullin.com/journal/2011/12/18/tech-layer-of-cqrs-systems-pushing-it-further.html) are very worth reading.
I switched to make it easier to install in develop mode. I've switched it back to distutils now.
great... but for what version of nivo slider is this code working ?!
Ah yes. That's what I was looking for!
This breaks virtualenv on both PyPy and Jython which lack -x option.
And this is why we should try to use the library functions that we've already written (and maybe even debugged!) :-)
The commit message is badly written and confusing.

The implicit rules where not used and could not be used if CFLAGS do not contain the correct information provided in INCLUDES.
Better yet would be to upgrade to "Oneiric Ocelot" but that's a whole bigger fish I'm guessing.
Well, Windows is traditionally case-insensitive... Not sure if this should be transposed to bakefile but I don't see any real harm in doing case-insensitive matching of extension for MSVC.
Same here, no light level...
-Don't play with Fire!
And Fire lost all his friends.
Pour la sécurité, il vaudrait mieux ne pas donner en paramêtre le user, mais utiliser le user en session via Security.connected()
This didn't take for some reason - comes up 0000-00-00 in the table.
have a look at this commit : 0cb36f5
Heh. I remember someone telling me something like that once. ;)
What would be the best way to include only vmmlib in some headers, while still using EQ in others? Should I just use vmmlib include from EQ (libs/eq/fabric/vmmlib.h), instead of the original one?
I am still getting some crash (in mapping.py file this time ) with some "false" requests : 

echo -e "GET hostsss\n\n" | nc.traditional localhost 50000

=>

  File "/usr/local/lib/python2.6/dist-packages/shinken/modules/livestatus_broker/livestatus_broker.py", line 165, in main
    self.do_main()
  File "/usr/local/lib/python2.6/dist-packages/shinken/modules/livestatus_broker/livestatus_broker.py", line 222, in do_main
    self.manage_lql_thread()
  File "/usr/local/lib/python2.6/dist-packages/shinken/modules/livestatus_broker/livestatus_broker.py", line 579, in manage_lql_thread
    response, keepalive = self.livestatus.handle_request(open_connections[socketid]['buffer'])
  File "/usr/local/lib/python2.6/dist-packages/shinken/modules/livestatus_broker/livestatus.py", line 84, in handle_request
    result = query.launch_query()
  File "/usr/local/lib/python2.6/dist-packages/shinken/modules/livestatus_broker/livestatus_query.py", line 274, in launch_query
    self.outputcolumns = list_livestatus_attributes(self.table)
  File "/usr/local/lib/python2.6/dist-packages/shinken/modules/livestatus_broker/mapping.py", line 4505, in list_livestatus_attributes
    tableclass = table_class_map[table][0]
KeyError: 'hostsss'
I definitely think movie exporting should be required, there's always a bunch of unused crap in Flash documents. It's nice to be able to "remove" a movie by un-exporting it rather than deleting it from the Flash document (where it will be impossible to merge back). Also, if an artist is partially through creating a new movie, the Flash doc should still be exportable even though that movie is unfinished.
Hi,
Since the user manual link is only for vendors, no reason to include this in globals.inc.php . 99.99% of the time, this should not be modified and making it blank (or placing something there) just opens the door for basic users to lose access to the most recent online User Manual forever(ie. even stays there after upgrades)... If a vendor wants this, then they can manually place this token in the globals table (it is not that hard).
-brady
lose and the import mock
Fixed in 1e3ccd70520671469b68aa1a5f453672a2a13400. Let me know what you think.
Look good to me!
Still yuck, who did this >.>
It is indeed redundand, I hate it as much as you do. Internally, the session uses functions from both the request and response object, such as req.getCookie, res.setCookie, etc.

Functions only have access to their own closure. There is no way of passing the req & res object to the session, unless we pass them as parameters.

Suggestions for a different approach are welcome.
Thank you for sharing this. For those looking for a quick fix: this works as well when called from the form block itself, without patching:

`f.form_buffers.last`
you could just put all this in `if request.user.is_authenticated()`
just call the `device_type` column explicitly
Y U TROLL!?
Isn't `$size` a property that should be auto calculated? IMHO it shouldn't be possible to set a size that is different from the real filesize.
Bitch, please.
![Bitch, please](http://funny-pictures-blog.com/wp-content/uploads/2011/09/Mona-Lisa---Bitch-Please.jpg)
@VASGO how does it look crash-wise?
3 things I would like to say about this:
1. The entire 'if' was not necessary, so I've already removed it.
2. With async sugar you've recommended below, this becomes not relevant at all.
3. As a matter of principle, I don't use short notation for 'if'. It is error prone. Including explicit brackets always improves code readability. 

I may change my habit no.3 if you convince me such style is better.
spaces around `/`
This doesn't do it right. If you set the background-color of the grid back to white, you'll see that there's still extra space between the lines
The setCodebase method can go away now to, since this is the only caller.
the setup of a message happens multipletimes in the modul. please consider moving the code to a more generic function to reduce code duplication and PROGMEM usage,
Please disregard this commit. I screwed up and sent again. Please use commit a77e2aab instead.
This line prevents from calling [line #468](https://github.com/FB55/readabilitySAX/blob/a4d2699673eaed0427a2634607eb4c2329f5e93d/readabilitySAX.js#L468) so divs with only one element won't be unpacked. Result: https://gist.github.com/3e40cd83a863928a06ac#L51
FOR MYSELF:
payment method should be populated by the value and not the title (may be too late to fix this)
Awesome...this looks great!
I'm not saying it's a perfect analogy, but in POSIX you absolutely can expect the file to be unlinked regardless of what order and timing they were dispatched in.

In this case what we have is a delete operation that reports success but never resulted in the file never actually being gone. That seems different to me than having conflicting writes where one of them is never user-visible, somehow. I'd like somebody else to weigh in on it.
should be fixed now

I am still not 100% sure it's correct...
Thanks, I did not know about that "sticky" property. However i can't merge this fix since it will remove the support for additional headers by the callers. 
The correct fix would keep the default parameter to None and test if None at each call. If none, it should create a new Dict.
trasnform into fly form?
This is not working. By using the + operator to combine a string (`this.buffer = ''`) with a Buffer (`buffer`), there is an implicit `buffer.toString()` call happening. Which basically means this change does nothing.
This is a really bad idea in the middle of a long patch series, since it makes rebasing much harder.
Also, generally, you shouldn't just change indentation on a whim - I am fine with 2 space indent, but
it was 4 space before for a reason.
:v: Yeah !
-1 you reformatted the file as part of your addition.
See https://github.com/cgeo/c-geo-opensource/blob/valentine/main/src/cgeo/geocaching/utils/CryptUtils.java#L114
Very Nice Core Plz Give Me Updates
“Avoid the beginning of line operator '^'” - http://jflex.de/manual.html#PerformanceTips
You should not delete the anchor. This is used for fast navigating to a comment.
without that change, I can't see what's different between our two scripts and why you are submitting a push request :o
Git diff on GitHub isn't helping much to show the diff.
I actually prefer to keep this as a server header in my htaccess. Also, do you know if this has any effect on the layout of the admin screens?
Add from(String uri) and check for null
Этот кеш есть, как правило, у всех. Если взять шесть кешей в разных хранилищах, то это потребует больших усилий на поднятие окружения.
Nice update, by the way. :-)
Didn't actually center, but flushed to the left. Hmm.
This does fix the bug, but now there's repeated code; what about:

```
if empty_value is None:
    kwargs = {'%s__isnull' % field: True}
else:
    if (isinstance(queryset, SearchQuerySet) and
        'WhooshEngine' in
        connections[queryset.query._using].options['ENGINE']):
        # HACK __exact queries don't work on Whoosh:
        # https://github.com/toastdriven/django-haystack/issues/529
        kwargs = {field: empty_value}
    else:
        kwargs = {'%s__exact' % field: empty_value}
```

After some thought, I'm actually not sure we should be fixing this at all - the reason it's being forced to an exact query is that the default (__contains) gives incorrect results - might even error in some cases; don't remember any more, and I didn't mention it in the commit message. If it's causing problems for local testing, have you tried using elasticsearch locally?
Bitte mit festen Werten arbeiten
Just wondering, do you actually need to tell clang where your C++ headers are on your slackware machine? Should have been fixed since they rewrote the linux toolchain path stuff right before 3.0.

I'd be interested in fixing it if it doesn't work properly for you, so please let me know or file a bug report if you're having issues still.

(Also, if they're no longer needed maybe this should be removed from the example? :))

Thanks! :)
if you change here, you should also probably change in the __APPLE__ case.
Make it a parameter ?
See my comment on the issue :)
clearly got THAT wrong. But I think we know that's going on the request object ASAP
There are a number of outstanding patches to remove relative paths from `Minify` (see b1faa8e0f815e0882d2865cf30cc5de2d923dfad and 8d996ac8d2cb230b8fa2089f1d37966ee7cf781d). The change is valid, but I’d prefer the change was its own commit; that way, depending on which patch gets applied first, the others can be dropped during their next rebase on Pita/etherpad-lite@master.
Could not find anything about that where do I find them? Then I change them too
so basically, your stub can be like this:

```
core = 7.x
api = 2

projects[pressflow][type] = core
projects[pressflow][download][type] = git
projects[pressflow][download][url] = https://github.com/pressflow/7.git
projects[pressflow][download][revision] = 86e637864707e

projects[mydev][type] = profile
projects[mydev][download][type] = git
projects[mydev][download][url] = file:///path/to/mydev/.git
```

Downsides:
* Can't accept relative paths (so isn't universal)
* when you're working on a deployed site, can't natively do an edit-then-push in $DRUPAL_ROOT/profiles/mydev/ until you run `git remote set-url origin git@example.com:mydev.git` or whatever.
* Need to remember to go back and commit the newest submodule ref in mydev-build.git whenever you update the mydev.git profile itself.

Advantages:
* Can test changes to install profile without commiting, which keeps untested junk outta logs.
* Can't always keep the buildfile with the remote url in VCS, then create a quick copy for local testing, easy-peasy
* allow for an easy place to put tests and other files that easily stays in lockstep with profile, and if you're adding acceptance tests related to added functionality, this is helpful
* For cont. integration, you can granularly commit to profile itself, but just have ci server look for changes in mydev-build repo, so only when you update submodule will it launch the automated testing suite (presumeably when you're adding tests too)

Advantages. Can build
Well I agree, this is a matter af taste. I personnally like to know where my variables come from, I'm an "explicit over implicit" guy. And like you said, the "use strict" pragma and jslint agree with me (on this point at least). But hey, you're the boss! I'll do another pull request without this change.
What other ways can you change the paragraphs color?
isnt gunship done?
Not sure there's anything to do here is there? meta 'destruct' flag should already be set and we are not shrinking.
James,
switched to 1.6.M03, can't test because of low bandwidth, but this
should work better?

/peter

On Thu, Jan 12, 2012 at 9:13 PM, James Thornton
<reply@reply.github.com>
wrote:
> Hey Peter - I still am not able to build -- is the new SNAPSHOT live yet?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/neo4j/javascript-plugin/commit/33a1eb4d4c2799fd5cfc8053c9460066c996f357#commitcomment-862239
Heh, yeah, that would help :)

Another update coming tomorrow. 



On Jan 14, 2012, at 3:06 PM, Chris Peterson<reply@reply.github.com> wrote:

> @tompatros you might want to also make the constructors and some methods global as well, without that it wouldn't be possible to instantiate or do much with the class from other code.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/tompatros/Milestones-PM/commit/ddb62ba88f2e8affb18f78bf5bc5eaea4812574b#commitcomment-867678
It's frustrating, must be a bug On github I saw this message come up in my notifications, then clicked on it and nothing was there!

Anyway, I *think* the indents are being adopted simply as-is according to LSST policy, so hopefully we don't have to change anything Will check this!




On 28 Feb 2012, at 17:40, Rachel Mandelbaum wrote:

> Perhaps if you reply via e-mail, it only goes in e-mail to the other people in the conversation, but not onto the website?  Weird.
> 
> Can I put in my vote for 5*19?  19 is really a sad and neglected prime number.  ;)
> 
> And now for the serious response: Thanks for taking care of that.  The column width is one thing I was thinking of; what about spacing/indents?  
> 
> - Rachel
> 
> On Feb 28, 2012, at 8:29 PM, rmjarvis wrote:
> 
>> Barney, I got 3 code comments in email from you, but I don't see them on the GitHub website.  Hmmm...
>> 
>> Anyway, my edit was to correct one thing that had 80 and another that had 110.  So I figured I'd do 96 for you.  But 100 is fine too.  I didn't do 2*3*17.  :)
>> 
>> --- 
>> Reply to this email directly or view it on GitHub:
>> https://github.com/GalSim-developers/GalSim/commit/129154fb487ffc3a6b3a1471dc60c1635652056a#commitcomment-1023944
> 
> 
> -------------------------------
> 
> Rachel Mandelbaum
> http://www.astro.princeton.edu/~rmandelb
> rmandelb@astro.princeton.edu
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/commit/129154fb487ffc3a6b3a1471dc60c1635652056a#commitcomment-1023987

--
Barnaby Rowe

Jet Propulsion Laboratory
MS 169-237
4800 Oak Grove Drive
Pasadena CA 91109
United States of America

Department of Physics & Astronomy
University College London
Gower Street
London
WC1E 6BT
United Kingdom
how i cant download Db ???
КО КО КО КО КО КО КО КО СПЕРМОГУИДЫ
This will not work because TMPDIR is not set in this branch.
Will this overwrite the real connect.php I have in my folder but which is ignored from being committed?
Why exactly is this needed for .com?
isn't this the same test as the first test?
Should probably be squashed with: https://github.com/wolfc/shrinkwrap-resolver/commit/8d2965b8ae2bd8888e899f5d14a381cf1fac8019

Overall, what is leading to the issue as reported in the JIRA?  Would like to understand the failing case.
something like

```bash
convert -size 160x -background lightblue -fill white label:"TESTING" -format "%[label:pointsize]" info:
```

is possible
Signed-off: 39cc52d0dcaf7c3a83de00fbd03dc8f249ed3760.

Are there any post-receive hooks that scan for GitHub issue links? (e.g. yannickwurm/sequenceserver/#54). I'm usually a real comment-nazi so apologies for the vague-ness.
Any tips on handling the buffer. What I think I'm supposed to do is pull the char* from the system call and then traverse the file until I hit EOF and return the byte value in buffer, or a separate variable.
Look fine in general and I'dl likely merge the commit. Please remove the historic / anecdotical comments and double check the compatibility of licenses. Thanks for you effort!
I have tested, both with *= require active_scaffold and @import active_scaffold and it's working

- with sass, including active_scaffold with "*= require", @import line is in generated file
- with sass, including active_scaffold with "@import", active_scaffold_colors is included in generated file

I'm using rails 3.2.1, are you using rails 3.1?
I would quite strongly support Charles' notion that we _should_ have the ability to assign default locale's in dependent styles. Huge issue for medical journals, e.g., as the vanilla Vancouver style (rightly) doesn't have a default locale. Also applies to APA and, to a lesser degree, CMoS.
So yes, I'd very much like to change this.
You can use it to stage only some of the edits in the file for commit. When
you run this command, you will enter interactive mode where you can go
through all uncommitted edits and either stage them for commit, or not. You
can also split hunks into smaller ones or edit them manually, so you have
absolute control over what parts of your new code you want in your patch.

On Sun, Jan 15, 2012 at 16:23, Menachem D. Mostowicz <
reply@reply.github.com
> wrote:

> I don't understand what you mean. I do realize I should have separated
> this into two commits, but what do you mean about git add *-p*?
> How do I use it, and how would it help in this case?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/InvisibleEngineer/XKCD-Downloader/commit/cc821d27bbf8ce02c913a44651220b17fd9eef9c#commitcomment-868502
>
thanks fixed in https://github.com/Strawberry-Pr0jcts/StrawberryCore/commit/9874c232b50ae96310524377ab60acfc95ad93aa
Oh shoot, you're right. I guess I'd been worried about scripts that would conflict with the main sub's emotes... not about their emotes conflicting elsewhere. Maybe I should have the script remove !important tags so that the CSS from the sub you're on will take precedence (assuming its stuff is also !important).
Maybe I should create a bigger version of the filetype icon (48x48 instead of 32x32), otherwise it looks a bit lost there, isn't it?
> Personaly i would have split the route in different files :
> because with one file, all application are impacted by the twig configuration, even if you don't use twig in one route (which is the case for the main route).

If you look at [bottle_app.py](https://github.com/seedifferently/the-great-web-framework-shootout/blob/master/bottle/bottle_app.py) there the templating library is present on all requests, too.

> You should also add a test with doctrine because Silex allow Doctrine Dbal and it would be a fair benchmark compared to other framework.

Again, look at the bottle test, no wrapper is used there.

My aim was to compare Silex to other self-proclaimed micro frameworks.

You should also add a test with doctrine because Silex allow Doctrine Dbal and it would be a fair benchmark compared to other framework.

But that's a nice work, i didnt' have the time to pull my request ;-)
Also also, note that `Rack::Request` has an `xhr?` method, so we could use `Rack::Request.new(env).xhr?` instead.
@ilikenwf https://github.com/nightingale-media-player/nightingale-hacking/blob/sb-trunk-oldxul/build/sbBuildInfo.mk.in

BTW can we take the same id in https://github.com/nightingale-media-player/nightingale-hacking/blob/sb-trunk-oldxul/app/application.ini.in ? songbird@songbirdnest.com ? I'd prefer using another one (but still leave names, so we can automatically migrate applications by adding nightingale@getnightingale.com) to ensure we won't run into issues with nightingale-specific features in add-ons for both applications.
I'm don't think we want to add one-more layer of synthetic event indirection for performance reasons. We just need a place to stick the lookup map. I'd recommend Y.Event.GESTURE_MAP, or Y.Event._GESTURE_MAP, or something with gesture in the name (as opposed to touch).
Sorry about that Evan, should be fixed in my next commit 90e4750.
Accidentally removed this..added back.
tell vs. !
for two adjacent lines of code I think you should stick to the same
Ah, good catch. Thank you.
keeping this at class-level is a bit irritating, why not just have local vals in the test cases?
wosh. thanks drewhk. Haven't seen that jargon before. Don't suppose you have any links handy that elaborate? Tried googling "applicatives compose". Found this: http://stackoverflow.com/questions/7040844/applicatives-compose-monads-dont . Oh-no. Monads. *sigh*
Why the Some(...)?
This is very similar to the other one.  I fixed it in the forward branch by making all the *_id and related functions work correctly in spite of the missnamed AR fields.  That may be another small increment we can bring forward.

It also sometimes fetches missing card_ids.  Fixing those methods means we can use card.tag_id over card.tag.id or even x=card.tag and x.id in many places.
card.codename == :recent
We'll have to cover this interactively, I think we are looking at different parts of the issue.
Why is this paragraph removed?
Not clear what this does from description.
I agree with the first argument (use step). But I would suggest to have the entire object as input not only the function. I think it looks nicer this way. Then link object.step inside MarkovIntegrator, e.g. self.take_step = stepper.step
Oh wait, would the group_ actions delegate to organization_ actions if the group type was organization?
Done. I've added a small commit clarifying things.
same as before, might be nice to not mix single and double quotes.
Wow, I did not know you could do that!

I'll just add that all python functions which do not have a return statement will return None. That's why I was saying it's optional.

```
>>> def foo():
...  pass
... 
>>> x = foo()
>>> x is None
True
>>> foo() is None
True
>>>
```
can we just use the mutations.tail timestamp?
I see. I used it because it was also used in the original code in <code>PVRRecordings.cpp</code>.
code can only be seen if you're logged in and have seo privileges. i need this approved so I can show it to jo ann.
To można uprościć tworząc serverTime w Smarty tylko w przypadku, gdy to co sprawdzasz powyżej jest spełnione, a te sprawdzanie powyżej również można uprościć używając np. funkcji check_conf() z lib/config.php (zajrzyj tam).
Are you sure it's MSVC10 (rather than MSVC100)?

Sorry, I have no MS VC install to test that variable myself.
Similar to your suggestion for redirect_id, I now agree this form is cleaner.
Maybe consistent with the render functions for views, _email would be without perm checks?
fix whitespace. check for using tab's instead of spaces ...
QTimer is not actually used in this file.
This is the main thing which gets the handlers setup properly
At the top of the function, I set `cb` to the empty function if `cb` is falsy.
As a result, there is no need for that `if`.
This should be an `NSUInteger`.
These as well.
Also entirely in spaces
Poor baby jesus, I'm still trying to figure out nodejs style for private/public I can fix that no problem.

I opted for a separate queue for two reasons, it seemed like too much work to special case 0 such that when the queue was empty it didn't destroy itself. And second, my interpretation of the draft spec made me think that I should yield after each item was processed instead of processing all of the queue when the timer fired.

I was thinking that the timer for the immediate queue should get lazily created on first use of `setImmediate` though
Isn't that the existing behavior for Unix and Windows?  getenv returns NULL  if there is no match.
содержимое этого if-а хорошо бы вынести в отдельный метод с говорящим названием
скобочка не там
@carlosantoniodasilva you mean if  ```option[:root] ``` is false?
If, for some reason, you provide both objetcs and strings/fixnums, this will break.
`#{count || 0} #{word}"`
Same here, I don't think it's required.
@rafaelfranca thank you. I removed this line too.
I'm wondering if this is thread-safe cc @tenderlove
Well, my personal preference is for the other option, but there's no need to change just because of my preference :)
Yep. Fixing.
Didn't we agree long ago that it should all be specified in terms of Product, not Tuple?
Notice: I remember at least another use of intercept (and friends) in FutureTests, TryTests, etc.
```ruby
transformed = event
```
Maybe default it to the event so in the case of errors (transformer error/unknown) the original event is returned.
You use caching quite a bit. I think it is better to use SymPy's solution for this 
add ```from sympy.core.cache import cacheit``` to your imports

add ```@cacheit``` to as a decorator to your function. (below ```@property``` I think though I'm not sure)
I think something got cut off from this sentence.
all of the other functions use an underscore as PEP8's suggestion. So why not angular_momentum and linear_momentum?
I know it's not likely, but this is going to fail if you have lots of variables. Perhaps ti's just better to test and raise an error if there are more than 26 variables;

```
if len(variables) > 26:
    raise NotImplementedError('only 26 boolean variables, A-Z, are supported.')
```
Please add `**kwargs` handling to `doit` and pass those to `_eval_trace`.
It's http://en.wikipedia.org/wiki/Jacobi_identity.  Apparently `[A, B, C]` means `[A, [B, C]]`, which I've never seen before.
the default value in `new_defaults()` is `list()`, so probably just need `opts_template = new_defaults()`
In the interest of potential mingw compatibility (specifically, mingw cross-compiled from *nix), I would suggest Windows headers should be lower-case (as that is how they are in the w32api headers)
Fixed in 	421740d
the import of everything in `units` should definitely not be here, as it fills the primary namespace with all of the units.
On 28 Dec 2012, at 13:26, Ben Noordhuis wrote:

> Using strndup() here is superfluous if you're calling strlen() anyway.
> 
> 
I think so too, but this was copying what other code close to that did on the grounds of being stylistically-compatible with it.  Would be happy to change it either way.
lower case, suffix with _struct, suffix the type with _t
::FileUtils.mkdir_p means search for method in FileUtils core gem (correct place)
FileUtils.mkdir_p means search for method in BBFS::FileUtils (incorrect place)
listDomainMembers -> listRepairActionsForPair
Would it also not be an idea to illustrate which setting is the default by defaulting the radio button?
Is this not the same as saying setSystemHardLimit(limitName, -2)?
as a note, perhaps. I'm not wed to it. 

Replica pairs are 2009/2010 era...
The first sentence narrows the context to "spherical queries," I'm unclear why you reiterate this context in the last sentence.

Refactor this paragraph in light of the change to the first sentence: I think it can become a lot more clear. Focus on what the command does and why/when you'd use it.
Should be:
```
* User object
* var phpbb_user
```
Now here, unlike acp, the event name is prefixed with mcp.
That seems like a valid reason to deny any code that uses it, then. What do you suggest I do, manipulate input given to it? The JSON and the XML output should be the same, but one should be XML and the other should be JSON.
Fixed in the previous push
Why is there a ?> here? Wasn't the idea to remove all of them? Because then a newline wouldn't make a difference.
$(target) once
Actually, the rest of the function.
Hmm you're right, the extra space was added by me, not removed. My bad.
This is added here because otherwise, functional tests do not work. I had to add it before these tests because they are run before the ones I add. If this _has_ to be a separate pull request, I can do that.
ето тук ще даде грешка ако няма _activity_content.rss.haml partial и дори няма да погледне _activity_content.html.haml :(
Това само по себе си е чудесно, но лошото е че двата partial-a са идентични..
Не можах да измисля начин да мина само с един :(
was that an unmatched #endif?
Point taken. It's not as big a deal in server-side JS, but can be a huge performance issue when iterating over client-side "dynamic lists" such as HTMLCollection etc.
what do you mean "Don't change anything below this point"  :) ? seems like a bad sign :/
units="1" is unnecessary as it is the default.
这样很多地方就不用去做迭代。再管理上也稍微方便些
groups[index]这种多次被用到的对象，用一个临时变量缓存起来。
"have the same"
Oh now I see your point of let java do the job.
doesn't add empty serial number
I think we should go towards having our primary action buttons "continue/submit/etc" in the lower right corner.
This is very abstract, very powerful, but I found it a little hard to pick up the flow of the logic.
Maybe an example of the query object that is expected here may make this a litte easier
Yes, but if it's callable I'd say it might be sensible to never even use it for table creation in the first place - examples of callables people have used are random.randint and uuid.uuid4, both of which you really shouldn't make rows with.

I'd vote for the core schema system raising an error if you try to add a not-null column with a callable default, and to then make migration frameworks detect this error and prompt the user if they want to add the column with a frozen callable result instead,
@Krinkle I guess... I'm just not sure of the benefit there considering I'm just reverting that line to its old value, and none of the other code depends on the return value. I think it's a bit of YAGNI.
Confirmed the -1 byte. Ah, whatever.
0.0001 seems like a magic number here. Can we be certain that this condition gets met?
btw, this pull request is awe-inspiring.
Here, I try to delete it assuming it to be a Windows style symlink, by using `del` and `rmdir`. This way a `rm` will not directly cause all files in the `node_modules` folder of ` dev_bundle/lib` to be removed, but do remove a Linux style symlink.
The node_modules symlink has to be handled differently on Windows.
Two things:

1. I'm not sure there is an auto_now_created. Do you mean auto_now_add?
2. Assuming you mean that, it only sets it when the object is created. You can override it after that.

https://docs.djangoproject.com/en/dev/ref/models/fields/#django.db.models.DateField.auto_now_add
This should get reordered:

```
import json

from django.http import HttpResponse, HttpResponseRedirect
from django.shortcuts import render

from funfactory.urlresolvers import reverse
from mobility.decorators import mobile_template

from fjord.feedback.forms import SimpleForm
from fjord.feedback import models
```
A witness of my Python heritage.
good point, using heredoc instead
The 3 condition logic is just looks messy and passing `nil` around is a bit of a code smell.
This file should probably not be in the repo
So the issue is that when we remove the items, we keep the image object in the imagepool cache, keyed with the filename and if we get that filename again, we use the old image right?

I think we could still run into the issue with the items in message.added then, it's just that we don't because of the timing of iconcache updates.

Could we add an mtime to the imagepool cache and check that when we want to fetch images?
Fixed by arranging for Publisher.publish_message to return the message in its deferred.
This is an assertion that the migration machinery is working correctly. We don't really need it in actual migrations.
I was wondering ;)
The `resources` path looks odd to me. Could we put the examples under `src/examples` instead? I guess it wouldn't affect the rest of the build process. (It'd actually be kinda nice to know that the examples compile, which was the case with the old build scheme.)
you already have the ``getProjectRoot()`` function. no need to declare another function inside it just to call it recursively.
Be explicit with your exception catching.
This should be "&" instead of "%".
But I suppose most of those attitudes are checked manually anyway and 
never get to starcheck :-).  Alright alright, I'll stop talking and fix 
code.
I am quite astounded that these test cases actually work! Well done!
This was discussed in chat, totally correct usage.
Duh. That makes sense.

It didn't occur to me that you were locking to protect the dictionary, not to ensure correctness of the `Get` operation.

Maybe that's a good reason to use `ConcurrentDictionary`, so it's more obvious that you're handling concurrent usage of the dictionary?
whitespace removal ENABLED
This unit test was passing incorrectly before. It asked AttrHints for hints on the following line
``<h1 id='foo'>Heading</h1>``
directly after the equals sign. But there should not be attribute value hints here. Instead of removing this broken test, I'll replace it with one that asserts that there should *not* be hints in this position. I'll also keep the new test, which instead expects (and finds) attribute hints on the following line: 
``<style type="text/css">``
again directly after the equals sign.
ok, I'll try to translate tomorrow, otherwise I'll revert my change
Oops, strike that too... these are maps, not arrays.  Could you rename 'i' to something more clear, like 'agentName'?
typo: uncomented
The browser version only fails when loading brackets as a file url ``file://path/to/brackets``. It works fine otherwise, assuming that it's hosted using the node-server branch. If I recall correctly, the node branches modify this to determine the brackets src path in a different way. We can probably just dump this block altogether.
Actually, my example was wrong. Sorry :) I was thinking of a false positives like `if (err) log("oh noes")` or `if (err) fixError()`, so cases that don't include the `err` argument.
This listener doesn't handle return key when pressed
That's why I had to add my commit
@jjac, what's going on with this at present?
direcoty
ah, snap. Good catch.
OK, you can also overlay, but then you have to change URL in some way (for example using URL anchor) so that we user can bookmark/copy link to results. Copy+pasting the URL should open the same page content.

For search I do not think we really need overlay. (Facebook does not have it. And in general I do not really like overlay. Do you?)

But it is OK as it is. It is good to have different approaches.
If it's a different locator then it's a different element, and available at different times. I would suggest two properties: register_password and login_password. The existing tests would need to be updated. We should not have logic in the page objects that decide the locator to use - that should be down the the test/scenario imo.
`font.value = font.label = ...`
check for `!CACHED_RESULTS[ query ]` once, then jump into checking for options.username/options.search, or "buildTheTweets"
remove the px for the 0
Yea as per what humph nailed me on we can do:

```javascript
if( ..... )
  if ( item[ "default" ] ) {
    return item[ "default" ];
  }
  return item.type === "number" ? 0 : "";
}
return val
````
ooops :S

I read the constructPlayer method instead haha, my bad.
Cache this function.
Another legacy step i didn't refactor:
```
Then /^the app on the page should have a link to a database named "(.*?)"$/ do |database_name|
  page.should have_css('#database', :text => database_name)
  page.click_link(database_name)
end
```
should sort the imports on all files
Fixed in 729df15
You're right--depending on your API setting, some tests will be skipped. It was the only way to swing it because the urlpatterns get created as a side effect of loading the module. So whatever the module shows at the time it's imported--that's the url patterns. And whatever the setting is at module import time, that's the url pattern.

Anyhow, so using ``override_settings`` doesn't work because by the time the test is running, it doesn't matter what ``API`` is set to.

This totally sucks. We've bumped into exactly this before when we were fiddling with opensearch suggestions. In this case, I think it's prudent to really have the API off.

If you set ``API=True``, you run all the API tests. Only one is skipped--that's the "API is disabled" test. However, since we disable the API by default, it means that travis won't run any of the API tests. That sucks, too.

I don't know how else to do this short of wrapping all the API url view functions with decorators that switch one way or the other depending on the API setting. I don't know how to do that offhand, though.
We should create a modelmaker for ``user()`` and maybe one for ``superuser()``, too. We can put them in ``richard/richard/tests/utils.py``.
I can't tell if you're commenting on the right pull request or not. I think this one is just about changing the style of the prev/next buttons, but it seems like you're talking about how to show a page of things.

Does the question you're asking here affect this pull request? If not, then we should move it elsewhere so as not to stray from the topic here.
Ah oui erreur d'inattention :p
# cat /proc/sys/kernel/domainname
(none)

We probably should handle this.
this could be `is` rather than `isequal`?
(or even check for `lst.length == 0`)
Indent this block, please?
ah no, sorry. It is checking the attributes themselves
I would really prefer to keep the number of packages as low as possible: maybe add version to  semolina in:

=Prv: walrus <= 2-5
=Req: semolina

so you don't need to introduce new ones. Please see here: https://github.com/akozumpl/hawkey/blob/master/tests/README
Your indentation leaves something to be desired.
I think the warning should be made only once, not every time get_current() is called - see my longer comment below.
Whoops, that wasn't supposed to be there
Should be moved down to maintain alphabetical order by class name.
Fixed this. it had to do with some weird behavior with erlang strings. Well, weird to me anyway.

Escape a tilde in a format string is ~~ but in a regular string is \~. Thanks for the consistency erlang!

Fixed and whatnot.
A scoped lock is acquired where you define it with LOCK(), and it is released immediately at the end of the block (`}`) in which you define it. So, yes.
Yes, that shouldn't be there. Whoops.
these checktx changes do look useful, but again... separate commit, not glommed together into a single "improve debug.log output" huge commit
Bitcoin-Qt has always been the official name of this Qt client.
Please follow cake's [coding conventions](http://book.cakephp.org/2.0/en/contributing/cakephp-coding-conventions.html).
browers -> browsers.
No, tested successfully in IE9, FF14 and Chrome 21
I know Redis class is the hard dependency of RedisCache.
But, for avoid confusion, i used same convention with ```MemcacheCache``` driver. 
https://github.com/doctrine/common/blob/master/lib/Doctrine/Common/Cache/MemcacheCache.php#L49
That's what I mean. Can we make it so that the client side image *does* exist, so that we don't need this call?
OK.  If the pipe is None, then the snap should just be given the data object unmodified, I guess.
runs_left
Do these need to be ordered?
А может лучше флаги в конец засунуть? и лучше всё-таки bool withLyrics
This is in a "working" state but needs a few more changes:

The getNextOccurances api needs a little more work, I think it should return three things: the event object (the exception when required) start date and end date. End dates are not handled anywhere yet and will require a bit more work. The current support in recur is enough but it assumes that the start date given has the same minute seconds as the original DTSTART. This is not always the cases (in my tests and gaia code) so the RECURRENCE-ID's where not aligned with the output of the recur iterator.
Looks like this function should be `const`.

Btw I get the impression a lot of these minor issues are actually in code copied from the SDL Mana client. Maybe you should apply those fixes there too?
I think you should only append nodes with a template here. That would simplify the other methods because they all look for nodes with a template.
When possible, use the {{ url('named.view') }} to generate URLs. I'm not sure you can do that here if the view doesn't exist yet. If it doesn't exists, use the php_url method which you've used elsewhere.
This says top 50, but the code below says top 60. Am I just conflating unrelated things?
It might be interesting to put a statsd call here, too.
Use ImpermanentGraphDB?
sorry, I meant ontology_versions should reference logic
Agreed - will do.

On 10/6/2012 9:15 AM, plaa wrote:
>
> In core/test/net/sf/openrocket/rocketcomponent/FinSetTest.java:
>
> >  import net.sf.openrocket.util.LineStyle;
> >  import net.sf.openrocket.util.BaseTestCase.BaseTestCase;
> >
> >  import org.junit.Test;
> >
> >  public class FinSetTest extends BaseTestCase {
> > -	
> > -	
> > +
> > +	@Test
> > +	public void testCGComputation() throws Exception {
>
> Please split these up into separate test cases. There's no reason to 
> have then in one method, as they're clearly separate. E.g. 
> testCGTriangularFin, testCGRectangularFin etc. The test case name 
> should also explain what the test contains, it's hard to deduce from 
> the numbers themselves.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/plaa/openrocket/pull/3/files#r1779419>.
>
Yes, i just created an issue: #188
But it's already in all tests files... :P
I checked this locally and it seems to work without the `.js`

Also... just a question... does require.js always require the full path to the file relative to the root? I noticed you put `../lib/utils.js` even though the file is already located there.
``php composer.phar install --dev`` as it is about the tests
typo: might or might not
It seems strange that you have to set both `HOST` and `STAGING_HOST`. Can't you just set host in the environment files or Heroku env?

Also, `HOST` is frequently used to refer to the host that THIS app is running on, so you may want to name it `YAMMER_HOST`.
:thumbsup: Thanks for cleaning this up :)
禽兽，这个文件都说了不用评审的，review下面的。
const DGtal::Color &aColor
?
Этого здесь быть не должно. Эта инициализация должна быть в конструкторе игрока
Между методами надо пустую строчку оставлять
I was actually under the impression sizeof(char[10]) would return 1. So, yeah, definitely makes more sense here.
space before :ident
Incorporated.
已改为通过配置文件来设置要搜索的域名
[https://github.com/leizongmin/nodeclub/commit/06740d8a9acfafc78fd276ab389b80c5fa2c2fe3](https://github.com/leizongmin/nodeclub/commit/06740d8a9acfafc78fd276ab389b80c5fa2c2fe3)
``unicode`` instead of ``str`` maybe?
Same as KEYSTORE_PROVIDER_ARGUMENT
Right - configuring passivation="false" means that the cache store behaves as a write-through cache.  Otherwise, sessions would only persist to disk when evicted from memory - which means that a server crash would lose sessions (i.e. any "active" sessions).
This results in attributes being resolved in Stage.MODEL instead of Stage.RUNTIME. That is usually incorrect.

I know what you did here follows what RemoteDomainControllerAddHandler did, but I wonder if RemoteDomainControllerAddHandler has a bug.
Agreed, no need to change 7.1 now. If we are still doing it in master then we can clean that up. I'm actually going to start/stop my local instance built from master later today to see if it really writes out the newline or if there's some common code which cleans up these extra newlines, because I think someone would have noticed these extra newlines by now and reported it.
That does not look like a useful default. Might as well drop this and use "currentDesktop" as the default.
nit: settingoption -> setting-option. Or camel case.
Reminder: Please don't forget to add the dialog to the :-moz-full-screen-ancestor group, just at the bottom the `z-index.css`,
App-install-dialog should be able to prompt behind the app who triggers mozRequestFullScreen.
// This function can be replaced with StringEncoding API:
    // https://bugzilla.mozilla.org/show_bug.cgi?id=764234
assert.matches(el.className, /\b.../)
Damn it! Try to remove the p's inside the div... ;-)
Should I remove the rest of homescreen.xx.properties that aren't already translated or keep them empty? thanks
We don't need the closuse when using setTimeout argument passing feature.
And these focus/blur calls allows to hide/show the keyboard correctly when displaying an attentionscreen on top of attention screen.
For example when being on USSD screen with a keyboard and receiving a call.
Without that, the keyboard stays.
let's remove this ms rule :)
Wow, did you run those tests? :)

Sadly we aren't able to move them to the new testing tools right now (explaining why they're still there).
But I don't think they run anymore :/
The event does fire if items is empty, it will be []
Ah, I wondered whether those units needed localising, thanks for the heads-up!
Yeah. I stole these templates from bedrock. Should have double checked.
Seems to work. Changing across the site.
Not sure it will work for all PHP versions. You should avoid the use of namespaces in the code, and use the `declareClass()` method.
Deprecated as of OS X 10.6. Simply updated naming.
我觉得返回最好是个Date对象，可读性高一些，而且使用起来也方便
Include these lines in the issue you add on GitHub (see above, `batch_put`).
Get rid of this extra line.
So you know where we made the changes
Make this a multi-line string.
We need to make sure this will work on different sizes as-well.
Also add a behat test for that.
Should be `integer|boolean` according to note.
Yes, the changes are overlapping, it's the reason why it's more difficult to follow :(
Add ARCHIVE_ to each of these.
Could you change TargetNotAllowed in the same commit?
Shouldn’t this either be a `warning` (if it’s not really supposed to happen) or an `info` (if it is)?

Also, I think it should give some indication what the slug was, so we can inspect it in the logs later.
please add an example format so that we don't have to read code to understand how to fill out the yaml during deployment
On Mon, Mar 26, 2012 at 1:33 PM, Stefan Zager <szager@gmail.com> wrote:
> On Mon, Mar 26, 2012 at 12:42 PM, Tom Prince
> <reply@reply.github.com>
> wrote:
>>>
>>>      :param miss_fn: function to call, with key as parameter, for cache misses.
>>> -        This function *must* return a Deferred.
>>> +        The function should return the value associated with the key argument,
>>> +     or None if there is no value associated with the key.
>>
>> This looks like you have tabs instead of spaces here. Also further down.
>
> No tab characters that I can see...
>
> $ grep -P '\t' master/docs/developer/utils.rst
> $
>
> ?

My bad; I was looking at an old version.  I'll fix this.

Stefan
Theses tests should probably be moved to a callback added to the deferred returned by `self.runStep`.
Couldn't you just put parens-- once on the line before and not alter the if-return block?
Oh, you got it. I think using debug macro is better.