[GTK] Test /webkit2/WebKitPrintOperation/print-errors gives runtime critical warnings
https://bugs.webkit.org/show_bug.cgi?id=98497

Reviewed by Martin Robinson.

The problem is that GTK+ tries to write in the IO channel that has
already been closed.

* WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::WebPrintOperationGtk::print): Finish the surface when
printing fails because printing data is invalid.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Mac] REGRESSION (r130411-r130414): fast/images/repaint-subrect-grid.html failing on Apple MountainLion Debug WK2 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=98523

Unreviewed gardening after r130414.

* platform/mac/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: [Styles] Unable to edit properties in broken stylesheets
https://bugs.webkit.org/show_bug.cgi?id=98246

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Pop source data for invalid rules off the stack whenever we have consecutive CSSParser::markRuleHeaderStart() invocations.

Test: inspector/styles/parse-stylesheet-errors.html

* css/CSSParser.cpp:
(WebCore::CSSParser::popRuleData):
(WebCore::CSSParser::markRuleHeaderStart):
(WebCore::CSSParser::markRuleBodyStart):
* css/CSSParser.h:
(CSSParser):

LayoutTests:

A small refactoring to share the CSS style data dumping code among tests.

* http/tests/inspector/elements-test.js:
(initialize_ElementTest):
* inspector/styles/parse-stylesheet-errors-expected.txt: Added.
* inspector/styles/parse-stylesheet-errors.html: Added.
* inspector/styles/styles-new-API.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Unskip fullscreen unit tests for EwkView
https://bugs.webkit.org/show_bug.cgi?id=98509

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-05
Reviewed by Kenneth Rohde Christiansen.

Update 2 fullscreen unit tests for EwkView so that
they don't require a call to ecore_evas_fullscreen_set()
to succeed. ecore_evas_fullscreen_set() does not
seem to work in Xvfb and causes the tests to hang.
With this update, we can now run those tests again.

* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Only inflate the height of rows in a popup menu when a touch device is detected.
https://bugs.webkit.org/show_bug.cgi?id=98515

Patch by Kevin Ellis <kevers@chromium.org> on 2012-10-05
Reviewed by Adam Barth.

Enforces a minimum row height for popup menus when a touch device is
detected.  In a previous patch (r127597), the sizing of popup was
consolidated for touch and non-touch.  Based on user feedback, reverting
to the old behavior for non-touch and only adding padding for touch
devices seems like a much safer strategy.  This patch is not a direct
revert of r127567 since the padding previously used for touch is a bit
excessive.

Covered by existing tests.

* platform/chromium/PopupListBox.cpp:
(WebCore::PopupListBox::getRowHeight):
* platform/chromium/PopupMenuChromium.cpp:
(WebCore):
* platform/chromium/PopupMenuChromium.h:
(WebCore::PopupMenuChromium::optionRowHeightForTouch):
(WebCore::PopupMenuChromium::setOptionRowHeightForTouch):
(PopupMenuChromium):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[WK2][WKTR] Avoid duplication of UIClient callbacks for main page and other pages
https://bugs.webkit.org/show_bug.cgi?id=98503

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-05
Reviewed by Kenneth Rohde Christiansen.

Avoid the need for duplicating UIClient callbacks for main page
and other pages by passing the view as clientInfo
for those callbacks.

Previously, callbacks for the main page were passed the
TestController as clientInfo while the callbacks for other pages
were passed the PlatformWebView as clientInfo. This was error prone
and leads to useless code duplication.

* WebKitTestRunner/TestController.cpp:
(WTR::getWindowFrame):
(WTR::setWindowFrame):
(WTR::runBeforeUnloadConfirmPanel):
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
(WTR::TestController::decidePolicyForNotificationPermissionRequest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Replace uses of prefixed properties with unprefixed versions in the UA stylesheets
https://bugs.webkit.org/show_bug.cgi?id=98453

Patch by Tab Atkins <jackalmage@gmail.com> on 2012-10-05
Reviewed by Ojan Vafai.

Switched 'border-radius' and 'box-shadow' to their unprefixed version in the UA stylesheets.

No new tests, because the unprefixed properties have the same behavior as the prefixed.

* css/fullscreenQuickTime.css:
(video:-webkit-full-screen::-webkit-media-controls-panel):
* css/html.css:
(keygen, select):
(select[size][multiple]):
(select[size="1"]):
(::-webkit-validation-bubble-message):
* css/themeBlackBerry.css:
(input, textarea):
* css/themeChromiumAndroid.css:
(select[size][multiple]):
* css/themeQtNoListboxes.css:
(select[size][multiple]):
* css/themeWin.css:
(select[size="1"]):
* css/view-source.css:
(.webkit-html-message-bubble):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL][WK2] Fix mktemp() compilation warning in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=98493

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-05
Reviewed by Kenneth Rohde Christiansen.

Fix wrong mktemp usage causing a compilation warning
in MiniBrowser.

* MiniBrowser/efl/main.c:
(on_download_request):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130517 268f45cc-cd09-0410-ab3c-d52691b4dbfc