labofsahil/github-event-dataset-2012 huggingface dataset:
First, using "l" and "i" as variable names is icky. Second, I prefer my implementation of this in kitsune:

https://github.com/mozilla/kitsune/blob/master/apps/search/utils.py#L38
Rebase your PR, and it will fix this stuff I guess
btw, I'm not sure this `default.properties` file is style needed..
I think that removing this, rather than having it "half work", is going to be less painful for users.  @zaphod42, do you have an opinion?
Looks like this description is wrong. It raises an exception and the description says otherwise.
I've moved the untaints back to there original locations
Why was this spec commented out?
Right now, no.  But I can add one easily if you like.

On Mon, Oct 8, 2012 at 4:37 PM, sbarman <notifications@github.com> wrote:

> In scripts/background/mainpanel.js:
>
> > +      var panel = this.panel;
> > +      var record = this.record;
> > +      chrome.windows.create({},
> > +        function(newWin) {
> > +          //let the panel know which events it shoudn't record
> > +          panel.twinWindow = newWin.id;
> > +          //let replay know where to simultaneously replay
> > +          record.simultaneousReplayer.twinWindow = newWin.id;
> > +          //start record
> > +          record.startRecording();
> > +
> > +          // Update the UI
> > +          chrome.browserAction.setBadgeBackgroundColor({color:[255, 0, 0, 64]});
> > +          chrome.browserAction.setBadgeText({text: "ON"});
> > +        }
> > +      );
>
> Is there a way to enable / disable simultaneous replay using a preset
> parameter?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/sbarman/webscript/pull/1/files#r1790346>.
>
>
The `title`s all seems to be oddly-indented
s/can't be iterate/can't be iterated over/
This will be addressed later after limit and offset have been implemented
Why removing ArrayUtils again?
Return immediately after you have the hydrator.
Needs `// CraftBukkit` tag
will need to be config later
can you add "--min-version 1.0.2 " in front of this line?
shouldn't all these new lines be added at a different date ? the refactoring was not done on August 20th
I'll take another stab at doing these through EF instead of SQL. I couldn't get the resulting SQL quite where I wanted it, but they're simple now, so maybe I can.
Please add the unit tests themselves too.
This should probably use -> getTableName(), I think.
Code style:

Space around arguments: `text.trim( newTaskName.copy() )`
Please fix the phpdoc by giving the right types if you write it.
pub adds the symlink in tests now :)
The code is extract method, it was this way before.
You can inline this semantical error. It won't exceed 120 chars
this code as been copied from CouchDB .. so i guess the issue is there as well /cc @beberlei
Returning an empty string seems like a good compromise, I like it.
...which would make them like Elixir for flattering them.. :)

On Sun, Oct 21, 2012 at 3:46 PM, José Valim <notifications@github.com>wrote:

> In Makefile:
>
> > @@ -38,7 +38,8 @@ erlang:
> >
> >  lib/elixir/ebin/Elixir-String-Unicode.beam: lib/elixir/priv/unicode.ex lib/elixir/priv/UnicodeData.txt
> >  	@ echo "==> unicode (compile)";
> > -	@ bin/elixirc lib/elixir/priv/unicode.ex -o lib/elixir/ebin;
> > +	@ echo "This step can normally take up to a minute to compile in order to embed the Unicode database"
>
> Ok, i just removed the normally then, otherwise people would believe they
> have super fast machines! :P
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/elixir-lang/elixir/pull/563/files#r1899399>.
>
>
Curious to know where this is coming from.
maybe also make a no_reserved_filter_search, eg to ignore project groups, VOs, other? (does that make sens)
Broken up into functions.
Building `packed-groups=False` and ictce toolkit now seems to yield a correct build: the demos work, and so does the user's testcase.

I must have changed something along the way that causes the packed-groups to be no longer necessary (possibly something in 8ab0789?).

I am not going to change it back to break it again. Let's just build with packed-groups enabled for ictce, and trust that one of the demos will fail if we (or someone else) happens to build it wrong again.
Not sure how compelling the case is. I can imagine someone wanting to
direct the output from ProgressFormatter to the console and the output from
HtmlFormatter to a file. Presumably that's why RSpec supports it and I just
emulated their syntax.

On Mon, Oct 8, 2012 at 1:21 PM, John Firebaugh <notifications@github.com>wrote:

> In README.md:
>
> > @@ -112,6 +112,22 @@ $ bundle exec rake konacha:run SPEC=foo_spec
> >  $ bundle exec rake konacha:run SPEC=foo_spec,bar_spec,etc_spec
> >  ```
> >
> > +Konacha includes a default formatter modeled upon RSpec's ProgressFormatter.
> > +Additionally, Konacha's runner implements the same protocol as RSpec, so many
> > +RSpec formatters also work with Konacha.
> > +
> > +To specify one or more formatters, provide a comma separated list of class names
> > +to the `FORMAT` environment variable. Output can be directed to a file by
> > +appending a colon and the file path to the class name.
> > +
> > +```
> > +$ bundle exec rake konacha:run FORMAT=Konacha::Formatter,RSpec::Core::Formatters::ProgressFormatter
> > +$ bundle exec rake konacha:run FORMAT=Konacha::Formatter:results.txt
>
> Is there a compelling use case for the colon redirect syntax that isn't
> satisfied by built in shell redirection?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jfirebaugh/konacha/pull/67/files#r1788543>.
>
>
I've never had a problem with it, since I first heard the recommendation to use it somewhere around 2007.  A quick and dirty google suggests that the most recent browser to not support it was Safari 2.0.1.  (Gleaned from this Stack Overflow answer from John Resig: http://stackoverflow.com/a/136411)
yes. i wonder how we should solve this in a general way? either we just tell people to overwrite the controller to do their checking, or they can use rules on the routing if their use case is as as simple as a single role.

maybe we should simple take all security related things out of this class to make things more clear, instead of providing a oversimplified solution that would better be done with rules on routing level. 

maybe security could also go into the createphp library, but on the other hand that library already does a lot as it is... it goes in the same direction as validating and filtering, maybe we find a good solution for all of that.
Please use another video XD
I think we should keep this as if the user screws up their selector in some way nothing in Popcorn is going to work, so throwing an error is probably best IMO.
Please use `\w\.` instead of `0-9-A-Z_`. The missing `\.` may also cause a lot of problems...
we could use "lighter"/less expensive checks before this one
Here is the answer I got from geemus:

> My question is, is that behavior meant to be a standard that providers should follow?  I found several comments that seem to indicate that, but I thought I should check with the source.

Sort of.  Mostly it comes from providers like AWS, for whom you can't
really change the attributes of a server except at boot time.  If you
did it would raise an error anyway, so the error for save + identity
is just to head that off at the pass.  For providers where you can
change properties of the server after boot I think it makes sense for
save to work (same as save on other models).  If that still isn't
clear I can probably answer better on a specific provider than in
general, if you have one in mind.


So, it seems like there needs to be some error handling put in here, so that the exceptions that Fog throws for the providers that do not support 'Save' get handled in a useful way.  That should be simple enough.
Try `"{server:s}.r-a-d.io:{port:d}{mount:s}.xspf".format(server=server_name, port=port, mount=mount)` this should be used for all formats so it's clear what types are to be expected.
What is that? Can you delete that please? ;)
Right, I gathered that. What I don't know is when it isn't a mouse:

1. What attribute should I use to determine if it has moved (`e.screenX`)?
2. How much movement is acceptable for a touch pointer?
Demonstrate `client.set` with this.
It will start, but from the Symfony stack. The problem is that we can't control where `eZSession::forceStart()` will be called from. On the Symfony part, session will be started on demand, so the result is the same, but if a session has already started it fails.

`$delegateSessionStart ` can of course be implemented in the session handler but the result will be the same. Instead of checking the static variable, we will need to check the session handler.
`isset()` instead of `array_key_exists()` would be better.
You're right, I forgot about the other parameters. Fixed :ok:
I didn't know this option existed, thanks :) .
сверху обычно пишут
Running regex on binary content throws.
Thanks! Switched to "psr-0": { "Console_Color2": "" }
Oh, I see, they are the defaults in bone.
yup.  ok, fixing the comment.
here's another one: "controller"
Fixed up some of the documentation here
Also, this function could use some internal comments. When will the different error's be executed, etc.
This should just be a 201 with no response body.
Please document this.
This boinks up the unit tests as it assumes that object is an error object
Yes, good idea. I didn't think to that.
I amended your commit and fixed this.
Вам не кажется, что было бы лучше определить указатели за циклом? Внутри же просто делать присвоение ( firstCellCode = [.....] ).
The magic numbers 11644473600ULL (seconds between 1/1/1601 and 1/1/1970) and 10000000ULL (100 nanosecond intervals per millisecond) should be defined in constants.
Last sentence ("This parameter is ignored when...") should be removed since this function doesn't have a chooseDirectory parameter.
writing custom email validation regexp makes me sad. for instance, this won't match .museum and maybe other TLDs. I might suggest something like vlaidates_email_of. there are also a couple direct implementations of [rfc 822](github.com/saepia/rfc822) in ruby using a BNF-like syntax. I'm not exactly sure what is best to do.
commit name - igorko?
In the git logs there is only an igor, not an igorko. 
As said in the other comment, I couldn't really find github account names in the git history itself. The github account names only matter for review here on github. I am not sure if github translates back the git history names to github user names.
Only used JSON::XS since it was already being referenced, but I'm all for pure perl, compiling yuk.
Clearer and more readable code
Don't think #capitalize should be necessary here.
:const 也是一个元数据，放到 :tag :added一起好了
I don't know what happened the bug is here: ValueError('%s is not a valid score_func.' % score_func)
I find it more natural do to:

ica = ICA(n_components=25, noise_cov=None)
ica.fit_raw(raw, picks, start, stop)

so you can next do:

ica.fit_epochs(epochs, picks)

and it will work the same relying on a hidden private function that does the ICA a 2d array of data.
You might be able to just put an @AutoWired annotation here and it will get the right dao object
You can break bullets into multiple lines in raw and preserve the bullet by doing something like:

```python
* This is the first line
  This is a continuation of the first line, indented 3 spaces to be inline with the previous line
```
Sure, go ahead :) I mean we can also remove the constants and just pass the values directly, if you think that scares users less. I just wanted to make a good example :angel:
This sentence looks weird
<header>Referer</header>字段
统一为
=>
<header>Referer</header>请求头
这句漏了
What does? The blank line?
Just fixed http://jira.xwiki.org/browse/XWIKI-8119
You can use default EntityReferenceSerializer to serialize the author reference. See http://extensions.xwiki.org/xwiki/bin/view/Extension/Model+Module.
I don't know how to factor complicated expressions. This can be improved over time if we learn a way to do it. It's not something to block this pull request.
perhaps create a real doctest with >>>
No, the caching for _deleteParams and _putParams is needed because the getDelete($name,$defaultValue=null) and getPut($name,$defaultValue=null) depend on that.

Don't forget the intended sequence of events is to support REST authentication.  Basically you want (potentially) a filter first to check the validity of a REST request (meaning it has to do a getPutParams() or getDeleteParams() to get a list of all PUT or DELETE params in order to create a hash and validate the request) and then allow the normal execution of the request where the controller will try to get the individual PUT or DELETE params to do its stuff.  They have to be cached by the time you try to use them.

I hope it is clear enough.
Хотя, можно же было не перентить, а просто передать. Затупил :-(
damn you're right, R# bugged me and I just gave in not thinking much about it. I'll better revert these lines...
should use the Service Provider
Hu ?
I don't think you mean for REBOOTING and RESIZING to have the same secret code, do you?
Unnecessary annotation, methods starting with `test...` are already considered tests. If you're expecting some exception, it makes sense to use the annotation, otherwise it's not necessary. This is to do with consistency with the rest of tests.
Please fix the CS here
Ok, I guess then I'll just do this independently and probably after the freeze.
Oops. Yes. Good spot. I will open another PR to address this.
Yes -- but in the future we may not want to let them do the wrong thing and turn this into an exception -- therefore I think a DeprecationWarning might be appropriate.
You have to pass in a value for X, but by passing in 0 for it then it plays no factor.

On the gallery image navigation swipe it's (100, 0) as you swipe sideways to scroll through the pictures.
Can you mark this as #TODO: ? those are easier to grep for
мы обычно пишем $e->getMessage()."\n".$e->getTraceAsString()."\n";
&& для условий?
Totally missed it there. Nice.
Just a matter of taste, as there is little specific in the Code Formatting Guidelines about it, but the rest of this Pull-Request writes it's floats 0.0f, and not 0.f. I guess it's better to be consistent (unless lua_v2.cpp already uses 0.f). The block below might suggest that this is partially the case.
Went through all my code and fixed this.
Sure. Shouldn't take much more to generalize it. 

Erm. Should I recreate the switch template and generalize that more too?
The name of the component is missing.
Committed conflicted file, please revert
There must be a single space between the closing parenthesis and the opening brace of a multi-line function declaration.
btw can't u just return from there?
What about omitting zero changes count?

“Commit (12)” with changes, but just “Commit” without any changes (instead of “Commit (0)”).
ah, ok. probably could save the photo_id from the API call into imageable_id and use this id to see if the photo exists already each time, and also to purge any photos that are no longer associated with an event.

btw, thanks so much for jumping in to help :)
Are you sure ``$validator->isValid('1a')`` has the correct type as "Boolean" is not a sub-type of "Boolean"?
I just added it :) oops
Sorry about the late reply.

Thanks very much for the excellent work, I'll test the code out tonight and
then get it pushed into the official repository.

I'll update the README/credits to include your name.

Once again, thanks for taking on this burden.

Drew

On 7 May 2012 19:02, Geert <
reply@reply.github.com
> wrote:

> > -
> > -            self.debug('Executing ' + str(sql))
> > -
> > -            cur.execute(sql)
> > +            # After building the query we can use it on all video
> databases
> > +            folder =
> os.listdir(xbmc.translatePath("special://database/"))
> > +            for database in folder:
> > +                if database.startswith("MyVideos") and
> database.endswith(".db"):
> > +                    con =
> sqlite3.connect(xbmc.translatePath("special://database/" + database))
> > +                    cur = con.cursor()
> > +
> > +                    self.debug("Executing query on %s: %s" % (database,
> query))
> > +                    cur.execute(query)
> > +
> > +                    # Append the results to the list of files to delete.
> > +                    #results += cur.fetchall()
>
> I forgot to uncomment this line before submitting the pull request.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/drewzh/xbmcfilecleaner/pull/8/files#r782751
>
No, in this instance the method was found, called, and returned successfully. But the return value was of a type other than `Plucky::Query`. Before this pull-request, a `NoMethodError` was raised by the call to `super`. Now, the result is returned.

The previous line, `model.send(method, *args, &block)`, is where a `NoMethodError` would be raised if the methods was not found. I agree that this is correct and this pull-request doesn't change that.

Thanks!
Ironically, I think your new JEvent would benefit from my proposal to change JObject.  See https://github.com/joomla/joomla-platform/pull/1673/files#diff-3 (you can use the "properties" of JObject as your "arguments").  We could also add the Countable interface to the new JObject since that is related to IteratorAggregate.  That would trim this class down a bit.
pauseSelfScanning(); should go here
I've been thinking about this a bit. I don't really like this approach, because it involves so much duplication for something that should - fundamentally - be a simple task.

Can you please patch qt-components (we have a repo for it) to add an "acceptButtonEnabled" and "rejectButtonEnabled" property to Sheet? (default them to true, obviously)
yes it is, but just if you have code before I think..
The naming here should be clearer than user_link/username_link
What if you just change the order of classes you inherit from? :-)))
Check `scrollintoView`. See if goes to there nicely (so that user can see that it moved) or it jumps so that user is not sure what happened. I prefer using existing functions because they are less error prone. And probably work across browsers.
But it is unneeded until we have edit functionality. Why adding it now to the model?

And probably we want to keep history anyway, if we want to do it. So this could be a separate issue.
But why you want to implement code in models.py? Why not views.py of frontend? The same place where the previous code was? That's the ideas of signals, you can implement them anywhere.

But the question is if that defined signals are good enough. I am not so sure because they are missing resource and bundle. So probably we have to implement our own signals for this case.
Move this file to `piplmesh/js/` directory. It is not really jQuery library, but our code!
Probably a comment about this field would be useful, to tell that we are mapping between number of columns to PanelState. Do we store number of columns as number or as string?
Can you order this alphabetically? Constants first, variables last?
Double spaces.
What is the idea behind skipping a. here?
even though this works (because empty string is a 'Falsey' value), `time = None` is semantically better
why did this need to change?
There is a check at the start of the while loop for statics and ignored. They are handled as roots at the beginning of the process. I recall this really being just an error case.
Maybe it's worth mentioning here that this is a "one shot" thing. this is me nitpicking, but mainly this would be something in the lines of "This command runs one watcher's process and does not try to control it in any way". Like you said, this is a fire-n-forget thing, that's worth mentioning here. :-)
you can combine both if(s) in a single one
It is just to have the bash prompt on a new line at the end of the command.
This step is failing in the test, defintely need an explicit wait here. 
I had the same problem when I was writing this code for the bidpom.
Any reason for `fill_` instead of `type_` ?
That's not a validation for user input that's an assertion for tricky part that I found while codinf
I'd indent this and the following line two spaces.
Space after ìf`.
What is the raison d'être of the `this._pre("\n")`?
Will this crash the binary if someone puts in a long option like:

pagespeed a a a a a a a a a a a a a a a a a a a a a

? Seems like it should just complain with an error. TODO?
Using `/` to search is a convention, widely supported by web browsers, paging applications and some text editors. I can't imagine why the keypad's `*` (which is adjacent to `/`) is being given exactly the same job.
K : standard notation that we try to use has k_xxx, for example ``k_vars``, instead of single capital letters
(current MNLogit is not standard compliant)
Also possible: QR version (might even be able to avoid the unique columns at the cost of an extra qr ?)
I think. We only square for the denominator because it's 1/ (2*d[i]*d[j])
Let's keep `self.resources` and add `self.get_resource` for backwards compatibility :)
I can change keys to strings, but it doesn't look like having symbols here hurts in any way at the moment. 

I remember we were talking about a serious impact of hashes deep symbolizing on the resources loading time. Have we decided to get rid of symbols at all and use strings everywhere, or we agreed that we'll update our resources to use symbols as keys, so we don't need any processing when we load them? I think it's the latter, but I'm not sure.
This was copied from another place in the cookbook, and is currently how the mysql cookbook works.

I'll use the new way; I think the recipe was written before the upstart provider was available.
using JUnit `fail()` here will throw an AssertionError that will be swallowed in the catch block, so not useful.

You need to catch the assertion error and check that the error message is right, you can do like this :
```java
@Test public void should_fail_if_objects_are_same() {
  AssertionInfo info = someInfo();
  Object actual = new Person("Yoda");
  try {
    objects.assertNotSame(info, actual, actual);
  } catch (AssertionError e) {
    verify(failures).failure(info, shouldNotBeSame(actual));
    return;
  }
  failBecauseExpectedAssertionErrorWasNotThrown();
}
```
I don't think there is a field or property called amqpPort.
What is this guy for?
Sorry, by "original", I meant the one you provided in your pull request. By "this", I meant the example I was giving.
Probably because it broke in my collision test cases in some way.

You're right. It's a breaking change. I'll make a note about it in the changelog. At some point we'll figure out how to handle this right, but at the moment the semantics rather ad hoc and opaque.
Here you assume to use curl for the bonusbox__client.

The idea was to create a module, which is used for different shopping systems.
Please remove the curl dependency and add a param to this function which receives the wrapper for doing the actual calls to the bonusbox api.

e.g. zend_http and curl are used, and I bet there are other http-adapters out there which can be used, too.
I'm preserving the same behaviour as before and in my tests, it seems to show the bad jobs properly in the logs.

Also, I realize that i need to remove some vestigal classes due to the removal of a few classes in this commit.
Maybe add a comment why it is necessary?
Thanks, but let's only update the notification if there are selected conversations.  Just move this up a line.
Ich weiß ja ned woher die kommt!
not sure about serve, but national? would fit galaxy's naming convention better.
We haven’t written the mediaService class yet. We’ll get there.

-Chris

From: Abdelrahman Elogeel [mailto:notifications@github.com]
Sent: Tuesday, August 14, 2012 2:47 PM
To: gcheng/azure-sdk-for-java
Cc: Chris Tavares
Subject: Re: [azure-sdk-for-java] Implementation of Authentication for Media Service. (#11)


In microsoft-azure-api/src/test/java/com/microsoft/windowsazure/services/media/OAuthRestProxyIntegrationTest.java:

> +import java.net.URI;

> +

> +import org.junit.Test;

> +

> +import com.microsoft.windowsazure.services.core.Configuration;

> +import com.sun.jersey.api.client.Client;

> +

> +public class OAuthRestProxyIntegrationTest {

> +    @Test

> +    public void serviceCanBeCalledToCreateAccessToken() throws Exception {

> +        // Arrange

> +        Configuration config = Configuration.getInstance();

> +        overrideWithEnv(config, MediaConfiguration.OAUTH_URI);

> +        overrideWithEnv(config, MediaConfiguration.OAUTH_CLIENT_ID);

> +        overrideWithEnv(config, MediaConfiguration.OAUTH_CLIENT_SECRET);

> +        OAuthContract oAuthContract = new OAuthRestProxy(config.create(Client.class));

Why this doesn't follow same pattern in storage APIs and have class called MediaService which will have a create method? IOW, I don't think that in Java customers are supposed to deal with OAuthRestProxy directly.

—
Reply to this email directly or view it on GitHub<https://github.com/gcheng/azure-sdk-for-java/pull/11/files#r1377630>.
If the XML library we use cannot encode nor decode (see my comment below about `&#5`), then we need to consider using a *different* XML library.
Nit (not blocking, up to you): maybe you'd prefer to have to function: `_buildToolControls` that would do what `_addToolToMenu(…, noAppend=true)` does. and `_addToolControls` that would append the controls.

From a dynamic registration, you'd do:
```js
let ctrls = _buildToolControls(tooldDefinition, chromeDoc);
_addToolControls(ctrls, chromeDoc);
```

From the batch mode:
```js
let ctrls = _buildToolControls(tooldDefinition, chromeDoc);
// … then, the fragment stuff
```
It creates a shell script (called ```composer```) which runs the command ```php <installation directory>/composer.phar```, along with whatever original arguments were passed to the command.
This shell script will be made executable and symlinked in the next 2 lines, and thus composer.phar can be used from anywhere just by calling ```composer```.
e.g. ```composer install``` will execute the following ```php <installation directory>/composer.phar install```

```/usr/bin/env php``` is used instead of hardcoding the php binary path.
You need to use KINITv to initialize object field.
Take a mock app object as an argument.
Concerning `peak_local_max`, I'm in favor of also using the center-of-mass approach.
Could you split this into 3 separate test functions?
> By the way, since the data is artificially generated, you could alternatively recode the function and put it in the sample_generator module.

+1

Alex
We generally use the term ``affinity matrix`` at the moment. Do you think ``similarity matrix`` is more appropriate? Cite?
No license exists, but I have express written consent from the author.  If you think a license is very important I can try and prepare one for the original author.
In principle +1. Are there any transformers that use ``n_jobs``? I am always afraid of having it on the wrong abstraction level....
It should use ``self.__class__.__name__``
http://stackoverflow.com/questions/510972/getting-the-class-name-of-an-instance-in-python

The `Exception` raised is not informative, it might raised a ``ValueError`` instead.
In general, more docs are better. But this seems a bit redundant. Isn't this true for all estimators in sklearn?
Could you add a comment that explains why this line is needed?
Ahoj,

jasne, pridam. To je tedka nove? Co presne lide najdou na strankach 
osmand.cz?

Petr

On 02/23/2012 07:43 AM, Pavol Zibrita wrote:
>> @@ -1,5 +1,32 @@
>>   ﻿<?xml version="1.0" encoding="utf-8" standalone="no"?>
>>   <resources>
>> +	<string name="offline_poi_edition">Offline editace POI</string>
>> +	<string name="offline_poi_edition_descr">Vždy používat offline editaci POI</string>
>> +
>> +	<string name="tip_recent_changes_0_7_1_t">Změny ve verzi 0.7.1 :
>> +	\n\t- offline editace POI
>> +	n\t- přímý přenos pozice - pravidelně posílá souřadnice na webový server (návod jak nastavit vlastní webovou služby je v HowTo článcích)
>> +	n\t- Zobrazení momentálně zaznamenávané trasy
>> +	n\t- Detekce směru pohybu: indikace a hlášení \'Otočte se zpět\' v případě pohybu směrem od cíle nebo po minutí odbočky
>> +	n\t- Obnovené hlasové hlášení \'Přepočítávám cestu\'
>> +	n\t- Optická indikace blížící se odbočky během 100m pomocí změny barvy šipky
>> +	n\t- Zobrazení aktuálnosti offline dat u deaktivovaných souborů (sekce Download) pomocí tmavě zelené a tmavě modré
>> +	n\t- Další změny
>
> Cau, bolo by mozne spomenut tu, ze funguje osmand.cz ? Dik.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/osmandapp/Osmand/pull/169/files#r479318
The event Id is unique to the instance of the control.
It's the derived classes the enforce the 'only updatable by writing/spilling threads', e.g. CThorSpillableRowArray
so the prev. comment in the general thread-unsafe CThorExpandingRowArray here, seems to be inappropriate
maybe better left for its own pull request, though. (with tests). Reverting this memory-related patch could regress in functionalities in the future.
maybe we do need to.
Really serialization of datasets would be more efficient if they used the count instead of the size as well.  It is unfortunately a bit late to change that I suspect.
But looking at the diff, it seems like a lot of lines changed only in indentation, i.e. you are wrapping some areas of code in try-blocks differently. It would just be easier to see what those changes are if they were not mixed up with unnecessary whitespace changes. Also if there is ever a need to examine history of those interior lines, annotate is going to be useless if their indentation changed.
you should typehint the ObjectManager interface to make it possible to use it in MongoDB too
Extremely relevant from the  [Python docs](http://docs.python.org/2/faq/design.html#how-fast-are-exceptions) :)

So it depends how often we expect the dict to have the key.
same as above. pep8 name and move out of models.
Please also make sure to set the pprint-color format for the logging output.
l10n.js uses `XMLHttpRequest`, like `self` module for `data.load`; bootstrap uses similar approach I did. Shall we tried to unified the methods?
This must default to `True` to maintain current behavior in the absence of the setting.
It should be ctor.
I agree, not sure what I was doing here.

How do you mean a dictionary list?
huh? we don't want to do this for every sort comparison
Thanks for catching this. You're one of the good ones :bangbang:
Username and Password should be options
`locality` --> `min_distance` to match `harris` function
This second call to circle is unnecessary.  Also, it might be clearer to combine the coloring step into

```python
img[rr,cc,:] = (255, 255, 0)
```
I now understand what you're saying.
No, because username must be unique in the table.
Apologies, I had expressed my thoughts on IRC. I think that page objects should not have any `go_to_` methods that load URLs as they are not aspects of the page. Page objects contain methods describing actions that a user can take on the page and properties available on the page. I feel we should have a page provider object that provides methods for navigating to pages and returning the appropriate page objects. Here's an example of the kind of thing I mean: https://gist.github.com/2002037. Note that it's late, and that's just a rough untested implementation. I'm certain it could be refined. This would also have the advantage of basic user flows being captured and maintained in a single file (or small collection of files if this became unwieldy.
Is two calls to `push` faster here?  CC @shunter
Here should be a check to see if quality is HD: `and quality['hd'] == True` should work ;)
Doesn't this remove map support unless we use "Google Inc.:Google APIs:14"?  I did some searching around and saw this style change made by other developers but I never found a clear explanation why/if map support was actually being cut out.
Would it be possible to place this code into `util.connect()`, and maybe have some kind of connect hook for each platform, if it's going to be system-dependent? There may be platforms other than mobileweb which will require a different strategy than iOS and Android use.
Meh ignore my previous comment, this addition is no longer true. I will remove it.
You need to check null on the return value of get().  The weak ref allows the activity to be collected if no one else holds a ref.  If that happens, the get() returns null.  Do me a fave: when you fix it, don't do a double get() (one to check null, the other to call finish).  Put it in an Activity variable and check/use that. :)
You can inline this if.
I actually removed several items from the config file in order to follow a "less rope" mindset and have the config file put more focus on properties that actually need attention.
Пропиши в `.gitignore`
`.idea/` -)
Can you replace "(error) => errorHandler(error)" with "errorHandler"?
Also, don't use `.hover()`.
The extra variable doesn't seem to add much value here.  Just inline the filename. :)
закрыть окошко)
`uploadcare.dragStateChange`
Nice! But how about not touching first [0..pos] elements at all? 
Basically stat appending past pos into an array iff capacity allows it.
Yeah, it is natural. But, there wasn't `are*` template in Phobos except a few deprecated cases, so I chose the `is*`.
However, I intend to take a policy to change `isParamsImplicitlyConvertible` to `areParamsImplicitlyConvertible` because I don't have the philosophy about sense of naming.
That was already discussed, though not explained.

The reason that isn't an option is because `is()` expressions which introduce aliases (the `x` in this case) are only allowed as the condition of a `static if`. Further, there is currently no `is(T == U, <submatches>)`, only an `is(T sym == U, <submatches>)`, which is the one used in `isInstanceOf`. I think a pull request exists by @9rnsr to introduce the alias-less form.
Second query: is _Vprime acceptable?  I ask because it's more convenient to my eye to have _Vprime (variable) and newVprime (function to set its value) rather than _vPrime and newVprime.
Testing this made it so slightly faster that way. Surrogate pairs are the rare case: having a `Index += 2` implies an else clause, or a middle of function return, which slows down the most common case.

I may be wrong, as there was a more deviation while testing wchars, so maybe I just observed some noise. In particular, I'll have to re-bench taking your enforce recommendation into account.

I'll either change it, or comment it I guess.
Why not just a single declaration assigning the `is(...)` result?
Yes. From an instantiation of `unbox`:

    4ada8c:       48 be 40 ec 4e 00 00    movabs rsi,0x4eec40
    4ada93:       00 00 00 
    4ada96:       48 8b 5d f8             mov    rbx,QWORD PTR [rbp-0x8]
    4ada9a:       48 8b 7b 10             mov    rdi,QWORD PTR [rbx+0x10]
    4ada9e:       e8 f5 14 00 00          call   4aef98 <_D6object8opEqualsFxC6ObjectxC6ObjectZb>
    4adaa3:       34 01                   xor    al,0x1
    4adaa5:       74 31                   je     4adad8 <_D3std8typecons3Box12__T5unboxTiZ5unboxMNgFNeZNgi+0x98>

(That's the code comparing the two type info objects.)
no symbols should be called o, O, l, or I
You put the lint.xml that ignores NewApi completely in the ABS library
folder, not your own project.
On Dec 12, 2012 12:41 AM, "Jan Berkel" <notifications@github.com> wrote:

> In library/src/com/actionbarsherlock/app/SherlockActivity.java:
>
> > @@ -18,6 +19,7 @@
> >  import com.actionbarsherlock.view.MenuInflater;
> >  import com.actionbarsherlock.view.MenuItem;
> >
> > +@TargetApi(11)
>
> btw, what you posted just ignores everything. i still want my own code to
> be flagged as warnings.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/JakeWharton/ActionBarSherlock/pull/736/files#r2386779>.
>
>
Смотри: добавляется уникальный индекс на vk_id, поэтому vk_id нужно заполнить данными; у всех (и у "старых", и у "новых") vk_id будет заполнен правильными данными - зачем дополнительная настройка? Ну и "There should be one-- and preferably only one --obvious way to do it." из PEP-20
Break this line out into well-named locals.
Can we separate the test from the persist, please?  And persist just as a JSON object, unless there is a compelling argument otherwise.
tl;dr - I can remove these lines if they aren't appropriate here & make the appropriate changes in the tests
two blanks are missing in the indentation
Not sure if we should depend this package.
This file is reviewed. This variable is never assigned anywhere.
Fixed. (I dont believe this template is ever used)
Does this not override any calls to a PSU\Persoon?
i would rather not have this supported in the ``create()`` method
Like the other changes, but I'm not sure this line adds clarity.

If you're trying to say that it's in bytes, I'd add that into the phrasing, or into the note down below - whatever you think works best!
I'd lose the redundant "version" in the output strings, aka, I'd prefer something like:


remote entitlement server: 0.6.3-1
subscription-manager: 1.0.0-1
python-rhsm: 1.0.0-1.git.5.56158cd.el6
The same key is in the hash twice. Was this a copy-and-paste issue?
Extra spaces at the end of the `5` here
New "Reshaper 6.1" with latest "Code Contracts" work like a charm.
Also you cannot do something like `Contract.Ensures()` with `throw new Exception*`.
That's why I prefer to use Contracts instead of `throw new Exception*`
What are the parens around `(strerror)` for? And why is it named `strerror`? The usual thing is to just name it `e`.
Doesn't that mean we simply revert this entire class?
Its not public so I can't ;)
In other words this is intentional
Never mind on this. After talking to @fourk this is intended behavior.
missing one =
ゴミ?
I don't think we have a mechanism in place yet to deal with this.
Duplicate code here, can you create a function ?
Oh, about your doubt.

I recover all apps which have the uaToken in theirs node array ... and only recover the _id field.
Can you use `TestConfiguration.php.dist` or `TestConfiguration.php` for this?
Also, I'd stop instantiating the service manager here and instead use something like https://github.com/Ocramius/OcraDiCompiler/blob/master/tests/OcraDiCompilerTest/ServiceManagerTestCase.php
Please quote variables, always.
As mentioned above, do you mean `API::V1::UsersController` ?
Looks like its triple commented out.
I changed a handful of styles on the check-in page because the container height did not adjust properly to different content sizes - its contents just overflowed (with the addition of emergency contact information this happened).
[Set](http://www.ruby-doc.org/stdlib-1.9.3/libdoc/set/rdoc/Set.html) is part tof the standard library. How is it a dependency?
such a matrix
> About moving it to the advanced features section. I did consider it but decided to leave it here. I don't think it's really advanced. CErtainly not as 
> advanced as opening your own IndexReader and messing around with Lucene indexes :)

Fair enough.
This is an important fix.  Nice catch.
you're right!! how can I forgot about that.. the code that I used totally sucks
Why not just leave it out if it's null?
right here we're not talking about a distributed framework, but the OpenEngSB :-) I know that the approach is general enough, but it feels quite strange to read parts of a mnual which describes parts in this manual in a more general manner :-)
Wait...so why doesn't the auth token get encrypted here?  Because it's just used in memory?
Sounds good for the jar, but we should have the version number for the js (since the js could be coming from a server etc).
Why is this removed in this PR? We agreed that we will create separated PRs for it.
If you want to go perfect (see http://stackoverflow.com/questions/1844355/java-static-class) throw an AssertionError
they won't that is why it is ignored specially. If I wanted to the ignore module somewhere else I would rather it stick to spec
Also user story spec calls out for it.
again I'm not understanding why these are class variables