labofsahil/github-event-dataset-2012 huggingface dataset:
Yes, this is going to be tricky. If you think that should be part of this change, feel free to merge this PR without this commit.
The value of the system property jboss.server.base.dir should be the full path to the dir, not just portion relative to $JBOSS_HOME.
also this one

```java
SaslResource.SERVER_AUTH_ATTRIBUTE.parseAndSetParameter(value,saslElement, reader);
```
Do we need to remember to change this to the correct year every January 1st ?
LGTM.

This should be fixed anyway in the next release of ruby backports, but this patch is great until then :)
no XML; use `"<li>"`
это чо такое?
How about using a constant for all those `'dialerRecents'`?
Is it a leftover ?
Cool, I was using https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/background_service.js as a reference, is that similiarly doing too much?

The only time a second window open did actually trigger was the 4th method of http://www.popuptest.com/goodpopups.html
is

title.textContent = '';

not enough here?
jejeje the label is hidden but they have label :) because when user move an app from dock to grid it shows the label
Hi, they are quite similar in shape but not in essence :-p I mean each loop has its own upper limit. We could use the maximum of both upper limits but we would have to check in each iteration if the array with the minor length has reached its maximum not to continue extracting values from it. Do you have in mind other type of refactor? Maybe I am missing something ;-)

Anyhow, I extracted and reused the 'i' variable ;-)
l10n warning -- get the `', '`string from l10n.

(can be done in a follow up)
I do not think it is a good idea having this code here. Although we do have a lot of space for improvement regarding separation of UI and functionality in the dialer, I would suggest trying to avoid it in case of new code. 

On the other hand (and this is aligned with my comment at the end of the PR), this code may cause trouble in concrete cases such as:
   1) What if someone has 100 or 1000 contacts with the same phone number. I know this is not a common case at all but there are many synonyms for "bitch" to assign to ex-girlfriends. Also many synonyms for "asshole" for ex-boyfriends :-p I guess you get my point. The 9 chars for the best contact match name may be too many.
   2) UX guys decide to change the font to whatever wide one that makes the "9" characters of the first contact name too many for the available space.
this.view ?
I’m about to implement the same Makefile-magic for `shared/style/` as well.
If you take this button out, don't forget to remove this handler.
Peut-être qu’on pourrait utiliser « messages » plutôt que « courriels » ici ? (même chose pour `settings-notify-mail`). C’est juste une question, pas une affirmation.
pretty basic stuff, but we should check indentation
I think the the first one is more explicit than the 2nd one.
just to be on the safe side, could you add a ``self.assertRaises(ImportError, import_module, "nowhere.non_existent_module")``? Just for the extremely weird case where there would be a package installed with that name.
Git here should be removed
I have reorganize the tests to be more atomic now:-  https://github.com/skyluc/scalatest/commit/0a90d7866abd891985573e2a676f948cbab56685
下記に示すように
↓
下に示すように、とか下記のように、とか
All of these translations should be written in Japanese.
I will rename it to run_tests, and rename run_tests to do_run_tests then
Ok, then I got `<C-X>H` just wrong.

Please just add it to the doc then.
Maybe make this a method of the RichPipe class instead of the object? That way we could do:

p.setReducers(r)

Instead of:

RichPipe.setReducers(p, r)
Erase this dead code.
Personally I would leave this check... Just for sake =)
so only getChannels() makes sense
while loops are a sign of weakness?  j/k
Do we have a config time checking of that common mistake? I think that would be very helpful.
Should `project` and `repository` be set to their default values here, instead of `None`? That means that the `branches` dict below won't have multiple keys for the same data (`None, None`, `None, self.svnurl`, `self.project, None`, `self.project, self.svnurl`).

And for `branch` and `path`, I think `''` might be a better default. (@djmitche?)
Ok, should I redo the pull request?
I am a git noob :)
Should be _If we have only one directory inside, this is the package itself_
Can you rebase? I added support for .inc this weekend, I guess your fork was out of date.
use statements should be placed before the phpdoc of the class (as it is not the phpdoc of the class anymore with your change)
This file has many whitespace changes, please remove them
"a Module is a more discrete component of the page. It is your navigation bars and your carousels and your dialogs and your widgets and so on."

"When defining the rule set for a module, avoid using IDs and element selectors, sticking only to class names"
We can, but it is different than the normal flow of things. Maybe just pass p->payload and p->payload_len to this function and use the pkt, len parameters?
isn't that a (partly) good thing, though? if they accidentally set it, this way, they can just change it and rehash to fix their linking issue without unloading & reloading or restarting
Nit: Indentation. Space after `throw`.
I know that I asked you to inject this, but it does look like the StatusPrinter on 503 will take care of this case.  We should drop it.  Sorry.
double rats... fixed.
is is_the_current_page going to know how to fill in that %s?
Yep! I think we should have the convention that `y_pred` should be binary, or interpreted as such (with positives => `True`, else `False`), what's your take on that?
To me, this directory structure implies that there is a `Muddle::Filters` object within which each of the filters is name-spaced. To me that also implies that we should have a `muddle/filters.rb` that is required here and that defines `Muddle::Filters` requires the filter classes its self (which would in turn be renamed to, e.g. `Muddle::Filters::Premailer`).
I don't know if it's SQL standard, but I think we should not use _ to detect LIKE comparison as it is very common for slugs.
I followed the naming convention of foreign keys, inside model classes: `$aSomething` and `$collSomethingElse` are the arrays of 1-n and n-1 relations keys. I can't find a better name (maybe little imagination...)
I missed this comment, so I mentioned using Puppet::Error in the diff elsewhere.

My opinion is that all exception classes in puppet should inherit from Puppet::Error.
@cprice-puppet yep, I think @domcleal already has submitted a PR there, but I'll be sure to follow up on that
Yep, I overlooked it.
This new field is part of an upcoming PR to add email verification and password reset capabilities to OAE. Safe to pull in, but not absolutely necessary.
Won't this cause problems if Geokit isn't installed?
It's technically 100% legal, you can throw any object, but by-convention as an error it's completely useless because you have no stack trace. True though, I agree we should definitely cover that in mocha, I'll see if I can add that in right away
Why are you including this, only if ActiveSupport is loaded? It either should be needed for this module, in which case we should require those files unconditionally, or it is not needed and we can leave it out. Maybe I am missing something though :)
Iterator and IteratorAggregate should be imported.
Actually, we should probably check if $name is a View Model -- that could simplify things, too. :)
Move brace to next line.
Interesting - looks like the ldap component doesn't follow the way zf2 handles exceptions
Add whitespace between if and opening paren, and between closing paren and opening brace.
Fix indentaion, probably a tab instead of spaces. Check whole file
@Mobbit hat das event_*-Prinzip erst eben verstanden :)
Or `which gcc`?
this is possible, but need to build sql-query using dbal query builder, can't imagine this query in builder-form
I'll make this look pretty :)
`title` instead of `name`
I agree, but everything else.
It seems you were using this template 3 times. If you add autofocus on each one, I guess that only the last one added in the dom will be loaded.
Btw, it is not supported by IE
On Thu, 13 Dec 2012, Birk Borkason wrote:

> >  	/* HTTP_HOST and SERVER_NAME. The difference between them is that
> > -	 * HTTP_HOST can include the «:PORT» text, and SERVER_NAME only
> > +	 * HTTP_HOST can include the Â«:PORTÂ» text, and SERVER_NAME only
> 
> I honestly don't know, what happened here. If I open this file in my editor,
> everything seems ok! I did not even change anything in this line.

I think something transformed the file into some UTF-8 or 16 chars.

Stefan
Seems to work now, thanks @Ocramius
@piotras suggestions have **absolutely no effect** on the installation. They are **only** used to display a message to suggest the user to install another package
One thing at a time. I would suggest merge this first and then do whatever you want with Code.load_file :-) And yes, I think it'd make a lot of sense to make load_file return the result of the evaluation.
Note: I'm just being consistent here and await consensus in the other pull request.
Done, please check again.
random whitespace here.
Instead of `We see profile picture` lets do something in the negative context i.e. we didn't...
Try looking at the way its done elsewhere. This would stop modelforms from working properly.

```python
d = self.cleaned_data
if username in d:
    d['irc_name'] = d['username']
super(RegistrationForm, self).save()
```
According to the docs for the `loggedInEmail` option of [navigator.id.watch](https://developer.mozilla.org/en-US/docs/DOM/navigator.id.watch):

> NOTE: This parameter will soon be renamed to loggedInUser. The change will enter production in mid-August.

Hmm. It seems like this observer API is in enough flux that you might not want to use it yet, at least as long as `navigator.id.get()` fulfills the same needs...
boolean -> checkbox
This is an example of specifying the domain of the granule to be returned.
Sorry for only noticing now - I think we want three suspension points with the Please wait, not just two.

Otherwise, sort of silly question: is the data thing something universal, or only for HTML5-literate browsers?
Do `placeholders` have to be in early defs?
We should maybe add a second line for all the employees who accidentally log in with their gmail address.
yeah I am pretty sure it was a mistake. We don't want to put stuff we want to keep in any tmp dir
Once for the opening anchor tag and again for the closing tag (the contents of the anchor element is very similar with or without the permission so I don't want to have to repeat it . I don't like it either though, so if you know of a tidier way of doing this let me know :D
Good idea - being able to add/remove PSFs from images without doing actual photometry would be very handy.
This conflicts with our standard wording.
CS : Missing WS after `$item`
I think the prototype of this method is confusing. Some parameters are practically the same and the description doesn't help understanding.
!= тоже будет удобен
очень плохая hash функция
NGHUTPR since you didn't write this originally, but dynamic_cast is unnecessary and "diagnostics" can probably be passed in to the get_proc_status call directly.
This assert is failing.
http://pastebin.com/u7NAudNY
MemChaser doesn't have a contribute form
it is: https://github.com/mozilla/persona.org/blob/master/public/javascripts/apps/controllers/AppsController.js#L29
I don't see the advantage of saving this constant away...if you're going to keep the same name, there doesn't seem to be much advantage of `http/HTTP-INTERNAL-ERROR` over `HttpURLConnection/HTTP_INTERNAL_ERROR`. Also, it occurs to me that we probably shouldn't use all caps for constants because...well, everything is basically a constant in clojure. :)

If we're going to provide more convenient access to these constants, it would probably be better to just take *all* the HTTP constants, programmatically, and just shove them into a map. Something like this would do it:

https://gist.github.com/1ac43845e5ad2afbd2b4

There are also other constants in this file (200, 400) that should be replaced, too, if we're going to the trouble of replacing one of them, methinks.
Can we create a generic function for this, like in utils.clj?

    (defn add-shutdown-hook!
      [f]
      {:pre [(fn? f)]}
      (.addShutdownHook (Runtime/getRuntime) f))

Then it's reusable, and this section of code just becomes `(utils/add-shutdown-hook! shutdown-hook)`
Inline this as `name.split("/")[0..-2].join("/")`.
Not in this test, as long as there is no exception I am happy. The other tests will exercise methods on the pool when parsing full classfiles.
This test is important. There must be a way to achieve the same thing in the new API.
I believe we no longer need ``toList`` here
httpfox 로 봐야 알겟지만, header 의 `content-type` 은 `application/json` 인데 `data` 를 저런식으로 넘기는건 `application/x-www-form-urlencoded` type 으로 전달되기 때문이 아닐까요?

요래조래 해도 httpfox 로 봐야 정확한 진단이..

흠 repo 를 받아서 직접 테스트 해보겠습니다.
Never end a section with an image.
[InvalidId](http://api.mongodb.org/python/current/api/bson/errors.html#bson.errors.InvalidId)
Can you please move these changes to another PR? It's not tied to your new provider.
Yes, that is why we put that sentence at the beggining of the index.php. All the time() functions will return the time in UTC, and the now() function will return it in the timezone you specify via config.php or the $thimezone parameter
а вот для этого нужно вызов mutate: запихивать в @try..@catch и обрабатывать исключение.
А если в ДНК будет не 100 элементов? Лучше сделать вычисление количества элементов для замены.
если @affilate не может быть false, то лучше

```
def affiliate
  @affiliate ||= NanoApi::Client.new(self).affiliate.try(:symbolize_keys)
end
```
Ok, sounds good. And remove "polifyfile" from the dependencies?
Unfortunately, I don't know the answer to either of these questions -- which is why this code is owned by Raj and why we're not touching these parts of it while he's out.  (The changes here are very minimal -- hoisting things into variables but keeping their values the same in theory shouldn't change anything about the end result of the script).

My vague understanding is that the UpgradeCode is really only used in upgrade install scenarios, which we have disabled since we always want side-by-side installs.  (I'm not sure _how_ we disabled it, though).

The language code stuff is somewhat magical since MSI only "unofficially" supports multi-locale installers.  We generate two single-locale MSIs and then apply some sort of "transform" utility to merge them together, which _might_ cause some of these language properties to effectively get ignored or overwritten... but I'm not sure if that explains this particular case or not.

Is that enough background for now?
just a thought. `key.present?` will check for nil or blank/empty string case
Won't this hide window.angular from the scope?
Looks sensible until this point, although I'd call the function just `transitionEndEvent()`. ("get" prefixes are pretty rare in our codebase AFAIK.)
oops, let me run this again here in a few.  i'm sure i messed something up when moving it over.
Docs por favor.
We should also test the variations of sending values and error.
Ok, I guess we need to come to an agreement on coding style for spaces in for conditions ;P Many of our code add spaces in deed. But since you are the C expert here, so I will leave this decision to you :)
A bit more abstraction would make this method more readable.  Pulling out "thor_scmversion_labels" into it's own method at least would be a good step.
add reference to MxNE paper
see new push

On 26.12.2012, at 14:47, Alexandre Gramfort <notifications@github.com> wrote:

> In examples/preprocessing/plot_ica_from_raw.py:
> 
> > @@ -46,7 +46,7 @@
> >  # between 0 and 1 to select n_components by a percentage of
> >  # explained variance.
> >  
> > -ica = ICA(n_components=0.90, max_n_components=100, noise_cov=None,
> > +ica = ICA(n_components=0.90, n_pca_components=100, noise_cov=None,
> why not 64 here?
> 
> —
> Reply to this email directly or view it on GitHub.
>
Use the shortcut notation here, replace line 318 - 320 with:

    You can also get the value selected directly by specifying return type::
The coding standard is to put every value in there own column:

    * @param \Symfony\Component\Form\FormView      $view
    * @param \Symfony\Component\Form\FormInterface $form
    * @param array                                 $options
although this comma will pass, it was lazy-left
You can combine these to steps by using:

    $ php composer.phar require symfony/finder:2.1.*
这里这样翻译怎么样：
日志写入时间。单位为秒，精度是毫秒。
You mean, what if dummy doesn't respond to avatar_updated_at?  It should probably return nil or raise NoMethodError (though I think raising an exception is a little aggressive).
How about caching it; would that solve the problem?

    def fingerprint
      @cached_fingerprint ||= Digest::MD5.hexdigest(read)
    end

If not, can you re-write this to use `#tap`? Thanks.
If we don't have one of these you want to hide it. I get a *lot* of stupid logentries errors on beginning deploys due to this nasty little line
Ticket already exists. Removing comment.
New archetypes should use the generated ginjector.
Esta es muy buena observación. Ya mismo voy a probarlo.
## Currently Supported Formats/Systems
missing licence for some file
but it means that creating the TableEventStore now requires to pass the table name explicitly, so you don't have a default anymore
@extends cc.Class
Formtastic allows users to override the input classes by simply creating a class like BooleanInput. Formtastic's methods check for its existence first, and then defaults to Formtastic's input class if it's not found. In AA, if we want to preserve that behavior, I think the only way is to reimplement the method. If we use the AA class if it exists, and otherwise call super, users will not have the same flexibility to override the input classes.
could we get rid of the after cleanup, before should be enough ?
I am not really interested in mac address, but mostly in the timestamp
embedded within the uuid so that they have a natural order
On 12 Oct 2012 17:35, "vblagoje" <notifications@github.com> wrote:

> In
> core/src/main/java/org/infinispan/commands/read/DistributedExecuteCommand.java:
>
> > @@ -55,17 +59,23 @@
> >
> >     private Callable<V> callable;
> >
> > +   private final UUID uuid = UUID.randomUUID();
>
> How do you know all these things @tristantarrant<https://github.com/tristantarrant>:-)? I think if we are able to do it with general UUIDs lets not add more
> dependencies. Although I can see how useful it could be to have address of
> the command sender encoded. Maybe we should just use Bela's UUIDs? But then
> people might be confused to see these uuid looking exactly like addresses.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/infinispan/infinispan/pull/1369/files#r1830658>.
>
>
`addresses` could contain addresses for all keys passed in, not just one.  So potentially a larger collection to check.
Ok I can do as I didn't see it.. but my concern is not only external users, also our own internal usage.

More importantly, I don't understand the goal of all this changes. What's the purpose?
The route `commit` does not have branch parameter.
isn't there something to get the root url of the application? btw, i have problems understanding this method? this does not append any locale so won't this lead to an endless loop?
We already have a convention in MPL to have None mean "the default".  Note that "the default" may be more than just a particular value, such as a set of actions to take in the case of None.  We are running into issues where existing code did not follow this practice and as such, changes are harder to make without breaking backwards compatibility.  For example, I have been trying to implement a broader attribute-cycling mechanism (not just for colors, but line colors, fill modes, etc.).  Such a mechanism depends on being able to distinguish between a user wanting the default or a user wanting a specific value.  If a parameter is set to default to 1.0 in the call signature, there is no way to know if the caller explicitly set that, or if we really want the default behavior.

By keeping it as None now, it makes changes easier in the future.
These are available from the superclass. I'm not sure if its better or not to do:

```
toolitems = NavigationToolbar2.toolitems[:-2] + ('Download', 'Download plot', 'filesave', 'download')
```
Yup, I fixed indentation and whitespace in all the files tracked in this
commit and pushed again. Do I need to make another pull request?

--
Brian


On Mon, Jun 4, 2012 at 12:05 AM, Lizzie Mamantov <
reply@reply.github.com
> wrote:

> >
> > -    fieldView->updateView();
> > -}
> > +      buttonLayout->addWidget(stopButton);
> > +      connect(stopButton, SIGNAL(clicked()), this, SLOT(stopDrawing()));
> > +
> > +      dockWidget->setWidget(buttonWidget);
> > +      addDockWidget(Qt::RightDockWidgetArea, dockWidget);
> > +
> > +    }
> > +
> > +    void FieldViewer::stopDrawing(){
> > +      keepDrawing = false;
> > +       qDebug()<<"Stopping WorldView...";
> > +      bot_locs->locs->stopListening();
> > +    }
> >
>
> And these extra whitespaces etc... just style things...
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/northern-bites/nbites/pull/289/files#r920584
>
Yes, message is not a good name.
It's there to avoid a long line (> 85).
Thanks.
please remove semicolon
@bp323 Yes, before it had the widget id, which didn't make any sense at all.
I was thinking about using the widget title, but that will just result in a duplicate reading for screenreaders (it is in the span beneath)

As this is an image which could also be a background image (just an icon for a widget) imo it doesn't need an alt attribute.
In particular, the jQuery style it out of character with our other PHP APIs.

If we wanted to keep hacking around with this API, we could potentially remove the `$clear` argument in favour of `setFrom()` and `addFrom()` as a pair of methods, which would store the set/get symmetry, but Sean may be getting sick of endless changes. ;-)
It's obvious, isn't it?
Comparing to methods overriding: all methods are “sealed” by default (“final” in Java terms) and developer should change method to “virtual” when he needs. There are no comments like “hey, overriding this method is restricted, change it for overriding”, so I doubt we really should write “hey, inheriting from this class is restricted, change it for inheriting”.

Sealing some class doesn't mean “never inherit from it” as well as other access modifiers cannot prevent from using types or members from wider scope in future. I don't know future, so I just start with less visible most restricted option and open it when it becomes necessary.

I hope other developers learn C# reading Eric Lippert, Bart Smet, Jon Skeet, Jeffrey Richter etc, so they wouldn't be suprised that most of classes are sealed.
I'm not sure we want to hardcode this? I often have multiple Rails apps running on my machine. I usually do something like:

    foreman start --port 3001

If the result comes back that the port is in use, I do:

    foreman start --port 3001
Was fixed, o Hitler of code.
Because that is the name in the actual object, so i figured this would keep it unambiguous
I agree with erik, here
Are you sure that ``$options`` (of type ``*``) is traversable? I also found this on lines 122, and 159.
Could you add a ``@return`` annotation? Please also check line 82.
Are you sure ``$locator`` has the correct type as "object<PHPUnit_Framework_MockObject_MockObject>" is not a sub-type of "object<Zend\ServiceManager\ServiceLocatorInterface>"?
Are you sure ``array()`` has the correct type as "array" is not a sub-type of "string"?
Are you sure the method ``setScrollingStylePluginManager`` can be called on ``$this->_paginator`` (of type "object<Zend\Paginator\Paginator>|null")?
尝试用<https://github.com/TBEDP/urllib>来做这个吧，封装了很多细节，和考虑了异常。
less logging so the important errors stand out.
Not a debug function. That function does next line until there are no more
lines and then next slide. I that is the one function you would connect to
a presentation remote for "forward". Without it you'd have to have 2.
On Sep 13, 2012 8:16 AM, "Alfredo Deza" <notifications@github.com> wrote:

> In plugin/posero.vim:
>
> > @@ -136,6 +138,10 @@ function! posero#PreviousLine()
> >      call s:Previous()
> >  endfunction
> >
> > +function! posero#NextAnything()
>
> Is this a debug function? why do you need this?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alfredodeza/posero.vim/pull/3/files#r1596867>.
>
>
This should have an `ensure` statement, e.g.

```puppet
package {
  'gitweb' :
    ensure => installed;
}
```
We could check `if String === options[:typecast] and options[:typecast].length > 0`, but it's ~10% slower than just the existential check according to a quick benchmark. That seems pretty overkill-ish for something that'd be a pretty extreme edge case. I'd be genuinely surprised it someone is defining a key with a blank typecast.
See the earlier comment about this.
I did use it for now but it is an alert description used to inform the user when his internet connexion is not reachable
тебе же нужно вывести имя каждого тега отдельно. Почему бы не делать этот цикл, и просто вставлять `<%= tag.name %>` ?
косяк.
No need, because they are all part of the same package.
`gettext(day.substr(5).append(":"))`?
That was my first implementation but when you were building id from session all you had were strings. If this was java I would use same name but different signature.
`var user =`, not just `user =`.
Comma at the end.
Well I don't know. Do I have to load something? <code>Invalid block tag: 'fullurl'</code>
I am not saying it doesn't make urls that I want, it doesn't work at all :)
Do we really have to supply initial value here? Do we not always populate it from state in the database?
Why not simply pass `option` object?
Yeap, That's a good idea.
replaced with if seq is None
Why did you add this line???
I think we can keep this down to just this line. We don't need to document the standard brew features in caveats.

If stone-soup savegames are not usually expected to be compatible from version to version, we can cut the caveats entirely.
Doesn't this else statement get called every time? Even if the datastream does exist?
To add a delay of 0.5 sec
Ctor auch hier entfernen
pfdetect_remote is in another package (packetfence-remote-snort-sensor) which conflicts with PacketFence. We should probably get rid of the files (and later do the remote-snort-sensor subpackage)
$NO ? where does it come from?
Should we use the already commonly used isEnabled or isDisabled ?
can this be moved above `public void setLocation` for readability? I generally like to order store / load func methods in order in which front / back end might call them.
Thanks! An extra ctor was bound to be added at some point to support non-key/val specific options. Just make the existing two arg ctor delegate to the three arg one and pass along an empty string so existing clients don't break.
https://mxr.mozilla.org/mozilla-central/search?string=[^\%3F]%2B\%3F[^\%3A]%2B\%3A&regexp=1&find=.jsm&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
The type GetDeploymentOptions does not make sense, here we are not trying to get a deployment, it would confuse the customer with the name.
Same styling as `.network-detail-overlay .foldable`, should they be merged?
Maybe make these uint64? It seems they should never be < 0.
While you're at it, check that the w/h passed to the renderer is correct. If I remember right there is an extra check in Graphics.cpp that the requested video mode is actually supported.
Like I said, I omitted the details of how I arrived at this solution, but before I did this, the plan was to watch for the notification both here and in the results controller so each could handle its own updates, but we need to target the specific object in the result array and I couldn't see a way to reference the array from the controller. Taking a second look this morning, it looks like `QSResultController currentResults` might be what I need. I'll play with it.
Afaik most rubists [agree](https://github.com/bbatsov/ruby-style-guide) (search for `{`) that having spaces around braces makes code much easier to read. Besides, here you can easily use `map(&:to_s)`.
I did not know this! I've changed the code to use `&&` and `||`.
This should probably be simply `||` rather than conditional assignment. I don't think that decent exposure should mutate the params hash.
Depends what you mean by "necessary". No curlies doesn't necessary mean more clarity, in fact many times means the opposite. I can get philosophical there, I assure you.
Do you gain much out of making this a class, rather than a standalone Dygraph.DrawRegularShape_ function? I definitely have a preference for the latter.
Typo "Firt", change pushed
Recommend adding a reference to the parallel sequence of *.yaml files that demonstrate the same functionality using galsim's config parser `galsim_yaml`.
No that's ok.  I didn't see it here, so I wasn't sure if there was a python doc string for it.  But help(galsim.HSMShapeData) works, so it's fine.
Heh, serious bypassing going on here.
forgive my maven ignorance but will this create a shaded jar or copy all the artifacts in?
either way it seems like it will slow down the build quite a bit.

are we better off removing this classifier and pointing to the CLI jar?
This won't work properly anyway, since the placeholder value changes for every site.
다 액티비티로 바꿀께요.
```'Der er ingen nyheder endnu. Klik "Tilføj nyhed" for at oprette den første.'````
Aceito.
really?  then methods like this wouldn't work:

```javascript
StackMob.isUserLoggedIn('justin',
    'no': function(){ ...do something... }
}
```

Requiring both to be defined would require a developer to add something like `'yes': null` for the 'no' callback to work.
You are mixing up  friendlyName and deviceName. We should get friendlyName from user but PZP internally should set on its own device name. It works fine for 1 PZP, for second PZP I would suggest combine with friendlyName.

Reason is there is WP to get PZP friendly name, support will be both via command line and browser. In that scenario it will be clash with your changes.
Per cakephp standards you  need to add a space before and after each comparison operator and assignment operator
doh, didn't notice but should have assumed since that is our norm :-)
This is code from before. I didn't want to mess with it. I suppose this isn't necessary. Should I take it out?
missing ``public`` keyword
Indent me!

`without('constructor')` instead of `withoutAll(...)`
A minor point, but I think it’d be more readable if these were either consistently on separate lines or consistently wrapped to a (sensible) line length; I would prefer the former.

Also, spaces around the `=>` symbols would be more consistent with the rest of our code.
Yep typo. :/
Закрываешь System.out.
И опять исправление в моём файле.
Why don't you call a rand function simply?
Not a required change, just a note, as you seem to use this idiom a lot rather than using regexes (which seems reasonable) or substring slicing (which seems like a bad idea).
Renaming "dev" to "device" would give this code more context.
Maybe add a bit more detailed description what this does.
Actually, I just added one in master recently, just had to rebase ;)
Could you add an explanation how the similarity/dissimilarity approach is different / similar to the affinity matrices used in other manifold methods?
you should avoid doing X[y == y_i, :] and sample_weight[y == y_i] twice
+1 Should we communicate to the caller that this "cheap" convergence criterion has been reached? If so how?
Yeah, could kinda go either way... I will fix the stuff you mentioned and hook up that example pub/emitter socket to use multipart. Having an actual socket implemented might help figure out the short comings and advantages of the temporarily dubbed "encoder/decoder" options at hand.
We probably want to translate to auto, or the users default locale seeing as lots of people use this app who aren't english. What different options can we use there?
pluriel
we already have all the script output as log messages. it should be good enough for know
I think it has to do with the

```python
# If the referrer was from an internal link or a non-search-engine site,
```
I think a common approach would be ideal, though I can see why this is not the case here
I know, but you could do root->setPropInt("@numsubfiles", n) , just the once after the for loop... (?)
couldn't resist...
I can't imagine why you would reuse it.  The importer will need something that maps from ids to expressions, rather than the other way around.
Actually I think it also ensures there is no padding on the record to round the size up to a power of 8.  I'm nervous about code like this, but I assume similar code exists elsewhere.  I think it might trigger a misaligned access assigning to meta on some architectures.

The other use I can find (jhtree) has a comment about #pragma pack not working there.  Have you verified the size is what you expect?
That is fine. I may use getLogs not getDebugValue .. 

I just did a test using getLogs("EclAgent", "EclAgent") for a legacy wuid and the function returns the tag name: <eclagentlog>, not the value (//10.239.219.6/...myeclagent/eclagent.2012_05_23.log) inside the tag. For non legacy wuid, the function returns: //10.239.219.6/...myeclagent/eclagent.2012_06_16.log. Could I do anything wrong?
I don't understand your comment regarding "rowsToSort expansion (inside CSimpleSorterBase::addRow) is unprotected", It never was protected and I don't see why it needs to be.  Its not protected in Roxie either.

Also don't understand your comment that "it's going to increment several times, until indexCapacity catches up with rowsToSort capacity". I query the rowsToSort row capacity and then reallocate the index capacity to the same value.

Meanwhile I will look at your recommendation to derive from DynamicRoxieOutputRowArray::ensure
Hmm well I guess we might as well give up if it's not 408 or 200, so that's a good point.
Why not just `if (!socGraphByReportType) {`?
closing quote seems to have escaped.
Wouldn't that rather be a functional test? Why should I want to unit test AMQP message properties in the class? That should rather be tested for the AMQP message itself
I guess because you can assign any value to undefined if you're not in strict mode
Yep. Got rid this method as if was no where being used.
Oops yeah, the outermost indentation has four. Will do.
Does this mark all notifications a read? If not now is the appropriate notification identified? Wouldn't `DELETE` be more appropriate than POST?
i thinking my last name "de filippo". i can to search "de" or "fi". 
however, I do not understand how you intend to implement this functionality
Okay. Just to be clear, though this is technically a variable, this is also a django form field declaration. It's pretty typical for forms to employ obscure field names so that the querystrings they generate have not-entirely-obvious meanings - i.e. ``?tier=premium&s=serj3k1`` vs. ``?tier=premium&security=serj3k1``.

I'm not sure how much validity there is to that way of doing things; it's a convention which may or may not be grounded. Just want to make sure you're thinking about this as a form field rather than as a reusable python variable. There are other ways that this could be made clearer - such as a comment.
Rex::Mime::Message is preferred for sure.  However, if that function is failing for you for some reason.... make sure the extra \r\n isn't the reason why it's failing.  Usually I do this to filter that out:

gsub(/^\r\n\-\-\_Part\_/, '--_Part_')
and maybe

```python
>>> print props['something']
```
flake8 is good. it does pep8 and pyflakes. will highlight the stefan-style ``**`` though ;)
Is black really the best choice for a default texture?  Seems like it would be hard to notice if the object was in space or in  night time.  Why not gray?  That seems pretty standard to me.
No, most of these changes are not needed (there is only one `_uniforms` now in master).  We only need the assignments to `positionArray` below.
Use [CesiumMath.sign](https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Core/Math.js).
Is this function useful and generic enough that it belongs in Core?
As we discussed, we are going to rename this to `intersect` and continue to use the `Intersect` enumeration where `Intersect.INSIDE` is the positive side of the plane.
I'd like to avoid the terms related with security. For example, SecurityProviderException should never exist into domain of controller, think about another SPI which aims to return HTTP responses currently is ag security but it could be spring security or any another service which returns HTTP responses.

Makes sense?
Change back to for loop if line 612 is being removed.
oh wait, you said the same name as *documented* in iOS.   I thought you meant the same class name  in Objective-C code.

Yeah we shouldn't follow pseudotype names.  Definitely (please) change this to lose the "Type".
If the line break mode has changed you should fire contentWillChange which will force a relayout if required
Wut? These are set to 1 or 0? What ere the default values for these options? Use store_true and do and() on the list?

~~~~
import operator

reduce(operator.and_, [options. ...])
~~~~
Yeah, `.hover()` is deprecated. See http://bugs.jquery.com/ticket/11731

@kswedberg The API docs don't have this marked as deprecated.
@etiennep : how did we end up back at this?  (Again, I'm ok with using the > instead of ".x" if we need to, but would like to make sure that I understand what got us into that situation.)
Oh, I meant that there's no way to use the keystone admin token to work with Glance. You have to supply the admin username and password. Since that is not readily available in a config file (unless openrc is required), I opt'd to use the glance service credentials instead.

Correct about returning an array -- I did have both Glance and Keystone used. But then just removed Keystone and forgot to modify the comment.
Is the CHANGELOG meant to be changed by this pull?
по-моему со скобками только хуже вся эта херня :( но это так
This method should be called mod_network_settings, all functions are named after the XML tag they use.
Have you considered subclassing your debian policy classes to avoid duplication here?
I think TDPL is quite clear that there are no such things as "unmoveable" in D.

As long as the source is correctly "de-initialized to T.init" without calling its destructor, and the target's constructor is not called either, it works.

That's how algorithm.move is implemented, and I never heard of anything broken with algorithm.move.
Please do not prepend `_` to a variable name if it's not a member variable. You can just leave it as `gen` and do `this.gen = gen;`.
s/seemless/seamless/g
First, you probably meant `s.f(i);` instead of `f(s, i);`.
Second, looks like you are checking my pulls very tired. `s.f(i);` obviously will not work as `i` is lvalue.
@monarchdodra I don't think that code works. If `RetType` is a string, you don't want to call `array` otherwise it will be converted to a `dchar[]`. strings should be converted using `to!RetType`.

I'll push something I think should work.
epoll_data_t is not used except inside epoll_event
Leaving it up to you. Feel free to hook an anchor to some of the text instead. All I say is that anyone reading that will be like, "well I better go see what that type is!"
fixed this.  pub for the win... had  to add a hacky setup step required in README but it will go away when the pub bug for self referential packages is fixed.
doSomeOperationWithAnException() would be better english :-)
то же самое, все упадет с AttributeError, если VK_IFRAME_APP_SECRET_SETTING не прописан
And this should really hit the delegate queue.
Worth cleaning up code comments?
Is this purely for testing? What's the use case? Seems of limited application. :-)
Really wish I could somehow emulate `String.IsNullOrWhiteSpace` so if you have an idea, let me know.
now try to change "type:     annotation" to "type: rest"
The system does not add doc comments for all parameters automatically. They only get added if they are deemed valuable. In this case, I'd assume that no type information (or just a very general) type was available for the other parameters.
Should it have a new line inbetween the closing bracket and the return statement ? Usually R# advises for it and i kinda like it.
I followed the pattern laid by the network API where REST is using this service layering.
I would recommend using the #### level for these titles.  It will create a more consistent flow in the document when it is merged together.
(don't we have Info / Warn / Error too?  basically stuff equivalent to printf, I think was decided to 'not be considered a side-effect')
Muy lindo el test!
Move up to the previous line.
@stof find is required here because you always point to a type that is an actual doctrine entity class. 
Also, deserializing sets the valid directly, which does not load the proxy (if I use getReference instead), which leads to weird situations.
const ссылка
Здесь та же хрень.
Forgot about this, it might be a good idea to make this: `scope MainFunc mainFunc`
Don't believe you! Still says "all_tests.h" here
why is this.available.size used in the getIdleSize() method, but availablePermits here?
Also the schema should be changed from xsd:boolean to xsd:string
http://www.connectionstrings.com/articles/show/important-rules-for-connection-strings

"No escape sequences are supported"
shouldn't this be:

    $expire = $this->config->item('user_expire', 'ion_auth') + time();
So those files are part of this pull request?
Let's us a symbol for the icon_ position arg
Although I understand why you use different markups, I would be inclined to use the same conventions for all mounting points. \`dev/sda1\` ??
you need to check if the ``Request`` is set
The way we create the test data (like the above) seems really hard to read.  Why don't we just have a multline string like this:

```
XElement element = XElement.Parse(@"<?xml version='1.0' encoding='utf-8'?>
                                    <Placemark xmlns:gx='http://www.google.com/kml/ext/2.2'>
                                        <name>STS-122</name>
                                        <description><![CDATA[<html><table><tr><td><b>Start Time (T-0:44): </b></td><td>2007 Dec 6 16:31:00.000 EST</td></tr></table></html>]]></description>
                                        <gx:MultiTrack>
                                        <gx:interpolate>1</gx:interpolate>
                                        <altitudeMode>clampToGround</altitudeMode>
                                        <gx:Track>
                                            <when>2007-12-06T16:31</when>
                                            <gx:coord>0 1 5</gx:coord>
                                            <when>2007-12-06T17:31</when>
                                            <gx:coord>0 2 6</gx:coord>
                                            <when>2007-12-06T18:31</when>
                                            <gx:coord>0 3 7</gx:coord>
                                            <altitudeMode>absolute</altitudeMode>
                                        </gx:Track>
                                        <gx:Track>
                                            <when>2007-12-06T19:31</when>
                                            <gx:coord>0 1 5</gx:coord>
                                            <when>2007-12-06T20:31</when>
                                            <gx:coord>0 2 6</gx:coord>
                                            <when>2007-12-06T21:31</when>
                                            <gx:coord>0 3 7</gx:coord>
                                            <altitudeMode>absolute</altitudeMode>
                                        </gx:Track>
                                        </gx:MultiTrack>
                                    </Placemark>");
```

Much easier to see.  You don't have to go and update them all, but if you have no objects, I'll make the change in a separate pull request after this is in.  It should be easy because we can just use the existing element we're creating to write out the pretty version for us.
You can pass it into path(), which will add the query parameter.

{ 'id': id, 'view': view }
I don't have my work laptop here, so I'll send it in tomorrow AM when I'm
at the office

On Fri, Apr 13, 2012 at 7:31 PM, Jim Klo <
reply@reply.github.com
> wrote:

> > +            conn = NodeConnectivityModel(connectionInfo)
> > +            result = conn.save()
> > +            if result["OK"]:
> > +                return "Your end point was successfully registered"
> > +            else:
> > +                return result['error']
> > +        except httplib.HTTPException:
> > +            abort(400,"Invalid destination URL")
> > +        except ValueError:
> > +            abort(400, "Invalid URL format")
> > +    def index(self):
> > +        # Return a rendered template
> > +        #return render('/register.mako')
> > +        # or, return a string
> > +        def get():
> > +            return render("register.mako")
>
> the registry.mako template file is missing from #197 pull request.  Need
> it added.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/LearningRegistry/LearningRegistry/pull/197/files#r684576
>
This makes it much easier to run the plugin using "mvn exec:java"
looks good on the left...
do you need '' here ? seems like the usual is to just reference.
this is completely arbitrary. leave it out. again, we need to see what people come up with.
This however I agree, is definitely a good idea.
```
$(function () {
  // code here
});
```
создать кучу без версий и смержить.
Oh yeah, I didn't think that all the way through.  That's probably a good idea.  We can manage any sort of deprecation and error handling around it in the native plugins, or a common lower layer.
I noticed your previous comment that said something to the effect of "this is required for some reason" - I assume you must have copied from one of the demo plugins?  So I took a look at the documentation to figure out what it actually does.  It's possible we may need to use it eventually, if for example we have a long-running background annotation lookup.
i'd call it 1.0-beta for now. 1.0.0 is a bit too early imo.

for phpcr we have the issue similar to symfony2 that this phpcr is the first, but it implements jcr 2.0... there i would vote for 2.0 and try to follow jcr in the first two numbers to make the relation more obvious.
For every bit faster that creating locks is than updating a column, having to still save this model to keep track of the owner kind of defeats the purpose of using them in the first place.
Fixed for ARQ-1069 pull request.
Because of trouble mocking require.toUrl... I've put a comment inside to explain that
Why are you looping over the keys then indexing based on them as an array? was for( webview in webviews) no good?
Remove TODO statement.  Already logged
Instead of ID (String) as the key to this map, use a composite key of <ID,Object type>, e.g. MigratableObjectDescriptor
Jeszcze nie obgadaliśmy co by to miało być i jak być używane. Musimy to obgadać  przez tel.