labofsahil/github-event-dataset-2012 huggingface dataset:
We now have only one serach view, it renders either embedded or fullscreen, and on both cases, it renders the top search area there are some notes later on about how this effects the search events...
Missing license info
DUPs can be added in the same step
oops, I did not notice this when I picked up Richards test case
Yeah, since I saw the tooltip issue and fix, we can probably drop this. I'll test it.
Yep. but also we have to think that is an experimental validator and we are also using experimental features that probably are not being covered by the w3c validator, and it just throw and error.
What do you think @jmcanterafonseca
<= 80 characters please
Working on it... ;-)
Sets benchmark does not really belong here, I wrote it up to verify my assumptions about its performance.
For example set.has(1) is slower then (1 in object) not sure whats that about...

Other benchmarks (like the ones for template) probably should go into a pref test when they are available.
This patch is still a work in progress :) According to @lco's mockups [1], the title should be different for system/app crashes, so it's not as simple as just substituting in a name. I'm thinking that maybe I should also be passing in a flag indicating whether or not this dialog is for a system crash.

[1] http://people.mozilla.com/~lco/Crash_Reporting_B2G/R1_Crash%20Reports%20v1.pdf
This hack can be more reliable if you probe for `device-height` & `max-height` I think. But it's ok if you think this is enough.
if (...) {
} else if (...) {
} else {
}
@davidflanagan I think it's possible that an audio file contains a broken image, so I would like to keep this handle of onerror.
I modified the comments cause I am not handling the inline activity condition. When an error occurs, the parseImageMetadata() will still go on to the next file.
RemoveRange?
Probably want to run `yard --server` locally and make sure you can easily navigate to all the docs you're adding. The above was originally doc'd where you've now added it, but nobody could find it :)
This is another place where I'd feel more comfortable with declaring the class private.  We can always make it public in the future if someone makes a case for that, but I prefer to err on the side of privateness for things like this that 99% of RSpec users won't have a reason to use.
Doesn't work in this case, since it is a jasmine spy. I could however move the spy creation to beforeEach and use sinon.
Shouldn't this be -f ?
Since this line is commented out, you can presumably erase it?
k. Also, how is babby formed?
This description doesn't help users much. As a user, I get the impression that this method puts entities, but what it really does it store rows. Try to bridge the gap between these two ideas.
+1 thanks, wonder what are all these checks for nil good for?
Right. I'll improve this.
The less than ideal solution if the host has no trust might be if its the composer url itself that is failing to validate (ie have no ca bundle at all), then bundle the current known composer public key in the phar. (chances are folks are going to experience this error shortly after downloading the latest version anyway) Then I'd add a new command, "composer build-ca", which will grab a known-good cacert.pem from https using the pre-known key. Install that for composer-use only, and go from there. 

I'd also update the install instructions on and nuke the file_get_contents version as that will happily grab an insecure url. http://getcomposer.org/download/ (eg try  php -r "echo('?>'.file_get_contents('https://www.hstscookie.ca'));") <-- that site has a self-signed ca.
You really care about the coding standard, even if it doesn't work?
you can change this back after including interm-bootstrap instead of bootstrap-complete in main.css
Hmm that actually works? Interesting, I think it should be `if root.author.present? && root.author != current_user.person`  or `if root.author_id.present? && root.author_id != current_user.persond_id`. Also specs! :)
Some lines benlow in ems_set_led() you check for i.e. HAVE_EMS_LED_BLUE. Why not here?
Move define to cpp file
Please add an description. This is really a no go.
Please see thread here: https://github.com/guardian/frontend/issues/142
I think for this issue we need to check if 1.3 branch if affected as well.
ROS topics and service names are under_scored, see http://www.ros.org/wiki/CppStyleGuide
h.getItemByFullName(name) instanceof ItemGroup

should do it. You should be able to test with the [CloudBees Folders Plugin] or a `MatrixProject` or a `MavenModuleSet` (the latter two produce `Item`s but not `TopLevelItem`s).

[CloudBees Folders Plugin]: https://wiki.cloudbees.com/bin/view/Jenkins+Enterprise/CloudBees+Free+and+Open+Source+Jenkins+Plugins#HCloudBeesFolderPlugin
Add level on next line:
$level = 'component';
Here is a form that would be easier to catch:
```
function require(id) {
...
}
require.main = loader.main;
return iced(require);
```
the only acceptable types are `bool`, `int`, and `string`.  So that is why `float`s were ignored.  It might be better to throw a warning, or error here tho, and the other acceptable JSON types (ie: `object`, `array`, and `null`) should be treated the same as a `float`.
The same line exists also at 177?
I didn't even notice this: the email and id aren't escaped. :(
Going along with the comments up above, if these are in the DOM, why not just show them when necessary instead of copying the contents to the label?
I think we also need: https://github.com/mozilla/nightlytt/pull/79/files#r1014458
I don't think that's the correct answer (iterations:salt:entropy).  I spoke with the Platform team about this, and it looks to be something we're definitely doing, but it won't make Telly.  As of right now the answer will be the additional properties, but in the future (when provider-specific properties are available), we will break them out.
Add a space here so it's easier to tell it's two different functions.
Might want to make this private and add a 'getResults()' method
I think it would make more sense to add the timeouts at the application level, ie in bazooka-cli
The original api treats lim as a count the terminates the loop when it reaches zero after [lim--](https://github.com/soundcloud/doozer/pull/3/files#L0L347) so if you want 20 items from position 5 you call `c.Getdir('', 0, 5, 20)`.  The len() of the original result would be 20.

This change would make the len() of the result 15.
I'm pretty sure parens are optional.

You also got an unclosed opening brace, you don't really need that one either
Yes, that's true. I fixed also in the other subclasses of Zend\Crypt.
The reason is StreamWriter does not add a newline. Without PHP_EOL, you really have a single line in your file for all the time who lives your application...

We must therefore solve this problem.
Fixed, see next commit :)
CS, description missing
Same: Docblocks were wrong (and had been before). Instead I updated those.
Noticed some upcoming changes where this line with the underscore might not be needed: 
https://github.com/zendframework/zf2/pull/1550/files#L39L43
The subpackage should be `Exception`

http://framework.zend.com/wiki/display/ZFDEV2/Coding+Standards#CodingStandards-Files
Please don't use the **@** operateur.
Added notes in searchManager and search.xhtml, and results2.xhtml
Yeah, I don't think the try/catch block is really necessary here.
It's a Runnable @Raphfrk ;)
The switch? Zidane asked to scrap the components for gamemode some weeks ago.
Again, tabs only for this whole file.
It's not needed anymore. I just forgot to delete this line.
I think this was right before.  If there is more than one free variable, then we don't want arbitrarily pick one to do the calculations with.   Better would be to use all variables, but for now, this is probably the better way.
I honestly don't know, what happened here. If I open this file in my editor, everything seems ok! This should be: "Copyright © 2001–2013 Alvaro Lopez Ortega"
you should handle the etag to return a 304 when there is no change, otherwise adding it is useless: http://symfony.com/doc/current/book/http_cache.html#optimizing-your-code-with-validation
it is a special (there was typo here in my comment) placeholder as ``_format`` will be used to set the content-type of the response if the format is in the [list of known formats](https://github.com/symfony/HttpFoundation/blob/master/Request.php#L1458) and the content type is not set explicitly.

Special routing parameters are documented [here](http://symfony.com/doc/current/book/routing.html#special-routing-parameters)
and here too?
i guess then we need to change to default the value to false and have the driver chose nt:unstructured if no better information comes from the parent.
new pr sent. I wonder why it built correctly on travis.
fixed in d0a07da
On Fri, Oct 5, 2012 at 1:10 PM, Edi Modric <notifications@github.com> wrote:

> In eZ/Publish/Core/REST/Server/Controller.php:
>
> > +     * @var \eZ\Publish\Core\REST\Common\Input\Dispatcher
>
> Wrong PHPDoc :)
>
Fixed

--
Bertrand Dunogier
Lead Engineer Extensions
eZ Systems AS | skype:bertrand-dunogier | http://www.ez.no/
---------------------------------------------
Freedom to Create Your Experience - Join us at this year's Conference
http://cologne2012.ez.no

eZ Publish Enterprise 4.7 Available
http://ez.no/About-eZ/Events-News/News/eZ-Publish-Enterprise-4.7
Of course. No idea how though :-)
not a big fan of 'install', maybe try and come up with something better (e.g., 'bin' or '')?

anyway, it's only a default config
This could just be `bitLen = bitLen || self._bitSize`
넵 말씀하신 부분 적용해보겠습니다.
again have a look at the user method :P

(sneaky sneaky sneaky)
I would change these to a single var statement b/c of the style guide, but it seems like they are not faster, assuming jsperf is to be believed. Yay for less work for you :)  (http://jsperf.com/single-var-vs-multiple-var)
I guess that means no scaling then? ;) Probably should drop the loop.
I do not know enough about node - should all the tests end with a trailing underscore?
I'm a bit down on removing this, though I could be convinced I'm wrong. Not everyone is using Bundler, and I think it's much better to surface library incompatibility issues at load time than runtime.
I have described it in the ticket, the reason is that the config_templates data is irrelevant to operatingsystems, it shows all related templates including template data, also the data of templates which are not selected. This data should be (and) is shown by querying template data. I hope my explanation is clear enough, if not I will give some examples.

I don't expect anyone is using this because it is just dumping all templates and not the relations.
Same nit as #2 above.
Moved all the delay stuff to DVDPlayerAudio. Everything indicates the delay is for audio, so it seems to be a better idea to tinker with audio and not video timestamps.
I know these hints are just from the spec, so this isn't a problem right now and shouldn't stand in the way of getting this shipped, but in general I think these hints are a bit too technical/terminology-heavy.

So just something to keep in mind for the future is we should try to keep the hints informal and try to find the simplest way to explain each concept.
Yeah, this is used in the data-ensure on L10 to make sure the inner shape is totally enclosed by the outer shape (there are some weird corner cases [literally :D])
We should add one more hint here giving the final answer
it's a body test
Why was this removed? We want public access to a Conversation.
Similar to ruby style, please use underscored ID names - `#last_twenty_games` and `#badges` - this makes any CSS and Javascript selectors much neater.
Agreed, reverted this recently.
either @zacc or @davehunt complained in a different pull about the test case that uses the options' text to determine if a particular menu element is there. (ie, the test that uses this code) 

the obvious solution is to create 
hover_menu_options(self, hover_locator, menu_locator, menu_item_locator, menu_item_class)
and returns a list of objects of type menu_item_class.

i'm going to defer this, however, until i figure out why the native events tests that are succeeding regularly are succeeding.
I didn't really add `APP`, I just gave the anonymous `%s` a name! ;-)
Please do it as rburchell suggested. Debugging in the code is great if you want to debug a particular feature. Trust us, the ifdef will make sure that it doesn't end up compiled into the release binaries.
The ``suite_for_feed_url`` method actually also has the fallback, so we should probably be using that.
if not key and req.api.extractKeyRegex?
It's an automatically created thread pool. If you look at the source of `future`, you'll see that it looks at `clojure.lang.Agent/soloExecutor`, which you can find here:

https://github.com/clojure/clojure/blob/master/src/jvm/clojure/lang/Agent.java#L53
Should be [] instead of (Optional). I've fixed this.
I'm assuming the principals.api.createUser function should be modified to take a Context
Test title should be in line with the other tests: `verify ...`. Above the test, there should be a bit of additional documentation as to what the test is trying to do.
> This was Iulian who fixed it this way. I admit it's the first time I see this code :)

Oh, I see. Then sorry for blaming you.
Why the catch & re-throw?
коротке ім’я має нормально сприймати
Just read PSR-2 spec and there is nothing about such things.
The point here is that using FQN is much better for IDEs. Mine (PHPStorm) has some problems with relative namespaces.
Probably not. I had some ideas about it, but I'm not using them now, so I'll dump it until I need it.
I think GET could also be GET_VERSIONS or GETALL? (I may be wrong, but I note that use of pipeline.getOperation().getSimpleName() elsewhere in this method.)
This represents an opportunity for sub-classing, e.g. RegularDeck, CanastaDeck, along with a Factory class to facilitate generating the right Deck based on information from the calling entity.
I didn't test images, but obviously they would trigger the event :-/

I'll iterate, good catch :-D
Да. _DNA - переменная, описывающая состояние объекта. Соответствующий getter - уже реализация.
А если и второй раз выпадет тот же индекс? И третий? И подряд 1000 раз? Вероятность такого варианта отлична от нуля. Логично было бы исключить этот элемент из выборки.
Можно подробнее, где тут магия?
Enlève juste cette ligne qui est en trop xDD
(and yes, this function has a poor name since it really only deletes files... )
It should actually be a map since all you are doing is making a collection of another type.  I vote this gets changed before merged in.
This should be consistent with rails 3 - controller#action
one Instalation section added.
Consider using [assertCount()](http://www.phpunit.de/manual/3.7/en/writing-tests-for-phpunit.html#writing-tests-for-phpunit.assertions.assertCount).
Yeah, this makes sense for me.
The associativity of folds is usually indicated in their names (fold left, fold right). If we're assuming a left fold and can't implement a right fold (I don't think there's a sane way to do so), I would like the name `reduceWithStart:combine:` more.
Aha, gotcha.
Just a note for future additions: `<br/>` elements are meant to be used for line breaks only, not for visual spacing. In general, the different HTML elements just provide the semantic markup of the page (except maybe `<span/>` and `<div/>`). Use CSS for anything visual. This difference is important, for example, for blind people who would like to use our website.
On Tue, Nov 13, 2012 at 10:59 PM, Alexandre Gramfort <
notifications@github.com> wrote:

> In examples/preprocessing/plot_ica_from_raw.py:
>
> >  # 1 minute exposure should be sufficient for artifact detection.
> >  # However, rejection performance may significantly improve when using
> >  # the entire data range
> >  start, stop = raw.time_as_index([100, 160])
> >
> > -# decompose sources for raw data
> > -ica.decompose_raw(raw, start=start, stop=stop, picks=picks)
> > +# Sign and order of components is non deterministic.
> > +# setting the random state to 0 makes the solution reproducible.
> > +ica = ICA.decompose_raw(raw, start=start, stop=stop, picks=picks,
>
> I don't know why you changed the API.
>
> why not keep the init as it was?
>

The problem I saw / see is that data, picks and ica / pca init have to go
together. With the current API this would mean to either pass everything on
init (instead of raw / epochs epochs_raw or meeg_container as arg, which
seems somewhat weird.) or have pseudo init that sets almost nothing and do
everything via decomposer_raw / _epochs. Both seemed strange to me. But may
be I'm  just temporarily blind, trapped in some attractor basin. Wait, just
writing it seems to help. I just got aware of one conceptual flaw. If we do
ICA with self-made whitening via RandomizedICA we can't pass any
n_components (whitening=False and n_components!= None will throw a warning
that n_components will be ignored....). So we can init the acutal ICA
without knowing the components, that is, we can set the pca whitening on
ica.deocompose_XXX.

Detours enhance your local knowledge -- let me get back tomorrow with a
clean PR. Thanks for the feedback.

D.


> the only change I see in that the whitener should be computed in the
> decompose use RandomizePCA.
>
> using class method you duplicate all the parameter definition that is
> common between raw and epochs
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/188/files#r2116915>.
>
>
just brainstorming... why not just a plot_topo_imshow where we display 2d imshow at each sensor location
maybe not as explicit as plot_topo_tfr but could be an internal function and we create plot_topo_power and plot_topo_phase_lock if this can be done with little code duplication. wdyt?
you can use evoked_auditory.plot() and evoked_visual.plot() it's shorter.
np.zeros(x_len, dtype=np.bool)

is good enough
ch_chan_types = np.concatenate(ch_type_idx)

should do the trick
Changed. I removed isDeathdateEstimated() method also.
Better to provide a comment saying *or* is part of a larger sentence.
There should be no space before or after the `.` operator.
Replace the dot with a semi colon
You should add `()` if you use the `new` operator.
s/confirmatio/confirmation/
s/  However/ However/
shit you're right on that one too


On Thu, Aug 23, 2012 at 2:12 PM, Carl Hall <notifications@github.com> wrote:

> In
> contrib/media/brightcove/src/main/java/org/sakaiproject/nakamura/media/brightcove/BrightCoveMediaService.java:
>
> >     * @see org.sakaiproject.nakamura.api.media.MediaService#acceptsMimeType(String)
> >     */
> >    @Override
> >    public boolean acceptsFileType(String mimeType, String extension) {
> > -    return mimeType.startsWith("video/") && supportedVideoExtensions.contains(extension);
> > +    return mimeType.startsWith("video/") && supportedVideoExtensions.contains(extension)
> > +        || X_MEDIA_BRIGHTCOVE.equals(mimeType);
>
> I'm not sure this logic does what you want. Seems like you might want (mimeType.startsWith("video/")
> && supportedVideoExtensions.contains(extension)) ||
> X_MEDIA_BRIGHTCOVE.equals(mimeType). wdyt?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/thecarlhall/nakamura/pull/2/files#r1447628>.
>
>
Why detect here? This is only going to be returning one order. Wouldn't you want to just do `past.bill_address?`
I created http://code.google.com/p/sympy/issues/detail?id=3107 for this.

And I refer you again to the simplify() docstring.  The whole things is just one long running discussion.  It would be much easier to read if it were broken up into logical sections based on what is being talked about.
No. Good catch. Thank you.
Оно там нормировано на единицу. Умножь возвращаемый qreal на 100,
чтобы получить проценты.
Зачем все это. Это же путь к директории с синхронизацией. Оно и так ок.
Hah. Whoops. Disregard.
I would throw the CATEGORY in here instead of writing it out fully, just so that when i search for CATEGORY, all of the related uses come up, including the expected output and the sample input.
Do you have a traceback?
these should be `node[:mongodb][:user]` and `node[:mongodb][:group]`, respectively
@danielwestendorf It looks like what you fixed in #1789 is still present here, right? I'll make sure to fix it if so.
Tuples can be handy, but beyond 2 elements, I think they're a bit messy.

Why not build and return a GetWithMetadataResponse from here? That'd make the code more readable :)
onEntryActivated does two things:

1. store.remove(key)
2. if stats are enabled, it updates the activation counter

onEntryActivated is called so that both of those things happen (if stats configured...)
Is it really worth optimizing for the single-server case?
don't do this. If you absolutely have to add padding and can't do it with a class, at least do this:

```<div class="ui-grid-a" style="padding: 12px 0">```
On Sunday, September 23, 2012, Francesco Montesano wrote:

> In lib/matplotlib/pyplot.py:
>
> > @@ -2189,8 +2192,7 @@ def getname_val(identifier):
> >              elif i==1:
> >                  ax = fig.add_subplot(1,1,1)
> >
> > -            ax.grid(True)
> > -
> > +	    ax.grid(gridon)
>
> I thought that too. But then if you go to my repository (
> https://github.com/montefra/matplotlib/blob/plotfile_grid/lib/matplotlib/pyplot.py)
> ax.grid(gridon) has the right indentation.
> Can be a problem with tabs. I use vim with some selfindent and it seems
> that it converts spaces to tabs when they are many.
> I've tested the code before submitting and didn't get any indent error. I
> can substitute the tab with spaces and recommit if it's a problem.
>

Do a google search for "python vimrc options", and you will find an
appropriate set of options to use.  They will work properly even with self
indent.

>


>
My plan here is to provide a page with "thumbnails" of all of the open figures (with the `figure.get_label` beneath it).
yeah if request is not set it'll be false and it goes back to regular behavior
This is weird. Calling `isElement` should be sufficient to know if the given object is an HTML element. If not `isElement` should be changed.
These lines look like guesses toward the cache issue, which was really something else. However, they seem correct, permit-able and possibly useful. So it's fine with me to leave them in
cache.get(cache_key) below may yield a None ( if file_obj.url is None for some strange reasons we don't control)
Maybe a bit of crazy-defensivness wouldn't hurt?

    if cache.has_key(cache_key):
        value = cache.get(cache_key)
        if value is None:
            return value
Can you break this long line up into smaller chunks?
empty line before protected please
please put that { into a new line
please use if (use_sg_mallocs) 

(one whitespace between if and ()
Can you please have a go at rewriting it if you have time? :)
why the removal of `bundle exec`?
Docs for this hook?

As for the name, we've implicitly settled on using `_` as a separator. So `ushahidi_filter.view_pre_render_layout`
Yes. I thought I'd caught that one, but there must have been two of them.

On 10 December 2012 08:19, Jocelyn Fiat <notifications@github.com> wrote:

> In library/server/wsf/router/wsf_router.e:
>
> > @@ -53,6 +53,9 @@ feature -- Mapping
> >  	map_with_request_methods (a_mapping: WSF_ROUTER_MAPPING; rqst_methods: detachable WSF_ROUTER_METHODS)
> >  			-- Map `a_mapping' for request methods `rqst_methods'
> >  		do
> > +			if attached rqst_methods as l_rm and then l_rm.has ({HTTP_REQUEST_METHODS}.method_get) then
> > +				l_rm.enable_head
>
> I guess the change in map_with_request_methods is not relevant anymore.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/EiffelWebFramework/EWF/pull/16/files#r2361207>.
>
>
This would also work.

```
assert_equal false, CloneWar.new.war?
```
Worth logging status type things as well.
PackageVersions is where the rest of the version upload logic lives. You go from `versions/new` to `versions/upload` to `versions/create`.
Yeah, I'm trying to follow the PEP8 style of separating imports into three sections: the standard library, third-party libraries, and local modules.
Your tests don't work.  You're setting Accept, but not Content-Type above, and definitely not sending JSON.

Also, you've only stubbed the token request, and not the commits. The test fails:

```
test_push(WorkmarketTest):
NoMethodError: undefined method `[]' for nil:NilClass
    /Users/rick/p/github-services/lib/service/../../services/workmarket.rb:19:in `auth_token'
    /Users/rick/p/github-services/lib/service/../../services/workmarket.rb:27:in `receive_push'
    test/workmarket_test.rb:19:in `test_push'
```

The authorization stub should return `{"response":{"access_token":"monkey"}}` so it can parse the token out and send the commits.
`(comp not pred)` = `(complement pred)`
ah ok, in which case the parser should get passed in the constructed string and not the InputStream - then either invoking parseTests by default or delegating to the specified parser, which makes the intention a bit clearer and avoid the no-op parseTests which follows.
Better to say "Enable speakerphone during a call"
Something missing here..
This should be replaced with a `StringBuilder`
Thanks for the input, i've revised the pull request with your suggestion.
yay copy-pasting :)
Oh. This is a test class. This may be OK for internal use.
Please expand to `getRelativePath`.
Nit: Double blank lines aren't necessary.

There are at least 2 other parts of this diff where the same comment applies.
I assume that job is already sent to all the workers, so I can remove it.

/cc @joshk @svenfuchs
I am not sure that `is_safe=True` is correct here, too.
You do not need this. This is used automatically if you do not set anything as from e-mail.
`base` is not used?
I was in hurry, that's why I wasn't focused enough. Sorry, it won't happen again.
Я про парсер, который генерит сайт yiiext.github.com (сейчас, правда, там поломка и ничего не генерится).
codestyle ^^
Wasn't AfterHit only called once for each spell?
also
GetHitUnit() should return NULL in this phase.
This needs to be redone, it'll be disastrous if you execute the query more than once.
Yep. Oops.
Getting closer to the actual changes :-)
if props is a mapping, you can write here : props.get('args')  as None is implicit
I don't think we want to use threads to do this kind of things. Why are you spawning threads here rather than doing that synchronously? I've seen this in different parts of your code; I may be missing something but it seems better to not do threading if we don't need to
Doh. Plus, I don't need this workaround anymore. That's the problem with old code.
ah, `(do_raw ? "raw" : "not_raw") + "_bound"` is what I mean, thanks. I do it this way so it's "lazy" – but it of course doesn't make a difference, I can change it if you want? Also I have renamed `not_raw` to `parsed`.
Good point . `_suppress_updates_url` would be enough.
True. I will get used to that at _some_ point.
I think it would be nice to only clone when it is needed, to lessen allocations on the critical path. AFAICT nginx reloads its configuration by starting new worker processes, so I think we could optimize a bit here, as we don't have to worry about on-the-fly reloads.
Just to this one (for the rest I need less distraction by kids)

The way I interpreted R and VD, I implemented the "small" sample version. They split the sample only for the case when nobs is large, run the process for 5 to 6 subsamples. I haven't implemented that part yet.

the number of iterations (c-steps) in the 1st stage are only guidelines, AFAIKS. In my examples, I often used only 1 refinement step. (There might be a small argument on the definition, because I check after the estimate, and I'm not sure if 1 c-step doesn't actually mean almost two in my case. I didn't check very carefully how many steps or half-steps are in my iteration.) 
Trying out different versions, it didn't seem to me that many refinement/c-steps are necessary in the first stage. Having more random starts looked often more important. But I keep more for the second stage than what R, VD recommend.

It looked to me a bit like guess work and extrapolating from examples, for what a good combination of the 3 "tuning" parameters are, number of random starts, number of c-steps in first stage, and how many of the first stage results to use in the second stage until convergence.
nice DRY!
Comment whether this is in radians or degrees. (or make the var name rotationRadians)
It was at one point, but the Configurable part wasn't working out, it was initialized with a null configuration. (although looking back it may have been my fault and happening with plexus based injection as well, have to try it again)
You don't need to set the property unless it was null.
recommend final be added to logs that have no setters like this.
"RealGalaxys" or perhaps better "RealGalaxy objects" (to avoid the nasty apostrophe altogether)?
Could this be "localhost", instead of "almacretin.local"?
Is the annotation really a "Catalog" or is it on a "CatalogItem"?
-1 for using "if !defined"
I suggest we put this augeas resource in a pam::limits::su class or something similar, and include this class here. What do you think ?
I will fixes it.
So does this mean if I have ***a*** defined in global then ***a:hover*** goes here.. Not sure if I like this?
" However, as said earlier, for mobile web applications that use relative URLs exclusively, introducing some form of URL customization is a requirement for being able to migrate them in a hybrid form." -> "Be warned, if you have a mobile web application that uses any relative URLs, you will need to refactor them to include some form of URL configuration".
I don't think this is correct. (Ditto for other occurrences.)

Perhaps the use of `<a response reader object>` to indicate that the section of text can't be represented as a Python expression. This is the style the Python interpreter uses when trying to print something complex, like an open file object.
That should do it, thanks!
Also, check to make sure Silverlight and WindowsPhone support this property.
It's better to pass here ConfMan.get("guioptions", ConfMan.getActiveDomainName());
Agree. Never used automated tools with that, so can't tell really. But i trust your opinion :-)
would change all these to "DEFAULT CHARSET=utf8" instead of latin1;
nm, I just wanted to squash individuality!
Ne pas utiliser du HTML mais du HAML.

http://html2haml.heroku.com/ pour traduire du HTML en HAML.

Lis le petit tuto ici :
http://haml.info/
Don't talk about yourself in the first person, or any person. And no smilie faces! :D
Can you kill this off so browsers without console available wont freak out?
I would change all 3 of these to let's and delete this before(:all) block

I don't have a personal problem with before(:all) but I've seen it heavily recommended that before(:all) be avoided due to potential headaches down the road.
Нет, если нужно именно текущее значение, то оставляй. Я просто уточнил.
Кажется, что это не по заданию реализовано.
Something to display to the user telling them what the target is. I can see at 2 uses for it: In the title of a developer tools window telling you what you are working on, and also in a target selection dialog telling you what targets are available.
For web pages, name probably == document.title
I saw you mentioned in #141 that php53 supports libedit. If you could do this as well, it’d be cool. Otherwise, it will need to be fixed soon. I hate useless dependencies.
er, too
We had issues with our Pivotal Tracker and this link doesn't point to this story. We should remove this.
the filter defined in the bundle is ``extra_markdown``, not ``markdown`` (sorry for giving a wrong name)
Fyi, the number of links that would be affected is:

```
jrs-macbookpro-25399:sphinx sebastien$ git grep components/bio-formats/src/loci/formats/in | wc -l
     105
jrs-macbookpro-25399:sphinx sebastien$ git grep components/scifio/src/loci/formats/in | wc -l
      22
```

I agree the numbers are large enough that it would make sense. Most of the links are in the `formats` pages and auto-generated though. So I would implement this in a separate PR.
Also this variable should be a boolean (`True` / `False`).
There isn't an ending date before changing the behavior.
It should be mentioned that 'gaussian' corresponds to what is often known as RBF or 'heat kernel' depending on the community.
add docstring :)
This function is not needed.
yup, it uses `with(){}` which is what gives you the magical global-like feel of local variables
`char*`
`char *`
Please remove the duplicate commented out lines above
Can we separate the dump logic from the output. Why would someone call this with a block when they can just call "table_description_for".
no, classes from csv aren't new style classes :-1:
Are you expecting this to expand? 

If so, "return hasLink..." would have the same effect, for now.
If not, a macro would have the same effect... ;)
I agree 100%, but we definitely need a common interface between strategies for all these methods too. The problem is not in this interface, but in Doctrine which doesn't have a common interface between Query and QueryBuilder classes in the ORM and ODM. Should we remove this methods from the interface anyway?
That's the UI's fault. It's hardcoded HTML there. 

It would be nice to be consistent. We could let this decorator set `request.possible_days` and then in the template we instead do:

```
{% for d in possible_days %}
  <a href="?days={{ d }}">bla bla</a>
{% endfor %}
```

Shall I implement that you think?
We're supposed to omit signing the body when the content type is multipart, I think. Would that make this logic wrong?
This should be DRYer. I can look at that after the pull.
这里的 really 可以考虑翻译成『实际上』，『Lisp 实际上是两种语言：一种。。。』，这样阅读起来更流畅。
@shacker isn't that what we're doing here? I do agree that we can resolve this with Require or another loading mechanism but again, that would add more complexity.
Needed to make this change otherwise it was a real pain in the ass to debug.
THIS ONE WAS EXCEPTIONALLY WONDERFUL
if (!is_kernel_24)?
I didn't, but I can.

On 4 Oct 2012, at 22:05, jlee-r7 <notifications@github.com> wrote:

> In modules/auxiliary/scanner/sap/sap_soap_brute_login.rb:
> 
> > +class Metasploit4 < Msf::Auxiliary
> > +
> > +	include Msf::Exploit::Remote::HttpClient
> > +	include Msf::Auxiliary::Report
> > +	include Msf::Auxiliary::Scanner
> > +	include Msf::Auxiliary::AuthBrute
> > +
> > +	def initialize
> > +		super(
> > +			'Name' => 'SAP SOAP Brute Forcer (via RFC_PING)',
> > +			'Version' => '$Revision$',
> > +			'Description' => %q{
> > +				This module attempts to brute force the username | password via an RFC interface (over SOAP).
> > +				Default clients can be tested without needing to set a CLIENT.
> > +				Common/Default user and password combinations can be tested without needing to set a USERNAME, PASSWORD, USER_FILE or PASS_FILE.
> > +				The default usernames and password combinations are stored in ./data/wordlists/sap_default.txt.
> 
> data/wordlists/sap_default.txt doesn't exist and isn't part of this pull. Did you mean to include it?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
> 

email:    dave@northern-monkee.co.uk
skype:   n-monkee
ichat:     nmonkee.mac.com
web:      www.northern-monkee.co.uk
bus:       www.linkedin.com/in/nmonkee
twitter:   www.twitter.com/nmonkee
This end mark test can fail, check for example "modules/exploits/windows/browser/adobe_utilprintf.rb", in_super will be false when you reach this line in the description:

<pre>
				< 8.1.3. By creating a specially crafted pdf that a contains malformed util.printf()
</pre>
 
and the full super call function won't be scanned.
I think the `params` construction you used in `_make_affine` reads a bit better.
You can just return the right-hand side of this equation.
This doesn't actually test that it ever binds to the event, does it? If you comment out line 3 of observer.js, do all the specs pass? This applies to the unbindFromAll spec below, as well as the specs for `Observer`.
Is `:with => /abc/` necessary here or anywhere in your pull?
Yes double quotes, no on one line.
Are you sure that #anything is reloading the page?
Also add `this._extent = undefined;`.  Do you see why?
> Throw an exception in those functions if isReady is false like we do with isDestroyed on objects holding WebGL resources?

This is a good idea, I'll do it.

> Have a factory that asynchronously returns the provider given the arguments of this class's constructor function? If I really knew what promises where, I might suggest them here.

This would yield terrible usability because the user would need to fiddle around with async callbacks just to create an imagery provider and add it to the CB.
Sorry to be picky, but why not just `context.draw(commandList[j]);`
Should we use a static `clone` or `from` function here?
Take subscriptionId as a parameter
Rakefileをコミットしたくない理由は何だったのでしょうか？
`provisioning_profile`や`codesign_certificate`ですか？

僕は https://github.com/satococoa/SoundTester/blob/master/Rakefile みたいにymlファイルに設定を書いているんですが、他の人で同じようなやり方をしている人が居るかどうかはわかりません。

https://github.com/HipByte/RubyMotion/pull/16 の `.rubymotionrc` 機能を RubyMotion につけると解決しそうですね。

とりあえずこのPull req.では乱暴ですが Rakefile をコミットしちゃいました。
Better yet maybe just get the timezone from the "begin" and "end" dates.
There's also a EVENT_END_TIMEZONE field we can use for the "end" timezone.
That is correct, BUT nor does minification strip out redundant `{` or `}`, i.e., even with minification, those `{`-embeddings of one-liner bodies still add two characters.
Declarations should be on different lines.
Brace should be on next line for methods
This is a good change but it was a mistake when we originally put this method inside TiConvert since this is used only by Geolocation.  If possible, I think this should be moved to GeolocationModule.java along with the existing buildLocationEvent() method and events should be built in a more generic way.

For example:
-success property should exist in all events for Geolocation events and ideally be set as part of a "buildBaseEvent" or "buildGeolocationEvent" perhaps that is then invoked by the "buildLocationEvent" and "buildErrorEvent" calls
-likewise, provider should always be present

I know this is arguably scope creep, but since the fix involves changing how the event is built we can (and should IMO) take this opportunity to update the mechanism to something that will cause less problems in the future by maintaining better encapsulation, code re-use and event consistency.
missing `);`
"jQuery UI {{component}} API documentation" works!
Yes. I will update the branch for all of these.
They led to a cyclic dependency for me..
change line, is already subclass of Toolchain (or just remove it)
:) Я там сначала написал `class="uploadcare-crop-widget__image-wrap" role="uploadcare-crop-widget-image-wrap"`, потом подумал "какого черта!?" и убрал `role`. Верну.
numVertices
OK, I understand. Thanks for your explanations.
> This seems wrong to me; it should be int.alignof on 32-bit systems.
Why?
Is static as opposed to dynamic? I see from the examples that the trait works e.g. with `int[]`.
Pretty self explanatory. Do rake -T to see all tasks.
What does Objects.equal() return if both parameters are null?
Hmmm, I think that's enabled by [default](http://maven.apache.org/plugins/maven-release-plugin/perform-mojo.html#useReleaseProfile). So I was wondering whether the JavaDocs aren't already published to the repository.
And indeed that seems to be the case for the [snapshot repo](https://repository.jboss.org/nexus/content/repositories/snapshots/org/hibernate/hibernate-validator/4.3.0-SNAPSHOT/), but there are no JavaDocs in the [release repo](https://repository.jboss.org/nexus/content/repositories/releases/org/hibernate/hibernate-validator/4.3.0.CR1/). Is there a way that we can test this without actually doing a release?
Nice testing approach with invocation counting :)
During a regtest, yes, full nodes are/should be used.

This is going to be an issue if multiple installations of Intel tools are performed side-by-side on the same system, but you would have to fire up two Intel instances to achieve that, which may cause problems in other ways as well (e.g., when building the same software twice, at the same time).
Missing a comma at the end of this line.
Un petit retour à la ligne s'il te plait :D
About testing:
It is very easy to test like it is, because it only have one public method and if we just mock this method, then there would just nothing happen. But I can of course add an interface for it.
@cneves: Is there a compelling reason to be using `==` here rather than `is`? If so it should be documented.
To remap old repo / package name to new.
It would make sense to make strings like author, entry, etc., constants. They're used in more than  one place.
This line took me a few reads to figure it out. It's correct, but it looks like a typo on first read. The comment
explains it though.
same as above - it's for better log output
@croby - These lines (until `enableSorting()` ) are almost exactly the same as in the `addTopPage` function.
Would it be possible to combine these in a parameterized function?
Should be an integer
`Util::XmlSettingsDialog_ptr` (и в типа класса тоже).
I actually gaved Foo Fighters another post. When I filter, the scope "All" remains at 2. It should go down to 1 isnit?
Please add comments about why this method is called and what it does.
hrm a bit unusual to put the semicolon after the comment
Phobos uses 4 indendation levels.
Hi!
Yes, it will "0", but I don't do 'default-delay' & 'delay-header-name' mutually exclusive, I just remove its requirement.
We don't forbid to determine 'default-delay' to use when Mesasge doesn't have the header.
Otherwise I feel a bit uncomfortable to add `default-delay="0"` for all `<delayer>`, when I want they work as filters: if messge has header it will be delayed, otherwise just replied.
On the other side, if I want my massages should be delayed independently of header, I just place these attributes togather:
````xml
<delayer id="delayerWithDefaultScheduler" default-delay="5000" delay-header-name="foo"/>
````
s/~~are requiring/require/
Should we throw an exception? Or allow XML configuration to override the class annotations? Seems to me we should allow both but XML wins.

I realize this was the old behavior, but since we are reducing exceptions here...
This sounds ok as we are indeed retrieving an entity.
I actually expected more comments about this than the defaults. This part requires redhat-lsb to be installed for RHEL 5 to work properly.
The sdk path parsing should go in the constructor above because you can't pass arguments into apiInjector due to how it's called.
I thought we dropped MSError, and just use NSError? Randall should have an existing error block typedef you could use?
@stuartf Awesome tip, didn't know about that. I added it in.
I'd skip this block and instead use the merged config only
what's this little guy?
Looks to me like it uses BigEndian byte order both times.
What the heck... it's not like that locally, yet persists here even after pushing with -f.
Why not use Disable()/Enable() instead of this?
setLabel already calls trimToFitButton
Consider renaming to ApnsFeedbackScript
instead of having knowledge of the message stanza here, the notifier should just require the messageText and sender as separate params. A change in the messageStanza object should not affect the notifier.
Done in 0108c04
This message should include the name of the group that couldn't be found.
Not sure why we have this doc.  Does it actually work?
Considering that users reading this document will almost certainly *not* be using 1.7.1 do we need this in here? This is a revision history, not a description of the API.
We should note that all these constants are available on android, but only SENT and FAILED are used.
Why the split between impl and int-tests ? 

Do we foresee a api/spi module coming here?

If we only have one 'exported' artifact, we should name it arquillian-jrebel (exclude the -impl)
Do we really want the string "null" for these, rather than having the field just not be present?
This is not really required, as it is the default of Twitter Bootstrap:

![Twitter Bootstrap defaults](http://dl.dropbox.com/u/5912/Jing/2012-02-29_1818.png)
No problem, even a totalitarian boss can make mistakes ! ;)
`[EventData.name="Событие"]`
well the feature wasnt really exposed, but i guess someone could have defined their own service. i will readd the property
When one of the fields defaults via external calling to `None` I generally set that as a kwarg so it's obvious when reading the original function that `None` is a property that's the default.
Hmm... I think it probably belongs inside `armstrong.db`.  Let's tentatively go that route.
In general; I don't think that any of these are actually correct; the main issue here is that the radio element is usually just simply wrapped within a label (no for tag) and does not contain a class.