labofsahil/github-event-dataset-2012 huggingface dataset:
Really, message flashing is the built-in flask way of handling this: http://flask.pocoo.org/docs/patterns/flashing/#message-flashing-pattern

But Samuel's code cleans this up anyway, so I'd say don't worry about it.
имейл => e-mail
you should use early returns instead of using ``elseif`` many times
So only this particular exception?
you should probably pass an event object giving access to the input and the output, to give a bit more power to the listeners (at least the input)
Do we really need to extract?
Won't this throw an exception if $value is only one character long?
Why not use getOneOrNullResult?
necessary for api
No. You don't need to pass a weak reference into the block when you call it.
Not sure if it is a good idea to promote https compared to SSH (for read/write access): https asks you your login/passwd when pushing whereas github provides a secure way to skip this point with SSH-key publishing in your account.
No?
OK, I'll look at these again.
same for these ones
true, good call.
you should look for other applications in Namespace registry
The decimal points should be escaped in the regex above.
Any chance that bad browsers may send this out-of-order? For example:

    pt-br;q=0.1,pt-PT,pt;q=0.9,en-US;q=0.8,en;q=0.6,es-ES;q=0.5,es;q=0.4,en-gb;q=0.3

Assuming they may, does it make sense to add a test for a header that's not nicely ordered, or to alter this one test to check for that?
Propably it isnt, just my bad, for some reason I assumed it has to be in "indclude" section. Should it be also removed from excludes?
Given that the 1.0 parser still needs to recognize the "domain" attribute, you should delete CommonAttributes.DOMAIN, and @Deprecate Attribute.DOMAIN("domain")
8644289
@jaoo we are waiting for action on your side (what @vingtetun suggests)
I guess that you could delete the code between lines:

https://github.com/benfrancis/gaia/blob/master/apps/homescreen/style/grid.css#L34
https://github.com/benfrancis/gaia/blob/master/apps/homescreen/style/grid.css#L47
it's not shared right no?
Use one |var| per variable.
Sure, i was waiting on landing the previous PR to do not break anything. Now is time to clean up!
One `var` per variable.
It cant be because we are targeting `span` assuming it will be an icon, if this approach does not cause any bug or several performance issue i will prefer to keep as it is, and as soon as we have markup independent icons we can change it.
Thx!
nit: space after colon
```css
  -moz-box-flex: 1;
```
If I'm reading the metadata parsing code right, then rotation will be undefined here for videos that are not 3gp. They'll have a metadata object, but the metadata object will not have a rotation property.

Then below, in the switch statements, none of the cases will match.

I haven't tried running the code yet, but it looks like it won't work right for non-3gp videos.
Remove the useless `slice()` at the end.
It sounds great. 
`highlightState` is a string-like variable 'GREEN', or have a more meaningful name? What do you think?
Cool! That worked.
This is a bug, $this is not accessible here.
I think this comment should be addressed.
stylus should be fine if this is left
enemyx and enemyy should be integers, rather than Strings.
I don't see where you initialize the logger - where is that?
Why are we installing `htop` now? Maybe move this out of this pull request since it doesn't appear to be relevant.
Don't assign to hd.util here. Just assume it has been initialized. If we extend the namespace elsewhere before this line executes, the extensions will be lost.
https://github.com/aeosynth/4chan-x/commit/804807955a7ef6d18b70f23915611eeda8265765

`$.NBSP` ?
`\u0` =/= `\0` you retarded monkey
This is where having a proper Python class to represent this will come in handy - this kind of ugly walking through the arrays disappears.
I apologize about the lack of comments. I often forget about them during the initial phases of just trying to get things to work.
I changed it so that it should work with Linux now.
same here (`pwd` test)
As an optimization, can't we simply use `Backbone.trigger.apply Backbone, arguments`?  This would also allow us to remove the splat in the parameters and reduce the length of the compiled js.
Should be `foreach (...) {`
public methods should come before private ones
Whoops. Good catch. Fixed.
Although, can you submit a separate pull request against ipython/master for this change.  I want to get other people to review it.
[Hulu](http://hulu.com/)は次世代のオンラインビデオ体験の構築にBackbone.jsを利用しました。Backboneを基盤としてウェブインターフェイスは刷新され、すべてのページのコンテンツはユーザの操作に合わせてスムーズに動的に読み込みを行うようになった。Backboneはスクリプトや埋め込まれたビデオをリロードすることなくアプリの中を移動することを容易にしつつ、追加のデータ操作を行えるよう、モデルとコレクションも提供しています。
[Bitbucket](http://www.bitbucket.org/)はGitやMercurialの無料のソースコードホスティングサービスです。モデルとコレクションを通してBackbone.jsが、Bitbucketの[REST API](https://api.bitbucket.org/)はもちろん、新しいコンポーネントであるインラインでのコメントのコーディングやPull Requestの許可などにおいて有用であることを証明しています。
Mustacheテンプレートを用いてサーバーとクライアントサイドのレンダリングを行いつつ、カスタマイズした[Google Closure](https://developers.google.com/closure/library/)を用いたウィジェットでBitbucketでは現存するDOMツリーを装飾したり、新しいDOMツリーを挿入するライフサイクルを実現しています。
This is Spaces!!!
if id.nil?
If you are sure that a __meaningfull__ exception is thrown on `clipboard.set("data:buggy-uri", "image")`, then ok.
It is just a weak assumption that some code will later throw a nice error message whereas we know that it is going to fail right here.
Oh never mind looks like you write about this in more details later.
why not use namespace?
> Do the promises passed always get handlers attached or does lazed wait until handlers are attached to the promise it returns
> before it does that? I think it's worth documenting (also think the latter should be the case)

Nope both `lazed` and `lazy` don't do anything until first handler is attached.
In case you're wondering ... this function doesn't get called, but I'm leaving it in here for now in the hopes that I can make the cef `signature` automatically somehow and have one argument fewer in the log calls.  If not, I'll remove this dead code.
Won't this make things like:
```
db_user=u'peter'
```
...potentially?

Maybe one safe way would be to use:
```
if isinstance(v, unicode):
    v = v.encode('utf-8', 'ignore')
v_str = repr(v)
```
I would like this too.
Change to single quotes:
<code>u'QMO Videos | QMO \u2013 quality.mozilla.org'</code>
I updated the PR message and the first commit to show the relationship of the config files as per our phone call
BlankSlate appears to be the [BlankSlate gem](https://github.com/masover/blankslate), which is under an MIT license, copyright retained by the original author.  Under the terms of the license we need to, at the very least, reproduce the license along with this inclusion.  It seems like the rest of the use we are making of it meets the terms, though.

Details of the license from the original are:

<pre>Copyright 2011 Jim Weirich (jim@weirichhouse.org)

Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:

The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.</pre>
Both of these used the signal activated() before. Was this change intended?
No reason, just cruft from an old test
Please make sure spacing after blocks is consistent--some have newlines after after them, some don't.
edit distance of 1 from IntShardWriter :) Consider renaming this to IntMultipleShardWriter
space before 1
ussing assertEquals($expected, $validator->isValid($color)) make the data provider reusable by other tests
Using typehinting this can be removed
I think that you can use $uri here and avoid use two vars
Yes this will be added to our code base.
I'm thinking you should check here to make sure we're not trying to create an index that already exists.  Since we're possibly running index creation outside a transaction, it's best to be extra careful.
-> `<input class="edit" value="{{todo.content}}"`
`~2.1.2` on all
safer way to escape html: `return new Option('<a></a>').innerHTML;`
Not needed, included in ie.js. See template.
-> `return this.$.content.trim().length;`
Agreed; is now part of the approach for the allowance of both tag and type
Actually the problem with preg_* is a bit more complex. The errors might or might not produce an error message (severity of E_*), but if it doesn't there still might be a runtime error detectable by preg_last_error. You might want to look at [this implementation](https://github.com/nette/nette/blob/891714b8fc6c562f2a6853977ebea0d37bccc011/Nette/Utils/Strings.php#L477).
Wrong ternary construction:

```php
$tableAlias = isset($this->class->fieldMappings[$fieldName]['inherited'])
    ? $this->getSQLTableAlias($this->class->fieldMappings[$fieldName]['inherited'])
    : $baseTableAlias;
```
this line should be removed again, we do not want to force a decision on the user of the lib
Bugger. I was quite proud of that sort line :-)
Will have to take a different approach.
The app still works with this filter commented out, does rails automatically assign this variable for you in controllers?
Frak...
I'm not sure I see the big picture, but I think that the feed generator needs both properties:

* feed_domain to generate the feed file url
* siteurl to generate the links to the posts

And these 2 properties could be different. So both need to be set for feeds to be generated correctly.

So no, I **think** that this warning is required.

We could move the check from generators.py to settings.py though to be more consistent.
Afaict, it's the introduction of the conditional statement for checking the option that adds this.  I'll adjust the whitespace control and it should take this out.
And here - > a
Why do we need this field in the database?
I guess the question fo rme is what do we need on every page? Because I don't think we are even using have of these boot strap libraries right now so maybe we should comment them out till that day comes.
The HTML isn't valid without the ul, so it really does need to be in there -- older versions of IE are especially prone to choking on missing tags, and it can also cause problems for screen readers that rely on the DOM. If adding the correct markup causes styling issues, CSS is the way to fix it.
I'll be accepting this pull reqeust, but it would be nice to have readable names. e.g. validate_email() or input.subscription_email
remember to change this to a callable function that makes it something like `participants/<thisyear>/<thismonth>/<thisday>/`
Is there anything more descriptive than "title" you could put here?
of course - that was supposed to be a placeholder. fixed.
What happens here with dvd's? stream source is not demux then if i remember correctly
With this change also in the podfile the platform can be defined as

``` ruby
platform :ios, '5.0'
```
Nit: extra trailing space after the 1. Trying to stick to http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml
String should be localized.
We should reference the latest spec:

RFC 6350

```
*  N:          Section 6.2.2
*  ADR:        Section 6.3.1
*  ORG:        Section: 6.6.4
*  CATEGORIES: Section 6.7.1
```
This should be in the library, or at least in the App_start\swaggerNet.cs file, not left up to App global.asax. Eg there should never have to be instructions like "install via nuget, then go add these lines to global.asax.."
I think being explcit here is probably safer for now. Who knows what will happen in 12.10 when it comes out? Ubuntu devs appear to be rather capricious in how they decide what process supervision they use.
The problem would still persist because how would you handle a build which has been produced at '00:00:00'? You wouldn't see it as given by build id and fetch a possible later build of the same day. Also the time is present in the date already, so I don't see a reason why a time argument would make more sense. We really have to know if a build_id has been specified.

Something we could do is to make the date argument optional and whether hand-over the date or the build_id to the method. One of both would be necessary to create the necessary date. How does that sound?
QString is not a POD. you shouldn't be using it as a static due to static initialization order being undefined - you could use a char*, or a define instead
As discussed on the mailing list, please use the largest image.  And please check that it is the largest, rather than making assumptions about element ordering.
This can just be 200 I think.
That makes sense, implementation on the way.
Can we add something in that checks if the current user is an admin?
should be callback.tenant
`readFile` doesn't need to pass back lib. Instead, the caller should pass in an anonymous function:

```javascript
readFile(lib, function(err, data) {
  callback(err, data, lib);
});
```
Actually, I prefer to be explicit. I'll use a named argument here.
I agree that express is not at fault. I think this is more of an issue regarding api usability/flexibility versus blame or a particular absolute "correct" way to do it. The */* is easy to do without any framework support. My argument came from the fact that browsers will add the */* as a fallback but often have the real mime types first.

If `req.accepts('html')` return true for `application/json; */*` then it makes it harder to write code that will handle the various cases. However, if it returns false unless the html mime type is present, then I find the resulting code clearer

```javascript
if (req.accepts('html') {
    // case when text/html is present
}
else if (req.accepts('json')) {
    // case when application/json is present
}
else {
    // default case for */*
}
```

The above doesn't work when */* causes everything to return true.
This didn't work just with user.profile ... I got a related manager of some sort back and it didn't have a geom attribute.
I had wanted to convert everything to CodeIgniter::instance(), but then discovered that our unit test framework usually provides an empty class as the root object. For isolation, we don't want all the other core classes to be dependent upon the CodeIgniter class for testing. So, the easiest solution I saw was to use the convenience function which has an override in the unit test mockups, returning that CI_TestCase member instead of a real CodeIgniter object.

Since all of the unit tests run in a single PHP instance, we can't redefine the actual CodeIgniter class (or else we couldn't test the real one), so I didn't see a way to change the behavior of instance() in that context. If you have any suggestions for a better workaround, I'd love to hear it. If I had my way, get_instance() and most of the functions in Common.php would disappear in favor of direct methods. Unfortunately, I haven't found the magic bullet to make that work across the board, and I'm a bit concerned that taking away familiar functions won't fly with the Ellis folks or some of the community (esp. not without deprecating first).

So, I thought since it was important to use the helper function at least in the core, I should add comments about why so others don't break that setup doing what I had wanted to do in the first place.
But since they both have accessor methods one could say that whoever accesses the property directly is to blame?
Тогда такой вопрос: чем будет отличаться выделение памяти int[percent] от вашей реализации?
Не проще сделать NSString, с содержимым "ATGC", потом просто по индексу брать нужный элемент. Выглядит проще и меньше кода писать, а работает точно также.
static NSString *nucleotides[4] = {@"A",@"T",@"G",@"C"};

ну вот это будет плохо, так как не доступно в категории mutator, только если через дефайн делать.
This code creates a bunch of objects, only one that gets used. The rest get dropped into the void.  Only make objects you need.
Actually, this field was used incorrectly.  It stores the factory account id (an attr returned by factory) and was overwritten when the associations were set.  This means we require the host application to create the Provider Account class and association.  (As it is currently in the test/dummy app)

I know we spoke about allowing the user to simply set the class (like we do for user) but conductor already had implemented it in the same way as test/dummy so decided to hold off on this till next release).
I found this necessary to get another bit of javascript to fire and insert the new thumbnail into a preview div.
It would only be "forcing" it in places where this scheduler is used, which I think is appropriate. It's weirder to me that you have to be _already_ on this scheduler in order for blocks on it _not_ to execute recursively.
log.Printf("server: listening on %q", service)
The message should rather be about manager users here, I guess. But manager users shouldn’t be able to remove editor groups in the first place (see also my general comment).
We should set t0 as well
It might be worthwhile to have this as an option on init, but I would not like it as the only option. For me, sometimes I analyze the same data in multiple ways, so the initialization would become quite complex. More importantly, there would be no way to equalize trial counts at the sub-condition level (e.g., equalize trial counts in AudL, AudR, VisL, and VisR) before combining conditions to avoid biases in cases where they could pop up (e.g., if you had 2x as many AudL trials as AudR trials by chance, subject response error, rejected epochs, etc.).

To me it is less clear to have the things being collapsed in the same argument as the things they are being turned into, but I have no problems with it being around if others want it. If it's going in the initialization code, then I think it makes sense to have a method in the Epochs instance itself for doing the equivalent operation after initialization, though...
... Actually the way it is handled is unambigous. But you are right, we want to correlate things :)
time_viewer : bool	
    Display time viewer GUI.
The documentation should be clearer and indicates what the service really does. It should say that it returns temperature and sky info for a given location.
LOG_ERR() macro
To make the test cover all scenarios, can you please add in another ConceptDescription with its description set to a white space character?
Boolean getPrior...
terminology: maybe wrap these in quotes?  "backend" or "backend server".
Again, indentation issue here.
-1 litmus should not depend on nexus
Done. Thanks ;)
What about putting `params[:.....]` inside backticks: ``
Thank you for reviewing this. I've added tests to test/geometry_test.rb and fixed Geometry.from_file so that it doesn't parse orientation when auto_orient is set to false.
`parameters` is not used at all...
assert_equal ^^^
While it's maybe a little of a faff in other places, doing the splat thing would make this much more obvious:

```ruby
@major += 1
@minor = 0
@point = 0
```
You're correct that the `:allow_nil` handling can be removed from the subset validation helper as it is handled by `EachValidator`. However, the handling for `:allow_blank` is needed in order for the following test case to pass:

```Person.validates_subset_of(:nicknames, :in => nicknames, :allow_blank => false)
assert Person.new(:nicknames => []).invalid?
```

I've updated the pull request with the `:allow_nil` handling removed.
I'm using repr because, originally, SymPyDeprecationWarning would use repr on its argument as well. I'm not sure I've seen this used anywhere across SymPy, but I decided to replicate the old behaviour anyway.
я пока не буду ничего делать по NSM. Сейчас не стоит на него, а переделывать и продумывать там по синхронизации не мало придется.
Not a big deal, but this function should probably be named "get-os", since the "system" is implied by the namespace.
' has_key()'  is bound for deprecation, one should rather use ' in'
a delimiter is also a character in a string, and a string does not need a "delimiter".
i don't like the title.
change update to success
Agree, update is in the way
Why would the projected vector be sparse?  if we saved the top 300 singular values, the resulting vector would have only 300 dimensions and they should all be dense, as they are in V^T, so this sparsification step isn't needed.
Can this be None? In some other artists it can, but perhaps not here...
Whenever a new client comes on line, it needs to get a "full" over the socket to start with.  It does this by sending a "refresh" event to the server.  I agree this deserves a comment.
> Too ugly? 

There is a lot to hold on to in your head. And even then passing a ```fname='broken.'``` would result in no extension being identified.

Apart from the (admittedly necessary) use of ```is_string_like```, I have no major problem with this code block. To address the ```IndexError``` you are referring to, I would probably factor out the indexing and adding a line before ```if ext not in handlers.keys():``` to the tone of:

```
if ext.startswith('.'):
    ext = ext[1:]
```

And depending on if we actually care about users who might pass ```format=''```, I would probably drop the ```else: ext='png'``` out of the if block and do:

```
if not ext:
    ext = 'png'
```
Later on.

Of course, this *is* a backport, so I'm not really advocating a structural change for this PR. I do think, however, a test would be beneficial.
To be consistent with the rest of the code-base, I would change "axes" to "ax"
Needs resolving before merging.
What is PrestaId for?
What does this do? Just want to make sure it's intentional
add a bit of context of what this example does in descriptive language, so something like: "it buffers an intersection of a geometry and a feature".
This sort of formatting stuff gets done a little later.   I went through and tried to standardize stuff like this.
Ohhhh finally got what you meant here. Good idea. I'll do that in a separate pull request.
Catching exceptions full stop is usually a really, really bad idea. Can you add some comments around this explaining why this is appropriate here? Better yet, can you catch the specific exception that you're expecting?
minlen and maxlen have the same form - they can be factored as per quantrule or childrule above
OK, I will fix this tomorrow.
I can't see this being used anywhere in the feature - and its mildly confusing naming, since there's a tag with the same name.
Can you explain why this is necessary (via css comment), an why this only needs to apply to the class fieldgroup vs all tags?
I guess this should now be called "SilverStripe URL rewrite" or something? "SilverStripe" isn't very descriptive.
Are you sure ``array($this, 'filterByCategory')`` has the correct type as "array" is not a sub-type of "object<callback>|null"?
At this point, you'll have to have commit message.
Evtl. ID vergleichen, die sind sicher eindeutig...
Single quotes could also be used here.
Changed to using ```keyWindow``` as the ```window``` property is only available on the application delegate since iOS 5.
The view is now added as a subview of the window's first subview to allow for rotation events to be handled.
I think I'd rather have this done by a quiet_system command that switches internally.
If `show_for_class` is nil/blank, it'll leave an empty space at the end of `:class`, I think `rstrip` needs to stay.
drop the empty line please
Yes, so you should leave this to others. You see that they are complaining that they do not have anything do to. ;-)
Agreed, will do tomorrow morning.
Just: *Based on date, returns horoscope sign key.*
When developing I am using `console.log`. I was adding `alert` into commits because i saw them in other parts of the project. Will remove them in next commit.
Feel free to check it in then, because I had problems for hours trying to work out the best solve for that - so I'll be happy if it's just working now.
Will this line couse any problems? I figured out that in the SinglePlayer state mouse events won't get passed down to the GUI, but this is needed now. Otherwise we could just pass the events down to the GUI if the mouse isn't grabbed (you will see the mouse cursor). In this case the user will interact with the GUI anyway.
My bad!  And yep, made private.
Same Y coordinate and label (no groupbox), above "Action log".
Do you think we need that button at all if we do it on every startup?
I am using 0.14.1
The memory leak is here somewhere and brutal... I'm trying to track it down. Then I'll merge.
This is not safe. The query is not escaped
These need to be updated to match the names above (`solution_type` rather than `pp_solution_type`)
would you have methods like "propertyQuorum" defined at this level? (Assuming that had some meaning .. it could have when applied to load lazy relations?)
sorry, again I think I messed up... this time with identation. I made another commit and now I think the exit callback returns correctly with the right exit value. Hope I understood what you meant. Do I need to open a futher pull request for the other commit?
I would get SQLAlchemy error NonMappedInstanceError or something similar when accessing `computer.owner`. Didn't want to dig into SQLAlchemy docs at the time and this solved the problem without braking tests so here it is.
I don't see the full error, do you have the end ?
We want to pull these options out of `server_context->global_options()->file_cache_` but can't until I finish porting configuration management.  So good for now.
What guarantees that url_.url.data is large enough to hold the contents of str_url_?

For that matter, what ensures that it points to writable memory? It seems to be assigned from the const char* proxy arg in the constructor.
Yeah it's for regressors. I *think* it's right for Poisson the way I wrote it, but I need to check. Likely broken for MNLogit. I'll have a look at these.
in case if asyncInitializeExperiments did not complete. don't want stringForKey or intForKey throwing up
line #4? shouldn't it be require 'exceptional' ?
This is not a problem, many sites have like that. Or you can hide it from the header if you want. But leave the rest of the header. Or we can only have the header one and display only results bellow.
not sure when the 'don't depend on external snapshots' rule is supposed to be applied...
Are we supposed to pass in that constant or the PD service name?  I see the other calls passing in the service name.
What's a mabster?
I decided to investigate.  I ran the following program on my laptop:
```
import galsim
import numpy
import time

# 1000 x 1000 = 10^6 total tiles!  That's a lot.
ntiles = 1000

t0 = time.time()
ix0 = []
iy0 = []
for ix in range(ntiles):
  for iy in range(ntiles):
    ix0.append(ix)
    iy0.append(iy)
t1 = time.time()
iy, ix = numpy.meshgrid(numpy.arange(ntiles, dtype=int), numpy.arange(ntiles, dtype=int))
ix1 = (ix.flatten()).tolist()
iy1 = (iy.flatten()).tolist()
t2 = time.time()
ix2 = [ k / ntiles for k in range(ntiles**2) ]
iy2 = [ k % ntiles for k in range(ntiles**2) ]
t3 = time.time()
ix3 = [ ix for ix in range(ntiles) for iy in range(ntiles) ]
iy3 = [ iy for ix in range(ntiles) for iy in range(ntiles) ]
t4 = time.time()
assert ix0 == ix1
assert ix0 == ix2
assert ix0 == ix3
assert iy0 == iy1
assert iy0 == iy2
assert iy0 == iy3

print 'time for append method = ',t1-t0
print 'time for meshgrid method = ',t2-t1
print 'time for comprehension method = ',t3-t2
print 'time for double comprehension method = ',t4-t3                                                              
```
The output was:
```
time for append method =  0.36986207962
time for meshgrid method =  0.376373052597
time for comprehension method =  0.569874048233
time for double comprehension method =  0.246691942215
```
So the single comprehension line was the slowest -- after all it's doing extra calculations.  The current method and the meshgrid way are about the same.  And the double comprehension line is the fastest.  However, for all methods, the total time is negligible compared to the other stuff that GalSim is doing.  But I'll change the code in process.py to use the double comprehension, since it's not actually all that different in readability than the current code, and it is apparently a little more efficient.
Done.  I mention that Linear is "highly recommended" and give a stern warning in the doc string that other interpolants are likely to be inaccurate.
Okay, good.
This is a bad CSS class name. Give it something descriptive. `logo` seems more appropriate from the HTML
testing view diff in discussion
pschiiiit
There are several files in the "mozilla" package that has changed. It seems the you somehow inserted an extra newline for each line.
This needs to be declared as `extern(C)` since it's used as a callback.
Thanks for the tip!

All commands, both the helpers and the $db->command(), are sent to the primary member of a replicaset.
So it should be consistent enough to return that version info.

PR updated
I think Djanog will convert the `id` to an actual `contact` for you so you probably want to just call this field `contact`.
Simpler version:

```
+    def tearDown(self):
+        if self.service.restart_required:
+            self.clearRestartMessage()
+            self.fail("Test left Splunk in a state requiring a restart.")
+        
+        for appName in self.installedApps:
+            if appName in self.service.apps:
+                self.service.apps.delete(appName)
+                wait(lambda: appName not in self.service.apps)
```
You need to instantiate::

    raise NotImplementedError()
I assume ``Apach2`` is a typo and should be ``Apache2``, right?
why is there a XXX by the way? Is there anything special about this code? Does it needs to support more authentification type? A comment would be helpful
:+1: I like what you've done here. The use of ssize_t just so we could have a -1 value always seemed unfortunate to me, so have a special invalid buffer ptr seems like a nice solution to this.
> Given that I had "bad settings", this should get backed out since the comment is wrong and the code change shouldn't have any effect.

I agree. If we were to opt into caching counts, I think we'd want them to be consistent.
I still don't get this # thing.
This is getting the messages that correspond to the user.  I use it in inbox.html at line 41.  I don't think it would work the same if it was in the controller.
> Since I'm guessing homebrew has no Tiger support (or very few Tiger users), 

We never supported Tiger, at least not officially. There is/was a fork that provided Tiger support, but I don't think it ever gained self-sustaining momentum.

> this makes `snow_leopard_64?` mean `MacOS.prefer_64_bit? and MACOS_VERSION >= 10.6`, correct?

correct.
Do we really need to define ``lively.module`` if we have ``module`` in the global namespace already? It seems redundant to me since every reference to ``lively.module`` can simply be replaced with ``module``.
Cast you vanish ability, you will see a new buff, called vanish too, with a duration of 3 seconds. At the buff end, stealth must be casted.
dunno, straight copy from django.
Можешь поступить как и с утилитами - вынести `"use strict";` в IIFE
```ruby
subject.should be_national
```
В общем и целом - нехорошо, конечно. Это общий репозиторий (т.е. классами, которые я помещаю, можно пользоваться всем), поэтому получается, что в общем репозитории два класса с одинаковым содержимым. Но в случае с чатом я это оставляю на усмотрение студентов.
Удалить бы это
Если в тексте будет присутствовать ПРИВЕТ и ПривеТ, то надо вывести "ПРИВЕТ 2" или "ПриветТ 2", но не "привет 2".
Вы не могли бы пожалуйста проверить весь код хотя бы на предмет общих недоработок которые нельзя исправить за 2 минуты, иначе исправляя мелкие ошибки я могу не дойти до крупных. Спасибо.
Might be worth even more emphasis - ", so the application has a slightly different architecture".
Does that work well on RTL?
I think this package do not need to import konoha.string package. Why?
This should be done from submit_app
Thanks Zac. I liked the approach of overriding is_current_page, but if it doesn't conform to what the team usually does then I can see how it might detract from maintainability.  The change seems to work fine so I guess we'll just leave it as is.
filter.py:63:17: E201 whitespace after '['
you are changing the  implicitly_wait to 1 here but you are not setting it back
Nit: please add a space after the if statement
I'd move this below `TEMPLATE_CONTEXT_PROCESSORS` just because it keeps the templaty stuff together.
xxxのクラス階層を使っていましたが
という表現があまりしっくりこないです。
    xxxのクラスを継承するようになっていましたが
とか？
Why `-b`, is `-f` already in use?
@kuantkid - `utils.arpack` is exactly the same as `scipy.sparse.linalg.arpack` in scipy v0.10.  The reason it's in the utils is because Scipy v0.10 added some features that aren't in earlier versions, and we don't yet require scipy 0.10+.  In fact, at the bottom of the file in `utils/arpack.py` [you can see](https://github.com/scikit-learn/scikit-learn/commit/87389f5059ea0f72f2d4adfcab7bbd26f548bff1#L0L1602) that we default to the Scipy code if the version is greater than 0.10.
I don't understand what this function is doing.
Why not directly define a function ``cython.floating[:] X``?
If the overhead is more than 30% I think we should keep the previous implementation as a special case.
`hasher` is a weird name for an instance of this class. Maybe `transformer` would be a better choice.
добре, більше не буду чіпати
Can you use a different variable name? I would expect `$nightly_enabled` to be a boolean, not a string. Perhaps `$archive_name`?
This should be `if (!empty(...))` - one space missing for CS.
Removed controlEnabled_
Should be in try catch to handle exception if occured.
Q < T
This would leave a reference to a variable that has gone out of scope.
oh, ignore that
ok, I don't have a stroing objection.
The enum names could possibly be clearer.  Sort_None, Sort_Unstable, Sort_StableEarly, Sort_StableLate.  ??  Ignore if you want.
In case of abort triggered by a semaphore, useINotify will also return 0.
No, because the ReportListForm will always return a datetime even it is passed a date. So I call it a "date" because it virtually has no hour/minute/second, but it needs to be an instance of datetime. Sadly, 

<pre>>>> datetime.date(2012, 1, 1) == datetime.datetime(2012, 1, 1, 0, 0)
False</pre>
Correct.  I fixed it.
While this will likely benchmark better than reflection (don't quote me on that!), I'd still like to see a different solution to this, long-term.
the `len(range)==2` case feels more like an assert. If len(range) were 1 (e.g. there was no ".." in the string), or 3 (e.g. "1..2..3"), that should never happen, right? So maybe it'd be safer to use:

    if ".." in sub:
        left, right = sub.split("..") # throws error if there are !=2 pieces
        subCondition.append("isBetween(%s, %d, %d)" % (lvalue, int(left), int(right)))
I would check to see if the file exists and then raise if it doesn't instead of rescuing and raising
Just FYI, there's this: https://docs.djangoproject.com/en/dev/ref/models/querysets/#latest for getting the latest object. There's, afaik, no symmetric ``first`` built-in, which I always wondered about. This is why there's the get_first and get_last in the Events.
Pourquoi as-tu besoin du relative et du z-index ici?
Following the prefixing this would be `get_table_pagination`.
remove all code that is not related.
Ah - the new "nopad" class was meant to be general enough to be used anywhere, but I had left in a temporary condition. I just simplified the selector so it's simply "nopad" now.
Christian wants to see rules alphabetized within selectors.
Yeah, changes are being made as we speak.  That's not the official description.  heh.
Will be changed by tonysyu afterwards.
Do the tests pass without the `:case_sensitive` option?
no need for the return. just '@curl.body_string' is fine.
Change this to `.czml` as part of the file renames.
Surprisingly, making multiple calls to push ends up slightly faster than using push with varargs.  I assume the single-arg call is optimized better.  From a code quality perspective, I prefer the varargs version, though.
Even if the result is the same due to a google bug, standard and hybrid from a titanium standpoint are NOT the same since we request different behavior.

When you say:  "SATELLITE_TYPE == hybrid" I am not clear on exactly what you refer to.  SATELLITE_TYPE enables sat imagery on Android.
All of the samples so far have been pretty conservative and have used private names. If you think we should drop that, we should update all of the examples. I'm okay either way, as long as it's consistent.
always open the braces on the following line
Yes.  

Maybe including whitespace was a typewriter thing, like putting two spaces after a period. But now, it's a no-no.
ты имеешь в виду, переименовать? %)
ag, hehe "idden" again :)
Can you run phpcs over it? You've fixed a lot of the issues, but string $result should probably only have 1-2 spaces
A `<<` returns the modified array (so you can chain `args << a << b`) so you don't need this line.
Nitpick: Document functions using verbs instead of nouns (»Calls the postblit of the given object, if any.«)
I'd like to keep all `*TypeOf` templates undocumented. These are necessary for std.format implementation, but I'm not sure that are really useful for general users. (and, writing documentation is most difficult work in my own..)
Since the user can't know what minTemp is, would it make sense to pass tmp by reference? That way the changes in length will persist after the call to sort.
These are both used later.  Example:

        <plugin>
          <groupId>org.apache.maven.plugins</groupId>
          <artifactId>maven-enforcer-plugin</artifactId>
          <version>${ness.plugins.enforcer.version}</version>
          <executions>
yeah I was wondering about that too. I'll update it.
final for these fields?
Agreed. We should change to using mirrors in a follow up... however not
sure if that is worth it depending on the time frame when we can get true
custom elements working in dartium.  Also, keep in mind that the mirrors
solution would be significantly lower performance.  I think the ideal
solution is actually to codegen using the mirrors api but that is gated by
the bug that forces this code to go through dart2js.

On Tue, Aug 21, 2012 at 2:34 PM, John Messerly <notifications@github.com>wrote:

> In components_polyfill_boostrap.dart:
>
> > + * flag -allow-file-access-from-files.
> > + */
> > +
> > +#library('webcomponents_bootstrap');
> > +
> > +#import('dart:html');
> > +
> > +// TODO(jacobr): this is a complete hack.  Figure out the correct relative URL or
> > +// embed the polyfill script directly in this script.
> > +//String polyfilLibraryLocation = "../../../../dart-web-components/webcomponents.dart";
> > +
> > +String polyfilLibraryLocation = "http://127.0.0.1:3030/Users/jacobr/src/dart-web-components/webcomponents.dart";
> > +
> > +final int REQUEST_DONE = 4;
> > +
> > +// TODO(jacobr): with mirror support this list doesn't need to be hard coded.
>
> agree. maybe we can change it to use mirrors in a follow up?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dart-lang/dart-web-components/pull/16/files#r1429795>.
>
>
So, check the version, and then you can always use this easyblock for building GHC, you don't have to care.

```
if LooseVersion(self.version) <= LooseVersion("7.0"):
    pass
else:
    super(EB_GHC, self).build_step(verbose=verbose)
```
relying on that short circuit.
`both 'key' and 'pattern' must be set`の方がよさそうですね。
Thanks for localizing, it's really cool that you took it into account right from the start.
Sorry, should not have been part of the commit. But the WidgetAreaEditor was throwing errors for me - does that class exist in SS3?
Ah okay, hadn't seen that.
Ah yes. So I borrowed the triangular mesh from [this triplot example](http://matplotlib.sourceforge.net/mpl_examples/pylab_examples/triplot_demo.py). The idea was to create a set of angles and a set of radii; map them to x, y coordinates and then compute z = -xy. I could clean this up a lot to make it less confusing and add some comments.
Do we need both of these here?
Extra semicolons here and below
Same question as in `fcntl.d`.
Should be unnecessary – as far as I recall, all x86_64 CPUs out there implement SSE2.
One question  - will this attribute change affect 2.1.0 stored messages?

I ran a test and a message I stored with 2.1.0 is retrieved ok with 2.1.1., but I just want to confirm that there are no other side-effects.
Not the way i would describe it, it actually makes the optimized correlation meaningless since by trying to preserve the backward compatibility optimization can only be considered optimization IF caching consumers is enabled. Without it its as if you never set optimization to true.
Now when Susy is used instead of 960 Grid System, this should be changed to `.clearfix h2` (or probably `[role=main] h2` or `section h2`?)
Y U NO USE PROD?
the `?` there will do a non-greedy whitespace match, which seems undesirable/unnecessary.
I can't use django templates in a general JS library. This is just the default, user should be able to set the url in the constructor of this (Datastream) class. But we have to decide first wether this will be a jQuery plugin or a more general JS API.
I know how write jQuery plugins, but there are some other functions in the datastream namespace that should not be packed as an extension. Do we want to break out our API?
Oh wait, this will explode in browsers without `Function#bind`. If you want, I can throw in a quick shim.
corrections are applied to all METs. might need to exclude METs used for systematics - not sure if they need to be corrected. also, GenMET of course doesn't need to be corrected
As for the `@synopsis` are you talking about line 62, the print statement? Print creates a list context for its arguments, doesn't it? (http://szabgab.com/scalar-and-list-context-in-perl.html) It worked the way I wanted it to.
And at line 57, I do mean `@synopsis` in scalar context (I need the length of the array).
Пжл. используй перенос строки перед скобками методов!
Then it really feels like this should just be additional options for ```PaypalExpressGateway``` as opposed to its own class; can you refactor the PR to handle it that way?
this is a good start, but perhaps put a TODO in there that we want to reload the table data without having to reload the entire page.
While I agree I am not sure how to easily define a map in a properties 
file. Xml would be easy enough to write a map with, but then a bit heavy 
weight on the parsing side.

Anyone know how to sanely write/read a map in a properties file?

On 21/07/12 18:58, Martijn Verburg wrote:
>> +import java.util.Collection;
>> +import java.util.HashMap;
>> +import java.util.Map;
>> +import java.util.Map.Entry;
>> +
>> +import javax.annotation.Nullable;
>> +
>> +import com.google.common.base.Optional;
>> +import com.google.common.base.Predicate;
>> +import com.google.common.collect.Collections2;
>> +import com.google.common.collect.ImmutableMap;
>> +import com.google.common.collect.Iterables;
>> +
>> +public class PackagingInstructions {
>> +
>> +    public static final ImmutableMap<String, Collection<String>> PACKAGING_DEFINITIONS =
> An enhancement would be if this could be passed in via a properties file
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/AdoptOpenJDK/PatchReviewUtilities/pull/15/files#r1211014


-- 
John Oliver

InsightfulLogic
http://www.insightfullogic.com
"the the" -> "the"
Please don't put IDE specific things in here - they belong in your `~/.gitignore` so that any project you work with using NetBeans doesn't need this.
Comment here is kinda broken...  This is more of a multi-line comment, not multiple distinct comments.
a brief comment would be good here
Currently the CLI does not provide a way to delete the Zumo service and the SQL DB without also deleting the SQL Server (so you can delete just the Zumo service, or Zumo service, DB, and SQL server). This commented out piece was an early attempt at deleting the DB alone, but that effort run into rocks (SQL management APIs in APIs make it rather hard to delete just the DB, it will require more work). 

I will yank out the comment.
nitpicking: what’s this `class="negative"` for? I’ve seen it in another pull request but didn’t really understand what it’s about…
I don't like having the user check in the model like this - in fact does it even work? Isn't the `@user` member variable on the controller object and therefore not visible here? I suspect you will need to arrange for a `show_redacted` flag to be passed in from the controller to the `to_xml_node` method to make this work...
jamesladd, question for you
Of course.  A case of the mondays on my part (and spending too much time in DOM land with HTML...)  retracted :)
This should probably just use `Activity.runOnUiThread` instead of our helper, which uses an async task and further delays execution
also please use `add_query_arg()`
What if this request fails? It does not deal with error!
whitespace between conditional statements
Yea, that's fair. I'll change the `WARNING` to be an `ERROR` since they really should be adding the necessary webplatform files prior to calling jake.
guess this one should list Nacho .. i will leave it to @nacmartin to add his information and merge the PR .. and finally register the bundle on packagist.org
`(not (teen? age))` would do the same