labofsahil/github-event-dataset-2012 huggingface dataset:
# Homework 3

| **Part**  | **Points** |
|-----------|------------|
| base      |  1 |
| advanced  |  0 |
| if statements | 0.25 |
| **Total** |  1.25 |

Well done on this homework.  I really have nothing much to say about it.  Since you seem to have strings more or less down you may want to look at string formatting.  You can find more information formating [here](http://docs.python.org/library/string.html#formatstrings).
thx
P.S
pls view issues. so many crashs. Core is unstable
This file should be in .gitignore, but it's propably lost in merging again.
In fact, it's not needed to copy the APN config at all in the device Makefile.
Just do the following in cyanogen_chacha.mk:

$(call inherit-product, vendor/cyanogen/products/gsm.mk)
(dance)
I think it can go either way. The Nexus devices use abbreviated names (GN, GN-CDMA, NS, NS4G) for instance.
This never gets called
Дима, ты забыл файл lib_gdoc добавить. И теста я не вижу.
We're not manifesting new devices. the build system pulls them automatically when you attempt a build
I think you meant Vending.apk ?
This shouldn't need the Google APIs to compile. We can just use android-8 here instead if you want to increase the API level.
Don't know :D I've didn't tried yet; i was a little busy. But tomorrow i'll try.
Why did you inflate the keylod from 10 to 20?  I never understood why it was 10 instead of 1 in the first place.
What's that supposed to mean? Final functions aren't virtual unless they override something!
Feel free to rename b2a to something more descriptive
Removing qt as well as the array design accession and name -- these aren't used anywhere other than process.atlas.nc and we are removing that. The only one from this list to keep is accnum since it's used in log further down.
Looks like [`_getScrollDims()`](https://github.com/derek/yui3/blob/eec0e8e8611236799cead0da4eea5596b60dfc76/src/scrollview/js/scrollview-base.js#L330) cases side-effects, that seems like a really bad idea… maybe I'm missing something?
Is deps[0] correct here? Not a typo? There's something special about the first dep? Tough to tell without the context, but thought it's worth pointing out.
Nah, `in` is much faster here, and we don't need the `hasOwnProperty()` check.
I didnt see any other JPA annotations on the other fields. They are most likely created and mapped all by default, save the evaulationOrder prop that defines some additional behavior (not nullable, etc).
If the element you're looking for has another class you can reference it by, it would be better to use closest() here (that way this is less likely to break if the DOM structure changes).
Awesomest case of typo I've seen so far :smiley_cat:
Should we hardcode a nightly version?
with `MultiNodeClusterSpec`, if you like
missing

+/**
 	 3	
+ * Copyright (C) 2009-2012 Typesafe Inc. <http://www.typesafe.com>
 	 4	
+ */
None of the methods, nor the class have any doc-strings. Would be good to add that.
Curious why you changed this. PEP-8 says to not do this:

"Code in the core Python distribution should always use the ASCII or Latin-1 encoding (a.k.a. ISO-8859-1). For Python 3.0 and beyond, UTF-8 is preferred over Latin-1, see PEP 3120."

Is there a reason we have to have it, like mod_wsgi or something?
could use fullfillCnt instead of a range (if fullfillCnt starts at 0)
OK. It could be a good idea to also call a new SupportedFormats function in CWinShader, to reduce the risk of problems later.
It's not a big deal and could be added later.
Yeah but it only ever translated from ftpx:// to ftp://, which, as you know, only ever existed on Xbox for mplayer. Currently TranslateProtocol() only does translation for http & https protocols (just check the function). So I'm sure it doesn't change behavior. It just made this function more in line (and clear) with the functions surrounding it.
Don't bother with `sys`, just pass `None` to `main()`. `OptionParser` uses `sys.argv` if `args is None`.
These two still relevant?
Should there be a `.hasOwnProperty()` call here?
Should probably be `@racket[_t]`
2012/8/7 Gedare <notifications@github.com>

> In cpukit/posix/src/keysetspecific.c:
>
> >    the_key = _POSIX_Keys_Get( key, &location );
> >    switch ( location ) {
> >
> >      case OBJECTS_LOCAL:
> > -      api   = _Objects_Get_API( _Thread_Executing->Object.id );
> > -      index = _Objects_Get_index( _Thread_Executing->Object.id );
> > -      the_key->Values[ api ][ index ] = (void *) value;
> > +      rb_node = _Workspace_Allocate( sizeof( POSIX_Keys_Rbtree_node ) );
>
> Is this allocation accounted for in estimating the size of the workspace?
> Is the number of these allocations bounded, e.g. by CONFIGURE_POSIX_KEYS?
> Or does it depend on more complicated factors?
>
I think it is not accounted. Because as the
_POSIX_Keys_Manager_initialization() show:

void _POSIX_Keys_Manager_initialization(void)
{
  _Objects_Initialize_information(
    &_POSIX_Keys_Information,   /* object information table */
    OBJECTS_POSIX_API,          /* object API */
    OBJECTS_POSIX_KEYS,         /* object class */
    Configuration_POSIX_API.maximum_keys,
                                /* maximum objects of this class */
    sizeof( POSIX_Keys_Control ),
                                /* size of this object's control block */
    true,                       /* true if names for this object are
strings */
    _POSIX_PATH_MAX             /* maximum length of each object's name */
#if defined(RTEMS_MULTIPROCESSING)
    ,
    false,                      /* true if this is a global object class */
    NULL                        /* Proxy extraction support callout */
#endif
  );

  _RBTree_Initialize_empty(
    &_POSIX_Keys_Rbtree,     /* the rbtree control block */
    _POSIX_Keys_Rbtree_compare_function,
                            /* the rbtree compare function */
    true                    /* true if each rbtree node is unique */
  );
}

Only the POSIX_Keys_Control's size is accountted.

>  —
> Reply to this email directly or view it on GitHub<https://github.com/RTEMS/rtems/pull/3/files#r1321882>.
>
>



-- 
Best wishes!
Zhongwei Yao
This is not BC
Should clean this up to ident = UnQual . Ident . concat . intersperse "_" $ map (\(PVar (Ident nm)) -> nm) vars
Good call-- missed that.
I suppose I still stand with my earlier opinion that these might be quite handy and simple to use, but better suited for a subclass.
Close, but [no cigar](http://cl.ly/image/2u1L3c1X0J2B).
But that would mean that even a `TUITableView` wouldn't initialize this
`isAtleastLion`. Would you mind explaining the logic? I'm having a hard
time grasping why I'd need to do this.
Added the block-based dispatch singleton!
I removed this segment and added an explicit synthesize.
I'm using the keypress event of Ctrl-c in stdin direcly. I agree that readline is the alternative.
Understood. I suggest that you leave out binary though (either that or add a big fat deprecation warning - but preferably remove it altogether).
On second thought, it's probably better to extend UnsatisfiedLinkError here.
put spaces!
I don't think we need to add this sort of disclaimer to public JavaDoc.  Instead, could we put it as a non-Javadoc comment such as `//` in method implementation?  Also, if you borrowed the code from SLF4J, we should update our NOTICE.txt.
I suggest "This macro calls memset, so obj must be contiguous"/
I bet it's the lack of this code that's causing the import problem on Py3.
Do we support // -style comments in C in NumPy.  Last I knew we did not.
Please add spaces around the ternary operator.
As far as I'm aware the %a is supposed to be the total number of days in the interval. I think you're right that if the interval is 2 days then %a could be set to 2. However, with other intervals, such as 1 month, you would not be able to set the %a unless the interval was relative to todays date.

Additionally, the example in the createfromdatestring docs say that instantiating from the constructor or createfromdatestring static method should create the same results. In bug 49778 Derick changed the the constructor so that %a would be (unknown). My patch makes the results of createfromdatestring match the constructor results.
This is a global `Hash` instance that is going to end up being modified by the incoming requests concurrently, this is not thread safe (because `Hash` is no thread safe).

You need to replace this by `ThreadSafe::Cache` like this:

```ruby
require 'thread_safe'

module ActionView
  class DependencyTracker
    @trackers = ThreadSafe::Cache.new
```
No worries! :-D
I think i'd rather stick with the same api for both add/remove references/belongs_to, than trying to figure out what's going on by myself - and having to add a new deprecation. My 2 cents ;)
Changing a `val` to `def` isn't source compatible (a client of the API might rely on the stability). I'm not sure how we should treat that for `scala-reflect`.
I think the argument symbol should be owned by the function's symbol.
Why sorting here?
Ah, forgot about that, thanks. Added @Ignore.
It would be nice to use consistent notation; in `xy` there is not space but it means multiply whereas in `x f_1` the space means multiply.
The docstring should make it clear at this is a numerical function, at least until we an get symbolic versions.
Well, there is something related to this test that is not consistent between real and imaginary. Here:
```

In [1]: ask(Q.real(x**Rational(3,4)), Q.positive(x))
Out[1]: True

In [2]: ask(Q.real(x**Rational(3,4)), Q.negative(x))
Out[2]: False

In [3]: ask(Q.real(x**Rational(3,4)), Q.real(x))
Out[3]: True

In [4]: ask(Q.imaginary(x**Rational(3,4)), Q.positive(x))
Out[4]: False

In [5]: ask(Q.imaginary(x**Rational(3,4)), Q.negative(x))

In [6]: ask(Q.imaginary(x**Rational(3,4)), Q.real(x))
```
Output number 3 is wrong, that is related to the not negative rather than positive. But also output 5 should be True, where the corresponding case is correctly handled when asking if it's real.
Point at the end is  better.
How about making it shorter like

For backwards compatibility a boolean value can be passed:
-  'false' for 'OR'
-  'true' for 'AND'
I think it is not. Password is clear. Hash opens the question: "Hash of what?"
remove new lines after first curly and second curly. :)
On Wed, May 23, 2012 at 9:13 AM, Robert Martone
<reply@reply.github.com>
wrote:
>> @@ -0,0 +1,433 @@
>> +/**
>> + * Tooltip class
>> + * @class Tip2
>> + * @constructor
>> + * @extends Button
>> + * @require Container
>> + * @version 0.0.1
>> + */
>> +
>> +
>> +var Button = require( '/scripts/lu-controls/Button' ),
>> +  //Container = require( '/scripts/lu-controls/Container' ),
>> +  Tip2;
>> +
>> +Tip2 = Button.extend( function (Button){
>
> As long as the tip is handling the hover/click logic - this can be Abstract.
>

Not Button?


-- 
jimg at yojimg dot net
Why do you need to use tab2list? Why not foldl or foldr?
Rename `forChildAndParent` to something that reflects the new semantics better.
Ow, I added them to quickly test something on my local server, forgot to remove them from the .gitignore.
Dereferencing a function pointer is unnecessary in C (since all function names ultimately degrade into pointers). The following is semantically equivalent:

```objc
__block BOOL isKey = originalIsKeyWindow(self, _cmd);
```
Sure, I'll do that soon
This is superfluous now, right?
This is just for my edification, but is it the standard in our documentation to refer to cursors as cursor objects?
should we add:
```
if not self.defer_rendering:
    return False
```
?
Use `item` object to avoid the speed penalty of jquery selectors.
What's this comment for?
copypasta :p
Comments on their own lines here too please.
This entire file needs to be deleted.
What is the usual shutdown time? Take that and multiply it by 3 to start. If that comes out to more than 20 seconds, limit to 20 seconds. Or check php time limit and use at most half that.
Why is it even possible that name and directory differ? Is there any advantage to that? Can't we just make it a lot simpler by requiring they always be the same?
It is used for the reference return, but the reference return should not be needed with php 5.
You don't need the loop, just remove them as a group.
I would probably move the require further up.
Let's use full class names for the methods, so we don't need to hardcode any class prefix here.
@ddispaltro said we should support everything. I'm totally wine just supporting int64, string, gauge and double here.
fixed in e1810e5
use loader-app-resolved{langPath}, which behaves better, and in any case u are already using loader-yui3-resolved.

a quick note on this:

if you plan to run functional tests, it will not work because yui-test is not part of the resolved meta ;) for that u have to use "/yahoo.libs.yui/loader-yui3/loader-yui3-min.js" instead of "loader-yui3-resolved{langPath}"
Это что за жесть? http://api.jquery.com/toggleClass/ - добавляй/убирай для элемента класс hidden. show не нужен
Perhaps use `as` instead? Would that make sense here?
TODO should be linked to a bug #. Or else commented code should be removed.
Ah, I see, these are the titles, not the values, fine.
Do I have to just rename this file?
We don't need any eclipse-specific files.
In general I'd avoid type checking, but I don't see a way to avoid it if you want to support both cubes and numpy arrays. Perhaps @bblay or @rhattersley might offer an opinion.
I don't think this does the change justice. Reading this I don't get the feeling that Cartopy is aiming to give me maps that Just Work(tm).
```
var viewCenter = {
    'x': map.viewBox[0] + map.viewBox[2] / 2,
    'y': map.viewBox[1] + map.viewBox[3] / 2
};
```
注意格式
どうせインストールの途中でhtml以下の権限チェックしてたりするから、そこにinstallディレクトリの権限チェックも追加するとか?
http://www.python.org/dev/peps/pep-0257/
spurious indentation - see below
I wanted to encapsulate the throwing of this error so that I didn't have to keep writing it. But yes, it either does nothing or throws an error.
I afraid `during a same` is incorrect. I think that `during the same` is the correct one.
I'm almost sure the "smart" is not needed here. Just use force_text. However, do we know what type of encoding is expected here? If it is UTF-8 encoded string, we should use force_bytes instead.
We need to parse it with increased level and return level back.
Not sure what that would add. This section is pretty small – multiple headings in such a short space would just look weird.
I know that you are following tds2024b here, but maybe is better to call it `force_trigger` to make it consistent with the rest of Lantz (we should change tds2024b too!)
A very good point. Maybe there should be a way to call send, recv, query with a different timeout ...
Should this be a static constant?
I'm not sure of anything. I'm just asking questions.
this applies to other variables as well, right? I don't directly reference any of them, so better keep them private?
I don't think we want both of text and varchar types
I was just lazy because people will specify it without quotes in command line and without quotes you cannot contain spaces, but it seems nice.
To be clear, I didn't mean that the current template worked on mobile (I haven't tested it). I mean that it should be easy to do a single template for both.
Bad indentation here, too.  I wonder if this is some sort of tabs-vs-spaces problem?
to_param is an alias for to_s if I'm not mistaken.  Let's just use to_s.
`--python` and `--qt` does imply `--pyqt`?

How do I specify that I only want python and pyside bindings then? (I am asking because right now pyqt does not build on xcode-only but pyside is fine)
You need to tell the build system where to install...
Don't use prdownloads (`brew audit` this formula).
Don't hardcode the path like this, just use `#{bin}/autopano-sift-c`

Also, it would be nice if the test was constructed such that it didn't need to be updated each time the formula is updated.
hrm... what about `var/mailman`? I don't have anything else that has created one... but it has a helper method and share doesn't... 

alternatively, want me to add a share helper method to formula.rb?
1-var
I actually struggled with that decision a little bit. I ended up making it an additional helper since the next event would be a common use case within this application's domain.

I'm fine with it being a method on the model though.
Ok.  Hopefully I've improved the text.
we usually put requires above the class and its associated comments. Please have a close look to other files structure so that we get an uniform look and feel for the code
Okay. Almost seemed the Celery docs suggested all "args" needed to be passed to super __init__.
I ran the test and seems to pass with your changes, so I'll merge it. Thanks.
Why is this necessary if it has an empty implementation?
same duplicate
1. It'd be cleaner to check `sel.end.line` against `editor.totalLines()` here.  (Also, note: to pass JSLint, use `===` instead of `==` for comparisons).
2. Since that doesn't use `doc`, you could leave its var declaration down below.
3. The use of ternary operator feels a little weird here since it's a no-op on one branch.  I think it'd read better if this was just a standard if statement.
Note that this is no longer necessary because whenever we retrieve the list of recent projects, we canonicalize each path in the list, so by the time it gets to this function it's already been canonicalized. This should work even when upgrading from a previous version that didn't do this canonicalization before saving out the project list.
I was thinking the same way as you, but in my testing without this code we're unable to close the inline color editor with Ctrl/Cmd-E. So the user has to use Esc key to dismiss it. I know we're talking about not to use Cmd-E to toggle anymore. So do you still think I should go ahead and remove this?
Also, although we don't set other font size types like percentages, it's conceivable (though probably unlikely) that someone might set that in a theme. We might want to detect those cases and just bail rather than doing something nonsensical. (i.e., explicitly test that the last two characters are either "em" or "px", and if neither, then bail.)
It would probably be better to break the highlighting logic in CSSDocument out into an explicitly named function (e.g. `updateHighlight()`) and have `onCursorActivity()` call that, rather than making it so other bits of code need to know that `onCursorActivity()` has the side effect of updating highlighting. But we can do that cleanup later.
One nice thing about using JSON as the sole API for adding menu items is that it makes it easy to migrate to externalized configuration files later.
I just thought I'd mention it to make sure you considered it. It's ok as is and we can listen for feedback.
If you scroll horizontally and then change the font size, the same row stays at the top, but the same column doesn't stay on the left.

This is what I was thinking:

        if (fsUnits === "px") {
            var scrollPos = editor.getScrollPos();
            var scrollDeltaX = Math.round(scrollPos.x / lhOld);
            var scrollDeltaY = Math.round(scrollPos.y / lhOld);
            editor.setScrollPos(scrollPos.x + (scrollDeltaX * direction), scrollPos.y + (scrollDeltaY * direction));
        }
 
// Note that "(fsOld + (lhOld - fsOld))" evaluates to "lhOld".
It seems a bit fragile that this is depending in part on menus and menu items that were added by the previous testcase.  I think it's ok to have all the tests share one window (meaning they're sharing the overall Menus/Commands state), but it makes me a bit worried to have the individual tests even more coupled...
Can remove the `return`
You may as well remove this entire loop now.
Current version of Sentry recommends slugs. We haven't made the change everywhere yet, but it's important that it's recognized as a string and not an integer
Should import the class first, then invoke simply Utils.escapeIllegalCharacterInQuery(getTitle()).
"#{trip.start_location.name} " should be trip.start_location_name -- you don't need the quotes or pound...
Наверное, лучше заменить на force_unicode.
Constant string! ;-)
https://docs.djangoproject.com/en/dev/ref/class-based-views/#django.views.generic.edit.FormMixin.get_context_data
oops missed that last time
Can you use `toggleSaveButton( true );` instead?
Not longer need the extra brackets, just one around _end - _start.
这个文档和 Docs/README.md 有啥区别？是不是可以去除了
this should be in a begin/ensure block, even though it's usefulness is debatable.
It never actually makes the request. Categorically, urllib3's unit tests don't make any external requests, even if it's httplib.org. :) We'd like to be able to run our tests offline.
Do we add reason?
I wasn't totally clear on the distinction. Since it's being restored pre-reload, though, it shouldn't *technically* matter, right? :)

(Happy to do either though)
It seems pretty wrong to tag this as a patch release. Pretty sure I'd make it at least a minor version bump (probably fair to just do that since we haven't released a 1.0 yet - if we had, I'd say we need to bump the major version)
Surely that's a typo, and meant to be 'not uncommon'. Which sounds fine to me - but perhaps it's more common to say this in British English.
Load Q if it's installed, if not, ignore
There's more info on the commit message but the summary is here: http://stackoverflow.com/questions/766809/whats-the-difference-between-utf8-general-ci-and-utf8-unicode-ci
yeah - I removed that as well...
Doesn't have to be explicitly set to undefined as that is the natural behavior.
@lzap the original Foreman admin would have to be renamed to something else not to colide with Katello admin. But renaming could broke Foreman, I would rather not to do that. 

Foreman is not creating its admin in `rake db:seed` or `rake foreman::load_default_data`, Foreman admin is created on first request when the admin is missing. This is actually broken in foreman/devel so i'll fix it first. The admin has to be present in Foreman before `rake db::seed` is executed to be able to call Foreman API. So I think Katello admin has to be manually mapped to Foreman admin in `rake db::seed`. Foreman user orchestration will work fine after this first step.

There is an error recovery code in current user orchestration implementation, which enables Katello to heal when Foreman user is already there or missing. I would remove that code. If an error like this happens it means that there is a DB inconsistency (katello has a private Foreman instance) and I would rather for Katello to raise error than silently heal. @lzap What is you opinion about this?
This still bugs me but maybe it works out just fine.
Paul, I started testing union across distributed tables and have a few questions I want  to clarify with you. So far PlanAssembler.verifyTablePartition method is called once per each select withing a union and once for the whole union statement. The list of tables associated with the ParcedUnionStatement is a superposition of all tables from individual selects. The reason for the latter check is that even individual statements may satisfy the criteria of no  more than one independent partitioned tables involved but the whole union may not. That would result in more than two plan fragments. Example would be the stament
select A from T1 union select B from T2;
where T1 and T2 are both partitioned gets rejected. Does it sound reasonable to you? Any suggestions to handle it differently?

There is one caveat though
select A from T union all select A from T;

It compiles fine and works as expected if T is replicated but returns only one set of values if T is partitioned. It passes though the check because it's the same table in both selects. The generated plan is
RETURN RESULTS TO STORED PROCEDURE
 UNION
  RECEIVE FROM ALL PARTITIONS
   SEND PARTITION RESULTS TO COORDINATOR
    SEQUENTIAL SCAN of "R1"
  RECEIVE FROM ALL PARTITIONS
   SEND PARTITION RESULTS TO COORDINATOR
    SEQUENTIAL SCAN of "R1"

but only one set of values is present in the final UNION ALL - should be two

Mike
same comment from above.
I owe you a beer for killing the tuple and moving towards this record. In any case, I've tried to look over this code very closely and ensure tuple to record transition was done properly. It looks good, although it's such a pain that I never know if I'm 100%. Hopefully you, me, and dialyzer are a good enough check here.
Use `infinity` with sequential keygens.
Yeah, that makes sense :).
No, since this script is going into the git repository, it should be able to assume it has the PGP keys in that directory already. I just mean touching the user's personal PGP key library is probably a bad idea.

https://github.com/bitcoin/gitian.sigs should match the binaries on SF: the installers as-is, and the contents of the ZIP files and tarballs.

@gavinandresen ACK, you're right this would probably end up equivalent and doesn't do any harm to pull as-is.
Why is MAX_URI_LENGTH used in qrcodedialog.cpp?  MAX_URI_LENGTH is not a part of the URI spec, it is part of bitcoin-qt's implementation, there is nothing wrong with a QR Code with a URI longer than MAX_URI_LENGTH.
You could just have several scoped locks (like with your suggestion below to include a name for the lock), and test whether they all succeed. That would however be different from the code above (which unlocks everything as soon as a failure occurs).
Couldn't this check be moved into constructor instead of checking on each write?
Extra spaces before and after `!`
the typehint should be removed to allow any callable
This entire dict is about a station, so just `name`
Not all of these objects are used. Please drop the ones that aren't.
@spraints Because we only have a policy for code reviewer :)
Should read: "No git-tfs repository __found__..."
Can you use `dir` (for consistency) and pattern should really be `\\.c$" if we're being picky
title is used in both the resultant html and the output filename. When a filename is passed in then this is used, however you do not have that luxury with stdin. Options are:

- Provide a default (stdin here)
- Error if the user does not explicitly provide a title (e.g. though a -t parameter). As a side note you could use the -o parameter if supplied, however in the case that a user wants source in on stdin and html out on stdout, this would not be available.

Currently stdout/stderr is used as a special -o parameter.
- Ideally docco would output on stdout if -o is not provided, but
- this doesn't work if a wildcard is passed as a list of files (you would have to concatenate the documentation of all files into the stdout)
- I'm not sure varying the output behaviour depending on the input (stdin, single file, multiple files) is intuitive

Thoughts?
loginUser suggests they know the login that's already on the image, so I don't think we have to special case this.  If they put the wrong answer here, that's just danger of doing business.  I think we should take block out, changing what was 'else' to if (template.getOptions().getLoginUser() == null)
another way to accomplish this is to add a \@Provides method to guice, which takes Supplier Access as input param, and returns Supplier String (maybe named "tenantid") using Suppliers.transform.  Then, in this ctor, save a reference to the tenant id supplier and call .get() on demand
It seems like a possible solution would be to add a magic level GIT_CONFIG_LEVEL_MAX which would, instead of testing for equality in `find_config_file_by_level` instead just took the largest (i.e. most local) value that it can find and returns that level.
We should also test for ../../util just to ensure nested "up directory" statements are handled cleanly.
``get_documents()`` isn't doing a raw query anymore but rather going through one of the elasticutils S thing. Because of that, it's getting a results dict rather than a raw ES results dict. So the keys are slightly different in some cases.
Yep, I tried to do this in the rest of the docs, but forgot to do it here. I'll fix this.
fixed with your suggestions to override tastypie to use the proxy user.
this happens only on init. we need the pinger to gather this dynamically
写成`var image_set = {};`
might as well rename helper function to `add_api_info_header`
`$body` should be named `$bodyChunk`
hmmm, lol I don't have nodejs installed, that fixed the problem :p
Rather than `Returns whether` say `Returns true if the method is synchronous`. Way less ambiguous.
btw, the only thing you can return here is a string
does it really need to extend ``RequestContextAwareInterface`` ? I think they should be able to be implemented separately
you should remove the extra braces around the condition
Since this exception might be used a bit more often I think we could add that. But I don't see a general need to add it to all exceptions.
I know but it's work just like the real `ResourceBundle::getLocales`

```
<?php
$locales = ResourceBundle::getLocales();
var_dump($locales); // NULL
var_dump(int_get_error_message()); // resourcebundle_locales: unable to parse input params: U_ILLEGAL_ARGUMENT_ERROR
```
CS: indentation.
style: using x = x stutters a lot, try instead

```scala
def makeLoginReq(sg: ServerGreeting) = 
  LoginRequest(username, password, database, sg.serverCap, sg.salt)
```
There must be a link to this page from somewhere.
This line should be in the def of buaa@bachelor@assign
если есть идеи по оптимизации - предлагай
I don't like the idea of seperating hosts and credentials for one service on multiple lines. This will be a pain for users to template and read. How about something like:

```
jmx_instance_1 = user:password@host:port1
jmx_instance_2 = user:password@host:port2
```

That being said, I'd look up the standard form of a JMX connection string and use that.
Assuming you mean from north as in the NORTH BlockFace, everything works as intended. The dead bush is able to be placed on sand and nothing else. Maybe I'm doing something wrong...
it might take less then a second for the pubsub_url connection to fail, in which case it'll busy loop a few times before the next second comes around... consider using gettimeofday()
I think the closure takes care of that, but I went ahead and added it for good measure.  Won't hurt anyway.
You're right on the module dependency
This should be context.revertRestartRequired();
This will have to go in the manualmode test dir, as this call will disrupt the state of the server instance and effect other tests.
This should be Map<String, String>
http://www.osgi.org/javadoc/r5/core/org/osgi/framework/launch/FrameworkFactory.html#newFramework(java.util.Map)
The minimum would be to document this behaviour properly on StandaloneServer.stop() so that calling code (i.e. FrameworkWrapper) knows that stop() is synchronous and that there is no need for Thread.sleep(). A better solution would be to deprecate stop() and introduce a two step API as on the ServiceContainer and the Framework
Where did this go in the new code?
Do we really need the " surrounding the rule?
No need to log here. You can delete the onsuccess handler.
Here, I'm trying to send same events that before, but I hesitated to only send an event when a real app was launched. (i.e. add `&& newApp != homescreen`)
Same here, there is no target.
This still need to be fixed.
The only work around is listening the resize event and add a case in getNextFontSize method when window.innerHeight == 60px. A little bit overkilling in my opinion, but we can do it.
The spinner is supposed to fade out but doesn't because it's immediately hidden now. I don't know how important that animation is but we may need to leave that intact?
changed to use native classList
Remove the bug id if this is a fixed bug.
alphabetize etc etc.
Same as above; it can stay.
Can be, but what about `uimodules` ? Convert to `helpers.uimodules` ?

I suggest: `ui.modules` and `ui.methods` to keep things consistent with naming convention in Tornado.
Better: `validates :username, :presence => true, :uniqueness => true`
OK OK.
Hm, why? It's not only for fails...
Where's the Algebird manifesto! If we abandon our explicit algebraic structures, we will be lost forever!
Add a TODO to move here the automatic renaming of fields in inner joins and drop the duplicated fields as we do in joinWithSmaller/Tiny now.
Why the first sleep?
Add a returns section.
+1 Cory, that's it :)
Emmm, get your idea this time and forget why I said no last time....
This should also explain the defaults.
I don't think any of the following should have this one space indent.
tests please
Thanks for this hint, will do the tests in the next few days.
bstr_ptr does not always return a c-string, memcpy is better here probably
$this->config does not exist and throws an error.
I can't require in to this file I think, it's only used in this one spot atm, which is mostly a isolated function, it just does the eval afterewards too.  So I'm just going to leave this for now, hopefully we can remove all of this code soon too.
this is great.  i like how extensible and flexible you've made this.
I chose to log them out, the ideal thing would be to re-provision them.

Problem - we've just removed their cert but they are far along in the state machine.

Solution - ?
Looks like these still need to be removed?
Also: I should have pointed that out before. Sorry for letting some 4 space stuff get through.
I thought I've mentioned to you to put the whole script after </footer>?
`(bool)` is valid in PHP but we use `(Boolean)` to follow the Symfony coding standards
@aboe76 Is this a left over conflict?
Fair call - I restricted that back down to a less global set of failures, from which I am confident that resuming is acceptable.
This was previously commented out.  Does this result in changed behaviour?
ah nice - i prefer that - could you change this @gutomaia please - thanks!
interesting question -- would it?

I believe (and can be would like to be proven wrong) that it would get closed since that file instance would not be bound to anything (it exists only for .read() call), so it would be _del_'ed quite soon (may be not right away though) thus closing the file.  but oh well -- above construct probably it more legit, especially if you move all logic relying on s under 'with'... ?
That was an Idea Artur Bodera and myself discussed briefly on the mailinglist. Returning a 'generic' URI class instead of throwing an Exception was the other option. So I will implement that.
Ouch! Thank you for spotting it!
We can remove the advice about errors when run the full test suite
Some of the classes in here inherit from object and others (like this one) don't...  Generally speaking, all Python 2.x classes should inherit from object in order to use the "new style" functionality correctly.
`std.range.chain`?
Out of interest, do we have a guideline for ternary operations? This would seem like an ideal case for one, and I'd argue that it's more readable.
Same as before `val().trim()`
@sethladd
right now we know that localstorage is fast, so there's no need to disable the UI during write. But I'd like to have it there simply if one would try to implement a remote storage module, in which case it would disable the input box during write callback.
this should probably use the logging, and not throw an error (even if with die=False it does approx. the same thing)
`$package` is already managed and in the database. Dont call `persist` on already managed objects, this will trigger a duplicate entry.
not sure it needs to be done in this PR though, but it would conflict with it :)
In order to make `ex_unit_ansi` work with both master and previous elixir versions, all you need to do is copy and paste the code from "New API" up to "Old API".
Well, if an action only affects a location,  I wonder why should its signal contain a content ID?
I would rename this to OUTPUT_SOURCES or something like this.
Not sure what you mean. Why shouldn't it be a singleton?
If you could please update that, I'm happy to pull in your change.
this test is nondestructive too
чтобы Request (ну и Respnse и все остальное по аналогии) был веделен как под-секция.
whoops, idea I had that I realized wasn't actually workable. :P
Note for the PR: the frei0r specification says that we should recurse in subdirectories (at least when the path is not overridden by an env variable). We should do this (even though in the Debian package there are no subdirectories).
oh i suppose that makes more sense...
I think you just re-implemented the get_instance method of this class:   def get_instance( self, classname, o ):
Should be private/protected?
нужно как-то одинаково называть
Linting:
[L667:C13] 'i' is already defined.
      var i = cachedRows.length;
Going to be picky... the id's on these should not be sign-in-google and sign-in-twitter.

It would also be cleaner if you made this an actual link tag:
```html
<a class="btn btn-primary btn-block" href="{{ url_for('register') }}">Sign Up</a>
```
I agree. Perhaps we could still have an email verification procedure that could happen at any time, like reddit.  But there'd have to be a reason to do that, like something we limit without an verified email address.
Yes, I know and understand - it's not a matter of trust :). I'm not worried about debug code ending up in release binaries as such but I really think leaving debug statements in the code needlessly clutters it up. If one wants to debug via debug statements it's quick to add relevant statements in places relevant for the problem in question. However, I'll add the debug macro for now even though this line is here only because the feature is incomplete.
Because we need rake task to be executed from spec/dummy dir.
This could be simplified to : `if (privacy) {`
Should be in the oae-config module
I think throwing an exception would be acceptable in this situation, as long as it is documented w/ `@throws`
If somebody runs `node cluster.js -c notANumber` this will probably not work.
This is quite an ugly check. Can it be simplified/improved in any way ?
This seems useful for all our debug tests. If so, why not having a ``DebugTestProjectSetup`` and moving the logic there?
I didn't want to presume to remove things from an existing interface, but if you say so. :-)
The problem is that i think require `zendframework/zend-http` should be enough.
But if @blaugueux install composer without the packages `zendframework/zend-uri`, `zendframework/zend-loader` and `zendframework/zend-validator` he get a error or something like this. 
And on my system it works with only `zendframework/zend-http`. My composer install the other packages automaticly.
Missed `use Symfony\Component\HttpKernel\HttpKernelInterface;` here
Hmmm. Wat is het idee hier precies?
This and the following line can be replaced with:

    $this->assertEquals(substr_count($word_wraped, "\n"), 4);

P.S.: It should be wrapped instead of wraped as well. :)
Ну что ж, и задания бывают не совсем верно составлены :)
Кто ж использует значения со знаком, если подразумевается значение от 0 до 100?
А от переполнения защита есть
обратите внимание, что надо использовать isNotEqualToString: с отрицанием вместо !=  для сравнения NSString
Подскажите: Если у нас есть категория какого то класс и мы ей пользуемся, и импортируем заголовочные файлы категории, то нужно ли (принято ли это) при этом делать импорт заголовочных файлов основного класса над которым создана категория?
NAssert у тебя выполняется два раза в строчке 21 и 33. Хотя процент не меняется.
А идея классная про проверку процента
@mvmn вопрос - почему не заточили всё до конца? Почему можно враз изменить DNA_LENGTH, тем самым приведя в негодность метод мутации? Если бы всё было заточено под конкретную реализацию, вопросов бы не возникло.
Why does this one have different comment notation?
Since there is no need to do any arithmetic with Image ID's I didn't see a reason to make them numerical. By making them a string it leaves open the possibility to have alphanumeric ID's
>And override the equality operators like you did in GitObject?

You can directly use the `LambdaEqualityHelper`, but you'll have to define what uniquely identifies a Note from another one.
Doesn’t `{% if not forloop.first %}` work?

And aren’t there nasty whitespaces before the commas of the rendered groups list?
You mean have a File I/O section as well as putting the functions into the relevant thematic section? So far I only did that for the classes that are used for reading files.
I don't think plot=False should be an option for a viz function
the other identified source goes there...
like in the updated epochs example.

On 28.10.2012, at 08:54, Alexandre Gramfort <notifications@github.com> wrote:

> In examples/preprocessing/plot_ica_from_raw.py:
> 
> >  
> >  ###############################################################################
> > -# Show MEG data
> > +# Show MEG data before and after ICA cleaning
> > +
> > +exclude = np.r_[ecg_source_idx]
> not used
> 
> —
> Reply to this email directly or view it on GitHub.
>
I would name it compute_proj_raw for consistency
I think the current behavior in all our DAO is to skip a restriction if a parameter null. As for collections with criteria API you can probably pass in an empty collection only if that is what the caller passed in which i think in this case will find all names with a blank locale, but am not sure if you can do the same with lucene queries
Yeah, I was just doing it the way that was already there - I'll change it
I think I've deleted it.
I don't think it's a good idea because it's a pluggable prompt, but I can enable only svn, git and hg by default.
Me neither, I'm Cuban and I speak Spanish. Probably you are right. Thanks.
The reason is that without it it will set the state to TEXT_FRAME on a text frame but will just "fall through" to the next case statement which would be NON_TEXT_FRAME. So it will never move to the right one.
you don't need these...

the whole reporter can be something like this:

````
var GrowlReporter = function() {
  this.onRunComplete = function(browsers, results) {
    growly.notify(util.format(messagePattern, results.failed, results.success), specResults);
  };
};
````
perhaps use an unsigned integer then.
It's good to make n an integer. Import int_tested from residue_ntheory and write:

```
n = int_tested(n)
if n < 1:
    raise ValueError("n must be positive")
```

int_tested will handle the error if n is not an integer-equivalent number.
Done. Nice :-)
slice order can be a list of integers or these

```
traits.Either(traits.List(traits.Int), traits.Enum(...), ...)
Me parece bien, lo puedo hacer mañana a la mañana

On Wed, Mar 21, 2012 at 9:17 PM, Alpha <
reply@reply.github.com
> wrote:

> > @@ -0,0 +1,8 @@
> > +﻿@{
> > +    ViewBag.Title = "Change Password";
> > +}
> > +
> > +<h2>Change Password</h2>
>
> ¿Creés que por consistencia pudiéramos pasar estos mensajes al usuario al
> español?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/CommonJobs/CommonJobs/pull/42/files#r588671
>
Creo que en el backlog no deberíamos hacer referencias temporales relativas a las decisiones. Me parece que es suficiente con la explicación sin indicar cuando se decidió.

Si queremos explicar que pasó, porqué y cuando, lo haría en otro documento. Aquí solo explicaría como es ahora mismo. Tal vez el documento de la retrospectiva es un buen lugar para poner esta información.

Otra opción que no me gusta, pero puede ser un punto intermedio, es reemplazar `A partir de este sprint` por `A partir del sprint 8`.
that was specifically not working because the appearance of the menu on the first click resetted the click count for some reason. So it would've been either double-click to close OR single click for menu, but not both. Then I found this solution and it works on my own Win7/x64 but also misbehaves on XP. It's also not registering mouse clicks on non-maximized window in XP as it does in Win7. It's pretty weird...
Absolutly. I did not meant initially to change the "by presta"'s design.

Q:
 Since I'm totally stupid with the github, how to amend the code so the merge will go swimingly?
 ie: If I do the change now do I have to do another pull request? Sorry I'm dumb and it is going on my nerves to spend hours to submit a change that take me 5mn to write.
This is not yet supported :)... you should write it for each one separately :S.
```
monetize :price_cents
monetize :tax_cents
monetize :total_cents
```
A class can only have one parent. When we talk about inheritance we are talking only about the parent class. A Ruby class can only have one parent, so you can not inherit more than one thing. You can incorporate additional functionality into your Ruby class by including multiple modules.
Superflous whitespace
please use other name :)
Done - I actually removed the bit about multiple apertures that are different for every source. This would make things a lot more complicated, and I don't think there's any advantage to trying to have the function do multiple apertures that are different for every source, as opposed to having the user do this manually.
should not be null
It looks like you aren't checking the connector supports modifiable coordinates any more. Or am I missing it?
Got this Prime class from mathn.rb in ruby 1.8.7
Copied from openstack-common. Need to update openstack-common in reddwarf soon.
Tästä puuttuu `'` sulkujen edestä.
That will do a lot of command calls.
You mean, public class constants? Should be private, I want to avoid something like HandlebarsFilter::OK_RETURN_CODE, known return codes should be at ProcessBuilder
Is it possible that you're working off of an old version of the libgit2 diff.h header file, because I think the type signature of `git_diff_tree_to_tree` was recently changed to `(git_diff_list **, git_repository *, git_tree *, git_tree *, const git_diff_options *)` and this looks like you may be using the old type signature...
@pelson I don't think that's right. I think the original issue was that I assumed the construction of the canvas was a standard interface. This was not the case for `TkAgg`, requiring an extra kwarg. In the original PR, I set up the canvas corresponding to the value in `rcParams['backend']`. The following snippet might help:

```python
import matplotlib
matplotlib.use('gtkagg')  # this sets rcParams['backend'] = 'gtkagg'
from matplotlib.figure import Figure  # set up the canvas defined by the backend above
```

I do exactly the same here, but now I'm using the `manager` to bypass a lot of the variation in backend set-up that `pyplot` makes so opaque.
Thanks, I'll take a look. I was having issues with this test locally, so glad you found it too.
I can't reproduce any serious lag after removing this. There might be a slight decrease in performance, but if that is true, we need to get rid of whatever isn't being destroyed - this won't help.

The 'plain widget as window surface' warning *should* be irrelevant due to the opengl graphicssystem.
Оу. Если про стрелочки - случайно залетел, другой кодинг стайл. Пройдусь по классам регуляркой поправлю. Если про spawnDb(array( одной строчкой тут сделал покороче для наглядности, что б не основное в тестах не занимало много места.
Not exactly sure why - but I *think" my reasoning was - a note can be posted by system as part of event log - adding ``%{staff.name}`` to internal note template will be problematic.
Just flagging this as a line to be updated once we sort out the namespace question.
This looks like it shouldn't do the right thing. ${$upkey} should be ${upkey}, no?
I did:

[31mFAIL[0m at (NO_SOURCE_FILE:1)
    Expected: (#< clojure.lang.AFunction$1@1e13bfe1> #< clojure.lang.AFunction$1@229a5c34> #< clojure.lang.AFunction$1@441b6bab>)
      Actual: [1.0000001 2.00001 3.000001]
Do you have a use case for this already? How would you use the return value?
why using static error here? you are in a non-static context
Not me. 

There is a reason to alter it for side-by-side, it doesn't fit properly without adjustments. I assume these were changes that Paul made that ended up here instead.
You're inside an entwine context here, no need to re-select the element, just use `this`. In fact, its harmful to re-select, since it will apply to all DOM elements matching this selector, rather than just the current one.
That goes for the styling of it too. Most recent version uses sprites.
I'll add some comments. The one in the WP example is not entirely applicable, because this config would not suffer the 404 problem.
How about  `getFrom()` and `getFromAsString()`?  `prepareFrom()` is equally nasty, frankly.
Set error message to "Author was not found"