labofsahil/github-event-dataset-2012 huggingface dataset:
wrong indentation - should be 4 spaces after begin of return.
Forgot to use level if provided.
I've added an implementation of truncate instead.
No need for leading backslash when referencing a class name in a string.
I would have thought {maxExplainFilesPerPair,maxEventsPerPair} would get read from the DB.
Let's audit the call sites, surely there cannot be that many of them.
String also doesn't iterate over it's characters for determining the length, so "def" is ok here.
Are you sure ``'Unable to locate adapter plugin manager with class "invalid adapter"; class not found'`` has the correct type as "string" is not a sub-type of "string"?
Are you sure the class "Doctrine\ORM\EntityManager" actually exists, or did you maybe forget to add a USE statement?
Are you sure ``$this->getAllowedOptionValues(array())`` has the correct type as "array" is not a sub-type of "array"?
this is only adding spaces at the end of the line, please revert
"Neuron" => "Neurons"
this one's the ticket. :)


On Thu, Nov 29, 2012 at 11:09 AM, rick <notifications@github.com> wrote:

> In services/asana.rb:
>
> > @@ -7,32 +9,49 @@ def receive_push
> >
> >      user = payload['pusher']['name']
> >      branch = payload['ref'].split('/').last
> > -    # rep = payload['repository']['name'] + "/" + payload['name']
> > +
> > +    branch_restriction = data['restrict_to_branch'].to_s
> > +    commit_restriction = data['restrict_to_last_comment'] == "true"
>
> "1" the string, not the integer :)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/github/github-services/pull/460/files#r2266584>.
>
>



-- 
Nathan Potter
VP Engineering, Chartbeat
--------------------------------------->
Seems like the modal width is always 752px and height varies with the content size, doens't matter the resolution. And the content has a width of 750px, also doens't matter the resolution.

The height varies, with a maximum of 400px and no minimum, so, I made the picture "resize" inside this boundaries, keeping proportion intact.
Not sure about this one. I suspect the idea was to mimic the behavior of PHP when the property doesn't exist. With your change I'd have to add a try catch (while catching BadMethodCallException) around simple property accesses like $key->something. That seems weird to me and would probably be more confusing than helpful.
I don’t get it. When does `uc` get a value other than the empty string?
The clarification from the dev kind of makes this test pointless now!

I think we should rename it to `test_snippet_set_present`
It's a table view section title
you should add FQCN here
Yes, that was the idea. Forgot the name of the method, though. Do it like it is user User model.
OK, it seems there is really nothing better.
Rewrap. Remove unnecessary spaces.
I am not sure if you are allowed to override `ajaxSettings` directly.
Use `prop` instead of `attr`.
I don't know. There is too much clutter to be sure. :-) Do a bit more work and I will check then.
You could set `context_object_name` in detail view to `user` and you would not have to user `object` around!
Little help: ;)

Hello test!

This message was sent to you to confirm this e-mail address as yours for
your account on PiplMesh with username "test". If you have already done
so or don't want to, you can safely ignore this e-mail.

Please click the link below to confirm your e-mail address:

http://127.0.0.1:8000/account/confirmation/token/Ei3GCO3ce9rJQXUe8p7U/

Or, open the following link:

http://127.0.0.1:8000/account/confirmation/token/

and copy-paste the following confirmation token into the input box
there:

Ei3GCO3ce9rJQXUe8p7U

Confirmation token will be active for 5 days. If it expires you will
have to redo the process of confirming your e-mail address.

Please also be careful to open complete link. Your e-mail client might
have broken it into several lines.

If you have any problems confirming your e-mail address or have any
other questions just reply to this e-mail.


Yours,

PiplMesh
http://127.0.0.1:8000/
Also this could be a simple atomic query, you set `is_online` to `True`, if `is_online` is `False` and if `user.connections` is non equal `[]`. If query succeeds, you send an update.
BTW. `self.author.username` is much nicer code. :-) In this way you somehow tell that `author` is an object.
then don't make it a bool
codestyle, remove hungarian notation
indeed i guess instance_encounters manages that manually
Update to lodash templates instead of "jquery templates" which is inaccurate either way.
The People API is really just key value data about individual users on the site, no event or test flags.
some `$options` are totally optional and other `$options` are not totally optional, you've to specify something . For example, in `createdHostedService` API the user is supposed to set either the location **or** affinity group.
Or maybe better

```javascript
var url_types = cls.ResourceManager["1.2"].UrlLoad.URLType;
var not_requested = entry.urltype == url_types.FILE || entry.urltype == url_types.DATA;
```
`url_types` can be cached outside.
But you know when you're in cockpit view, because you can *see the cockpit*. It's more useful to know whether you're shooting forwards or backwards, I think.
Could you just print err. msg only when it is failing?
Please use code similar to:

print ('In the handler.')
if not number == 762:
    raise SystemExit('pubsub failed.')
Yeah, I think the rule about owning an object if you call a method with “init” in the name can really only be trusted if it’s a class from Apple. There’s nothing forcing the rest of the world to follow that convention.

In this case, it’s a method we control, so if it isn’t following the convention, we should probably fix it. But isn’t ARC just around the corner? :-)
hm. we should prevent this from ever happening.
Constant string: `'`.
...remove autogen TODOs
It's great that you've made sure that non-breaking space is right to left, your readers would have been screwed otherwise.
No, better is faster. Harder is stronger.
Yeah, I agree I wasn't a big fan of exposing this past the server. But I also didn't have a quick way for handling these "lower case" scenarios where it's not actually the datastore property but a different property altogether.

@robertkluin-wf
I just pushed this change.
In testing, timezone info wasn't accepted by the LRS. This function was essentially lifted from elsewhere (ScormDriver/src/APIFiles/UtilityFunctions.js) but was modified to satisfy the jslint check.  I used another "accepted" function for consistency's sake, and I added it here instead of using that one so as not to create a reverse dependency.
ProblemSet imported but unused.
actually no, we want to allow it to be inherited from parent.  perhaps just say in description that this is required, either set here or inherited (eg from nginx controller).  (we also have runtime check in getDomain.)
We found that for ActiveMQ it was important to do:
  "nohup ./bin/activemq start > ./data/activemq-extra.log 2>&1 &"

Without the redirect (i.e. relying on nohup.out) it would sometime fail to execute the command when testing it in a VM in Rackspace.

Suggest you add the redirect here as well.
I agree that we should be encouraging use of `git clone`. The alternative tarball is described on the downloads page so that's fine.

It's a shame that `mvn clean install` will download brooklyn artifacts again, when it's already in the downloaded distro. But I think we should live with that for now.
you should use `propertyName` (or just `property`) here, because underscore_case is prohibited my most js style guides
Yep I like that.
**Error:** Opening brace of a class must be on the line after the definition
**Error:** Scope modifier not specified for member variable "$foo"
I'm confused by this test.
The parsing notices seem to expect 4 calls to MongoClient, but you only do it 3x?

This test atleast doesn't work for me
I believe this is related to https://jira.mongodb.org/browse/PHP-502
Believe this is done
can you change this to take the User object, not the UpdateUserRequest object (which will be an internal class once the other change above is made)
Should be "these based boxes"?
Also, could be an alias and I don't think this even belongs in here.
Удали файл.
Сделай тест, в котором метод будет выбрасывать исключение. Только надо проверять, что выбросилось именно то исключение.
Included by the `init` call
ENV["LOGALING_OFFLINE_INDEX"]  って、どこででてきてましたっけ...
(はじめて見た気がしています ><)
crap i didnt think of the situation where a user is using two MPMetrics instances at once. you are right
it should be ``input``
Could you add `assert_equal` or `assert_almost_equal` assertions too? (to check that the proportions of each class are roughly respected)
Shouldn't h be sampled here?
Looks like the file is called ``plot_adaboost_error.py``.
you should add a line below each parameter see other docstrings.

```
param: type
    Description ...
```
I think this is an important point and can be made in half a sentence. I agree, you shouldn't overcomplicate things.
I believe that this line above should be in the fit and not the __init__, as it violates the estimator API and will break things like clone.
This isn't really necessary...
This is a duplicate, please remove it.
See https://github.com/Macadamian/titanium_mobile/pull/76#discussion_r974838
This is not a final solution.  I prefer that we don't add that, as it would be easy to forget to remove especially without a comment saying why it's there.  I can live with unused function warnings for functions that are imcomplete.

There is however still a warning for signed unsigned comparison on line 209 that can/should be fixed in that patch.
This is part of choice 2 though :P
"If you are not"
nitpicking: log file size IMHO shouldn't be part of the name
What about building an intermediate flattened dict?

Subkeys like ["foo"]["bar"] become ["foo["bar"]], since that's the same format you're expecting AFAIK. The nesting will never go past two levels, right? Seems more straightforward to manipulate data structures.
Not sure dev would want to override the set, but they could add to it using a per-project `lint_args` setting right?  This would be the same approach the original `erlang-flymake.el` implementation does with it's [erlang-flymake-extra-opts variable](https://github.com/erlang/otp/blob/maint/lib/tools/emacs/erlang-flymake.el#L19).

I'm thinking we start with that approach and can expose a `erlc_options` (or similar) setting if it proves to be too restrictive.
@shacker thanks
If you store all the `Insight.get_by_id_async(insight_key)` results into a list, then do `[x.get_result() for x in insight_futures]` you will do a single ndb request instead of one per insight.
```if not mapping_p_o[label]:``` is neater.
The browser (and the browser user) doesn't care about what the names of the
fields are, or how long they are. The only people who do care are us,
reading the code, and it's much clearer if they have obvious names.

-p
--
Paul Swartz
This message sent from a mobile device
On Jun 5, 2012 3:11 PM, "Stephen Burrows" <
reply@reply.github.com>
wrote:

> > +    def __init__(self, tier, *args, **kwargs):
> > +        super(DowngradeConfirmationForm, self).__init__(*args, **kwargs)
> > +        self.tier = tier
> > +        self.initial['tier'] = tier.slug
> > +
> > +
> > +class TierChangeForm(forms.Form):
> > +    """
> > +    This form can be used to change a tier without going through paypal.
> > +
> > +    """
> > +    action = reverse_lazy('localtv_admin_tier_change')
> > +    method = "post"
> > +
> > +    tier = forms.SlugField(widget=forms.HiddenInput)
> > +    s = forms.CharField(widget=forms.HiddenInput)
>
> Okay. Just to be clear, though this is technically a variable, this is
> also a django form field declaration. It's pretty typical for forms to
> employ obscure field names so that the querystrings they generate have
> not-entirely-obvious meanings - i.e. ``?tier=premium&s=serj3k1`` vs.
> ``?tier=premium&security=serj3k1``.
>
> I'm not sure how much validity there is to that way of doing things; it's
> a convention which may or may not be grounded. Just want to make sure
> you're thinking about this as a form field rather than as a reusable python
> variable. There are other ways that this could be made clearer - such as a
> comment.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/pculture/mirocommunity-saas/pull/1/files#r931088
>
SYNCFILE -> HTTP_HEADERFILE
thres_image -> thresh_image perhaps... the first breaks the word in an unnatural place
These multiple estimate functions can all be reduced into one.  Please refer to the NiPy code I mentioned earlier.
I'm not a big fan of re-using variable names when the type changes. ``item_model`` perhaps?
s/that he has been successfully registered/that they have successfully registered/
Can't we clean up the logic in this function so it is:
```
if (hit) {
}
else {
}
```
Instead of having it in two conditionals?
OK, move it closer to the function.  I still argue that given the wide scope of the variable, it is hacky.  However, considering alternatives, like hiding it in a closure, this is probably the lesser of the evils.
I think it would be cleaner to re-write this loop to use `Math.min` and `Math.max` functions.
Okay, despite my bitching I went ahead and made the changes.  I'm still genuinely curious as to if there are any technical difference though.
It was Map, thanks.
Can't this check and early return go first in this function?
Having done a little testing, I think this (and the original bug) is more than a little misleading. In practice, I don't think the developer should **ever** specify VIDEO_CONTROL_FULLSCREEN on iOS. Here's why:

- When a video player is opened in iOS, it is opened in non-fullscreen mode, even if (as in this case) the view fills the screen.

- If VIDEO_CONTROL_DEFAULT or EMBEDDED is specified, the standard, embedded controls are shown. These include a "Fullscreen" button. If the user presses the fullscreen button, the video goes to fullscreen, and the FULLSCREEN controls are automatically displayed.

- If the FULLSCREEN controls are displayed, they include a "DONE" button to return to non-fullscreen mode. BUT if the video isn't in fullscreen mode to start with, the DONE button doesn't do anything. And, of course, there's no way for the user to switch to fullscreen.

Not sure how all this interacts on Android.
do you think it would beneficial if it said  `If MIME type omitted`
Please open a new issue instead of add a todo.
hah. yes and no. I did use the Keystone type as a reference, but when I started this type, I originally tried to use the Keystone admin token to interface with Glance -- therefore, I wanted both Glance and Keystone running. It turns out this is not possible to do, so I resorted to the glance-api-paste.ini file.
For what?  If u don't need `richtextfield`, don't use that.
``cd cmf-sandbox``
но я не понимаю в какой момент если у них макс коннекшинс мелкий

логично было бы при открытии окошка и закрытии, но у нас еще и фромурл

может

* сделать счетчик использований пушера
* если достигает 0 ждем 5 секунд и убивает коннект

?
Nice PR, just asking why you're replacing " ' " with " ' " (without spaces) ?
Nevermind, [I see now](http://dlang.org/function.html#parameters) that it is supposed to be evaluated on every use, by design.
The point is that `Not` is a template which evaluates to another template. The fact that `enum Not` appears in the text is just a consequence of the »inner« template having to be eponymous to the outer template.

Both Jonathan and I are aware of the common Phobos conventions concerning the casing of symbol names. Still, we both intuitively chose to put the template predicate primitives in PascalCase. This is simply a case not covered by the current »value/type« conventions. The rules I (and presumably Jonathan) would propose for choosing template names are:

 * If a template returns a (type) tuple, its name is PascalCased.
 * If a template returns a type, i.e. is(T!Params), its name is PascalCased.
 * If a template returns a value, i.e. is(typeof(T!Params)), or returns a fully IFTI-able template function (and thus behaves like a function), its name is camelCased.
 * Otherwise, e.g. if the template returns another template, or simply isn't eponymous at all, it is PascalCased.

Now, back to the specific case discussed here. Originally, I just intuitively chose the names, and they still seem to fit well with the rest of my Phobos-convention code. But thinking a bit about it, I think there are two main reasons why the tmeplate predicate primitives should be cased like this:

First, for consistency, because »higher order templates«, i.e. templates acting on other templates, are generally in PascalCase (I don't think there is disagreement about this), and I tend to see `Not` as a special case of template composition. For example, if Phobos had [`Compose` and `PApply`](https://gist.github.com/1733753) templates, `Not could easily be implemented like this:

```d
template not(bool value) { enum not = !value; }
alias PApply!(Compose, not) Not;
```

Thus, having it in upper case just seems a lot more consistent to me. A template which returns another template »feels« completely different from a template which evaluates a value – for instance, you can't even directly get a value out of a `Ǹot` instance, unless you resort to a kludge like `Instantiate`.

The second reason is that it offers a nice way to mentally disambiguate between compile-time and run-time »algorithms«. For example, `std.typetuple.not` would conflict with `std.functional.not`, as Jonathan also mentioned above. Granted, this can't be a reason to break an otherwise consistent naming convention – after all, D has renamed imports and all that goodness. But I think it would be unwise to ignore this benefit when defining the naming convention in the first place.

To wrap up, I'm all for following the Phobos conventions with regard to naming. I just don't think they are as clear as it might seem here. You are right about `pred`, though, I'll definitely change that.
I'd prefer to keep the Users namespace pure to the ACS methods
If i believe the tests, yes.

then again, what's the common point between all the production code that
break?
It passes all the tests!

:D

2012/6/24 denlab <
reply@reply.github.com
>

> >
> > -(defmulti to-query "Dispatch on the :tag flag"
> > -  (fn [x] (cond (map? x)       (:tag x)
> > -               (#{"(" ")"} x) :par
> > -               (s/blank? x)   :blank)))
> > +(defmulti to-query "Dispatch on the :tag flag" :tag)
>
> are you sure ?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/clojure-consulting/solr-parse/pull/4/files#r1038929
>
do we know if this syntax is legal in MDV?
not worth changing for now but it'd be nice to add a TODO if it is not.

Also FWIW, this does not match the input/item.html
Ok, I hadn't realised that.
There is already an EKBException. Maybe that should be thrown instead? 
Or do you think it is better to throw a TransformationException to be 
more specific?

Am 2012-10-16 15:15, schrieb Christoph Gritschenberger:
>>           checkMethod(method);
>> -        forwardEvent((Event) args[0]);
>> +        Object source = args[0];
>> +        ModelDescription sourceModel = getModelDescription(source.getClass());
>> +        Class<? extends DomainEvents> target = findDomainEventsInterface(proxy);
>> +        ModelDescription targetModel = getModelDescription(target);
>> +        Event e = (Event) transformer.performTransformation(sourceModel, targetModel, source);
> Maybe we should throw a more distinct Exception in the TransformationEngine
> maybe "TransformationException" or something more specific
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openengsb/openengsb-framework/pull/783/files#r1853556
>
This means that dictionaries could be projected down to remove fields that weren't used.  It might need some changes elsewhere (especially once Renato's change is merged in).  

It might be safer for the moment to be a SourceActivity.
`<nitpicking>` Can you add some translation context here as a third argument? Something like "Switch from preview to CMS view mode, needs to be a short label". `</nitpicking>`
build/ was added for a bug fix.  for some reason my build did was getting sent to npm
This is going to need to be param-ified, eventually. Okay for now.
Well as I said, it was just to preserve the previous behavior, if you
want to change it feel free to make another PR.
/[[:alnum:]-_\.]+/i ?
Not 0.4, but 0.3.1. We are just rounding out someting starting before.
Probably want to say "crowbar barclamp" here.
The cleanup code must always run. Better put it into another finally clause
Sorry, den Typ werde ich natürlich hinzufügen. Ich glaube wir haben das deshalb gemacht, weil es sein kann, dass ein Proofreader etwas hochlädt, dann aber krank wird und sein Nachfolger dann auf die Korrektur zugreifen kann.
Laut den Services setzen wir den Proofreader erst, wenn das Ganze zum Kunde committed wird. So hab ich das jedenfalls interpretiert.
the approach we use in order to keep a class's creators is by using the @author javadoc tag. Generally if your modifications added to a class impacts its functionality, as they obviously are in many of the classes this patch touched, then you should add your name to the list of the authors.
This should throw an unimplemented exception for now.
I think it'd be cleaner if `UserCache` didn't need to know about or accept a result object either. It could just raise a `ValueError` on a not-found `User`, much like `import_steps` (or, even better, it could just allow the initial `User.DoesNotExist` error to propagate upwards), and the caller would be responsible for adding that to the result
Remove the space after `sakai.api.Util.tagEntity(`
Запили при случае такую же херню в аггрегатор, а то меня там с этим уже просто доебали.
We probably don't want to use the date.toString() representation.  

Suranga, what do dates look like in HL7?
Why only **beanProperty**? It can be any valid SpEL
The ConnectionStringParser function will never be used standalone, correct? If so, there's no reason to expose it. Instead, do:

```javascript
exports = module.exports = { ConnectionStringParser: { parse: ConnectionStringParser.parse } }
```
Why these lines are needed?
maybe we should leave info about random starting offset?
yes, this is like `@Name`, but for a whole path
Added under `"suggest"`because you have to RTFM anyways to set up the `ProfilingAdapter`.
Pass in a TextWriter instead of assuming a StringWriter.  See the latest versions of the KML CzmlDocument.
This is exactly the type of reasoning that belongs in code comments - nice! :clap:
wrong CS here
Just a comment about our way to work. (It's not important at all, I just try to increase my skills in github)

I can't change that indentation issue simply from the Github GUI. Normally the logical procedure would be to reject this pull until this is fixed (in another pull request). (This is surely overkilled for this small issue, I accept is of course, I just try to find the best way to work with this tool).
I guess we can resolve these kind of issues by creating branches. Then the branch IS the pull request, and you can modify it after having created the pull request, in the same thread of discussion.
=> I will document myself on that
Nullable. remove the "per offer language"
Took me a while to see what was wrong ;-)
AbstractBaseMetaShuffleSplit: this doesn't feel generic enough for me, but I like the meta part
if it's a new file, I don't think we need to keep this copyright statement
menu-dialoges is mispelled. I suggest to rename to menu-dialogs, including the folder name,
All formats are supported, but anything new should be in markdown - the html format is legacy for stuff created before we had markdown and text is used for stuff arriving via email.
This should be deprecated in favor of using `keyboardDidShowAtHeight:forView:` exclusively.
This is for Titanium View implementations, that correspond with TiViewProxy. A TiUIView is responsible for creating and maintaining a native Android View instance
Mibbit iframe with IRC server set to irc.subluminal.net and channel set to #abertayhackers
I agree. We should create a separate PR that throws the error (for 2.2), and possibly switch this to a WARN message for 2.1.1 (even stating that it will generate an error later).
Please add a description for the unsuccessfulMessage.
This checks only the first entry of the access list.  If blackberry.push is defined in another access list, autoDefer will not be set correctly
I can't remember, I should test each one on their own.