labofsahil/github-event-dataset-2012 huggingface dataset:
We need to have some way to unsubscribe this "error" event. Otherwise, there will possibly be unused memory occupation and memory leak.
well, the display wakes up now. Honestly not sure if this is the commit that did it, but at least that's working now.
getDefaultNavigationApp is not allowed to return null (and must avoid that by design). Otherwise we would have a NullPointerException in the code creating the menus.
we might also want to add the new option to https://github.com/openengsb/labs-paxexam-karaf/blob/master/options/src/main/java/org/openengsb/labs/paxexam/karaf/options/KarafDistributionOption.java?
this is a duplicate of the first line and should be removed
The commit message should reference platform_manifest not android; do not init my old (deprecated and soon to be deleted) android manifest. You do not want to spend 10 minutes trying to figure out why you can't sync like I did.
J-PAKE.
this works fine for us on AR 3.2. Any chance we can get this merged in?
Hi,
you forget to call the afterScroll function (if any) after scrollTo on touch devices.
Did you run into an issue where some of the stylesheet links (the one's that use {{ MEDIA_URL }} instead of /media) don't work out properly? I'm getting this issue right now and searching around it seems to be because it's not a RequestContext anymore. Is there any way to get around this without messing up proxy caching? Should we just move away from {{ MEDIA_URL }} altogether?
Use ENV.cc here instead. No makefile?
But we will still have an option to do so in Settings right
It's the same as the 16px png, just converted to .ico for maximum compatibility.
How does this look? It seems to have been made from the same template: https://github.com/chamnap/javascript_style_guide
Now we're missing HTML, CSS, Jade, and OMeta. I think we'll need to write that last one..
I expect that we need to add composite values to the result presentation soon, to disambiguate records (e.g. "$Name ($Email)" for members which could have the same name).
you can write readme in markdown if you do not mind, which will look better in the GitHub page
#ifndef MISSING_EGL_EXTERNAL_IMAGE
Thank you Sindre. You should consider submitting this to the jQuery Mobile team's ThemeRoller repo:
https://github.com/jquery/web-jquery-mobile-theme-roller

This index file was downloaded straight from their download tool.
we are testing implementation here!
Ahh, ok. Care to fix it?
I think we ought to also have a "Cancel" button, or some way for the user to revert their changes to the last saved value, in case they accidentally cut and paste the wrong code, or change their minds and want to restore the last script code that was in the editor before they started making changes.

Maybe there is another way to do this (short cut keybinding?) that I'm not aware of, but if not, we need it
this message is not going to be formatted, is it?
What if the class actually wants `_BackendSelectorWithH5` as its metaclass?
So can this be mitigated by implementing `Set.__eq__` as
```python
def __eq__(self, other):
    return self is other
```
Because the required code for each of the four deserialization cases is logically distinct and should be idempotent, I think a branch is still appropriate... for now. I've updated the second TODO in favor of future deprecation/removal.
ok, it returns a map view, which might be the problem. Is there anything smarter `map`?

    scala> Map(1 -> "aa", 2 -> "bb").map{case (k, v) => (k -> v.toUpperCase)}.toMap
    res12: scala.collection.immutable.Map[Int,java.lang.String] = Map(1 -> AA, 2 -> BB)
No need to repeat type annotations
I'm not 100% sure though, 2.1-M2 was cut when I was away.
Reuse PoisonPill?
Here the double param list becomes both very ugly and unintutive. Is this the best we can do?
Evernote was unable to submit your note for the following reason:
The storage limit for this account has been reached.

Original message information:
From: drewhk <notifications@github.com>
Delivered to: thanhbv.fa84f@m.evernote.com
All recipients: akka/akka <akka@noreply.github.com>; giabao <giabao@sandinh.net>; 
Subject: Re: [akka] Minor cleanups in new remoting (#981)
Sent: Fri Dec 21 08:40:20 PST 2012

To prevent excessive emails, you may not receive another error reply
for the next 360 minutes.
I like Account more than User but am a little confused as to its role so far.  Do you intend for there to be an Account class at 2.0?  Or an account_controller?  I wasn't expecting either.  How do these fit into the RESTful web api?  More importantly, how do they relate to the set api?    My expectation had been that we were going to basically be moving all the accounts data into cards and all the account handling into packs, no?  What is our pivotal ticket for that discussion?
This was Card.current_user, I think.  We may want to move parts of this to Session or whatever that becomes.
I think maybe this should be more like this:
NamLogic.configure({
  :code_hash => Wagn::Codename,
  :main_hash => Wagn::Conf,
  :fetch => Card
})

And allow the block form too.
`Dir.new.each` yields filenames (without path), so `start_with? "."` isn't enough.
Name space polution
selectedReplicas then? Basically, it's the replica the protocol should be sending the message to. Depending of the use case, we may want to send to all or only one and it's the selected flag that tell us that. I guess it would make more sense to be "selectedReplicas" instead?
Indeed, it is not initialised in the constructor nor used anywhere inside the code. I removed the property entirely now.
test that if a status is changed, distribution centre creation logic is triggered on the new value, not the old value
How to remove read permissions?
Please remove ``@inheritDoc`` again, we have not defined any semantics for this annotation (see also previous discussion on this topic).
strange that this rule is duplicated
again, copyOfRange
Alright, that makes sense. I'll fix that.
Although it might take 25ms to set the properties, we can't be sure that this will not cause an invalidation of some key aspect of the cell. 

This probably means that each of the properties will need to have their setters overridden to forward it onto the cell itself.
These still need to be named. See my previous reply.
No, the test will fail otherwise. Maybe creating a mapper with hasDependencies flag will fix that? We'll look into it.

Thanks!
M-x transpose-lines
We are not appending a port to it, but setting it if not already set.
Typically, this should not happen : but not having the property set messes up all sorts of assumptions within spark (with and without yarn branch iirc).
Currently I am using it more as debug code than anything else !
ben cest la ligne de code qui est utiliser partout mais qui sert a rien.... mais qu'on voulais quand meme garder... so je lai mit
This will break compatiblity with java5
I don't think we'll need excludeFields here.
If the res header has a invalid url as the 'location', authority() return 'null' which causes a TypeError.
нужен комментарий. кто не знает, никогда не поймет, зачем это тут нужно
у нас сначала методы, потом поля
`# :nodoc:`
I think it's better to use `*args` here:

```ruby
Proc.new { |*args| instance_exec(*args, &rescuer) }
```

Or use different argument name, e.g.:

```ruby
Proc.new { |exception| instance_exec(exception, &rescuer) }
```
yes, and there is a line a little lower that sets `app = self`, it might be more clear to move that line up and use the app var rather than relying on the hard coded
Same spacing around `{}`.
It is, but it's only tied to STARR.   The real FJBG source may have changed, and you'll wind up with compiler errors.

We don't need a new starr everytime FJBG source changes now.
It may be enough to check that the identifier starts with a capital letter or is backquoted and let those pass.
Adding methods to StringLike is discouraged. New methods in the standard library have to be powerfully motivated. If these are really needed for the interpreter patch, put them in scala.reflect.internal.util.StringOps.
Yes, the changes above result in that one-branch-switch becoming straight-line code, [a comment in SI-5672](https://issues.scala-lang.org/browse/SI-5672?focusedCommentId=57812&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-57812) shows the javap output for it.
does it work with other scipy minimizers?
needs tests for other cases

would be easy by subclassing and defining different methods

I didn't see if there is or what is a default method.
Again, just do '>>> K.commutative' and test the output.
In fact, only np.inf seems to be used.  So maybe just create a separate `test_np_inf`. Or would it be the same to just test `float('inf')`?
PEP8 "requires" a number of spaces here. I suppose use your best judgement.
Maybe add `CondVar = CondVariable` (which maybe could then be called `ConditionalVariable`) and `Var = Variable` shortcuts so that they match the string values.  I don't know what `valid` means.  Is it useful to have it in the string value too?
Following the comment above, we don't need this method anymore.
lines 423 to 444 can be simplyfied as:

```
if(isset($component['class']) && get_class($this->_components[$id])!==$component['class'])
{
  unset($this->_components[$id]);
  $this->_componentConfig[$id]=$component; //we should ignore merge here
  return;
}

foreach($component as $key=>$value)
{
  if($key!='class')
    $this->_components[$id]->$key=$value;
}
```
I'm wondering why we want to support create_function() here. This wasn't supported before, and create_function() is worse than anonymous function. Moreover, we don't deal with create_function() in other places of the framework.
Maybe it worth describing in a nutshell (2—3 sentences) the main idea and workflow of the git submodules even if we referring to the git-scm.com?
Should probably specify that "setenv" is for tcsh and "export" is for bash, and also say that people should add these lines to their .bashrc or .tcshrc so they don't have to run them all the time.
What does extending `ActionView::Base` bring to the party? Presumably just needed for the helper methods `content_tag`, `link_to` and so on?
無駄な空行
(just to bring this convo online)

This is the only place where I'd say import * is acceptable. This package acts as a convenience/perma namespace for user-facing exports. When __all__ is defined in base, we're guaranteed to only export/import what we need, and we're not actually creating code relying on anything within this file.
Move the documentation from `loop/5` into this function instead, if the intention is to deprecate `loop/4` (the same applies to `sequence/4` as well).
I agree with @stof that this is not really an option in this context.
missing 'List' in there, I think: shouldBeAbleToListItemsInDomainForUser
This will be a lot easier to read if you only do the get chain once, sore it in a variable and use that variable.
I'd like `CommunityViewModel` to have `infoPopup` property, that contains html that is going to be displayed in map and when user hovers community link. This property can be populated on server side for simplicity (like resolving URLs by controller and action name)

So, for this particular situation binding will look like: `infoPopup: infoPopup`

And also the same property will be used when you are adding:

```js
Global.Map.addPolygon(self.gpsBounds, self.infoPopup);
```
As a rule of thumb, never use |safe. http://playdoh.readthedocs.org/en/latest/bestpractices.html#safe-considered-harmful

(though it looks like this was already here. Hmmmmm.
Since it is set, but you're checking against null, you should use empty()
Better yet, if it is possible keep the response as an object.
there was a wrong event added afterwards, i seem to have deleted too much, will readd it.
I f.e. need it in my gallery MOD to update images of deleted users, so they are guest images.
This line produces PHP warnings and a notice like:
<blockquote>[phpBB Debug] PHP Warning: in file [ROOT]/test.php on line 15: htmlspecialchars_decode() expects at most 2 parameters, 3 given
[phpBB Debug] PHP Warning: in file [ROOT]/includes/utf/utf_tools.php on line 217: Missing argument 2 for utf8_substr(), called in [ROOT]/test.php on line 15 and defined
[phpBB Debug] PHP Notice: in file [ROOT]/includes/utf/utf_tools.php on line 221: Undefined variable: offset</blockquote>

Additionally, function utf8_htmlspecialchars() should be used.
Moreover, there's function truncate_string() in includes/functions_content.php, which would be used here.
Also is there any reason, not to call user_add from includes/functions_user.php
Would you mind replacing diologue with dialogue or dialog while you're on it?
can this logic be simplified to path.unix:join('/', filepath)?
This error will only be emitted if there is a callback, which is probably maybe not what we want.
Probably #include <global.h> would be better.
looks like here should be "copied" , not "copyied" ;)
I'm also wiping the output directory before building, so that probably needs to change too.
do we need those paragraphs?
ha, good point.
libpath.join() ?
If you want to get logLevel to warn, remember to add `debug: true` as well.
Seems like extra overhead here. We have 3 args possible: msg, lvl, src. We should be able to avoid an apply() and just call directly.
I've been thinking about DF access. When trying to add data.table-style row access, I realized how many combinations there are. I think we should look at adding an index type. The index type would return something that would index Vectors. That might simplify all of the combinations. That way, the main definition for ref would be:

```jl
ref(df::AbstractDataFrame, r, c) = ref(df, colindex(r, df), rowindex(c, df))
ref(df::AbstractDataFrame, c) = ref(df, colindex(c, df))
```
Index methods would look something like this:

```jl
colindex(s::String, df::AbstractDataFrame) = df.colindex[s]   # this could be a Dict
colindex(i::Int, df::AbstractDataFrame) = i
```

I think pandas does something like this. I'll play around with this idea some more.
Single-line if blocks should be wrapped in curly braces
Change from float to int.
Adding in another ticket to change around the order in which everything is called. We will use username + password for the user the whole way through, so this is fine for now
Added back the [0]s for now. We can take the rest of the changes?
@johnstoecker would you mind double-checking this logic?
We might be interested in sharing this function in common resource, so that other modules which create lab order can just call this function (I implemented same code in OPD, so will put in util. (eventually screener will soon the same code.)

Is it the right time to work on shared store and model?
please link RAXAJSS-355 directly in the code
We don't need to save a user's searchQuery -- we can delete all references to searchquery here and below.
How about ```'{}({!r})'.format(self.__class__.__name__, self.ff_filename)```?
The formatting needs a tidy.
Typeo found.
Nitpick, but Thin is actually a server so that should be up top ;-)
Maybe we should also apply it in the "specialize" phase, if some CAReduce operations are introduced by later optimizations.
Alternatively is there a root issue I could solve? Perhaps the constant folding optimizations definition of what a constant is could be rewritten slightly.
again - prefer explicit comparison for non-bool types.
This method's actions are: the outcomes of this function are nothing but throw error or don't throw error?
Not 100% on this, but I think it would be safer to put the erase after the deletes.  It would be easiest to just put a spawned_children_.clear(); after the while loop does all the deletes.
Not sure what this docstring means :)
Add an empty line so doxygen knows where \brief ends.
we need escape it within  ,otherwise it's a string like '"~\xxx\xxx"\vundle'
@miketaylr, thought you might be interested in this...
There is now a function called check_if_raises_error() in the utilities module. This is used for the modified Student-t test. Eventually, we might want to make this function more fine-grained and make sure a particular exception is raised.
I suppose one should be 'numberOfCategories'?
Yes, that could happen. I'm not sure I want to spend time on working around that, since instantiation of the wrapper is something we do in our code where we can take not to do such a thing. We should document it, though.
My guess is that Mopidy will exit, and that you'll need to reconfigure it to not start the Spotify backend. Clearly something we should decide on how to handle before v0.9.
The "not throwing errors" but comes from near the beginning of the function `if 'firefox' not in ua.lower()`.

Supporting more browsers isn't a horrible idea, and it shouldn't be hard to hit the major ones.
Ditto no-no here.
Why the extra `class << self` here? Would it be ok to have `mecab_support?`a normal method of Hyperestraier?
Any chance of getting a stable release tagged? We're trying to avoid head-only formulae these days.
As I said, I think enabling it if `ARGV.debug?` would be fine.
Sorry, cut and paste between two computers just before pushing as killed me :(
In other projects we've defined a `DIALYZER_DEPS` var and used that on the command line, e.g. https://github.com/opscode/chef_wm/blob/master/Makefile#L38-L42

I like the optional build of ~/.dialyzer_plt. Although I would also like us to investigate building a top-level plt for dev-vm and maybe even for osx that we can just share. For a given version of Erlang, it should be stable, so why rebuild?
wouldn't `rule_number` equal `i` here anyway?
Le 20/12/2012 14:33, Philippe Lhoste a écrit :
>
> In fr/04-git-server/01-chapter4.markdown:
>
> > @@ -367,7 +367,7 @@ Si vous l'hébergez en interne et avez réglé le DNS pour faire pointer `gitser
> >  De cette manière, vous pouvez rapidement mettre en place un serveur Git en lecture/écriture pour une poignée de développeurs.
> >
> >  En précaution supplémentaire, vous pouvez simplement restreindre l'utilisateur 'git' à des actions Git avec un shell limité appelé `git-shell` qui est fourni avec Git.
> > -Si vous positionnez ce shell comme shell de login de l'utilisateur 'git', l'utilisateur git ne peut pas avoir de shell normal sur ce serveur.
> > +Si vous positionnez ce shell comme shell de login de l'utilisateur 'git', l'utilisateur Git ne peut pas avoir de shell normal sur ce serveur.
>
> C'est "git" au sens "nom d'utilisateur / de login"? OK, j'ajoute des 
> quotes, alors.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/progit/progit/pull/334/files#r2477180>.
>

En fait, j'ai déjà poussé ces corrections..
Yes, the keyword only affects the scope where it is written ;)
Good catch. This is intentional, but unhappy. It's a seam. I'm trying to promote HttpConnection to the public API, but I don't want to promote Transport as a public API class. My extremely lame workaround is to return 'Object' here to avoid leaking an implementation type.
Is there a way to tune perltidy to allow the original? That is, if the only argument to a function or method is a hash ref (or array ref, for that matter), have it open on the same line as the parens.
I generally prefer the former because it's consistent with core and hopefully means you don't have to guess what the parameters are when switching between commands (although currently I suppose you do need to guess)
I think if we remove the int constructor, it will break binary compatibility.  Can we leave it there, delegating to the long constructor?

Everything else looks good.
Style nit (trying to keep falkor clean and consistent)

`} else if (`
How about something like `viewDirective` instead of  `directiveAccessor`. I'm not really sure what the latter does, aside from the fact that it's going to generate an accessor, which to me seems like an implementation detail.
I'm not, though http://caniuse.com/#feat=css-sel3 suggests they do.

Either way, happily, Android 2.2 never shipped on a tablet.
These properties are basically the same ones you set right away if you're skipping the animation--seems like there's an opportunity to refactor the code (which would make the intent clearer in any case--if you're skipping the animation, then you're setting these end-state properties immediately, otherwise you're setting different properties first and then setting these properties on timeout).
Maybe it has something to do with https://github.com/adobe/brackets-shell/issues/61 ?
typo: porviders
I noticed this also retires quicksearch?

@cadorn @gjtorikian Note that these plugin changes may affect C9 local.
I see what you mean...I thought you were talking on the Lvc_Request class...you were just talking about the helpers that come along in AppController...
Sure, but the fact that the return value of a block is the last value computed is kind of the expected ruby way as well. Why is not expected that the event is passed down?

May be the non-intuitive part is the way we are forcing the user to handle the events. What about this solution instead?

### Explicitly pass the event down (returning it)

Either by returning it

```ruby
button.clicked do |event|
  # .. do something
  event
end
```

Or by the :continue

```ruby
button.clicked do |event|
  # .. do something
  :continue
end
```


### Generate a cancel event

```ruby
button.clicked do |event|
  # .. do something
  :cancel
end
```
### Event is not passed down

```ruby
button.clicked do |event|
  # .. do something
  # any other value (false, true, whatever)
end
```
I did not want to force the user to use the symbols. But the default behavior when not being explicit should be handle the event and not pass it down.

I will update the commits with this behavior.
I'm surprised it worked before but I guess we were just lucky with how flask is working. 
So instead of:

```
/users/balrogadmin/permissions//rules/:id
```
...it's now...
```
/users/balrogadmin/permissions/%2Frules%2F%3Aid
```

Which, although quite off-topic, just feels a lot safer.
In the strictest sense, this isn't a Butter module, correct? It doesn't have a startup sequence, isn't listed in the `/modules.js` file, etc. What's the real purpose of this file? It looks a little bit like it's supposed to do UI things for header functionality, but so does `src/ui/header/header.js`. Some explanation at the top would probably work fine, but perhaps it's worth considering arranging functions by their purpose and placing them in files which reflect that arrangement.
I'm not sure this is correct. It looks like this `while` loop only happens once or twice now, and moves on, calling `correctOverlapingTrackEvents` recursively. The `while` loop was meant to circumvent recursion. `nextTrack` should be updated and used in `_media.getNextTrack` to evaluate what happens after one instance of the loop occurs.

Am I reading this right?
"recover=1" most likely won't happen anymore.
After some thought, it seems like there are two mutually exclusive use-cases:

1. "I want to find out exactly what URL this string defines" — in this case, `parse_url` should return *exactly* what the URL defines, and `None` for everything it doesn't. For example, `parse_url("foo.com") should return `Url(scheme=None, host="foo.com", port=None, path=None, …)` (or maybe `path=""`… But I think `path=None` makes more sense, so it could be distinguished from `parse_url("foo.com/")`, where `path=""` would make sense).

2. "I want to use this string as if it was a URL" — in this case, `parse_url` should return sensible defaults for components that aren't defined. For example, `parse_url("foo.com")` should return `Url(scheme="http", host="foo.com", port=80, path="", …)` (or maybe it shouldn't assume HTTP?) and `parse_url("https://bar.com")` should return `Url(…, port=443, …)`.

My first instinct would be to make the function's signature: `parse_url(url, default_scheme=None)`. If `default_scheme` is defined, sensible default values are returned for everything… Otherwise `None` is returned for all the components which aren't explicitly defined.
Je pense pas que cette fonction soit nécessaire dans ce service.

En revanche une fonction "isBanned" prenant un UserInterface serait bien :).
Keep in mind this is a BuildRequires only if that affects the answer to the question.
Sleep menu should handle itself.

Can you move this and `SleepMenu` independently, like `app/system/js/sleepmenu/sleepmenu.js` ? Next pull req would do.
When you have bulleted lists like this, they have to have a blank line before and after the list for sphinx to format them properly.
yes ``$encoding`` musst be at the end
Cool, I must have fucked up testing it.

*Nikhil Goel* | Vanderbilt University, 2013 | Computer Engineering,
Economics**

LinkedIn <http://www.linkedin.com/in/ngoel1> |* ngoel36@gmail.com | ( (256)
503-9183 | NikhilGoel.me <http://nikhilgoel.me/>



On Sun, Dec 2, 2012 at 2:01 PM, Luke Steensen <notifications@github.com>wrote:

> In app/helpers/application_helper.rb:
>
> > @@ -1,2 +1,12 @@
> >  module ApplicationHelper
> > +  def avatar_url(user)
> > +    # if we have an image from OmniAuth, return that
> > +    user.avatar_url if user.avatar_url
> > +
> > +    # otherwise, try to get a Gravatar using the user's email address
> > +    # if no Gravatar (or email) exists, use the default image
> > +    default_url = "http://i.imgur.com/NgOB1.png"
> > +    gravatar_id = Digest::MD5::hexdigest(user.email).downcase
> > +    "http://gravatar.com/avatar/#{gravatar_id}.png?s=48&d=#{CGI.escape(default_url)}"
> > +  end
>
> No, that function would never return user.avatar_url. Ever. It's fine
> now, but you need to know that this is very obviously wrong.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bitcast/bitcast/pull/23/files#r2287969>.
>
>
I took that from the Wiki and was not very creative, but it describes what Bitcoin-Qt is. If you don't like is please suggest something better. I chose to put Bitcoin-Qt in front as this text is displayed e.g. when the app crashes and Windows displays the error dialog.
Rather move this to an #else under the #ifndef WIN32...
There should be spaces on either side of the `=>`.
So you can custom format any column type except date?
Yes we do need to call it for each rule. Consider this rules array for a particular field:

```
'field' => [
	'_isRequired' => 'create',
	'rule1' => [
		'rule' => 'rule1',
		'on' => 'update'
	],
	'rule2' => [
		'rule' => 'rule2',
		'on' => 'create'
	]
]
```
So when the function params `$isUpdate` is `false`, for the first rule "rule1" `checkRequired()` will return `false` since the rule is applicable only for updates but for "rule2" `checkRequired()` will return `true`.
oh, nice one :)
Same indent comments as above.
I noticed this existing line of code, which is not in this pull request, which I think isn't idea. I think you should be querying for the subgroups you want, not querying for all subgroups and then checking in ruby if you can show them. I believe that this is possible to do with cancan.
Unfortunately 'TerminalInteractiveShell' object has no attribute 'log', so I'm unsure, how to get access to a logger in this file.
Changed in the other file through.

How is it possible to log from a TerminalInteractiveShell object?
above block, if the mode does not start with `magic_`just apply it
Actually using JSV now?
I just merged [bug 786195](https://bugzilla.mozilla.org/show_bug.cgi?id=786195) that removes some copy of this function. Could you use the version in `global.js`?
Done, will be gone when I update the pull request
This should be `tech.js`, not `tech.less`
It really should not, was probably over zealous here.
note that create_django_user does a whole pile of saves, next two lines are irrelevant

https://github.com/mozilla/zamboni/blob/master/apps/users/models.py#L373
This should be `if ( fileSystem.fileExists( file.getAbsolutePath() ) )`
it will not pass jslint already because of hoisting things ...
It's a channel used right up there in signal.Notify can be changed, but seems clear enough
did you saw my previous comment about ``iterable`` ? It would require bumping the Twig requirement to 1.7+ but this is not an issue at all as Twig is fully BC (and already in 1.9)
Not really, this is for shared fixtures.
you execute the whole same code twice maybe factorize it inside a loop or a method ?
relevant ;)
Thanks, I added :)
I can see both in the symfony codebase so I guess there is no rule for that yet (or that it doesn't really matter).
don't know, might be some sort of merge thing.
yes, you are right it does seem to be convention... probly born out of Xcode generated code.  There seems to be some disagreement as to whether this saves you anything. see http://stackoverflow.com/questions/4686526/why-is-the-static-keyword-used-in-uitableviewcell-identifiers

My understanding is that the compiler will place it in the static data section as opposed to the stack, but will still make the assignment each time you enter the function, gaining you little. 

But as this is convention and essentially existing code, i wont beleaguer the point.  leave the statics be : )
I like the rename.

Sent from my iPhone

On Dec 6, 2012, at 4:40 PM, Dan Croak <notifications@github.com> wrote:

In spec/models/group_private_messenger_spec.rb:

> +
> +    help_out_text = UserPrivateMessenger.new(invitation, sender).get_help_out_text
> +
> +    help_out_text.should == "out #{invitation.event.owner.name}"
> +  end
> +
> +  it 'return me out when the recipient is the owner' do
> +    invitation = build_stubbed(:invitation)
> +    sender = build_stubbed(:user)
> +    invitation.invitee = invitation.event.owner
> +
> +    help_out_text =  UserPrivateMessenger.new(invitation, sender).get_help_out_text
> +
> +    help_out_text.should == 'me out'
> +  end
> +end

It might help to rename PrivateMessage to something like
PrivateMessageTemplate. It has a very clear responsibility right now of
gluing the current class' instance variables to an ERb template in
app/private_messages.

This test doesn't test that work. It tests the help_out_test logic, which
nicely cohesive with a user private message.

—
Reply to this email directly or view it on
GitHub<https://github.com/yammer/sched.do/pull/238/files#r2343695>.
Stubbing an old boundary. `User` doesn't depend on `UserMailer` any more. That's been abstracted under the `UserMailerFacade`.
Might be moot. The tag should be removed in all stories, as per this card:
https://trello.com/card/remove-the-tag-line-from-the-bottom-of-all-the-yammer-posts-this-poll-was-sent-using-sched-do-create-your-own-polls-for-free-at-https-www-sched-do/50b3ffc4c7cd26072c00ebfd/26


On Thu, Dec 6, 2012 at 11:16 AM, Dan Croak <notifications@github.com> wrote:

> In app/views/user_mailer/_footer.text.erb:
>
> > @@ -0,0 +1 @@
> > +*Did you know you can send your own polls for free? Use sched.do to plan events easily and collect feedback fast on virtually any topic. Learn more at https://www.sched.do.
>
> Is the leading * intentional?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/yammer/sched.do/pull/240/files#r2339671>.
>
>



-- 
@adarshp <http://twitter.com/adarshp>
developer at thoughtbot, inc <http://www.thoughtbot.com>.
313.454.1515 (m)
这里的注释和实际参数不一致，是不是有typo error？
Шикарная миграция ;)
// JOL: 2012/11/21: I left these lines in comments because I am not
  // sure yet if my correction above has no other side effects.
  //
Changed 1d8fd7a
I'm not certain we can do reverse look up.
May we leave this to take shape once we start introducing new srs strings, at a later date?
Also, since this and the following else clause cover the "view NOT generated" conditional, perhaps it makes sense to restructure:

```
if (count(...)) {
  // we have a view
} else {
  // we dont' have a view
  if (in_array(...)) {
    // flowplayer supports the file type
  } else {
    // flowplayer doesn't support the file type
  }
}
```
Ah, I see you added "ajp" to the -ha configs for 7.1.1.
How about...

```js
// to disable (for autocomplete)
aria: false 
// for selectmenu
aria: { role: "listbox", items: "option" }
// as default
aria: { role: "menu", items: "menuitem" }
```
If I'm mapping this comment correctly, you're referring to the option.of.pageX/Y calls, which we can't replace, as they access event properties.
You know the code better than me, if you think its required, ill add it. What do you think?
"in a way don't like."

something's missing here ;)
тут не надо. Если есть #navPath, то надо optional, а если нет то не надо
nit: Might be better to use menu.classList.add here to avoid accidentally overwriting other classes added elsewhere in the future.
ok, the anonymous function could be written before and the code would be 

currentPage.onReArranged = dispatchMouseMoveEvent; or the name as you want...
Nit: Application Storage
You should use a single lock here so that all values are set in one transaction and no other request can interfere.
pseudo_evt -> pseudoEvt
s/utilisez/utiliser/
according to my comment above this should be doc.body. The same applies to all the doc() calls within the code
-> `this.notifySuccess.bind(this)` and use `this` instead of `UssdManager` in the `notifySucess` function
`self.defaultAdapter = req.result;`
@timdream 
I remove the flag "isUnderneathCallScreen".
Because we don't notify user in the case.
So, it will not receive mozinterruptbegin event.
The flag is useless...

Please review my change again.
1. Remove the flag "isUnderneathCallScreen" in init() function.
2. Remove useless logic here.
tabs and spaces spaces and tabs =( my bad 

This should fix it: @79b323c
No need to change but one pattern I've been using is:

```
if self.request.REQUEST.get('_format', 'html') == 'select2':
```

Just a bit simpler and deals with the default case.
You should use `assertArrayHasKey` and/or `assertFalse` instead
Do you think that documentation should eventually go in the Chef broker wiki page? That's one reason I added the configuration option for that script--you could elect to set up a local mirror, rather than relying on the default at https://www.opscode.com/chef/install.sh
no time here?
Why is this needed here? user properties come from the hapi consumer back to the app and not used by hapi beyond that.
The kind of solution you want to avoid is exactly why in my final blog post I rant about ensuring all UI elements are linked to the instance. 

From experience with the Help->About pop-up boxes, it is safe to link things to the application instance. 
It's a matter of doing as zxiiro said. 

I left that ROADBLOCK comment because it is a real roadblock for a tester. In real environments, a developer will be testing their own code and as such would be responsible to fix stuff like this themselves or risk leaving it untested. 

As I wanted to focus on breadth testing, I left things like this alone.
What you changed.
The main reason I avoided using JS is that the mappings of measurement-type-to-parameters are in the python logic, so it seemed easier to think about/manage if all the code was in the same language. Plus, I'm terrible at JS so this was the easiest to implement. I realized I can simplify the logic so there's just one if/else block, so hopefully this will look less complicated as a result.
I'll alphabetize at the end to avoid nasty merge conflicts.
This code is used to copy the header files from the source directory to the binary directory when the "INSTALL" project is run. It makes it possible to use HPX with only a link to the binary root.
Regardless, it's premature optimization which isn't something to sacrifice for readability.
Fair enough, they can be annoying.
Collection#sort will sort them by priority.
shouldn't we test whether `popd` also successfully changed `pwd`?
doh. yup.
I have no idea, i didnt write that part of the code :)
I haven't really looked through the stuff in templates/.. as I copied it directly from the mochajs repository. The unholy combination of mochajs and phantomjs just needs a few more batteries to work apparently.
node_data.cloud.public_ipv4 would at least be cross-cloud compatible, but its kind of moot IMO. Whats the use case?
fair enough, and null is certainly more consistent with all other code in composer
It should be 
```
return HttpResponseRedirect(reverse('checkout_payment'))
Really? I thought its merely a WinRT API compatible version of the basic sqlite API. Not a component. A component consist of a dll and a md file.
The cleanUp method will disconnect the child tuple, so it won't be possible to iterate its siblings on the parent.
Might something similar have been done in other nodes?
Because purple.found not yet implemented.
@rlane : Yes , the test needs to verify that the packets are not received on any of the dataplane ports nor on the control plane (in other words , they should be dropped). We could have verified it with ports_stats (rx_dropped counter). But, when I was testing it that way with physical switches --- some of them were not incrementing counters properly.

Now, since this test is not verifying the counters itself. I though this was a better way to test the test-case.
По-моему, оно будет работать и без этого
Yeah that sounds good
`module.id` will be undefined here as we only pass `uri` here:
https://github.com/Gozala/addon-sdk/blob/f0d33ffc6c72076e952ae97e4658f8152a3d6f47/packages/api-utils/lib/cuddlefish.js#L11
In any case, as we don't really know what will be the final value of module.id, it may be safier to hardcode its value here in anycase.
@warner, @fmarier - Can you chime in here?
I changed off of the $'s to dom.* calls. Thanks for pointing this out.
How does j sound?  k is already used elsewhere consistently for dictionary keys.
Don't reference lines because those will change over time and will make the comment invalid.
Always use static to allow subclasses to override the static methods
I'm not sure if we should move the parsing of the URI to the Request object and just give it the detected route.
CS: no need for this extra line.
I presume you mean <code>Application.find</code>?  You are probably right, I'll give that a try.  I guess I had just assumed that there was a reason that the original code was duplicating that logic.  I'll check it out.
Thanks for clarifying that.  I am not going to respond to everything you answered like this, because too much noise, so assume if I didn't say anything I accepted your comment. :)
Perhaps this should use the POSIX standard `COLUMNS` environment variable to allow users actual control over the rendering width independent of the physical width of their terminal?  Also, more efficient and all.
The `NotImplementedError` is there because `client_cert()` isn't implemented for Mongrel servers, although perhaps stubbing the method would be better than catching the exception here. The `ArgumentError` is caught since the cert could come back as `nil`, making the certificate creation fail -- which doesn't seem like an app-killing kind of error. In hindsight, this is definitely a case of exception-handling-as-control-structure; I'll clean it up when pulling it all out of this method.
I think we need a new testing page for this information (maybe testing.rst for now). We should show:

1. how to run the test suite manually
2. how to run the test suite with coverage
3. how to use tox to test multiple environments

Something along the lines of https://docs.djangoproject.com/en/1.3/internals/contributing/#running-the-unit-tests.
I agree that no default is the right first step.

re: getting a handle on the original, I appreciate that `stub_const` can provide the right thing, but it still feels awkward to me to get the original from that method. I'm curious what others might think. Anybody else listening to this besides @myronmarston, @alindeman and @justinko?
This is kinda cryptic. I'd prefer to see the following.

```ruby
if Rubinius::ENDIAN == :little # should this just be LITTLE_ENDIAN since it was just defined?
  BYTE_ORDER = LITTLE_ENDIAN
else
  BYTE_ORDER = BIG_ENDIAN
end
```
If I had to guess, it's because the version number is used in directory names for extensions (`RbConfig::CONFIG['sitearchdir']`).  In OpenBSD's ruby ports, we remove the version number as otherwise it uses separate directories every time you upgrade, which can cause problems and creates more work for the packagers.
I think you can just add `&& filereadable(".zeus.sock")` and it will only add it if zeus is actualy running.
use Logger.log(Level.INFO) instead of println
This seems like a debug log. Please add a doc-level comment.
I think that sformat should go to own variable. This way it is not much readable.
修正してください。
As explained on #zftalk.2 the output of that $sql will look something like this: INSERT INTO tablename ('key') VALUES (':key') and the mapping between keys and values will be done when executing the statement.
This should not allow null anymore, no?
Please, mark the test as Incomplete. We are using Skipped when a third party dependency cannot be satisfied.
Why is this functionality removed?
Spacing inconsistency
Yeah. or the other version - restore the nutriton to the old one again.
Should radius be changed to yield here also? (new to github sorry if this is not proper)
this is pending as the api web context is a port from common context we are using to make this happen

@stof do you think we can PR this class to common contexts?
I think I missed the is null bits in my first look down there. Description is a required element but it could be empty. Let me update...
Title tai palikai neišversta :)
-> `Batman  • TodoMVC`
Yup, you're right, what I meant was this:

```js
var tasks = ["a","b","c"];
for ( var i = tasks.length; i > 0; ) {
    console.log( tasks[ --i ], i );
}
```

But still, I think the while loop would be even better.
`$(function() {`
Why do you need to change the margin-top for 980px screen resolution? there might be an other solution, and at least, show me the problem so that I can help you directly :)
I would recommend that you test the navigation (at least once) all the way from the homepage to here.
FilteredJSON ?
Is this correct, or does this scope return the comments posted by a given user?  If that's the case, this can be removed in favor of `user.comments`.
I would come at these from the resource you want to return -- in this instance, an API like `Article.voted_on_by(current_user)` seems like a good idea.  Take a look at using [`joins`](http://guides.rubyonrails.org/active_record_querying.html#joining-tables) to get the data you need without doing N+1 queries.
snew is a separate file, the only reason it exists is so the user is told they need to login before they can submit, but I can do this with a flash message instead and save a lot of code
I would make the logging destination configurable through the `DataImport` module. So that can adjust it to write to any stream. Also I would be a nice start to have a simple wrapper around the logger, which forwards the messages to STDOUT when they are important (fatal, error, warn) The rest of the messages is only present in the logging-stream.
Purely out of curiosity: what's the functional difference here? (I should probably just go finish reading Exceptional Ruby.)
Fwiw, I would have used `<dl>`s here; less HTML and arguably more semantic.
Please re-add the deleted blank line (2 required)
Hmm, I got rid of the space and it does appear just fine. Space be zapped now!
Same thing as the two previous comments regarding the link for "contact Support"
Again, see if you can put this in a template instead.
Can you check that this continues to work when we use collectstatic and django_compressor?
I don't remember the details but I remember there being some surprises when going debug=false with another django_compressor app. 
We can test together.
That's cool. Using `<<` is less declarative and more procedural in my mind. Feels like it detracts from the readability of this example. Your example code is going to be criticized more than the actual library code because it's partially documentation for the library. So devs will need to be able to grok it quickly. They might even refer to this code more often than the actual library code.
I don't think this should be necessary in theory. Maybe you need to use namespaces in your XPaths?
Yes, the valuesSetableToString() are used for creating the dialog boxes when you want to set the episode status. It was kinda C hackish lol.

We should add a boolean like you said. I can add it now (I have it open) or you can just keep making changes and send me a pull when you think your done. I don't know what to call the boolean though. "setable"? idk.
I don't understand what's going on here. Could you explain it, please?
Generally the title the same-ish as the exercise's file name? See my other comment on this...
Can all of this block go into the if old_registery_office_tag block? we don't need to update artefacts unnecessarily or loop through them if the old tag is gone.
Delete the "really", sounds a bit desperate xD
@m4tthumphrey @daneden Just tested and yes, current version does support both. Though for backwards compatibility for people running older versions (not sure of the metrics but I'm sure they would exist) shouldn't we use the hyphenated version?
I haven't tried it, but it doesn't look like this should work. Shouldn't this class be named FourView?
IMO, you need to are more methods here. 
Each time I add a new feature in the schema, I add this API:

* hasOptions()
* hasOption($option)
* getOptions()
* getOption($option)
* setOptions(array $options)
* setOption($option, $value)

You need to add unit test accordingly in ``AbstractAssetTest``.
а почему тут get, а там нет? надо как-то единообразно
you could also do this :-) but i guess it makes no real difference.

    foreach ($this as $event) {
        if ($event->getDate() >= $date) return;
    }
Is there a reason you're ussing `==` when comparing to `null`?
I stand corrected.. 

On Mar 26, 2012, at 1:13 PM, Cees Moerman wrote:

>>     roles:
>>       superuser: Beheerder
>> -      refinery: Refinery gebruiker
>> +      refinery: Refinery-gebruiker
> 
> Sorry, I don't agree. Compounds with proper nouns [should also be written as a single word][1], with an optional hyphen for readability. So it's _Refinery-gebruiker_, just like _Facebook-profiel_, _Albert Heijn-filiaal_, _Hemaworst_.
> 
> [1]: http://www.onzetaal.nl/taaladvies/advies/rabobankrekening-rabobank-rekening-rabobank-rekening "Rabobankrekening / Rabobank-rekening / Rabobank rekening, language advisory, Society for our Language / Genootschap Onze Taal"
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/resolve/refinerycms/pull/1483/files#r602329
Fixed this in latest commit, please review
The locale, timezone (and visibility) should probably also not be exposed for private users.
Does it make sense for updateFileBody to return a revision?
Can you do a test that checks that private users their information gets hidden correctly?
If a request comes in asking for a file that is not in the cache, it will:
 - read it
 - send it back to the user immediately
 - cache it async
There should be a test to verify permissions for comment creation. There should be a test to verify validation as well (empty body, empty contentId, non-existing contentId, etc.)
`reply(msg)` is just a shorthand for `sender ! msg`, that's all.
We don't really need the 'object' attribute.