labofsahil/github-event-dataset-2012 huggingface dataset:
It's a functionally equivalent clone, minus performance.   At this point, our clone is exposed, so we have to have it.   However, a java clone is not exposed.   See the ticket for more discussion.

 Right now I'm going for correct behavior first.   Will cloning a *wrapped* tree set in a hash set cause functional differences from this api?  I think not.
Yes, number, not nuber :) If there are more nodes, a "X classes/traits" node will appear and the tooltip will contain the names. Example: https://scala-webapps.epfl.ch/jenkins/view/scaladoc/job/scaladoc-diagram-nightly/ws/build/scaladoc/library/index.html#scala.Serializable@inheritance-diagram
Unrelated to this commit - strictly speaking, I'm not even sure if we even allowed to change the serialization between minor versions - this should be a binary compatibility breakage.
*.cmd
What does this attempt to do? You can do something like ``isinstance(Tr(A), Trace)``, if that's what you intended.
It seems there is no agreement in the mathematical world on this. It might be helpful to have both x*self*~x and ~x*self*x as functions. Anyway, as long as you're consistent with the type of conjugation being used you should get the same results in the end
Perhaps the test will be more consistent, if you create this file "on the fly", using "runtime" directory.
I think it will be OK. Better than having bad-named methods.
Did you try out different colors on the train?
I don't know why, the pom says that I must add a boolean inside the <gen> parameters then it creates the folder with what i put inside it...
Am 13.06.2012 um 13:15 schrieb Daniel Nouri:

>> +import os
>> +from fanstatic import Group, Library, Resource
>> +from js.bootstrap import bootstrap_js
>> +from js.bootstrap import bootstrap_responsive_css
>> +from js.jquery import jquery
>> +from js.jquery_timepicker_addon import timepicker
>> +from js.jqueryui_tagit import tagit
>> +
>> +# deform doesn't provide fanstatic resources itself
>> +lib_deform = Library("deform", os.sep.join((os.path.dirname(deform.__file__), "static")))
>> +deform_js = Resource(lib_deform, "scripts/deform.js")
>> +jquery_form_js = Resource(lib_deform, "scripts/jquery.form.js", depends=[jquery, ])
>> +
>> +# deform_bootstrap doesn't provide fanstatic resources itself
>> +# this should be moved to deform_bootstrap in the future
>> +lib_deform_bootstrap = Library("deform_bootstrap", os.sep.join((os.path.dirname(deform_bootstrap.__file__), "static")))
> 
> Also, can we agree that 79 characters per line is a good idea? :o)

Hm… It only applies to your split screen setup, but we can agree nevertheless… ;)
wouldnt it be better to just do

``` php
list($controller, $action) = parent::createController();

if ($controller instanceof AbstractController) {
    $controller->setApplication($this->app);
}

return array($controller, $action);
```
Since I assume TreeSet correctly implements an ordered way of iterating that should indeed not be a problem. it's a bit of an artifact from when using Collection
Let's talk about the nil contraint
Isn't ````old_setup.destroy_if_unattached```` already going to be done when the question is saved b/c question.rb has ````after_destroy :destroy_childless_question_setup````?

Why did you pull the ````kopy.question_setup = self.question_setup.content_copy if !self.question_setup_id.nil?```` code out of ````init_copy````?
Will change the var; partial functions are displaying/hiding the textbox. Don't think I can use the toggle method here because one could click wrong then right and have the textbox displayed and then hidden again when we want it to only be displayed on the clicking of the partial credit radiobutton.
Hey,  you reverted my changes here :(. Was that an accident or did I break something?
angle brackets rather than curly brackets.
pep8: need another blank line between class definitions
for consistency, use single instead of double quotes. feel free to merge after updating!
Is anyone actually using this reader? Can we take it out, if all callsites use #loaded_recipe?
OK I guess, somewhat confusing.
I'm not sure about needing to cast to integer here. Sure it doesn't hurt, but in what case is something directly from a not null integer field in the database going to be any type of value besides an integer?
Agree with @naderman.
Same comment here about wrapping the file to pass jQuery object for $ and domcontentloaded.
no @ api
Please don't use globals in new code where avoidable. This should either be passed to the function or be stored in the constructor.
The table prefix in tests is always phpbb_ so no need to use a variable here, just hardcode phpbb_extension_groups to make it easier to read please.
+1 I wish I had known about that before.
removed in c93dca1
Le sterg. Era un experiment care am uitat sa-l sterg. My bad.
thx, should it be StashMultiHandler or MultiHandler ?
In this case it makes no difference, and I guess I opted for the word-y one by default. I'm not too sure why, but I'm happy with either where there's no change in meaning.
`next if input.empty?` also works.
this is fine for now, but i'd like to see us adopt a pattern that doesn't create objects that might not be necessary. so anywhere we could check for null/undefined instead of creating objects which affect memory consumption we should.
If we're deleting the hack, there's no need to continue talking about it.  Perhaps a comment like this would be better:

```javascript
// We need to ignoreRegistered so that we get a full list of dependencies (including those that might
// have happened to be loaded by some other code).
```
Can zombies age? Or are they just babies forever?
Deze logica kan je ook prima in je view model doen?
And does it also work if you remove this field from the template?
Looks like we're set. JQuery is handling the urlencode.
Wonder if we should throw in a couple of more test cases that aren't English based. Perhaps pick a couple that are not so equal.. Something like Russian, Asian etc
the indenting is off
You should probably respect makeFlags, makeFlagsArray, buildFlags{,Array}(when building), and installFlags{,Array}(when installing)
shouldn't have this, which allows the "red line" to appear below saying it's empty if you click on these readOnly fields
rather than capturing this in a var, can you just make it a helper method inside of the Application definition (below line 33)?
Like I mentioned in the review on ur branch, uuid should be char(38)
Rest all looks fine. Can you make that change and send a pull request
We can more be more explicit and say that the lengths are unequal rather than incompatible. Saying they are incompatible may not help the user understand the problem (i.e. they are not equal).
So, I looked at it and I understand now. This is because this Op has 2 outputs, and only the gradient w.r.t. one of them is None.
Basically, this means that any Op with multiple outputs should check for None gradients in its ``grad()`` method, which I didn't know. It seems a bit cumbersome but I don't see an easy way around it.
Bottom line: I'm good with your fix. I'd just like the test to be a bit more explicit as to what it's testing exactly...
Add them, but they all should return -1 because there is key found for each of them. This is the definition of rankAsc() and rankUpper(), comments are also added for them. Thanks.
If (as I suspect) m_unionType is only ever set from the loadFromJSON code, please eliminate the unused setter function.
This block is older code that came from AdHoc.executePlanFragment(). I'll fix the 00. You're right that that it could be written better as
```if (dependencies.size() == 1) {
    inputDepId = dependencies.keySet().next();
}```
Same as with get_next_free_hostname, don't include status and message. Simply return the IP address.
didn't you just call this same method at line 216 ?
This needs to be `\DateTime`
Agreed: where "will need some" needs to be a new issue.
This looks like it's the same for every backend, why is this not just in the field?
This check is now done earlier, in the Option.contribute_to_class method
Do you really need this public property ? I don't see it used anywhere
Remove byte_size, match on <<>>, <<Body:Length/binary, Rest/binary>> directly instead?
It seems that there is the exact same snippet of code in the classical calculator. Could you factor out these lines somewhere (in models.py or in hazard/general.py)?
This corresponds to the first shared example defined. It should match its number of arguments.
Also, it's probably better to use AC_IFELSE or similar to generate the if statements, so that we don't impose requirements on the shell used
Because some IDE will format code. such as change

filter: alpha(opacity=10)

to

filter: alpha(opacity = 10)

then error occurs, see tc.
Yeah. I have a ticket to do just that in 1.9.

Mike Sherov
Lead Programmer
SNAP Interactive, Inc.
Ticker: STVI.OB

Sent Via Mobile: Please excuse my grammar, tone, and punctuation. My
thumbs can't create flowery prose.

On Jul 13, 2012, at 5:21 PM, Corey Frang
<reply@reply.github.com>
wrote:

>> @@ -426,6 +426,17 @@ Tween.propHooks = {
>>    }
>> };
>>
>> +// Remove in 2.0 - this supports IE8's panic based approach
>
> Sounds like an amazing idea, likely a @mikesherov project?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jquery/jquery/pull/861/files#r1162418
I suppose I can do `name[0]`. I have no preference, and it's a win on bytes.
What about when `method` is defined in `ajaxSettings`? You'd probably better do some magic on `s` or maybe even in `ajaxSetup`.
Using these imports?
You can get the two parallel lines for the norm operator via `\|` (as opposed to `||`).
Removed the lower and btrim.
This setting of ```functionInformation``` is missing if the call is set returning function.
"We use 4 spaces for indentation and no tabs."
Let's remove trailing tabs and white spaces.
Since this was part of the changes I made to sample data, I am just nixing it altogether.
This index will give problems with some mysql installations, which limit the keysize to 1000byte or ~333 utf8 characters
What does this magic # do?
Happy to leave it as is now that I understand it better.
> Let's leave it like this for now, and once we add the information to the wiki, we can simplify the README and link to the proper wiki page.  ¨

Sounds like a good solution.

I prefer not keeping documentation like this in the source code, because ideally only contributors will be reading through it. Those trying to learn how to use PRAW and the Oauth part of it, will be looking at the wiki
Great spot that one..
Because those fields are currently sitting on the site, and previously had nothing like num_default, and "" would become None
I'm not sure a separte register method is needed. How about the constructor receiving the contracts? Like middlewares and extension do. See `scrapy.middleware` module.
Is there any value added to including this statement?  These are a little hard to spot when scanning the starcheck output.
I think there's a better way to structure this code that allows us to use codegen rather than reflection in a few cases. Instead of this code in the `if` clause, use this instead:

    seedAdapters[s++] = plugin.getModuleAdapter((Class<?>) module, null);

The arguments to getModuleAdapter are the class we want, and optionally an instance of that class. Or at least that's what they used to be before the big plugin refactor. That way we can call getModuleAdapter when we have a module instance (as passed to ObjectGraph.create) and also when we don't (as in an includes clause of `@Module`).

This way we end up using ModuleAdapter#newModule to create instances which may end up calling codegen.
I don't think the logging adds anything to the test, does it? IMHO logging is just one example of how to use this new rule.
Evan, 
this needs to be when _gaq does not exist.   The only case when this should be true is when we are testing ios or android in mulberry serve.
Отключится – I think should be ‘Отключиться’
destroy now calls hide()
I'd like a comment here to remind the reader that these latter functions simply implement the other half of the `Replaceable` IDL attribute
renommer en views/google.html.twig
/cc @rtomayko how's this looking?
What are those empty lines?
This method is pretty big, and some of the things it does (like figuring out the types of each change) seem like they belong in the History class or somewhere else more general purpose. What do you think?
Ah, that's much nicer
Please put `false` as the last param here.
I'm not sure about this - In the danish locale I haven't translated this, because it's a "name". I'd like to know if translators are to translate the name, or leave it as "PDF Viewer"? @yurydelendik
I removed this commit now. My final goal was to write test to clean a bit the basecode. This part should wait for another pull request. Sorry to be a bit too hasty on this one.
You're right.  This was done for convenience.  Chances are this will index into a token.  Like the previous comment, I don't expect this to matter much since we'll train the model.
Why is it initialized as 1000? I think it should relate to 'worker_connections';
这里是否应该保证 file.data 最后以 \0 结尾?

ngx_memcpy(file.data, name->data, name->len + 1);
Tohle potřebuje plurál.
For me we must be logged to report a message and for add a messages.

Some forum allow unlogged users to add messages but for me it's not a good idea. We can have probleme when a suscribe user want to add message but he was not logged...

For report, I think it's not a good idea too because unlogged users can report a lot of message and doing many spam just for playing and not for necessity
Hmm we do have this in all our man pages, I'd stick with this. Why not to have it there? Other projects do the same...
It is mouseup callback and we are checking if the target element is inside #switcherContainer.
It contains a lot of elements so we would need to check every single one of them and that is not a good idea.
You are right, sorry I didn't realize.
might wanna add select("repositories.pulp_id")
Create will need two contexts, one for if creation was successful and one if not (for example if trying to create a unit with a name that is already taken)
I agree - one method, even at the expense of computation. I researched this and the GIS community recommended Vicenty, so that would be my One and Only implementation. If someone knows enough about the differences and caveats between them, it's a line or two of code to write the method themselves.
Fixed in 47cc9c5.
For module-level "constants" that are not public API I frequently don't bother to capitalize them either--no reason to draw attention to them. But I don't think there's any hard or fast rule about that.
I understand that all the coordinate systems we're currently practically considering are variations on spherical coordinates. But I still don't see why `SphericalCoordinatesBase` can't just be a subclass of `Coordinate`. There's no reason they can't both be ABCs or that one ABC can't subclass another.
Alright, that represents a majority, so I'll go ahead and change `string` to `format` and use the default for `__str__`.  If @demitri or @wkerzendorf strenuously object to this, I'd suggest you make a separate comment below or on the *new* diff, because this thread will be hidden as an "outdated" diff once I push up the changes.
I was very very careful :)
"Signatures" is fine with me. "Contracts" implies something more, like advanced  transactions.
I meant more about when someone is appending conditions to an existing string.  Previously a string ending in `&` would work.  Now that will result in `&&` so people upgrading have to go around and make sure all their string query strings do not end in `&` when they append more conditions onto them.
Yet :) it will look like Psr0ClassReflection. Same for Psr0MethodReflection.
I think that there should be a comment referring to the external document.
Done: http://repository.excilys.com/index.html#nexus-search;quick~akka-testkit

I've been tempted to play with testkit for a long time now, but couldn't find time though...
What about:

git mv
commit
edit edit
commit

?


  Jesse Reynolds
  m: +61 414 669 790

On 08/11/2012, at 1:14 PM, Ali Graham <notifications@github.com> wrote:

> In lib/flapjack/api.rb:
> 
> > @@ -1,388 +0,0 @@
> On 8/11/12 12:57 PM, Jesse Reynolds wrote: In lib/flapjack/api.rb: > @@ -1,388 +0,0 @@ It's a pity we're losing history here, i guess because 'git mv' was not used?
> git mv only preserves history if you mv without changing, which is impossible to do without breaking builds. You can use --follow in git log, but that's not ideal either.
> —
> Reply to this email directly or view it on GitHub.
>
Result is already a pointer, so you're passing a pointer to a pointer here. I'm guessing this works in a sane fashion; maybe I should adopt it elsewhere.
I haven't checked to see if this is the case or not, but if `WorkingCopyHasUnstagedOrUncommitedChanges` is called inside of a `WithTemporaryIndex` call, then this won't work right (ie. it looks at the default index instead of the temporary one).
OK, give it a shot again.

On Sun, Aug 5, 2012 at 12:02 PM, Brian Granger <ellisonbg@gmail.com> wrote:
> Ah crap, I will fix that...
>
> On Sun, Aug 5, 2012 at 12:01 PM, Bussonnier Matthias
> <reply@reply.github.com>
> wrote:
>>> +      }
>>> +     ],
>>> +     "prompt_number": 2
>>> +    },
>>> +    {
>>> +     "cell_type": "markdown",
>>> +     "metadata": {},
>>> +     "source": [
>>> +      "Or these URLS can be relative to the Notebooks working directory:"
>>> +     ]
>>> +    },
>>> +    {
>>> +     "cell_type": "code",
>>> +     "collapsed": false,
>>> +     "input": [
>>> +      "Mesh('files/data/smallsurface.vtk', opacity=0.7, magicmode=True, bgcolor='#FFF')"
>>
>> why `data/?`  I does not work with data for me.
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/ipython/ipython/pull/2258/files#r1308450
>
>
>
> --
> Brian E. Granger
> Cal Poly State University, San Luis Obispo
> bgranger@calpoly.edu and ellisonbg@gmail.com



-- 
Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com
If I understand things correctly, decoupling the notebook and kernel is effectively what we did with the Sage Cell server (any webpage can embed a single cell and execute code as part of that single cell, and in fact, any webpage can just call the aleph.sagemath.org/service/ URL to do arbitrary computations without even embedding any cells into the webpage).  It would be *great* if IPython had that sort of thing.
It's in both because I didn't know which one to choose.  If there were no other commands, `locate profile foo` makes more sense because it's an actual sentence.  But we already have an `ipython profile` subtree of commands, so it seemed weird for it to not be there.  I will add `ipython locate profile foo` to the `ipython profile` help, if you think that's best, and remove the `ipython profile locate` entry point.
We recently had a long thread (I can't remember exactly where, @minrk  might) about years in copyright notices, and figured the most sensible thing would be to just put the initial year when the file is created and leave it at that.  Otherwise over time we're finding ourselves with a combination of busywork to update a bunch of files, and inevitably a random smattering of years that don't really make any sense.
it isn't a set, it is a map.  extend ForwardingMap<String, String> for convenience and consider renaming
"Sign in as a developer"
Hmm, yes I was considering the same thing... I feel like _foo conveys "don't touch this or you will f' yourself over".
Its definitely not  "private" either though. It makes a lot of sense to un-underscore them for consistency with other classes.

What is your stance on this in general? Should I stay away from _ prefixes?
`origin` here should probably be `remote->name`, shouldn't it?
Any way to make this based on the DEV or DEBUG settings? Perhaps if you made a view like you did for the JS.
was curios what the php_url bit was about
HTML should be indented 2 spaces.
Needs ms as the second argument.
This is OSX-specific. Probably want to make a note of that.
Good point. I'll nix that.
LESS is cool!
challenge accepted. i'll try :)
I made a change there, and used the ``datetimeutil.date_to_string`` function that I changed a bit to fully respect ISO 8601. It's ugly but it's the best I can do, I think. Python's ``datetime.strftime`` functions are useless, and ``isodate`` doesn't seem to do a better job with timezones.
``for one``
`l` and `1` so near each other might be unfortunate for those with a bad font. :)
one class per file
Will fix, accidental typo :)
any advantage of making this private (we could avoid a BC break here) ?
Shouldn't it set `$this->sorted = true;` after sorting?!
Ok, so I checked it. There is indeed a circular dependency. It is not detected at compile time ( @schmittjoh this looks like a bug) and it does not occur everytime.
As Twig uses setter injection for the extensions, the twig service is already registered before building the extensions, and so can be retrieved by the constructor of the engine when building it.
However, if you retrieve the renderer or the engine before Twig, you will need to get the Twig service before registering the engine in the build services (the constructor arguments are needed before calling the constructor) and this will trigger an exception.

I wrote [this code](https://github.com/stof/symfony-standard/commit/c33597a51cd2f7ff3b7201106af269a77d2e711d#L4R5) triggering the exception. And if the exception was removed in the container to prevent the circular reference, the var_dump call would be dumping ``false``
This does not respect the interface: inexistant keys will be missing in the returned array instead of having a value set to ``false``
applied your suggestion @stof
Hmm, maybe this `UPGRADE` file should be updated to easily notice changes between beta versions ? @fabpot What do you think ?
@stof But the use statement is just usefull for the PHPDoc. Doesn't you think that it is memory use for nothing on execution? Even if it's it's negligible.
Yes but it is slower and less "clean" (IMO at least).
Space before (
Do I understand correctly that this conflates NULL and empty string by always translating empty string to None? If a legitimate empty string were returned would it result in None and thus be indistinguishable from NULL? That would not be a good thing.
This file is strange. I am pretty sure it must not be here. Please remove it.
Why return List<Object>? Don't we know it'll be List<Comment>?
no need for `else` as above
Definitely open to this audit. These private methods are intended for just this controller's usage.

What's your specific concern?
bug ! test kardam bishtar az 2 ta nemishe :( yani right nemiyad
For now, Archive and Delete run at same frequency.
for me, it is good practice to set pointer to NULL after deletion, this prevents double-free when user call close() two times. Same with m_file_ptr.
I'd move this to line 134.
Для упрощения пользовательского API можно добавить методы `setNode()`, `removeNode()`, `replaceNode()` и т.д., которые будут проксировать вызовы в `this.arch`
Should be ooo_xeon
``if getattr(settings, 'CMS_RAW_ID_USERS', False):``
Either `Ember.get(this, 'content')` or `this.get('content');`
What is this bindAll method?
it is strange but it should work, but in any case this could be improved :)
You are right, I have missed the META-INF folder!
Tnx
I'll move this part of the change to a different branch and bring it back in when I need it (depending on how the CapeDwarf integration goes).  

I'll also use the custom bootstrap mechanism for creating the Hibernate EMF in two steps (when that's ready).  I'm also pushing for a JPA spec change to support the 2 phase bootstrap but that won't happen overnight.
Actually, I don't think we should be doing any of this in the undeploy. Right now it's trying to scan the resource roots, find the MANIFEST.MF files, look for the Loggin-Profile attribute and then fetch the LogContext for that profile. All this is not needed during undeploy. The undeploy should just unregister the LogContext associated with the DU classloader, irrespective of how it was associated by the deploy() method. So just the:

        ... (do any TCCL switch if necessary)
        LoggingExtension.CONTEXT_SELECTOR.unregisterLogContext(module.getClassLoader(), LogContext.getLogContext());
       ... (reset the TCCL if it was switched)

should be enough, IMO.
Let's change this to:
```js
if ( this.options.modal ) {
    this.overlay = ...;
}
```
1. add hour and min
2. add status (normal, hidden, over)
For some reason, the dist_metric and agg_mean shows up as missing ("squared_dist_norm2(DOUBLE PRECISION[], DOUBLE PRECISION[])" does not exist) but works when changed to madlib.squared_dist_norm2. Any solutions?
Why do we want these semantics?
я еще не проверял, но подозреваю что тут нужно заэкранировать теги
Yes, mapping the enumeration through a string value with some human context is nice.  And we aren't limited to a strict set of values here (although for localization purposes we probably need to, at least until/unless we get a lib that helps us out.)
Not sure why are we removing this css from Contacts, these changes are not related with dialer?
better if(typeof callback === 'function'). the same for the rest
align with the end `}`.
Hmm, I am fairly sure csp is not going to be happy with this.
`font-family: "Open Sans", sans-serif;`
I wonder this change would make all system app's XXX dialog corrupts.
See https://bugzilla.mozilla.org/show_bug.cgi?id=801532

For short, if you are going to apply shared building blocks to system app, PLEASE make sure all dialogs works fine.
Including: banner, modal dialog, authentication dialog, all [role="dialog"]....
Remove this while space
Can we use window.confirm fot this?
we have a view which is the same, right? no need to call this
you're right, but we clean the lists when we enter the delete methods -line 277 (so actually instead of adding a line here, we should remove it)
「」to ""
Remove or redo uncommenting. Is this test still needed?
I don´t see a necessity to pass offset and limit here. I like it more modular, e.g. `Track.sort_by_date.limit(4).offset(0)` in the controller. The line below would then just be `Track.order("created_at DESC")`.
ok this will take time - but I will refactor this to use arrays, please hold on as I work on this
Consider logging in this else clause what `len(app_data)` and `app_data` are.
This would also be a good place for a function called `_get_zendesk_tickets` that encapsulates this logic.
`if params.get("emulate_file_remove", "no")  == "yes":`
This should be `'help'` and the `or path == "help/"` isn't needed.
Can you leave this in for now so that travis passes (well.. it'll still fail but not ALL tests)
you alter $this->vendorDir for the rest all the class using it
HTTP response body
Fixed ;)

2012/9/13 Florian Weißhardt <notifications@github.com>

> In srs_grasping/manifest.xml:
>
> > @@ -19,14 +19,14 @@
> >    <depend package="geometry_msgs"/>
> >    <depend package="kinematics_msgs"/>
> >    <depend package="srs_msgs"/>
> > -  <depend package="srs_object_database_msgs"/>
> > +  <depend package="srs_object_database"/>
>
> why do you depend on the database directly, not on the API (messages)?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ipa320/srs_public/pull/64/files#r1595413>.
>
>



-- 
Manuel Rodríguez García
Departamento I+D
-----------------------------------------------------------------------------------------------------------------
Robotnik Automation, SLL                  Tel: (+34) 963383835
C/Berni y Catala, 53 bajo                    http://www.robotnik.eu
46019 - VALENCIA - SPAIN                 mrodriguez@robotnik.es
-----------------------------------------------------------------------------------------------------------------
Follow us:
<https://www.facebook.com/Robotnik.Automation>
<http://www.youtube.com/user/RobotnikRoman>

<http://www.robotnik.es/en/news/robotnik-celebrates-its-tenth-anniversary>
-----------------------------------------------------------------------------------------------------------------
-   Aviso legal / Privacy policy<http://www.robotnik.es/es/legal/email.html>
  -
Forgot to override `getRequiredPermission`.
The flatfile hit counter was not working correctly, but the database one was. Are both working with your new version? I think I had it that the flat file was backing up the dbfile.
Is `is` really necessary in this message string ?
I would wrap this disable into promised as well so addonId could be a promise.
Please put the closing bracket right behind the }
No, it will not. With Firefox 4 we included the feature to change the add-on id with the update.rdf. I'm fairly sure AMO supports that.
PEP8 issue: header.py:19:1: W293 blank line contains whitespace
We need to make this option always valid because this error is strange given the help information:

    $ facter --json
    invalid option: --json
@hkenney and here..
Yes, I think so.  Singleton methods on class objects act different from singleton methods on non-class objects in that singleton methods on classes can apply to other objects (specifically subclasses), so when the object is a class, we need to look to the superclass to find the method we want.
@alindeman -- do you find this version of the logic easier to parse?

431e255894516f55a975f0889583a55be22f0575
Specs that expose bugs in MRI should be guarded with a ruby_bug guard:

ruby_bug '#6605', '1.9.3' do

end

The number here refers to the filed issue with Ruby and the version is where it's failing.
expected it to be thrown but was in the mood to dig down:

In our lib the error bubbles up from here: https://github.com/soundcloud/doozer/blob/master/conn.go#L268
coming from

http://localhost:6060/src/pkg/net/iprawsock_posix.go?s=1517:1562#L64
http://golang.org/src/pkg/net/fd.go (line 522)
Yeah - it means almost the same thing as "Use exact version numbers for framework gems" above. What about adding "Only" to the sentence below and removing this one?
would be great to modify README as well to point out that this exists, and provide an end to end example of something running on a small graph read via this reader
> I think we should remove all grunt reference from the Generator system

Absolutely. I have some more work I'll push today, trying to break the coupling with grunt.

As for the templating and the `.render()` method in generators, I was thinking about adding the ability to define a specific engine. Defaults would be underscore, but it would be possible to switch it to hogan or handlebars for instance.

Sindre, I'll also try to tackle #134
These were running as of beta2. Probably should not skip these.
@Maks3w What do you propose?
@cordoval this is useless, because you can do the same by running ``php app/console doctrine:schema:update --force``
this can be problematic. Once you register a service as a form.type, its  `getName` method HAS TO return the same value as the tagged serice alias.
Why are you setting this again... you already remove the first one?
Double quotes -> single quotes.
This script only uses $site and $targetenv. 1. Call it $target_env, like update-db.sh. 2. By setting all the other variables, you are restricting this example to work only as a post-code-deploy hook, whereas it could be just as useful as a post-db-copy hook; so, please don't assume the other command-line args are present.
Is this just a stylistic thing? Shouldn't these be basically equivalent?
Will this cope with title changes.  It may be beter to do the find_or_initialize_by using the business_support_identifier only, and then set the title separately.
I swear I've seen a library that lets you do something like this:

```ruby
deprecate :last_accessed, :accessed_at
```

That makes it show a nice deprecation notice, aliases, etc.  Or maybe just part of that...  At any rate, let's try to give a notice so we can get rid of the older name later.
StaticDocument should still exists though. Imo can be done smartly by comparing it to a dict
上面那行 _MSC_VER 的檢查沒用嘛？
On Mon, Oct 29, 2012 at 10:34 AM, Nicolas Tsiftes
<notifications@github.com> wrote:
>
> While looking at the commit, I found a potential license issue here. The file contains references to two files that do not exist in the Contiki tree: copying-gpl.txt and copying-liquorice.txt. The latter is supposed to contain exceptions to GPL, so it is important that it is included to make the legal status clear for AVR firmwares.

I found a copy of it here:

http://www.codeforge.com/read/122339/copying-liquorice.txt__html
A test for the error path would be nice.
yeah you are right, i will take care of php errors in different PR
I tried. And couldn't. As said here, anyway, it will be removed. Later.
Should these lines be deleted? This looks like an unrelated change.
i clarified the intended order in the docstring. the code here uses the option parser to parse the configfile values (make 'python' objects instead of strings; it also test the validity of names and values), the values are added to self.options after that (or not if eg set in an other way)
you should add ``isRequired()``, otherwise the user can still omit it (but not set it to null)
IIRC Affiliates is still using an older version of jingo, but I'll double check. This is definitely on the todo list for the entire site, though I'd rather not add a site-wide change to the Facebook branch unless you think it's bad enough to warrant fixing now.
why would `','` be in g if you split on `','`?
its bootstrap. This is how the brogrammers want us to do it.
I'm not quite sure what this is doing. I think backbone tracks with `isNew()` what you're tracking with `pending`? It seems like the main utility here is to call a callback after a save, but it's not clear to me that you'd want the same callback for both the success and error conditions.
Nit: should use `jQuery.Deferred` instead of `$` (like you do in `Session`)
It's possible, if the popcorn api is bypasses, but that should be treated as "voiding the warranty" - we can't support cases that paint outside of Popcorn.js API. The actual property is being set asynchronously... it was a real wtf to deal with.
&times. ?
Please indent this line and the one below it by 2 more spaces.
Oh, so I had added this to ... uh ... i forget why
I don't think so. I meant to not change the use of m_bIsAllocated so that it's true when dvdplayeraudio thinks the sink is initialized.
m_bInitialized is new and true when the references to the device are valid. Basically it's a shortcut to "m_pRenderClient != NULL && m_pAudioClient != NULL && m_pDevice != NULL).
Close() sets it to false and the following AddPackets() should try to reopen and eventually set it to true again,.
This does not look like it will compile (especially the .isOk). For usage instructions, consider instead referring to something that is compiled, such as (ideally) an example project, or a unit test. Code in comments tend to rot, and nobody notices until a poor bastard tries to use this example.
This should probably be some kind of default. We really want to run every test with A3 enabled. But it is difficult to manipulate the user database, if it is only on file.
Circles don't have vertices :)  But actually is this even used anywhere? It looks like `drawShape()` just calls `g.circle()`
Simple date format is not thread safe, just create a new instance every time you need it, but keep the pattern use by the date format in a constant  reference
Should you use index here to be REST-ful, I would normally associated a new or a create method with a POST request
Class description would probably be a good idea for those who might browse through this in the future.
We really don't have any guidance on this except for the behavior of the `CodeExecutable` class. In that class, the code can be changed, and `execute` will reflect that when called. I think we should do the same thing here. Recreating the block when the code changes is the most direct way of achieving this.

If we want the block to take precedent over the code, then this deserves additional discussion.
CS : Point `.` missing at the end of this line.
you still need to roll this back.
s/got_to_page/go_to_page ?
Is this intended to invoke `callback` before the `fs.unlink` is performed?
I think a 401 is more in line with the  [HTTP Spec](http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.4.2) if it's just a case of not being logged in.
> I didn't say it's "just" a visibility issue :)

True, my bad for implying that.

> In general, I think it would be more helpful to put down your reasoning from the beginning, instead of a question that needs a few more hops to clarify.

I fully agree. Sorry everyone for the wasted time.

> If the var is volatile, other threads will see the latest assigned value, am I right?

Yes, that is what ``@volatile`` does (plus it also prevents the compiler from reordering instructions)

> Or you think that the invoke call should have exclusive access, so that nobody can modify the currentThread variable while it's executing?

Yes, I believe we need exclusive access. Otherwise, we may end up invoking methods on a (no-longer) suspended ``ScalaThread``, which would cause the debugging session to shutdown (https://github.com/scala-ide/scala-ide/blob/master/org.scala-ide.sdt.debug/src/scala/tools/eclipse/debug/model/ScalaThread.scala#L209).
I would suggest, that Geocoder should follows the [sf2 coding standard}(http://symfony.com/doc/current/contributing/code/standards.html).
Where are valid `type` values enumerated?
@RSEvseev я так понял, ты проверял мою работу, а оценки ты уже выставил? А то я не вижу оценки, думаю где ее искать ?
Что мешает использовать containsObject: у массива наполненного NSNumber?
кажется exists и recreate принимают одни и те же значения  - можно изменить цикл на do с одной переменной.
I prefer to have this change in separate commit. Because i is not "Performance work", but still useful.
ты правда думаеш я ее видел?
hum ... to build the model for the GUI no ?
@markhealy This really isn't a good idea. Rephrase it in such and such way ...
Yeah,  I thought you might have been thinking about longs after I posted. It's all a mess, but `int`s are probably the most reliable datatype you can have.
Since this can be a name too, I would call this argument simply `shake`, and describe it as "ID or URL name of the shake to list".
darn I messed up... nice catch
> I vote for using scipy.signal.resample() or scipy.signal.decimate().
>
> While resample could be used to increase the sampling rate, it assumes the
> signal is periodic, which may give edge artifacts. So decimate() may be the
> better option. A problem could be that the filter decimate() uses is not
> zero-phase, maybe it would be better to implement decimation ourselves using
> zero-phase filters. @agramfort what do you think?

indeed the bin as it is is rather crude and not recommended by text books.

but take a look at the --interp and --tstep params in mne_make_movie command:

	--tstep   time/ms   specify the time step between frames (default
1/(sampling frequency))
	--integ   time/ms   specify the time integration for each frame (default 0)

I thought you wanted something like this.
remove 1 indentation level in Parameters block pep257
let me know when you commit
Here's the check for raising an error if no setno is specified.
Aren't the annotations inherited? i'm just being curious!
Pull request with fix:

https://github.com/playframework/Play20/pull/243
the recommended syntax to access properties in Twig is ``form.tags.vars.prototype``, which is working since 2.0 and did not changed.
@fabpot it is: 

[Chapter 4.2 Properties:](https://github.com/pmjones/fig-standards/blob/psr-1-style-guide/proposed/PSR-2-advanced.md#42-properties)

 > The var keyword MUST NOT be used to declare a property.
extra blank spaces here
默认不编译
对齐，好看
A good set of questions. I can change to code to make the if not a surprise. 

Previously, the option was essentially a true/false to enable encryption. Here, the option is off unless you provide an encryption algorithm, which is now limited to just AES256, but could include others later. I know I like to use symbols for 'enum'-like things, hence I provided for someone to do s3_server_side_encryption: :aes256 or the like. 

If I have some defaults set in params hash and want to override the setting for :s3_server_side_encryption, I can do that here, I just use false or nil instead of '' to mean 'no encryption method'. I suppose I can keep the '' option. Let me amend this.
is node.receive threadsafe?
А я магог и пилю личкрафты - мне вообще можно даже детей убивать и есть за
мои заслуги!!
И зачем дергать для этого volumeSlider, если можно дергать audioOutput? Не дергай volumeSlider и спрячь геттер обратно в PlayerTab.
The "master" is merely the node in charge of writing to the index, but the index is not local to the master node: it's distributed/replicated (whatever the index-storing cache is configured: see the various caches in the configuration file).

So when the "master" goes down, another node is elected to perform its duties but there is no need to transfer any state.

What might need some more thinking is the fact that the node originating the change crashed between the transaction commit, manages to commit succesfully, but doesn't send the synch command. This latest scenario isn't covered by Hibernate Search either so I'd leave it for a future discussion.
Two things:
1. Executor service left unclosed.
2. I doubt migrator tasks are very common, but since the migration manager is a per-cache component, wouldn't it be better to keep the exec service there, cached, and then shut it down when the cache stops?
moved ptest() function below removeLowerCaseDiacritics()
Ok that makes sense.

Thanks.
E.g., break it into two steps, starting with "aliases = self.aliasd[s].iterkeys()".
uber-nit: s/is/if
Is there a Moztrap test case ID associated with this test?
I had an "adjust-timeseries" function that's a more general version of this -- maybe use that?
This is an outdated function that is no longer used.  In later commits, it is removed.
extra ending < br/ >, missing closing </ p >
@gsilver can we also use `$('#topnavigation_container .s3d-jump-link')` in here?
Also one missing space after `,`
I'm not sure about this, ``null`` could be seen as value in some cases.

Why would you use this over explicitly calling either Some, or None?
could you please use a single capital letter for the template type name, e.g. T
Use get_computed_dot_feature_vector(), computing whole matrix is way too memory expensive
I changed this to ```find_or_create_by_...``` to match the style with the rest of vanity.

& yes ```vanity_metric_counts.create``` does create a ```VanityMetricCount``` associated with the current ```VanityExperiment```.
> Right, but if we don't shuffle pointers, just, if the session we're closing
> is the last active entry, we decrement session_cnt back to the new "last
> active entry", we're not doing any pointer shuffling at all, and the list
> stays relatively compact.

Sure, we're holding a spinlock there, so no new sessions can be opened, and we're explicitly ignoring sessions that are not in use, so that seems fine.

BTW, if we do this, we will need to move the line `WT_PUBLISH(session->iface.connection, NULL);` to earlier in `__session_close`: after getting the spinlock but before freeing anything in the session that other threads read, such as the hazard array.

Michael.
I know you're not planning to go this way, but I think you meant `pass_count % 100 == 0` in the test above...
In both commit and rollback, the  WT_TRET call can be WT_RET, there's no need for a local ret variable.
Why create a random table name?
It's not an abstract class but an interface. `getMock` should suffice.
This isn't necessary as the default value is already given as second parameter of the get() method of the config object
Thank you thank you thank you.  :)
Is it possible to add a ``@param`` annotation for parameter ``$options`` which defines the array type; using ``array<SomeType>``, or ``SomeType[]``?
- Are you sure you want to override the parameter ``$min``? This often makes code less readable.
- Are you sure ``$max`` has the correct type as "integer" is not a sub-type of "array"?
Should sanity check this number before using.
where do you see that? I only see "add the path the bin" which should change to "add the path to the \bin", but I can't see your quote
You can remove the word Discussion, just make it the number.
I agree with @hhamon l10n prefix is shorter
Crap, you took the URL off this and broke all the pull hooks.
Splunk's problem and consistent with the other SDKs.
This check shouldn't be necessary (here and elsewhere) from a casual reading of the code. rwdb should return None as the cur_cid if None is passed to get_current_channel.
Please add TOTO. This is something we can improve a lot. For example, question is if we really want a slow animation. Then, maybe we just want a button which enables user to display all new posts which came in meantime (like Twitter has). Also, it would be useful that posts are displayed, but page is scrolled in a way, that it is not move for the user.
Sorry, that was lazy... :\
and gens are tuples.
Did you test these? My understanding is that this will display the text /handler403/, not the page.
the simplest thing here is not to allow for options, if MP needs a higher max_nesting or tidier formatting it can specify it
.encode('unf-8') is quite important; hashlib.sha1 fails for non-ascii values.
We should use a mark for this. See https://github.com/davehunt/pytest-moztrap
The style guide says braces can be left out only if the statement is one physical line.
`extend ` would be more efficient here.
@yaoweibin
The fetchers are deleted over here: http://code.google.com/p/modpagespeed/source/browse/trunk/src/net/instaweb/rewriter/rewrite_driver_factory.cc#116
no camel case: standard python is ``restrict_matrix``
u[k] should equal the absolute value of x[k]
Cleaner (IMHO) to say `final.first`
If I use `Hash#fetch` with a block, wouldn't I be able to access *only* the code_point from inside the block? I don't see a way to pass `block_data` to `get_range_start` without making `block_data` a class variable.  

```ruby
block_data.fetch(code_point.to_sym) do |code_point_sym|
  #Can't access block_data from here, only code_point
end
```
Why?
from models import UserProfile
if you write piplmesh.account code breaks if you use it in another project (rename current etc..)
Why import modules as whole and not just the parts?
And then indent the content of the dict one indentation more to the right.
Should indicate @throws NullPointerException if document null
Are you sure this is correct?  Wouldn't be prefer to either completely delete, or leave the constraint in?  Why are we commenting it out?
This is in the part of the code that Joe wrote, and I deliberately modified it as little as possible (just put in our RNG instead of the numpy one) because I didn't want to introduce any bugs into his code before I had tested it.  I agree that it doesn't seem strictly necessary to make these assignments (though I have little feel for which might be more or less resource-intensive in python).  Now that I've tested how the code works I'm less averse to changing things, so I simplified the function to not do those assignments.
I suggest using explicit key words for True and 1.e-4.  It's a nice feature of python that makes parameters like this self-documenting.
ascii_fields isn't documented or even used -- is that something that is a placeholder for future use, or should it be removed?
Should we be using a default value of `None` for `dx`?  If `image == None` it is set automatically, and here we only use it if it's set.  Not sure what to do about negative values, but could take an `abs()` or might be nicer to raise an Exception...
it might be good to give some motivation for why one might want wmult !=1.