labofsahil/github-event-dataset-2012 huggingface dataset:
Sorry for being picky here: I distinguish promise **resolution** and  **fulfillment**. Promise may be resolved to an actual value or to another promise, later one may still be pending though. For example:

```js
var d1 = defer() 
var d2 = defer()

deliver(d1, d2)
```

Above `d1` is resolved to `d2`, but it's not fulfilled yet, it will be fulfilled only after `d2` is fulfilled `deliver(d2, 3)`.
Function `when` let's one observe value **fulfillment** rather then **resolution**, there for I'd change phrasing
to something like: "Wait for a given value to be fulfilled / delivered, then execute an appropriate callback."
Can you please put a function to clear all of these and call it from the all the required locations
I don't understand the way you want to store the route parameters. here
I don't think the associations like this one are working correctly, I think they require more setup as described in the FactoryGirl documentation.
Thank you for fixing this.
doh, yup
Does this actually copy the array data?  I would expect a `copy` method to do that.
There should definitely be an `__str__`, though it can just call this method, perhaps with the default arguments, thus documenting what the default string representation is.  I also vote for renaming this to `.format()` or maybe `.strformat()` or something verbier like that.
There's actually already a `earth_orientation.obliquity` function that's probably better to use here.  I'm not sure which of the three algorithms there (1980, 2000, or 2006) are most closely matched to what you're doing here because the units are different (years vs. ), but if it's necessary for precision, you can add a new algorithm there.
I made my previous comment too early.  I already explained in one of the other comments why this is not set.  I still think it's crap but it will take a little work to have more info on inbound xfers.  This doesn't hurt anything, though.
Perhaps we could have a class CHubClient, which has a pointer to a CHub in a protected field, and public methods Emit*, which forward to the connected CHub (or maybe the Emit* method's implementations could even be moved to CHubCLient). class CHubListener could then extend CHubClient and reuse the phub pointer in it.

Advantage: inside CWallet, you can simply call Emit* directory without qualifying with the phub pointer, while guaranteeing that the wallet will get callbacks from the same hub as the one it submits to.
or maybe a ternary operator ? that's waht I used first before I added the comments line
Pretty sure this is also supposed to be scheme.
I guess there are probably not many custom readers out there, as long as we document it well I'm ok with the interface change.
Link was wrong too :s
Ooops. Should be gen_event_EXIT.
There is another pattern that might be interesting:
const %type% %var% (
Pulled this out to the ApplicationHelper so that I could share it across all of the mailers.
FD_ISSET 的第一个参数是 fd, 但 i 并不是 fd
I think it's better to keep FAKE here (and in the other.)

-[Unknown]
We are trying to use names such as `process_math` in our JS code.  Can you convert all your names to this convention?
added check!
Usually called anonymous in JavaScript.
Move these functions to be within the `$(document).ready` callback below so that they aren't in the global namespace.
I would use .transform() for these.
Wow--I've never seen that syntax before. That's funky.
Mmm...  Looks like some/most/all of the tests in this class set it first and then do stuff. So, it's probably not something to worry about.
Sorry! I guess that's what settings/local.py is for.
I don't see too many use cases very a Countable object should be considered as a string, should we default to Collection in this case ??
@stof Things are different now as you can now access the dispatcher via `$form->getConfig()->getEventDispatcher()`.

I disagree that we cannot ensure deep unmodifiability, but that's not what we need. If the user *wants* to mess things up, he can always do that (think reflection). We just need safety measures to show how things are supposed to be used (or not).
simply use ``if`` as the previous ``if`` returns
It is now again, thanks for the heads-up.
You are right, this was a mistake.
The `prefix` can also have parameters in it. So, I would rename `hostnamePattern` to `hostnamePrefix` to be more consistent (this only needs to be done here).
empty collection -> `hasChildren() === false` -> no CSRF ?
I see. The problem is github puts all commits at the end after that in ` Tobion added some commits` section.
So conversation history is not that easy to follow.
304 error : This does not really indicate an error, but rather indicates that the resource for the requested URL has not changed since last accessed or cached.

Is 304 really the correct error to use here? I'm not aware of any codes, and infact, I did look through an abridged list, before I decided to return this *arbitrary string
不需要介绍那么多，只介绍 $$ 即可（我用到现在都不知道前面那个东西……）
For clarity, lets just say "without animation".
s/THe/Yjr
Add one of these to the osgb class
This approach assumes the `smart_common` module is included at the root level of the project in a directory called `smart_common`.  Can you finding the ontology relative to the absolute location of **this file** instead, i.e. something like 

``` python
os.path.join(os.path.abspath(__file__),  "..", "schema", "smart.owl")
```
this should probably be `'' == pairs[0]` so we dont clobber falsey strings
I think this causes memory leak.  Why not something like this?

```python
def hash(self):
    return hash((self.__class__, self.word, self.description))
```
This didn't really belong in this commit, but snuck in. It's solving the same issue as #1128. If we keep it, I should probably merge the tests from that request as well.
why did you split the comment? now it is wrong, as the trailing char is removed by slice(0, -1)
Rather than getting to the target view like this, you could just use `viewName` in the template and then do `view.nameOfView`.
AFAICT, this attribute was never actually used for anything (other than in the parser). But this patch removes it from BridgeDefinition/BridgeAdd/BridgeWriteAttributeHandler. That becomes an incompatible API change without much benefit. I think we're better off leaving the attribute in there and logging a WARN if a value is passed to BridgeAdd or BridgeWriteAttributeHandler. that's consistent with what the parser does.

FYI, I just opened https://issues.jboss.org/browse/AS7-5112
You can simply pass a string resource name into .addAsWebResource here, no need to use the TCCL
Why is it necessary to run these tests under the full profile?
These should be incrementing by 100. In other places they have got out of order because re-numbering existing phases is not very practical, but as these are new this is not a problem
actually it doesn't. but in accordion it's the same, i just adapted the code. we can remove the wrapper height here of course.
зачем и ref_user_name, и nick? Кстати лучше refUserName, как принято в Java
a better name for this variable would be numberOfChunks
nit: aCrashID -> crashID
@arcturus would love to add the fixed header but I think that should be part of a follow up PR. #4102 is tracking that.
Build system (when it exists!) will enforce load order. Its very ugly to hack a global but I have not really come up with something better. What do you think of just setting mozSystem to true when in a browser environment?
Do you need that? It seems that you have added this with a default value of 0, sothis is always true, correct?
no aria-disabled = aria-disabled=false, visually speaking
no.  See https://developer.mozilla.org/en/Security/CSP/CSP_policy_directives#Keywords or https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#script-src for unsafe-inline.  The basic idea is that you get happy protection from XSS attacks since even if a jerk manages to get your app to display some HTML they still can't run JS.  (They could still insert a script tag, but since there is a source restriction on where the JS files get loaded from, unless you host attack code in the app, you're safe.)

Since Calendar displays externally sourced data from calendars, it seems like a reasonable protection to have in place, especially since you may end up displaying HTML eventually too.  (But even if you don't display HTML, it's still possible to screw up just inserting text, as demonstrated by previous revs of the SMS app, etc.)  I forget if your templating thing uses eval right now, but that's a separate flag, and arguably that's a safer foot-gun since user data tends not to flow along the same data-flow paths.
This is just how it was designed. Place holder text = "SEARCH"
I'm afraid these characters are incorrect. This Brauciet pa ceïu looks much nicer than this Brauciet pa ceÄ¼u. 

Please try to find appropriate UTF-8 editor.
OK, so you're creating tables for each collection, then storing a byte-array under that collection's table for each key/value pair...is this better/worse than using the HStore optional module from within PostgreSQL (granted, it's only available in PostgreSQL v9.0 and later) to add similar key/value functionality (or are you specifically trying to put something together here that will work or **any** version of PostgreSQL)?
Removed in this commit: https://github.com/skyluc/scalatest/commit/0d3d88cfb43facd3e14a13e13809e26c57885320
Ah, I pushed in the branch I had openned, but you already had merged the patch, too bad :-)
Should I open a new pull request ?
This is how you add/customize the loggers listening for events
Remove the extra newlines.
This makes sure that text is not selected while you drag the mouse (even if you drag over some text off of the map), useful to call while map dragging
I'd rather you do

```
$.replace deadlink, Array::slice.call deadlink.childNodes
```
The names of the booleans in the status dictionary were chosen to mirror the names of the lists whose status they represented (e.g. the not_tracking boolean represents the status of the not_tracking list), but since the not_tracking name might cause confusion, I renamed that list and status boolean to `unassociated_enhancements` which is more specific and should hopefully clear up any confusion.
.present?
True - probably a link to the `GerritStatusPush` docs can clear that up
Is there a reason why we are limiting the regex here? `.*` isn't too much more to write than `*`. It would also clean up the code here and you could just construct regex and test it against the action name. The constructed / compiled regex could even be cached, etc.
OK, i will contact **YuLei** and ask him whether we should delete these two functions.
Thanks.
я тож так думал, но не пашет
javascript:// in href ? 

The analytics module will log events from span tags.

Also this line is 297 characters long :D
It's how all the other modules work isn't it?

So, I was expecting something like this - https://gist.github.com/2f7aeb05aa3e785e4ea8

.... the gallery just communicates it's change in state with a index number.

Still think we need to decide what we are building here - a client side application from a list of images on a single URL or a mix of server-side and client-side code to page images on the server. Former is simpler IMHO. All the complexity in this module is due to need to manage state across images.
Hi Florian,

we do not have our soft casing on, to have more freedom with the torso. 
So we would like to have the 60°. For the calibration we need at leased 
lower="-0.6" upper="0.6".

regards
Jan

On 12/18/2012 04:51 PM, Florian Weißhardt wrote:
>
> In cob_description/urdf/torso_v0/torso.urdf.xacro:
>
> > @@ -17,7 +17,7 @@
> >  			<axis xyz="0 0 1" />
> >  			<calibration rising="${torso_lower_neck_pan_ref}"/>
> >  			<dynamics damping="25.0" friction="10.0"/>
> > -			<limit effort="24" lower="-0.2" upper="0.2" velocity="0.5"/>
> > +			<limit effort="24" lower="-1.0" upper="1.0" velocity="0.5"/>
>
> this is like 60°, I think that's not possible any more for the soft 
> casing. Why do you need to extend the range of the pan joints? If it 
> is just for the homing, then let's set them to a resonable value close 
> to the homing switch.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/ipa320/cob_common/pull/22/files#r2450288>.
>


-- 
------------------------------------------------------------------------
M.Sc. Jan Paulus                         Bonn-Rhine-Sieg University oAS
Fon: +49 2241 865 437                    Computer Science Department
Fax: +49 2241 865 8437                   Grantham-Allee 20
Net: jan.paulus@h-brs.de                 53757 Sankt Augustin, Germany
------------------------------------------------------------------------
Let's put the HTML code in a separate file and read it in.  That would allow us to use jinja2 to template over variables if we need to.
Isto é uma possível causa do problema, o que eu sei é que é questão de sincronização, se eu tiro o sleep, o browser nao consegue dar switch_to_frame nem por reza, aew não tenho acesso aos fields.
`Pagination` doesn't sound like a noun. Maybe `Paginator` would be a better name?
refactor to use only one line
not: this variable seems unnecessary
@lloyd - I agree, we also have to ensure that the BigTent servers are always available from the Persona servers, especially if they are run on distinct machines.  I'm less worried about the BigTent code than about network reliability.
fixing an orthogonal bogus log message.
A remnant of requiredEmail that is never actually used anywhere. Issue #2705 is now open to remove this.
fixed in this case
Please don't call getService twice here but cache it locally right before:

var obs = Cc["@mozilla.org/observer-service;1"].getService(Ci.nsIObserverService)
obs.addObserver(...);

Same applies to the SessionStore service below.
Ok. That sounds good. So when there's an 's=' tag in the whiteboard, but the sprint doesn't yet exist, the bug will go into the "Ready backlog", so it will be in the short list for planning the next sprint.
What should we do for these lines? We need to keep track of the exception somewhere!
oops, didn't mean to leave that like that
I don't quite see why these should be queued connections in the first place. We should check into that.
Regarding my comment above: It's confusing to return two different types, when they are both "stub const". Maybe returning an instance of `StubbedConstant` (a new class) with `original_value` set for real constants, and `nil` for "fake" constants.
Yes it should. Typo.

Regards,
Ben Langfeld

Em 17 Nov 2012, às 20:10, Dirkjan Bussink <notifications@github.com>
escreveu:

In spec/ruby/core/string/encode_spec.rb:

> @@ -58,6 +58,12 @@
>        str.encoding.should == Encoding::UTF_8
>      end
>
> +    it "returns self when called when target encoding equals source encoding" do
> +      str = "caf\xe9".force_encoding("iso-8859-1")
> +      copy = str.encode "iso-8859-1", "iso-8859-1"
> +      copy.encoding.should == Encoding::UTF_8

Shouldn't this be Encoding::ISO-8859-1?

—
Reply to this email directly or view it on
GitHub<https://github.com/rubinius/rubinius/pull/2012/files#r2160346>.
Please make a note that this is single threaded for now.
As I understand it, @jreidinger wanted to point out that  both `issubstring(interface, "-id-")` and `issubstring(interface, "-bus-")` should be replaced with a more understandable function.

The fact that the code would than contain `if( !(FunctionA(...) || FunctionB(...)) )` is not the important part of the message (although you are right that @jreidinger did not write that correctly).

Anyway `if (!A && !B)` is IMO more understandable then `if (! (A || B))` although the latter could be a bit faster.
There are files under git control in doc/ (their usefullness is another thing).
i understand. i should remove it.
Hi Marc,

Perhaps it's a good idea to move this object instantiation to a separate method like 'getDefaultCapabilities()' or 'getDefaultCapabilityOptions()', so that one can easily override those without having to override this entire method?
I added the check for the $priority > 0 and $priority < count($this->priorities)
We are consistent. This type is used most of time in this project.
The indentation of the "{}" block seems odd...

Oh snap. I just Pranav'd Pranav!
I believe I did this because the TextEngine has no access to the Layer. Since I only needed the surface (which is cloned later on), I stored just that.
Could you add a tiny comment explaining why an array parent is a special case?
Found out why our edge case was requiring this and found a different fix so I'll remove all this.
Pas besoin de return.
Didn't consider it as being used at the time but now that you mention it; I am adding a refactoring to allow the possiblity
FQCN should be used here
I understand your point here, so we could do:
```
# ignore when no author or empty author
if article.author and article.author.name != '':
    ...
```
I think we can get rid of this warning since this is already done in ``configure_settings``:
https://github.com/jawher/pelican/blob/8cc3b84fbf964d08658392f612815b45946d2ca2/pelican/settings.py#L186
does this need a lambda?
what's wrong with
perform_step("preparation", app, app.prepare_build, applog)
We should ask gatox why he did this...
Tastypie is 3rd party, there should be an empty line between the last `tastypie` import and the `common` import.
Nice catch. I copy/pasted this code from another place in the project without reading it carefully :S I fixed that in two more places.
I added it as JSON.

When I checked for the format, I checked plugins which did not use JSON it seems. There seem to be string, xml and json context markups!? A common recommendation/definition would be nice. Including on the/common field names.

Also, am I correct in that the context defined in the plugin itself is appended to the plugin name for the effective context?
(The PAHelper displays it as such.)
Then one couldn’t parse it as JSON right away anyway!?
Yay, translation strings in title attributes! However, the old one is still there and should be removed.
Aggh, I am so sorry! I've been finalsing this past week and didn't get to this in time before it was merged. Do you want me to correct and reupload the issue?
This makes sure that using a secret with cookieParser still works. It is a test to make sure backwards compatibility with signedCookies was maintained. All the other tests had the secret moved to the session middleware setup.
hostList = _append_services
I'll give you a much better decorator for returning JSON.
ummm, why is replyTo = self and then only used to do replyTo ! Failure(cause)?
that essentially means "self ! Failure(cause)" which will not restart self, if you want to restart self, just don't bother catching the exception at all.
Just use double-quotes here.
@potatoboy2 What is a "trax"?
Attempting to get an attribute of a <module>?
I was thinking of that. The thing is, in OAI-PMH it is called format. But we can of course say that for us it's a schema
Chaining of "+" to concatenate text is frowned upon in Python. You want ``''.join((my, tuple))``.
This method is common with AuthenticationFilter. Move it to parent or utility class.
ты это глазками потом читаешь? нужно проверять прямо в тесте
@calebthompson, it seems you've added an extra curly brace.
This may not work as intended. If two processes each creates the file, they will end up each locking their own fd.
Any reason to expose this? The only interesting method on `ProxyManager` is `proxy` which you're already exposing.
s/titile/title :)
also, there seems to be no default initialization of this to true
You should be able to prove that this is correct, not just rely on the happenstance of successfully running.

It could be that you have, and this is just a misleading comment, in which case the fix is obvious. ;)
Would this produce a line in the logs every time a file is fetched from S3?
In developing the content module, it actually makes things harder. I work with full content ids (c:cam:contentid) and full principalids (u:cam:simong or g:cam:math101), which is what we will be passing around. Creating the SecurityContext causes me to split the strings and pass them in separately.

Even without the SecurityContext, the lookups could be easily cached

It still feels mostly unnecessary to me and I'm leaning towards the simpler solution that simong specs out below.
I changed this across all the code.
dumped it.
We have a validator for checking that the current user is logged in. This would remove the need for the `!ctx.user()` check and would avoid calling hasAccess for anonymous users.
Looks like a typo s/no/to.
Would be good to add a few more. One that comes to mind is mixed-in methods, or `$init$` methods (trait constructors). Mixed-in methods it's a bit harder to identify, though. It's easy if you can look at the bytecode though, they always have an `invokestatic` towards an implementation class (one that ends with `$impl`).
The date is wrong here. The first year should be the year you began. In this case just this year is relevant, as you are starting from scratch.
1) What I mean is that, unless I`m wrong, in Velocity you can do either one of:
* #set ($list = ["string", 1, true])
* #set ($list = ["string", "another string", "so on"])
* #set ($list = [false, false, true])

and every time you basically get a List\<Object>. What happens when you give a List\<Object> to your diff(List<E>...) method? Does the underlying DiffUtils utility class check that the E type (Object in this case) isAssignableFrom(String.class or Character, some other type?) ?

2) I imagine that there is a limited set of supported types for the @param \<E> that we should maybe document.
Levi recommends creating a new Guid instead of using the Asp.net session id.

Levi can explain the reason.



On May 15, 2012, at 6:09 AM, "Andrew Arnott" <reply@reply.github.com> wrote:

>> @@ -148,6 +159,20 @@ public OpenAuthSecurityManager(HttpContextBase requestContext)
>>            // attach the provider parameter so that we know which provider initiated 
>>            // the login when user is redirected back to this page
>>            uri = uri.AttachQueryStringParameter(ProviderQueryStringName, this.authenticationProvider.ProviderName);
>> +
>> +            // Guard against XSRF attack by injecting session id into the redirect url and response cookie.
>> +            // Upon returning from the external provider, we'll compare the session id value in the query 
>> +            // string and the cookie. If they don't match, we'll reject the request.
>> +            string sessionId = Guid.NewGuid().ToString();
>> +            uri = uri.AttachQueryStringParameter(SessionIdQueryStringName, sessionId);
>> +
>> +            var xsrfCookie = new HttpCookie(SessionIdCookieName, sessionId);
>> +            if (FormsAuthentication.RequireSSL) {
>> +                xsrfCookie.Secure = true;
>> +            }
>> +            this.requestContext.Response.Cookies.Add(xsrfCookie);
> 
> Does this really require a new GUID and cookie?  ASP.NET has already assigned a session cookie to the client, hasn't it?
> 
> For example, DotNetOpenAuth's OAuth 2 client class uses the preassigned session ID for this exact same XSRF protection.  [Check it out](https://github.com/AArnott/dotnetopenid/blob/master/src/DotNetOpenAuth.OAuth2.Client/OAuth2/WebServerClient.cs#L106)
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/AArnott/dotnetopenid/pull/145/files#r823146
> 
> 
>
While this might address if the url ends with one of the known extensions, what happens when it might end with .png, but serves up a HTML wrapper around a file?

There is no exception handling, the explosion would still happen.
I haven't found a better place for it. 

I HATE this sort of code, it is ugly and unmaintainable. But it was copied from another place where it wasn't much better. 

In short, lets remove it later and not make this PR any bigger unless it is fixes :P
A space here between `foreach` and the opening parenthesis
О, при таком коде http://d.pr/i/6t73 второй вариант выполняется за 5 секунд.  Тааак, я чувствую, что надо половину кода переписать. 
Еще хочу потестировать на скорость свой код формирования случайных индексов.
предпочтительней использовать типы Cocoa - в данном случае NSUInteger
1) Практический смысл в том, чтобы избавиться от не нужной здесь операции преобразования массива в строку.
2) @property (nonatomic, readonly) NSArray *DNA; благодаря такому property вы сможете обращаться к DNA из вне, но не сможете изменить указатель, хранящейся в DNA, и не сможете изменить массив, хранящийся в памяти по этому указателю. Вот вам поддержка идеологии объекта.
@crmaxx в том-то и дело, что всё уже уточнили у самого преподавателя, который ответил, что менять нужно на любой другой символ, но не тот, что был, и только один раз.
@slebedev нет тут рационального зерна 
какое задание такая и реализация
int length = MIN([self.DNA count], [aCell.DNA count]);

И сразу все понятно без комментариев
Спасибо за проверку.
Что значит "не может"? Вашей задачей было написать класс, которым будут пользоваться, грубо говоря, другие люди. У класса есть соответствующий интерфейс, которым являются все ваши методы. И сейчас реализация вашего метода mutate такова, что ввод числа>100 никоим образом обрабатываться не будет, что не есть хорошо.
I assume this is only for old lines, where new lines will be added automatically?
I think we should start by checking that the git is in a coherant status - if there are uncommited changes, the following "cp" will just destroy them.
validates :rating, :is_right, :presence => true
There's no data anymore, so the object only contains no attributes.
Good idea! I adopted your suggestion.
Doesn't seem to be used in this class.
This doesn't really belong here...
Brace escape seems to be necessary in 1.8, not any more in 1.9; positive lookahead appears to be recognised by 1.8. However, `\b` is clearly the cleaner alternative. I'll update the pull request accordingly.
Added <ul> anyway in 3b95998
start, stop not used
thanks, already saw it. se latest commit


On Thu, Dec 6, 2012 at 4:42 PM, Christian Brodbeck <notifications@github.com
> wrote:

> In mne/epochs.py:
>
> > @@ -463,19 +493,30 @@ def __repr__(self):
> >      def __getitem__(self, key):
> >          """Return an Epochs object with a subset of epochs
> >          """
> > -        if not self._bad_dropped:
> > -            warnings.warn("Bad epochs have not been dropped, indexing will be "
> > -                          "inaccurate. Use drop_bad_epochs() or preload=True")
> > -
> > -        epochs = cp.copy(self)  # XXX : should use deepcopy but breaks ...
> > -        epochs.events = np.atleast_2d(self.events[key])
> > +        epochs = self.copy()
>
>  def copy(self):
>
> raw = self.raw.copy()
> del self.raw
> new = deepcopy(self)
> new.raw = raw
>
>  don't forget to re-assign self.raw
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2336326>.
>
>
maybe i should term the new arg epochs_idx to avoid this confusion.
probably add NeuroImage reference here too
... makes senee to me

On 25.12.2012, at 15:09, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/mixed_norm/optim.py:
> 
> > @@ -3,7 +3,7 @@
> >  # License: Simplified BSD
> >  
> >  import warnings
> > -from math import sqrt
> > +from math import sqrt, ceil
> it's faster and I find it more explicit as it means that it applies to a float and not an array
> 
> —
> Reply to this email directly or view it on GitHub.
>
These commands wont be in /usr/bin if they are working within the virtualenv.   So they should be something like ../bin/datanommer-stats
For consistency you could use `page.has_descendants?`.
How about:

>Start by building a spin-off of the classic "Hello World!" application.
Hmm, I think it's just there fore backwards compatibility. So, we should say that using `property_path` => `false` to disable mapping is now deprecated and to use `mapped` instead.
``html+php`` ? where is the html code ?
To avoid horizontal scrolling, you should do something like this:

    ->addTypeExtension(
        new FormTypeValidatorExtension($this->getMock('Symfony\Component\Validator\ValidatorInterface'))
    )
Don't add whitespace here.
@anxiousmodernman sowwy
I'm pretty sure they are covered in a generic egg-info line somewhere else
in the file. Maybe I'm wrong tho.


On 5 December 2012 17:34, Steven Skoczen <notifications@github.com> wrote:

> In .gitignore:
>
> >  .DS_Store
> > -salad.egg-info
>
> I'm generally +1 on these changes, but why pull these lines? The egg is
> generated when I package for pip. Definitely want it excluded.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/wieden-kennedy/salad/pull/34/files#r2322743>.
>
>
superfluous braces
you most likely don't want this since this will be executed every time. just pass in addresses
wait, addHeaders suggests modification in place and mutability of the message.
I've intentionally chosen plus as for +=. 
As far as I am concerned plusHeaders clearly states that we are not modifying current object but creating new.
Please revert unless vetoed by BOSS :)
please add condition "and config.get('check', 'interval')"
so with 0 value I could disable the check altogether
I like that. Fixed.
Да и почему бы вообще не написать вместо исходного if'а и этого всего как-то так?

    if (avatarUrl.isEmpty ())
        avatarUrl = ProfileData_.AvatarUrl_;
    if (avatarUrl.isEmpty ())
        return;
Ah, sorry, I meant `autoescape`
I guess those can/should raise other exceptions than "No such JobId", so that's why you've moved them outside that try/catch, neat.
Agreed. Modified method_missing. We do get this behavior for free for values inside the properties loaded from YAML. These changes are necessary for settings loaded in line like

```ruby
Figleaf::Settings.configure_with_auto_define do |s|
  s.property = true
end

puts "YAY" if Figleaf::Settings.property?
```
Can you do a search for System.out.print and delete those lines?
please add a log message here
This is taken care of in the create_users migration.
:) I see you got your 'any' in here.
Rather than attach "req" to Flavors in the model, which brings a WSGI component into the controller/view agnostic model code, just return flavor.links from the links property.  Then put this more complex code into view and force it to always use the req property which is required in that item's constructor.
Could you expand a bit on this comment?
Like if your code is making any assumption on this value, or if it just is a sensible default, does it need to be exactly like _QueryHits.DEFAULT_TOP_DOC_RETRIEVAL_SIZE_ ...
This doesn't seem more readable to me.  It took me a couple of reads to realize that one branch is "with_font" and the other is "mathtext". A ternary expression here might be easier to read.
>This is an example of some of the inconsistencies that have developed over the years with defaults.

This is exactly what I was referring to.

>However, in this case, there is no rcParam to refer to.  So long as it is clearly documented what a transform of None means, I am fine with this.

Awesome. So `None` _should_ mean "go to the rc param". If this is the case then since, as you point out, there is no rc param to default to, I am happy with this approach.
Ideally the line should be wrapped to 80 characters.
My B!
Wouldn't `max(...)` work instead of `sorted(...)[-1]`?
Can you add some kind of processing so that there's not `(\b|\()` in front of so many lines? Maybe have a separate dict that gets `.update(...)`ed into `js_patterns` that has something like `js_patterns.update(dict("(\b|\()" + k, v for k, v in prefixed_patterns))`?
It has to be here or else I can't access testvars. I've moved the bulk of it into GaiaData
What would you think about adding more details in the doc? For example:

```
/**
 * APIProperty: preserveCenter
 * {Boolean} Set this to true if you don't want the map center to change while pinching. For
 * example you may want to set preserveCenter to true when the user position is being
 * watched and you want to enable zooming in and out while preserving the user
 * position on the center of the map. Default is false.
 */
```
If don't see why

if (extension_loaded('apc')
    && isset($GLOBALS['cfg']['Server']['StatusCacheDatabases'])
    && ! empty($GLOBALS['cfg']['Server']['StatusCacheLifetime'])
) {

is less readable than 3 if's.
Besides, there is no reason to have 3 if's if you're just checking the 3 statements and do something if all of them are true, and not handling the other cases. This just makes the code more complex.
"bad habits" from strongly typed languages. I will remove this function and check the tests.
@jsloane Can't we rely on an other property, is this something that Modernizr could solve for us?
I don't follow why this service should activate immediately. What was the motivation here?
Use <> include here - it may cause some compile-time glitches
the Relaxed tree is formulated on top of binary SVM. So it requires the sub-machines to be SVM and it uses the SVM parameters in its own algorithm. That's why I'm making those parameters for the RelaxedTree machine.
here comes the non-STL version. @vigsterkr why CMap doesn't have a function like set_element(key, val) or so?

btw: I'm still wondering what "urgs" mean...
No need for regexp. `String#startsWith` is enough (and faster).
"applications" -> "application's"
Yes, ´ php composer.phar validate´ complained about it.
Be fixed.
Please surround with brackets
Sorry... see my error now.
create Methode fehlt noch
Da gehts ums Exceptionhandling, das ist erst provisorisch. Ich werde das ganze mit dem StatusService abhandeln, aber das will ich gerne in einem neuen Branch machen, nach dem das ganze gemerged ist.
кажется, кодировка в 1.9 задается с помощью 
# encoding: utf-8
Shouldn't we prevent confusion with contributing to Studio itself?
O no no. You will not translate strings like this. Learn how to interpolate strings with translation in JavaScript in Django.

Don't do `<a href="#" >` links because they might destroy information we might have stored in anchor/hash.
Well merging was awfull, so I just use previous file. My mistake, sorry.
Hmm I hope "C/P" is ok. :)
Move this file to `piplmesh.frontend`.
In django generic forms, every label is uppercased. I think we should leave it like that.
I am having problems here, because if I change this
<code>"{{ STATIC_URL }}piplmesh/images/logo-{{ LANGUAGE_CODE }}.png"</code>
into this
<code>"{% static "piplmesh/images/logo-{{ LANGUAGE_CODE }}.png" %}"</code>,
the *{{ LANGUAGE_CODE }}* variable does't work.
Too much copy-pasting.
I think this should be done at the provider level.
No, we can always have in JavaScript code that if a post comes from an user for which we believe is offline, we switch the user to online. :-)

And yes, if you check Facebook, you will see things are sometimes inconsistent. But users do not really care. Much better is that things work!
I see, you read only my first comment and not my additional comments or changes to them. :-) I corrected myself, e-mail notifications are not always correct here.
If time is `None` will this turn into invalid js? I would recommend using something like
```
setTimeout(function() { $("#error").fadeOut(500) }, {% if time %} {{ time }} {% else %} DEFAULT_TIME {% endif %} * 1000);
```
and then set `DEFAULT_TIME` to something sensible.
Is this no longer necessary? It looks like the cleaning still removes the saves and morgue directories.
shouldn't it be `RedactorRails.picture_model.respond_to?(:user_id)`?
remove: #include "Group.h"
Even better, may a generic spellscript for those spells.
So hoch? Sure? Config find ich gut. Was hälts du von 60'000?
gehört irgendwie nicht dahin. z.B mit Before After Pattern.
ok good to know.  Also, what version of the `pg` gem are you using?  I'm interested to know *where* this change has occurred, if it's the gem or the db itself.
You are right, I put it there as a reminder to myself, but it is now implemented as a timer and works nicely. I will remove the comments
the proper way to initialize context is to read all other values that could be possibly set already.

```python
context = self.get_context_data()
```
Indentation. Where is this language string used?
L<pf::SNMP::Motorola> will automagically link to the right file on our online documentation. Use that instead.
s/browser/window/
Ahh yes you are right.  The way it is implemented it is equivalent to a
do
{
}
while(c!=0)
loop.
Please use parenthesis with ternary if, especially if you have two of them.
Indention is wrong as I added parent to WebView. I will fix it.
Should clone the $blobProperties, otherwise changing this object will also change the input.
Does this set rtt in the case of a timeout?  I agree we should be setting rtt regardless of the response, but not if there is not response.
You like typing, don't you? I would've just used $0. :-)

All kidding aside, LGTM.
here what?
Btw, we have Travis CI (a continuous integration system)  set up for this project. That means you can run specs on [travis-ci.org](http://travis-ci.org/) for your fork of the project too. Just go to this site, sign in with you GitHub account, flip the trigger for `twitter-cldr-rb` project in your profile and push smth to your fork. Right after you push changes to GitHub it'll notify Travis CI which will immediately clone the project and run the specs both on 1.8 and 1.9 rubies. I do most of the development with 1.9 and emails from Travis CI is how I usually notice that I've broken smth on 1.8 ;)
Minor stylistic thing but visually it's tough to find the 'else' of the if ( 'localStorage' ... ) since it's so far away. I dunno how to fix that (sometimes I'll negate and put the 'else' cond at the top) but it does make it a bit more difficult to read. Dunno if the negation will over-complicate it, though.
Really a Quilting result? This really is taking lambs to slaughter.
OK, I like that.  If there are no objections I fix and let you know when this is pushed...
Very clear, thanks for this Mike.
I removed the ipdb cruft and re-merged against master, manually tested, ran
the unit test suite, and re-pushed (-f) to the same branch at origin. There
are currently no merge conflicts on the branch, @sefk.

Jenkins is re-building and we should see what it thinks soon.

On Sat, Dec 8, 2012 at 9:02 AM, Jason Bau <notifications@github.com> wrote:

> In main/c2g/models.py:
>
> > @@ -1844,6 +1836,16 @@ class ExamRecordScoreField(TimestampMixin, models.Model):
> >      associated_text = models.TextField(null=True, blank=True)
> >
> >
> > +class CurrentTermMap(TimestampMixin, models.Model):
> > +    course_prefix = models.CharField(max_length=64, unique=True, db_index=True)
> > +    course_suffix = models.CharField(max_length=64)
> > +    def __unicode__(self):
> > +        return (self.course_prefix + "--" + self.course_suffix)
> > +
> > +class StudentExamStart(TimestampMixin, models.Model):
> > +    student = models.ForeignKey(User)
> > +    exam = models.ForeignKey(Exam)
> > +
>
> These classes _are_ in master. I made the model class definitions in
> master and then "backported" to fall2012-master, precisely because we'd
> have two codebases sharing one database.
> … <#13b7b781b9c70870_>
> On Dec 8, 2012, at 8:48 AM, Joe Blaylock <notifications@github.com>
> wrote: In main/c2g/models.py: > @@ -1844,6 +1836,16 @@ class
> ExamRecordScoreField(TimestampMixin, models.Model): > associated_text =
> models.TextField(null=True, blank=True) > > > +class
> CurrentTermMap(TimestampMixin, models.Model): > + course_prefix =
> models.CharField(max_length=64, unique=True, db_index=True) > +
> course_suffix = models.CharField(max_length=64) > + def __unicode__(self):
> > + return (self.course_prefix + "--" + self.course_suffix) > + > +class
> StudentExamStart(TimestampMixin, models.Model): > + student =
> models.ForeignKey(User) > + exam = models.ForeignKey(Exam) > + But I just
> realized it may look like it came in from master because you merged my
> other PRs which also had this commit on them, so it may have derived from
> someplace else originally. The other likely candidate is perhaps this
> change made it into dca_work_new right before I pulled. That makes sense
> actually because he was starting to work on the exam things on this branch
> just as I was setting up to work on parent/child, and I wasn't particularly
> discriminant about which commits I pulled in from him. There must be some
> one-liner to say 'follow this commit back and tell me where it started
> from, no really'. — Reply to this email directly or view it on GitHub.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Stanford-Online/class2go/pull/1450/files#r2357046>.
>
>
It took me forever to figure out how the live_datetime was making it from the POST parameters into the created objects.  @kluo helped out with this -- whenever you create a `modelForm` with an `instance=` kwarg, which happens a few lines above this, django automatically populates the instance object field properties with the corresponding values from the POST.   This is dark magic, because these values are not explicitly being set anywhere, and in fact new_video is only used as an _input_ parameter to a function--but it's being mutated by that S3UploadForm constructor.  So it's very subtle and hard to figure out where live_datetime is being set, but it's in that S3UploadForm constructor.

(OTOH, I could try to use this in exams.views to make my code more terse, actually).
Int -> Float?
If using "alwaysRun", you don't need to specify "groups" (because alwaysRun means all groups). Personally, I like to always say alwaysRun for before and after methods (I've been bitten before where someone marks a test as group \@Integration, e.g. because it's slow, but the before/after methods didn't have alwaysRun...)
Extremely minor: I'd declare field as ConfigMap so that we don't leak out implementation classes as much. Is it used as a BasicConfigMap in any sub-type (given it's protected)?
This is what I get for quickly porting JavaScript.

Definitely agree on dropping the extra parens, and (obviously) discarding semi-colons.
There is lot of such code. I don't want to change it as much as possible, because a bug may occur.
Such as a code that uses an array[1] for a pointer can work even in D.
Ideally, I think let's call it Apache Cordova, and say that Phonegap provides an easy to use bundle.
Please don't hardcode this. Instead use I18n.
But not XHTML
That's on purpose, the settings in bitcoin.conf and the command line *always* override settings in the UI. However, if you change them later on in the UI, they will end up in the QSettings as normal.  Which are overridden again on next start, **if** the user keeps them in the configuration file/command line.

I think that is the right behavior, as only advanced users will change bitcoin.conf and the command line, and they know what they're doing. It allows you to override settings such as proxy and upnp from the UI settings before they are used (when you edit them in the UI settings you're too late, networking code already started).
Can't you just do ```vectorLayer.destroyFeatures``` here?
Sa scoti ghilimelele si sa pui la inceputul fisierului o descriere despre cum ar trebui sa arate o configurare OK.
Do we want to add the individual authors here?  Typically we've put the project name.
This is the global message object for the all GCS. It is done the same way for the board manager and telemetry manager for example.
You can rewrite your commit message with "--amend" option:

    git commit --amend

Change the message in the editor, save and exit. Then you just push with option '-f':

    git push -f patrickatamaniuk tests/sidebar

A pull request will be updated automatically.
This is a somewhat evil kludge to deal with some floating point rounding errors which do not affect gameplay but DO affect test runs. Because I was having trouble isolating all potential sources of error and the floating point errors do not really affect gameplay, I decided to marshal a World object during one of the successful test runs. The problem with this of course is that it masks an underlying problem that may lead to unexpected results in other places.
Looks like you want to bind that.press to button.click instead of wrapping a call to it.
Why did you set <code>search_term=""</code>? My personal preference is the tests that use this method must provide a string to the method even it is an empty one.

Please add a docstring for the available parameters for <code>search_term</code>, <code>click_arrow=True</code>, and <code>click_arrow=False</code>
these locators apply only to self._app_validation_status_locator so it has no use to add them as class variables if we use them once here and never need them again
Same comment about timezone.now()
I'd suggest changing this to something like ```bigImage = sizeX > 3000 || sizeY > 3000;``` or ```bigImage = sizeX * sizeY > 9000000;```, as right now an e.g. 200000 x 2048 image would not be flagged as a big image (when it really is).
The standard deviation for the color range a user passes via `sigma_color` is always in respect to the range of values in the input image. Though, `img_as_float` changes the range of values and `sigma_color` would not be correct any more.

I hope it is clear now?
you could avoid this list comprehension with pure numpy and broadcasting
This is a cython API change on positional argument so I don't think it's a problem. However I would have preferred to have them in a separate PR to be able to merge separately and review the meat of this PR separately. But this is no big deal.
I guess we need to alter this to make use of $use_testing in some way, since we'll need to know what repo to use for Debian, just the same as for Redhat...
Name the va_list parameter also.
Why the space?
done: http://d.puremagic.com/issues/show_bug.cgi?id=9072
Used macro to hide size statement
Its for unit testing only. you can provide -t or -t with ndk path.
We cannot change the background colour of the controls. Only the containers can have a background colour.
messages for all of them
Validation errors be gone!  It does not work to set `self.fields['email'].validation = []`, the error message still shows up.  I don't know why.
> I think it should be banned

Yes. Or people will start using this side effect to create empty superfiles and do weird things with it... users...
Since we're never interested in things that are not in `kwargs` I think you should do this:
```
if p not in kwargs: 
    continue
```
Does it make more sense to override the existing `initialize_schema_migrations_table` method for this? (https://github.com/rails/rails/blob/3-2-stable/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb#L429)
Actually it shouldn't be there at all anymore, fixed.
Well -  there isn't a preference. See the discussion here:

http://projects.puppetlabs.com/issues/5013

I would say that its probably better to be absolute on Solaris - especially in the case of a Solaris specific command that _shouldn't_ change. Linux/BSD stuff isn't all that simple due to all the different flavours.
@cursedcoder  - I'll do that today. Sorry for the delay.
Can we get this in an external JavaScript file?
Is there something else we could wait for instead? somethings needs to load or anything else?
That makes sense. How will we deal with minor variations in 2013, for example? Review the warnings, add the new awards, then re-parse the new awards?
no need for ordered here: you only have one subdir and this will (inadvertently) make it slow when you add more.

the correct way to do things is to use .depends on a target, btw, not use ordered builds - except as a last resort
it looks like concurrency is not actually used. I dont really like the idea of a class param that is only used to capture a fact to set as a default for other class params. In fact, I am not entirely sure that using class params as the default for other class params is fully supported.
If you want a shorter line length for msftidy that's your business, but many, many modules need 100+ columns for line lengths for things like long, static regexes.

You can make an argument against that, but contriving to fit into 100 columns is not usually a good use of anyone's time.
The Narcissus' quote I think should be out