labofsahil/github-event-dataset-2012 huggingface dataset:
I tried following --

```python
from sympy.ntheory.residue_ntheory import int_tested

def igcd(a, b):
    """Computes positive, integer greatest common divisor of two numbers.

       The algorithm is based on the well known Euclid's algorithm. To
       improve speed, igcd() has its own caching mechanism implemented.
    """
    try:
        return _gcdcache[(a,b)]
    except KeyError:
        #from sympy.ntheory.residue_ntheory import int_tested
        if not (a, b) == int_tested(a, b):
            raise TypeError("Can't convert input arguments into int")

```

It gives the following error

```python

hector@hector:~/sympy$ bin/isympy 
Traceback (most recent call last):
  File "bin/isympy", line 341, in <module>
    main()
  File "bin/isympy", line 334, in main
    from sympy.utilities.exceptions import SymPyDeprecationWarning
  File "/home/hector/sympy/sympy/__init__.py", line 49, in <module>
    from sympy.core import *
  File "/home/hector/sympy/sympy/core/__init__.py", line 8, in <module>
    from expr import Expr, AtomicExpr
  File "/home/hector/sympy/sympy/core/expr.py", line 2913, in <module>
    from mul import Mul
  File "/home/hector/sympy/sympy/core/mul.py", line 1545, in <module>
    from numbers import Rational, igcd
  File "/home/hector/sympy/sympy/core/numbers.py", line 13, in <module>
    from sympy.ntheory.residue_ntheory import int_tested
  File "/home/hector/sympy/sympy/ntheory/__init__.py", line 5, in <module>
    from generate import nextprime, prevprime, prime, primepi, primerange,\
  File "/home/hector/sympy/sympy/ntheory/generate.py", line 617, in <module>
    from sympy.ntheory.residue_ntheory import int_tested
  File "/home/hector/sympy/sympy/ntheory/residue_ntheory.py", line 1, in <module>
    from sympy.core.numbers import igcd
ImportError: cannot import name igcd

```

whereas if I import within function, it works. 

```python

def igcd(a, b):
    """Computes positive, integer greatest common divisor of two numbers.

       The algorithm is based on the well known Euclid's algorithm. To
       improve speed, igcd() has its own caching mechanism implemented.
    """
    try:
        return _gcdcache[(a,b)]
    except KeyError:
        from sympy.ntheory.residue_ntheory import int_tested
        if not (a, b) == int_tested(a, b):
            raise TypeError("Can't convert input arguments into int")

```
No, because the `_eval_expand` methods are defined on Expr, not Basic.
Why did you remove the ; at the end of the output string?
I'd prefer `if (!name) { name = this.name; }` rather than always doing the assignment
Does this change what we get when we do http://quadbase.org/questions/qXXXX.json?
It's not now.  Earlier on in the life of the patch, it was used to name a new partition in a verification step.  Removing.
the driver's reuse.
`|safe` should only be used for non-interpolated strings that contain HTML (e.g. `_('<span>Firefox</span> Documentation')|safe`). If `submission_creator` returns HTML, it should be wrapped in a `jinja2.Markup` object, and instead of the `|f()` filter, use `|fe()`. If it doesn't return HTML, use the `|f` filter by itself, without `|safe`.

Nit, and I'm not sure on MDN, but most of the time our style is not to use spaces around the pipes when using filters.
nit: maybe get_descendants to be more explicit what's happening?
Won't this trigger unused variable warnings?
I'm guessing you had a bad rebase :) ?
Je n'aime pas trio ca nonplus les boites de texte parce que c'est pas responsive.
Can you static import Assert to be consistent with the rest of the file?
One per line. protected?
Hmm, well the only other place that gen_forum_auth_level is used it was preceded by $s_forum_rules = '' so I assumed it was necessary due to the way the function worked. I've looked at the function source though and I can't see $s_forum_rules used at all. I went ahead and removed line 173 from my patch and it didn't seem to affect anything so I will go ahead and remove it from the commit now.
or `assertCount` even.
Why not pass it to the event?
isset() checks if the variable is set and not null.
If I didn't assign any value to the variable, then it will not have any value different than null.
@brunoais That has already been said.
You can (and probably should) use UTF8 in language files. Also, I have the feeling such an entry already exists.
It turns out you don't need to assign language variables like this. All language variables in `$user->lang` are available in templates with the `L_` prefix, e.g. `{L_PLUPLOAD_SELECT_FILES}`. As such you only have to load the language file via add_lang() and you're done. The changes to the user class are probably not necesarry either. Sorry for having missed this.
Use multiple shorter lines.
I believe this line should go away, right?
Seems like another thing that appeared with the rebase for some reason.
As Erik pointed out in a reply to the wrong comment, yes it can. https://github.com/phpbb/phpbb3/pull/995#discussion_r1652584
thanks, will fix this
Lets submit an issue for this, and link to it from this comment.
Commented out code in a couple of places
This should return an error (e.g. -1) or throw an exception. The calling method handle the error code / exception appropriately, rather than "quietly" failing with a console.log statement. 

Given that this was also seen above, we need to be consistent about using error or exception (making it easier for programmers to be prepared to handle errors).
ideally should continue to use HOST, which could (and will!) change
FYI: As much as possible, *Dont* include styling details at this point. We want to use Sencha / ExtJS4 defaults, if possible and appearance is good. If needed, we can customize, but I believe the proper way to do so is via CSS, not inline in the code.
I removed 3 items from this section as they are all described in the main body of this page, so not "Other changes".
Could/should we check ```lat_dims == lon_dims```? Might be overkill.
oh, I forgot about this comment...
No, apparently it's completely useless. At the time I committed it I was not sure.
I can't find any substring anywhere in that query, so it should be safe to remove it...in case we can revert the commit later. :P
last_name, first_name
Make sure the case of the string is right for what is in the database
Reverse the if clauses to avoid "not" in the condition.
Yeah, that’s better. I’ll update it.
sorry, I meant "this file is 'missing' the currentmodule annotation."

I'd add this to the top of the file:

.. currentmodule:: django.contrib.auth  (or include .models if you want to omit it throughout the rest of this doc)

Unless you decide on what to do, I think we can ignore the issue of CustomerUser not being an actual model for now.  I'll be happy to clean that up as part of  #19516
For the reasons explained above, I would avoid `force_str` if possible. For instance, it's to override `test_dir` with a native string version at the top of the function:

        test_dir = os.path.dirname(os.path.dirname(__file__))
        project_dir = os.path.dirname(test_dir)
        base_dir = os.path.dirname(project_dir)
What if len(part)>max_index_name_length? Say, Oracle, and len(column_names[0])>21?
description needed.
Another future TODO: we should think about if we can turn there types and functions into abstractions instead of just ways to share code. For example: is `InstallArgs` a useful concept on its own? What does it represent?
[..xs] is a tuple of references. Let it copy. Deferenced values are moved.
I didn't do as in your email because didn't know how to change 'return x + closure.a^ + closure.b^;` to `return x + a + b;`
Right.  I was just too lazy to do it.
getAs<int32_t>() sounds like something that checks (signed) integer, but I'm not sure, either.
Indents fixed to be consistent with the rest of the file.
On Tue, Sep 11, 2012 at 6:34 AM, Will Kahn-Greene
<notifications@github.com>wrote:

> In fjord/analytics/helpers.py:
>
> > +@register.function
> > +def querystring(*args):
> > +    """Build a query string from fragments.
> > +
> > +    This allows for a default or current mapping that is then specialized by
> > +    specifics, such as a page number.
> > +
> > +    >>> querystring({'page': 1}, {'platform': 'Firefox'}, {'page': 2})
> > +    page=2&platform=Firefox
> > +
> > +    """
> > +    total_query = {}
> > +    for query in args:
> > +        total_query.update(query)
> > +
> > +    return '?' + '&'.join('%s=%s' % (k, v) for k, v in total_query.items())
>
> funfactory.helpers has urlparams which does this sort of thing.
>
`funfactory.helpers.urlparams` has a slightly different behavior than this
function. This function allows you to pass many dictionaries, that will be
considered in order, with the last one being the highest priority. Also it
works indendent of urls, which is useful for me.

That being said, I'm a big fan of using other people's code, so I will see
if I can use `funfactory.helpers.urlparams` instead.


>  —
> Reply to this email directly or view it on GitHub<https://github.com/mozilla/fjord/pull/24/files#r1576369>.
>
>
here I directly go and check if the sdk is a valid one by looking for make. Since we use make to check if `/usr/bin` is "ok" it is sensible to do the same for the SDK. Now, of course `File.directory?` is implicit.
Is an `unless`-expression possible?
I'd like to keep the `--no-framework` for @Sharpie. He loves the unix build. And he obviously doesn't use wx :-)
@jacknagel what a damn cool feature. But honestly, `grep` is among the worst ways to doc something :-)
Heya, it does make sense; actuallay I was stuck for a while till I figured out that it was a dict of ids. It makes the test harder to write, which in itself is a sign that something is wrong. :)

I won't have time to look at this for now, so feel free to apply it and we can revisit later, or to make the changes yourself, or I will make them probably at the weekend.
We probably want to specify the `timeout` in the `ApplicationTestCase`
This is awkward, and I think actually incorrect. First of all, binding a function and then executing it is the same as executing it directly, possibly via an `apply` or `call` method, at least semantically. So the first improvement here would be:

``helper: function (options) { return componentHelper.helper.call(this, options, 'container'); }``

Now, what does ``this`` reference ? The exported object, since ``helper`` would be called directly on it. If you look inside the component helper, it writes/deletes properties on the ``ComponentHelper`` class instance that is created on the spot. This is also strange and surprising, since that object is shared, but we're not talking about that now. So those properties would be written/deleted to/from this exported object. Is this the intented behavior ?

Thanks.
That's a bit of an unintuitive tri-state; could you please revert the structure to something similar to the original, like the following, so it's clear that the `None` is a key factor in the logic:

```
if self.wiki_override is None:
    return True
else:
    return self.wiki_override
```

(or consider refactoring)
Improvement:

Given a command, decides whether it is ready for execution, as opposed to being unfinished, such as missing a closing brace.
Ahh, that's not you losing the formatting, it's github. Github doesn't know how to escape less than signs! Garbage.

Instead of Set{T} extends Binding{T}
do
Set{T} extends Binding{Set{T}}
that way you can make contributors typesafe.
Hmmmm . . . . should this be more fatal? What were we doing previously?
不配置~/.Renviron的原因在于解决多个R并存(比如/usr/bin一个，/usr/local/bin一个，HOME里面还有个)，但是~/.Renviron配置不同的情形。对于很多人这个确实不实用。


On 2012-3-31, at 上午12:33, Yihui Xie wrote:

>> @@ -253,5 +291,17 @@ font = TT DejaVu Sans Mono
>> language = en
>> ```
>> 
>> +Mac下需手动修改Renviron文件,比如对于X64的R,修改为
>> +
> 
> 既然不会忽略那就更应该用`~/.Renviron`啊，修改程序主文件是非常非常坏的坏习惯。不可持续发展。
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/yihui/r-ninja/pull/2/files#r629486
Did you decide not to use TypeSafeMatcher here?
@dsaff 
Sure, i can put a comment to the code.

For us here this would explain the problem more simply than FailOnTimeout.
The application does not exit unless setDaemon(true) is uncommented.


Thread t = new Thread() {
            public void run() {
                while (true) {
                    try {
                        System.out.println("run");
                        Thread.sleep(1000);
                    } catch (InterruptedException e) {
                        System.out.println(e.getLocalizedMessage());
                    }
                }
            }
        };
        /// t.setDaemon(true);
        t.start();
        t.join(1100);
        t.interrupt();
variable assignment inside conditionals is fine; it's variable declaration inside conditionals that's not. i can go either way on this one, what's here presently is probably most readable.
I think we should use the JSON form for the init(), since it's probably going to be more performant and easier to edit than a bunch of separate method calls anyway.
There's something to be said for the convenience (and readability) of a single declarative tree that shows the full menu hierarchy with keybindings alongside.  That could be done as a simple shortcut to the direct keybinding-command mapping, so it'd still be possible to have shortcut keys without menu items.

That said, I think I agree with Glenn & NJ anyway, because we're likely to want keybindings to be much more readily user-configurable than the menu structure.  If we want to do something lightweight like have an editable JSON file for keybindings (a la Sublime), we'll be forced to keep it separate from menu creation.
This 2nd check is unneeded: as long as $listItems.length >= 1, this will always be true (you're taking a single DOM node, wrapping it in a jQuery DOM node collection, and then verifying that the collection is still just a single DOM node).  Ditto for the last expect() at the bottom too.
I'll correct that. I guess I was thinking that clients shouldn't construct it directly, but that is different than private.
This values need to be updated; they are not only out of date here (latest in your Ace branch is 67d75fc, latest in your APF branch is 5fc3440), but of course once you merge those two into master they'll be different again.
Ooops!  Perhaps we should updateJoystickName(cur_joy, "none") here?  Could be that the user plugs/unplugs joysticks, and in the case of an unplug, then reset of the Lua program, the old name will still stick around .. okay, I'll fix that when I do the buttons, maybe ..
There's a reason stylesheets exist, I'd say use them unless you have a good reason not to.
We don't use the static helpers in Java 7 because they aren't needed with the new type inference for constructors.
Possibly, if they want to enable compatibility with multiple ggplot2 versions?
is there really something to do here?
If no remove the comment :-)
The main goal of this class is pretty clear thanks to the javadoc. Or not. :-p
There is no variable named 'file' anymore, before the change it contained only the file name without its path.
path = [fileURL path] contains the full path and we need only the name of the file (without its path) to produce a "betterName". Actually, I think that "betterName" should be named "displayName" so it would be clearer.
Unnecessary lines.
Can you split up any of the tests with multiple different requests into multiple tests? I try to go by the one-condition, one-test philosophy, because it helps get a more whole view of what's broken. (Eg, if the first assert here fails we never test the other ones, so we don't know if they'll fail or not).
`stores.publish.expand( id + 'e' )` should probably refer to `e` as a const.
:) Thank you.
`inherit`?
Acho que entre a linha 3 e a linha 13, a linha 3 deixa mais claro que o usuário pode mexer nesse arquivo. Acho que podemos melhorar a linha 14 porque ela não deixa claro que o arquivo pode ser alterado.
I'll clean these next three comments up once we lock down the requirements.
It seems this function could be merge into ngx_http_variable_sent_cookie().
DeclFlags are declared at https://github.com/yast/yast-core/blob/b93093f13f095e7d48eb558641f24da1fa8db7c3/libycp/src/include/ycp/StaticDeclaration.h#L46

I cannot quite parse your question, but anyway, the problem is that we haven't really agreed on whether nil is an "exception" or a processable value.
Moving this down here can potentially modify behavior in an unwanted way.  Putting it here makes it set ALL tags to type "os:DataRequest", even if it wasn't originally a PeopleRequest, ViewerRequest,OwnerRequest or ActivitiesRequest.

What if there was some other tag that wasn't supposed to be transformed to a DataRequest?
https://github.com/aporat/iTellAFriend/tree/1.0.0
When you will be checking permissions, check the WHOLE PATH from the root to the final destination. Apache needs eXec permission on them, then Read permissions, right?
Is it only needed for metrics calculation though? I can imagine cases where you do neither realignment nor recalibration (e.g. the upcoming Halo pipeline). Then, the MarkDuplicates file would be used for variant calling. "Deduplicated file removed to save space" would then suffice.
True. The next person to add an argument does that :-)
Sorry - I meant to take that out before submission.
I'll edit it out ASAP.
`../images/notifications.png`

Unless we put an images dir in this subdir.
There are a few repetitions in the examples between `client.conesearch` and `client.vos_catalog` that overlap, in case users do not bother to read the whole thing. But I can remove the repetitions if you find them confusing.
For that matter, don't use type(...) ==.  Instead use issubclass().  But  in this particular case @mdboom is right: `np.asarray` is fine here.  The later check for number of dimensions will take care of the rest.
put backticks around "cd"?
Good idea - this is done.
I try to leave a few easter eggs in the tests I write.  Consider it a scavenger hunt :)
I don't see why that distinction is necessary though, `[]` works exactly the same on strings and arrays.  While `{}` only works on strings.  Seems that in a loose dynamically typed language like php `[]` has more utility than `{}`.
Do we want combined get/set methods for these properties?
I would still prefer the view var name `_rootNode`, less typing :smile:.  Also better to name the local var `$rootNode` instead of `$root` to match the view var.
Also, I don't think you mean to call `self()` inside the spawned process, do you?
and the curly brace should be on the same line than the ``if``
`hbox` should work
A concise version of this and previous explanation would be looking good in the comment.
`if (length(setVars) == 0)` would be preferable here (and in next block).
I was thinking of this too, but there's also the issue of operator chaining: `master^2~3^{tree}`. I'm using the state machine to detect operators and dispatch the parsing operations, and `handle_caret_syntax` to parse the argument to the caret. It seems like `^3` syntax use a different state than `^{tree}` would simplify the argument handlers, but add transitions to the state diagram, which seems like a wash complexity-wise.
remove this else condition
We are discouraging this kind of var declaration, see the js style guide: http://mozweb.readthedocs.org/en/latest/js-style.html

Use vars for each line
Bedrock convention is to avoid a space between def and the method body. \</nitpick\>
This means no more stripes in expanders in IE7 & IE8 - still a big chunk of our audience. I see you kept the .expander-odd class around though, so we can still support it on a per-page basis. Fair enough.
You are not calling the right URL here.
Sorry I meant `if ($param->isDefaultValueAvailable()) {` at line 243 should be replaced by this isOptional, but I'm not sure whether that makes sense.. Didn't look at the code too much.
Can you remove the comments now this is translated?
Right here if he used a `forEach` he wouldn't be able to return from `_getBuildSHA`. Where possible I do prefer it though just because you get a new scope.
Is this endian-safe?
Opera brags about supporting the W3C syntax so if they implemented it right then it shouldn't be a problem. I've tested it as best as I could, I'll do some research and come back to this if need be.
`testOpenMethodAlwaysReturnTrue()` ?
hmm, not sure if it is automatic for maintenance releases. It may be indeed.
I would use an early return here to avoid the else and the extra indentation:

```php
if (!is_dir($bundleName)) {
    throw ...
}

$file = ...
```
Can you remove all but this method from this class?
Yes, and caught me unawares a few times already as I was trying to figure out what scrooge was looking at when it bombed out :)

Prepending the filename to exceptions also helps, particularly in non-verbose mode where it's the only output you get on an error.
okay, I have to merge this manually.
Does this work? Preferable?

```ruby
found_vote || log_error and return false
```
你不觉得如果结构是这样的话会不会骨架更清晰些：
baidu.dom.extend({
    draggable: function(){
        //draggable
        var Clazz = baidu.lang.createClass(function(options){
            //constructor
            
        }).extend({
            //
            endOf: function(){
                
            },
            //
            zIndex: function(){
                
            }
        });
        
        
        
        return function(selector, options){
            return new Clazz();
        }
    }()
});
Интересно сколько занимает времени поиск по 100 событиям?
Why are you deleting these?
I thought we were moving the logging config into it's own config file, not rewriting the logging config? The good thing about using python's standard logging config is that anyone can adjust any logger, not just the datadog ones, but if for example you wanted to see what the redis library was logging, you can just update the config to enable it.
The final parameter (that starts with a colon) should always be passed as a single parameter. Use string formatting instead of passing two parameters.
Repeated on lines 496 and 503
Seems already done in master. We should discard this one.
To be rather picky... I liked this a lot more when it was compact. (Compare: 19 lines vs 4!)   If you want to space things out a bit I'd suggest the following alternative:

```C
    if (   A.spec().format != TypeDesc::TypeFloat
        || A.nchannles() == 0
        || channel < 0 || channel >= A.nchannels()
        || bins < 1
        || max <= min)
        return false;
```
I was thinking of this code here -- doesn't this normalize again?
Yep. Move out of here and into crs.py (for now).
Needs multiple constructors, or perhaps just passing it a null list
add comments!
could it be methods fromArray and toArray on Changelog/Version/Feature objects?
uff, totally missed that one, isDeprecated used to return boolean :)
Maybe these fields can be made non-static? I wont hold up the PR merging though, for this.
This class in general seems all mixed up with EjbMessages. I have no idea what harm that might cause but it seems like a likely source of maintenance issues and bugs.
Nevermind, didn't see that one was `position` and one was size
All you're doing here is mapping from one set of constants to another set of constants.  I suspect you can simplify this and just use the device storage constants without defining your own.  If you don't use the change handler, then you won't need the INIT state. You may not even need to save storageState at all, just check it before accepting a transfer?
There is a comment above said: "want to be responsive to user input", so we don't need this any more?
This *will* create issues when I’ll optimize the `l10n.js` library, that’s why I was suggesting to re-open #5680.
Why do we need this check?
ok I know but it is a lot of work and I thought this pull request is a good point to start the bookmarks. OK this could be other issue and other person could implement it
`Settings.openDialog()` will check a form and handle reset/submit actions, which is useless here AFAIK. You probably want to use the generic `openDialog()` instead.
Same as before ;-) Already rems :-)
Are you confident that this line works even though you don't wait for an onload event?  It would be safer to put all of this inside an onload() handler.
pending = 1? We probably need to refactor load...
@aymanmaat 

1) For me it's an option that wont happen that often (the fact of changing from SIM to SIM, without restarting the phone, currently is impossible). Adding a listener just for that IMHO is a bit overkilling

2) If no SIM, right now we don't show the option to import from SIM, it's totally hidden.

Cheers!
What about using classList.contains instead of className == ?
Indent issue, this should be

    if (LockScreen.locked) {
      this.setIdleTimeout(10, false);
    } else {
      this.setIdleTimeout(this._idleTimeout);
    }
    return true;

There is a tab at L230
This cuke looks great to demonstrate the usage of the `query_parser` config option.  I think it would also be good to add to the [request matcher README](https://github.com/myronmarston/vcr/blob/master/features/request_matching/README.md) and maybe a cuke in the request_matching folder for the new `query` request matcher.  Thoughts?
exe.EnvironmentVariables["GIT_SSL_NO_VERIFY"] = "true";
Should be in resources
fixed :package:
This is only checking one direction of the "iff"
This might make sense in the companion object for the Monoid itself. I guess everyone will redo this.
Do you need override identifiers for the abstract methods of KeyedList?
Straight-up laziness.  I realized that this trait doesn't care about the Fields object at all, and I simply differed it until where it was used. I can make it concrete if you prefer. Just say so.
Well, it was always Mappable so you could just operate on the string in each line.  You can easily imagine a non-file based TestLineScheme.  For instance, it could be an in-memory list of strings.  Taps abstract the storage mechanism, schemes abstract the mapping of tuples into that storage mechanism.  I don't think it is strange to have TextLines outside the context of files.
this log statement doesn't reflect a real method call.
No need to call floor on the devision:

````
>> 10 / 3
=> 3
````
Maybe make the comment more specific? What kind of config file is this? Are you making a config file for the provided app name (as it says), or are you generating a nginx configuration file that routes users to App Engine apps via a full-proxy configuration style?
Document these fields.
On Nov 19, 2012, at 8:28 AM, Navraj Chohan <notifications@github.com> wrote:

> In InfrastructureManager/agents/__init__.py:
> 
> > @@ -0,0 +1 @@
> > +__author__ = 'hiranya'
> Our other option which I'm now leaning towards is not having this information, similar to other popular projects (hadoop, cassandra, etc). The authors can be tracked by github instead.
> 

+1 to that. In fact putting developer names in source files is prohibited by the "Apache Way". That's why you don't find any developer names in the source files of Hadoop, Cassandra etc. Putting the license header is mandatory in that model though.

Thanks,
Hiranya

> —
> Reply to this email directly or view it on GitHub.
> 
> 

--
Hiranya Jayathilaka
Mayhem Lab/RACE Lab;
Dept. of Computer Science, UCSB;  http://cs.ucsb.edu
E-mail: hiranya@cs.ucsb.edu;  Mobile: +1 (805) 895-7443
Blog: http://techfeast-hiranya.blogspot.com
Remove the "a".
This would be a good place to check the libvirt version and/or help content, then throw an exception if the requested unattended method is incompatible.  In the exception text, it would be helpful for new users if it suggested the working types i.e. url
You should be using a named url pattern here, not hard-coding the URL.
i was thinking we'd want this but wasn't sure -- glad you agree and have added it
Moved the saveTransaction so it happens after the spawner is successfully sold, so if there is an error before it's sold, it does not save it
Ah, but I see that I forgot to move it to setUp()
I'm not sure that it makes sense to watch the log ... typically there will be builds running, which make take a while to complete, before the build is complete. In any case, if you do display logs, you should update this comment, and make sure that `LogWatcher` is watching the appropriate things for this.
Oops too far indented.
can't remember now but have a weird feeling that we needed this change because it was making `require` die when we loaded bean. `curl` might not have a problem, though...
moved events to a method to allow for user adding/removing
`sponsor.website` may be blank. Don't make an `<a href>` with no URL.
That comes from upstream.

See: https://github.com/joomla/joomla-cms/blob/master/administrator/components/com_menus/access.xml
ワールド！！
We need reverse engineering in order to understand this code. I think there is too much deconstruction here.
There is multiple options here. Here is some: give a name to the second argument, or use more than one word name for `base`.
Can you please define constant for this magic number ?
nit: I know it is a code already in place, but `response` ends up being used only to store `request`. On the one hand, the convention to use same Base class name with a lowercase makes sense, on the other end, we end up with weird mixes like this one and we are using `response` with a lower case as a simple variable in `onreadystatechange`.
It is not a big deal, just in case you hesitate with another naming.
Would be nice to mention combinations too like what will `[ 'top', 'existing' ]` do.
Mind getting rid of write?
ok. understood!
just me being OCD but `fast {` :D
have added to ElementInterface
use a getter here instead for the dateTimeFormat.
Exist the posibility of pass `null`  in such case hmac throws a couple of warnings and return false
What is type for?
it would be better if you put a dash here chart-{{ id }} so the code looks not chart1 chart2 which is a bit unnatural but more like chart-1, char-2 which for ids seems better? not sure just a suggestion already saw this was merged so it may be too late.
why not adding the ``/`` in packagistUrl variable ? And btw, why adding a variable for it as you use it only once ?
@stloyd is right about the CS :)
Just talked to David Ebbo. It's not controllable with the current version of T4MVC. He said he'll fix it in the next version. :)
When is this supposed to be called?
diff should be output from JSON.parse so it won't suffer from poisoning.
This makes me think we can share this logic between the pdf generator and this one.
This might be better in the outermost `before`, just to be safe.
Or try checking if the role_model class exists rather than using "isset"
Fixed in a4ef0e7.
date('N') palauttaa ( 1 - 7)
yeah, not sure how much control flow/conditionals I wanted to put at the top of the file

This would presume that 'default' is not memcached or something, which is a valid assumption. I'm fine with saying COUCHEXPORT_CACHE must point to a CACHES key.
no. You need to register an autoloader for the Symfony namespace, but you should not target a Doctrine folder for this as it will not be installed in ``Doctrine/Symfony/Component/`` when installing through PEAR now
they are also missing here
I would probably extract the wildcard block into a new class.  The DSL should check wether a wildcard block or a legacy block is required. The wildcard block should then handle both cases (legacy with block arguments and the accessor through the context)
and make functions add_cn and modify_cn and use those here
don't add this, we already have a Python-2.7.3 example, should suffice
I think we discussed that normally, imports should occur at the top of the module, not somewhere in the middle. So maybe extract this function and put it in its own file. I really do not like it this way.
Indenting and whitespace is cocked up in this file
The same comments about glDeleteShader apply here as well.
Shouldn't we do this in all browsers? If it isn't a mousemove, we should consider the movements to the 0 everywhere it seems?
This worked on OS X, I didn't test on other systems, sorry :) I just tested your change on OS X and it seems to work with uppercase CURL as well.

On 24 Jul 2012, at 12:42, Kai Nacke wrote:

>> @@ -97,6 +97,11 @@ list(APPEND CORE_D ${LDC_D} ${RUNTIME_DIR}/src/object_.d)
>> file(GLOB CORE_C ${RUNTIME_DIR}/src/core/stdc/*.c)
>> 
>> if(PHOBOS2_DIR)
>> +    #
>> +    # Locate curl.
>> +    #
>> +    find_package(curl REQUIRED)
> 
> This line gives an error on my Gentoo system. Looking at cmake 2.8, the module is named FindCURL.cmake. I had to rewrite the line as `find_package(CURL REQUIRED)`. Is this a problem on other systems, too?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ldc-developers/ldc/pull/144/files#r1226833
my intuition here is preferring a secure default that generates errors to an insecure default that is transparent. maybe should put in an assert for this though.
And `assertNotContains` I think, is the counterpart.
Would you mind moving inline JS to a separate file and update this PR? It helps keep the code cleaner and better. I also noticed that you use inline JS in other parts of register.html, please update these too. 

Thanks!
This feels like it's fighting Backbone a bit. I think there's value in using a framework in the way it expects to be used instead of building a lot of plumbing around it, but then again Backbone's views are weird so I can understand the temptation. Still, something about this makes me uneasy.
Your self.down section is backwards - you actually want to remove the unique one and re-add the non-unique one.
oh, and while I personally like _ separated names, it is apparently not kosher in Java. So use a combination of shorter name (move text to assert), and CamelCase.
right, merging...
Backticks around variable name
My hope is that if this pull request is accepted you can simply elide this change.
```php
<?php 
$filter = $input->getOption('filter') === 'include';
``` 
is better.
I'm more than happy adding additional authors, and people claiming credit this way.. BUT.. I must ask to retain copyright. This is an awkward thing to ask, and I feel a bit bad doing so. Not being super clear about copyright has complicated stuff for me in the past, so I simply have to demand this.

If this really is an issue for you (I really hope it's not) I will have to rewrite this class from scratch :(. 

Sorry.. and thanks for giving credit to Lars. He was cool in the past with not keeping copyright, so I'll definitely keep him on the author property as well.
It's not just Mer, exactly the same thing happened on Harmattan.

Pkgconfig: https://etherpad.jollamobile.com/pastebin/1348656934/

QT += sql: https://etherpad.jollamobile.com/pastebin/1348656987/
get_headers function has no timeout attribute. This may be painfull for our web server under high load
`context` was not initialized to NULL.
we should use the `isResourceId` validator here.
That's a temp fix for https://github.com/sakaiproject/Hilary/issues/251
It starts with 'Create all the requests ...' but it doesn't create any request, just enable them (or not).
I'm pretty sure I use it in the preferences dialog somewhere, so it might be good to consolidate it in one place.
With the risk of saying something silly, I think there may be a way to avoid this sleep.

```scala
DebugPlugin.getDefault().getLaunchManager.addLaunchListener(new ILaunchesListener2() {
  override def launchesTerminated(launches: Array[ILaunch]): Unit = {
    // the resto of your test
  }
})
```
That's actually a 'bug' in the comment, the self type is only added when necessary, i.e. when the trait accesses class members. I'll correct the comment.
... with the exception where a valid subclass is actually a number, or otherwise very dynamic value (something that can't reasonably be enumerated for all possibilities).
оформи нормально докблок (список змінних і т.д.)
I think maybe this can be simplified, I'm tempted to say that we make this HTSP version dependant. So for HTSPv7+ we simply will return
channelIcon: /channellogo/CHANID
or something like that.

Alternatively if we need to return a fully qualified URL, then assume that the IP being used for the HTSP connection is the same as the HTTP?
`prepare_with`?
"Template represents a parsed template where all dependencies are attached through other functions."

How's that?
Yeah, I think I agree with @welwood08 here.  We should copy any objects recursively, as well.  Also, since we're only ever overwriting properties, it would probably be more efficient to use shadow objects.  Maybe something like this?  (untested)

```javascript
function copy (obj) {
  var o = Object.create(obj)
  Object.keys(obj).forEach(function (k) {
    if (obj[k] && typeof obj[k] === 'object') {
      o[k] = copy(obj[k])
    }
  })
  return o
}
```
This looks weird ... if you're using spaces - switch to tabs. :)
относительно mutatePercent - я еще не очень знаю coding conventions для Objective-C, но, возможно, percent был лучше, т.к. слово mutate не повторяется 2 раза и переменная не похожа на название метода.
Уговорили)Мне стало стыдно, переделаю)
По условиям, X-число в процентах, а не количество элементов для замены. Так что тут наверное лучше посчитать  число элементов для замены перед выполнением цикла.
Eh, let's solve that problem if we have it. Never saw anyone abusing http://www.causes.com/health/oops :)
Nitpick: whitespace ;)
can we add staging to .gitignore?
You should use the link_to helper here:
<%= link_to event.geocode_address _____ %>
Where ____ is where you want the link to go to.
You should be able to remove this by switching to rspec?
template style represents a resource not a query, and here the filter is a query.

Template styel example: /jobs/filter/engineer

Query style example: /jobs?filter=engineer

so the style here should be query not template.
The important thing for unit tests for tickets is that the test should fail before your fix and pass after.  I think this test will pass without your fix, right?  Is the problem that people were submitting only 2 digit years?  Your change should support that now, so your test should be about 2 digit years
It should be false by default. If there are no descriptions your code says a concept is valid.
Is this necessary? Why not let hibernate do this for you so that you don't have to generate all this hql
minor, but looks like we set the name if it already matches. Maybe an extra clause is worthwhile?
That theme plugin is for **rvm**, not generally for Ruby, if it hurts your feelings he can remove it and keep it in his preztorc, but I don't see how a plugin for a theme can duplicate functionality in a module.
This change and the removal of line 390 suggest that a node providing mapping on voxels does not need to provide a point-cloud map. I was thinking of requiring such a map in order to have a minimal interface to which any 3D mapper will comply. But I agree this is matter of discussion.
Mmm sorry about that. It was maybe a little too late when I did this…
You should use `::` here. It's the shorthand for:

    implement it:

        .. code-block:: php

            // the code
You also forgot the dollar sign.
没有 “且” 的关系。
I don't @tsaleh any farther than I can throw him but he [claims](http://tammersaleh.com/posts/rescuing-net-http-exceptions/) the comprehensive list is:

* `Timeout::Error`
* `Errno::EINVAL`
* `Errno::ECONNRESET`
* `EOFError`
* `Net::HTTPBadResponse`
* `Net::HTTPHeaderSyntaxError`
* `Net::ProtocolError`
OK. Just checking that my understanding of the code was correct.
If this method throw type error, I would rather raise type error with expression about parameter infomation.

I'd like to receive type error with which parameter is wrong.
I'll fix it.
Kill will simply crash the actor and make it eligible for restart, is that the desired behavior or is "context stop self" what's desired?
See previous comment about `current_user.orders.where`...
Yes, just do `"%d is not a valid hint to expand()." % i`.
I need to think about this a little bit more, but I'm not sure getBoundingClientRect is the right frame of reference in HTML speak. The returned coordinates should be consistent with absolute positioning numbers (for parity with the SVG behavior, which is in the "current user coordinates"). So, I think this code may have to looking at offsetParent, offsetTop, and offsetLeft?

For that matter, it appears that mouse events have an offsetX and offsetY property, which might be what we need, which could mean something as simple as `return [e.offsetX, e.offsetY]`, but I haven't confirmed that yet.
И тут аналогично.
емнип, mingww сannot into std=c++11
Estó es una falla mía, este segundo ítem no vá, es una taréa que parece estar duplicada, creo que tendríamos que volver a redactarla, pero con 40 sp debería ser suficiente.
hey cool, I didn't know about max_by!
array_combine might be used here
Please revert copyright year
missing a comma at the end of this line.
What value does a view give, over just being able to see the instrument listed with the others?
Man, I don't even know why I wrote this, but javadocced
But that doesn't ever match our use cases?  If we're treating the Jaccard Index as something comparable in terms of uses to the CosineSimilarity, then the input arrays/vectors will contain counts/weights for the items that were observed.  So I'll enhance the javadoc to make this clear.
Are you saying to switch back to allowing nulls or leave it as is?
actually we need both a <dependency> with <scope>test</scope> and one without
I don't think that is the case any longer. Please have a look at innerGet method of DistributedTaskPart
Looks like I did the checkin in a bit of a rush last night. I'll go back and review. I also in the "Contributing to Infinispan" documentation that I'm supposed to put all INFO level messages in the Log class, of which there's one in this pull request (MemoryUsageInterceptor.java). I'll change that as well.
Same thing. An interceptor shouldn't be a listener too. They're too competing mechanisms which should not be mixed up.
a little bit of spacing could make this class more pretty
It's a little weird to me that the property is `status` but the enum is `Type`. We should reconcile the two.
That's also a good reason. I just find it useful to annotate `copy` when the implementation is guaranteed not to mutate it. With `strong` properties, you never know – it could be an immutable instance publicly, but mutated privately.
I should also note -- it doesn't make sense to convert to tuples outside of the backends because the Agg backend benefits from having the colors as a Numpy array.
As far as I can see, this has made the code more likely to fail. Currently PNGVERSION in this file is 1.5.4 but the 1.5.4 folder only exists in the older-releases folder
Any clue what this was for?  Could there still be code elsewhere that might need a "patchA" key popped out?
it is done :)
s/alrm/alarm
Use a different exchange name
we'll need to change this in the readme to dmg_package after this cookbook's name.
This... is going to take a really, really long time.

```
1.9.3p0 :001 > Version.indexed.count
   (172.1ms)  SELECT COUNT(*) FROM "versions" WHERE "versions"."indexed" = 't'
 => 253733
```

Maybe there's a better way we can do this with S3? Some kind of export of data? /cc @geemus
@arnodeclercq Use single quotes throughout this file
@arnodeclercq we should be using the api in here `sakai.api.Util.Modal.setup`
Can you please check if that mixin was still required, or just accidentally added? Has nothing to do with the functionality at hand.
You change the meaning of $firstSelected from a string (`selected="selected"`) to a boolean in the initial value, and use it as one in the template, yet it contains a string. Is this for backwards compat, in case somebody has overloaded the template? If so, please add a TODO in the PHP logic, and mark the string usage as deprecated.
You should probably use setTitle() consistently if you start using it in an example above already
i think that you should get here entity manager form container, and use it for getting repository, and all others operations on entity. Personaly i don't like this helpers, this is always another file to read.
Actually I emit the document which contains the definition. It does make sense in case you want to remove the definition or update it.
I think the `Lookup` should not be directly coupled to one definition. I think we should have one LookupTable per mapping. If a definition has 2 LookupTables we should have two instances somewhere. @stmichael what do you think?
nice find, thanks @henrikhodne
This makes me nervous.   I think I've convinced myself it works, but finding a page with WT_REF_EVICT_WALK set, then resetting it to WT_REF_MEM so we can then re-reset it to WT_REF_EVICT_WALK feels bad.

But, __wt_evict_file() separately calls __wt_evict_clear_tree_walk() -- if this is needed, why is that call needed as well?

Can we please talk through this one?

Second, this is a good reason to fix #394, we're going to have to wait on WT_REF_READING states, because we aren't sure the page isn't modified, whereas if REF_READING meant "reading", we wouldn't have to wait.
On Sun, Dec 23, 2012 at 6:16 PM, agorrod <notifications@github.com> wrote:

> In src/include/cache.i:
>
> > + * __wt_eviction_page_force --
> > + *	Return if a page should be a high priority for eviction. The method
> > + *      does not use a session handle, since it is called from the eviction
> > + *      sort routine, that does not have a session easily available.
> > + */
> > +static inline int
> > +__wt_eviction_page_force(WT_BTREE *btree, WT_PAGE *page)
> > +{
> > +	/*
> > +	 * The number 60 is arbitrary here. It happens to be about 1MB
> > +	 * if the btree is using 16KB pages.
> > +	 */
> > +	return (!WT_PAGE_IS_ROOT(page) && __wt_page_is_modified(page) &&
> > +	    page->type != WT_PAGE_ROW_INT && page->type != WT_PAGE_COL_INT &&
> > +	    (page->memory_footprint > 60 * btree->maxleafpage));
> > +}
>
> This wasn't related to the test failure.
>
> The eviction code goes to some lengths to avoid evicting internal pages, I
> noticed that this code would negate that internal page prioritization.
>
OK.

I'd get rid of __wt_eviction_page_force() myself, it's used in two
completely different ways, and I don't see much reason for them to share
code, and sharing code complicates things rather than clarifying them.

Maybe a #define so "60" only appears in one place would be just as good?

Also, is it possible for the argument btree to __wt_eviction_page_force()
to be NULL?

Regardless, you've thought about this a lot more than I have, feel free to
ignore me.  :-)

-- 
--keith

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Keith Bostic
keith.bostic@wiredtiger.com
can you fix up the indentation in this file? it looks fine in the actual file, but in the diff it looks like there are some tab/space issues.
Good catch. Damned my copy-pasting!

But after some thinking, I'm still a bit unclear as to the difference between `exists` and `alive` in this context. They seem to be used interchangeably in the code, with the only difference being is `draw()` is only run if the object `exists`.

You can read the following in the ASDoc of `FlxBasic::kill()`:

> Default behavior is to flag them as nonexistent AND dead. However, if you want the "corpse" to remain in the game, like to animate an effect or whatever, you should override this, setting only alive to false, and leaving exists true.

If the user has done this override on the objects, would it be better to only resurrect the object if it is not alive? Or perhaps check both fields?
```
if((basic != null) && (!basic.alive || !basic.exists)
```
Or would the user override the FlxGroup as well to make sure it revives all objects, even ones that are dead but still exist? (this seems unnecessary) Is it easier to add a line to `FlxBasic::revive()` that only revives the object if it is dead? Or maybe if it does not exist? (subclasses would need to make sure they implement this as well)

I think I'm overcomplicating things here. Someone take a step back, look at the class, and let me know what to do. ;)
The assignment to ``$XmlRpcBigInteger`` seems to be dead. Are you sure it is necessary, or maybe you have a typo somewhere?
Are you sure the method ``setSimple`` can be called on ``$this->filter`` (of type ``object<Assetic\Filter\HandlebarsFilter>|null``)?