labofsahil/github-event-dataset-2012 huggingface dataset:
Removed one tab from the mentioned rows.
Still not good ;)
It was more "able".
Hmm... sophisticated.
I don't think it'll hurt. It should be possible to make the change even after we're live without much issue.
Her er samme stien definert to ganger, både i `package` og i `download`. Kan dras ut til en variabel.
Oh, I didn't explain well - I'm pretty sure the `<LUT1D>` and the 3D `<LUT>` produce identical results. The files in `testdata/iridas.zip` that contain the LUT1D match the reference image (despite only loading the 3D LUT)

The 3D LUT is always included, and if the transform is 1D, then the `LUT1D` section is also included
Why are we removing var? Doesn't that raise a new JSLint error?
This variable name is rubbish. Can we use something to make it clear what's a legacy DOM code and what's a DOM4 code?
Is there a RuntimeException thrown in this method? I don't see it.
Why did you solve this using a switch a not trough inheritance?
No it is slightly different. In ```skip?```, ShowFor.skip_blanks has to be true.
or even:

```
from textwrap import TextWrapper

def wrap(text, column_width=80):
    wrapper = TextWrapper(width=column_width, initial_indent='* ', subsequent_indent='  ')
    bullets = [wrapper.fill(paragraph.strip()) for paragraph in text.split('\n\n')]
    return '\n'.join(bullets)
```
Sadly that's not `Rails.root` but instead the gem root. The jquery-rails gem does the same thing so I suspect it's the only way to do it.
Huh.. I like more functions :)
By allowing patch, you are allowing user to change ANY field of notification object. This is probably not what you want.

You should define other than read mark fields as read-only.
(See the code on GitHub, I edited it.)
This should not be a configuration option, because code depends on it. We should request things the code depends on (e-mail and profile data).
Space before `function`.
`error`? Why not `success`? Space after comma. Translatable string.
So no need to pass values between functions through global variables. Simply define both variables and needed helper functions inside `ready`.
I have just removed the `-e` thing.

I (deliberatedly) opted to not change the 2 calls to `system` because I have not yet tested that it works with a simple `make install` (that is, in just 1 step).

Please, comment on the new version.
this is good, but you should not need the '../'. the `action` value should match what will be read in `urls.py`  which is just plain 'login/'. Does it not work that way?
Since we set the default transforms here, but select DC above, the module won't work out of the box.
Yes, I did notice that test and that particular test does not pass in my system. I am using OSX Mountain Lion with postgresql 9.2. 

Something that I have noticed is that ```full_search_path``` that is being assigned to ```connection.search_path``` may contain both non-existant as well as existant schema. Further, even if I assign only non-existant schema to the ```connection.search_path``` in rails console, ```activerecord``` does not throw any error.
`$sD-!^!` shouldn't it be something like `<radiusSecret>`
$node => $result
Should this maybe use `error_callback`? When it times out I would expect that to be called, not the default one.
this is awesome, do you think we can use it in the other places we communicate with jenkins?
Here comes the biggest part of my review:
If I am not mistaken, the random starts in stage 1 should be done in limited subsamples. That is, you must split your datasets into subsets and THEN (only then), you perform c_step with random initializations. In that case, `iin` should be a "mask of a mask" / a selection of n2 observations in a predefined subset of n1.
This raise a programming challenge because according to the (sub)set you are running the c_step on, the size of `ii2` will vary and it becomes tricky to pool it at stage2 (my above "mask of a mask" suggestion).
I am not sure I am clear enough? Would you confirm it please?
This is the main class right? At least it's the only one that's not noted as "not intended for the end user". Then here I'd expect a full description of what empirical likelihood estimation does and how to use it.
exog_full ?  (similar to exog_all)

not important (I didn't check usage yet)
I think ELModel might be better here. Lower case L's can be hard.
this line feels a little odd :/
AsmPushToken is Simple, not Complex. Complex expressions get surrounded by parentheses when used in arithmetics context, and Simple ones do not. It doesn't matter here anyway, so you can omit Is* from all Asm* tokens whatsoever.
Yea, that does make sense. Thanks for the explanation. It just cased a bit of naming confusion when one wants to map your products (really pointers) to hydrated product objects. I want to call those products too :)
please pull these out as properties so that they can be overridden.
If you're going to use a font tag, you should probably put text in it.
Mike, if I do that I get tons of things that are actually a sequence of spaces... ?

On Jun 13, 2012, at 11:49 AM, Mike Jarvis wrote:

>>             if (nargs<2 || nargs>3 || !allNumbers)
>>                 throw SBError("SBParse: Bad arguments for SBMoffat: " + args.print());
>>             double flux=1.;
>>             double beta = dargs[0];
>> -            double truncationFWHM = dargs[1];
>> -            double re = (nargs>2) ? dargs[2] : 1.;
>> -            dbg << "**Returning moffat with beta, truncation, flux, re " << beta
>> -                << " " << truncationFWHM << " " << flux << " " << re << std::endl;
>> -            return SBMoffat(beta, truncationFWHM, flux, re);
>> +            double trunc = dargs[1];
>> +            double fwhm = (nargs>2) ? dargs[2] : 1.;
>> +	    SBMoffat::RadiusType rType = SBMoffat::FWHM;
> 
> Or use ctrl-v to get a literal tab.  grep '[ctrl-v][tab]'
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/pull/189/files#r977092


-------------------------------

Rachel Mandelbaum
http://www.astro.princeton.edu/~rmandelb
rmandelb@astro.princeton.edu
I think this is a good idea. Will change it accordingly.
The new doc string for getShear makes this clearer.
... if there is demand for it?  (perhaps worth mentioning so people will think to ping us if they want it?)
this is becoming a single value TotalTax for the whole order
This is the same name as a guava class, so I don't like us using it here.
Strings2 or MoreStrings are horrible, but follow the pattern of jclouds' Throwables2 and guava's MoreExecutors.
Is it better to propagate exception here, rather than getting NPE later?
Or perhaps set field in getInstance() if sometimes the class will be loaded without ssl being used?
Delete it in this pull request. It should be used by nothing except JBoss6Server, which has been refactored here.
Perhaps better descriptions than the same words re-arranged? e.g. is this the number of bytes in the queue waiting to be consumed?
Because exist a template and a function same name on a one module, occur an error.
Rather than using the magic numbers and comments to indicate what the color is, I'd prefer to see constants (e.g. `RED = 31`).

Also, if the `color` method did something like `"\e[#{code}m#{text}\e[0m"` then your the code here that uses it could read like `color(line, RED)` which is more clear and readable, I think.
This should also check that username and password are set. Otherwise, we can't autologin/autorelogin.
Do you mean to hangup the call when leaving ?
Also, that fast_isin code extends to lists of sizes northward of 1 million effectively, so it might be useful in other contexts.
I've got another pull with them all changed to examples, but I'll have to get this one merged first.
is `clean` needed here?
Does a normal `system "make"` `system "make", "install"` not work here?
This is the only change that has me concerned because I don't understand it.  Previously this flag was only set when the object was a meta data, so that means we have changed all the normal masks to include this when they wouldn't previously.

Trying to follow the consequences of this (me thinking out loud) all of the objects will respond to the object unpacked event.  Whenever we receive an object through the telemetry link there is a call on its unpack method and objuectUnpacked and objectUpdated are both called.  Will telemetry respond to this twice now, needlessly?

To be honest I don't understand why it's even required for for meta data.

..... 20 minutes later ....

Oh ok.  Starting to see.  As your comment says, you need this event because telemetry doesn't look at objectUpdated.  That means when the object update comes in something goes into the low priority object queue, then finally gets to telemetry.cpp:427 go emit transactionCompleted.   Man that could do with documenting somewhere.

Am I right?
\o/

On Wed, Oct 31, 2012 at 5:33 PM, Daniel Passos <notifications@github.com>wrote:

> In src/org/aerogear/android/impl/pipeline/AdapterFactory.java:
>
> >  import org.aerogear.android.impl.core.HttpRestProvider;
> >  import org.aerogear.android.pipeline.Pipe;
> >
> >  import java.net.URL;
> >
> > -import static org.aerogear.android.impl.datamanager.StoreType.MEMORY;
> > +import static org.aerogear.android.datamanager.impl.StoreType.MEMORY;
> >
> >  public final class AdapterFactory {
>
> I totally agree with you :)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/aerogear/aerogear-android/pull/22/files#r1994623>.
>
>



-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
Not necessarily true.

1) You PM a player
2) You disconnect, and reconnect later
3) The player has logged off between that period, but you still have a PM open.

But, that very rarely happens so it would be better to do that.
This seems odd to me to display 8 digits.  I noticed this in chameleon.  Isn't 4 more normal?
Д.б. IllegalStateException (см. javadoc)
Метод awaitTermination
Please remove this line and squash yer commits
I believe support for custom readline could be useful to people wanting to compile their own.

Otherwise, if this change goes through, you’ll need to also remove all references this switch if php53 and php54, not just the switch itself.

Ex: `depends_on 'readline' unless ARGV.include? '--without-readline'`
I will remove this section
Yeah, I did it the same way like it was done in the other methods. I felt I should not touch it in the context of this bug, as it requires a bit more planning what's the best way to support updating the model for all operations. I'm thinking something based on QFileSystemWatcher may be best.
fine with me.

ianal (and we might be in different jurisdiction), but i thought every _file_ needs a copyright header, so i included one. for now, i have just added a doc block (and commented the copyright block with /* */ instead of hashes).
I don't think this is true. If there are more than one components, than the first eigenvector (or was it the second?) will separate them afaik.
On 09/23/2012 08:00 PM, Gael Varoquaux wrote:
> 'R' is a single-letter non descriptive name. It would be much better 
> to find a better name
This should go on twitter ;)
there are different possible approaches:
have a single setting in the CoreBundle or each bundle has its own setting but we implement the PrependExtensionInterface (or want ever that was called) in the CoreBundle. the later prevents a hard dependency.
What's missing is a method for the general ratio.

The author of the test should be able to put the timeout into one of these categories - they are created based on QA team's experience. E.g., database operations are easily told apart, and the timeout ratio would be set if the DB machine used is quite slow.

But if you feel it should be there, I will add it.
update the apidoc to say this isn't supported and also use/create a string from TiMessageStrings.h
typo: Unable to a remove ==> Unable to remove
contenue (avec un e à la fin)
Cannot really echo it... What about using `Doctrine\Common\Util\Debug::dump()`?
I'm not really convinced that an exception is particularly helpful. The removeal of the suibscription has suceeded, after all. The fact that you haven't managed to tell the server about it isn't really something that the person who just called you needs to know - there's absolutely nothing anyone can do with this exception other than ignore it, so isn't it better to do that here rather than at (every) caller ?

Have you checked that all callers DO check for execptions?
Yes, it is possible to miss changes that occur between calls to CFile::useINotify.  This is the current behavior of CFile::monitorDirectory.  If there is no change and the timeout expires, then a file/directory is changed between the subsequent call to CFile::monitorDirectory, the change will be missed.
Weird indentation - tabs?
See my comment under renamePhysical also..
Its renamed to SysMgrDeviceKeydefs.h, i believe.
A double no. Just used it as a misconfiguration guard.
As ``key`` is a reserved keyword in SQL, you should here add tildes (`` ` ``) around the field names as you did it for other sql files.
The 1 is for me the good and consistent way of addressing this.
Lets limpyd make *opinionated* choices to keep its internal API as light as possible. :)
Button's text is not updated at language change
You are passing `_resIndex` and `_apply` as parameters, you should do what you do in $callback.

We need a test for this
There are some closing PHP tags in some of the new files like you see here.
Hah. Let's go ahead and change this to a useful comment about specifying where redis lives. Perhaps have the two options on separate lines and tell the user to uncomment accordingly.
I'm not in the office today but I can look tomorrow. You'll have to change the Java code style (in Preferences) to use tabs. Apart from that I think the default formatting settings are agreeable with ours. With the whole team on IDEA we can even share configuration files.
It doesn't seem to...
`filter`:n ja `max`:n avulla:

~~~clojure
(apply max (filter (fn [value] (hand-has-value? hand value)) (range 8)))
~~~
> Of course. The only yucky part is that Rails includes more than just the get parameters in the params hash. But as you pointed out that isn't a big deal in this case since that method is only using the values it is concerned with, state and category

Yeah, the fact that we're passing around some unrelated data is something a bit ugly here. It's one of those situations where there are tradeoffs either way, and I tend to err on the side of having one less line to change whenever these names change. BUT if it causes us problems, the `Hash#slice` or explicit generation of a new hash would be the way to go.

I'll shore up documentation / tests in the next iteration, once we have some of the buttons in place that can modify the discussions. Sound good?
It would be better to use QMailMessageKey::nonMatchingKey() here.
Hi,
i don't understand your your observation. Can you clarify?

                 N.

In data martedì 28 agosto 2012 18:14:50, John Brooks ha scritto:

In contacts/seasideproxymodel.cpp:
> @@ -72,6 +89,23 @@ bool SeasideProxyModel::filterAcceptsRow(int source_row,
>          return true;
>      }
>  
> +    if (priv->filterType == FilterSearch) {
> +        // TODO: this should not be here
> +        qDebug("fastscroll: FilterSearch emitting countChanged");
> +
> +        if (person->displayLabel().contains(filterRegExp())) {
> +
> +
Please remove this and other cases of more than one blank line.
Seems a good idea to use report_auth_info and store_loot from the Auxiliary::Report mixin to store the collected info.
wasn't sure here either .. i assume you mean via a DIC parameter?
Maybe `(min_row, min_col, max_row, max_col)`.
Maybe explain that  ``radius`` indicates "the  size of the swirl in pixels" instead?
Yes, I need to change this in the resize function.
Is the `adopted` attribute necessary here?
do we have that field?
No. We already deal with all this in the parent class of profile form.
this is wrong. The package is not auto-updated. This is a manual trigger, not the github hook. Marking it as auto-updated would mean that it will not be crawled automatically anymore (well, only once a week) as it expects github to notify changes
This has no effect.
It s just to keep consistency with android implementation
var declarations go at the top of functions
There's a lot here. Perhaps you can move it into a CSS file.
It would break any such usage...

```D
int[] a = [1, 2, 3];
int[] b = [0, 0, 0];
copy(a, b);
assert(a == b);
```

That'd be a bit hard to justify, IMO.
redundant flow (basic idea: early returns make extra flow control a "lie" because the shape of the code fails to reflect its flow)
`HEAVY` means *heavyweight modules* from comment above.
We need to fix this by defining one overload of equal() with no explicit pred (and that assumes pred is equality comparison), and one with pred. Then no need for awkwardly testing for the default lambda. But that can wait for another diff.
This is in find. The needle, of type R2, is defined as by template restrictions as at least isBidirectionalRange!R2
WDYT about making these classes inner classes in the actual test? I think it would be a bit easier to follow that way.
keep in minimum number of lines
please respect the formatting we're using; there's an formater for eclipse in etc/eclipse in the framework repository.
ah yeah much better
:bowtie: I'll ask the good folks at Opscode.
Use scheme here
It's not about compiler semantics, It's bad coding style because you have to **remember** the rule.
~~via~~ over
as discussed, I think Dancer2 should ship Dancer::Template::Tiny or something
@robertbasic  : ok, added.
No creo que sea conveniente traducir los textos de interfaz de poedit
Is needed a white line after `:lineos:`
i'll look into this in future, but the if is going out of there... it has no use at all.
it makes no sense to me to manually do exactly the same order. lets change.
Can you remove this conflict marker?
add some spacing here for readability (just one newline)
Use `IEnumerator<T>` instead of `IEnumerator`, and make this class implement `IEnumerable<T>`.
you should remove the dash from the beginning of the title
armstrong.apps.content also needs to be added to INSTALLED_APPS because Article inherits from Content
That feels wrong to me. You create a weak reference pointing to List<ValidationProvider> but nowhere else do you keep a hard reference to it.
That means the weak reference will be garbaged collected very quickly. That seems wrong to me.
The point with WeakHashMap is that the key ie the classloader is weakly referenced.
indeed, it seems to work perfectly without it.
I have fixed it.
I'd prefer `wrap-oauth2` so as not to clash with OAuth 1.0 implementations.
This is a function.
Right. I like to give the reasons for a feature early but in this case that was not working out
> Is getter actually well enough defined in the spec?

properties and getters are defined in the spec <http://beanvalidation.org/latest-draft/spec/#constraintdeclarationvalidationprocess-requirements-property> but essentially refer to the JavaBeans specification.
But that reminded me of clarifying that getters have no parameter. I've added 6cd8877
Yeah, had to put that in due to the path being different between the tar and the git checkout.
doctype ro bayad ba horof bozorg zad
LOL, copypaste is not always your friend :)
Do 
`obj, just_create = a[0], a[1] `
and use those variables. This makes it more readable.
Should be: `"zendframework/zendframework": "dev-master#fedd11dce74ca2ec20c1370915be06615e91b9d2"` 

or whatever the have is that we want to pin to.
Yeah, it would be better to allow this via the generic `additional.url.schemes` property below
barColor not available on android
`TiRect` should not be removed, but instead have its documentation rewritten to reflect the changes made by the composite layout spec.
The entire withCredentials logic can be significantly reduced to:

    this._xhr.withCredentials = (!!this.withCredentials).toString();

Also, in mobile web, our coding standard is to put the else on the same line as the if's closing bracket like this:

    } else {
Isn't this going to be caught by the catch clause as well? See assertThrown and friends.
"Returns the Sync node to which the client's account is assigned."
how would there be conflicts? You realize that the extension is self-contained?

Anyway, I changed it because I didn't like looking at 'blog', 'blog'. too much "the same". but I'm not overly attached to "common.php", just figured that it wasn't much of a big deal anyway.
Split these three <tt>payload.get</tt>s into local variables. Neater, no need to split line.
Remove mixin if not used
As discussed, this is VCS rather than ICS so that won't work. We could programmatically check for the file and display an alert box to the tester.
I agree here, especially since one day I'd like to fix the framework to do it automatically, and on that day we would need to stringify and encode for no good reason.
What if we want it more then once?
Create a single services provider that has everything that is a service. Controller can then use the provider.
Yes, of course.
Should I make another pull request for this?
No those one :
https://github.com/symfony2admingenerator/AdmingeneratorGeneratorBundle/blob/master/Resources/templates/CommonAdmin/EditTemplate/fieldset.php.twig#L6with
the i18n_catalo option setted

and like i've said in my first review you sould cast as array and keep the
same type

public function getEchoTrans($str, array $params = array() $catalog =
'Admingenerator')

And check if count($params) == 0 instead of null




2012/8/11 NeoShadybeat <notifications@github.com>

> In Twig/Extension/EchoExtension.php:
>
> > @@ -132,9 +132,18 @@ public function export($variable)
> >          return str_replace(array("\n", 'array (', '     '), array('', 'array(', ''), var_export($variable, true));
> >      }
> >
> > -    public function getEchoTrans($str, $catalog = 'Admingenerator')
> > -    {
> > -        return '{% trans from "'.$catalog.'" %}'.$str.'{% endtrans %}';
> > +    public function getEchoTrans($str, $parameters=NULL, $catalog = 'Admingenerator')
>
> You say, change this
>
>     {{ echo_trans("Display all <b>%count%</b> results") }}
>
> by this
>
>     {{ echo_trans("Display all <b>%count%</b> results",null,"Admingenerator") }}
>
> Is this what you mean?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/symfony2admingenerator/AdmingeneratorGeneratorBundle/pull/218/files#r1357224>.
>
>