labofsahil/github-event-dataset-2012 huggingface dataset:
`MultipleActiveResultSets=false` should be removed here in future when #112 will be resolved (i will work on it after unit tests will be actualized).
Well the problem is, if there is no id/key, then you can't fully guarantee uniqueness due to all the possible variations of a tag, that's why the original implementation (serialize($options)) was correct in this aspect.

I don't really understand the problems you see in $key. A developer will know all the keys and all the places where those (default-)keys may be defined. Also a registerMetaTag() call will most likely not be deeply hidden somewhere (unlike a call to registerCss/Js* from some widget).
I agree. Changing this right now.
Just why is that?
`findBy` returns an array of objects, so `remove` will not work here.
Either do `findOneBy` or loop through the returned objects.
Also test that when provided different properties in the constructor the identifier changes.  Right now I can change the implementation of `identifier` to this and the test would still pass:

```python
@property
def identifier(self):
    return 'http://127.0.0.1:8098/riak'
```
Some would be useful as public methods, but many are conversions where we should use `to_` or whatever interface we settle on. Maybe those that are useful should go into another file.
Yeap, that was for a different use case.
This window seems unnecessary for what we're testing here.
oops thought that variable was :password, not :username, fixed now
Why does the DbUpdaterJob need the rule table?
The destination server must have sufficient free space for the database you are copying.

(I would put this lower on the list becasue while it's true, and must be said, but it's sort of obvious and I fear people might not read the next point, which is not obvious.)
assumes
when you're done testing, you should remove this too.
webapp.css est une relique du template du site initial. Je l'ai enlevée.
The spacing seems kind of off in parts of your code.
Yes, they should. PRs for both created.
Yes, its commented out by default. Style author can enable it to override default value
That's true with the current rules. By the time this was written I had no information about such rules. Changed.
Replace "bom" with a meaningful description of what would happen.
As this means avatar downloading is broken on develop, please do fix it in a separate PR.
you won't need level=player.level_no. Rollback doesn't check **params. Or maybe it should?
Cool, I like 3 too.
when you look closely you will see itz just white string change on this line .)
Append "this."
Did you confirm this already? How did you know to do it this way? I suggest that the comment is redundant: ultimately, if its not correct, we will soon know about it!
```shared_coord_points``` is undefined.
Missing docstring for a public method.
it return -> that it returns
This might deserve more explanation. You and I know what it means, but it may not be obvious to someone who is new to Theano.

How about, "It tests that the Op gets optimized out of the graph if only the shape of the output is needed and not the output itself. Additionally, it checks that such an optimized graph produces the correct shape by comparing it to the actual shape of the computed output."
Unrelated hunk.

Besides... optimizing the error path which only leads to our early doom is more than a little useless.
Global JS variable.
item.model.group
Отступа не хватает
done & removed one callback
In fact JSDom should be able to load and execute the scripts from the html file automatically, but I couldn't get that working.
nit: following calls to url() - as it reminds people that url is a function
`basestring` isn't correct on python3, you want to use `django.utils.six.string_types`
Muharem is not the maintainer anymore.
For reference, you can observe this error by changing the exposure and job.ini inputs as follows:

<pre>
diff --git a/demos/classical_psha_based_risk/exposure.xml b/demos/classical_psha_based_risk/exposure.xml
index aacae18..f434252 100644
--- a/demos/classical_psha_based_risk/exposure.xml
+++ b/demos/classical_psha_based_risk/exposure.xml
@@ -7,7 +7,7 @@
        <assetDefinition gml:id="a1">
                <site>
                        <gml:Point srsName="epsg:4326">
-                       <gml:pos>-1     1</gml:pos>
+                       <gml:pos>178 0</gml:pos>
                        </gml:Point>
                </site>
                <reco>0.1</reco>
@@ -18,7 +18,7 @@
        <assetDefinition gml:id="a2">
                <site>
                        <gml:Point srsName="epsg:4326">
-                       <gml:pos>0      1</gml:pos>
+                       <gml:pos>179.1 0</gml:pos>
                        </gml:Point>
                </site>
                <reco>0.2</reco>
@@ -29,7 +29,7 @@
        <assetDefinition gml:id="a3">
                <site>
                        <gml:Point srsName="epsg:4326">
-                       <gml:pos>0      0</gml:pos>
+                       <gml:pos>-178 0</gml:pos>
                        </gml:Point>
                </site>
                <reco>0.2</reco>
diff --git a/demos/classical_psha_based_risk/job.ini b/demos/classical_psha_based_risk/job.ini
index 5cc9707..7990e62 100644
--- a/demos/classical_psha_based_risk/job.ini
+++ b/demos/classical_psha_based_risk/job.ini
@@ -9,6 +9,7 @@ exposure_file = exposure.xml
 lrem_steps_per_interval = 5
 conditional_loss_poes = 0.1 0.2 0.3
 
-region_constraint = -1.5 1.5, 0.5 1.5, 0.5 0.5, -1.5 0.5
+# region_constraint = -1.5 1.5, 0.5 1.5, 0.5 0.5, -1.5 0.5
+region_constraint = 179 10, -179 10, -179 -10, 179 -10
</pre>
Assuming you guys are counting bits, then yes.
style nits here too: `window.supportsFixedPosition = ( checkDiv.offsetTop === 20 || checkDiv.offsetTop === 15 );`
Hmm...did those comments never make it into master? I swear there was a discussion about this and I saw the comments at some point.
`jQuery.css` -> `curCSS`
In converting countmin.args from a Datum to an Int64 haven't you locked the datatype down to a single datatype?  I don't even understand what the purpose of countmin.typOid is anymore.
test: I am giving comment here to show examples for Grace.
If you split up "register_live_index" into a post_save and pre_delete handlers, you could use the Django receiver decorator:

https://docs.djangoproject.com/en/dev/topics/signals/#connecting-receiver-functions

Amongst other things, that might make it easier to move the registration code into the right place.
Leaks?
My previous comment applies here also.
It's version with a dot prefixed.
Maybe rename `frameNameOrNumber ` to `frameInfo`
This is 400 because of a bug fix that happened in this sprint.  Getting status on a non-existing cart used to return Success.  This was already fixed in the REST API and now the legacy reflects that fix also.  In order for the tests to pass I had to fix this here.
missing a $
Ich hatte gehofft, dass du die Stelle übersiehst :D
Hinten ist ja die Variable $param_string, die wird vorher schon irgendwie zusammengesetzt. Und `rex_getUrl()` bietet einen Parameter $_divider, `frontendController()` aber bisher nicht. Daher hab ich es erst mal so gelassen, wie es ist. ;)
Looking at the changelog for cssutils, it looks like they break compatibility quite frequently. Would it be better to pin a specific (new) version?
Good to know, I'll switch to 'unused'
A problem with this SHA setup is that SHA_FILES includes the full path to the current working directory.  Issue #41
It's my own problem, but I think and/or is just ugly. Could this be a list?
I'd use String::Quote(...) for tmpdir parameter. Of course, also quoting '%1/config' part of the command.
`var hasDataMain = /data-main=['"]([^'"]+)['"]/.test( indexBuffer );`
This is a bit confusing. Maybe if there is nothing to convert it should say something like `Clear the base path? There are no attachments with relative paths. New attachments will be stored with absolute paths.`

The messages below might read something like `Clear the base path? %S attachments will be converted to absolute paths. New attachments will be stored with absolute paths.`
@mmichaelis `t`?
no it does not need the license.
i was too lazy and too fast to this week clean it up, i was in hurry.

If you extract the installation package, you can see the file conf/setting.xml
http://www.us.apache.org/dist/maven/maven-3/3.0.4/binaries/apache-maven-3.0.4-bin.tar.gz 
it is legal to create a custom one.
we do not need the original one.

a brief tutorial to this file:
http://maven.apache.org/guides/mini/guide-configuring-maven.html
classname should be hyphenated `.nameText` should be `name-text`.  Also, is there a better classname name `name-text`? Seems specific, yet generic.
Yeah, I had the test configured differently when I was trying that. I really need a function that connects to the video player's `loadstart` method... which I think I've now done.
I'd rather see parameter 4 be explicitly specified as false for this call (and also for "css" case). I think that optional parameters are ok if you're refactoring a fair amount of code, but I don't see any value in creating optional parameters in new code.
This was hugely helpful, thanks a ton. Fixed.
targetDir is the folder path passed to NativeFileSystem.requestNativeFileSystem() to retrieve the contents of that folder. It is not seen by user. The list that it returns is the list used for hints, which is encoded.
I think this might be better as "@brackets on Twitter".
In what case would we hit this? If we're `inSelector`, then we hit a {, so we shouldn't be in a context where there are properties.
The isNaN() check doesn't concern me so much.  What worries me is that hsv.s and hsv.v are sometimes a number and sometimes a string.  That seems bug-prone.  I think the conversion to a string here should only be saved into a temp variable -- afaict the string representation is needed for the css() call below, but not for anything else.
I agree. The reason I did it that way was conciseness, and so `new_salts()` didn't have to be called first.
this is just a nitpick, but I think it's more consistent to call this `scaling_bloom_check_and_score()`
This can be on one line.
this looks funny. if the intent was to provide other ways to order keys down the road i'd add it in at that point. unless this is somehow fitting in with other framework code outside of this view?
Updated as in they may have changed their picture or name or something like
that so we want to make sure we update all of their data.

On Sat, May 12, 2012 at 8:27 PM, bayers <
reply@reply.github.com
> wrote:

> > @@ -1,7 +1,21 @@
> >  require 'test_helper'
> >
> >  class UserTest < ActiveSupport::TestCase
> > -  # test "the truth" do
> > -  #   assert true
> > -  # end
> > +
> > +  test "should create a new user if one doesn't already exist" do
> > +    auth = { "provider" => 'facebook', "uid" => '122', "info" =>
> {"name" => 'Brian Ayers', "urls" => {"Facebook" => 'facebook_link'},
> "image" =>'image_link' }}
> > +
> > +    b = users(:brian)
> > +    #make sure it doesn't already exist
> > +    database_entry = User.find_by_uid(b.uid)
> > +    database_entry.destroy if (database_entry)
> > +
> > +    User.find_by_provider_and_uid(b.provider, b.uid)
> > +    new_entry = User.create_with_omniauth(auth)
>
> What do you mean that the user is "updated"?
> I just made sure it is able to find the user correctly, because it is then
> just set as the current session user.
> I don't think anything is updated.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/gaye/rideshare/pull/30/files#r812857
>



-- 
Best,
Gareth
Nice class description ;-)
So you will probably have to write your own middleware, similar to the one you are using now to set language based on the browser settings.
As in not fixed?
You should probably do the same to `src/core/project` as well.
Mind adding a newline above this line?
`util/uri` is here twice now.
Why not just make this a bool?
I'll just ask because I haven't been able to figure it out. Why do we not need to check for the id anymore?
that's UTF-8 BOM
There is no reason to touch this lines (and 3 lines below). Please changing previous line to something like:

```
if (document.getElementById('thumbsSwitch').disabled)
  break;
```
In else statement can we keep keep using `scaffold` in place of `BlogScaffold` for consistency since you've already setup scaffold to point to the correct location. 

Also for bonus points, maybe rename `BlogScaffold` to `DefaultBlogScaffold`
Okay : ) 

Then I will revert it.
Why put this into TransientState rather than State? I'm pretty sure you want this to persist across Einhorn reloads.
It's better to do style things in the css rather than inline with the HTML. It makes it easier on the browser and causes fewer stutters when rendering the page.

So this style setting should get moved to the css file.
Supprime la ligne.
then why are we sorting by seniority?
Please remove the extra space after ``!``
I added one more parameter to the getBestCostPlan - int planIdRange[] an
array of two int. The first element (the input) is the starting index to be
used to generate the unique name, the second element 9the output) is  the
last used indexes plus one. The only reason for the array is that Java
doesn't allow the pointer/reference as an argument to be modified.

On Tue, Sep 25, 2012 at 8:44 PM, Michael Alexeev
<michael.alexeev@gmail.com>wrote:

> I cheated a little. With the current approach where we first identify the
> best plans for the individual selects and then combine them into a best
> plan for the whole union there always will be one and only one winner. I
> simply call it "union". So, the final winner plan is WINNER-union.txt.
> Also, as you rightly noticed, the file names for the  individual selects
> are not unique and get overridden, but the individual winners though are
> incorporated in the WINNER-union.txt.
>
> This is indeed a departure from the current behavior. Probably better to
> follow it as is.
>
>
>
>
> On Mon, Sep 24, 2012 at 11:04 AM, Paul A Martel <notifications@github.com>wrote:
>
>> In src/frontend/org/voltdb/planner/QueryPlanner.java:
>>
>> > @@ -68,6 +70,13 @@
>> >      // generated by plan(..)
>> >      boolean m_wasParameterizedPlan = false;
>> >
>> > +    class NextPlanParams {
>>
>> How are you then accounting for the counter that establishes unique
>> diagnostic output file names?
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/3/files#r1673859>.
>>
>>
>
>
nit: move the dead code to the graveyard
FYI, #240 is now in master - you can either rebase against master on this branch (and remove this), or I can just do it directly in master after this is merged.
I think what you're doing here is fine based on my reading of how the ``py.test`` fixtures work.  

I also agree it's a bit confusing, but it may end up pretty powerful once we get used to it...
驼峰？allowedFields?
Maybe it's a personal preference, but I'm not a huge fan of the type being named `handoff`, yet having all the code in handoff/vnode managers using the `#handoff_status{}` record to get/set elements. A bit confusing until you realise `handoff == #handoff_status`.
why 5?
I dislike commented out code and you have re-introduced "int BlocksOfPeers" here.
I like that better but it actually doesn't work on *BSD at all. -ldl is part of libc. I can successfully build statically on open/freebsd as is without adding it back in.
Won't the std::string temporary from GetDebugLogName() free pszFile before it is used?
Please yes. We also often have `@package` in the file header when it should be on the classes, or not present in 3.0. Package names can be inferred from the namespaces.
Why not have a separate and specific option for disabling the automatic input options?
You could always write it as `$Model->escapeField($left) . ' asc';`.  That would be less prone to maintenance errors in the future.
same for next methods btw
As for the matching string, it is a string in the standard input which the lexer reads. The lexer recognizes strings matching the regular expressions defined in the second section of the lexer, that is one starting from the first line `%%` in its code. Each statement of this section is a rule of the form `REGEXP actions;` where REGEXP is either a regular expression or `{NAME}` which is the regular expression defined in the first section of the lexer, while actions are written in C (with some additional variables and macros available). The actions part may be omitted which means that regular expression will be ignored.
Should this be 2008-2012?
NewTab
delete first
NewTab

Tada ! two tab with same name !
(I did the same in qtconsole)
I suppose it is *technically* generic, but I've never had a reason to compare subsets of dictionaries before this.
I'd switch these properties to test.compute.* and add test.compute.provider to designate their scope

there shouldn't be a direct tie-in to ec2 at this point;
newline only change
the one with the predicate arg does the work.  having listNodes() call that one with Predicates.alwaysTrue() basically allows you to reuse the logic
Ah, I see what you're saying now.

Anyway, I'll update to use `git_branch_tracking`.
The problem with that is that if we, for whatever reason, have a reference to a node that doesn't have a template and try to get it's previous or next node, we can't because we don't know where in the ordering it is if we only save nodes with a template. `self.preordered_nodes.index(current_node)` in the methods below would fail.
Technically we didn't need this - as we're not linking to that page that we were on...
Yes, you'll have to `r'eula'` into `apps/legal/urls.py`.

And nope it won't cause issues. It would only cause issues if we botch the /b/ redirect.
ahem... wow. not sure what i was doing there.
Totally! Functions are objects and have a bunch of attributes:

```
Python 2.7.3rc2 (default, Apr 22 2012, 22:35:38) 
[GCC 4.6.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> def f(): return None
... 
>>> dir(f)
['__call__', '__class__', '__closure__', '__code__', '__defaults__', '__delattr__', '__dict__', '__doc__', '__format__', '__get__', '__getattribute__', '__globals__', '__hash__', '__init__', '__module__', '__name__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__sizeof__', '__str__', '__subclasshook__', 'func_closure', 'func_code', 'func_defaults', 'func_dict', 'func_doc', 'func_globals', 'func_name']
>>> f.__name__
'f'
>>> 
```
Am I crazy or would jinja auto-escape this, removing the need for `|safe`?
Funny! The only reason you wouldn't have spotted the tuples vs string thing above is because `assert 'update_adu' in 'update_adu'`
This would only be for running standalone/dev mode, Apache (and any other WSGI server) would have it's own configuration (unless I am misunderstanding)
You're right. I take it back. You didn't write *new* code here.
Why use a h6 here instead of a span or any other "meaningless" tag?
`);` should go on a new line
I don't think you need the extra wrapper function, you should be able to just pass the `loadTemplates` function to ready

    $(document).ready(loadTemplates)
This is indented too far now :(
setSystemPalette() was really just a shortcut in the old days when videos had RGB palettes and OSystem took RGBA palettes. Since the change to OSystem, setSystemPalette() has just been a lazy wrapper. Setting the palette on screen shouldn't be part of the VideoDecoder code anyway.
I updated the documentation for restart() and placed the rest in separate request since there were more than just the one.
Why not use {@inheritdoc} here?

And the interface PHPDoc does not mention the return.
why removing the return statements for the default options ?
To be honest I don't like that either but it turns out that Firefox, didn't checked the others, wants to store every value as a string so... since I'm storing a string there why storing something else but the value itself?
Done, please check though, first time I touched that.
You didnt define $this->attributes
@vicb, I saw it, but I don't get any point!, you change the access modifier to private to make the class not instantiated, but some one could inherit from the class and make an instance object of inherited class without calling the parent constructor, and it is bug.
Hah - this actually fixed problems with classes being examined by checkstyle that depended on thrift gen code iirc.  I'll test on our codebase to confirm.
println--
OK, let's postpone the refactoring to later...
Might do a `contains` here to be less brittle.
这个单引号引得不对。
Since we now have a backing store, shouldn’t the `update_attribute` and `update_attributes` methods now update the cache?
"It has" is just as wrong. The correct form is "I haz" ;-)
Should this be "container view" rather than "collection view"?
What's the purpose of supporting the inverse?
You should not need this line ( phaseContext.addToAttachmentList(Attachments.NEXT_PHASE_DEPS, Services.JBOSS_MODULE_INDEX_SERVICE))
We have a few points where we are concatenating together search filters - is there any option to just create these Strings once instead of per request?
sorry about that, i haven't done any unit test over javascript. that was the first time i'm doing it. so i just copied the code for it from the widget-creation test. that is why you have clean up after me. :-)
here we have a bug. 
the '_' is missing for both variables
nit: // Be careful to do the return.
add a test for set an alarm for 13 minutes from now then changing sync time to 30 minutes (exercise the time difference  code).
The `role=dialog` has 2 direct childs that are inline-block, if you do not set up `font-size: 0;` the white-spaces, break linkes and this stuff in the code, will apply ~3px of unwanted visual space betewen inline-block elements
oook, will update this, anyway is conflicting ;)
renderedApps -> appsInDB
I'm not sure it does, this is just the most concise way to make sure all of them have completed before any test starts.  Not particularly efficient I know.
Don't write `element.parentNode.parentNode` like this, it's not readable and may fail if someone updates DOM structure.
In this case, you don't have to grey-out the whole `li` element, just disable the switch is okay, I think.
I don't think we should leave this in here. Once we land this, we should get GaiaTestCase specific docs up and listed (https://developer.mozilla.org/en-US/docs/Marionette/Tests) and we can promote the page_source function there, unless you think otherwise!
The predictiveTextBindings.js & predictiveText.js are provided by Christoph and today I know that the engine  would be changed to be implemented in native code.
So, if possible, I prefer not to modify it.
Ok, will move to the same if (but will add the else)
the opacity and transitions are .3 seconds, could it be .3 instead of .5 seconds? thanks
pass false explicitly here in this error case.
FWIW, `make` works if you put this line in a try…catch.

The problem is that for such apps like `communications`, shared resources are included from the main app (index.html) and from sub-apps (e.g. contacts/index.html), and this raises an error when shared *directories* like the `date` one are included twice.
You would need to remove the permission on mozapps manifest also
I guess my intention here is that removeFrame removes the app from the runningApps table which means isRunning(homescreen) is false.
The real problem here is that the homescreen code (ensureHomescreen) thinks its running even though it has crashed.
Don't you need to update the :local signature too?
My initial feeling is that this seems unnecessarily over abstracted with ProgressWriter/ConsoleWriter/IWriter. Do we really gain much over it just being a ConsoleWriterWithProgress class?
Something broke whitespace here, going to fix that.
Can this be moved into CMSCountsTable?
Call this `setup_transaction`.
I've been using the convention if it doesnt have anything returned there is no return section. Same thing with raises.
``// No variant lines in this factory.``
Also return gives me an error when compiling.
Copysnapshot probably sets the snapshot value to the new value.  However, that has to be done by the main thread.  If the main thread is slow, then the entities wouldn't be moving.  

For thread safety, it is assumed that the snapshot value is stable.

Is this the Player's transform?
argh... automatically put in there by idea... sorry..
Divide by zero erros are possible here.  I think setting them to +/- Float.MAX_VALUE should fix it.
You don't need the type if there is a default given, I think.
I think this is really sneaky, and should be refactored.  Rather than adding `ss` to the database (it's probably already in the database, in fact), this adds a *copy* of `ss`, with its sourcestampsetid changed.  It probably makes the most sense to call `master.db.sourcestamps.addSourceStamp` with appropriate args here, instead.
I am tempted to say that `fromChdict is only ever passed the result of `db.changes.getChange`, so if that is changed to not return `category`, then this block of code won't be needed here (which incidentally gets rid of the code duplication with the code below.

But I'm not sure if the premise is going to continue to hold. @djmitche? Perhaps at the least, we can assert that all code calling this directly is going to be new code, so can handle tags directly.
currently works on windows and linux for me. but we might need some additional testing then.
Does "soundID = this.mSoundPool.load(pPath, 0);" return 0 when a file does not exist?
Because when a file does not exist, "soundID = this.mSoundPool.load(this.mContext.getAssets().openFd(pPath), 0);" will trigger an exception.
This is actually factory method called by PackageBuilder, so I moved it there. The following, cloneAsInherited, is not even used so I removed it
GitHub looks for a "README" file at project root. You can use [GitHub Flavored Markown](http://github.github.com/github-flavored-markdown/) if file extension is `.md`.
It seems ok. 

How do we confirm "the piece wasn't syndicated", vs "the piece wasn't syndicated just yet, but will be".

e.g. in zombiejs, we have the browser event queues, and we can wait on both players event queue, ensuring that all async actions are complete.
any classes in the `implements` array property of the instance.

To avoid emphasis on heritage.
Switched to this.
To be honest I copied it from old code of mine, so I forgot to style it properly :)
I would rephrase this saying that if you omit the leading `./` or `../` characters it will still work
but is discouraged and is only supported for backwards compatibility.
I don't think `require('chrome')` is going to work for system modules, is it?
So, I believe you're referring to line:

```js
delete selections(window).selection;
```

Github is showing your comment to a totally different lines and I've no idea why. :/

Anyway. First of all, I can't set this to `null`, because it can be `null`, and in that case have a specific meaning: it means "I tried to add the selection, but it was null". So, I have to check if the property is actually present to check if I tried to add it or not. It's the best thing to do, IMO. In addition the performance you're talking about is not huge, it makes difference if you're writing a game or something but I don't think we should write in that way if makes the code more complicated or less readable without any specific reasons (to me is Premature Optimization). And last but not least, in accordance with Eddy's talk, `delete` shouldn't be used unless we're deleting the last property added to an object, and in this specific case we have only one property. :) So we're safe! :)
This is worrisome. Can you open an issue about this and assign it to me to investigate?
I left it to also have the error logged in the console but I'll revert this change.
Let's use separate `var foo = require('bar');` on each line. Persona is doing it too so it's consistent, and I think it's easier to copy/add new stuff. (https://github.com/mozilla/persona.org/blob/master/test/test.authenticate.js#L1)
Why did you change the Doctype and meta tags?
specialized exception?
Good catch. I have adjusted the range from 23:00 to 22:00.
This is an internal method that should be private and so not tested here.
_I_ guess this refers to a VariableWrapper, ie. the signal's name needs to be changed too.
I'd rather not.

Basically, this method is shared by any kind of SQL object that needs to process smaller expression objects.  This could happen 1/2 a dozen times per SQL statement.  This code, as written, is as fast as it's getting. There is currently no chance of a parent overriding any one particular behavior of this block of code.  As for maintenance, it does nothing special, it is just building strings an arrays based off of an object.  I will agree though that for the comprehension aspect, this could use more commenting, which I will add now.

All that said, I only see drawbacks in breaking this up into more methods, no benefits.
Thanks. I'll make that change.
It will be done very soon.
Has been corrected to compile. Should not be commented out.
If you want to match the github rendering more closely, you need to activate more extensions:

- ``no_intra_emphasis`` (so that ``foo_bar_baz`` does not look like ``foobarbaz`` with ``bar`` in emphasis)
- ``autolink``
- ``strikethrough`` to support the ``~~foo~~`` syntax to provide ~~this effect~~
- ``tables`` (for the case where someone uses a table in the readme, which is supported currently and on github)

and also a few html render flags:

- ``filter_html`` (github strips the HTML code, not only the tags)
- ``hard_wrap`` to wrap lines when a newline character is in the source
Unrelated, but we don't have to set the value inside the csproj. The value is explicitly set when we do BuildSolution.ps1
I presume you're referring to my variables - I'll look into it.
Use a constant instead of the number directly.
Also use space. See app spec, idiomatic.js.

```js

var ENTER_KEY = 13;

...

if ( e.keyCode === ENTER_KEY )
does PSR-2 really forbids to keep the array declaration where it was ?
this change here is unrelated and should have better been done in master .. sigh.
I prefer not to include namespaces when not needed -- it makes the resulting code a lot harder to trace. No worries though; I'll fix it up.
add spaces around '=' and after ',' and ':'
Two empty lines before function definitions outside classes
I don't think so, because this isn't actually served from the same place as other admin-media. I can't find anything on adding media files to admin-media right now, but I'll have to address this later when I try to pull this out into a library.
So for release candidate builds we have different priorities

> release-mozilla-esr(CUR)    =  700
> release-mozilla-esr(LAST)   =  600

But I'm not inclined to do the same for nightly builds. I think esr10pre and esr17pre can have the same priority.
Well, you're changing the default behavior, so change the default tests. Now instances have one event attached to them.
Can't you access the wrappers _canPlaySrc directly, without instantiating Popcorn?
No, it's identical to how video works, where you have to create an instance to use canPlayType.
đổi lại dùng MAXVAL + 1 đi
Good idea! In this case, we should cleanup all calls to the `Lang` counterpart in this PR :-)
i'm almost done with it. I'm making the Edit link on the main trends page have a table to edit all the values as well.
just strip and clean it here instead of having to do it in the for loop. 
```
split_participants = [p.strip() for p in participants.split(',') if p.strip()]
```
Is this use case no longer supported?
这里为什么删除掉呢。这个样式是有用的。
StringReference instances appear when a client sets the reference to a non-reference value (e.g., "Hello World" in the case of some JCR TCK tests) or when connector creates a reference from an ID (e.g., without the source or workspace keys) that is too short to be a NodeKey, as determined by `NodeKey.isValid(...)`. In the latter case, we can create a NodeKey here because the source and workspace keys have been added to the string representation.
This is the first time I've seen Github do a diff badly. I indented after my `private` declaration and now it thinks I added lots of new methods.
We definitely would want something more informative than `m` here.

In any case, as discussed, you should use the optional parameter on the [Split](http://www.ruby-doc.org/core-1.9.3/String.html#method-i-split) method.
I actually think this is very smart. He obviously wants to make Wordpress not function on servers which are too scared to run the short tag option.

Wordpress should only be for those nerdy enough to be prepared to run with everything PHP has to offer. All options must be set to 'on'!
Better if we checkParams after that.
入れ子になった配列を平坦化します(入れ子はどんな深度でも可能です)。*shallow* 引数を渡すと、入れ子の配列は第一階層のみ平坦化されます。
For me without it set it returns an empty string.
@nicolaasmatthijs his suggestions seems a bit easier to me. if the UI really doesn't need the providers/login ids attached to a user then this seems preferable.
.. content item ..
The options should be an array.
Should just be `Content comments`
Is there a need to wrap the callback? (There is a missing return statement here as well.)
`connection` has a `ready` event as well. Should this `init` method take in a callback and finish initialization only when the connection comes ready?
It doesn't look like this is being used here.
As discussed offline these will disappear once the UI is hooked up so can be left like this for now.
Is there a better way to figure out if a source file has changed than comparing the contents?
You can set that variable from `RunSpecFile`, so that running the latest spec (if it can't find one) will still work.
I haven't tested this yet but does using the async pack affect being able to use VS2010?
Small different was, while `fetchObject` require PECL pdo >= 0.2.4, `fetch` only require PECL pdo >= 0.1.0
сравнение ссылок, объекты класса nsstring сраниваются с помощью метода isEqualToString
Хотелось бы увидеть поле DNA, для доступа из main, чтобы иметь возможность вывести содержимое массива.
Ок, теперь понятно, добавлю проверку или try-catch если такой есть в Objective-C
Да, согласен, спасибо за замечание. Автоматически сработало то, что элементов на данный момент 100, значит любое число переданное - будет означать количество процентов.
You are right. I made mistake there. So will fix it.
А как же быть, если значение больше 100?
Did you mean the annotation catergory creation from lines 133-154?
It doesn't work because of an obscure C gotcha: The operator `==` binds tighter than `<<`, so `flag` is shifted by `1 == ROOM_GODROOM`. Use ((flag << 1) == ROOM_GODROOM)
Can you double check to make sure that all available packages are marked for export?
@chrox No, @houqp is right. It should be turned OFF by default. MOST PDFs which are properly made for Kindle 3 (or generally for 6" eReaders) do not require reflow. And about 90% of PDFs which are NOT specifically made for Kindle do not require it either because we have a very good manual bbox assignment function which makes them readable, except the remaining 10% which either have a too big page size or too small font size.
Invalid is invalid; the message can explain why.

I don't see this as an exception clients should plan to handle, but rather an exception they should avoid by not using `Checkout()` if `IsBare`.
True, this would be cleaner.  However, it may not cover all use cases. E.g. a user may want to compute the connectivity between a seed in the lh and all sources in rh and vice versa (but not the connections lh-lh and rh-rh). This is possible by making a custom idx array. Maybe we could have `idx`, `seeds`, and `targets` to cover everything. We can also allow e.g., `seeds = [100]`, `targets = None`, in which case all targets are used. 

In case `seeds` and `targets` is used should return `idx` so the user knows what the indices of the connections are.
we don't put blank lines between parameters anymore.
The top of the pull request shows the commit range:

"unpixie wants to merge 3 commits into opsschool:master  from unpixie:master"

It's not a huge deal, just something to be mindful of, to prevent a bajillion more merge commits. :)
Maybe tag with: `.. todo::`
I used the alias_attribute to keep the code cleaner. I was avoid the creation of the getter, setter and also the attribute_was and attribute present? methods. 
Even if the tests are passing you would suggest the formal definition of the methods?
I find the trailing conditional on blocks very hard to read. If you want to avoid an additional level of nesting, returning early with `return if roots.blank?` as the first line would be preferable.
Because if we are previewing it shouldn't take on any characteristics of admin.
1. Why didn't you use cpk's [quote_column_names](https://github.com/drnic/composite_primary_keys/blob/master/lib/composite_primary_keys/connection_adapters/abstract_adapter.rb#L4) ?
2. What's up with the weird indent?
Oh, hold on, I guess it was right.  But what we should test also is
that Symbol('f')(x) doesn't work at all.  See the issue page.

On Sat, Feb 18, 2012 at 1:14 AM, Aaron Meurer <asmeurer@gmail.com> wrote:
> Actually it should have been !=.
>
> On Sun, Jan 15, 2012 at 8:50 AM, Christopher Smith
> <reply@reply.github.com>
> wrote:
>>> @@ -467,3 +467,8 @@ def _eval_derivative(self, s):
>>>      expr = MyExpr(x,y,z)
>>>      assert diff(expr,x,y,f(x),z) == Derivative(expr,f(x),z)
>>>      assert diff(expr,f(x),x) == Derivative(expr,f(x),x)
>>> +
>>> +@XFAIL
>>> +def test_issue_1612() :
>>> +   x= Symbol("x")
>>> +   assert Symbol('f')(x) != Function('f')(x)
>>
>> the `!=` here should be `==`
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/sympy/sympy/pull/973/files#r353929
HRWA
Херь какая-то. В общем, полагайся на то, что maxvol ≡ 1.
I tested it on a 10.7 machine without notification center, It doesn't fail there so I assume it won't fail on linux/unix/windows, but I'll test it on a linux machine tonight.
please remove comments
`if opt in ['professions.enchanting', 'professions.blacksmithing']`
I disagree. We have code conventions in our libraries.

Brian Cardarella
Principal at DockYard
Visit us: http://dockyard.com
Call us: (855) DOCK-YRD
Follow me on Twitter: http://twitter.com/bcardarella
Follow us on Twitter: http://twitter.com/DockYard

On Oct 26, 2012, at 2:03 AM, Michael Graff <notifications@github.com> wrote:

> In lib/postgres_ext/active_record/connection_adapters/postgres_adapter.rb:
> 
> > @@ -303,7 +308,19 @@ def ipaddr_to_string(value)
> >        end
> >  
> >        def array_to_string(value, column)
> > -        "{#{value.map{|val| type_cast(val, column, true)}.join(',')}}"
> > +        '{' + value.map { |val| item_to_string(val, column) }.join(',') + '}'
> > +      end
> > +      
> > +      private
> > +      
> > +      def item_to_string(value, column)
> > +        if value.nil?
> > +          'NULL'
> > +        elsif value.is_a?String
> > +          '"' + type_cast(value, column, true).gsub('"', '\\"') + '"'
> I'm happy to do that, but why? I tend to think the latter is more readable, since the rest is all buried in a string, and makes it look at first glance like we're returning a ruby string-of-code.
> 
> —
> Reply to this email directly or view it on GitHub.
>
Isn't  "plats" or "lokalisering" better words to use in this sentence?
A little bug on my machines.
ok i split this into 2 clients compute/volume
If you're not going to override this method, it's better if you don't extend MultipleCacheManagersTest cos you're gaining little out of it since it's main job is to manage the lifecycle of these cache managers.

You can still create cache manager using static methods in TestCacheManagerFactory.

The test should extend AbstractInfinispanTest though.
Oh yeah, Anna wrote tons - failover tests that is!
I arrived late in the game, but it was decided not to use the DatabaseMetaData a while ago. Maybe Mircea can shed some light
Hmmm, an empty interface? This reminds me of EJB 2.1 ;)

If you need to mark a class and you have no methods, what about you use an annotation? More like EJB 3.0+ :)
I'll need to double check the code, but this sounds like a sane approach to me
This doesn't look equivalent. I need to re-address this.
Maybe `canvas = fig.canvas` instead?
No, the continuation of the list should line up with the start of the list, as @NelleV has it, I think.
Good to know. I actually stole this code outright from `LogNorm`. I'll put together a patch fixing this class as well.
why did we removed this mark?
this is from the SOAP structure. Header , body, body contains fault element
reviewing code in github always make it a little bit hard to grep the context; but is it really worth extending an List instead of simply using one internal and e.g. only provide an iterator?
Probably worth making it clearer that 'better-frobulator' is the app name in this example.
In hindsight I am not sure if we should be checking for undefined as well here. If somebody asks for a WFS GetFeature request and specifies a list of property names = A,B, the WFS GetFeature response will only include those two properties. It does not mean that the value of Property C or D etc. is null.
Why not something like

```php
$alert = $this->replaceVars($msg['body'], array('recipient' => $staff));
```

and use `%{recipient.first_name}` in the body as the token?
If *one* project does, it's OK-ish. But when multiple authors collaborate across projects, there needs to be a single standard. Also, the current use of spaces over tabs in the surveyed member projects is 2:1, a supermajority. Finally, using spaces allows for fine-grained sub-indentation. For extended discussion, visit <http://paul-m-jones.com/archives/2312>
I'm merely suggesting to split it even more for readability. E.g:
```
function test_db_connection(
    param1,
    param2,
    param3,
    param4,
    ...
) {
```
Wszędize powinno być raczej $this->basePath('/images/js/css')
No template references in here.  It _looks_ like you have enough of these that you probably should extend `PSU\Template` after all.
This comment still stands - but can be fixed later...
I'm on my way out.  There is a function called `singular?` in the
`forma.matrix.utils` namespace.  I can work on this in a few hours; but
can't right now.  It's pretty simple, I think:

```clojure

(if (singular? focsum-mat)
   [nil nil]
   ...)

```

On Fri, Aug 3, 2012 at 10:30 AM, Robin Kraft <
reply@reply.github.com
> wrote:

> > -            focsum-mat (i/mmult focsum (i/trans focsum))]
> > -        (-> (i/solve (i/mult foc-mat (i/nrow ts-mat)))
> > -            (i/mmult focsum-mat)
> > -            (i/trace)))
> > -      (catch Exception e))))
> > +        foc-mat (i/mmult foc (i/trans foc))
> > +        output (try
> > +                 (let [focsum (map i/cumulative-sum foc)
> > +                       focsum-mat (i/mmult focsum (i/trans focsum))]
> > +                   (-> (i/solve (i/mult foc-mat (i/nrow ts-mat)))
> > +                       (i/mmult focsum-mat)
> > +                       (i/trace)))
> > +                 (catch Exception e))]
> > +    (if (string? output)
> > +      nil
> > +      [output])))
>
> The occasional singular matrix that should really just be ignored. I'm not
> sure what the best way to do it is, but these changes are hacks to get
> around the problem - I'm trying to minimize downtime for this huge cluster
> processing trends. If the solution is to return to `singular?`, let's do
> it! I don't remember when/why this changed.
>
>
> On Aug 3, 2012, at 10:25 AM, Dan <reply@reply.github.com> wrote:
>
> >> -            focsum-mat (i/mmult focsum (i/trans focsum))]
> >> -        (-> (i/solve (i/mult foc-mat (i/nrow ts-mat)))
> >> -            (i/mmult focsum-mat)
> >> -            (i/trace)))
> >> -      (catch Exception e))))
> >> +        foc-mat (i/mmult foc (i/trans foc))
> >> +        output (try
> >> +                 (let [focsum (map i/cumulative-sum foc)
> >> +                       focsum-mat (i/mmult focsum (i/trans focsum))]
> >> +                   (-> (i/solve (i/mult foc-mat (i/nrow ts-mat)))
> >> +                       (i/mmult focsum-mat)
> >> +                       (i/trace)))
> >> +                 (catch Exception e))]
> >> +    (if (string? output)
> >> +      nil
> >> +      [output])))
> >
> > Wait.  All this is incorrect.  We shouldn't be checking to see if the
> output is a string -- that distracts from the point of the conditional in
> the first place.  There are much better ways to do this, given that we know
> exactly what sort of issue will arise at this step.  We can revert back to
> the old code with the `singular?` function, and then return two `nil`
> values.  This need not check for general errors.
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> > https://github.com/reddmetrics/forma-clj/pull/193/files#r1303649
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/reddmetrics/forma-clj/pull/193/files#r1303682
>
@dooremont Do we need those changes in here?
If not, can we remove these?
Those buttons still have background images instead of CSS3 gradients. I suggest we leave this as is and refine in a specific ticket in the next iteration as this rewrite would have an impact on every button in the system.
Can you split this to multiple lines?
I'm not sure what the double asterisks do in this class - sometimes they look like inline lists (which would be better done with dashes), but other times its in the middle of a sentence, IDE fail maybe?
Not sure if the \n would get parsed correctly,  sending the hex code definitely works so I stuck with that.  For example I had to send the hex for a quote (") because inserting \" in the string didn't work.
u volání maker ty zavorky taky odsazujeme mezerou, či?
Should the type for parameter ``$accessMethod`` not be "string|null" instead of "string"?
Are you sure ``array('languages' => array(), 'i18n_class' => '', 'columns' => array(), 'type' => 'translation_type', 'allow_add' => false, 'allow_delete' => false)`` has the correct type as "array<string,array|string|Boolean>" is not a sub-type of "array"?
Should the type for parameter ``$entities`` not be ``array|null``? Maybe you can also make the array more specific, something like ``array<String>``, or ``String[]``?
``$is_foo`` does not seem to conform to the naming convention (``^[a-z][a-zA-Z0-9]*$``). Please also check line 21.
Are you sure ``array('columns' => array(), 'language' => '')`` has the correct type as "array<string,array|string>" is not a sub-type of "array"?
Should be: `$filename, $content, $public = false, $description = ''` as description is only optional here. Also you need to update phpdoc above.
Just let you know:

whole thing could be rewritten as 

```java
if (!finalPrefix.isEmpty()) { //in case there is no prefixes beforehand, prevents a ghost space
    finalPrefix += " " + prefix;	
 }
```
See SpoutPlugin reply to your same comment.
This was a bit tricky - I needed an object that had no "own" properties to get past  Object.keys check, but still had properties to trigger the usage of the for-in loop.  Putting the hasOwnProperty in the prototype kills 2 birds with one stone, by hiding the hasOwnProperty method from the Object prototype and providing a not own property to test with.

I initially had used Object.create(null, {}), but I wasn't sure if I should include such recent features in the test suite.
You're right my test sucked. I've improved it. Thanks !
You'll need to fix the docblock on the method if we don't return a boolean anymore.
Please keep using the tenary operator. It's much compacter.
Only platform will be fine. We merge the platform changes in bigger batches back to the CMS.
please do not omit curly brackets