labofsahil/github-event-dataset-2012 huggingface dataset:
It *does* take an array of options with some nice defaults.
It just also takes the 6 things you'll want to supply every time as separate parameters.
above was all just fixing indent
nit: Should use === equality

What are we guarding against with this check? If an implementation doesn't support postMessage it's not clear that silent failure is the correct option; we should at least have some mechanism to inform the user that things are going wrong. Or is there some other case where the check can fail?
I try to avoid abbreviations like "repo".  I think it's better to use the full word.
Ok ok, bem me parecia que estava a dar uma calinada xD.
Yes, down below in the promo page.
k... chcialem ładniej... ;-(
You don't need triple-single quotes here (and other SQL statements). You could replace them with single-single quotes.
these should match the rest of the lib (`/*` style)
Hardcoded URL? `/panels/order/get/` instead of `/panels/order/get`?
Are you sure there does not exist any existing Python library for this?
I am asking why. So this looks suspicious: or you can change the icon itself and store it like that, or something else is happening. So why exactly 3%? Not 10px? Or something?
Rename keywords to plural versions.
So, this is the key: $.ajaxSettings.traditional = true;?
You can remove whole callback, if i is empty. What does callback in post do?
(See source for official `dumpdata` management command.)
Please cast to string
To have a dead creature cast a spell by using SmartAI use castflag SMARTCAST_TRIGGERED. That worked for me on several quest fixes.
without brackets, you were actually adding the flag, not removing it - () required
Please make it `protected` unless there's a good reason why it shouldn't be.
Can you check if just changing this one (without the rest) does the trick?
Agree. This is weird.

Envoyé de mon iPhone

Le 2 oct. 2012 à 11:46, Marco Pivetta <notifications@github.com> a écrit :

> In src/DoctrineModule/Authentication/AuthenticationService.php:
> 
> > + * <http://www.doctrine-project.org>.
> > + */
> > +
> > +namespace DoctrineModule\Authentication;
> > +
> > +use Zend\Authentication\AuthenticationService as ZendAuthenticationService;
> > +
> > +/**
> > + * Authentication service that adds login and logout methods.
> > + *
> > + * @license MIT
> > + * @link    http://www.doctrine-project.org/
> > + * @since   0.5.0
> > + * @author  Tim Roediger <superdweebie@gmail.com>
> > + */
> > +class AuthenticationService extends ZendAuthenticationService
> Don't think we need this...
> The way ZF does it has always been
> 
> get the adapter
> set credentials into adapter
> set adapter in auth service (if it hasn't been fetched from the auth service itself)
> authenticate
> (see my example on the auth docs)
> 
> —
> Reply to this email directly or view it on GitHub.
>
Marquer cette page ?
Note that if isAutoCloseSessionEnabled() is true, then sessionOwner.shouldAutoCloseSession() has no implact.
Read source code where `HttpResponse` is defined and look a bit around and you will understand.
I didn't see any filtering of the event_list, which I suspect from the `interval_start` argument, . Is there any chance `left` can get greater than the container width or that `left`+ `width` is lower than 0 ?

On second look, I only see a single call to this private method, with a hardcoded `interval_start` set to 0.

Better drop that argument then.
I tried, but it seems very hard to move this line below to compsys and preserve whatever it is doing with compctl.

```
compctl -U -K _fasd_zsh_cmd_complete -V fasd -x 'C[-1,-*e],s[-]n[1,e]' -c - 'c[-1,-A][-1,-D]' -f -- fasd fasd_cd
```

Maybe you can give me some insights?
Use this pattern a lot so would be good to know how to do it without a copy. I don't think this will work for a boolean index though?

```
x = np.random.random((10, 10))
idx = np.random.randint(0,2,size=10).astype(bool)
x[idx[:,None], idx]
```
Intend ?
Isn't this test just testing that Rails path helpers work? I don't think this is necessary with the `:id => one` test above.
I could agree for methods like `enableVim` or `disableVim`, since they are applied the extension context, and so they could be rightful methods. But there is a clear and intentional difference between 'methods' and 'functions'. There is no reason why `addCommands` should be a method of an instance, since it doesn't depend on the instance in any way. Same for `removeCommands` or  `onConsoleCommand`. Please leave them as functions, this style is intentional and differentiates between members of an instance and external utility functions.
That's the line that should show up if we had a status bar
See the comment above the form of the command. We should not allow to send random commands.
What would happen if user send a non returning command like top?
There's a bit of unneccessary overlap between text here and stuff a couple of lines above, perhaps combine?
I don't understand this either.  I checked going to grid_nx=5000, and it didn't really change, so it's not due to the finite number of grid points.  My best guess is that it must come from the square grid looking different in the g1/-g1 directions than in the g2/-g2 directions.  (square vs diamond)  I kind of think this might be something we want to figure out before merging.  But maybe we just defer it to the other tests you have planned like comparing to Chris's code using shear correlations and such.  It might just be something weird for the flat power spectrum that we don't actually care about.
I suspect it would be shorter, but I don't think it's any clearer.
Correct that flux is inexact *either* because there are pos / neg regions cancelling, *or* the flux-weighting method is being used.  The proposed workaround for having Poisson variation in the flux would fail, however: the code will always divide the flux equally among the N requested photons so if you pick a smaller N, you just get fewer photons adding up to the same flux.  However you could also rescale the flux when you're done by (N_selected / N_nominal), which would give what you want.  Do you want to open a new issue on this, or have an issue that collects these many suggestions for usability improvements to photon shooting?
I'm with greg here.  Let's loose this one, unless you have a compelling reason.
while you are at it { } ;)
The docs were recently changed to use links to base classes and detailing only those methods/attributes that have been specialised/added, rather than including all of the inherited stuff. This caused a significant number of changes so something undesirable might have slipped through. As @bblay points out, http://scitools.org.uk/iris/docs/latest/iris/iris/fileformats/rules.html#iris.fileformats.rules.ConcreteReferenceTarget is missing docstrings for ```name``` and ```transform```
What happens if registry is null? Is the new SshSensorAdapter never registered?
Should we do something different to tell the user that it hasn't been registered?
Why is the import in this file, then? Yes, we absolutely must htmlescape
code when embedding it in HTML.

-jj


On Fri, Dec 7, 2012 at 2:35 PM, adam <notifications@github.com> wrote:

> In bin/doc_code_merge.dart:
>
> > @@ -0,0 +1,22 @@
> > +#!/usr/bin/env dart
> > +
> > +// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
> > +// for details. All rights reserved. Use of this source code is governed by a
> > +// BSD-style license that can be found in the LICENSE file.
> > +
> > +library doc_code_merge;
> > +
> > +import 'dart:io';
> > +import 'package:htmlescape/htmlescape.dart';
>
> Its being used on doc_code_merge.dart#L354<https://github.com/dart-lang/doc-code-merge/blob/master/doc_code_merge.dart#L354>,
> maybe the question is do we really need to have an escape filter? I think
> htmlescape as a package has gone away, if we need it should we dig it up?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dart-lang/doc-code-merge/pull/2/files#r2354601>.
>
>
I'd rather use `initalise` than `initialize`
Maybe the %s should be in quotes like in the query parameter parsing?
Just in case they pass in false or empty string?
On Fri, 14 Dec 2012, Hannes Magnusson wrote:

> > @@ -494,7 +507,25 @@ mongo_connection *mongo_pick_server_from_set(mongo_con_manager *manager, mcon_co
> >  			return con;
> >  		}
> >  	}
> > +
> > +	/* If we prefer a secondary, then we need to ignore the last item from the
> > +	 * list, as this is the primary node - but only if there is more than one
> > +	 * node in the list AND the last node in the list is a primary. */
> > +	if (rp->type == MONGO_RP_SECONDARY_PREFERRED) {
> > +		if (
> > +			(((mongo_connection*)col->data[col->count - 1])->connection_type == MONGO_NODE_PRIMARY) &&
> 
> Is there a check somewhere for col->count > 0 so this won't crash?

Good one, I'll change the conditions around - but, I don't think it can 
get here at all when count = 0.
removed it from the page object, and from the test it will be removed when the tests are migrated
Not a bad idea.   I just did a massive windows refactoring, do you mind looking at that and merging into it first?
You're right. Fixed the docs.
Yes, I just edited my previous comment :) ^
??? The 't' is on line 79.
Why are you adding checking connections by username? Isn't this the same thing as byEmail?
I this line needed, I don't see what this is for ?
We really shouldn't be creating users with # in the name (I can't think of any locality that allows # in a legal name).
.. It shouldn't all be green. I changed a number of things in here, but they were specific lines, not pages worth.
should be Q_ASSERT(baro)
Oh, and it should be 'activesupport' rather than 'active_support', they will not get the same dep
MOAR final to the variable above.
I fear we can't just drop the function like that, we have to deprecate it first and drop it in the next major.

If the new calendar works without such "explicit" `calender_for`, I suppose we could make it a no-op (wouldn't break existing stuff, removing the function would throw a method not found error) containing just the deprecation notice.

@meineerde what do you think?
I see php54 declaring the option `['--without-readline', 'Build without readline support'],`.

Can you add a commit removing this and the rest of the references in php53 ?

Also, if you could confirm if php53 supports libedit or not, that would be awesome.

Thanks
Is this dependency necessary? Will mean that you cannot use system php, or another other php, with the formula.
Yep, 2nd one - all elements not appear unless you've paged through all of images. So I can't count them to go through all the list afterwards. Of course it could be changed logic of next one verification of each image. Feel free to propose your solution, I'm always happy to work on it
I made the change suggested by @davehunt :point_up:
Oh, I just saw that division is float. Never mind, I thought it was int.
>    No I don't, but I need it internally.

Why does it have to be an attribute if you need it internally?
I tried 'Partial dependence\nwith house price' but a two-lined label looks quite ugly. 

Personally, I do think that "partial dependence" is quite explicit (we don't write "Test error w.r.t. the house price" either)

Other people use "marginal effect" or "marginal effect on f(x)"
> Just out of general interest: Did you profile this and it made a difference?

It did. This line went substential faster. However, the total time didn't
go up by much, as this line wasn't contributing more than a few percent
to the total.
That's good point but I'm not sure what would be a good solution.

I think the right way to do it in OOP theory would be introducing getter and setter for $parent in PHPUnit_Framework_Test interface. But it will require to copy-paste its getter-setter implementation in all the PHPUnit_Framework_Test derivatives and potentially could break many code outside of phpunit that implement PHPUnit_Framework_Test.

I implemented it less brittle way - just made the $parent variable dynamically so anything passed in addTest() method will have the public $parent member on output. But it's kind of "hack" available in dynamic languages and you're right it adds lots of complexity because the $parent variable defined explicitly in PHPUnit_Framework_TestSuite but could exist in any PHPUnit_Framework_Test implementation.

I thought about making PHPUnit_Framework_Test as an abstract class (instead of interface) that could keep the getter-setter implementation and wouldn't require the derivatives to copy-paste one. But PHPUnit_Framework_Test extends Countable interface and it requires to implement the Countable interface in the abstract class what is not what I wanted to reach out.

Another option I keep in mind would be introducing an additional interface like "HierarchicalTest". It would describe the getter/setter for parent and only PHPUnit_Framework_TestCase would implement it and all phpunit's PHPUnit_Framework_Test derivatives. It wouldn't break any external code but the hierarchical filter wouldn't work everywhere. Another problem with that is it's less obvious why hierarchical filter isn't working when something not implementing HierarchicalTest.

What do you think about it?
delete all commented lines!
Is mongrel use still needed, since it doesn't seem like openid is being used anymore?
should it be 0 ?
I don't think so (but I may be wrong). Are you sure getRowAllocator links ?
Change this to:
```
return sorted(versions, reverse=True)
```
I think it refers to code here: https://github.com/mytardis/microtardis/blob/master/filters/__init__.py

But I don't know exactly how it works, or whether it's redundant now.
This should likely have a `language="JavaScript"` attribute.
* Is there any particular reason in using `yield`? I'm not against it, if we aren't trying to use it everywhere but just for some cases.
 * Same question for this slice/while/shift pattern, is this really necessary to create a temporary array?
Can't we just use for or foreach and iterate on the original array?
 * I'm not sure that we should bind this experimental method to `emit` which is not. We may expose it without willing it, if another API expose `emit`.
I imagine you made this for context menu, in order to be able to stop iteration when a listener returns something valid?
When talking to Mike, we discussed that these kinds of numbers were those that are also words. hot4you or love2hate for instance. Ambiguous doesn't really convey this notion.
hmm, nice to know! Thanks.
Should be 'given' instead of 'giveng'
You can add PHP 5.2 and 5.3 too
If `Y.properties` does not have `'threshold'`, t is going to be `None`, so before `ax.axhline(t, **tkwargs)` you should make sure t is not None
Ah, it was dependent on CLC-205, since at the bottom of the security xml, there was the restTemplate definition for canvas
Just put the sql strings as local variables in the method where they're used, and delete the SqlQueries inner class.
@christianv  You're right, it does. Solving this  turned into an interesting dive. The trouble with ng-switch here is that that directive compares different values of a single property, whereas we need to do different things depending on whether that property exists at all. I tried to hit this from every ng-switch angle I could think of, but couldn't nail it. Finally took a different tack and wrote a pair of filters in the controller. This fixes, but am not sure the extra processing is worth it. Opinion?
We could change this later to take in a parameter of the filtering type we are interested in so that we don't need separate methods for different filtering methods.
can you make these -%> so they wont insert an extra newline.
done in the last commit
Or you want the module to bail when it times out?
Blarg no idea, I tested it both at home and on my work environmental and worked fine and this functionality was part of another module that egypt asked me to split off into its own which was working then.....if you run the updated version does it pull the correct DC (should print status it) / work if you set DOMAIN_CONTROLLER to the DC ip?
Are the blank lines needed? If not would be nice to delete them.
This has to stay a final class.
Good idea. I use ``prism`` now as ``spectral`` didn't show all details.
And again no extra space.
the indentation should only use 4 spaces per level. You have too many here
No, bcz of DatabaseDriver.php#L307

One-To-One mapping is created only if all columns that make a combined primary key, are used in association.
In your case it would create Many-To-One, and consistency would be ok. :)
Shouldn't this be `fromId` instead of `fromID`?
Fine with me too, I'll make those changes.
I added these, we now have a "this" test for anything that takes a result.
And by "this needs some styles" I mean "I broke your nice styles", sorry!
Let's put these into a test constants file so we have one place to look for them, or in a resource, as you prefer
That's fine, but you should remove the comment then because it's inaccurate.
It's worth noting that MobileWeb doesn't support globalpoint since it was deprecated.
MW supports this.
Prevents network activity indicator from being displayed.
It is also non intuitive.  Given the environment that the Driver is running in, I prefer to keep the more explicit form.
Yes, forgot about those. I will fix that.
Actually, this entire loop should be rethought.
It's doing a property look up twice, but it's not always needed.

Also, do we need to check if the tag is an object? Are there cases where the tag comes back as some other data type?
I'm guessing maybe from the suggestions, but in that case, format the data inside of the suggestions loop when you're iterating those results inside of _showSuggestionsPopup.

Then you can skip having to create an object or checking if it's an object.
@cprice-puppet alright - pushed new commit adding the code snippet back, only change was to allow a backtrace to be passed, fallback to caller(1).
It could be yeah, but it seems like it fits more into utils (with some other currently "in-line" functions).

I was actually thinking about depending on `rackspace-shared-utils`, but I thought you won't like it so I rather just put it in utils module :)
The problem with `toFixed(2)` here is that a sales tax percentage like 8.1% won't be displayed properly. To two decimal places, it would be .08, whereas it should be .081. Consider either making it 'toFixed(3)` or making the variable a whole number up above.
Вообще осталось сделать нормальный readme и можно пиарить. Побольше примеров, пояснений зачем вообще мы сделали очередной гем для авторизаций, как он работает и т.п. Вдохновляться ридми аналогов можно.
Yeah, `_value` can be anything whatsoever (value type, class, primitive, etc).
I added it to stress, that this bug is fixed
Could you add a link to this section in "Download & Install" section (and fix number of ways ?)
update.
 you may use commas for the enumeration instead of the slash
no comma after edb
What's this tied to?
This doesn't match the [coding style guidelines](http://codeigniter.com/user_guide/general/styleguide.html).
There a line break missing here.
Is the first character in that string a "c" or somethring else. I see it rendered differently than the "c" on the preceding line.
please remove this ``@abstract``. It does not make any sense
I would say no; I don't think they contain anything we want to protect. But I am not a lawyer :)
Nit: it would be good to have this regex in `Resources` with little comment about what is does
Refactored here: d38c53abc3b4c1544faf6fb747031aafde1cf98d
How about renaming this to $maxDepth instead?

You can then also keep track of the current depth in the GraphNavigator only, and don't need to modify the visitors at all.
In https://github.com/tiramizoo/tiramizoo.github.com/blob/master/orders.md#show-order
there is /orders/uuid

It should be unified in one way or another
good point. ok. fixed.
Why? Using tabs has more advantages than using spaces.
This is for whatever local customizations institutions have done (templates, config files, custom private spaces, etc.), so they have a way in which they can convert their old structures into the new ones.
Стоит везде исправить шапки на те, как в других частях личкрафта. Копирайт оставь свой, а потом допиши еще мой с 2006-2012.
`Format` is for ANSI-coloured output. Did you really intend to put colours in the JSON?
Each statement on its own line.
Please use an `only_if` block on the bash resource instead of doing the check at compile time.
ah, it's my fault :), thanks.
bootstrapping > inicialización
would you mind updating the code style here to match the project's code style?

Something like this:

if (url.match(/https?:\/\//) url = '/' + url.split('/').slice(3).join('/');

Also, why not just name the method cleanURL(), getURL() or something simple like that?
Good suggestion - done.
Shouldn't this be except Exception or are you worried SystemExit or KeyboardInterrupt?
@tarjei ``that`` is already ``$(this)``. So it is already a jQuery object. You don't need to wrap it again with jQuery
I actually tried that and didn't succeed, but that was probably me then. I'll refactor.
当要修改一个开源软件时，最好了解一下原有代码的风格，并与其保持一致，而不是按照自己的喜好来。你这里已发现的问题包括左大括号、else的位置，以及缩进风格（应为4个空格）
crot还支持odt、rtf的，都继承过来。相关代码在http://cvs.moodle.org/contrib/plugins/plagiarism/crot/locallib.php?revision=1.3&view=markup 的tokenizer()中
is there a reason this is not enabled?
Generally, when there is a need for getting version from another file, VERSION.RELEASE_VERSION variable is being used. I mean this.
**Error:** Expected "if (...) {\n"; found "if(...) {\n"
WDYT about call this file `test_models`?
Mistyped "available" here
What about if its `.`? Does this need to handle that?
IntelliJ project files, which shouldn't be committed
Il ne faut pas l'initialiser dans le new car celui-ci peut être changer directement dans le input field. La variable ne peut donc pas être trustée.

Il faut juste le mettre dans le create.

De plus il faudrait lier une translation à un author_id plutôt qu'à une string.
- template file cleanup (don't set title in template file)
Please update the year to 2012
It is still not decided whether we should return a single 5 character code or just 2 character code. If yes, we also need to add
 The language returned is from the language codes defined by ISO 639-1
 ( http://en.wikipedia.org/wiki/List_of_ISO_639-1_codes ), using the
 rules set by BCP47 ( http://tools.ietf.org/html/bcp47 ).
to the description.
Can you use the link_url attribute instead?

Refinery::Page.where(:link_url => '/contact').any?

Same with the thank you page :-)
(Underlying "smart SQL" query, that is.  All query specs get converted into smart SQL get converted into SQL.)
On refresh flow, we need to send client secret also.
Assign the citizen object as Idea author instead of assigning IDs.
```html
<ul id="submenu_id_{sn_user_menu.ID}" class="ui-widget ui-widget-content" style="display:none">{sn_user_menu.SUBMENU}</ul>
```
Лучше создать новый глобальный объект, а не маскировать в nav переменные, которые не совсем ему релевантны.
will asInt() not work here?
blackberry.event is global, should not need this
Removed the function, was unused
yes, an `elif` statement would be more suitable.
Grab() and release() need function comments.