labofsahil/github-event-dataset-2012 huggingface dataset:
Hi. As the original poster I should probably explain "some" of the things in buildjs.cfg
Measure.js was added to provide the Measure plugin within the Editor. Why? Because it allows you to measure distances or areas which - in theory - can make drawing things easier, when you don't have an exact gps coordinate, but for example distances given.

Especially when you are using satellite pictures combined with the measurement tool and some handwritten information (e.g. there is a 5 meter parking space) this tool was very helpfull for me.
Could you loop over `:dump` and `:idump` and `@eval` these methods since they look at a glance the same for both on these simpler types unless I'm missing something?
Do we need the :library_instance_id at all? Or is it more just an optimization? With the upcoming work on content views, the fewer references we don on environment, the better.
`model` was the right keyword for this function.
IIRC, `v` and `V` unpack formats were supposed to be dropped from this patch.
The comment is wrong - cut-and-paste error. Should be
     * Create a UnionPlanNode that clones the configuration information but
     * is not inserted in the plan graph and has a unique plan node id.
The purpose  of the method s to clone itself and all its children

On Fri, Sep 21, 2012 at 5:28 PM, Paul A Martel <notifications@github.com>wrote:

> In src/frontend/org/voltdb/plannodes/UnionPlanNode.java:
>
> > -        // This node doesn't actually exist
> > -        assert(false);
> > +        // Should be at least two selects in a join
> > +        assert(m_children.size() > 1);
> > +        for (AbstractPlanNode child : m_children)
> > +        {
> > +            child.resolveColumnIndexes();
> > +        }
> > +    }
> > +
> > +    public ParsedUnionStmt.UnionType getUnionType() {
> > +        return m_unionType;
> > +    }
> > +
> > +    /**
> > +     * Create a DistinctPlanNode that clones the configuration information but
>
> This comment is wrong, and I can't tell if this implementation makes sense
> because I don't fully understand the now-quite-dead calling code and am not
> sure that it, as dead code, is worth diving into. Unless you have very high
> confidence that this is exactly what's called for, I would suggest that you
> simply assert(false) here.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/3/files#r1665955>.
>
>
seems like you can use a const for sms.ring.received and use it instead of harcoding the string everywhere. (same for sms.vibration.received)
Ugly color
At worst it's just a temporary extra array of zeroes until `_init_from_vals` finishes.  It makes it easier to write `TimeFormat` classes because those can be certain that the input values are well-formed and consistent.

For Time formats like `TimeJD` or `TimeMJD` it's actually zero-cost because the internal `jd2` value gets set to the `val2` reference.

I do agree that the code here looks unsightly.  One could probably move some of this into a validation method of TimeFormat that always gets run and makes sure the input `val1` and `val2` are well-formed and consistent.  The different TimeFormat subclasses could override as needed, for instance the string-type formats would complain if `val2` was provided, while numeric forms would create the zeroes as happens now.  I think this is a good idea as an enhancement issue.
This returns true only when we have met all required distances across all possible pairs in the adjacency matrix? A comment would be very helpful here, even if it just reinforces what a reader determines by looking over the code.
It stays with the new version no matter what I do. Does it matter?
I would do string-changes / grammar changes in seperate pulls.
is it `isUUID()` or `isUuid()`.

I noticed a few in RequestHandler that follows camelCased naming convention with the exception of `isSSL()`.
I agree, ternary looks good imo.
is it necessary to check `isRoomVisible` twice?
Small style thing. Add the  braces.
Missing line break after this line
This seems to be a `sys.error` within a `sys.error` - intentional?
Currently kernels do need to associated with a notebook.  We could relax that assumption, but I think it is a separate issue.
On Apr 23, 2012, at 0:01, Bussonnier Matthias<reply@reply.github.com> wrote:

>> @@ -36,6 +44,12 @@ def __init__(self, *args, **kw):
>>         # Dictionary for resolving document resource names to SVG data.
>>         self._name_to_svg_map = {}
>> 
>> +        # Do we support jpg ?
>> +        # it seems that sometime jpg support is a plugin of QT, so try to assume
>> +        # it is not always supported.
>> +        self._supported_format = map(str, QtGui.QImageReader.supportedImageFormats())
>> +        self._jpg_supported = 'jpeg' in self._supported_format
> 
> Well, it's true that I can put it at class top level, but I don't see why `'jpeg' in _supported_format` can be not defined. and Bool traits would be overkill no ?

No, it's not overkill.  But what can be undefined is 'self._jpeg_supported'.  In IPython, there should be zero instance attributes that are not defined at the class level, even if it is just `_jpeg_supported = False` and not a trait.


> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/ipython/ipython/pull/1643/files#r718863
It just feel weird seeing camelcase variable in L3, I don't mind if we are already ported to L4.
I think this is the right thing for now.  But I had seen someone mention that DDOS attacks can happen with GET calls, too.  I don't think we're threatened by that at this point, however...  But that might change some day...
Variables are case sensitive so I tend not to like to capitalize them. That being said, it appears this was done before you, so you're not required to fix it.
This still bothers me. The use of `self.osModule`. I'm pretty confident of what the standards `os` module does in any python project but I have to stop and think about what `self.osModule` is. Has it been changed? Does it work differently? What wasn't `os` good enough. 

My nazi-view is that if this is NEW code that we're going to keep then we should switch over to using `os` and `mock` in tests. Otherwise, just leave it like this. And almost always, feel free to ignore.
What is that ``999`` value?
space after the `#`s
Why are you using verify=False here? Don't we want to check that ssl is working to serve this file? It seems to me that it's a potential security hole otherwise.
Curious, why did you change this? New jQuery syntax?
Shouldn't be FIXME here?

Also to enforce this, I would add #ifdef RELEASE_BUILD #error

So the porters would fix it before release.
без буде вилітати exception при редагувані полів спонсора, без зміни картинки (image)
https://github.com/dustin10/VichUploaderBundle/issues/27
`tries` is `trials` in English
You should add a phpdoc here.
typo here: flashes -> meta
and what if the guy uses something else as ``$options['return']`` ?
what is the difference between this and `option.user`?
ちなみに、このメソッドはbooleanを返すので、メソッド名の最後に"?"を追加したいのですが、おかしいでしょうか？
Topic#owned_by(user)
↓
Topic#owned_by?(user)
hard coded formats are a localization pain.  Sticking with the localized styles is better..
See: https://developer.apple.com/library/mac/#documentation/Cocoa/Reference/Foundation/Classes/NSDateFormatter_Class/Reference/Reference.html
e.g.: 
[dateFormatter setTimeStyle:NSDateFormatterMediumStyle];
[dateFormatter setDateStyle:NSDateFormatterShortStyle];
add small doc on class members
Can we change it to 2.9.1:1.8 to match artifactory?
OK, good idea, I just pushed this.
Also took the opportunity to add some additional unit tests (all-match, and empty string), and expanded the whitespace definition to the full " \t\n\r\f\v".
Not sure what you mean...I didn't originally implement that variable. I just initialized it in the constructor because I'm trying to cleanup and standardize some code.
``request_specific_tags`` feels like a slightly awkward name. Why not do:

```
def tags
  super + ["campaign"]
end
```
No se necesita, y puede fallar en algunos navegadores
why cant you do this with one class name instead of two ids? use the .html() instead of .append() it would definatly be cleaner than Activity_Feed1
I don't really like this test. It seems very hacky, and if it fails it will leave mess in the build directory, which means that if the delete fails for some reason the final dist could end up with that test module in the resulting AS7 distribution. This is because to save space we do not copy the modules dir into every AS7 instance we create for testing to save space.

I would just leave the test for now. The proper way to do it would be to have the test suite infrastructure append an extra path in the testsuite target directory onto the modules path, and then we could create additional modules there without touching the actual AS7 modules.
Let's check for `if (!a.result.dataurl)`
This code is the same than the one in handle_call.js, is there a way of putting this in a single place?
Hum.. `undefined` is falsy no?

We should be able to
`additionalContactInfo.textContent = additionalInfo ? additionalInfo : ''`
Let's change `screen` to `overlay`. This is misleading. Thanks!
This is my fault :-/
This should be spelled busyPrecision I believe unless there's a pun and nuance involved.  This does appear to be used consistently, however.
don't really need to be removed
Is this not the same that:

var addressField = contact.adr[i];
if(!addressField.type) {
  addressField.type = TAG_OPTIONS['address-type'][0].value
}

If not possible, you can always extract the contact address to a variable:

var contactAddress = contact.adr[i];
...
streetAddress: contactAddres.streetAddress; // And so on
Need to get rid of the code duplication here. Execute should be a simple wrapper around executeBinary
don't remove this line :o
callbacks should be moved within the v.check() closure. In this case, calling callback(); is adequate.
If we're moving to `~/.rspecrc` as the main convention, this warning should be updated I think.
I'm personally used to the convention of starting character ranges with hyphen `-` and in the rare case, ending with a hyphen - the important part being the hyphen in the character class is either at the beginning or end.

I prefer the beginning because ordering the character ranges from specific to general like in [re2](http://code.google.com/p/re2/wiki/Syntax) [:print:] is space plus graph [ [:graph:]].

Backticks are recommended for regexps to avoid string escaping rules.

Suggested change:

```
"^/apps/([-.[:alnum:]]+)/procs/([-.[:alnum:]]+)/instances/([-[:digit:]]+)$"
```

And it would be good to see a corresponding validation of application name somewhere else in this commit that follows these rules so that new applications cannot be created that don't satisfy the encoding rules.
I think this is imprecise. What are these families of variadic functions?

So, what do we know?  We actually know that f is related to a function on a List[T], because you are requiring only type T to be passed in, so we can define flist:

```scala
def flist[T](list: List[T]): T
```
And what we are requiring is that
```scala
def flist[T](list: List[T]) = list.reduceLeft(f)
```
for some ```f```.

So, your objection to requiring a Semigroup is that you are saying that you really don't need associativity at all. What you are saying is that you just need a function that can be written as a reduceLeft operation.

My concern with this is the following: this seems like a false generality and it strongly limits the internal implementation. If we required a Semigroup now (which is associative, and has this property), and then later we change our mind and decide we really need some more general reduce function, that is not associative, we can add it later. If, on the other hand, we discover a parallelization that we would like to do that requires associativity (likely), all the functions we use this on are associative (and probably 100% of them are actually numeric sum), then we have a breaking API change.

If you can't come up with a compelling example of a non-associative function to plug in here, I am going to block on this.
Why do we need IContext and Context?
Move t() logic inside _garmentbox_factory_production_order_delivery_form_row()
Il ne manquerait pas un filtre ?

* Limiter l'edition de boites au seul createur de la boite et aux admins/mods
* Pareil pour la suppression
'Need to export ...'
Yeah, agree.

Incomplete agree, as usual, the output information may be change, but for error output, we often can catch 'not installed' for rpm output, and 'No such file' for finding a file. thanks.
isinstance(a,int) is better than type(a)==int
Adding info to the API doesn't hurt, so I'd say yes, no need for the `includePath` parameter.
We should perhaps deprecate this?
Please keep the phpdoc aligned (the [PHP-CS-Fixer](http://cs.sensiolabs.org/) can fix it for you)
I am ok with the negative form for the command argument, but could you rename skipScripts to runScripts to avoid the double negative problems in this class?
read the full sentence
In doubt don't change anything than the english locale, even if you think you should edit other ones, in 90% of the cases you shouldn't :P
links are inline elements and thus perfectly fine in forms, but yes it would need to be inside the form tag.
sprinkling of jasmine tests?
I think we are meant to be using short names for these?
Is this a test? What are you doing with the `user` object? This is all setup code. It should be in `setUp`, not in `test_*`.
'antiredirect' maybe? more descriptive of what it does
Are the comment usefull here ?
I would move them inside of get_site_info.
I tried this again, and:

* I couldn't get `@cache.getRegion` (line 73) to ever return nil for any "reasonable" failure scenario (even disconnecting from the network). That renders this check moot.

* if `@region.put` throws an exception (e.g. all GemFire peers are unreachable) the plugin will indeed drop messages, but since the exception is caught in `agent.rb` the plugin is still ok. Once I fix the problem, the next @region.put works.

This is all made mode complicated by the number of possible topologies in GemFire.
I.e. if I really wanted to ensure no message was ever lost, I could configure it as a peer instead of a client cache, in which case the only failure scenarios for `@region.put` would be catastrophic events like an OOM.

So at the end of the day, I'm going to make this even simpler, until we get more feedback from out in the trenches :)
Thanks for pushing me to think this through :)
add default sort
It isn't a firefox usecase. I can let people from m-c decide about the usefullness of this ...
Why doesn't just plain `Components.utils.import` work here?
Not what I was really talking in my last review comment. I kinda would like to see elements for a specific data point bundled under a separate span element. Like:

span id="resident"
  span class="label" Resident: /span
  span class="data" n/a /span
/span

Same applies to all the other elements.
As an extra check you could do something like:
Assert.true(search_results_page.get_url_current_page().endswith('/?s='))
Also you'll need to implement the get_url_current_page() method in page.py.
I think the readme is missing a simple section describing how to enable auto validation on save - probably by calling validate() in the preSave() method.
This method was designed for deprecating methods and so prints out the caller of the deprecated method. This causes some odd output:

````
Warning: Puppet kick is deprecated. See http://links.puppetlabs.com/puppet-kick-deprecation
   (at /Users/andy/work/puppet/lib/puppet/application.rb:340:in `block (2 levels) in run')
````

Instead of using this, I think it can just us `Puppet.warning` which won't output that second line. It makes it a little harder to find later, but isn't a huge problem.
Please observe the coding style: Variable names should use lower camel case, ie. self.binaryName, self.fileWatcher, etc.
Sorry, finna fix that.
ad6a714f4df4785622a0ef3028a13b31e3c4e815
Look at this : https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md for Coding Style Guide
Undo this change.  Words in `@package` are splitted with underscores by ZF2 CS
You retored this but not the import, now this is broken. Restore the import and the docblock as well
`extends` must be share the line with `class`
Should that not be $line = stream_get_line($f, $maxLength, PHP_EOL);
Add your doc blocks
redundant braces removed
wouldn't the second comparison always evaluate to true?

As index is an unsigned int and can not be a value below 0 anyway.
Fixed now. It was because I used tab on the first line and space on the second line, even though they look the same in the file, but seem to have a difference here.
THE :D
We prefer to get our source straight from the project whenever possible. What is the reasoning for switching from `apache.org` to `mirror.synyx.de`?
Another note, if you are comparing arrays / objects you need to use deepEqual

A good workflow is to make sure that the tests are passing when you are using CouchDB, since we aim to be CouchDB compatible as much as possible, changing this to deepEqual shows the tests passing with http-http replication, and failing when idb is involved, which makes it easier for us to know ehere the issues is
```javascript
var addAlert = function(type) {return 'alert ' + type;};
var issueAlerts = ['issues_opened', 'issues_closed', 'issues_reopened'].map(addAlert);
var otherAlerts = ['push', 'commit_comment', 'download', 'delete', 'gollum', 'fork', 'watch_started'].map(addAlert);

...
else if (issueAlerts.indexOf(alertType) >= 0)
...
else if (otherAlerts.indexOf(alertType) >= 0)
```
Had to introduce this dirty fix because of

  - https://github.com/doctrine/doctrine2/blob/beae0865dbe7416f2639100c45dcb477b734af9d/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php#L329
  - https://github.com/doctrine/doctrine2/blob/beae0865dbe7416f2639100c45dcb477b734af9d/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php#L337

These steps cannot be reproduced within `doLoadMetadata` with the given parameters, and patching `Doctrine\Common\Persistence\Mapping\AbstractClassMetadataFactory` didn't work either...
Ideas?
Looks like my less compiler does things a little bit different :p
Isn't `var` missing for `type`?
what's the default value ?
Leave a space before the closing ruby tag.
The user_id references the contact owner. I am trying to make it such that only the contact owner can edit contacts. Now that I look at it, I think this should all be happening in the controller.
You dropped the toBasetype
I have no idea why it's there, sorry, my bad.
why not put an id on this for the JS selector later. Also, I believe `action` is required and must be non-blank according to the spec. I know this works, but I've been called on it, so I guess we want to not do that. I usually do:

```html
<form action="{{ request.path }}">
```

It's probably redundant, but specific.
sorry that shouldn't have pushed :(

fail on my behalf
We do use `staticfiles` in mozillians but `collectstatic` apps collects only `browserid.js` and not `include.js`. Any clues?
`self.assertEqual` feels so Java-y. The shorter tool `eq_()` with the same signature should be in this module.
Yes, one way could be to have the DataProcess object have an attribute process_id, which will contain the pid after the process is created. This pid can then be used to stop the actual process too. I have the working code. I have to check with Maurice if its okay for the DataProcess object to have the above attribute.

> We need a place to keep track of the pid otherwise the process becomes unmanaged.

—
Reply to this email directly or view it on GitHub<https://github.com/ooici/coi-services/pull/274/files#r1590300>.
`if (` for these, and we need a test or two, rest looks good thanks!
does the form still refers org_ids ?
Here for example it would be better to use a constant.
Detection with the title in the header, more simple.
Excellent question.  Helped me answer a question I had.  The javascript in email-browser.js does an ajax call to EmailAccountSummaryController.getAccountSummary which returns the inboxUrl in JSON.  The javascript updates the href with the response.
I would add something like:

    In this case, the conclusion is the second part of the sentence.

Not sure on the wording.
Isn't that for when we're authoring Gems?
There's CoffeeScript sugar for this:

    > coffee -bep 'cli.run process.argv[2..]'
    cli.run(process.argv.slice(2));
I seem to have moved this method.
We could also refactor to add a "full_name" or something to the repo model so we could just search for "schneems/wicked", then we could do it all in one query  `Repo.where("full_name in (?)", @own_repos.map {|x| x["full_name"]}).all` we could then memoize the result and check individual repos in memory. Having that column on the repo table could also be handy in other places too.
@kibiz0r, why did you go this route instead of just `trampoline.retain`?
looks good, just to be clear github_id corresponds to the github username, like "gomayonqui" in your case
You should document that in-situ, then, along with all the reasoning.  Otherwise this looks incredibly suspicious. :)
That's a good point. On the other hand, it's also a good way of re-validating the list in the index from time to time.
Is Math.random() sufficient for a salt?
It looks like `crypto` has a `randomBytes` method where you can specify the number of bytes you wish (16 might be enough?)
There is no permissions feature yet. Also there is no notion in the groups api to add someone as a group 'manager', only as a member.

Securing the groups API will have to be a separate work item altogether.
* Rephrase first sentence to something like "This portlet, which is an extension of the Asset Publisher, enahnces your ability to filter on Assets."
* Add comma after "For example".
* In the last sentence, add comma before second to last item.
what? this is implementing the interfaceaware @stof that is how @everzet said to do it in the docu
other.receiveDamage( 10, this ); this.kill(); },         zo liever?
It should be consistent with other libraries, starting with a brief library description and how to load it.
See e.g. user_guide_src/source/libraries/image_lib.rst
новый класс - это лишнее...просто создайте категорию  Cell (Mutator) в main.m
Это да, решил адаптировать алгоритм, воспользовавшись счастливой случайностью. Однако по условию следовало мутировать ровно на perc процентов, что сложно гарантировать, не будь количество генов кратно 100, а в простейшем случае - просто 100.
Согласен, потерял универсальность алгоритма. Спасибо за замечание!
Нашел такой способ определения константы, не хотел #define.
Хидер разве не есть место для определения констант?
ну собственно на данном этапе и требуется только интерфейс. внимательнее ознакомьтесь с заданием.
I'm pretty sure that's what this was.

-- 
   Craig M. Stimmel
   Software Engineer, Academic & Collaborative Applications
   UW Information Technology
   University of Washington
   (206) 616-6597

On Wed, 22 Aug 2012, jswan2 wrote:

>> @@ -51,6 +51,8 @@ def get_shifts(year, month, day=None, user=None, week=None, payperiod=None):
>>          for shift in shifts:
>>              shift_date = shift.intime
>>              this_week = shift_date.isocalendar()[1]
>> +            if this_week == 52 and int(month) == 1:
>> +                this_week = 1
>
> Was this block that thing we did to fix how isocalendar handles the first week?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/abztrakt/labgeeksrpg/pull/3/files#r1438777
If we make changes to pass the callback to CloseLiveBrowser, this block of code should boil down to

```
// Send response
browser->SendProcessMessage(PID_RENDERER, response);
```
The default timeout has been halved, but remains overridable by the user... in my opinion 15 seconds may even be too high a default to allow for good user experiences within mobile apps.
when I try that, it doesn't recognize the label =(.  If I inspect the source in chrome, it shows the label as "user_Email", etc
In order to match the code style, could you please add a space before and after the pipe (`|`) char?
Right, just confirmed that. I will allow site_media then.
scores.fill(np.inf)

is a faster way to set all values of an array to the same value
What do you think about getattr(scipy.spatial.distance, sort_func). We could allow convenient access to all distance metrics from scipy: ica.find_sources_epochs(epochs, target='eog', score_func='euclidean')
I think the distance.correlation also is more appropriate than pearson...
what I had in mind is to be able to pass a list of evoked to plot all of them. In white, yellow, green, ... the mne_analyze way.
I know, just that plot_topo doesn't support it..


On Thu, Dec 6, 2012 at 7:25 PM, Alexandre Gramfort <notifications@github.com
> wrote:

> In examples/plot_topo_compare_conditions.py:
>
> > +
> > +print epochs_au, epochs_au
> > +
> > +layout = read_layout('Vectorview-all')
> > +
> > +evoked_au, evoked_vi = epochs_au.average(), epochs_vi.average()
> > +
> > +
> > +###############################################################################
> > +# Show topography for two different conditions
> > +
> > +pl.close('all')
> > +for evoked in [evoked_au, evoked_vi]:
> > +    pl.figure()
> > +    title = 'MNE sample data (condition : %s)' % evoked.comment
> > +    plot_topo(evoked, layout, title=title)
>
> what I had in mind is to be able to pass a list of evoked to plot all of
> them. In white, yellow, green, ... the mne_analyze way.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2338840>.
>
>
This needs a javadoc sentence.

Also needs an "@since 1.10, 1.9.2" annotation on it.
why is this an error, it should just return immediately, if source is null or undefined it's an error (argNotNull).
you need to register the ``acme-something`` namespace alias in your root tag (instead of ``acme-hello`` which is not used)
发送给客户端的字节数，响应头不计算在内
发送给客户端的字节数，响应头大小不计算在内
可能更容易理解。
I agree, but this entire block (lines 143-149) seems to like overwriting that variable
``` js
.put('/' + db_name("b") + '/foobaz', "{\"foo\":\"baz\"}")
```
IIRC, there were also problems with default sizes being 8 characters, so you might want to also test with some longer strings. I can't find a ticket for that however.
typop here: extra ``e`` in ``using``
Alright then, private it is. I'll also remove the empty constructor then, we'll have no use for that.
Yea - I can now finally load the plugin into SketchUp directly from the repo. Makes me a happy :panda_face:.
Remove these deprectaed headers
Uh, store*
Please add some documentation as to what `index_classes` is. An array of what? from where?
seems like rsdns is everywhere :P
Well looks like that should indeed be a separate if, if you want to test both
Rather than accept an id argument, simple change "id" in this function to "server.id." Then when you call this with poll_until you won't need the lambda, you can just pass ip_is_available directly.
What is andrei supposed to mean? Please rename the file accordingly :)
Doesn't seem that generous to me, you've still got wait times < 1 second. I'd modify the lifespan and maxIdle params to ~ 5 seconds and allow for a ~ 1 second diff either way. I was going to point you to ExpiryTest, but although the code there is simpler, it doesn't allow for weird scheduling either (and it also doesn't check the lower bound).

I think something like this should work, without involving eventually():
    put with lifespan = 5 seconds
    sleep 4 seconds
    test that the key is still there
    sleep for 2 seconds
    test that the key is no longer there
Done in a new commit.
Let's change this to say "followed by an immediately executed function". I believe that was @krisk 's term.
Agreed. The None case is handled in exactly the same way as it was previously.
I didn't have enough exposure to ```pip``` to have confidence, so thanks for the clarification.

Note: For clarification, I read what you said to mean "even if the original install wasn't done by pip, no reinstallation will be done".
@verbit Line 508 of `lib/matplotlib/backends/backend_tkagg` is

```python
FigureCanvas = FigureCanvasTkAgg
```

so the return value of `pylab_setup[0]` does indeed have a `FigureCanvas` for this backend. Do you see this behaviour with `qt4agg` or `gtkagg`?

Perhaps this is actually a bug in the `tkagg` backend?
Is it supposed to work?  Can we reference a Marionette or Gaia issue, here?
Hmm...the python docs don't call out support for 2 args - https://developer.mozilla.org/en-US/docs/Marionette/Marionette#switch_to_frame%28%29. Are the docs out of date or is this code incorrect?
But it does what I want :D

If the timeseries is nil, it returns a nil, which trips up the precondition.

Would it be better to use ((complement nil?) ts)?
Should include other oae- folders as well.
I think the email field should still be `text_ci`. It looks like there were some commits to `schema.xml` to the `solr` project back in April that didn't make it into `search.impl`.
newline before for please and use for (int32_t i=0; i<x_n; i++) please
Thanks for the review, I will include this fix with double quotes in another pull request, this one can be dismissed.
i think that it will return null if there will be no results. This is not a query builder method.
Whoops. debugger.
I think we should name these two properties something better. They're no longer set to the last observed size after each loop iteration. They're only used in the case that the webkit bug is present. Maybe we should call them `webkitFallbackSizeA_` and `webkitFallbackSizeB_` instead?
Oh sweet, got it. I was wondering what that was supposed to be...
I've already said that ;-)
JESUS!
shouldn't you return here then? seems weird to have an explicit case for it without returning.
The error_message doesn't ned to be freed to thats fine.
I'd rather not use ``inlineCallbacks`` in *my* code (IMO they complicate debugging and invite ambiguity), but that is purely a matter of taste (especially in this case).
Directly injecting HTML elements into the `__` function is not a good idea. You should replace this and other occurrences as follows:

__('Simplified: %s', array('<code>page-name/:user/projects/:project</code>'))
Spaces after commas, around () and so on. Keep the style of the code as we have it elsewhere.
*Registracija je bila uspešna.*
Spaces are corrected, what comment should we make here? About converting time?
I kind of understand hidden HTML part. What I do not know is, how high up the hierarchy should this fragment go? As I see it, this would be common approach for mostly static content. If I remember correctly this part is very dynamic (meaning content will likely change when moving on map) but more importantly this is generated in a loop which implies loading HTML fragment and populating HTML fragment for every item. Have I overlooked something?
Is this really good label on the form? Maybe "Send"?
Modify this to return assigned node?
Import only modules.
Maybe not, but they certainly did views that way. Will move to class based
I haven't followed the code very closely but why do you need to store the filter value in a class name? Why didn't you use a hidden input for instance? (in which case http://api.prototypejs.org/dom/Form/serializeElements/ would have been very handy for building the update URL query string)
But the inlined version could avoid doing work it didn't have to do, eg. scripts. Now you have them all being processed through functions - and yes, `handleScript` does check `script.type`, but after we've already entered another function scope and asked the runtime to create whole different execution context - one that can't be optimized because it's argument is a object that contains circular references.
Is 0.01 the right threshold?
Agree with you.
Changed to used GetBufferSubData instead.
Will add to the pull request today night.
Line ending change :/
Really, you need to import classes of super packages
DoAuthorize is for transactions that were originated with a PaymentAction of "Order"
http://www.paypalobjects.com/en_US/ebook/PP_APIReference/authcapture.html

Btw, PaymentAction object seems deprecated in DoExpressCheckoutPayment
https://cms.paypal.com/us/cgi-bin/?cmd=_render-content&content_ID=developer/e_howto_api_soap_r_DoExpressCheckoutPayment
Was tut das genau?
This comment seems to suggest to me that you think every pair of [] instructions is nested inside of another.

This is a valid program: "[][]"

When I use nestLevel in my interpreter it means "how deeply nested am I, i.e., how many nested loops are there, relative to some starting '[' character.
This file is actually required...
"an equal sign"
Also this is element access without check if it exists. So far we have not used `dataset`. Is it support in ci 168?
Specifying 0%, 100% explicitly is not strictly needed. Same in some other places. But I don't mind much if you prefer it that way.
Should this be `lua_pushboolean(l, 1);` instead?
And take this with a grain of salt, but [this article](http://excess.org/article/2011/12/unfortunate-python/) suggests using `rindex()` instead of `rfind`, because when `rfind()` fails, it returns -1 instead of `ValueError`.
Fixed the header. Just ti be clear: Strictly speaking, that example that follows (as I've written it) is not fully self-contained without numpy. Is `import numpy as np` implicit throughout the docs?
You are right
https://github.com/josef-pkt/statsmodels/commit/f10c87f2fad3ce5a1d351778dd7bf196683e83e7

I think I copied your changes over to my Stata working directory, and then didn't pay enough attention, when I decided to commit my changes on top of your file instead of keeping it as a new file, when adding it to git.

I think you changed the nans just after I got started with your script in my Stata directory.
Yes! Work it harder, make it better!
I thought the order was as follows:

1. run __init__ (doing nothing but creating a placeholder "app")
2. run.py executes, running the make_app function which instantiates a Flask app, and then sets the __init__.app variable to bind to the newly created Flask application
3. view.py then is imported, it imports "from rhaptos2.repo import app" and uses app.config app.XXX to perform its decorator based setup of routes etc.

we could either keep app as it is or we could change views.py to from rhatps2.repo import _app as app 
or some similar solution.

Or am I missing something?
This needs to follow phpBB coding guidelines, each bracket needs to be on its own line (this and any other instances).

}
else
{
Yes.  The python layer has these names for drawShoot.  But we never changed the corresponding stuff in c++.  (And I don't see a compelling reason to.)
Yes.  Indeed, the sort of more strictly structured approach that Jim mentions below would provide a natural framework for doing just that, so I think it's sensible for us to wait and see how things evolve a little bit.
"work the first time"
(and I'm laughing at the original version of this sentence)
Any reason not to allow PositionI, which would have to be converted to a float array?
Agreed, happy to leave this as a TODO.
Thanks >.< Gonna change
Was never sure if this worked. My goal here was to find nodes that I'd run the hosted_publisher recipe on.
Oh, I read up on these myself, now I know what they're for.  Never mind
Delete commented lines.. this shouldn't get committed! 

We use version control for a reason
they are different :( one is deprecated (the one we used to use), there for backwards compatibility
this one should be replaced with a logger
Writing this "MutableMap" makes me feel dirty, but is required because of the way Location (and entity, and policy) are currently implemented: the super-class modifies the map so that the sub-class only sees the remaining entries in the map.
The getResource() method does some fancy (unexpected?) things for dealing with file and class-path references that aren't actually URLs. So if someone passed in "http-example.war" that was on their classpath or whose relative path was valid, it would previously have worked. 

Perhaps we should be strict that it's not just starting with "http", but is "http://" or "https://".

Perhaps we should use a variant of `CommonCommands.downloadUrlAs(...)`. Unfortunately the existing variants aren't good enough but it should be fairly easy to refactor that, so our download commands we execute when installing/deploying are consistent. For example, when installing it will have tried to use curl and here we use wget - but therefore wget might not have been installed on the machine.
That’s funny. Thanks.
These are floats I believe so should be `4.0f` etc.
:thumbsup: Can't believe I missed that one!

BTW @bobbus, this also applies to `admin/categories/_category`.
`lambda { ... }.must_raise(X)`

(which will be a `RuntimeError` per my prev comment)
Cool, I didn't realize tuples of numbers were ordered. Fixed everywhere.
Is the a reason you are using ``escape`` here?  I don't think it's needed.
Maybe use DataSource here?
Please don't use HTML in the exception message. It does not make sense.

And the indentation is wrong
А из скольки потоков ты добавляешь в toMerge?
Надо экранировать
why do we need the test_app in this method if we are already using the details page of that app?
You're not using this return value anywhere. What is this returning? Can we make it a property?
home.py:60:86: W292 no newline at end of file
I couldn't figure out the css in the 10 minutes that I tried it for. I'm going to touch base with Frans on this one and leave it for now.
Will this ever be executed? It enters here if there's no framework, right? So the internal `unless` won't be executed.
You are right about selected_add. With the .html, it adds a little overhead. 
I mistaken this with python optimization.
Shouldn't it say ``which implements the **shrunken** nearest centroid classifier``?
This will pose problem in the sparse case.
so does it throw an eligible error message if sparse array is passed? ;)
I feel that the long lines make some stuff easier while doing cp to console. The should be only in the test_ and only as long as I'm  changing lot of things.
Add default value here.
Variable name missing.
localhost and port 9999 are hardcoded

Can be Stuart's approach[1] applied here?

[1] http://lists.jboss.org/pipermail/jboss-as7-dev/2012-February/005391.html
Might be better managed as a config file of some kind, but not a major issue.  Something to consider for the future.
This was an auto-detab FYI.
It already had the correct loc but the *this* expression is modified and loses its original *loc* field in `AssignExp::AssignExp` in the statement `e1 = die->semantic(sc, 1);`.  But at the top of that function the original expression is backed-up with `Expression *e1old = e1;` and then used in the call `e1 = e1->modifiableLvalue(sc, e1old);`. So e1old is really e1 with the right loc. I don't know why this is done this way but DMD is a convoluted mess..
See memory leak comment above.
remove if not used or add a test with it
was for holder

meaningless word here, removed
_Lets_ -> _Let's_
Yup. Annotations are dumped elsewhere.
You are correct, added (back in)
This can't possibly get past review....
As I told Richard, exceptions are not welcomed in GDB. 

I prefer to have an unknown for longer than necessary than having my GDB crashed after half-hour searching for the place to put a breakpoint (with the right context) just because a dump function wanted to be complete.
Isn't this always testing the row that was just removed, so will always break out straight away?
Rows are added to rowsToSort via the append method, which does not take ownership (ref count stays at 1). In the above code I set the rowsToSort entry for the returned row to NULL (see line 3850).  When the activity completes the call to  rowsToSort.kill() loops over the array, but all the entries are NULL so there is no double release.
Long name, please.
The new pep8 will complain that this isn't indented with 4 spaces :)
I'll kill it off so...
btw, the test should be in the ``Composer\Test\Repository\Vcs`` namespace (moving the file too) to mimic the namespace of the tested class
rename method with a more descriptive name. This method actually clicks the link. It uses the link to do that but the name should be some action like navigateToLoginPage.
Although let's do that in a separate diff.
I don't either; I was responding to your question about why we don't remove the field.
The privileges are case-sensitive in current master. As far as I can tell, case-insensitive privileges should never have worked correctly. If you can confirm that these privileges used to work, I'll try to get case-insensitive privileges working in the new privilege system.

Otherwise, please fix your casing here.
How about:

    def autosave
      @options[:autosave] = true
      self
    end

Not sure why you were passing a symbol, either. `true.to_s` produces the same thing as `:true.to_s`.
Ok, but this is the issue.  I do have capistrano but it's saying that the constant isn't loaded.  If we don't load any of the code, then I wouldn't get any of the benefits of using the rvm-capistrano gem.
why deleted?
I think `git flow feature start` automatically checks out the new feature branch for you, making this command superfluous.  You can verify by running `git branch` immediately after `git flow feature start`.  I also have my zsh (and before, bash) configuration show the current git branch in my prompt since it gets tiresome to run `git branch` all the time.
Can you remove that file?
I agree that allowing all parameters to be set in the constructor is desirable.  But I don't think "radiiSquared" is a parameter.  It's just a value derived from the radii parameter and cached for performance reasons.
I don't get why `Enumeration` is called `Enumeration` (instead of ie `NamedValue`).
Isn't the constructor call required for every single value overkill ?
_(This is partly a note to myself as I don't have time to check before next year the rationale in the doc)_
I changed it to `spatialState` because its a bounding volume and a model matrix. Not a tree or a mini-scene-graph yet.
Make sure you understand what this method does before commenting please. Instead of doing:
```JavaScript
self.bind(Event.MOUSEDOWN, self,mousedown);
self.bind(Event.MOUSEUP, self,mouseup);
self.bind(Event.MOUSEMOVE, self,mousemove);
self.bind(Event.DBLCLICK, self,dblclick);
```
using this method, there is just
```JavaScript
self.bindAll(['mousemove', 'mousedown', 'mouseup', 'dblclick']);
```

You can still say you don't like such implementation for some other reason, and I don't insist to have this method either. But when you said "default implementation? We already have a default implementation of this and it is called EventHandler.bind(...).", I feel like you only read the first line of the method description, and posted you comment based on that. It is not a good way to review code, man.
This is an old change in WebPI that was shipped already, but just not pushed. I can explain in person what this does, but it is not part of setup, so should be safe to just merge.
remove inline style and replace with css class
To me, this sounds like we only write data into the provider buffer IF offset and length are specified.  It click better (IMO at least) if we keep the previous offset comment but make note that the offset default is 0.  Just thinking out loud.
ditto re force
OK, add a comment then and say something like "don't use window.alert in real life" :)
Just one space after ":".
The class is named `EchoApi` but here you use `ECHOApi`.

This code won't compile
This value results in an extremely tiny padding/margin-right (as you can see in the CSS file below)
Yeah I've done it with a pointer before but it's easyer to just use the return value.
Please use `core.memory.GC.free` instead.
Yah, that's a relatively new thing. At this point it's unclear what's the best policy to decide between CTFE and sheer templates. Ideally whatever computes values would be CTFE.
I kinda like the approach here of returning uint, the 1-based index of the matching range. That way we can just use canFind as a Boolean, or actually look at the result. It's more informative at no loss in convenience. Thoughts?
Same here. Might just be your editor.
wouldn't it be easier using commons-compression?
On most systems, I use `chef-client::service` to install, enable, and start chef-client as a system service (i.e. with `-i` and `-s` options). I like this approach (a) for consistency, and (b) to easily be able to tell if the client is running or not.
Actually it (supposedly) is a class that is called when actions are made and you can add an install(), uninstall() etc. methods which are run when actions are done.
better to use a mixin or a hex rgb value.
Is this because the missing sg? You could change the other side code to use the stack if sg is not provided.
I think this comment needs to be fixed - you say "either" and then only describe one option.
Yes, but if we remove this, VirtualProperty annotation will work only together with SerializedName. If you sure, that this variant is better, i can try remove this.
Request change to:
Here you can select your second preferred navigation tool. It\'s activated by long clicking the navigation menu item.
I like 2nd more, it's easier to read for me.
These backticks breaks the sphinx output
Should be using `.on()` and `.off()` here
MINOR: Comment does not refer to actual function.
But, what if they just want a custom region name? Seems a little onerous to force them to configure a whole region, just to get a different region name.
Given it might not be a CCF, maybe reword to...

Consider using a CachingConnectionFactory with attribute 'cacheConsumers' set to TRUE.
Ah, my mistake. Didn't know there is a "No articles" text coming up.
@naleksi you can add this if again if you need to. Just pull these changes and merge/rebase to your local feature branch before creating a pull request.
I would add ISite to bbb.py rather than creating 2 ZCML directives here.
"can be substantively" - don't split infinitives. :)
In a test, you probably don't want to seem wishy-washy... this "unless" makes it seem like you don't KNOW what's going on. You'll probably want to setup the test that you do know what's going on (because you set the environment beforehand),
lol my bad, one sec
When doing a translate3d here, you should also do a rotate3d instead of a plain rotate.
`GoogleAuthentication` &rarr; `GoogleAuthenticatorRails::ActiveRecord::Helpers`
`GIT` -> `git`
@apex13 

* Fixed the `There`
* Removed the expand links (since they're not doing anything)
* Added a link to `/system/doc`
I'm actually against 2 spaces instead of 4. We should keep it consistent with the OAE.
Shouldn't be a configuration option ? The class can exist and still use the PHPCR, in case we have a PHPCR and ORM project ;)
Hmm...this calculation is strange. 11/12 of the screen-size...ok, so it doesn't fill the complete screen, only almost the complete screen. But what with `- 2*EDGEINSET`?
thats true. I will fix that.
we should probably call this `setProperty` since it can be done more than once to the same property
It's `AUTHENTICATION_BACKENDS`, and I think it only accepts strings (dotted paths to the actual backends). Adding an import statement for the `RateLimitMixin` example would also help.
This isn't necessary. The job of the writer is to create the image.
Ditto here. All my patches have been merged upstream.
NB: I'll remove this; it was just for testing.
Config option?
Should be removed, not for public consumption. This may change in the future.
I think the wording is still off.. maybe..


"An interface for receiving Activity results from TiActivitySupport"
do not delete id gen
Fixed in 9e21793
Tämä ei ole se mitä `map` tekee jos sekvenssi pitää sisällään kokoelmia. Funktion `f` oletetaan ottavan vain yhden parametrin, sen tyypistä riippumatta.
Is this still an open issue? Or was it forgotten?
I think your test should expect the user to press a specific button. One you tell them to in the message.
Updated as below:
1. Changed file name to menuService.js instead of menu.service.js
2. Updated example in comments
There is no moduleTable parameter
`plugins_url` was introduced in WP2.6
Since this plugin requires 2.9, I think this is a better option than reinventing the wheel.