labofsahil/github-event-dataset-2012 huggingface dataset:
Good call. Should l update https://github.com/ozten/browserid/blob/dev/lib/wsapi/cert_key.js#L29 also?
This will return incorrect results.  When using a `LIMIT` to reduce the quantity of data returned, where the total number of rows returned had there not been a `LIMIT` is relevant, use `SQL_CALC_FOUND_ROWS` and `FOUND_ROWS()` like so:

`"get_test_runs":{

    "sql":"SELECT SQL_CALC_FOUND_ROWS tr.id, tr.name, etc... LIMIT 0, 80"

...

Then execute a query right after `get_test_runs` that looks like this:

`SELECT FOUND_ROWS()`

Found rows will return the total number of rows that would have been returned if there was no `LIMIT` on `get_test_runs`.  The count displayed in the json results returned:

`"Mozilla-Aurora": {
    "count": 80,
    "test_runs": [ … ]
},`

Should always be the return value from `FOUND_ROWS()` otherwise it will just max out at 80.  Also, in general, don't use * in `SELECT` statements, there are a whole host of reasons why *'s are bad form, you can read about some of them here http://stackoverflow.com/questions/321299/what-is-the-reason-not-to-use-select.  It's better to list out the columns that you need explicitly.
Should this be changed to <code>def go_to_media_page(self):</code> for better readability?
well, I think refactoring implies API cleaning too...
It looks like there are at least 6-7 different ways to exit this function without freeing this buffer.
both consts are never used.
This import (alias) is not used
Please see how to split the arguments across multiple lines https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md#44-method-arguments
CS, spacing between arguments
Can you change this Exception for a InvalidArgumentException? thx
Same comment as for https://github.com/zendframework/zf2/pull/1792/files#r1133311
I don't like this line as the body of the if() depends on $argNum being set in the first expression, even though the if() statement is being executed because of the second expression. Can't think of a more efficient way to write it though, so it stays unless there is a clearer way to write it that is equally efficient.
I'd probably use attributes[:slug] rather than relying on #method_missing (unless we do define those methods instead). Seems like since this is internal to the class and we know how it works, making that assumption about implementation is fine.
Hmm, didn't realize the $routes adds the base path.
you should probably rename the property (and the accessors) to use a plural. There is many versions
You're not asserting anything in this test. It's just mocking one of the dependent objects. Can you assert what you state in the test description please?
AFAIK this is not required.
@harjis Tähän varmaan kans lasku.myyja
@vesak Pupen-styleguiden mukaan ollaan yleensä kirjoitettu muuttujan stringin sisällä näin: {$asiakastiedot["tunnus"]} niin ei tarvitse ".-escapettaa
should be CUSTOM
I think it is ok to leave this as is.   

If I really need to test js in production mode I will add konacha gem in default section of Gemfile.  

If I follow instructions and add konacha in development and test section then I'm safe.  

I think this is good defaults.  


On Wednesday, 4 April 2012 г. at 17:26, Jo Liss wrote:

> > @@ -1,4 +1,8 @@
> > Konacha::Engine.routes.draw do
> > - match "/" => "konacha/specs#specs"
> > - match "*path" => "konacha/specs#specs"
> > + match "/" => "specs#specs"
> > + match "*path" => "specs#specs"
> > +end
> > +
> > +Rails.application.routes.draw do
> > + mount Konacha::Engine => "/konacha"
> > end
> >  
>  
>  
> This should be protected with `unless Rails.env.production?`, just in case the Konacha gem got loaded in production.
>  
> ---  
> Reply to this email directly or view it on GitHub:
> https://github.com/jfirebaugh/konacha/pull/25/files#r644642
>  
>
You are inside `while (funMore) {` here. continue will actually work because `funMore` is not yet set to true, but might as well just do a `break` here.
Right - working from the point of view of the window-list, I didn't think it was appropriate to have that as a possible action when clicking on a window-list 'alert' item.
Can you add ``public`` in front of the method?
Nice job avoiding `nil`.
Thanks to hoistEither we can write a very lean function, and still use runEitherT to do the conditional evaluation trick.
also, there might be a search string in the first place, so this patch will not take that into account as well
wont this allow someone to pass an arbitrary id and get data?
isnt it 
rails server ? (or rails s?)
check.py doesn't complain for some reason.
Looks good to me, although I guess only doing:

```css
td:first-child {
```

Would also work.
At the very least I would make these tags "automatic" type. Otherwise this will _really_ clutter up the tag selector window.

```item.tags.push({name:bibtex:'+field, type:1);```

See this comment from Simon https://github.com/zotero/translators/pull/307#r686085
Please comment what this block of code does.
well the pull request was saying the source was different now.... since the upstream master had been changed by merging in another of my pull requests, so it suggested this as an alternative method.  it definitely was a pain doing it with the tortoisegit GUI... need to learn some shortcuts, or maybe get handier with sublime text 2's git plugin.
Do we want to keep these in or were they just for debugging.
Please add a limit, to prevent a infinite bucle (100 or 200)
Changed template to not show "Selected Items:" if the grid is not in multi select mode.
с optional пишут просто if (a)
the Node::orderBefore method is part of the API. 
https://github.com/cryptocompress/jackalope/blob/921f5d72ebcf0c750968dfb1a8c8a0334d37b97c/src/Jackalope/Node.php#L419

according to the api spec, an exception must be thrown if either src or dest is not existing (if srcChildRelPath is not existing, we try to move around a node that is not there, if destChildRelPath is not there, we try to move the node to a place that does not exist. both cases make no sense and need an exception) http://phpcr.github.com/doc/html/phpcr/nodeinterface.html#orderBefore%28%29
Hmm, you interpret the ttl as a "block" window after the execution of a job? I.e. with a ttl of 10, no same job can be enqueued until 10 seconds after the previous job was finished? I think that the meaning of ttl was that a job should only be marked as "enqueued already" for a specific time. I.e. mark the job as not queued after 10 seconds, regardless of wether or not it was run already.

Could you make sure we don't change the way resque loner works here, please? :-)

Thanks for sharing your work!
This needs to go last, so that it can manipulate any pages added by proxy, or by the blog page list manipulators I plan to add, etc. Does this do that? Otherwise, it'll directory-index-ify only some of the pages (this is one reason why having rewriting paths be separate from identifying which pages are in the sitemap is kinda nice).
Hi, I have modified my code as you suggest. Should I send another pull request?
We say we support 'popular', which would map to 'viewCount'.
I know there's precedent for not converting units, but I think we should change that rather than perpetuate it.

I propose we convert all units to pixels at DisplayMetrics.DENSITY_DEFAULT (160 pixels per inch) for now, and assume font size is default so sp would work like dp.
It seems like this is a bit opaque; maybe `.check_for_and_log_...` instead?
You're a gem! Thanks for explaining it! :)
I find the file easier to read if the internal function are next to their globally exposed version
Can you also add something to make it flush Redis when the tests have successfully finished?
I've added this.
Needs Validator.
Same answer as above, the reason there is a doSynchronous in this code is because we need to read the files synchronous on server start up. There are too many files in the UI and doing it all async would result in too much open files (at least on OS X where the limit is 256.)

When reading something from disk in a request-cycle it's async.
this should now be "sbt-package-dist" % "1.0.0"
Is tok::eod a tok::identifier? Is the extra check of Tok.isNot(tok::eod) necessary?
Is there any reason for changing this to static?
*FIXED*
Niet in gebruik. Remove?
I've been told myself to not touch the license agreement, even if it is just for white-spaces. If not anything else - it's in virtually every CI file and one such change must be done in all of them, so that it can easily be modified via e.g. regexp replace in the future.
Please revert this one.
этот алгоритм полностью не верный. Мало того, что длина ДНК = 100, а ты делаешь индексный массив всего с числами от 0 до 9 так еще при каждой итерации вероятность выпадения одного и того же числа увеличивается. 

Нужно же сделать алгоритм, который бы сформировал десять случайных цифр в дипапазоне от 0 до 99
как, например?
имхо это лучше, чем делать копию массива self.nucleotides, что я делал в более раннем коде.
We can leave this for now, but we'll want to not limit this to xml in the very near future, I think
In my opinion, this tests for correctness of `c(:, i)` *and* `lam(i)`.
Yes it is dorkster, but there is no actual 'dorkster' commit name in the logs, so github is not using the github account name, but the real name, which you gave to github.
(Here just the mail addresses are mapped to each other. We could leave out the second name, but I want to keep all the lines the same format, so I choose the full version)
Why is this removed? It seems to be used just a few lines before. Did you forget to add something?
Couldn't this be defaulted like
```
if (receiverSignalBlock == nil) receiverSignalBlock = RACSignalTransformationIdentity;
if (otherSignalBlock == nil) otherSignalBlock = RACSignalTransformationIdentity;
```
?
this relies on 2 versions of underscore? is that even possible?
@codyhoag It would be good to add text to transition the reader into the next section.
:static我没记错的话在clojure.core里面早期是有用的，但是后来好像什么实现改进了，这个标示就完全没用了对吧？
Another option could be to dict everything:

```Python

def __init__(self, n_components=None):

        self.epochs_decomposition = {'S': None, 'A': None, 'whitener': None,
                                     'ID': None, 'data': None, 'has_cov': None}
        self.raw_decomposition = {'S': None, 'A': None, 'whitener': None,
                                  'ID': None, 'data': None, 'sorted_by': None}
        self.seed = FastICA(n_components)

```

And then:

```Python

def fit_raw(self, raw, picks, noise_cov=None, start=None, stop=None,
                sort_method='skew'):
        """ Run the ica decomposition for raw data
        Paramerters
        -----------
        sort_method : string
            function used to sort the sources and the mixing matrix.
            If None, the output will be left unsorted

        Returns
        -------
        self : instance of ICA
            returns the instance for chaining
        """
        
        has_cov = True if noise_cov is not None else False
        source_ids = (np.arange(self.n_components) if self.n_components
                      is not None else np.arange(picks.shape[0]))

        if raw._preloaded:
            data = raw._data[picks].copy()
        else:
            start = raw.first_samp if start is None else start
            stop = raw.last_samp if stop is None else stop
            data = copy(raw[picks, start:stop][0])

        if noise_cov is not None:
            assert self.raw_decomp['data'].shape[0] == noise_cov.data.shape[0]
            pre_whitener, _ = compute_whitener(noise_cov, self.raw.info,
                                                    self.picks)
            del _

            data = np.dot(pre_whitener, data)

        elif noise_cov is None:  # use standardization as whitener
            std_chan = np.std(data, axis=1) ** -1
            pre_whitener = np.array([std_chan]).T
            data *= pre_whitener

        else:
            raise ValueError('This is not a valid valur for noise_cov')

       print ('\nComputing signal decomposition on raw data.'
                 '\n    Please be patient. This may take some time')

        S, A = self._fit_data(data, sort_method=sort_method)

        self.raw_decomp['data'] = data
        self.raw_decomp['whitener'] = pre_whitener
        self.raw_decomp['S'] = S
        self.raw_decomp['A'] = A
        self.raw_decomp['ID'] = source_ids
        self.raw_decomp['has_cov'] = has_cov

        return self


```
why are you not using raw.copy() for this?
It would be nice to be able to use environment variable,  e.g., MNE_LOG_LEVEL, to set the default log level, WDYT?
For myself, I'd prefer consistency, both between `values_list` with no args, and `values_dict` with no args, and between Django (though, less important).
Fix'd'd'd
Perhaps this is commented out for debug? line 100 will break if its not defined.
I think this first sentence doesn't quite read smoothly yet
I think this shoud say  default values
Done.

Marc Morata | Sr. System Engineer | Abiquo | +34 626 06 88 74 |
marc.morata@abiquo.com <http://marc%2Emorata@abiquo.com/>



On Tue, Feb 28, 2012 at 12:25 AM, Ignasi Barrera <
reply@reply.github.com
> wrote:

> > @@ -74,6 +75,17 @@ def find_smallest_template(context, vdc):
> >          return None
> >
> >
> > +def find_template_by_name(context, vdc, name):
> > +    """ Finds the template with the given name. """
> > +    template =
> vdc.listAvailableTemplates(VirtualMachineTemplatePredicates.name(name))
>
> Nice! Just a hint: When looking for a single element, you can use the
> **find*** methods. You could better do the following:
>
> ```java
> template =
> vdc.findAvailableTemplate(VirtualMachineTemplatePredicates.name(name))
> if template:
>    log.info("Found compatible template: %s" % template.getName())
> else:
>    log.info("No compatible template found")
> return template
> ```
>
> I'll merge the pull request this afternoon. If you want to commit the
> change it would be perfect! :)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/nacx/kahuna/pull/10/files#r494929
>
>
pep8 here and below in x/(1+x)
Это я у тебя спиздил :-(
Si el último envió es anteayer programa el evento para hoy.
Otro de Trello (o yo tengo terrible dislexia). En lugar de `no y se cancelan los cambios` no debería decir `no se cancelan los cambios, y`.
hi,

To make a perfect pull request please remove mod='blockpermanentlinks' on line 61 because the cms.tpl is not in the module blockpermanentlinks
Good point, I don't know.  For some reason, after the dashboard page comes up, control seems to be handed back from selenium before the page is truly ready.  clicking on the org select to drop it down doesn't work.  Waiting 3 seconds allows it to work.  I hate to add sleeps, but I put it in just to get it working.
Could you put this in the same order as the upstream version and what's indicated in the TOC?
A bit borderline, as the point was to practice recursion. I let it pass this time.
lolxcode.
Perhaps you could change this to True & False (and double check it all still works as expected)?
Thanks. Scrap my suggestion. :-)
The PR is a request to merge this *branch*. So if you add commits and push them to your fork, the PR will automatically be updated appropriately.
On Tue, Nov 13, 2012 at 1:37 AM, Phil Elson <notifications@github.com>wrote:
>
> Cool. Glad it inspired you! [image: :smile:]
>
> I think we can use your new syntax here now. Thoughts?
>
This is going into 1.2.x and the new feature was merged into master, so we
could only change this once it's merge in master.

This is the sort of bifurcation that I was talking about in the recent
thread on mpl-devel - but no solution is perfect...
A future test will need the same setup and will use swipe/flick to kill the app (but for the problems with flick)
Hmm...never really seen use of setting __class__ directly. Why? Is there a cleaner way you could do this?
According to the schema this can also take a literal: http://schemas.opengis.net/filter/1.0.0/filter.xsd so maybe just add:

```
                // handle Literals or Functions for now
                this.writeOgcExpression(filter.value, node);
```
Then I'd suggest to change it to something like "implementors ``MAY`` cast
it to a string, but ``MUST NOT`` fail on non-strings" to resemble what this
is intended to achieve.


On Thu, Nov 29, 2012 at 2:36 PM, Jordi Boggiano <notifications@github.com>wrote:

> In proposed/logger-interface.md:
>
> > +
> > +The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD",
> > +"SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be
> > +interpreted as described in [RFC 2119][].
> > +
> > +[RFC 2119]: http://tools.ietf.org/html/rfc2119
> > +
> > +1. Specification
> > +-----------------
> > +
> > +- The interface exposes methods to write logs to the eight [RFC 5424][] levels
> > +  (debug, info, notice, warning, error, critical, alert, emergency).
> > +  Implementors MAY support custom levels but they are not allowed via this
> > +  interface.
> > +
> > +- Every method accepts a string as the message. Objects are allowed so long as
>
> That is one thing, but the main advantage is extensibility I think. Doing
> it this way kind of allows you to pass an object to an extended interface
> and basic implementations will just cast it instead of choking on it.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/php-fig/fig-standards/pull/60/files#r2264668>.
>
>
Huge HUGE :-1: to processing gem size as part of this method. It should be in `update` instead.

A few reasons for this:

1) We don't need to calculate the size yet until we know the gem has been found and authorized to push.
2) This really ruins the flow of this method...it's not "core" to the processing of a gem.
@dooremont Shouldn't `Asia` go after `Atlantic`?
Should this be an h2 tag like the other widgets?
@arnodeclercq We should be using an i18n string here.
Why would you throw a QuestionSetTitleException in updateQuestion?
Oh that can be a problem. Why don't you use clapack_dgetrf there?
This needs to be reverted before the merge (btw, should we release 1.1 first and bump Assetic to 1.2 with these changes ?)
It might be worth it to interpolate the version of Ruby that you're using to generate the app.
Not with the current implementation of rollout. Can be extended for sure.
Could we call this reportsdownload or something more obvious?
Download helper could be for downloading anything. Especially if you think about the existing upload() helper.. which has to do with all uploads.
just curious, are `data-id` and `data-url` standard element attributes for `button`?
Six is a number I guessed at.
Docblocks missing.
Are you sure the method ``setAdapterPluginManager`` can be called on ``$this->_paginator`` (of type "object<Zend\Paginator\Paginator>|null")?
Hier kanns jetzt eine Nullpointer Exception geben. Wird diese StatusService korrekt behandelt?
Das if Konstrukt müssen später noch ändern. Es kommen ja noch paging attribute hinzu.
Yes, sorry, this is from the unpublished 0.11 (aka M1) spec.
I thought this could contain both private messages and reply notifications, to consolidate UI.
ah sorry, missed it
I didn't make it static in JApplication to facilitate us eventually moving to JApplicationWeb. and removing JApplication. So I'd be fine doing it here, however I think that's potentially confusing. Maybe we should make it static after dropping JApplication?
We must attempt the scala-symbol match before the char-literal since the both begin with a single quote character, but the symbol may contain multiple characters.
Oh and just fyi, this could have worked without worry of IE gc:

``` js
var border = '2px solid #123abc';
expect(new Element('div').setStyle('border', border).getStyle('border').toEqual(border));
```
Can you move this to examples folder?
Perhaps a note that these are here strictly for backwards-compatibility?
Not sure...I interpreted it as not including the line number in the annotation digest.

I'm not really certain which is preferred. I _think_ it is better to ignore the line number, because the case where adding a line to the beginning of the file invalidates all the annotation digests seems bad. But so does missing a potential vulnerability because someone copy-pasted code into a slightly different context.

This is why this is a hard problem!
Sorry, I don't remember what brought this up. But that line would never warn, even before to_sql was whitelisted, right?
Does this really need to be an enum, and if so, does it need to be root class, as opposed to an inner class on `CollectionArgs`?
def strong(name)
    "<strong>#{h(name)}</strong>".html_safe
  end
Если так? Или тупо raw
`panels_forcedby` -> `panels_requiredby`.
Spaces around `=`.
`-1` please, no space. It is an unary operand.
I am not sure, how it does not work? What happens? From what I see it of course should not work. You are doing URL to account page, not to process token page. And you should pass confirmation_token as parameter to `url` tag.
Nop. Don't read from `settings` (that is just default), you have to read from context.
I understood that "map_layers" should be configurable, I fixed this in last commit.
Well, both the official `BrowserIDBackend` and our `MongoEngineBackend` contain `get_user()`, so `super()`, I think, would call only the official implementation because of the Method Resolution Order (MRO) of Python's multiple inheritance.

I've changed the order to be
    class BrowserIDBackend(MongoEngineBackend, browserid_auth.BrowserIDBackend):
since that seems to have no such ambiguities.
tester les intéraction avec le parent model.
I actually checked that there were no implementations of this class and failed to realize that the abstract class itself was used in some tests. Shall I revert those changes and create my own classes?
Ah. Asche über meinen Grind.
Jajajajaja ausser Watashiwapeterdesu macht das keiner :P

...mir sind die Security-Probleme mit Bruteforcezeiten und so schon klar. Ich finds einfach nicht so wichtig in diesem Fall (jaja, ich weiss). Dass das erzwingen von längeren Passwörtern eine Applikation nicht sicherer macht ist ja auch so ein Ding...

Aber wie gesagt, gerne so lassen. War nur ein Input.
Correct indetation
There's a lot of whitespace-only noise in this pull. Can you leave the whitespace alone?

If you really care about it, send a separate pull with the formatting fixups on their own, after all of this is merged or rejected for reals.
why 5 spaces ? :P
good, so that's fine. And thanks for the code review, I really deserved one :)
missed that one :)
Hier mag ook een exceptie
Do you have overlaps or gaps if the division doesn't come out to whole numbers?  Consider `Math.floor()` or `Math.ceil()` here.
I'm not sure what's worse. Having a MapElement[] in C#-Interfaces or having a really odd dummyfield in APIs
Or just `attrs.push("data-spec", "http#" + token[STR].trim());`.
As with `Camera::GetLights` this should return a const reference.
`pos` should be a `vector2f`.
I recommend you pass the entire video settings struct to the renderer constructor instead of an extra bool. You can also do the glew... check inside the constructor.
```
// helper range which filters method names.
/// private
```

`/// private` is a special comment, similar to `/// ditto` that tells the DDOX engine to mark a template as private. This is necessary right now, because DMD does not output the protection class of templates in its JSON output.
would be simpler to just write  if(location_url)
Not correct import. Use full module path when importing.
splitting arguments to different tags is not that easy to just split 'em by space, for example this command: echo "test test"
These event types will go away.
There are conditions for embeddedXMLSize and keyXMLSize in the actual method, but we aren't testing all of those here.

It'd be nice to have a few related test cases that show complete branch coverage.
How back is it to change the names everywhere?
Not actually sure where that came from, but fixing...
Should these be final, or do they need to be non-final for deserializing or something?
there is setBlacklist so caller can do what they need if ever remove is needed (though i think that unlikely), of course they would need to manually follow with a refresh.  have added comment to that effect.
* For iPad optimization. 
* Tu peux meme du coup dire que la librairie est compatible mobile mais que les optimisations sont pas faites et que si des devs sont chauds ils seraient les bienvenus a en faire une vraie librairie mobile non ?
* Petit lien vers BA ? :)
Why is this removed, duplicated code?
`alias` instead of `super`.
Isnt better to place all defs in helpers?
`sendStartMessage` and `sendFinishMessage` are already defined like this in the parent, these can be removed for simplicity
Am I reading this right.. if I connect to replicaset and we discover the name as 'foobar' but I pass in array("replicaSet" => "hobo") .. we ignore the name we discovered and use what was passed.. shouldn't we atleast throw some notices at this point?
We should rename this to <code>_browserid_login_locator</code> or something similar for better code readability.
message.py was wrong, see above comment.
Wrote a better comment. What I was trying to say was that parse doesn't currently return anything but the XML from Splunk, and it's going to get a better interface.
Can't these lines that are now commented (SCREEN_WIDTH, SCREEN_HEIGHT) be removed or do they need to be kept in case of a reverse (please keep in mind, historical information is never lost with Git!)
Can you please update the year number?
Instead of Exporting each command, add [InheritedExport] to ICommand.
Just thinking about updates not builds...



On Mar 8, 2012, at 7:05 AM, Andrew Mount<reply@reply.github.com> wrote:

>> @@ -38,3 +38,6 @@
>>    path = lib/amplify
>>    url = git@github.com:armount/amplify
>>    ignore = dirty
>> +[submodule "lib/jasmine-jquery"]
> 
> It wouldn't hurt.  I omitted since we don't build it but I guess better safe than sorry.  Will fix.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/sym3tri/hubalog/pull/43/files#r534087
I believe this is what @glennpratt is working on atm... this probably needs to be updated to `$client->getClient()->getConfig()->add('curl.PEER...', false);` at the setup of the client... pulling conf from config.php
Agreed. 

It was a question intended to satisfy my curiosity about how I should be making libs in the future.
Created issue https://github.com/aeolus-incubator/thor-cli/issues/3
I did the same as it was in the source code previously. Could you tell me how exactly should I update the "mailtemplates" extension? There will be several cases for that, right?
Looks like @keithtom created that using  ActiveResource::HttpMock.  Seems to do a fake http action and compare the URL with what is expected.  Something like an active resource version of should_receive
I wonder if it's possible to write the association helpers to use ```define_method``` instead of ```eval```  I'm guessing you are storing this stuff so that it will be available in the generated method?  If it were ```define_method``` you could just access opts directly instead of storing it elsewhere for later use.  the name ```default_params``` is confusing, it sounds like it's default params sent to the server during find requests or something, if it needs to survive I'd call it something else, maybe something like ```has_many_options_for(association_name)``` and I would store it in an instance variable on the class instead of a class variable to avoid potential collisions (like two classes both having ```has_many :users``` but with different options.)
never use this method before, do we really need it?
Если в конструкторе BufferedReader возникнет исключение - файл останется открытым.
Видимо, после + '\n' ты не проверял работоспособность. Сортировка сейчас не работает (вывод неправильный).
I'm just going to change this to a bullet list for legibility purposes.
now that is an interesting thought. I will have another look at those methods and try and adjust the code. Thanks for the pointer. :) 

I believe the idea of checking the assets hash directly was that in our original usecase the precompilation is handled by deployment so we didn't worry about the case where the asset might be compiled during runtime. You have made a brilliant point and it would definitely improve the code!

I'll try and get an update to this in the next day or so.
But we just want to log in, isn't it up to the test to know if we're logging back in or logging in as a new user? Even if it's omitted in the test, there should be a sensible default and it should apply to both string users or MockUsers, no?
Why, that seems pointless? It'd be painful to have to re-add this code everytime I need to use it.
We do not need this here, I think.
Isn't this line the implementation of ``assert_all_finite`` ?
Any use of random number generator should be controlable. See sklearn.utils.check_random_state and how it is used in the scikit.
Capitalization, full stop. ![grammar nazi cat](http://static2.fjcdn.com/thumbnails/comments/you+will+play+with+mein+furrer+_de84ccb291ce74229056fd3102df1438.jpg)
@GaelVaroquaux See 40745ce. More like it?
We still need ``tree.terminal_region`` for the line searches (= ``_update_terminal_region``). It actually puzzles me that ``tree.predict`` is faster than ``take``. The reason might be the additional memory copy due to fancy indexing. 

Looking at the code - I notice that there might be a bug due to the fact that tree.terminal_region might be -1 for two reason: a) they are out of the sample mask or b) they have not be assigned to a leaf due to ``min_samples_leaf``.

I'll keep you posted. 

@glouppe Thanks for the review and feedback - I really appreciate that!
ця версія підходить під шаблон 2.1.*
I would prefer to avoid setting the variable in view and just use ```app.flavor.name```...
It will work for this specific case, but if in future another layer needs to know about scrolling as well as the planning layer, it will not receive any notification. This is an unlikely scenario, so I will implement the suggestion.
Also, things other than DotVarExps should work with getProtection.  VarExp, SymbolExp, etc.
Yes, there are many equality tests already.
You need to conform to the existing style.
want me to reformat!? :-)
That's a better name, and a better logic. I got carried away with semantics... (and haven't finished my tests, yet)
This shouldn't be a member of the interface - a global function is a better solution.  

My argument is that this function only needs to access public members of the class, so adding this function to the interface makes the interface harder to understand, and harder to implement.

If this was a class rather than an interface I *might* be tempted to add it as an (inline) non-virtual method, but even then the argument above still applies.  You would essentially be swapping a member function for a global function.  You could argue the global function was better because it demonstrated the function only worked on public members.

The reason I'm not so against things like isNumeric() is that the public member they are dependent on are a type field which could be frowned upon in OO designs.
Please do not reformat sources without making a semantic change.
This is the first Category/Arrow code i've written :D
during tests, env['omniauth.strategy'] is nil in 2 cases. is this expected behaviour, or a kink of some of the tests?
While you're refactoring... please remove the underscores from all non-public members. :)
Change `post` to `post.el`.
you should not assume that there is a service with the id ``buzz`` IMO.

either you declare a dependency to SensioBuzzBundle which uses this id, or you use an alias to a service id configured by the user (and they would be able to configure it to ``buzz`` if they use SensioBuzzBundle)
le lorem ipsum est pas editable?
parameterization can not be done for registration because  a new user can select only one value at a time from drop down list on the page then that user will be registered with those values which has been selected at registration time. In short, we can verify only one set of  value at time per new user. To verify another set of values we need another new user. 

 but yes new user can login the new generated username ,password and change time, timezone etc from the business portal not at registration time.
Done in 2cf55de.
datastore options should be filled by the USER, doesn't seem a good idea to fill here this datasotre option.
Sorry, I didn't mean that the actual code is incorrect---just that it can be confusing to someone reading through the code.
I'll add both mean and median.
Makes no difference but I changed it for you.
I'll look into refactoring the test, thanks.
hmmm. this could probably be "instance update" instead of "update instance" to follow along with the new convention. So update can be a function in the InstanceCommands
Why not just `64 * 1024` instead of `(64 * 1024)`?
The faster way only applies if you are using string literals, for example `/^(\d{4})$/`, if you are building the regex at runtime from variables, than you need to use `RegExp`.
ah... now that I'm looking at the code, the dynamicobjectcollection could have just been passed into the updater's constructor. This would also simplify the CzmlProcessors logic as well. I can update this if you're not looking at it anymore.
Rather than log it, why wouldn't we just call `doneCallback` with the exception?  This way calling code can handle it.
Does this mean that this setting overrides `pagingControlOnTop`? Can the overlay be modified beyond just displaying the paging control?
Тут все норм. Просксто скажу, что есть такой сайт http://www.140byt.es/ на котором собираются всякие красивые и короткие реализации популярных функций - UUID https://gist.github.com/982883 ;-)
docstring for module.
Hmm, I suppose. I can see why it was put here though.
I think it would be better to pullt he currently running template.  Check https://github.com/live-community/simple_deploy/blob/master/lib/simple_deploy/cli/template.rb for an example.
Oops, accidentally committed a wrong code. Will made another pull request shortly.
s/optimized/an optimized/
Comment is GC-specific I bet. What will hapen if sometime later we get other allocation strategies?

Wouldn't it be better to say that ranges that share elements with the remove region are invalidated?
Just staying on the safe side and keeping our hands untied for future improvements/changes.
shall we return `DollarToken.init` here lest we get into more debates :)
No, `== Object` and `== class` are obviously different.
The former returns true only if S equals to `Object`, and the latter can tests whether S is a kind of class type (not only Object, and user-defined class types).
From the viewpoint of dimensionality of static arrays, any type that's not a static array is a scalar with dimension zero.
this is quite a good example how you can work around the "great" static util methods; you can use the simplemodel like new SimpleModel(xxx); simpleModel.isEO(); simpleModel.toEO();... objects are your friends, util classes your enemies ;-)
why not defining this as a constant?
depends on what meaning you give to thresholds, but probably >= makes more sense since if for example you define a threshold to alert only on cpu being 100% busy , it will never alert as there won't be 101% cpu :)
This is creating a sandbox domain. I was having an issue in .NET 3.5 where it could not load any assemblies as it couldn't get the `FileIOPermission`. This fixed it.
missing spaces in format
This is a mistake when rebasing the branch. Fixed now
this is wrong. Install will not install your new dependency. It will install the locked dependencies and warn you that your lock file is outdated
Please format code and whitespaces consistently with the other code. (In this case, just DAPSONE = "74250AA...";
All the more worrisome - I've entrusted you with an xbox controller that you have no need for?!
Yes, it will. We took a shortcut last week.

I'll create a story to fix this.
Indeed.
Thanks Thomas, I'm fixing it.


On Thu, Dec 6, 2012 at 4:03 PM, Thomas Jost <notifications@github.com>wrote:

> In src/util/recent.js:
>
> > \ No newline at end of file
> > +};
> > +
> > +exports.rsmToJSON = function(reply) {
> > +  var rsmSet = xml.parseXmlString(reply.toString()).get('//set:set', {set: rsmNs});
> > +  var rsm = {};
> > +
> > +  var firstNode = rsmSet.get('set:first', {set: rsmNs});
> > +  var first = '';
> > +  if (firstNode) {
> > +    rsm['first'] = firstNode.text();
> > +  }
> > +  var lastNode = rsmSet.get('set:last', {set: rsmNs});
> > +  var last = '';
>
> Looks like first and last are never used.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/buddycloud/buddycloud-http-api/pull/42/files#r2339504>.
>
>



-- 
Abmar Barros
MSc in Computer Science from the Federal University of Campina Grande -
www.ufcg.edu.br
OurGrid Team Leader - www.ourgrid.org
Buddycloud Dev - www.buddycloud.org
Paraíba - Brazil
A dictionary is a mutable type, every call of getWizard will use the _same_ dictionary!
for example if you call the function and initial_data acquires some keys the next time you'll call that function initial_data will have the old values! That's probably not what you're trying to do

You should change that in
```
def getWizard(self, initial_data=None):
    if initial_data is None:
        initial_data = {}
```
Lol. Because it doesn't equal true, that expression becomes equal to the first value. Its an oddity - if you want true true, you should use the ternary operator.
I'm not sure whether that's a great idea, Paul. I've done this in the past, too, and I liked it a lot, but when you start refactoring code it requires you to shift around a lot of lines, and if in bad luck, it's not done with a few `tab`s (of course, interpreted as 4 `space`s). What do you think about indenting concatenation with 4 `space`s?

```
$foo = 'prefix_string '
    . $object->getSomeStringResult()
    . ' suffix string'
;
```
Moved. Let me know if everything is all right now.
Can you refactor this so that it only has ONE place in the code where that Message is sent to the channel? Currently there is an inconsistency where one send uses a 0 timeout and the other calls the potentially-blocking send method, and also there is a lot of nesting for conditionals making it difficult to read. It could delegate to a method that evaluates the expression if that's not null OR it could delegate to a method that returns the Message to be sent (and in that method either evaluates an expression or returns the Message as-is).
Suggest we add a comment about how to get these tests to run in STS

    -javaagent:/home/<user>/Downloads/openjpa-2.1.1.jar
do you want me to just remove them?
Hi Artem, I am curious as to why you added this restriction; what if the last component in a chain is non-reply-producing, e.g. 

    <int-jdbc:outbound-channel-adapter/>

Why do we not want to allow, say, a retry advice?
Wil change
Just wanted to comment that this is really cool, since now you can wire disposition-result-channel to let's say JMX notification mechanism etc. . . don't you wish you had this two weeks ago  so you could demo it in the webinar ;)
STS does this automatically with Organize Imports, but why is this a concern? Especially when the class is in the same jar.

Without the import, you'd have to fully qualify the  @ link to avoid javadoc warnings

````
/home/gpr/Documents/workspace-si-github/spring-integration/spring-integration-core/src/main/java/org/springframework/integration/handler/advice/AbstractRequestHandlerAdvice.java:37: warning - Tag @link: reference not found: AbstractReplyProducingMessageHandler
````
Using the same syntax as in `activate` view should result in more consistent and resilient code.
Anyway I integrated your patch in our branch, so we're going to test this a bit more.
Thanks for sharing
Er. Yes. Apologies! I'll fix up and re-PR.

Thanks!
You know, you're right. We don't need to include the class. It's only 
the parser library additions (uriescape specifically) that we're 
interested in. Updated.

On 11/07/2012 12:04 PM, Dan Bode wrote:
>
> In manifests/all.pp:
>
> > @@ -83,7 +83,9 @@
> >    $libvirt_type            = 'kvm',
> >    $nova_volume             = 'nova-volumes'
> >  ) {
> > -
> > +  include stdlib
>
> what is this stdlib class? what is it for?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/puppetlabs/puppetlabs-openstack/pull/132/files#r2060332>. 
>
>
Most lines are not wrapped. Should this be on one line (or alternatively should the others be wrapped?)
This should be ``Zend\Form\View\Helper\FormButton``.
Fixed in a0cf26231a085b99eb120476e7175f8ba0204f73
名前がいまいちです。
Since the subject of both contexts is `UserMfaSession.find`, you should have it be set directly under `describe '#find'` and use `it` in the `context 'no session'` block.
the code isnt aligned
if ('x-powered-by' in response.headers) {}
If you use RegexOptions.IgnorePatternWhitespace, you can split the parts of the regex up across multiple lines, and use # for comments to explain what each part matches.

For example
```csharp
@"
<\s*filter                              #open filter tag
(?<PreAttrs>\s+[^>]*)                   #capture any attributes before 'name' in PreAttrs
name\s*=\s*""(?<Filter>[^""]+?)""       #capture the value of 'name' in Filter
(?<PostAttrs>.*?)                       #capture any attributes after 'name' in PostAttrs
(?:
/>|>                                    #either tag self-close, or end of open tag
(?<Content>.*?)                         #capture the content of the tag in Content
<\s*/filter\s*>                         #close tag
)",
```
on any page other than the first, the top link is wrong...  we should meet and talk about possible solutions to this.
doesnt bother me either way :)
________________________________________
From: Mike Asthalter
Sent: Thursday, July 05, 2012 11:30 AM
To: Nirmal Ranganathan
Cc: Cloud DB
Subject: Re: [reddwarf_lite-integration] final doc updates for 7/2/12 EAP release (#103)

Hi all,

Here is what is used in the Beta version of the Cloud Identity Client
Developer Guide:

<?xml version="1.0" encoding="UTF-8"?>
<auth>
  <apiKeyCredentials
    xmlns="http://docs.rackspace.com/identity/api/ext/RAX-KSKEY/v1.0"
    username="jsmith"
    apiKey="aaaaa-bbbbb-ccccc-12345678"/>
  </auth>

I would be happy to change to this for the next version of the doc if you
all prefer.

Please advise,

Mike




On 7/5/12 11:23 AM, "Nirmal Ranganathan"
<reply+p-1106263-90f89f6d31b89094c3c0826baeae7fbf1114bcc6-1015169@reply.git
hub.com> wrote:

>> @@ -0,0 +1,14 @@
>> +POST /v2.0/tokens HTTP/1.1
>> +User-Agent: curl/7.21.0 (x86_64-pc-linux-gnu) libcurl/7.21.0
>>OpenSSL/0.9.8o zlib/1.2.3.4 libidn/1.15 libssh2/1.2.6
>> +Host: identity.api.rackspacecloud.com
>> +Accept: application/xml
>> +Content-Type: application/xml
>> +Content-Length: 88
>> +
>> +<?xml version="1.0" encoding="UTF-8"?>
>> +<auth>
>> +   <apiKeyCredentials
>> +
>>xmlns="http://docs.rackspace.com/identity/api/ext/RAX-KSKEY/v1.0"
>> +       username="hub_cap"
>
>yeah that's just a dummy api key. But you are right we should probably
>change that .
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/hub-cap/reddwarf_lite-integration/pull/103/files#r11062
>63
yeah that's just a dummy api key. But you are right we should probably change that .
<pre><code>:   (</code></pre>
i think the sort order must only change for the node inserted at dstAbsPath, not for its children. the children are moved along with the parent but i don't see why they need to update the sort_order. maybe i am overlooking something, but i fear this creates funny values in the sort order of the child nodes.
Don't need this if we're not going to use the serializer for the response
Please remove line 109 and 110
We should add some tests cases when actaul is not a subset of given value, at least 
should_fail_if_actual_is_not_subset_of_values
You can refactor this to something like:

```ruby
hint_content  = hint.is_a?(String) ? hint : translate(:hints)
hint_content.html_safe
```
Ok, +1 for text analysis.
chera kar mikone !
commit kon bebinim moshkel chiye
lets bin these debug lines too
I wonder if we should think about using something like https://github.com/carhartl/jquery-cookie rather than parsing the cookies ourselves, to make this easier?
Isn't this the same as an allback? Or am I misunderstanding something?
I had worked on allowing multiple contexts to be logged - and this would have been in an Array.  Since I backed out from doing that, this check isn't necessary.
I would probably say something more like "The format of the response conforms to <a ref...."
Not available on IOS for streamed content
neither; the EKB will do the transformations; but yes we can talk
about it tomorrow

On Tue, Jul 24, 2012 at 5:53 PM, Peter Grman
<reply@reply.github.com>
wrote:
>> + *     http://www.apache.org/licenses/LICENSE-2.0
>> + *
>> + * Unless required by applicable law or agreed to in writing, software
>> + * distributed under the License is distributed on an "AS IS" BASIS,
>> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>> + * See the License for the specific language governing permissions and
>> + * limitations under the License.
>> + */
>> +
>> +package org.openengsb.domain.requirement.events;
>> +
>> +import org.openengsb.core.api.Event;
>> +import org.openengsb.domain.requirement.Person;
>> +import org.openengsb.domain.requirement.Requirement;
>> +
>> +public class PersonCreatedEvent extends Event{
>
> OK I think I didn't get it - we should talk about it tomorrow, but should I reference the Person object itself in the Requirements model or just the ID of the person?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openengsb/openengsb-domain-requirement/pull/1/files#r1226327
Calculation for block size for layout in Firefox 12 doesn't reduce size based on margin-right value.
I've first tried this on our main Jenkins installation, which has a URL like http://servername:8080/jenkins/. The method getDefaultIcon() is called to get the icon for the entry in the left menu which is shown on all pages, while the other two methods getImageUrl(String size, String name) and getImageUrl(String name) are internally used by the plugin. The result of getDefaultIcon() is added to the relative static icon URL which was correctly added behind '/jenkins/' before I have changed this class. But as getImageUrl(DEFAULT_ICON_NAME) is forwarding to getImageUrl(String size, String name), the root URL was added and the link was broken.

With the proposed change the two methods getImageUrl(String size, String name) and getImageUrl(String name) are using the full URL and the method getDefaultIcon() is using the relative static URL. I have tested the change on this Jenkins instance and all images were shown correctly.
Test that $repository is an object before use.
Renamed into HttpQueryStringParser.
Ah yep, sorry, forgot it was jinja templates...
上文出现的URL的参数解释，使用的tab，这里保持一直。
is logging needed here? this looks like left in debugging statements
{ needs to go on new line
There shouldn't be any hard references to the web context, "kr-rad", that's stored in the config object so you should retrieve it from there. Also if the request begins with the web context then you can ignore it all together, the core API will insert it.
Why remove this? I think it's an incredibly important rule. Random piece of C code from Libav:

    av_malloc(sizeof(AVFilterFormats**)*(a->refcount+b->refcount));

This kind of stuff is completely unreadable.