labofsahil/github-event-dataset-2012 huggingface dataset:
Hi,

1. For consistency I would only use one tab this time. Consistency makes the source easier to edit by other people as well.
2. I like it, but the availability of the function may be an issue since the renderers only share the global context. We may have to create api.preprocessText within the Cufon core if we want to avoid further refactoring. One solution would be to simply wrap everything inside an anonymous function and place the function there, however I would not accept it because I don't want to anything to be out of place.

    Haven't really thought about the split vs charAt issue. I suppose the original reason was that it was easier to work with. I would imagine that it's slower because of the additional function calls, though. [Is that what you had in mind](http://jsperf.com/string-split-vs-charat)? Seems to be about 17% slower in my Chrome.
3. Good, but I may just have had a slightly better idea. First of all, let's rename the option to "ligatures". Then, let's make the default value of that option the object which latinLigatures currently holds, and get rid of latinLigatures altogether. This will allow people to add their own ligatures should the default ligature list prove insufficient. To disable ligatures, one would set the ligatures option to null. This does mean that the ligature regexp would have to be recreated each time a new Cufon.replace call is made, but it may be cacheable the same way for example textShadow and other options are (in Cufon.replace, although the caching is starting to take up quite a bit of space there...). So yeah, it's slower but I much prefer the idea of flexibility.

Thoughts?
btw im Electronic Engineer with mention on Control Automatization and Robotics xD
I can't seem to reproduce this - at @jaredbeck said the only way I can get this error is by passing nil to `sighting_response_path`, e.g:

``` erb
<%= link_to 'Response', sighting_response_path(sighting, nil) %>
```
@artellectual are you sure you're not mistakenly passing `nil` or something that evaluates to `nil` to a URL helper somewhere?

Watch out for passing unsaved model objects to URL helpers, even though they are not `nil` themselves, calling `#to_param` on them returns `nil` which was the cause of my problems.
Test added as 5808 was written 588, that became 5.88 or 6.28 degrees.
item about inplace
rtmpdump built with llvm 2336 still segfaults on streams from at least one well-known site (BBC).  Obviously, this will vary from site to site, but it would be better to leave the fails_with_llvm warning in place so users will know what to do when rtmpdump doesn't work.
Please review: 14d7d03425a80fd226cb7e7584e840fbf18bd499

Tests pass.
Variante 2 ist genau die Schwierigkeit, "erlaubt" und "verboten" vertauscht hingegen dürfte keine Probleme machen, also so:
--> verboten: REX_VALUE[ifempty="REX_ARTICLE[id=1]"...]
--> erlaubt: REX_ARTICLE[ifempty="REX_VALUE[id=1]"])

Aber ich denke, ich werde erst mal Variante 1 umsetzen und dann mal weiter sehen.
colvols makes sense, I'm less sure about grouping the rest. What's the view on backwards compatibility? Through engine or through unitdefs_post? (The latter is useless for basically all but new projects... and is useless then because they will just write them the new way anyway)
`self.class.abilities.keys.include?(command)` is another good candidate for extraction into a private method.
This is good because, in case another function has been generated in the if block, the builder will be set to insert into one of the function's block. So you want to tell it to insert back again in the current function
simple fix for #1464
Missing lock? http://pastebin.com/ALHWndJs
strange way for use this bonus :) more simple add usage this DBC field directly in bonus calculation method...
我的那个项目已经移交到 github.com/xdlinux  欢迎加入这个组织。
hi anyone can look at this, would be really nice to have it crash fre, GJ so far
Updated in bnoordhuis/node@f54cfdf.
Wobei es vllt besser wäre ob es das pdflatex einfach im PATH gibt und nicht explizit in `/usr/bin/pdflatex` schauen?
Disables buffering of file to determine content-length. Instead you can specify it up front.
np - just a suggestion. having that pattern as a file/folder name in the css would be twisted, but possible. feel free to modify, or discard.

cheers
да емае... я же эту фигню с драконами фиксил ХЗ помнит когда. видно уже отмержилось где-то...
hmm... very strange, XYZ coordinats in Cell::VisitCircle - from freeze (broken XY). but no freeze?
typo: should be "site-header"
Hah no worries! Thanks for helping!
You tell as close as possible. There is a typo in possible. Also, I suppose from the name pseudo-inverse that it is an approximation. So can you tell that if we need a more precisse result you can use the inverse that is slower? Or I mis understood something?
Justification.
Could we set them for removal in 2.2 instead?
well the convention would be that whatever you pass .. you end up with the equivalent of what http_build_query would do.
if it wouldn't be such a big overhead i would propose to always send everything through ``parse_str(http_build_query($params))`` .. well actually we need to check if we can make a user land implementation that does the same but faster. maybe 2 C pace functions are faster than what we can do anyway, it would certainly be easier to ensure reliable behavior.
@canni in case of `array()` also
Yoi pake bootstrap dongs :D, sam ini juga blom aku push... masih natain HTML nya
meow :D
Won't accept these into the master branch.
This wildcard import was removed a few commits ago.
Yes, of course. I had looked only at your change and neglected the context.
Kill this MODELING_SCHEMA nonsense
Надо завести свой тип .экспешинов. В зависимости от типа будем решать что делать. Если эксепшен при логировании, то просто в консоли отображаем. Если криическая ошибка, то закрываем принудительно все стримы.
Если я правильно понял, то класс Shell должен просто поддерживать общение с клиентом.
\o/ Good job. Page load performance with persistent QR has improved immensely in 2.28.1.
or perhaps if db == DEFAULT_DB_ALIAS and os.path.exists is false for join(path, db, migration) then use join(path, migration)
character encodings screwed up...
Shouldn't this be:
>this.value.lazySet(...)
Actually, the crmservice already has been changed in this osgi way some days ago by Alexey,just apply it to reservationservice because with cellar cluster env, the <bean> injection for locator will not take effect anymore from my testing. now it's the right way for locator working in osgi (especially in cluster env).
I found this bug: http://code.google.com/p/hamcrest/issues/detail?id=145. Does this code rely on that jar?
Interesting...

Yes, I suppose we could do that - good idea!

I was using the $data property as follows:

$app->get("/users/get", "myCallable");

$app->hook('slim.after.router', function($body)
{
    $app = Slim::getInstance();

    $app->contentType("application/json");
    $app->response()->header("Access-Control-Allow-Origin", "*");

    echo json_encode($app->response()->data());
});

function myCallable()
{
    return array("name" => "danny");
}

Does that make sense? I can give you access to my bigger working example
and you can see it all in action there...




*Danny Kopping* *Flash Platform Consultant*
Adobe Certified Expert (Flash, Flex, AIR)

<http://dannykopping.com/>http://dannykopping.com | (+27) 84 941 4422




On Thu, Jan 5, 2012 at 3:43 AM, Josh Lockhart <
reply@reply.github.com
> wrote:

> What if we assigned the callable's return value to the Response body? This
> avoids the long-term need for output buffering (not that ob is a problem),
> and may also solve what you are trying to do. Just tossing around some
> ideas to hash this out.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/dannykopping/Slim/commit/3fdc30d98d5038ec9520420fa6d81ef9de24b8a7#commitcomment-838954
>
Shouldn't that be placeholder too? Also the value in the locale is missing ;)
https://github.com/diaspora/diaspora/commit/226554becf73ae84c33058f4993ea63d918b370a#commitcomment-720582
> Actually, nahi and I were both developing on 64 bit, so we never encountered these ;)

Ah, good to know that I'm not crazy. Soon there will be a 64bits Ruby for Windows too, still need to workout how to make that functional from rake-compiler too (at least will be able to do native compiling until then)
Might break compatibility but its another function call shaved off
I didn't look at MacPorts, just built the binary and ran otool -L for the libraries. The patch was straightforward.
@jacknagel Thanks, fixed and updated the pull request: 0021279059cc0414efc85fda7d2a0f6700410d5a
k, I'll push asap.
why Dreadii has deleted his account?
You forgot [Xv](http://dev.opera.com/articles/view/xhtml-voice-in-style/).
Kan man inte köra `amount.nonzero? || amount.abs`. Det tycker i alla fall jag gör att det ser lite klarare ut vad målet faktiskt är.
Seems good. Just remember to add an upgrade notice for linux people since their configuration path will change and they won't have their settings any more.

In the past I've added a temporary function to check presence of the old config location, and if so, warn the user that they should move it.
Cant compile this crap.
kaelima is a keyword and can only be used for methods declared with the identifier "awesome". I would suggest you renamed it to warpten.

also; I werent online when you commited this, so warpten (or kaelima in this case) would return NULL.
Looks good. Added it to the following branch, which plan to commit to 
sourceforge:
https://github.com/bradymiller/openemr/commits/security-exploit-fix_3

On 1/28/2012 5:20 AM, Kevin Yeh wrote:
> There is at least one other file vulnerable to this exploit.  I've made a branch to address it here, and have tested it
>
> https://github.com/yehster/openemr/commit/bc0f07c64bfda43cb0f1cef977a4e322fd7ce047
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/bradymiller/openemr/commit/527799177c3916d3c65199448a27dc2584835159#commitcomment-910802
Good, catch! +1
So, to understand how we convert the module_name around, look at:

https://github.com/chicks/sugarcrm/blob/master/lib/sugarcrm/module.rb

For associations (such as SugarCRM::Account.first.contacts), look at:

https://github.com/chicks/sugarcrm/blob/master/lib/sugarcrm/associations/association.rb

I tried to document both of those areas as much as possible, but there are always interesting problems that crop up when we start converting names of modules.  

Can you send me the output of: 

    require 'pp'
    pp SugarCRM.modules
    pp SugarCRM::AbcBuilders.new.associations
should have some doc comments...
This was a smart commit/revert that was planned — it solved the likely issue that people were going to have with dependencies, and now that we're moving onward with 2.1, it should be removed.
Oops.  Didn't notice I removed this blank line.
This is incorrect when options[:swallow_stderr] is true and local_options[:swallow_stderr] is false: in this case, swallow_stderr is forced to be true when we would expect local_options[:swall_stderr] to take precedence.

I guess that you should fix it as follows:

-      local_options = local_options.merge(:swallow_stderr => options[:swallow_stderr]) if !local_options[:swallow_stderr] && !options[:swallow_stderr].nil?
+      local_options = local_options.merge(:swallow_stderr => options[:swallow_stderr]) if local_options[:swallow_stderr].nil? && !options[:swallow_stderr].nil?
You are right – uploading new patch right now
身份判断部分还是要靠你啊，再看看objectiveLevel和getGameProcessValues怎么改吧。目前的身份判断很好哦。
transform is inconsistent.
## Testing Github Flavored Markdown parser!

```javascript
function hello(bool) {
  if(bool) {
    alert("yes");
  }
}
```
danke, das wollte ich auch gerade machen
Good for a temporary fix. Eventually it would be good to have a little expand/collapse thing; the full topic should be viewable somehow.
We could also bump down the font size -- it's a little big.
Может стоит попробовать не блокировать скрипты с неизвестного домена, если таких скриптов более одного.
@will-moore: Any problems with the `copy` to `get` method naming change?
-_- This results in a NPE.
Add this code before you putAll:
        if (this.varMap == null){
        	varMap = new TreeMap<String, String>();
        }
It is a matter of taste (I did all the refactorings live while reading the code). I like have the constructors next to the definitions, it is less error prone.
Bitte mit Zeilenumbruch und Konsistenten Quotes:
...text.html", function() {
  $("#kochmarkus-screenshots-content a").lightbox();
});
Esto hace magia.
This was a great idea.
Looks like it, yeah. Either a `GROUP BY` or `DISTINCT`. And the `General::array_remove_duplicates()` can be removed from `fetchAvailablePageTypes()`. Good spot.
Ok good. 

And ya, and I think over about branching again, I think it's not quite necessary for a 2-man team. You can freely push codes to the master branch
![](http://g.static.memegenerator.net/cache/instances/400x/12/13259/13577396.jpg)
The `locale` field can be removed since only `loadLanguage()` method uses it, am I right?  It can be passed as parameter to this method.
擦= =你怎么用这个来同步我的hosts了……
正考虑要不要把hosts从这个repo里面去掉
Conditionals are a code smell, in this case it is somewhat of a wash between complexities but because of the branching nature of conditionals they quickly lead to much higher complexity so it's best to avoid them when you can. On the other hand, method chaining complexity is linear. Once you begin you learn more about the standard library and how to compose methods you will find that you can do pretty much anything you want to a collection just via methods.
Nice comprehensive set of tests I see...
Level Editor discussion. Work on the engine cholo
shouldn't spell 34400 be used here?
You are right. This problem should be fixed in the latest commit.
Could we just replace these three lines with

    NSMutableArray *fileObjects = [[[QSLibrarian sharedInstance] arrayForType:QSFilePathType] mutableCopy];

and then use that for the rest of the method?
Как я понимаю, для скробблера все есть.
Nice.

But im wondering which might be the base db of this? do you continue developement where ccdb stopped? or is this even based on old skyfiredb? please tell us
Got this from the new Android Developers Google+ page.
Not sure that MSBuildBasedProject should have a dependency on ProjectBrowserPad. 

Should the ProjectBrowserPad instead listen to events fired from the active project?
After this commit, I no longer have recovery either through flashing the full ROM or the boot.img separately. Before this it worked just fine.
what


On Wed, Mar 7, 2012 at 2:03 PM, Oscuro1987 <
reply@reply.github.com
> wrote:

> Removed from collabs, you're no longer wanted here rcp.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/Oscuro1987/Severe-Uranium/commit/5fdd37285bd0c4aa2f5fca1b2892c57214f92147#commitcomment-1053563
>



-- 
this email will self destruct in 10 seconds,
have a nice day ;-)
my server shuted down after learning/using aura for cast while walking, maybe here's some mistake, i'm running latest DB updates + latest DB & core and i set disabled for these spells, because they are unstable

i think that the reason, why my server is shutting is is maybe here, please look at it, TY
Geodar
Thanks. I didn't test it yet as I'm on cLK. Maybe you can get somebody to test if it's actually working.
ship-it
Ari: no^^
If you get SLQB going and avoid the magic bootloop maker that it's been for me, do let me know how. FYI, though - morfic informed me that it shows no benefit over SLUB. I'm going to toss it and try out SLAB at his recommendation. See my Kocaine_kernel test branch.
Semantically, it doesn't make too much sense to use `POPULARITY_CACHE_VIEW_TIMEOUT` as a toggle for using caching. It might be better to add a separate `POPULARITY_CACHE_VIEW` setting and make `POPULARITY_CACHE_VIEW_TIMEOUT` optional. This seems to be more in line with Django's own cache settings.
You have added base_description above but are not using it anywhere. Maybe you should assign it to self.description here?
@richardmiller why doing this ? The reasoning to catch exception was that it does not make sense to rollback the Doctrine transaction (and make the whole stuff fail) just because you ES server had an issue. In such case, the ES index would of course be outdated but the main feature of your site will still work.
อาจารย์ค้าาา Fork แล้วไงต่อคะ
I had to remember that I can't write 

```shell
set gcccompiler = which gcc
```

Because ultimately we're going to alias `gcc` to our research compiler.
Incorrect date format
Nope, its actually because you can have a JComboBox store associated objects then the strings internally correlate to the objects. Basically, it behaves like a dictionary. Not exactly sure how it works, but kinda cool.
merged - can be deleted
Sorry, I'm not trying to be rude, I'm just a little curious why you emailed
me about this, unless I was supposed to help you and have had a sudden bout
of amnesia :)

On Fri, Feb 10, 2012 at 7:27 PM, Dustin Fennell <
reply@reply.github.com
> wrote:

> An attempt a user rights management stuff... this whole class, and
> IterationResource.java, are likely going to get scrapped at some point.
> Unless we can actually make them run somehow, in which case, well, then who
> knows :P.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/Agilefant-Finnucks/agilefant/commit/197a024e4a883429d25ff32dd0a5c3aead27352b#commitcomment-956096
>
this is awesome....i'm gonna push it now!
Good.  Some very very minor tweaks.  Happy to make them myself if needed.
Notare la sequenza dei processi:
1) viene processato il motore fisico.
2) viene processato il livello in corso.
3) (che include un altro processo poiché): viene processato il Bgui corrente (gli sprite) e infine mandato tutto a video
I'm not sure how I feel about this one. It looks like more maintenance to support Chocolatey when I'd rather people just install from the installer.
change 'i' to 'displayPosition'?
trackStoredForExclusion reads ambiguously to me.  How about storeAsTrackedForExclusion?  It's  parallel to isTrackedForExclusion below.
Of course, you need to define yourself the styles named "p", "h1", "h2", "li".... so that FTCoreText actually knows how to format text inside these tags ;)
En nog eentje in backend/modules/progiles/widgets/registered_today.php, lijn 66: er moet een spatie rond de ternary operators ?:
@fbennett, does setting a default-locale interfere with bibliographic-entry-level localization in MLZ?

(see #93)
Ok.  My most recent commit addresses methods as well.
Not "spring" - "spacing"
mysql accept both :P
It seems to be working for me (and as far as i understand the man pages it should work as intended) but i'll change it back if this isn't common practice. Thanks!
I removed an if or two, but to remove more I would need to remove my groupings of odd and even and convert to a 1, 2, 3, 4 case system which means duplicated code for the 3 and 4 case.
It exists in game/Achievements/AchievementMgrBase.h
Merci Mika ^^
Tu falar isso foi até bom, já vi q o teste precisa de refatoração, no mesmo ele só testa se ele precisa logar, TEM q fazer com q ele tbm teste se é o administrador. Já em Alunos e Professores ainda não tem paginas especificas, só criei a autenticação, pelo fato de não ter precisado nesse teste.

Mas creio q não precise de um teste especifico como esse de admin, se os testes de aceitação forem feitos certinhos, acho q já cobre esse quesito q vc levantou
What about hating tabs ? Any reason ?
I realize this is probably out of your hands, but I just wanted to note that the caliper.jar has disappeared again.

The link you posted goes to a directory but it no longer contains the appropriate jar.
What are you calling cheese and crackers with here?
問題がないようであればMITライセンスで運用しましょう．
disabling fb (framebuffer) is not needed anymore because we use MISSING_GRALLOC_BUUFERS.
Had no idea it existed. Do I need to modify code and resubmit the pull request?

On 1/11/12, sinn3r
<reply@reply.github.com>
wrote:
> Please use the file_local_digestmd5() function, I think that's the one you
> wanna use?
> https://github.com/rapid7/metasploit-framework/blob/master/lib/msf/core/post/file.rb#L25
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/averagesecurityguy/metasploit-framework/commit/72072c4ef3945fdb90a2b6bccbd7d3038043bd0b#commitcomment-858656
>


-- 
Stephen Haywood
Information Security Consultant
CISSP, GPEN, OSCP
T: @averagesecguy
W: averagesecurityguy.info
Hummm, nope.

`TESTABLE` is used by both qtest and qtest2.
What's this list for? I don't think it is necessary here
Still can't agree, The structure is same as RIB.

In a modern project the js file is not only just one, they can not all at the root directory.
From here down, you are grossly exceeding the 80 character line width policy we have.  Each of these can be wrapped and indented to fix this, or, create a new function that will do all this for you and allow you to not have to be indented so far.
Datalists being flags like 0/1
Would suggest to be renamed to `cas-management` or something similar that indicates the file has something to do with CAS.
To have PIDs (the uids) exposed to users is not something we should add without much careful thought.
great that you have fixed ways around the SHA1PRNG issue, just to make sure I understand, what is the default if user doesn't configure anything? if default will still use the broken SHA1PRNG I think we should log warning (on Linux)
that obviously needs documenting ;-)
extends PossiblyHarmful?
What about a negative double? Like -1.0 for an undefined metric? (floating point numbers returned in Right(...) if I see correctly)
Shouldn't the null case be an exception? That should never ever happen.
We need to fulfill the `path` contract and always return a valid path, even after the ref has been stopped.
Here I wasn't sure whether `provider.tempPath` could conceivably throw an exception and how we'd best deal with this case
(sorry, I meant line 29)
Or rather verb...
If you uncheck the email notifications checkbox and submit the form, it submits a data_dict with no 'email_notifications' key, rather than one with 'email_notifications': False.
The parenthesis with hyphen end up looking funny, like 3/4 of a circle. You can see this on the docs-staging-2.0 build on readthedocs. Maybe consider quotes instead.
This raises an eyebrow for obvious reasons. I'm not sure why you changed out_func to accept a list of documents, so I'll take your word on it that it was necessary.  So I'm not suggesting a change, but my eyebrow gained sufficient altitude that I thought it was worth noting, at least to confirm that you are satisfied with this.
please put the two finds in 1 if statement, invert them, and drop the two continues. makes it a lot more readable
It *is* that simple. You just have to create the object *after* you patch the class:

```python

>>> class X(object):
...     def a(self):
...         print 1
... 
>>> def new_a(self):
...     print 2
... 
>>> X().a()
1
>>> X.a = new_a
>>> X().a()
2
```
You could use System.currentTimeMillis() in here to avoid creating a new Date object
commenting on blank line before 'more things to read'
('Service',)
Did you forget to check for {error, Reason}?
True, I just cut'n'pasted the suggested patch to get a pull request in as this is *so* broken at the minute.  Would you prefer it this way around ?
For arrays, we also need to check all values.
Please no! We don't let them `ivars` run free around this neck of the woods. Don't add more! :D
This swallows errors. Is that intentional?
move this mapper into mappers.js Also, after my pull request is through, ```component``` will not be passed as a param. Instead ```this === component```
Maybe it would be clearer to say "Job %s with ID %s  had %d executor failures; aborting".
Ce contrôleur aussi est inutile
Didn't we want to move these methods to ByteBufAllocatorService ?
Just that PyErr_WriteUnraisable is defined by the Python API as the official thing to do in exactly this situation :-). I guess it might have trivial improvements too, like printing to sys.stderr even if that's reassigned.
This comment is contradicted directly below... please keep comments consistent with each other and with code :-)
Hmm, I think someone else is doing a mass conversion from hash rocket to 1.9 hash syntax? If I switched this one test case it would make it inconsistent with the surrounding test cases, making any mass conversion effort more difficult / error-prone. Or should I change the other test cases in the same file while I'm at that?

Sent from my phone

On 2012-10-25, at 7:01 PM, Francesco Rodríguez <notifications@github.com> wrote:

> In activerecord/test/cases/finder_test.rb:
> 
> > @@ -28,7 +28,8 @@ def test_find_with_string
> >    def test_exists
> >      assert Topic.exists?(1)
> >      assert Topic.exists?("1")
> > -    assert Topic.exists?(:author_name => "David")
> > +    assert Topic.exists?(:title => "The First Topic")
> > +    assert Topic.exists?(:heading => "The First Topic")
> ditto.
> 
> —
> Reply to this email directly or view it on GitHub.
>
Is this the same as `has_one_macro` in the code below?
Again, these were copied and pasted from other tests that had the same whitespace. If you want to get rid of it, wouldn't it make more sense to have a separate commit that eliminates it throughout the whole file?
I'm working on a better implementation of message. For now, consider it just a stub whose attributes will be changing.
`Payloads are stored in type-indexed slots, which can be read with get[T] and written with update[T] and remove[T].`
Also, sometimes skew is just a single value (no length) in which case I need pearson3._argcheck to return and an array with a single True value.
p.s. the oldest stack frames will be dropped if > 100.
This should have a docstring, perhaps with some examples explaining what it is doing. IMO, it looks too complicated right now. There are sympy tools that could make this a lot cleaner, I think. e.g. coeff.as_base_exp() will give you the base and exponent of any expression, power or not.
On Mon, Apr 23, 2012 at 9:02 AM, Comer Duncan
<reply@reply.github.com>
wrote:
>>      M = Matrix(( (x,y,z),
>>                   (1,0,0),
>>                   (y,z,x) ))
>>
>>      assert M.det(method="bareis") == z**2 - x*y
>>      assert M.det(method="berkowitz") == z**2 - x*y
>> +
>> +
>> +    def test_det_LU_decomposition():
>> +        x, y, z = Symbol('x'), Symbol('y'), Symbol('z')
>
> Chris,
>
> I have made the changes you indicated and have made changes to address
> the snags that sympy-bot kicked up.  I hope this is getting close.
>

Close, but a couple minor edits remain. Please see my recent test1
branch at https://github.com/sympy/sympy/pull/1253 .

1) the output of a doctest is tested literally, so "[0, 1]" is not the
same as "[ 0, 1]" (note the space before the zero in the latter).

2) is_foo tests should fail as quickly as possible. Although you've
stated your test in an accurate way, it is inefficient in that *all*
the simplifications are done before testing begins. In the update that
I sent, the failure is reported as soon as possible.

If what I have there looks fine, there is no need to make the changes.
That's part of the joys of collaboration: git gives me tools to show
you what I would recommend and if you like it we can just update your
work with that. (If showing you would take too much time then I would
just say what I think needs to be done and wait until you do it.)
I guess this means that the form has already been submitted (so it is not the initial rendering).
I must have gone temporarily stupid on this one. Thanks for pointing this out.
This line shouldn't be here, and version_idx below isn't used either
We definitely do. However, I'm going to defer that until my next branch on this topic. Read the '###' as a TODO marker.
@royaltm meta? I guess this is a variable to store the last message sent to the server.
You forgot the link to your recipe (use : <form_no_csrf>)
Actually, I think the binmode version should remain, and have the read/size one added as a second elsif.  That way it should work for things like the paperclip thing you mentioned, but without breaking anything.  In particular the binmode stuff helps ensure that the size is calculated correctly for files which use non-utf8 characters.  Is that feasible as a solution, or do the paperclip things reply to binmode but not File.size correctly?  If it is the latter then perhaps the binmode check could remain, but File.size could be replaced with just body.size.  Does that make sense?
Is this part needed?  If so, shouldn't it still check_permissions and do new(path, parse(...))?
You can remove the comment. I checked the xnu source - a zero timeout polls, it never blocks.
Copied the FIXME already in place in another location so that if it is fixed, these locations are found as well.
"full connectivity" is not clear as such.
would be great to combine this with https://github.com/mozilla/kuma/blob/master/apps/wiki/tests/__init__.py#L191 for a general-purpose test utility for making topical parent & child docs.
J'ai tout rendu non-fluide.
"an extensions" should be either "an extension's" (note the apostrophe) OR "its". Preferably the latter (its).
Opening curly braces go on own line
I was thinking about the same thing. I will create a ticket.

-- 
(¨`•.•´¨) Keep
`•.¸(¨`•.•´¨) In
(¨`•.•´¨)¸.•´ Touch!
  `•.¸.•´
Semi-colon required here
we still need to remove ourselves even if there is no new client, right?
I'm leaving it here, for further reference. We shouldn't send signals by hand, instead we should use views to test expected behavior.
slim 也是支持 .container 就可以的
This likewise feels more like hasContentsInAnyOrder(...) or hasUnorderedContents(...)

Hmm.
Neat idea, and probably OK.

My worry is that the `syntheticStat` probably marks the resource as a directory.  The way we use this stat structure today it's probably no big deal, but it might lead to interesting surprises later.

I have a slight preference for saying that "synthetic files don't have a 'stat' structure" and then make sure that trickles into all parts of the system (static handler in this case).

But, the above code will work fine for now.
Move `return` to separate line and add `break` for code consistency
There is a 3.2.21 kernel, any reason not to use it? 

It would also be nice to unify this file with linux-3.2.nix instead of duplicating it. Isn't it possible to do something like

```
linux_3_2_xen = makeOverridable (import ../os-specific/linux/kernel/linux-3.2.nix) { 
  extraConfig =
    ''
      XEN_DOM0 y
    '';
};
```
Style: just naming it ```model.encounter``` is preferred rather than ```model.encounterModel``` (which is redundant).
createRegList and createScrList should be one function createList that also takes in the store. Also, you don't need 'd' here
if checking for actual null, use `===` or `is_null`, `(0 == null) === true`
If a function has both integer-valued inputs and integer-valued outputs, which case applies? It's worth spelling out.
Hi, 75-77 probably won't work as long as we have line 73.
the font setting looks good, though. Maybe use the "Monospace" font as default, as it is used by gnome terminal? (btw, we will have to add it to the dependencies)
Please create a new commit containing only 24 and 79. Thanks for your participation :)
Makes sense. I'll improve the tests.
What's with the comments?
No problem.  reverted in 185bbcb
lower case for "Fundamental"?
why the is not  None and issubclass check here instead of the normal isinstance?
No empty lines between clauses.
I did the same thing with a simple code in my pull request #200

```
let n = substitute(a:name,"['".'"]\+','','g')
let b = filter(copy(g:bundles), 'v:val.name_spec == n')[0]
```
I'd recommend turning on invisibles in your IDE and enable some sort of "remove end of line and empty line whitespace on save"
Could you please break this out into a separate pull request?
Also, it seems that the parenthesis are misplaced. Did you mean to add on the port even if ROOT_URL is explicitly set?
This fixed your problem because it forces the TextureCollection to reapply all textures.  Which tells us we're changing the bound texture incorrectly.
Minions (which should eventually just use Monster class) also use WeaponMeleeInstant.
I wouldn't bother changing it here, it can be a follow-up, but it's worth double-checking that this is the intended behavior. It seems like it violates the users expectations to just never respond to them--they took the time to enter the email address.
Don't need an args array here, just pass `--prefix` directly. And remove the `ohai` line.
I'd prefer not to rename it, but I noticed there's another formula for a tool called le. (I noticed it linked to a non existant tar so I updated that too).

Is there a way to avoid the renaming? Is it ok for Formulas to clash?
Probably moot at this point, but s/libmxl2/libxml2/
Ah, got it. Adjusting now.
Should these maybe be prepended instead of appended?
If you want the head of a list you can use `hd/1` that is more idiomatic than `lists:nth`.
The three copies of this method are identical except for the state set -- maybe they could be combined into one and just set the appropriate state?
As with the puppet file, I think it's odd to have these Alias statements inside a VirtualHost section and also repeated outside of it. Maybe you don't want this bug fix to turn into an apache config cleanup story, so sorry for moving it that direction. :) I think it's at least worth pointing out that perhaps we only need one set of statements to appear outside a VirtualHost section, or we should have matching VirtualHost sections for ports 80 and 443.
should probably revert this
Rename method to 'enableDirectoryListing', to make it more in line with the convention of the other builder style methods.
This works, though it makes the view dependent on living inside a workspace. If someone wanted to use it in some other context, like a dashboard or a search screen or something, this would make less sense.

I would have added a binding somewhere that attached to the collection's parent:
var parent = list.getParent();
parent.on('statusChange', this.updateButtons, this);
IIRC, forEach runs in parallel -- do we want to hit all the partitions at the exact same time?
Then fix it in the spout engine, not here.
Remove ``!``
Can we enable/disable this with a preference?
Coding guide says to use double-quotes instead of single-quotes, except when nesting (to avoid escaping).

Sorry to be pedantic, but I recently had to review a *huge* pull request where one of our users went thru the entire code base and corrected this.
Super! But now I want a back button. :)
Ditto -- indentation
You can delete this file from this pull request since you're not submitting a translated getting started project.

If you plan on doing this in the future, you would update the ``GETTING_STARTED`` path below to a relative path under the ``/samples`` folder and also update ``src/nls/urls.js`` to add ``ja`` to the list of languages.
ended up multiplying CAPACITY by 2, works, seems inelegant but couldn't reason something much better
would be nice if we only had to maintain this list in a single place
you can use standard java NotSupportedException
You have to log out (ie visit /signout or clear your cookies).

On Wed, May 9, 2012 at 6:29 PM, Daniel Trauner <
reply@reply.github.com
> wrote:

> > @@ -6,5 +6,6 @@ class ApplicationController < ActionController::Base
> >
> >    def current_user
> >      @current_user ||= User.find(session[:user_id]) if session[:user_id]
> > +     rescue ActiveRecord::RecordNotFound
>
> Dude I probably dropped and re migrated the database 15 times and
> couldn't get rid of the user with ID 1 not found bug.  That fixed it;
> I can give you the Stack Overflow link.
>
> Dan
>
>
>
> On May 9, 2012, at 6:25 PM, "Gareth G. Aye"
> <reply@reply.github.com>
> wrote:
>
> >> @@ -6,5 +6,6 @@ class ApplicationController < ActionController::Base
> >>
> >>   def current_user
> >>     @current_user ||= User.find(session[:user_id]) if session[:user_id]
> >> +     rescue ActiveRecord::RecordNotFound
> >
> > Kill this. If there is a user_id key in the session hash, then it should
> be in the database. The only reason you'd ever lose it is if you change the
> database in which case you'd want to have the user log out.
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> > https://github.com/gaye/rideshare/pull/22/files#r798494
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/gaye/rideshare/pull/22/files#r798524
>



-- 
Best,
Gareth
Why woudln't `rescuable?` return true for a `Grape::Exception::Base` instead?
"let the user select"
As far as I remember, the branches and reference names are treated internally as ASCII strings (I.e. a pointer of chars). Do not know which policy should be applied in rugged.
What if there will be some global Python module named `account`?
class="no-js" not needed
small nit, but you can just do `media.popcorn.popcorn` here
This is to allow cropping of the image, so changing height will actually do something
s/they/"the user"
`namedtuple` is a thing. :)
void
ngx_minheap4_delete
既然是两个问号那就应该写上两个问号吧'??'
`PATH.join(__dirname, 'freeze_basic/test.xxx')`
Pretty sweet that you've used Ruby's convention to add a ! to methods that change state!
Best to use a 'var' keyword for every variable. It's just a style nit, but it's one people are passionate about.
I agree, but leaving it as it is. Testing this is pretty difficult and i don't feel comfortable enough to really implement less aggressive locking.
If people report problems (or large deployments), i'm happy to take a look.
Seems really awkward not to call these `first` and `last`.
minor mod  
```ruby
KTEnvironment.content_readable(current_organization).select("environments.id").collect{|e| e.id}
```
Having it on the line 255 should be anough
Yup you did, but I'd forgotten about it. Maybe good to include a note in the NS as well?
Is there any benefit on the pythonic way?
If it's not needed right now, let's remove it for now.

If we ended up implementing `<iframe seamless>` (neat proposal BTW), then we can add it back if the implementation really require us to.
I appreciate nitpicky.  :-)  I had arguments with myself about the trailing period for docstrings that are not a sentence.  Thoughts?  I'll make the one-liners not have a trailiing newline.
Why not just directly implement this stuff in update/1 and call slide:moment() where required?  It probably doesn't matter for low frequency gossip stats but for any high frequency calls it means calling os:timestamp() which I think maps to a gettimeofday call to the operating system.
I wonder why we still have a mysterious boolean parameter for the 'modal' state, even though that's one of the CClientUIInterface flags? :-)
I'd prefer simply giving back an error, instead of guessing and fooling around. I suppose if GetSpecialFolderPath fails something is wrong anyway.
Do I understand correctly that this doesn't change the "generated coins always to '' account" behaviour?
variable names should be camelBacked.
Better to temporarily set useBoldFont = YES, then call getFontForChar:isCopmlex:fgColor:renderBold, then restore useBoldFont. That lets you remove the if statement at 5706, which will be much slower than getting the cached bold font.
You can use `file.path` here
That makes good sense, and I will make the change to avoid future similar confusion.
The `Scripts` directory is also Windows specific, I think.
If this part goes in, I'd consider having something like a 0.1s sleep, then poll to see if it's exited with a non-zero return code, and grab the contents of stderr so the user can see what's gone wrong. It looks like the %open part is unlikely to be accepted, though.
As [discussed](https://github.com/laravel/laravel/pull/1272#discussion_r1671958) in the previous pull request (see the discussion on the "outdated diff"), you are right, but as that parameter isn't even documented in the Laravel docs, people should not use it.

Also, the approach that was implemented here is much cleaner and more Laravel-ish, I'd say.

Let's see what @taylorotwell says...
@carlosmn I'll fix that as well.
As an external typedef, this should have the `git_` prefix - i.e. `git_tag_foreach_cb`

Also, everywhere else we've written our function pointers like:

`typedef int (*git_tag_foreach_cb)(const char *name, git_oid *oid, void *data);`

And then we use it as `git_tag_foreach_cb cb` instead of `tag_foreach_cb *cb`.
Remove - will update the pull and they're gone
This is a little goofy, but I'd put 73 here instead of 72 since that's definitely outside the boundary. I can't tell if it's possible for the timings to be such that there's an edge case where it ends up being inside the boundary and shows up in the "from last 72 hours" list.
I think I'd use "suggest" instead of "search"--that's closer to what this stage is about.
Speaking of above, it might be nice to make it easy to override NFS here, some people don't want to run as root or run on windows etc.
```ruby
it "doesn't extend ActiveRecord" do
  Sidekiq.options = { :enable_rails_extensions => false }
  refute_includes ActiveRecord::Base.included_modules, Sidekiq::Extensions::ActiveRecord
end
```

and same for ActionMailer. Am I missing something?
There is a missing "%s" in the flash message
We should have a generic async cache interface. Just created a ticket for it: #63.
There is no point in passing query to script filter, what kind of query it can be? Only script is accepted. I left setQuery() method just for BC, but i'm not sure if anyone uses it. I'll fix the @param in dockblock.
Well, it's not an alpha-value in this case, the PixelFormat explicitly says that it's a 4-byte format with 3 bytes for RGB and 0 bytes for alpha. The point being to avoid having to add yet another endian-check here. I might as well have done 24bpp I guess.
The exception type is surprising.

Especially for posts.
Please add `Use {@link OneOfValidator} instead.` here.
Add an empty line before `throws`
yes apparently it's related, tests pass with ```phpunit --process-isolation src/Symfony/Bundle/FrameworkBundle/Tests/Functional/RequestTest.php```
Btw, I don't think this is necessary as a request coming from AJAX will contain ``HTTP_X-Requested-With``, as for other HTTP headers. If you pass ``$_SERVER['X-Requested-With']`` in the test, you are not doing the same thing than your real code
I would suggest ``BatchDriverInterface``
Returning a guess with the value "null" is (almost always) useless, because that's the same as having no guess at all. So you can remove this one.
Please keep the short class name (and add the use statement if it is missing)
you should not extend collectionType. This is not how the form type hierarchy works
Please remove this phpdoc. You are not author of this class, and you are already mentioned above.
CS issue here
OBController already has user() in it. Use that.
show error message using `SVProgressHUD` in `else` block
I know this is nitpicky but since you'll be fixing things anyways this should probably say reduced quick action
Should we actually check a call to ruby -v as well in case build fails partway? Or does it not touch that dir till fully successful?
This looks familiar :) maybe it should live somewhere more generic...
Please give me the reason of why you must use \heiti in thesis.
I would be more appreciate if you show me your real example.
add osgb
This PR is all about improving the download interface ... and yet you've added a new shapefile to the repo? Isn't that a little contradictory?
after these asserts we should assert that the Queue is empty
This file should use print "string" or echo "string" to match the coding style used in Drupal.
This is an improvement overall but still a bit unclear as to whether the `controller.target` defaults to the router only or also to the supplied `target`. It might be clearer to say:

The `{{action}}` helper registers an HTML element within a template for DOM event handling and forwards that interaction to the view's `controller.target' or supplied `target` option (see 'Specifying a Target'). If not otherwise set, `controller.target` defaults to the application's router.

I'll let you decide on the exact wording.
This will be out of date if the cache is only updated when a cert is added/removed.
This looks strange, I need to investigate...
I'm not sure what the API expectations are, but should there be a WARN/INFO or error if there's no such bean or if there's more than one such bean?
Why are all of these if checks needed? The register operations do a putIfAbsent, and this risks a race.
这个地方不对。dateCreated 不用初始化，系统自动搞成当前时间。
但是dateExpired要初始化成创建时间，才能使用户一创建就不能用vpn。
nit: user -> use
everytime there's a change on locales, we should pinga l10n-driver, as we are string frozen (@stasms, probably?)
You should not hardcode the string 'FirefoxOS'. There is a l10n key called {{brandShortName}} for that.
Do you prefer:

```javascript
_appSettings.option('calltime',
  _appSettings.option('calltime') + duration
);
```

Really? If so, what is the pattern? First parameter in the same line, the rest in the following ones?
Fine, I think it would not influence `statusbar` now. Merged. Thank @riadhchtara .
Here i need to reset the className, if i use classList i would have to use a for loop. 
Is there a way a can reset/replace a class using classList ?
Damn it! The is a typo in the second appearance of "/apps/communications/contacts/index.html" in my prior comment. It should be "/apps/communications/dialer/index.html" ;-) But I guess you get my point :-)
Does the event fires event if the `evt.detail.contextmenu.items` is empty? Do you need to check it?
nit: same line as window.addEventListener please
This is for the animation on the album art (cover).
The info (album, artist) will initially  show up when a song being played,
then it will be disappeared after 5 second if users does not tap the album art (cover) again.
however, if users tap before 5 second ends, then the timeout will be cleared to keep the info on screen.
interesting to know that -moz-calc should be unprefixed now.
whoaa what's up with all this whitespace?
It would definitely do something sneaky if the 500 was raising an exception, otherwise it should work properly.
See update.
the visor lib is still go-getable via `github.com/soundcloud/visor`, but the visor binary would not be installable via `go install`

The reason why I did it: when using the expanded import path there was the following problem: when you have the package sources installed in your `$GOROOT` and you build you binary, go install will take the `github.com/soundcloud/visor` version from your `$GOROOT`, means that once your `$GOROOT` has an old version of your lib, you will always get this old code -- even if the `$GOPATH` is set correctly. It made updating with brew impossible for me.

I briefly looked into the source code but can have a look again.
I think it would be better to have these "magic numbers" on the car as properties. Even if its not the best place to put something like the width and height in pixels into a model, its still clearer than having these magic numbers there ;-)
Document these globals.
Again, return the reason why it failed.
Add in a `Raises` section and a `Returns` section.
This should set the dimensions and anchor of the image too.
The same for `id` (though I'm not sure if its needed as `className` may be sufficient)
This was causing the infinite loop as it calls save_node, which uses hook_nodeapi. So now this is change so that it just sets the node, as it's saved after nodeapi calls anyway during the normal execution order.
That method was already there, I added the one after it..
i can has real sscs file please?
This is currently badly implemented. I propose to comment it and prepare a better implementation in next step.
Just need to merge up with master probably. Pull Request diffs are against the last merge base on master and head, not current master.
bleh, I hate shoulda :(
Sure deferring that until necessary is a very reasonable approach.
You apparently can't use Markdown inside certain HTML block elements including tables, so this has to be <code>control</code>. It's painful, I know.
Instead of doing this, we are going to want to include this in our static resources list so we minimize the number of requests.