labofsahil/github-event-dataset-2012 huggingface dataset:
Because annotations aren't those things.

Von meinem iPhone gesendet

Am 28.12.2012 um 08:19 schrieb thehutch <notifications@github.com>:

In src/main/java/org/spout/engine/SpoutApplication.java:

>  	public boolean ccoverride = false;
> -	@Parameter(names = {"--path" }, description = "Override path for the client")
> +	@Parameter (names = {"--path"}, description = "Override path for the client")

Why not? if/for/else/while etc... statements get this space? Why can't the
parameters get it?

—
Reply to this email directly or view it on
GitHub<https://github.com/SpoutDev/Spout/pull/2152/files#r2516249>.
I'm going to punt on this for now. Mocking out a YQL response that has mock responses for the various feeds doesn't feel quite right.
Google Translate is correct on this one
There is a basic performance testing timer builtin to Brackets called PerfUtils that you can use to time both cases. Use it something like this:

``PerfUtils.markStart("[descriptive string]");
``// code to measure ...
``PerfUtils.addMeasurement("[descriptive string]");  // same string passs to markStart()

Then use Debug > Show Performance Data to see min/max/avg times measured.

I measured this both ways and saw a max timing so 1ms, so this code does not seem have a significant impact. But you might want to try this:
http://updates.html5rocks.com/2012/08/When-milliseconds-are-not-enough-performance-now

I would think that regexp.test() would be faster than a replace with no hits, so please remove these comments.
You have get/setEnabled as well as _isEnabledFn. Is that intentional? How would they be used together?
All the `return` statements here can be removed too
I think it should just call `debugger.setFrame(frame)`, which would call `debug_handler.setFrame(frame, callback)`.
it looks like this will create a global registry of api names (meaning two apis defined by different domains for different stuff will override each other in unexpected ways). probably not a big deal for now and not sure if custom reports also has this problem but something to think about
Newline at the end of this file plz
If I remember correctly, these values are constant and stored in Type. Use the constants, not their values, for consistency reasons.
ah ok, I always confuse myself with that stuff ;)
thanks!

On Jun 13, 2012, at 1:54 PM, Carlos Martín Nieto <carlosmn@noreply.github.com> wrote:

>> @@ -30,4 +30,17 @@
>>     assert obj.read_raw
>>   end
>> 
>> +  test "can lookup an object by refspec" do
> 
> This is not a refspec. A refspec is what tells `fetch` where to store the refs it downloads. The documentation calls this an "extended SHA1 syntax", but you can call it whatever you want as long as it's not refspec.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/libgit2/rugged/pull/71/files#r975270
Also clean unneeded imports.
Same comments as bellow.
Call this `generateIdString`, since it isn't really generating an ID.
You can't use `toward` here anymore. Maybe use `around`.
space after <code>for</code>
You can use DIST_DIR here too
I'm only assuming this won't work the way you want it to, right? `advancedContainer` isn't taken into account here at all, I think.
yeah might as well :) we only need it on the topmost file (also jshint will tell you otherwise b/c you're not jshinting the entire app)
Well, of course - don't mess with multiple convention. Stick to one.
Am besten auch noch in der englischen Sprachdatei hinzufügen.
nit: I'd present this as an offset from the RECENT_COMPILE_DATE to avoid having a tlsdate-y2k bug
Just 'modules' is enough.
Why this change? Does >= somehow block you?
Can this be pushed off to a class to separate view from styling?
Same here. bestPlan is the top plan

On Fri, Sep 21, 2012 at 5:28 PM, Paul A Martel <notifications@github.com>wrote:

> In src/frontend/org/voltdb/planner/QueryPlanner.java:
>
> >              finalizeOutput(bestFilename, stats);
> >          }
> >
> > -        // split up the plan everywhere we see send/recieve into multiple plan fragments
> > -        Fragmentizer.fragmentize(bestPlan, m_db);
>
> This is also probably better defered to the top plan.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/3/files#r1665952>.
>
>
OK. Sorry about that. It looks like I was mistaking old code for new code -- I struggle sometimes with github's one-size-fits-all online diff. 
I'd rather pull the code and use my local diff tool of choice (merge via gitmerge.py), except that then sending comments is harder.
Maybe someday I'll learn the web 2.0 API and write a comment transfer tool.
This part of the docs isn't true anymore, right?  That is, it doesn't return a readable file-like object, but rather a context manager that yields a readable file-like object. (Nominally, there should also be a "Returns" section that says this, but that might be more confusing given this is a context manager.)
Sorry about that; I changed it back to "Astropy" in the latest commit. (I think somebody, maybe @taldcroft, had referred to it as "AstroPy" and that seemed more natural to me - emphasizes its NumPy parentage and that it should be pronounced as "astro - pie" rather than something that sounds like "entropy")

I also made the "Developers" change in that commit.
Not really relevant to repair, but would it make sense to have a variant of this function that also returned the default bucket props appended to the list as , say, `[{default, Props}]`? Could have used it in the `NValMap` code in repair to avoid needing to query the default `n_val` separately.
That should not be here I guess.
NAK, I like these unconditional
>But currently is labelSeparator modified when we change the language? 

Currently 'labelSeparator' don't use any i18n.

>Can this be done globally at the application level?

As I see Ext don't offer a way to do that, but it we set a value to `Ext.layout.FormLayout.prototype.labelSeparator` it will probably do that.
I don't understand why you use:
this.tpls.allTpl
this.tpls.mouseoverTpl
this.tpls.rightclickTpl
this.mouseoverTpl
this.rightclickTpl
Why mouseoverTpl and rightclickTp where at two places ?
shouldn't we use:
this.allTpl
this.mouseoverTpl
this.rightclickTpl
or:
this.tpls.allTpl
this.tpls.mouseoverTpl
this.tpls.rightclickTpl
This step should be more specific (e.g. "I should see a record that the close date has been updated")
same comment about `allow_scientific_notation` being overly verbose.
WalletTransactions has some optional parameters.
well, the factory handles this issue, and we only use the class name to call the factory.
We'll have to keep this in mind - We have not built a release that used a native DLL up until now.
haha, itchy mash? Great name, but it conflicts with the existing [rash](https://github.com/tcocca/rash) gem.
Insert a logical line break here as you do in the tests?
Here, if the -j command-line is omitted, the old implementation is used.
Is there a better/shorter way to forward these to the paging scroll view? For controllers addChildController usually suffices but that one is a UIView.
Please change the order of the parameter so that `$table->integer('id', 3)` becomes possible.
I'll try it and see if it still works.  If so, that'll be a bit cleaner
Heuh... Periods in macros?
Quite right! Fix forthcoming!
Instead of disabling the identity map, how about just hitting moped directly?

```ruby
query.dup.select(_id: 1).limit(1).entries.first.nil?
```
what's wrong with `user = request.user`, why re-query?
You could fit more on this line!
Missing space before `+`
I don't think you need these two fun heads. Code should be the same whether the principal is a client our a user.
Been down and out man. Ill get this covered tomorrow for ya.
 
 

Ryan Thompson
President / CEO
AI Web Systems, Inc.
[http://aiwebsystems.com] www.aiwebsystems.com
(877) 705-0806



 
Killer websites, amazing results and easy content management.
 


-----Original Message-----
From: "Adam Fairholm" <reply@reply.github.com>
Sent: Tuesday, June 19, 2012 12:07am
To: "RyanThompson" <service@aiwebsystems.com>
Subject: Re: [pyrocms] Feature/tabs (#1452)



> @@ -105,7 +105,7 @@ public function locate($segments) {
>  			}
>  
>  			// If this domain is an alias and it is a redirect
> -			if ($site->alias_domain !== NULL and $site->alias_type === 'redirect')
> +			if ($site->alias_domain !== NULL and $site->alias_type === 'redirect' and str_replace(array('http://', 'https://'), '', trim(strtolower(BASE_URL), '/')) !== $site->domain)

Hey Ryan! Let me know when you can get rid of this - I'm excited to get this into 2.2!

---
Reply to this email directly or view it on GitHub:
https://github.com/pyrocms/pyrocms/pull/1452/files#r1007509
Use doc comments:

/// <summary>Unescape xaml positional parameters (i.e. removes all occurences of "{}")</summary>
I would use ``!empty()`` here as we don't care about the count.
It worked when I tested but I didn't test nested folders which might require this. thanks for the hint.
ah sorry, the stub is not in composer because the functions cannot be autoloaded
I know this is the convention, but why must it be a hard requirement?  (Maybe it already is in full stack, not sure.)
```[VenueInfoViewController onScreenVenueVC]``` may return ```nil```
Yes, this code was produced by someone else, I've only changed indention. It's bad, there has been a lot of bad in this file. I'll fix it too.
I vote for keeping the class but renaming to reflect its delivery responsibility and making the methods less noun-y and more verb-y.
These comments about "unit test" here and below aren't totally truthful - it runs after every spec, whether it's a unit test, an integration test, a controller test, etc. What about "# Run before each spec"
I understand why you decided to create another class for that task but still think that there should be another logic in UnnecessaryNotNullAssertionFix and ReplaceCallFix. I propose ReplaceCallFix could also be used for replacing !!. call to something else as it can be used for introducing such calls now. And this class can could be responsible only for introducing and removing a!! postfix operation.
What do you think?
My bad, when i saw that Squeryl return Option values, i thought they handle exceptions by returning a None, changing everything to boxes ...
不是没有DistributedCache了, 这里的作用是?
CS: extra indentation here.
boolean のリテラル表記は DBMS によって異なるのでプレースホルダにしておくのが無難です
This should be

ModelNode node = DATASOURCE_DRIVER.resolveModelAttribute(context, model);
looking back on it I realize that is just wrong to write back the value. I'm committing a patch removing line 80 and 83
That was my idea too until I realized this code is in the controller subsystem. Adding a reference to the security subsystem Constants would create an undesirable dependency here, wouldn't it?
top + targetHeight - elemHeight
`style.position` should do
childWindow.onload = function childWindowLoaded() {
`ColorPickerView`
Nit: remove dead code (please check other occurrences).
url.indexOf('blob') != -1
We can not use CSS gradients due to performance issues, please adapt your code for using background images.
Thx!
It'll be more readable
nit: you can do var width =  ...; var height = ...; here instead of declaring it above.
It doesnt break the initlogo. If the logo doesnt dissapear properly it's due to the Build, because there is some bug with activities (if you check the log you will find something like `E/GeckoConsole(  106): [JavaScript Error: "caller is undefined" {file: "resource://gre/modules/ActivitiesService.jsm" line: 299}]`)
sorry, I don't understand this comment.

I initialize a default value for a variable that I change the value in the following switch block. What's wrong ?
It looks wrong to me as well, but I just copied the text from the bug. I'll pass along the comment there.
```ruby
# Use dedicated hash for request options

request_options = {
  :version => "3",
  :authenticate => true,
  :raw => false,
  :force_urlencoded => false,
  :media_type => :json
}
patch("repos/#{Repository.new(repo)}/comments/#{id}", options, request_options)

def patch(path, options={}, request_options={})
  request(:patch, path, options, request_options)
end

# Use a single hash, use octokit to prevent api param name conflicts.

options.merge!({
  :octokit => {
    :version => "3",
    :authenticate => true,
    :raw => false,
    :force_urlencoded => false,
    :media_type => :json
  }
})
patch("repos/#{Repository.new(repo)}/comments/#{id}", options)

options[:octokit][:media_type] = :json
patch("repos/#{Repository.new(repo)}/comments/#{id}", options)

Octokit.commit_comments("pengwynn/octokit", 1, {:media_type => :json})

def patch(path, options={})
  request(:patch, path, options)
end
```

After looking at this for a few minutes, I'm in favor of using a single hash since we pass those params around a lot internally.     I think putting it into the options hash for users to set if they want a custom media type is better too, the fewer times we have to throw around optional parameters, the better.
I would recommend adding encoding comment, because it is not defined as UTF-8 in Python 2x.
`equal` > `==` > `eq`

I suggest we keep the current solution :)
Use `self.assertEquals`, which is the proper way to use Python unittest.
@Freeaqingme  dan word er een exception gegooid. Hoe wil je hier mee omgaan? Gewoon ZF2 includen in alle projecten die gebruik maken van glitch of heb je er een idee voor.
This should happen with a change to MeasurementListToDictList since we are using that for part of the serialization.  That was the code that came from controllers/measurement.py (you mentioned wanting to improve this).  I think that if we can change helpers/util.py:MeasurementListToDictList to use a query and iterate over it as you suggested, then the controllers/archive.py:GetMeasurementDictList could take a more proactive approach to dealing with large query results.

Again marking with a TODO for now.
ahh... well there are no DOCS about this atm :-)

so instead of onSpawned I will do onAttached... thanks
Thanks for pointing out that this was confusing,  While re-writing, I found that everywhere <code>nic_mode = tap</code> was being used, it was always synonymous with a bridge, so I eliminated <code>nic_mode</code> and just made <code>nettype = bridge</code> have the same meaning.  So, no it really doesn't have anything to do with llibvirt per sey, though under the hood, it's all the same stuff.l
As I mentioned in `rebuildBuild`, I think that this new method is not a good idea, since it does something different than what it claims.
``return isset(static::$formats[$format])`` will be faster
Just a nitpick, the * doesn't need escaping here.
we need to keep interm-bootstrap for the time being, otherwise there will be weirdness in all of our pages where we use blueprint over bootstrap (for the time being)... this is re your .span-24 finding weirdness.
Might then be more efficient to also store the visible fields per section?
Move logic to helper or decorator or role. Same for issue
since #1692 there is no `target` on Note any more
What's wrong with that, is that you shouldn't really be supporting raw pointers. If someone wants to normalize a string or a wide string you do this:

template <class Type>
void normalize(Type &path);
We need a per_cpu macro to add on the array scripts and the cache alignment (which you miss in this example).

struct cos_sched_data_area per_cpu(cos_sched_notifications);
Got rid of FrontRefresher and moved logic (except monitir status) into Front
Ahhh... the Configuration objects are flatten in the code too. Okay, I guess.
Think this check makes sense for file_data (which tells the sig to be checked against the http response body) but not for pkt_data
Yes, it can be deleted :-)  I seriously probably have a file named `;` in every one of my repositories.  It is a result of me thinking that I am fast with vim.
Just my opinion: I find it very confusing to use numeric values for configuration values. For boolean 0 and 1 are OK, but when it comes to 'above', 'below' and 'split', it's better to use words to make the code easier to understand. Yeah, we all use integers, but why not change that habit and do it better?

I'm also not sure it mixing logic operation variations: OR, or and || in the same file is a good idea. Does Joomla coding style have anything to say which one to use?
It is misleading to have a `check` function on a radio button element if it implicitly "unchecks" other elements in the group.

Using "setSelected" would be less ambiguous and would work for both checkboxes and radio buttons.
thanks for the clarification @gozala I think this is something that we should mention in the docs @wbamberg
We try to minimize moz-specific JS to a bar lower for new comers. Such let scoping can be very confusing, could you please change it more obvious form:

```js
let branchName = options.branchName || '';
let branch = Cc["@mozilla.org/preferences-service;1"].
  getService(Ci.nsIPrefService).
  getBranch(branchName).
  QueryInterface(Ci.nsIPrefBranch2);
this.prefs = Branch(branchName);
same as above, we have box-sizing: border-box on *
Same with this one, seems to be unused as well.
I think so. I'll try to come up with a good name for it.
Any reason you added these specs? It's fine that the specs just throw an exception if a file doesn't exist or anything. This isn't really the behavior we're testing here, so I would leave those cases out and just do the two require assertions.
Need to add this file to test-harness.html
Please add a newline after this.
This is wrong. When you read DNSORIPv6 expects literally DNS or IPv6 and not DNS or IPv6 or <Other things>
line 122 and 123 have be the same indent
Same note here -- PHP-style comments, but move this to a \@todo annotation.
You're right... and the class is a BigInteger, not HighPrecisionFloat (or something)

I'll convert it to int, then talk to @ezimuel about it
One problem here: if you're using PHPUnit from git, this fails, even if you're using it from the 3.6 branch.
OK, I will delete them all, and do a separate pull request tomorrow.
Why allow post by default?
It is impossible to achieve white text on white background (or anything the like), since the text color is computed depending on the bgcolor. And if a users chooses to have a white bgcolor, the text will be black and the only effect is, it's not visibly "highlighted" (white text-bg on white ground), but I don't think that's a big issue.

I'd just remove this check.
It seems I'm too used to Eclipse format shorcut...
Ah, that's normally as simple as doing something like this:

from pelican import logger
logger.warning('blah')
I've never used FakeFs.  I'll take a crack at it at some point, but for now I'd like to clear a couple of your other features first.
````ruby
puts "Hello world"
````
Nope. In real DOM (and this one) it's always at least an empty list, even for leafs like TextNodes.
@harjis Kaikkiin teksteihin, jotka menee ruudulle ain t-funkkari. Virheviesteissä käytetään Pupessa <font class='error'> fonttia.
How do you feel about this?
```ruby
redirect_to :back
```
It's more vague but definitely points to the right url.
We could even use `mkdir_p` here, it would be more appropriate.
This empty line may be removed, as you see fit.
docstring doesn't make sense?

If configure is empty, use `pass` in the function body.
Nit: but lining up attributes is prettier.
Uh, should be '-p1' here. Yes, '<' is needed because that's what patch expects. It reads its info from stdin.
I think it should be deleted case this reasons:
1. ``list_formatters`` isn't a good name cause if future it should be used in readonly fields in manage form
2. price example ``dict(price=lambda c, m, p: m.price*2)`` doesn't work and words only with code ``getattr(m, price)``
3. pass all this args c, m, p isn't obviously and usually a waste of effort
At least it appears to be consistent, so that's good. Probably due to the default sequence sep in json being `, ` and not just `,`.
よかったらindex はりましょう。
в твому IDE є проблеми з відступами?
good call, yeah
Why not just build a literal array here `project_tasks = ["Client Communication, "Planning"...]`?
I tried setting m_bIsAllocated to false here to get around this earlier, but dvdplayeraudio still crashed (another thing: in paplayer audio is lost, but it does not seem to crash). Biggest issue now is to find a free timeslot in the living room for a more in-depth experiments but I doubt this will happen before the weekend.
What time unit is this in? Seconds?
Just being nitpicky -- but could you please keep the gems listed together.
instead of all this code to get the tags, why not just use

    $cobj->getAttribute('tags');
Hi. Logo as background is perfectly fine at this place in the Web-based app interface.
зачем это все? а если я захочу определять какую имплементацию использовать в зависимости от количества пуговиц на моей рубашке?
мы вроде обсуждали, что это должно быть вне класса.
Я могу не знать заранее степень и вообще;;;
сохрани ссылку на comp..s[size - 1]
Is `typeof` smaller? Also, double quotes (I know it was already wrong).
@AlinT http://pastie.org/4005806
The docs say you use nose. So... I used nose. If you want to change it, go for it.
`applied` is only used in one spot, so I think it can be inlined
This case is the reverse of the above. The user simply has no access so I *think* this should be a 403
I'm not sure if we need to wrap everything in a SecurityContext.

As far as I understand, our principalIds will be along the lines of "g:cam:groupid1", otherwise we can not seamlessly use them across tenants. In other words, modules using this API would want to pass in the full thing rather than split them up.

The only thing we probably do want here is a composite id generator, so "g:cam:groupid1" can be generated consistently in the groups API.
Missing `'`
I noticed that stepping is pretty slow. Not sure about the ordering, so I may be totally wrong, but could this call

    scalaStackFrame.thread.getStackFrames.indexOf(scalaStackFrame)

be made faster with a custom `indexOf` implementation that searches backwards (assuming the current stack frame is very close to the top of the stack, and that `getStackFrames` returns them in bottom-up order.
extract-method to the field access (can be used in the handles? method aswell)
Would it be possible to use a public-api method to pull out the filled in values? I prefer using the API under test to achieve the assertions.
you should do this kind of thing instead

```ruby
class OKComputerController < ApplicationController
  respond_to :text, :json

  def index
    @checker = OKComputer.checker

    respond_with @checker 
  end
```
Same here. CopyinElement.
On 23/05/12 18:20, Phil Sturgeon wrote:
>>   	*/
>>   	public function initialize()
>>   	{
>> -		$this->_ci_classes = array();
> Whats happening here? Accident?

Intentional.  The field does have an initializer, so the question is why 
does initialize() set it again?

Answer: despite the function name and the comment, initialize() was 
intended to be called more than once.  When CodeIgniter.php used the 
404_override route, CI_Controller was created twice, and initialize() 
was called each time.

The second time round, initialize() had to reset the loader's idea of 
which optional classes were loaded.  Because those classes would have 
been assigned to the first controller, and if the second controller 
requests those classes, a new instance needed to be assigned to the 
second controller.

With this commit, CI_Controller is only ever created once.

Alan
Да, похоже на то.
Советуется сразу при создании массива выделять память под столько объектов, сколько в нём будет (если это известно заранее, конечно же).

Вместо

`_DNA = [NSMutableArray array];`

Советую использовать 

`_DNA = [[NSMutableArray alloc] initWithCapacity:MAX_ITEMS];`
или 
`_DNA = [NSMutableArray arrayWithCapacity:MAX_ITEMS];`
Да, всё же, не зря у нас метод возвращает какое-то значение.

Тем более, когда разрабатывается какой-либо класс, или модуль, или фреймворк - допустимо, чтобы ваш класс возвращал какое-то значение, которое программа сможет обработать. Ничего выводить класс, по сути, не должен.
Свойство лучше объявить только для чтения. Иначе есть возможность поменять ДНК в обход метода мутирования.
I pushed some changes to BaseLinter, please use `self.jsc_path()` instead if you need the path. Eliminate this.
Because "I need you more tonight!" ♩
Do you understand why this class exists? :/
the block style with the parameter is not necessary.  This can be written as:
factory: user do
  email
  password "password"
  password_confirmation password
end
need the same here
I am aware, they are doing it wrong.
Make this into a STEPS constant.
For now (especially as the clone is no longer part of the test suite) I will remove this change so we can concentrate on the core Fetch changes.
On 01.12.2012, at 23:04, Eric89GXL <notifications@github.com> wrote:

> In mne/fiff/raw.py:
> 
> > @@ -75,7 +76,12 @@ def __init__(self, fnames, allow_maxshield=False, preload=False,
> >                   verbose=None, proj_active=False):
> >  
> >          if not isinstance(fnames, list):
> > -            fnames = [fnames]
> > +            if not op.isabs(fnames):
> > +                fnames = op.abspath(fnames)
> > +            fnames = [op.abspath(fnames)]
> I think these three lines (79-81) can be more compactly written as:
> 
>             fnames = [op.abspath(fnames)] if not op.isabs(fnames) else [fnames]


but would that work for a list of fnames in which some are abspath and some are not?
> I can add the commit for that if you're okay with the change.
> 
> —
> Reply to this email directly or view it on GitHub.
>
For backward compatibility ok. With the new feature whatever you do --- len(event_id) will never be 0 and event_id will never be None..
I get a couple warnings on the nosetests:

```
spectral.py:79: ComplexWarning: Casting complex values to real discards the imaginary part
  / np.sqrt(psd_xx * psd_yy)

spectral.py:136: RuntimeWarning: invalid value encountered in divide
  self.con_scores[con_idx] = num / denom

spectral.py:167: RuntimeWarning: invalid value encountered in divide
  / (sum_abs_im_csd ** 2 - sum_sq_im_csd)
```

Do you think we should handle these in the code?
Why is the count changing from 2 to 3?
but it's a question whether we want that.
seems like this may need to be more nuanced, depending on the use case.
ok changed :)
Yes, see for example:

- BlackBerry [normalizes return values](https://github.com/apache/incubator-cordova-blackberry-webworks/blob/master/framework/ext/src/org/apache/cordova/accelerometer/Accelerometer.java#L48-L51).
- Windows Phone [has a constant](https://github.com/apache/incubator-cordova-wp7/blob/master/framework/Cordova/Commands/Accelerometer.cs#L78) that is used to [normalize values returned by native](https://github.com/apache/incubator-cordova-wp7/blob/master/framework/Cordova/Commands/Accelerometer.cs#L177-L179).
- Android returns values in m/s^2 by default, so no normalization is necessary on the native side.
- iOS also [has a constant](https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVAccelerometer.m#L36) for [normalization](https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVAccelerometer.m#L103-L105).
Not only this, but the trick I just mentioned on the mailing list to get all solutions to this no longer works:

(your branch)

```py
In [1]: solve(sin(x - 2*pi*n) - cos(x - 2*pi*n), x)
Out[1]: 
⎡π⋅(8⋅n + 1)⎤
⎢───────────⎥
⎣     4     ⎦
```

(master)

```py
In [32]: solve(sin(x - 2*pi*n) - cos(x - 2*pi*n), x)
Out[32]: 
⎡π⋅(8⋅n - 3)  π⋅(8⋅n + 1)⎤
⎢───────────, ───────────⎥
⎣     4            4     ⎦
```

So I am -1 to this as long as we have this regression here.
Nice catch... yes this should be before the empty check
Можно было бы, наверное, `return qHash (fr.get ());`.
intensidad
No estoy seguro, pero creo que entre títulos y entre título y texto debería haber un salto de línea, no?
use .equals instead of ==
Here's an unbalanced parenthesis
Not sure the PyCharm meta files are needed in SCM ;)
Yeah, this and the two other sleeps below are for my own environment. I'll zap them.
Ok deal. I'll do it.
Это нарушает принятый cs afair.
Gotcha.   Just pushed a patch that fixes this.   I wasn't sure where to put the images, exactly.  Maybe they should be in /a/?

On a side note, I can't think of a markup language that I like /less/ than Markdown.  :)
@bp323 fixed
Is `Voyagel` a typo? (if not, apologies for my rusty French!)
With a earlier version of Nakamura and on our old non high available oracle hardware, the inclusion of this line was causing errors when booting nakamura with 11.2.0.3 drivers, hence I commented the line out. However I have re-tested with nakamura 1.4 snapshot on our new high available oracle hardware and this line is no longer preventing nakamura from booting, so I have un-commented that line.
please let #ifdef's start at the beginning of the line
Can't we simply use $.position for this? http://api.jqueryui.com/position/
@jferris What do you think of the new version?

https://github.com/thoughtbot/suspenders/pull/111/files
Checks to see if there are '0' languages (no captions).
shouldn't this be `job.id`?
This could also replace `__wt_config_strcmp`.
Bidirectionality is not used thus it is not handled.
What is plugin?
- Are you sure ``$mockAdapter`` has the correct type as ``object<PHPUnit_Framework_MockObject_MockObject>`` is not a sub-type of ``object<Zend\Db\Adapter\Adapter>``?
- Are you sure ``$mockStatement`` has the correct type as ``object<PHPUnit_Framework_MockObject_MockObject>`` is not a sub-type of ``object<Zend\Db\Adapter\S...mentContainerInterface>``?
Are you sure ``$validator->isValid('A')`` has the correct type as "Boolean" is not a sub-type of "Boolean"?
Should the return type not be "Reader" instead of "AnnotationReader"?
path.join(source, "package.json");
not seeing the reversion
This is pretty long for and anonymous class. Maybe you can refactor it out into a private (static?) class instead?
This is not html standards.
should be <hr/>
Hier ebenfalls, kein SKIP ohne LIMIT, absicht?
Nevermind.  I see.
Not quite sure. I seem to remember `isArray` was problematic in IE, so I looked to [userscore.js](http://documentcloud.github.com/underscore/docs/underscore.html#section-97) to see how they did it.
Parempi ja halvempi tarkistus olisi:
~~~clojure
(not (empty? (filter pred a-seq)))
~~~
Done.
Thanks
Shouldn't we pin the version to a known stable release?
Honestly the whole regex confuses me.

Would 

    \A\/(\\A.*\\z|.{0,3})\/\z

be more concise?
Instead of open -a, it's probably better to alias the command line binary that's embedded in sublime, `alias st='/Applications/Sublime\ Text\ 2.app/Contents/SharedSupport/bin/subl'`
We need some comments on this method works. There is a bit of a state machine here, needs to be documented.
Please use infix notation, i.e. no dots and parens
(You are missing reading documentation. :-) )
Rename `access_token` to `twitter_token`, same for Facebook.
No, just store it in a same way as we store values for other backends.
`if (!$('#email_info').length) {`
`i18n` is probably not needed?
In general I use `buttons` for such `div` because sometimes there are more buttons (like reset button).
This line should be intended one time less.
Translatable string. Check how translation is done in JavaScript.
for future purposes only.
Copy any external files to our static directory. But of course license should be checked. If you want, you can use the icon from jQuery Visage. There is also a close button available.

Anyway, I would design close button differently. So that it is not over the map in the corner, but in the corner of the window itself.
We should to engine.execute from engine.exec
You don't need to specify a view for the 500, django's default is fine. All it needs is the template.
add 33705
magic number^^
How does:
f(x)=-16x+500
x=dist
y=dmg
Sound? :D
Hopefully I got it right this time

On 12/28/12, joschiwald <notifications@github.com> wrote:
>> +        class spell_egg_explosion_SpellScript : public SpellScript
>> +        {
>> +            PrepareSpellScript(spell_egg_explosion_SpellScript);
>> +
>> +            void HandleAfterCast()
>> +            {
>> +                if (Creature* buru =
>> GetCaster()->FindNearestCreature(NPC_BURU, 5.f))
>> +                    buru->AI()->DoAction(ACTION_EXPLODE);
>> +            }
>> +
>> +            void HandleDummyHitTarget(SpellEffIndex /*effIndex*/)
>> +            {
>> +                if (Unit* target = GetHitUnit())
>> +                    GetCaster()->DealDamage(target,
>> GetCaster()->GetDistance(target) == 0 ?
>> +                                            500 :
>> +                                            500 /
>> (GetCaster()->GetDistance(target) / 5));
>
> checking float == 0 is not so good
>
> i think the formula is also bad:
> dist = 0: 500 dmg
> dist = 0.1: 25000 dmg
> dist = 0.5: 5000 dmg
> dist = 1: 2500 dmg
> dist = 2: 1250 dmg
> dist = 5: 500 dmg
> dist = 10: 250 dmg
> dist = 25: 100 dmg
>
> or i'm wrong?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/TrinityCore/TrinityCore/pull/8755/files#r2513192
>
This won't work, since getWhitelistedPlayers() always creates a new List. Anyway, Spout wouldn't know about the change.
Rather than moving these from the api module, this should probably introduce usefully-named encoder/decoder pairs (or factories for same) that are invoked in api to build the default one. The 'api.default_request_encoder' and 'api.default_response_decoder' symbols are part of refreshbooks' API and should be preserved.
It is also worth nothing **that** the Lucene index ...
missing space after OneToMany
'' is default for join, can leave it out if you like
No love for [BaseStoreFunc](https://github.com/kevinweil/elephant-bird/blob/master/pig/src/main/java/com/twitter/elephantbird/pig/store/BaseStoreFunc.java)?
Is this an expensive call?
It would be good if we decoupled the export logic and the restore logic from this command line tool.  This will provide a better api for developers of other front end tools (or any code bit really) that wish to expose backup/restore functionality.  

The Kiji install / uninstall framework does this by having a class KijiInstaller that implements the actual install/uninstall logic, and then command line tools InstallTool and UninstallTool that just call methods on KijiInstaller.
is this function still necessary? /data/local ($WORK_DIR) should be writable without the need for a remount. also, I don't see any "cleanup" happening here :)
We'll do the version bump on release.
we can write this in this way:

In the last case, it would return: `{ :featured => true, :by_degree => "phd" }`.
I think that's half-way what I'm thinking. I mainly just separated this out so _hopefully_ it can be generalized and re-used internally.
Sort the use block alphabetically and without blank lines
Ok we are releasing it with pr2 dashboard so ill probably have to implement
at least some of that.

I haven't really looked at much do you know what other must haves are
missing from robot monitor?  I'm going to show off pr2 dash to folks
tomorrow but the freeze is soon and dirk is out. Could get hectic so any
info you have would be awesome.

Gonna be a fun week.

When are you back in the building again? I bought a bunch of new games and
so did some of the new employees. It is something of a gaming extravaganza
now.
Aaron

On 2012/10/07, at 18:38, Ze'ev Klapow <notifications@github.com> wrote:

In src/robot_dashboard/widgets.py:

>      def _show_console(self):
> -        if not self._console:
> -            self._console = ConsoleWidget(self._proxymodel)
> +        if self._console is None:
> +            self._console = ConsoleWidget(self._proxymodel, True)

Sweet!

There probably should be but robot_monitor is currently way
under-implemented, its missing a lot of features, that being one of them.

—
Reply to this email directly or view it on
GitHub<https://github.com/zklapow/robot_dashboard/pull/9/files#r1781514>.
A notation for these that might be easier for the reader to parse is `Gaussian(flux=1, {sigma, fwhm, half_light_radius})`.  Then either here or before the listing, you can mention what this notation means.
OK guys, I've pushed a fix that raises an exception in this case in frontend.py, but it certainly doesn't solve the more general question of getting a system in place for dealing with this. Something to think about.
Same comment as in the GSObject class definition.
I understand Mike: it's happened a number of times that code having nothing to do with me is reviewed on my pull requests.  It's inevitable given the line-based functionality of diff, I guess.

Rachel makes a good argument for the fluxes not being 50:50.  I that case, I don't really have a clear preference.  Maybe requiring fluxes is best, since if we set flux1=0.75 and flux2=0.25 we have no guarantee that the user will make sigma1 the inner scale...!
>  Happy Mike?

Thank you.  Yes.
Please handle `NameError`s created as a result of missing constants. I would also prefer to use the `:type` rather than the `sport_name` which can be changed from our UI.

In the event of `NameError` just don't set the `@home_team` and `@away_team` for now.
Agreed, will update metadata.  I see this repo as somewhat self contained in it's, as in people won't be pulling cookbooks to often and merging them in other repos.  I like the hard dependency, but could be convinced either way.
It's a pity I didn't look into this myself. I actually would have been able to make this change :P
Is this a real directory, or are we looking for /usr/local/bin/screen and this is a typo?
Better to `return true;` than to `die();` (sounds poetic!). We learnt this lesson with the AJAX endpoints.
the namespace is wrong
Change name to cycleMessages
Yeah I don't think it should. Otherwise the connection could end up being closed twice, or closed too early.
Someone else already has added Skin. This changeset should not include this.
The standard style for methods is `def method(argument, arg2, arg3)`, including the parens. In the interest of getting this merged, I'm going to fix this in a different commit.
See my comment on line 58
So `Target` objects implement a factory-like object and the target object. Isn't that confusing? Can't we have two different things? `TargetFactory` and `Target`?
redeclared var `key`.
There's a case for an integration test as there is a record created in the marketplace database but I don't think it's a priority.
can we add a check to see if we are on the apps page?
I know this is on a different page but we could put this in the review.py file 
It tests the same area
If insert fails catch it and do update?
ops :D i haven't  old code... thanks, fix this
`n_particles` sounds betters, as `n_samples` is usually used for `X.shape[0]`.
After copying, you can do an inplace operation here, to save time and memory.
"in case of classification" should be removed as it is confusing. This estimator is for classification only.
消します＞＜
This doesn't support context or callback.
Right, it was taken from pre-restructuring commit where it was there. Could be moved.
Don't mention dev alpha devices, let's just use BlackBerry for now
-i IP_ADDRESS should be optional as it's only needed for the run command
yes, the constants need to be defined in a cpp.  

it's macro dark magic :)
Ups. One sec
I was actually unsure about the quote string part...
I could clean it up some more.  It is used inside that function as a reference parameter.
Have to be careful here.. another thread could be spilling/updating numCommitted , needs a lock I think.
Not time critical, so may not matter too much reading directory.
But pity this isn't reading a chunk from pipe at a time, instead of per char.
Should this be a throwUnexpected() - indicating that control should never get here - or indeed a pure virtual, rather than an UNIMPLEMENTED (which implies the code is not yet complete, and should really be fixed before I pull it) ?
The release_clobj() is wrong. It should be:

#ifdef AMD_WORKAROUND
        MEM_FREE(inbuffer);
        MEM_FREE(outbuffer);
#else
        HANDLE_CLERROR(clEnqueueUnmapMemObject(queue[ocl_gpu_id], mem_in, inbuffer, 0, NULL, NULL), "Error Unmapping mem in");
        HANDLE_CLERROR(clEnqueueUnmapMemObject(queue[ocl_gpu_id], mem_out, outbuffer, 0, NULL, NULL), "Error Unmapping mem out");
        HANDLE_CLERROR(clFinish(queue[ocl_gpu_id]), "Error releasing memory mappings");
#endif
Is that not the default?
The problem is that this string is also in the title of the page, and that's the only one I can look for for this specific test. Should I look for ``'Query Results</h2>'`` instead to make it "less worse"?
UI only shows 3, 7, 14
Oh I guess that's what min_value is for above :)

I think some other forms in forms.py need this treatment, too.
Why is this a parameterized type?
The last sentence sounds harsh? I'm not the best judge regarding my english level ...
I'm wondering if it is usefull, isn't the first sentence informative enough?
This is the preferred way of changing settings in tests, and the harness resets them after each test. Stubbing config lookups causes problems if part of the code looks up any other settings.
Actually, that seems to be buggy. I was able to log in with a blank password when both password and username were the same, and it seemed to me that the hash function would generate identical hashes for "admin" and "adminadmin".

Also, if you can brute-force salted sha1, then you must have pretty good hardware: http://stackoverflow.com/questions/2772014/is-sha-1-secure-for-password-storage

Personally, I'd rather do without beaker's crypto altogether - it is a sizable amount of code to add to simple projects.

On 30/09/2012, at 16:38, Federico Ceratto <notifications@github.com> wrote:

> In cork/cork.py:
> 
> > @@ -31,7 +31,7 @@
> >  #    (e.g. a key/value database)
> >  
> >  from base64 import b64encode, b64decode
> > -from beaker import crypto
> The original codebase relies on Beaker's PBKDF2 implementation.
> The simple hashing that you are proposing makes the salted passwords vulnerable to brute-force reversing in case they were exposed.
> 
> —
> Reply to this email directly or view it on GitHub.
>
What is this ```for``` loop doing here?
It came by mistake.
remove the d.exists() check, either it exists already (in which case, mkdir(2) will return EEXIST and we don't care) or it doesn't and we're going to create it anyway
these could technically have 'static' appended so they're explicitly file-local... I don't think they will be exported anyway, as we build with hidden symbols, but if you're adding test coverage anyway - just add it when you amend
Just saw that /modules/auxiliary/server/capture/http.rb line 216 has a
basic implementation to deliver a wpad.dat/pac file however the
definition  of myhost and @myport dont make sense  to make it usefull
to redirect to a proxy.

prx = "function FindProxyForURL(url, host) { return 'PROXY
#{mysrc}:#{@myport}'; }"

What is your opinion ? fix http.rb or fix wpad.rb? In my opinion it
will be cleaner to have a wpad.rb.

On Fri, Jun 8, 2012 at 2:37 PM, Efrain Torres <etlownoise@gmail.com> wrote:
> Sorry but what do you mean by wrap?
>
> On Fri, Jun 8, 2012 at 2:24 PM, jlee-r7
> <reply@reply.github.com>
> wrote:
>>> +#   http://metasploit.com/
>>> +##
>>> +
>>> +require 'msf/core'
>>> +
>>> +class Metasploit3 < Msf::Auxiliary
>>> +
>>> +     include Msf::Exploit::Remote::HttpServer::HTML
>>> +     include Msf::Auxiliary::Report
>>> +
>>> +     def initialize(info = {})
>>> +             super(update_info(info,
>>> +                     'Name'        => 'WPAD.dat file server',
>>> +                     'Version'     => '$Revision$',
>>> +                     'Description' => %q{
>>> +                                     This module generates a valid wpad.dat file for WPAD mitm attacks. Usually used in combination with DNS attacks or nbns response spoofing.
>>
>> Wrap, please.
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/rapid7/metasploit-framework/pull/456/files#r953334
user #{peer}, no #{ip} on all the print_* calls, please
If the vulnerability allows you to read files on the system, maybe you can check the file exists before try to overwrite. If it doesn't exist abort execution and warn the user via consola if you can. If the file exists proceed to exploit.
Changing the datasource name to something generic makes sense.  However, we should probably add a line in the README.rdoc to let users know the name of the datasource their applications need to code too.
Sure, adding these explanations in a Notes section (as in numpy documentation standard) seems a very good idea.
Yes, I know that since you indicated that in the VertexDraggingHandler (Lines 35-36). The problem is that even with the select & deselect combo, the glowing never gets updated to the new shape. The original glowing shape always remains. And because of that existing behavior, which I did not change, I disabled the glowing feature. In other words, the select and deselect combo is not working as you are hinting.
Change the name to JavaTestContextTests (TestContext as in "TestContext framework")
Nevermind, wrong context.
If `backgroundDisabledImage` is undefined, and the normal  background image [backgroundImage](Titanium.UI.View.backgroundImage) is set, the normal image is used when this view is disabled.
Shouldn't we fallback to the old signature if the new version doesn't exist?
should be es
thks fixed
y si no lo validamos y dejamos que explote?
It also shows `1x` instead of `x` in the last two hints. @mathiash is working on a configurable expression simplifier to make things easier, so we won't have to work around it with a bunch of `data-if` statements everywhere.

Gonna hold off on merging/deploying until then, but welcome other feedback in the mean time.
largest alignment would prolly be real.
`argv[0] == pathname`
Okay. I changed `codeUnitLimit` so that it's a template.
updated instructions to set the Dartium package root environment var
the indentation is totally off here
Kill this whitespace.
This doesn't look correct to me. exec() only accepts command arguments. To set the environment you need to set ENV after forking.
You're right, thanks. I just merged with the latest Backbone-relational code in master, and pushed a fix to my fork.
a question, we don't we just have a CTOR with string and its content type as parameter?
Esto fortifica lo que digo estás lanzando ParserException en algo que es un Factory que debería crear base a lo que le pases.
I changed this to protected since the `_` indicated it was, I also couldn't find any other instances where it was called other than in the `_execute` of the same class.
On second thought, I may have read your comments incorrectly. Let me re-read this...
This really is just one big conditional -- I changed it from multiple if statements that have the same body.
MINOR: Use of ? operator can be unclear.
What is 'int21' ??
Well, I definitely don't want to make DefaultSearchTermStrategy public unless there is a case where it would be useful for public as a standalone class and so far it was never brought up and its the rule that we use all the time (don't make things public unless public needs it), so all I did is minor refactoring to encapsulate the existing code into a class, so the logic could be changed by providing custom implementation.

As far as moving SearchTermStrategy into 'support' package that might not be such a bad idea. Currently we don't have support package, but may be with this new strategy we have to introduce one. Let's see what other's think about it.
s/~~around~~/when/ (also javadoc for the property).
sobra `en el`
missing Z in Zend
一文なので最後の中括弧はいらないと思います。
def toAscOrDesc(order : SortOrder.Value): AscOrDesc =
  order match {
    ...
why not re-raise respone.statusCode instead of flattening to code 503?
i copied this from DoctrineBundle :)
You can use the Util/BaseConfiguration.h to load this information. Format the language files as simple ini files. This gives a lot more structure to the internationalization and does not introduce any new loading code.
also, it should be of type int, since it will be referencing a PK from the location table.
is this call necessary? What side effects does it have?  I'm not that familiar with imaplib.
I'd rather skip this entirely