labofsahil/github-event-dataset-2012 huggingface dataset:
This looks promising; thank you.
Rebased prior commits
0.5 is no longer provided on travis-ci.org. 0.7 is but after 0.8.0 release, it will be removed. And so on for all future development versions.
would `window = window.top` work? I'm more curious than serious.
@ZachBora

Quoted from Notch's Tumblr:

"But I still struggle some with math [...]"
notify_notification_new with 4 arguments is only available in libnotify < 0.7.
I would prefer us to support the latest version.

If you really want to support both, we have a macro to do so : HAVE_NOTIFY_0_7
I think you spotted the last instance not supporting both :)

You can have a look at one of this files :

carrick/carrick-notification-manager.c
carrick/carrick-service-item.c
panels/devices/src/mpd-storage-device-tile.c
panels/power-icon/src/mpd-power-icon.c
Yup :) Be sure to update the report name too
my proposal adds it to the SPI as that seemed appropriate; I also think other Integrators might find it useful.
I'm all ears for better ideas.
yea, i like this. cleaner.
это должно быть в common changes - так как изменения в ядре и GUI ничего о ней не знает.
Seems alright.
Perhaps we need a whole bunch of specs, somehow.
/me just learned from the great phiggins how HEREDOC actually works.
Cabal has a bug with test blocks containing if/else. This code has to be removed in order for it to work, at least on the version of cabal-install I'm using (and apparent the build server too). I've just been using --ghc-option=-DWITH_POSTGRESQL to get the tests running.
umm... this merge reverted almost all of my weather changes
Oh my god take a break and learn naming conventions that is all.
and thanks for test=)
https://github.com/Havenard/tmpFaceCore/commit/93d199f04382fe3c7f6f08f59fd2ad058568679a

look ths comit.  this is you vmaps problem
Typo in framework/src/play/src/main/resources/messages:
-constraint.email=Email required
+constraint.minLength=Minimum length: {0}
+constraint.maxLength=Maximum lenght: {0}

Maximum "lenght"
Well... ::sigh:: fix soon-ish then?
stupid me: Why not for premium?
Causes a Problem in the Testcases:

Test set: TestSuite
-------------------------------------------------------------------------------
Tests run: 57, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 71.433 sec <<< FAILURE!
testValidation(org.got5.tapestry5.jquery.ValidationTest)  Time elapsed: 5.431 sec  <<< FAILURE!
com.thoughtworks.selenium.Wait$WaitTimedOutException: The Element field not found
        at com.thoughtworks.selenium.Wait.wait(Wait.java:85)
        at com.thoughtworks.selenium.Wait.wait(Wait.java:62)
        at org.got5.tapestry5.jquery.ValidationTest.assertValidationWorking(ValidationTest.java:32)
        at org.got5.tapestry5.jquery.ValidationTest.testValidation(ValidationTest.java:18)
Unsure about the "That wasn't so hard was it?" comment? Maybe end it on "Congrats you have installed _your_ Umbraco site!"?
My read of open_db_and_mkey() is that it will allow kdb5_util to continue if it can't fetch the master key list (though it will flag an error status on exit, which is kind of an odd choice).
Это не то... видимо надо ещё проверку в ` case 0:` на то что мы не кликнули элемент хелпера. Сама функция к хелперу не имеет отношения, это выделение элемента на странице.
I'm having trouble running the tests successfully. This is what I get when I run "rake test" for 1.7.1 on a clean pull, after adding parse_resource.yml with the keys to my empty test Parse project: https://gist.github.com/1658162

I'm guessing something is missing from my local environment.
I get a compile error here - doesn't like the type spec - note sure if this a runtime version issue? I'm stuck on RB14 until I can work out how to shift off SSL to TLS for cluster...
Doesn't the postbox also respawn game object [176360]Postbox Parcel. Does the script do it also?
That's correct as a requirement.
Bei mir gibts dabei aber keine Performancegewinne. Das Problem ist, dass die meisten Aufrufe an send nur einen Parameter beinhalten. Deswegen lohnt es sich vermutlich nicht wirklich. Vielleicht kann ich am Script-"Compiler" noch was drehen um das zu verbessern.
Experimental cure for issue #7
Does the latest state_machine not work on Rails 2?  Sorry, don't mean to be annoying here... just like to stalk forks a little bit.
You're welcome.

On Fri, Jan 13, 2012 at 18:03, Menachem D. Mostowicz <
reply@reply.github.com
> wrote:

> I was thinking more along the lines of: http://xkcd.com/859/
> Will need to go soon, but I'll add the escaping code to all the received
> data tomorrow evening.
> Again, thanks for pointing me to this module.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/rumith/XKCD-Downloader/commit/06686fdfa40858781d605c27ae2d48d4c00e5931#commitcomment-864828
>
If anyone can create a better way to fix the config not loading issue I encountered, please, fork and pull...
Wrong Issue ID
I think you are now rounding up to nearest block multiple when it used to be rounding down...

I would argue that rounding down was more correct.
spawndist`!=0 - copy pste or not ?
Looks like it was just a mistake from 77a75ed365dbe5f640e7d3d3ea2954059cd1cada. Alright, we should be good.
Hi! 
Welcome! )
我也一样，哈哈。

我只是换了一个 theme ，可以在 config.py 里面改，我现在在用的这个是 nature ，还有其他几个可以选，你可以到 sphinx 官网搜索 theme 看看。
Hi, did you have time to do the integration yet?
Do you have any estimate for a CPAN release of 0.21?
is rtloverride a mark non spacing character? If yes, then the special check should be removed.

Also, instead of the inefficient multiple replace i like something like that better:

```QString result = s;
int y = -1;

for (int x = 0; x < s.size(); x++) {
    if (s[x].category() != QChar::Mark_NonSpacing && s[x] != rtloverride) {
      if (y==-1) {
        continue;
      } else {
        y++;
        result[y] = x;
      }
    } else {
      y = x;
    }
}

if (y != -1) {
  result.resize(y);
}```

This is a lot more efficient as you go through the string only once in every case (instead of twice at the minimum but a lot more if needing a replace)
In that case I would remove the constants / seed data.  or just delete with SQL or in the rails console.  Having this in the admin area can lead to big mistakes.
i think you got me wrong, the commit was perfectly fine except for the wrong physical address. Instead of reverting the commit, you should have changed the added the following
#if defined(CONFIG_ARCH_QSD8X50) && defined(CONFIG_MACH_HTCLEO)
#define PHYS_OFFSET    UL(0x11800000)
#define RESET_VECTOR    UL(0x00000000)
(#else or #endif or #elif depending on where you place this)
What? This method is now a bit more unreadable and always returns nil :)
Glömde kommatecken efter
'database'  => 'te-12-adam'
'username'  => 'te-12-adam'
It hasn't been worked on for a long time.
Thanks Steve, I'll check it now.

On 2/14/2012 1:15 PM, Stephen Kostas wrote:
> @jhinkey - Fixed all of these issues. You can double check and we should be good to go.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/stephenkostas/liferay-docs/commit/e8be3686f4dd32c33ed7d3e10fe5b1a8844a0c67#commitcomment-965773
Yep, that will work :)
You forgot to remove an nVidia on this line.
Hmmm... I'll try that.
On Feb 19, 2012 6:05 PM, "psyke83" <
reply@reply.github.com>
wrote:

> Guys,
>
> Have you tried building the entire kernel with ENABLE_BCM_4329=true? It's
> there in the Makefile and I always build with this option via the
> command-line (ENABLE_BCM_4329=true make -j4).
>
> I rebuilt the kernel without this enabled, and my wifi driver is no longer
> initializing. It may be a coincidence, but it's worth a try.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/psyke83/kernel_huawei_u8160/commit/3fddb39af1e6fc677f32a8cb73f9c0dde70183ce#commitcomment-982598
>
Probably, we can run a sed script for that.
Shouldn't you be committing the editor you just obtained?
Why remove this line? removing the local, while being used below, will generate a global?
@adam3smith, we have quite a few harvard-(some university name) styles. Do we have any preference on what format to settle on?

harvard-university-of-wolverhampton.csl or university-of-wolverhampton-harvard.csl ? The former is currently more common.
Looks like this validation will allow a the username to also be empty. Because we aren't checking to see if there aren't some characters.
Код очень хороший. Весьма Pythonic.
=)

On Thu, Feb 23, 2012 at 10:23 AM, Jonathan Cardoso Silva <
reply@reply.github.com
> wrote:

> Na verdade, da seo 2.1. Estava com problemas no meu git
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/mhartl/rails_tutorial_translation/commit/1fbd434e6b72cced64acbf19ea0d57d2d24b5308#commitcomment-1002125
>
Yes, except that you don't have to execute "git add ."

On Sun, Jan 15, 2012 at 16:46, Menachem D. Mostowicz <
reply@reply.github.com
> wrote:

> So basically, this allows me to select which edits to commit? And
> therefore, executing
> ``` git add -p # some edits
>    git commit
>    git add .
>    git commit
> ```
> will give me two commits, one with those edits I selected in the ```git
> add -p``` and the other with the other edits?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/InvisibleEngineer/XKCD-Downloader/commit/cc821d27bbf8ce02c913a44651220b17fd9eef9c#commitcomment-868519
>
Pokemon catching again
Change tag to @PB10+ if next playbook OS supports this method.
@afriggeri : You probably know more than me, but

1. Whats the point of putting things in a do block, since everything is in function I am not leaking variables to global namespace?
2. $("tr:even", this) why is this more idiomatic than $("tr:even", @)

Thanks for the patch.
Does it need to be 'final ArrayList' or would it do to just say 'final List' ?
We're specifically after a single and empty (no ef or efv) condition - I thought the original name reflected that requirement better, no?
Should the type be an enumeration ?
Yeah, yeah, I know the theory. Well don't extend it :-)

Anyway, I'll make another pull req to address all the nitpicking to make everyone happy. After all - easy coop dev billable time :-)

Sent from my iPhone

On Jul 17, 2012, at 23:37, Misagh Moayyed<reply@reply.github.com> wrote:

>> +
>> +import javax.validation.constraints.NotNull;
>> +
>> +/**
>> + * Performs a basic check if an authentication request for a provided service is authorized to proceed
>> + * based on the registered services registry configuration (or lack thereof)
>> + *
>> + * @author Dmitriy Kopylenko
>> + * @since 3.5.1
>> + */
>> +public class ServiceAuthorizationCheck extends AbstractAction {
>> +
>> +    @NotNull
>> +    private final ServicesManager servicesManager;
>> +
>> +    private static final Logger logger = LoggerFactory.getLogger(ServiceAuthorizationCheck.class);
> 
> Since the class is not marked final, any child classes that extend it would get the `ServiceAuthorizationCheck.class` logger instance as opposed to the `this` instance.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Jasig/cas/pull/88/files#r1185122
you mean:

kernel_code = """ void foo(...) {} void bar(...) {}"""
foo_kernel = Kernel(name='foo', code=kernel_code)
bar_kernel = Kernel(name='bar', code=kernel_code)

?

I'm not sure that's something we even want to support
not currently, no. same goes for ActorKilled and IllegalActorState. I’m leaning towards removing those causes as well.
implement `private void writeObject(java.io.ObjectOutputStream out) throws IOException`, which tries `out.defaultWriteObject` and substitutes the exception by null if that fails
move to src/test
Might want to clarify which headers override which.
this is never shutdown
this match is unrelated to the action
Until we have something better.
I really can't remove the `start` methods since I need to start the cell separate from creation/init in the normal case, see `Children.scala` line 195, right after `initChild` (which is not this `init`, but is related to the child container). The path to this constructor call is a couple of lines higher up.

Maybe just a constructor argument `_cellShouldStart` with default value `false`, that can be overridden in TestActorRef, is nicer.
It is a bit contrary to your previous DRY comment though ;-)
My intention was simply to return the simplest thing, indicating no exception was thrown.  We can refine as needed....

On Jul 31, 2012, at 6:59 AM, Matthew Rocklin wrote:

>> @@ -79,10 +79,17 @@
>>                              :subject "added some functionality"
>>                              :timestamp 1341594990
>>                              :body "added function fn to file.clj"})))
>> -                           
>> +
>> +(defn ^{:doc "Test DB functionality and raise exception if something breaks"}
>> +  db-tests []
>> +  (sql/with-connection DB_URL
>> +    (println (table-names))))
>> +
>> +(expect (db-tests) nil)
> 
> Returns nil because of the println? Why use expect here?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hits/hits/pull/13/files#r1272187
this name could possibly be improved: axis_index?
Btw. when we go for a special page for subscription searches then this should be an issue anymore, because we'll look up for name/id there.
I agree. However the UX should be preserved as is as it gives the user the ability to first search and then, when necessary, subscribe to it.

Maybe we can split this method into two separate private methods.

search
 - _search
 - _search_subscription

where _search performs the regular search
and _search_subscription performs the update when necessary and then modify the search results in order to have them the right way

Two separate views aren't really satisfying as the user might get confused which view is what.

Limitation to 50 and always ordering by modified_date is due to the face that users in case of a subscription want to see currently modified items only and a limit to 50 due to performance and storage issues.
This one is certainly not required. I can remove the commit adding some logging to CGUIDialogMediaFilter but if the filter dialog doesn't open/work for someone there's no other way to know why.
Hold off a few days. Let me have a look when I get access to a computer.
blog-grid?
That is, you should be calling set.
I know there's a timesleep parameter, but I didn't know if the intention was to actually sleep _before_ making the request, or if it was originally intended as the timeout interval for `_cluster/health`. So, I left it like it was, and just added this parameter. I imagine `timesleep` and `timeout` will be merged, though.
I would use zip(arg_types, fn_arg_types) instead of enumerate for clarity.
trying not to change pip internals for pip wheel.
don't think we should have this ignore in here at all?
Please, add a 'return false'.
i think the older versions are not supported. for example,  phpbrew itself would be broken if  we switch to php-5.2.x. in that case it hard to switch the version back by phpbrew.

it's better to explicitly declare to use not supported version. it's a feature for advanced user.

or simply allow install all possible version but add a warning message before switching to old one
This might be clearer as `{# template.html will have access to the variables from the current context and the additional ones provided. #}`.
I don't see this one being used either.
Alright, but I've only added the simpler ones >_> Sure, a few of them could be removed, but ones like `Standard`, `Minimal`, or `Inline` make sense to keep around...
this must be a mistake/oversight. I will fix it up.
The PR itself LGTM but I suggest using GetEnvironmentVariableW() and converting the result to UTF-8 with WideCharToMultiByte().

Calling the non-suffixed version of GetEnvironmentVariable means you get either the ANSI or the wide character version, depending on whether or not UNICODE or _UNICODE is defined.
In compiler has not check for only create() method.
No don't worry about being picky it drives me crazy when people don't follow codding standards :).
Add a short comment stating the invariant these satisfy: NULL means no tracer set, None also means no tracer set, anything else is a Python callable.

Though, that makes it clear that the current invariant is unnecessarily complicated. Can we remove the None case, so these are always NULL or callable?

It'd also be nice to explicitly initialize these to 0, even though this is not required by C99.
No need to create an instance here. Just change the `xtype` to "gxp_editorgrid". See below why.

And don't forget to add a dependency to `plugins/FeatureEditorGrid` at the top of the file!
Check out Andrew's photos on Facebook.

If you sign up for Facebook, you'll be able to stay connected with friends by seeing their photos and videos, staying up to date with their latest status updates, exchanging messages and more.

Join Andrew on Facebook
http://www.facebook.com/p.php?i=100004081283072&k=AQBSNwkYGPZS-BSUkslzNKlzauXrBNqJtGk10hst-tJwubw_kTBC_UwUffSjqLz4hcDYNXW0UisGz1YHm25IOX81rT0&r&app_id=350685531728

Already have an account? Add this email address to your account:
http://www.facebook.com/merge_accounts.php?e=reply%2Bp-1211597-be5808b6d9de4c6c74ad8b8af74fe2331af164da-579774%40reply.github.com&c=AQCMU50L1RA2RkbP-xm9YTSL-3S_SypoSLsUwjwgl6yPxQ&source=unknown

=======================================
This message was sent to reply@reply.github.com. If you don't want to receive these emails from Facebook in the future, please follow the link below to unsubscribe.
http://www.facebook.com/o.php?k=AS1F22KQ-wsT8dao&e=reply%2Bp-1211597-be5808b6d9de4c6c74ad8b8af74fe2331af164da-579774%40reply.github.com&mid=HMTEwMTI0NjQ0OnJlcGx5K3AtMTIxMTU5Ny1iZTU4MDhiNmQ5ZGU0YzZjNzRhZDhiOGFmNzRmZTIzMzFhZjE2NGRhLTU3OTc3NEByZXBseS5naXRodWIuY29tOjg
 Facebook, Inc. Attention: Department 415 P.O Box 10005 Palo Alto CA 94303
Couldn't you make it cache the strlen result so it does not have to compute the string length twice? I don't know how strlen is computed, but I just figured it would be good practice.
Стайлгайд уже даже не рекомендует, а требует стиль комментариев ///
больше 120 символов
не убедил. надо разобраться, почему его пришлось убрать, потому что я точно помню, зачем его поставили
I Agreed. 
I updated the PR. I like the new version :-)
@pixeltrix ah, that makes sense.  Seems like we could just change this implementation to use `strftime('%s').to_f` (unless there's a perf diff or something)?.
Can you use `to_a.first` in these cases?
Isn't a per-controller config, is a global setting for all controllers. This was added to be used in protected_attributes plugin and it's used just to bypass strong_parameters protection marking everything as permitted.
What does this method name mean? "changeSymbolOwnerIfCorrect", as in change the symbol owner if it's correct to do so? I am crossing my fingers there isn't a method somewhere called "changeSymbolOwnerAtRandom"...

Less wittily, I suggest a name which captures what it is that correctness entails in this case, rather than the general concept of correctness.  Perhaps "changeOwnerOfNestedReturn" (we know it's a symbol owner we're changing - it takes a symbol parameter - that it is a symbol need not be restated.) Or if we want to communicate that we are only changing the owner if it needs changing, "verifyOwnerOfNestedReturn."
True, I got misled by the file the comment belongs to. Then take a look at how implementation restriction errors are raised in the reifier and add another one. Or if you're up to fixing the problems, that'd be even better :)
Removing call to `Order#update!` here because it is already called when the adjustment is created via an `after_save` call back in the adjustment.
Let's see if the new commit passes.
Did you intend to delete this file?
og -> log
let's change the 100 to 200 and delete the 77/3 test.
you used goog.style.showElement previously. why directly setting display to block now?
should be `$this->processConditions(array('AND', $this->_query['where'], $conditions));`.
The order does matter here. Similar for `orWhere()`.
So of course this kind of DOM traversal totally works, but I sometimes fear it can be a bit brittle.  If the next guy comes along and changes the dom structure for appearance sake only, it is possible that this code will break. 

What I normally recommend in a situation like this is giving the elements you are interested in unique IDs.  Normally the ID is something like "ac_partial_#{some unique number here, e.g. the ID of the AC or a counter you keep in the page}".  Then you can just target those fields directly instead of using the relative DOM traversal approach.  Is something like that doable here?

I also realized why the names of these methods were confusing me -- I was thinking "partial" as in a rails partial. 

I know in your comment you said you couldn't use ````hide();````.  Are you sure?  Why can't the right and wrong radio buttons just have an onclick of ````$("#ac_partial_4").hide();````?  Similar for the enablePartial.

For the changePartial call, if the partial radio button has a unique ID, you can just target it directly too.
>> set(fieldToLimit, limitValue)
?
Is this MySQL config just used for your own testing purposes?
Given the new layout of the `DIFFS` table (the PK is now just the `seq_id` column and the link back to a pair and its containing space is via the `EXTENTS` indirection), is this comment still valid? Also, is the `space` reference still valid in this context, or does it make no difference?
Another nit, usually comments are full sentences with period.
Nice trick, thnx ;)
This comment block is informative for this pull request, but doesn't need to live on in the code. Please delete.
You probably want `$disallowed[$attach['extension']] = $attach['extension'];`
What happens if cache is cleared and the next page requested is in acp?
As per IRC: the anonymous check should be removed.
p is for debugging
Affected AssetDisplayObjects overwrite `destroy()` and remove the reference.
perhaps we could migrate ycb etc. into an npm module so we avoid these kinds of things? a todo here might be nice to remind us to come back and clean this up
This seems like a nice reusable "initCtx" routine that could be leveraged to mock contexts etc. Maybe we can extract it?
Есть таблица статистики unit_name, shows, clicks, date - в неё пишет нода. Все. Больше ничего связанного со статистикой нет
It's not good to have copied code in our tests... Some reasons: 1) Copied code is bad... For example, what if src code gets updated but test code doesn't? 2) We want to test against the real application environment, so non-ideal to have a "fake" test environment.

Is it possible to use symlinks in the /test/ directory to point to the real i18n files in the /src/ directory ? (bundle.js, model/property.js, reader/property.js) other possible workarounds?
Okay, I'll update the PR with the capability to copy a PPField.
"sparse" -> "sparse matrices"
Other thoughts:
I try to put the corresponding .h for a .cpp first to prove that it is self-contained and includes everything it needs, so that I can include it anywhere else without worrying about prerequisite headers.

I try to put the system headers last in case there are any .h files that don't have a corresponding .cpp file looking out for them in this way.

I've been coding this way since C++ learned enough tricks (templates, namespaces) to avoid most of the objectionable uses of #define that had the greatest potential for system header symbol corruption. I still now and then see complaints from deep within system headers -- usually from something really stupid that header rearrangement won't completely fix just move the symptom -- like forgetting to terminate a block in a header. 
I guess I'm willing to trade this for the better enforcement of self-contained headers -- if there is an undefined due to a missing include, the include goes in the file where the undefined occurs, in a position that consciously tries not to cover for other headers, resulting in a general ordering of headers from most likely dependent local headers to most likely independent global headers.

I've read online opinions on this that run both ways and various twisty ways down the middle of the road.
Asset.objects.filter(query)
Returning empty list may be better
That's because it's gibberish. :)

I've cleaned it up in b1ea6addc9
The value generated by the """ '%s_refs_%s_%x' % ... """ expression is used, as is, as a name in an SQL statement. If it goes over 30, nothing will stop it (except an Oracle "Invalid Identifer" or some such).
I'm fine with that - kill away. Let's just add a release note about it since it's theoretically backwards-incompatible (albeit in an incredibly minor way.)
Why the fudge bump? IIRC I ran into test problems with our current suite on Fudge 1.0.x (i.e. an API change in 1.0 broke us). I have not verified that in a while though, just that 0.9.x works fine.
you have an incorrect comment terminator here
I don't know if this still applies, but I had to encapsulate the entries with `"` characters.
Simplest and probably fastest way around this would be to move all your code that needs gevent to a new module, and then be very careful about which thread you import that module from. Doing it this way you won't have to do non-global imports for most of your code.
Nit: We use single quotes for string delimiters.
Shouldn't this be `rabbitmq-env.conf`?

Also, would it make sense to add `NODE_IP_ADDRESS=127.0.0.1` and `NODENAME=rabbit@localhost@`? The former makes it listen only on localhost, and the latter protects you against hostname change issues. But those settings probably only make sense for isolated, single machine usage.
Do I need to do something different to get my formula into Homebrew-alt?
Why is here __declspec(dllexport) and not VLCQT_EXPORT? Typo?
I would at a link to the online documentation, makes this more useful for git versions
C'est l'accés de l'user pour leimz. Si tu veux on peut laisser
So this is actually kind of weird because the feed description is stored in entry_description.  This is for the "metadata description", which i'm not sure if we even support at all right now.  As far as I can tell, it's always blank for all items.  I thought of just removing that column, but I could see us using it in the future if we could get descriptions from ID3 tags or something like that.

The only way that I could see to get a blank description is if you opened the item edit dialog and put nothing in there.  That might be a separate bug actually, since I think we should use NULL for that as well.
Why `outline` and not `border`? Both appear to have similar effects on the extraneous box.
I know this are some crazy macros... but the code was repeated over and over and over.... The problem is that if we want to not block for the dbus call we need to use watches.
Trimmed in 8c63a915e (though should have been separate commit).
Since SOSA there is almost no situation where we have maneuver-only loads that get checked by starcheck.  NSM recovery doesn't use starcheck.  But in any case with starcheck screaming for each obsid that the 3-star rule was not checked, even the sleepiest ACA reviewer would count the bright stars.
These function names ( subtract_from_xyz and add_to_xyz ) annoy me :) We do not add or subtract any data, just grow/shrink the data buffer (as described in comments)
How about replacing add_to_front/back with grow_front/back or expand_front/back?
and replacing subtract_from_front/back with shrink_from_front/back or reduce_from_front/back?
What do you think?
Cool solution, take a library that does the separation well and just use it!
This feels like a weird linebreak.
I think the suggestion was to remove the constructor taking a `long` value. Keep the original `int` constructor for compatibility and add the `long` + `TimeUnit` constructor.
Not sure why 2 services would be turned off by adding strava. Maybe a merge issues or a remnant of an partially configured local dev environment.
None of this should be part of the pull request :)
The ctor arguments above imply commandFn isn't optional, and register() below throws if it's null, so is this check unneeded?
I actually couldn't get it to work if I put double-quotes around the filename with the ~ in it--it might be because double-quotes defeat tilde substitution?
Could these go inside the forEach() function?  Better to be more narrowly scoped when possible.
Good catch, It is not necessary anymore, I just tested it.
Don't we need to serialize the attribute name too?
Agree, that makes more sense.
Heh.  I've run resque with 15,000 concurrent workers in the past (managed to cut that down substantially), so I try to keep an eye out for anything that might create for bad debugging situations.
So the HQFormData model data is going to be all available in ES via the XFormES index. You can paginate your resultset  (though it just moves the memory burden to ES) as you iterate through them. All meta block info is correctly indexed by the respective types.

Right now we're storing all the form data (for better or for worse) so the json for the entire xform will be made available as well (but you can cherry pick the relevant info you want).

I'll also be testing out the streaming response on staging shortly to see if it's viable with our existing infrastructure.
I find this surprising, I would have expected the function to return False if the insurance boundaries are not defined
Looks perfect! :heart:
how will this fine the libs it uses as above it sets the LD_LIBRARY_PATH to `pwd`/install/lib
Use full path imports (or relative/absolute imports). Not this.
Don't remove translation here. ;-)

Check how it is done on [homepage](http://dev.wlan-si.net/browser/homepage).
Not sure what to do here. Changed all these variables to False and added #TODO: comments.
```
js> Date.now() === Date.now()
true
```
The problem is that Dates are only ms accurate, so you can collide.  Won't happen often, but with lots of users it might.  I was just adding some noise to the name.
The logic here is wrong.  In all code paths, you call finish, so move it down below the try/catch block, and don't bother calling it inside try/catch.  Change this if check to check if obj does exist, and if so, do the block at 326:

```javascript
if ( obj && butter.config.value( "recover" ) !== "purge" ) {
  p = new Project( butter );
  p.import( obj );
}
```
Same question as above here. Why do you need `order` _and_ `zindex`?
This is a bit gross. How does this profile? Might be a useful time to file a new ticket to make this algorithm much better.
I don't think we actually want that space padding before the arguments brackets.
Jepp, seh ich auch so. Am besten noch urlencode() testen.
Windows has an environment variable 'os', so we check if that variable exists and then check if it startswith Windows.
It should be 'dso_tool', in its singular form.
Fixed in 	48e2efe
I did add line 474. The problem that occurs if you do not do that check is you skip over blank lines which is incorrect. Please see [this commit](https://github.com/dojoteef/XVim/commit/9272c33a9ea2a474187d57da9f72dac3c52cfe77)
What is purpose of these empty docstrings? Can you put there documentation text there? And to class as well?
Our general convention is to not create any new global object namespaces but instead attach them to our singular namespace - KT.  i.e. `KT.noticeArray`
A comment or a const will help to understand why this is set to 1100.
Secify the name of the configuration option here.
This is a somewhat non-standard abbreviation.  Maybe this should just be `multiprocessing`?
I think you want backticks around the `h5py` objects here.  And if you add http://h5py.alfven.org/docs-2.0/ to the intersphinx inventory (in the docs ``conf.py``) it will link to the relevant doc pages.
Can you clarify in the description here that changing this at run-time does *not* change the "current" cosmology, and that this option only affects the default at first import?
I would mention here what algorithm is used, so people know if it's exact or approximate.
还是想更灵活。
如果如果要实现category/children方法中把name为空的过滤掉。
或者是feedback的某个connnection里两个status，status:{1,2}，等等。
就是觉得只有等于用起来的时候还是太少了。

ps. github的comment太搓了，写完之后不小心点到了close form。。。。啊啊啊啊。。。
除了等号，还有冒号，官方两种用法都支持。

Attributes

Jade currently supports '(' and ')' as attribute delimiters.

```a(href='/login', title='View login page') Login```
Alternatively we may use the colon to separate pairs:

```a(href: '/login', title: 'View login page') Login```
Or just add a simple flag to say, dont try again if you fail here...
"psz" prefix means pointer-to-string-terminated-with-zero.
Should be strName if we want to keep using type prefixes...
darn - the original test file already contained those. it is a tab afaik. I thought I fixed em all.
I'm not seeing anything in the new GeoExt-based translations for this one.
Yes it runs for every request. It's shortcircuited if fed auth is not enabled. 

https://github.com/davidfowl/JabbR/pull/525/files#L3L-1
Thanks for your feedback! Shouldn't catch the "except" below the exception from keepass too?

The config flag is a good idea - I try to add this.
"notebook will be larger, but the image will still be present offline."
Maybe print a message here with just the exception in case a stale process fails to clean up?  That way the user may know there's something worth looking at manually.
Could you import it from IPython.external ? 
otherwise it fails on python 2.6
Do you want to add a note here that explains that this var only exists in 0.11-0.13?  I believe it was added as a rename in the Great Reorganization of 0.11, but as described in #1167, the complexity and confusion is probably not worth whatever aesthetic improvement may have been achieved.
I don't think so, at least not unless there is a bug in IPython or pagedown's code.
I'd prefer to spread the try/except out onto 4 lines so that it's obvious that an exception is being caught.
I removed the wrong location, meant to remove it in the live scrubber
`Gemfile`に依存かかかんくてもだいじょうぶですか?
I have taken this from gaia (written by asuth)
`git_revwalk_next()` can return that there was an error or that we ran out of commits in the history. If either of those things happen, we jump out of the loop, because we don't want to send anything else. If the error was `GIT_EREVWALKOVER`, it's not really an error and we set `error` to zero just after the loop.
from `man git-config`:
```
The default is true, except git-clone(1) or git-init(1) will probe and set core.symlinks false if appropriate when the repository is created.
```
So, the `*can_symlink = 0;` below is wrong; But since we might have come here from a `clone`-operation: Maybe we should probe it here unconditionally?
I guess it's alright in this case as it doesn't alter user data or anything, but we should really open a bug about the lack of CSRF.
This should probably be set after testing that a mail has been sent.
A comment explaining this block would be lovely.
Nitpicks on import: can you alphabetize them?
to link to another page? yes you do. URL reversal > hard-coded URLs.
Yeah, exactly. And it was messy doing it outside of the loop.
All I did was fix the line-length problem here. pyflakes kept flagging it.
I like your way of thinking, to encapsulate this into another part of the framework, but I think this might be overkill. Especially if the only components using this are PhaseAction and PhaseBinding. Thoughts?
The intention of bubbling up the deleted checksums was to separate S3/Bookshelf related operations (nuking the actual files) from the database operations (nuking our /knowledge/ of the files).  @schisamo and I talked about it, and this seemed like the most logical place to coordinate those activities.
why injecting an entity manager when all you use is the DBAL connection ? You are adding a dependency to the ORM only to **access** DBAL
why duplicating the assertion ?
@cordoval the UPGRADE file is about documenting BC breaks. Nothing else.
Yes. I preferred to keep it protected in order to not pollute the public interface of non-BC classes.
please use an event listener class instead of a closure
I added this to the UPGRADE file nw.
you should remove the line :

```
     * @return Boolean true if the directory has been created, false otherwise
I was thinking about making the same remark...
Good feature!
should be renamed to number of buckets or smth?
the cancelling logic isn't required if UserProfileViewController isn't being cached
is it retired to import?
Unclear where `owner_name` variable is used.
The > selector selects only direct children. The reason I used it is to make sure that the rule doesn't apply if the same class is used further down the hierarchy.
I think Dan's paste has a bunch of extraneous things. Here's what I think is a stripped-down version with just the GC code:

```ruby
config.before(:each) do
  GC.disable
end

last_gc_run = Time.now

config.after(:each) do
  if time_to_run_gc?
    GC.enable
    GC.start
    last_gc_run = Time.now
  end
end

def time_to_run_gc?
  Time.now - last_gc_run > 1.0
end
```

I like the  non-randomized version because it makes it easy to track down what went wrong if you get a weird error. Same reason we don't use Faker in factories (`user1@example.com` over `["adarsh@thoughtbot.com", "gabe@google.com", "blake_thompson@example.com"].sample`)
add ` | home`
For this functor and the next ones, shouldn't f be declared a member of the class, so as to avoid instanciation at each call to operator() ?
Fair enough, though in practice the code won't be fixed until it actually breaks ;)
I think ``logger`` will be undefined?

Separately, this could be rewritten as:
```
def initialize(client = ZendeskClient.get_client(logger))
  @client = client
```
though code of that form tends to confuse syntax highlighters, so maybe it's not worth it :)
link breaks don't work for wiki links. Should be `[[Usage and Billing Data]]`
I commented this because it is the right way to... comment.  This was "stringed" for a reason I ignore.  And since I think it is OK to perform a `.all()` on a PublisherManager (to be able to do `Page.objects.all()` for example), removing them may be the best thing to do.  I will update this pull request if you agree.
So based on our conversation, I think you can drop the "!$album ||" part and leave the rest.
Okay, sounds good!

One other minor note: this function is subtly different from Item_Model::scale_dimensions in that it uses ceil instead of int.  I found in testing that this exactly mimics the behavior of Flowplayer, and that using round or floor could result in a 1 pixel size mismatch.
i see, i moved all the buttons to be next to their progressbars to save more space on the top line
I'm not clear on the conclusion of this discussion. My impression is using @OverProtocol will remove the need for a separate maven module? If so can this patch be converted to that approach?

BTW, Bartosz, you are a very patient guy, putting up with us. ;)
You need to reverse these two lines, the deployment can have already started here.
Sorry, I wasn't clear. What I meant was, you don't need to set the Dependencies manifest header in the MANIFEST.MF file. It's just a minor comment by the way. I won't hold up the merge because of that.
I think it is better to use ServiceName here?
What is the earliest version of python is pkg_resources available in? Having some trouble googling to find this.
Why are we using an anchor here? Can it be a `<button>` or even just a `<span>`?
Don't use a cast. Use:

    assert rval.dtype == grad.dtype

and if the assert fails, figure out what changed the dtype and fix it. Using the cast at the end will make stuff bounce onto CPU and then go back to the GPU after the cast.
I'm a bit scared that you need to access private members. If someone decide to rename them (because they are supposed to be private) then your tests will break.
Try to use 'value' attribute of checkbox for retrieving this data
What about alphabetical order for the system message name?
font-size: 0 ?
Now we have "placeholder" design when there is no call log.
window.clearTimeout(this.geolocationTimer);
      
      var icon = this.icons.geolocation;
      icon.dataset.active = this.geolocationActive;

      if (this.geolocationActive) {
        icon.hidden = false;
      } else {
        this.geolocationTimer = window.setTimeout(self) {
          icon.hidden = true;
        }, this.ACTIVE_INDICATOR_TIMEOUT);
      }
On 21/08/2012 22:01, Eitan Isaacson wrote:
>
> In apps/system/js/accessibility.js:
>
> > @@ -10,3 +10,10 @@ SettingsListener.observe('accessibility.invert', false, function(value) {
> >    else
> >      screen.classList.remove('accessibility-invert');
> >  });
> > +
> > +SettingsListener.observe('accessibility.screenreader', false, function(value) {
> > +  var event = document.createEvent('CustomEvent');
> > +  event.initCustomEvent('mozContentEvent', true, true,
> > +                        {type: 'accessibility-screenreader', enabled: value});
> > +  window.dispatchEvent(event);
> > +});
>
> Chrome JS listens for this event, and activated or deactivates the 
> screen reader.
> http://mxr.mozilla.org/mozilla-central/source/accessible/src/jsat/AccessFu.jsm#223
>

Instead of using mozContentEvent, why don't you simply observe the 
mozSetting value it self in accessible/src/jsat/AccessFu.jsm#223 
<http://mxr.mozilla.org/mozilla-central/source/accessible/src/jsat/AccessFu.jsm#223> 
?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/mozilla-b2g/gaia/pull/3657/files#r1428780>.
>
And rather than look at the DOM (via theCardInstance.domNode), I'd iterate over theCardInstance.foldersSlice.items.  It's slighty cleaner.
use indexOf instead of a regex here (huge performance difference).

Ideally we would not have this specific week-events case in the base class but I am ok with it for now.
This comment is not really accurate not that we will listen for recording-events too
In fact I am updating dialer.en-US.properties to take it as the reference i18n file ;-)
Actually, the last value defined wins I think.
Not directly related to this bug but I have noticed that this code is cancelled as soon it is done because the lockscreen fire an unwanted panelchange that set back this to 60.
I was probably looking for a magical .getOwnProperties ;)
Why must this be a component? The ``uuid`` module is standard and comes with Python, and I think it's an advantage that you know which implementation you get. If you think it's necessary with a helper function to get a ``UUID`` object from a content object, then put ``uuid_object`` simply in a helper module (or view).
Muze byt ten uhel zaporny?
Why not go one step further and remove the "EnsureSuccessStatus", we can check if it is success status (IsSuccessStatus instead) and if not we throw the same HttpUnsuccessfulRequestException with the right parameters, this way we know if we failed because we got a 404, 409, 500, ...
Yea that makes sense, but then I'd have to have a nested try catch around that delete just incase it threw. So something like:

    using (new FileStream(_path, FileMode.Open, FileAccess.Write, FileShare.None))
    {
       // Nobody is here
       try { File.Delete(_path) } catch { }
       return false;
    }
This couples the persist layer, and I think what was meant here is closer to this

    persist_mode = config.persist_mode
    db = ProjectRazor::Persist.new(persist_mode)
    db.connect(config.persist_host, config.persist_port, config.persist_timeout)

Looking at the original code in persist/controller.rb it appears to have the same issue as well.
include the max number of elements in the error?
agree -- e.g. change this to

     `git push origin fix-typo-in-slides` (if your branch is named "fix-typo-in-slides")
Document the direction argument.
shouldn't need to be a block.
If this is a command method you could just have this be the last statement in the method rather than using a bare `klass`.
This is to avoid a disconnect with low bandwidth (for example a simulated speed of 8 KiB/s or possibly as high as 32 KiB/s or higher) because `RTMP_PACKET_TYPE_BYTES_READ_REPORT` is sent too infrequently.

`RTMP_READ_REPORT_THRESHOLD` is an arbitrary value high enough to fit the handshake so that a `RTMP_PACKET_TYPE_BYTES_READ_REPORT` is not sent too early and interrupt the connection establishment.
shouldn't that be in an environment variable stored locally?
Use line breaks here please
should we hoist this to the top?
Don't set `isName` to 0 or 1 - just use a bool.
We want people to give issues from a production system and hence there is a link.
Done.

On Fri, Jul 20, 2012 at 6:38 PM, aaronsw <
reply@reply.github.com
> wrote:

> > @@ -250,9 +250,8 @@ def close(self):
> >          self.o('', 0, 'end')
> >
> >          self.outtext = self.outtext.join(self.outtextlist)
> > -
> > -        if self.google_doc:
> > -            self.outtext = self.outtext.replace('&nbsp_place_holder;',
> ' ');
> > +        nbsp = unichr(name2cp('nbsp')) if self.unicode_snob else u' '
>
> Would you mind converting this to a normal if/else block so we can
> preserve our backward-compatibility with old Python versions?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/aaronsw/html2text/pull/43/files#r1205752
>
Could this just be `selectWordAt: operation(selectWordAt)`? (The arguments get passed through by `operation()`, I think.)
Oh and we need a spec! ;)
**** END GIST processing. Everything else should be critical.
I do not see any use case for an 800ms interval, so can we please agree to use a resolution of 1s steps instead. Should fit any use case.
Lincense!
No, not necessary here.
Using this in the forms in the views.
instead of this, why not:

```config :metricname, :validate => :string, :default => "%{CW_metricname}"```

It has practically the same effect (the default you want), but is more flexible.
Actually this is referenced in [core/date_api.php - date_finish_calendar() ](https://github.com/mantisbt/mantisbt/blob/master-1.2.x/core/date_api.php#L296) which is in turn referenced in 

* bug_change_status_page.php - due_date rendering
* bug_report_page.php - due_date rendering
* bug_update_advanced_page.php - due_date rendering
* manage_proj_ver_edit_page.php - project version date rendering

So out of the box this will break stuff
Also I think it would be much simpler and clear to use a service instead:

```js
Cc['@mozilla.org/toolkit/app-startup;1'].
  getService(Ci.nsIAppStartup).
  enterLastWindowClosingSurvivalArea()
```
I think little comment here would help:

```js
value = !!value;  // Cast to boolean.
```
s/SDKs/SDK's/
sure.. is there a good way to tell when it's needed? I figured a hardcoded list of operation names wouldn't be a good idea..
so at a higher level, the wsapi handlers will need to verify a password is provided if required.
So that's just staying BigTent should act like a normal IdP? If there's a `well-known`, we're going to send you there, period. If there's not a `well-known`, we're going to send you to our fallback. Right?
these four lines can be just one line: `loadlimit = int(options.get("loadlimit", 1))`
oh ok.  removed.
Please revert that change. It's not necessary to have that in the config module.
Underscores are a pythonism. They have no place is JavaScript, except as brian said.
Why are there two URLs that seem to do the same thing in comments and URL form but different things otherwise? I'm confused.
Why a separate function? Move this code directly into the else case of `manageCompatPrefsSetting`.
Maintainer nitpick: it's much harder to determine what changed in a given diff, if you combine reformatting with functional changes in the same commit.

What's much easier on us maintainers is for you to do the reformatting first, commit that, then commit the functional change. (e.g. `git add -p`, sometimes using the edit option to remove your change from the hunk getting staged.)

Not asking for a change to this PR, just a note for the future. Thanks!
Please use lower camel case here, ie. ``recentFiles``.
"bajo una"
My intent here was only to give it some similarity to DateInterval, since that is what is being used. Looking at it again it sounds kind of redundant. :)