Fix gh-2640 pipe8.ecl test filing in Roxie

Roxie does not output an empty dataset to the xml result stream for
outputs to disk file or PIPE WRITE activities.

It's arguable whether it should. Easiest fix for the regression suite
issue is simply to give a sepate key for the roxie case.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Fix gh-2515 Improve behaviour of getWuid() in Roxie

When ECL code calls thorlib.wuid() in a roxie query it gives an internal
error which does not help identify the issue.

Most Roxie queries do not have a unique WUID to return, and an error
seems reasonable (but more specific). A query that was executed via a
dali queue DOES have a workunit, and the wuid should be returned in
such cases.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Fix gh-2654 Skip library tests in hthor regression suite

Until #2653 is fixed, the library*.ecl tests in hthor should be skipped.
Also skip the aaalibrary*.ecl tests in thor as they have no purpose until
library support is implemented there.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #2651 from richardkchapman/roxie-wuid-error-gh2515

Fix gh-2515 Improve behaviour of getWuid() in Roxie

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Fix gh-2624 remote.ecl mismatch test in Roxie regression suite

Rework the test so that the output is independent of the number of nodes
in the system, while still testing that the number of results returned
from the ALLNODES() is proportional to the cluster size.

This requires that issue #2656 is fixed if it is to work correctly on
clusters with > 1 channel.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
More output to library2a.ecl
Fix gh-2656 thorlib.nodes() always returns 1 on Roxie

It's hard to guess what people want to use nodes() for - for some uses when
writing code that needs to work on thor or roxie, 1 may be the best answer.
But for other uses it's no good at all.

Given that it's always possible to code IF(platform='roxie',1,nodes()) if
that's the semantics you want, I think it would be more useful for nodes()
on Roxie to return the number of channels.

This could conceivably break code that is relying on the old semantics.
Though I suspect any such code would be unusual.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #2641 from richardkchapman/regression-suite-pipe8

Fix gh-2640 pipe8.ecl test failing in Roxie

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merge pull request #2659 from richardkchapman/roxie-nodes-gh-2656

Fix gh-2656 thorlib.nodes() always returns 1 on Roxie

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merge pull request #2655 from richardkchapman/library-tests-hthor

Fix gh-2654 Skip library tests in hthor regression suite

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merge pull request #2658 from richardkchapman/remote-test-gh-2624

Fix gh-2624 remote.ecl mismatch test in Roxie regression suite

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merge pull request #2657 from rengolin/regression

More output to library2a.ecl

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>