labofsahil/github-event-dataset-2012 huggingface dataset:
OK, that didn't really answer my question. There's an undocumented "magic number" in the CSS. It could be 100px because its half of a 200px height of a container element, or because it'll always need to fit 5 times 20px elements, or something else. Or in your case, because its a reasonable height to fit a couple of tree nodes. The CMS CSS is becoming very complex, which is why I'm so hardline about keeping it documented.
``$min_priority`` does not seem to conform to the naming convention (``^[a-z][a-zA-Z0-9]*$``). I found this a couple of more times on lines: 39, 40, 52, 58, 59.
Done in aktueller Version.
capital idea. done.
I wouldn't be for changing or augmenting anything explicitly passed in, thats probably trying to be too clever. Explicit is better than implicit.
It looks like indentation is done with tabs which expand to too much space in the output. Could you re-indent with 4 space characters?
For `map` however you do need it, not for the others :D
This should be changed to GetServices(...), as there can already be multiple registrations for a given type.
this whole class can be imported from ldc_2d.
I need to do that a lot more in `.end()` too it's a crazy mess right now haha
This is not good. If user left the field empty, it would get a mismatch error?

I would do:

```
if password1 and password2 and password1 != password2:
    raise ...
return password2 # not 1
```
Comma after *zahtevali*.
Of course. :-)

And include external file *after* this block.
I think you also have to call `makeColumnsSortable`.

And `orderPanelsDefault` is not really the correct thing, no? It reorders thing.
Properly structure imports (each package into separate section).
It does. If users does not have permission 'locations_form' will be undefined (None) and will not include that code. I don't like to duplicate same conditions. Its usually prone to errors.
That is still TODO. Is external file home.js ok? I wrapped

    $(function() {
        registerUpdatesProcessor('userlist', updateUserlist);
    }
We could instead ignore all `cython` modules, i.e.,

```
a = list(x for x in self.cimports(filename) if x.split('.')[0] != 'cython')
```

and then just verify that `len(a) == len(b)` below.
You're better off putting these values into "constants" somewhere.
I'm not sure if this is any correct. Egris can you comment on this please?
nom significatif.
if this flag should never be together with transport enter/exit, modify these 2 functions instead

        void EnableTransportEnter() { raw() = (raw() & ~TransportExit) | TransportEnter; }
        void EnableTransportExit() { raw() = (raw() & ~TransportEnter) | TransportExit; }

to

        void EnableTransportEnter() { raw() = (raw() & ~(TransportExit | SmoothGroundPath)) | TransportEnter; }
        void EnableTransportExit() { raw() = (raw() & ~(TransportEnter | SmoothGroundPath)) | TransportExit; }

in MoveSplineFlag.h
@Takenbacon 

No. If consistency was important then there would be a "wrong" and "right" notation in the coding standards, not left to interpretation. Besides there are other areas in the core that aren't consistent.

@Subv 

Since you explained it nicely and it is a preferred method then I'll repbulish the patch.
Actually, let's make it the semicolon solution like you suggested. API is meant to be consumed by machines in the first place :)

I will not put a space after semicolon, so that the client app does not have to strip the strings.

Thanks Martyn, good review ;)
"ID"
Coole Idee! Die kannte ich nicht.
no, it's only required when you need to also pass options.
Arcanist is part of the phabricator toolset from Facebook, it's used for creating code reviews amongst other things.

Maybe this would be better in an "arcanist.snippets"?
The evil TDD me keeps thinking this means that `bar!` only returns a `3`. :-)
bascially => basically
slf4j-api itself does not include any implementation. It'll complain if it doesn't find one at runtime.

Simple is a light-weight slf4j api impl whose use makes sense for testing purposes.
WARNING : generally, FIXME are never fixed :D
This feels mysterious to me.  `density` is not a list of locations in the viewport.  `setDensity()` makes more sense from the client perspective.
Possibly. You still need to compile and link with -pthread though - this way at least it's clear why. I'm not against changing it to NewMutex() though.
Si seulement j'avais accompagné tout ça de tests :)
Merci Simon!
No. One is the secured event, the other is the unsecured version of the same event.
This works correctly, but the notation is a bit odd IMO.  I'd rather
```
gal_mask_image = galsim.ImageI(gal_image.bounds,1)
```
or even
```
gal_mask_image = galsim.Image(bounds=gal_image.bounds, init_value=1)
```
Comments have been updated to reflect this.
btw, the above comment is in jest.  does github support <sarcasm> tags?  Guess not, not even in :autocomplete: . (But it has :jack_o_lantern: )
Is there a gem that handles lists of emails? That might be easier than manually parsing it
this should come from mgmt context not be a field here, shouldn't it ?
Redirect stdout/stderr?
See similar comment under Qpid.
It is a lot. I will do grep.
That sounds like a good thing to support as well and I think this change only makes it easier.
since it's only used in this function, why not do it like this:

static QPixmap dotIcon;

if ( dotIcon.isNull() ) {
   create the icon
}
return dotIcon;
}
That said, I think I would have been less confused if I had just read this file first before looking at the tests :-). So, it is kind of my fault actually.
Could you make this one line? It's a bit difficult to read as is.
if(src)
var/turf/T = get_turf(src)

Then give the co-ords of the turf.
Wat.  WHY?
looks like a typo in the html right here
[b (массив байтов, с помощью Arrays.toString) упс, не тот toString...
Ah! So that's what Ctrl+T does in the ACE editor. I gotta say, I hate it that they hijacked a common browser shortcut :( I'll fix it right away.
だいぶ見通せる感じになったと思います！
メソッド名も冗長ではありますが、現状のコードの制約によるものなので、情報が欠けてしまうよりはこのままが良いと思いました。ということでマージしちゃいます！
対応ありがとうございました！
home.py:57:1: W293 blank line contains whitespace
@arjoly not currently. Are all classifiers in sklearn supposed to have this attribute? In fact maybe we should be checking ``isinstance(estimator, ClassifierMixin)`` and then expecting estimator.classes_ to exist.
I think I was going by Luxburg but I can check again.
The comment is wrong, I'll change it.
OK, I will change that. So is `eig_tol`? That is another parameters for solving the eigenvalue problem here.
As mentionned on IRC, I think boxplots would be better than errorbars.
I also think the labels should be set, both on X and Y axis.
![pep8](http://media.tumblr.com/tumblr_lvdkskkv9Q1qjajb5.gif)
Thanks, for this suggestion. I'm thinking it may also resolve comment 1.
Die Zeile set 'path' könnte gespart werden wenn (wie unten erklärt) eine private Methode _updateTrackLength aufgerufen wird.
The trouble with adding a separate file for each test is it tremendously increases the time necessary to run the test suite. Please instead add it to one of the other test files, which adds very little to the time.
How about moving this guarantee inside findOutputParameter.
added todo for the part 2
In these cases where we silently ignore unknown values, it would be good to log a line saying that we received unknown value and log what the received value was.
Fix the warnings about userContext, caller, and args not being used. Same for the rest of the times too.
Running of ndk commands should be strictly reserved to the ndk class.  Other classes shouldn't deal with building command lines, only use the api functions made available by the ndk class.

deploy assignment really shouldn't be duplicated 4 times.
ca doit etre un probleme d'espace / tabulations
This changes was needed otherwise a table with no fields was treated as a constant.
For non 'legacy wuid', I have to call getProcesses() first. If I use the common code for both non 'legacy wuid' and 'legacy wuid',  the getLogs() will not be called since the getProcesses() returns nothing. So, I choose not to use the common code.
Why is fileType different per thorlog* ?
We certainly could do that, however, I could definitely see there being lots of cases where we may have integer IDs being passed in as path variable values. As such, I thought that coercion to String via `to_s` was a reasonable constraint for values.
Nit: Remove one of these empty new lines.
Done in  4f5cff78dc
Shouldn't it be sum2 instead of sum?
Does that mean that `future` accept only a function and one argument?
>
> * Is there any particular reason in using `yield`? I'm not against it, if we aren't trying to use it everywhere but just for some cases.
> I imagine you made this for context menu, in order to be able to stop iteration when a listener returns something valid?
> I don't think we should ban some particular JS/Mozilla features, but be conscious of what we use and avoid using everywhere everytime everything.
> And Proxy like yield/iterator allow to address some particular issues.
>

Yes it's for context menu only & I hope we'll be able to get rid of it at some point. In fact comment on top of this function is pretty vocal about
the fact that it should be used only in exceptional cases.

>
>  * Same question for this slice/while/shift pattern, is this really necessary to create a temporary array? Can't we just use for or
> foreach and iterate on the original array?
>

1. You cant escape loop when using `forEach` without throwing exceptions.
2. `forEach` will take a function and we need to yield from this function not from the one passed to `forEach`.

> Looks like you intend to avoid side effects regarding your tests/docs?

Not sure I got the question right, but yes we intentionally do not trigger listeners added in the same dispatch and that was always a case.

> * I'm not sure that we should bind this experimental method to `emit` which is not.
> We may expose it without willing it, if another API expose `emit`.

I kept it this way as `emit.lazy` describes exactly what it does, and avoids some publicity by not
exporting right from the module. Also, we won't expose `emit` in high level modules anyway as
it requires `this` as first argument, so even if we decide to expose it it will be `emit.bind(null, this)` in
which case `lazy` property won't  be there. That being said I'm fine exporting it right from the
module with as different function if you still think it's better.
This is a separate bug, please file a new ticket on the bugtracker. It is not blocking for 2.4.0~rc1, since Debian by default does not use syslog-ng, but should be fixed swiftly never the less. Good catch!
Task should be canceled in FormCommit.Dispose.
Sorry, that must have been a typo when I was cleaning up the code for github. 
Resuming files does work as filemtime returns when the file was last modified. If you are uploading larger chunks, then modifying  max_file_age or disabling cleanup_dir will fix the issue.
using a DI parameter instead of hardcoding ``50`` in the service definition
Good suggestions. Will use GConf, as we probably want to use that anyway.
this is not WINS domain.
this is DNS domain.
The target 0 is default. It is possible to change but out of the box this is your friend :)


----- Originalnachricht -----
Von: Tod Beardsley [mailto:reply@reply.github.com]
Gesendet: Monday, June 04, 2012 08:53 PM
An: Michael Messner
Betreff: Re: [metasploit-framework] winlog_lite_2.07.14 initial commit (#446)

> +
> +class Metasploit3 < Msf::Exploit::Remote
> +     Rank = NormalRanking
> +
> +     include Msf::Exploit::Remote::Tcp
> +     include Msf::Exploit::Remote::Egghunter
> +
> +     def initialize(info = {})
> +             super(update_info(info,
> +                     'Name'          => 'Sielco Sistemi Winlog Buffer Overflow 2.07.14',
> +                     'Description'   => %q{
> +                                     This module exploits a buffer overflow in Sielco Sistem Winlog <=
> +                                     2.07.14. When sending a specially formatted packet to the
> +                                     Runtime.exe service on port 46824, an attacker may be able to execute arbitrary
> +                                     code. The reliability depends on the actual project. We need to generate some more
> +                                     targets. Two of them for the default project and one other project is now available.

Are the offsets random, or can you discover them programmatically? Is there a default project? I'm just trying to figure out how a user could either make use of the description, or can figure out how to use the module with datastore options (instead of resorting to editing the module).

---
Reply to this email directly or view it on GitHub:
https://github.com/rapid7/metasploit-framework/pull/446/files#r924711

Integralis Deutschland GmbH
Robert-Bürkle-Str. 3
85737 Ismaning

Geschäftsführer: Georg Magg, Heiner Luntz
Registergericht: AG München HRB 147654

********************************************************************************************
Please note that:

1. This e-mail may constitute privileged information. If you are not the intended recipient, you have received this confidential email and any attachments transmitted with it in error and you must not disclose, copy, circulate or in any other way use or rely on this information.
2. E-mails to and from the company are monitored for operational reasons and in accordance with lawful business practices.
3. The contents of this email are those of the individual and do not necessarily represent the views of the company.
4. The company does not conclude contracts by email and all negotiations are subject to contract.
5. The company accepts no responsibility once an e-mail and any attachments is sent.

http://www.integralis.com
********************************************************************************************
Seems like you could move the "if res and res.code == 200" into a parent if statement, and make these lines a bit shorter, then use an else for the safe check code.
Hm, looks really neat, but what does `nuS` stand for? :confused:
Could you please use the same syntax here as the rest of the code?
This doesn't gain much.
Again, better to use CDI here, rather than fiddling around with the session.
HA I didn't see that!
Why did you change this to 'items'? I like it as people - it seems more clear.
That code is there to predict if the string you are using is an image path or just a regular string (like `'rgb'` for `channels`). I could check if a string has a `.` in the middle and then assume it is an image path, but that could sacrifice accuracy.
This might be a micro-optimization, but couldn't you extract `CesiumMath.TWO_PI / 86400.0` as a constant so it's not recomputed every time?  There might be a few other minor optimizations like this elsewhere in this function.  I don't know if they are worth it or not.  @shunter ?
Do we need to store all three of these?  What about only storing one and recomputing after a morph?
Missing copyright etc
This absolutely needs to be a Ti.UI.Button, otherwise it won't look like a proper themed buggon
The _doLayout method is not used anymore...this code is never called.
This description doesn't really match the error. Perhaps something like "Unable to open gallery image- Image file does not exist." would be more fit.
Угу, в 3м задании уже исправлено
Now that there is a SHOW_ELEV_PROFILE setting, this can be made optional.
Space after `!`  and before `?`. Plus, can you add a comment explaining what this is doing and why we're alternating with positive and negative elements?
Its defined above (line 63), because the version specifics are different.
return = foo is illegal syntax in python. Are you sure you tested this change?
So, is the point of this to make it so that when `lessFun(r.front, r.front)` fails to compile, you get the instantiation error rather than the `static if`'s condition silently evaluating to `false`?
This one? Neither -- the only purpose of this one was consistency (and making it express the intent better, IMO). Feel free to ignore it.

The only "real" bug was with templates like mostNegative (if I remember correctly...), which blew up on my custom struct. The rest of the fixes were just for making the intent clearer to the reader.
std.algorithm.foo seem to infringe a namespace for other unittests.
You might make them inner functions of unittest if they don't seem to have any problem.
то же самое: щас специально проверил - молча делает всё как надо
Does `register_submodules` need to be called her on the inner elements?
Everywhere else I think we use lconfig.lockerDir here, would that be better than the ..'s?
Why removing this validation? This would accepts ints and other scalar variables.
I'm surprised it wasn't went I went looking for title styles. I'll update the others I find as well
Должно быть created_at
Bist du sicher, dass du in diesem Fall nicht speichern möchtest?
Ich denke, es wäre evtl gut zu wissen, dass dieser Nutzer einmal Student war!

$legi->isValid() sehe ich eher als hilfreich bei der Pricings-Auswahl...
Could do with a docstring (and on the figure method).
We should be very careful when we change this function since a lot of our code uses it.
What is the particular reason for changing it?
Temporary solution.
Hi Gunnar, I am still not comfortable merging this hard-coded value; I ran some tests and $buildDir causes it to look in the parent directory, not the module.

Given that $buildDir is a java.io.File, we can use ${buildDir.name} because File.getName() returns just the last part of the path (build), which is the same as your hard-coded value. I just tested this with my local Sonar install and it worked fine.

I know you are traveling, but I want to get this merged. If you don't object in the next hour or so, I will make this change while squashing for the merge.

Gary
The buffers are automatically resized as needed (e.g. see line 130)
Well it depends on how it is used, that's why I point you to line 284. 
```
Object value = entry.getValue().getValue(this.evaluationContext, requestMessage, String.class);
```
As you can see we pass a Message in getValue(..) call essentially swapping the root object
Good evening, Gary!
It's me again ;-)
Maybe:  ... 'message-converter' **or** 'request-payload-type'...?
Sorry, I had wrong understanding for runningJobs.remove().
The latest ZF1 does not have Zend_Form_Element_Abstract
not quite what i wanted
This is why you always use null for variables. Anyway, I refactored add_metric = undefined to add_metric = null, but I will leave this defined (hm, I defined undefined :) since I use it in metric name and maybe I will also use it in some if clause...

On 29. 09. 12, at 12:52, Mitar <notifications@github.com> wrote:

> In tests/test_project/test_app/static/test_app/js/datastream.js:
> 
> > @@ -0,0 +1,700 @@
> > +(function($, undefined) {
> Interesting way to assure that undefined is not overridden. :-)
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
correct.

and looking at the rest of the code again, it makes sense for the `getItemView` to just return the type, not an instance. there are too many other things that need to happen, surrounding the instance creation, to leave it up to this method to create the instance.
I'm seeing a lot of escaping going on in this file, can't we avoid this?

Since we use single quotes for all of our JavaScript and we surround everything with double quotes in ruby?
Nit: Instead SINCE_EPOCH_TIME use a real timestamp like in

https://github.com/telefonicaid/notification_server/blob/develop/test/scripts/send_notification.sh

in order to be used in a near future ;)
These docs look handy, but could use some cleanup; in particular please wrap long lines, and use rdoc formatting as much as possible.
remove excess blank lines
no .. you would need to construct the query yourself.
Probably this would be more concise as a dropdown? Which I guess should be relatively straightforward to implement, since we have the Tool.EMULATOR constant to populate it with. I can take a look at this if you like.
Start with upper letter.
Ahh -- I think I see the misconception here.  This particular line was done as a stop-gap.  There should be *no* `ArmSectionsTestCase*, I just didn't feel like swapping them all out right now and didn't want to write more incorrect code.

This is something that's already been decided -- each component is supposed to exposed a `tests.._utils.TestCase`.  As I said in the last comment, there's a few projects in Armstrong that do not follow that pattern, this being one of them.  Those should be changed.  When you're in a component, if you extend from `TestCase`, you're getting the default `TestCase` for that component for component.  No other `TestCase` should ever be imported inside a component without renaming it to signify its from the outside.
I don't think it is that obvious for casual readers. I did forgot about this myself :D. I'd be in favor of not having it as a tip.
Same remark here  on docstring formatting.
You should clean up the spacing here and you actually don't need that verifyMaxCustomerUsageThreshold; this check is already done in cartService, you just need to catch the exception
i thought it would be nice to standardize  database tables name e.g say if you were to write/run some scripts to directly with interact with database for  whatever purpose .one can  easily going by meta  db table name  otherwise you will have to depend  by  django default database table names i.e appname_modelname  which is at times truncated depending on database engine . 
I agree there is no need  for it now will remove.
|| "ok then say that" 

"that" is the first sentence in the link I provided in the README.

Responsive, as a skill set and a design principle does not mean "multiple looks", nor does it mean "only one look". Otherwise, the test would be design principle would be stated as, "Make a tic tac toe game that changes its look when you shrink your browser or view it on a phone". If the developer can make an easy-to-use interface that works well on multiple sizes / types of displays, then yes, it is responsive, even if this merely means adjusting the viewport via a `<meta` tag.
Unfortunately the `nearby` method on a user is very expensive, so we need to be very careful where we're using it, or find a way to optimise it.
Doubled percentage sign.
put in getUrl
Same notes for this file as previous one.
The Mandatory text should not be necessary. Optional parameters are wrapped in []'s
I would simplify this to "should the window cover show notification badges"
Should be removed, not for public consumption. We will not be allowing overriding of the root controller.
It was never set (at least from the Android side). Did iOS set it?
- remove admin page from menu
Yes, they will get a deserialization exception.
This is a little weird. Why are you requiring 'path' each time, instead of using the path variable above?
buffer isn't large enough to hold what itoa outputs, char is only 1 byte in size, if your number is larger than a single digit it will cause a memory leak, consider using stringstream to convert int to string, see dialog_js.cpp in dialog_ext branch for an example
pagination will be removed when we remove users and groups.