labofsahil/github-event-dataset-2012 huggingface dataset:
On Jan 4, 2012, at 3:09 PM, Brad Roberts wrote:

> It's clearly broken, as Walter reported:
> 
> src/rt/minfo.d(207): Error: function rt.minfo.rt_moduleCtor.runModuleFuncs!(__lambda210).runModuleFuncs is a nested function and cannot be accessed from _moduleCtor
> src/rt/minfo.d(207): Error: function rt.minfo.rt_moduleCtor.runModuleFuncs!(__lambda212).runModuleFuncs is a nested function and cannot be accessed from _moduleCtor

Um, what?  Here's the relevant code (in rt/minfo.d):

    extern (C) void rt_moduleCtor()
    {
        _moduleinfo_array = getModuleInfos();
        _sortedCtors = sortCtors(_moduleinfo_array);

        // run independent ctors
        runModuleFuncs!((a) { return a.ictor; })(_moduleinfo_array);
        // sorted module ctors
        runModuleFuncs!((a) { return a.ctor; })(_sortedCtors._ctors);
        // flag all modules as initialized
        foreach (m; _moduleinfo_array)
            m.flags = m.flags | MIctordone;
    }

    // NOTE: This is to preserve compatibility with the Windows DLL sample.
    extern (C) void _moduleCtor()
    {
        rt_moduleCtor();
    }

All I did was add the _moduleCtor() function above.  This looks like a bug in DMD's inlining mechanism.  I guess what I'll do to fix is move _moduleCtor() out of minfo.d so the call to rt_moduleInfo() is opaque.
I mad it compile by disabling sound chip completely, not just audio 
drivers, but it doesn't boot..
no use of that kernel, it's not's a real 3.0 kernel.. I mean it is 3.0 
based, but all drivers are forwarded to compile with 3.0, they are not 
from 3.0 base.. so the drivers are the same as on 2.6.35

On 02/06/2012 10:25 AM, XxXPachaXxX wrote:
> hey lc, this kernel compiles for you? i modified makefile and now the menuconfig is fixed to configure a DHD kernel, but it stop during th compilation process...and your?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/LorDClockaN/htc-kernel-msm7x30-exp/commit/b0e62512d3d6339892e4b7b50cc70e827e0eccc6#commitcomment-935847
>
Heh...I happened to be looking at it at at just the right time...
Yep, I saw already the nice pull request. I'll add some info and a link to it when it gets merged.
Lol.... sorry ;p
I think this is the right way, looking at http://developer.android.com/reference/android/graphics/PixelFormat.html#TRANSLUCENT
Now you only need to figure out where to put it :D
I think this should be options (plural) instead of option (singular), same with the one in a couple lines below this.
unused imports.
use [cmd]-[alt]-[o] to optimize imports.
Add URL to where these assets live in the YUI Assets project (once they are moved).
Yes, we can't specify the exported file name before, so we write the exported file in sandbox with a correct file name. But now we can specify the correct file name by a.download, so we can always write to a single temporary file and point out the correct download name. For example, we have 3 projects named "a", "b", "c", then we need to create a.zip, b.zip, c.zip in sandbox before, but new we just need one exportFile.zip.
"," is not necessary
Should this be "Elgg-specific stuff"?
This is for testing purpose. A *mockito* logger is injected during testing to *verify* that the right log has been generated.
Better to copy from the subclass than have no documentation at all.  See the section "Automatic Copying of Method Comments" of http://docs.oracle.com/javase/6/docs/technotes/tools/solaris/javadoc.html for more info.
I think in general, all debugging statements need to check for appropriate level being enabled. May prove to be minor, but there are some performance gains to benefit from.
Just a minor nitpick, but I'd say that PyOP2 isn't the OP2 runtime library with Python bindings - it's a complete implementation by itself, and the only OP2 part it uses is the plan function from OP2-Common (for now).
try if this works

  node(node2) / "user" / "ponger"
AES128CounterInetRNG + AES256CounterInetRNG + AES128CounterSecureRNG
3nd ?
I don't think it should, yet
that's nice, perhaps change order and the negation

    val (rejoiningMember, newUnreachableMembers) = localUnreachable partition { _.address == node }

!isEmpty => nonEmpty
This doesn't return Changes anymore right, it returns all subkeys
Since you always do remove you might as well start the method with:

endpointToAddress.remove(endpoint) match {
  case Some(address) => addressToEnd....
  case None => ...
}
Points in here (together with azimuths that are set on a next line) define four great circle arcs that contain four edges of surface projection. First two are for arcs that contain top and bottom edges (hence top left and bottom left points and surface's azimuth are used) and last two are for arcs containing left and right edges (downdip from top left (again) and top right corners).
One import per line - follows pep8 and makes for cleaner diffs.
I should import division from future just to be safe
Please read the [CKAN Coding Standards](http://docs.ckan.org/en/latest/index.html#for-ckan-developers) on docstrings, these should be in triple-single quotes, have a short, one-line summary at the start, be in the imperative tense, etc.
Again appears to replace groups with organizations
@johnmartin Will this work now that lengths of activity streams is configurable? Looks like 30 is hardcoded. Can you try putting `ckan.activity_list_limit = 15` in your config file and see if it still works?
Following on my above comments, they can see the message body here, no need to apologize so profusely for its format. They'll know what they are getting into after seeing this example.
What happens in the event that only some of them were successfully associated? There's no description of that case.
Good catch.
This is a mistake.  The pulp_rpm/__init__.py needs to be owned by rpm-common, not rpm-extension since it's needed by almost all the packages..  Surprised this builds.  I'll fix.
I feel like mentioning the messages are quite spartan is taking a shot on ourselves in our own documentation. I think mentioning it's a JSON-serialized representation will do enough to set the expectation that they aren't getting Shakespeare sent to them.
So this is always valid right? - will do so
Actually, there is no provision in webdav for partial writes at all. The standard HTTP put is supposed to be used, i.e. all in one pass.
Doing a PUT with Content-Range is kind of a "de facto" standard.

Mult interface  = asynchronous calls = buffering of the data
I thought about buffering, but that would hardly be feasible for large files, e.g. videos.
you can also stick a with statement here for consistency.
Made None.
This extra line can be removed.
Yes, your solution worked.  No cast needed and Eclipse is happy.  Excellent.
This is where most of the work is going on.  The content is split on the chunk regular expression and the chunks and between texts stored up in an array that is the parsed object.
are we guaranteed that set.size is constant?
why the uppercase? ^^
Indentation is still weird here. It doesn't match the lines below.
Why is this a float?

An ellipsis only replaces a single character.
Hmm.  Now we have two versions of each process and array method.  Let's document why we need both, and when to use which.
These comments are not correct. This new function doesn't generate a Makefile but a header file. This header file will be used by other GEMs C files not Makefiles to access other GEMs data.
can you use an input to determine compression? i'm really moving away from any uncompressed outputs. takes up too much space! so by default i would like to see things compressed. since this uses nibabel, perhaps allow any of the outputs that nibabel allows.
With my suggested one-line modification to `gxp.plugins.WMSGetFeatureInfo::displayPopup`, you can remove this whole block.
заведи константную ссылку
дебаг лучше убрать совсем
Yes, now that the code is supporting multiple queues this is no longer necessary
I don't agree. The assert_ name implies that it either raises or doesn't raise. It's a gatekeeper method that's not supposed to return anything useful at all, thus returning nil.
@rafaelfranca I guessed there was a `delegate` somewhere. Is there any place where `AssetUrlHelper` is included that either doesn't include `ControllerHelper` or `request` is available? The only one I cna think of it Action Mailer but `controller` is not defined there either so I'm not sure that the `elsif` branch is ever called.
The output_safety and erb requires should probably be out. We need to bring some hash requires in (at least extract_options! one, but i think we also need others).
By calling `super` here, could we remove the `@message` assignment below?
I prefer the `entry = nil` here
Btw, for a `true` return you could use `===`:

```ruby
%r{^rails/info|^rails/welcome} === controller || 
  %r{^#{Rails.application.config.assets.prefix}} === path
```

Not that it'd make any big difference, just in case :).
I think there's no need for the `Performance` module, wdyt?
At the moment the only thing I'm proposing is **crashing is not how you
handle the condition.**
Yep, would be cool.
`'{joinTable}'=>$matches[1]` does not work here anymore.
I right click on project goto check style and activate, and noticed that its already using the gwtp style, but i need to verify. I've reinstalled eclipse recently so I had to reinstall the check style. hmmm
the formatting is still messed up in this file
@rykov - Why does this link redirect through badge.fury.io instead of just going to rubygems.org?
Да, эта функция мне вообще не нужна.
Убийство app_dixt оставлю на потом.
Might it be better to do this in the `Changes` class? That way, the AMQP receivers would hit this codepath as well. If a `ConfigValidationException` is thrown in there, then the standard exception mapper should format it too.
The point of isolating it here is to make it easily changeable. At worst, you'd need to rebuild your sequence cache since all the calculated entries would be missing - but this happens as time passes anyway.

I was actually thinking at later points we could support multiple policies (for quieter vs more active pairs), then analyse pairs and attach (via some kind of metadata table) cache policies to them.
Also, files in git aren't necessarily utf-8 encoded. They could be in some other character set. My understanding is that there's no way to get that info either.

/cc @brianmario Can you take a look at this?
Don't forget to nuke the commented-out code. We should probably just remove this `converge!` method entirely.
Remove useless white space change
Same on 'his/her' as above.
Maybe something like: When enqueueing the same kind of job with the same args in multiple places it's a pain to have to declare the job args everytime. You can define default job options directly on the job class:
I think parseFloat works quite well without the regex.
the indentation is off on this line
Don't want to hardcode this in now
I thought the pep8 guidelines call for no spaces in param lists.
such things are more readable when they are written like

take(
     cuda_ndarray.blah.blah,  # idx
     0,             # axis
     out_[0][0]  # return
`infer_shape`
I think Fred said we shouldn't use this shortcut in examples. @nouiz can you confirm?
There are ways to get overflow that the java can not detect -- through
parameters. You might need to add stored proc test cases to uncover this.

On Wed, Aug 15, 2012 at 10:12 PM, Xin Jia <notifications@github.com> wrote:

> In src/ee/executors/indexcountexecutor.cpp:
>
> > +        try {
> > +            m_searchKey.setNValue(ctr, candidateValue);
> > +        }
> > +        catch (SQLException e) {
> > +            // This next bit of logic handles underflow and overflow while
> > +            // setting up the search keys.
> > +            // e.g. TINYINT > 200 or INT <= 6000000000
> > +            // rethow if not an overflow - currently, it's expected to always be an overflow
> > +            if (e.getSqlState() != SQLException::data_exception_
> numeric_value_out_of_range) {
> > +                throw e;
> > +            }
> > +
> > +            // handle the case where this is a comparison, rather than equality match
> > +            // comparison is the only place where the executor might return matching tuples
> > +            // e.g. TINYINT < 1000 should return all values
> > +            TableTuple& tmptup = m_outputTable->tempTuple();
>
> Actually VoltDB never run this overflow or underflow code in ee. I think
> it already returns with an error message in Java level.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/VoltDB/voltdb/pull/126/files#r1389401>.
>
>
The interest should be added before the request, otherwise there is a race between the snapshot completing and the interest being registered.
This will break when using any other locale than English.
Why not filter it in the view?
looks like I really did
Shouldn't the eunit.hrl header be -ifdef'ified and uncommented?  This looks like a bit of debugging cruft.
I know the comment says "TODO", but I think the biggest item missing from this sum is metadata, which is specifically interesting because of its use for storing secondary index information (and links, and other user-defined things, but 2i is the place people are really starting to use it a bunch).
ok I'll update this
How much smaller is this? I'm concerned about maintenance because we may need to add more specified fixes later.
Will this still compile for other OPENGL platforms such as Android?
Looking at other MonoDevelop template projects, it does seem to be how its done.
s/implment/implement/, again
Why are these substitutions superfluous? As far as I can tell, the static libraries are still missing.
I'm the source. I created the gists. How would you like that documented?
On my system 10.8.2 with Xcode-only, I need to change this line to include the `-sdk` like so:

```ruby

    system *%W(xcodebuild -project source/Irrlicht/MacOSX/MacOSX.xcodeproj -configuration Release -target libIrrlicht.a GCC_VERSION=com.apple.compilers.llvmgcc42 -sdk macosx#{MacOS.version} )
```
This comment doesn't need to be in the formula
Would those 2.7 be easier to maintain as a variable?
This doesn't really have anything to do with keyboard shortcuts ;)
The "Ready to get learning" seems good, but the "Greeting from ...'" bit maybe need to more explicitly mention that the user need to confirm their email. The registrations_confirm message will only be sent to an existing user if they change their email address.
marvelous. why don't you put that in a comment ? :D
This isn't a redirect?
> I'm just surprised that `dbh.fetchone(...)` would return a dict 
> `{'max_id': None}`.  I guess that what it does if the table is defined 
> but with no rows?

Yes.  The aggregate operators seems to behave differently than column 
identifiers:

In [18]: print dbh.fetchone("select max(id) from timelines")
{'': None}

In [20]: print dbh.fetchone("select max(id) as max_id from timelines")
{'max_id': None}

In [19]: print dbh.fetchone("select id from timelines")
None
This way CDIST_PATH works reverse to PATH: i.e. last one wins => is this the expected behaviour?
the destination should be a parameter, but may default to whatever is usual.
Ya I think that was pretty much it as well as way we would query for os+version. I m guessing we would have to encode values with = before sending to couch view.
Ah, I didn't think about the case where you want to actually point to an empty directory, but it makes sense and I think the code should work for that as well.
use example hub id from docs.
Good feedback, that's fixed in the latest build. The minimum snap is 200 so anything less than that will just snap back to 200 instead.
Isn't it awesome when JSLint forces you to make the code less readable than before? :-(
I simplified this a lot. The click handler is now in addMenuItem and uses the trick you described. I removed setCommand and moved the functionality to the MenuItem constructor (without the swapping logic)

You did remind me I need to review the "exports". MenuItem and Menu are supposed to be exported with some of the top level functions. Working on that now...

-----Original Message-----
From: Peter Flynn [mailto:reply@reply.github.com] 
Sent: Thursday, May 24, 2012 5:01 PM
To: Ty Voliter
Subject: Re: [brackets] Menu and Command and Shortcut Extensibility implementation (#936)

> +
> +    var _menuDividerIDCount = 1;
> +    function _getNextMenuItemDividerID() {
> +        return "brackets-menuDivider-" + _menuDividerIDCount++;
> +    }
> +
> +    /**
> +     * Sets the Command that will be execited when the MenuItem is clicked
> +     * @param {Command}
> +     */
> +    MenuItem.prototype.setCommand = function (command) {
> +        var menu = _getHTMLMenuItem(this.id);
> +        var oldCommand = this._command;
> +        this._command = command;
> +
> +        // Replace click handler

If this was ```this._command.execute()```, then you wouldn't need to swap handlers when the command changes.

Also, do we need to support swapping commands on the fly at this point?  It looks like getMenuItem() isn't a public API, so extensions wouldn't be able to use this method to override an existing piece of Brackets UI...  I can't think of other use cases that we have right now.

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/936/files#r879127
This declaration seems garbled--did you mean `MenuItem.prototype.createSubMenu() = function(text, id, relativeMenuID)`?
I would use upper case for "Sprint"
Does this work in XP?
This can't be reused as a generic no-op command because its label will always be "Experimental:"
This case will never be hit because start.ch and end.ch will never be -1 since those values always get assigned on line 115 and 116. I think you want to check if start and end are equivalent for the second case when you replace the range with only the start value
Add a comment that this can be removed after we migrate to brackets-shell.
Going with most recent seems easiest to implement, though?
EditorManager.getFocusEditor() is not a simple getter, so it shouldn't be called until after shouldShowHintsOnChange is checked. And checking for  no focused editor can be simplified:

    if (shouldShowHintsOnChange) {
        var focusedEditor = EditorManager.getFocusedEditor();
        if (!focusedEditor || editor === focusedEditor)) {
In the patch, that line is a deletion. Just making sure everyone sees that...
This won't help if `self.worker.postMessage(rev)` is computationally expensive. It defers the work until later but it will still run inside the main loop.

Also, calling `setTimeout()` without an actual timeout is woefully underspecified in Node. :-)
`data` is now a giant string, and doesn't have the `getElementsByTagName` method. This is crashing for me here.
No, there's not. It's common practice to escape all "special" characters -- and to not put them between character ranges ;) Didn't see it was already there.
I'm not sure if write will be nice to other threads trying to access $lag_values at the same time, chances are it is but worth checking.
I'm not sure what you mean. Two spaces before comment?
Maybe, these are result of copy&paste from other lines..... I'll fix it.
Maybe put this in a TODO
If nobody is using, it we can remove it.
Default needed. Use `app.config.get` with default value `[([], '')]`.
Please explain a bit more this comment.
Is this supposed to be `normal!` with an `!`?
`!=` in ocaml is like `is not` in python; this should be `<>` instead. (fixing this in the branch.)
Please use own version of jQuery. We want predictability. And also that things work on localhost without Internet connectivity. And also we want that things work under HTTPS (and your code above would trigger warnings).
Check what `./manage syncdb` does. ;-)
So check what happens if you navigate directly to login site.
Just raise `PermissionDenied`.
This should probably be a separate method so it can be called independently.
remove plz!
Yeah, that's what I feared. It's important for people that want to make sure their dom stays the same, and just want to change the url of things that are already there. Style might get messed up, etc.

No worries though. It *functions* now, just file a new bug to take care of it in 0.4.
multi-lined object plz
remove code comments.
complete() handles success or failure so this is fine
It's all unused code that lint was complaining about. Wasn't sure if it was important, because of the comment, so I commented it out for now. I could remove it and put it as a comment in that ticket.
Wow, great catch!

The reason this slipped through is because my iPad seems to be running Safari 6 and that browser is still having the same issue. Fixed it, thanks @yurydelendik
This is _very_ special case. Since there is no way to compare functions' source AST, we have to compare their execution results. All of the rest samples return just a plain object (or an array, or a string), so it is not a good idea to use such an interface with all of them. Since there is no regular way to compare functions, the constructor test handler interpret them as a "self-testing" assertors.

`getExpectedData` is separated from the assertor code because of upcoming representer tests which need some actual data to dump. It is also a function in order to give it same flexibility which regular "plain data" samples have.
copy+paste? :)
Using defaults sounds dangerous to me. I think that if a hash is specified, all keys should be given. This can be tested by something like:

```ruby
[:time, :intvl, :probes].all? do |key|
  unless options[:tcp_keepalive][key].is_a?(Fixnum)
    raise "Expected the #{key.inspect} key in :tcp_keepalive to be a Fixnum"
  end
end
```
This line and the 3 below should not be here
At least fix that typo, "I love Linus Torvalds".
Intentional comment there? Looks good, harder to follow all the changes since there is already some changes pushed, but ACK from my side.
config_dir maybe not, but apache conf dir is quite OS specific (Fedora: /etc/httpd, Debian: /etc/apache2). Once we support more OSes, or further releases will bring some changes in path conventions, or we will depoloy with dynamic software collections, this convention will be broken.
How are they separated? With a comma? I'd add this to the help section.
Observed that when the admin is creating a user, as they type in the password the "The passwords do not match" causes a formatting issue with the "System Registration Defaults" header.  (This is observed in FF 11.0)
This was before the change.
I think the simulated post should come before the assertion (except for the cases like should_receive).
and the formatter should return only the formatted message instead of returning a full record with a different message.
nit: "page-screen" is a bit of a weird name, though I'm not sure if I come up with anything better. Maybe "main-screen" as opposed to the side tray.
nit: the indentation seems wrong here
Do we want to make FILE_FORMAT a configuration option (with this as the default)?
If it is static I get thrown with compiler warnings.
Satoshi is a very bad person to learn C++ style from :poodle:
I'm not sure either, it doesn't warrant changing all the functions I guess... maybe just leave it like this then.
Isn't it possible to use EVFILT_READ, EVFILT_WRITE, etc. here?
thats what I was thinking but didnt try so far. all right then.

PS: docs update could be: https://github.com/dereuromark/docs/compare/2.2-request#L0L89
Thanks for patch, but can you update it? 

Frankly i don't like stripping name form URL, because it can cause problems with UTF8 artist names. It will be much better if you will get artist name from "header > h1" element on page.
where are node and service allocated?
I might be a bit behind the times, but what does this annotation do? I looked briefly at phpdoc.org, but there's no description about it
Should I also take out `@keywords internal`?
Why not put the `normcase` call inside `pyfile`?  That way, all tests that call it will benefit automatically...
Almlost perfect, I'd just move this `if` clause above the lambda so that we don't even bother declaring `b` when `browser` is None.
Why change whitespace here?
Yes, an exception is an item with RECURRENCE-ID, that holds data about the changes to an instance of a recurring item.
Not quite sure what you mean here? They use the same standard ical, caldav has one event per vcalendar I guess, ical has multiple ones?
The thing here is that both on error and successful completion, we need to do the cleanup. Adding an `on_error` label would duplicate the cleanup code.
After talking to pascalc we've decided that all new bedrock work should have l10n wrappers regardless of plans. This will mean that if we do decide to translate things at some point it'll be ready for pascal to extract and go w/o needing to wait on us. Sorry if this decision wasn't well communicated.
Do we have a maximum length that the password can be maybe restricted by the db column? If so, we might as well toss a max_length validator in, too.
this snowballed into a whole new feature of keeping and handling dupes for results.  but it's now addressed.  :)
Isn't that one quite good to keep uncommented?
why calling "update" rather than directly setting up the key / value?
add (backquote) for people who cannot see it that clearly.
@mfults: I just pulled this from the LSMSA website.
Not sure why you renamed it as it can stil be an Elastica_Query_Abstract object?
Putting the opening brace on its own line like this is a bit inconsistent with the surrounding code.
а PaymentBundle можно и обновить
what about equal priorities ?
The best pratice is to return something or `null` (and not to follow some old fashioned PHP API). Thanks.
I've added a method which acts like in the above description
this description is very abstruse and the link doesn't belong here
Fixed. Thanks.



On Wed, Dec 5, 2012 at 10:05 PM, Mario A. Alvarez Garcia <
notifications@github.com> wrote:

> Form/ChoiceList/ModelChoiceList.php:
>
indention wrong
This will not work correctly in some cases:

master request -> masterRequest
1st sub request _> set to subRequest1
continue the master request -> still using subRequest1
@lyrixx the LdapAuthenticationProvider is used when authenticating from the form, not when refreshing the user.
please use the new ``canBeDisabled()`` shortcut
It sounds to me then that we need a well tested way of doing prepared statement encoding client side. In order to support this, the MySQL driver appears to have a SQL parser along with all the escaping rules once the context of the ? is well understood through parsing.

http://www.docjar.com/html/api/com/mysql/jdbc/PreparedStatement.java.html
Bug I have fixed in this file will most propabli won't be possible on production. Author is null when user has created some feed item and if he was deleted from users table then (eg. for debugging - to get trough signup process). This will prevent crashing on staging, when you want to view that feed.
有 baidu.dom其中一定会import baidu; 所以不需要import baidu;
That'd let through `contourf(..., crs._as_mpl_transform())` ... but if you're getting that freaky (and using a private API) I'm happy that it's up to you to know what you're doing.
Yep. There is a whole lot of work just waiting to be done here... (the data directory should ideally not live in site-packages, but instead live in a user's homespace / a well defined place (be it via a config file or what-have-you).


I'm going to dodge this issue now as it is definitely something I want to do soon (before 0.5 I hope).

Thanks @bjlittle.
i need to run some test to generate a file and we have umlauts in this one, but can't test the correct rendering in the resulting file in it - thats why we do it here instead.

We have similar test patterns in the ReportCreatedIntegrationTest.
got~ 
![34](https://f.cloud.github.com/assets/176544/15588/0b21842e-4796-11e2-943a-c5cd86e76005.png)
can you turn these into classes instead of ids
What about a value of < 1 ?  IIRC you said the console had "0"? Was that also equivalent to 'disabled'?
Please remove this commented `require`.  Generally, I would prefer to omit commented code like this, at least in the `master` branch.
usernames can be numeric
These 5 lines can be 1 with .toggleClass( className, switch )
if os.environ.get('USE_LIBMOCKSPOTIFY', '') .lower() in ('1', 'true') perhaps? Or simply if os.environ.get('USE_LIBMOCKSPOTIFY'): i.e. if it is set assume it is true?
0s is the initial value
readibility nit: put the conditional expression in ()
@etiennesegonzac just to clarify that the only "FB operations" that will be resolved by Contacts itself will be 'link' and 'import'.  The rest will be handled as Activities as it occurs with e-mail, SMS, etc. On the other hand we have been requested to create a setting to hide FB functionalities if an specific device instance requires that. 

I hopes this helps to clarify this PR
Add a line break between the 2 rules
Hi, childNodes takes into consideration the presence of "text nodes" and so on so the way to this it (at least one way to do it) is the included one :-p Have a look at this: http://jsbin.com/equsem/1/edit Try to remove the <p>s inside the <div>. Another option would be to check if childNodes.length is equal to 1, but we could end up with weird cases. The previous code works always :-)
This is done every time, we can put it in the main `suiteTeardown`
we can, but sometimes you create it with createElement and sometimes with innerHTML.
this causes the code to be very fragmented and unreadable.
plus it duplicates the amount of work- for each element you need to write both an attribute and a value, instead of just an attribute.

from what I saw when testing it I didn't notice any performance issues, nor did I see "flickering" of content.
is there a problem with using mutation observers?
`innerHTML` -> `contentText`.
sleep_until_all_reservations_ready?
Sure, will fix.
Hard disks are cheap now ;-P Descriptive names are better than shorter ones. Of course, too verbose is even worse.
Wrapped all info calls in compiler.askOption:-

https://github.com/skyluc/scalatest/commit/1a8c0a051687084a767c62f478ec9a237e46ecda
Silently drop?
Great, thanks!  (And, this is not Urgent, so you can definitely wait until after Wed night if that's convenient.)
Add a space before Author, and add in your email.
Python doesn’t support a native switch statement
Document this method.
you should remove the braces around the condition. There are useless here
What exactly of the initial state will it be testing? E.g. will it test for the 'idle' state?
Since we already have some JS, why do we need this. Isn't it a simple ``$.toggle()``?
You're still missing the check:

    if ($topic_emoticon) $topic->icon_id = $topic_emoticon;

Otherwise icon will be changed to 0 with templates that do not support the feature.
The rest of Priam uses @Inject with constructors, not private fields.  http://code.google.com/p/google-guice/wiki/Injections says that field injection is the least testable approach so I much prefer constructor injection.
<android/asset_manager.h> and <android/asset_manager_jni.h> exist since Android2.3, and cocos2d-x should support from Android2.2, so can not use these headers.
Hello,

size_increment is not uppercase because I was wondering if this could 
be a variable (to be initialized thanks to the config file).

I agree with you for a 1024 default value. But here we need far more 
than 1024. This is why I would prefer a new item in the configuration 
file.
What do you think ?

Regards,
Yves

Le 02.10.2012 09:40, Florian Forster a écrit :
>> @@ -572,6 +572,14 @@ int uc_get_names (char ***ret_names, cdtime_t 
>> **ret_times, size_t *ret_number)
>>    char **names = NULL;
>>    cdtime_t *times = NULL;
>>    size_t number = 0;
>> +  size_t size_arrays = 0;
>> +
>> +  /* Increment size for the 2 arrays of values
>> +   * Because realloc is time consuming, it's better to
>> +   * realloc by blocks and not by units.
>> +   * To see the difference, set this value to 1.
>> +   */
>> +  #define size_increment 102400
>
> Can you please write defines in all uppercase? Also, I think 102400
> is a bit too large for your average user. I think 1024 could be a 
> good
> middle ground, but we could do some exponential increment as well.
> I.e.:
>
> ```c
> #define SIZE_INCREMENT 1024
> ```
>
> … or do something like:
>
> ```c
> size_t increment = 16;
> buffer = realloc (size + increment);
> if (increment < (1 << 16)) /* max 2^16 =~ 65k elements at once */
>   increment *= 2;
> ```
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/collectd/collectd/pull/139/files#r1736269

-- 
- Homepage       - http://ymettier.free.fr                             
-
- GPG key        - http://ymettier.free.fr/gpg.txt                     
-
- C en action    - http://ymettier.free.fr/livres/C_en_action_ed2.html 
-
- Guide Survie C - http://www.pearson.fr/livre/?GCOI=27440100673730    
-
最後に`"change"`イベントが発火したときに記録された属性の値を取得する。
Delete is called within delete_users_ids_from_team from roles/team.rb
editorial, really I guess - but the more trailblocks the larger the download for the user - mainly due to number of images we add in to the source html.

11 feels like a lot for a weedy connection.
Accident? This creates a cross dependency between the modules.

The gallery tells everyone it's moved.

```
common.mediator.emit('modules:gallery:moved', index)
```

And the URL modules listens out for such events and change it's state.
this should probably be fp_engine_analysis_set
although it is commented, please use ttyTact
Should `@see AbstractInterceptorCallableWrapper`.
Again, repeated in line 148+.
Elin's last comment triggered me that a menu item can have a menu item as parent item as well, not only a menutype as parent of course... So please find an update of this code below:
// This is a menu item under a menu item.
		if ($this->level > 1)
		{
			// Build the query to get the asset id for the parent menu item.
			$query = $this->_db->getQuery(true);
			$query->select($this->_db->quoteName('asset_id'));
			$query->from($this->_db->quoteName('#__menu'));
			$query->where($this->_db->quoteName('id') . ' = ' . $this->parent_id);

			// Get the asset id from the database.
			$this->_db->setQuery($query);
			if ($result = $this->_db->loadResult())
			{
				$assetId = (int) $result;
			}
		}
		// This is a menu item that needs to parent with the menutype.
		elseif ($assetId === null)
		{
			// Build the query to get the asset id for the parent menutype.
			$query = $this->_db->getQuery(true);
			$query->select($this->_db->quoteName('asset_id'));
			$query->from($this->_db->quoteName('#__menu_types'));
			$query->where($this->_db->quoteName('menutype') . ' = ' . $this->_db->quote($this->menutype));

			// Get the asset id from the database.
			$this->_db->setQuery($query);
			if ($result = $this->_db->loadResult())
			{
				$assetId = (int) $result;
			}
		}
You haven't implemented `setExports`. Take care of adding a note in release note about this possible breaking change.
Shouldn't we get rid of these two debug lines?
Or at least, dump(error.fileName) seems redundant.
I do not believe requiredEmail is ever used anymore and this is a remnant of that era.
elevate this to a `const` outside the function. only need to construct the array once.
Should probably have a "Creating sprints" section, too.
Need to add `@deprecated`
good catch, yes 'inf' should also go.
This needs to be rw, otherwise _set_recipients won't actually do anything, however as is that won't work directly, since Moo as of 1.000007 will not check for reader&writer before creating the accessor. However there is an easy workaround:

  is => 'rw',
  accessor => undef,
Why opening the file twice? Just to create it?
spaces after the ':' here and everywhere
@nschonni From my understanding, it's specific to IE5.5-7. I guess it was being used as a workaround for what ``white-space: pre-wrap;`` achieves.
I think that this not need to be changed. I understand that the paragraph is about Zend\Module
That's true. I used also the ArrayUtils::iteratorToArray($options);
Typically, your factories should not have a constructor, as that requires instantiation before connecting them to the container. I'd argue you should simply pull config from the "Config" or "Configuration" service within the createService() method, and look for a standard configuration key where pages are defined.
Can't we just use the low level api?
I think modifying List's insert method to be virtual should fix this (with very few negatives) and I think it'd also cause calls from IList<object>.Insert(...) to call the overloaded insert(...) method as well, which would seem to be an improvement.
What with already existing `score` details ?
Can you rename this to `clear_queue` please?
Had no idea about the `:selected` syntax on the classBindings. Pretty cool. 

Looks great to me.
This works, but it's ambiguous, much more succinct to do:

```js
$('#new-todo').val('');
return true;
```

Same with the below.
agreed, if removed the commit from this branch
maybe should we change this and update it to "ANTECHRONOLOGICAL_ORDER", or something less verbose, but more explicit?
It asks only one. It's written in 2.2.

`All PHP files MUST end with a single blank line.`
Well, it makes it more convenient when developing a field type template IMHO. And the result is the same.
This is destructive, but there's no awesome way around that.
no space after `function`
We should. I'll double check.
s/des Positionsabhängiges/des Positionsabhängigen/
(selbes eins drüber)
doh! Just saw there is a already a rake task for benchmarking. Anyway the result is the same: this patch is slightly faster.

```
ORIGINAL
------------------------------------------------------------------------
Using ruby 1.9.3 AR 3.2.3 with sqlite3 (in-memory)
Rehearsal ---------------------------------------------------------------
find (without FriendlyId)     0.080000   0.200000   0.280000 (  0.279392)
find (in-table slug)          0.150000   0.190000   0.340000 (  0.340293)
find (external slug)          0.280000   0.420000   0.700000 (  0.698035)
insert (without FriendlyId)   0.160000   0.440000   0.600000 (  0.600971)
insert (in-table-slug)        0.490000   0.900000   1.390000 (  1.393599)
insert (external slug)        2.010000   1.900000   3.910000 (  3.912179)
------------------------------------------------------ total: 7.220000sec

                                  user     system      total        real
find (without FriendlyId)     0.060000   0.180000   0.240000 (  0.238112)
find (in-table slug)          0.130000   0.210000   0.340000 (  0.339205)
find (external slug)          0.210000   0.460000   0.670000 (  0.668866)
insert (without FriendlyId)   0.150000   0.450000   0.600000 (  0.598783)
insert (in-table-slug)        0.490000   0.870000   1.360000 (  1.359357)
insert (external slug)        1.770000   2.030000   3.800000 (  3.808227)
```

```
PATCH

------------------------------------------------------------------------
Using ruby 1.9.3 AR 3.2.3 with sqlite3 (in-memory)
Rehearsal ---------------------------------------------------------------
find (without FriendlyId)     0.120000   0.150000   0.270000 (  0.278280)
find (in-table slug)          0.110000   0.210000   0.320000 (  0.334384)
find (external slug)          0.260000   0.430000   0.690000 (  0.698892)
insert (without FriendlyId)   0.160000   0.430000   0.590000 (  0.597399)
insert (in-table-slug)        0.480000   0.900000   1.380000 (  1.387550)
insert (external slug)        2.010000   1.880000   3.890000 (  3.905083)
------------------------------------------------------ total: 7.140000sec

                                  user     system      total        real
find (without FriendlyId)     0.110000   0.130000   0.240000 (  0.246795)
find (in-table slug)          0.110000   0.220000   0.330000 (  0.336970)
find (external slug)          0.180000   0.480000   0.660000 (  0.671551)
insert (without FriendlyId)   0.180000   0.410000   0.590000 (  0.598598)
insert (in-table-slug)        0.440000   0.910000   1.350000 (  1.358312)
insert (external slug)        2.060000   1.790000   3.850000 (  3.866687)
```
`RUBY_ENGINE` is not defined in Ruby 1.8.7:

```
C:\Users\Luis>ruby -v -e "puts RUBY_ENGINE"
ruby 1.8.7 (2011-12-28 patchlevel 357) [i386-mingw32]
-e:1: uninitialized constant RUBY_ENGINE (NameError)
```
@zacc I can definitely do this without passing a url. I'll add that functionality now

@davehunt this is more complementary than an alternative. We want to be able to switch to frame independent of launching (say to go back into an app after you launched and switched into another one), but I can add optional switch_to_frame and url parameters to launch, so you can automatically switch into the launched frame if desired.
whitespace before and after the mdash?
Javadoc for public members.
I like the idea of having a stack of logs. I'll just refactor this myself after merging this request.
Нормально, если память будет пропорциональна максимальному номеру вершины?
It doesn't matter that much, but since the other RPC calls here return just a dictionary by itself, there's probably no need to wrap this with another dict.
The user API has userAPI. This should probably be groupAPI.
I'd prefer for this method to have a basic test as well.
I disagree that a role necessarily needs to be direct. When you have a role by virtue of a group membership, you still have that role and all of the permissions that come with it. I think it makes sense to have 2 functions here, one that allows you to check for a direct role and one that allows you to check for a direct or indirect role. I think we'll find that using the directRole function will be quite rare.

I do agree with the distinction you're making between roles and permissions, and fully anticipate that we'll start making that distinction. However, we should only be doing this when we actually have this distinction, otherwise I think we make the code more complex and confusing than it needs to be. In the old code, we weren't actually asking "Can this user manage this resource". We were asking "Is this user a manager of the resource" instead. As long as the permissions are based on the roles and determined in the actual modules, Authz can be simplified to just use roles in a consistent manner. Once we're ready to start assigning permissions to roles, we can expand from there rather than continue working with a confusing hybrid.
Couldn't you just use our IO.readfile function for this?
Same here I think
I've moved that bit of logic to PrincipalsUtil as it's required there as well and avoids a cyclical dependency.
I've added some documentation to the models explaining that extra information will be attached to it from outside the model file.
I''d prefer 

```
branch_cmd = ""
if branch
  branch_cmd = "git fetch --all; git checkout #{branch} &&"
end
```

for readability, but that's a minor thing.
Oh, sorry, my bad! Actually PyMongo doesn't do it - Must have the right type to query.
I don't get the purpose of this method. Should just call ```Time.now``` where we need it.
Missing spaces :)
А что будет, если в this.ctx.items строка?
this should maybe be `logging.root.manager.loggerDict[key].disabled = False`?
In other examples, the default is represented by a hashtag following nil, with the default/example. Maybe provide one here?
Если у вас в ячейке А значение А, то значение не заменилось. По поводу один раз - это для того, чтобы было изменено строго какой-то процент, чтобы не было такого, что ваш алгоритм какую-то (какие-то) ячейку (ячейки) заменил несколько раз. 
--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
не забывайте, что х - процентный показатель.
сделал немного по другому- через else if
это уже исправлено было
Hmm, this is bothering me. Why can't we retrieve students in the right order? This is retrieving things and then (on occasion) reversing the order of the retrieved list. I'd rather retrieve it in the right order immediately. thoughts?
насчет всех тестов, они должны читаться как документация, а почти нигде не понятно что тестируется. То есть вместо it exist хорошо бы написать it should have Edit User link
'undefined' is good.  It does what is says on the tin.
The class-level annotation should be `@ShardKeys`, since users may specify one or more fields. The field-level annotation can be `@ShardKey` later on.
It's now used in a context that starts at 0, whereas before it was used in a context that started at 2.
pep 257 :)
That would be more general, which would be nice. However, it seems like that would take a lot of re-coding, in which case it might not be worth it for now. I'd be happy with merging this in its current state and revising it later on when one of us feels the need to include PPC or other pairwise measures (or other crazy methods), especially since I think those could be made without changing the functions called by the user.

I assume using classes would also make it easier to do causality analyses later, too (?), but maybe those would go in a different module. It's hard to plan too far ahead, so it might not be worth puzzling over now...
please define the object like this:
```
var story = {
  title: newsItem.title,
  description: newsItem.description,
  link: newsItem.link
};
```
@weaverryan reverted ;)
一个请求分到第二个服务器，一个请求分到第三个服务器。
Why top level?
Хтмл-разметку лучше в tr не пихать, а обойтись конкатенацией строк.
Sobre los saltos de línea, tenés razón, pero esto se está mostrando en el tbody de una tabla.
I honestly couldn't make sense of the docs. I had assumed that get or set
returned an object, but got Nonetype errors.. Will look at your comments
when I get home.
On Mar 28, 2012 10:17 PM, "Patrick-Ranjit D. Madsen" <
reply@reply.github.com>
wrote:

> > +            snpObj = snp()
> > +            snpObj.snpid = int(snpStr)
> > +        tags = domain_tag.all()
> > +        self.out({'tags':tags, 'snp':snpObj})
> > +
> > +    def post(self):
> > +        # Add tag logic
> > +        snpStr = self.request.get("snp")
> > +        tagStr = self.request.get("tag")
> > +
> > +        snpObj = snp.get_or_insert(snpStr, snpid=int(snpStr))
> > +        if snpObj == None:
> > +            snpObj = snp(snpid = int(snpStr))
> > +
> > +        tagObj = domain_tag.get_or_insert(tagStr, tag = tagStr)
> > +        if tagObj == None:
>
> See [AppEngine Documentation](
> https://developers.google.com/appengine/docs/python/datastore/modelclass#Model_get_or_insert
> )
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/DIKU-DevStudio/PerseQ/pull/21/files#r617587
>
parent.something should not happen anymore, no ?
! done !
You could use cookies as a fall-back.
ok sounds like a valid point that it's not a good idea after talking with you.
Tässä olisi päässyt helpommalla käyttämällä `seq-max` funktiota.
Ignore that comment - Galder is right, why use a concurrent map at all?  :)
And don't forget copyright headers on new files
Why FORCE_SYNCHRONOUS here? Does it make sense to have a GridFS metadata cache configured with async at all? If not, and synch should be enforced at the cache definition level, not at the operation level.
Wouldn't it be simpler to use "<hey>ho</hey>" everywhere?
By making this an empty set, there is a lot of extra work that will happen.  This gets passed in to `notifyEvictionListener()` which has a short circuit if the set is null, but not if the set is empty.  This should either be null by default, or change the impl of `notifyEvictionListener()` to short circuit if the set passed in is empty.
Use the word "percentage" here to emphasize what you're about to say in your example.
Hi there,

This code is already in the master branch of your repo?

Ben
5は定数にしてください。
```python
In [1]: None is False
Out[1]: False

In [2]: None is True
Out[2]: False
```
can we change "Gaia" to "Firefox-OS devices"?
ну это уже обсуждалось вроде [там](https://github.com/onPHP/onphp-framework/pull/101/files#r852536) откуда это взято. 
про Form -- во всем файле раз уж так его архитектуру меняем.
"autoloader" => "chargeur de classes"
where should I put them?  this is what I had called about.
btw, if you init shogun with init_with_defaults() you dont need this method, take a look at other examples
and why set and map?

stl *urgs*
Parameters, function and other stuff should stay here