labofsahil/github-event-dataset-2012 huggingface dataset:
And it's not a composer *bug* per se. It's a side effect of all the auto-versioning magic and we can't really fix it, but given it only affects a few packages it sounds worth the benefits.
Since the error will be a fatal error, I can't link a assert to this test (since the test itself will trigger the fatal error).
what's the `jit` dep?
http://www.playframework.org/documentation/api/1.2.4/play/mvc/Controller.html
It's possible to have perfectly valid 2-point lines (e.g. cutting across a corner of a projection) - do you still need this filter? What cases does it fix?
That depends on whether you consider this control flow.  I'm of the opinion that it is.  I also think it reads better with `or`
After `When #{current_name} stops buying cards`, card locations will be checked. This means that any treasures auto-played will need to be updated to being in `@play_cards[name]`. And you're right - this fails if anything stops treasures auto-playing.
are `v` and `w` typical sort variables like `i`, `j`, etc for loops? I've never seen these.
Should `defaultApplication` move to `Ember.Application` instead of `Ember` ?
Tu peux sortir le Pattern et le mettre en static, il est threadsafe. C'est le matcher qui n'est pas threadsafe. Sinon "loggin" ce n'est pas très parlant, tu peux peut-être mettre "LOGIN" plutôt?
This is adding a requirement to the master HostController that it has a copy of every JSF module used in the domain on its module path.  I don't want to introduce such a requirement.
As I said above: "Btw. to test just install grunt-cli globally, then you can npm install when switching branches and get the right local grunt version.". Jenkins should do the same, then grunt-cli will take care of running whatever grunt version is installed locally. That works great with both 0.3 and 0.4, so I agree with Scott, we *shouldn't* add grunt-cli as a dependency.
We did discuss this earlier. The span is needed for CSS scope if a custom style should be added to this specific selectmenu.
Need to remove the generate report logic here.
be careful because onHideStart is not defined in the facade object
On second thought, let's leave it as is.  No need to change the identifier.
Just being told that `alert()` will not work. Filing bug.
I’d still think an `h1 + *` would be simpler. Why do you want to use another `<header>` element instead?
Not a great fan of having to add now 'parentNode' to all the targets in the event to get the element.

@etiennesegonzac you happy with this changes?
l10n.js and l10n_date.js are libraries too. Just move the declaration next to those one and remove the unneeded comment.
Create a goForward method that wrap that and attach it directly to the click handler of your element.
icc.stkMainAppMenu -> icc.applications ? (I don't have a strong opinion on it).
It's prepared in next pull ;). I could add it to this pull but I would prefer to go step by step, but I can add it to this pull! What do you think?
location.replace will affect history. I think that what you expect here but I just want to be sure :)

Also you may wanto to generate the url with:

var page = document.location.protocol + '//' + document.location.host + 'index.html#icc';
"set displayedApp as homescreen" would be done in openWindow(homescreen).
I would prefer that too. But should that apply to mongo as well? My 
intention was to be as consistent as possible.

On 2012-10-24 18:29, Daniel Pittman wrote:
>
> In lib/project_razor/persist/postgresplugin.rb:
>
> > +      # @param object_doc [Hash] The document to insert
> > +      # @param collection_name [Symbol] The name of the collection where the document is stored
> > +      # @return The updated document (with version 1)
> > +      #
> > +      def table_insert(conn, object_doc, collection_name)
> > +        uuid = object_doc['@uuid']
> > +        if uuid != nil
> > +          uuid = unpack_uuid(uuid)
> > +        else
> > +          uuid = SecureRandom.uuid.to_s
> > +          object_doc['@uuid'] = pack_uuid(uuid)
> > +        end
> > +
> > +        object_doc['@version'] = 1
> > +        begin
> > +          conn.exec_prepared("insert:#{collection_name}", [uuid, {:value => BSON.serialize(object_doc), :format => 1}]);
>
> I would generally prefer string-JSON to BSON for the data in the 
> database. It makes it easier for human debugging later, and a smoother 
> path to PostgreSQL 9.2 JSON column support.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/puppetlabs/Razor/pull/224/files#r1930538>.
>
We don´t use `index`, do we?
No, I´m concerned about the syntax. It´s a method, so it should at least start with a verb because the method name should describe what the method does. As already mentioned in my first comment `userWantsToSignUp` has a event-like syntax.
are you sure this is the right order?

(f1 + f2)(x) == (f2(f1(x))?

I'm not too attached, but I'd like to hear a strong argument for one or the other.
unnecessary residue
Yes, ok.
These should be using `Djinn.log_run` so that our mocks actually work, and running tests doesn't remove files on the user's computer.
Set this as default option (would be replaced in `__construct()` if needed) ?
Would it be better to point to the actual style guide?

http://google-styleguide.googlecode.com/svn/trunk/pyguide.html
Some old cpu doesn't have this file, eg, the cpu in my old laptop, T_T. so better to add try/except block when access this file below.
This seems to jump right into the downsides!  Another sentence or two about what Interpolate allows would be good here.  This is a great improvement -- let's highlight it!

The second sentence ("Interpolate doesn't..") can start a new paragraph, perhaps in a 'note::'?
Do we perhaps want to keep these two functions around as forwarding functions, with deprecation warnings?
nitpick: should be "is not None"; even though that's what was there before, might as well update it now.
using identifier now, what do you mean with "considered safe"?
thanks, yeah `blank?` is better. (Too many other frameworks in my head, currently)
The idea of those validations was to keep the stuff away from AR as long as possible in order not to bother it with stuff that I can easily check myself (to avoid creating a model instance just for throwing it away), or that might be valid in the model, but not in this context (e.g. author = person, public = true).
Oh, cool; I'll experiment with that.
I think you could do the translation like the strings above this one, so that you don't have to concatenate.

so, this should be `completed: "{file} completed"`
and in the js ` t('.completed', { 'file': fileName })`
(untested)
How about something like the following:

import random
rulenum = random.randint(10000,12000)
`options.errorHandler = options.errorHandler || errorHandler;`
Open question. Does each image need to be bookmarkable?

Personally find it annoying having to hit back about 12 times to get to the referring url.

 /cc @kungpochicken
Misuse of comma. Colon would be more appropriate here I think.
Never use `System.err.println` from a plugin code. If a build listener is not available, use `java.util.logging.Logger`.
Not sure what to do when pool is empty. Printing a friendly message and redirecting is good for the web but the api probably wants sth. else.
Yeah I was hoping to get rid of that cfx-py check once Bug 747434 ships.
rejcet -> reject
Drop the ' from the first it's
great question @shane-tomlinson - I'm noticing when I cancel a dialog I get an error from winchan inside the dialog (user closed dialog) then I get a null response - presumably both browserid code and winchan are trying to handle the cancellation case.  This defense ensures we don't multiply invoke client code, but we should probably go and remove the handling of client closing window in dialog?
@lloyd I removed this console.log message in 0a4c08e3b9747463593d6821138be48987a33abe
nit: please fix the indentation and the 'an output stream' part of the comment.
__whimboo__ wrote:
> Damn. ...

I happily do the needed extra maintenance work. :)
And then your loading seems something like

`raise ... unless clazz = try_load_class(class_name) || try_load_class(file_name.capitalize)`
Have you taken into account the situation where a configuration setting ends in a trailing slash?  I'm thinking the case where Windows users specify the path to a directory:

    confdir = C:\puppet\etc\
    vardir = C:\puppet\var\
That is the Ruby way, and there isn't much real problem with that. :)
This is incorrect, we want only the window to whom the event is addressed to be notified, not all windows.
Is this the only line that is actually new functionality in this patch? If so, can you please rebase this branch and only continue this one line? Doing cleanup/style changes among changes in extra confusing.
We now have a boolean flag for whether to simultaneously replay.  Didn't
want to clutter up the global namespace, so it's an argument to the Record
constructor.

On Mon, Oct 8, 2012 at 5:24 PM, sbarman <notifications@github.com> wrote:

> In scripts/background/mainpanel.js:
>
> > +      var panel = this.panel;
> > +      var record = this.record;
> > +      chrome.windows.create({},
> > +        function(newWin) {
> > +          //let the panel know which events it shoudn't record
> > +          panel.twinWindow = newWin.id;
> > +          //let replay know where to simultaneously replay
> > +          record.simultaneousReplayer.twinWindow = newWin.id;
> > +          //start record
> > +          record.startRecording();
> > +
> > +          // Update the UI
> > +          chrome.browserAction.setBadgeBackgroundColor({color:[255, 0, 0, 64]});
> > +          chrome.browserAction.setBadgeText({text: "ON"});
> > +        }
> > +      );
>
> I think that would be good. At least for when I debug stuff.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/sbarman/webscript/pull/1/files#r1790676>.
>
>
Why is it panel.jquery being checked?
@denixport  There are this in the code

> array('name' => 'Zend\Filter\StringTrim'),
> array('name' => 'Zend\Filter\StringToLower'),
Instead of using 'h', perhaps we should use constants? Imho that would make the code more legible.
Is this accurate? I would suggest something along the lines of 'Instantiate from plain mime document'
Why remove this docblocks?
I've just been experimenting with this, and I think the winning invocation is this:

``` ruby
begin
  require 'bundler'
  Bundler.require
rescue LoadError
rescue Bundler::GemfileNotFound
end
```

I will post additional information on #22 and rebase the relevant commit out of this pull request branch.
I just love how anal we are about this. ;)
Nah-ah! Look at the construtor. Also look t the javdocs for the class, same as FurnaceBurnEvent
I think I agree, although in practice it's probably fine.

Also aren't we making data only changes like this in a *data* migration?
page_name=aut.url)
Was thinking about ID lines yesterday, since we use git now they should all be removed in master as well...
Ok, I see what you're saying. I'll update it.
Oops, can't believe that I missed the url in TagDetail. Good catch.

For future-proofing, I'd suggest moving this logic to a different function (the escaping of "/" and "\" needs to happen in both as well), and call that from both sub Tag and sub TagDetail.
If that works in every instance, that's exactly what you want and I would feel very good about it :smiley:. I figured you weren't doing that because in some cases the referer might not be where you want to send them to.
no need for system packages here. Simply drop it.
idem as above, but now with 'wb'
import statement order
imports at the start of the file.
I don't understand this. It looks like dead code.
change JEE to Java EE.
why not hashcode?
Huh, again?
yea, you're right... :)
I think returning the validated string for the rest of the method makes the most sense.
I think we can handle this level of duplication, especially as there may be some differences between projects over time.
There should be a single new line at the end of the file, no blank lines. We should not ignore anything from PEP8 that's not mentioned in our style guide.
How do I get to/use this?
Don't know but i'll look into it
also have them use double quotes
A cue and exec are just plugins.

      //  Creating a one second track event with an empty end
      //  Or update an existing track event with new values
      Popcorn.addTrackEvent( this, {
        id: id,
        start: time,
        end: time + 1,
        _running: false,
        _natives: {
          start: fn || Popcorn.nop,
          end: Popcorn.nop,
          type: "cue"
        }
      });
It needs to be wrapped in a "canplay" event...

```js

asyncTest( "Popcorn instance integrity inside natives", 4, function() {
  var p = Popcorn( "#video" );

  Popcorn.plugin( "integrityTest", {
    _setup: function( options ) {
      ok( this instanceof Popcorn, "Popcorn instance accessible in plugin _setup" );
    },
    start: function( event, options ) {
      ok( this instanceof Popcorn, "Popcorn instance accessible in plugin start" );
      p.currentTime( 5 );
    },
    end: function( event, options ) {
      ok( this instanceof Popcorn, "Popcorn instance accessible in plugin end" );
      p.removeTrackEvent( p.getLastTrackEventId() );
    },
    _teardown: function( options ) {
      ok( this instanceof Popcorn, "Popcorn instance accessible in plugin _teardown" );
      Popcorn.removePlugin( "integrityTest" );
      start();
    }
  });
  
  p.on("canplayall", function() {
    p.integrityTest({ start: 2, end: 5 });
    p.play(1);
  });

});
Nit: This can be a completely empty file.
Yes, it should be within check.
I like alphabetized stuff.  We should do that.  Imports, constants, EVERYTHING!!!
self.host(hostname).is_host():
I added these for the sunspot piece because I was using a local Solr index (provided by sunspot_solr).  I ended up just using VCR for that Solr bit and didn't run a local instance, but I still use these migrations as a quick test of the Sfx4 search module.  I db:migrate them in travis and add some SFX fixtures and can do some sanity testing on the Sfx4 searching.
The PMID and PMCID will always be numeric, so no need to worry about non-numeric characters. The JSTOR ID there is actually a DOI, but if you wanted to match it via regexp you'd use ```/JSTOR\s*\:\s*([0-9\/.]+)\s*/```.
We should give the user an idea what it means to loose a lock. Can you find it back? No. And it happens after it has been locked. How about: "A lock can be lost after it has been acquired. It is considered as a system error that might happen. It has to be refetched/relocked". It might mean that somebody else grabbed it.
Why the each_char vs gsub, and why the selectively encoding?
This was later ammended to no longer upload shit and the description was also modified
I've seen this twice now. It seems like we wouldn't need to rewind the file since we don't appear to be reading it anywhere.
But what does this do? :P
L45 has the variable declaration with same name. the line is out of scope from the diff though.

```
    # Create a new IncidentLogger.
    def initialize(progname=nil, options={})
```
This line is suspect; it compiles to `return +(match != null ? match[1] : void 0);` which means that if `match == null` we'll end up doing `+undefined` which gives `NaN`. I'd rewrite it like so:

```coffeescript
+match[1] if match = pattern.exec $('Hand/Life')[0]?.text
```

This way we return `undefined` if a match is not found, which is necessary (I believe) to ensure that the `(hand|life)_modifier` property is not added in these cases.
My mistake for the other configurations.
You're right, we should do the same so ...

I propose adding an additional option param `cacheBusting {Boolean}`, apply the rewrite when `root` is set and `cacheBusting` is `true`, and so checking if file exists.
What do you think?
It will be safer and simpler here to to:

``` ruby
awards.create(:badge => badge)
```
I'll check. Might be even smaller to use a "<p>" tag.
@nawroth @peterneubauer how can I translate this part.

If I'm right it comes from here https://github.com/neo4j/community/blob/master/neo4j/src/docs/ops/upgrades.txt ?

Would making a branch for the *fr* translation a temporary option possible or do I comment currently these includes ?

Chris
We can modify to make use of closure. Let me know if you really need to change . I will do if this is worth for a merge only .
And by "this hunk", I mean `drop-constraints`, `drop-primary-key`, and `drop-foreign-keys`.
I haven't benchmarked it.  I can include that in the other benchmark card if you like.  My one concern was that I've seen some amazing performance hits in Java apps that are doing a lot of debug logging--even when the log level is set to something less fine than DEBUG--because it still constructs all of the strings for the log messages.  However, I checked the source code for our connection pool library ("Bone"), and they are doing "if LOGGER.isDebugEnabled()" before all of their calls to the logger, so that should alleviate that concern.

I'm happy to pull this out of the config if you prefer.
It seems like there should be a better primary key here, though I'm struggling to come up with on off the top of my head. It seems like there should be a constraint that prevents us from doing things like inserting the exact same report twice.

Is "id" just the command id? If we made that something more meaningful, like a hash of the report data itself, then that would prevent a race condition where a puppetmaster thinks it couldn't send a report, but actually did (say, when we add things like spooling to disk on the puppetmaster side instead of immediate failure).
I would like to rework this in a separate branch including #1 if it's okay?
I struggled with finding a proper name for it and settled on `start_if_empty`. What you propose would make the start value always not-null.
Thus always getting one column extra and disregarding the first one. (as in api-roles) which is different than what the getPagingParameters currently does.
Duplicated import :-)
You're right NSNumericSearch is not needed, I don't remember why I put it ;)
Maybe more reliable way to get the database name:

``` bash
ruby -ryaml -e "puts YAML.load(IO.read('config/database.yml'))['development']['database']"
```
mm... wouldn't it be nicer for the photo to have properties such as fileTitle and fileContent ?
could just use $( this ) and remove need for each function parameters
Well surely how the env detection is worked out and how it is handled (below) is as much config as anything else?
все верно, сравнение != умышленное, потому что фактически массив состоит из указателей на статические NSString, они определены в статической функции класса, то есть, например, если в двух разных ячейках значение "T", но это указатели на одну и ту же "T"
В описании класса метод назван mutate, а имплементирован метод mutator
Работает правильно, но при percent = 100 будет очень долго вариться.
Согласен с Рахимом, плохо читается такой вариант, хоть и имеет право на жизнь. Такая конструкция на первый взгляд сбивает с толку.

Скажите, есть разница:

do {
//some code
} while (--count)

и 

while (count--) {
//some code
}

И что нужно сделать, чтобы можно было пользоваться первым вариантом в вашем случае, если это возможно.

Всё же, когда есть что-то типа 
for(int i=0;i<DNALength;i++) 
читать легче - видно, что у нас итерации идут по i и ограничены по DNALength
@mvmn  очевидно человек был согласен с ним и исправил код, но замечание там есть, его можно развернуть
"freetonik discussed an outdated diff 8 days ago Show outdated diff"
почему нет? сделал их readonly в последнем коммите, они используются в категории
"Stirlingmootor" is alternative
sylius_blogger_frontend
Да-да, вот тут. На самом деле было бы очень круто также записать в @game в поле user_win_id соответствующее значение. Но это уже есть в другом таске, делать не обязательно, тут вопрос в другом: надо тогда переписать функцию, которая определяет, есть ли у пользователя не законченные игры (в index используется повсеместно). Сейчас она проверяет, есть ли у него хоть одна игра, у которой пуст user_win_id, а должна, видимо, проверять, есть ли игры без статуса :closed. Тогда и отпадёт твой вопрос в другой задаче.
Had to check for ``NULL`` here since ``m_closeLiveBrowserCallback`` is set null after the callback is fired.
The license header is missing
*`+mainThreadScheduler`
if (...) {
Readability nit: Add blank lines above and below the ```#put``` and ```#post``` calls throughout this spec, which nicely separates them into setup -> act -> assert sections.
have you tested this to confirm it works? those *are* regex metachars...
Ok. Any objections if I change the parameter name to "bandwidth" as well?
Please add some comments and documentation to the code and a little bit more logging information with clear messages. This helps in debugging errors.
@djazayeri 
Removed  wildcard imports as you suggested.
Nope but that is still a good change :)
there should probably be an additional test to make sure that the block returning false actually makes `matches?` return false - doesn't look like there's a test for that in here.
Why would you want to reuse *one liners* like that? Especially since the whole point of this low-level code is to be as close to the specification as possible for simple review?

You also completely ignored my comment on pointless conversions.
You still need to know the string length in order to bump `argv_data`. This is more efficient.
you mean to the children? because otherwise it’s like a normal failure
XFAIL means the test is expected to fail.  If you want to mark it as slow, you can use @slow.  If it passes after it finishes, don't use XFAIL, but if it's slow and it fails, use both.
Hay que eliminar esta propiedad.
remove 
```php
$request->get(...)
```
in profit of more precise getter
See my comments on the other pull request.
Good point, but it is not missing as custom ExecutorService is used in the constructor of DistributedExecutorService so there is no need to call shutdown.
I guess you both are aware, but just in case, chapter 7 of http://jcip.net/ explains the advantages of task cancellation with interruptions in quite some detail.
good point. I wonder if it can do all the directory stuff too?
why make the class the video id?
Again, two lines, start second with "if".
Nit: Unnecessary to explicitly call an unlock anymore since we call it in initial `cleanup()` https://github.com/mozilla/gaia-ui-tests/blob/master/gaiatest/gaia_test.py#L220
s/deosn't/doesn't -- also, is there a bug on file for clicking on the button not working?  (Should there be?)
Any reason not using unittest-zero in this test?
По поводу мултиязычности, тут наверно он снаруже должен приходить уже в мулти _() но вот с xml проблема, но для метагенератора тогда запускать _() те внтури метагенератора будет идти присвоение не просто $label а _($label) тогда смело можно переводить :)
Well I need a special list, this list takes into account, how often a elements has been chosen and always returns that one with the lowest numbers. This could be done without an own list but it makes it readable and I have less code.
Look that this property isn’t used.
Needs a blank line before the return.
Please put all this m2e crap into a m2e profile as you did for the lifecycle/pom.xml
Zvolil jsem nakonec "expire" - inspirace v linux kernelu.
@joshk frankly I had the same feeling after I wrote it, but was too lazy to do anything with that :D I will make it regular assignment
Big if/else constructs are not the most elegant way of implementation. Either move the code to another method or try to find another solution
perhaps this should remain .art-connections
Please don't put spaces inside the `if` condition unless the condition is so long that spaces makes things more readable. Here it should be

    if (size > 0) {
        ....
    }
Should the type for parameter ``$role`` not be "null|Acl\Role\RoleInterface" instead of "Acl\Role\RoleInterface"?
This is a new method used in sorting the backup displays
Don't change this line
Okey dokey. That's what dartlang.org is doing too, so I guess that makes sense.
Sorry about that ;). missed the "merged" message from @braddunbar
Nice......
Qualify boost::intrusive pointer names which are not qualified by default under GCC 4.7.x stricter scoping rules.
I think this should "throw" an UnexpectedValueException as well, but you can also put a type hint in the method arguments, e.g.:

    public function test($element, $value, $group = null, $input = null, JForm $form = null)

This is unfortunate design in hindsight because $form should really be mandatory, but we can't do that because it's at the end of the list.
shouldn't it be Liip ?
We're canceling a subscription. The phrase used here makes it seem like we're closing down an account?
Always write all arguments callback can get.
Why `staticfiles`?
lxml is additional library, not built-in. Move to separate part.
OK, so you are saying 25x25 is OK, then use it.
You should not need this.
No, you have to run both, no? Without `-d` (for Python and template) and with `-d` (for JavaScript).
mm what's this line for?
Can this be tested? If not, please remove the test.
I think that we should log the error class as well.
why 2 emty lines?
-SpellPair const _auraPairs[MAX_SPELL_PAIRS] = {
+SpellPair const _auraPairs[MAX_SPELL_PAIRS] =
+{
Some guys from our development team tested the encounter and reported a bug with the spell. The npc were shown with 1 life but had more.
This could be converted to a LINQ query.
felt 30... das kommt auf mich zu...
I like this change overall. I think there are a couple things that could make this a bit cleaner. We could make the form class a variable so that the form is instantiated in one line.

if request.user and request.user.has_perm('timepiece.view_entry_summary'):
    Form = timepiece_forms.UserYearMonthForm
else:
    Form = tiempiece_forms.YearMonthForm
year_month_form = Form(request.GET or None)

I don't think you that doing it this way is 100% required, but it prevents you from instantiating the form twice.

When handling the UserYearMonthForm, I think we should still obtain the month and year from the form save method. We could use super() in the form, and then return the month, year, and user in three tuple.
There has to be a way for me to turn this off. It gets me all the time.
`REMOTE_ADDR` is good as it is. This is standard constant string.
I'd prefer if this was done by cleanup() in test.sh. was the sdcard polling code there causing you trouble?
same here, wrapping json.dumps in try: except: is good practice.
I'll revisit this early in the new year.
Thanks for testing.
Then I definitely suggest we seriously consider a test suite. Writing that now will give us some reasonable confidence that a rewrite won't let features vanish.
There are several headers that have the wrong number of underlines. They will cause a REST error during doc build.

recommended: run make html to build the docs and check errors
indention problem
Absolutely, I'll update it.
You've convinced me to change it. Renamed to
highlightSeriesBackgroundAlpha, and reversed the direction with 1.0 meaning
fully visible background (no fade) and 0 meaning invisible background.

On Mon, Feb 27, 2012 at 9:26 AM, Dan Vanderkam <
reply@reply.github.com
> wrote:

> > @@ -78,8 +78,26 @@ Dygraph.OPTIONS_REFERENCE =  // <JSON>
> >    "highlightCallback": {
> >      "default": "null",
> >      "labels": ["Callbacks"],
> > -    "type": "function(event, x, points,row)",
> > -    "description": "When set, this callback gets called every time a
> new point is highlighted. The parameters are the JavaScript mousemove
> event, the x-coordinate of the highlighted points and an array of
> highlighted points: <code>[ {name: 'series', yval: y-value}, &hellip;
> ]</code>"
> > +    "type": "function(event, x, points, row, closestSeries)",
> > +    "description": "When set, this callback gets called every time a
> new point is highlighted. The parameters are the JavaScript mousemove
> event, the x-coordinate of the highlighted points, an array of highlighted
> points: <code>[ {name: 'series', yval: y-value}, &hellip; ]</code>, and the
> index of the data row corresponding to the x-coordinate. If
> highlightSeriesOpts is set, closestSeries is passed as an additional
> argument giving the name of the timeseries closest to the mouse pointer,
> and the callback gets called whenever this changes, including vertical
> movement."
> > +  },
> > +  "highlightSeriesOpts": {
> > +    "default": "null",
> > +    "labels": ["Interactive Elements"],
> > +    "type": "Object",
> > +    "description": "When set, the options from this object are applied
> to the timeseries closest to the mouse pointer for interactive
> highlighting. See also 'highlightCallback'. Example: highlightSeriesOpts: {
> strokeWidth: 3 }."
> > +  },
> > +  "highlightSeriesBackgroundFade": {
>
> I'd suggest including "Alpha" in the option name -- when I first saw this
> being used, I guessed that it was the animation duration (in seconds).
>
> highlightSeriesBackgroundAlpha?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/danvk/dygraphs/pull/126/files#r491784
>
I agree - this also impacts the DirectException.
This comment is about 3 lines too high due to the mid-review push.  Basically I was wondering if instead of prepending the filters we should instead require a "filters" div or something, so that they could be, for example, placed at the bottom or side.
Yes, I think that's probably true.  I don't think keeping `numpy` as the standard has any harmful effects, I just think the positive ones are mostly very low probability due to a strong (admittedly ad-hoc) convention in this one particular instance :)
I see, yes that does seem sensible.  I'll make that change...
Would it be possible to have a quick comment here about the difference between the `OLD_WAY`of doing things and the newer alternative?
2 return statements.
This is the python draw command, which does not require the .view().
So, the honest answer is that I copied @TallJimbo 's equivalent work at the end of the `galsim/fits.py` where the read and write methods are added to the Image class; I think I might well have forgotten the `del Class` myself.

However, in Jim's code there is also the comment `# cleanup public namespace` after the `del Class` command, which it probably would have been helpful for me to retain!  I think the point is that the loop through the iterated classes in the Image dict is happening in the main body of the noise.py module on import, and therefore unless there was a `del Class` there would still be an object called `galsim.Class` kicking around which would in fact be equivalent to an `ImageD` (this being the last of the four iters in the dict).  `del Class` gets rid of this... `galsim.ImageD` is not affected, and the changes to it (the new method) stay.  Which is a bit magical, but undeniably handy.

Have I got this right @TallJimbo ?
@crazyjul Just had a look, that looks wrong indeed. 
That said, to which stuff are you referring to ? the email I sent you or some GitHub issues ? 

From my understanding, this code removed the export of the common profile when a IDxMaterial holds a valid filename (to just export HLSLProfile).  I believe this can an issue because not everyone will support that, and fallback to common profile should always be provided for better interoperability. So I would uncomment this and allows the export of both profiles. What do you think ?

Also, some commented out code has been added (see after line 308 for instance ), could it be removed or is it here because of a work in progress ?
Do you really still qmake here ? btw `%{make}%` is automatically rewritten as `qmake` on BSD systems.
This is actually the third frame, right?  Since you're adding this to the frame with the change detected.
4?  or 1?
Using guava helper methods makes for more readable and maintainable code, e.g.
    Objects.hashCode(certificate, key, reuseSessions, targetIsSsl)

But don't feel strongly as long as nobody modifies this method by hand without converting it to use guava first...
agree ... but refactor doesn't get internal refs to e i've gone for e & exc here
Why does XSS needed to be disabled?
Assignment in the middle of expressions makes me sad... I can see the argument that you're just make a named function here, but it's still not immediately obvious what's happening.
Wow, that's brutal. How long do these conversions take? Does it make sense to spin up a worker so that we can pass the data there as a transferrable, and then do the slow send from there? I guess that would only (possibly) be necessary in the streaming case.
So,

```scss
$header-color: $white
```
Old standard is old.

HTML5 ftw:
http://www.w3.org/TR/html5/the-h1-h2-h3-h4-h5-and-h6-elements.html#the-h1-h2-h3-h4-h5-and-h6-elements
Please don't add this either. We want to test this gem against many Ruby versions, and not everyone uses rbenv. This should be in your `excludesfile` too, `git add` it explicitly on your private projects if your whole team wants to use rbenv.
_session_expiry is new to me.  what is that?
Actually, we can probably fix this by specifying $puppet::server::master_package as an array in the debian part of puppet params.pp...
Is a listener id a source's UUID? If so  might make sense to call it a UUID instead of Id?
unnecessary muesli style nitpick: & goes w/ lrentry_ptr :)
Really sorry to be making you jump through so many hoops, but this should inherit from StandardError, not from Exception.
I'm fine with that change as long as it doesn't break something.
Creaza o clasa cu o metoda statica pentru a evita duplicarea codului in fiecare catch.
Ah, you're using the BCCs as a fallback. However, that will not work as for every BCC you send the email, all the other BCCs will receive a copy.
How about you update the "mailtemplates" extension to support sending without recipient? Does the Contao core class & SwiftMailer support that? I guess we'll have to try and find out ;-)
Preferably use strerror_die -- nothing else uses stdio and I am keeping it that way to maintain the original daemontools flavour.
Using a percentage value means that bigger screens end up having a lot of wasted space at the bottom of the page, perhaps using a fixed pixel value might be nicer (e.g. $.viewportHeight() == 1342 for me so there's about 270px wasted).
Некорректное создание стрима. При исключении в BufferedWriter, файл не будет закрыт.
А если имя будет просто server?
Если res = Integer.MAX_VALUE, будет ли выброшено исключение?
This constraint has been changed, is this change still necessary?
TFR allows us to configure where the theme files are stored. We don't store our themes in the assets folder (essentially git submodules under #{Rails.root}/themes/{theme_name}.)

In this case the theme path is not added as part of the default rails assets folder.

It may be worth checking the existing paths in sprockets to see if the theme_root is already in there to avoid duplication.
What do you think?
Another issue with using NoSuchElementException for this purpose is that if another locator is incorrect that would cause the test to pass whether or not there was an exception on the input field.
there is no need to return anything here, this is not a property that returns something. if anything here we should raise an exception and cancel the test
Should I do this or do you want to do it?
Same as further down, if you move the render out of the `if` ... `else` block and put it down below you only need it once.
As far as I remember, XML regions of Scala are not considered as Scala part. They are considered as XML (HTML) part.
https://github.com/scala-ide/scala-ide-play2/blob/master/org.scala-ide.play2/src/org/scalaide/play2/templateeditor/lexical/TemplatePartitionTokeniser.scala
You should check:

```python
if hasattr(transformer, 'fit_transform'):
    return (transformer.fit_transform(X, y, **fit_params)
        * transformer_weights[name])
else:
     return (transformer.fit(X, y, **fit_params).transform(X)
        * transformer_weights[name])
How can that work with SVC in the tests? My PR that adds ``classes_`` to SVC is not merged yet afaik.
otherwise numpy complains about ambiguous broadcasts.
We need to add a deprecation warning if solver is passed in, and take it in account.
`x_test` -> ``X_test`` : should be true-type rather than italics, and probably should be upper-case
You do not need to use Identifiers here, string literals would be sufficient.
Is this comment still accurate?  I think it could be removed.

We may want to rename tibbtest to something a bit more precise in the future, maybe that's what that comment should say now
Still looks fishy:

`max * numberPart / max;` can be simplified to `numberPart` which is likely not what you intended.
s RootObject::executeScript function is too big, could we separate it into smaller logical pieces
No packages for these?
-1 this won't pass productization
same here. Let's keep it simple?
If I remember correctly the call to doBuildAliasValue just happened to be a way of solving the problem.  The commented out code was ideally what should have been called.  It would be worth going back and re-examining the issue again.

(We may conclude the alias call is the best fix).
How do you guarantee that they are mutually exclusive?  That must mean you are locking with a critical section?
This is crazy - you need to process the file in chunks not assume you will always load any file entirely into memory to process it.
Have you taken legal actions against this item? :D
Needs to say ```--target```
Can we do away with this? It's it obvious that someone wants to actually do a query from the other parameters? 

Using hidden input fields feels so 2002.
One thing to keep in mind is that in `#respond_to?` creates a Symbol with whatever is passed into it, and then uses that to see if the method exists for the object. Symbol objects aren't GC'd, so if you're passing in user input into the constructor it would be trivially easy for an attacker to DOS a machine this way. The same problem exists with `Class#public_method_defined?`.

Of course this assumes user input is being passed in directly, which is probably a bad idea, but since it's such a common idiom I figured I'd mention it.

This was a problem that affected both Sequel and DataMapper (which I'm the maintainer of) in the past. Both use the same general approach to work-around it: a whitelist of allowed methods is checked before allowing an attribute to be set.
I think @ochameau outlined it correctly. I would also remove `api-utils` from the list and hopefully from code base sometime soon & would put `namespace` and `event/target` to the top. Not sure about `event/core` though maybe also worth mentioning. Before `events` was used for both
emitting events and listening events and now it's event/target for listening and event/core for emitting.

P.S.: Those APIs have already landed.
Fix alignment (remove all spaces after $path except one).
This should be 

/*insert your API Key here*/
var api_key = 'xxxxx';
If you want ``sequence`` to be fully backwards compatible I suppose we could always re-instantiate ``self.sequence`` everytime ``iteritems`` is called. But ideally, I think ``sequence`` should be stored in one canonical place, and the most logical place to store that is in ``Table``.

Yeah if you don't mind having a slight backwards compatibility, I prefer making  ``table.sequence`` default to `...`.
@shacker Can we use the comment block style here?

```
/////////////
// Shacker //
/////////////
Jäi `let`:llä annettu nimi käyttämättä.
~~~clojure
(let [xx (+ x x)]
  (Math/pow xx xx))
~~~
kuten myös funktion has-a-living-author?
Yes but there will never land something like that because this is always a string from form.
I think this comment is outdated.
Since the function starts with an `_`, it is `@private` by default.
I can move the var closer to where it's used if you like, but otherwise they are just local private variables and we use them all over the place in the code.
Is there a test for this?
It would be better for this to be at file-level scope like `getExtentPosition`, then it will really be private.
This should be czm_moonDirectionEC.
Can we just use [Array.forEach()](https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Array/forEach) or [jQuery.each()](http://api.jquery.com/jQuery.each/)?
Can combine if statements
also needs `since: "2.1.0"`
This works great if you only set the label "text", but if you set "html", it measures the height of an empty string. Changing it to this fixed it:

    var text = self._textContainerDomNode.innerHTML;
One space before "{".
s/FileSystem/filesystem/g
http://thecodelesscode.com/case/41
это не функция, это параметризованный класс :D
So, here we call a destructor on a temporary  which equals`T.init` except can has a context pointer. And there is no [disabled] constructors. So this code compiles:
```D
T t;
T t = T.init;
```
So destructor should work properly with out temporary. Good. But the logic isn't obvious at all and should be written as a comment.
`did not have at least $(D n) elements.

It's better to have "at least" IMHO, but the big thing is that elements needs to be plural.
Thanks! - this makes me realize that we should add file:// too. I'll merge it in, and fixed that later...
s/contains/contains a/
The version will increment over time but yes these will always remain in synch.
例外をテストするなら、`assert_raise`使う感じですねー
http://www.ruby-doc.org/stdlib-1.9.3/libdoc/test/unit/rdoc/Test/Unit/Assertions.html#method-i-assert_raise
@mkai Can you make this `Class` extend `TumblpyError` instead of `Exception` and I'll go ahead and merge this in.
double ofToDouble(const string& doubleString){
	double x = 0;
	istringstream cur(doubleString);
	cur >> x;
	return x;
      }
OMFG! structured-mongoDB is sooooo pretty!
man too design hamchin harfi nemizanam
agar ham goftam ya eshtebah fahmidi ya man eshtebah kardam
dar programming 2 inkar ro anjam midim vali ba htaccess miyaym too root address dehi mikonim
higher first
does it really make sense to make the view handler optional, requiring to add this check ?
`/^(tcp|udp)$/` ?
you also need to map ``int`` as the MongoDB ODM uses it instead of ``integer`` IIRC
I am really not a big fan of this renaming of these functions.  I would rather see a new keyword added to colorbar that would specify whether it is inner or outer (and default to outer).
In that case, I would probably go for Christian's original suggestion as it is quite a bit cleaner and less additional code.
You could use only one function name if you
dispatch the version on the outside.
```d
version (OSX)
  void initPlatform() { /*...*/ }
else version (FreeBSD)
  void initPlatform() { /*...*/ }
else
  void initPlatform() { /* NOOP */ }
```
leaving as string might be fine since an invalid property name string would lead to a JMSException at runtime. That said, I don't think the rules for syntax here are very hard to imitate. Like I said, please refer to the spec. IIRC it's the same as java identifiers (e.g. start with a letter or underscore, after that can also include numbers, etc).

I'm not sure what you mean about 'LIKE/AND' - sounds like you are referring to valid selector values which is completely different than correlation KEYs.
No and they were not originally, but Gary was concerned with destroy(). The bottom line is that given the fact that those are a very low value maps concurrent or not it will not (did not) have any effect on performance.
Why the change to force the poller to be the first child elemenr?

This worked previously...

````

	<chain input-channel="pollableInput1" output-channel="output">
		<filter ref="typeSelector" />
		<service-activator ref="testHandler" />
		<poller fixed-delay="10000" />
	</chain>
````

While it probably makes sense to declare it first, this seems like an unnecessary breaking change.

Let's see what others think 
@olegz 
@ghillert 
@markfisher
Need two tests to show we don't override an already-present CT header, unless the attribute is set on the transformer.
I modeled it after the code in APE.createPoller() - I did remove one redundant CollectionUtils.isEmpty that appears there.

Copying to a local variable avoids issues with the field being changed while we are using it.

The isEmpty() test performs 2 functions - 1. it checks the field wasn't set to null between the test and the assignment; 2. It makes sure the chain is not empty - we don't want to wrap it in a proxy that does nothing.
I don't like the `====` Markdown syntax also. `#` is way better.
Please write comments in english ;)
List ALL requirements. So also depdendencies. You mostly can get that with `pip freeze`. (Sometimes you have to check if it uses repository, if installed from repository.) `brukva` is known to not work through `requirements.txt`.
mantiene > mantienes
The same with the rest of `:lineos:` in the PR
curly brace should be under the function, etc:

``` php
function method()
{
    if (true === false) {
        exit('wrong universe');
    }
}
```
Excluir esta linha em branco.
In order to emit generic AfterDeleteEvent. CascadingMongoEventListener catches events for all types of objects so generics are not used in this case but if someone would want to create his own listener for particular type then generics are needed.
With these headings, I'm afraid I have absolutely no sense that I could participate in developing this project at the Hackergarten. This blog has taken on the feel of a general project update - a very awesome, very complete report - but remember, the big, hairy overarching goal of this post is to encourage people to come come the the Hackergarten and hack on this idea. After the event we can do another post  to update the community on the progress made and encourage them to participate on the next steps online/next event/etc.

h3.

Hacking Logistics at the Devoxx 2012 Hackergarten?
Hack on Thucydides and Drone at the Devoxx 2012 Hackergarten?
Hack with us at Devoxx 2012?
def toBy(...) = filter match {
  ...
}

のように書くみたいです。全体的に直してもらえますでしょうか。
参考 → http://docs.scala-lang.org/style/declarations.html
Nitpicking here. 
In our current doc, most of the pages correspond to sections.
Should we convert this page title example into:

````
Title of the page
============

````
subclass must contains a key and not the real class name.
Ok. CS fix done.
```.eql?``` is generally not idiomatic; any reason to use it instead of ```==```?
looked at the other changes that moves ensureUDFContext() to Loader, but not used in Loader. Is that part required?
and how obvious in your eyes? "notEnoughMoneyToBuildDroid"? o.o
@scashin133 
just curious, how would this module be saved on the file system?  would the plugins folder have a socialcast directory (ex: `PLUGIN_DIR/socialcast/fake_attribute_map.rb`)?
inro rastesh eshkal dashtam ba ostad ke sobat kardam goftan kelasesho ba animation avaz konam ke ta shab dorost mikonam
khob mage chi shode? :D
ina ro bara IE nafahm neveshtam! :))
Will this still work properly in the case where you click the export tab while not looking at the map?

The point of having site/export as the URL was to allow us to do a full page load and switch to the map view when the we weren't on the map view  - when on the map view the click handler would catch it instead and the URL would never be used.
required stuff should be taken in the constructor instead of relying on setters
If you add a setter, your api clients will not break, but if you add a parameter to the constructor, they will break and hence correct their usage
#done. Please let me know if you have any feedback about the implementation 215d122a59d58a75b20e76f5cf0ab92dd0f3f73b
There is no click event on iOS.