labofsahil/github-event-dataset-2012 huggingface dataset:
well, finally the date is transfered in a long; but working with the
interface would still yield a date

Kind regards,
Andreas

On Tue, Jul 24, 2012 at 8:49 AM, Peter Grman
<reply@reply.github.com>
wrote:
>> +
>> +    /**
>> +     * Comments added to the document.
>> +     */
>> +    public List<Comment> getComments() {
>> +        return comments;
>> +    }
>> +
>> +    public void setComments(List<Comment> comments) {
>> +        this.comments = comments;
>> +    }
>> +
>> +    /**
>> +     * When was the document changed the last time. (Comments aren't changes.
>> +     */
>> +    public long getLastChange() {
>
> does date work well? usually there are many problems when translating date between different langauges and i think that OpenEngSB uses also long when you're asking for different versions
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openengsb/openengsb-domain-requirement/pull/1/files#r1222545
Based on code below, this doesn't have to inject grialsApplication, but just the "rejectIfNoRule" boolean.
This change came from David, but as I understand it, he made the event
type classes inherit from GerritTriggeredEvent.  All of the event
types emitted by Gerrit include the identity of the person who caused
the event, but the name for that field is different for various types.
I believe David may have been trying to simplify and unify that.  This
method is only currently called when setting the build parameters for
the job.  This will have the effect of using the uploader if the event
has a patchset, and otherwise substituting the identity of the person
who triggered the event for PATCHSET_UPLOADER (also _EMAIL and _NAME).

For reference, here are all the people-like attributes of the events
from gerrit, with the values that would be used by getAccount() marked
by an asterisk:

patchset-created: owner, patchset.uploader, uploader*
comment-added: owner, patchset.uploader, author*
ref-updated: submitter*
change-abandaned: owner, abandoner*
change-merged: owner, patchset.uploader, submitter*

(In writing this, I realized I have neglected to add author to
comment-added; I will fix that.  Also, ref-updated anticipates my next
branch, but it's good to get the design set here.)

I don't think backwards compatibility will be broken, since in the
current release all events are PatchsetCreated events, they will all
have a patchset.uploader field, and so won't need to call
getAccount().

I don't actually understand why the findUploader() method was needed
in the first place.  It says:

     * There are two uploader fields in the event, this method gets
       one of them if one is null.

But in the Gerrit source code, it appears to just copy the field:

    final AccountState uploader = accountCache.get(patchSet.getUploader());
    ...
    event.uploader = eventFactory.asAccountAttribute(uploader.getAccount());

I don't see how only one of them can be null.

I think the main question is, what should we supply as environment
variables for the build?  If I understand your suggestion correctly,
you believe we should not substitute any other values for
PATCHSET_UPLOADER and start adding event-specific build parameters.
Given all of the above, perhaps we should:

1) Remove findUploader()
2) In setOrCreateParameters, set PATCHSET_UPLOADER if the event has a
   patchset and it has an uploader
3) Set UPLOADER, AUTHOR, SUBMITTER, ABANDONER (along with _NAME and
   _EMAIL) build parameters as appropriate if they exist

How does that sound?
Add this to prevent users from updating other user's ratings because we find submission by calling `submission = current_user.submissions.find(params[:id])`, then we call `submission.rating`, so we make sure it is always for himself and we don't allow to mess assignments to change to other user's ratings.
The purpose is to keep a list of all running webviews created by any groups using this factory.  Do you think this is a feature we dont need?
the order is... "actual", "expected", "message" ...
Node has XMLHttpRequest module you can use to actually make a XHR request if you would like. I guess it has implicit problems related to actually get the XHR to call framework in a test environment but something to consider instead fo mocking the XHR.
I'm not sure but aren't custom context menu items supposed to be added after the menu service items?
We can simplify this block to webviewObj.autoDeferNetworkingAndJavaScript = !shouldAutoDefer, which looks a little weird.  Are we sure we want to set it to false when 'shouldAutoDefer' is true?
@rcruz - can you address this comment, I would like to close this soon?
use #include <plugin.h> instead it's in the path and safer
Fixed. thread_info pointer deleted in FindThread/SaveThread/RemoveThread.
If args and env aren't being used, don't add to the signature
Environment cache created at 09-02-2012? By pascal?
No spacing before brackets
`(- x)` would be sufficient.
This one liner was elegant, to be honest. String formatting is not exotic, and any person is probably aware that #AFAFAF is actually a hexadecimal number. There is no need to go back and check the definition of HEX_DIGITS. 

With "varying degree of skills" in mind, i'd say the one liner is simpler in that you don't need to know list comprehension and how it works, you don't need to have any idea about what HEXDIGITS variable is, or what _ is used for.