labofsahil/github-event-dataset-2012 huggingface dataset:
Without the 'highlight' check in render(), the radius would show up for 80 ticks when they are either highlighted or unhighlighted. Without 'justDroppedTicks = 80', the radius will disappear immediately when unhighlighted. So I've combined the two to make the transition smoother.
This line may be to ;-)

<pre>
      DESCRIPTION = open("README.rst").read()
</pre>

Or

<pre>
      DESCRIPTION =  open(os.path.join("README.rst")).read()
</pre>
ну да. тут надо определиться кто целевые пользователи этого расширения. и под эту аудиторию делать.
ридми да, никогда не помешают, я и сам не весь функционал noads точно знаю)
Around... 0?
Hello,
What db are you using ? :O
Can t run it with TDB : it said outdated db :X
Would you give me a download link of your actual DB ?
Sincerely yours,Jahz.
This test and the one below should be more comprehensive. `eval a.eval eval.b eval[0]` or something would be better.
Bug. The difference between the two colors is too subtle to survive the bit depth reduction. Overrides added in 39a779a.
I saw that Phobos 0.6.2 actually seems to depend on (a repackaging of) Mozilla Rhino 1.6R7, but it's hard to tell from the pom alone: http://uk.maven.org/maven2/com/sun/phobos/phobos-rhino/0.6.2/phobos-rhino-0.6.2.pom

If there really isn't any suitable js-engine on mvn central, I think we should deploy one ourselves. Maybe just try the phobos engine with Mozilla Rhino 1.6R7 - and if that doesn't work, we should deploy the js-engine. Does that make sense?
Алсо, сделай optional говно Limit действительно optional. Можно подсмотреть в Network.Lastfm.Track. Сам метод optional можно вынести в коре.
I would not test assertions. It is technically tricky, because the tests use assertions as well. If you want to test an assertion, it might be the case that either the method should throw an explicit exception instead of using an assertions, or that the test case would test something minor that should not be tested.
After a couple of hours we are seeing this issue coming up again. I added warn logging to `Buffer#<<` for starters.
ohcoxx, oisit voinu myös cd oikeeseen hakemistoon 1 kpl aluksi ::)))

t. BASHMON
Maybe missing a # prefix here before the color value.
@parndt @thomasdarde  ...aaaaand never mind. I see that that's exactly what's been done here. Sorry about that.
This works? Cos I can't set any currency, and type is for? 1 or 2 ok, but what is each value? can you show an example? please
abstract missing? But this can be an empty method {} that does nothing in the default case.
So to change two lines of code, you've copied the whole file, made those changes unmarked hidden in a massive "new file" commit,
and named the file in a way that indicates its a plugin for chosen.js? That's about the worst way I can think of to apply a patch to a library ;)
Windows should use the GetTempPath() function.  (The string always ends with a backslash - see documentation).
.start = 2073,
It should. And the message should be about failing to encrypt the record, not the key bundle.
assertArrayEquals()
@SubJunk - we must be in telepatic sync. I did the exact same fix to FormatFactory in my build as well :).
Made me lol
Challenges only has one 'a'. Probably good to fix the grammar in a couple sentences. Might be a good idea to break them out into bullet type points rather than just a big ugly paragraph.
because it's the most used Format  d-m-Y :D:D
How about using 

    /^bin (.*)$/

as well?
Yeah, I can't deny that. The type safety aspect was nice, but I'll make the change
I like to separate the included files like this:

```c
/* File own header */
#include "Game.h"

/* Headers from the project */
#include "PhyEngine.h"
#include "RenderEngine.h"

/* Library headers */
#include <GL/glew.h>
#include "FreeImage.h"

/* STL and system headers*/
#include <vector>
#include <iostream>
```
I think we can break the step function into smaller functions. The Game class already has a step function that we call loop() (or onLoop()) the PhyEngine can have specific function to update things on the world. Like moveEntities() moveEntity() checkCollisiton(Entity, Entity) checkCollision(Entity, World).

What do you guys think?
This seems very strange.  If you get an error 'alleged_crime' is never initialized but you're assigning it to a value here. If this happens wont it cause the application to crash?
That would require a language change. At the moment, I was just fixing the 
documentation.

On 1/19/2012 12:15 PM, Martin Nowak wrote:
> How about ".init" which already caused a lot of grief?
>
>
Hmm. Is that something that we have to do?
let's remove 'seems to' from all comments - for the reason I mentioned above.
Could you elaborate on these two changes? I know that ``basestring`` is used in ``path_import`` below, but I'd prefer to have the conversion done by ``2to3`` instead of doing it like this.
there's a couple of these to remove
Looks like my build script didn't pick up the Travis Env. I'll look into it in a bit.
We can extract a function to avoid duplication of specifying "{queue: false, complete: that._scrollPageCompleteHandler}" everywhere.
On the same note, could you update your changes to use the documentation style?
no need for volatile here, there is only one thread
you don't, and I don't think there is a need for that, this is similar to `ActorSystem.registerOnTermination`
This is not the way to do it, use intercept
fixed sealed
Or simply check the sender if it's the router?
Already opened: http://www.assembla.com/spaces/akka/tickets/2137
How often is this called?
this might be good enough, but it's not perfect
it highlights the version number in all search results
I think it would be better to use `site`, as described here: http://w3bguy.wordpress.com/2012/01/26/google-custom-search-restricted-to-specific-directory-and-filetype/

I understand that you don't want to avoid hardcoding the url and do the snapshot replacement, but it would give a better user experience, in my opinion
`http://doc.akka.io/docs/akka/<version or snapshot>/`
Yes, it should be properly encapsulated. The way it is defined with  
protobuf now will eagerly deserialize the payload part -- which violates  
the layering. I will change the protobuf definition after I removed the  
old remoting.
why? (meaning: we usually rely on automatic cleanup at the end of the test suite unless we have a reason to do it earlier)
it doesn't have to, but it's only used here, close connection to the binarySearch, I can make it private if you prefer that
No need to create a StringContext for a single param
Why not search all at once, using multivariate minimization?
two blank lines here for PEP-8
BLOCKER: See above about self.prompt.
Probably would be helpful.
BLOCKER: All public manager methods should have docstrings.
indexes is not declared as a VALUE, so I don't think this will compile under most C compilers.

If indexes is supposed to be a VALUE (from the return type of this function), you want to use one of the rb_ary_new family functions to allocate a ruby Array of the correct size.

Returning the pointer from a bare malloc() will crash ruby.

Not checking the return value of malloc() will crash any C program.
these are the biggest changes (and they're logically tiny, I think)
get should show form
Let's talk about this tomorrow, but I think we are missing a piece. This call should be on the client interface to Scn not the service itself. This client interface should allow us to cache sequence number and avoid a round trip on every transactions to a possible remote Scn node.
Ok, I changed the whole thing to:
```c++
void CGUIDialogVideoInfo::AddItemPathToFileBrowserSources(VECSOURCES &sources, const CFileItem &item)
{
  if (!item.HasVideoInfoTag())
    return;

  CStdString itemDir = item.GetVideoInfoTag()->m_basePath;

  //season
  if (itemDir.IsEmpty())
    itemDir = item.GetVideoInfoTag()->GetPath();

  CFileItem itemTmp(itemDir, false);
  if (itemTmp.IsVideo())
    itemDir = URIUtils::GetParentPath(itemDir);

  if (!itemDir.IsEmpty() && CDirectory::Exists(itemDir))
  {
    CMediaSource itemSource;
    itemSource.strName = g_localizeStrings.Get(36041);
    itemSource.strPath = itemDir;
    sources.push_back(itemSource);
  }
}
```
I noticed one more thing: yesterday we decided to take a **single** path for multipath shows, but the path of a season of such a show is a **multi** one. I don't see an easy solution for getting the correct path out of it; besides the way to use the, probably wrong, first one, which would mean another include. So maybe we should revise the decision from yesterday or just leave it as it is now, which of course is inconsistent.
Now I'm a PITA ;)
I think reg.GetReplaceString("\\1")[0] might be more obvious?
ptr check?
Blank lines can go away.
exactly - updated.
This mass shift of User to Account is a little more that a rename.  Now the User class is proxied (delegated) through Account so that we can connect other modules with that function.

There is still a lot of this.
This line actually does nothing... just going out of scope is sufficient to get rid of a.  delete is only used to remove structure members or array elements.
Yes, indeed, that was my idea.
`{` should be on the previous line.
This PR is simply moving **existing** code about. For now, for simplicity in this PR, it's just about making the testing process reusable in 3rd party twig extensions.  Optimizations should go in a separate PR.
In Twig, `none` is an alias for `null`. The dangers of using jinja2 and Twig at the same time...
Is there a reason why you don't  call `removeJob()` instead of throwing an exception?  Removing the job would prevent it from being scheduled.

I'm trying to fix [SPARK-643](https://spark-project.atlassian.net/browse/SPARK-643), which is related to this exception.
We should come up with a better name for this; maybe local-cluster.
Can we get rid of these, when it's ready for master?
Protože forma s dvěmi argumenty je deprecated, viz: https://github.com/nette/nette/blob/master/Nette/common/Callback.php#L33, phpDoc + 1. podmínka.
I had to add an `O` here to be able to try the binary ufucs...
Mainly because I wanted a consistent return value. Having it always return an array seemed the better option to requiring yet another branch...
There's a leftover `)` at the end of the comment :)
переименовать метод во что-нибудь понятное
You're changing the precedence by using `and` (note we don't use `or` we use `||`)

```ruby
@topic.user && @topic.user == forem_user
```
We should also stop looping at the moment we find the first symbol key, otherwise we are converting many keys unnecessarily.
Can not we use?

```ruby
if options[:config]
```
IMO this is a perfect place. Developer sees clearly where and how default headers are defined. Also, how is he supposed to remove them if he doesn't need Frame-Options? We cannot "hardcode" these values.
The `return` keyword isn't necessary here.
no, for the same reason.

On Thu, Jun 21, 2012 at 4:40 PM, Rafael Mendonça França <
reply@reply.github.com
> wrote:

> > @@ -192,6 +193,7 @@ def attribute_method_affix(*affixes)
> >        #   person.nickname # => "Bob"
> >        #   person.name     # => "Bob"
> >        def alias_attribute(new_name, old_name)
> > +        self.attribute_aliases = attribute_aliases.merge new_name.to_s
> => old_name.to_s
>
> Can we use `merge!` instead? `self.attribute_aliases.merge!(new_name.to_s
> => old_name.to_s)`
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/rails/rails/pull/6800/files#r1026447
>
I know.  I meant that the only changes with any meaning in this commit are initialization order. It actually changes from !sym.owner.isPackageClass to sym.owner.isPackageObjectClass (you omitted an important negation) and in this context, those are equivalent. "This context" means "when the only question is whether sym is in the package object of package pkg." If sym.owner.isPackageClass, it cannot be; if sym.owner.isPackageObjectClass it must be, subject to the remaining condition that sym.owner.owner == pkg(Class).
I'd remove the blank line.
Right, thanks. Fixed.
put space around the `-`

Also, these tests look fine with just one blank line. Perhaps you could edit the lines above that you increased to 3 and reduce them to 1...but that's not a big deal.
You should probably be wrapping this in a loop like:

```
pats = [_pat_sincos, _pat_tansec]
for pat, a, n, m in [pat(x) for pat in pats]:
    M = f.match(pat)
    if M is None:
        continue
    n, m = [M[i] for i n [n, m]] # powers on each trig func
    if not n and not m:
        return x
    a = M[a] # angle arguments
    break
```
On the other hand, this would invalidate a lot of tests.
On Sun, Apr 15, 2012 at 11:05 AM, Sachin Irukula
<reply@reply.github.com>
wrote:
>> @@ -236,6 +236,11 @@ def test_issue936():
>>      assert sign(x).expand(trig=True)    == sign(x)
>>      assert arg(x).expand(trig=True)     == arg(x)
>>
>> +def test_issue3206():
>> +    x = Symbol('x')
>> +    assert Abs(Abs(x)) == Abs(x)
>> +    assert Abs(Abs(Abs(x))) == Abs(x)
>
> @smichr I have modified the test cases and squashed them, but i have a doubt  if <code>arg.is_nonnegative </code>is placed instead of <code> arg.is_positive</code> and <code> arg.is_zero</code> then its showing errors such as http://paste2.org/p/1979595 if <code>arg.is_zero</code> is true the <code>arg.is_nonnegative</code> also should be true
>

You spelled it with 1 n instead of 2 (is_nonegative instead of is_nonnegative).
This docstring is not formatted properly.
I guess this doesn't take into account Turkish letters.
Is it possible we could just put this formatting into the `_diff_message` function that `assert_equal` calls, then replace all uses of `assert_sets_equal` with `assert_equal`?
Ah, I see - I misread this and was thinking in the ``if`` statement you meant to return something else, but I now see that it gets set to `self` as well.
all tests are added with this line to make the test portable.
Since this flag might be changed by a different test I want to make sure it is in its false mode.
There are other solutions such as make sure that if other test sets it to rtue (like the init tests then it would also set it back to false. To use this approach?
Shouldn't need base_class here since you did it above. votable.class should be enough.
What protection do we have from some sort of state problem that stops us from ever clearing out the currentlyTerminating list?  Would probably be good to start emitting alerts after some amount of time has passed and it still isn't clear.
every other sentence begins with the words "the following" which is consistent but also makes things easier to not read and therefore miss/skip over
in 2.2 there's also a field for tags for each host
Yes, that's [bug 759368](https://bugzilla.mozilla.org/show_bug.cgi?id=759368) mentioned in the comment.
True, it's just how ./manage dumpdata exports ;)
You should also check for the actual message here, although this test is marked incomplete.
I think the constants should be removed from includes/constants.php
They only might confuse afterwards.
Instead the constants in question should be part of the migrations (tm) set later
this doesn't look right.
You don't need the brackets around the `request_var` here.
Thinking about, though, i may at least rename these error methods the be easier to understand for Extension authors. For example, this one would be phpbb_controller_error::unauthenticated() and 403 would be phpbb_controller_error::unauthorised() and 404 would be phpbb_controller_error::not_found().
This probably should be rewritten - you can keep the last sentence, but, please, state after it what is a real problem (IE throws error); "not liking" is not serious problem...
Should be "copyright before" since there could be a "copyright after".
The method name is called locate_source_files() and the variable name is $files. However, the return is one file. I recommend one of the following:
1. Rename the method and variable name to be singular so that people don't get confused by what the method does
2. Add a second boolean parameter that lets you return all located source files as an array
Should be cleared again.
We will have to put things in a retry queue here eventually, right?
Add this to the inputs for collector.zip so it isn't included in the zip sent to customers.
Why these are not initializers?
They're not odd. Feature name can't be 100% canonical - it's just a small summary. And feature number says the number of C++ document (NXXXX) which describes this feature.

For the future I'll prefer to stick to fearture name+feature number pairs here.

P.S. Please note, this script isn't 100% complete, we should improve it for needs of development.
Fair point. I'll make it a point to remove it from the repo until I find something suitable. It turns out there are more out there now than there were six months ago. If anyone has particular suggestions, I'm game, but I took a quick look at those listed on this [stack overflow post](http://stackoverflow.com/questions/1890434/javascript-library-for-drawing-graphs-over-timelines-zoomable-and-selectable)
Why did you add ```class="standard"```?
The indenting of this line if wrong
This package should probably be moved into the pythonPackages set and use the buildPythonPackage function. Other than that it looks good to me.
I do not believe that is necessary as the list return by ```coord_dims()``` cannot be not be modified by any subsequent changes to the cube.
By default, ```Iris``` directory will be lowecase.
I updated the code to use a spin loop to check the condition. It will spin for about a minute before failing which is 60x the tick interval. On my desktop it terminated in iteration 6 of 1000.
WRONG. 

please read about django fields to know how exactly do they work
yeah.. I tried that and I came to the conclusion that files that are
included from app should have the "app/" removed. But files that come from
some where else should have that part in the path to avoid confusion and
namespace conflicts.

Example 1:
config.coffee
  paths:
    app: [ 'app', 'widgets' ]

widgets/date/calendar.js will map to moduleName 'widgets/date/calendar'
and called as:
require('widgets/date/calendar')

Example 2:
config.coffee
  paths:
    app: [ 'app', '../widgets' ]

../widgets/date/calendar.js will still map to moduleName
'widgets/date/calendar'
and calling it as:
require('widgets/date/calendar') or require('../widgets/date/calendar')
will still work


On Tue, May 1, 2012 at 5:42 PM, Paul Miller <
reply@reply.github.com
> wrote:

> > @@ -29,7 +29,7 @@ module.exports = class SourceFile
> >        moduleName = JSON.stringify(
> >          @path
> >            .replace(new RegExp('\\\\', 'g'), '/')
> > -          .replace(/^app\//, '')
> > +          .replace(/^app\/|^(\.+\/)+/g, '')
>
> nah, `@config` would be undefined
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/brunch/brunch/pull/264/files#r758768
>
The `ukeysort` here just serves to fill in the blanks in the ring where the local zone had no shards, right?
Yes, correctly. I did not want to deteriorate performance.
Is this line necessary? This is already happening before the if, right?
Yeah, it's not a big deal for now, just something to keep in mind
Something like:

`if [[ "$PTHREAD_CFLAGS" == *-pthread* ]]; then`

?
PHP has no distinction between associative arrays and numerical arrays. It is a very blurry thing. Either way, when an "intended to be" associative array is empty, `json_encode` outputs an array, not an object.
I also tried gpdb 4.2.2 in redhat server. The error message is still the same. Please see the message below. The error message is not very helpful for users.

ERROR:  plpy.SPIError: function madlib.mlogregr_irls_step(double precision, integer, double precision[], double precision[]) does not exist (plpython.c:4648)
LINE 6:             madlib.mlogregr_irls_step(
                    ^
HINT:  No function matches the given name and argument types. You may need to add explicit type casts.
QUERY:  
        INSERT INTO _madlib_iterative_alg
        SELECT
            1,
            
            madlib.mlogregr_irls_step(
                (y),
                (3),
                (x)::FLOAT8[],
                (st._madlib_state)
            )
            
        FROM
            _madlib_iterative_alg AS st,
            madlibtestdata.mlogr_incorrecty_decimal_observations AS src
        WHERE
            st._madlib_iteration = 1 - 1
        
CONTEXT:  Traceback (most recent call last):
  PL/Python function "compute_mlogregr", line 27, in <module>
    return multilogistic.compute_mlogregr(**globals())
  PL/Python function "compute_mlogregr", line 178, in compute_mlogregr
  PL/Python function "compute_mlogregr", line 96, in __runIterativeAlg
PL/Python function "compute_mlogregr"
SQL statement "SELECT  ( SELECT madlib.compute_mlogregr( $1 ,  $2 ,  $3 ,  $4 ,  $5 ,  $6 ,  $7 ) )"
PL/pgSQL function "mlogregr" line 32 at assignment
You assume that, but don't check it?
Actually, I have never seen such a SRF that returns NULL value (not a tuple cotaining NULL value).  I'm not even sure if it's expected.  With SRF_RETURN_NEXT(), you always return the Datum.  if you set fcinfo->isnull to true before SRF_RETURN_NEXT(), it might be possible to do it, but again it's not common.
Can't do this, the sources are not available when this method is invoked (by `brew test`).
You mean `if ARGV.build_universal?`, and also this is missing an `end`.
If the OS X one works, we should use it.
This doesn't match the option above.
Yeah, it does get confusing quite quickly unfortunately. Not sure what to do with this comment other than acknowledge that yes, this is painful.
shouldn't all this go in nanops? There's duplicated logic here
pep8, spaces, kwargs
I had some issues with paster when doing it this way.  It seems running this in the context of 'paster run' screws up the automatic test detection, which is why I created a TestSuite and a runner to do it specifically.  I'm open to suggestions that would make this play nice with paster.
Yeah... thanks for the fix.
It's complicated pages like this that make me really dislike doing page definitions in yaml instead of haml.
Is all this to add a border next to the toggle button when it exists?
I don't understand this example--Menus don't have a selected state (only MenuItems do).
Good point. Can you file an issue?
This is a bit of a chicken-and-egg problem because jsTree sorts *after* the item is created, but *before* any callbacks are made. 

I added an explicit `.sort()` call if the new item is a folder. I don't have a Windows system here to verify on, so hopefully this will work :-)
For the second problem, we only need to dispatch add/remove events if these events are not triggered by the add/remove menu items.
This introduces a bug when executing the following steps:

1. start a fresh IDE
2. open a javascript file via the tree
3. open the runpanel
4. add a couple of configs (prolly 1 is enough)
5. delete the configs
6. open the dropdown for the runpanel:

Uncaught Error: aml file: [line: 0] Unkown filename
Process: Converting XML to Xpath
Message: [0] Error xml node without parent and non matching context cannot be converted to xml.
Related Markup: <config path="plugins-client/ext.testpanel/package.json" name="package.json" extension="" args="" a_id="0|3"/>
Let's not do pathname replacement to build URLs but rather info thats on the ide object
Add simple verification for directories that should be there.
My problem is up at lines 128 and 147 where I'm toggling back to flex box explicitly.  I'm open to suggestions on that.  I'll see if I can make it all point to CSS instead of explicit assignments.  That should allow for -moz and other vender support.
There are three changes here, only one of which is *necessary*.

1. Remove hoptoad
2. Sort alphabetically
3. Change double quotes to single quotes, as is used in require statements within the project
Use I18N, this description is seen on the SQL panel function list.
It's not the "nearest". It's the index where you have to insert your new element if you want your collection to stay sorted. I find this comment confusing.
Well this has me officially terrified how many other instances of this anti-pattern there may be in iMedia's code.
*BUTON IN LINK TRANSFORMATION*? Improve this. ;-)
Use `facebook_token`.
Please be consistent with indenting: are we using two or four spaces?
What is this? You really believe this will tell some later developer what has to be done?
I think it's perfectly legal to not use quotes in all browsers, but we generally include them, so let's continue to do that
lets remove this extra white space here
I'd argue that this isn't enough actually. Instead, why not put this in `main.js` where it can be emitted from the Butter object and will have the correct `<html>` wrapper already.
Sorry: my problem here was that `trackBottom` isn't a variable at all. Is this supposed to refer to `lastTrackBottom`?
"fiction","icon need space after ,
Spacing on these two.
Why `**`? I think you meant

   find -name "*.pyc" -delete
Or maybe just a bit of javadoc to clarify behavior
fixed the installation directory error with the DSO module when creating a RPM package.
Comment describing this in more detail would be nice. What's the unit?
we should just add dnslabel to pdns_server
Do print at system.out instead of log
Okay, just checked the rules.

"...define a tree node class and methods, a tree node record and procedures, or an algebraic data type and functions, or…"

We'd fall under the "record and procedures" category, and you've done exactly what is asked.
can you add index to this column?
Do you really want to render nothing? Would it  be useful to return some basic text error message here? What's the scenario that hits this error condition?
I think you need this pack here.
See the comment above about guidelines.
That might be a good idea.  Although for 0.1 I just sent mine up to the OpenPGP servers as the instructions directed in this file.  Isn't that  good enough unless we're worried about someone revoking their key?
I think it's supposed to be  `` :ref:`operations on masked arrays <numpy:operations-on-masked-arrays>` `` (note the ``:ref:``), although I've not used this, so YMMV
Ah okay, I see what you mean now. Added Examples like you asked.
By default, the base templates are in ``sphinx/ext/autosummary/templates`` in the sphinx package, so I wanted to mirror that. I tried for hours to get it to work by having the templates in docs/templates, but failed. This was the cleanest and easiest in the end.

If you figure out how to do it with ``docs/templates`` let me know though.
I think this method should be retired. It can be changed to use the model class from ip scheduler and hide the model class for ip leasing operation.
4 bytes magic, 4 bytes block length; that's just the file format of blk*.dat.
If I set the focus on an element in a widget instead of the widget itself ... perhaps I find the answer via a web-search. Sounds pretty logical though.
I'd also change the return to false, inside the if, in the code docs says that will return boolean

```php
/**
 * If $uses = true
 * Loads AppModel file and constructs AppModel class
 * makes $this->AppModel available to subclasses
 * If public $uses is an array of models will load those models
 *
 * @return boolean
 */
	protected function _loadModels() {
```
`FALSE` should be `false`
It works, but is it a suitable way to do it?
If so where should we add this?

Ext.layout.FormLayout.prototype.labelSeparator =
OpenLayers.i18n('labelSeparator');

On Thu, Nov 22, 2012 at 11:46 AM, Stéphane Brunner <notifications@github.com
> wrote:

> Ext.layout.FormLayout.prototype.labelSeparator
Cleanup the cookie generated by WIF. That cookie contains the user claims and will be used to populate Thread.CurrentPrincipal with a ClaimsPrincipal
Do we really want to have this in every test? Perhaps you should just provide your name and not the email?
nasty tabs here and just below
Sure, it was for the eventuality of unit-tests for the install-git functions.
Ah, I see.

So I'm guessing after `__KernelReSchedule()` returns, the code (and `currentMIPS`) is potentially on the other thread?  Makes sense in a way, but works against usual threading experience.

Will probably clean this up tomorrow.  Guess I'll keep it wrapped but void with a note as you said.  Almost want to make a separate template to resched with the func name, but that's probably overboard.

-[Unknown]
Changeset = require "../lib-etherpad/Changeset"
I guess this is acceptable, but it is not how I think of filemode normalization at all. I would probably write something like:

```c
git_filemode_t fmt = filemode & 0170000; /* S_IFMT */

if (fmt == 0100000) { /* S_IFREG */
    if (filemode & 0111) /* any execuable bits set? */
        return GIT_FILEMODE_BLOB_EXECUTABLE;
    else
        return GIT_FILEMODE_BLOB;
}

if (fmt == GIT_FILEMODE_LINK || fmt == GIT_FILEMODE_COMMIT)
    return fmt;

return GIT_FILEMODE_TREE;
```

I know this is already merged, but I thought I'd put this alternative out for comment anyhow... I'm slightly wary that if someone passing in 0160001 that the above will convert it to 0100755 instead of leaving it as 0160000. I feel like an error of accidentally included permissions bits on a commit or link shouldn't normalize it into a blob executable.
update comment, not avg
what if d is null?
Looks like there's an extra space between `}}` and the quote.
This if/else block is in here twice. Might be better to turn it into a function, but I'm on the fence about it.
I think that we should still leave this call at the end of the loop, so that we do not spin the event loop if the result is not a boolean value.
I had tried that before, but I get: bad result object data missing key: Cannot assign "<User: camd>": "Result.created_by" must be a "User" instance.
I believe the User object in the bundle is not a Django type user, it's a user in the request data.  Tastypie doesn't have any knowledge of the MozTrap User model.  If it did, it's possible it would have constructed the right type of user for me, but in this case, it does not.
again, IndexError instead?
Why does not use just like that <code>unless url.blank?</code>?
True, although I wanted to help people get started with a standard template and such.
Ok, I guess I did not know/think about that the connection was available as a service.
What is the service id of the DBAL connection?
And what is the full name of the interface to use?
@lmcd what was the reason to check for the color support ?
http://help.github.com/line-endings/
there is already another PR for this. You should keep your PR limited to its purpose IMO
Thanks. I have fixed that now.
Again, it is not necessary to change the quote type. Here even more so, as the previous string with the nested quotes was more readable.
what's all this?
dunno, looks the same to me.  might be replace tabs with spaces or something.
Discussed offline.
The names are legacy. I'm totally open to changing them.
So, I do still agree with the point you made, but after taking a closer look at this test I think we're probably okay. The only reason I say that is this test is actually testing that multiple invitations get created. When trying to stick with the one assert (or should) per test policy that is generally viewed as the norm (like with any other CS norm though I see plenty of excellent examples of exceptions) a count is appropriate here.  We're also protected because the step above is testing that event created is for the same person we posted the information about. 

All that said, I'm still open to making it more specific if you guys think it's best.
Large input derivatives (remember, this could come from any foolish computation in a shader) could still lead to arbitrarily large axes, even in this formulation.  I think the clamp is probably still prudent.
style nit: i'd remove ": null", it's the implied default, just use "{String baseDir}"
I am also thinking that maybe this should be a <ul> list.
I prefer "Showing _TOTAL_ nodes"
``$filter`` is undefined
Note to self: PrivilegedAction
integration ... fb integration do you prefer  renaming it?
I knew it, witchcraft!

Could be good to add a comment to this effect when you next touch that code.
This code was in the gallery app because when I first implemented the share activity there were no apps that could handle it, and I didn't want clicking on the share button to do nothing.

In your case you don't need this code because, there will always be the bluetooth app, and you're linking it to a long hold rather than an actual button.

So I'd take this NO_PROVIDER case out and just do a console.warn here.  It means that you don't have to add a new string, which is nice, too!
Indeed, we are setting the contact photo to the little arrow (default value), the photo of the contact if any or none if there is no photo associated to the contact.
and by removing this part you don't need the `this.token` anymore.
I would clear this somewhere in the transaction complete phase...
self instead of this?
so maybe you don't even need the instance variable `this.downloading` as you could directly use `app.downloading` everywhere ?
2-space indentation please
you can use evt.application here and put this function out of restartDownload :)
It makes me happy to see SQL, indexedDB has killed all my pleasures about it!
sorry, don't remove this line, but add 

`if (!alarm) alarm = this.getDefaultAlarm()` above.
This code do inherit from settings.css so that's ok right?
It's all one word? (Mozillalabs)
Oh. Good catch. I meant to remove that as I made it unnecessary via the previous line.
why 0.2 and 0.85? this will make a distribution between 1min and ~4min, not between 0 and 5.
Done, `nimbus.local.dir` is used only for local mode now. The path used for local storage impl is `STORM_LOCAL_DIR + "/nimbus/"`.
This regular expression could also capture wrong anchors.

`<a title="hello">blah blah</a><a href="test">test</a>` will be captured only once and will probably result in `<a href="test">test</a>`.

Could that happen?
This isn't part of the rest api.
do we still use a fakeroot?
Remove all these trailing newlines.
Is it ok that nothing happens if the connection is already closed? If so, document that above in the docstring.
These are my changes. What commit did you merge with? I can move this branch to it so that only your changes show up.
small nitpick but you use `<file>` first then reference `<path>`
I think someone requested me to add this to the PR? Maybe @bergerkiller but i'm not sure :P
No, because some tests assert that it's ``[]``.
This can just be `return self._get_hit(key)`
You should inject the configuration instead of creating a new one.
Ah sorry, i missed that.
Well that's an annoying oversight :/

That function can be copy&pasted into leiningen because it shares the same license (EPL) as clojure (and clojure-contrib). Subrosa isn't licensed under the EPL, though. And since (I believe) that license is *more* restrictive than BSD, so I don't think we can copy it like lein has
Yeah, and it should be called the I/O monad...
Kill off edition here (you can pick it up in the controller without making it part of the URL)
Well, depends on the UX of it - I've never seen a design that renders it this way and I guess that's a larger initial download. When the JS kicks in it effectively does that anyway, loading them on-demand. Up for discussing it with UX etc but I quite like the fact that loading this page will just request the one image, not the entire lot.
Add level on next line:
$level = 'menu';
If you already have a hash (event is a hash, right?), you probably don't need to convert it to json to have logstash convert it back into a hash

Since your 'event' is already a logstash event, you can just do: 

```
e = LogStash::Event.new(event)
e.source = @sitename
output_queue << e
```
To read the URL of the document you could use [document.URL](https://developer.mozilla.org/en-US/docs/DOM/document.URL), if you need to access to `location` object it's better use [window.location](https://developer.mozilla.org/en-US/docs/DOM/window.location). That's because [document.location]() is not part of any standard and if it's possible is better follow them (for consistency and for a better future proof code).
Ah ok. So if the only case where we do not get into the `if` is when `selection` is null then it is fine.
We might just miss some edge case where it ends up being nor null nor a nsISelectionPrivate.
I like.  Ensures that we keep this current with future api changes.
i feel like i have failed to communicate. 

this line should have been changed in pull 2366, where i pulled out the --email and --password flags out of browserid's copy of bidpom. in the bidpom repo proper, this line will be wrong as soon as pull 2366 gets merged up.

i clearly messed this up by both forgetting to change this line in pull 2366, and for submitting pull 2366 while there were outstanding changes in bidpom that hadn't been merged down.
this should be process.env.VCAP_APP_PORT || settings.options.port to make it work under petri. You can do it in settings if you wish.
The meta tags is not important. So its okay to leave it.
That would be hard from the same reason: we don't know where puppet will be installed. We can also drop this functionality, but it will impact readability of errors in Ruby DSL.
git commit hash really, not github specific
Shouldn't this be `ret.should equal(x)`?
For the second sentence just say that this extractor performs no work and always returns the empty list.
Is this supposed to be a child selector for .no-js?
Why is this method removed?
Same as previous note.
IMHO we should avoid this kind of comments
Do not skip
no space between '...( super...'
missing empty line after 21
Should be `// CraftBukkit start - Reset location in favor of kicking`
That's really stupid. It should at least say something like "Have you installed anything yet?".

Anyway - manually making the directory is fine.
isn't there a typo here ?
Sama kuin alempaa.
Can you point me to these bug reports?

I briefly talked with @beberlei about this yesterday, and he thought it was a bug.
Why `search` here and not `all` or another custom scope?
The iterator is already a protocol and as such it already defines its own
type. All we need to do is:

    @type t :: Enum.Iterator.t

:)
Changed to:

   * Gets a List[T] of docs returned from Lucene.
Thanks a lot for that hint! Got multiline metadata to work with kodos. :)
factor out common prefix, e.g. use `srcfile = os.path.join(srcdir, "bin", "SOAPdenovo-" % suff)`
didn't we decide upon  some example.com here?
`configopts` at the bottom, `toolkitopts` with `toolkit`
Ah that. Well you can configure that yourself, it will blow up if you use something incorrect. I'm not sure how to validate that.
Ah! Sorry if I was being unclear, but I had `ROLE_HWIOAUTH_{$token->getResourceOwnerName()}` in mind. That way you can do things like "you need github for this page" or "twitter for this action".
remove spacing inside parenthesis.
```python
ua = request.META.get('HTTP_USER_AGENT')
return ua and ua.startswith('facebookexternalhit')
```

More succinct. I guess I just don't like `else: return False`. Seems verbose or something.
This `if` clause could be nested inside the next `if` clause to safe a test every click. This is async so it's probably not a big deal, but if you feel you need some optimization...
Django-browserid provides the JS to bind the persona code to buttons/links but not the actual persona code. See https://github.com/mozilla/django-browserid/blob/master/django_browserid/static/browserid/browserid.js
Backslash should be unneeded.
This is used by db-migrate. I need to patch it to accept this as a JSON when it's called internally, or to get it from the environment.
Need a , to end the value
This is the right way to determine the parameter dictionary / stream definition for output streams on processes.
parse.y読んできます
так воно так і є, layout.html для адмінки, main.html для основних сторінок сайту
can we use the if twice (e.g. for both tab and tab content) instead of duplicating the other tabs view?
what if type is not nil but not an allowed type?
instead of listing all you can use `exclude` (or was it `exclude_fields`?)
@knowncitizen I am considering to remove this line as I think it might be better to include it in actual interstitial content_for, so it is customizable.
minor nit.  would be nice if you had something like Area= <box> square units.

Catch me in chat, or drop me a line if you need help doing this.
There was another one somewhere.

Wish it were possible. It's possible with AsciiDoc (very similar to MarkDown, I used it for my book), and it's very useful. Might have to modify the MarkDown library I'm using :-D


On 5 Aug 2012, at 18:22, MSuhajda wrote:

>> +Socket.io has built-in 'exposed events' on the server side and on the client side.
>> +
>> +**Let's talk about the client side ones first:**
>> +
>> +When a client connets to your application:
>> +
>> +		io.sockets.on('connection', function(client) {
>> +			// insert client-handling code here
>> +		}
>> +
>> +In this case, the argument client should be used further on.
>> +
>> +Another exposed event is to handle messages from the client.
>> +
>> +		io.sockets.on('connection', function(client) {
>> +			**client.on('message', function(message) {
> 
> It is not and I already removed it. Probably forgot that one there.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/callumacrae/lynx.io/pull/5/files#r1308342
Just noting down like we discussed in gchat: that problem doesn't happen, due to error checking elsewhere, but I like your rewrite for its expressiveness.
Sure, you'd just need to make sure a known-good hash works.
storage --- это существительное
Алгоритм не верен. Нужно написать тесты, чтобы это обнаружить.
Actually, no. That was done by habit :smile: I'm gonna remove it.
why do we add this here when we have it in basepage
These ignores do not seem to be necessary because phpseclib has no composer dependencies.
did you mean to use malcolmsparks as the groupid here?
was this supposed to be `'code': 400` ?
can you change this to:

```
var profileSection = new ProfileSection(principalId, sectionName, {}, visibility);
```
This adds to the UI, can we split this up to a separate sprint item?
getFirstError()
trailing semicolon
if check here too..
Misschien hernoemen als `handlePlayerDetection`?
Can't you just pass FALSE below?
Just 'array'.
I'm not going to trawl through a while file change for specific changes, seeing line comments i'm going to assume what the comments tell me.
Для хранения длины DNA используйте константу или #define. Тогда будет гораздо быстрее и проще изменить программу так, чтобы она работала с цепочками ДНК длиной 150 (например).
Аналогичный совет для длины алфавита.
Чтоб запутать всех с толку, зачем ж ешё. Но делать так категорически не стоит, никто не будет искать переменную вне класса.
Unneeded \n's
How about some check that the client is not yet set and raising exception when it is.
That could prevent a situation when someone by accident adds doorkeeper_client! to 2 models and one of those models will get lost.
min_score and max_score
I'm not sure why this is here. Who should this crazy guy removing the documentElement be? We are sensible enough not to do strange things like that, and we are not writing a library for others here, so I don't see the point. Is this a real problem with our current codebase?
But the header is included in both targets, and with the wrong visibility for a Mac framework. Either the Mac header should be Public, or the header should be omitted from both targets (depending on whether this class should be considered public or not).
Are you sure you see the right diff???


On Sun, Dec 16, 2012 at 4:39 PM, Denis-Alexander Engemann <
denis.engemann@gmail.com> wrote:

> why is it still there?? I removed it
>
>
> On Sun, Dec 16, 2012 at 4:38 PM, Alexandre Gramfort <
> notifications@github.com> wrote:
>
>> In mne/viz.py:
>>
>> > @@ -1109,6 +1115,10 @@ def plot_image_epochs(epochs, picks, sigma=0.3, vmin=None,
>> >          (data.shape[1] == len(times))
>> >      show : bool
>> >          Show or not the figure at the end
>> > +    scalings : dict
>> > +        The scalings of the channel types to be applied for plotting.
>> > +    titles : dict
>> > +        The titles associated with the channels.
>>
>> keep_only_data_channels is not documented and titles in not an argument.
>>
>> I don't really like keep_only_data_channels. When this problem happened
>> in the past we agreed that picks=None was equivalent to
>> keep_only_data_channels=True
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/221/files#r2430076>.
>>
>>
>
>
I think it's okay to have functions under two headings. I think it will be easier for users to find what they're interested in (and they link to the same page anyway). So I'd keep read_ and write_events here.
_raw_lengths would be more explicit
Hrm... I haven't really looked at this, but we probably don't want to be reading the annotations every time through this code if we can avoid it. Wouldn't that be wasteful? 

Also, all this getArguments()[index] looks odd.

I need to read up on how this junk works.
This should be updated too, to use the new syntax instead of the deprecated one
nice! changed.
已改
``Required.YES``
Is this user-level API?
Saw your similar comment below.  Seems like you would prefer having the defaults in the config.  I'll add it to the list for next commit.
oh, I see...you test for a bunch of others below.
А зачем тут эта переменная?
I'm not sure how I feel about this one, currently we don't allow control structures to be on a single line, but this rule was assume.

We do not allow control structures to be in this format, but I do believe at one point we allowed classes to be on a single line, right?
¿Y esto? jaja
Just thought of something else. ParseException is checked unfortunately. Can we wrap the exception and throw a RuntimeException instead? In doing so, you wouldnt have to catch/log exceptions down below and we'd just letter the logger handle that throw levels. 

makes sense?
I think it might be better to add content-search-errata and content-search-repo-compare  groups inside content-search-tests, instead of adding them at the top level.
I'm pretty sure this can introduce nasty errors. These cases should not happen but when they do, we will probably need to take care of it manually..
Nice use of lambda
same here no consistency for getters and setters methods name
Could these be handled as static files?
At last the mystery is solved.
I totally do exactly the same thing in create
@pdmars Me too.
Please, do not instantiate DCM directly. Always use TestCacheManagerFactory. In this case, TestCacheManagerFactory.fromStream().
Agreed. A migration wiki page (linked in the CH/CHF javadocs) would be good.
I had to get the keyword regex without diacritics here, otherwise the keyword without diacr would have been generated at each ptest() call.
:smile: - your loving this @dmcdougall! Personally, I'm quite happy to accept that @NelleV has made an improvement and not go through all of the remaining code, but I have to say your more thorough review will result in the better overall code changes.
We should move the developer to a constant too, so if we need to change the application we can do it from the top of the file.
This is dark magic to me. I trust it's right.
Hehe, acabei de perguntar delas.
this loop is the same in every of the case distinctions, could you refactor in such way that is there only once? The size is the only thing that is different for different types - also you can use TSGDataType again and then theres no need for a case distinction at all

I would also use memcpy here and not iterator over all the bytes by hand. Thats much faster for large matrices! For casting, you need not to touch every byte.

I think there is a semantic error: You in fact only copy the first element of the parameter data (bytewise). However, there are vectors and matrices, which you wouldnt cover here. I would get the size in bytes of the parameter data using TSGDataType and then just use memcpy to copy all.