jiebi/ids-paragraph-commentary-corpus huggingface dataset:
Draft: draft-ietf-mls-protocol

Commentary: You can now rebase this on master for clarity . 
 Here 's the Weekly Digest for : - - Last week 5 issues were created . Of these , 1 issues have been closed and 4 issues are still open . : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : heart : , by : speaker : , by It received 3 comments . - - Last week , 8 pull requests were created , updated or merged . Last week , 7 pull requests were updated . : yellowheart : , by : yellowheart : , by : yellowheart : , by : yellowheart : , by : yellowheart : , by : yellowheart : , by : yellowheart : , by Last week , 1 pull request was merged . : purpleheart : , by - - Last week there were 3 commits . : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by - - Last week there were 2 contributors . : bustinsilhouette : : bustinsilhouette : - - Last week there were no stargazers . - - Last week there were no releases . - - That 's all for last week , please < kbd : eyes : Watch</kbdand < kbd : star : Star</kbdthe repository to receive next weekly updates . : smiley : You can also . 
 This looks good , just one minor clarification
Paragraph (version A):
Construct an initial Commit object with "updates", "removes", and
"adds" fields populated from Proposals received during the current
epoch, and an empty "path" field.
Paragraph (version B):
Construct an initial Commit object with "updates", "removes", and
"adds" fields populated from Proposals received during the current
epoch, and empty "client_init_key" and "path" fields.
Paragraph (version B):
Generate a new ClientInitKey for the Committer's own leaf.  Store
it in the ratchet tree and assign it to the "client_init_key"
field in the Commit object.
Draft: draft-ietf-mls-protocol

Commentary: Blanking on add ( I think ) was obsoleted by unmerged leaves Add leaf to unmerged list for non - blank nodes on add There are now four elements in each node 
 Here 's the Weekly Digest for : - - Last week 11 issues were created . Of these , 1 issues have been closed and 10 issues are still open . : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : heart : , by : speaker : , by It received 2 comments . - - Last week , 11 pull requests were created , updated or merged . Last week , 6 pull requests were opened . : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by Last week , 4 pull requests were updated . : yellowheart : , by : yellowheart : , by : yellowheart : , by : yellowheart : , by Last week , 1 pull request was merged . : purpleheart : , by - - Last week there were 2 commits . : hammerandwrench : by : hammerandwrench : by - - Last week there were 2 contributors . : bustinsilhouette : : bustin_silhouette : - - Last week there were 2 stagazers . : star : : star : You all are the stars ! : star2 : - - Last week there were no releases . - - That 's all for last week , please < kbd : eyes : Watch</kbdand < kbd : star : Star</kbdthe repository to receive next weekly updates . : smiley : You can also . 
 Nice catch , Thank you !
Paragraph (version A):
For each intermediate node along the path from the leaf at
position "index" to the root, add "index" to the "unmerged_leaves"
list for the node.
Paragraph (version B):
For each non-blank intermediate node along the path from the leaf
at position "index" to the root, add "index" to the
"unmerged_leaves" list for the node.
Draft: draft-ietf-mls-protocol

Commentary: This PR begins filling in the IANA Considerations section , starting with a Ciphersuites registry . This addresses the concerns in as discussed at the interim ( 2019 - 10 ) , namely by reserving for vendor use chunk of the code points space large enough to be selected at random without huge risk of collision ( 2 ^ 12 values ) . Depends on 
 Here 's the Weekly Digest for : - - Last week 9 issues were created . Of these , 6 issues have been closed and 3 issues are still open . : greenheart : , by : greenheart : , by : greenheart : , by : heart : , by : heart : , by : heart : , by : heart : , by : heart : , by : heart : , by : speaker : , by It received 2 comments . - - Last week , 13 pull requests were created , updated or merged . Last week , 3 pull requests were updated . : yellowheart : , by : yellowheart : , by : yellowheart : , by Last week , 10 pull requests were merged . : purpleheart : , by : purpleheart : , by : purpleheart : , by : purpleheart : , by : purpleheart : , by : purpleheart : , by : purpleheart : , by : purpleheart : , by : purpleheart : , by : purpleheart : , by - - Last week there were 38 commits . : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by - - Last week there were 2 contributors . : bustinsilhouette : : bustin_silhouette : - - Last week there was 1 stargazer . : star : You are the star ! : star2 : - - Last week there were no releases . - - That 's all for last week , please < kbd : eyes : Watch</kbdand < kbd : star : Star</kbdthe repository to receive next weekly updates . : smiley : You can also . * 
 Enable , e.g. , P-256 with both AES - GCM and ChaChaPoly Re - use code points from TLS 
 We should discuss that today
Paragraph (version B):
All of these registries should be under a heading of "Message Layer
Security", and administered under a Specification Required policy
RFC8126.
Paragraph (version B):
The "MLS Ciphersuites" registry lists identifiers for suites of
cryptographic algorithms defined for use with MLS.  These are two-
byte values, so the maximum possible value is 0xFFFF = 65535.  Values
in the range 0xF000 - 0xFFFF are reserved for vendor-internal usage.
Draft: draft-ietf-mls-protocol

Commentary: I think what we discussed at the interim , but I agree with that we should n't label it as " protection " because of the lack of guarantees . It is indeed just an information mechanism , but a number of questions are left open : what should the client creating a group do if better ciphersuites /higher versions are advertised but the DS does n't deliver the corresponding keys ? what should an client do when it realises it was with a sub - optimal ClientInitKey ? ... 
 This now has a MUST for using the extensions to prevent downgrade . 
 To address the risk of version / ciphersuite downgrade by the CIK server , CIKs need to express the lists of versions and ciphersuites that a client supports . Add a general extensions field to ClientInitKey , in the same form as TLS ClientHello / ServerHello Define a extension Define a extension  both extensions to be present This allows the creator of a group to verify that CIKs it gets do not omit versions that the other client actually supports . On Init , the participants of the group can examine the CIKs in the group to verify that the proper version / ciphersuite have been selected .
Paragraph (version A):
where "node_public_key" is the public key of the node that the path
secret is being encrypted for, and the functions "SetupBaseI" and
"Seal" are defined according to I-D.irtf-cfrg-hpke.
Paragraph (version B):
A Remove proposal requests that the client at a specified index in
the tree be removed from the group.
Paragraph (version B):
A Commit message initiates a new epoch for the group, based on a
collection of Proposals.  It instructs group members to update their
representation of the state of the group by applying the proposals
and advancing the key schedule.
Paragraph (version B):
Update the ratchet tree by replacing nodes in the direct path
of the sender with the corresponding nodes in the path (see
direct-paths).
Paragraph (version B):
The sender of a Commit message is responsible for sending a Welcome
message to any new members added via Add proposals.  The Welcome
message provides the new members with the current state of the group,
after the application of the Commit message.  The new members will
not be able to decrypt or verify the Commit message, but will have
the secrets they need to participate in the epoch initiated by the
Commit message.
Draft: draft-ietf-mls-protocol

Commentary: Here 's the Weekly Digest for : - - Last week , no issues were created . - - Last week , 5 pull requests were created , updated or merged . Last week , 3 pull requests were updated . : yellowheart : , by : yellowheart : , by : yellowheart : , by Last week , 2 pull requests were merged . : purpleheart : , by : purpleheart : , by - - Last week there were 2 commits . : hammerandwrench : by : hammerandwrench : by - - Last week there was 1 contributor . : bustin_silhouette : - - Last week there were no stargazers . - - Last week there were no releases . - - That 's all for last week , please < kbd : eyes : Watch</kbdand < kbd : star : Star</kbdthe repository to receive next weekly updates . : smiley : You can also . 
 Here 's the Weekly Digest for : - - Last week 18 issues were created . Of these , 3 issues have been closed and 15 issues are still open . : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : heart : , by : heart : , by : heart : , by : speaker : , by It received 5 comments . - - Last week , 10 pull requests were created , updated or merged . Last week , 1 pull request was opened . : greenheart : , by Last week , 7 pull requests were updated . : yellowheart : , by : yellowheart : , by : yellowheart : , by : yellowheart : , by : yellowheart : , by : yellowheart : , by : yellowheart : , by Last week , 2 pull requests were merged . : purpleheart : , by : purpleheart : , by - - Last week there were 4 commits . : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by - - Last week there were 4 contributors . : bustinsilhouette : : bustinsilhouette : : bustinsilhouette : : bustin_silhouette : - - Last week there were no stargazers . - - Last week there were no releases . - - That 's all for last week , please < kbd : eyes : Watch</kbdand < kbd : star : Star</kbdthe repository to receive next weekly updates . : smiley : You can also .
Paragraph (version B):
In the case where the client could have been compromised (device
loss...), the client SHOULD signal the delivery service to expire all
the previous ClientInitKeys and publish fresh ones for PCS.
Draft: draft-ietf-mls-protocol

Commentary: I could n't find this written anywhere else and this is also related to a discussion about PCS with Cas and  . 
 Here 's the Weekly Digest for : - - Last week , no issues were created . - - Last week , 5 pull requests were created , updated or merged . Last week , 3 pull requests were updated . : yellowheart : , by : yellowheart : , by : yellowheart : , by Last week , 2 pull requests were merged . : purpleheart : , by : purpleheart : , by - - Last week there were 2 commits . : hammerandwrench : by : hammerandwrench : by - - Last week there was 1 contributor . : bustin_silhouette : - - Last week there were no stargazers . - - Last week there were no releases . - - That 's all for last week , please < kbd : eyes : Watch</kbdand < kbd : star : Star</kbdthe repository to receive next weekly updates . : smiley : You can also . 
 Here 's the Weekly Digest for : - - Last week 18 issues were created . Of these , 3 issues have been closed and 15 issues are still open . : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : heart : , by : heart : , by : heart : , by : speaker : , by It received 5 comments . - - Last week , 10 pull requests were created , updated or merged . Last week , 1 pull request was opened . : greenheart : , by Last week , 7 pull requests were updated . : yellowheart : , by : yellowheart : , by : yellowheart : , by : yellowheart : , by : yellowheart : , by : yellowheart : , by : yellowheart : , by Last week , 2 pull requests were merged . : purpleheart : , by : purpleheart : , by - - Last week there were 4 commits . : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by : hammerandwrench : by - - Last week there were 4 contributors . : bustinsilhouette : : bustinsilhouette : : bustinsilhouette : : bustin_silhouette : - - Last week there were no stargazers . - - Last week there were no releases . - - That 's all for last week , please < kbd : eyes : Watch</kbdand < kbd : star : Star</kbdthe repository to receive next weekly updates . : smiley : You can also .
Paragraph (version B):
Note that each new credential that has not already been validated by
the application SHOULD be validated against the Authentication
Service.
Draft: draft-ietf-mls-protocol

Commentary: Here 's the Weekly Digest for : - - Last week 2 issues were created . Of these , 0 issues have been closed and 2 issues are still open . : greenheart : , by : greenheart : , by - - Last week , 8 pull requests were created , updated or merged . Last week , 1 pull request was opened . : greenheart : , by Last week , 5 pull requests were updated . : yellowheart : , by : yellowheart : , by : yellowheart : , by : yellowheart : , by : yellowheart : , by Last week , 2 pull requests were merged . : purpleheart : , by : purpleheart : , by - - Last week there were 2 commits . : hammerandwrench : by : hammerandwrench : by - - Last week there was 1 contributor . : bustinsilhouette : - - Last week there was 1 stargazer . : star : You are the star ! : star2 : - - Last week there were no releases . - - That 's all for last week , please < kbd : eyes : Watch</kbdand < kbd : star : Star</kbdthe repository to receive next weekly updates . : smiley : You can also .
Paragraph (version A):
It is important to delete all security sensitive values S as soon as
they, or another value derived from them, is used for encryption or
decryption.
Paragraph (version A):
if a key, nonce or secret derived from S has been consumed.
Paragraph (version A):
Here, S may be the init_secret, update_secret, epoch_secret,
application_secret as well as any secret in the AS Tree or one of the
ratchets.
Paragraph (version B):
Here, S may be the "init_secret", "update_secret", "epoch_secret",
"application_secret" as well as any secret in the AS Tree or one of
the ratchets.
Paragraph (version A):
the init_secret, update_secret, epoch_secret, application_secret
of that epoch,
Paragraph (version A):
application_[i]_[j]_key and application_[i]_[j]_nonce.
Paragraph (version B):
the "init_secret", "update_secret", "epoch_secret",
"application_secret" of that epoch,
Paragraph (version B):
"application_[i]_[j]_key" and "application_[i]_[j]_nonce".
Draft: draft-ietf-mls-protocol

Commentary: Prior drafts enabled encryption of handshake messages , via the common framing structure . This had the unfortunate effect of making it impossible to add new members ! If an Add is sent encrypted , then the new joiner had no way to get the key to decrypt it . This PR adds the key and nonce for the  encryption to the corresponding WelcomeInfo structure . This maintains the confidentiality of the Add because the WelcomeInfo is encrypted to the new joiner , while providing the new joiner the key material it needs to decrypt the Add . 
 I think we 'll need to carefully study the impact of this one but this seems fine for now . In the future aligning the way we do and ( for the new member ) which both are PKE operations will probably allow us to merge and and remove that issue all together .
Paragraph (version A):
The Welcome message contains the information that the new member
needs to initialize a GroupContext object that can be updated to the
current state using the Add message.  This information is encrypted
for the new member using HPKE.  The recipient key pair for the HPKE
encryption is the one included in the indicated ClientInitKey,
corresponding to the indicated ciphersuite.
Paragraph (version B):
The Welcome message contains the information that the new member
needs to initialize a GroupContext object that can be updated to the
current state using the Add message.  This information is encrypted
for the new member using HPKE.  The recipient key pair for the HPKE
encryption is the one included in the indicated ClientInitKey,
corresponding to the indicated ciphersuite.  The "add_key_nonce"
field contains the key and nonce used to encrypt the corresponding
Add message; if it is not encrypted, then this field MUST be set to
the null optional value.
Draft: draft-ietf-mls-protocol

Commentary: Here 's the Weekly Digest for : This week , 8 issues were created . Of these , 4 issues have been closed and 4 issues are still open . : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : heart : , by : heart : , by : heart : , by : heart : , by The issue most discussed this week has been : : speaker : , by It received 9 comments . This week , no pull requests has been proposed by the users . This week , 4 users have contributed to this repository . They are , , , and . This week , no user has starred this repository . This week , there have been 4 commits in the repository . These are : : hammerandwrench : Merge pull request from rozbb / mlsplaintext - signature Multiple clarifications around Framing by : hammerandwrench : Merge pull request from rozbb / hpke - encrypt Clarify how HPKE ciphertexts are computed by : hammerandwrench : by : hammerand_wrench : by # RELEASES This week , no releases were published . That 's all for this week , please watch : eyes : and star : star : to receive next weekly updates . : smiley :
Paragraph (version A):
The HPKECiphertext values are computed according to the Encrypt
function defined in I-D.barnes-cfrg-hpke.
Paragraph (version B):
where "node_public_key" is the public key of the node that the path
secret is being encrypted for, and the functions "SetupBaseI" and
"Seal" are defined according to I-D.barnes-cfrg-hpke.
Draft: draft-ietf-mls-protocol

Commentary: Here 's the Weekly Digest for : This week , 8 issues were created . Of these , 4 issues have been closed and 4 issues are still open . : greenheart : , by : greenheart : , by : greenheart : , by : greenheart : , by : heart : , by : heart : , by : heart : , by : heart : , by The issue most discussed this week has been : : speaker : , by It received 9 comments . This week , no pull requests has been proposed by the users . This week , 4 users have contributed to this repository . They are , , , and . This week , no user has starred this repository . This week , there have been 4 commits in the repository . These are : : hammerandwrench : Merge pull request from rozbb / mlsplaintext - signature Multiple clarifications around Framing by : hammerandwrench : Merge pull request from rozbb / hpke - encrypt Clarify how HPKE ciphertexts are computed by : hammerandwrench : by : hammerand_wrench : by # RELEASES This week , no releases were published . That 's all for this week , please watch : eyes : and star : star : to receive next weekly updates . : smiley :
Paragraph (version A):
The signature field in an MLSPlaintext object is computed using the
signing private key corresponding to the credential at the leaf in
the tree indicated by the sender field.  The signature covers the
metadata and message content, with the signature field truncated.
Paragraph (version B):
The signature field in an MLSPlaintext object is computed using the
signing private key corresponding to the credential at the leaf in
the tree indicated by the sender field.  The signature covers the
plaintext metadata and message content, i.e., all fields of
MLSPlaintext except for the "signature" field.
Paragraph (version A):
Use the "confirmation_key" for the new epoch to compute the
confirmation MAC for this message, as described below, and verify
that it is the same as the "confirmation" field in the
GroupOperation object.
Paragraph (version B):
Use the "confirmation_key" for the new epoch to compute the
confirmation MAC for this message, as described below, and verify
that it is the same as the "confirmation" field in the
MLSPlaintext object.
Draft: draft-ietf-mls-protocol

Commentary: While trying to implement , I noticed that the confirmation and transcript hash calculations in draft-06 do not actually allow a new participant to join the transcript hash . Since the value is sent , and not the value , the new joiner is missing the auth data necessary to compute the next value . To fix this and clarify terminology , this PR makes the following changes : becomes , since this is what goes into the confirmation MAC becomes is updated to refer to the 
 Here 's the Weekly Digest for : - - Last week 2 issues were created . Of these , 1 issues have been closed and 1 issues are still open . : greenheart : , by : heart : , by : speaker : , by It received 1 comments . - - Last week , 2 pull requests were created , updated or merged . Last week , 1 pull request was updated . : yellowheart : , by Last week , 1 pull request was merged . : purpleheart : , by - - Last week there were 2 commits . : hammerandwrench : by : hammerandwrench : by - - Last week there were 2 contributors . : bustinsilhouette : : bustin_silhouette : - - Last week there were no stargazers . - - Last week there were no releases . - - That 's all for last week , please < kbd : eyes : Watch</kbdand < kbd : star : Star</kbdthe repository to receive next weekly updates . : smiley : You can also . 
 This looks ok . If we want , merging and messages like in the TreeKEM paper would probably avoid some pain here . Merging .
Paragraph (version A):
The "transcript_hash" field contains the list of "GroupOperation"
messages that led to this state.
Paragraph (version B):
The "confirmed_transcript_hash" field contains a running hash over
the handshake messages that led to this state.
Paragraph (version A):
This structure incorporates everything in an MLSPlaintext up to the
confirmation field in the transcript that is included in that
confirmation field (via the GroupContext).  The confirmation and
signature fields are then included in the transcript for the next
operation.  The intermediate hash enables implementations to in
corporate a plaintext into the transcript without having to store the
whole MLSPlaintextOpAuthData structure.
Paragraph (version A):
When a new one-member group is created (which requires no
GroupOperation), the "transcript_hash" field is set to an all-zero
vector of length Hash.length, where the Hash algorithm is defined by
the ciphersuite.
Paragraph (version B):
This structure incorporates everything in an MLSPlaintext up to the
confirmation field in the transcript that is included in that
confirmation field (via the GroupContext).  The confirmation and
signature fields are then included in the transcript for the next
operation.  The interim transcript hash is passed to new members in
the WelcomeInfo struct, and enables existing members to incorporate a
handshake message into the transcript without having to store the
whole MLSPlaintextOpAuthData structure.
Paragraph (version B):
When a new one-member group is created (which requires no
GroupOperation), the "interim_transcript_hash" field is set to the
zero-length octet string.