jiebi/ids-paragraph-commentary-corpus huggingface dataset:
Draft: draft-ietf-suit-manifest

Commentary: adds a missing digest parameter corrects CDDL for suit - text removes dangling 
 I have discovered this because the EAT build process pulls the SUIT CDDL in for validation using the cddl tool . 
 posted to the list the following : I think I found a little typo in the draft - ietf - suit - manifest-14 ... At the " Appendix A. A. Full CDDL " of the " SUITSeverableMembersChoice " , the last two members are pointing to " SUITCommand_Sequence " are probably typos as following , 
 In draft - ietf - suit - manifest-04 In the example manifest image - digest parameter is set for component 0 in common sequence . The load sequence sets component - index to 1 and after directive - copy it specifies image - match condition . However , the image - digest parameter has not been set for component - index 1 causing the condition to fail as . Is it expected that parameters are implicitly copied from source component when copy - directive is executed ? Should the image - digest be also specified for component - index 1 or perhaps for all components ? Another observation in the example is that vendor - id and class - id parameters and corrsponding condition checks are specified for component 0 , which seems to be the " external storage " . Would n't it be better to specify the VID and CID globally for the entire device or for the component 1 , which seems to be the one running the image ? < pre/ common / 3 : h'a2024782814100814101045856880c0014a40150fa6b4a5 3d5ad5fdfbe9de663e4d41ffe02501492af1425695e48bf429b2d51f2ab45038202582 000112233445566778899aabbccddeeff0123456789abcdeffedcba98765432100e198 ' / { / components / 2 : h '' / [ [ h'00 ' ] , [ h'01 ' ] ] / , / common - sequence / 4 : h ' e663e4d41ffe02501492af1425695e48bf429b2d51f2ab450382025820001122334455 66778899aabbccddeeff0123456789abcdeffedcba98765432100e1987d001f602f6 ' / [ <  directive - set - component - index / 12,0 , < /b/ directive - override - parameters / 20 , { / vendor - id / 1 : h '' / -d5ad-5fdf- be9d- / , / class - id / 2 : h '' / -2569 - 5e48 - bf42- / , / image - digest / 3 : [ / algorithm - id / 2 / sha256 / , / digest - bytes / h'00112233445566778899aabbccddeeff0123456789abcdeffedcba9876543210 ' ] , / image - size / 14 : , } , / condition - vendor - identifier / 1,F6 / nil / , / condition - class - identifier / 2,F6 / nil / ] / , } / , ( ... ) / load / 11 : h '' / [ <  directive - set - component - index / 12,1 , < /b/ directive - set - parameters / 19 , { / source - component / 22:0 / [ h'00 ' ] / , } , / directive - copy / 22,F6 / nil / , < b/ condition - image - match / 3,F6 / nil / < /b ] / , < /pre
All CBOR maps in the Manifest and manifest envelope MUST be encoded
with the canonical CBOR ordering as defined in RFC8949.
The algorithms used in SUIT_Authentication are defined by the
profiles declared in I-D.moran-suit-mti.