jiebi/CodeConvo huggingface dataset:
Code change:
VS Code Version: 1.82.0-insider OS Version: Ubuntu 22.04 The path is missing the first character in the path for a specific file on the 'git show --textconv' lines 'ub-folder' vs 'sub-folder' If the command is run manually, with the correct path there are no issues Working (Non-root folder) 2023-08-03 19:10:33.264 [info] git show --textconv [4ms] 2023-08-03 19:10:33.267 [info] git ls-tree -l HEAD -- [4ms] Not Working (Root folder) 2023-08-03 19:12:26.351 [info] git show --textconv [20ms] 2023-08-03 19:12:26.386 [info] git ls-tree -l HEAD -- [35ms] Expected (Root folder) 2023-08-03 19:12:26.351 [info] git show --textconv [20ms] 2023-08-03 19:12:26.386 [info] git ls-tree -l HEAD -- [35ms] Originally posted by in
could you please share repro steps that I could use to reproduce this? Or the complete contents of the git output window would also help. I have a suspicion where the issue is but I need the logs to reproduce and fix the issue. Thanks!
Hello Ladislau Szomoru, open vsc go to Source Control (Ctrl+Shift+G) look under "Staged Changes" and click on notice left side is always empty and right side shows entire file changed. Thanks, Gregory Porras

Related discussion:
text: * Given the `repository.root` compute the relative path while trying to preserve * the casing of the resource URI. The `repository.root` segment of the path can * have a casing mismatch if the folder/workspace is being opened with incorrect <del> * casing. </del> <ins> * casing which is why we attempt to use substring() before relative(). </ins> */ export function relativePath(from: string, to: string): string { <del> // On Windows, there are cases in which `from` is a path that contains a trailing `` character // (ex: C:, serverfolder) due to the implementation of `path.normalize()`. This behavior is // by design as documented in https://github.com/nodejs/node/issues/1765. if (isWindows) { from = from.replace(/$/, ''); </del> <ins> // There are cases in which the `from` path may contain a trailing separator at // the end (ex: "C:", "serverfolder" (Windows) or "/" (Linux/macOS)) which // is by design as documented in https://github.com/nodejs/node/issues/1765. If // the trailing separator is missing, we add it. if (from.charAt(from.length - 1) !== sep) { from += sep; </ins> } if (isDescendant(from, to) && from.length < to.length) { <del> return to.substring(from.length + 1); </del> <ins> return to.substring(from.length); </ins> } // Fallback to `path.relative`
Code change:
hover over editor tabs observe some kind of shadow dropping over the text
This only reproduces with set to and tabs enabled in general. Hovering over any tab shows the white shadow at the end of the label. With this setting, every tab label has a element to draw a linear gradient (): <img width="400" alt="image" src=""A tab itself is a container of a label and the toolbar with the close button. The close button is set to to not take more space than needed. When you hover, the toolbar is made visible, actually pushing the element into view having the described effect: <img width="504" alt="image" src=""I actually think this is an OK behaviour for when the tab is small enough that the label cannot full show, and that was the intention. However, it is a bit strange that this would happen even for a tab that shows fully and has enough space. If someone wants to chime in to take a look with a reasonably small change, opening for help wanted. But may decide to close out of scope as this does not seem like it was ever a regression.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

Related discussion:
text: padding-right: 5px; /* with tab sizing shrink/fixed and badges, we want a right-padding because the close button is hidden */ } <ins> .monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container > .tab.sizing-shrink:not(.tab-actions-left):not(.tab-actions-off) .tab-label { padding-right: 5px; /* ensure that the gradient does not show when tab actions show https://github.com/microsoft/vscode/issues/189625*/ } </ins> .monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container > .tab.sticky-compact:not(.has-icon) .monaco-icon-label { text-align: center; /* ensure that sticky-compact tabs without icon have label centered */ }
Code change:
Insiders 1.82.0 Looks like the command center and associated toolbar buttons aren't functioning when clicked. Weirdly it seems like I can sometimes(?) get a hover state but it doesn't always work. Repeated clicks minimizes the window which makes me think the events are going straight to the titlebar and being handled as such.
I can reproduce
Maybe an Electron 25 update regression with draggable regions and custom title bar? //cc
looks like behavior on macOS is now aligned with windows and linux, the region no longer emits events. Behavior changed with this commit and verified with the following fiddle Looks like we would need to revert this change to align with Windows and Linux.
Yeah, looks like drag and click isn't working for macOS anymore. It always seems like an oversight/bug but a wanted one. To enable clicking again I have the for the CC even for mac. On the downside it means that the window cannot be repositioned from the CC anymore
Slack is the same, you cannot drag from their command center either.

Related discussion:
text: /* Window Title Menu */ .monaco-workbench .part.titlebar > .titlebar-container > .titlebar-center > .window-title > .command-center { z-index: 2500; <del> } /* MacOS Desktop supports click event despite `drag` and therefore we don't need to clear it */ .monaco-workbench:not(.mac) .part.titlebar > .titlebar-container > .titlebar-center > .window-title > .command-center, .monaco-workbench.mac.web .part.titlebar > .titlebar-container > .titlebar-center > .window-title > .command-center { </del> -webkit-app-region: no-drag; }
Code change:
Settings: !
How it should be: <img width="442" alt="image" src=""
Hm, strange. I haven't made any changes here lately. I'm noting that is not having an effect on the foreground color used on the tree within Explorer. It does however affect other lists like the one used in the quick pick. I also noticed the terminal tabs tree flicker to use that red before being stomped on again. Not sure what's going on here yet.
Looks like this is from
Gotcha I might just revert the change and switch it to something more specific - I didn't consider all the other applications of the list widget and checking other themes (it was okay in a couple of the themes I checked)

Related discussion:
text: } if (styles.listFocusForeground) { <del> content.push(`.monaco-list${suffix}:focus .monaco-list-row.focused:not(.monaco-list-row.action.option-disabled) { color: ${styles.listFocusForeground}; }`); </del> <ins> content.push(`.monaco-list${suffix}:focus .monaco-list-row.focused { color: ${styles.listFocusForeground}; }`); </ins> } if (styles.listActiveSelectionBackground) {
Code change:
Settings: !
How it should be: <img width="442" alt="image" src=""
Hm, strange. I haven't made any changes here lately. I'm noting that is not having an effect on the foreground color used on the tree within Explorer. It does however affect other lists like the one used in the quick pick. I also noticed the terminal tabs tree flicker to use that red before being stomped on again. Not sure what's going on here yet.
Looks like this is from
Gotcha I might just revert the change and switch it to something more specific - I didn't consider all the other applications of the list widget and checking other themes (it was okay in a couple of the themes I checked)

Related discussion:
text: } .action-widget .monaco-list-row.action.option-disabled, <ins> .action-widget .monaco-list:focus .monaco-list-row.focused.action.option-disabled, </ins> .action-widget .monaco-list-row.action.option-disabled .codicon { color: var(--vscode-disabledForeground); } .action-widget .monaco-list-row.action:not(.option-disabled) .codicon { color: inherit; }
Code change:
Type: <bPerformance Issue</bIn a bash terminal with Shell Integration, execute the following command, which is 5k characters long: On both my machines (Linux native and Windows + RemoteSSH), this commande takes 1s to execute. Make it 10k characters and it takes 4s. At 15k, it takes 8s. I'm using bash version 4.4.23 (the one shipped on SLES15 SP4). It appears to be related to the Bash Shell Integration, specifically the function located . This can even be reproduced outside of VSCode, in plain bash. Just define this function in a shell and execute it with a long argument. As a workaround, it is possible to disable Shell Integration in the settings and open new terminals. With a newer bash 5.2 built by myself, performances are better, but still non-negligible: 5k: 0.5s, 10k: 1.5s, 15k: 3.5s. Note: I get similar numbers with a bash 4.4 compiled by myself, so better performances with newer bash might just be related to different compilation options/optimizations. VS Code version: Code 1.81.1 (, 2023-08-09T22:18:39.991Z) OS version: Linux x64 5.14.21-.24.28-default Modes: <details<summarySystem Info</summary </details<details<summaryProcess Info</summary</details<details<summaryWorkspace Info</summary</details<details<summaryExtensions (1)</summaryExtensionVersion ------ remote-ssh0.90.1 </details<!-- generated by issue reporter --
Thanks for the report, hopefully a bash expert will spot this and help optimize the function
Unfortunately this still seems to be quite slow for me. Normal bash runs quicky (). Bash in VS Code has had a core stuck at 100% CPU for a few minutes now with no signs of letting up... <img width="790" alt="image" src=""Doing some binary searching, it's "fast" until the echo hits 1989 characters (a total command length of 2001 characters), at which point it stalls as above
Actually, it seems any command over 2000 characters in bash stalls and takes a long time to run. Doesn't have to be an echo. It seems like time taken is somewhat exponential, 2001 characters take 21s to run for me while 2100 characters jumps that up to 29s. That seems to be the point at which we use a 'fast' implementation. In reality this seems much slower on macOS at least
Hi. Could you check that whether you have command and on your system? Since I actually provided two fast impl in the PR, I would like to know which is problemetic for subsequent troubleshooting. Edit: never mind. I have reproduced the hang and propose another fix.

Related discussion:
text: builtin printf '%s' "${terms[2]:-}" } <ins> __vsc_escape_value_fast() { builtin local LC_ALL=C out out=${1///} out=${out//;/x3b} builtin printf '%sn' "${out}" } </ins> # The property (P) and command (E) codes embed values which require escaping. # Backslashes are doubled. Non-alphanumeric characters are converted to escaped hex. __vsc_escape_value() { <ins> # If the input being too large, switch to the faster function if [ "${#1}" -ge 2000 ]; then __vsc_escape_value_fast "$1" builtin return fi </ins> # Process text byte by byte, not by codepoint. builtin local LC_ALL=C str="${1}" i byte token out=''
Code change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --This would replace . Proposal: ts /
Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT License. See in the project root for license information. *
-------------/ declare module 'vscode' { // export enum RelatedInformationType { SymbolInformation = 1, CommandInformation = 2, SearchInformation = 3, SettingInformation = 4 } interface RelatedInformationBaseResult { type: RelatedInformationType; weight: number; } // TODO: Symbols and Search export interface CommandInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.CommandInformation; command: string; } export interface SettingInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.SettingInformation; setting: string; } export type RelatedInformationResult = CommandInformationResult | SettingInformationResult; export interface RelatedInformationProvider { provideRelatedInformation(query: string, token: CancellationToken): ProviderResult<RelatedInformationResult[]; } export interface EmbeddingVectorProvider { provideEmbeddingVector(strings: string[], token: CancellationToken): ProviderResult<number[][]; } export namespace ai { export function getRelatedInformation(query: string, types: RelatedInformationType[], token: CancellationToken): Thenable<RelatedInformationResult[]; export function registerRelatedInformationProvider(type: RelatedInformationType, provider: RelatedInformationProvider): Disposable; export function registerEmbeddingVectorProvider(model: string, provider: EmbeddingVectorProvider): Disposable; } }

Related discussion:
text: import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { InstantiationType, registerSingleton } from 'vs/platform/instantiation/common/extensions'; import { ISemanticSimilarityService } from 'vs/workbench/services/semanticSimilarity/common/semanticSimilarityService'; <ins> import { IAiRelatedInformationService, RelatedInformationType, SettingInformationResult } from 'vs/workbench/services/aiRelatedInformation/common/aiRelatedInformation'; </ins> export interface IEndpointDetails { urlBase?: string;
Code change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --This would replace . Proposal: ts /
Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT License. See in the project root for license information. *
-------------/ declare module 'vscode' { // export enum RelatedInformationType { SymbolInformation = 1, CommandInformation = 2, SearchInformation = 3, SettingInformation = 4 } interface RelatedInformationBaseResult { type: RelatedInformationType; weight: number; } // TODO: Symbols and Search export interface CommandInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.CommandInformation; command: string; } export interface SettingInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.SettingInformation; setting: string; } export type RelatedInformationResult = CommandInformationResult | SettingInformationResult; export interface RelatedInformationProvider { provideRelatedInformation(query: string, token: CancellationToken): ProviderResult<RelatedInformationResult[]; } export interface EmbeddingVectorProvider { provideEmbeddingVector(strings: string[], token: CancellationToken): ProviderResult<number[][]; } export namespace ai { export function getRelatedInformation(query: string, types: RelatedInformationType[], token: CancellationToken): Thenable<RelatedInformationResult[]; export function registerRelatedInformationProvider(type: RelatedInformationType, provider: RelatedInformationProvider): Disposable; export function registerEmbeddingVectorProvider(model: string, provider: EmbeddingVectorProvider): Disposable; } }

Related discussion:
text: private settingsRecord: Record<string, ISetting> = {}; private currentPreferencesModel: ISettingsEditorModel | undefined; <del> constructor(private readonly semanticSimilarityService: ISemanticSimilarityService) { } </del> <ins> constructor( private readonly aiRelatedInformationService: IAiRelatedInformationService, private readonly semanticSimilarityService: ISemanticSimilarityService ) { } </ins> updateModel(preferencesModel: ISettingsEditorModel) { if (preferencesModel === this.currentPreferencesModel) {
Code change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --This would replace . Proposal: ts /
Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT License. See in the project root for license information. *
-------------/ declare module 'vscode' { // export enum RelatedInformationType { SymbolInformation = 1, CommandInformation = 2, SearchInformation = 3, SettingInformation = 4 } interface RelatedInformationBaseResult { type: RelatedInformationType; weight: number; } // TODO: Symbols and Search export interface CommandInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.CommandInformation; command: string; } export interface SettingInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.SettingInformation; setting: string; } export type RelatedInformationResult = CommandInformationResult | SettingInformationResult; export interface RelatedInformationProvider { provideRelatedInformation(query: string, token: CancellationToken): ProviderResult<RelatedInformationResult[]; } export interface EmbeddingVectorProvider { provideEmbeddingVector(strings: string[], token: CancellationToken): ProviderResult<number[][]; } export namespace ai { export function getRelatedInformation(query: string, types: RelatedInformationType[], token: CancellationToken): Thenable<RelatedInformationResult[]; export function registerRelatedInformationProvider(type: RelatedInformationType, provider: RelatedInformationProvider): Disposable; export function registerEmbeddingVectorProvider(model: string, provider: EmbeddingVectorProvider): Disposable; } }

Related discussion:
text: this.settingKeys = []; this.settingsRecord = {}; <del> if (!this.semanticSimilarityService.isEnabled() || !this.currentPreferencesModel) { </del> <ins> if ( !this.currentPreferencesModel || (!this.semanticSimilarityService.isEnabled() && !this.aiRelatedInformationService.isEnabled()) ) { </ins> return; }
Code change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --This would replace . Proposal: ts /
Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT License. See in the project root for license information. *
-------------/ declare module 'vscode' { // export enum RelatedInformationType { SymbolInformation = 1, CommandInformation = 2, SearchInformation = 3, SettingInformation = 4 } interface RelatedInformationBaseResult { type: RelatedInformationType; weight: number; } // TODO: Symbols and Search export interface CommandInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.CommandInformation; command: string; } export interface SettingInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.SettingInformation; setting: string; } export type RelatedInformationResult = CommandInformationResult | SettingInformationResult; export interface RelatedInformationProvider { provideRelatedInformation(query: string, token: CancellationToken): ProviderResult<RelatedInformationResult[]; } export interface EmbeddingVectorProvider { provideEmbeddingVector(strings: string[], token: CancellationToken): ProviderResult<number[][]; } export namespace ai { export function getRelatedInformation(query: string, types: RelatedInformationType[], token: CancellationToken): Thenable<RelatedInformationResult[]; export function registerRelatedInformationProvider(type: RelatedInformationType, provider: RelatedInformationProvider): Disposable; export function registerEmbeddingVectorProvider(model: string, provider: EmbeddingVectorProvider): Disposable; } }

Related discussion:
text: constructor( @ISemanticSimilarityService private readonly semanticSimilarityService: ISemanticSimilarityService, <ins> @IAiRelatedInformationService private readonly aiRelatedInformationService: IAiRelatedInformationService </ins> ) { <del> this._keysProvider = new RemoteSearchKeysProvider(semanticSimilarityService); </del> <ins> this._keysProvider = new RemoteSearchKeysProvider(aiRelatedInformationService, semanticSimilarityService); </ins> } setFilter(filter: string) {
Code change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --This would replace . Proposal: ts /
Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT License. See in the project root for license information. *
-------------/ declare module 'vscode' { // export enum RelatedInformationType { SymbolInformation = 1, CommandInformation = 2, SearchInformation = 3, SettingInformation = 4 } interface RelatedInformationBaseResult { type: RelatedInformationType; weight: number; } // TODO: Symbols and Search export interface CommandInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.CommandInformation; command: string; } export interface SettingInformationResult extends RelatedInformationBaseResult { type: RelatedInformationType.SettingInformation; setting: string; } export type RelatedInformationResult = CommandInformationResult | SettingInformationResult; export interface RelatedInformationProvider { provideRelatedInformation(query: string, token: CancellationToken): ProviderResult<RelatedInformationResult[]; } export interface EmbeddingVectorProvider { provideEmbeddingVector(strings: string[], token: CancellationToken): ProviderResult<number[][]; } export namespace ai { export function getRelatedInformation(query: string, types: RelatedInformationType[], token: CancellationToken): Thenable<RelatedInformationResult[]; export function registerRelatedInformationProvider(type: RelatedInformationType, provider: RelatedInformationProvider): Disposable; export function registerEmbeddingVectorProvider(model: string, provider: EmbeddingVectorProvider): Disposable; } }

Related discussion:
text: } async searchModel(preferencesModel: ISettingsEditorModel, token?: CancellationToken | undefined): Promise<ISearchResult | null> { <del> if (!this.semanticSimilarityService.isEnabled() || !this._filter) { </del> <ins> if ( !this._filter || (!this.semanticSimilarityService.isEnabled() && !this.aiRelatedInformationService.isEnabled())) { </ins> return null; } this._keysProvider.updateModel(preferencesModel); <ins> const filterMatches = this.aiRelatedInformationService.isEnabled() ? await this.getAiRelatedInformationItems(token) : this.semanticSimilarityService.isEnabled() ? await this.getSemanticSimilarityItems(token) : []; return { filterMatches }; } // TODO: Remove this when all semantic similarity providers are migrated to aiRelatedInformationService private async getSemanticSimilarityItems(token?: CancellationToken | undefined) { </ins> const settingKeys = this._keysProvider.getSettingKeys(); const settingsRecord = this._keysProvider.getSettingsRecord();