jiebi/CodeConvo huggingface dataset:
Code change:
The steps are simple: settings editor in one group untitled editor in the group next to it sizes are equal drag the untitled editor to the left of the settings editor the sizes end up not to be equal. Insiders ! Stable ! Maybe this is related to the settings editor wanting a larger size? I can reproduce this in a small window size (the default one when you open a fresh user data dir).

Related discussion:
text: const data = this.editorTransfer.getData(DraggedEditorIdentifier.prototype); if (Array.isArray(data)) { const draggedEditor = data[0].identifier; <del> const targetGroup = ensureTargetGroup(); </del> const sourceGroup = this.accessor.getGroup(draggedEditor.groupId); if (sourceGroup) { <del> if (sourceGroup === targetGroup) { return; </del> <ins> const copyEditor = this.isCopyOperation(event, draggedEditor); let targetGroup: IEditorGroupView | undefined = undefined; // Optimization: if we move the last editor of an editor group // and we are configured to close empty editor groups, we can // rather move the entire editor group according to the direction if (this.editorGroupService.partOptions.closeEmptyGroups && sourceGroup.count === 1 && typeof splitDirection === 'number' && !copyEditor) { targetGroup = this.accessor.moveGroup(sourceGroup, this.groupView, splitDirection); </ins> } <del> // Open in target group const options = fillActiveEditorViewState(sourceGroup, draggedEditor.editor, { pinned: true,										// always pin dropped editor sticky: sourceGroup.isSticky(draggedEditor.editor),	// preserve sticky state }); </del> <ins> // In any other case do a normal move/copy operation else { targetGroup = ensureTargetGroup(); if (sourceGroup === targetGroup) { return; } </ins> <del> const copyEditor = this.isCopyOperation(event, draggedEditor); if (!copyEditor) { sourceGroup.moveEditor(draggedEditor.editor, targetGroup, options); } else { sourceGroup.copyEditor(draggedEditor.editor, targetGroup, options); </del> <ins> // Open in target group const options = fillActiveEditorViewState(sourceGroup, draggedEditor.editor, { pinned: true,										// always pin dropped editor sticky: sourceGroup.isSticky(draggedEditor.editor),	// preserve sticky state }); if (!copyEditor) { sourceGroup.moveEditor(draggedEditor.editor, targetGroup, options); } else { sourceGroup.copyEditor(draggedEditor.editor, targetGroup, options); } </ins> } // Ensure target has focus
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.79.2 (user setup) OS Version: Windows 10 22H2 To fix the issue please update the native-is-elevated package. It was fixed two months ago.
Could you maybe verify using our insiders? You can give our preview releases a try from:
It seems working properly now. Thanks!

Related discussion:
text: "jschardet": "3.0.0", "keytar": "7.9.0", "minimist": "^1.2.6", <del> "native-is-elevated": "0.6.0", </del> <ins> "native-is-elevated": "0.7.0", </ins> "native-keymap": "^3.3.2", "native-watchdog": "^1.4.1", "node-pty": "1.1.0-beta1",
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.79.2 (user setup) OS Version: Windows 10 22H2 To fix the issue please update the native-is-elevated package. It was fixed two months ago.
Could you maybe verify using our insiders? You can give our preview releases a try from:
It seems working properly now. Thanks!

Related discussion:
text: resolved "https://registry.yarnpkg.com/napi-build-utils/-/napi-build-utils-1.0.2.tgz#b1fddc0b2c46e380a0b7a76f984dd47c41a13806" integrity sha512-ONmRUqK7zj7DWX0D9ADe03wbwOBZxNAfF20PlGfCWQcD3+/MakShIHrMqx9YwPTfxDdF1zLeL+RGZiR9kGMLdg== <del> native-is-elevated@0.6.0: version "0.6.0" resolved "https://registry.yarnpkg.com/native-is-elevated/-/native-is-elevated-0.6.0.tgz#9fd9c9c53bfd87d6e6af15a5d6bcb8e592b7ec79" integrity sha512-HW1wDo4WYZC7W68kaS0cs7FtDTrcFoAY1APc4SlU4Un/FuL7pjilXFEteBCA58EWClKk0912JLIoekOJ/NohnQ== </del> <ins> native-is-elevated@0.7.0: version "0.7.0" resolved "https://registry.yarnpkg.com/native-is-elevated/-/native-is-elevated-0.7.0.tgz#77499639e232edad1886403969e2bf236294e7af" integrity sha512-tp8hUqK7vexBiyIWKMvmRxdG6kqUtO+3eay9iB0i16NYgvCqE5wMe1Y0guHilpkmRgvVXEWNW4et1+qqcwpLBA== </ins> native-keymap@^3.3.2: version "3.3.3"
Code change:
in VS Code :bug: sticky scroll has no syntax highlighting <img width="691" alt="image" src=""
Hey I update my insiders version and tested on the file you sent, I am currently not able to reproduce this error: ! I'll try to reproduce this issue. I think I may have seen this happen for a very brief moment.
It appears this is due to the following PR which attempted to fix Since the state was no longer recomputed when the new state was equal to the old state, this means that the rendering was no longer done when the model tokens changed but the state remained the same. A fix will be made to revert this change.

Related discussion:
text: import * as dom from 'vs/base/browser/dom'; import { StandardMouseEvent } from 'vs/base/browser/mouseEvent'; import { createTrustedTypesPolicy } from 'vs/base/browser/trustedTypes'; <del> import { equals } from 'vs/base/common/arrays'; </del> import { Disposable, DisposableStore } from 'vs/base/common/lifecycle'; import 'vs/css!./stickyScroll'; import { ICodeEditor, IOverlayWidget, IOverlayWidgetPosition } from 'vs/editor/browser/editorBrowser';
Code change:
in VS Code :bug: sticky scroll has no syntax highlighting <img width="691" alt="image" src=""
Hey I update my insiders version and tested on the file you sent, I am currently not able to reproduce this error: ! I'll try to reproduce this issue. I think I may have seen this happen for a very brief moment.
It appears this is due to the following PR which attempted to fix Since the state was no longer recomputed when the new state was equal to the old state, this means that the rendering was no longer done when the model tokens changed but the state remained the same. A fix will be made to revert this change.

Related discussion:
text: readonly lineNumbers: number[], readonly lastLineRelativePosition: number ) { } <del> public equals(other: StickyScrollWidgetState | undefined): boolean { return !!other && this.lastLineRelativePosition === other.lastLineRelativePosition && equals(this.lineNumbers, other.lineNumbers); } </del> } const _ttPolicy = createTrustedTypesPolicy('stickyScrollViewLayer', { createHTML: value => value });
Code change:
in VS Code :bug: sticky scroll has no syntax highlighting <img width="691" alt="image" src=""
Hey I update my insiders version and tested on the file you sent, I am currently not able to reproduce this error: ! I'll try to reproduce this issue. I think I may have seen this happen for a very brief moment.
It appears this is due to the following PR which attempted to fix Since the state was no longer recomputed when the new state was equal to the old state, this means that the rendering was no longer done when the model tokens changed but the state remained the same. A fix will be made to revert this change.

Related discussion:
text: private _lastLineRelativePosition: number = 0; private _hoverOnLine: number = -1; private _hoverOnColumn: number = -1; <del> private _state: StickyScrollWidgetState | undefined; </del> constructor( private readonly _editor: ICodeEditor
Code change:
in VS Code :bug: sticky scroll has no syntax highlighting <img width="691" alt="image" src=""
Hey I update my insiders version and tested on the file you sent, I am currently not able to reproduce this error: ! I'll try to reproduce this issue. I think I may have seen this happen for a very brief moment.
It appears this is due to the following PR which attempted to fix Since the state was no longer recomputed when the new state was equal to the old state, this means that the rendering was no longer done when the model tokens changed but the state remained the same. A fix will be made to revert this change.

Related discussion:
text: } setState(state: StickyScrollWidgetState): void { <del> if (state.equals(this._state)) { return; } this._state = state; </del> dom.clearNode(this._rootDomNode); this._disposableStore.clear(); this._lineNumbers.length = 0;
Code change:
create a folder with a task that uses: update an extension and use "Reload window" or use Reload window directly from the command pallette observe that the task now runs twice: <img width="328" alt="image" src=""
Likely a regression from one of the task fixes this iteration.
Not able to reproduce Do you have task.reconnection enabled? Would be helpful to see each of the terminals
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
This problem still exists, I'm afraid I'm not sure the repro steps are as Alex described, but I still get duplicated tasks
It seems for Alex's repro steps to work, the terminal panel needs to be hidden
When the panel is hidden, the tasks don't run at all for me atm. I'm going to merge something that will fix this part of the issue, but in order to truly test it, I'll have to first

Related discussion:
text: private _onDidChangeTaskSystemInfo: Emitter<void> = new Emitter(); private _willRestart: boolean = false; public onDidChangeTaskSystemInfo: Event<void> = this._onDidChangeTaskSystemInfo.event; <ins> private _onDidReconnectToTasks: Emitter<void> = new Emitter(); public onDidReconnectToTasks: Event<void> = this._onDidReconnectToTasks.event; </ins> constructor( @IConfigurationService private readonly _configurationService: IConfigurationService,
Code change:
create a folder with a task that uses: update an extension and use "Reload window" or use Reload window directly from the command pallette observe that the task now runs twice: <img width="328" alt="image" src=""
Likely a regression from one of the task fixes this iteration.
Not able to reproduce Do you have task.reconnection enabled? Would be helpful to see each of the terminals
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
This problem still exists, I'm afraid I'm not sure the repro steps are as Alex described, but I still get duplicated tasks
It seems for Alex's repro steps to work, the terminal panel needs to be hidden
When the panel is hidden, the tasks don't run at all for me atm. I'm going to merge something that will fix this part of the issue, but in order to truly test it, I'll have to first

Related discussion:
text: } this.getWorkspaceTasks(TaskRunSource.Reconnect).then(async () => { this._tasksReconnected = await this._reconnectTasks(); <ins> this._onDidReconnectToTasks.fire(); </ins> }); }
Code change:
create a folder with a task that uses: update an extension and use "Reload window" or use Reload window directly from the command pallette observe that the task now runs twice: <img width="328" alt="image" src=""
Likely a regression from one of the task fixes this iteration.
Not able to reproduce Do you have task.reconnection enabled? Would be helpful to see each of the terminals
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
This problem still exists, I'm afraid I'm not sure the repro steps are as Alex described, but I still get duplicated tasks
It seems for Alex's repro steps to work, the terminal panel needs to be hidden
When the panel is hidden, the tasks don't run at all for me atm. I'm going to merge something that will fix this part of the issue, but in order to truly test it, I'll have to first

Related discussion:
text: } if (executeResult.kind === TaskExecuteKind.Active) { const active = executeResult.active; <ins> if (active && active.same && runSource === TaskRunSource.FolderOpen) { // ignore, the task is already active, likely from being reconnected. this._logService.debug('Ignoring task that is already active', executeResult.task); return executeResult.promise; } </ins> if (active && active.same) { if (this._taskSystem?.isTaskVisible(executeResult.task)) { const message = nls.localize('TaskSystem.activeSame.noBackground', 'The task '{0}' is already active.', executeResult.task.getQualifiedLabel());
Code change:
create a folder with a task that uses: update an extension and use "Reload window" or use Reload window directly from the command pallette observe that the task now runs twice: <img width="328" alt="image" src=""
Likely a regression from one of the task fixes this iteration.
Not able to reproduce Do you have task.reconnection enabled? Would be helpful to see each of the terminals
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
This problem still exists, I'm afraid I'm not sure the repro steps are as Alex described, but I still get duplicated tasks
It seems for Alex's repro steps to work, the terminal panel needs to be hidden
When the panel is hidden, the tasks don't run at all for me atm. I'm going to merge something that will fix this part of the issue, but in order to truly test it, I'll have to first

Related discussion:
text: @IWorkspaceTrustManagementService private readonly _workspaceTrustManagementService: IWorkspaceTrustManagementService, @ILogService private readonly _logService: ILogService) { super(); <del> if (this._workspaceTrustManagementService.isWorkspaceTrusted()) { this._tryRunTasks(); } </del> <ins> this._taskService.onDidReconnectToTasks((() => { if (this._workspaceTrustManagementService.isWorkspaceTrusted()) { this._tryRunTasks(); } })); </ins> this._register(this._workspaceTrustManagementService.onDidChangeTrust(async trusted => { if (trusted) { await this._tryRunTasks();
Code change:
create a folder with a task that uses: update an extension and use "Reload window" or use Reload window directly from the command pallette observe that the task now runs twice: <img width="328" alt="image" src=""
Likely a regression from one of the task fixes this iteration.
Not able to reproduce Do you have task.reconnection enabled? Would be helpful to see each of the terminals
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
This problem still exists, I'm afraid I'm not sure the repro steps are as Alex described, but I still get duplicated tasks
It seems for Alex's repro steps to work, the terminal panel needs to be hidden
When the panel is hidden, the tasks don't run at all for me atm. I'm going to merge something that will fix this part of the issue, but in order to truly test it, I'll have to first

Related discussion:
text: export interface ITaskService { readonly _serviceBrand: undefined; onDidStateChange: Event<ITaskEvent>; <ins> onDidReconnectToTasks: Event<void>; </ins> supportsMultipleTaskExecutions: boolean; configureAction(): Action;
Code change:
Verification steps: Make sure you are on diff editor version 2. Enable whitespace only diffing (the reversed P in the toolbar). Diff two identical documents, change indentation. Verify that a notification is shown.
I cannot find your reversed P, nonetheless, with diff version 2 and removed "ignore leading/trailing whitespace", I get this: <img width="1384" alt="image" src=""and TBH, why should have an option to ignore any diff view? Isn't the purpose of the diff, to really see the diff? Git extensions -more logical diff: <img width="551" alt="image" src=""

Related discussion:
text: } }; observable.addObserver(observer); <ins> observable.reportChanges(); </ins> return { dispose() { observable.removeObserver(observer);
Code change:
Verification steps: Make sure you are on diff editor version 2. Enable whitespace only diffing (the reversed P in the toolbar). Diff two identical documents, change indentation. Verify that a notification is shown.
I cannot find your reversed P, nonetheless, with diff version 2 and removed "ignore leading/trailing whitespace", I get this: <img width="1384" alt="image" src=""and TBH, why should have an option to ignore any diff view? Isn't the purpose of the diff, to really see the diff? Git extensions -more logical diff: <img width="551" alt="image" src=""

Related discussion:
text: *--------------------------------------------------------------------------------------------*/ import * as assert from 'assert'; <del> import { Emitter } from 'vs/base/common/event'; </del> <ins> import { Emitter, Event } from 'vs/base/common/event'; </ins> import { ISettableObservable, autorun, derived, ITransaction, observableFromEvent, observableValue, transaction, keepAlive } from 'vs/base/common/observable'; import { BaseObservable, IObservable, IObserver } from 'vs/base/common/observableImpl/base';
Code change:
Verification steps: Make sure you are on diff editor version 2. Enable whitespace only diffing (the reversed P in the toolbar). Diff two identical documents, change indentation. Verify that a notification is shown.
I cannot find your reversed P, nonetheless, with diff version 2 and removed "ignore leading/trailing whitespace", I get this: <img width="1384" alt="image" src=""and TBH, why should have an option to ignore any diff view? Isn't the purpose of the diff, to really see the diff? Git extensions -more logical diff: <img width="551" alt="image" src=""

Related discussion:
text: myObservable2.set(1, tx); }); }); <ins> test('bug: fromObservableLight doesnt subscribe', () => { const log = new Log(); const myObservable = new LoggingObservableValue('myObservable', 0, log); const myDerived = derived('myDerived', reader => { const val = myObservable.read(reader); log.log(`myDerived.computed(myObservable2: ${val})`); return val % 10; }); const e = Event.fromObservableLight(myDerived); log.log('event created'); e(() => { log.log('event fired'); }); myObservable.set(1, undefined); assert.deepStrictEqual(log.getAndClearEntries(), [ 'event created', 'myObservable.firstObserverAdded', 'myObservable.get', 'myDerived.computed(myObservable2: 0)', 'myObservable.set (value 1)', 'myObservable.get', 'myDerived.computed(myObservable2: 1)', 'event fired', ]); }); </ins> }); export class LoggingObserver implements IObserver {
Code change:
enough cells in the interactive window that it needs to scroll "interactiveWindow.alwaysScrollOnNewCell": false to the bottom of the IW and execute another cell :bug: scrollbar height changes and is at the bottom, but the new cell isn't visible

Related discussion:
text: private _isInLayout: boolean = false; <del> private readonly _viewContext: ViewContext; </del> private _webviewElement: FastDomNode<HTMLElement> | null = null; get webviewElement() {
Code change:
enough cells in the interactive window that it needs to scroll "interactiveWindow.alwaysScrollOnNewCell": false to the bottom of the IW and execute another cell :bug: scrollbar height changes and is at the bottom, but the new cell isn't visible

Related discussion:
text: ) { super(listUser, container, delegate, renderers, options, contextKeyService, listService, configurationService, instantiationService); NOTEBOOK_CELL_LIST_FOCUSED.bindTo(this.contextKeyService).set(true); <del> this._viewContext = viewContext; </del> this._previousFocusedElements = this.getFocusedElements(); this._localDisposableStore.add(this.onDidChangeFocus((e) => { this._previousFocusedElements.forEach(element => {
Code change:
enough cells in the interactive window that it needs to scroll "interactiveWindow.alwaysScrollOnNewCell": false to the bottom of the IW and execute another cell :bug: scrollbar height changes and is at the bottom, but the new cell isn't visible

Related discussion:
text: const scrollHeight = this.view.scrollHeight; const scrollTop = this.getViewScrollTop(); const wrapperBottom = this.getViewScrollBottom(); <del> const topInsertToolbarHeight = this._viewContext.notebookOptions.computeTopInsertToolbarHeight(this.viewModel?.viewType); this.view.setScrollTop(scrollHeight - (wrapperBottom - scrollTop) - topInsertToolbarHeight); </del> <ins> this.view.setScrollTop(scrollHeight - (wrapperBottom - scrollTop)); </ins> } //#region Reveal Cell synchronously
Code change:
enough cells in the interactive window that it needs to scroll "interactiveWindow.alwaysScrollOnNewCell": false to the bottom of the IW and execute another cell :bug: scrollbar height changes and is at the bottom, but the new cell isn't visible

Related discussion:
text: } getViewScrollBottom() { <del> const topInsertToolbarHeight = this._viewContext.notebookOptions.computeTopInsertToolbarHeight(this.viewModel?.viewType); return this.getViewScrollTop() + this.view.renderHeight - topInsertToolbarHeight; </del> <ins> return this.getViewScrollTop() + this.view.renderHeight; </ins> } setCellEditorSelection(cell: ICellViewModel, range: Range) {
Code change:
enough cells in the interactive window that it needs to scroll "interactiveWindow.alwaysScrollOnNewCell": false to the bottom of the IW and execute another cell :bug: scrollbar height changes and is at the bottom, but the new cell isn't visible

Related discussion:
text: import * as assert from 'assert'; import { DisposableStore } from 'vs/base/common/lifecycle'; <del> import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; </del> import { TestInstantiationService } from 'vs/platform/instantiation/test/common/instantiationServiceMock'; import { CellKind } from 'vs/workbench/contrib/notebook/common/notebookCommon'; <del> import { INotebookExecutionStateService } from 'vs/workbench/contrib/notebook/common/notebookExecutionStateService'; import { NotebookOptions } from 'vs/workbench/contrib/notebook/browser/notebookOptions'; </del> import { createNotebookCellList, setupInstantiationService, withTestNotebook } from 'vs/workbench/contrib/notebook/test/browser/testNotebookEditor'; suite('NotebookCellList', () => { let disposables: DisposableStore; let instantiationService: TestInstantiationService; <del> let notebookDefaultOptions: NotebookOptions; let topInsertToolbarHeight: number; </del> suiteSetup(() => { disposables = new DisposableStore(); instantiationService = setupInstantiationService(disposables); <del> notebookDefaultOptions = new NotebookOptions(instantiationService.get(IConfigurationService), instantiationService.get(INotebookExecutionStateService), false); topInsertToolbarHeight = notebookDefaultOptions.computeTopInsertToolbarHeight(); </del> }); suiteTeardown(() => disposables.dispose());