jiebi/CodeConvo huggingface dataset:
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.0 OS Version:mac os monterey 12.3.1 Steps to Reproduce: to settings (command+,) for markdown drop <img width="719" alt="Screen Shot 2022-05-20 at 11 55 58 AM" src="https://user-"
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.67.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Confirmed on latest insiders Version: 1.68.0-insider Commit: Date: 2022-05-16T05:30:27.563Z Electron: 17.4.3 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Darwin arm64 21.4.0 <img width="636" alt="Screen Shot 2022-05-20 at 1 11 00 PM" src="https://user-"
Fixed as of
<img width="967" alt="image" src="https://user-"
Hey I see with the same fixes, already merged.
Yeah but it accidentally got reverted via This just brings your changes back in

Related discussion:
text: "configuration.markdown.links.openLocation.currentGroup": "Open links in the active editor group.", "configuration.markdown.links.openLocation.beside": "Open links beside the active editor.", "configuration.markdown.suggest.paths.enabled.description": "Enable/disable path suggestions for markdown links", <del> "configuration.markdown.editor.drop.enabled": "Enable/disable dropping into the markdown editor to insert shift. Requires enabling `#workbenck.experimental.editor.dropIntoEditor.enabled#`.", </del> <ins> "configuration.markdown.editor.drop.enabled": "Enable/disable dropping into the markdown editor to insert shift. Requires enabling `#workbench.experimental.editor.dropIntoEditor.enabled#`.", </ins> "configuration.markdown.experimental.validate.enabled.description": "Enable/disable all error reporting in Markdown files.", "configuration.markdown.experimental.validate.referenceLinks.enabled.description": "Validate reference links in Markdown files, e.g. `[link][ref]`.  Requires enabling `#markdown.experimental.validate.enabled#`.", "configuration.markdown.experimental.validate.headerLinks.enabled.description": "Validate links to headers in Markdown files, e.g. `[link](#header)`. Requires enabling `#markdown.experimental.validate.enabled#`.",
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.0 OS Version:mac os monterey 12.3.1 Steps to Reproduce: to settings (command+,) for markdown drop <img width="719" alt="Screen Shot 2022-05-20 at 11 55 58 AM" src="https://user-"
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.67.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Confirmed on latest insiders Version: 1.68.0-insider Commit: Date: 2022-05-16T05:30:27.563Z Electron: 17.4.3 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Darwin arm64 21.4.0 <img width="636" alt="Screen Shot 2022-05-20 at 1 11 00 PM" src="https://user-"
Fixed as of
<img width="967" alt="image" src="https://user-"
Hey I see with the same fixes, already merged.
Yeah but it accidentally got reverted via This just brings your changes back in

Related discussion:
text: "configuration.markdown.links.openLocation.currentGroup": "Open links in the active editor group.", "configuration.markdown.links.openLocation.beside": "Open links beside the active editor.", "configuration.markdown.suggest.paths.enabled.description": "Enable/disable path suggestions for markdown links", <del> "configuration.markdown.editor.drop.enabled": "Enable/disable dropping into the markdown editor to insert shift. Requires enabling `#workbenck.experimental.editor.dropIntoEditor.enabled#`.", </del> <ins> "configuration.markdown.editor.drop.enabled": "Enable/disable dropping into the markdown editor to insert shift. Requires enabling `#workbench.experimental.editor.dropIntoEditor.enabled#`.", </ins> "configuration.markdown.editor.pasteLinks.enabled": "Enable/disable pasting files into a Markdown editor inserts Markdown links.", "configuration.markdown.experimental.validate.enabled.description": "Enable/disable all error reporting in Markdown files.", "configuration.markdown.experimental.validate.referenceLinks.enabled.description": "Validate reference links in Markdown files, e.g. `[link][ref]`.  Requires enabling `#markdown.experimental.validate.enabled#`.",
Code change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Love the new title control: ! My only problem is that I would often drag the window around by clicking and dragging the title bar. Since this takes up a large chunk of the title bar, I have less real estate to drag... but there's no reason the drag experience can't also apply to the area covered by the title control. Can the drag of the title control bubble up to the title bar so that dragging the window works?
There is a technical reason... Marking things as drag-region () swallows all events and you won't be able to click onto things anymore... I can try adding the style while dragging but it might not be possible <img width="113" alt="Screenshot 2022-05-24 at 09 15 34" src="https://user-" that's more concerning here...
Yeah, I have tried to set the style during mouse down (with a delay) but that doesn't seem to have an effect Plan was to mark the element as app region drag when holding for 200ms
related issue (which caused this)
and more context - seems like a hard problem
Can the top 1-2 pixels not be part of the drag element/target?
yeah, it already should be like that, there is another PR in the works that increases the title bar height. with that merged, dragging be simpler again
The title bar height is now aligned with the height of editor tabs. This allows to drag the window when clicking on the space above/below the CC. https://user- That's the best I can do (and aligns with Slack etc). Set/unsetting the property while dragging isn't supported...
To verify: enable CC via make sure you can drag the app window with the regions above/below the CC (see )

Related discussion:
text: }); } <del> MenuRegistry.appendMenuItem(MenuId.TitleMenu, { command: { id: NavigateBackwardsAction.ID, title: NavigateBackwardsAction.LABEL, icon: Codicon.arrowLeft } }); MenuRegistry.appendMenuItem(MenuId.TitleMenu, { command: { id: NavigateForwardAction.ID, title: NavigateForwardAction.LABEL, icon: Codicon.arrowRight } }); </del> <ins> MenuRegistry.appendMenuItem(MenuId.TitleMenu, { order: 1, command: { id: NavigateBackwardsAction.ID, title: NavigateBackwardsAction.LABEL, icon: Codicon.arrowLeft } }); MenuRegistry.appendMenuItem(MenuId.TitleMenu, { order: 2, command: { id: NavigateForwardAction.ID, title: NavigateForwardAction.LABEL, icon: Codicon.arrowRight } }); </ins> // Empty Editor Group Toolbar MenuRegistry.appendMenuItem(MenuId.EmptyEditorGroup, { command: { id: UNLOCK_GROUP_COMMAND_ID, title: localize('unlockGroupAction', "Unlock Group"), icon: Codicon.lock }, group: 'navigation', order: 10, when: ActiveEditorGroupLockedContext });
Code change:
I'm building a custom Insiders to test one of the changes. The Linux localization smoke test seems to be failing consistently Edit: This result is likely a false positive. I think I forgot to update the branch.

Related discussion:
text: // Shared before/after handling installAllHandlers(logger); <del> // skipped until translations are available https://github.com/microsoft/vscode/issues/150324 it.skip('starts with "DE" locale and verifies title and viewlets text is in German', async function () { </del> <ins> it('starts with "DE" locale and verifies title and viewlets text is in German', async function () { </ins> const app = this.app as Application; await app.workbench.extensions.openExtensionsViewlet();
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --! Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.2 OS Version: Windows 11 10.0. Build Steps to Reproduce: the new folder button in the explorer panel; the new folder "**", without the quotation marks; text from red dialog box under the folder name is now bold, except for "The name ".
Probably because of markdown
The text box doesn't turn red or bold, so considering that a success
The text box should still be red saying it's an invalid file name on windows. Just the text should not become bold
I think the box is supposed to be red
the box did not turn red for me with a folder name of
Was this on windows?
no it's working for me on windows. it wasn't working on mac
** just happens to be a valid file name on macOS , thanks for verifying!

Related discussion:
text: // Check for invalid file name. if (names.some(folderName => !pathService.hasValidBasename(item.resource, os, folderName))) { <ins> // Escape * characters const escapedName = name.replace(/*/g, '*'); </ins> return { <del> content: nls.localize('invalidFileNameError', "The name **{0}** is not valid as a file or folder name. Please choose a different name.", trimLongName(name)), </del> <ins> content: nls.localize('invalidFileNameError', "The name **{0}** is not valid as a file or folder name. Please choose a different name.", trimLongName(escapedName)), </ins> severity: Severity.Error }; }
Code change:
Testing This file has several headers which contain square brackets, and the contents that are delimited by square brackets get the link validation treatment ! One escape hatch for users is probably to set , but then you end up losing all reference link validation. Wondering if there is a less aggressive in-between option here, e.g. not validating link syntax in headers?
I'm taking this.
I've just submitted the PR.
Links in headers are valid. You can escape them if you don't want them to be considered link: I'm updating this issue to focus on links incorrectly be detected inside of other links, which your screenshots also shows
I've just submitted another PR. Could you please check it?
With Insiders on , it still seems like nested links are getting detected: !
Looks like the current fix doesn't handle cases where there are no spaces in the brackets. Will push a PR with a fix
I'm still seeing on the latest Insiders on macOS.

Related discussion:
text: /** * Matches `[text](link)` */ <del> const linkPattern = /([((![[^]]*?](s*)([^s()]+?)s*)]|(?:]|[^]])*])(s*)(([^s()]|([^s()]*?))+)s*("[^"]*"|'[^']*'|([^()]*))?s*)/g; </del> <ins> const linkPattern = /([((![[^]]*?](s*)([^s()]+?)s*)]|(?:]|[^]]|][^(])*])(s*)(([^s()]|([^s()]*?))+)s*("[^"]*"|'[^']*'|([^()]*))?s*)/g; </ins> /** * Matches `[text](<link>)` */ <del> const linkPatternAngle = /([((![[^]]*?](s*)([^s()]+?)s*)]|(?:]|[^]])*])(s*<)(([^<>]|([^s()]*?))+)>s*("[^"]*"|'[^']*'|([^()]*))?s*)/g; </del> <ins> const linkPatternAngle = /([((![[^]]*?](s*)([^s()]+?)s*)]|(?:]|[^]]|][^(])*])(s*<)(([^<>]|([^s()]*?))+)>s*("[^"]*"|'[^']*'|([^()]*))?s*)/g; </ins> /**
Code change:
Testing This file has several headers which contain square brackets, and the contents that are delimited by square brackets get the link validation treatment ! One escape hatch for users is probably to set , but then you end up losing all reference link validation. Wondering if there is a less aggressive in-between option here, e.g. not validating link syntax in headers?
I'm taking this.
I've just submitted the PR.
Links in headers are valid. You can escape them if you don't want them to be considered link: I'm updating this issue to focus on links incorrectly be detected inside of other links, which your screenshots also shows
I've just submitted another PR. Could you please check it?
With Insiders on , it still seems like nested links are getting detected: !
Looks like the current fix doesn't handle cases where there are no spaces in the brackets. Will push a PR with a fix
I'm still seeing on the latest Insiders on macOS.

Related discussion:
text: } }); <ins> test('Should ignore texts in brackets inside link title (#150921)', async () => { { const links = await getLinksForFile('[some [inner bracket pairs] in title](<link>)'); assertLinksEqual(links, [ new vscode.Range(0, 39, 0, 43), ]); } { const links = await getLinksForFile('[some [inner bracket pairs] in title](link)'); assertLinksEqual(links, [ new vscode.Range(0, 38, 0, 42) ]); } }); </ins> test('Should handle two links without space', async () => { const links = await getLinksForFile('a ([test](test)[test2](test2)) c'); assertLinksEqual(links, [
Code change:
Testing This file has several headers which contain square brackets, and the contents that are delimited by square brackets get the link validation treatment ! One escape hatch for users is probably to set , but then you end up losing all reference link validation. Wondering if there is a less aggressive in-between option here, e.g. not validating link syntax in headers?
I'm taking this.
I've just submitted the PR.
Links in headers are valid. You can escape them if you don't want them to be considered link: I'm updating this issue to focus on links incorrectly be detected inside of other links, which your screenshots also shows
I've just submitted another PR. Could you please check it?
With Insiders on , it still seems like nested links are getting detected: !
Looks like the current fix doesn't handle cases where there are no spaces in the brackets. Will push a PR with a fix
I'm still seeing on the latest Insiders on macOS.

Related discussion:
text: private *getReferenceLinks(document: ITextDocument, noLinkRanges: NoLinkRanges): Iterable<MdLink> { const text = document.getText(); for (const match of text.matchAll(referenceLinkPattern)) { <del> const linkStart = document.positionAt(match.index ?? 0); </del> <ins> const linkStartOffset = (match.index ?? 0) + match[1].length; const linkStart = document.positionAt(linkStartOffset); </ins> if (noLinkRanges.contains(linkStart)) { continue; }
Code change:
Testing This file has several headers which contain square brackets, and the contents that are delimited by square brackets get the link validation treatment ! One escape hatch for users is probably to set , but then you end up losing all reference link validation. Wondering if there is a less aggressive in-between option here, e.g. not validating link syntax in headers?
I'm taking this.
I've just submitted the PR.
Links in headers are valid. You can escape them if you don't want them to be considered link: I'm updating this issue to focus on links incorrectly be detected inside of other links, which your screenshots also shows
I've just submitted another PR. Could you please check it?
With Insiders on , it still seems like nested links are getting detected: !
Looks like the current fix doesn't handle cases where there are no spaces in the brackets. Will push a PR with a fix
I'm still seeing on the latest Insiders on macOS.

Related discussion:
text: let reference = match[4]; if (reference === '') { // [ref][], reference = match[3]; <del> const offset = ((match.index ?? 0) + match[1].length) + 1; </del> <ins> const offset = linkStartOffset + 1; </ins> hrefStart = document.positionAt(offset); hrefEnd = document.positionAt(offset + reference.length); } else if (reference) { // [text][ref] const pre = match[2]; <del> const offset = ((match.index ?? 0) + match[1].length) + pre.length; </del> <ins> const offset = linkStartOffset + pre.length; </ins> hrefStart = document.positionAt(offset); hrefEnd = document.positionAt(offset + reference.length); } else if (match[5]) { // [ref] reference = match[5]; <del> const offset = ((match.index ?? 0) + match[1].length) + 1; </del> <ins> const offset = linkStartOffset + 1; </ins> hrefStart = document.positionAt(offset); const line = getLine(document, hrefStart.line); // See if link looks like a checkbox
Code change:
Testing This file has several headers which contain square brackets, and the contents that are delimited by square brackets get the link validation treatment ! One escape hatch for users is probably to set , but then you end up losing all reference link validation. Wondering if there is a less aggressive in-between option here, e.g. not validating link syntax in headers?
I'm taking this.
I've just submitted the PR.
Links in headers are valid. You can escape them if you don't want them to be considered link: I'm updating this issue to focus on links incorrectly be detected inside of other links, which your screenshots also shows
I've just submitted another PR. Could you please check it?
With Insiders on , it still seems like nested links are getting detected: !
Looks like the current fix doesn't handle cases where there are no spaces in the brackets. Will push a PR with a fix
I'm still seeing on the latest Insiders on macOS.

Related discussion:
text: continue; } <del> const linkEnd = linkStart.translate(0, match[0].length); </del> <ins> const linkEnd = linkStart.translate(0, match[0].length - match[1].length); </ins> yield { kind: 'link', source: {
Code change:
Testing This file has several headers which contain square brackets, and the contents that are delimited by square brackets get the link validation treatment ! One escape hatch for users is probably to set , but then you end up losing all reference link validation. Wondering if there is a less aggressive in-between option here, e.g. not validating link syntax in headers?
I'm taking this.
I've just submitted the PR.
Links in headers are valid. You can escape them if you don't want them to be considered link: I'm updating this issue to focus on links incorrectly be detected inside of other links, which your screenshots also shows
I've just submitted another PR. Could you please check it?
With Insiders on , it still seems like nested links are getting detected: !
Looks like the current fix doesn't handle cases where there are no spaces in the brackets. Will push a PR with a fix
I'm still seeing on the latest Insiders on macOS.

Related discussion:
text: new vscode.Range(0, 35, 0, 39), ]); } <ins> { const links = await getLinksForFile(joinLines( `# h`, `[[a]](http://example.com)`, )); assertLinksEqual(links, [ new vscode.Range(1, 6, 1, 24), ]); } </ins> }); test('Should handle two links without space', async () => {
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.0 OS Version: Win10 21H1 .1706 Steps to Reproduce: ! This is caused by When L122 , the element may have been created in the tree before. Thus, may be more than once and causes icon style conflict. ! A PR will be linked. Idea from After fix: !

Related discussion:
text: renderElement(node: ITreeNode<Call, FuzzyScore>, _index: number, template: CallRenderingTemplate): void { const { element, filterData } = node; const deprecated = element.item.tags?.includes(SymbolTag.Deprecated); <ins> template.icon.className = ''; </ins> template.icon.classList.add('inline', ...CSSIcon.asClassNameArray(SymbolKinds.toIcon(element.item.kind))); template.label.setLabel( element.item.name,
Code change:
!
works in OSS !
also works for me in insider's
works for that exact task for me !
It's because of this: Here's the I was using:
This works but it adds an extra line because of initialText so it doesn't look quite right: Before: ! After: !

Related discussion:
text: comment: ['The task command line or label'] }, 'Executing task: {0}', commandLine), { excludeLeadingNewLine: true }) + taskShellIntegrationOutputSequence; } <ins> } else { shellLaunchConfig.initialText = taskShellIntegrationStartSequence + taskShellIntegrationOutputSequence; </ins> } } else { const commandExecutable = (task.command.runtime !== RuntimeType.CustomExecution) ? CommandString.value(command) : undefined;
Code change:
!
works in OSS !
also works for me in insider's
works for that exact task for me !
It's because of this: Here's the I was using:
This works but it adds an extra line because of initialText so it doesn't look quite right: Before: ! After: !

Related discussion:
text: comment: ['The task command line or label'] }, 'Executing task: {0}', `${shellLaunchConfig.executable} ${getArgsToEcho(shellLaunchConfig.args)}`), { excludeLeadingNewLine: true }) + taskShellIntegrationOutputSequence; } <ins> } else { shellLaunchConfig.initialText = taskShellIntegrationStartSequence + taskShellIntegrationOutputSequence; </ins> } }
Code change:
!
works in OSS !
also works for me in insider's
works for that exact task for me !
It's because of this: Here's the I was using:
This works but it adds an extra line because of initialText so it doesn't look quite right: Before: ! After: !

Related discussion:
text: /** * A string including ANSI escape sequences that will be written to the terminal emulator <del> * _before_ the terminal process has launched, a trailing n is added at the end of the string. * This allows for example the terminal instance to display a styled message as the first line * of the terminal. Use x1b over 033 or e for the escape control character. </del> <ins> * _before_ the terminal process has launched, when a string is specified, a trailing n is * added at the end. This allows for example the terminal instance to display a styled message * as the first line of the terminal. Use x1b over 033 or e for the escape control character. </ins> */ <del> initialText?: string; </del> <ins> initialText?: string | { text: string; trailingNewLine: boolean }; </ins> /** * Custom PTY/pseudoterminal process to use.