Code change:
Terminal live output is not announced. As far as I tested on Windows with JAWS and NVDA, terminal aria-live event is not auto-announced. I typed "echo hello" in terminal, but there was no read-aloud feedback.
since the buffer will now be readonly, I think this can be closed. Voice over and NVDA are announcing as I type
Aw, I think there was a miscommunication between us. The issue that I highlight here is not the input announcement. I am talking about the auto output announcement. For example, if you open an external terminal on Mac or or on Windows outside VSCode, executing any command, such as will make your screen reader read aloud the output as soon as you hit return key. The VSCode terminal was behaving like this before the a11y terminal buffer. What you have seen is that screen-reader users want this real-time output announcement per command execution just like before. This no longer works as far as I tested with NVDA and JAWS on Windows.
Thanks for clarifying. I was confused by: Now I understand
I can repro this not working in the latest stable VS Code as well. I type and it does not read
-- Aw, that's my bad! Sorry for confusing you. I assume that attribute got broken somewhere for the terminal a11y buffer.
I have just spent the last 2 hours looking into the output not being read issue and am stumped . since I can repro in Stable, I don't think this is a regression. We're doing the right thing here and debugging showed the element's text content is updated to be the output on enter, but the browser /screen reader is not reading it
-- I would try the following: if aria-live works when terminal buffer container is marked with instead of (also need to remove role = "textbox" for this testing). works, just add textbox role and see if it works.
thanks for the suggestion. still does not work with that. I'm going to try to find the last commit where this was working - which will be at least a month ago
in version 1.72 of VS Code stable, it similarly does not work for short output, but does read the message "too much output to announce for the command for example.
also just tried reverting all of my changes (adding the accessibility buffer) and that does not fix it
navigation mode also works in 1.72
the element doesn't exist in insider's with screen reader mode on while it does exist in version 1.72 <img width="935" alt="Screenshot 2023-01-23 at 2 53 35 PM" src="https://user-"<img width="1247" alt="Screenshot 2023-01-23 at 2 53 15 PM" src="https://user-"

Related discussion:
text: resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.15.0-beta.4.tgz#d03a98e446372a5dbb7d92075d1f125eec23b030" integrity sha512-W9N0+5i3trQhgBOHDsnNiBbBiJpleFenY668wWaZ9GlvWseCTnjnWis1kfnM9WASDh/0+7aOjWrD089o+QeHGQ== <del> xterm@5.2.0-beta.19: version "5.2.0-beta.19" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.19.tgz#b3fd2eda3d9aa2672abaf03e864fafe64269c8a0" integrity sha512-3U+NYHjnIdUQf+MXiitmoFAcBOaLFHid3R/LzzvELjMwQx227EFk+3OmQjkBt7eH/IR+A4VlP5aPGmgriyLtGQ== </del> <ins> xterm@5.2.0-beta.20: version "5.2.0-beta.20" resolved "https://registry.yarnpkg.com/xterm/-/xterm-5.2.0-beta.20.tgz#52ed300d7077ce394f7656655ad07d90f96c6c64" integrity sha512-UIbFYmUPNTOSYIhAt/2pJ9AF7nc8RxT2k2bBUZOER4VdaeA89FH3xcNC5/3OysPkn6QS9INcYS2dX5gM2RnChg== </ins>