Code change:
Testing No matter whether I use or set it to some other keybinding, I cannot seem to invoke this command with a keyboard shortcut--only from the command palette.
I cannot repro on mac, windows, or linux, could you pls run and provide me with the logs? The terminal has to be focused btw for it to work
Yeah the terminal was focused in my testing. Weirdly enough, seems to work now--definitely wasn't working before though.
I've run into this as well. Here's the output when turned on Toggle Keyboard Shortcuts Troubleshooting: 2023-01-24 19:45:48.902 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:48.925 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:48.925 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:48.925 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:48.925 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.404 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.404 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.404 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.405 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.405 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.435 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.435 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.435 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.435 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.435 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.482 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.482 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.482 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.483 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.483 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.513 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.514 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.514 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.514 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.514 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.544 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.545 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.545 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.545 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.545 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.577 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.577 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.577 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.577 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.578 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.608 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.608 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.608 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.608 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.609 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.641 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.642 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.642 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.643 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.643 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.673 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.673 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.674 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.674 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.675 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.703 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.703 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.703 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.703 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.704 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.735 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.736 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.736 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.736 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.736 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.767 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.767 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.767 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.768 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.768 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.798 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.798 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.798 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.799 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.799 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.844 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.844 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.845 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.845 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.845 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.877 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.877 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.878 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.878 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.879 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.907 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.908 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:49.909 [info] [KeybindingService]: / Received keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 16, key: Shift 2023-01-24 19:45:49.909 [info] [KeybindingService]: | Converted keydown event - modifiers: [shift], code: ShiftLeft, keyCode: 4 ('Shift') 2023-01-24 19:45:49.910 [info] [KeybindingService]:  Keyboard event cannot be dispatched in keydown phase. 2023-01-24 19:45:49.916 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:49.917 [info] [KeybindingService]: | Resolving shift+F1 2023-01-24 19:45:49.917 [info] [KeybindingService]:  From 2 keybinding entries, matched , when: terminalFocus && terminalProcessSupported, source: built-in. 2023-01-24 19:45:50.063 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:50.063 [info] [KeybindingService]: | Resolving shift+F1 2023-01-24 19:45:50.063 [info] [KeybindingService]:  From 2 keybinding entries, matched , when: terminalFocus && terminalProcessSupported, source: built-in. 2023-01-24 19:45:50.483 [info] [KeybindingService]: / Soft dispatching keyboard event 2023-01-24 19:45:50.483 [info] [KeybindingService]:  Keyboard event cannot be dispatched 2023-01-24 19:45:50.484 [info] [KeybindingService]: + Ignoring single modifier shift due to it being pressed together with other keys.
This was on my Surface with Windows 11. I wonder if it has to do with needing to press the Windows function key to get my F1 key? I need to do Shift + Function + F1 as without the Function key, F1 is the screen dimmer. Alt+Function+F1 works for showing the regular accessibility help. I wonder what that code is doing to work?
This is expected as to use , the function key needs to be activated. in the terminal does funny things on Windows/Linux, which is why we went with instead here
On Windows, when I set the keybinding to , it's not a valid chord and the result from the keybinding service is . That's true even when I set the weight for our action to be greater than workbench contrib. It doesn't work even when I set . Thus, we need to stick with here and the function key has to be used before pressing . !
shift+f1 isn't working for me

Related discussion:
text: primary: KeyMod.Alt | KeyCode.F1, weight: KeybindingWeight.WorkbenchContrib, linux: { <del> primary: KeyMod.Shift | KeyCode.F1, secondary: [KeyMod.Shift | KeyCode.F1] }, win: { primary: KeyMod.Shift | KeyCode.F1, secondary: [KeyMod.Shift | KeyCode.F1] </del> <ins> primary: KeyMod.Alt | KeyMod.Shift | KeyCode.F1, secondary: [KeyMod.Alt | KeyCode.F1] </ins> }, when: TerminalContextKeys.focus }