jiebi/CodeConvo huggingface dataset:
Code change:
enough cells in the interactive window that it needs to scroll "interactiveWindow.alwaysScrollOnNewCell": false to the bottom of the IW and execute another cell :bug: scrollbar height changes and is at the bottom, but the new cell isn't visible

Related discussion:
text: cellList.attachViewModel(viewModel); // render height 210, it can render 3 full cells and 1 partial cell <del> cellList.layout(210 + topInsertToolbarHeight, 100); </del> <ins> cellList.layout(210, 100); </ins> // scroll a bit, scrollTop to bottom: 5, 215 cellList.scrollTop = 5;
Code change:
enough cells in the interactive window that it needs to scroll "interactiveWindow.alwaysScrollOnNewCell": false to the bottom of the IW and execute another cell :bug: scrollbar height changes and is at the bottom, but the new cell isn't visible

Related discussion:
text: cellList.attachViewModel(viewModel); // render height 210, it can render 3 full cells and 1 partial cell <del> cellList.layout(210 + topInsertToolbarHeight, 100); </del> <ins> cellList.layout(210, 100); </ins> // init scrollTop and scrollBottom assert.deepStrictEqual(cellList.scrollTop, 0);
Code change:
Testing Repro: screen reader mode the editor the show notification command, :bug: the editor is still focused the show notification command, the notification center is now focused?
My notification was read once fully, then the screen reader started reading it a second time. Part way through that second time, the notification no longer seemed selected (didn't have a blue box around it), and the screen reader just stopped reading it.
the looks correct here, but I can repro the focus getting stuck in the editor any thoughts would be appreciated

Related discussion:
text: if (this._isVisible) { const notificationsList = assertIsDefined(this.notificationsList); <del> // Make visible and focus first notificationsList.show(true /* focus */); </del> <ins> // Make visible notificationsList.show(); // Focus first </ins> notificationsList.focusFirst(); return; // already visible
Code change:
Testing Repro: screen reader mode the editor the show notification command, :bug: the editor is still focused the show notification command, the notification center is now focused?
My notification was read once fully, then the screen reader started reading it a second time. Part way through that second time, the notification no longer seemed selected (didn't have a blue box around it), and the screen reader just stopped reading it.
the looks correct here, but I can repro the focus getting stuck in the editor any thoughts would be appreciated

Related discussion:
text: import { NotificationsListDelegate, NotificationRenderer } from 'vs/workbench/browser/parts/notifications/notificationsViewer'; import { CopyNotificationMessageAction } from 'vs/workbench/browser/parts/notifications/notificationsActions'; import { IContextMenuService } from 'vs/platform/contextview/browser/contextView'; <del> import { assertIsDefined, assertAllDefined } from 'vs/base/common/types'; </del> <ins> import { assertAllDefined } from 'vs/base/common/types'; </ins> import { NotificationFocusedContext } from 'vs/workbench/common/contextkeys'; import { Disposable } from 'vs/base/common/lifecycle'; import { AriaRole } from 'vs/base/browser/ui/aria/aria';
Code change:
Testing Repro: screen reader mode the editor the show notification command, :bug: the editor is still focused the show notification command, the notification center is now focused?
My notification was read once fully, then the screen reader started reading it a second time. Part way through that second time, the notification no longer seemed selected (didn't have a blue box around it), and the screen reader just stopped reading it.
the looks correct here, but I can repro the focus getting stuck in the editor any thoughts would be appreciated

Related discussion:
text: super(); } <del> show(focus?: boolean): void { </del> <ins> show(): void { </ins> if (this.isVisible) { <del> if (focus) { const list = assertIsDefined(this.list); list.domFocus(); } </del> return; // already visible }
Code change:
Testing Repro: screen reader mode the editor the show notification command, :bug: the editor is still focused the show notification command, the notification center is now focused?
My notification was read once fully, then the screen reader started reading it a second time. Part way through that second time, the notification no longer seemed selected (didn't have a blue box around it), and the screen reader just stopped reading it.
the looks correct here, but I can repro the focus getting stuck in the editor any thoughts would be appreciated

Related discussion:
text: // Make visible this.isVisible = true; <del> // Focus if (focus) { const list = assertIsDefined(this.list); list.domFocus(); } </del> } private createNotificationsList(): void {
Code change:
Testing Repro: screen reader mode the editor the show notification command, :bug: the editor is still focused the show notification command, the notification center is now focused?
My notification was read once fully, then the screen reader started reading it a second time. Part way through that second time, the notification no longer seemed selected (didn't have a blue box around it), and the screen reader just stopped reading it.
the looks correct here, but I can repro the focus getting stuck in the editor any thoughts would be appreciated

Related discussion:
text: } focusFirst(): void { <del> if (!this.isVisible || !this.list) { return; // hidden </del> <ins> if (!this.list) { return; // not created yet </ins> } this.list.focusFirst();
Code change:
Testing Repro: screen reader mode the editor the show notification command, :bug: the editor is still focused the show notification command, the notification center is now focused?
My notification was read once fully, then the screen reader started reading it a second time. Part way through that second time, the notification no longer seemed selected (didn't have a blue box around it), and the screen reader just stopped reading it.
the looks correct here, but I can repro the focus getting stuck in the editor any thoughts would be appreciated

Related discussion:
text: } hasFocus(): boolean { <del> if (!this.isVisible || !this.listContainer) { return false; // hidden </del> <ins> if (!this.listContainer) { return false; // not created yet </ins> } return isAncestor(document.activeElement, this.listContainer);
Code change:
a md file: between the html elements bug This inserts markdown syntax even though markdown typically isn't supported inside of html like this:
Likely requires a proper markdown parser to fix
I don't know if this is the expected result, since I don't see any difference pasting in the tags. I tried using two versions of .
Thanks for testing. I think there's still a bug with . In this case it should likely not paste as a markdown link. Somewhat weird case because it's the pasting itself that makes the html span multiple lines. With the newlines it's two entirely separate html blocks according to markdown

Related discussion:
text: } } <ins> const textTokenTypes = new Set(['paragraph_open', 'inline', 'heading_open', 'ordered_list_open', 'bullet_list_open', 'list_item_open', 'blockquote_open']); </ins> async function shouldSmartPasteForSelection( parser: IMdParser, document: ITextDocument,
Code change:
a md file: between the html elements bug This inserts markdown syntax even though markdown typically isn't supported inside of html like this:
Likely requires a proper markdown parser to fix
I don't know if this is the expected result, since I don't see any difference pasting in the tags. I tried using two versions of .
Thanks for testing. I think there's still a bug with . In this case it should likely not paste as a markdown link. Somewhat weird case because it's the pasting itself that makes the html span multiple lines. With the newlines it's two entirely separate html blocks according to markdown

Related discussion:
text: if (token.isCancellationRequested) { return false; } <del> for (const token of tokens) { if (token.map && token.map[0] <= selectedRange.start.line && token.map[1] > selectedRange.start.line) { if (!['paragraph_open', 'inline', 'heading_open', 'ordered_list_open', 'bullet_list_open', 'list_item_open', 'blockquote_open'].includes(token.type)) { </del> <ins> for (let i = 0; i < tokens.length; i++) { const token = tokens[i]; if (!token.map) { continue; } if (token.map[0] <= selectedRange.start.line && token.map[1] > selectedRange.start.line) { if (!textTokenTypes.has(token.type)) { return false; } } // Special case for html such as: // // <b> // | // </b> // // In this case pasting will cause the html block to be created even though the cursor is not currently inside a block if (token.type === 'html_block' && token.map[1] === selectedRange.start.line) { const nextToken = tokens.at(i + 1); // The next token does not need to be a html_block, but it must be on the next line if (nextToken?.map?.[0] === selectedRange.end.line + 1) { </ins> return false; } }
Code change:
I was just looking at the field of our event and I noticed that a lot of the durations are negative. Looking at the code here It looks like we are computing the miliseconds since 1970. I guess that we are hitting some overflow, and thus the numbers are negative. I suggest that we instead use the class that Joh is using here for example I can go ahead and push a fix for this.
I am not 100% sure if using would fix this. at the end of the day uses , and you were using . It looks like getTime treats timezones differently. So my proposed fix might fix the problem or it might not. What do you think Here's the Kusto query to see the events with the negative durations
I have pushed a potential fix for this. To verify run the above query in kusto Make sure that no events are happening in the latest VS Code Stable / Insiders version (thus that the fix indeed fixes it). I am assigning this to September to give it some time for the data to settle in.
Thanks for the fix. Using is the right thing here.

Related discussion:
text: import { resolveMarketplaceHeaders } from 'vs/platform/externalServices/common/marketplace'; import { IStorageService } from 'vs/platform/storage/common/storage'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; <ins> import { StopWatch } from 'vs/base/common/stopwatch'; </ins> const CURRENT_TARGET_PLATFORM = isWeb ? TargetPlatform.WEB : getTargetPlatform(platform, arch); const ACTIVITY_HEADER_NAME = 'X-Market-Search-Activity-Id';
Code change:
I was just looking at the field of our event and I noticed that a lot of the durations are negative. Looking at the code here It looks like we are computing the miliseconds since 1970. I guess that we are hitting some overflow, and thus the numbers are negative. I suggest that we instead use the class that Joh is using here for example I can go ahead and push a fix for this.
I am not 100% sure if using would fix this. at the end of the day uses , and you were using . It looks like getTime treats timezones differently. So my proposed fix might fix the problem or it might not. What do you think Here's the Kusto query to see the events with the negative durations
I have pushed a potential fix for this. To verify run the above query in kusto Make sure that no events are happening in the latest VS Code Stable / Insiders version (thus that the fix indeed fixes it). I am assigning this to September to give it some time for the data to settle in.
Thanks for the fix. Using is the right thing here.

Related discussion:
text: } if (needAllVersions.size) { <del> const startTime = new Date().getTime(); </del> <ins> const stopWatch = new StopWatch(); </ins> const query = new Query() .withFlags(flags & ~Flags.IncludeLatestVersionOnly, Flags.IncludeVersions) .withPage(1, needAllVersions.size) .withFilter(FilterType.ExtensionId, ...needAllVersions.keys()); const { extensions } = await this.queryGalleryExtensions(query, criteria, token); this.telemetryService.publicLog2<GalleryServiceAdditionalQueryEvent, GalleryServiceAdditionalQueryClassification>('galleryService:additionalQuery', { <del> duration: new Date().getTime() - startTime, </del> <ins> duration: stopWatch.elapsed(), </ins> count: needAllVersions.size }); for (const extension of extensions) {
Code change:
I was just looking at the field of our event and I noticed that a lot of the durations are negative. Looking at the code here It looks like we are computing the miliseconds since 1970. I guess that we are hitting some overflow, and thus the numbers are negative. I suggest that we instead use the class that Joh is using here for example I can go ahead and push a fix for this.
I am not 100% sure if using would fix this. at the end of the day uses , and you were using . It looks like getTime treats timezones differently. So my proposed fix might fix the problem or it might not. What do you think Here's the Kusto query to see the events with the negative durations
I have pushed a potential fix for this. To verify run the above query in kusto Make sure that no events are happening in the latest VS Code Stable / Insiders version (thus that the fix indeed fixes it). I am assigning this to September to give it some time for the data to settle in.
Thanks for the fix. Using is the right thing here.

Related discussion:
text: 'Content-Length': String(data.length), }; <del> const startTime = new Date().getTime(); </del> <ins> const stopWatch = new StopWatch(); </ins> let context: IRequestContext | undefined, error: any, total: number = 0; try {
Code change:
I was just looking at the field of our event and I noticed that a lot of the durations are negative. Looking at the code here It looks like we are computing the miliseconds since 1970. I guess that we are hitting some overflow, and thus the numbers are negative. I suggest that we instead use the class that Joh is using here for example I can go ahead and push a fix for this.
I am not 100% sure if using would fix this. at the end of the day uses , and you were using . It looks like getTime treats timezones differently. So my proposed fix might fix the problem or it might not. What do you think Here's the Kusto query to see the events with the negative durations
I have pushed a potential fix for this. To verify run the above query in kusto Make sure that no events are happening in the latest VS Code Stable / Insiders version (thus that the fix indeed fixes it). I am assigning this to September to give it some time for the data to settle in.
Thanks for the fix. Using is the right thing here.

Related discussion:
text: this.telemetryService.publicLog2<GalleryServiceQueryEvent, GalleryServiceQueryClassification>('galleryService:query', { ...query.telemetryData, requestBodySize: String(data.length), <del> duration: new Date().getTime() - startTime, </del> <ins> duration: stopWatch.elapsed(), </ins> success: !!context && isSuccess(context), responseBodySize: context?.res.headers['Content-Length'], statusCode: context ? String(context.res.statusCode) : undefined,
Code change:
Type: <bBug</bOn Mac, in terminal, press Option+F1. It says: Go to Next Command (Command+DownArrow) Go to Previous Command (Command+UpArrow) This has been recently updated as: Option+Up/DownArrows. VS Code version: Code - Insiders 1.81.0-insider (Universal) (, 2023-07-28T12:09:45.183Z) OS version: Darwin arm64 22.5.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (90)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 dscodegpt2.1.15 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.294 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 chatgpt1.1.2 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Yes reported this, but I cannot find that issue, so we'll track it here. This is because of this line

Related discussion:
text: } } <del> this._currentContent = message + provider.provideContent() + readMoreLink + disableHelpHint + localize('exit-tip', 'nnExit this dialog via the Escape key.'); </del> <ins> this._currentContent = message + provider.provideContent() + readMoreLink + disableHelpHint + localize('exit-tip', 'nExit this dialog via the Escape key.'); </ins> this._updateContextKeys(provider, true); this._getTextModel(URI.from({ path: `accessible-view-${provider.verbositySettingKey}`, scheme: 'accessible-view', fragment: this._currentContent })).then((model) => {
Code change:
Type: <bBug</bIn editor, I can't use and alt+[` do not have specific "when" clause and conflict against inline suggestion view in keybindings. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-28T12:08:04.472Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (89)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.297 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --

Related discussion:
text: const accessibleViewService = accessor.get(IAccessibleViewService); accessibleViewService.next(); return true; <del> }, accessibleViewIsShown)); </del> <ins> })); </ins> this._register(AccessibleViewPreviousAction.addImplementation(95, 'previous', accessor => { const accessibleViewService = accessor.get(IAccessibleViewService); accessibleViewService.previous(); return true; <del> }, accessibleViewIsShown)); </del> <ins> })); </ins> } }
Code change:
Type: <bBug</bIn editor, I can't use and alt+[` do not have specific "when" clause and conflict against inline suggestion view in keybindings. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-28T12:08:04.472Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (89)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.19.1 gitlens14.1.1 EditorConfig0.16.4 prettier-vscode9.19.0 vscode-google-translate1.4.13 codespaces1.14.13 copilot1.99.297 copilot-chat0.5. remotehub0.60.0 vscode-github-actions0.25.8 vscode-pull-request-github0.68.1 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.3 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.12.0 vscode-pylance2023.7.40 jupyter2023.6. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.80.2 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.7.2417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.90.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.52.0 vscode-java-dependency0.23.0 vscode-java-pack0.25.12 vscode-java-test0.39.0 vscode-maven0.41.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --

Related discussion:
text: import { KeyCode, KeyMod } from 'vs/base/common/keyCodes'; import { KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry'; import { MenuId } from 'vs/platform/actions/common/actions'; <ins> import { RawContextKey } from 'vs/platform/contextkey/common/contextkey'; export const accessibilityHelpIsShown = new RawContextKey<boolean>('accessibilityHelpIsShown', false, true); export const accessibleViewIsShown = new RawContextKey<boolean>('accessibleViewIsShown', false, true); </ins> export const enum AccessibilityVerbositySettingId { Terminal = 'accessibility.verbosity.terminal',