jiebi/CodeConvo huggingface dataset:
Code change:
First, thanks for making VSCode soooo awesome! Wouldn't be as productive as I am without it Currently, VSCode suggests installing the to have support for TypeScript. However, is supposedly going to be deprecated sometime this year. ! Change the suggested extension to ESLint instead. This way, we're providing a solution to the community that is future-proof (at least for the foreseeable future) I'd be happy to open a PR if you were to accept this proposed solution. (it looks like this would be a matter of replacing the extension id here: )
Removing it sounds good. We already stopped recommending tslint for general ts users: Probably just remove the whole typescript section for now. Setting up eslint for TypeScript is not simple enough at the moment to show on the welcome page in my opinion Can you submit a PR that does that?
Agree with you there. Definitely!
I noticed you the "help wanted". I'm planning to submit a PR. Can we change the label indicate this issue is in progress or taken?

Related discussion:
text: const extensionPacks: ExtensionSuggestion[] = [ { name: localize('welcomePage.javaScript', "JavaScript"), id: 'dbaeumer.vscode-eslint' }, <del> { name: localize('welcomePage.typeScript', "TypeScript"), id: 'ms-vscode.vscode-typescript-tslint-plugin' }, </del> { name: localize('welcomePage.python', "Python"), id: 'ms-python.python' }, // { name: localize('welcomePage.go', "Go"), id: 'lukehoban.go' }, { name: localize('welcomePage.php', "PHP"), id: 'felixfbecker.php-pack' },
Code change:
! ! Version: 1.39.2 autoReveal always moves the filename entry to the middle in file explorer window when we select a file on tab. if the filename is not visible in the explorer, this is ok. if the filename is visible in explorer, it should not move the filename to the middle in explorer, just highlight the filename where it is, right there in explorer. thanks!
I've taken a stab at this in as it's something that annoys me, hope that's alright

Related discussion:
text: if (item.isDisposed) { return this.onSelectResource(resource, reveal, retry + 1); } <del> this.tree.reveal(item, 0.5); </del> <ins> // Don't scroll to the item if it's already visible if (this.tree.getRelativeTop(item) === null) { this.tree.reveal(item, 0.5); } </ins> } this.tree.setFocus([item]);
Code change:
I'd love it if the description would specify that this setting only pertains to the command as explained in , as opposed to the SCM interface, which would be the expected behavior according to the current description.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.564 --<!-- potentialduplicatescomment --
Feel free to submit a PR for this instead. Here's where you want to edit:
Cool, thanks!

Related discussion:
text: "config.scanRepositories": "List of paths to search for git repositories in.", "config.showProgress": "Controls whether git actions should show progress.", "config.rebaseWhenSync": "Force git to use rebase when running the sync command.", <del> "config.confirmEmptyCommits": "Always confirm the creation of empty commits.", </del> <ins> "config.confirmEmptyCommits": "Always confirm the creation of empty commits for the 'Git: Commit Empty' command.", </ins> "config.fetchOnPull": "Fetch all branches when pulling or just the current one.", "config.pullTags": "Fetch all tags when pulling.", "config.autoStash": "Stash any changes before pulling and restore them after successful pull.",
Code change:
Babel 7.7 introduces a : , which shares the schema with . When editing a , one expect to see JSON validations same as . I tag it as feature request as Babel 7.7 is not yet released.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.92 --<!-- potentialduplicatescomment --

Related discussion:
text: "url": "https://schemastore.azurewebsites.net/schemas/json/babelrc.json" }, { <ins> "fileMatch": "babel.config.json", "url": "https://schemastore.azurewebsites.net/schemas/json/babelrc.json" }, { </ins> "fileMatch": "jsconfig.json", "url": "https://schemastore.azurewebsites.net/schemas/json/jsconfig.json" },
Code change:
Issue Type: <bBug</bTypeScript references code lenses the VS Code Code base, open the line: After type a comma then and re-type again Bug Suggestions take forever to come in Computing the references in TypeScript can potentially be expensive. This is caused because the method is not being as aggressively canceled when the document changes as I expect it to be (and as I believe it used to be) We can workaround this on the TS side but it seems like unexpected behavior /cc VS Code version: Code - OSS Dev 1.41.0 (Commit unknown, Date unknown) OS version: Darwin x64 18.7.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Adds a TS specific fix. Whenever the document changes, we now aggressively cancel all existing code lens requests against the TS server for that document
I believe nothing has changed here - at least not as far as my recent memory goes... Cancellation happens after 250ms which isn't aggressive but should also not be perceived as overly slow. Are those 250ms the delay you were seeing?
the delay is more like several seconds. It could be because we now provide references code lenses for object members, which adds a lot more references for TS to compute.
hm... but the delay/debounce on the by this... Does work happens on the extension host thread (not the tsserver-process) so that the cancellation doesn't come through until the event loop is free again?
Ok, so after more digging, I don't think is related to the debounce. Instead it seems some calls to are not ever canceled when the document changes. Here's the basic sequence I see on the extension host side: The issue is that the first batch of resolve requests (40-49) are not cancelled when they should be Resolving individual TS code lenses can take around a second in some cases
Nice find and kudos for digging through that code

Related discussion:
text: return; } <del> this._currentResolveCodeLensSymbolsPromise = createCancelablePromise(token => { </del> <ins> const resolvePromise = createCancelablePromise(token => { </ins> const promises = toResolve.map((request, i) => {
Code change:
Issue Type: <bBug</bTypeScript references code lenses the VS Code Code base, open the line: After type a comma then and re-type again Bug Suggestions take forever to come in Computing the references in TypeScript can potentially be expensive. This is caused because the method is not being as aggressively canceled when the document changes as I expect it to be (and as I believe it used to be) We can workaround this on the TS side but it seems like unexpected behavior /cc VS Code version: Code - OSS Dev 1.41.0 (Commit unknown, Date unknown) OS version: Darwin x64 18.7.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Adds a TS specific fix. Whenever the document changes, we now aggressively cancel all existing code lens requests against the TS server for that document
I believe nothing has changed here - at least not as far as my recent memory goes... Cancellation happens after 250ms which isn't aggressive but should also not be perceived as overly slow. Are those 250ms the delay you were seeing?
the delay is more like several seconds. It could be because we now provide references code lenses for object members, which adds a lot more references for TS to compute.
hm... but the delay/debounce on the by this... Does work happens on the extension host thread (not the tsserver-process) so that the cancellation doesn't come through until the event loop is free again?
Ok, so after more digging, I don't think is related to the debounce. Instead it seems some calls to are not ever canceled when the document changes. Here's the basic sequence I see on the extension host side: The issue is that the first batch of resolve requests (40-49) are not cancelled when they should be Resolving individual TS code lenses can take around a second in some cases
Nice find and kudos for digging through that code

Related discussion:
text: return Promise.all(promises); }); <ins> this._currentResolveCodeLensSymbolsPromise = resolvePromise; </ins> this._currentResolveCodeLensSymbolsPromise.then(() => { if (this._currentCodeLensModel) { // update the cached state with new resolved items this._codeLensCache.put(model, this._currentCodeLensModel); } this._oldCodeLensModels.clear(); // dispose old models once we have updated the UI with the current model <del> this._currentResolveCodeLensSymbolsPromise = undefined; </del> <ins> if (resolvePromise === this._currentResolveCodeLensSymbolsPromise) { this._currentResolveCodeLensSymbolsPromise = undefined; } </ins> }, err => { onUnexpectedError(err); // can also be cancellation! <del> this._currentResolveCodeLensSymbolsPromise = undefined; </del> <ins> if (resolvePromise === this._currentResolveCodeLensSymbolsPromise) { this._currentResolveCodeLensSymbolsPromise = undefined; } </ins> }); } }
Code change:
Please add an option to disable incremental naming. By disabling ... the end effect should be to effectively overwrite existing files when pasting. The current options of and are helpful; however, not useful in my context. For myself and those users who commonly do file operations in the host OS file explorer, the expected behavior when copying files/folders in the VSCode explorer is to similarly have these overwritten.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
We are open to a PR which adds the option to the setting. Code pointer
To verify set and copy and paste a file to ensure its name isn't changed and if a file of the same name exists in that directory it asks to overwrite the file

Related discussion:
text: } <del> export function findValidPasteFileTarget(explorerService: IExplorerService, targetFolder: ExplorerItem, fileToPaste: { resource: URI; isDirectory?: boolean; allowOverwrite: boolean }, incrementalNaming: 'simple' | 'smart'): URI { </del> <ins> export function findValidPasteFileTarget(explorerService: IExplorerService, targetFolder: ExplorerItem, fileToPaste: { resource: URI; isDirectory?: boolean; allowOverwrite: boolean }, incrementalNaming: 'simple' | 'smart' | 'disabled'): URI { </ins> let name = resources.basenameOrAuthority(fileToPaste.resource); let candidate = resources.joinPath(targetFolder.resource, name);
Code change:
Please add an option to disable incremental naming. By disabling ... the end effect should be to effectively overwrite existing files when pasting. The current options of and are helpful; however, not useful in my context. For myself and those users who commonly do file operations in the host OS file explorer, the expected behavior when copying files/folders in the VSCode explorer is to similarly have these overwritten.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
We are open to a PR which adds the option to the setting. Code pointer
To verify set and copy and paste a file to ensure its name isn't changed and if a file of the same name exists in that directory it asks to overwrite the file

Related discussion:
text: break; } <del> name = incrementFileName(name, !!fileToPaste.isDirectory, incrementalNaming); </del> <ins> if (incrementalNaming !== 'disabled') { name = incrementFileName(name, !!fileToPaste.isDirectory, incrementalNaming); } </ins> candidate = resources.joinPath(targetFolder.resource, name); }
Code change:
Please add an option to disable incremental naming. By disabling ... the end effect should be to effectively overwrite existing files when pasting. The current options of and are helpful; however, not useful in my context. For myself and those users who commonly do file operations in the host OS file explorer, the expected behavior when copying files/folders in the VSCode explorer is to similarly have these overwritten.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
We are open to a PR which adds the option to the setting. Code pointer
To verify set and copy and paste a file to ensure its name isn't changed and if a file of the same name exists in that directory it asks to overwrite the file

Related discussion:
text: const context = explorerService.getContext(true); const toPaste = resources.distinctParents(await clipboardService.readResources(), r => r); const element = context.length ? context[0] : explorerService.roots[0]; <ins> const incrementalNaming = configurationService.getValue<IFilesConfiguration>().explorer.incrementalNaming; </ins> try { // Check if target is ancestor of pasted folder
Code change:
Please add an option to disable incremental naming. By disabling ... the end effect should be to effectively overwrite existing files when pasting. The current options of and are helpful; however, not useful in my context. For myself and those users who commonly do file operations in the host OS file explorer, the expected behavior when copying files/folders in the VSCode explorer is to similarly have these overwritten.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
We are open to a PR which adds the option to the setting. Code pointer
To verify set and copy and paste a file to ensure its name isn't changed and if a file of the same name exists in that directory it asks to overwrite the file

Related discussion:
text: target = element.isDirectory ? element : element.parent!; } <del> const incrementalNaming = configurationService.getValue<IFilesConfiguration>().explorer.incrementalNaming; const targetFile = findValidPasteFileTarget(explorerService, target, { resource: fileToPaste, isDirectory: fileToPasteStat.isDirectory, allowOverwrite: pasteShouldMove }, incrementalNaming); </del> <ins> const targetFile = findValidPasteFileTarget(explorerService, target, { resource: fileToPaste, isDirectory: fileToPasteStat.isDirectory, allowOverwrite: pasteShouldMove || incrementalNaming === 'disabled' }, incrementalNaming); </ins> return { source: fileToPaste, target: targetFile }; }));
Code change:
Please add an option to disable incremental naming. By disabling ... the end effect should be to effectively overwrite existing files when pasting. The current options of and are helpful; however, not useful in my context. For myself and those users who commonly do file operations in the host OS file explorer, the expected behavior when copying files/folders in the VSCode explorer is to similarly have these overwritten.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
We are open to a PR which adds the option to the setting. Code pointer
To verify set and copy and paste a file to ensure its name isn't changed and if a file of the same name exists in that directory it asks to overwrite the file

Related discussion:
text: }; await explorerService.applyBulkEdit(resourceFileEdits, options); } else { <del> const resourceFileEdits = sourceTargetPairs.map(pair => new ResourceFileEdit(pair.source, pair.target, { copy: true })); </del> <ins> const resourceFileEdits = sourceTargetPairs.map(pair => new ResourceFileEdit(pair.source, pair.target, { copy: true, overwrite: incrementalNaming === 'disabled' })); </ins> const undoLevel = configurationService.getValue<IFilesConfiguration>().explorer.confirmUndo; const options = { confirmBeforeUndo: undoLevel === UndoConfirmLevel.Default || undoLevel === UndoConfirmLevel.Verbose,
Code change:
Please add an option to disable incremental naming. By disabling ... the end effect should be to effectively overwrite existing files when pasting. The current options of and are helpful; however, not useful in my context. For myself and those users who commonly do file operations in the host OS file explorer, the expected behavior when copying files/folders in the VSCode explorer is to similarly have these overwritten.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding
<!-- -a7ce-58b9-b1f9- --This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our . Happy Coding
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our . Happy Coding!
We are open to a PR which adds the option to the setting. Code pointer
To verify set and copy and paste a file to ensure its name isn't changed and if a file of the same name exists in that directory it asks to overwrite the file

Related discussion:
text: }, 'explorer.incrementalNaming': { 'type': 'string', <del> enum: ['simple', 'smart'], </del> <ins> enum: ['simple', 'smart', 'disabled'], </ins> enumDescriptions: [ nls.localize('simple', "Appends the word "copy" at the end of the duplicated name potentially followed by a number"), <del> nls.localize('smart', "Adds a number at the end of the duplicated name. If some number is already part of the name, tries to increase that number") </del> <ins> nls.localize('smart', "Adds a number at the end of the duplicated name. If some number is already part of the name, tries to increase that number"), nls.localize('disabled', "Disables incremental naming. If two files with the same name exist you will be prompted to overwrite the existing file") </ins> ], description: nls.localize('explorer.incrementalNaming', "Controls what naming strategy to use when a giving a new name to a duplicated explorer item on paste."), default: 'simple'