jiebi/CodeConvo huggingface dataset:
Code change:
Type: <bBug</bWhen first opening vscode or reloading the window several context keys are set to incorrect values. These values may eventually be corrected when focusing another editor and returning to the original one. The keys I have noticed with this issue are: It can be a little tricky to catch some of them misbehaving. It depends on which editors you have open and how they are arranged. ! Steps to repro: Open 2 editors Focus the first editor Pin it Record context keys Reload window Record context keys Diff the two sets of context keys and notice they are not the same VS Code version: Code - Insiders 1.86.0-insider (, 2023-12-18T05:36:59.983Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Ben, maybe you could check for the ones in editor area since you recently fixed some issues there. Maybe its a regression?
The following context keys were not being updated on reload: Updating them now on reload
This seems to apply to a few additional context keys outside of . Just a heads up in case closing the issue was accidental.

Related discussion:
text: }; // Update group contexts based on group changes <del> this._register(this.onDidModelChange(e => { </del> <ins> const updateGroupContextKeys = (e: IGroupModelChangeEvent) => { </ins> switch (e.kind) { case GroupModelChangeKind.GROUP_LOCKED: groupLockedContext.set(this.isLocked);
Code change:
Type: <bBug</bWhen first opening vscode or reloading the window several context keys are set to incorrect values. These values may eventually be corrected when focusing another editor and returning to the original one. The keys I have noticed with this issue are: It can be a little tricky to catch some of them misbehaving. It depends on which editors you have open and how they are arranged. ! Steps to repro: Open 2 editors Focus the first editor Pin it Record context keys Reload window Record context keys Diff the two sets of context keys and notice they are not the same VS Code version: Code - Insiders 1.86.0-insider (, 2023-12-18T05:36:59.983Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Ben, maybe you could check for the ones in editor area since you recently fixed some issues there. Maybe its a regression?
The following context keys were not being updated on reload: Updating them now on reload
This seems to apply to a few additional context keys outside of . Just a heads up in case closing the issue was accidental.

Related discussion:
text: // Group editors count context groupEditorsCountContext.set(this.count); <del> })); </del> <ins> }; this._register(this.onDidModelChange(e => updateGroupContextKeys(e))); </ins> // Track the active editor and update context key that reflects // the dirty state of this editor <del> this._register(this.onDidActiveEditorChange(() => { observeActiveEditor(); })); </del> <ins> this._register(this.onDidActiveEditorChange(() => observeActiveEditor())); </ins> // Update context keys on startup observeActiveEditor(); <ins> updateGroupContextKeys({ kind: GroupModelChangeKind.EDITOR_ACTIVE }); updateGroupContextKeys({ kind: GroupModelChangeKind.GROUP_LOCKED }); </ins> } private registerContainerListeners(): void {
Code change:
Testing The setting says " speech recognized" which reads a bit weird. Maybe leave "speech" away or says "Controls whether the editor listens for the 'Hey Code' phrase and what to do with it"
Bonus points for mentioning that this happens all locally
Yeah, I think I will go with this:

Related discussion:
text: localize('voice.keywordActivation.inlineChat', "Keyword activation is enabled and listening for 'Hey Code' to start a voice chat session in the active editor."), localize('voice.keywordActivation.chatInContext', "Keyword activation is enabled and listening for 'Hey Code' to start a voice chat session in the active editor or view depending on keyboard focus.") ], <del> 'description': localize('voice.keywordActivation', "Controls whether the phrase 'Hey Code' should be speech recognized to start a voice chat session."), </del> <ins> 'description': localize('voice.keywordActivation', "Controls whether the keyword phrase 'Hey Code' is recognized to start a voice chat session. Enabling this will start recording from the microphone but the audio is processed locally and never sent to a server."), </ins> 'default': 'off', 'tags': ['accessibility', 'FeatureInsight'] }
Code change:
]- Identify accessibility bugs before check-in and make bug fixing faster and easier. #A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Jan2024; #WCAG1.4.3; #Color Contrast; Visual Studio Code insider version 1.86.0 Microsoft Windows 11 Enterprise 22H2 Build .3007 Visual Studio Code Insiders editor ctrl+P or Tab till go and press ENTER then TAB till Go to File. that Color contrast ratio of the "search files by name" placeholder text is "2.283:1" which is less than 4.5:1. Color contrast ratio of the "search files by name" placeholder text is "2.283:1" which is less than 4.5:1. Similar issue is also observed throughout the application. Color contrast ratio of the "search files by name" placeholder text should be greater than or equals to 4.5:1. Low vision users will not be able to see the placeholder text if color contrast ratio will be less than 4.5:1. ! !
I can't reproduce this one. With the Dark Modern theme I see a background value for inputs of which passes the 3:1 ratio with the placeholder foreground of .
Misread that the ratio should be 4.5:1. This I can fix.
Verified the issue in below environment: Visual Studio Code Insider Version: 1.87.0-insider (user setup) Issue is fixed. Hence Closing the bug. please find attachment for reference. !

Related discussion:
text: "input.background": "#313131", "input.border": "#3C3C3C", "input.foreground": "#CCCCCC", <del> "input.placeholderForeground": "#818181", </del> <ins> "input.placeholderForeground": "#989898", </ins> "inputOption.activeBackground": "#2489DB82", "inputOption.activeBorder": "#2488DB", "keybindingLabel.foreground": "#CCCCCC",
Code change:
]- Identify accessibility bugs before check-in and make bug fixing faster and easier. #A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Jan2024; #WCAG1.4.3; #Color Contrast; Visual Studio Code insider version 1.86.0 Microsoft Windows 11 Enterprise 22H2 Build .3007 Visual Studio Code Insiders editor ctrl+P or Tab till go and press ENTER then TAB till Go to File. that Color contrast ratio of the "search files by name" placeholder text is "2.283:1" which is less than 4.5:1. Color contrast ratio of the "search files by name" placeholder text is "2.283:1" which is less than 4.5:1. Similar issue is also observed throughout the application. Color contrast ratio of the "search files by name" placeholder text should be greater than or equals to 4.5:1. Low vision users will not be able to see the placeholder text if color contrast ratio will be less than 4.5:1. ! !
I can't reproduce this one. With the Dark Modern theme I see a background value for inputs of which passes the 3:1 ratio with the placeholder foreground of .
Misread that the ratio should be 4.5:1. This I can fix.
Verified the issue in below environment: Visual Studio Code Insider Version: 1.87.0-insider (user setup) Issue is fixed. Hence Closing the bug. please find attachment for reference. !

Related discussion:
text: "input.background": "#FFFFFF", "input.border": "#CECECE", "input.foreground": "#3B3B3B", <del> "input.placeholderForeground": "#868686", </del> <ins> "input.placeholderForeground": "#767676", </ins> "inputOption.activeBackground": "#BED6ED", "inputOption.activeBorder": "#005FB8", "inputOption.activeForeground": "#000000",
Code change:
<img width="431" alt="image" src=""The debug view uses monospace font by default other than the workbench font

Related discussion:
text: protected override renderBody(container: HTMLElement): void { super.renderBody(container); <ins> this.element.classList.add('debug-pane'); </ins> this.tree = <WorkbenchAsyncDataTree<INotebookScope, INotebookVariableElement>>this.instantiationService.createInstance( WorkbenchAsyncDataTree,
Code change:
Enable Write a long commit message that triggers validation Hover over the diagnostic squiggle <img width="405" alt="image" src=""

Related discussion:
text: private renderMarkerStatusbar(context: IEditorHoverRenderContext, markerHover: MarkerHover, disposables: DisposableStore): void { if (markerHover.marker.severity === MarkerSeverity.Error || markerHover.marker.severity === MarkerSeverity.Warning || markerHover.marker.severity === MarkerSeverity.Info) { <del> context.statusBar.addAction({ label: nls.localize('view problem', "View Problem"), commandId: NextMarkerAction.ID, run: () => { context.hide(); MarkerController.get(this._editor)?.showAtMarker(markerHover.marker); this._editor.focus(); } }); </del> <ins> const markerController = MarkerController.get(this._editor); if (markerController) { context.statusBar.addAction({ label: nls.localize('view problem', "View Problem"), commandId: NextMarkerAction.ID, run: () => { context.hide(); markerController.showAtMarker(markerHover.marker); this._editor.focus(); } }); } </ins> } if (!this._editor.getOption(EditorOption.readOnly)) {
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.1 OS Version: Ubuntu 23.04 Steps to Reproduce: an empty text editor the text opening and closing an empty text editor several times that the number of disposables increases each time Opening and closing an editor 1997 times results in 3994 disposables with this stack trace: When opening an editor, the function is called , the function calls adds a disposable to the disposable store When closing and opening the editor again, the same happens: the function is called , the function calls adds a disposable to the disposable store again This probably causes more and more disposables to be in . It seems, disposing the codeEditorContributions disposable () when a text editor model becomes detached might be a possible solution. That way, it would be registered when a model is attached and disposed when a model becomes detached:
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Thanks a lot!

Related discussion:
text: import { getWindow, runWhenWindowIdle } from 'vs/base/browser/dom'; import { onUnexpectedError } from 'vs/base/common/errors'; <del> import { Disposable, DisposableMap } from 'vs/base/common/lifecycle'; </del> <ins> import { Disposable, DisposableMap, IDisposable } from 'vs/base/common/lifecycle'; </ins> import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { EditorContributionInstantiation, IEditorContributionDescription } from 'vs/editor/browser/editorExtensions'; import { IEditorContribution } from 'vs/editor/common/editorCommon';
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.1 OS Version: Ubuntu 23.04 Steps to Reproduce: an empty text editor the text opening and closing an empty text editor several times that the number of disposables increases each time Opening and closing an editor 1997 times results in 3994 disposables with this stack trace: When opening an editor, the function is called , the function calls adds a disposable to the disposable store When closing and opening the editor again, the same happens: the function is called , the function calls adds a disposable to the disposable store again This probably causes more and more disposables to be in . It seems, disposing the codeEditorContributions disposable () when a text editor model becomes detached might be a possible solution. That way, it would be registered when a model is attached and disposed when a model becomes detached:
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Thanks a lot!

Related discussion:
text: this._instantiateSome(EditorContributionInstantiation.BeforeFirstInteraction); } <del> public onAfterModelAttached(): void { this._register(runWhenWindowIdle(getWindow(this._editor?.getDomNode()), () => { </del> <ins> public onAfterModelAttached(): IDisposable { return runWhenWindowIdle(getWindow(this._editor?.getDomNode()), () => { </ins> this._instantiateSome(EditorContributionInstantiation.AfterFirstRender); <del> }, 50)); </del> <ins> }, 50); </ins> } private _instantiateSome(instantiation: EditorContributionInstantiation): void {
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.1 OS Version: Ubuntu 23.04 Steps to Reproduce: an empty text editor the text opening and closing an empty text editor several times that the number of disposables increases each time Opening and closing an editor 1997 times results in 3994 disposables with this stack trace: When opening an editor, the function is called , the function calls adds a disposable to the disposable store When closing and opening the editor again, the same happens: the function is called , the function calls adds a disposable to the disposable store again This probably causes more and more disposables to be in . It seems, disposing the codeEditorContributions disposable () when a text editor model becomes detached might be a possible solution. That way, it would be registered when a model is attached and disposed when a model becomes detached:
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Thanks a lot!

Related discussion:
text: private readonly _overflowWidgetsDomNode: HTMLElement | undefined; private readonly _id: number; private readonly _configuration: IEditorConfiguration; <ins> private _contributionsDisposable: IDisposable | undefined; </ins> protected readonly _actions = new Map<string, editorCommon.IEditorAction>();
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.1 OS Version: Ubuntu 23.04 Steps to Reproduce: an empty text editor the text opening and closing an empty text editor several times that the number of disposables increases each time Opening and closing an editor 1997 times results in 3994 disposables with this stack trace: When opening an editor, the function is called , the function calls adds a disposable to the disposable store When closing and opening the editor again, the same happens: the function is called , the function calls adds a disposable to the disposable store again This probably causes more and more disposables to be in . It seems, disposing the codeEditorContributions disposable () when a text editor model becomes detached might be a possible solution. That way, it would be registered when a model is attached and disposed when a model becomes detached:
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Thanks a lot!

Related discussion:
text: this._onDidChangeModel.fire(e); this._postDetachModelCleanup(detachedModel); <del> this._contributions.onAfterModelAttached(); </del> <ins> this._contributionsDisposable = this._contributions.onAfterModelAttached(); </ins> } private _removeDecorationTypes(): void {
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.1 OS Version: Ubuntu 23.04 Steps to Reproduce: an empty text editor the text opening and closing an empty text editor several times that the number of disposables increases each time Opening and closing an editor 1997 times results in 3994 disposables with this stack trace: When opening an editor, the function is called , the function calls adds a disposable to the disposable store When closing and opening the editor again, the same happens: the function is called , the function calls adds a disposable to the disposable store again This probably causes more and more disposables to be in . It seems, disposing the codeEditorContributions disposable () when a text editor model becomes detached might be a possible solution. That way, it would be registered when a model is attached and disposed when a model becomes detached:
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Thanks a lot!

Related discussion:
text: } private _detachModel(): ITextModel | null { <ins> this._contributionsDisposable?.dispose(); this._contributionsDisposable = undefined; </ins> if (!this._modelData) { return null; }
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.1 OS Version: Ubuntu 23.04 Steps to Reproduce: an empty text editor the text opening and closing an empty text editor several times that the number of disposables increases each time Opening and closing an editor 1997 times results in 3994 disposables with this stack trace: When opening an editor, the function is called , the function calls adds a disposable to the disposable store When closing and opening the editor again, the same happens: the function is called , the function calls adds a disposable to the disposable store again This probably causes more and more disposables to be in . It seems, disposing the codeEditorContributions disposable () when a text editor model becomes detached might be a possible solution. That way, it would be registered when a model is attached and disposed when a model becomes detached:
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Thanks a lot!

Related discussion:
text: if (this._bannerDomNode && this._domElement.contains(this._bannerDomNode)) { this._domElement.removeChild(this._bannerDomNode); } return model; }