jiebi/CodeConvo huggingface dataset:
Code change:
Testing If there are no changes, we should not be able to create a new edit session. In this particular case, I would expect that an information message is being shown, and that the existing edit session is not being overwritten.

Related discussion:
text: } } catch { } <ins> hasEdits = true; </ins> if (await this.fileService.exists(uri)) { workingChanges.push({ type: ChangeType.Addition, fileType: FileType.File, contents: (await this.fileService.readFile(uri)).value.toString(), relativeFilePath: relativeFilePath }); } else {
Code change:
Testing If there are no changes, we should not be able to create a new edit session. In this particular case, I would expect that an information message is being shown, and that the existing edit session is not being overwritten.

Related discussion:
text: folders.push({ workingChanges, name: name ?? '' }); } <ins> if (!hasEdits) { this.logService.info('Edit Sessions: Skipping storing edit session as there are no edits to store.'); if (fromStoreCommand) { this.notificationService.info(localize('no edits to store', 'Skipped storing edit session as there are no edits to store.')); } return undefined; } </ins> const data: EditSession = { folders, version: 1 }; try {
Code change:
Testing If there are no changes, we should not be able to create a new edit session. In this particular case, I would expect that an information message is being shown, and that the existing edit session is not being overwritten.

Related discussion:
text: let instantiationService: TestInstantiationService; let sessionSyncContribution: SessionSyncContribution; let fileService: FileService; <ins> let sandbox: sinon.SinonSandbox; </ins> const disposables = new DisposableStore(); <del> setup(() => { </del> <ins> suiteSetup(() => { sandbox = sinon.createSandbox(); </ins> instantiationService = new TestInstantiationService(); // Set up filesystem
Code change:
Testing If there are no changes, we should not be able to create a new edit session. In this particular case, I would expect that an information message is being shown, and that the existing edit session is not being overwritten.

Related discussion:
text: } }); <ins> // Stub repositories instantiationService.stub(ISCMService, '_repositories', new Map()); </ins> sessionSyncContribution = instantiationService.createInstance(SessionSyncContribution); });
Code change:
Testing If there are no changes, we should not be able to create a new edit session. In this particular case, I would expect that an information message is being shown, and that the existing edit session is not being overwritten.

Related discussion:
text: }; // Stub sync service to return edit session data <del> const sandbox = sinon.createSandbox(); </del> const readStub = sandbox.stub().returns({ editSession, ref: '0' }); instantiationService.stub(ISessionSyncWorkbenchService, 'read', readStub); <del> // Stub repositories instantiationService.stub(ISCMService, '_repositories', new Map()); </del> // Create root folder await fileService.createFolder(folderUri);
Code change:
Testing If there are no changes, we should not be able to create a new edit session. In this particular case, I would expect that an information message is being shown, and that the existing edit session is not being overwritten.

Related discussion:
text: // Verify edit session was correctly applied assert.equal((await fileService.readFile(fileUri)).value.toString(), fileContents); }); <ins> test('Edit session not stored if there are no edits', async function () { const writeStub = sandbox.stub(); instantiationService.stub(ISessionSyncWorkbenchService, 'write', writeStub); // Create root folder await fileService.createFolder(folderUri); await sessionSyncContribution.storeEditSession(true); // Verify that we did not attempt to write the edit session assert.equal(writeStub.called, false); }); </ins> });
Code change:
Testing Have one profile with GitLens installed and other without. Notice how walkthrough shows up in Welcome page on profile without GitLens <img width="1653" alt="image" src="https://user-"
It seems welcome page is not updating when extensions are removed. This has to be fixed in walk throughs / welcome page component. Not sure who owns this now. Can you please assign it to the corresponding owner?
It appears we are handling it correctly here
I see is being invoked for gitlens extension when switching profiles, but I do not know why the walk through page is still showing it. I do not know the implementation of it. Can you please investigate from walk through component perspective first to see why it is still being shown?
I disabled gitlens and used the button to reload the window. The walkthrough is no longer there. is that expected?
!
I changed profiles to the one with Gitlens still enabled and there's still no walkthrough
Hmmm I cannot repro this. Can you provide a gif? If I have the walkthrough open and reload my window the walkthrough page doesn't dissapear
https://user-

Related discussion:
text: } extension.contributes?.walkthroughs?.forEach(section => { <del> const categoryID = extension.identifier.value + '#walkthrough#' + section.id; </del> <ins> const categoryID = extension.identifier.value + '#' + section.id; </ins> section.steps.forEach(step => { const fullyQualifiedID = extension.identifier.value + '#' + section.id + '#' + step.id; this.steps.delete(fullyQualifiedID);
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: =1.66.0 OS Version: iOS 14.3 Steps to Reproduce: Safari on iOS 14.3 to any vscode server (e.g. , or ) The Safari developer tools console shows the following error:
. I see references to in the following commits: (soft reference) Thoughts?
As this has been supported since iOS 15, do we want to change this?
The changes introduced in completely break vs code for all devices below iOS/iPadOS 15, the other occurrences of don't seem to have any negative impact according to my testing (anything below 1.66.0 works). The fix I proposed in is a more elegant solution that supports all browsers and does not break anything.
We are generally only aiming for latest and greatest browser version. The use of seems small enough to justify a special case but we shouldn't target a lower version nor is there any guarantee that other things won't break, e.g "fixing" this might just reveal another bunch of blocker etc pp.
Sounds good, forwarding to to evaluate the PR.

Related discussion:
text: * @returns whether the provided parameter is of type `Buffer` or Uint8Array dervived type */ export function isTypedArray(obj: unknown): obj is Object { <ins> const TypedArray = Object.getPrototypeOf(Uint8Array); </ins> return typeof obj === 'object' <del> && (obj instanceof Uint8Array || obj instanceof Uint16Array || obj instanceof Uint32Array || obj instanceof Float32Array || obj instanceof Float64Array || obj instanceof Int8Array || obj instanceof Int16Array || obj instanceof Int32Array || obj instanceof BigInt64Array || obj instanceof BigUint64Array || obj instanceof Uint8ClampedArray); </del> <ins> && obj instanceof TypedArray; </ins> } /**
Code change:
<img width="368" alt="CleanShot 2022-07-18 at 08 28 16 src="https://user-""Configure" and "Manage" are really similar to each other and I had a hard time knowing which one opened what, which caused me to open the wrong one. "Configure" opens the settings UI with a query, and "Manage" opens a custom editor. My proposal would be to change "Configure Workspace Trust" to "Workspace Trust Settings" to make it explicit.
I'd actually like to tweak your proposal to "Manage Trusted Workspaces" and "Configure Workspace Trust Settings"

Related discussion:
text: * Actions */ <del> // Configure Workspace Trust </del> <ins> // Configure Workspace Trust Settings </ins> const CONFIGURE_TRUST_COMMAND_ID = 'workbench.trust.configure'; const WORKSPACES_CATEGORY = { value: localize('workspacesCategory', "Workspaces"), original: 'Workspaces' };
Code change:
<img width="368" alt="CleanShot 2022-07-18 at 08 28 16 src="https://user-""Configure" and "Manage" are really similar to each other and I had a hard time knowing which one opened what, which caused me to open the wrong one. "Configure" opens the settings UI with a query, and "Manage" opens a custom editor. My proposal would be to change "Configure Workspace Trust" to "Workspace Trust Settings" to make it explicit.
I'd actually like to tweak your proposal to "Manage Trusted Workspaces" and "Configure Workspace Trust Settings"

Related discussion:
text: constructor() { super({ id: CONFIGURE_TRUST_COMMAND_ID, <del> title: { original: 'Configure Workspace Trust', value: localize('configureWorkspaceTrust', "Configure Workspace Trust") }, </del> <ins> title: { original: 'Configure Workspace Trust Settings', value: localize('configureWorkspaceTrustSettings', "Configure Workspace Trust Settings") }, </ins> precondition: ContextKeyExpr.and(WorkspaceTrustContext.IsEnabled, ContextKeyExpr.equals(`config.${WORKSPACE_TRUST_ENABLED}`, true)), category: WORKSPACES_CATEGORY, f1: true
Code change:
Repro: Using Open a Remote - WSL folder !
This would probably not be limited to the title, what about the hover over the tab?
The separators seem to be flipped: !
I wonder if could have regressed this, is this a recent regression?
I cannot reproduce, so this is some setting you have or some configuration most likely.
It might be remnants of the formatted caching bug?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

Related discussion:
text: this.os = OS; this.userHome = pathService.defaultUriScheme === Schemas.file ? this.pathService.userHome({ preferLocal: true }) : undefined; <del> const memento = this.storedFormattersMemento = new Memento('cachedResourceLabelFormatters', storageService); </del> <ins> const memento = this.storedFormattersMemento = new Memento('cachedResourceLabelFormatters2', storageService); </ins> this.storedFormatters = memento.getMemento(StorageScope.PROFILE, StorageTarget.MACHINE); <del> this.formatters = this.storedFormatters?.formatters || []; </del> <ins> this.formatters = this.storedFormatters?.formatters?.slice() || []; </ins> // Remote environment is potentially long running this.resolveRemoteEnvironment();
Code change:
Repro: Using Open a Remote - WSL folder !
This would probably not be limited to the title, what about the hover over the tab?
The separators seem to be flipped: !
I wonder if could have regressed this, is this a recent regression?
I cannot reproduce, so this is some setting you have or some configuration most likely.
It might be remnants of the formatted caching bug?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

Related discussion:
text: test('label caching', () => { <del> const m = new Memento('cachedResourceLabelFormatters', storageService).getMemento(StorageScope.PROFILE, StorageTarget.MACHINE); </del> <ins> const m = new Memento('cachedResourceLabelFormatters2', storageService).getMemento(StorageScope.PROFILE, StorageTarget.MACHINE); </ins> const makeFormatter = (scheme: string): ResourceLabelFormatter => ({ formatting: { label: `${path} (${scheme})`, separator: '/' }, scheme }); assert.deepStrictEqual(m, {});
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Steps to Reproduce: The documentation has a spelling mistake LINK: -Value of an environment variable on the host machine (in this case, called VARIABLENAME). Unset variables are left blank. To for example, this would set a variable to your local home folder on Linux / macOS or the user folder on Windows:
/ , can you please point me to the GitHub page that corresponds to this page.
Thanks for pointing this out. It looks like we fixed the typo () but have not yet deployed the latest changes.
You are welcome, ! I was trying to fix the issue for Hacktoberfest 2022, but I was unable to figure out in which repo this file was located. Just out of curiosity I would like to know as to where the source file for the page with the typo reside in GitHub?
Thanks for looping me in! Opened a PR in is the repo for

Related discussion:
text: }, { "name": "border-image-width", <del> "desc": "The four values of 'border-image-width' specify offsets that are used to divide the border image area into nine parts. They represent inward distances from the the top, right, bottom, and left sides of the area, respectively.", </del> <ins> "desc": "The four values of 'border-image-width' specify offsets that are used to divide the border image area into nine parts. They represent inward distances from the top, right, bottom, and left sides of the area, respectively.", </ins> "browsers": "FF13,IE11", "restriction": "length, percentage, number", "values": []
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Steps to Reproduce: The documentation has a spelling mistake LINK: -Value of an environment variable on the host machine (in this case, called VARIABLENAME). Unset variables are left blank. To for example, this would set a variable to your local home folder on Linux / macOS or the user folder on Windows:
/ , can you please point me to the GitHub page that corresponds to this page.
Thanks for pointing this out. It looks like we fixed the typo () but have not yet deployed the latest changes.
You are welcome, ! I was trying to fix the issue for Hacktoberfest 2022, but I was unable to figure out in which repo this file was located. Just out of curiosity I would like to know as to where the source file for the page with the typo reside in GitHub?
Thanks for looping me in! Opened a PR in is the repo for

Related discussion:
text: }, { "name": "counter-increment", <del> "desc": "Counters are used with the 'counter()' and 'counters()' functions of the the 'content' property.", </del> <ins> "desc": "Counters are used with the 'counter()' and 'counters()' functions of the 'content' property.", </ins> "browsers": "C,FF1.5,IE8,O10.5,S3", "restriction": "identifier, integer", "values": []
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Steps to Reproduce: The documentation has a spelling mistake LINK: -Value of an environment variable on the host machine (in this case, called VARIABLENAME). Unset variables are left blank. To for example, this would set a variable to your local home folder on Linux / macOS or the user folder on Windows:
/ , can you please point me to the GitHub page that corresponds to this page.
Thanks for pointing this out. It looks like we fixed the typo () but have not yet deployed the latest changes.
You are welcome, ! I was trying to fix the issue for Hacktoberfest 2022, but I was unable to figure out in which repo this file was located. Just out of curiosity I would like to know as to where the source file for the page with the typo reside in GitHub?
Thanks for looping me in! Opened a PR in is the repo for

Related discussion:
text: "values": [ { "name": "center", <del> "desc": "Places the center of the Grid Item's margin box at the center of the the Grid Item's column." </del> <ins> "desc": "Places the center of the Grid Item's margin box at the center of the Grid Item's column." </ins> }, { "name": "end",
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Steps to Reproduce: The documentation has a spelling mistake LINK: -Value of an environment variable on the host machine (in this case, called VARIABLENAME). Unset variables are left blank. To for example, this would set a variable to your local home folder on Linux / macOS or the user folder on Windows:
/ , can you please point me to the GitHub page that corresponds to this page.
Thanks for pointing this out. It looks like we fixed the typo () but have not yet deployed the latest changes.
You are welcome, ! I was trying to fix the issue for Hacktoberfest 2022, but I was unable to figure out in which repo this file was located. Just out of curiosity I would like to know as to where the source file for the page with the typo reside in GitHub?
Thanks for looping me in! Opened a PR in is the repo for

Related discussion:
text: "values": [ { "name": "center", <del> "desc": "Places the center of the Grid Item's margin box at the center of the the Grid Item's row." </del> <ins> "desc": "Places the center of the Grid Item's margin box at the center of the Grid Item's row." </ins> }, { "name": "end",
Code change:
The focus on a search result shouldn't change when removing an element that isn't affected by the removal. ]() Should be like this: ! Likely due to changes in

Related discussion:
text: async performReplace(element: FolderMatch | FileMatch | Match): Promise<any> { // since multiple elements can be selected, we need to check the type of the FolderMatch/FileMatch/Match before we perform the replace. <del> const elementsToReplace = getElementsToOperateOnInfo(this.viewer, element, this.configurationService.getValue<ISearchConfigurationProperties>('search')); </del> <ins> const opInfo = getElementsToOperateOnInfo(this.viewer, element, this.configurationService.getValue<ISearchConfigurationProperties>('search')); const elementsToReplace = opInfo.elements; </ins> await Promise.all(elementsToReplace.map(async (elem) => { const parent = elem.parent();
Code change:
The focus on a search result shouldn't change when removing an element that isn't affected by the removal. ]() Should be like this: ! Likely due to changes in

Related discussion:
text: } override run(): Promise<any> { <del> const elementsToRemove = getElementsToOperateOnInfo(this.viewer, this.element, this.configurationService.getValue<ISearchConfigurationProperties>('search')); </del> <ins> const opInfo = getElementsToOperateOnInfo(this.viewer, this.element, this.configurationService.getValue<ISearchConfigurationProperties>('search')); const elementsToRemove = opInfo.elements; </ins> const currentBottomFocusElement = elementsToRemove[elementsToRemove.length - 1]; <del> const nextFocusElement = !currentBottomFocusElement || currentBottomFocusElement instanceof SearchResult || arrayContainsElementOrParent(currentBottomFocusElement, elementsToRemove) ? </del> <ins> const nextFocusElement = opInfo.mustReselect && (!currentBottomFocusElement || currentBottomFocusElement instanceof SearchResult || arrayContainsElementOrParent(currentBottomFocusElement, elementsToRemove)) ? </ins> this.getElementToFocusAfterRemoved(this.viewer, <any>currentBottomFocusElement) : null;
Code change:
The focus on a search result shouldn't change when removing an element that isn't affected by the removal. ]() Should be like this: ! Likely due to changes in

Related discussion:
text: }); }; <del> function getElementsToOperateOnInfo(viewer: WorkbenchObjectTree<RenderableMatch, void>, currElement: RenderableMatch, sortConfig: ISearchConfigurationProperties): RenderableMatch[] { </del> <ins> function getElementsToOperateOnInfo(viewer: WorkbenchObjectTree<RenderableMatch, void>, currElement: RenderableMatch, sortConfig: ISearchConfigurationProperties): { elements: RenderableMatch[]; mustReselect: boolean } { </ins> let elements: RenderableMatch[] = viewer.getSelection().filter((x): x is RenderableMatch => x !== null).sort((a, b) => searchComparer(a, b, sortConfig.sortOrder)); <ins> const mustReselect = elements.includes(currElement); // this indicates whether we need to re-focus/re-select on a remove. </ins> // if selection doesn't include multiple elements, just return current focus element. if (!(elements.length > 1 && elements.includes(currElement))) { elements = [currElement]; } <del> return elements; </del> <ins> return { elements, mustReselect }; </ins> }
Code change:
Remove Manual Folding Range doesn't work Originally posted by in select a range in the editor invoke . Selection turns into a folding range put the cursor at the beginning of the collapsed line invoke . Should remove the manual folding range
It works when the cursor is at the second column or to the right of that, but not when it's right at the beginning of the line, which is exactly where it is placed after running the create manual folding range command.

Related discussion:
text: public removeManualRanges(ranges: ILineRange[]) { const newFoldingRanges: FoldRange[] = new Array(); <del> const containedBy = (foldRange: FoldRange) => { </del> <ins> const intersects = (foldRange: FoldRange) => { </ins> for (const range of ranges) { <del> if (range.startLineNumber <= foldRange.startLineNumber && range.endLineNumber >= foldRange.endLineNumber) { </del> <ins> if (!(range.startLineNumber > foldRange.endLineNumber || foldRange.startLineNumber > range.endLineNumber)) { </ins> return true; } }