jiebi/CodeConvo huggingface dataset:
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.55 OS Version: MacOS Big Sur The unit testing readme instructions for running unit tests from node is missing the --ui tdd flag and doesn't work without it. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.453 --<!-- potentialduplicatescomment --
This is about
Yeah see pull request sorry. I just lumped it into something else.

Related discussion:
text: `function helloWorld() { return someGlobalObject.printHelloWorld("en", "utf-8"); } <del> helloWorld();`.replace(/^s+/gm, '') </del> <ins> helloWorld();`.replace(/^s+/gm, ''), `'JavaScript'`, 'parseHTML4String', '_accessor: ServicesAccessor' </ins> ], {}, (editor) => { let model = editor.getModel()!; let uppercaseAction = new UpperCaseAction();
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.55 OS Version: MacOS Big Sur The unit testing readme instructions for running unit tests from node is missing the --ui tdd flag and doesn't work without it. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.453 --<!-- potentialduplicatescomment --
This is about
Yeah see pull request sorry. I just lumped it into something else.

Related discussion:
text: } hello_world();`.replace(/^s+/gm, '')); assertSelection(editor, new Selection(14, 1, 17, 15)); <ins> editor.setSelection(new Selection(18, 1, 18, 13)); executeAction(snakecaseAction, editor); assert.strictEqual(model.getLineContent(18), `'java_script'`); assertSelection(editor, new Selection(18, 1, 18, 14)); editor.setSelection(new Selection(19, 1, 19, 17)); executeAction(snakecaseAction, editor); assert.strictEqual(model.getLineContent(19), 'parse_html4_string'); assertSelection(editor, new Selection(19, 1, 19, 19)); editor.setSelection(new Selection(20, 1, 20, 28)); executeAction(snakecaseAction, editor); assert.strictEqual(model.getLineContent(20), '_accessor: services_accessor'); assertSelection(editor, new Selection(20, 1, 20, 29)); </ins> } );
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.55 OS Version: MacOS Big Sur The unit testing readme instructions for running unit tests from node is missing the --ui tdd flag and doesn't work without it. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.453 --<!-- potentialduplicatescomment --
This is about
Yeah see pull request sorry. I just lumped it into something else.

Related discussion:
text: - use the `--debug` to see an electron window with dev tools which allows for debugging - to run only a subset of tests use the `--run` or `--glob` options <ins> - use `yarn watch` to automatically compile changes </ins> For instance, `./scripts/test.sh --debug --glob **/extHost*.test.js` runs all tests from `extHost`-files and enables you to debug them.
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.55 OS Version: MacOS Big Sur The unit testing readme instructions for running unit tests from node is missing the --ui tdd flag and doesn't work without it. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.453 --<!-- potentialduplicatescomment --
This is about
Yeah see pull request sorry. I just lumped it into something else.

Related discussion:
text: ## Run (with node) <del> yarn run mocha --run src/vs/editor/test/browser/controller/cursor.test.ts </del> <ins> yarn run mocha --ui tdd --run src/vs/editor/test/browser/controller/cursor.test.ts </ins> ## Coverage
Code change:
The call was removed in
It's weird, seems like in stable we should be leaking terminal processes then but I see them shut down immediately after closing the window in stable...

Related discussion:
text: return this._remoteTerminalChannel.setTerminalLayoutInfo(layout); } <del> public getTerminalLayoutInfo(): Promise<ITerminalsLayoutInfo | undefined> { </del> <ins> public async getTerminalLayoutInfo(): Promise<ITerminalsLayoutInfo | undefined> { await this._remoteTerminalChannel?.listProcesses(true); </ins> if (!this._remoteTerminalChannel) { throw new Error(`Cannot call getActiveInstanceId when there is no remote`); }
Code change:
On Windows: a local empty folder an empty a with the following contents: the Markdown preview the link File opens with a strange input, as if its entire path is the file name. Also, if you open from the Explorer, it now appears twice in Quick Open: once normally and another in the weird long format. !
windows? local/wsl? Doesn't repro on macOS so I suspect an issue with how URIs are being created from the markdown.
This is local Windows, updated the steps.
There is some weird encoding going on with that URL, here is what it should look like: And here is what I get:
I'm working on this issue. I've logged out how the Markdown Preview renders the paths to HTML with "Click Here Absolute Path" containing the same link as in the issue: Markdown: HTML Output: The paths are correct though. Plus I think the link should be given as a relative path (ie. ) instead of an absolute path. Giving the absolute path here () is not correct. Btw, I've tried on other IDEs for comparison, they all don't open the absolute path link properly (or open nothing at all). The relative path link always works. Not sure how would you want to tackle this now?
I have a hunch that maybe the issue is somewhat related to
Thanks, for the pointer. I misunderstood the issue at first...

Related discussion:
text: private async onDidClickPreviewLink(href: string) { let [hrefPath, fragment] = decodeURIComponent(href).split('#'); <del> // We perviously already resolve absolute paths. // Now make sure we handle relative file paths </del> if (hrefPath[0] !== '/') { <del> // Fix #93691, use this.resource.fsPath instead of this.resource.path hrefPath = path.join(path.dirname(this.resource.fsPath), hrefPath); </del> <ins> // We perviously already resolve absolute paths. // Now make sure we handle relative file paths const dirnameUri = vscode.Uri.parse(path.dirname(this.resource.path)); hrefPath = vscode.Uri.joinPath(dirnameUri, hrefPath).path; </ins> } else { // Handle any normalized file paths <del> hrefPath = vscode.Uri.parse(hrefPath.replace('/file', '')).fsPath; </del> <ins> hrefPath = vscode.Uri.parse(hrefPath.replace('/file', '')).path; </ins> } const config = vscode.workspace.getConfiguration('markdown', this.resource);
Code change:
skipped in
Seems to only flake on Windows
Couldn't reproduce locally
Let's try re-enable in debt week

Related discussion:
text: }); }); <del> // https://github.com/microsoft/vscode/issues/119826 suite.skip('environmentVariableCollection', () => { </del> <ins> suite('environmentVariableCollection', () => { </ins> test('should have collection variables apply to terminals immediately after setting', (done) => { // Text to match on before passing the test const expectedText = [
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: main branch, commit (28 march) OS Version: Linux Component: notebook When a user adds a new cell in a notebook, this created cell is automatically selected. This selection happens in the class (): However, when the user undoes and redoes this action, this new cell is not selected any more. This may be considered as an issue since undo/redo must be an identify function. I think that this issue takes sources in the method () where the current selection operation to do after the cell creation is . If I replace this arrow function by: and I removed the block of it works as expected (build, tests, integration tests OK). Steps to Reproduce: To reproduce the issue automatically, adds this test in (executed by ): I will open a PR to detail the proposal. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (in development mode). <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
I created a cell, and then undo/redo a bunch on that cell and the selection isn't always the recreated cell
any chance you can do a screen recording of the reproduce?
Can't repro this anymore. Marking as verified. Don't know what happened before. Although there is some screen cheese on many undo redos it's very brief.

Related discussion:
text: assert.strictEqual(count, 0); }); <ins> test('correct cell selection on undo/redo of cell creation', async function () { const resource = await createRandomFile('', undefined, '.vsctestnb'); await vscode.commands.executeCommand('vscode.openWith', resource, 'notebookCoreTest'); await vscode.commands.executeCommand('notebook.cell.insertCodeCellBelow'); await vscode.commands.executeCommand('undo'); const selectionUndo = [...vscode.window.activeNotebookEditor!.selections]; await vscode.commands.executeCommand('redo'); const selectionRedo = vscode.window.activeNotebookEditor!.selections; // On undo, the selected cell must be the upper cell, ie the first one assert.strictEqual(selectionUndo.length, 1); assert.strictEqual(selectionUndo[0].start, 0); assert.strictEqual(selectionUndo[0].end, 1); // On redo, the selected cell must be the new cell, ie the second one assert.strictEqual(selectionRedo.length, 1); assert.strictEqual(selectionRedo[0].start, 1); assert.strictEqual(selectionRedo[0].end, 2); }); </ins> test('editor editing event 2', async function () { const resource = await createRandomFile('', undefined, '.vsctestnb'); await vscode.commands.executeCommand('vscode.openWith', resource, 'notebookCoreTest');
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: main branch, commit (28 march) OS Version: Linux Component: notebook When a user adds a new cell in a notebook, this created cell is automatically selected. This selection happens in the class (): However, when the user undoes and redoes this action, this new cell is not selected any more. This may be considered as an issue since undo/redo must be an identify function. I think that this issue takes sources in the method () where the current selection operation to do after the cell creation is . If I replace this arrow function by: and I removed the block of it works as expected (build, tests, integration tests OK). Steps to Reproduce: To reproduce the issue automatically, adds this test in (executed by ): I will open a PR to detail the proposal. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (in development mode). <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
I created a cell, and then undo/redo a bunch on that cell and the selection isn't always the recreated cell
any chance you can do a screen recording of the reproduce?
Can't repro this anymore. Marking as verified. Don't know what happened before. Although there is some screen cheese on many undo redos it's very brief.

Related discussion:
text: } async runWithContext(accessor: ServicesAccessor, context: INotebookActionContext): Promise<void> { <del> const newCell = context.notebookEditor.insertNotebookCell(context.cell, this.kind, this.direction, undefined, true); if (newCell) { context.notebookEditor.focusNotebookCell(newCell, 'editor'); } </del> <ins> context.notebookEditor.insertNotebookCell(context.cell, this.kind, this.direction, undefined, true); </ins> } }
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: main branch, commit (28 march) OS Version: Linux Component: notebook When a user adds a new cell in a notebook, this created cell is automatically selected. This selection happens in the class (): However, when the user undoes and redoes this action, this new cell is not selected any more. This may be considered as an issue since undo/redo must be an identify function. I think that this issue takes sources in the method () where the current selection operation to do after the cell creation is . If I replace this arrow function by: and I removed the block of it works as expected (build, tests, integration tests OK). Steps to Reproduce: To reproduce the issue automatically, adds this test in (executed by ): I will open a PR to detail the proposal. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (in development mode). <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
I created a cell, and then undo/redo a bunch on that cell and the selection isn't always the recreated cell
any chance you can do a screen recording of the reproduce?
Can't repro this anymore. Marking as verified. Don't know what happened before. Although there is some screen cheese on many undo redos it's very brief.

Related discussion:
text: createCell(index: number, source: string, language: string, type: CellKind, metadata: NotebookCellMetadata | undefined, outputs: IOutputDto[], synchronous: boolean, pushUndoStop: boolean = true, previouslyPrimary: number | null = null, previouslyFocused: ICellViewModel[] = []): CellViewModel { const beforeSelections = previouslyFocused.map(e => e.handle); <ins> const endSelections: ISelectionState = { kind: SelectionStateType.Index, focus: { start: index, end: index + 1 }, selections: [{ start: index, end: index + 1 }] }; </ins> this._notebook.applyEdits([ { editType: CellEditType.Replace,
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: main branch, commit (28 march) OS Version: Linux Component: notebook When a user adds a new cell in a notebook, this created cell is automatically selected. This selection happens in the class (): However, when the user undoes and redoes this action, this new cell is not selected any more. This may be considered as an issue since undo/redo must be an identify function. I think that this issue takes sources in the method () where the current selection operation to do after the cell creation is . If I replace this arrow function by: and I removed the block of it works as expected (build, tests, integration tests OK). Steps to Reproduce: To reproduce the issue automatically, adds this test in (executed by ): I will open a PR to detail the proposal. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (in development mode). <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
I created a cell, and then undo/redo a bunch on that cell and the selection isn't always the recreated cell
any chance you can do a screen recording of the reproduce?
Can't repro this anymore. Marking as verified. Don't know what happened before. Although there is some screen cheese on many undo redos it's very brief.

Related discussion:
text: } ] } <del> ], synchronous, { kind: SelectionStateType.Handle, primary: previouslyPrimary, selections: beforeSelections }, () => undefined, undefined); </del> <ins> ], synchronous, { kind: SelectionStateType.Handle, primary: previouslyPrimary, selections: beforeSelections }, () => endSelections, undefined); </ins> return this._viewCells[index]; }
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.55.0 OS Version: Windows 10 Home 20H2 .867 Steps to Reproduce: run latest version of VS Code, 1.55.0 the list of default WSL profiles and you will find something like "Ubuntu (predet.)" instead of just "Ubuntu". profile is impossible to launch, because there is NO distro named "Ubuntu (predet.)". This happens because , at line 178 of latest snapshot I'm checking, does this: . It should remove other locales, too. I know this is difficult to do because... well, there's plenty of locales. So, in order to get the distribution name, another way should be used. I think it's safe to remove any last element within parentheses from the distro name as returned by , but really another method is available which I think it's safer, but I'm not sure how to write it in TypeScript. I have the following code already written in Python, for a system maintenance script I use in my own system, where I retrieve the installed distribution names from the registry: It's a partial code but well, I think it's self explanatory, and I can provide further information if needed. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
Same happens to me with the new version 1.55.0 One temporal solution that I found is to disable the autodetection of the distros and include each one with the profile setting:
hi, at first glance it looks that adding a -q argument to the 'wsl -l' command would be safe... regards
Thanks for the suggestion and the fix. Still, I'll keep an eye on this, just in case Microsoft decides to change command line interface. But so far, so good, and it's simpler than having to read the registry
Just encountered this issue today (after updating Docker for Desktop, but not sure if this has something to do with the issue).
Verified in

Related discussion:
text: if (useWslProfiles) { const distroOutput = await new Promise<string>((resolve, reject) => { // wsl.exe output is encoded in utf16le (ie. A -> 0x4100) <del> cp.exec('wsl.exe -l', { encoding: 'utf16le' }, (err, stdout) => { </del> <ins> cp.exec('wsl.exe -l -q', { encoding: 'utf16le' }, (err, stdout) => { </ins> if (err) { return reject('Problem occurred when getting wsl distros'); }