jiebi/CodeConvo huggingface dataset:
Code change:
Issue Type: <bBug</bI had a file with unusual line endings in it, and this happened: the dialog kept reappearing after pressing 'ignore' until i finally relented. When I tried to create a new file with weird line endings it seemed to work, maybe since I had the file opened while the file was being generated, every time the file changed the dialog was re-enqueued even though it was already open? VS Code version: Code 1.66.2 (Universal) (, 2022-04-11T07:49:20.994Z) OS version: Darwin arm64 21.1.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ astro-vscode0.16.0 vscode-graphql0.4.4 vscode-docker1.22.0 svelte-vscode105.16.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
could you post some steps to verify?
I could not reproduce this myself, I did the change by realizing that the code showing the dialog is re-entrant. Could you please verify the fix using our
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
I tried adding to the end of files and got the dialog, but I couldn't get the dialog to keep showing up on Stable.
Verified by code review
unfortunately it was a one-off conversion script from an old system that caused the issue which I don't have any longer, so I'm not sure about the exact steps to reproduce it! edit: oops wrong account, i'm threecreepio. :D

Related discussion:
text: import { IEditorContribution } from 'vs/editor/common/editorCommon'; import { ITextModel } from 'vs/editor/common/model'; import * as nls from 'vs/nls'; <del> import { IDialogService } from 'vs/platform/dialogs/common/dialogs'; </del> <ins> import { IConfirmationResult, IDialogService } from 'vs/platform/dialogs/common/dialogs'; </ins> const ignoreUnusualLineTerminators = 'ignoreUnusualLineTerminators';
Code change:
Issue Type: <bBug</bI had a file with unusual line endings in it, and this happened: the dialog kept reappearing after pressing 'ignore' until i finally relented. When I tried to create a new file with weird line endings it seemed to work, maybe since I had the file opened while the file was being generated, every time the file changed the dialog was re-enqueued even though it was already open? VS Code version: Code 1.66.2 (Universal) (, 2022-04-11T07:49:20.994Z) OS version: Darwin arm64 21.1.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ astro-vscode0.16.0 vscode-graphql0.4.4 vscode-docker1.22.0 svelte-vscode105.16.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
could you post some steps to verify?
I could not reproduce this myself, I did the change by realizing that the code showing the dialog is re-entrant. Could you please verify the fix using our
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
I tried adding to the end of files and got the dialog, but I couldn't get the dialog to keep showing up on Stable.
Verified by code review
unfortunately it was a one-off conversion script from an old system that caused the issue which I don't have any longer, so I'm not sure about the exact steps to reproduce it! edit: oops wrong account, i'm threecreepio. :D

Related discussion:
text: public static readonly ID = 'editor.contrib.unusualLineTerminatorsDetector'; private _config: 'auto' | 'off' | 'prompt'; <ins> private _isPresentingDialog: boolean = false; </ins> constructor( private readonly _editor: ICodeEditor,
Code change:
Issue Type: <bBug</bWhen closing the Python interactive window the Terminal panel shows itself. ! VS Code version: Code 1.67.0 (, 2022-05-04T12:06:02.889Z) OS version: Windows_NT x64 10.0. Restricted Mode: No <details<summaryExtensions (8)</summaryExtensionVersion ------ remotehub0.32.0 python2022.6.0 vscode-pylance2022.4.3 jupyter2022.4. jupyter-keymap1.0.0 jupyter-renderers1.0.6 remote-repositories0.6.0 markdown-all-in-one3.4.3 </details<!-- generated by issue reporter --
what's the recommended approach to debug this? I'm not sure who is opening the terminal (but I know it's not notebook or iw as it's the editor tab close button)
I debugged this, and determined that when the interactive window is closed, it updates a context key which hide a view container in the panel. this incorrectly triggers the panel to show.

Related discussion:
text: contextKey.set(true); this.compositeBar.addComposite({ id: viewContainer.id, name: viewContainer.title, order: viewContainer.order, requestedIndex: viewContainer.requestedIndex }); <del> const activeComposite = this.getActiveComposite(); if (activeComposite === undefined || activeComposite.getId() === viewContainer.id) { this.compositeBar.activateComposite(viewContainer.id); </del> <ins> if (this.layoutService.isVisible(this.partId)) { const activeComposite = this.getActiveComposite(); if (activeComposite === undefined || activeComposite.getId() === viewContainer.id) { this.compositeBar.activateComposite(viewContainer.id); } </ins> } this.layoutCompositeBar();
Code change:
Open in two different tabs Make sure settings sync is OFF Change the theme in one tab Theme is not updated in other tab

Related discussion:
text: // User data let userDataProvider; if (indexedDB) { <del> userDataProvider = new IndexedDBFileSystemProvider(logsPath.scheme, indexedDB, userDataStore, false); </del> <ins> userDataProvider = new IndexedDBFileSystemProvider(Schemas.vscodeUserData, indexedDB, userDataStore, true); </ins> this.registerDeveloperActions(<IndexedDBFileSystemProvider>userDataProvider); } else { logService.info('Using in-memory user data provider');
Code change:
The layout controls icons can be a bit of an eye sore when in the default state. One way to remedy this and to give a stronger indication of the state, we could swap icons based on their state. Would look something like this: https://user-
these icon are now in: - -

Related discussion:
text: public static readonly layoutStatusbar = new Codicon('layout-statusbar', { fontCharacter: 'ebf5' }); public static readonly layoutMenubar = new Codicon('layout-menubar', { fontCharacter: 'ebf6' }); public static readonly layoutCentered = new Codicon('layout-centered', { fontCharacter: 'ebf7' }); <ins> public static readonly layoutSidebarRightOff = new Codicon('layout-sidebar-right-off', { fontCharacter: 'ec00' }); public static readonly layoutPanelOff = new Codicon('layout-panel-off', { fontCharacter: 'ec01' }); public static readonly layoutSidebarLeftOff = new Codicon('layout-sidebar-left-off', { fontCharacter: 'ec02' }); </ins> public static readonly target = new Codicon('target', { fontCharacter: 'ebf8' }); public static readonly indent = new Codicon('indent', { fontCharacter: 'ebf9' }); public static readonly recordSmall = new Codicon('record-small', { fontCharacter: 'ebfa' });
Code change:
Many of these onDispose listeners get created:
we fixed this at one pt. !
They were in and
here's when we lost it
want to fix it since you're working on that PR?
Let's hold off until it's done, this PR is complicated enough without merge problems
it's a simple fix - literally adding to the conditional on line 218
Did another review and haven't seen this issue since

Related discussion:
text: if (beforeCommandExecution && !this._placeholderDecoration) { this._placeholderDecoration = decoration; this._placeholderDecoration.onDispose(() => this._placeholderDecoration = undefined); <del> } else { </del> <ins> } else if (!this._decorations.get(decoration.marker.id)) { </ins> decoration.onDispose(() => this._decorations.delete(decoration.marker.id)); this._decorations.set(decoration.marker.id, {
Code change:
Request refactorings, and extract to a function at the top-level. Expected: no crash Actual: I'm not sure on the specific version, but in the last 9 days or so we started seeing the following crash:
Actually I found this while trying to repro a different bug. The one I was looking to repro had the following stack trace: <details<summaryOriginal Stack Trace </summary</details I think this actually only repros when working in an anonymous buffer in VS Code. When you ask for a refactoring on an anonymous buffer, we come back with the same buffer name However, VS Code pops up a notification that "You cannot rename this element" and creates a new buffer with the contents. This confuses TSServer a lot, and makes it fail over and over again.
I initially read the last part of the issue title as “thanks, language service” and thought the sarcasm was appropriate.
I may steal that in the future :D
can you transfer this issue to VSCode if appropriate?
Did this just start happening with the latest insiders?
Possible introduced with
Yeah, I believe it didn't repro on a 2 week old nightly, but I can't 100% confirm.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

Related discussion:
text: export default class TypeScriptServiceClient extends Disposable implements ITypeScriptServiceClient { private readonly pathSeparator: string; <ins> private readonly emptyAuthority = 'ts-nul-authority'; </ins> private readonly inMemoryResourcePrefix = '^'; private readonly workspaceState: vscode.Memento;
Code change:
Request refactorings, and extract to a function at the top-level. Expected: no crash Actual: I'm not sure on the specific version, but in the last 9 days or so we started seeing the following crash:
Actually I found this while trying to repro a different bug. The one I was looking to repro had the following stack trace: <details<summaryOriginal Stack Trace </summary</details I think this actually only repros when working in an anonymous buffer in VS Code. When you ask for a refactoring on an anonymous buffer, we come back with the same buffer name However, VS Code pops up a notification that "You cannot rename this element" and creates a new buffer with the contents. This confuses TSServer a lot, and makes it fail over and over again.
I initially read the last part of the issue title as “thanks, language service” and thought the sarcasm was appropriate.
I may steal that in the future :D
can you transfer this issue to VSCode if appropriate?
Did this just start happening with the latest insiders?
Possible introduced with
Yeah, I believe it didn't repro on a 2 week old nightly, but I can't 100% confirm.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

Related discussion:
text: { return this.inMemoryResourcePrefix + '/' + resource.scheme <del> + '/' + resource.authority </del> <ins> + '/' + (resource.authority || this.emptyAuthority) </ins> + (resource.path.startsWith('/') ? resource.path : '/' + resource.path) + (resource.fragment ? '#' + resource.fragment : ''); }
Code change:
Request refactorings, and extract to a function at the top-level. Expected: no crash Actual: I'm not sure on the specific version, but in the last 9 days or so we started seeing the following crash:
Actually I found this while trying to repro a different bug. The one I was looking to repro had the following stack trace: <details<summaryOriginal Stack Trace </summary</details I think this actually only repros when working in an anonymous buffer in VS Code. When you ask for a refactoring on an anonymous buffer, we come back with the same buffer name However, VS Code pops up a notification that "You cannot rename this element" and creates a new buffer with the contents. This confuses TSServer a lot, and makes it fail over and over again.
I initially read the last part of the issue title as “thanks, language service” and thought the sarcasm was appropriate.
I may steal that in the future :D
can you transfer this issue to VSCode if appropriate?
Did this just start happening with the latest insiders?
Possible introduced with
Yeah, I believe it didn't repro on a 2 week old nightly, but I can't 100% confirm.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

Related discussion:
text: } if (filepath.startsWith(this.inMemoryResourcePrefix)) { <del> const parts = filepath.match(/^^/([^/]+)/(.+)$/); </del> <ins> const parts = filepath.match(/^^/([^/]+)/([^/]*)/(.+)$/); </ins> if (parts) { <del> const resource = vscode.Uri.parse(parts[1] + '://' + parts[2]); </del> <ins> const resource = vscode.Uri.parse(parts[1] + '://' + (parts[2] === this.emptyAuthority ? '' : parts[2]) + '/' + parts[3]); </ins> return this.bufferSyncSupport.toVsCodeResource(resource); } }
Code change:
<img width="628" alt="image" src="https://user-"I often by accident click on the wrong button when adding a comment, imho this action is way too prominent there because it seems like the primary button to add the comment. //cc also because both buttons have the same color <img width="306" alt="image" src="https://user-"
The "Go to Review" button was to address confusion on how to complete a review: We could add some convention where the left-most button gets more prominent styling. what do you think?
Catching up after a week off.. I believe we should follow the same patterns used for dialogs and notifications where a single primary button is used alongside one or more secondary buttons. From what I understand, our the order the buttons in a dialog depends on the OS. Windows gets left-aligned primary buttons, vice versa for macOS. In this case, since the buttons are always right-aligned to the comment input on any platform, I think the primary button should be on the far right to align with the edge of the container. This looks to already be the case elsewhere in the extension: <img width="423" alt="CleanShot 2022-04-18 at 09 09 03 src="https://user-"
Thanks I want to update the style of this button to be a primary button, but there may be extensions that flip the order of importance for their buttons. I'll poll some other folks and see if it seems ok.
Verified. I assume that Go to Review button is renamed to Start Review !
The Start Review button is a Go to Review button once you have already started a review. But since you verified the button colors this is still verified.

Related discussion:
text: this._buttonElements.forEach(b => b.remove()); const groups = menu.getActions({ shouldForwardArgs: true }); <ins> let isPrimary: boolean = true; </ins> for (const group of groups) { const [, actions] = group; this._actions = actions; <del> actions.forEach(action => { const button = new Button(this.container); </del> <ins> for (const action of actions) { const button = new Button(this.container, { secondary: !isPrimary }); isPrimary = false; </ins> this._buttonElements.push(button.element); this._toDispose.add(button);
Code change:
<img width="628" alt="image" src="https://user-"I often by accident click on the wrong button when adding a comment, imho this action is way too prominent there because it seems like the primary button to add the comment. //cc also because both buttons have the same color <img width="306" alt="image" src="https://user-"
The "Go to Review" button was to address confusion on how to complete a review: We could add some convention where the left-most button gets more prominent styling. what do you think?
Catching up after a week off.. I believe we should follow the same patterns used for dialogs and notifications where a single primary button is used alongside one or more secondary buttons. From what I understand, our the order the buttons in a dialog depends on the OS. Windows gets left-aligned primary buttons, vice versa for macOS. In this case, since the buttons are always right-aligned to the comment input on any platform, I think the primary button should be on the far right to align with the edge of the container. This looks to already be the case elsewhere in the extension: <img width="423" alt="CleanShot 2022-04-18 at 09 09 03 src="https://user-"
Thanks I want to update the style of this button to be a primary button, but there may be extensions that flip the order of importance for their buttons. I'll poll some other folks and see if it seems ok.
Verified. I assume that Go to Review button is renamed to Start Review !
The Start Review button is a Go to Review button once you have already started a review. But since you verified the button colors this is still verified.

Related discussion:
text: button.enabled = action.enabled; button.label = action.label; <del> }); </del> <ins> } </ins> } }
Code change:
<img width="628" alt="image" src="https://user-"I often by accident click on the wrong button when adding a comment, imho this action is way too prominent there because it seems like the primary button to add the comment. //cc also because both buttons have the same color <img width="306" alt="image" src="https://user-"
The "Go to Review" button was to address confusion on how to complete a review: We could add some convention where the left-most button gets more prominent styling. what do you think?
Catching up after a week off.. I believe we should follow the same patterns used for dialogs and notifications where a single primary button is used alongside one or more secondary buttons. From what I understand, our the order the buttons in a dialog depends on the OS. Windows gets left-aligned primary buttons, vice versa for macOS. In this case, since the buttons are always right-aligned to the comment input on any platform, I think the primary button should be on the far right to align with the edge of the container. This looks to already be the case elsewhere in the extension: <img width="423" alt="CleanShot 2022-04-18 at 09 09 03 src="https://user-"
Thanks I want to update the style of this button to be a primary button, but there may be extensions that flip the order of importance for their buttons. I'll poll some other folks and see if it seems ok.
Verified. I assume that Go to Review button is renamed to Start Review !
The Start Review button is a Go to Review button once you have already started a review. But since you verified the button colors this is still verified.

Related discussion:
text: padding: 10px 0; } <del> .review-widget .body .edit-container .form-actions { display: flex; justify-content: flex-end; } </del> .review-widget .body .edit-textarea { height: 90px; margin: 5px 0 10px 0;
Code change:
<img width="628" alt="image" src="https://user-"I often by accident click on the wrong button when adding a comment, imho this action is way too prominent there because it seems like the primary button to add the comment. //cc also because both buttons have the same color <img width="306" alt="image" src="https://user-"
The "Go to Review" button was to address confusion on how to complete a review: We could add some convention where the left-most button gets more prominent styling. what do you think?
Catching up after a week off.. I believe we should follow the same patterns used for dialogs and notifications where a single primary button is used alongside one or more secondary buttons. From what I understand, our the order the buttons in a dialog depends on the OS. Windows gets left-aligned primary buttons, vice versa for macOS. In this case, since the buttons are always right-aligned to the comment input on any platform, I think the primary button should be on the far right to align with the edge of the container. This looks to already be the case elsewhere in the extension: <img width="423" alt="CleanShot 2022-04-18 at 09 09 03 src="https://user-"
Thanks I want to update the style of this button to be a primary button, but there may be extensions that flip the order of importance for their buttons. I'll poll some other folks and see if it seems ok.
Verified. I assume that Go to Review button is renamed to Start Review !
The Start Review button is a Go to Review button once you have already started a review. But since you verified the button colors this is still verified.

Related discussion:
text: margin-bottom: 5px; } <del> .review-widget .body .comment-form .monaco-text-button { </del> <ins> .review-widget .body .form-actions .monaco-text-button { </ins> float: right; }
Code change:
Issue Type: <bBug</bJust updated VSC and I can no longer execute jupyter notebook cells This happens when working both in local and connected to a SSH host, both with python and markdown cells I get the following error: Checked the output every extension and log, there's no errors or no clue as to what is happening. VS Code version: Code - Insiders 1.68.0-insider (, 2022-05-11T05:17:12.474Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 5.4.0-1072-aws <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ jupyter-keymap1.0.0 remote-containers0.235.0 remote-ssh0.80.0 remote-ssh-edit0.80.0 remote-wsl0.66.2 vscode-remote-extensionpack0.21.0 python2022.6.1 vscode-pylance2022.4.3 jupyter2022.5. jupyter-keymap1.0.0 jupyter-renderers1.0.6 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Snapshot of message: ! I would post snapshots of the outputs of extensions and logs, but there is no output whatsoever generating when attempting to run a cell
I experienced the same after todays update to the same version. Using WSL2 Debian remote from Windows 10.
Same here!
Same.
I was able to workaround this issue by using the command "Notebook: Execute Cell".
same
Via the command palette? (Cmd/Ctrl+shift+p)?
Yep, that's how I first found it. You can also invoke the command directly from a cell with ctrl+alt+enter.
Same problem here too, thanks in advance for addressing!
I fixed it by determining the keyboard shortcut again. (ctrl + enter) However, the run icon still does not work. But the shortcut works.
run icon or regular shortcuts (shift+enter, ctrl+enter) did not work form me, only ctrl+alt+enter (which I wasn't even aware of until mentioned it) did anyways, seems to be fixed with PR, thanks for the quick response
How can I activate the PR in Insiders?
fix was already released for the VSC insiders build, update your installation
when I run jupyter notebooki type three words in it,the window can't response occur,then the vscode crushed,what should i dot to slove this problem

Related discussion:
text: } } <del> async function runCell(accessor: ServicesAccessor, context: INotebookActionContext): Promise<void> { const editorGroupService = accessor.get(IEditorGroupsService); const group = editorGroupService.activeGroup; </del> <ins> async function runCell(editorGroupsService: IEditorGroupsService, context: INotebookActionContext): Promise<void> { const group = editorGroupsService.activeGroup; </ins> if (group) { if (group.activeEditor) {