jiebi/CodeConvo huggingface dataset:
Code change:
Testing fyi Single click on the instruction breakpoint properly reveals that instruction breakpoint - great. Double click should pass focus to the disassembly view. Just like we do for regular breakpoints
Will fix this.

Related discussion:
text: this.loadDisassembledInstructions(targetAddress, -DisassemblyView.NUM_INSTRUCTIONS_TO_LOAD, DisassemblyView.NUM_INSTRUCTIONS_TO_LOAD * 2).then(() => { // on load, set the target instruction in the middle of the page. if (this._disassembledInstructions!.length > 0) { <del> this._disassembledInstructions!.reveal(Math.floor(this._disassembledInstructions!.length / 2), 0.5); </del> <ins> const targetIndex = Math.floor(this._disassembledInstructions!.length / 2); this._disassembledInstructions!.reveal(targetIndex, 0.5); // Always focus the target address on reload, or arrow key navigation would look terrible this._disassembledInstructions!.domFocus(); this._disassembledInstructions!.setFocus([targetIndex]); </ins> } }); }
Code change:
We only respect the setting when a is found: We should always support the separator.
//cc
Went ahead with a fix myself because I figured it is more involved: without formatting we cannot just add the separator so I ended up using the method that matches the config in that case on the relative path.
Thanks for the proper fix! I had couple of attempts but first failed when list of files in with stopped to work (apparently needed ) Second was but it produced different results for and . Haven't thought about using same normalization as in
what are some verification steps for this issue?
thanks for bringing this up. Steps from : different values for "Copy relative path" for some nested filed - separators should match selection (or system separator for ) I've checked latest version in and looks like fix doesn't work at this moment: apparently won't replace with ! Maybe it make sense to use ?
is a valid character in filenames on POSIX so this is a bit tricky... I don't think we should ever convert it to on a POSIX system as that would represent a totally different resource.
Yep, in name is tricky but is it common case? Anyway: Alternative option will be to "force" path formatting which will work with and I'm assume it will always have as separator that later converted to if needed without causing problem with -that might replace from filenames This will be "similar" to missing formatting as would work with it as with path anyway. But then there will be inconsistency with : - relative as expected, expected separator- relative as expected, expected separator- - not expected but return full path (same as current behavior in ) as it's processed with , separator not supported at all. I'm not sure why returns full path but I guess it's incorrect setup for in web playground, as works OK for files in VS Code desktop.
Reopening with verification steps web on windows .copyRelativePathSeparator: a path from the memfs system that it still uses I can take this as I own label service from Going to push out as products are not affected.
It looks like the code that is typically doing this conversion when a formatting is there is this one: Maybe we can do something similar instead of and replace any of or with the separator.

Related discussion:
text: // Without formatting we still need to support the separator // as provided in options (https://github.com/microsoft/vscode/issues/130019) if (!formatting && options.separator) { <del> switch (options.separator) { case paths.win32.sep: return paths.win32.normalize(label); case paths.posix.sep: return paths.posix.normalize(label); } </del> <ins> return label.replace(sepRegexp, options.separator); </ins> } return label;
Code change:
We only respect the setting when a is found: We should always support the separator.
//cc
Went ahead with a fix myself because I figured it is more involved: without formatting we cannot just add the separator so I ended up using the method that matches the config in that case on the relative path.
Thanks for the proper fix! I had couple of attempts but first failed when list of files in with stopped to work (apparently needed ) Second was but it produced different results for and . Haven't thought about using same normalization as in
what are some verification steps for this issue?
thanks for bringing this up. Steps from : different values for "Copy relative path" for some nested filed - separators should match selection (or system separator for ) I've checked latest version in and looks like fix doesn't work at this moment: apparently won't replace with ! Maybe it make sense to use ?
is a valid character in filenames on POSIX so this is a bit tricky... I don't think we should ever convert it to on a POSIX system as that would represent a totally different resource.
Yep, in name is tricky but is it common case? Anyway: Alternative option will be to "force" path formatting which will work with and I'm assume it will always have as separator that later converted to if needed without causing problem with -that might replace from filenames This will be "similar" to missing formatting as would work with it as with path anyway. But then there will be inconsistency with : - relative as expected, expected separator- relative as expected, expected separator- - not expected but return full path (same as current behavior in ) as it's processed with , separator not supported at all. I'm not sure why returns full path but I guess it's incorrect setup for in web playground, as works OK for files in VS Code desktop.
Reopening with verification steps web on windows .copyRelativePathSeparator: a path from the memfs system that it still uses I can take this as I own label service from Going to push out as products are not affected.
It looks like the code that is typically doing this conversion when a formatting is there is this one: Maybe we can do something similar instead of and replace any of or with the separator.

Related discussion:
text: assert.strictEqual(generated, label); }); }); <ins> test('relative label with explicit path separator', () => { let generated = labelService.getUriLabel(URI.parse('myscheme://myauthority/some/folder/test.txt'), { relative: true, separator: '/' }); assert.strictEqual(generated, 'some/folder/test.txt'); generated = labelService.getUriLabel(URI.parse('myscheme://myauthority/some/folder/test.txt'), { relative: true, separator: '' }); assert.strictEqual(generated, 'somefoldertest.txt'); }); </ins> });
Code change:
! //cc
Works great in most cases! Maybe this button needs manual tweaking though to align with the one we have in search view: ! !
Removed the border radius for the expanding chevron: <img width="139" alt="CleanShot 2021-09-13 at 15 40 09 src="https://user-"

Related discussion:
text: } .monaco-editor .find-widget .button { <del> width: 20px; height: 20px; </del> <ins> width: 16px; height: 16px; padding: 3px; border-radius: 5px; </ins> display: flex; flex: initial; margin-left: 3px;
Code change:
! //cc
Works great in most cases! Maybe this button needs manual tweaking though to align with the one we have in search view: ! !
Removed the border radius for the expanding chevron: <img width="139" alt="CleanShot 2021-09-13 at 15 40 09 src="https://user-"

Related discussion:
text: justify-content: center; } <ins> /* find in selection button */ .monaco-editor .find-widget .codicon-find-selection { width: 22px; height: 22px; padding: 3px; border-radius: 5px; } </ins> .monaco-editor .find-widget .button.left { margin-left: 0; margin-right: 3px;
Code change:
! //cc
Works great in most cases! Maybe this button needs manual tweaking though to align with the one we have in search view: ! !
Removed the border radius for the expanding chevron: <img width="139" alt="CleanShot 2021-09-13 at 15 40 09 src="https://user-"

Related discussion:
text: import { FindReplaceState, FindReplaceStateChangedEvent } from 'vs/editor/contrib/find/findState'; import { IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; <del> import { contrastBorder, editorFindMatch, editorFindMatchBorder, editorFindMatchHighlight, editorFindMatchHighlightBorder, editorFindRangeHighlight, editorFindRangeHighlightBorder, editorWidgetBackground, editorWidgetBorder, editorWidgetResizeBorder, errorForeground, inputActiveOptionBorder, inputActiveOptionBackground, inputActiveOptionForeground, inputBackground, inputBorder, inputForeground, inputValidationErrorBackground, inputValidationErrorBorder, inputValidationErrorForeground, inputValidationInfoBackground, inputValidationInfoBorder, inputValidationInfoForeground, inputValidationWarningBackground, inputValidationWarningBorder, inputValidationWarningForeground, widgetShadow, editorWidgetForeground, focusBorder } from 'vs/platform/theme/common/colorRegistry'; </del> <ins> import { contrastBorder, editorFindMatch, editorFindMatchBorder, editorFindMatchHighlight, editorFindMatchHighlightBorder, editorFindRangeHighlight, editorFindRangeHighlightBorder, editorWidgetBackground, editorWidgetBorder, editorWidgetResizeBorder, errorForeground, inputActiveOptionBorder, inputActiveOptionBackground, inputActiveOptionForeground, inputBackground, inputBorder, inputForeground, inputValidationErrorBackground, inputValidationErrorBorder, inputValidationErrorForeground, inputValidationInfoBackground, inputValidationInfoBorder, inputValidationInfoForeground, inputValidationWarningBackground, inputValidationWarningBorder, inputValidationWarningForeground, widgetShadow, editorWidgetForeground, focusBorder, toolbarHoverBackground } from 'vs/platform/theme/common/colorRegistry'; </ins> import { IColorTheme, IThemeService, registerThemingParticipant, ThemeIcon } from 'vs/platform/theme/common/themeService'; import { ContextScopedFindInput, ContextScopedReplaceInput } from 'vs/platform/browser/contextScopedHistoryWidget'; import { AccessibilitySupport } from 'vs/platform/accessibility/common/accessibility';
Code change:
! //cc
Works great in most cases! Maybe this button needs manual tweaking though to align with the one we have in search view: ! !
Removed the border radius for the expanding chevron: <img width="139" alt="CleanShot 2021-09-13 at 15 40 09 src="https://user-"

Related discussion:
text: } } <ins> // Action bars const toolbarHoverBackgroundColor = theme.getColor(toolbarHoverBackground); if (toolbarHoverBackgroundColor) { collector.addRule(` .monaco-editor .find-widget .button:not(.disabled):hover, .monaco-editor .find-widget .codicon-find-selection:hover { background-color: ${toolbarHoverBackgroundColor} !important; } `); } </ins> // This rule is used to override the outline color for synthetic-focus find input. const focusOutline = theme.getColor(focusBorder); if (focusOutline) {
Code change:
Issue Type: <bBug</bthe getting started page split editor split editor cursor on left hand side Bug A scroll bar is shown even though there is plenty of space. Scrolling doesn't seem to do anything <img width="679" alt="Screen Shot 2021-08-23 at 11 19 37 PM" src="https://user-"VS Code version: Code - Insiders 1.60.0-insider (, 2021-08-23T10:42:53.526Z) OS version: Darwin x64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
I would like to contribute to this. Can I help you with the issue?

Related discussion:
text: const media = stepToExpand.media; const mediaElement = $<HTMLImageElement>('img'); <ins> clearNode(this.stepMediaComponent); </ins> this.stepMediaComponent.appendChild(mediaElement); mediaElement.setAttribute('alt', media.altText); this.updateMediaSourceForColorMode(mediaElement, media.path);
Code change:
Issue Type: <bBug</bthe getting started page split editor split editor cursor on left hand side Bug A scroll bar is shown even though there is plenty of space. Scrolling doesn't seem to do anything <img width="679" alt="Screen Shot 2021-08-23 at 11 19 37 PM" src="https://user-"VS Code version: Code - Insiders 1.60.0-insider (, 2021-08-23T10:42:53.526Z) OS version: Darwin x64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
I would like to contribute to this. Can I help you with the issue?

Related discussion:
text: this.container.classList.toggle('height-constrained', size.height <= 600); this.container.classList.toggle('width-constrained', size.width <= 400); this.container.classList.toggle('width-semi-constrained', size.width <= 800); <ins> this.categoriesPageScrollbar?.scanDomNode(); this.detailsPageScrollbar?.scanDomNode(); this.detailsScrollbar?.scanDomNode(); </ins> } private updateCategoryProgress() {
Code change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --VSCode have add a new keybinding for , so, remenber to add ctrl+i for toggleSuggestionDetails which is usiing the same let add this !

Related discussion:
text: weight: weight, kbExpr: EditorContextKeys.textInputFocus, primary: KeyMod.CtrlCmd | KeyCode.Space, <del> mac: { primary: KeyMod.WinCtrl | KeyCode.Space } </del> <ins> secondary: [KeyMod.CtrlCmd | KeyCode.KEY_I], mac: { primary: KeyMod.WinCtrl | KeyCode.Space, secondary: [KeyMod.CtrlCmd | KeyCode.KEY_I] } </ins> }, menuOpts: [{ menuId: suggestWidgetStatusbarMenu,
Code change:
Issue Type: <bFeature Request</bWhen foldind HTML tags inside JSX code, the closing tag is hidden and sometimes this make the understanding of the code a little bit confusing. Also, copying the folded code becomes a bit difficult. I was wondering if its possilble to make it work like in HTML, where when you fold a tag it is possible to see both opening and closing tags. Imagine that we have this JSX code: When we fold the tag, it is displayed like this: In HTML the code will be like this, showing the closing tag: so its easier to copy the code and understand the structure VS Code version: Code 1.59.1 (, 2021-08-19T11:54:37.513Z) OS version: Linux x64 5.11.0-31-generic Restricted Mode: No <!-- generated by issue reporter --
Relevant code:
Hi, would love to take this on as my first contribution!

Related discussion:
text: return new vscode.FoldingRange(start, end, kind); } <del> private static readonly foldEndPairCharacters = ['}', ']', ')', '`']; </del> <ins> private static readonly foldEndPairCharacters = ['}', ']', ')', '`', '>']; </ins> private adjustFoldingEnd(range: vscode.Range, document: vscode.TextDocument) { // workaround for #47240
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (Needs InlineSuggestions from some extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0 OS Version: MacOS Catalina 10.15.7 Steps to Reproduce: GitHub Copilot. The exact version shouldn't be important, but this was verified using 1.4.2586. a blank Python document and enter the following text: There are a single space after each sign. Put the cursor on the end of the first line and trigger Copilot inline-suggestion by pressing Backspace then Space. Don't accept it, but press Down-arrow, Backspace, Space. After pressing Down-arrow the suggestion on the first line disappears (as it should), but after the Backspace+space, you may see the suggestion briefly appear again, before the new inline-suggestion appearing on the second line. This is a bit flaky, and it may not appear every time the cursor is moved. It may also depend on latency to the Copilot server, and so be less pronounced in e.g. North America than in Europe or Asia. Edit by This is the buggy behavior: !
Please let me know soon if we should release this with our Recovery Release tomorrow!
Thanks for your lightning fast fix, Releasing this quickly would be awesome - it's a quite distracting glitch!
can you verify that the issue is fixed in todays insider build?
As he's out today, I've had a play with today's insiders build and can't reproduce it, whereas I can with the insiders build from 6th September. So looks good to me!

Related discussion:
text: } })); <ins> this._register(toDisposable(() => { this.cache.clear(); })); </ins> this._register(this.editor.onDidChangeCursorPosition((e) => { if (this.cache.value) { this.onDidChangeEmitter.fire();
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (Needs InlineSuggestions from some extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0 OS Version: MacOS Catalina 10.15.7 Steps to Reproduce: GitHub Copilot. The exact version shouldn't be important, but this was verified using 1.4.2586. a blank Python document and enter the following text: There are a single space after each sign. Put the cursor on the end of the first line and trigger Copilot inline-suggestion by pressing Backspace then Space. Don't accept it, but press Down-arrow, Backspace, Space. After pressing Down-arrow the suggestion on the first line disappears (as it should), but after the Backspace+space, you may see the suggestion briefly appear again, before the new inline-suggestion appearing on the second line. This is a bit flaky, and it may not appear every time the cursor is moved. It may also depend on latency to the Copilot server, and so be less pronounced in e.g. North America than in Europe or Asia. Edit by This is the buggy behavior: !
Please let me know soon if we should release this with our Recovery Release tomorrow!
Thanks for your lightning fast fix, Releasing this quickly would be awesome - it's a quite distracting glitch!
can you verify that the issue is fixed in todays insider build?
As he's out today, I've had a play with today's insiders build and can't reproduce it, whereas I can with the insiders build from 6th September. So looks good to me!

Related discussion:
text: import { timeout } from 'vs/base/common/async'; import { CancellationToken } from 'vs/base/common/cancellation'; import { Disposable } from 'vs/base/common/lifecycle'; <del> import { CoreEditingCommands } from 'vs/editor/browser/controller/coreCommands'; </del> <ins> import { CoreEditingCommands, CoreNavigationCommands } from 'vs/editor/browser/controller/coreCommands'; </ins> import { Position } from 'vs/editor/common/core/position'; import { ITextModel } from 'vs/editor/common/model'; import { InlineCompletionsProvider, InlineCompletion, InlineCompletionContext } from 'vs/editor/common/modes';
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No (Needs InlineSuggestions from some extension) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.60.0 OS Version: MacOS Catalina 10.15.7 Steps to Reproduce: GitHub Copilot. The exact version shouldn't be important, but this was verified using 1.4.2586. a blank Python document and enter the following text: There are a single space after each sign. Put the cursor on the end of the first line and trigger Copilot inline-suggestion by pressing Backspace then Space. Don't accept it, but press Down-arrow, Backspace, Space. After pressing Down-arrow the suggestion on the first line disappears (as it should), but after the Backspace+space, you may see the suggestion briefly appear again, before the new inline-suggestion appearing on the second line. This is a bit flaky, and it may not appear every time the cursor is moved. It may also depend on latency to the Copilot server, and so be less pronounced in e.g. North America than in Europe or Asia. Edit by This is the buggy behavior: !
Please let me know soon if we should release this with our Recovery Release tomorrow!
Thanks for your lightning fast fix, Releasing this quickly would be awesome - it's a quite distracting glitch!
can you verify that the issue is fixed in todays insider build?
As he's out today, I've had a play with today's insiders build and can't reproduce it, whereas I can with the insiders build from 6th September. So looks good to me!

Related discussion:
text: this.editor.trigger('keyboard', 'type', { text }); } <ins> public cursorUp(): void { CoreNavigationCommands.CursorUp.runEditorCommand(null, this.editor, null); } public cursorRight(): void { CoreNavigationCommands.CursorRight.runEditorCommand(null, this.editor, null); } public cursorLeft(): void { CoreNavigationCommands.CursorLeft.runEditorCommand(null, this.editor, null); } public cursorDown(): void { CoreNavigationCommands.CursorDown.runEditorCommand(null, this.editor, null); } public cursorLineEnd(): void { CoreNavigationCommands.CursorLineEnd.runEditorCommand(null, this.editor, null); } </ins> public leftDelete(): void { CoreEditingCommands.DeleteLeft.runEditorCommand(null, this.editor, null); }
Code change:
Currently when using , ArrayBuffers just turn into an empty object. We should support these for efficient data transfer between extensions/extension hosts. We recently support for them on a protocol level, so support here should not be terribly hard...
I see two possible approaches to support this: this logic specifically for commands (or even just for a specific command). This is what we do for webviews for example: our implementation aware of array buffers instead of only supporting VSBuffers. Take a look at how is used in our rpc code as a starting point: The webview serialization logic I linked to above would probably be a good starting point for this

Related discussion:
text: import { extHostNamedCustomer } from 'vs/workbench/api/common/extHostCustomers'; import { revive } from 'vs/base/common/marshalling'; import { IExtensionService } from 'vs/workbench/services/extensions/common/extensions'; <ins> import { SerializableObjectWithBuffers } from 'vs/workbench/services/extensions/common/proxyIdentifier'; </ins> @extHostNamedCustomer(MainContext.MainThreadCommands) export class MainThreadCommands implements MainThreadCommandsShape {