jiebi/CodeConvo huggingface dataset:
Code change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --Hello, I searched for an existing ticket with , but didn't find anything related. <!-- Describe the feature you'd like. --Prior to v1.72.0, the extension sidebar showed which version an extension will be updated to. And when hovering over the extension in the sidebar, or opening the extension in a tab, you could see the currently installed one. That way you could see for example if an update is a major, minor, or patch update, and depending on that dig into the release notes or not. Further in the past, IIRC, the extension sidebar even showed both, installed and target version, which was even more convenient. Now with v1.72.0, I don't see anywhere the target version of an extension update. Many extensions don't keep a proper changelog, so that's not a reliable place to check. Here's an example for vscode-icons, a very popular extension with 12 million installs: ! Only when going to the Marketplace webpage () we see the target version: ! =Feature request: Please make the target version for extension updates visible inside of VS Code again.
Latest version is now shown in the hover. Update button in the extension editor shows the version.

Related discussion:
text: markdown.appendText(`n`); } <ins> if (this.extension.outdated) { markdown.appendMarkdown(localize('updateRequired', "Latest version:")); markdown.appendMarkdown(`&nbsp;<span style="background-color:#8080802B;">**&nbsp;_v${this.extension.latestVersion}_**&nbsp;</span>`); markdown.appendText(`n`); } </ins> const preReleaseMessage = ExtensionHoverWidget.getPreReleaseMessage(this.extension); const extensionRuntimeStatus = this.extensionsWorkbenchService.getExtensionStatus(this.extension); const extensionStatus = this.extensionStatusAction.status; <del> const reloadRequiredMessage = this.reloadAction.enabled ? this.reloadAction.tooltip : ''; </del> <ins> const reloadRequiredMessage = this.extension.reloadRequiredStatus; </ins> const recommendationMessage = this.getRecommendationMessage(this.extension); if (extensionRuntimeStatus || extensionStatus || reloadRequiredMessage || recommendationMessage || preReleaseMessage) {
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.72.1 (Universal) Commit: OS Version: macOS 12.6. Steps to Reproduce: this file: sure it has a extension. all current instances of VS Code it with VS Code with all extensions disabled: around. In a few seconds the editor will lock up. This file has some extremely long lines, around ~65,000. I was under the impression though that VS Code stopped rendering at some cutoff, however. It appears the issue is the syntax highlighting for C#. If I open it as plain text, then I can no longer reproduce the behavior.
Here is a reduced repro: By using the command, I could find that the oniguruma regex engine gets stuck trying to match the regex: which comes from As a workaround, you can reduce the limit for C# files from 20k to something smaller e.g.: We also have the option of reducing C#'s default. We already did that for javascript to 2500.

Related discussion:
text: "update-grammar": "node ../node_modules/vscode-grammar-updater/bin dotnet/csharp-tmLanguage grammars/csharp.tmLanguage ./syntaxes/csharp.tmLanguage.json" }, "contributes": { <ins> "configurationDefaults": { "[csharp]": { "editor.maxTokenizationLineLength": 2500 } }, </ins> "languages": [ { "id": "csharp",
Code change:
Repo explorer, collapse the timeline view a breakpoint in  window Bug See the breakpoint being hit even through the contents of the timeline are not visible This is caused by this code: It seems to me we should try to defer this work until the view actually becomes visible
would you be willing to verify for completeness?
Works great!

Related discussion:
text: private expandedSize: number | undefined = undefined; private _headerVisible = true; <ins> private _bodyRendered = false; </ins> private _minimumBodySize: number; private _maximumBodySize: number; private _ariaHeaderLabel: string;
Code change:
Repo explorer, collapse the timeline view a breakpoint in  window Bug See the breakpoint being hit even through the contents of the timeline are not visible This is caused by this code: It seems to me we should try to defer this work until the view actually becomes visible
would you be willing to verify for completeness?
Works great!

Related discussion:
text: this.updateHeader(); if (expanded) { <ins> if (!this._bodyRendered) { this.renderBody(this.body); this._bodyRendered = true; } </ins> if (typeof this.animationTimer === 'number') { clearTimeout(this.animationTimer); }
Code change:
Repo explorer, collapse the timeline view a breakpoint in  window Bug See the breakpoint being hit even through the contents of the timeline are not visible This is caused by this code: It seems to me we should try to defer this work until the view actually becomes visible
would you be willing to verify for completeness?
Works great!

Related discussion:
text: }); this.body = append(this.element, $('.pane-body')); <del> this.renderBody(this.body); </del> <ins> // Only render the body if it will be visible // Otherwise, render it when the pane is expanded if (!this._bodyRendered && this.isExpanded()) { this.renderBody(this.body); this._bodyRendered = true; } </ins> if (!this.isExpanded()) { this.body.remove();
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.2 OS Version: macOS Montery 12.6 Steps to Reproduce: merge editor while rebasing on a branch with a lot of branch pointers or ones with a long name The text from the "Current" column overlaps into the "Incoming" column. Confirmed that it happens with the default theme as well. !
Please try out the latest insiders, this should be fixed.
Still appears to be an issue in the latest insiders ! !

Related discussion:
text: readonly model = this.viewModel.map(m => /** @description model */ m?.model); protected readonly htmlElements = h('div.code-view', [ <del> h('div.title@header', [ </del> <ins> h('div.header@header', [ </ins> h('span.title@title'), h('span.description@description'), h('span.detail@detail'),
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.2 OS Version: macOS Montery 12.6 Steps to Reproduce: merge editor while rebasing on a branch with a lot of branch pointers or ones with a long name The text from the "Current" column overlaps into the "Incoming" column. Confirmed that it happens with the default theme as well. !
Please try out the latest insiders, this should be fixed.
Still appears to be an issue in the latest insiders ! !

Related discussion:
text: *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> .monaco-workbench .merge-editor .code-view>.title { </del> <ins> .monaco-workbench .merge-editor .code-view > .header { </ins> padding: 0 10px; height: 30px; display: flex; align-content: center; <ins> overflow: hidden; </ins> } <del> .monaco-workbench .merge-editor .code-view>.title>SPAN { </del> <ins> .monaco-workbench .merge-editor .code-view > .header > span { </ins> align-self: center; text-overflow: ellipsis; overflow: hidden;
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.2 OS Version: macOS Montery 12.6 Steps to Reproduce: merge editor while rebasing on a branch with a lot of branch pointers or ones with a long name The text from the "Current" column overlaps into the "Incoming" column. Confirmed that it happens with the default theme as well. !
Please try out the latest insiders, this should be fixed.
Still appears to be an issue in the latest insiders ! !

Related discussion:
text: color: var(--vscode-editorCodeLens-foreground) } <del> .merge-editor-conflict-actions>span, .merge-editor-conflict-actions>a { </del> <ins> .merge-editor-conflict-actions > span, .merge-editor-conflict-actions > a { </ins> user-select: none; -webkit-user-select: none; white-space: nowrap; } <del> .merge-editor-conflict-actions>a { </del> <ins> .merge-editor-conflict-actions > a { </ins> text-decoration: none; } <del> .merge-editor-conflict-actions>a:hover { </del> <ins> .merge-editor-conflict-actions > a:hover { </ins> cursor: pointer; color: var(--vscode-editorLink-activeForeground) !important; } <del> .merge-editor-conflict-actions>a:hover .codicon { </del> <ins> .merge-editor-conflict-actions > a:hover .codicon { </ins> color: var(--vscode-editorLink-activeForeground) !important; }
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.2 OS Version: macOS Montery 12.6 Steps to Reproduce: merge editor while rebasing on a branch with a lot of branch pointers or ones with a long name The text from the "Current" column overlaps into the "Incoming" column. Confirmed that it happens with the default theme as well. !
Please try out the latest insiders, this should be fixed.
Still appears to be an issue in the latest insiders ! !

Related discussion:
text: color: var(--vscode-editorCodeLens-foreground); } <del> .merge-editor-conflict-actions>a:hover .codicon::before { </del> <ins> .merge-editor-conflict-actions > a:hover .codicon::before { </ins> cursor: pointer; }
Code change:
These are a few more unused exports which git blame says have been around since Hello Code, based on I removed a few false positives which are indirectly referenced through the public api exported from these files and which therefore should probably remain public for consumers

Related discussion:
text: import { $, addDisposableListener, append, EventHelper, EventType } from 'vs/base/browser/dom'; import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent'; import { EventType as GestureEventType, Gesture } from 'vs/base/browser/touch'; <del> import { AnchorAlignment, IAnchor, IContextViewProvider } from 'vs/base/browser/ui/contextview/contextview'; </del> <ins> import { AnchorAlignment } from 'vs/base/browser/ui/contextview/contextview'; </ins> import { IMenuOptions } from 'vs/base/browser/ui/menu/menu'; import { ActionRunner, IAction } from 'vs/base/common/actions'; import { Emitter } from 'vs/base/common/event';
Code change:
These are a few more unused exports which git blame says have been around since Hello Code, based on I removed a few false positives which are indirectly referenced through the public api exported from these files and which therefore should probably remain public for consumers

Related discussion:
text: (container: HTMLElement): IDisposable | null; } <del> export interface IBaseDropdownOptions { </del> <ins> interface IBaseDropdownOptions { </ins> label?: string; labelRenderer?: ILabelRenderer; } <del> export class BaseDropdown extends ActionRunner { </del> <ins> class BaseDropdown extends ActionRunner { </ins> private _element: HTMLElement; private boxContainer?: HTMLElement; private _label?: HTMLElement;
Code change:
These are a few more unused exports which git blame says have been around since Hello Code, based on I removed a few false positives which are indirectly referenced through the public api exported from these files and which therefore should probably remain public for consumers

Related discussion:
text: } } <del> export interface IDropdownOptions extends IBaseDropdownOptions { contextViewProvider: IContextViewProvider; } export class Dropdown extends BaseDropdown { private contextViewProvider: IContextViewProvider; constructor(container: HTMLElement, options: IDropdownOptions) { super(container, options); this.contextViewProvider = options.contextViewProvider; } override show(): void { super.show(); this.element.classList.add('active'); this.contextViewProvider.showContextView({ getAnchor: () => this.getAnchor(), render: (container) => { return this.renderContents(container); }, onDOMEvent: (e, activeElement) => { this.onEvent(e, activeElement); }, onHide: () => this.onHide() }); } protected getAnchor(): HTMLElement | IAnchor { return this.element; } protected onHide(): void { this.element.classList.remove('active'); } override hide(): void { super.hide(); this.contextViewProvider?.hideContextView(); } protected renderContents(container: HTMLElement): IDisposable | null { return null; } } </del> export interface IActionProvider { getActions(): readonly IAction[]; }
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.0-insider OS Version: KDE Neon 5.26.2 Steps to Reproduce: to settings (UI). for "duplicate". "Explorer: Incremental Naming" to . the file explorer, hold down the key (to copy a file instead of moving) and drag a file to the same directory. Actual result: VSCode hangs until I am presented the "This window is not responding" dialg. Clicking has the same effect as . Expected result: I am telling VSCode to duplicate a file, while I have taken away its algorithm to automatically create new file names. Therefore I might expect VSCode to show a dialog with a text input. The text input would contain the file's current name, which I can alter. Confirming the dialog would copy the file using the new name. Or something to this effect. But maybe that solution is trying to counter a symptom rather than solving the root of the problem. Because how would should VSCode respond when drag-copying multiple files? Maybe the root of the problem is the ability to set "Explorer: Incremental Naming" to in the first place. Maybe VSCode must always have a 'duplicate file naming algorithm' in order to function? Even if it is a one. Removing and using the algorithm as a bare minimum would surely fix the problem. Addendum: The description of states the user "will be prompted to override the existing file". So this might be the expected / intended result.

Related discussion:
text: target = element.isDirectory ? element : element.parent!; } <del> const targetFile = findValidPasteFileTarget(explorerService, target, { resource: fileToPaste, isDirectory: fileToPasteStat.isDirectory, allowOverwrite: pasteShouldMove || incrementalNaming === 'disabled' }, incrementalNaming); if (incrementalNaming === 'disabled') { const canOverwrite = await askForOverwrite(fileService, dialogService, targetFile); if (!canOverwrite) { return; } </del> <ins> const targetFile = await findValidPasteFileTarget( explorerService, fileService, dialogService, target, { resource: fileToPaste, isDirectory: fileToPasteStat.isDirectory, allowOverwrite: pasteShouldMove || incrementalNaming === 'disabled' }, incrementalNaming ); if (!targetFile) { return undefined; </ins> } return { source: fileToPaste, target: targetFile };
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.0-insider OS Version: KDE Neon 5.26.2 Steps to Reproduce: to settings (UI). for "duplicate". "Explorer: Incremental Naming" to . the file explorer, hold down the key (to copy a file instead of moving) and drag a file to the same directory. Actual result: VSCode hangs until I am presented the "This window is not responding" dialg. Clicking has the same effect as . Expected result: I am telling VSCode to duplicate a file, while I have taken away its algorithm to automatically create new file names. Therefore I might expect VSCode to show a dialog with a text input. The text input would contain the file's current name, which I can alter. Confirming the dialog would copy the file using the new name. Or something to this effect. But maybe that solution is trying to counter a symptom rather than solving the root of the problem. Because how would should VSCode respond when drag-copying multiple files? Maybe the root of the problem is the ability to set "Explorer: Incremental Naming" to in the first place. Maybe VSCode must always have a 'duplicate file naming algorithm' in order to function? Even if it is a one. Removing and using the algorithm as a bare minimum would surely fix the problem. Addendum: The description of states the user "will be prompted to override the existing file". So this might be the expected / intended result.

Related discussion:
text: if (sourceTargetPairs.length >= 1) { // Move/Copy File if (pasteShouldMove) { <del> const resourceFileEdits = sourceTargetPairs.map(pair => new ResourceFileEdit(pair.source, pair.target)); </del> <ins> const resourceFileEdits = sourceTargetPairs.map(pair => new ResourceFileEdit(pair.source, pair.target, { overwrite: incrementalNaming === 'disabled' })); </ins> const options = { confirmBeforeUndo: configurationService.getValue<IFilesConfiguration>().explorer.confirmUndo === UndoConfirmLevel.Verbose, progressLabel: sourceTargetPairs.length > 1 ? nls.localize({ key: 'movingBulkEdit', comment: ['Placeholder will be replaced by the number of files being moved'] }, "Moving {0} files", sourceTargetPairs.length)
Code change:
I noticed that there are a couple colors here that are available in : ! but the rest of the colors are available in the monaco workbench : ! these probably should be with the others. possible code pointer:

Related discussion:
text: .monaco-workbench .notebookOverlay .output { position: absolute; height: 0px; <del> font-size: var(--notebook-cell-output-font-size); </del> user-select: text; -webkit-user-select: text; cursor: auto;
Code change:
I noticed that there are a couple colors here that are available in : ! but the rest of the colors are available in the monaco workbench : ! these probably should be with the others. possible code pointer:

Related discussion:
text: insertToolbarPosition, insertToolbarAlignment, fontSize, <ins> outputFontSize, </ins> focusIndicatorLeftMargin, focusIndicatorGap } = this._notebookOptions.getLayoutConfiguration();
Code change:
I noticed that there are a couple colors here that are available in : ! but the rest of the colors are available in the monaco workbench : ! these probably should be with the others. possible code pointer:

Related discussion:
text: const fontFamily = this._generateFontFamily(); styleSheets.push(` <del> :root { --notebook-cell-output-font-size: ${fontSize}px; --notebook-cell-output-font-family: ${fontFamily}; </del> <ins> .notebook-editor { --notebook-cell-output-font-size: ${outputFontSize}px; </ins> --notebook-cell-input-preview-font-size: ${fontSize}px; --notebook-cell-input-preview-font-family: ${fontFamily}; }