Code change:
Version: 1.58.0-insider Commit: Date: 2021-06-16T05:18:57.982Z Electron: 12.0.11 Chrome: 89.0.4389.128 14.16.0 V8: 8.9.255.25-electron.0 OS: Linux x64 5.11.0-18-generic After starting up VS Code I got a modal dialog telling me about an unusual line delimiter. It didn't tell me about the file this is about. ! After accepting to fix, I saw where the problem was ! I find the dialog too heavy, especially on startup. I would need to see the code to find out what's the issue here. E.g. in our case, this is in a test, so might be intended Maybe have a warning triage next to 'LF' in the status bar? When I click ignore for this file, how can I unignore the file?
I agree this is pretty weird. The prompt comes from a code editor contribution which executes only when a code editor widget is instantiated and shows the problematic file. I think that this normally works fine, but in this case I believe the problematic file was opened, the dialog was shown, and then the "Release Notes" editor opened under the prompt and changed the active editor from under the prompt. I agree with the feedback here, but I'm not sure what to do. Maybe we could make the "Release Notes" editor wait until all confirm dialogs have been closed before showing itself or that the workbench starts directly with that editor after a release? Regarding converting this to a passive indicator in the status bar: I don't think that would be wise. Having this unusual line terminator will lead to semantic tokens, jump to definition and all kind of language features to become off. Here is the background:
Maybe instead of a modal dialog this could be shown somewhere in the editor area? Almost like the trust banner but instead of showing to the top of the window, showing right above the editor but still inside the editor? ! As for release notes, I think we are investigating to move away from using an editor and using something else but I cannot find the issue now. Arguably this can happen in other cases too I guess, e.g. when I open a file which loads slow and I manage to open another editor over it?
Well, easiest fix is to add the file name into the dialog, I would argue then it doesn't really matter which editor is active.
PR is up to change the dialog just a bit (): !

Related discussion:
text: const result = await this._dialogService.confirm({ title: nls.localize('unusualLineTerminators.title', "Unusual Line Terminators"), message: nls.localize('unusualLineTerminators.message', "Detected unusual line terminators"), <del> detail: nls.localize('unusualLineTerminators.detail', "This file contains one or more unusual line terminator characters, like Line Separator (LS) or Paragraph Separator (PS).nnIt is recommended to remove them from the file. This can be configured via `editor.unusualLineTerminators`."), primaryButton: nls.localize('unusualLineTerminators.fix', "Fix this file"), secondaryButton: nls.localize('unusualLineTerminators.ignore', "Ignore problem for this file") </del> <ins> detail: nls.localize('unusualLineTerminators.detail', "The file '{0}' contains one or more unusual line terminator characters, like Line Separator (LS) or Paragraph Separator (PS).nnIt is recommended to remove them from the file. This can be configured via `editor.unusualLineTerminators`.", basename(model.uri)), primaryButton: nls.localize('unusualLineTerminators.fix', "Remove Unusual Line Terminators"), secondaryButton: nls.localize('unusualLineTerminators.ignore', "Ignore") </ins> }); if (!result.confirmed) {