jiebi/CodeConvo huggingface dataset:
Code change:
Ref: I would expect the comment editor to behave just like a regular editor window, but in my case it is not. I don't hear screen reader feedback as I move through words and lines with the keyboard. Also, when I press a routing cursor key on my braille display, it does not move the cursor to the desired character. Tested with NVDA and JAWS. Invoke the action to leave a comment in the current line Write some text Use ctrl+left and ctrl+right to move through words Use up and down arrow keys to move through lines If you have a braille display with routing keys, press a routing cursor key to move to a specific character in the text

Related discussion:
text: @IContextKeyService contextKeyService: IContextKeyService, @IConfigurationService private readonly configurationService: IConfigurationService ) { <del> super(editor, { keepEditorSelection: true }); </del> <ins> super(editor, { keepEditorSelection: true, isAccessible: true }); </ins> this._contextKeyService = contextKeyService.createScoped(this.domNode); this._scopedInstantiationService = instantiationService.createChild(new ServiceCollection(
Code change:
Ref: I would expect the comment editor to behave just like a regular editor window, but in my case it is not. I don't hear screen reader feedback as I move through words and lines with the keyboard. Also, when I press a routing cursor key on my braille display, it does not move the cursor to the desired character. Tested with NVDA and JAWS. Invoke the action to leave a comment in the current line Write some text Use ctrl+left and ctrl+right to move through words Use up and down arrow keys to move through lines If you have a braille display with routing keys, press a routing cursor key to move to a specific character in the text

Related discussion:
text: enabled: false }, autoClosingBrackets: configurationService.getValue('editor.autoClosingBrackets'), <del> quickSuggestions: false </del> <ins> quickSuggestions: false, accessibilitySupport: configurationService.getValue<'auto' | 'off' | 'on'>('editor.accessibilitySupport'), </ins> }; } }
Code change:
The issue is that when I resize the page to see it along with other content, I can see some text over the scroll page area. I think it wasn't supposed to work like this, that's why i'm reporting it here. ! ! .
The scrollbar is intentionally transparent. We have a color that is used only when the minimap is enabled. We could potentially use it always if set to allow defining opaque scrollbars.
Oh. Thank you for explaining :) In this case, sorry for bothering! Best, Alvaro
To verify, configure the color and that will be applied and will make the overview ruler opaque. e.g.

Related discussion:
text: const minimapOpts = options.get(EditorOption.minimap); const minimapEnabled = minimapOpts.enabled; const minimapSide = minimapOpts.side; <del> const backgroundColor = minimapEnabled ? theme.getColor(editorOverviewRulerBackground) || TokenizationRegistry.getDefaultBackground() : null; </del> <ins> const themeColor = theme.getColor(editorOverviewRulerBackground); const defaultBackground = TokenizationRegistry.getDefaultBackground(); let backgroundColor: Color | null = null; if (themeColor !== undefined) { backgroundColor = themeColor; } else if (minimapEnabled) { backgroundColor = defaultBackground; } </ins> if (backgroundColor === null || minimapSide === 'left') { this.backgroundColor = null;
Code change:
Import following settings profile Timeline and Outline views are not updated. Refreshing the window updates the views. Expected that Timeline and Outline views shall be moved together into sidebar as a separate viewlet
Reopening this and making this a dup of because this is not completely fixed.
/duplicate

Related discussion:
text: this._register(this.extensionService.onDidRegisterExtensions(() => this.onDidRegisterExtensions())); <ins> // Cached View Containers Locations should be registered before Cached View Positions // Because View Containers cache should be updated first because View Positions Cache depends on View Containers Cache if views are moved to generated view containers </ins> Registry.as<IProfileStorageRegistry>(Extensions.ProfileStorageRegistry) .registerKeys([{ <del> key: ViewDescriptorService.CACHED_VIEW_POSITIONS, description: localize('cachedViewPositions', "View locations customizations"), }, { </del> key: ViewDescriptorService.CACHED_VIEW_CONTAINER_LOCATIONS, description: localize('cachedViewContainerPositions', "View Container locations customizations"), <ins> }, { key: ViewDescriptorService.CACHED_VIEW_POSITIONS, description: localize('cachedViewPositions', "View locations customizations"), </ins> }]); }
Code change:
Issue Type: <bBug</bany command line run or pipe another process that runs indefinitely to that a window does not open and the command does not return. The file should open and update as new data is piped to the code cli command. This works on the Mac when you run but does not work on Windows. This is not a 1.67.0 regression VS Code version: Code 1.67.0 (, 2022-05-04T12:06:02.889Z) OS version: Windows_NT x64 10.0. Restricted Mode: No <!-- generated by issue reporter --
This is probably related to the file watcher not recognizing changes to the file on Windows, have to debug why that is the case but might be a limitation of the single file watcher.
The underlying reason seems to be that writing to a file via stream API where the file handle is not closed does not trigger file events on Windows at least. Maybe as a workaround we have to use the less efficient method that opens a file handle each time and closes it.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
I am still experiencing this issue on the version of insiders below. Version: 1.69.0-insider (user setup) Commit: Date: 2022-06-24T06:32:08.615Z (13 hrs ago) Electron: 18.3.4 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0.
Here is how to verify: ensure you are on latest insiders from a terminal on Windows run verify output is updated
I tried on the latest insiders with that command and vscode-insiders still does not not open for me. If I run it hangs and never opens vscode-insiders If I run without the -t flag, it will open after the command completes. Version: 1.69.0-insider (user setup) Commit: Date: 2022-06-27T07:59:47.622Z (10 hrs ago) Electron: 18.3.5 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0.
This works for me on Windows 11 with both Powershell and , but may need further investigation

Related discussion:
text: *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { createWriteStream } from 'fs'; </del> import { tmpdir } from 'os'; <ins> import { Queue } from 'vs/base/common/async'; </ins> import { randomPath } from 'vs/base/common/extpath'; <ins> import { Promises } from 'vs/base/node/pfs'; </ins> import { resolveTerminalEncoding } from 'vs/base/node/terminalEncoding'; export function hasStdinWithoutTty() {
Code change:
Issue Type: <bBug</bany command line run or pipe another process that runs indefinitely to that a window does not open and the command does not return. The file should open and update as new data is piped to the code cli command. This works on the Mac when you run but does not work on Windows. This is not a 1.67.0 regression VS Code version: Code 1.67.0 (, 2022-05-04T12:06:02.889Z) OS version: Windows_NT x64 10.0. Restricted Mode: No <!-- generated by issue reporter --
This is probably related to the file watcher not recognizing changes to the file on Windows, have to debug why that is the case but might be a limitation of the single file watcher.
The underlying reason seems to be that writing to a file via stream API where the file handle is not closed does not trigger file events on Windows at least. Maybe as a workaround we have to use the less efficient method that opens a file handle each time and closes it.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
I am still experiencing this issue on the version of insiders below. Version: 1.69.0-insider (user setup) Commit: Date: 2022-06-24T06:32:08.615Z (13 hrs ago) Electron: 18.3.4 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0.
Here is how to verify: ensure you are on latest insiders from a terminal on Windows run verify output is updated
I tried on the latest insiders with that command and vscode-insiders still does not not open for me. If I run it hangs and never opens vscode-insiders If I run without the -t flag, it will open after the command completes. Version: 1.69.0-insider (user setup) Commit: Date: 2022-06-27T07:59:47.622Z (10 hrs ago) Electron: 18.3.5 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0.
This works for me on Windows 11 with both Powershell and , but may need further investigation

Related discussion:
text: } export async function readFromStdin(targetPath: string, verbose: boolean): Promise<void> { <del> // open tmp file for writing const stdinFileStream = createWriteStream(targetPath); </del> let encoding = await resolveTerminalEncoding(verbose); const iconv = await import('@vscode/iconv-lite-umd');
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Same issue as , the tag is being to the repository again. Breaking automated tools like Renovate Bot thinking that there is a new version to update. <img width="934" alt="image" src="https://user-"
Is there a way a GitHub action could help identify who pushed the tag and delete the tag automatically? /cc
We can id the tag and ping the creator, we don't give our Actions git write access so can't go and delete the tag automatically.
Deleted tag manually, action to ping the pusher upon pushing it back to the repo.

Related discussion:
text: <ins> name: Bad Tag on: create jobs: main: runs-on: ubuntu-latest if: github.event.ref == '1.999.0' steps: - name: Checkout Actions uses: actions/checkout@v2 with: repository: "microsoft/vscode-github-triage-actions" ref: stable path: ./actions - name: Install Actions run: npm install --production --prefix ./actions - name: Run Bad Tag uses: ./actions/tag-alert with: token: ${{secrets.VSCODE_ISSUE_TRIAGE_BOT_PAT}} tag-name: '1.999.0' </ins>
Code change:
Issue Type: <bBug</brun in the terminal where is the path to an existing directory see VSCode open the workspace as expected run in the terminal where is the path to an existing directory focus changes back to VSCode, but showing the window for project instead of project Here is a movie of the experience: ! In previous versions of VSCode, when opening a new project with , the new window would show up above any existing windows. This is what I expected to happen. VS Code version: Code 1.67.1 (, 2022-05-06T12:37:14.619Z) OS version: Darwin arm64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (17)</summaryExtensionVersion ------ vscode-tailwindcss0.8.3 vscode-eslint2.2.2 copilot1.19.5865 go0.33.0 terraform2.22.0 vscode-env0.1.0 jsonnet-language1.0.0 vscode-docker1.22.0 python2022.6.2 vscode-pylance2022.5.1 remote-containers0.234.0 remote-ssh0.80.0 remote-ssh-edit0.80.0 excalidraw-editor2.0.16 code-spell-checker2.1.11 svelte-vscode105.16.0 cython0.1.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Looks similar to and .
Same issue. On Mac OS, VsCode 1.67 How to reproduce: shortcut to open new window <kbdCMD</kbd+ <kbdSHIFT</kbd+ <kbdN</kbdshortcut to open new file/folder <kbdCMD</kbd+ <kbdO</kbdThe selected file/folder is now opened in the previously focused vscode window instead of the newly opened one. To solve the problem, you have to think to click in the newly opened window. When you do so, you see the focus takes effect, proving the window was not actually focused (EDIT: What is confusing is that you can see the cursor blinking inside of the editor of the new window, even though it is not focused) I can tell this is a relatively new issue (1 or 2 months max), because I'm doing the procedure above almost every day and it has been pissing me off since then (sorry, but truly annoying).
Sounds a bit like or
Do you have configured?
This is a regression from
Thanks for the fix!

Related discussion:
text: this.setFullScreen(true); } <del> if (!this._win.isVisible()) { </del> <ins> if ( !this._win.isVisible() || // TODO@electron: Required condition ever since https://github.com/electron/electron/pull/33536 // landed in Electron 17.4.2: calling `window.maximize()` on macOS will wrongly result in // `window.isVisible()` to return `true` even though a different window might still be on top. // As such, we also need to ask for `window.isFocused()` which on macOS will ask whether the // window is a "key" window. (isMacintosh && !this._win.isFocused()) ) { </ins> this._win.show(); // to reduce flicker from the default window size to maximize, we only show after maximize } mark('code/didMaximizeCodeWindow');
Code change:
Issue Type: <bBug</brun in the terminal where is the path to an existing directory see VSCode open the workspace as expected run in the terminal where is the path to an existing directory focus changes back to VSCode, but showing the window for project instead of project Here is a movie of the experience: ! In previous versions of VSCode, when opening a new project with , the new window would show up above any existing windows. This is what I expected to happen. VS Code version: Code 1.67.1 (, 2022-05-06T12:37:14.619Z) OS version: Darwin arm64 20.6.0 Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (17)</summaryExtensionVersion ------ vscode-tailwindcss0.8.3 vscode-eslint2.2.2 copilot1.19.5865 go0.33.0 terraform2.22.0 vscode-env0.1.0 jsonnet-language1.0.0 vscode-docker1.22.0 python2022.6.2 vscode-pylance2022.5.1 remote-containers0.234.0 remote-ssh0.80.0 remote-ssh-edit0.80.0 excalidraw-editor2.0.16 code-spell-checker2.1.11 svelte-vscode105.16.0 cython0.1.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Looks similar to and .
Same issue. On Mac OS, VsCode 1.67 How to reproduce: shortcut to open new window <kbdCMD</kbd+ <kbdSHIFT</kbd+ <kbdN</kbdshortcut to open new file/folder <kbdCMD</kbd+ <kbdO</kbdThe selected file/folder is now opened in the previously focused vscode window instead of the newly opened one. To solve the problem, you have to think to click in the newly opened window. When you do so, you see the focus takes effect, proving the window was not actually focused (EDIT: What is confusing is that you can see the cursor blinking inside of the editor of the new window, even though it is not focused) I can tell this is a relatively new issue (1 or 2 months max), because I'm doing the procedure above almost every day and it has been pissing me off since then (sorry, but truly annoying).
Sounds a bit like or
Do you have configured?
This is a regression from
Thanks for the fix!

Related discussion:
text: this.focus({ force: true }); this._win.webContents.openDevTools(); } }, 10000)).schedule(); }
Code change:
https://user- Steps to Reproduce: the panel, see the comments tab the comments tab, reload the window :bug: comments panel keeps re-appearing Version: 1.68.0-insider (Universal) Commit: Date: 2022-05-13T17:25:40.854Z Electron: 17.4.3 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Darwin arm64 21.4.0
does the file you have open have a comment in it? We show the comments view the first time you open a file that contains comments (once per reload).
no comments, regardless of what workspace I am in it always appears (even in an empty workspace) <img width="475" alt="CleanShot 2022-05-31 at 08 10 17 src="https://user-"
I'm not sure what's going on here, maybe you know. The Comments view is actually registered with , so I'm surprised it's even possible to hide the view. Is there anything else I need to do to prevent it from hiding or, even better, to respect the hide after reload?
The action takes is hiding the View Container so that's why it is hideable. There isn't anything that you can set on the View Container to prevent the hiding. I am also at a loss. can you "Export Settings as a Profile"? the profile should have the stored information about your views and view containers
hmm I don't see anything alarming in there, but I can now reproduce it ... but I don't get it in an empty workspace
is there any logging that can be in views to help narrow this down? I don't think there's anything else I can do from comments.
after lots of debugging, I think I have a fairly simple fix in the PR above.

Related discussion:
text: const viewContainerModel = this.viewDescriptorService.getViewContainerModel(viewContainer); state.push({ id: compositeItem.id, name: viewContainerModel.title, pinned: compositeItem.pinned, order: compositeItem.order, visible: compositeItem.visible }); placeholders.push({ id: compositeItem.id, name: this.getCompositeActions(compositeItem.id).activityAction.label }); <ins> } else { state.push({ id: compositeItem.id, name: compositeItem.name, pinned: compositeItem.pinned, order: compositeItem.order, visible: compositeItem.visible }); </ins> } }
Code change:
I am the maintainer of VS Code basic latex language support. The language defines / as a bracket pair. This leads to wrongly highlight <img width="415" alt="Capture d’écran 2022-05-26 à 08 07 09" src="https://user-"I believe this is related to fixed it in by surrounding brackets using letters only with . However, in LaTeX every command starts with and the fix does not apply. This issue occurs on Version: 1.67.2 and also on Version: 1.68.0-insider (Universal) Commit: Date: 2022-05-25T05:16:10.689Z Electron: 17.4.4 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Darwin x64 21.5.0 This problem was originally reported at
should be extended to check if the bracket starts/ends with a word. Only at those borders, should be . Should be easy to implement. I'm open for a PR here ;)
hey I am a beginner in open source contributions . Could you please guide me how too start contributing
I'd start here:
Hi I'm just starting out with open source contributions and just finished reading the how to guide you linked in this thread. I'm having some trouble understanding exactly what the issue is, could you please explain it a bit more? Is rangledot supposed to be highlighted as a whole?
This issue is actually already handled by PR , which will be merged for the July 2022 release.
Verification steps: Install the LaTeX extension Verify that and is matched, but not with in
I would personally highly go against this fix As it would disallow word based brackets inside word strings with no alternative (other than to reinvent the bracket highlighter again) I have no example of any language being affected But I would question the arbitration decesion to limit such function Instead, I think LaTeX should fix their bug (which was present before coloured brackets) by just disallowing/allowing certain word based bracket scopes via the and sections in !
Let's discuss this in a separate issue once this actually is a problem!

Related discussion:
text: } function prepareBracketForRegExp(str: string): string { <del> const escaped = escapeRegExpCharacters(str); // This bracket pair uses letters like e.g. "begin" - "end" (see https://github.com/microsoft/vscode/issues/132162) const needsWordBoundaries = (/^[w ]+$/.test(str)); return (needsWordBoundaries ? `b${escaped}b` : escaped); </del> <ins> let escaped = escapeRegExpCharacters(str); // These bracket pair delimiters start or end with letters // see https://github.com/microsoft/vscode/issues/132162 https://github.com/microsoft/vscode/issues/150440 if (/^[w ]+/.test(str)) { escaped = `b${escaped}`; } if (/[w ]+$/.test(str)) { escaped = `${escaped}b`; } return escaped; </ins> } export class LanguageAgnosticBracketTokens {
Code change:
Testing Version: 1.68.0-insider (user setup) Commit: Date: 2022-05-31T05:17:04.479Z Run the command and select Would be nice to get a message in the log
Looks like the the message is not shown as it is of type and is less than than. Would be good to always show it, regardless of the current and the new level. Same problem with the initial message when the output is started.

Related discussion:
text: return; } <del> this.outputChannelLogger.setLogLevel(choice.logLevel); </del> <ins> this.outputChannelLogger.currentLogLevel = choice.logLevel; </ins> } @command('git.refresh', { repository: true })
Code change:
Testing Version: 1.68.0-insider (user setup) Commit: Date: 2022-05-31T05:17:04.479Z Run the command and select Would be nice to get a message in the log
Looks like the the message is not shown as it is of type and is less than than. Would be good to always show it, regardless of the current and the new level. Same problem with the initial message when the output is started.

Related discussion:
text: private _onDidChangeLogLevel = new EventEmitter<LogLevel>(); readonly onDidChangeLogLevel: Event<LogLevel> = this._onDidChangeLogLevel.event; <del> private _currentLogLevel: LogLevel; </del> <ins> private _currentLogLevel!: LogLevel; </ins> get currentLogLevel(): LogLevel { return this._currentLogLevel; } <ins> set currentLogLevel(value: LogLevel) { if (this._currentLogLevel === value) { return; } this._currentLogLevel = value; this._onDidChangeLogLevel.fire(value); this.log(localize('gitLogLevel', "Log level: {0}", LogLevel[value])); } </ins> <del> private _defaultLogLevel: LogLevel; </del> <ins> private _defaultLogLevel!: LogLevel; </ins> get defaultLogLevel(): LogLevel { return this._defaultLogLevel; }