jiebi/CodeConvo huggingface dataset:
Code change:
Snippets that use the SELECTION variable should be grouped into a new "Surround With..."-command, e.g support selection with try-catch or if-else. We should also consider not showing such snippets in IntelliSense because the selection is always where users are typing.
closing this in favour of
After and given that a dedicated command is more visible we should add this
hi, Thanks for your adding support for outside code and could please add some identification for those snippet support and/or when users are using command e.g.: when using insert snippet, users never know which snippet is outside-code supported there is the ui: ! and the snippet code from C# official extension ! for that reason, I have to add some tip/text for the name of snippet when I develop the snippet extension. after that, user could know that which is outside code supported. ! I could do it for myself and my extension, I there are many snippets that have no tip or identification Please add some identification for those outside code supported in UI when users using insert snippet. that will be useful and helpful for user to distinguish
! maybe some icon for text is good
BTW, there is another issues related to this. please
hi, should I file a new issue?
To verify open a typescript files select some code select F1 Surround with Snippet try-catch ensure the selected code is surrounded by the snippet
Verification looked good with both TS and CS files.

Related discussion:
text: import { EditorContextKeys } from 'vs/editor/common/editorContextKeys'; import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { Snippet, SnippetSource } from 'vs/workbench/contrib/snippets/browser/snippetsFile'; <del> import { IQuickPickItem, IQuickInputService, QuickPickInput } from 'vs/platform/quickinput/common/quickInput'; </del> import { IClipboardService } from 'vs/platform/clipboard/common/clipboardService'; <del> import { Codicon } from 'vs/base/common/codicons'; import { Event } from 'vs/base/common/event'; </del> <ins> import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { pickSnippet } from 'vs/workbench/contrib/snippets/browser/snippetPicker'; </ins> class Args {
Code change:
Snippets that use the SELECTION variable should be grouped into a new "Surround With..."-command, e.g support selection with try-catch or if-else. We should also consider not showing such snippets in IntelliSense because the selection is always where users are typing.
closing this in favour of
After and given that a dedicated command is more visible we should add this
hi, Thanks for your adding support for outside code and could please add some identification for those snippet support and/or when users are using command e.g.: when using insert snippet, users never know which snippet is outside-code supported there is the ui: ! and the snippet code from C# official extension ! for that reason, I have to add some tip/text for the name of snippet when I develop the snippet extension. after that, user could know that which is outside code supported. ! I could do it for myself and my extension, I there are many snippets that have no tip or identification Please add some identification for those outside code supported in UI when users using insert snippet. that will be useful and helpful for user to distinguish
! maybe some icon for text is good
BTW, there is another issues related to this. please
hi, should I file a new issue?
To verify open a typescript files select some code select F1 Surround with Snippet try-catch ensure the selected code is surrounded by the snippet
Verification looked good with both TS and CS files.

Related discussion:
text: } const clipboardService = accessor.get(IClipboardService); <del> const quickInputService = accessor.get(IQuickInputService); </del> <ins> const instaService = accessor.get(IInstantiationService); </ins> const snippet = await new Promise<Snippet | undefined>((resolve, reject) => {
Code change:
Snippets that use the SELECTION variable should be grouped into a new "Surround With..."-command, e.g support selection with try-catch or if-else. We should also consider not showing such snippets in IntelliSense because the selection is always where users are typing.
closing this in favour of
After and given that a dedicated command is more visible we should add this
hi, Thanks for your adding support for outside code and could please add some identification for those snippet support and/or when users are using command e.g.: when using insert snippet, users never know which snippet is outside-code supported there is the ui: ! and the snippet code from C# official extension ! for that reason, I have to add some tip/text for the name of snippet when I develop the snippet extension. after that, user could know that which is outside code supported. ! I could do it for myself and my extension, I there are many snippets that have no tip or identification Please add some identification for those outside code supported in UI when users using insert snippet. that will be useful and helpful for user to distinguish
! maybe some icon for text is good
BTW, there is another issues related to this. please
hi, should I file a new issue?
To verify open a typescript files select some code select F1 Surround with Snippet try-catch ensure the selected code is surrounded by the snippet
Verification looked good with both TS and CS files.

Related discussion:
text: } else { // let user pick a snippet <del> resolve(this._pickSnippet(snippetService, quickInputService, languageId)); </del> <ins> resolve(instaService.invokeFunction(pickSnippet, languageId)); </ins> } });
Code change:
Snippets that use the SELECTION variable should be grouped into a new "Surround With..."-command, e.g support selection with try-catch or if-else. We should also consider not showing such snippets in IntelliSense because the selection is always where users are typing.
closing this in favour of
After and given that a dedicated command is more visible we should add this
hi, Thanks for your adding support for outside code and could please add some identification for those snippet support and/or when users are using command e.g.: when using insert snippet, users never know which snippet is outside-code supported there is the ui: ! and the snippet code from C# official extension ! for that reason, I have to add some tip/text for the name of snippet when I develop the snippet extension. after that, user could know that which is outside code supported. ! I could do it for myself and my extension, I there are many snippets that have no tip or identification Please add some identification for those outside code supported in UI when users using insert snippet. that will be useful and helpful for user to distinguish
! maybe some icon for text is good
BTW, there is another issues related to this. please
hi, should I file a new issue?
To verify open a typescript files select some code select F1 Surround with Snippet try-catch ensure the selected code is surrounded by the snippet
Verification looked good with both TS and CS files.

Related discussion:
text: readonly codeSnippet: string; readonly isBogous: boolean; readonly needsClipboard: boolean; <ins> readonly usesSelection: boolean; </ins> constructor(body: string) { // init with defaults this.isBogous = false; this.needsClipboard = false; <ins> this.usesSelection = false; </ins> this.codeSnippet = body; // check snippet...
Code change:
Snippets that use the SELECTION variable should be grouped into a new "Surround With..."-command, e.g support selection with try-catch or if-else. We should also consider not showing such snippets in IntelliSense because the selection is always where users are typing.
closing this in favour of
After and given that a dedicated command is more visible we should add this
hi, Thanks for your adding support for outside code and could please add some identification for those snippet support and/or when users are using command e.g.: when using insert snippet, users never know which snippet is outside-code supported there is the ui: ! and the snippet code from C# official extension ! for that reason, I have to add some tip/text for the name of snippet when I develop the snippet extension. after that, user could know that which is outside code supported. ! I could do it for myself and my extension, I there are many snippets that have no tip or identification Please add some identification for those outside code supported in UI when users using insert snippet. that will be useful and helpful for user to distinguish
! maybe some icon for text is good
BTW, there is another issues related to this. please
hi, should I file a new issue?
To verify open a typescript files select some code select F1 Surround with Snippet try-catch ensure the selected code is surrounded by the snippet
Verification looked good with both TS and CS files.

Related discussion:
text: this.isBogous = true; } <del> if (marker.name === 'CLIPBOARD') { this.needsClipboard = true; </del> <ins> switch (marker.name) { case 'CLIPBOARD': this.needsClipboard = true; break; case 'SELECTION': case 'TM_SELECTED_TEXT': this.usesSelection = true; break; </ins> } } else {
Code change:
Snippets that use the SELECTION variable should be grouped into a new "Surround With..."-command, e.g support selection with try-catch or if-else. We should also consider not showing such snippets in IntelliSense because the selection is always where users are typing.
closing this in favour of
After and given that a dedicated command is more visible we should add this
hi, Thanks for your adding support for outside code and could please add some identification for those snippet support and/or when users are using command e.g.: when using insert snippet, users never know which snippet is outside-code supported there is the ui: ! and the snippet code from C# official extension ! for that reason, I have to add some tip/text for the name of snippet when I develop the snippet extension. after that, user could know that which is outside code supported. ! I could do it for myself and my extension, I there are many snippets that have no tip or identification Please add some identification for those outside code supported in UI when users using insert snippet. that will be useful and helpful for user to distinguish
! maybe some icon for text is good
BTW, there is another issues related to this. please
hi, should I file a new issue?
To verify open a typescript files select some code select F1 Surround with Snippet try-catch ensure the selected code is surrounded by the snippet
Verification looked good with both TS and CS files.

Related discussion:
text: return this._bodyInsights.value.needsClipboard; } <ins> get usesSelection(): boolean { return this._bodyInsights.value.usesSelection; } </ins> static compare(a: Snippet, b: Snippet): number { if (a.snippetSource < b.snippetSource) { return -1;
Code change:
Snippets that use the SELECTION variable should be grouped into a new "Surround With..."-command, e.g support selection with try-catch or if-else. We should also consider not showing such snippets in IntelliSense because the selection is always where users are typing.
closing this in favour of
After and given that a dedicated command is more visible we should add this
hi, Thanks for your adding support for outside code and could please add some identification for those snippet support and/or when users are using command e.g.: when using insert snippet, users never know which snippet is outside-code supported there is the ui: ! and the snippet code from C# official extension ! for that reason, I have to add some tip/text for the name of snippet when I develop the snippet extension. after that, user could know that which is outside code supported. ! I could do it for myself and my extension, I there are many snippets that have no tip or identification Please add some identification for those outside code supported in UI when users using insert snippet. that will be useful and helpful for user to distinguish
! maybe some icon for text is good
BTW, there is another issues related to this. please
hi, should I file a new issue?
To verify open a typescript files select some code select F1 Surround with Snippet try-catch ensure the selected code is surrounded by the snippet
Verification looked good with both TS and CS files.

Related discussion:
text: import 'vs/workbench/contrib/snippets/browser/snippets.contribution'; import 'vs/workbench/contrib/snippets/browser/snippetsService'; import 'vs/workbench/contrib/snippets/browser/insertSnippet'; <ins> import 'vs/workbench/contrib/snippets/browser/surroundWithSnippet'; </ins> import 'vs/workbench/contrib/snippets/browser/configureSnippets'; import 'vs/workbench/contrib/snippets/browser/tabCompletion';
Code change:
<!-- Please search existing issues to avoid creating duplicates. --I noticed in the settings-editor that there are now duplicate clear buttons when the user searches but finds no result. <!-- Describe the feature you'd like. --I propose getting rid of the "Clear Search" text in the bottom left corner as there is now a button in the search bar that achieves the same thing but with less clutter (in my opinion). This change would make the settings-editor more consistent with the keyboard shortcuts tab as well. !
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.464 --<!-- potentialduplicatescomment --
Yeah we can probably just get rid of the text link
What about the "Clear Filters" link? Should there be an extra Clear Filters button that appears in the search bar itself, or let the link stay?
Would you mind sending me a picture of the "Clear Filters" link ? Where exactly is the link ? I will look into this.
! When you use one of the @ filters it appears.
For now I think we can let the 'Clear Filters' link stay. This issue was originally meant to get rid of the duplicates. In another PR I could add a button to the search bar that adds this , and then we could get rid of that link though, although other tabs don't have that sort of button . What do you think ?
Yeah the "Clear Filters" link is all about discoverability and I'd rather leave it

Related discussion:
text: DOM.append(this.noResultsMessage, this.clearFilterLinkContainer); <del> const clearSearchContainer = $('span.clear-search'); clearSearchContainer.textContent = ' - '; const clearSearch = DOM.append(clearSearchContainer, $('a.pointer.prominent', { tabindex: 0 }, localize('clearSearch', 'Clear Search'))); this._register(DOM.addDisposableListener(clearSearch, DOM.EventType.CLICK, (e: MouseEvent) => { DOM.EventHelper.stop(e, false); this.clearSearchResults(); })); DOM.append(this.noResultsMessage, clearSearchContainer); </del> this._register(attachStylerCallback(this.themeService, { editorForeground }, colors => { this.noResultsMessage.style.color = colors.editorForeground ? colors.editorForeground.toString() : null; }));
Code change:
A lot of extensions have configuration code. It is extremely annoying that since some version ago we are unable to copy anything from that pane, mouse or keyboard. Steps to reproduce: Go to extension description Try to copy something Video:
See I'm surprised that you can't copy using the keyboard. What key sequence are you using? What command(s) does your Keyboard Shortcuts page show that bound to?
Im using the usual cmd+c which works in other apps. And cmd+c also works in the editor mode, terminal mode - so i think its not my key bindings customization. I recorded video in presenter mode (displaying what i press) showing copying something else + not working for ext description:

Related discussion:
text: } focus(): void { <del> if (this.activeElement) { this.activeElement.focus(); } </del> <ins> this.activeElement?.focus(); </ins> } showFind(): void { <del> if (this.activeElement && (<Webview>this.activeElement).showFind) { (<Webview>this.activeElement).showFind(); } </del> <ins> this.activeWebview?.showFind(); </ins> } runFindAction(previous: boolean): void { <del> if (this.activeElement && (<Webview>this.activeElement).runFindAction) { (<Webview>this.activeElement).runFindAction(previous); </del> <ins> this.activeWebview?.runFindAction(previous); } public get activeWebview(): Webview | undefined { if (!this.activeElement || !(this.activeElement as Webview).runFindAction) { return undefined; </ins> } <ins> return this.activeElement as Webview; </ins> } private onNavbarChange(extension: IExtension, { id, focus }: { id: string | null, focus: boolean }, template: IExtensionEditorTemplate): void {
Code change:
A lot of extensions have configuration code. It is extremely annoying that since some version ago we are unable to copy anything from that pane, mouse or keyboard. Steps to reproduce: Go to extension description Try to copy something Video:
See I'm surprised that you can't copy using the keyboard. What key sequence are you using? What command(s) does your Keyboard Shortcuts page show that bound to?
Im using the usual cmd+c which works in other apps. And cmd+c also works in the editor mode, terminal mode - so i think its not my key bindings customization. I recorded video in presenter mode (displaying what i press) showing copying something else + not working for ext description:

Related discussion:
text: import { InstallExtensionQuickAccessProvider, ManageExtensionsQuickAccessProvider } from 'vs/workbench/contrib/extensions/browser/extensionsQuickAccess'; import { ExtensionRecommendationsService } from 'vs/workbench/contrib/extensions/browser/extensionRecommendationsService'; import { CONTEXT_SYNC_ENABLEMENT } from 'vs/workbench/services/userDataSync/common/userDataSync'; <ins> import { CopyAction, CutAction, PasteAction } from 'vs/editor/contrib/clipboard/clipboard'; import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; import { MultiCommand } from 'vs/editor/browser/editorExtensions'; import { Webview } from 'vs/workbench/contrib/webview/browser/webview'; </ins> // Singletons registerSingleton(IExtensionsWorkbenchService, ExtensionsWorkbenchService);
Code change:
A lot of extensions have configuration code. It is extremely annoying that since some version ago we are unable to copy anything from that pane, mouse or keyboard. Steps to reproduce: Go to extension description Try to copy something Video:
See I'm surprised that you can't copy using the keyboard. What key sequence are you using? What command(s) does your Keyboard Shortcuts page show that bound to?
Im using the usual cmd+c which works in other apps. And cmd+c also works in the editor mode, terminal mode - so i think its not my key bindings customization. I recorded video in presenter mode (displaying what i press) showing copying something else + not working for ext description:

Related discussion:
text: } }); <ins> function overrideActionForActiveExtensionEditorWebview(command: MultiCommand | undefined, f: (webview: Webview) => void) { command?.addImplementation(105, (accessor) => { const editorService = accessor.get(IEditorService); const editor = editorService.activeEditorPane; if (editor instanceof ExtensionEditor) { if (editor.activeWebview) { f(editor.activeWebview); return true; } } return false; }); } overrideActionForActiveExtensionEditorWebview(CopyAction, webview => webview.copy()); overrideActionForActiveExtensionEditorWebview(CutAction, webview => webview.cut()); overrideActionForActiveExtensionEditorWebview(PasteAction, webview => webview.paste()); </ins> const workbenchRegistry = Registry.as<IWorkbenchContributionsRegistry>(WorkbenchExtensions.Workbench); class ExtensionsContributions implements IWorkbenchContribution {
Code change:
VSCode Version: Code 1.41.0 (, 2019-12-11T18:37:42.077Z) OS Version: Windows_NT x64 10.0. Steps to Reproduce: a Markdown file on a network shared folder (ex.: ). that network shared folder to a drive letter in Windows (ex.: ). the Markdown file in VS Code using the mapped drive letter (ex.: ) and open its Side-by-Side Preview (). The preview should be correctly formatted. the same Markdown file in VS Code, but using the file's UNC path (ex.: ) and open its Side-by-Side Preview. The preview is incorrectly formatted. Does this issue occur when all extensions are disabled?: Yes Correct format (file opened through mapped drive letter): ! Wrong format (file opened through UNC path): !
I would like to work on this if possible.
There was a typo in the code was causing this. I have tested on Windows 10 with a file on a UNC path with the fix above and it is working fine.

Related discussion:
text: resourceFsPath = resourceFsPath.toLowerCase(); } <del> return startsWith(resource.fsPath, rootPath); </del> <ins> return startsWith(resourceFsPath, rootPath); </ins> }
Code change:
If you return in a completion item, the property is when calling through . Setup: Test code: Output is: Full repro project is here:
It looks like the conversion is missing. The doc states that additionalTextEdits should not overlap with the main edit range or each other, should that be checked or is that done when the edits are carried out? Adding this: ! works, unless the range intersections need to be checked.
No checks required - this is already the way back from the UX and check should have been carried out already

Related discussion:
text: }; return this._commands.executeCommand<modes.CompletionList>('_executeCompletionItemProvider', args).then(result => { if (result) { <del> const items = result.suggestions.map(suggestion => typeConverters.CompletionItem.to(suggestion)); </del> <ins> const items = result.suggestions.map(suggestion => typeConverters.CompletionItem.to(suggestion, this._commands.converter)); </ins> return new types.CompletionList(items, result.incomplete); } return undefined;
Code change:
If you return in a completion item, the property is when calling through . Setup: Test code: Output is: Full repro project is here:
It looks like the conversion is missing. The doc states that additionalTextEdits should not overlap with the main edit range or each other, should that be checked or is that done when the edits are carried out? Adding this: ! works, unless the range intersections need to be checked.
No checks required - this is already the way back from the UX and check should have been carried out already

Related discussion:
text: import { LogLevel as _MainLogLevel } from 'vs/platform/log/common/log'; import { coalesce, isNonEmptyArray } from 'vs/base/common/arrays'; import { RenderLineNumbersType } from 'vs/editor/common/config/editorOptions'; <ins> import { CommandsConverter } from 'vs/workbench/api/common/extHostCommands'; </ins> export interface PositionLike { line: number;
Code change:
If you return in a completion item, the property is when calling through . Setup: Test code: Output is: Full repro project is here:
It looks like the conversion is missing. The doc states that additionalTextEdits should not overlap with the main edit range or each other, should that be checked or is that done when the edits are carried out? Adding this: ! works, unless the range intersections need to be checked.
No checks required - this is already the way back from the UX and check should have been carried out already

Related discussion:
text: export namespace CompletionItem { <del> export function to(suggestion: modes.CompletionItem): types.CompletionItem { </del> <ins> export function to(suggestion: modes.CompletionItem, converter?: CommandsConverter): types.CompletionItem { </ins> const result = new types.CompletionItem(suggestion.label); result.insertText = suggestion.insertText; result.kind = CompletionItemKind.to(suggestion.kind);