jiebi/CodeConvo huggingface dataset:
Code change:
When a user opens a file extension that does not have a specific recommendation tied to it, we show the general notification that points users to the marketplace. This has the following flaws: Most popular file types are already covered by specific extensions, so what gets left in this experience is leftovers For most of the extensions there is no good extension to handle this experience. Thus opening the Extension page does not provide value This is adding un-needed pings to the Marketplace service Also we had a bug that this feature was not available in stable and only 3 users found it is not there Would love for us to get some telemetry on this actions to see if this is actually bringing value to users. If not, we should either: Remove this flow completely Have a pre-defined set of file extensions for which we show this. Checking with tags seems to be very faulty. In my example below there is not an extension that helps with PowerPoint files. !
Only of these notifications end up with users clicking on Search Marketplace ! When it is actually clicked here are the top extensions ! Thus I suggest that we: Remove this dialog Add explicit extension recommendation for and . Since those seem to be missing. what do you think?
Sounds good to me
Great. Ok, you remove the dialog when you find time, I will add the recommendations for csv and pdf. Or if you go on vacation, I can also remove the dialog. I am working in August. Thanks
Feel free to remove it in August, otherwise I can also do it in September. Here it is
To verify: a file with some strange extension. For example -make sure no notification shows up a .py file or .go file. Make sure you get an extension recommendation for specific python / go extensions

Related discussion:
text: if (Object.keys(matchedRecommendations).length) { this.promptFromRecommendations(uri, model, matchedRecommendations); <del> return true; </del> } <del> return false; </del> } private promptFromRecommendations(uri: URI, model: ITextModel, extensionRecommendations: IStringDictionary<IFileOpenCondition[]>): void {
Code change:
Notice the "Define Keybinding" button: !
how did you get this to happen? I cannot repro
This happens when the keybinding editor is in the background
yeah, that's what I tried. !
might have been fixed via that styling pr where I a high z-index?
Can you check the dom? z-index shouldn't be the solution to this problem
i'm not able to reproduce so don't know if checking the dom would help
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
! I'm able to reproduce it consistently. Open keyboard shortcuts (JSON) While the editor has focus, press alt+F1 Notice that the dialog has the "define keybinding" button Also, I can only use alt+f1 once. After I close the dialog I have to reload VS Code. And I suggest to add the accessibility help command to the F1 command palette. I have a different keybinding on Alt+F1 and for testing this feature, it would be very helpful if you don't have to lookup/redefine a keybinding.
Still cannot reproduce but will keep trying it's in the command palette <img width="671" alt="Screenshot 2023-08-10 at 11 13 34 AM" src=""that's a different bug, thanks.
Oh sorry, I didn't see it! I can also investigate the context key issue if it doesn't reproduce for you. ~Actually, that is very weird, now I cannot reproduce anymore. But I was able to reproduce on two different devices (though with synced settings).~ It seems like it happens when something other than the editor has focus: ! When I now open accessibility help using the command palette, I get this: !
Oh, like the panel?
Yes

Related discussion:
text: codeEditor = codeEditorService.getActiveCodeEditor()!; } accessibleViewService.show(instantiationService.createInstance(AccessibilityHelpProvider, codeEditor)); <del> })); </del> <ins> }, EditorContextKeys.focus)); </ins> } }
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Insiders OS Version: macOS Steps to Reproduce: a notebook it a memory snapshot cell text models are not released <img width="1648" alt="image" src=""

Related discussion:
text: return this._view; } <del> const toolbar = this.instantiationService.createInstance(WorkbenchToolBar, this.toolbarContainer, { </del> <ins> const toolbar = this._register(this.instantiationService.createInstance(WorkbenchToolBar, this.toolbarContainer, { </ins> actionViewItemProvider: action => { return createActionViewItem(this.instantiationService, action); }, renderDropdownAsChildElement: true <del> }); </del> <ins> })); </ins> const deleteToolbar = this._register(this.instantiationService.invokeFunction(accessor => createDeleteToolbar(accessor, this.toolbarContainer, 'cell-delete-toolbar'))); if (model.deleteActions.primary.length !== 0 || model.deleteActions.secondary.length !== 0) {
Code change:
Tracking issue to ensure that we can run a build with all tests passing, mainly smoke tests. Previously tracked as

Related discussion:
text: get disableWorkspaceTrust(): boolean { return !!this.args['disable-workspace-trust']; } @memoize <ins> get disableKeytar(): boolean { return !!this.args['disable-keytar']; } @memoize </ins> get policyFile(): URI | undefined { if (this.args['__enable-file-policy']) { const vscodePortable = env['VSCODE_PORTABLE'];
Code change:
Tracking issue to ensure that we can run a build with all tests passing, mainly smoke tests. Previously tracked as

Related discussion:
text: get disableUpdates(): boolean { return !!this.args['disable-updates']; } @memoize <del> get disableKeytar(): boolean { return !!this.args['disable-keytar']; } @memoize </del> get crossOriginIsolated(): boolean { return !!this.args['enable-coi']; } @memoize
Code change:
Tracking issue to ensure that we can run a build with all tests passing, mainly smoke tests. Previously tracked as

Related discussion:
text: private async initialize(): Promise<IStorageService> { let storageService; if (!this._useInMemoryStorage && await this._encryptionService.isEncryptionAvailable()) { <ins> this._logService.trace(`[SecretStorageService] Encryption is available, using persisted storage`); </ins> this._type = 'persisted'; storageService = this._storageService; } else {
Code change:
Tracking issue to ensure that we can run a build with all tests passing, mainly smoke tests. Previously tracked as

Related discussion:
text: this._sequencer.queue(key, async () => { await this.resolvedStorageService; <del> if (this.type !== 'persisted') { </del> <ins> if (this.type !== 'persisted' && !this._environmentService.disableKeytar) { </ins> this._logService.trace('[NativeSecretStorageService] Notifying user that secrets are not being stored on disk.'); await this.notifyOfNoEncryptionOnce(); }
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Latest OS Version: MacOS Latest Steps to Reproduce: I have already disabled the following but I still have an empty top bar taking space in fullscreen mode, whereas before this change I could have removed the topbar completely. Before <img width="1439" alt="Screenshot 2023-08-03 at 10 13 57" src=""After <img width="1439" alt="Screenshot 2023-08-03 at 10 13 32" src=""Similar issue:
Workaround: It seems to be fixed once I exit/enter the fullscreen mode again.
To clarify--this is the issue you're running into? That issue is just about being able to toggle it in the first place, which does work as expected today. This behavior seems scoped to fullscreen mode specifically.
I also have this problem. I need that top bar completely removed, but I can turn off stuff and it still stays up. Is this really forced on us to not be able to remove?
actually that worked, had to go outside of fullscreen and now in fullscreen it correctly disappears. Cheers ;)
Yeah, I don't think this is intentional but just wanted to confirm the issue.

Related discussion:
text: } })); <ins> // Title Menu changes this._register(this.titleService.onDidChangeCommandCenterVisibility(() => this.doUpdateLayoutConfiguration())); </ins> // Fullscreen changes this._register(onDidChangeFullscreen(() => this.onFullscreenChanged()));
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Latest OS Version: MacOS Latest Steps to Reproduce: I have already disabled the following but I still have an empty top bar taking space in fullscreen mode, whereas before this change I could have removed the topbar completely. Before <img width="1439" alt="Screenshot 2023-08-03 at 10 13 57" src=""After <img width="1439" alt="Screenshot 2023-08-03 at 10 13 32" src=""Similar issue:
Workaround: It seems to be fixed once I exit/enter the fullscreen mode again.
To clarify--this is the issue you're running into? That issue is just about being able to toggle it in the first place, which does work as expected today. This behavior seems scoped to fullscreen mode specifically.
I also have this problem. I need that top bar completely removed, but I can turn off stuff and it still stays up. Is this really forced on us to not be able to remove?
actually that worked, had to go outside of fullscreen and now in fullscreen it correctly disappears. Cheers ;)
Yeah, I don't think this is intentional but just wanted to confirm the issue.

Related discussion:
text: this._register(this.titleService.onMenubarVisibilityChange(visible => this.onMenubarToggled(visible))); } <del> // Title Menu changes this._register(this.titleService.onDidChangeCommandCenterVisibility(() => this.layout())); </del> // Theme changes this._register(this.themeService.onDidColorThemeChange(() => this.updateStyles()));
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A (remote extensions are needed) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.81.0 (Universal) and 1.82.0-insider (Universal) OS Version: MacOS 13.3.1 (22E261) [Ventura] Steps to Reproduce: a repository with a devcontainer from GitHub Codespaces (either in browser VS Code, or desktop) at the Source Control tab - it says "Scanning folder for git repositories…" I have seen this issues before months back, and it was fixed in Insiders and subsequently the release version - but it is back again and very frustrating. I have a minimal repo here - you will need to create a Codespace to see the issue (or choose a different devcontainer workflow). The issue could be to do with the docker image used, I think last time there was some suggestion of a problem with Alpine (or Alpine containers), and I believe the Jekyll container is based on Alpine. too.
it looks like has resurfaced. I am able to reproduce with the latest Insiders release.
Very likely candidate , will investigate tomorrow.
Steps for verification: Reopen in a container Verify server launches and integrated terminal works fine
I've checked in the latest Insiders release and the same bug seems to still be present when using GitHub Codespaces (both in web version of VS Code insiders, and desktop version of VS Code insiders when connecting to the Codespace) Version: 1.83.0-insider (Universal) Commit: Date: 2023-09-13T05:34:48.836Z Electron: 25.8.0 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Darwin x64 22.4.0
the alpine servers run fine with the provided container configuration, however the git scm is hanging for a different reason can you please look into it
I have created a new Codespace on the linked repository and I am still able to reproduce the problem. As far as I can tell the extension how is completely busted as running "Show Running Extensions" is empty. In the Window output log I see the following: If I look at the Git extension I see the following: !
Ah missed the logs, is based on whereas our server alpine modules are built on . We don't plan to revert the alpine version as is reaching EOL I am closing this as designed, please update the jekyll container to use

Related discussion:
text: disturl "https://nodejs.org/dist" target "18.15.0" <del> ms_build_id "223745" </del> <ins> ms_build_id "229541" </ins> runtime "node" build_from_source "true"
Code change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Currently, it says "No forwarded ports. Forward a port to access your running services locally.". But when using the Ports tab locally (no remote), this doesn't have the same meaning because I can already access the port locally. The suggestion is to change the text in the local port forwarding case to show something more meaningful. Just as an example, something like "No forwarded ports. Forward a port to securely access your locally running services over the Internet."

Related discussion:
text: ) { super(); this._register(Registry.as<IViewsRegistry>(Extensions.ViewsRegistry).registerViewWelcomeContent(TUNNEL_VIEW_ID, { <del> content: `No forwarded ports. Forward a port to access your running services locally.n[Forward a Port](command:${ForwardPortAction.INLINE_ID})`, </del> <ins> content: this.environmentService.remoteAuthority ? nls.localize('remoteNoPorts', "No forwarded ports. Forward a port to access your running services locally.n[Forward a Port]({0})", `command:${ForwardPortAction.INLINE_ID}`) : nls.localize('noRemoteNoPorts', "No forwarded ports. Forward a port to access your locally running services over the internet.n[Forward a Port]({0})", `command:${ForwardPortAction.INLINE_ID}`), </ins> })); this.enableBadgeAndStatusBar(); this.enableForwardedPortsView();
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.81.0 OS Version: Windows_NT x64 10.0. Steps to Reproduce: In , set the content to then start VS Code with shell integration enabled and use Windows PowerShell. This bug will occur: The use of at: Needs to be guarded for Windows PowerShell (where it doesn't exist). /cc
Sharing from my profile:

Related discussion:
text: } # Set IsWindows property <del> [Console]::Write("$([char]0x1b)]633;P;IsWindows=$($IsWindows)`a") </del> <ins> if ($PSVersionTable.PSVersion -lt "6.0") { # Windows PowerShell is only available on Windows [Console]::Write("$([char]0x1b)]633;P;IsWindows=$true`a") } else { [Console]::Write("$([char]0x1b)]633;P;IsWindows=$IsWindows`a") } </ins> # Set always on key handlers which map to default VS Code keybindings function Set-MappedKeyHandler {
Code change:
Type: <bBug</bOpen terminal. Start typing. Note the noticeable delay in the text rendering on screen even though the cursor advances. In fact some timess the text never renders. Makes the terminal pretty unusable. VS Code version: Code - Insiders 1.82.0-insider (, 2023-08-10T05:33:20.243Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (19)</summaryExtensionVersion ------ togglehs0.1.2 vscode-eslint2.4.2 githistory0.6.20 gitlens2023.8.1005 dotnet-test-explorer0.7.8 copilot1.101.325 copilot-chat0.7. vscode-mojom0.1.4 mojom-language0.0.1 vscode-clangd0.1.24 csharp2.0.328 vscode-dotnet-runtime1.6.0 python2023.15. vscode-pylance2023.8.21 remote-wsl0.81.0 cpptools1.17.1 powershell2023.6.0 vscode-jest5.2.3 clang-format1.9.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
does changing help?
Yes. It apparently was set to auto previously. If it turn it to "off" the issue goes away.
repro's for me with set to or . does not repro for or gif: !
I can't reproduce this unfortunately
I still have a consistent repro if you want me to try anything or collect diagnostics.
Findings from looking at it together: It repro'd in Code - OSS It did not repro in xterm demo It did not repro in Code - OSS with symlinked webgl addon It repro'd after running scripts/update-xterm
I'm going to manually look through all the code that went in around rendering ~1-2 weeks ago to see if I can spot something.
Maybe it's related to Chromium.
Upstream bug filed at , thanks to
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Verified on Linux
verified on windows

Related discussion:
text: readonly raw: RawXtermTerminal; private _core: IXtermCore; private static _suggestedRendererType: 'canvas' | 'dom' | undefined = undefined; <ins> private static _checkedWebglCompatible = false; </ins> private _attached?: { container: HTMLElement; options: IXtermAttachToElementOptions }; private _isPhysicalMouseWheel = MouseWheelClassifier.INSTANCE.isPhysicalMouseWheel();
Code change:
Type: <bBug</bOpen terminal. Start typing. Note the noticeable delay in the text rendering on screen even though the cursor advances. In fact some timess the text never renders. Makes the terminal pretty unusable. VS Code version: Code - Insiders 1.82.0-insider (, 2023-08-10T05:33:20.243Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (19)</summaryExtensionVersion ------ togglehs0.1.2 vscode-eslint2.4.2 githistory0.6.20 gitlens2023.8.1005 dotnet-test-explorer0.7.8 copilot1.101.325 copilot-chat0.7. vscode-mojom0.1.4 mojom-language0.0.1 vscode-clangd0.1.24 csharp2.0.328 vscode-dotnet-runtime1.6.0 python2023.15. vscode-pylance2023.8.21 remote-wsl0.81.0 cpptools1.17.1 powershell2023.6.0 vscode-jest5.2.3 clang-format1.9.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
does changing help?
Yes. It apparently was set to auto previously. If it turn it to "off" the issue goes away.
repro's for me with set to or . does not repro for or gif: !
I can't reproduce this unfortunately
I still have a consistent repro if you want me to try anything or collect diagnostics.
Findings from looking at it together: It repro'd in Code - OSS It did not repro in xterm demo It did not repro in Code - OSS with symlinked webgl addon It repro'd after running scripts/update-xterm
I'm going to manually look through all the code that went in around rendering ~1-2 weeks ago to see if I can spot something.
Maybe it's related to Chromium.
Upstream bug filed at , thanks to
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Verified on Linux
verified on windows

Related discussion:
text: if (!this.raw.element || this._webglAddon) { return; } <ins> // Check if the the WebGL renderer is compatible with xterm.js: // - https://github.com/microsoft/vscode/issues/190195 // - https://github.com/xtermjs/xterm.js/issues/4665 // - https://bugs.chromium.org/p/chromium/issues/detail?id=1476475 if (!XtermTerminal._checkedWebglCompatible) { XtermTerminal._checkedWebglCompatible = true; const checkCanvas = document.createElement('canvas'); const checkGl = checkCanvas.getContext('webgl2'); const debugInfo = checkGl?.getExtension('WEBGL_debug_renderer_info'); if (checkGl && debugInfo) { const renderer = checkGl.getParameter(debugInfo.UNMASKED_RENDERER_WEBGL); if (renderer.startsWith('ANGLE (Google, Vulkan 1.3.0 (SwiftShader Device (Subzero)')) { this._disableWebglForThisSession(); return; } } } </ins> const Addon = await this._getWebglAddonConstructor(); this._webglAddon = new Addon(); this._disposeOfCanvasRenderer();