jiebi/CodeConvo huggingface dataset:
Code change:
Type: <bBug</bIssue Reporter, e.g. from off Command Palette. the first dropdown to VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-24T07:50:18.385Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
good catch, thanks! looks like an issue with the refactor

Related discussion:
text: // Store into config object URL this.configuration = { <ins> zoomLevel: data.zoomLevel, </ins> appRoot: this.environmentService.appRoot, windowId: 0, userEnv: {},
Code change:
Type: <bBug</bIssue Reporter, e.g. from off Command Palette. the first dropdown to VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-24T07:50:18.385Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
good catch, thanks! looks like an issue with the refactor

Related discussion:
text: cursor: pointer; appearance: auto; border: none; <ins> border-right: 6px solid transparent; padding-left: 10px; </ins> } .issue-reporter-body #similar-issues {
Code change:
a workspace: and drop into Expected Inserts Actual Inserts
Closing as fixed in main and release branch

Related discussion:
text: return; } <del> const snippet = await this.createUriListSnippet(uriList); </del> <ins> const snippet = await this.createUriListSnippet(document.uri, uriList); </ins> if (!snippet || token.isCancellationRequested) { return; }
Code change:
a workspace: and drop into Expected Inserts Actual Inserts
Closing as fixed in main and release branch

Related discussion:
text: return new UriList(uris.map(uri => ({ uri, str: uri.toString(true) }))); } <del> private async createUriListSnippet(uriList: UriList): Promise<{ readonly snippet: vscode.SnippetString; readonly label: string } | undefined> { </del> <ins> private async createUriListSnippet(docUri: vscode.Uri, uriList: UriList): Promise<{ readonly snippet: vscode.SnippetString; readonly label: string } | undefined> { </ins> if (!uriList.entries.length) { return; }
Code change:
a workspace: and drop into Expected Inserts Actual Inserts
Closing as fixed in main and release branch

Related discussion:
text: const snippet = new vscode.SnippetString(); for (let i = 0; i < uriList.entries.length; i++) { const uri = uriList.entries[i]; <del> const relativePath = getRelativePath(uri.uri); </del> <ins> const relativePath = getRelativePath(getDocumentDir(docUri), uri.uri); </ins> const urlText = relativePath ?? uri.str; snippet.appendText(`url(${urlText})`);
Code change:
a workspace: and drop into Expected Inserts Actual Inserts
Closing as fixed in main and release branch

Related discussion:
text: } } <del> function getRelativePath(file: vscode.Uri): string | undefined { const dir = getDocumentDir(file); if (dir && dir.scheme === file.scheme && dir.authority === file.authority) { if (file.scheme === Schemes.file) { </del> <ins> function getRelativePath(fromFile: vscode.Uri | undefined, toFile: vscode.Uri): string | undefined { if (fromFile && fromFile.scheme === toFile.scheme && fromFile.authority === toFile.authority) { if (toFile.scheme === Schemes.file) { </ins> // On windows, we must use the native `path.relative` to generate the relative path // so that drive-letters are resolved cast insensitively. However we then want to // convert back to a posix path to insert in to the document <del> const relativePath = path.relative(dir.fsPath, file.fsPath); </del> <ins> const relativePath = path.relative(fromFile.fsPath, toFile.fsPath); </ins> return path.posix.normalize(relativePath.split(path.sep).join(path.posix.sep)); } <del> return path.posix.relative(dir.path, file.path); </del> <ins> return path.posix.relative(fromFile.path, toFile.path); </ins> } return undefined;
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.92.0, commit OS Version: Windows 10 Enterprise, 22H2 build .4651 Error message: Steps to Reproduce: a new VS code window ! a new file and drag out to make another window ! "Create New Terminal in Editor Area" on that new window ! error will show up ! "Try Again" will reload the terminal, but it doesn't accept inputs, cannot type anything there ! Creating terminal in main window and drag it to side windows does work, but I have to do that with every window reload. Yesterday I could still use terminals in side windows like normal, this only occured after updating to 1.92 July update Thanks for reading :)
! Facing same issue
coming from xterm here I think !
I have the same problem on Fedora 40 Sway. After I click , it will create a non-interoperable terminal.
I'm also having this issue, I thought it might be a problem with WSL but it started for me after updating to VSCode 1.92.0 !
QUICK FIX!!! Just create a new In-window terminal and drag it to the new terminal window.
Will this be hotfixed or should we downgrade?
sorry this won't get a patch release as there's a few workarounds. To downgrade in the meantime you can grab 1.91.1 here , you'll also want to set
Hi. Didn't do the trick for me. Other hack: Ctrl+J (new term in main window) Ctrl + Shift + P Terminal: Move Into New Window Drag & Drop into wanted window. Cumbersom many many times a day.

Related discussion:
text: "@vscode/windows-mutex": "^0.5.0", "@vscode/windows-process-tree": "^0.6.0", "@vscode/windows-registry": "^1.1.0", <del> "@xterm/addon-clipboard": "0.2.0-beta.34", "@xterm/addon-image": "0.9.0-beta.51", "@xterm/addon-search": "0.16.0-beta.51", "@xterm/addon-serialize": "0.14.0-beta.51", "@xterm/addon-unicode11": "0.9.0-beta.51", "@xterm/addon-webgl": "0.19.0-beta.51", "@xterm/headless": "5.6.0-beta.51", "@xterm/xterm": "5.6.0-beta.51", </del> <ins> "@xterm/addon-clipboard": "0.2.0-beta.35", "@xterm/addon-image": "0.9.0-beta.52", "@xterm/addon-search": "0.16.0-beta.52", "@xterm/addon-serialize": "0.14.0-beta.52", "@xterm/addon-unicode11": "0.9.0-beta.52", "@xterm/addon-webgl": "0.19.0-beta.52", "@xterm/headless": "5.6.0-beta.52", "@xterm/xterm": "5.6.0-beta.52", </ins> "http-proxy-agent": "^7.0.0", "https-proxy-agent": "^7.0.2", "jschardet": "3.1.3",
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.92.0, commit OS Version: Windows 10 Enterprise, 22H2 build .4651 Error message: Steps to Reproduce: a new VS code window ! a new file and drag out to make another window ! "Create New Terminal in Editor Area" on that new window ! error will show up ! "Try Again" will reload the terminal, but it doesn't accept inputs, cannot type anything there ! Creating terminal in main window and drag it to side windows does work, but I have to do that with every window reload. Yesterday I could still use terminals in side windows like normal, this only occured after updating to 1.92 July update Thanks for reading :)
! Facing same issue
coming from xterm here I think !
I have the same problem on Fedora 40 Sway. After I click , it will create a non-interoperable terminal.
I'm also having this issue, I thought it might be a problem with WSL but it started for me after updating to VSCode 1.92.0 !
QUICK FIX!!! Just create a new In-window terminal and drag it to the new terminal window.
Will this be hotfixed or should we downgrade?
sorry this won't get a patch release as there's a few workarounds. To downgrade in the meantime you can grab 1.91.1 here , you'll also want to set
Hi. Didn't do the trick for me. Other hack: Ctrl+J (new term in main window) Ctrl + Shift + P Terminal: Move Into New Window Drag & Drop into wanted window. Cumbersom many many times a day.

Related discussion:
text: "@vscode/vscode-languagedetection": "1.0.21", "@vscode/windows-process-tree": "^0.6.0", "@vscode/windows-registry": "^1.1.0", <del> "@xterm/addon-clipboard": "0.2.0-beta.34", "@xterm/addon-image": "0.9.0-beta.51", "@xterm/addon-search": "0.16.0-beta.51", "@xterm/addon-serialize": "0.14.0-beta.51", "@xterm/addon-unicode11": "0.9.0-beta.51", "@xterm/addon-webgl": "0.19.0-beta.51", "@xterm/headless": "5.6.0-beta.51", "@xterm/xterm": "5.6.0-beta.51", </del> <ins> "@xterm/addon-clipboard": "0.2.0-beta.35", "@xterm/addon-image": "0.9.0-beta.52", "@xterm/addon-search": "0.16.0-beta.52", "@xterm/addon-serialize": "0.14.0-beta.52", "@xterm/addon-unicode11": "0.9.0-beta.52", "@xterm/addon-webgl": "0.19.0-beta.52", "@xterm/headless": "5.6.0-beta.52", "@xterm/xterm": "5.6.0-beta.52", </ins> "cookie": "^0.4.0", "http-proxy-agent": "^7.0.0", "https-proxy-agent": "^7.0.2",
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.92.0, commit OS Version: Windows 10 Enterprise, 22H2 build .4651 Error message: Steps to Reproduce: a new VS code window ! a new file and drag out to make another window ! "Create New Terminal in Editor Area" on that new window ! error will show up ! "Try Again" will reload the terminal, but it doesn't accept inputs, cannot type anything there ! Creating terminal in main window and drag it to side windows does work, but I have to do that with every window reload. Yesterday I could still use terminals in side windows like normal, this only occured after updating to 1.92 July update Thanks for reading :)
! Facing same issue
coming from xterm here I think !
I have the same problem on Fedora 40 Sway. After I click , it will create a non-interoperable terminal.
I'm also having this issue, I thought it might be a problem with WSL but it started for me after updating to VSCode 1.92.0 !
QUICK FIX!!! Just create a new In-window terminal and drag it to the new terminal window.
Will this be hotfixed or should we downgrade?
sorry this won't get a patch release as there's a few workarounds. To downgrade in the meantime you can grab 1.91.1 here , you'll also want to set
Hi. Didn't do the trick for me. Other hack: Ctrl+J (new term in main window) Ctrl + Shift + P Terminal: Move Into New Window Drag & Drop into wanted window. Cumbersom many many times a day.

Related discussion:
text: "@vscode/iconv-lite-umd": "0.7.0", "@vscode/tree-sitter-wasm": "^0.0.1", "@vscode/vscode-languagedetection": "1.0.21", <del> "@xterm/addon-clipboard": "0.2.0-beta.34", "@xterm/addon-image": "0.9.0-beta.51", "@xterm/addon-search": "0.16.0-beta.51", "@xterm/addon-serialize": "0.14.0-beta.51", "@xterm/addon-unicode11": "0.9.0-beta.51", "@xterm/addon-webgl": "0.19.0-beta.51", "@xterm/xterm": "5.6.0-beta.51", </del> <ins> "@xterm/addon-clipboard": "0.2.0-beta.35", "@xterm/addon-image": "0.9.0-beta.52", "@xterm/addon-search": "0.16.0-beta.52", "@xterm/addon-serialize": "0.14.0-beta.52", "@xterm/addon-unicode11": "0.9.0-beta.52", "@xterm/addon-webgl": "0.19.0-beta.52", "@xterm/xterm": "5.6.0-beta.52", </ins> "jschardet": "3.1.3", "tas-client-umd": "0.2.0", "vscode-oniguruma": "1.7.0",
Code change:
Note that quick pick instances and their events are disposables. Noticed a few cases of missing:

Related discussion:
text: return true; } <del> const quickPick = this._quickInputService.createQuickPick<KernelQuickPickItem>({ useSeparators: true }); </del> <ins> const localDisposableStore = new DisposableStore(); const quickPick = localDisposableStore.add(this._quickInputService.createQuickPick<KernelQuickPickItem>({ useSeparators: true })); </ins> const quickPickItems = this._getKernelPickerQuickPickItems(notebook, matchResult, this._notebookKernelService, scopedContextKeyService); if (quickPickItems.length === 1 && supportAutoRun(quickPickItems[0]) && !skipAutoRun) { <del> return await this._handleQuickPick(editor, quickPickItems[0], quickPickItems as KernelQuickPickItem[]); </del> <ins> const picked = await this._handleQuickPick(editor, quickPickItems[0], quickPickItems as KernelQuickPickItem[]); localDisposableStore.dispose(); return picked; </ins> } quickPick.items = quickPickItems;
Code change:
Note that quick pick instances and their events are disposables. Noticed a few cases of missing:

Related discussion:
text: }, this); const pick = await new Promise<{ selected: KernelQuickPickItem | undefined; items: KernelQuickPickItem[] }>((resolve, reject) => { <del> quickPick.onDidAccept(() => { </del> <ins> localDisposableStore.add(quickPick.onDidAccept(() => { </ins> const item = quickPick.selectedItems[0]; if (item) { resolve({ selected: item, items: quickPick.items as KernelQuickPickItem[] });
Code change:
Note that quick pick instances and their events are disposables. Noticed a few cases of missing:

Related discussion:
text: } quickPick.hide(); <del> }); </del> <ins> })); </ins> <del> quickPick.onDidHide(() => { </del> <ins> localDisposableStore.add(quickPick.onDidHide(() => { </ins> kernelDetectionTaskListener.dispose(); kernelChangeEventListener.dispose(); quickPick.dispose(); resolve({ selected: undefined, items: quickPick.items as KernelQuickPickItem[] }); <del> }); </del> <ins> })); </ins> quickPick.show(); }); <ins> localDisposableStore.dispose(); </ins> if (pick.selected) { return await this._handleQuickPick(editor, pick.selected, pick.items); }
Code change:
Note that quick pick instances and their events are disposables. Noticed a few cases of missing:

Related discussion:
text: private async displaySelectAnotherQuickPick(editor: IActiveNotebookEditor, kernelListEmpty: boolean): Promise<boolean> { const notebook: NotebookTextModel = editor.textModel; const disposables = new DisposableStore(); <del> const quickPick = this._quickInputService.createQuickPick<KernelQuickPickItem>({ useSeparators: true }); </del> <ins> const quickPick = disposables.add(this._quickInputService.createQuickPick<KernelQuickPickItem>({ useSeparators: true })); </ins> const quickPickItem = await new Promise<KernelQuickPickItem | IQuickInputButton | undefined>(resolve => { // select from kernel sources quickPick.title = kernelListEmpty ? localize('select', "Select Kernel") : localize('selectAnotherKernel', "Select Another Kernel");
Code change:
Note that quick pick instances and their events are disposables. Noticed a few cases of missing:

Related discussion:
text: resolve(button); } })); <del> quickPick.onDidTriggerItemButton(async (e) => { </del> <ins> disposables.add(quickPick.onDidTriggerItemButton(async (e) => { </ins> if (isKernelSourceQuickPickItem(e.item) && e.item.documentation !== undefined) { const uri = URI.isUri(e.item.documentation) ? URI.parse(e.item.documentation) : await this._commandService.executeCommand(e.item.documentation); void this._openerService.open(uri, { openExternal: true }); } <del> }); </del> <ins> })); </ins> disposables.add(quickPick.onDidAccept(async () => { resolve(quickPick.selectedItems[0]); }));
Code change:
Note that quick pick instances and their events are disposables. Noticed a few cases of missing:

Related discussion:
text: private async _selectOneKernel(notebook: NotebookTextModel, source: string, kernels: INotebookKernel[]) { const quickPickItems: QuickPickInput<KernelPick>[] = kernels.map(kernel => toKernelQuickPick(kernel, undefined)); <del> const quickPick = this._quickInputService.createQuickPick<KernelQuickPickItem>({ useSeparators: true }); </del> <ins> const localDisposableStore = new DisposableStore(); const quickPick = localDisposableStore.add(this._quickInputService.createQuickPick<KernelQuickPickItem>({ useSeparators: true })); </ins> quickPick.items = quickPickItems; quickPick.canSelectMany = false; quickPick.title = localize('selectKernelFromExtension', "Select Kernel from {0}", source); <del> quickPick.onDidAccept(async () => { </del> <ins> localDisposableStore.add(quickPick.onDidAccept(async () => { </ins> if (quickPick.selectedItems && quickPick.selectedItems.length > 0 && isKernelPick(quickPick.selectedItems[0])) { await this._selecteKernel(notebook, quickPick.selectedItems[0].kernel); } quickPick.hide(); quickPick.dispose(); <del> }); </del> <ins> })); </ins> <del> quickPick.onDidHide(() => { quickPick.dispose(); }); </del> <ins> localDisposableStore.add(quickPick.onDidHide(() => { localDisposableStore.dispose(); })); </ins> quickPick.show(); }
Code change:
For: Passing in an empty markdown file fixes this issue currently. [x] Add the ability to go back to the last focused view instead of the welcome page.
Removing the button on walkthroughs if opened from the cmd. This should prevent the walkthrough from going to the welcome page. The button is now only shown when a walkthrough is invoked from the page or another walkthrough.

Related discussion:
text: if (walkthroughID) { const selectedCategory = typeof walkthroughID === 'string' ? walkthroughID : walkthroughID.category; <del> const selectedStep = typeof walkthroughID === 'string' ? undefined : walkthroughID.category + '#' + walkthroughID.step; </del> <ins> let selectedStep: string | undefined; if (typeof walkthroughID === 'object' && 'category' in walkthroughID && 'step' in walkthroughID) { selectedStep = `${walkthroughID.category}#${walkthroughID.step}`; } else { selectedStep = undefined; } </ins> // We're trying to open the welcome page from the Help menu if (!selectedCategory && !selectedStep) {
Code change:
For: Passing in an empty markdown file fixes this issue currently. [x] Add the ability to go back to the last focused view instead of the welcome page.
Removing the button on walkthroughs if opened from the cmd. This should prevent the walkthrough from going to the welcome page. The button is now only shown when a walkthrough is invoked from the page or another walkthrough.

Related discussion:
text: // Try first to select the walkthrough on an active welcome page with no selected walkthrough for (const group of editorGroupsService.groups) { if (group.activeEditor instanceof GettingStartedInput) { <ins> const activeEditor = group.activeEditor as GettingStartedInput; activeEditor.showWelcome = false; </ins> (group.activeEditorPane as GettingStartedPage).makeCategoryVisibleWhenAvailable(selectedCategory, selectedStep); return; }
Code change:
For: Passing in an empty markdown file fixes this issue currently. [x] Add the ability to go back to the last focused view instead of the welcome page.
Removing the button on walkthroughs if opened from the cmd. This should prevent the walkthrough from going to the welcome page. The button is now only shown when a walkthrough is invoked from the page or another walkthrough.

Related discussion:
text: if (!editor.selectedCategory && group) { editor.selectedCategory = selectedCategory; editor.selectedStep = selectedStep; <ins> editor.showWelcome = false; </ins> group.openEditor(editor, { revealIfOpened: true }); return; }
Code change:
For: Passing in an empty markdown file fixes this issue currently. [x] Add the ability to go back to the last focused view instead of the welcome page.
Removing the button on walkthroughs if opened from the cmd. This should prevent the walkthrough from going to the welcome page. The button is now only shown when a walkthrough is invoked from the page or another walkthrough.

Related discussion:
text: const activeEditor = editorService.activeEditor; // If the walkthrough is already open just reveal the step if (selectedStep && activeEditor instanceof GettingStartedInput && activeEditor.selectedCategory === selectedCategory) { <ins> activeEditor.showWelcome = false; </ins> commandService.executeCommand('walkthroughs.selectStep', selectedStep); return; }
Code change:
For: Passing in an empty markdown file fixes this issue currently. [x] Add the ability to go back to the last focused view instead of the welcome page.
Removing the button on walkthroughs if opened from the cmd. This should prevent the walkthrough from going to the welcome page. The button is now only shown when a walkthrough is invoked from the page or another walkthrough.

Related discussion:
text: const activeGroup = editorGroupsService.activeGroup; activeGroup.replaceEditors([{ editor: activeEditor, <del> replacement: instantiationService.createInstance(GettingStartedInput, { selectedCategory: selectedCategory, selectedStep: selectedStep }) </del> <ins> replacement: instantiationService.createInstance(GettingStartedInput, { selectedCategory: selectedCategory, selectedStep: selectedStep, showWelcome: false }) </ins> }]); } else { // else open respecting toSide <del> const options: GettingStartedEditorOptions = { selectedCategory: selectedCategory, selectedStep: selectedStep, preserveFocus: toSide ?? false }; </del> <ins> const options: GettingStartedEditorOptions = { selectedCategory: selectedCategory, selectedStep: selectedStep, showWelcome: false, preserveFocus: toSide ?? false }; </ins> editorService.openEditor({ resource: GettingStartedInput.RESOURCE, options
Code change:
For: Passing in an empty markdown file fixes this issue currently. [x] Add the ability to go back to the last focused view instead of the welcome page.
Removing the button on walkthroughs if opened from the cmd. This should prevent the walkthrough from going to the welcome page. The button is now only shown when a walkthrough is invoked from the page or another walkthrough.

Related discussion:
text: } else { slideManager.classList.add('showDetails'); slideManager.classList.remove('showCategories'); <del> this.container.querySelector<HTMLButtonElement>('.prev-button.button-link')!.style.display = 'block'; </del> <ins> const showGoBackButton = this.editorInput.showWelcome || this.prevWalkthrough; this.container.querySelector<HTMLButtonElement>('.prev-button.button-link')!.style.display = showGoBackButton ? 'block' : 'none'; </ins> this.container.querySelector('.gettingStartedSlideDetails')!.querySelectorAll('button').forEach(button => button.disabled = false); this.container.querySelector('.gettingStartedSlideCategories')!.querySelectorAll('button').forEach(button => button.disabled = true); this.container.querySelector('.gettingStartedSlideCategories')!.querySelectorAll('input').forEach(button => button.disabled = true);