jiebi/CodeConvo huggingface dataset:
Code change:
For: Passing in an empty markdown file fixes this issue currently. [x] Add the ability to go back to the last focused view instead of the welcome page.
Removing the button on walkthroughs if opened from the cmd. This should prevent the walkthrough from going to the welcome page. The button is now only shown when a walkthrough is invoked from the page or another walkthrough.

Related discussion:
text: export const gettingStartedInputTypeId = 'workbench.editors.gettingStartedInput'; export interface GettingStartedEditorOptions extends IEditorOptions { <del> selectedCategory?: string; selectedStep?: string; showTelemetryNotice?: boolean; </del> <ins> selectedCategory?: string; selectedStep?: string; showTelemetryNotice?: boolean; showWelcome?: boolean; </ins> } export class GettingStartedInput extends EditorInput {
Code change:
For: Passing in an empty markdown file fixes this issue currently. [x] Add the ability to go back to the last focused view instead of the welcome page.
Removing the button on walkthroughs if opened from the cmd. This should prevent the walkthrough from going to the welcome page. The button is now only shown when a walkthrough is invoked from the page or another walkthrough.

Related discussion:
text: this.selectedCategory = options.selectedCategory; this.selectedStep = options.selectedStep; this.showTelemetryNotice = !!options.showTelemetryNotice; <ins> this.showWelcome = options.showWelcome ?? true; </ins> } override getName() {
Code change:
For: Passing in an empty markdown file fixes this issue currently. [x] Add the ability to go back to the last focused view instead of the welcome page.
Removing the button on walkthroughs if opened from the cmd. This should prevent the walkthrough from going to the welcome page. The button is now only shown when a walkthrough is invoked from the page or another walkthrough.

Related discussion:
text: selectedCategory: string | undefined; selectedStep: string | undefined; showTelemetryNotice: boolean; <ins> showWelcome: boolean; </ins> }
Code change:
Run the following cell Stage the notebook Make changes to the HTML Run again and view the diff Problems Clicking the will display a quick pick, however selecting anything is a noop !
/cc

Related discussion:
text: let result: IInsetRenderOutput | undefined = undefined; const [mimeTypes, pick] = this.output.resolveMimeTypes(this._notebookTextModel, undefined); <del> const pickedMimeTypeRenderer = mimeTypes[pick]; </del> <ins> const pickedMimeTypeRenderer = this.output.pickedMimeType || mimeTypes[pick]; </ins> if (mimeTypes.length > 1) { outputItemDiv.style.position = 'relative'; const mimeTypePicker = DOM.$('.multi-mimetype-output');
Code change:
Testing I had this code: But I still got results from a workspace folder: ! Full Extension:
I happen to want to report the same problem When there is only one item in the exclude string, the exclusion is correctly applied. When the exclude string contains more than one item, the exclusion is not applied. !
I think that your issue is a duplicate of
Seems that this only happens when is not defined. Strange.

Related discussion:
text: } const parsedInclude = include ? parseSearchExcludeInclude(GlobPattern.from(include)) : undefined; <del> const excludePatterns = include ? globsToISearchPatternBuilder(options.exclude) : undefined; </del> <ins> const excludePatterns = globsToISearchPatternBuilder(options.exclude); </ins> return { options: {
Code change:
We'd like to have a safety net if we ever break Insiders users once more to the point of them not being able to update.
Implementation is done. Requires

Related discussion:
text: { "name": "code-oss-dev", "version": "1.94.0", <del> "distro": "2560b0e8d341a0b6734d28ef71b08e1920ff2501", </del> <ins> "distro": "3617bc772b253b9c3ffd60d2e7165c4d945ac7c7", </ins> "author": { "name": "Microsoft Corporation" },
Code change:
We'd like to have a safety net if we ever break Insiders users once more to the point of them not being able to update.
Implementation is done. Requires

Related discussion:
text: // Running out of sources if (Object.keys(product).length === 0) { Object.assign(product, { <del> version: '1.91.0-dev', </del> <ins> version: '1.94.0-dev', </ins> nameShort: 'Code - OSS Dev', nameLong: 'Code - OSS Dev', applicationName: 'code-oss',
Code change:
We'd like to have a safety net if we ever break Insiders users once more to the point of them not being able to update.
Implementation is done. Requires

Related discussion:
text: (emergencyAlert.platform && emergencyAlert.platform !== platform) ||	// platform mismatch (emergencyAlert.arch && emergencyAlert.arch !== arch)					// arch mismatch ) { <del> return; // skip versions we are not on </del> <ins> return; </ins> } this.bannerService.show({
Code change:
move editor into its own window trigger find the input box is cropped, the border isn't fully visible !
I can reproduce and I am puzzled as to why this is. Opening for help wanted for a CSS wizard to step in if possible. Steps: open a text editor in the main window open the find widget and focus it, notice how the blue outline color goes all the way around the input box right click into the editor tab and "Copy into New Window" do the same and notice that the outline is cropped I already see that the wrapper around the is in the main window and in the auxiliary window ! ! CSS is defined from here: and
I can fix this, please assign me this issue if it's still open
we cannot assign issues to non-members of the team, but feel free to open a PR. Thanks!
sure, thanks for letting me know.

Related discussion:
text: .monaco-inputbox > .ibwrapper { position: relative; width: 100%; <del> height: 100%; </del> } .monaco-inputbox > .ibwrapper > .input {
Code change:
Enable the setting which enabled the native edit context adoption (make sure to reload the editor) Toggle word wrap on Resize the editor, so one of the lines is wrapped Type on that line Part of the line is deleted/incorrectly edited
Looks like this could be an issue with the coordinate system chosen too.

Related discussion:
text: this._register(editContextAddDisposableListener(this._editContext, 'textupdate', (e) => { const compositionRangeWithinEditor = this._compositionRangeWithinEditor; if (compositionRangeWithinEditor) { <del> const position = this._context.viewModel.getPrimaryCursorState().viewState.position; </del> <ins> const position = this._context.viewModel.getPrimaryCursorState().modelState.position; </ins> const newCompositionRangeWithinEditor = Range.fromPositions(compositionRangeWithinEditor.getStartPosition(), position); this._compositionRangeWithinEditor = newCompositionRangeWithinEditor; }
Code change:
Enable the setting which enabled the native edit context adoption (make sure to reload the editor) Toggle word wrap on Resize the editor, so one of the lines is wrapped Type on that line Part of the line is deleted/incorrectly edited
Looks like this could be an issue with the coordinate system chosen too.

Related discussion:
text: this._screenReaderSupport.writeScreenReaderContent(); })); this._register(editContextAddDisposableListener(this._editContext, 'compositionstart', (e) => { <del> const position = this._context.viewModel.getPrimaryCursorState().viewState.position; </del> <ins> const position = this._context.viewModel.getPrimaryCursorState().modelState.position; </ins> const newCompositionRange = Range.fromPositions(position, position); this._compositionRangeWithinEditor = newCompositionRange; // Utlimately fires onDidCompositionStart() on the editor to notify for example suggest model of composition state
Code change:
Enable the setting which enabled the native edit context adoption (make sure to reload the editor) Toggle word wrap on Resize the editor, so one of the lines is wrapped Type on that line Part of the line is deleted/incorrectly edited
Looks like this could be an issue with the coordinate system chosen too.

Related discussion:
text: if (i === this._primarySelection.endLineNumber) { selectionEndOffset += this._primarySelection.endColumn - 1; } else { <del> selectionEndOffset += this._context.viewModel.getLineMaxColumn(i); </del> <ins> selectionEndOffset += this._context.viewModel.model.getLineMaxColumn(i); </ins> } } <del> const endColumnOfEndLineNumber = this._context.viewModel.getLineMaxColumn(this._primarySelection.endLineNumber); </del> <ins> const endColumnOfEndLineNumber = this._context.viewModel.model.getLineMaxColumn(this._primarySelection.endLineNumber); </ins> const rangeOfText = new Range(this._primarySelection.startLineNumber, 1, this._primarySelection.endLineNumber, endColumnOfEndLineNumber); <del> const text = this._context.viewModel.getValueInRange(rangeOfText, EndOfLinePreference.TextDefined); </del> <ins> const text = this._context.viewModel.model.getValueInRange(rangeOfText, EndOfLinePreference.TextDefined); </ins> const textStartPositionWithinEditor = rangeOfText.getStartPosition(); return { text,
Code change:
If the diff element is disposed while the diff element is being resolved/built, then we might end up leaking the text models. Here its possible that the element was disposed just after the first line, i.e. once the promise resolves the element has been disposed. Thus leaking the text models. We have similar code in other parts and handle this correctly.

Related discussion:
text: this.textModelService.createModelReference(CellUri.generateCellPropertyUri(this.cell.originalDocument.uri, this.cell.original.handle, Schemas.vscodeNotebookCellMetadata)), this.textModelService.createModelReference(CellUri.generateCellPropertyUri(this.cell.modifiedDocument.uri, this.cell.modified.handle, Schemas.vscodeNotebookCellMetadata)) ]); <ins> if (this._isDisposed) { originalMetadataModel.dispose(); modifiedMetadataModel.dispose(); return; } </ins> this._metadataEditorDisposeStore.add(originalMetadataModel); this._metadataEditorDisposeStore.add(modifiedMetadataModel); const vm = this._metadataEditor.createViewModel({ original: originalMetadataModel.object.textEditorModel, modified: modifiedMetadataModel.object.textEditorModel }); <ins> this._metadataEditor.setModel(vm); </ins> // Reduces flicker (compute this before setting the model) // Else when the model is set, the height of the editor will be x, after diff is computed, then height will be y. // & that results in flicker. await vm.waitForDiff(); <del> this._metadataEditor.setModel(vm); </del> <ins> if (this._isDisposed) { return; } </ins> this.cell.metadataHeight = this._metadataEditor.getContentHeight();
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.93.0-insider (user setup) Commit: Date: 2024-09-04T13:13:15.344Z Electron: 30.4.0 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0. OS Version: Windows 11 Insiders Steps to Reproduce: in the first paragraph doesn't appear to be a link, which I was surprised about: ! I hover over it, I see it's supposed to be a link, but clicking on it does nothing: ! The other docs links at the bottom of the playground appear correctly as links and do open when I click on them: !
This seems related to the bookmark issue we had in the release notes. The other bookmark links in the interactive playground don't work either.
Fixed the toc links. Need another fix for the documentation link too (which use command uris)
The Editor Playground is not showing at all anymore in the latest insiders. When selecting the Editor Playground menu item, a black editor comes up.
hm working from oss builds. Insiders, it seems like the error is:
Actually unrelated. Seems like a duplicate of and fixed by

Related discussion:
text: import { ILanguageService } from '../../../../editor/common/languages/language.js'; import { tokenizeToString } from '../../../../editor/common/languages/textToHtmlTokenizer.js'; import { IExtensionService } from '../../../services/extensions/common/extensions.js'; <ins> import { markedGfmHeadingIdPlugin } from './markedGfmHeadingIdPlugin.js'; </ins> export const DEFAULT_MARKDOWN_STYLES = ` body {
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.93.0-insider (user setup) Commit: Date: 2024-09-04T13:13:15.344Z Electron: 30.4.0 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0. OS Version: Windows 11 Insiders Steps to Reproduce: in the first paragraph doesn't appear to be a link, which I was surprised about: ! I hover over it, I see it's supposed to be a link, but clicking on it does nothing: ! The other docs links at the bottom of the playground appear correctly as links and do open when I click on them: !
This seems related to the bookmark issue we had in the release notes. The other bookmark links in the interactive playground don't work either.
Fixed the toc links. Need another fix for the documentation link too (which use command uris)
The Editor Playground is not showing at all anymore in the latest insiders. When selecting the Editor Playground menu item, a black editor comes up.
hm working from oss builds. Insiders, it seems like the error is:
Actually unrelated. Seems like a duplicate of and fixed by

Related discussion:
text: return tokenizeToString(languageService, code, languageId); } }), <del> MarkedGfmHeadings.gfmHeadingId(), </del> <ins> markedGfmHeadingIdPlugin(), </ins> ...(options?.markedExtensions ?? []), );
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.93.0-insider (user setup) Commit: Date: 2024-09-04T13:13:15.344Z Electron: 30.4.0 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0. OS Version: Windows 11 Insiders Steps to Reproduce: in the first paragraph doesn't appear to be a link, which I was surprised about: ! I hover over it, I see it's supposed to be a link, but clicking on it does nothing: ! The other docs links at the bottom of the playground appear correctly as links and do open when I click on them: !
This seems related to the bookmark issue we had in the release notes. The other bookmark links in the interactive playground don't work either.
Fixed the toc links. Need another fix for the documentation link too (which use command uris)
The Editor Playground is not showing at all anymore in the latest insiders. When selecting the Editor Playground menu item, a black editor comes up.
hm working from oss builds. Insiders, it seems like the error is:
Actually unrelated. Seems like a duplicate of and fixed by

Related discussion:
text: const snippets: Promise<IReference<ITextEditorModel>>[] = []; let i = 0; <del> const renderer = new marked.Renderer(); renderer.code = ({ lang }: Tokens.Code) => { </del> <ins> const renderer = new marked.marked.Renderer(); renderer.code = ({ lang }: marked.Tokens.Code) => { </ins> i++; const resource = this.options.resource.with({ scheme: Schemas.walkThroughSnippet, fragment: `${i}.${lang}` }); snippets.push(this.textModelResolverService.createModelReference(resource)); return `<div id="snippet-${resource.fragment}" class="walkThroughEditorContainer" ></div>`; }; <del> content = marked(content, { async: false, renderer }); </del> <ins> const m = new marked.Marked({ renderer }, markedGfmHeadingIdPlugin()); content = m.parse(content, { async: false }); </ins> return Promise.all(snippets) .then(refs => new WalkThroughModel(content, refs)); });
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.93.0-insider (user setup) Commit: Date: 2024-09-04T13:13:15.344Z Electron: 30.4.0 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0. OS Version: Windows 11 Insiders Steps to Reproduce: in the first paragraph doesn't appear to be a link, which I was surprised about: ! I hover over it, I see it's supposed to be a link, but clicking on it does nothing: ! The other docs links at the bottom of the playground appear correctly as links and do open when I click on them: !
This seems related to the bookmark issue we had in the release notes. The other bookmark links in the interactive playground don't work either.
Fixed the toc links. Need another fix for the documentation link too (which use command uris)
The Editor Playground is not showing at all anymore in the latest insiders. When selecting the Editor Playground menu item, a black editor comes up.
hm working from oss builds. Insiders, it seems like the error is:
Actually unrelated. Seems like a duplicate of and fixed by

Related discussion:
text: /** * Sanitizes the given `value` and reset the given `node` with it. */ <del> export function safeInnerHtml(node: HTMLElement, value: string): void { </del> <ins> export function safeInnerHtml(node: HTMLElement, value: string, extraDomPurifyConfig?: dompurify.Config): void { </ins> const hook = hookDomPurifyHrefAndSrcSanitizer(defaultSafeProtocols); try { <del> const html = dompurify.sanitize(value, defaultDomPurifyConfig); </del> <ins> const html = dompurify.sanitize(value, { ...defaultDomPurifyConfig, ...extraDomPurifyConfig }); </ins> node.innerHTML = html as unknown as string; } finally { hook.dispose();
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.93.0-insider (user setup) Commit: Date: 2024-09-04T13:13:15.344Z Electron: 30.4.0 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0. OS Version: Windows 11 Insiders Steps to Reproduce: in the first paragraph doesn't appear to be a link, which I was surprised about: ! I hover over it, I see it's supposed to be a link, but clicking on it does nothing: ! The other docs links at the bottom of the playground appear correctly as links and do open when I click on them: !
This seems related to the bookmark issue we had in the release notes. The other bookmark links in the interactive playground don't work either.
Fixed the toc links. Need another fix for the documentation link too (which use command uris)
The Editor Playground is not showing at all anymore in the latest insiders. When selecting the Editor Playground menu item, a black editor comes up.
hm working from oss builds. Insiders, it seems like the error is:
Actually unrelated. Seems like a duplicate of and fixed by

Related discussion:
text: readonly token?: CancellationToken; } <del> /*marked.* </del> <ins> /** </ins> * Renders a string of markdown as a document. * * Uses VS Code's syntax highlighting code blocks.