jiebi/CodeConvo huggingface dataset:
Code change:
debugging the loaded scripts view open debugging, notice exception in the console can not reproduce with Stable so it might be that my listener refactoring caused this If you pause on exception you will see that caused it.
did you have a chance to look into this? Or would you like me to investigate? I suspect this is breaking the loaded scripts view and is the root cause for
no, please investigate since this and was working before, and I haven't touched this code for two weeks.
end session events are not arriving in As a consequence the tree for the session is not properly removed.
I see something differnetly, the end sessions are arriving however when the last session end arrives view starts refreshing the tree and while that is in progress the view gets disposed which throws an exception. Looking into a fix...
I have created a PR which address this issue

Related discussion:
text: private treeContainer: HTMLElement; private loadedScriptsItemType: IContextKey<string>; private settings: any; <ins> private shouldRefreshRecursive; </ins> constructor( options: IViewletViewOptions,
Code change:
debugging the loaded scripts view open debugging, notice exception in the console can not reproduce with Stable so it might be that my listener refactoring caused this If you pause on exception you will see that caused it.
did you have a chance to look into this? Or would you like me to investigate? I suspect this is breaking the loaded scripts view and is the root cause for
no, please investigate since this and was working before, and I haven't touched this code for two weeks.
end session events are not arriving in As a consequence the tree for the session is not properly removed.
I see something differnetly, the end sessions are arriving however when the last session end arrives view starts refreshing the tree and while that is in progress the view gets disposed which throws an exception. Looking into a fix...
I have created a PR which address this issue

Related discussion:
text: this.loadedScriptsItemType = CONTEXT_LOADED_SCRIPTS_ITEM_TYPE.bindTo(contextKeyService); } <ins> @memoize private get treeRefreshScheduler(): RunOnceScheduler { return new RunOnceScheduler(() => { if (this.tree) { this.tree.refresh(undefined, this.shouldRefreshRecursive); this.shouldRefreshRecursive = false; } }, 300); } </ins> protected renderBody(container: HTMLElement): void { dom.addClass(container, 'debug-loaded-scripts');
Code change:
debugging the loaded scripts view open debugging, notice exception in the console can not reproduce with Stable so it might be that my listener refactoring caused this If you pause on exception you will see that caused it.
did you have a chance to look into this? Or would you like me to investigate? I suspect this is breaking the loaded scripts view and is the root cause for
no, please investigate since this and was working before, and I haven't touched this code for two weeks.
end session events are not arriving in As a consequence the tree for the session is not properly removed.
I see something differnetly, the end sessions are arriving however when the last session end arrives view starts refreshing the tree and while that is in progress the view gets disposed which throws an exception. Looking into a fix...
I have created a PR which address this issue

Related discussion:
text: const root = new RootTreeItem(this.debugService.getModel(), this.environmentService, this.contextService); this.tree.setInput(root); <del> let timeout: number; </del> const registerLoadedSourceListener = (session: ISession) => { this.disposables.push(session.onDidLoadedSource(event => { const sessionRoot = root.add(session); sessionRoot.addPath(event.source); <del> clearTimeout(timeout); timeout = setTimeout(() => { if (this.tree) { this.tree.refresh(root, true); } }, 300); </del> <ins> this.shouldRefreshRecursive = true; this.treeRefreshScheduler.schedule(); </ins> })); };
Code change:
debugging the loaded scripts view open debugging, notice exception in the console can not reproduce with Stable so it might be that my listener refactoring caused this If you pause on exception you will see that caused it.
did you have a chance to look into this? Or would you like me to investigate? I suspect this is breaking the loaded scripts view and is the root cause for
no, please investigate since this and was working before, and I haven't touched this code for two weeks.
end session events are not arriving in As a consequence the tree for the session is not properly removed.
I see something differnetly, the end sessions are arriving however when the last session end arrives view starts refreshing the tree and while that is in progress the view gets disposed which throws an exception. Looking into a fix...
I have created a PR which address this issue

Related discussion:
text: this.debugService.getModel().getSessions().forEach(registerLoadedSourceListener); this.disposables.push(this.debugService.onDidEndSession(session => { <del> clearTimeout(timeout); </del> root.remove(session.getId()); <del> if (this.tree) { this.tree.refresh(root, false); } </del> <ins> this.treeRefreshScheduler.schedule(); </ins> })); }
Code change:
debugging the loaded scripts view open debugging, notice exception in the console can not reproduce with Stable so it might be that my listener refactoring caused this If you pause on exception you will see that caused it.
did you have a chance to look into this? Or would you like me to investigate? I suspect this is breaking the loaded scripts view and is the root cause for
no, please investigate since this and was working before, and I haven't touched this code for two weeks.
end session events are not arriving in As a consequence the tree for the session is not properly removed.
I see something differnetly, the end sessions are arriving however when the last session end arrives view starts refreshing the tree and while that is in progress the view gets disposed which throws an exception. Looking into a fix...
I have created a PR which address this issue

Related discussion:
text: this.settings[LoadedScriptsView.MEMENTO] = !this.isExpanded(); super.shutdown(); } <ins> dispose(): void { super.dispose(); this.tree = undefined; } </ins> } // A good example of data source, renderers, action providers and accessibilty providers can be found in the callStackView.ts
Code change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.28.0 (1.28.0) OS Version: macOS High Sierra 10.13.6 (17G65) Steps to Reproduce: a markdown file preview to the side ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.721 --- <!-- score: 0.717 --- <!-- score: 0.672 --- <!-- score: 0.651 --- <!-- score: 0.645 --<!-- potentialduplicatescomment --

Related discussion:
text: } .hljs-addition { <del> background-color: #144212; </del> <ins> background-color: var(--vscode-diffEditor-insertedTextBackground, rgba(155, 185, 85, 0.2)); color: rgb(155, 185, 85); </ins> display: inline-block; width: 100%; } .hljs-deletion { <del> background-color: #600; </del> <ins> background: var(--vscode-diffEditor-removedTextBackground, rgba(255, 0, 0, 0.2)); color: rgb(255, 0, 0); </ins> display: inline-block; width: 100%; }
Code change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.28.0 (1.28.0) OS Version: macOS High Sierra 10.13.6 (17G65) Steps to Reproduce: a markdown file preview to the side ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.721 --- <!-- score: 0.717 --- <!-- score: 0.672 --- <!-- score: 0.651 --- <!-- score: 0.645 --<!-- potentialduplicatescomment --

Related discussion:
text: .vscode-light .hljs-literal, .vscode-light .hljs-template-tag, .vscode-light .hljs-template-variable, <del> .vscode-light .hljs-type, .vscode-light .hljs-addition { </del> <ins> .vscode-light .hljs-type { </ins> color: #a31515; } <del> .vscode-light .hljs-deletion, </del> .vscode-light .hljs-selector-attr, .vscode-light .hljs-selector-pseudo, .vscode-light .hljs-meta {
Code change:
Voiceover does not read new option details because of describedby issue. May require the new ARIA combo box model.
Any problem with me creating new tags for NVDA and voiceover like there is already a tag for jaws? Accessibility-NVDA Accessibility-Voiceover I will also volunteer to do triage on accessibility issues if I can identify them.

Related discussion:
text: white-space: nowrap; } <del> .monaco-select-box-dropdown-container > .select-box-dropdown-list-container .monaco-list .monaco-list-row > .option-text-description { display: none; </del> <ins> /* Accepted CSS hiding technique for accessibility reader text  */ /* https://webaim.org/techniques/css/invisiblecontent/ */ .monaco-select-box-dropdown-container > .select-box-dropdown-list-container .monaco-list .monaco-list-row > .visually-hidden { position: absolute; left: -10000px; top: auto; width: 1px; height: 1px; overflow: hidden; </ins> } .monaco-select-box-dropdown-container > .select-box-dropdown-container-width-control {
Code change:
Voiceover does not read new option details because of describedby issue. May require the new ARIA combo box model.
Any problem with me creating new tags for NVDA and voiceover like there is already a tag for jaws? Accessibility-NVDA Accessibility-Voiceover I will also volunteer to do triage on accessibility issues if I can identify them.

Related discussion:
text: import 'vs/css!./selectBoxCustom'; <del> import * as nls from 'vs/nls'; </del> import { IDisposable, dispose } from 'vs/base/common/lifecycle'; import { Event, Emitter, chain } from 'vs/base/common/event'; import { KeyCode, KeyCodeUtils } from 'vs/base/common/keyCodes';
Code change:
Voiceover does not read new option details because of describedby issue. May require the new ARIA combo box model.
Any problem with me creating new tags for NVDA and voiceover like there is already a tag for jaws? Accessibility-NVDA Accessibility-Voiceover I will also volunteer to do triage on accessibility issues if I can identify them.

Related discussion:
text: data.root = container; data.optionText = dom.append(container, $('.option-text')); data.optionDescriptionText = dom.append(container, $('.option-text-description')); <ins> dom.addClass(data.optionDescriptionText, 'visually-hidden'); </ins> return data; }
Code change:
Voiceover does not read new option details because of describedby issue. May require the new ARIA combo box model.
Any problem with me creating new tags for NVDA and voiceover like there is already a tag for jaws? Accessibility-NVDA Accessibility-Voiceover I will also volunteer to do triage on accessibility issues if I can identify them.

Related discussion:
text: const optionDisabled = (<ISelectOptionItem>element).optionDisabled; data.optionText.textContent = optionText; <del> data.root.setAttribute('aria-label', nls.localize('selectAriaOption', "{0}", optionText) + ',.'); </del> if (typeof element.optionDescriptionText === 'string') { const optionDescriptionId = (optionText.replace(/ /g, '_').toLowerCase() + '_description_' + data.root.id); <del> data.root.setAttribute('aria-describedby', optionDescriptionId); </del> <ins> data.optionText.setAttribute('aria-describedby', optionDescriptionId); </ins> data.optionDescriptionText.id = optionDescriptionId; <del> data.optionDescriptionText.setAttribute('aria-label', element.optionDescriptionText); </del> <ins> data.optionDescriptionText.innerText = element.optionDescriptionText; </ins> } <del> // Workaround for list labels data.root.setAttribute('aria-selected', 'true'); </del> // pseudo-select disabled option if (optionDisabled) { dom.addClass((<HTMLElement>data.root), 'option-disabled');
Code change:
Issue Type: <bBug</bWith at least one folder loaded in Code: to Code Preferences Settings on either "User Settings" or "Workspace Settings" Notice tab spacing is jumpy when changing active selection. It should NOT be as jumpy. I believe it's caused by the text being bolded on active selection. <iDesired</i! <iActual</i! VS Code version: Code 1.28.2 (, 2018-10-17T00:18:43.347Z) OS version: Darwin x64 18.0.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Here's the
I'm not sure about this change, I think the bold is necessary to make the selected tab noticeable. Some themes hide the underline on the selected item, and in some themes, the color difference is not really noticeable. So I would worry that this would make it impossible to tell which tab is selected. I also don't really have an issue with the slight shifting, I've never noticed it before now.
We should try to remove this shift as it's not really smooth. In our other tabs (panels, settings json) we don't use alternate font-weights for active/inactive, so I think we should keep them consistent and the same. Alternatively, if we really want to make the states look different we could adjust the opacity (just like the other tabs) as long as they pass the color contrast ratio: !
I agree that it's not smooth. It's also not consistent with the other tabs in the product. There is a hack that can remove the shifting (discussed with this ), however I think that might be overdoing it to achieve this effect. I would add the opacity change as well to help reinforce the two states.
Should I just borrow the inactive color from the panel tabs, at least for the builtin themes? Or if I should use opacity, can you tell me what color/opacity to use? Looking through some popular ones, I don't think this change would be a problem for that many other themes really... Also for folder settings, the folder name and string "Folder Settings" are currently distinguished by size and color, so we might still need 3 colors.
Actually the current panel tab colors in Monokai don't meet the contrast requirement: ! !
We only need to meet the color contrast on the themes we own, which is light/dark/hc. Here's the contrast on the inactive text: Here's the colors and opacity for the active/inactive panels: For the folder settings, you can change the opacity to (which passes) and will end up looking like this: !
Not using the panel foreground color because the background is not always the same, but I think it looks good as is after the PR.

Related discussion:
text: } .settings-editor > .settings-header > .settings-header-controls .settings-tabs-widget .action-label.checked { <del> font-weight: 500; </del> opacity: 1; }
Code change:
Issue Type: <bBug</b VS Code version: Code 1.28.2 (, 2018-10-17T00:23:51.859Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.504 --- <!-- score: 0.472 --- <!-- score: 0.457 --<!-- potentialduplicatescomment --

Related discussion:
text: import 'vs/css!./media/settingsWidgets'; import { localize } from 'vs/nls'; import { IContextViewService } from 'vs/platform/contextview/browser/contextView'; <del> import { foreground, inputBackground, inputBorder, inputForeground, listActiveSelectionBackground, listActiveSelectionForeground, listHoverBackground, listHoverForeground, listInactiveSelectionBackground, listInactiveSelectionForeground, registerColor, selectBackground, selectBorder, selectForeground, textLinkForeground, textPreformatForeground, editorWidgetBorder } from 'vs/platform/theme/common/colorRegistry'; </del> <ins> import { foreground, inputBackground, inputBorder, inputForeground, listActiveSelectionBackground, listActiveSelectionForeground, listHoverBackground, listHoverForeground, listInactiveSelectionBackground, listInactiveSelectionForeground, registerColor, selectBackground, selectBorder, selectForeground, textLinkForeground, textPreformatForeground, editorWidgetBorder, textLinkActiveForeground } from 'vs/platform/theme/common/colorRegistry'; </ins> import { attachButtonStyler, attachInputBoxStyler } from 'vs/platform/theme/common/styler'; import { ICssStyleCollector, ITheme, IThemeService, registerThemingParticipant } from 'vs/platform/theme/common/themeService'; import { disposableTimeout } from 'vs/base/common/async';
Code change:
Issue Type: <bBug</b VS Code version: Code 1.28.2 (, 2018-10-17T00:23:51.859Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.504 --- <!-- score: 0.472 --- <!-- score: 0.457 --<!-- potentialduplicatescomment --

Related discussion:
text: collector.addRule(`.monaco-select-box-dropdown-container > .select-box-details-pane > .select-box-description-markdown a > code { color: ${link}; }`); } <ins> const activeLink = theme.getColor(textLinkActiveForeground); if (activeLink) { collector.addRule(`.settings-editor > .settings-body > .settings-tree-container .setting-item .setting-item-description-markdown a:hover, .settings-editor > .settings-body > .settings-tree-container .setting-item .setting-item-description-markdown a:active { color: ${activeLink}; }`); collector.addRule(`.settings-editor > .settings-body > .settings-tree-container .setting-item .setting-item-description-markdown a:hover > code, .settings-editor > .settings-body > .settings-tree-container .setting-item .setting-item-description-markdown a:active > code { color: ${activeLink}; }`); collector.addRule(`.monaco-select-box-dropdown-container > .select-box-details-pane > .select-box-description-markdown a:hover, .monaco-select-box-dropdown-container > .select-box-details-pane > .select-box-description-markdown a:active { color: ${activeLink}; }`); collector.addRule(`.monaco-select-box-dropdown-container > .select-box-details-pane > .select-box-description-markdown a:hover > code, .monaco-select-box-dropdown-container > .select-box-details-pane > .select-box-description-markdown a:active > code { color: ${activeLink}; }`); } </ins> const headerForegroundColor = theme.getColor(settingsHeaderForeground); if (headerForegroundColor) { collector.addRule(`.settings-editor > .settings-header > .settings-header-controls .settings-tabs-widget .action-label.checked { color: ${headerForegroundColor}; border-bottom-color: ${headerForegroundColor}; }`);
Code change:
Issue Type: <bBug</bIn Lua, when comment contains "function", like: -- blah blah function then type Enter, the next line will auto indent for one tab, but it shoud not auto indent. VS Code version: Code - OSS 1.27.2 (, 2018-09-14T00:41:55.375Z) OS version: Linux x64 4.18.16-arch1-1-ARCH <details<summarySystem Info</summary </details<details<summaryExtensions (5)</summaryExtensionVersion ------ vscode-language-pack-zh-hans1.27.2 python2018.10.1 cpptools0.20.1 Go0.7.0 markdown-all-in-one1.7.0 </details<!-- generated by issue reporter --
Introduced by

Related discussion:
text: ["'", "'"] ], "indentationRules": { <del> "increaseIndentPattern": "^s*((b(else|function|then|do|repeat)b((?!b(end|until)b).)*)|({s*))$", </del> <ins> "increaseIndentPattern": "^((?!(--)).)*((b(else|function|then|do|repeat)b((?!b(end|until)b).)*)|({s*))$", </ins> "decreaseIndentPattern": "^s*((b(elseif|else|end|until)b)|(})|()))" } }
Code change:
Issue Type: <bBug</bthe settings editor a setting that has a dropdown so that the options are displayed editors The dropdown remains open: ! Not sure if this is an issue with the select itself, or the settings editor. VS Code version: Code - Insiders 1.30.0-insider (, 2018-12-03T06:12:08.874Z) OS version: Darwin x64 18.0.0 <!-- generated by issue reporter --
Nice, for me it even jumps to the corner of the screen for some reason after switching to the editor. ! I think we will need some way to hide the list when the settings editor hides? Is there a way to force it to hide from outside currently?
Ha, I was afraid this would occur. The _sticky flag that Jackson for debugging was changed to true in a recent PR. I was going to ask if this was intentional. My Insiders was just old enough to not have this. was this left as 'true' by mistake when you're doing some mouse work for list? I will verify if this is the case and fix unless requested otherwise...
Good catch, it looks like a mistake, I'll revert it so it can get into tomorrow's build. Let me know if that's not the case
Actually looks like you are on it go ahead if you want to create a PR.
Fixed with,
- you have to merge, I'm not allowed :-(

Related discussion:
text: private selectionDetailsPane: HTMLElement; private _skipLayout: boolean = false; <del> private _sticky: boolean = true; // for dev purposes only </del> <ins> private _sticky: boolean = false; // for dev purposes only </ins> constructor(options: string[], selected: number, contextViewProvider: IContextViewProvider, styles: ISelectBoxStyles, selectBoxOptions?: ISelectBoxOptions) {
Code change:
Issue Type: <bBug</bUsing similar contribution in extension: Command palette is doing it correctly: Keybinginds is only showing . VS Code version: Code 1.29.1 (, 2018-11-15T19:13:36.375Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.447 --<!-- potentialduplicatescomment --
I'm going to work on this.

Related discussion:
text: private static getCommandLabel(menuCommand: ICommandAction, editorActionLabel: string): string { if (menuCommand) { <del> return typeof menuCommand.title === 'string' ? menuCommand.title : menuCommand.title.value; </del> <ins> let category; if (menuCommand.category) { category = typeof menuCommand.category === 'string' ? menuCommand.category : menuCommand.category.value; } const title = typeof menuCommand.title === 'string' ? menuCommand.title : menuCommand.title.value; return category ? `${category}: ${title}` : title; </ins> } if (editorActionLabel) {
Code change:
Issue Type: <bBug</bRepro steps: settings to for a setting screen really large :bug: Content does not center with the header <img width="1282" alt="image" src="https://user-"VS Code version: Code - Insiders 1.31.0-insider (, 2019-01-23T06:13:04.232Z) OS version: Darwin x64 18.2.0 <details<summarySystem Info</summary </details<details<summaryExtensions (6)</summaryExtensionVersion ------ vscode-browser-preview0.2.5 vscode-svgviewer1.4.7 prettier-vscode1.7.3 vscode-typescript-tslint-plugin0.3.0 debugger-for-chrome4.11.1 code-settings-sync3.2.4 (5 theme extensions excluded) </details<!-- generated by issue reporter --

Related discussion:
text: text-decoration: underline; } <del> .settings-editor.no-toc-search > .settings-body .settings-tree-container .monaco-list-rows, </del> .settings-editor.narrow-width > .settings-body .settings-tree-container .monaco-list-rows { margin-left: 0px; }