jiebi/CodeConvo huggingface dataset:
Code change:
Testing Once again, I'm not sure what the norms are here, but would it be useful to have the actions in the status bar show in the accessibly view? <img width="607" alt="image" src=""
Hi yes that would make sense. Good point!

Related discussion:
text: return ''; } if (renderedPart.type === 'statusBar') { <del> return localize('hoverAccessibilityStatusBar', "This is a hover status bar."); </del> <ins> const statusBarDescription = [localize('hoverAccessibilityStatusBar', "This is a hover status bar.")]; for (const action of renderedPart.actions) { const keybinding = action.actionKeybindingLabel; if (keybinding) { statusBarDescription.push(localize('hoverAccessibilityStatusBarActionWithKeybinding', "It has an action with label {0} and keybinding {1}.", action.actionLabel, keybinding)); } else { statusBarDescription.push(localize('hoverAccessibilityStatusBarActionWithoutKeybinding', "It has an action with label {0}.", action.actionLabel)); } } return statusBarDescription.join('n'); </ins> } return renderedPart.participant.getAccessibleContent(renderedPart.hoverPart); }
Code change:
Testing Once again, I'm not sure what the norms are here, but would it be useful to have the actions in the status bar show in the accessibly view? <img width="607" alt="image" src=""
Hi yes that would make sense. Good point!

Related discussion:
text: export class EditorHoverStatusBar extends Disposable implements IEditorHoverStatusBar { public readonly hoverElement: HTMLElement; <ins> public readonly actions: HoverAction[] = []; </ins> private readonly actionsElement: HTMLElement; private _hasContent: boolean = false;
Code change:
Testing Once again, I'm not sure what the norms are here, but would it be useful to have the actions in the status bar show in the accessibly view? <img width="607" alt="image" src=""
Hi yes that would make sense. Good point!

Related discussion:
text: const keybinding = this._keybindingService.lookupKeybinding(actionOptions.commandId); const keybindingLabel = keybinding ? keybinding.getLabel() : null; this._hasContent = true; <del> return this._register(HoverAction.render(this.actionsElement, actionOptions, keybindingLabel)); </del> <ins> const action = this._register(HoverAction.render(this.actionsElement, actionOptions, keybindingLabel)); this.actions.push(action); return action; </ins> } public append(element: HTMLElement): HTMLElement {
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.91.0 (Universal) OS Version: Darwin arm64 23.5.0 Steps to Reproduce: new profile test to new profile in Devcontainer sample container is loaded without extensions. Opening in DevContainer with the default profile works correctly. Works correctly with the previous version of vscode 1.90.2
Same For Me
+1 extensions from are not enabled in the container when using a custom profile. Although the container logs does report that the extension was successfully installed, and I can see it is installed in the container, in . It's just not enabled when using a custom vscode profile.

Related discussion:
text: } extensionsToInstall.push({ extension: gallery, <del> options: { ...installOptions, installGivenVersion: !!version, isApplicationScoped: installedExtension?.isApplicationScoped }, </del> <ins> options: { ...installOptions, installGivenVersion: !!version, isApplicationScoped: installOptions.isApplicationScoped || installedExtension?.isApplicationScoped }, </ins> }); }));
Code change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --VSCode Version 1.91.0 introduces a new "New Window with Profile menu item". I see it's not currently available in the command palette, like the "New Window" command. <img width="603" alt="image" src=""It would be nice to have this available in the command palette.

Related discussion:
text: this._register(this.registerSwitchProfileAction()); this.registerOpenProfileSubMenu(); <ins> this.registerNewWindowWithProfileAction(); </ins> this.registerProfilesActions(); this._register(this.userDataProfilesService.onDidChangeProfiles(() => this.registerProfilesActions()));
Code change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --VSCode Version 1.91.0 introduces a new "New Window with Profile menu item". I see it's not currently available in the command palette, like the "New Window" command. <img width="603" alt="image" src=""It would be nice to have this available in the command palette.

Related discussion:
text: }); } <ins> private registerNewWindowWithProfileAction(): IDisposable { return registerAction2(class NewWindowWithProfileAction extends Action2 { constructor() { super({ id: `workbench.profiles.actions.newWindowWithProfile`, title: localize2('newWindowWithProfile', "New Window with Profile..."), category: PROFILES_CATEGORY, precondition: HAS_PROFILES_CONTEXT, f1: true, }); } async run(accessor: ServicesAccessor) { const quickInputService = accessor.get(IQuickInputService); const userDataProfilesService = accessor.get(IUserDataProfilesService); const hostService = accessor.get(IHostService); const pick = await quickInputService.pick( userDataProfilesService.profiles.map(profile => ({ label: profile.name, profile })), { title: localize('new window with profile', "New Window with Profile"), placeHolder: localize('pick profile', "Select Profile"), canPickMany: false }); if (pick) { return hostService.openWindow({ remoteAuthority: null, forceProfile: pick.profile.name }); } } }); } </ins> private registerNewWindowAction(profile: IUserDataProfile): IDisposable { const disposables = new DisposableStore();
Code change:
Type: <bBug</bscreen ready accessiblity mode to be on. Look for screen reader optimized at the bottom bar of VS Code. settings, search for "accessibility volume". Set it to 0. an action in a VS Code editor that creates a sound (which you haven't configured to be "off"/"never"), eg trigger an inline copilot suggestion. a sound (make sure your computer audio is on) even though you set volume to 0. VS Code version: Code 1.91.1 (, 2024-07-09T22:07:46.768Z) OS version: Darwin arm64 23.5.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (71)</summaryExtensionVersion ------ better-comments3.0.2 quitcontrol-vscode4.0.0 solarized-light-custom4.0.1 solidjs3.0.7 vscode-tailwindcss0.12.5 turbo-console-log2.10.4 ruff2024.30.0 regex0.4.0 doxdocgen1.4.0 vscode-eslint3.0.10 xml2.5.1 es7-react-js-snippets3.1.1 gitlens15.2.0 prettier-vscode10.4.0 figma-vscode-extension0.3.5 auto-rename-tag0.1.10 shell-format7.2.5 kotlin0.2.34 macros1.2.1 copilot1.213.0 copilot-chat0.17. vscode-pull-request-github0.92.0 go0.41.4 gti-vscode0.6.1 vscode-graphql-syntax1.3.6 better-cpp-syntax1.27.1 vscode-go-template0.2.1 cmake-language-support-vscode0.0.9 Kotlin1.7.1 git-graph1.30.0 vscode-docker1.29.1 vscode-dotnet-runtime2.0.9 black-formatter2024.3. debugpy2024.9. isort2023.10.1 python2024.10.0 vscode-pylance2024.7.1 jupyter2024.6.0 jupyter-keymap1.1.2 jupyter-renderers1.0.18 vscode-jupyter-cell-tags0.1.9 vscode-jupyter-slideshow0.1.6 remote-containers0.375.1 remote-ssh0.112.0 remote-ssh-edit0.86.0 remote-wsl0.88.2 vscode-remote-extensionpack0.25.0 cmake-tools1.18.43 cpptools1.20.5 cpptools-extension-pack1.3.0 remote-explorer0.4.3 remote-server1.5.2 test-adapter-converter0.1.9 vsliveshare1.0.5932 vsix-viewer1.0.5 vscode-hack2.20.0 quicktype23.0.170 webgl-glsl-editor1.3.8 code-spell-checker3.0.1 tauri-vscode0.2.6 blueprint3.0.0 best-dark-themes-pack1.0.2 best-light-themes-pack1.0.2 cmake0.0.17 vscode-lldb1.10.0 vscode-swiftformat1.6.10 change-case1.0.0 luahelper0.2.28 pretty-ts-errors0.5.4 markdown-all-in-one3.6.2 material-theme3.17.2 (28 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
thanks for taking a look ! i believe this will resolve as well
Specifically the setting doesn't get saved to Even if you write it manually in , VSCode removes it on next start. Both and have this problem.

Related discussion:
text: } private getVolumeInPercent(): number { <del> const volume = this.configurationService.getValue<number>('accessibilitySignals.volume'); </del> <ins> const volume = this.configurationService.getValue<number>('accessibility.signalOptions.volume'); </ins> if (typeof volume !== 'number') { return 50; }
Code change:
Postgres supports dollar quoted strings as an alternative to regular strings. This is useful when you need to include the character itself but don't want to escape it. The official documentation can be found . Unfortunately, the default SQL highlighter in VSCode does not seem to support this syntax. Steps to Reproduce to a new file the "SQL" language mode the following content: Expected should not start a new string. The content between and should be identified as a string and highlighted as such. Actual ! Additional context Version: 1.91.1 Commit: User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36 Embedder: Also tested in the desktop version with identical results.
Note that there may be good reason the editor tries to highlight code in the dollar quoted block. Dollar quoted strings are often used to declare function bodies in postgres and there are therefore (perhaps most commonly) instances where the content inside the dollar signs would be better off using "regular" sql highlighting. However, the reported issue is very annoying as it breaks highlighting for the rest of the file. If implementing a full parser with support for these types of "sometimes strings" requires too much effort, a passable alternative would be to at least stop the highlighter from leaking outside the dollar quoted scope.
Th grammar we have is for MS SQL and doesn't support features outside that. Duplicate of
In that case, I think you should rename the user-visible language mode to "MSSQL" rather than "SQL". I find just calling it "SQL" to be a deceptive marketing practice if you are not going to support other SQL dialects in it.
It is fair to say that MS SQL won't work for all SQL flavors. I will discuss renaming it with the team.
Based on some quick digging, MS SQL uses Transact-SQL (T-SQL). The most appropriate thing to rename the built in SQL grammar to would be T-SQL. However, I'm not sure that T-SQL will mean something to most users.
I'm going to wait and try renaming at the very beginning of our next milestone so that I can see if any insiders users are thrown off first.
I think T-SQL is not well known enough and will be confusing. I'll try renaming to MS SQL.
<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the label directly, or comment .
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
To verify: Open a file in VS Code Open the language picker from the status bar Verify that you don't see SQL, but instead see MS SQL

Related discussion:
text: ".dsql" ], "aliases": [ <del> "SQL" </del> <ins> "MS SQL", "T-SQL" </ins> ], "configuration": "./language-configuration.json" }
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No, this is an extension-related issue that arises across extensions with walkthroughs <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.91.1 OS Version: Windows 11 Extension walkthroughs are not launching upon install. Expected behavior: walkthrough launches automatically upon install. Tested on C# Dev Kit extension and Python extension. Seemed to work in 1.90.0 but does not work in 1.91.1. Steps to Reproduce [Windows Sandbox]: a Windows Sandbox Edge and download VS Code (stable) from the VS Code website the C# Dev Kit extension. Note: Upon install the walkthrough is supposed to launch automatically. This is not happening, but I can manually open the walkthrough using these steps. command palette. command 'Welcome: Open Walkthrough' 'Get Started with C# Dev Kit' ! steps 3-7 with the Python extension. Same behavior. Steps to Reproduce [VS Code stable and VS Code insider]: VS Code C# Dev Kit (if you have it installed) VS Code C# Dev Kit extension. Note: Upon install the walkthrough is supposed to launch automatically. This is not happening, but I can manually open the walkthrough using these steps. command palette. command 'Welcome: Open Walkthrough' 'Get Started with C# Dev Kit' steps 2-7 with the Python extension. Same behavior.
closedWith
using the steps above, I am not seeing the walkthrough open when I reinstall the extension
Was just talking with about this- if you've had it installed in the past, it won't work, but for me it works in a window with a clean user-data-dir

Related discussion:
text: installed.forEach(ext => this.progressByEvent(`extensionInstalled:${ext.identifier.id.toLowerCase()}`)); }); <del> this._register(this.extensionManagementService.onDidInstallExtensions(async (result) => { const hadLastFoucs = await this.hostService.hadLastFocus(); </del> <ins> this._register(this.extensionManagementService.onDidInstallExtensions((result) => { </ins> for (const e of result) { const skipWalkthrough = e?.context?.[EXTENSION_INSTALL_SKIP_WALKTHROUGH_CONTEXT] || e?.context?.[EXTENSION_INSTALL_DEP_PACK_CONTEXT]; // If the window had last focus and the install didn't specify to skip the walkthrough // Then add it to the sessionInstallExtensions to be opened <del> if (hadLastFoucs && !skipWalkthrough) { </del> <ins> if (!skipWalkthrough) { </ins> this.sessionInstalledExtensions.add(e.identifier.id.toLowerCase()); } this.progressByEvent(`extensionInstalled:${e.identifier.id.toLowerCase()}`);
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No, this is an extension-related issue that arises across extensions with walkthroughs <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.91.1 OS Version: Windows 11 Extension walkthroughs are not launching upon install. Expected behavior: walkthrough launches automatically upon install. Tested on C# Dev Kit extension and Python extension. Seemed to work in 1.90.0 but does not work in 1.91.1. Steps to Reproduce [Windows Sandbox]: a Windows Sandbox Edge and download VS Code (stable) from the VS Code website the C# Dev Kit extension. Note: Upon install the walkthrough is supposed to launch automatically. This is not happening, but I can manually open the walkthrough using these steps. command palette. command 'Welcome: Open Walkthrough' 'Get Started with C# Dev Kit' ! steps 3-7 with the Python extension. Same behavior. Steps to Reproduce [VS Code stable and VS Code insider]: VS Code C# Dev Kit (if you have it installed) VS Code C# Dev Kit extension. Note: Upon install the walkthrough is supposed to launch automatically. This is not happening, but I can manually open the walkthrough using these steps. command palette. command 'Welcome: Open Walkthrough' 'Get Started with C# Dev Kit' steps 2-7 with the Python extension. Same behavior.
closedWith
using the steps above, I am not seeing the walkthrough open when I reinstall the extension
Was just talking with about this- if you've had it installed in the past, it won't work, but for me it works in a window with a clean user-data-dir

Related discussion:
text: this.storageService.store(walkthroughMetadataConfigurationKey, JSON.stringify([...this.metadata.entries()]), StorageScope.PROFILE, StorageTarget.USER); <del> if (sectionToOpen && this.configurationService.getValue<string>('workbench.welcomePage.walkthroughs.openOnInstall')) { </del> <ins> const hadLastFoucs = await this.hostService.hadLastFocus(); if (hadLastFoucs && sectionToOpen && this.configurationService.getValue<string>('workbench.welcomePage.walkthroughs.openOnInstall')) { </ins> type GettingStartedAutoOpenClassification = { owner: 'lramos15'; comment: 'When a walkthrthrough is opened upon extension installation';
Code change:
Connect to my mac with Remote-SSH See these errors from the server in the log (Remote-SSH output channel) doesn't seem to cause a problem but it's noisy and looks like an issue
could you point me at which line this is? Our stack beautifier doesn't work on server code afaik
I don't know which line it is, I only have that stack
It's this line: Somehow node-pty can return undefined for Doesn't seem like it should be possible considering or are the fallbacks for :
I'm seeing this on my own machine so could do some debugging if you want to add logs or something

Related discussion:
text: if (this._store.isDisposed) { return; } <del> this._currentTitle = ptyProcess.process; </del> <ins> // HACK: The node-pty API can return undefined somehow https://github.com/microsoft/vscode/issues/222323 this._currentTitle = (ptyProcess.process ?? ''); </ins> this._onDidChangeProperty.fire({ type: ProcessPropertyType.Title, value: this._currentTitle }); // If fig is installed it may change the title of the process const sanitizedTitle = this.currentTitle.replace(/ (figterm)$/g, '');
Code change:
Type: <bBug</bWelcome - Learn the Fyndamentals Safely browse and edit code Workspace Trust Link 404 - page not found VS Code version: Code 1.91.1 (, 2024-07-09T22:06:49.809Z) OS version: Windows_NT x64 10.0. Modes: Restricted <!-- generated by issue reporter --
could you please provide a screenshot of where this broken link is? Thanks!
Got it - issue is in the walkthrough. Fix incoming. Thanks for signaling this
Is this a candidate? The change has been merged to the main branch but not the release branch, and so the fix is not in the latest Insiders.
IMO, it can go with the next one.
<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the label directly, or comment .
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased

Related discussion:
text: { id: 'workspaceTrust', title: localize('gettingStarted.workspaceTrust.title', "Safely browse and edit code"), <del> description: localize('gettingStarted.workspaceTrust.description.interpolated', "{0} lets you decide whether your project folders should **allow or restrict** automatic code execution __(required for extensions, debugging, etc)__.nOpening a file/folder will prompt to grant trust. You can always {1} later.", Button(localize('workspaceTrust', "Workspace Trust"), 'https://github.com/microsoft/vscode-docs/blob/workspaceTrust/docs/editor/workspace-trust.md'), Button(localize('enableTrust', "enable trust"), 'command:toSide:workbench.action.manageTrustedDomain')), </del> <ins> description: localize('gettingStarted.workspaceTrust.description.interpolated', "{0} lets you decide whether your project folders should **allow or restrict** automatic code execution __(required for extensions, debugging, etc)__.nOpening a file/folder will prompt to grant trust. You can always {1} later.", Button(localize('workspaceTrust', "Workspace Trust"), 'https://code.visualstudio.com/docs/editor/workspace-trust'), Button(localize('enableTrust', "enable trust"), 'command:toSide:workbench.action.manageTrustedDomain')), </ins> when: 'workspacePlatform != 'webworker' && !isWorkspaceTrusted && workspaceFolderCount == 0', media: { type: 'svg', altText: 'Workspace Trust editor in Restricted mode and a primary button for switching to Trusted mode.', path: 'workspaceTrust.svg'
Code change:
Type: <bBug</bIssue Reporter, e.g. from off Command Palette. the first dropdown to VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-24T07:50:18.385Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
good catch, thanks! looks like an issue with the refactor

Related discussion:
text: if (styles.backgroundColor) { content.push(`.monaco-workbench { background-color: ${styles.backgroundColor} !important; }`); <ins> content.push(`.issue-reporter-body::-webkit-scrollbar-track { background-color: ${styles.backgroundColor}; }`); </ins> } if (styles.inputBorder) {
Code change:
Type: <bBug</bIssue Reporter, e.g. from off Command Palette. the first dropdown to VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-24T07:50:18.385Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
good catch, thanks! looks like an issue with the refactor

Related discussion:
text: content.push(`a:hover, .workbenchCommand:hover { color: ${styles.textLinkActiveForeground}; }`); } <del> if (styles.sliderBackgroundColor) { content.push(`::-webkit-scrollbar-thumb { background-color: ${styles.sliderBackgroundColor}; }`); } </del> if (styles.sliderActiveColor) { <del> content.push(`::-webkit-scrollbar-thumb:active { background-color: ${styles.sliderActiveColor}; }`); </del> <ins> content.push(`.issue-reporter-body::-webkit-scrollbar-thumb:active { background-color: ${styles.sliderActiveColor}; }`); </ins> } if (styles.sliderHoverColor) { <del> content.push(`::--webkit-scrollbar-thumb:hover { background-color: ${styles.sliderHoverColor}; }`); </del> <ins> content.push(`.issue-reporter-body::-webkit-scrollbar-thumb { background-color: ${styles.sliderHoverColor}; }`); content.push(`.issue-reporter-body::--webkit-scrollbar-thumb:hover { background-color: ${styles.sliderHoverColor}; }`); </ins> } if (styles.buttonBackground) {
Code change:
Type: <bBug</bIssue Reporter, e.g. from off Command Palette. the first dropdown to VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-24T07:50:18.385Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
good catch, thanks! looks like an issue with the refactor

Related discussion:
text: if (issueType === IssueType.PerformanceIssue && this.receivedSystemInfo && this.receivedPerformanceInfo) { return true; } <ins> if (issueType === IssueType.FeatureRequest) { return true; } </ins> } return false;