jiebi/CodeConvo huggingface dataset:
Code change:
Noticed how the process explorer is bundling and still. Can we not use Codicons for this? //cc
Oh this seems to be used in the issue reporter, not process explorer. But not sure how to actually see it...
are we actually using these icons? I'm not seeing it: !
it looks like these are only used when VSCode is connected to a remote to show the remote processes as well. I didn't even know we had that, pretty cool: ! Anyhow, my request still seems valid.
PR up at !

Related discussion:
text: private renderProcessGroupHeader(sectionName: string, body: HTMLElement, container: HTMLElement) { const headerRow = document.createElement('tr'); <del> const data = document.createElement('td'); data.textContent = sectionName; data.colSpan = 4; headerRow.appendChild(data); const twistie = document.createElement('img'); this.updateSectionCollapsedState(!this.collapsedStateCache.get(sectionName), body, twistie, sectionName); data.prepend(twistie); </del> <ins> const headerData = document.createElement('td'); headerData.colSpan = 4; headerRow.appendChild(headerData); const headerContainer = document.createElement('div'); headerContainer.className = 'header'; headerData.appendChild(headerContainer); const twistieContainer = document.createElement('div'); const twistieCodicon = new CodiconLabel(twistieContainer); this.updateSectionCollapsedState(!this.collapsedStateCache.get(sectionName), body, twistieCodicon, sectionName); headerContainer.appendChild(twistieContainer); const headerLabel = document.createElement('span'); headerLabel.textContent = sectionName; headerContainer.appendChild(headerLabel); </ins> <del> this.listeners.add(addDisposableListener(data, 'click', (e) => { </del> <ins> this.listeners.add(addDisposableListener(headerData, 'click', (e) => { </ins> const isHidden = body.classList.contains('hidden'); <del> this.updateSectionCollapsedState(isHidden, body, twistie, sectionName); </del> <ins> this.updateSectionCollapsedState(isHidden, body, twistieCodicon, sectionName); </ins> })); container.appendChild(headerRow);
Code change:
Issue Type: <bBug</bSemantic token colorization fails when a token type ID matching any object.prototype property name is provided. Some examples are: , and . is the most problematic name since it is likely to be used as a token type ID. Any string should be able to be used as a token type ID without causing the colorization to fail. Because tries to call on what was thought to be a but was actually a , which throws a TypeError and causes the colorization to fail. The easiest way is probably to use a instead of an object for . Another solution might be to instantiate using instead of an object literal in order to avoid the object.prototype. VS Code version: Code 1.47.2 (, 2020-07-15T18:22:15.161Z) OS version: Linux x64 4.19.0-9-amd64 <!-- generated by issue reporter --

Related discussion:
text: constructor() { this.tokenTypeById = {}; this.tokenModifierById = {}; <del> this.typeHierarchy = {}; </del> <ins> this.typeHierarchy = Object.create(null); </ins> } public registerTokenType(id: string, description: string, superType?: string, deprecationMessage?: string): void {
Code change:
Issue Type: <bBug</bSemantic token colorization fails when a token type ID matching any object.prototype property name is provided. Some examples are: , and . is the most problematic name since it is likely to be used as a token type ID. Any string should be able to be used as a token type ID without causing the colorization to fail. Because tries to call on what was thought to be a but was actually a , which throws a TypeError and causes the colorization to fail. The easiest way is probably to use a instead of an object for . Another solution might be to instantiate using instead of an object literal in order to avoid the object.prototype. VS Code version: Code 1.47.2 (, 2020-07-15T18:22:15.161Z) OS version: Linux x64 4.19.0-9-amd64 <!-- generated by issue reporter --

Related discussion:
text: const stylingSchemeEntry = getStylingSchemeEntry(description, deprecationMessage); this.tokenStylingSchema.properties[id] = stylingSchemeEntry; <del> this.typeHierarchy = {}; </del> <ins> this.typeHierarchy = Object.create(null); </ins> } public registerTokenModifier(id: string, description: string, deprecationMessage?: string): void {
Code change:
Issue Type: <bBug</bSemantic token colorization fails when a token type ID matching any object.prototype property name is provided. Some examples are: , and . is the most problematic name since it is likely to be used as a token type ID. Any string should be able to be used as a token type ID without causing the colorization to fail. Because tries to call on what was thought to be a but was actually a , which throws a TypeError and causes the colorization to fail. The easiest way is probably to use a instead of an object for . Another solution might be to instantiate using instead of an object literal in order to avoid the object.prototype. VS Code version: Code 1.47.2 (, 2020-07-15T18:22:15.161Z) OS version: Linux x64 4.19.0-9-amd64 <!-- generated by issue reporter --

Related discussion:
text: public deregisterTokenType(id: string): void { delete this.tokenTypeById[id]; delete this.tokenStylingSchema.properties[id]; <del> this.typeHierarchy = {}; </del> <ins> this.typeHierarchy = Object.create(null); </ins> } public deregisterTokenModifier(id: string): void {
Code change:
latest VS Code insiders, turn on Voice Over on mac P -notice how the screen reader does not read any of the items in the quick pick This works just fine on Linux and Windows. Also works fine for stable. So it seems like an chrome update in electron broke this I can also repro running in . In Firefox and Safari all is good. I can not reproduce in Chrome cannary, so there seems to be a fix in Chrome latest. Ideally we would find the fix in Chrome and backport it to our Electron. fyi And for Chrome smartness, maybe one of your collegues fixed something like this (should be related to )
I can add this to my list (which is starting to grow I'm afraid). BUT, you don't need smartness; you need the most excellent bisect-build tool! :smile: Docs here: Once you have the regression range, you just sit there as pre-built binaries are presented for you to try and mark as good or bad. Best. Tool. Ever. Lemme know if you have any questions or need help.
Thanks a lot. Let's see if already has this set up, otherwise I can also look into it.
Yup I can do the bisect shortly.
Bisect result for when regression was introduced: Potential candidate: https://chromium-
Looking for fix now.
Upstream fix: https://chromium- Crbug:
Impressive. Thanks a lot!

Related discussion:
text: disturl "https://atom.io/download/electron" <del> target "9.2.0" </del> <ins> target "9.2.1" </ins> runtime "electron"
Code change:
latest VS Code insiders, turn on Voice Over on mac P -notice how the screen reader does not read any of the items in the quick pick This works just fine on Linux and Windows. Also works fine for stable. So it seems like an chrome update in electron broke this I can also repro running in . In Firefox and Safari all is good. I can not reproduce in Chrome cannary, so there seems to be a fix in Chrome latest. Ideally we would find the fix in Chrome and backport it to our Electron. fyi And for Chrome smartness, maybe one of your collegues fixed something like this (should be related to )
I can add this to my list (which is starting to grow I'm afraid). BUT, you don't need smartness; you need the most excellent bisect-build tool! :smile: Docs here: Once you have the regression range, you just sit there as pre-built binaries are presented for you to try and mark as good or bad. Best. Tool. Ever. Lemme know if you have any questions or need help.
Thanks a lot. Let's see if already has this set up, otherwise I can also look into it.
Yup I can do the bisect shortly.
Bisect result for when regression was introduced: Potential candidate: https://chromium-
Looking for fix now.
Upstream fix: https://chromium- Crbug:
Impressive. Thanks a lot!

Related discussion:
text: "git": { "name": "electron", "repositoryUrl": "https://github.com/electron/electron", <del> "commitHash": "0c2cb59b6283fe8d6bb4b14f8a832e2166aeaa0c" </del> <ins> "commitHash": "03c7a54dc534ce1867d4393b9b1a6989d4a7e005" </ins> } }, "isOnlyProductionDependency": true, "license": "MIT", <del> "version": "9.2.0" </del> <ins> "version": "9.2.1" </ins> }, { "component": {
Code change:
latest VS Code insiders, turn on Voice Over on mac P -notice how the screen reader does not read any of the items in the quick pick This works just fine on Linux and Windows. Also works fine for stable. So it seems like an chrome update in electron broke this I can also repro running in . In Firefox and Safari all is good. I can not reproduce in Chrome cannary, so there seems to be a fix in Chrome latest. Ideally we would find the fix in Chrome and backport it to our Electron. fyi And for Chrome smartness, maybe one of your collegues fixed something like this (should be related to )
I can add this to my list (which is starting to grow I'm afraid). BUT, you don't need smartness; you need the most excellent bisect-build tool! :smile: Docs here: Once you have the regression range, you just sit there as pre-built binaries are presented for you to try and mark as good or bad. Best. Tool. Ever. Lemme know if you have any questions or need help.
Thanks a lot. Let's see if already has this set up, otherwise I can also look into it.
Yup I can do the bisect shortly.
Bisect result for when regression was introduced: Potential candidate: https://chromium-
Looking for fix now.
Upstream fix: https://chromium- Crbug:
Impressive. Thanks a lot!

Related discussion:
text: "css-loader": "^3.2.0", "debounce": "^1.0.0", "deemon": "^1.4.0", <del> "electron": "9.2.0", </del> <ins> "electron": "9.2.1", </ins> "eslint": "6.8.0", "eslint-plugin-jsdoc": "^19.1.0", "event-stream": "3.3.4",
Code change:
latest VS Code insiders, turn on Voice Over on mac P -notice how the screen reader does not read any of the items in the quick pick This works just fine on Linux and Windows. Also works fine for stable. So it seems like an chrome update in electron broke this I can also repro running in . In Firefox and Safari all is good. I can not reproduce in Chrome cannary, so there seems to be a fix in Chrome latest. Ideally we would find the fix in Chrome and backport it to our Electron. fyi And for Chrome smartness, maybe one of your collegues fixed something like this (should be related to )
I can add this to my list (which is starting to grow I'm afraid). BUT, you don't need smartness; you need the most excellent bisect-build tool! :smile: Docs here: Once you have the regression range, you just sit there as pre-built binaries are presented for you to try and mark as good or bad. Best. Tool. Ever. Lemme know if you have any questions or need help.
Thanks a lot. Let's see if already has this set up, otherwise I can also look into it.
Yup I can do the bisect shortly.
Bisect result for when regression was introduced: Potential candidate: https://chromium-
Looking for fix now.
Upstream fix: https://chromium- Crbug:
Impressive. Thanks a lot!

Related discussion:
text: resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.3.27.tgz#78ecb8a399066187bb374eede35d9c70565a803d" integrity sha1-eOy4o5kGYYe7N07t412ccFZagD0= <del> electron@9.2.0: version "9.2.0" resolved "https://registry.yarnpkg.com/electron/-/electron-9.2.0.tgz#d9fc8c8c9e5109669c366bd7b9ba83b06095d7a4" integrity sha512-4ecZ3rcGg//Gk4fAK3Jo61T+uh36JhU6HHR/PTujQqQiBw1g4tNPd4R2hGGth2d+7FkRIs5GdRNef7h64fQEMw== </del> <ins> electron@9.2.1: version "9.2.1" resolved "https://registry.yarnpkg.com/electron/-/electron-9.2.1.tgz#54ef574e1af4ae967b5efa94312f1b6458d44a02" integrity sha512-ZsetaQjXB8+9/EFW1FnfK4ukpkwXCxMEaiKiUZhZ0ZLFlLnFCpe0Bg4vdDf7e4boWGcnlgN1jAJpBw7w0eXuqA== </ins> dependencies: "@electron/get" "^1.0.1" "@types/node" "^12.0.12"
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.47.3 OS Version: Darwin x64 18.7.0 Steps to Reproduce: completeFunctionCall new tyepscript file, ype cursor at <kbdTAB</kbdExpected: Actual: Does this issue occur when all extensions are disabled?: Yes/No

Related discussion:
text: ).snippet.value, 'foobar(${1:param})$0'); }); <ins> test('Should skip over this parameter', async () => { assert.strictEqual( snippetForFunctionCall( { label: 'foobar', }, [{ "text": "function", "kind": "keyword" }, { "text": " ", "kind": "space" }, { "text": "foobar", "kind": "functionName" }, { "text": "(", "kind": "punctuation" }, { "text": "this", "kind": "parameterName" }, { "text": ":", "kind": "punctuation" }, { "text": " ", "kind": "space" }, { "text": "string", "kind": "keyword" }, { "text": ",", "kind": "punctuation" }, { "text": "param", "kind": "parameterName" }, { "text": ":", "kind": "punctuation" }, { "text": " ", "kind": "space" }, { "text": "string", "kind": "keyword" }, { "text": ")", "kind": "punctuation" }, { "text": ":", "kind": "punctuation" }, { "text": " ", "kind": "space" }, { "text": "void", "kind": "keyword" }] ).snippet.value, 'foobar(${1:param})$0'); }); </ins> });
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.47.3 OS Version: Darwin x64 18.7.0 Steps to Reproduce: completeFunctionCall new tyepscript file, ype cursor at <kbdTAB</kbdExpected: Actual: Does this issue occur when all extensions are disabled?: Yes/No

Related discussion:
text: const next = displayParts[i + 1]; // Skip optional parameters const nameIsFollowedByOptionalIndicator = next && next.text === '?'; <del> if (!nameIsFollowedByOptionalIndicator) { </del> <ins> // Skip this parameter const nameIsThis = part.text === 'this'; if (!nameIsFollowedByOptionalIndicator && !nameIsThis) { </ins> parts.push(part); } hasOptionalParameters = hasOptionalParameters || nameIsFollowedByOptionalIndicator;
Code change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Since you can have multiple s in a project, it would be great if vscode would be able to detect them and apply the right Language Mode (Groovy). The feature is essentially the same how vscode handles s.

Related discussion:
text: "languages": [{ "id": "groovy", "aliases": ["Groovy", "groovy"], <del> "extensions": [".groovy", ".gvy", ".gradle"], "filenames": [ "Jenkinsfile" ], </del> <ins> "extensions": [".groovy", ".gvy", ".gradle", ".jenkinsfile"], "filenamePatterns": ["Jenkinsfile.*"], </ins> "firstLine": "^#!.*bgroovyb", "configuration": "./language-configuration.json" }],
Code change:
Issue Type: <bBug</bsomething like Gentoo Linux VSCode in terminal get something like Possible fix: Don't hardcode the path to these :^) VS Code version: Code 1.49.1 (, 2020-09-16T23:23:33.049Z) OS version: Linux x64 5.8.8-gentoo <details<summarySystem Info</summary </details<details<summaryExtensions (6)</summaryExtensionVersion ------ gitlens10.2.2 cpptools1.0.0 vsliveshare1.0.2740 LiveServer5.6.1 vscodeintellicode1.2.10 vscode-icons11.0.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --

Related discussion:
text: *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { exec } from 'child_process'; import { isWindows } from 'vs/base/common/platform'; const cmdline = { windows: 'getmac.exe', unix: '/sbin/ifconfig -a || /sbin/ip link' }; </del> <ins> import { networkInterfaces } from 'os'; </ins> const invalidMacAddresses = new Set([ '00:00:00:00:00:00',
Code change:
Issue Type: <bBug</bsomething like Gentoo Linux VSCode in terminal get something like Possible fix: Don't hardcode the path to these :^) VS Code version: Code 1.49.1 (, 2020-09-16T23:23:33.049Z) OS version: Linux x64 5.8.8-gentoo <details<summarySystem Info</summary </details<details<summaryExtensions (6)</summaryExtensionVersion ------ gitlens10.2.2 cpptools1.0.0 vsliveshare1.0.2740 LiveServer5.6.1 vscodeintellicode1.2.10 vscode-icons11.0.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --

Related discussion:
text: function doGetMac(): Promise<string> { return new Promise((resolve, reject) => { try { <del> exec(isWindows ? cmdline.windows : cmdline.unix, { timeout: 10000 }, (err, stdout, stdin) => { if (err) { return reject(`Unable to retrieve mac address (${err.toString()})`); } else { const regex = /(?:[a-fd]{2}[:-]){5}[a-fd]{2}/gi; let match; while ((match = regex.exec(stdout)) !== null) { const macAddressCandidate = match[0]; if (validateMacAddress(macAddressCandidate)) { return resolve(macAddressCandidate); } </del> <ins> const ifaces = networkInterfaces(); for (const [, infos] of Object.entries(ifaces)) { for (const info of infos) { if (validateMacAddress(info.mac)) { return resolve(info.mac); </ins> } <del> return reject('Unable to retrieve mac address (unexpected format)'); </del> } <del> }); </del> <ins> } reject('Unable to retrieve mac address (unexpected format)'); </ins> } catch (err) { reject(err); }
Code change:
When executing search from extension api 2 checkboxes are not exposed: Preserve Case Use Exclude Settings and Ignore Files !
Hey , Can you please explain a little more about the issue?
It's possible to trigger a search from extension by using this api: And it has a good amount of options: But 2 of them are missing:
Thank got the idea. I will raise a PR to fix the issue ASAP :)
I have raised the . If you get time please review :)
genuinely didn't notice the existing PR, apologies
Thanks :). No problem
It great now that it's possible to control it but why does it called ? Would it possible to have the same name as in label:
Updated to as per suggestion and for consistency with search editor post . Also these to the keybindings intellisense registry.

Related discussion:
text: export interface IFindInFilesArgs { query?: string; replace?: string; <ins> preserveCase?: boolean; </ins> triggerSearch?: boolean; filesToInclude?: string; filesToExclude?: string; isRegex?: boolean; isCaseSensitive?: boolean; matchWholeWord?: boolean; <ins> excludeSettingAndIgnoreFiles?: boolean; </ins> } export const FindInFilesCommand: ICommandHandler = (accessor, args: IFindInFilesArgs = {}) => {
Code change:
When executing search from extension api 2 checkboxes are not exposed: Preserve Case Use Exclude Settings and Ignore Files !
Hey , Can you please explain a little more about the issue?
It's possible to trigger a search from extension by using this api: And it has a good amount of options: But 2 of them are missing:
Thank got the idea. I will raise a PR to fix the issue ASAP :)
I have raised the . If you get time please review :)
genuinely didn't notice the existing PR, apologies
Thanks :). No problem
It great now that it's possible to control it but why does it called ? Would it possible to have the same name as in label:
Updated to as per suggestion and for consistency with search editor post . Also these to the keybindings intellisense registry.

Related discussion:
text: if (typeof args.triggerSearch === 'boolean' && args.triggerSearch) { this.triggerQueryChange(); } <ins> if (typeof args.preserveCase === 'boolean') { this.searchWidget.replaceInput.setPreserveCase(args.preserveCase); } if (typeof args.excludeSettingAndIgnoreFiles === 'boolean') { this.inputPatternExcludes.setUseExcludesAndIgnoreFiles(args.excludeSettingAndIgnoreFiles); } </ins> } toggleQueryDetails(moveFocus = true, show?: boolean, skipLayout?: boolean, reverse?: boolean): void {
Code change:
1) install the Remote-SSH and the Codespaces extension 2) Open the remote explorer 3) Select SSH Targets 3) Grab the SSH Targets view and drag it onto the activity bar -the drop down still shows both entries but without any view -the dropped view only shows SSH Targets (as expected) and so there is no way to get to Codespaces anymore 4) Use the SSH Targets view and move it back into the Remote Explorer -two views, one of them a zombie
Looks like somehow the remote explorer got enable for moving views again...

Related discussion:
text: containerIcon: icon || viewContainer?.icon, containerTitle: item.contextualTitle || viewContainer?.name, canToggleVisibility: true, <del> canMoveView: true, </del> <ins> canMoveView: viewContainer?.id !== REMOTE, </ins> treeView: type === ViewType.Tree ? this.instantiationService.createInstance(CustomTreeView, item.id, item.name) : undefined, collapsed: this.showCollapsed(container) || initialVisibility === InitialVisibility.Collapsed, order: order,
Code change:
Connect a mac-windows SSH remote Open terminal See this popup ! So fails here because it checks ".PATH" on the environment when this is actually "Path" on windows. has special behavior where it resolves property accesses in a case-insensitive way on Windows. We changed many accesses from using to a constructed environment object, and need the same behavior there.
is this a mac-specific issue or are there steps to repro/verify on Windows?
Can't be verified on windows. Thanks

Related discussion:
text: return result; } <ins> export function getCaseInsensitive(target: obj, key: string): any { const lowercaseKey = key.toLowerCase(); const equivalentKey = Object.keys(target).find(k => k.toLowerCase() === lowercaseKey); return equivalentKey ? target[equivalentKey] : target[key]; } </ins>
Code change:
Connect a mac-windows SSH remote Open terminal See this popup ! So fails here because it checks ".PATH" on the environment when this is actually "Path" on windows. has special behavior where it resolves property accesses in a case-insensitive way on Windows. We changed many accesses from using to a constructed environment object, and need the same behavior there.
is this a mac-specific issue or are there steps to repro/verify on Windows?
Can't be verified on windows. Thanks

Related discussion:
text: diff = objects.distinct(base, obj); assert.deepEqual(diff, obj); }); <del> }); </del>  No newline at end of file <ins> test('getCaseInsensitive', () => { const obj1 = { lowercase: 123, mIxEdCaSe: 456 }; assert.equal(obj1.lowercase, objects.getCaseInsensitive(obj1, 'lowercase')); assert.equal(obj1.lowercase, objects.getCaseInsensitive(obj1, 'lOwErCaSe')); assert.equal(obj1.mIxEdCaSe, objects.getCaseInsensitive(obj1, 'MIXEDCASE')); assert.equal(obj1.mIxEdCaSe, objects.getCaseInsensitive(obj1, 'mixedcase')); }); }); </ins>
Code change:
Connect a mac-windows SSH remote Open terminal See this popup ! So fails here because it checks ".PATH" on the environment when this is actually "Path" on windows. has special behavior where it resolves property accesses in a case-insensitive way on Windows. We changed many accesses from using to a constructed environment object, and need the same behavior there.
is this a mac-specific issue or are there steps to repro/verify on Windows?
Can't be verified on windows. Thanks

Related discussion:
text: import { readFile, exists } from 'vs/base/node/pfs'; import * as path from 'vs/base/common/path'; import { isString } from 'vs/base/common/types'; <ins> import { getCaseInsensitive } from 'vs/base/common/objects'; </ins> let mainProcessParentEnv: IProcessEnvironment | undefined;