jiebi/CodeConvo huggingface dataset:
Code change:
I've attempted to find any other requests for this but didn't seem to see any. At the moment the CVS context menu shows: ! Only "Pop latest stash" and "Pop stash..." are visible. Is it possible to change the default stash behaviour to "apply" rather than "pop"? Additionally, is it possible to add two lines under "Pop stash..." for the same actions, just using apply: Apply latest stash Apply stash... I just lost a few hours and considerable amount of hair when a popped stash was deleted. I then had to sift through doing on each . Having "Apply stash..." easily accessible might be nicer.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.676 --<!-- potentialduplicatescomment --
I suggest to simply add and commands.
is anyone working on this, if not, I'll like to pick it up as a
looks like it might already be done in
yeah, just confirmed, Thanks. If I may ask, is there any rule around tagging an issue that is being worked on as it would be multiple efforts if I happen to have started it without anyone's knowledge. I've been scouting for an issue with no assignee to work on :-( Thanks for the catch tho!

Related discussion:
text: } async popStash(index?: number): Promise<void> { <del> try { const args = ['stash', 'pop']; </del> <ins> const args = ['stash', 'pop']; this.popOrApplyStash(args, index); } async applyStash(index?: number): Promise<void> { const args = ['stash', 'apply']; this.popOrApplyStash(args, index); } private async popOrApplyStash(args: string[], index?: number): Promise<void> { try { </ins> if (typeof index === 'number') { args.push(`stash@{${index}}`); }
Code change:
I've attempted to find any other requests for this but didn't seem to see any. At the moment the CVS context menu shows: ! Only "Pop latest stash" and "Pop stash..." are visible. Is it possible to change the default stash behaviour to "apply" rather than "pop"? Additionally, is it possible to add two lines under "Pop stash..." for the same actions, just using apply: Apply latest stash Apply stash... I just lost a few hours and considerable amount of hair when a popped stash was deleted. I then had to sift through doing on each . Having "Apply stash..." easily accessible might be nicer.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.676 --<!-- potentialduplicatescomment --
I suggest to simply add and commands.
is anyone working on this, if not, I'll like to pick it up as a
looks like it might already be done in
yeah, just confirmed, Thanks. If I may ask, is there any rule around tagging an issue that is being worked on as it would be multiple efforts if I happen to have started it without anyone's knowledge. I've been scouting for an issue with no assignee to work on :-( Thanks for the catch tho!

Related discussion:
text: } } getStatus(limit = 5000): Promise<{ status: IFileStatus[]; didHitLimit: boolean; }> { return new Promise<{ status: IFileStatus[]; didHitLimit: boolean; }>((c, e) => { const parser = new GitStatusParser();
Code change:
I've attempted to find any other requests for this but didn't seem to see any. At the moment the CVS context menu shows: ! Only "Pop latest stash" and "Pop stash..." are visible. Is it possible to change the default stash behaviour to "apply" rather than "pop"? Additionally, is it possible to add two lines under "Pop stash..." for the same actions, just using apply: Apply latest stash Apply stash... I just lost a few hours and considerable amount of hair when a popped stash was deleted. I then had to sift through doing on each . Having "Apply stash..." easily accessible might be nicer.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.676 --<!-- potentialduplicatescomment --
I suggest to simply add and commands.
is anyone working on this, if not, I'll like to pick it up as a
looks like it might already be done in
yeah, just confirmed, Thanks. If I may ask, is there any rule around tagging an issue that is being worked on as it would be multiple efforts if I happen to have started it without anyone's knowledge. I've been scouting for an issue with no assignee to work on :-( Thanks for the catch tho!

Related discussion:
text: return await this.run(Operation.Stash, () => this.repository.popStash(index)); } <ins> async applyStash(index?: number): Promise<void> { return await this.run(Operation.Stash, () => this.repository.applyStash(index)); } </ins> async getCommitTemplate(): Promise<string> { return await this.run(Operation.GetCommitTemplate, async () => this.repository.getCommitTemplate()); }
Code change:
Issue Type: <bBug</bI haven't been able to reliably reproduce this, but it happens decently often. To repo: -click on a line in an editor (seems to happen more often if it is not the active line) of the time the context menu will open, but sometimes it just flashes in and disappears My guess is that it feels like some sort of conflict between showing a hover vs the context menu. And I'm not sure if GitLens plays a roll here or not (though it never happens with the native menus). Another observation, it seems to be more likely to happen right after you've switched to a editor as well (either that or just becomes less likely after the menu has been shown already or something). VS Code version: Code - Insiders 1.26.0-insider (, 2018-07-18T05:19:07.488Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<!-- generated by issue reporter --
I think vscodebot is drunk This should be tagged and likely assigned to
it just loves to classify things as terminal :sob:
Looks like this happens when the contributor codelens info gets to the editor which may trigger scroll which dismisses context menus. /cc
possibly related
I saw this issue while testing today.
was the behavior unique to the latest insiders or could you reproduce with stable
I tested only on latest insiders did not try on stable
/confirm still repro on 1.30.0 stable version
/confirm
Sorry, I still this one from time to time. Not fixed, but also no steps. can we add logging when programmatically(?) closing a menu, esp. withing 1sec of opening
do you know if yours is the case that a menu item is triggered immediately (because the menu was drawn under the cursor and mouseup triggers the item) or that it is actually dismissed?
That - unless the command is a no op. I think this happens when I open the context menu but not immediately interact with it. Can it be that while the menu is open and context-key events comes in, causing the menu (native. macOS) to hide?
oh, native case, alright, i'll dig into it
This is now reproducing with the custom context menus as well. The scrollTop change does not appear to work anymore(fully?). Something to note is that in VS Code, with the custom titlebar enabled or using a mac, it is not possible to scroll the editor with the conext menu open. Thus, dismissing due to a scroll event is now wrong (I think). Dismissal due to scrolling seems like it was for the benefit of monaco more than vs code. See Do you think we could switch to event? This way, I believe, monaco's behavior should be preserved and vs code would not have this event triggered because of the blocking div when a context menu is open.
:+1: That could work well.

Related discussion:
text: this._toDispose.push(this._editor.onContextMenu((e: IEditorMouseEvent) => this._onContextMenu(e))); this._toDispose.push(this._editor.onDidScrollChange((e: IScrollEvent) => { <del> if (this._contextMenuIsBeingShownCount > 0) { </del> <ins> if (this._contextMenuIsBeingShownCount > 0 && e.scrollTopChanged) { </ins> this._contextViewService.hideContextView(); } }));
Code change:
Issue Type: <bBug</bI have a file named F1000-v117.au3. When copying/pasting the file, it creates a file named F1001-v117.au3. This is not the expected result. F1000 is the name of the file and not a version number that should be incremented. Changing the regex within the incrementFileName function fixes the issue. Basically, make sure the first section of the file name is numeric only. to VS Code version: Code 1.25.1 (, 2018-07-11T15:43:11.471Z) OS version: WindowsNT ia32 6.1.7601 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
PR for this is welcome It would be great if the PR contains a unit test fyi
I'll take a look tomorrow.
is the expected result right?
Actually it seems like other cases are broken now. Have a file , copy and paste it The new file is , in 1.26 it was
Thanks for finding that Due to that I had to revert the original fix. So now copying gives However this issue is now not fixed, but it was like that in previous stable so nothing urgent -removing mielstone let me know if you want to fix your fix and provide a working PR. Thanks
Hey guys, I took a crack at fixing this regex have some questions on how the naming / number schema works and I want to make sure I have an understanding of the naming schema. We have our cases here: suffix: prefix: single number: no number: ends with number: mixed (new case / why the above PR broke): prefixed with number: The issue is that mixing letters and numbers triggers the prefix regex which incorrectly increments the number. But all the different variations of prefix / suffix and single number / mixed with letters make this particularly tricky. It seems like edits need to be made to existing regexes to ensure that they are matching digit only groups. However, the above PR regex edits and the edits I've made consistently break other regexes. Any ideas or considerations here?
This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details . If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider. If you wonder what we are up to, please see our and guidelines. Thanks for your understanding and happy coding!

Related discussion:
text: } // 1.file.txt=>2.file.txt <del> let prefixFileRegex = RegExp('(d+)(' + separators + '.*)(..*)$'); </del> <ins> let prefixFileRegex = RegExp('^(d+)(' + separators + '.*)(..*)$'); </ins> if (!isFolder && name.match(prefixFileRegex)) { return name.replace(prefixFileRegex, (match, g1?, g2?, g3?) => { let number = parseInt(g1);
Code change:
Issue Type: <bBug</bI have a file named F1000-v117.au3. When copying/pasting the file, it creates a file named F1001-v117.au3. This is not the expected result. F1000 is the name of the file and not a version number that should be incremented. Changing the regex within the incrementFileName function fixes the issue. Basically, make sure the first section of the file name is numeric only. to VS Code version: Code 1.25.1 (, 2018-07-11T15:43:11.471Z) OS version: WindowsNT ia32 6.1.7601 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
PR for this is welcome It would be great if the PR contains a unit test fyi
I'll take a look tomorrow.
is the expected result right?
Actually it seems like other cases are broken now. Have a file , copy and paste it The new file is , in 1.26 it was
Thanks for finding that Due to that I had to revert the original fix. So now copying gives However this issue is now not fixed, but it was like that in previous stable so nothing urgent -removing mielstone let me know if you want to fix your fix and provide a working PR. Thanks
Hey guys, I took a crack at fixing this regex have some questions on how the naming / number schema works and I want to make sure I have an understanding of the naming schema. We have our cases here: suffix: prefix: single number: no number: ends with number: mixed (new case / why the above PR broke): prefixed with number: The issue is that mixing letters and numbers triggers the prefix regex which incorrectly increments the number. But all the different variations of prefix / suffix and single number / mixed with letters make this particularly tricky. It seems like edits need to be made to existing regexes to ensure that they are matching digit only groups. However, the above PR regex edits and the edits I've made consistently break other regexes. Any ideas or considerations here?
This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details . If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider. If you wonder what we are up to, please see our and guidelines. Thanks for your understanding and happy coding!

Related discussion:
text: } // 1.txt=>2.txt <del> let prefixFileNoNameRegex = RegExp('(d+)(..*)$'); </del> <ins> let prefixFileNoNameRegex = RegExp('^(d+)(..*)$'); </ins> if (!isFolder && name.match(prefixFileNoNameRegex)) { return name.replace(prefixFileNoNameRegex, (match, g1?, g2?) => { let number = parseInt(g1);
Code change:
Testing When using the '...' menu to add sort filter options, the option becomes disabled in the menu, preventing it from being twice from that UI. I think it would be nice if the suggestions behaved similarly, not suggesting filters that are already present in the input. ! VS Code version: Code - Insiders 1.26.0-insider (, 2018-07-31T05:18:06.861Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --

Related discussion:
text: this.value = value.trim(); } <del> static autocompletions(): string[] { </del> <ins> static autocompletions(query: string): string[] { </ins> const commands = ['installed', 'outdated', 'enabled', 'disabled', 'builtin', 'recommended', 'sort', 'category', 'tag', 'ext']; const subcommands = { 'sort': ['installs', 'rating', 'name'],
Code change:
Testing When using the '...' menu to add sort filter options, the option becomes disabled in the menu, preventing it from being twice from that UI. I think it would be nice if the suggestions behaved similarly, not suggesting filters that are already present in the input. ! VS Code version: Code - Insiders 1.26.0-insider (, 2018-07-31T05:18:06.861Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --

Related discussion:
text: 'ext': [''] }; <ins> let queryContains = (substr: string) => query.indexOf(substr) > -1; let hasSort = subcommands.sort.some(subcommand => queryContains(`@sort:${subcommand}`)); let hasCategory = subcommands.category.some(subcommand => queryContains(`@category:${subcommand}`)); </ins> return flatten( <del> commands.map(command => subcommands[command] ? subcommands[command].map(subcommand => `@${command}:${subcommand}${subcommand === '' ? '' : ' '}`) : [`@${command} `])); </del> <ins> commands.map(command => { if (hasSort && command === 'sort' || hasCategory && command === 'category') { return []; } if (subcommands[command]) { return subcommands[command].map(subcommand => `@${command}:${subcommand}${subcommand === '' ? '' : ' '}`); } else { return [`@${command} `]; } })); </ins> } static parse(value: string): Query {
Code change:
Testing When using the '...' menu to add sort filter options, the option becomes disabled in the menu, preventing it from being twice from that UI. I think it would be nice if the suggestions behaved similarly, not suggesting filters that are already present in the input. ! VS Code version: Code - Insiders 1.26.0-insider (, 2018-07-31T05:18:06.861Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --

Related discussion:
text: // dont show autosuggestions if the user has typed something, but hasn't used the trigger character if (alreadyTypedCount > 0 && query[wordStart] !== '@') { return []; } <del> return Query.autocompletions().map(replacement => ({ fullText: replacement, overwrite: alreadyTypedCount })); </del> <ins> return Query.autocompletions(query).map(replacement => ({ fullText: replacement, overwrite: alreadyTypedCount })); </ins> } private count(): number {
Code change:
Testing When using the '...' menu to add sort filter options, the option becomes disabled in the menu, preventing it from being twice from that UI. I think it would be nice if the suggestions behaved similarly, not suggesting filters that are already present in the input. ! VS Code version: Code - Insiders 1.26.0-insider (, 2018-07-31T05:18:06.861Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --

Related discussion:
text: query2 = new Query('hello', 'installs', ''); assert(!query1.equals(query2)); }); <ins> test('autocomplete', () => { Query.autocompletions('@sort:in').some(x => x === '@sort:installs '); Query.autocompletions('@sort:installs').every(x => x !== '@sort:rating '); Query.autocompletions('@category:blah').some(x => x === '@category:"extension packs" '); Query.autocompletions('@category:"extension packs"').every(x => x !== '@category:formatters '); }); </ins> });  No newline at end of file
Code change:
Tested in Windows with Insiders for 8/1 Add a couple of spaces in the extension search box Move focus to any of the open editors Come back to the extension search box and enter a letter !

Related discussion:
text: config.wordWrap = 'off'; config.scrollbar.vertical = 'hidden'; config.ariaLabel = ariaLabel || ''; <ins> config.renderIndentGuides = false; </ins> config.cursorWidth = 1; config.snippetSuggestions = 'none'; config.suggest = { filterGraceful: false };
Code change:
: Check whether it's ok to map to : Add 'null' or "None" item to enum : =- : ?? I don't see this in vscode's core settings Also, . Example:
These are the settings explicitly that I could find with a simple search. Of these, the HTML ones are the only concern. For most of them we should probably just get rid of accepting null, as it doesn't make a ton of sense to have just mean either default or some secondary default. But has very different behavior between and so we'll have to decide on something to do there.
[ ] : fix requires API discussion over adding an additional schema parameter [x] : fixes [x] : fixed [ ] : Probably wont fix? Would require some new components and UI/UX discussion. [x] : fixes
can you add some steps for how to verify?
Here are some settings with compound types - Test that they work as you'd expect. I can't remember which extension has the nullable enum but you can test it with a contribution like
seems to work for the first one, but not second. e.g. here I cannot type "null": ! I can only type numbers (I am on Windows).
For the null|number type, an empty input box will correspond to in the json

Related discussion:
text: this.overriddenScopeList = overriddenScopeList; this.description = this.setting.description.join('n'); <del> if (this.setting.enum && (this.setting.type === 'string' || !this.setting.type)) { </del> <ins> if (this.setting.enum && (!this.setting.type || settingTypeEnumRenderable(this.setting.type))) { </ins> this.valueType = 'enum'; } else if (this.setting.type === 'string') { this.valueType = 'string';
Code change:
: Check whether it's ok to map to : Add 'null' or "None" item to enum : =- : ?? I don't see this in vscode's core settings Also, . Example:
These are the settings explicitly that I could find with a simple search. Of these, the HTML ones are the only concern. For most of them we should probably just get rid of accepting null, as it doesn't make a ton of sense to have just mean either default or some secondary default. But has very different behavior between and so we'll have to decide on something to do there.
[ ] : fix requires API discussion over adding an additional schema parameter [x] : fixes [x] : fixed [ ] : Probably wont fix? Would require some new components and UI/UX discussion. [x] : fixes
can you add some steps for how to verify?
Here are some settings with compound types - Test that they work as you'd expect. I can't remember which extension has the nullable enum but you can test it with a contribution like
seems to work for the first one, but not second. e.g. here I cannot type "null": ! I can only type numbers (I am on Windows).
For the null|number type, an empty input box will correspond to in the json

Related discussion:
text: setting.key === 'search.exclude'; } <ins> function settingTypeEnumRenderable(_type: string | string[]) { const enumRenderableSettingTypes = ['string', 'boolean', 'null', 'integer', 'number']; let type = isArray(_type) ? _type : [_type]; return type.every(type => enumRenderableSettingTypes.indexOf(type) > -1); } </ins> export enum SearchResultIdx { Local = 0, Remote = 1,
Code change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: master commit OS Version: macOS 10.13.6 Steps to Reproduce: clone vscode ouput: how to fix: update typescript version from to will fix it.

Related discussion:
text: "rimraf": "^2.6.1", "strip-json-comments": "^2.0.1", "tmp": "0.0.33", <del> "typescript": "2.5.2", </del> <ins> "typescript": "2.9.2", </ins> "watch": "^1.0.2" } }
Code change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: master commit OS Version: macOS 10.13.6 Steps to Reproduce: clone vscode ouput: how to fix: update typescript version from to will fix it.

Related discussion:
text: version "0.0.6" resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777" <del> typescript@2.5.2: version "2.5.2" resolved "https://registry.yarnpkg.com/typescript/-/typescript-2.5.2.tgz#038a95f7d9bbb420b1bf35ba31d4c5c1dd3ffe34" </del> <ins> typescript@2.9.2: version "2.9.2" resolved "https://registry.yarnpkg.com/typescript/-/typescript-2.9.2.tgz#1cbf61d05d6b96269244eb6a3bce4bd914e0f00c" </ins> uid-number@^0.0.6: version "0.0.6"
Code change:
debugging the loaded scripts view open debugging, notice exception in the console can not reproduce with Stable so it might be that my listener refactoring caused this If you pause on exception you will see that caused it.
did you have a chance to look into this? Or would you like me to investigate? I suspect this is breaking the loaded scripts view and is the root cause for
no, please investigate since this and was working before, and I haven't touched this code for two weeks.
end session events are not arriving in As a consequence the tree for the session is not properly removed.
I see something differnetly, the end sessions are arriving however when the last session end arrives view starts refreshing the tree and while that is in progress the view gets disposed which throws an exception. Looking into a fix...
I have created a PR which address this issue

Related discussion:
text: import { isWindows } from 'vs/base/common/platform'; import URI from 'vs/base/common/uri'; import { ltrim } from 'vs/base/common/strings'; <ins> import { RunOnceScheduler } from 'vs/base/common/async'; import { memoize } from 'vs/base/common/decorators'; </ins> const SMART = true;