jiebi/CodeConvo huggingface dataset:
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.1 OS Version: Mac Sonoma 14.3 Steps to Reproduce: Note: the following is just one way to easily reproduce, but this really is an issue with the CSS variable that affects more than just the Jupyter extension (hence why the issue is opened in this repository). the Jupyter extension a cell, execute code that in the cell output, the green color is using the theme variable <img width="263" alt="image" src=""the following in the terminal that the green ANSI styling is different in light themes: <img width="280" alt="image" src=""<img width="427" alt="image" src=""<img width="419" alt="image" src=""Works as expected in dark themes: <img width="377" alt="image" src=""<img width="290" alt="image" src=""This is a problem because in light theme, the contrast ratio requirement is not met. This means that when the CSS variable is used there will be an accessibility bug. Thanks!
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Confirmed reproing on 1.86.1 as well
Github Tags: #BM-VisualStudioCodeClient-Win32-Jan2024; #Visual Studio Code Client; #A11yMAS; #WCAG1.4.3; #AILimited; #A11yTCS; #ColorContrast; #A11ySev2;
the terminal has the minimum contrast ratio feature that fixes the contrast ratio, anywhere else that piggy backs on that color might not meet contrast.
Assigned to April as it comes from s360
so no matter what color we use, terminal will automatically adjust it? I can change the default color used to solve the contrast issue outside of terminal. Just not sure how to keep them aligned.
yes the terminal will by default slide the color to be 4.5:1 (). It's fine if their luminosity is a little inconsistent imo, we just need to make sure the color meets contrast elsewhere.
Tweaked colors for light and light hc themes in !
thanks a lot. I think we can close this bug as fixed now, right?
Build failing, will auto close when it merges

Related discussion:
text: 'terminal.ansiGreen': { index: 2, defaults: { <del> light: '#00BC00', </del> <ins> light: '#107C10', </ins> dark: '#0DBC79', hcDark: '#00cd00', <del> hcLight: '#00bc00' </del> <ins> hcLight: '#136C13' </ins> } }, 'terminal.ansiYellow': {
Code change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.1 OS Version: Mac Sonoma 14.3 Steps to Reproduce: Note: the following is just one way to easily reproduce, but this really is an issue with the CSS variable that affects more than just the Jupyter extension (hence why the issue is opened in this repository). the Jupyter extension a cell, execute code that in the cell output, the green color is using the theme variable <img width="263" alt="image" src=""the following in the terminal that the green ANSI styling is different in light themes: <img width="280" alt="image" src=""<img width="427" alt="image" src=""<img width="419" alt="image" src=""Works as expected in dark themes: <img width="377" alt="image" src=""<img width="290" alt="image" src=""This is a problem because in light theme, the contrast ratio requirement is not met. This means that when the CSS variable is used there will be an accessibility bug. Thanks!
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Confirmed reproing on 1.86.1 as well
Github Tags: #BM-VisualStudioCodeClient-Win32-Jan2024; #Visual Studio Code Client; #A11yMAS; #WCAG1.4.3; #AILimited; #A11yTCS; #ColorContrast; #A11ySev2;
the terminal has the minimum contrast ratio feature that fixes the contrast ratio, anywhere else that piggy backs on that color might not meet contrast.
Assigned to April as it comes from s360
so no matter what color we use, terminal will automatically adjust it? I can change the default color used to solve the contrast issue outside of terminal. Just not sure how to keep them aligned.
yes the terminal will by default slide the color to be 4.5:1 (). It's fine if their luminosity is a little inconsistent imo, we just need to make sure the color meets contrast elsewhere.
Tweaked colors for light and light hc themes in !
thanks a lot. I think we can close this bug as fixed now, right?
Build failing, will auto close when it merges

Related discussion:
text: assert.deepStrictEqual(colors, [ '#000000', '#cd3131', <del> '#00bc00', </del> <ins> '#107c10', </ins> '#949800', '#0451a5', '#bc05bc',
Code change:
Steps to Reproduce: a notebook and put in a cell and run it to establish a kernel for that notebook vscode and run the cell before the kernel is auto-selected :bug: notebook variable view will not initialize
HI is this a candidate? This issue is assigned to the recovery 2 milestone, but it does not have a candidate label and there appears to only be one PR to main. We will discuss this issue in standup and decide if this should be merged to the release branch.
As mentioned in a private discussion, if we accept this candidate recovery release will be held on Monday which is when the next endgame starts. To avoid overlap of the two endgames, this fix should be included instead in the next release.

Related discussion:
text: import { IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { NOTEBOOK_VARIABLE_VIEW_ENABLED } from 'vs/workbench/contrib/notebook/browser/contrib/notebookVariables/notebookVariableContextKeys'; export class NotebookVariables extends Disposable implements IWorkbenchContribution { private listeners: IDisposable[] = []; private configListener: IDisposable;
Code change:
Steps to Reproduce: a notebook and put in a cell and run it to establish a kernel for that notebook vscode and run the cell before the kernel is auto-selected :bug: notebook variable view will not initialize
HI is this a candidate? This issue is assigned to the recovery 2 milestone, but it does not have a candidate label and there appears to only be one PR to main. We will discuss this issue in standup and decide if this should be merged to the release branch.
As mentioned in a private discussion, if we accept this candidate recovery release will be held on Monday which is when the next endgame starts. To avoid overlap of the two endgames, this fix should be included instead in the next release.

Related discussion:
text: this.viewEnabled = NOTEBOOK_VARIABLE_VIEW_ENABLED.bindTo(contextKeyService); <del> this.listeners.push(this.editorService.onDidEditorsChange(() => this.handleInitEvent())); this.listeners.push(this.notebookExecutionStateService.onDidChangeExecution(() => this.handleInitEvent())); </del> <ins> this.listeners.push(this.editorService.onDidActiveEditorChange(() => this.handleInitEvent())); this.listeners.push(this.notebookExecutionStateService.onDidChangeExecution((e) => this.handleInitEvent())); </ins> this.configListener = configurationService.onDidChangeConfiguration((e) => this.handleConfigChange(e)); }
Code change:
Steps to Reproduce: a notebook and put in a cell and run it to establish a kernel for that notebook vscode and run the cell before the kernel is auto-selected :bug: notebook variable view will not initialize
HI is this a candidate? This issue is assigned to the recovery 2 milestone, but it does not have a candidate label and there appears to only be one PR to main. We will discuss this issue in standup and decide if this should be merged to the release branch.
As mentioned in a private discussion, if we accept this candidate recovery release will be held on Monday which is when the next endgame starts. To avoid overlap of the two endgames, this fix should be included instead in the next release.

Related discussion:
text: if (this.configurationService.getValue(NotebookSetting.notebookVariablesView) && this.editorService.activeEditorPane?.getId() === 'workbench.editor.notebook') { <del> if (this.hasVariableProvider()) { </del> <ins> if (this.hasVariableProvider() && !this.initialized && this.initializeView()) { </ins> this.viewEnabled.set(true); <del> } if (!this.initialized && this.initializeView()) { </del> this.initialized = true; this.listeners.forEach(listener => listener.dispose()); }
Code change:
Steps to Reproduce: a notebook and put in a cell and run it to establish a kernel for that notebook vscode and run the cell before the kernel is auto-selected :bug: notebook variable view will not initialize
HI is this a candidate? This issue is assigned to the recovery 2 milestone, but it does not have a candidate label and there appears to only be one PR to main. We will discuss this issue in standup and decide if this should be merged to the release branch.
As mentioned in a private discussion, if we accept this candidate recovery release will be held on Monday which is when the next endgame starts. To avoid overlap of the two endgames, this fix should be included instead in the next release.

Related discussion:
text: private setActiveNotebook() { const current = this.activeNotebook; const activeEditorPane = this.editorService.activeEditorPane; <del> if (activeEditorPane && activeEditorPane.getId() === 'workbench.editor.notebook') { </del> <ins> if (activeEditorPane?.getId() === 'workbench.editor.notebook') { </ins> const notebookDocument = getNotebookEditorFromEditorPane(activeEditorPane)?.getViewModel()?.notebookDocument; this.activeNotebook = notebookDocument; }
Code change:
Type: <bBug</b! I think the log files are listed in the order the LogOutputChannels got created. Unless this is intentional / important I suggest we sort them alphabetically. I also propose adding the contributing extension's ID as the description element of the list item for LogOutputChannels created by extensions. VS Code version: Code - Insiders 1.87.0-insider (, 2024-02-13T05:47:27.450Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
Changed it to show in the same way like in the output channel dropdown !
This is a little confusing because a provider that shows in the Output view dropdown might not show in "Developer: Open Log File...". I assume this is because Output has all output channels and "Open Log File" only has log output channels. I specifically noticed this with ESLint.
Thats right. Not all output channels are logs.

Related discussion:
text: import { IViewsService } from 'vs/workbench/services/views/common/viewsService'; import { ViewPaneContainer } from 'vs/workbench/browser/parts/views/viewPaneContainer'; import { IConfigurationRegistry, Extensions as ConfigurationExtensions, ConfigurationScope } from 'vs/platform/configuration/common/configurationRegistry'; <del> import { IQuickPickItem, IQuickInputService, IQuickPickSeparator } from 'vs/platform/quickinput/common/quickInput'; </del> <ins> import { IQuickPickItem, IQuickInputService, IQuickPickSeparator, QuickPickInput } from 'vs/platform/quickinput/common/quickInput'; </ins> import { AUX_WINDOW_GROUP, AUX_WINDOW_GROUP_TYPE, IEditorService } from 'vs/workbench/services/editor/common/editorService'; import { assertIsDefined } from 'vs/base/common/types'; import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey';
Code change:
Type: <bBug</b! I think the log files are listed in the order the LogOutputChannels got created. Unless this is intentional / important I suggest we sort them alphabetically. I also propose adding the contributing extension's ID as the description element of the list item for LogOutputChannels created by extensions. VS Code version: Code - Insiders 1.87.0-insider (, 2024-02-13T05:47:27.450Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
Changed it to show in the same way like in the output channel dropdown !
This is a little confusing because a provider that shows in the Output view dropdown might not show in "Developer: Open Log File...". I assume this is because Output has all output channels and "Open Log File" only has log output channels. I specifically noticed this with ESLint.
Thats right. Not all output channels are logs.

Related discussion:
text: const editorService = accessor.get(IEditorService); const fileConfigurationService = accessor.get(IFilesConfigurationService); <del> const entries: IOutputChannelQuickPickItem[] = outputService.getChannelDescriptors().filter(c => c.file && c.log) .map(channel => (<IOutputChannelQuickPickItem>{ id: channel.id, label: channel.label, channel })); const argName = args && typeof args === 'string' ? args : undefined; </del> let entry: IOutputChannelQuickPickItem | undefined; <del> if (argName) { entry = entries.find(e => e.id === argName); </del> <ins> const argName = args && typeof args === 'string' ? args : undefined; const extensionChannels: IOutputChannelQuickPickItem[] = []; const coreChannels: IOutputChannelQuickPickItem[] = []; for (const c of outputService.getChannelDescriptors()) { if (c.file && c.log) { const e = { id: c.id, label: c.label, channel: c }; if (c.extensionId) { extensionChannels.push(e); } else { coreChannels.push(e); } if (e.id === argName) { entry = e; } } </ins> } if (!entry) { <del> entry = await quickInputService.pick(entries, { placeHolder: nls.localize('selectlogFile', "Select Log File") }); </del> <ins> const entries: QuickPickInput[] = [...extensionChannels.sort((a, b) => a.label.localeCompare(b.label))]; if (entries.length && coreChannels.length) { entries.push({ type: 'separator' }); entries.push(...coreChannels.sort((a, b) => a.label.localeCompare(b.label))); } entry = <IOutputChannelQuickPickItem | undefined>await quickInputService.pick(entries, { placeHolder: nls.localize('selectlogFile', "Select Log File") }); </ins> } if (entry) { const resource = assertIsDefined(entry.channel.file);
Code change:
With the custom hover now making appearance everywhere in the workbench UI, I think we should try to make it a bit more compact. Previously I had reported as but I think is still too large and there is a lot of empty space as well. I suggest to find the sweet spot between native hover size and custom hover size. <img width="213" alt="image" src=""

Related discussion:
text: hideOnHover: true, hideOnKeyDown: true, }, <ins> appearance: { compact: true, }, </ins> ...overrideOptions }, focus); }
Code change:
Testing <img alt="image" src=""For this, I put an invalid , and as expected, the field in the issue reporter is not set to a specific extension. However, I'd appreciate a warning log in the debug console that warns devs that they have an invalid

Related discussion:
text: const response = await fetch(url, init); if (!response.ok) { <ins> console.error('Invalid GitHub URL provided.'); </ins> return false; } const result = await response.json();
Code change:
Testing <img alt="image" src=""For this, I put an invalid , and as expected, the field in the issue reporter is not set to a specific extension. However, I'd appreciate a warning log in the debug console that warns devs that they have an invalid

Related discussion:
text: let issueUrl = hasUri ? this.getExtensionBugsUrl() : this.getIssueUrl(); if (!issueUrl) { <ins> console.error('No issue url found'); </ins> return false; }
Code change:
Testing <img alt="image" src=""For this, I put an invalid , and as expected, the field in the issue reporter is not set to a specific extension. However, I'd appreciate a warning log in the debug console that warns devs that they have an invalid

Related discussion:
text: try { url = await this.writeToClipboard(baseUrl, issueBody); } catch (_) { <ins> console.error('Writing to clipboard failed'); </ins> return false; } }
Code change:
Testing <img alt="image" src=""For this, I put an invalid , and as expected, the field in the issue reporter is not set to a specific extension. However, I'd appreciate a warning log in the debug console that warns devs that they have an invalid

Related discussion:
text: owner: match[1], repositoryName: match[2] }; <ins> } else { console.error('No GitHub match'); </ins> } return undefined;
Code change:
Testing <img alt="image" src=""For this, I put an invalid , and as expected, the field in the issue reporter is not set to a specific extension. However, I'd appreciate a warning log in the debug console that warns devs that they have an invalid

Related discussion:
text: githubAccessToken }, dataOverrides); <ins> if (issueReporterData.extensionId) { const extensionExists = extensionData.some(extension => extension.id === issueReporterData.extensionId); if (!extensionExists) { console.error(`Extension with ID ${issueReporterData.extensionId} does not exist.`); } } </ins> if (issueReporterData.extensionId && this.extensionIdentifierSet.has(issueReporterData.extensionId)) { ipcRenderer.send(`vscode:triggerReporterMenuResponse:${issueReporterData.extensionId}`, issueReporterData); this.extensionIdentifierSet.delete(new ExtensionIdentifier(issueReporterData.extensionId));
Code change:
Testing I had the arg For and clicking "Create on GitHub" did nothing. I would expect an error to log in the console for this so that devs know what has happened.
Did this log anything in the console? (ie, or something like that)
I didn't see anything in the debug console.
Technically, it's a valid URI, but it doesn't resolve to a valid endpoint.

Related discussion:
text: const response = await fetch(url, init); if (!response.ok) { <ins> console.error('Invalid GitHub URL provided.'); </ins> return false; } const result = await response.json();
Code change:
Testing I had the arg For and clicking "Create on GitHub" did nothing. I would expect an error to log in the console for this so that devs know what has happened.
Did this log anything in the console? (ie, or something like that)
I didn't see anything in the debug console.
Technically, it's a valid URI, but it doesn't resolve to a valid endpoint.

Related discussion:
text: let issueUrl = hasUri ? this.getExtensionBugsUrl() : this.getIssueUrl(); if (!issueUrl) { <ins> console.error('No issue url found'); </ins> return false; }
Code change:
Testing I had the arg For and clicking "Create on GitHub" did nothing. I would expect an error to log in the console for this so that devs know what has happened.
Did this log anything in the console? (ie, or something like that)
I didn't see anything in the debug console.
Technically, it's a valid URI, but it doesn't resolve to a valid endpoint.

Related discussion:
text: try { url = await this.writeToClipboard(baseUrl, issueBody); } catch (_) { <ins> console.error('Writing to clipboard failed'); </ins> return false; } }
Code change:
Testing I had the arg For and clicking "Create on GitHub" did nothing. I would expect an error to log in the console for this so that devs know what has happened.
Did this log anything in the console? (ie, or something like that)
I didn't see anything in the debug console.
Technically, it's a valid URI, but it doesn't resolve to a valid endpoint.

Related discussion:
text: owner: match[1], repositoryName: match[2] }; <ins> } else { console.error('No GitHub match'); </ins> } return undefined;
Code change:
Testing I had the arg For and clicking "Create on GitHub" did nothing. I would expect an error to log in the console for this so that devs know what has happened.
Did this log anything in the console? (ie, or something like that)
I didn't see anything in the debug console.
Technically, it's a valid URI, but it doesn't resolve to a valid endpoint.

Related discussion:
text: githubAccessToken }, dataOverrides); <ins> if (issueReporterData.extensionId) { const extensionExists = extensionData.some(extension => extension.id === issueReporterData.extensionId); if (!extensionExists) { console.error(`Extension with ID ${issueReporterData.extensionId} does not exist.`); } } </ins> if (issueReporterData.extensionId && this.extensionIdentifierSet.has(issueReporterData.extensionId)) { ipcRenderer.send(`vscode:triggerReporterMenuResponse:${issueReporterData.extensionId}`, issueReporterData); this.extensionIdentifierSet.delete(new ExtensionIdentifier(issueReporterData.extensionId));
Code change:
Testing I'm not sure what the correct fix is but if the text was generated outside of the view, I would image the editor would scroll horizontally as text gets inserted. (same as typing in the editor). !
Yes, very good catch.

Related discussion:
text: previewStart = assertIsDefined(this.editor.getPosition()); } <ins> const endPosition = new Position(previewStart.lineNumber, previewStart.column + text.length); </ins> this.editor.executeEdits(EditorDictation.ID, [ EditOperation.replace(Range.fromPositions(previewStart, previewStart.with(undefined, previewStart.column + lastReplaceTextLength)), text) ], [ <del> Selection.fromPositions(new Position(previewStart.lineNumber, previewStart.column + text.length)) </del> <ins> Selection.fromPositions(endPosition) </ins> ]); if (isPreview) {
Code change:
Testing I'm not sure what the correct fix is but if the text was generated outside of the view, I would image the editor would scroll horizontally as text gets inserted. (same as typing in the editor). !
Yes, very good catch.

Related discussion:
text: lastReplaceTextLength = 0; } <ins> this.editor.revealPositionInCenterIfOutsideViewport(endPosition); </ins> this.widget.layout(); };
Code change:
Fyi
Verification: install the pre-release version of speech extension: make sure is configured to (it should be by default) switch VS Code display language to another language that is supported by the speech extension such as german or portuguese start voice dictation in a text editor via "Start Dictation in Editor" verify you get prompted to install the related language pack for the display language you picked

Related discussion:
text: import { RawContextKey } from 'vs/platform/contextkey/common/contextkey'; import { workbenchConfigurationNodeBase, Extensions as WorkbenchExtensions, IConfigurationMigrationRegistry, ConfigurationKeyValuePairs } from 'vs/workbench/common/configuration'; import { AccessibilityAlertSettingId, AccessibilitySignal } from 'vs/platform/accessibilitySignal/browser/accessibilitySignalService'; <del> import { ISpeechService } from 'vs/workbench/contrib/speech/common/speechService'; </del> <ins> import { ISpeechService, SPEECH_LANGUAGES, SPEECH_LANGUAGE_CONFIG } from 'vs/workbench/contrib/speech/common/speechService'; </ins> import { Disposable } from 'vs/base/common/lifecycle'; import { IWorkbenchContribution } from 'vs/workbench/common/contributions'; import { Event } from 'vs/base/common/event';