jiebi/CodeConvo huggingface dataset:
Code change:
When I put a fenced code area in the middle of a bulleted list, I notice that list entries following the fenced code area lose their formatting, like so: ! Is this intentional behavior? Am I formatting my markdown wrong? Is there any way that I can have formatting in both the fenced code block and the subsequent list items?
The current formatting is somewhat off: the second list is treated as code block. ! This is expected and is in keeping with the common mark spec. The correct formatting would be to indent fenced code block as well: javascript for(var i = 0; i < 5; i++){ ("Hello"); } ! Our syntax coloring is off here though, with the indented code block no longer being highlighted as js
Okay. I didn't read the markdown specification closely enough to understand that the code block should be highlighted as well. I had tried indenting the code block, but when the indented code block lost syntax highlighting, I thought I was doing something incorrect. Should I update the title of this issue to indicate that the real problem is that indented code blocks lose formatting?
Thanks I've just gone ahead and updated the title of the issue to: "Markdown Fenced Code Block in Indented List Not Properly Highlighted". If you do not feel that the new title accurately captures the bug here, feel free to update the title again
New title looks good. Thanks!
I made an extension to fix this Surely it would cause side effects but it is worth it for me at the moment.

Related discussion:
text: <array> <dict> <key>include</key> <del> <string>#list_paragraph</string> </del> <ins> <string>#block</string> </ins> </dict> <dict> <key>include</key> <del> <string>#block</string> </del> <ins> <string>#list_paragraph</string> </ins> </dict> </array> <key>while</key>
Code change:
Testing Insiders dated 28th March, 2017 Happens in linux and windows <img width="333" alt="screen shot 2017-03-28 at 11 42 13 am" src=""

Related discussion:
text: background-color: transparent!important; color: #333; -webkit-user-select: initial; <del> overflow: hidden; /* prevents the terminal output being incorrectly placed over the title */ </del> position: relative; } .vs-dark .monaco-workbench .panel.integrated-terminal { color: #CCC; }
Code change:
Testing Insiders dated 28th March, 2017 Happens in linux and windows <img width="333" alt="screen shot 2017-03-28 at 11 42 13 am" src=""

Related discussion:
text: }, 'terminal.integrated.enableBold': { 'type': 'boolean', <del> 'description': nls.localize('terminal.integrated.enableBold', "Whether to enable bold text within the terminal."), </del> <ins> 'description': nls.localize('terminal.integrated.enableBold', "Whether to enable bold text within the terminal, this requires support from the termianl shell."), </ins> 'default': true }, 'terminal.integrated.cursorBlinking': {
Code change:
Testing Insiders dated 28th March, 2017 Happens in linux and windows <img width="333" alt="screen shot 2017-03-28 at 11 42 13 am" src=""

Related discussion:
text: }); } <del> public setWidgetManager(widgetManager: TerminalWidgetManager) { </del> <ins> public setWidgetManager(widgetManager: TerminalWidgetManager): void { </ins> this._widgetManager = widgetManager; }
Code change:
Testing Insiders dated 28th March, 2017 Happens in linux and windows <img width="333" alt="screen shot 2017-03-28 at 11 42 13 am" src=""

Related discussion:
text: callback(true); } <del> private _addTooltipEventListeners(element: HTMLElement) { </del> <ins> private _addTooltipEventListeners(element: HTMLElement): void { </ins> let timeout = null; let isMessageShowing = false; this._tooltipDisposables.push(dom.addDisposableListener(element, dom.EventType.MOUSE_OVER, () => {
Code change:
Testing in this setup Get this Code lense with '0 References' in ! Clicking the references link just shows an empty peek, it is not clear what is being search for. !
Now I understand what is going on: ! The reference in the template isn't found by the Angular Language Service extension.
Do you suggest we don't show the peek view from zero references code lens? Or should the peek view have more info on what would normally be displayed?
since the empty peek view is not helpful I would not show it and '0 References' should not be shown as a link on hover.

Related discussion:
text: title: locations.length === 1 ? localize('oneImplementationLabel', '1 implementation') : localize('manyImplementationLabel', '{0} implementations', locations.length), <del> command: 'editor.action.showReferences', </del> <ins> command: locations.length ? 'editor.action.showReferences' : '', </ins> arguments: [codeLens.document, codeLens.range.start, locations] }; return codeLens;
Code change:
Testing in this setup Get this Code lense with '0 References' in ! Clicking the references link just shows an empty peek, it is not clear what is being search for. !
Now I understand what is going on: ! The reference in the template isn't found by the Angular Language Service extension.
Do you suggest we don't show the peek view from zero references code lens? Or should the peek view have more info on what would normally be displayed?
since the empty peek view is not helpful I would not show it and '0 References' should not be shown as a link on hover.

Related discussion:
text: title: locations.length === 1 ? localize('oneReferenceLabel', '1 reference') : localize('manyReferenceLabel', '{0} references', locations.length), <del> command: 'editor.action.showReferences', </del> <ins> command: locations.length ? 'editor.action.showReferences' : '', </ins> arguments: [codeLens.document, codeLens.range.start, locations] }; return codeLens;
Code change:
Testing in this setup Get this Code lense with '0 References' in ! Clicking the references link just shows an empty peek, it is not clear what is being search for. !
Now I understand what is going on: ! The reference in the template isn't found by the Angular Language Service extension.
Do you suggest we don't show the peek view from zero references code lens? Or should the peek view have more info on what would normally be displayed?
since the empty peek view is not helpful I would not show it and '0 References' should not be shown as a link on hover.

Related discussion:
text: title: command.title }; <del> if (!isFalsyOrEmpty(command.arguments)) { </del> <ins> if (command.command && !isFalsyOrEmpty(command.arguments)) { </ins> // we have a contributed command with arguments. that // means we don't want to send the arguments around
Code change:
! Note the extra bar the right of the blue block quote bar
I hope my fix will work for you. :smile:

Related discussion:
text: border-left: 3px solid rgba(0, 0, 0, 0.40); } <ins> .vscode-light.showEditorSelection .code-line .code-line:hover:before { border-left: none; } </ins> .vscode-dark.showEditorSelection .code-active-line:before { border-left: 3px solid rgba(255, 255, 255, 0.4); }
Code change:
! Note the extra bar the right of the blue block quote bar
I hope my fix will work for you. :smile:

Related discussion:
text: border-left: 3px solid rgba(255, 255, 255, 0.60); } <ins> .vscode-dark.showEditorSelection .code-line .code-line:hover:before { border-left: none; } </ins> .vscode-high-contrast.showEditorSelection .code-active-line:before { border-left: 3px solid rgba(255, 160, 0, 0.7); }
Code change:
! Note the extra bar the right of the blue block quote bar
I hope my fix will work for you. :smile:

Related discussion:
text: border-left: 3px solid rgba(255, 160, 0, 1); } <ins> .vscode-high-contrast.showEditorSelection .code-line .code-line:hover:before { border-left: none; } </ins> img { max-width: 100%; max-height: 100%;
Code change:
VSCode Version: Code - Insiders 1.13.0-insider (, 2017-05-26T05:14:23.944Z) OS Version: Windows_NT ia32 10.0. Currently you can multi-select items in the Git files view and if you right-click, the & menu items will only open the file/change of the focused item, with the stage/unstage command work with the whole selection. It would be great to have these 2 command act upon the whole selection.

Related discussion:
text: await this._openResource(resource); } <del> private async _openResource(resource: Resource): Promise<void> { </del> <ins> private async _openResource(resource: Resource, preview?: boolean): Promise<void> { </ins> const left = this.getLeftResource(resource); const right = this.getRightResource(resource); const title = this.getTitle(resource);
Code change:
VSCode Version: Code - Insiders 1.13.0-insider (, 2017-05-26T05:14:23.944Z) OS Version: Windows_NT ia32 10.0. Currently you can multi-select items in the Git files view and if you right-click, the & menu items will only open the file/change of the focused item, with the stage/unstage command work with the whole selection. It would be great to have these 2 command act upon the whole selection.

Related discussion:
text: const viewColumn = window.activeTextEditor && window.activeTextEditor.viewColumn || ViewColumn.One; <del> if (!left) { return await commands.executeCommand<void>('vscode.open', right, viewColumn); } </del> const opts: TextDocumentShowOptions = { <ins> preserveFocus: true, preview: preview, </ins> viewColumn };
Code change:
VSCode Version: Code - Insiders 1.13.0-insider (, 2017-05-26T05:14:23.944Z) OS Version: Windows_NT ia32 10.0. Currently you can multi-select items in the Git files view and if you right-click, the & menu items will only open the file/change of the focused item, with the stage/unstage command work with the whole selection. It would be great to have these 2 command act upon the whole selection.

Related discussion:
text: opts.selection = activeTextEditor.selection; } <ins> if (!left) { const document = await workspace.openTextDocument(right); await window.showTextDocument(document, opts); return; } </ins> return await commands.executeCommand<void>('vscode.diff', left, right, title, opts); }
Code change:
VSCode Version: Code - Insiders 1.13.0-insider (, 2017-05-26T05:14:23.944Z) OS Version: Windows_NT ia32 10.0. Currently you can multi-select items in the Git files view and if you right-click, the & menu items will only open the file/change of the focused item, with the stage/unstage command work with the whole selection. It would be great to have these 2 command act upon the whole selection.

Related discussion:
text: } @command('git.openFile') <del> async openFile(arg?: Resource | Uri): Promise<void> { let uri: Uri | undefined; </del> <ins> async openFile(arg?: Resource | Uri, ...resourceStates: SourceControlResourceState[]): Promise<void> { let uris: Uri[] | undefined; </ins> if (arg instanceof Uri) { if (arg.scheme === 'git') { <del> uri = Uri.file(fromGitUri(arg).path); </del> <ins> uris = [Uri.file(fromGitUri(arg).path)]; </ins> } else if (arg.scheme === 'file') { <del> uri = arg; </del> <ins> uris = [arg]; </ins> } } else { let resource = arg;
Code change:
VSCode Version: Code - Insiders 1.13.0-insider (, 2017-05-26T05:14:23.944Z) OS Version: Windows_NT ia32 10.0. Currently you can multi-select items in the Git files view and if you right-click, the & menu items will only open the file/change of the focused item, with the stage/unstage command work with the whole selection. It would be great to have these 2 command act upon the whole selection.

Related discussion:
text: } if (resource) { <del> uri = resource.resourceUri; </del> <ins> uris = [...resourceStates.map(r => r.resourceUri), resource.resourceUri]; </ins> } } <del> if (!uri) { </del> <ins> if (!uris) { </ins> return; } <del> const activeTextEditor = window.activeTextEditor && window.activeTextEditor; const isSameUri = activeTextEditor && activeTextEditor.document.uri.toString() === uri.toString(); const selections = activeTextEditor && activeTextEditor.selections; const viewColumn = activeTextEditor && activeTextEditor.viewColumn || ViewColumn.One; await commands.executeCommand<void>('vscode.open', uri, viewColumn); if (isSameUri && selections && window.activeTextEditor) { window.activeTextEditor.selections = selections; </del> <ins> const preview = uris.length === 1 ? true : false; const activeTextEditor = window.activeTextEditor; for (const uri of uris) { // If the active editor matches the current uri, get its selection const selections = activeTextEditor && activeTextEditor.document.uri.toString() === uri.toString() ? activeTextEditor.selections : undefined; const opts: TextDocumentShowOptions = { preserveFocus: true, preview: preview, viewColumn: activeTextEditor && activeTextEditor.viewColumn || ViewColumn.One }; const document = await workspace.openTextDocument(uri); await window.showTextDocument(document, opts); if (selections && window.activeTextEditor) { window.activeTextEditor.selections = selections; } </ins> } }
Code change:
VSCode Version: Code - Insiders 1.13.0-insider (, 2017-05-26T05:14:23.944Z) OS Version: Windows_NT ia32 10.0. Currently you can multi-select items in the Git files view and if you right-click, the & menu items will only open the file/change of the focused item, with the stage/unstage command work with the whole selection. It would be great to have these 2 command act upon the whole selection.

Related discussion:
text: } @command('git.openChange') <del> async openChange(arg?: Resource | Uri): Promise<void> { let resource: Resource | undefined = undefined; </del> <ins> async openChange(arg?: Resource | Uri, ...resourceStates: SourceControlResourceState[]): Promise<void> { let resources: Resource[] | undefined = undefined; </ins> <del> if (arg instanceof Resource) { resource = arg; } else if (arg instanceof Uri) { resource = this.getSCMResource(arg); } else { resource = this.getSCMResource(); </del> <ins> if (arg instanceof Uri) { const resource = this.getSCMResource(arg); if (resource !== undefined) { resources = [resource]; } </ins> } <ins> else { let resource: Resource | undefined = undefined; if (arg instanceof Resource) { resource = arg; } else { resource = this.getSCMResource(); } </ins> <del> if (!resource) { </del> <ins> if (resource) { resources = [...resourceStates as Resource[], resource]; } } if (!resources) { </ins> return; } <del> return await this._openResource(resource); </del> <ins> const preview = resources.length === 1 ? undefined : false; for (const resource of resources) { await this._openResource(resource, preview); } </ins> } @command('git.stage')
Code change:
<!-- Do you have a question? Please ask it on --- VSCode Version: Version 1.12.1 (1.12.1) OS Version: Windows 64 bits This issue is not a bug but just a suggestion/idea to improve CodeLens performance for TypeScript when and are activated. In this case tsserver command which can take times and response can be big is called twice: one call of navtree for providing references CodeLens. one call of navtree for providing implementation CodeLens. I tell me if CodeLens provider could manage a shared context to store some data that other code lens provider could use it. For instance in this case, we could have just one call of navtree: one call of navtree for providing references CodeLens and store the result in a shared context. the implementation CodeLens provider search navtree from the shared context.

Related discussion:
text: } } <ins> export class CachedNavTreeResponse { response?: Promise<Proto.NavTreeResponse>; version: number = -1; document: string = ''; matches(document: TextDocument): boolean { return this.version === document.version && this.document === document.uri.toString(); } update(document: TextDocument, response: Promise<Proto.NavTreeResponse>) { this.response = response; this.version = document.version; this.document = document.uri.toString(); } } </ins> export abstract class TypeScriptBaseCodeLensProvider implements CodeLensProvider { private enabled: boolean = true; private onDidChangeCodeLensesEmitter = new EventEmitter<void>(); public constructor( <del> protected client: ITypeScriptServiceClient </del> <ins> protected client: ITypeScriptServiceClient, private cachedResponse: CachedNavTreeResponse </ins> ) { } public get onDidChangeCodeLenses(): Event<void> {
Code change:
<!-- Do you have a question? Please ask it on --- VSCode Version: Version 1.12.1 (1.12.1) OS Version: Windows 64 bits This issue is not a bug but just a suggestion/idea to improve CodeLens performance for TypeScript when and are activated. In this case tsserver command which can take times and response can be big is called twice: one call of navtree for providing references CodeLens. one call of navtree for providing implementation CodeLens. I tell me if CodeLens provider could manage a shared context to store some data that other code lens provider could use it. For instance in this case, we could have just one call of navtree: one call of navtree for providing references CodeLens and store the result in a shared context. the implementation CodeLens provider search navtree from the shared context.

Related discussion:
text: return []; } try { <del> const response = await this.client.execute('navtree', { file: filepath }, token); </del> <ins> if (!this.cachedResponse.matches(document)) { this.cachedResponse.update(document, this.client.execute('navtree', { file: filepath }, token)); } const response = await this.cachedResponse.response; </ins> if (!response) { return []; } const tree = response.body; const referenceableSpans: Range[] = []; if (tree && tree.childItems) {
Code change:
<!-- Do you have a question? Please ask it on --- VSCode Version: Version 1.12.1 (1.12.1) OS Version: Windows 64 bits This issue is not a bug but just a suggestion/idea to improve CodeLens performance for TypeScript when and are activated. In this case tsserver command which can take times and response can be big is called twice: one call of navtree for providing references CodeLens. one call of navtree for providing implementation CodeLens. I tell me if CodeLens provider could manage a shared context to store some data that other code lens provider could use it. For instance in this case, we could have just one call of navtree: one call of navtree for providing references CodeLens and store the result in a shared context. the implementation CodeLens provider search navtree from the shared context.

Related discussion:
text: export default class TypeScriptImplementationsCodeLensProvider extends TypeScriptBaseCodeLensProvider { public constructor( client: ITypeScriptServiceClient, <del> private readonly language: string </del> <ins> private readonly language: string, cachedResponse: CachedNavTreeResponse </ins> ) { <del> super(client); </del> <ins> super(client, cachedResponse); </ins> } public updateConfiguration(): void {
Code change:
<!-- Do you have a question? Please ask it on --- VSCode Version: Version 1.12.1 (1.12.1) OS Version: Windows 64 bits This issue is not a bug but just a suggestion/idea to improve CodeLens performance for TypeScript when and are activated. In this case tsserver command which can take times and response can be big is called twice: one call of navtree for providing references CodeLens. one call of navtree for providing implementation CodeLens. I tell me if CodeLens provider could manage a shared context to store some data that other code lens provider could use it. For instance in this case, we could have just one call of navtree: one call of navtree for providing references CodeLens and store the result in a shared context. the implementation CodeLens provider search navtree from the shared context.

Related discussion:
text: import * as Proto from '../protocol'; import * as PConst from '../protocol.const'; <del> import { TypeScriptBaseCodeLensProvider, ReferencesCodeLens } from './baseCodeLensProvider'; </del> <ins> import { TypeScriptBaseCodeLensProvider, ReferencesCodeLens, CachedNavTreeResponse } from './baseCodeLensProvider'; </ins> import { ITypeScriptServiceClient } from '../typescriptService'; import { tsTextSpanToVsRange, vsPositionToTsFileLocation } from '../utils/convert';
Code change:
<!-- Do you have a question? Please ask it on --- VSCode Version: Version 1.12.1 (1.12.1) OS Version: Windows 64 bits This issue is not a bug but just a suggestion/idea to improve CodeLens performance for TypeScript when and are activated. In this case tsserver command which can take times and response can be big is called twice: one call of navtree for providing references CodeLens. one call of navtree for providing implementation CodeLens. I tell me if CodeLens provider could manage a shared context to store some data that other code lens provider could use it. For instance in this case, we could have just one call of navtree: one call of navtree for providing references CodeLens and store the result in a shared context. the implementation CodeLens provider search navtree from the shared context.

Related discussion:
text: export default class TypeScriptReferencesCodeLensProvider extends TypeScriptBaseCodeLensProvider { public constructor( client: ITypeScriptServiceClient, <del> private readonly language: string </del> <ins> private readonly language: string, cachedResponse: CachedNavTreeResponse </ins> ) { <del> super(client); </del> <ins> super(client, cachedResponse); </ins> } public updateConfiguration(): void {
Code change:
<!-- Do you have a question? Please ask it on --- VSCode Version: Version 1.12.1 (1.12.1) OS Version: Windows 64 bits This issue is not a bug but just a suggestion/idea to improve CodeLens performance for TypeScript when and are activated. In this case tsserver command which can take times and response can be big is called twice: one call of navtree for providing references CodeLens. one call of navtree for providing implementation CodeLens. I tell me if CodeLens provider could manage a shared context to store some data that other code lens provider could use it. For instance in this case, we could have just one call of navtree: one call of navtree for providing references CodeLens and store the result in a shared context. the implementation CodeLens provider search navtree from the shared context.

Related discussion:
text: import DiagnosticsManager from './features/diagnostics'; import { LanguageDescription } from './utils/languageDescription'; import * as fileSchemes from './utils/fileSchemes'; <ins> import { CachedNavTreeResponse } from './features/baseCodeLensProvider'; </ins> const validateSetting = 'validate.enable';