Code change:
Currently blocked by:
Branch is at
The arg is causing the issue on Windows. This: Calls which passes to .
It may not work because out-build doesn't exist. I can repro when doing:
After spending quite a bit of time looking into this, I'm pretty stumped on why this is failing. any help would be great as I'm not sure where to go from here. Here's what I've found so far: I can reproduce using the following: Unit tests on Windows fail at random times Passing shows the window and all tests complete, with KeyboardMapper tests failing which I frequently when running unit tests on Windows. ! Listening to the in addition to printing test names seems to stop at random spots, telling me that this isn't related to a single test. Here are the end of some logs from test runs:The test runner pauses for 2-5 seconds after a the last output and then exits.
I just tried to reproduce on Windows, for me the tests are looking all OK. Do you see the test failures on the command line as output?
the output stops before any failures example output: etc.
does this reproduce with mocha tests (and the exact same version that electron 1.7.4 uses) too?
Seems to happen when using node 7.9.0 as well which ships with 1.7.4. Currently the build machine is set up to use 7.10.0 (set in ).
Ok so it seems electron unrelated then. Can you explain this, are you saying the keyboard mapper test is causing this?
No, the keyboard mapper tests on Windows just have always seemed to fail for me a lot on most of my Windows machines.
Created to track upstream. It appears to be happening only when using because calls stop making it to the main process after a short period.
Possibly related:
Update: It appears is an issue with my home desktop only and is different to what we're seeing on the VSTS build server. So I started to add some logs and run more builds on VSTS to see what is going on and it appears like the tests are exiting with but is being set to 255. I made a change to the test script to change error code 255 to 0 to get around this issue since the tests were passing anyway After doing this I did a full build and it succeeded, however it does not launch. running with gives this:
That's pointing at , perhaps it's related to the snapshot stuff?
Commenting out the "Create loader snapshot" step from fixes the exception on launch Also integration tests are not running on VSTS for Windows, this may have caught the snapshot issue earlier.
When updating electron you must also bump the version of . Unsure if there is electron migration guide that should have been updated...
Added to the guide
Discussed with we will shift this to August.
could you look into the exit code issue when you get a chance? We're seeing VSTS giving an exit code of 255 even though appears to be getting called. The change for that is here:
When I log in to the build machine and try to run , the unit tests don't even run at all. All I see is two processes stuck. Do you see this too? ! I also can't find the build where you had a 255 exit code.
interestingly I just noticed that Electron marks 1.7.5 as "latest release" while 1.7.4 is still a pre-release. We should consider being on the latest official release if possible imho. ! !
well I've never been able to log into the machine, I an echo %errorlevel% and it was printing 255 after the tests. It looks like VSTS has discarded the build as it wasn't marked as retain. If the Windows builds succeed after this line is removed then all is well:
Update: I have Electron 1.7.5 on the branch , I'm running into build issues on VSTS/macOS though which appear to be related to using the new file watcher in the build? Not sure why an updated Electron would make this error occur yet though.
We got that error in the official smoke tests and Andre said in Slack that the Mac build machine was messed up. Try it again.
Will do

Related discussion:
text: { "name": "code-oss-dev", "version": "1.16.0", <del> "electronVersion": "1.7.4", </del> <ins> "electronVersion": "1.7.5", </ins> "distro": "724097db097bfde7796fcca70aaac83ba80a95f8", "author": { "name": "Microsoft Corporation"