jiebi/CodeConvo huggingface dataset:
Code change:
import { isIOS } from 'vs/base/common/platform'; import Severity from 'vs/base/common/severity'; import { ThemeIcon } from 'vs/base/common/themables'; <del> import { isString, withNullAsUndefined } from 'vs/base/common/types'; </del> <ins> import { isString, withNullAsUndefined, withUndefinedAsNull } from 'vs/base/common/types'; </ins> import 'vs/css!./media/quickInput'; import { localize } from 'vs/nls'; import { ILayoutService } from 'vs/platform/layout/browser/layoutService';

Related discussion:
text: vscode-spring-boot-dashboard0.12.0 vscode-spring-initializr0.11.2 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
This is happening because of the fix for I think it is behaving as designed, though will leave that with
That's a bit weird. Since experience does not visually render a placeholder. So I would not expect it gets read out.
Question is, should it say nothing, or is the aria-label for not correct and it should be ? I'm leaning "nothing" because otherwise they might have to hold down until the actual quick pick option highlighted is read out.
I have a fix out with the "nothing" idea... but would love to know what you folks think before I merge.
In version 1.77, when I press ctrl+tab, orca informs me that the focus has moved to a list box and the name of the next file is read. Imagining the following scenario: two files, a.js and b.js. start editing the a.js file. press ctlr+tab. My screen reader reads the following information: List Box, b.js. In my view this behavior would be sufficient.
It is fixed, thanks.
Code change:
"build-notebook": "node ./esbuild" }, "dependencies": { <del> "@vscode/markdown-it-katex": "^1.0.3" </del> <ins> "@vscode/markdown-it-katex": "^1.1.0" </ins> }, "devDependencies": { "@types/markdown-it": "^0.0.0",

Related discussion:
text: Type: <bBug</bWhen editing a Markdown file, VS Code will apply LaTeX syntax highlighting to math in double-dollar signs (math blocks), e.g., will color and and the numbers. GitHub Markdown also supports a code block syntax (the triple-tick syntax; see ), so the above could be written in GitHub-flavored Markdown as <img width="200" alt="image" src="https://user-"It'd be nice if it could apply the same highlighting as double-dollar signs. VS Code version: Code 1.75.1 (Universal) (, 2023-02-08T21:34:59.000Z) OS version: Darwin arm64 22.2.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (19)</summaryExtensionVersion ------ prettier-vscode9.10.4 linter-gfortran3.2.0 unicode-math-vscode0.3.5 isort2022.8.0 python2023.2.0 vscode-pylance2023.2.30 jupyter2023.1. jupyter-keymap1.0.0 jupyter-renderers1.0.14 vscode-jupyter-cell-tags0.1.6 vscode-jupyter-slideshow0.1.5 cmake-tools1.13.45 cpptools1.14.3 cpptools-extension-pack1.3.0 vsliveshare1.0.5831 rewrap1.16.3 cmake0.0.17 clang-format1.9.0 markdown-all-in-one3.5.0 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Yay, 23 upvotes!!
<!-- -c9e0-7adb-d31b- --:slightlysmilingface: This feature request received a sufficient number of community upvotes and we moved it to our backlog.
Code change:
"build-notebook": "node ./esbuild" }, "dependencies": { <del> "@vscode/markdown-it-katex": "^1.0.3" </del> <ins> "@vscode/markdown-it-katex": "^1.1.0" </ins> }, "devDependencies": { "@types/markdown-it": "^0.0.0",

Related discussion:
text: To learn more about how we handle feature requests, please see our . Happy Coding!
Having math block and code-block specific code linting would be also great!
Code change:
'properties': { 'workbench.startupEditor': { 'type': 'string', <del> 'enum': ['none', 'welcomePage', 'newUntitledFile'], </del> <ins> 'enum': ['none', 'welcomePage', 'newUntitledFile', 'welcomePageInEmptyWorkbench'], </ins> 'enumDescriptions': [ localize({ comment: ['This is the description for a setting. Values surrounded by single quotes are not to be translated.'], key: 'workbench.startupEditor.none' }, "Start without an editor."), localize({ comment: ['This is the description for a setting. Values surrounded by single quotes are not to be translated.'], key: 'workbench.startupEditor.welcomePage' }, "Open the Welcome page (default)."), localize({ comment: ['This is the description for a setting. Values surrounded by single quotes are not to be translated.'], key: 'workbench.startupEditor.newUntitledFile' }, "Open a new untitled file (only applies when opening an empty workspace)."), <ins> localize({ comment: ['This is the description for a setting. Values surrounded by single quotes are not to be translated.'], key: 'workbench.startupEditor.welcomePageInEmptyWorkbench' }, "Open the Welcome page when opening an empty workbench."), </ins> ], 'default': 'welcomePage', 'description': localize('workbench.startupEditor', "Controls which editor is shown at startup, if none are restored from the previous session.")

Related discussion:
text: You can debug it either in VS Code or in the Developer Tools (Help Toggle Developer Tools in the window running from source).
Upon opening a new window, it isn't undefined (verified by a console log) but then it turns undefined (verified by the same console log). Edit: and immediately after Edit2: Found it! Seems like isWelcomePageEnabled() is called twice, once in the class constructor and the other one in the onReady method. I'll make the PR in a bit
Code change:
const original = md.renderer.rules.image; md.renderer.rules.image = (tokens: Token[], idx: number, options, env: RenderEnv, self) => { const token = tokens[idx]; <del> token.attrJoin('class', 'loading'); </del> const src = token.attrGet('src'); if (src) { <del> env.containingImages?.push({ src }); const imgHash = stringHash(src); token.attrSet('id', `image-hash-${imgHash}`); </del> <ins> env.containingImages?.add(src); </ins> if (!token.attrGet('data-src')) { token.attrSet('src', this.toResourceUri(src, env.currentDocument, env.resourceProvider));

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.1 OS Version: Windows 10 Steps to Reproduce: a Markdown file and open "Open Preview to the Side" add line: ! image in preview second line: ! second image shows up. Remove the line above image preview shows 2 images and does not update properly !
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.68.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Still happens in 1.68.1. Updating bug
Does this reproduce in the with all ?
Yes still happens with all extensions disabled
Code change:
class TestParcelWatcher extends ParcelWatcher { <del> testNormalizePaths(paths: string[]): string[] { </del> <ins> testNormalizePaths(paths: string[], excludes: string[] = []): string[] { </ins> // Work with strings as paths to simplify testing const requests: IRecursiveWatchRequest[] = paths.map(path => { <del> return { path, excludes: [], recursive: true }; </del> <ins> return { path, excludes, recursive: true }; </ins> }); return this.normalizeRequests(requests).map(request => request.path);

Related discussion:
text: I'm using to mount a remote Azure Blob storage container into my local file system with FUSE. Once I open up that mount point (say ) in VSCode, network traffic immediately goes up to around 100 kb/s. In the storage provider's API logs I can see many thousand operation requests per second to files located at any hierarchy level inside my storage container, but also files that do not exists (e.g. ). I was assuming this is related to VSCode attempting to watch these files for changes, but can't use inotify on the remote share, so falls back to polling the files with a crazy frequency. However, applying the following settings didn't have any effect: Same issue occurs with or AWS S3 + and I presume also for sshfs, davfs2_ and the like. When killing the sub-process, I can observe a short decline in network usage until the process almost immediately restarts.
In this case I wonder if we should simply not install the file watcher at all if a setting is configured to disable it. I see no other workaround other than maybe addressing this in our external file watcher where we pass on these exclude rules.
Verification: run with and filter dev tools console to to see only file watcher related output configure to have an entry open a folder verify that in the output for the watcher you see no indication that the folder is being watched compare this to how the output looks like when you not have such a setting
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Code change:
this._list.triggerScrollFromMouseWheelEvent(event); } <ins> previousChange(): void { let currFocus = this._list.getFocus()[0]; if (isNaN(currFocus) || currFocus < 0) { currFocus = 0; } // find the index of previous change let prevChangeIndex = currFocus - 1; while (prevChangeIndex >= 0) { const vm = this._diffElementViewModels[prevChangeIndex]; if (vm.type !== 'unchanged') { break; } prevChangeIndex--; } if (prevChangeIndex >= 0) { this._list.setFocus([prevChangeIndex]); this._list.reveal(prevChangeIndex); } else { // go to the last one const index = lastIndex(this._diffElementViewModels, vm => vm.type !== 'unchanged'); if (index >= 0) { this._list.setFocus([index]); this._list.reveal(index); } } } nextChange(): void { let currFocus = this._list.getFocus()[0]; if (isNaN(currFocus) || currFocus < 0) { currFocus = 0; } // find the index of next change let nextChangeIndex = currFocus + 1; while (nextChangeIndex < this._diffElementViewModels.length) { const vm = this._diffElementViewModels[nextChangeIndex]; if (vm.type !== 'unchanged') { break; } nextChangeIndex++; } if (nextChangeIndex < this._diffElementViewModels.length) { this._list.setFocus([nextChangeIndex]); this._list.reveal(nextChangeIndex); } else { // go to the first one const index = this._diffElementViewModels.findIndex(vm => vm.type !== 'unchanged'); if (index >= 0) { this._list.setFocus([index]); this._list.reveal(index); } } } </ins> createOutput(cellDiffViewModel: DiffElementViewModelBase, cellViewModel: DiffNestedCellViewModel, output: IInsetRenderOutput, getOffset: () => number, diffSide: DiffSide): void { this._insetModifyQueueByOutputId.queue(output.source.model.outputId + (diffSide === DiffSide.Modified ? '-right' : 'left'), async () => { const activeWebview = diffSide === DiffSide.Modified ? this._modifiedWebview : this._originalWebview;

Related discussion:
text: Testing Ideally there would be commands to navigate between changes. And they might deserve an action in the diff title bar. Same as the editor diff experience. !
Why is for these commands? I would expect them to be available from the command palette, since in a regular text editor Show Previous Change and Show Next Change both appear.
Code change:
this._list.triggerScrollFromMouseWheelEvent(event); } <ins> previousChange(): void { let currFocus = this._list.getFocus()[0]; if (isNaN(currFocus) || currFocus < 0) { currFocus = 0; } // find the index of previous change let prevChangeIndex = currFocus - 1; while (prevChangeIndex >= 0) { const vm = this._diffElementViewModels[prevChangeIndex]; if (vm.type !== 'unchanged') { break; } prevChangeIndex--; } if (prevChangeIndex >= 0) { this._list.setFocus([prevChangeIndex]); this._list.reveal(prevChangeIndex); } else { // go to the last one const index = lastIndex(this._diffElementViewModels, vm => vm.type !== 'unchanged'); if (index >= 0) { this._list.setFocus([index]); this._list.reveal(index); } } } nextChange(): void { let currFocus = this._list.getFocus()[0]; if (isNaN(currFocus) || currFocus < 0) { currFocus = 0; } // find the index of next change let nextChangeIndex = currFocus + 1; while (nextChangeIndex < this._diffElementViewModels.length) { const vm = this._diffElementViewModels[nextChangeIndex]; if (vm.type !== 'unchanged') { break; } nextChangeIndex++; } if (nextChangeIndex < this._diffElementViewModels.length) { this._list.setFocus([nextChangeIndex]); this._list.reveal(nextChangeIndex); } else { // go to the first one const index = this._diffElementViewModels.findIndex(vm => vm.type !== 'unchanged'); if (index >= 0) { this._list.setFocus([index]); this._list.reveal(index); } } } </ins> createOutput(cellDiffViewModel: DiffElementViewModelBase, cellViewModel: DiffNestedCellViewModel, output: IInsetRenderOutput, getOffset: () => number, diffSide: DiffSide): void { this._insetModifyQueueByOutputId.queue(output.source.model.outputId + (diffSide === DiffSide.Modified ? '-right' : 'left'), async () => { const activeWebview = diffSide === DiffSide.Modified ? this._modifiedWebview : this._originalWebview;

Related discussion:
text: Testing Notice that the scroll range is below the decorations, even though they're on screen <img width="717" alt="image" src="https://user-"Meanwhile if I scroll to where they're shown, they aren't in viewport <img width="713" alt="image" src="https://user-"This was on the following gif: <img width="401" alt="image" src="https://user-"
Code change:
return true; }); <del> for (const placeholder of incompletePlaceholders) { </del> <ins> const fillInIncompletePlaceholder = (placeholder: Placeholder, stack: Set<number>) => { </ins> const defaultValues = placeholderDefaultValues.get(placeholder.index); <del> if (defaultValues) { const clone = new Placeholder(placeholder.index); clone.transform = placeholder.transform; for (const child of defaultValues) { clone.appendChild(child.clone()); </del> <ins> if (!defaultValues) { return; } const clone = new Placeholder(placeholder.index); clone.transform = placeholder.transform; for (const child of defaultValues) { const newChild = child.clone(); clone.appendChild(newChild); // "recurse" on children that are again placeholders if (newChild instanceof Placeholder && placeholderDefaultValues.has(newChild.index) && !stack.has(newChild.index)) { stack.add(newChild.index); fillInIncompletePlaceholder(newChild, stack); stack.delete(newChild.index); </ins> } <del> snippet.replace(placeholder, [clone]); </del> } <ins> snippet.replace(placeholder, [clone]); }; const stack = new Set<number>(); for (const placeholder of incompletePlaceholders) { fillInIncompletePlaceholder(placeholder, stack); </ins> } return snippet.children.slice(offset);

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Steps to Reproduce: created this simple snippet: I expand the snippet, I get this: Expected this: It uses the first variable as a part of the placeholder of the second variable. The second occurrence of the second variable is not substituted properly. !
Confirmed... Looks like we capture the value of 1 "replication". For now you can workaround by "inlining" the second occurrence of $1, e.g have two times
Code change:
import { IRange, Range } from 'vs/editor/common/core/range'; import { getDefinitionsAtPosition } from 'vs/editor/contrib/gotoSymbol/browser/goToSymbol'; import { goToDefinitionWithLocation } from 'vs/editor/contrib/inlayHints/browser/inlayHintsLocations'; <del> import { Position } from 'vs/editor/common/core/position'; </del> <ins> import { IPosition, Position } from 'vs/editor/common/core/position'; </ins> import { CancellationTokenSource } from 'vs/base/common/cancellation'; import { ILanguageConfigurationService } from 'vs/editor/common/languages/languageConfigurationRegistry'; import { ILanguageFeatureDebounceService } from 'vs/editor/common/services/languageFeatureDebounce';

Related discussion:
text: Testing a Markdown file with headers up to H3, enable Sticky Scroll and scroll up and down in the editor. Stick Scroll a header leve and press . Try to scroll up and down with the arrow keys. Unclear where the cursor focus is. Try typing, the editor doesn't have focus Focus should should probably go to the editor on the selected header. That is the behavior with breadcrumb navigation
This is the general behavior of Sticky Scroll and also reproduces if you select a level via the mouse
Verified on OSS
Code change:
} canSerialize(): boolean { <del> return this.configurationService.getValue<boolean>(InteractiveWindowSetting.interactiveWindowHotExit); </del> <ins> return this.configurationService.getValue<boolean>(InteractiveWindowSetting.interactiveWindowRestore); </ins> } serialize(input: EditorInput): string {

Related discussion:
text: Testing microsoft/vscode-jupyter The setting description says that the 'interactive window session' is restored. But after a reload, it seems that the state has been forgotten e.g. Open the interactive window run run prints 9 reload the window the output is restored but running again will show Note that I had to retype print(x) as there was no way to rerun the previously shown cells What's restored seems to be the last output. Maybe the settings description can clarify that?
Code change:
} canSerialize(): boolean { <del> return this.configurationService.getValue<boolean>(InteractiveWindowSetting.interactiveWindowHotExit); </del> <ins> return this.configurationService.getValue<boolean>(InteractiveWindowSetting.interactiveWindowRestore); </ins> } serialize(input: EditorInput): string {

Related discussion:
text: Testing microsoft/vscode-jupyter IMO is about restoring a editor with unsaved changes, but the interactiveWindow doesn't seem to have a dirty state. Maybe just call it 'interactiveWindow.restore`? It's actually not really a window ;-)
Good point Martin, I think calling it makes better sense. is a bit ambiguous, we can revisit the name for it in the core when we stabilize the API.
Code change:
</header> <div class="content"> <div class="iframe-focused-alert">${vscode.l10n.t("Focus Lock")}</div> <del> <iframe sandbox="allow-scripts allow-forms allow-same-origin"></iframe> </del> <ins> <iframe sandbox="allow-scripts allow-forms allow-same-origin allow-downloads"></iframe> </ins> </div> <script src="${mainJs}" nonce="${nonce}"></script>

Related discussion:
text: Type: <bBug</bSimple Browser to visit a webpage that offers a download. the download. happens :bug: I plan to submit a PR. VS Code version: Code - Insiders 1.80.0-insider (, 2023-06-14T09:02:23.566Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Code change:
// Extensions Management else if (shouldSpawnCliProcess(args)) { <del> const cli = await import(['vs', 'code', 'node', 'cliProcessMain'].join('/') /* TODO@esm workaround to prevent esbuild from inlining this */); </del> <ins> const cli = await import(['./cliProcessMain.js'].join('/') /* TODO@esm workaround to prevent esbuild from inlining this */); </ins> await cli.main(args); return;

Related discussion:
text: Version: 1.94.0-insider Commit: Date: 2024-09-09T17:10:54.809Z Electron: 30.4.0 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Darwin arm64 23.6.0 Steps to Reproduce:
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!