jiebi/CodeConvo huggingface dataset:
Code change:
if (!disableServiceWorker) { hostMessaging.onMessage('did-load-resource', (_event, data) => { <del> navigator.serviceWorker.getRegistration().then(registration => { assertIsDefined(registration.active).postMessage({ channel: 'did-load-resource', data }, data.data?.buffer ? [data.data.buffer] : []); </del> <ins> assertIsDefined(navigator.serviceWorker.controller).postMessage({ channel: 'did-load-resource', data }, data.data?.buffer ? [data.data.buffer] : []); </ins> }); <del> }); </del> hostMessaging.onMessage('did-load-localhost', (_event, data) => { <del> navigator.serviceWorker.getRegistration().then(registration => { assertIsDefined(registration.active).postMessage({ channel: 'did-load-localhost', data }); </del> <ins> assertIsDefined(navigator.serviceWorker.controller).postMessage({ channel: 'did-load-localhost', data }); </ins> }); <del> }); </del> navigator.serviceWorker.addEventListener('message', event => { switch (event.data.channel) {

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.77.1 OS Version: All Steps to Reproduce: This is not a problem in the extension, the extension code is the same, but a commit changes the way webviews are loaded and it's breaking it. This commit: Has introduced a regression that makes my extension unusable. It introduces a problem on webviews in which workers are not available, and causes the following errors in the console: Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'active') at I have been tracking all changes since 1.76.2 release, building VSCode myself, and setting the build to the previous commit, my webview works flawlessly, if I checkout this commit, it's totally broken. I have not been able to send you are reproducible test case, but if interested, I can show you a video on how to use my extension, so you can check for yourself the issue. Thanks!
To add more information, check these two videos: Not working scenario, with the code at 1.77.1: ! Working scenario at the commit previous to the one I mention. Just remark that checking out the code at the commit I'm pointing, causes the not working scenario: !
Sorry you are running into this. Do you have an extension you can share that shows this issue? I can't simply revert the change because it was made to fix an hang with webviews opening. If I can repo this locally though, I can try to investigate
Thanks for checking this one!
Code change:
if (!disableServiceWorker) { hostMessaging.onMessage('did-load-resource', (_event, data) => { <del> navigator.serviceWorker.getRegistration().then(registration => { assertIsDefined(registration.active).postMessage({ channel: 'did-load-resource', data }, data.data?.buffer ? [data.data.buffer] : []); </del> <ins> assertIsDefined(navigator.serviceWorker.controller).postMessage({ channel: 'did-load-resource', data }, data.data?.buffer ? [data.data.buffer] : []); </ins> }); <del> }); </del> hostMessaging.onMessage('did-load-localhost', (_event, data) => { <del> navigator.serviceWorker.getRegistration().then(registration => { assertIsDefined(registration.active).postMessage({ channel: 'did-load-localhost', data }); </del> <ins> assertIsDefined(navigator.serviceWorker.controller).postMessage({ channel: 'did-load-localhost', data }); </ins> }); <del> }); </del> navigator.serviceWorker.addEventListener('message', event => { switch (event.data.channel) {

Related discussion:
text: My extension is this one: Find attached a sample project: These are the steps: Install the extension Unzip in its own folder Open the folder with VSCode With selected, issue the command Toggle Design/Code This will open up the webview, and with the changes, you could see in the console the issues Find here a video with the steps on how to open the webview, and the behavior when its working: ! Thanks!
Needless to say that if I should perform any changes on the extension to make it work, it's not a problem at all. That is, if I can get an idea on what the changes are, have no problem on that. :-) Thanks!
Thanks for the repo steps I have a potential Please try the next VS Code insiders build that comes out and let me know if you still see the problem. With the fix, things seem to be loading correctly: <img width="1129" alt="Screenshot 2023-04-12 at 4 06 24 PM" src="https://user-"
Checked insiders, but not sure if the fix got through, as I see some checks failed: ! Also tried update from the repository, and it seems still is not merged. In any case, what I see in your shot is that the Tool Palette is missing content. The content is provided by loading an external file called "" and it seems the webview is not able to load it: ! Will keep checking, THANKS!
ignore my last message, I have merged your changes locally and works perfect! So once this is merged, consider the issue fixed, thanks a lot!! !
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Code change:
// We're trying to open the welcome page from the Help menu if (!selectedCategory && !selectedStep) { <del> editorService.openEditor({ resource: GettingStartedInput.RESOURCE }); </del> <ins> editorService.openEditor({ resource: GettingStartedInput.RESOURCE, options: <GettingStartedEditorOptions>{ preserveFocus: toSide ?? false } }, toSide ? SIDE_GROUP : undefined); </ins> return; }

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.82.2 OS Version: MacOS 12.0.1 Steps to Reproduce: our extension (Evidence), create a new project using the VS Code command palette which pages open automatically text file is opened automatically on the left walkthrough is opened automatically on the right This was working until one of the more recent VS Code versions I believe. text file is opened in full walkthrough is opened in full, taking over the editor pane from the text file (i.e. you can only see the walkthrough in your editor) This is the function we use to open the walkthrough: Where maps to I was under the impression that the in this function will open the walkthrough "to the side", which was happening successfully before, but is no longer working.
I had an older version of VS Code running on another computer and have confirmed it used to work in VS Code version
should this command be documented here
I did update our docs last week to include this command. Waiting for the newer changes to be published.
Code change:
"tas-client-umd": "0.1.6", "vscode-oniguruma": "1.7.0", "vscode-textmate": "9.0.0", <del> "xterm": "5.2.0-beta.30", "xterm-addon-canvas": "0.4.0-beta.7", </del> <ins> "xterm": "5.2.0-beta.33", "xterm-addon-canvas": "0.4.0-beta.9", </ins> "xterm-addon-search": "0.11.0", "xterm-addon-unicode11": "0.5.0", <del> "xterm-addon-webgl": "0.15.0-beta.7" </del> <ins> "xterm-addon-webgl": "0.15.0-beta.8" </ins> } }

Related discussion:
text: <!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --With the above settings in effect and a terminal open in the bottom panel: If the terminal has focus, the cursor blinks If the terminal doesn't have focus, then the cursor remains visible without blinking Unlike the block-shaped cursor, which becomes hollow when the terminal loses focus, the line-shaped cursor doesn't change appearance when the terminal loses focus; it merely stops blinking. This makes it hard to tell at a glance whether the terminal has focus. So that it's easier to tell whether the terminal has focus, I would like an option to customize how the line-shaped cursor appears in the terminal when it doesn't have focus. Possible options (not exhaustive): Hide the cursor altogether Keep it visible, but make it (say) 50% opacity Show the same hollow block that's used with the block-shaped cursor
I actually thought it showed the hollow block in this case, I think that makes the most sense
try try
We're going back on the decision made in and making unfocused show the rectangle regardless of cursor style. Discussion:
Code change:
set dataProvider(dataProvider: ITreeViewDataProvider | undefined) { if (dataProvider) { <ins> if (this.visible) { this.activate(); } </ins> const self = this; this._dataProvider = new class implements ITreeViewDataProvider { private _isEmpty: boolean = true;

Related discussion:
text: creates a tree view opens the tree view disposes the tree view while it's still open creates the tree view again The tree view will stay empty until it's is toggled Real world repo (also works as steps to verify): to a Codespace (to use a specific build of VS Code you can specify a commit in the URL with , ex ) the Remote Explorer the page. This will cause the Codespace to load with the remote explorer visible 'll see that the Codespace view in the remote explorer is empty
update
Code change:
this.storageService.store(walkthroughMetadataConfigurationKey, JSON.stringify([...this.metadata.entries()]), StorageScope.PROFILE, StorageTarget.USER); <del> if (sectionToOpen && this.configurationService.getValue<string>('workbench.welcomePage.walkthroughs.openOnInstall')) { </del> <ins> const hadLastFoucs = await this.hostService.hadLastFocus(); if (hadLastFoucs && sectionToOpen && this.configurationService.getValue<string>('workbench.welcomePage.walkthroughs.openOnInstall')) { </ins> type GettingStartedAutoOpenClassification = { owner: 'lramos15'; comment: 'When a walkthrthrough is opened upon extension installation';

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No, this is an extension-related issue that arises across extensions with walkthroughs <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.91.1 OS Version: Windows 11 Extension walkthroughs are not launching upon install. Expected behavior: walkthrough launches automatically upon install. Tested on C# Dev Kit extension and Python extension. Seemed to work in 1.90.0 but does not work in 1.91.1. Steps to Reproduce [Windows Sandbox]: a Windows Sandbox Edge and download VS Code (stable) from the VS Code website the C# Dev Kit extension. Note: Upon install the walkthrough is supposed to launch automatically. This is not happening, but I can manually open the walkthrough using these steps. command palette. command 'Welcome: Open Walkthrough' 'Get Started with C# Dev Kit' ! steps 3-7 with the Python extension. Same behavior. Steps to Reproduce [VS Code stable and VS Code insider]: VS Code C# Dev Kit (if you have it installed) VS Code C# Dev Kit extension. Note: Upon install the walkthrough is supposed to launch automatically. This is not happening, but I can manually open the walkthrough using these steps. command palette. command 'Welcome: Open Walkthrough' 'Get Started with C# Dev Kit' steps 2-7 with the Python extension. Same behavior.
closedWith
using the steps above, I am not seeing the walkthrough open when I reinstall the extension
Was just talking with about this- if you've had it installed in the past, it won't work, but for me it works in a window with a clean user-data-dir
Code change:
} } <del> abstract class AbstractLaunch { </del> <ins> abstract class AbstractLaunch implements ILaunch { abstract readonly uri: uri; abstract readonly name: string; abstract readonly workspace: IWorkspaceFolder | undefined; </ins> protected abstract getConfig(): IGlobalConfig | undefined; <ins> abstract openConfigFile(options: { preserveFocus: boolean; type?: string | undefined; suppressInitialConfigs?: boolean | undefined }, token?: CancellationToken | undefined): Promise<{ editor: IEditorPane | null; created: boolean }>; </ins> constructor( protected configurationManager: ConfigurationManager,

Related discussion:
text: <img width="1792" alt="image" src="https://user-"Hi, like visible on the screenshot, more than half of the terminal width in vertical mode is taken to display the path of the file where the log originated. I think this is not relevant to many of us since the path will point to the logger file At some point it gets really hard to read the logs Just to have an option to display path in cli would be enought for me. My screen resolution is 3072x1920 and my zoom level is -0.5 (at 0 it is even worst)
This has always been a bit off- I think only showing the file name would be sufficient
To be honest, who even needs the filename? When debugging I know what my messages mean and where they are generated. If I don't, a simple clickable elipsis will save space and perform the same function by bringing me directly to the line of code.
Code change:
} const stashChanges = await repository.showStash(stash.index); <ins> const stashParentCommit = stash.parents.length > 0 ? stash.parents[0] : `${stash.hash}^`; </ins> if (!stashChanges || stashChanges.length === 0) { return;

Related discussion:
text: a new file with the following content and commit it. the file to like as follows, save it, and create a stash with it the file to like as follows, and save it the "Git: View Stash..." command and pick the created stash diff in the stash should look as follows: <img width="921" alt="image" src=""
Code change:
this._register(DOM.addDisposableListener(document.body, DOM.EventType.DRAG_START, this.onGlobalDragStart.bind(this), true)); this._register(DOM.addDisposableListener(document.body, DOM.EventType.DRAG_END, this.onGlobalDragEnd.bind(this), true)); <del> const addCellDragListener = (eventType: string, handler: (e: CellDragEvent) => void) => { </del> <ins> const addCellDragListener = (eventType: string, handler: (e: CellDragEvent) => void, useCapture = false) => { </ins> this._register(DOM.addDisposableListener( notebookEditor.getDomNode(), eventType,

Related discussion:
text: Tracks enabling the new drop into editor features () for code cells in notebooks Was disabled as we were incorrectly showing the drop into indicator while dragging cells within a notebook
Actually looks like may have the most experience in this area. I'll submit a PR shortly that may fix the issue but will need your help verifying it
Code change:
}, { type: 'array', <del> items: [ </del> <ins> prefixItems: [ </ins> { type: 'string', enum: ['search'] }, { type: 'object',

Related discussion:
text: Type: <bBug</bSteps to reproduce: a fresh, vanilla VS Code Insiders installation without any extensions. and open a new folder. , open it, and save it with the following contents: Actual results: A warning is reported in Problems tab and via yellow squiggles at line 10, column 25 (= character of the line specifying the ): Expected results: No warning is reported. Additional information: The problem matcher has been copied directly from the (). VS Code should not display warnings for unmodified examples from the docs. This also occurs in the current non-insiders release 1.74.0. VS Code version: Code - Insiders 1.75.0-insider (, 2022-12-08T05:20:51.149Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
I can repro this. probably caused by your changes to the schema - could you pls take a look?
Of course. I'll submit the fix.
The PR is ready for review.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified Thanks for the quick fix!
Code change:
? this.options.installPreReleaseVersion /* Respect the passed flag */ : metadata?.preRelease /* Respect the existing pre-release flag if it was set */); } <del> metadata.pinned = this.options.installGivenVersion ? true : undefined; </del> <ins> metadata.pinned = this.options.installGivenVersion ? true : metadata.pinned; </ins> this._profileLocation = metadata.isApplicationScoped ? this.userDataProfilesService.defaultProfile.extensionsResource : this.options.profileLocation; const scannedExtension = URI.isUri(this.extension) ? await this.webExtensionsScannerService.addExtension(this.extension, metadata, this.profileLocation)

Related discussion:
text: <!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --I saw and created this issue anyway because I think that issue is a) too old b) has too many other things going on. <!-- Describe the feature you'd like. --For me, personally, I'd like a simple way to enable/disable automatic extension updates per extension. I really care about updates for many of them and want to read the changelog before I update but for some, like Copilot, who get several updates a day, I really just want to always be on the latest. Copying section 7 from the above: Users could opt-out of Auto-Update for specific extensions, with toggle button next to Disable/Uninstall in Extensions Sidebar (under gear icon menu) and next to those buttons in Extensions Detail Page. This could allow users to stick with previous versions before new high-risk permissions became required This could allow avoiding updating to problematic versions of extensions until issues are resolved. This could allow users to manually review/approve updates based on reviews and changelog for higher (security or reliability) risk extensions This could be controlled per extension without disabling globally as may be desired by default for most extensions. Can be set per extension to "Default" vs Auto-Update vs. Disable Automates, like with Firefox, with Default behavior controlled through global setting. Could provide Undo Update button or choose from version history (like with Chrome/Firefox extension stores) on extension details page, to enable rollback to previous version after an update causes issues, instead of just disabling until if/when ever fixed.
Have you tried to select specific version for extension? This should effectively force version and prevent updates.
No, would that still show if there was an update available?
It should show. Also September 22 update had few updates to including . Check it out
Supported auto updating options per extension/publisher <img width="550" alt="image" src=""This is enabled when auto update mode is disabled or set to (new config)
Code change:
import * as dom from 'vs/base/browser/dom'; import { StandardMouseEvent } from 'vs/base/browser/mouseEvent'; import { createTrustedTypesPolicy } from 'vs/base/browser/trustedTypes'; <ins> import { equals } from 'vs/base/common/arrays'; </ins> import { Disposable, DisposableStore } from 'vs/base/common/lifecycle'; import 'vs/css!./stickyScroll'; import { ICodeEditor, IOverlayWidget, IOverlayWidgetPosition } from 'vs/editor/browser/editorBrowser';

Related discussion:
text: In there is , which seems to be called every time the scroll event of the editor fires. That method seems to clear the dom node and reconstruct it unconditionally. When smooth scrolling is turned on, the scroll event fires many times per second and the call seems to take some time: ! I think if you would only rerender the sticky scroll widget when necessary (and generally try to minimize dom API accesses), we could improve the performance here easily. I think could have an equals method and would just do an early return if the new state equals the old state.
Thanks for this remark. It is a very good optimization point.
Code change:
} async setToken(token: IUserDataSyncAuthToken | undefined): Promise<void> { <del> if (token && this._token ? token.token !== this._token.token && token.authenticationProviderId !== this._token.authenticationProviderId : token !== this._token) { </del> <ins> if (token && this._token ? token.token !== this._token.token || token.authenticationProviderId !== this._token.authenticationProviderId : token !== this._token) { </ins> this._token = token; this._onDidChangeToken.fire(token); }

Related discussion:
text: I see that settings sync is suspended because of invalid token and token is not getting refreshed / updated. Sync LogMicrosoft Account Log Did not work even after Reloading the window / opening new window. Restarting VS Code worked. any insights? Is there a cache on the extension?
From the account log, the token gets refreshed before it expires. This should trigger an event which causes the new token to get set, but it seems like something about this is failing, since we then get into a loop of getting a 401 and trying to resolve the access token.
Every time we see a failure, we unset the token and send token failed request and we update the token by getting it from the account sessions. Looks like we are getting an invalid token from the account sessions. Can you please check if that can happen?
Found the issue! The token was not being set in the shared process
Easier steps to verify: in with an account to preferences sync out of the same account in to the account again Preferences sync should restart without any error.