jiebi/CodeConvo huggingface dataset:
Code change:
.interactive-session .interactive-input-part .interactive-execute-toolbar { height: 22px; <ins> /* It's bottom-aligned, make it appear centered within the container */ margin-bottom: 7px; </ins> } .interactive-session .interactive-input-part .interactive-execute-toolbar .codicon-debug-stop {

Related discussion:
text: In VS Code action items inside inputs are vertically aligned to top, in the Chat features they are centered in the middle. This happens when putting in a lot of text or pressing Shift+Enter. Panel: <img width="425" alt="image" src=""Inline: <img width="608" alt="image" src=""Quick: <img width="621" alt="image" src=""For Inline and Quick the action items to the right of the input box should also stick to the top.
Seems like we have a mix of top-aligned and overflow w/ scroll (see below). But I agree that we should be consistent as much as possible. But it does feel like a chat send button should generally but aligned to the bottom, no? We may even consider rendering the toolbar on its own row once we're into multiple lines. That would ensure the text isn't forced to fill a tiny space now that we have 2+ icons. Here's how Teams does it as an example: ! ! ! !
Would be awesome if the text could wrap around it, especially in the narrow search widget case, I've always wanted that but I think it would be a pain to implement.
Don't have a strong opinion about top or bottom, I think each can be justified on a case-by-case basis. but middle looks weird. :) For example, inline Chat may want to do top alignment as the icons would align with those outside the input field (poppet and close) Bottom would help with the wrapping.
Code change:
@IConfigurationService configurationService: IConfigurationService, @IEditorService editorService: IEditorService, @IBackupFileService backupFileService: IBackupFileService, <ins> @IWorkspaceContextService contextService: IWorkspaceContextService, </ins> @ILifecycleService lifecycleService: ILifecycleService, ) { <del> const enabled = isWelcomePageEnabled(configurationService); </del> <ins> const enabled = isWelcomePageEnabled(configurationService, contextService); </ins> if (enabled && lifecycleService.startupKind !== StartupKind.ReloadedWindow) { backupFileService.hasBackups().then(hasBackups => { const activeEditor = editorService.activeEditor;

Related discussion:
text: When you open a recent project from the welcome screen, the last one remains opened in a tab. VSCode Version: 1.9.1 OS Version: macOS Sierra 10.12.3 Steps to Reproduce: a new VSCode window. a recent project from the welcome screen. project is opened and the welcome screen remains opened.
The current behavior was chosen in the hope that this would help new users by staying in the same context.
I agree that the welcome screen should be closed after taking an action from it. Especially in my case, where I prefer to use the setting, having to close the otherwise empty welcome window after opening from the 'Recents' list or via FileOpen feels like a bug.
You can just not show it at all. Or do you need any of the actions on it? (I'm trying to preserve the new user experience here which relies much more on guidance.)
It's ok showing the welcome screen, but it should be closed after opening a project from there.
With we change the Welcome editor to open in preview mode, this way it will close when the next editor opens. (If preview mode is not disabled in settings.)
This could be an additional value for the setting.
Hey, I could look into this. Got any tips on where I should start ?
Great: Add an additional enum literal here: Check for that literal and the 'open folder' condition here:
Hey , I've ran into some questions which you might be able to help me with: should I name the enum literal? I can't seem to come up with the right name would I check for the 'open folder' condition?
You could use . Check for no folder being open: . You can get at the context service by adding it to the constructor of the calling class, similar to:
Hey everything seems to be working now, just one last question which is confusing me: isn't the objective of this issue to NOT show the Welcome Page when opening a new project? So why is your enum suggestion welcomePageInEmptyWorkbench? What is happening right now after my additions is: upon opening a new project, no Welcome Page is shown. Is this right?
Show it only in the empty workbench. :)
Hey Now I'm getting upon opening a new window (empty workbench). Any ideas? I did the comparison as you said for no folder being open.
Is the ?
Code change:
@IConfigurationService configurationService: IConfigurationService, @IEditorService editorService: IEditorService, @IBackupFileService backupFileService: IBackupFileService, <ins> @IWorkspaceContextService contextService: IWorkspaceContextService, </ins> @ILifecycleService lifecycleService: ILifecycleService, ) { <del> const enabled = isWelcomePageEnabled(configurationService); </del> <ins> const enabled = isWelcomePageEnabled(configurationService, contextService); </ins> if (enabled && lifecycleService.startupKind !== StartupKind.ReloadedWindow) { backupFileService.hasBackups().then(hasBackups => { const activeEditor = editorService.activeEditor;

Related discussion:
text: You can debug it either in VS Code or in the Developer Tools (Help Toggle Developer Tools in the window running from source).
Upon opening a new window, it isn't undefined (verified by a console log) but then it turns undefined (verified by the same console log). Edit: and immediately after Edit2: Found it! Seems like isWelcomePageEnabled() is called twice, once in the class constructor and the other one in the onReady method. I'll make the PR in a bit
Code change:
import { mainWindow } from 'vs/base/browser/window'; import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; import { TitlebarStyle } from 'vs/platform/window/common/window'; <ins> import { IPreferencesService } from 'vs/workbench/services/preferences/common/preferences'; </ins> // Register Icons const menubarIcon = registerIcon('menuBar', Codicon.layoutMenubar, localize('menuBarIcon', "Represents the menu bar"));

Related discussion:
text: ! is not very discoverable. If it would be a submenu of the context menu, it would be much easier to tweak this setting.
...
I'm for making these types of settings more discoverable, however, I do not want to add these types of settings to the contextmenu. We mainly use the context menu to change the visibility of elements/features but we don't really use it to configure them/change appearance. Also, the context menu is already pretty full and I don't want to overload it.
I'm open to other ideas to make them more discoverable. Maybe a "configure" entry in the overflow menu of the toolbar?
Yeah I like the idea of an action in the "..." menu to configure all things editor related by narrowing down a settings search in the settings editor.
verification steps: Right click on the tab bar (not on a tab) At the bottom of the context menu there is an action "Configure Tabs...", press it Settings editor should open with tabs related settings
Code change:
* Search text in files across all {@link workspace.workspaceFolders workspace folders} in the workspace. * @param query The query parameters for the search - the search string, whether it's case-sensitive, or a regex, or matches whole words. * @param options An optional set of query options. <del> * @param callback A callback, called for each result </del> <ins> * @param callback A callback, called for each {@link TextSearchResultNew result}. This can be a direct match, or context that surrounds a match. </ins> * @param token A token that can be used to signal cancellation to the underlying search engine. * @return A thenable that resolves when the search is complete. */

Related discussion:
text: Testing I can see that the of can be . When should I expect each of these types? I'm not sure I understand what the purpose of is.
is like the surrounding context lines that you see in the search editor. ! For example, here, lines 1791 and 1793 are context lines because they come directly before and after line 1792. I can try to explain this better in the docs, though!
Code change:
* Search text in files across all {@link workspace.workspaceFolders workspace folders} in the workspace. * @param query The query parameters for the search - the search string, whether it's case-sensitive, or a regex, or matches whole words. * @param options An optional set of query options. <del> * @param callback A callback, called for each result </del> <ins> * @param callback A callback, called for each {@link TextSearchResultNew result}. This can be a direct match, or context that surrounds a match. </ins> * @param token A token that can be used to signal cancellation to the underlying search engine. * @return A thenable that resolves when the search is complete. */

Related discussion:
text: Testing From the API: What is the behavior supposed to be in the following cases: The pattern contains . The pattern contains and is false. The pattern is a regex and is false. The pattern contains whitespace and is true.
If regex is not on, it just looks for literally. I believe that this actually acts as if is true (if I'm interpreting code correctly). Any time that you have regex enabled and explicitly match a newline, it will be multi-line. I should probably document this. Any characters in the regex will also match the other case. ie: should also match all characters, not just lowercase letters. It will look for the whitespace, and will look for line boundaries on either side of the search string.
I can also add extra examples for corner cases so that this is more clear.
Code change:
if (this._preLaunchInputQueue.length > 0) { this._process.send({ event: 'input', <del> data: this._sanitizeInput(this._preLaunchInputQueue) </del> <ins> data: this._preLaunchInputQueue </ins> }); this._preLaunchInputQueue = null; }

Related discussion:
text: VSCode Version: Version 1.12.2 (1.12.2) OS Version: OS X E Capitan 10.11.6 Steps to Reproduce: integrated terminal <kbdctrl+`</kbdterminal: key combination <kbdctrl + j</kbdExpected Cursor moves back a word, this the behavior that iTerm and exhibit Actual Newline is sent, essentially the same as using <kbdreturn</kbd
doesn't seem to be in the path in for me?
It's in zsh which is in mac by default? So just type in
Works for me, if you remove the backtick from your command: Not
Oh that was a typo, I am using Hmm that works in the integrated terminal for you? Using zsh without a .zshrc: Expected (in iTerm): ! <kbdctrl + j</kbdcauses the cursor to jump back to the beginning of each word. Actual (in integrated terminal): ! Should have probably left this gif linger a bit longer but at the end it says: As if you had just pressed <kbdreturn</kbd.
FYI, I just tried rebinding <kbdctrl + j</kbdwith bash's native binding commands: Again this works in iTerm and but not in the integrated terminal. Expected Terminal screen should be cleared Actual Newline is sent, essentially the same as using return
Hm I doesn't seem to be working anymore, maybe I didn't test it right or something. I looked into it a little bit, it seems to work fine in the demo which is the underlying library used. so that's why it's happening. The question is why does it work in the demo but not VS Code. It definitely gets registered within zsh inside VS Code: <img width="430" alt="screen shot 2017-05-17 at 9 50 05 pm" src=""Stepping through the code nothing stuck out as misbehaving through when run inside VS Code; they appear to both be sending 'n'. Nothing in the seems to be wrong either.
Aw I was really of hoping it was something wrong with my local configuration. Also I got the same behavior when trying it on windows + cygwin with a fresh install of vscode, <kbdctrl + j</kbdnot being distinguished from newline.
Hey just wondering if there was any progress on this?
Code change:
if (this._preLaunchInputQueue.length > 0) { this._process.send({ event: 'input', <del> data: this._sanitizeInput(this._preLaunchInputQueue) </del> <ins> data: this._preLaunchInputQueue </ins> }); this._preLaunchInputQueue = null; }

Related discussion:
text: If this is low priority could one of the contributors point me a area/file that might be causing the issue? Thanks!
I can't look into it any further right now, I'm pretty stumped on where to go from here though. It's a pretty technical problem so it might not be the easiest thing to jump in to. If you want to you can start by cloning and trying to reproduce it using the demo. If you can reproduce it you can check what's sent to the backend by loading up devtools and debugging If works fine, it would be a matter of doing a similar exercise but figuring out why VS Code behaves different by debugging similar code.
(Copied from ) This was happening because ctrl+j translates to (see ) and since we normalized to all input to the pty, this was getting lost and converted to a new line. The fix here is to never "sanitize" data that has already been processed by (ie. key strokes and paste) as knows how to handle them. We only need to process text that we send directly to the terminal such as a script the user is running or text being pasted into vim, etc.
Hmm just updated to 1.14.1 and this still isn't working for me... !
This will only be in 1.15.
Oh okay thanks.
Code change:
private getResourcePath(webviewEditor: vscode.WebviewPanel, resource: vscode.Uri, version: string) { switch (resource.scheme) { case 'data': <del> return encodeURI(resource.toString(true)); </del> <ins> return resource.toString(true); </ins> case 'git': // Show blank image <del> return encodeURI('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAAEElEQVR42gEFAPr/AP///wAI/AL+Sr4t6gAAAABJRU5ErkJggg=='); </del> <ins> return 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAAEElEQVR42gEFAPr/AP///wAI/AL+Sr4t6gAAAABJRU5ErkJggg=='; </ins> default: // Avoid adding cache busting if there is already a query string if (resource.query) { <del> return encodeURI(webviewEditor.webview.asWebviewUri(resource).toString(true)); </del> <ins> return encodeURI(webviewEditor.webview.asWebviewUri(resource).toString()); </ins> } <del> return encodeURI(webviewEditor.webview.asWebviewUri(resource).toString(true) + `?version=${version}`); </del> <ins> return encodeURI(webviewEditor.webview.asWebviewUri(resource).toString() + `?version=${version}`); </ins> } }

Related discussion:
text: Issue Type: <bBug</bI have noticed that every time I try to open an image on vs code, I get the error stated on the title no matter what image file type VS Code version: Code 1.39.2 (, 2019-10-15T15:33:00.827Z) OS version: Darwin x64 18.7.0 <details<summarySystem Info</summary </details<details<summaryExtensions (21)</summaryExtensionVersion ------ html-snippets0.2.1 vscode-browser-preview0.5.9 rails0.13.1 vscode-gemfile0.0.2 solargraph0.21.1 vscode-eslint1.9.1 code-runner0.9.14 vscode-rufo0.0.1 vscode-gutter-preview0.23.0 atom-keybindings3.0.6 vsliveshare1.0.1056 debugger-for-chrome4.12.0 erb0.1.1 LiveServer5.6.1 ActiveFileInStatusBar1.0.3 slim0.1.2 html-preview-vscode0.2.5 highlight-matching-tag0.9.5 simple-ruby-erb0.2.1 quokka-vscode1.0.257 erb-vscode-snippets0.0.4 </details<!-- generated by issue reporter --
Please share a screenshot of the error. Also, does this reproduce in the with all ?
I'm having the same issue on a feshly installed copy.
Found out the issue to be with the image file name. If the file name has % symbol in it, vscode does not show the image. <img width="708" alt="Screen Shot 2019-10-30 at 12 17 40 PM" src="https://user-"If, i remove the % symbol in my file name, vscode displays the image properly. Tested this both in current stable mac release and the insider build. Do let us know if you observe the same pattern.
Even i am facing the same problem and my image file name does not contain % character , resolve my issue.
My file doesn't contain the % character either and it's not working.
Code change:
import * as nls from 'vs/nls'; import { IContextKey, IContextKeyService, RawContextKey } from 'vs/platform/contextkey/common/contextkey'; import { KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry'; <del> import { editorSelectionBackground, iconForeground, registerColor, transparent } from 'vs/platform/theme/common/colorRegistry'; </del> import { FoldingDecorationProvider } from './foldingDecorations'; import { FoldingRegion, FoldingRegions, FoldRange, FoldSource, ILineRange } from './foldingRanges'; import { SyntaxRangeProvider } from './syntaxRangeProvider';

Related discussion:
text: <!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --When folded, folding ranges are displayed in the editor as a single line with darkened background. Hovever (as of ), on the minimap, the background of this line is not darkened. This makes it harder to navigate using the minimap. !
Either this isn't working or steps are non trivial
Ok, see this working unless I have render characters enabled
Code change:
@ILabelService private readonly labelService: ILabelService, @IProductService private readonly productService: IProductService, @IBrowserWorkbenchEnvironmentService private readonly environmentService: IBrowserWorkbenchEnvironmentService, <del> @IWorkbenchLayoutService private readonly layoutService: IWorkbenchLayoutService </del> <ins> @IWorkbenchLayoutService private readonly layoutService: IWorkbenchLayoutService, @IHostService private readonly hostService: IHostService </ins> ) { super();

Related discussion:
text: I like the improved "All done. You can close this tab now."-dialog but I think it is missing a "Close Tab" option. Today, when everything works you need to hit "Cancel" but I don't have the close tab option - which is what the title suggests
what are the steps to trigger this?
Use Continue On Reopen on the Desktop from
Code change:
const scrollTop = scrollTopObservable.read(reader); const scrollHeight = scrollHeightObservable.read(reader); <del> const computedAvailableSize = Math.max(0, layoutInfo.height); const computedRepresentableSize = Math.max(0, computedAvailableSize - 2 * 0); const computedRatio = scrollHeight > 0 ? (computedRepresentableSize / scrollHeight) : 0; const computedSliderSize = Math.max(0, Math.floor(layoutInfo.height * computedRatio)); const computedSliderPosition = Math.floor(scrollTop * computedRatio); viewportDomElement.setTop(computedSliderPosition); viewportDomElement.setHeight(computedSliderSize); </del> <ins> const scrollBarOptions = this._editors.modified.getOption(EditorOption.scrollbar); const state = new ScrollbarState( scrollBarOptions.verticalHasArrows ? scrollBarOptions.arrowSize : 0, scrollBarOptions.verticalScrollbarSize, 0, layoutInfo.height, scrollHeight, scrollTop ); viewportDomElement.setTop(state.getSliderPosition()); viewportDomElement.setHeight(state.getSliderSize()); </ins> } else { viewportDomElement.setTop(0); viewportDomElement.setHeight(0);

Related discussion:
text: This has been fixed for notebook diffs but is still an issue for text diffs: <img width="115" alt="image" src="https://user-"
Code change:
// Get All types of recommendations, trimmed to show a max of 8 at any given time private async getAllRecommendationsModel(options: IQueryOptions, token: CancellationToken): Promise<IPagedModel<IExtension>> { <del> const local = (await this.extensionsWorkbenchService.queryLocal(this.options.server)).map(e => e.identifier.id.toLowerCase()); </del> <ins> const localExtensions = await this.extensionsWorkbenchService.queryLocal(this.options.server); const localExtensionIds = localExtensions.map(e => e.identifier.id.toLowerCase()); </ins> const allRecommendations = distinct( flatten(await Promise.all([

Related discussion:
text: <!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --in my project, there are several extensions in our recommended , but vscode sneaks in recommendations that are not recommended by workspace, but by vscode itself: ! in this screenshot, the WSL extension is recommended by vscode, and the YAML extension is recommended by the workspace. you have to hover over the star icon to figure out which recommendations are actually relevant for this workspace. this makes it confusing for new developers who just want to install the extensions required for the workspace, and not random additional ones that vscode suggests. as a workaround, i can add these vscode recommendations to the array, but that's annoying because i would have to update that list whenever new recommendations show up.
VS Code shows workspace recommendations on the top followed by other recommendations. If you are not seeing in this order, can you please share the steps to reproduce?
i don't know if i could, since it seems to be some sort of recommendation algorithm that shows different results based on all sorts of unknown factors. (i feel like it'd be comparable to coming up with steps to reproduce an ad i saw in a social media feed.) but i'll give it a go
it seems that the docker and wsl extensions (ones made by microsoft) always appear above workspace recommendations. steps to reproduce: to the workspace recommended extensions a to trigger the non-workspace recommendation to the extensions tab and look at the recommended extensions list ! ! even if these were showing up in the correct order (workspace recommendations first), it's still extremely confusing and misleading to the user to use the exact same icon for two completely different types of recommendations. i get that microsoft wants to get as many people using their extensions as possible, but this seems comparable to an advertisement that is not clearly labelled as one.
I found out that there is a bug in showing them in the right order. Will fix that. I am not sure how much it makes sense to show different icons for different kinds of recommendations. It might be super noisy or confusing. I believe at present we have a right balance to show an icon for recommendation and explanation on hover.