jiebi/CodeConvo huggingface dataset:
Code change:
reviveBuffer: string | undefined, private _icon?: TerminalIcon, private _color?: string, <ins> name?: string, </ins> fixedDimensions?: IFixedTerminalDimensions ) { super(); <ins> if (name) { this.setTitle(name, TitleEventSource.Api); } </ins> this._logService.trace('persistentTerminalProcess#ctor', _persistentProcessId, arguments); this._wasRevived = reviveBuffer !== undefined; this._serializer = new XtermSerializer(

Related discussion:
text: Hi, I would like to request that upon restart vscode, the terminals can be restored. By restored, i mean the layout, the custom names, icon and color for the terminals are retained. The content DOES NOT need to be retain. Otherwise efforts to customize all the opened terminals would gone to waste when vscode is restarted. Alternatively, vscode can provide new workspace configurations, where developer can manually enter a list of terminals' custom names, Vscode, upon starting, will automatically create new terminals based on the configured list. Even better, each time, deveoper manually open a new terminal , vscode will auto update the workspace configuration file to add a new terminal to the configured list. This applies the same to renaming of terminal Hope that this can be achieved without relying on plugin. *Do note that this might not be a duplicate of other look similar kind of feature request. Cos for this request, content does not need to be preserved. And the terminal's custom names should be preserved (sadly, persistentSessionReviveProcess, does not maintain the terminal custom names)
except it doesn't save custom terminal names.
Not only it doesn't save custom terminal names, it also doesn't save icon and color.
This is meant to be supported with including content as well, there are currently some issues with it causing it to be flaky though. They might have to wait until v1.63 where we will focus on testing. Related:
fixed !
It's persisting the icon, color, name, and layout on window reload. Doesn't seem to persist icon, color, or name on restart.
Yes. My request is focusing on restart, not window reload
Code change:
<ins> <?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> <plist version="1.0"> <dict> <key>fileTypes</key> <array> <string>ini</string> <string>INI</string> <string>inf</string> <string>INF</string> <string>reg</string> <string>REG</string> <string>lng</string> <string>cfg</string> <string>CFG</string> <string>url</string> <string>URL</string> <string>.editorconfig</string> </array> <key>name</key> <string>INI</string> <key>patterns</key> <array> <dict> <key>captures</key> <dict> <key>1</key> <dict> <key>name</key> <string>punctuation.definition.comment.ini</string> </dict> </dict> <key>match</key> <string>^s*(;|#).*$n?</string> <key>name</key> <string>comment.line.semicolon.ini</string> </dict> <dict> <key>captures</key> <dict> <key>1</key> <dict> <key>name</key> <string>punctuation.definition.section.ini</string> </dict> <key>2</key> <dict> <key>name</key> <string>entity.section.ini</string> </dict> <key>3</key> <dict> <key>name</key> <string>punctuation.definition.section.ini</string> </dict> </dict> <key>match</key> <string>^s*([)(.*?)(])</string> <key>name</key> <string>meta.tag.section.ini</string> </dict> <dict> <key>captures</key> <dict> <key>1</key> <dict> <key>name</key> <string>meta.property.ini</string> </dict> <key>2</key> <dict> <key>name</key> <string>punctuation.definition.quote.ini</string> </dict> <key>3</key> <dict> <key>name</key> <string>keyword.name.ini</string> </dict> <key>4</key> <dict> <key>name</key> <string>punctuation.definition.quote.ini</string> </dict> <key>5</key> <dict> <key>name</key> <string>punctuation.definition.equals.ini</string> </dict> <key>6</key> <dict> <key>name</key> <string>meta.value.ini</string> </dict> <key>7</key> <dict> <key>name</key> <string>punctuation.definition.quote.ini</string> </dict> <key>8</key> <dict> <key>name</key> <string>string.name.value.ini</string> </dict> <key>9</key> <dict> <key>name</key> <string>punctuation.definition.quote.ini</string> </dict> <key>10</key> <dict> <key>name</key> <string>comment.declarationline.semicolon.ini</string> </dict> </dict> <key>match</key> <string>^(s*(["']?)(.+?)(2)s*(=))?s*((["']?)(.*?)(7))s*(;.*)?$n?</string> <key>name</key> <string>meta.declaration.ini</string> </dict> </array> <key>scopeName</key> <string>source.ini</string> <key>uuid</key> <string>957acd74-6d7c-4732-a25b-5f66a1e637cd</string> </dict> </plist> </ins>

Related discussion:
text: VSCode Version: 1.6.0 OS Version: OSX 10.11.6 *.ini files comments-line starts with the SEMI-COLON. but VSCode has insert (or remove) the HASHMARK.
Pull request pushed, thanks a lot !
Code change:
<ins> <?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> <plist version="1.0"> <dict> <key>fileTypes</key> <array> <string>ini</string> <string>INI</string> <string>inf</string> <string>INF</string> <string>reg</string> <string>REG</string> <string>lng</string> <string>cfg</string> <string>CFG</string> <string>url</string> <string>URL</string> <string>.editorconfig</string> </array> <key>name</key> <string>INI</string> <key>patterns</key> <array> <dict> <key>captures</key> <dict> <key>1</key> <dict> <key>name</key> <string>punctuation.definition.comment.ini</string> </dict> </dict> <key>match</key> <string>^s*(;|#).*$n?</string> <key>name</key> <string>comment.line.semicolon.ini</string> </dict> <dict> <key>captures</key> <dict> <key>1</key> <dict> <key>name</key> <string>punctuation.definition.section.ini</string> </dict> <key>2</key> <dict> <key>name</key> <string>entity.section.ini</string> </dict> <key>3</key> <dict> <key>name</key> <string>punctuation.definition.section.ini</string> </dict> </dict> <key>match</key> <string>^s*([)(.*?)(])</string> <key>name</key> <string>meta.tag.section.ini</string> </dict> <dict> <key>captures</key> <dict> <key>1</key> <dict> <key>name</key> <string>meta.property.ini</string> </dict> <key>2</key> <dict> <key>name</key> <string>punctuation.definition.quote.ini</string> </dict> <key>3</key> <dict> <key>name</key> <string>keyword.name.ini</string> </dict> <key>4</key> <dict> <key>name</key> <string>punctuation.definition.quote.ini</string> </dict> <key>5</key> <dict> <key>name</key> <string>punctuation.definition.equals.ini</string> </dict> <key>6</key> <dict> <key>name</key> <string>meta.value.ini</string> </dict> <key>7</key> <dict> <key>name</key> <string>punctuation.definition.quote.ini</string> </dict> <key>8</key> <dict> <key>name</key> <string>string.name.value.ini</string> </dict> <key>9</key> <dict> <key>name</key> <string>punctuation.definition.quote.ini</string> </dict> <key>10</key> <dict> <key>name</key> <string>comment.declarationline.semicolon.ini</string> </dict> </dict> <key>match</key> <string>^(s*(["']?)(.+?)(2)s*(=))?s*((["']?)(.*?)(7))s*(;.*)?$n?</string> <key>name</key> <string>meta.declaration.ini</string> </dict> </array> <key>scopeName</key> <string>source.ini</string> <key>uuid</key> <string>957acd74-6d7c-4732-a25b-5f66a1e637cd</string> </dict> </plist> </ins>

Related discussion:
text: VSCode Version: v1.2.1 OS Version: Windows 10 Steps to Reproduce: file type to INI "A=b;xxxx" in file content Expected: "b;xxxx" colored as white Actual: "b" in white but ";xxxx" in green ";xxxx" should only be regard as comments when there is no other contents in the line before ";"
This issue was moved to demyte/language-cshtml
Code change:
@IPartService partService: IPartService, @IKeybindingService keybindingService: IKeybindingService, @IInstantiationService instantiationService: IInstantiationService, <del> @IThemeService themeService: IThemeService </del> <ins> @IThemeService themeService: IThemeService, @IContextKeyService contextKeyService: IContextKeyService, </ins> ) { super( notificationService,

Related discussion:
text: I wanted to customize my keybindings depending on the OutputPanel state, but it looks there's no clause to set in the stanza for it.
There is a context , please try that
Ok that works when if focused (but needs to be documented), what about when it's visible?
We accept PRs that update our docs. Checkout the vscode-docs repo. No this is not currently supported, we accept PRs that add this. Code pointers Similar to the viewlet service here The panelPart would add a context key
works but how does a user learn the panel ID?
good point. However we already had that issue with the viewlets, since we already have a "activeViewlet" conext key. We should document this properly
Code change:
registerEditorContribution(MarkerController); registerEditorAction(NextMarkerAction); registerEditorAction(PrevMarkerAction); <ins> registerEditorAction(NextMarkerInFilesAction); registerEditorAction(PrevMarkerInFilesAction); </ins> const CONTEXT_MARKERS_NAVIGATION_VISIBLE = new RawContextKey<boolean>('markersNavigationVisible', false);

Related discussion:
text: Issue Type: <bBug</bWhen pressing F8 in editor without error markers in current file, tab will switch to another opened file with error. Is it possible to prevent tab switching when F8 is pressed and there is no errors in current file? VS Code version: Code 1.22.0 (, 2018-04-05T17:25:43.982Z) OS version: Darwin x64 16.7.0 <!-- generated by issue reporter --
It's caused by a change in behavior in 1.22 (). I think it's a change to the worse: it's very easy to get used to hitting F8 to get a quick feedback for whether the current file has any errors, and this change breaks this workflow in a very noisy way. It also punishes those who work on 'dirty' projects with lots of errors and prefer to concentrate on one file at a time. I think it would be great to have a config switch for "F8 checks all files/current file", or at least a pair of keyboard bindings for the old behavior. I'm actually surprised that it wasn't implemented with this change.
Understood. The goal was to keep the number of setting low, but I understand the different use-cases and muscle memory. Until then, a workaround, albeit weak, is to hit Shift+F8 which takes to back to the file.
Yeah, I agree that "convention over configuration" has its benefits, and it seems that the suggestion that caused this change was quite popular, but IMO this warrants at least a pair of shortcut bindings. Speaking about conventions, I've just checked that for example similar shortcuts in PyCharm (and I assume all other JetBrains IDEs) only jump through errors in the current file. One upside of the old behavior was that when the current file had no errors, there were no visual changes after pressing F8, and the cursor stayed where it was. Now in this case Shift+F8 after F8 won't even bring you back to that file, it would jump to another file with errors. "Go Back" or "Open Next Recently Used Editor" works though. It was also very useful that F8 would wrap around and bring you to the first error in the current file if you are working near the end of it and did some changes that e.g. made some imports or vars unused.
Code change:
registerEditorContribution(MarkerController); registerEditorAction(NextMarkerAction); registerEditorAction(PrevMarkerAction); <ins> registerEditorAction(NextMarkerInFilesAction); registerEditorAction(PrevMarkerInFilesAction); </ins> const CONTEXT_MARKERS_NAVIGATION_VISIBLE = new RawContextKey<boolean>('markersNavigationVisible', false);

Related discussion:
text: I think I was relying on this behavior 80% of times when I pressed F8. And now it's become quite difficult to predict whether F8 or Shift-F8 would keep you in the current file or move to another one.
We have the two old commands back (in addition to the new commands). That means there is now "Go to Next Problem" and "Go to Next Problem In Files" as well as the other direction. We have not changed the keybindings, so F8/Shift-F8 walks across the project and you would need to reassign the them to get old, old behaviour back.
Wow, I didn't expect this minor issue to get resolved so quickly! Big thanks to the team, it's really a marvel to witness the development of this amazing project.
Thanks to
I verified the new command works as expected, however is the name "in Files" really clear what it does. Why not "across Files"?
We chose "in Files" to match "Find in Files". "across Files" makes sense too though and might be clearer for users who haven't used "Find in Files" before.
Code change:
const keybindingService = accessor.get(IKeybindingService); const contextKeyService = accessor.get(IContextKeyService); <del> const next = keybindingService.lookupKeybinding(AccessibleDiffViewerNext.id)?.getAriaLabel(); const previous = keybindingService.lookupKeybinding(AccessibleDiffViewerPrev.id)?.getAriaLabel(); </del> if (!(editorService.activeTextEditorControl instanceof DiffEditorWidget)) { return; }

Related discussion:
text: mentioned that the diff editor experience is a little confusing because we don't explicitly state that the current editor is the modified one vs the original editor. AFAICT, there's also no way to jump between the original and modified ones. Is this correct? & I'd appreciate your thoughts here. Edit: action items: [ ] add info in help dialog about switch sides command [ ] get accessibility signals to work in original editor
There is the Diff Editor: Switch Sides command that moves focus to the other side. Maybe the wording could be improved. So not sure what needs to be done here? Feels like similar to the other issue you created about missing clarity in announcements on original vs modified.
Yes, I was unaware of that command. We should include it in the diff editor help dialog and include a default keybinding for when in screen reader mode as that's definitely something users would want to do IMO.
pointed out this should maybe be a tab stop if possible
I have the following keybinding, but there was no noticeable change (at least to from a screen reader user's standpoint) after switching into the other side. :
could you tell there was a focus change at all? Is there also no difference if you run the command vs use the keybinding?
Audio cues do not work when I'm navigating in the original editor. !
Code change:
let debugKeybindingLabel = ''; viewsRegistry.registerViewWelcomeContent(WelcomeView.ID, { <del> content: localize( { key: 'runAndDebugAction', comment: [ '{0} will be replaced with a keybinding', 'Please do not translate the word "command", it is part of our internal syntax which must not change', '{Locked="](command:{1})"}' ] }, "[Run and Debug{0}](command:{1})", debugKeybindingLabel, DEBUG_START_COMMAND_ID), </del> <ins> content: `[${localize('runAndDebugAction', "Run and Debug")}${debugKeybindingLabel}](command:${DEBUG_START_COMMAND_ID})`, </ins> when: CONTEXT_DEBUGGERS_AVAILABLE, group: ViewContentGroups.Debug, // Allow inserting more buttons directly after this one (by setting order to 1).

Related discussion:
text: There's an unnecessary whitespace in "i18n/vscode-language-pack-". The whitespace after "command:" makes the link dead. !
you can add a comment to this string like so: to ensure that the command never has a problem like this. Notice that the example string has, in the Locked area, a at the start of it. This will make sure there is no whitespace between them.
Code change:
"vscode-proxy-agent": "^0.12.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "7.0.1", <del> "xterm": "5.0.0-beta.32", "xterm-addon-canvas": "0.2.0-beta.15", "xterm-addon-search": "0.10.0-beta.3", "xterm-addon-serialize": "0.8.0-beta.3", "xterm-addon-unicode11": "0.4.0-beta.3", "xterm-addon-webgl": "0.13.0-beta.32", </del> <ins> "xterm": "5.0.0-beta.35", "xterm-addon-canvas": "0.2.0-beta.17", "xterm-addon-search": "0.10.0-beta.5", "xterm-addon-serialize": "0.8.0-beta.5", "xterm-addon-unicode11": "0.4.0-beta.5", "xterm-addon-webgl": "0.13.0-beta.35", </ins> "xterm-headless": "5.0.0-beta.5", "yauzl": "^2.9.2", "yazl": "^2.4.3"

Related discussion:
text: Repro: folder test task, wait to finish another terminal test task again <img width="1344" alt="Screen Shot 2022-08-07 at 11 40 14 am" src="https://user-"
In repo, ctrl+shift+b is focusing the terminal: !
Reproduces on webgl only
Guessing it's related to canvas recreation:
Yep: !
Code change:
return undefined; } if ((resolverData === undefined) && (grouped === undefined)) { <del> return (await quickResolve(this, identifier)) ?? fullResolve(this, uri, identifier); </del> <ins> return (await quickResolve(this, uri, identifier)) ?? fullResolve(this, uri, identifier); </ins> } else { return fullResolve(this, uri, identifier); }

Related discussion:
text: Issue Type: <bBug</bRunning tasks with dependencies in a multi-root workspace executes the wrong dependency tasks, if there are multiple tasks defined under the same label but in different root folders. VSCode will just pick the first occurance in the order of the root folders defined in the workspace settings. To reproduce the issue: a simple multi-root workspace, e.g. each root folder, add a with two tasks. One task depends on the other. Example tasks of : and have the same tasks configured except that they echo their respective folder name instead. task of either or . VS Code version: Code 1.65.1 (, 2022-03-08T02:06:27.846Z) OS version: WindowsNT x64 10.0. Restricted Mode: No <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Experiencing same issue on: VS Code version: 1.65.1 OS version: macOS 12.2.1 BuildVersion:21D62
To verify: or create a multi root workspace with 2 roots, FolderOne and FolderTwo (or names of your choice). each of your roots add a .vscode folder. each of your .vscode folders add a file with the following contents: "PrimaryTask" in FolderOne (command "Tasks: Run Task" and choose the task with the label "PrimaryTask" that says "FolderOne" next to it). Verify that both PrimaryTask and DependsTask echo FolderOne's path. "PrimaryTask" in Folder Two (command "Tasks: Run Task" and choose the task with the label "PrimaryTask" that says "FolderTwo" next to it). Verify that both PrimaryTask and DependsTask echo FolderTwo's path.
Code change:
private readonly _onDidChangeVisibility = this._register(new Emitter<boolean>()); readonly onDidChangeVisibility = this._onDidChangeVisibility.event; <ins> private readonly _onWillPaste = this._register(new Emitter<string>()); readonly onWillPaste = this._onWillPaste.event; private readonly _onDidPaste = this._register(new Emitter<string>()); readonly onDidPaste = this._onDidPaste.event; </ins> constructor( private readonly _terminalShellTypeContextKey: IContextKey<string>, private readonly _terminalInRunCommandPicker: IContextKey<boolean>,

Related discussion:
text: Steps to Reproduce: text into PowerShell (with Terminal suggest enabled) see batched pasting behavior
maybe related to
Haha, I think this is it triggering completions while the pasted text is being send then kicking in. Pastes should never trigger completions so let's track that here.
When verifying make sure you're on macOS.
Code change:
@IChatService chatService: IChatService, @IHoverService hoverService: IHoverService, ) { <del> super(location, { ...options, chatWidgetViewOptions: { editorOverflowWidgetsDomNode: _parentEditor.getOverflowWidgetsDomNode() } }, instantiationService, contextKeyService, keybindingService, accessibilityService, configurationService, accessibleViewService, textModelResolverService, chatService, hoverService); </del> <ins> super(location, { ...options, chatWidgetViewOptions: { ...options.chatWidgetViewOptions, editorOverflowWidgetsDomNode: _parentEditor.getOverflowWidgetsDomNode() } }, instantiationService, contextKeyService, keybindingService, accessibilityService, configurationService, accessibleViewService, textModelResolverService, chatService, hoverService); </ins> } // --- layout

Related discussion:
text: todays insiders do any inline chat query the edits are done live and shows inside the chat diff editor <img width="946" alt="Screenshot 2024-06-14 at 10 59 47" src=""
Code change:
export async function pickRemoteSource(model: Model, options: PickRemoteSourceOptions & { branch: true }): Promise<PickRemoteSourceResult | undefined>; export async function pickRemoteSource(model: Model, options: PickRemoteSourceOptions = {}): Promise<string | PickRemoteSourceResult | undefined> { const quickpick = window.createQuickPick<(QuickPickItem & { provider?: RemoteSourceProvider; url?: string })>(); <del> quickpick.ignoreFocusOut = true; </del> quickpick.title = options.title; if (options.providerName) {

Related discussion:
text: Testing When I was on the section of the walkthrough I clicked on "open remote repository" and it had the dropdown. I noticed that I couldn't just click outside the dropdown (back on the welcome page) to make the dropdown disappear and instead had to use the "esc" button. From my experience with other dropdowns if you click away from the dropdown it disappears and think that behavior would make sense here.
does the quick pick come from ? If yes, who should I direct this issue to?
Yes that's where the quickpick comes from. owns the desktop git extension.
could you please help with this? Thanks.
Clicking outside of the dropdown still doesn't escape. !
It turns out that the "Remote Repositories" extension does not leverage the picker from the git-base extension so the fix that I made is not relevant. To verify this, please download the latest pre-release version of the "Remote Repositories" extension.