jiebi/CodeConvo huggingface dataset:
Code change:
"git": { "name": "electron", "repositoryUrl": "https://github.com/electron/electron", <del> "commitHash": "dc3ce65dd5fd872db86e5308ae005a898142435a" </del> <ins> "commitHash": "67b2739f44ce98aad493170fecc696f76dc12de1" </ins> } }, "isOnlyProductionDependency": true, "license": "MIT", <del> "version": "25.8.1" </del> <ins> "version": "25.8.2" </ins> }, { "component": {

Related discussion:
text: Still need to check older versions to see if that check was backported and see if there is a way to test this assessment.
is available in 18.8.0 and 16.18.0, our exploration builds based on Node v18 has this change, you can use the builds from to verify the assessment.
The test does not reproduce the issue in the exploration build. Still trying to understand what is happening (please ignore the above code pointers) by looking at the code at the tag. I see the failing call to being triggered in : What I don't quite understand is that the callstack to with comes from : But at that line is supposed to call not as it appear in the callstack: Could you point me at the source that went into Electron? I believe that is not the exact same as that at
Electron pulls source from when building, what you are looking at is the correct one. I think the async stack is missing a trampoline calll, but you are seeing a write after shutdown stack same as
Thanks This looks like an upstream issue to me, should not be called when is already . I don't see the change in 18.15.0 (the version the exploration build is using) yet that might have fixed it.
We have reverted to the previous way of loading certificates as we are getting close to a release ().
We're seeing this again in our macos and Windows CI jobs for VSCode "Insiders" (not current VSCode stable version 1.82.2). Was node or electron updated in the last 2 days on VSCode Insiders?
There is fix in upstream for the above scenario, I will backport it to relevant release lines.
Could you confirm that todays Insiders build fixes the problem? Thanks!
Confirmed, thanks!
Code change:
import { AbstractInitializer, AbstractSynchroniser, getSyncResourceLogLabel, IAcceptResult, IMergeResult, IResourcePreview } from 'vs/platform/userDataSync/common/abstractSynchronizer'; import { IMergeResult as IExtensionMergeResult, merge } from 'vs/platform/userDataSync/common/extensionsMerge'; import { IIgnoredExtensionsManagementService } from 'vs/platform/userDataSync/common/ignoredExtensions'; <del> import { Change, IRemoteUserData, ISyncData, ISyncExtension, ISyncExtensionWithVersion, IUserDataSyncBackupStoreService, IUserDataSynchroniser, IUserDataSyncLogService, IUserDataSyncEnablementService, IUserDataSyncStoreService, SyncResource, USER_DATA_SYNC_SCHEME } from 'vs/platform/userDataSync/common/userDataSync'; </del> <ins> import { Change, IRemoteUserData, ISyncData, ISyncExtension, ISyncExtensionWithVersion, IUserDataSyncBackupStoreService, IUserDataSynchroniser, IUserDataSyncLogService, IUserDataSyncEnablementService, IUserDataSyncStoreService, SyncResource, USER_DATA_SYNC_SCHEME, EXTENSIONS_SYNC_CONTEXT_KEY } from 'vs/platform/userDataSync/common/userDataSync'; </ins> import { IUserDataProfileStorageService } from 'vs/platform/userDataProfile/common/userDataProfileStorageService'; type IExtensionResourceMergeResult = IAcceptResult & IExtensionMergeResult;

Related discussion:
text: I don't think the state of walkthrough progress is synced between machines, so I see this on each new machine I setup: !
Again, we do try to sync the state but there may be a race where it's not available in time. I'll investigate more..
Fixed it by adding the context to the installation event when extensions are synced by settings sync. Walk through component shall simply ignore walk through for those extensions which are installed by settings sync (irrespective of the walk through state is synced or not).
Code change:
import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; import { Event } from 'vs/base/common/event'; import type { ISearchOptions } from 'xterm-addon-search'; <ins> import { TerminalCommandId } from 'vs/workbench/contrib/terminal/common/terminal'; </ins> export class TerminalFindWidget extends SimpleFindWidget { private _findInputFocused: IContextKey<boolean>;

Related discussion:
text: Terminal: <img width="328" alt="image" src=""Editor: <img width="436" alt="image" src=""
Code change:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <ins> import * as arrays from 'vs/base/common/arrays'; </ins> import { IScrollPosition, Scrollable } from 'vs/base/common/scrollable'; import * as strings from 'vs/base/common/strings'; <del> import { CursorConfiguration, CursorState, EditOperationType, IColumnSelectData, ICursorSimpleModel, PartialCursorState } from 'vs/editor/common/cursorCommon'; import { CursorChangeReason } from 'vs/editor/common/cursorEvents'; import { IViewLineTokens } from 'vs/editor/common/tokens/lineTokens'; </del> import { IPosition, Position } from 'vs/editor/common/core/position'; import { Range } from 'vs/editor/common/core/range'; <ins> import { CursorConfiguration, CursorState, EditOperationType, IColumnSelectData, ICursorSimpleModel, PartialCursorState } from 'vs/editor/common/cursorCommon'; import { CursorChangeReason } from 'vs/editor/common/cursorEvents'; </ins> import { INewScrollPosition, ScrollType } from 'vs/editor/common/editorCommon'; <del> import { EndOfLinePreference, IModelDecorationOptions, ITextModel, PositionAffinity } from 'vs/editor/common/model'; import { BracketGuideOptions, IActiveIndentGuideInfo, IndentGuide } from 'vs/editor/common/textModelGuides'; </del> import { EditorTheme } from 'vs/editor/common/editorTheme'; <del> import { VerticalRevealType } from 'vs/editor/common/viewEvents'; </del> <ins> import { EndOfLinePreference, IModelDecorationOptions, ITextModel, PositionAffinity } from 'vs/editor/common/model'; </ins> import { ILineBreaksComputer, InjectedText } from 'vs/editor/common/modelLineProjectionData'; <ins> import { BracketGuideOptions, IActiveIndentGuideInfo, IndentGuide } from 'vs/editor/common/textModelGuides'; import { IViewLineTokens } from 'vs/editor/common/tokens/lineTokens'; </ins> import { ViewEventHandler } from 'vs/editor/common/viewEventHandler'; <ins> import { VerticalRevealType } from 'vs/editor/common/viewEvents'; </ins> export interface IViewModel extends ICursorSimpleModel {

Related discussion:
text: a TS file, use the keyboard and type out a syntax error. The scrollbar error marker doesn't show up. the text cursor to another location using the mouse. The scrollbar error marker shows up then. says:
Very likely a regression from
Code change:
<del> <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16"><defs><style>.icon-canvas-transparent,.icon-vs-out{fill:#252526;}.icon-canvas-transparent{opacity:0;}.icon-vs-action-green{fill:#89d185;}</style></defs><title>restart</title><g id="canvas"><path class="icon-canvas-transparent" d="M16,0V16H0V0Z"/></g><g id="outline" style="display: none;"><path class="icon-vs-out" d="M8.5,1A7.5,7.5,0,0,0,4,2.527V1H0V9H3.068l-2.057.583.272.962A7.5,7.5,0,1,0,8.5,1Zm0,11A3.515,3.515,0,0,1,5.131,9.455L5,9H8V5.036A3.6,3.6,0,0,1,8.5,5a3.5,3.5,0,0,1,0,7Z"/></g><g id="iconBg"><path class="icon-vs-action-green" d="M15,8.5A6.5,6.5,0,0,1,2.245,10.272l1.924-.544A4.509,4.509,0,1,0,4.764,6H7V8H1V2H3V5.07A6.486,6.486,0,0,1,15,8.5Z"/></g></svg> </del>  No newline at end of file <ins> <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16"><style>.st0{fill:#252526;fill-opacity:0}.st1{display:none}.st2{display:inline;fill:#252526}.st3{fill:#89d185}</style><title>restart</title><path class="st0" d="M16 0v16H0V0h16z" id="canvas"/><g id="outline" class="st1" style="display: none;"><path class="st2" d="M8.5 1C6.9 1 5.3 1.5 4 2.5V1H0v8h3.1L1 9.6l.3 1c1.1 4 5.3 6.3 9.3 5.2s6.3-5.3 5.2-9.3C14.8 3.2 11.9 1 8.5 1zm0 11c-1.6 0-2.9-1-3.4-2.5L5 9h3V5h.5C10.4 5 12 6.6 12 8.5S10.4 12 8.5 12z"/></g><path class="st3" d="M15 8c0 3.6-2.9 6.5-6.5 6.5-2.9 0-5.5-1.9-6.3-4.7l1.9-.5c.7 2.4 3.2 3.8 5.6 3.1 2.4-.7 3.8-3.2 3.1-5.6S9.7 3 7.3 3.7c-1 .3-1.9.9-2.5 1.8H7v2H1v-6h2v3.1c1.9-3 5.9-4 8.9-2.1C13.8 3.7 15 5.7 15 8z" id="iconBg"/></svg> </ins>  No newline at end of file

Related discussion:
text: !
when we triage issues assigned to ourselves we usually use the milestone, anything that will be fixed in this milestone we put to june. Appart from that adding the bug label is usually good so this issue gets verified in the endgame (since it is june and bug). Assigning issues to other team members we usually leave with no label and milestone so the owner can triage and assign it. Cheers
thanks, I'll make sure and mark them appropriately next time!
Code change:
primary: KeyMod.Alt | KeyCode.UpArrow }); <del> CommandsRegistry.registerCommand('scm.openInIntegratedTerminal', async (accessor, provider: ISCMProvider) => { if (!provider || !provider.rootUri) { </del> <ins> CommandsRegistry.registerCommand('scm.openInIntegratedTerminal', async (accessor, ...providers: ISCMProvider[]) => { if (!providers || providers.length === 0) { </ins> return; } const commandService = accessor.get(ICommandService); <ins> const listService = accessor.get(IListService); let provider = providers.length === 1 ? providers[0] : undefined; if (!provider) { const list = listService.lastFocusedList; const element = list?.getHTMLElement(); if (list instanceof WorkbenchList && element && isActiveElement(element)) { const [index] = list.getFocus(); const focusedElement = list.element(index); // Source Control Repositories if (isSCMRepository(focusedElement)) { provider = focusedElement.provider; } } } if (!provider?.rootUri) { return; } </ins> await commandService.executeCommand('openInIntegratedTerminal', provider.rootUri); });

Related discussion:
text: Type: <bBug</bIn the "Source Control Repositories" view, if you have several repos selected, and then right click on one of them and choose "Open in Integrated Terminal", it will open the terminal in the directory for the first selected repo regardless of which repo you right clicked on. However if you right click on a repo under "Source Control" then it will open the terminal correctly. VS Code version: Code 1.90.2 (, 2024-06-18T22:33:48.698Z) OS version: Linux x64 6.6.15-2rodete2-amd64 Modes: Remote OS version: Linux x64 6.6.15-2rodete2-amd64 <details<summarySystem Info</summary </details<details<summaryExtensions (22)</summaryExtensionVersion ------ jupyter-keymap1.1.2 remote-containers0.375.1 remote-ssh0.112.0 remote-ssh-edit0.86.0 vscode-remote-extensionpack0.25.0 remote-explorer0.4.3 remote-server1.5.2 rewrap1.16.3 githistory0.6.20 gitlens15.1.0 go0.41.4 debugpy2024.6.0 isort2023.10.1 pylint2023.10.1 python2024.10.0 jupyter2024.5.0 jupyter-keymap1.1.2 jupyter-renderers1.0.18 vscode-jupyter-cell-tags0.1.9 vscode-jupyter-slideshow0.1.6 preview-vscode2.3.7 code-spell-checker3.0.1 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.91.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Is that option being contributed by an extension? Please use the command to investigate.
The menu option is there even with no extensions loaded by "Start Extension Bisect"
<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history.
Code change:
primary: KeyMod.Alt | KeyCode.UpArrow }); <del> CommandsRegistry.registerCommand('scm.openInIntegratedTerminal', async (accessor, provider: ISCMProvider) => { if (!provider || !provider.rootUri) { </del> <ins> CommandsRegistry.registerCommand('scm.openInIntegratedTerminal', async (accessor, ...providers: ISCMProvider[]) => { if (!providers || providers.length === 0) { </ins> return; } const commandService = accessor.get(ICommandService); <ins> const listService = accessor.get(IListService); let provider = providers.length === 1 ? providers[0] : undefined; if (!provider) { const list = listService.lastFocusedList; const element = list?.getHTMLElement(); if (list instanceof WorkbenchList && element && isActiveElement(element)) { const [index] = list.getFocus(); const focusedElement = list.element(index); // Source Control Repositories if (isSCMRepository(focusedElement)) { provider = focusedElement.provider; } } } if (!provider?.rootUri) { return; } </ins> await commandService.executeCommand('openInIntegratedTerminal', provider.rootUri); });

Related discussion:
text: If this was closed in a separate repo you can add the label directly, or comment .
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Code change:
resolve(-1); } let tunnelProcess: ChildProcess | undefined; <ins> const stdio: StdioOptions = ['ignore', 'pipe', 'pipe']; </ins> token.onCancellationRequested(() => { if (tunnelProcess) { this._logger.info(`${logLabel} terminating(${tunnelProcess.pid})`);

Related discussion:
text: Version: 1.78.0-insider (user setup) Commit: Date: 2023-04-04T09:32:52.453Z Electron: 22.4.3 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes run from a Windows command prompt The tunnel starts and prints open VS Code, and open the output Note that the output is stuck at Missing are the message and the info that the tunnel is attached The UI thinks the tunnel is still connecting. Sometimes this also works, but when I try it, most of the time it is stuck
Can you please enable trace logging and share the output?
Nothing extra messages shown when the Desktop tunnel attaches:
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Still a problem in Version: 1.78.0-insider (user setup) Commit: Date: 2023-04-12T05:19:38.288Z Reproduces every time I try it
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
I'm still not seeing info in the log in VS Code that the tunnel is attached after from the command line and seeing the "Open this link in your browser". <img width="945" alt="image" src=""
the tunnel will not start unless you "Turn on Remote Tunnel Access"
<img width="730" alt="image" src=""Looks good to me after enabling tunnels in VS Code
Thanks. Enabling Tunnels in VS Code fixed it.
Code change:
if (args.verbose) { fancyLog(`${ansiColors.magenta('BuiltIn extensions')}: ${dedupedBuiltInExtensions.map(e => path.basename(e.extensionPath)).join(', ')}`); <del> fancyLog(`${ansiColors.magenta('Additional extensions')}: ${additionalBuiltinExtensions.map(e => path.basename(e.extensionLocation.path)).join(', ') || 'None'}`); </del> <ins> fancyLog(`${ansiColors.magenta('Additional extensions')}: ${additionalBuiltinExtensions.map(e => path.basename(e.path)).join(', ') || 'None'}`); </ins> } const secondaryHost = (

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.58+ OS Version: Windows Steps to Reproduce: with and . the browser launches, the server throws. This is due to: It should just be . I have a PR to fix this, but needed an issue to reference.
Code change:
} .monaco-workbench .predefined-file-icon[class*='codicon-']::before { <del> font-family: 'codicon'; </del> width: 16px; padding-left: 3px; /* width (16px) - font-size (13px) = padding-left (3px) */ padding-right: 3px; } <ins> .predefined-file-icon::before { /* do add additional specificity to this selector, so it can be overridden by product themes */ font-family: 'codicon'; } </ins> .monaco-workbench:not(.file-icons-enabled) .predefined-file-icon[class*='codicon-']::before { content: unset !important; }

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (all other extensions disabled) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- Version: 1.89.0 Commit: Date: 2024-05-01T02:09:22.859Z Electron: 28.2.8 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0. This is a continuation of I'm in the process of creating a product icon theme and noticed the following icons not being (properly) replaced. They either appear invisible or are unthemed. There may be more icons that suffer from the same problems described below, but I have not been able to find them as of writing this. The icon is invisible after applying the theme. This is due to the following CSS rule overriding the attribute: ! Same as settings editor tab icon, it's invisible for the same CSS rule overriding the attribute. Visible in, for example, output and terminal panel views (left next to close icon), editor tabs more actions (where the 'split editor' action icons is), etc. This doesn't appear to get any overrides at all, so it remains unthemed. The icon is invisible after applying the theme. This is due to the a second attribute always being present and overriding the first attribute that correctly retrieves which value should have. !
To verify: extends the with export it as VSIX, import select the theme verify that the settings editor has now a explorer icon, as well the more icons
Code change:
class GitHubGistProfileContentHandler implements vscode.ProfileContentHandler { readonly name = vscode.l10n.t('GitHub'); <ins> readonly description = vscode.l10n.t('gist'); </ins> private _octokit: Promise<Octokit> | undefined; private getOctokit(): Promise<Octokit> {

Related discussion:
text: Testing In the export flow, there's the step to "Export as...". The options are "File" and "Github" <img width="615" alt="image" src="https://user-"I can make the educated guess that I'm not exporting the whole of Github from my VS Code window, but it'd be better to say "Github Gist" instead, or "Export to" instead of "Export as". I prefer the former since it's clear where it's going--otherwise people might assume it creates a repo on their account or something.
It was GitHub Gist before, after feedback I changed to GitHub. I will bring this to UX and see what other think too.
Good feedback. We will also do a user study next week so we will see how users react here. Alternative rendering: "GitHub" and then "gist" as the description a bit to the right - QuickPick should support this.
There was some confusion in the user study when exporting as GitHub. They were expecting that it will be part of a repository. So calling it GitHub Gist might be the way to go.
I think adding as description would be good
!
Lovely, tried it out. Verified.
Code change:
} const command = prepareCommand(shell, args.args, !!args.argsCanBeInterpretedByShell, cwdForPrepareCommand, args.env); <del> terminal.sendText(command); </del> <ins> if (terminal.shellIntegration) { terminal.shellIntegration.executeCommand(command); } else { terminal.sendText(command); } </ins> // Mark terminal as unused when its session ends, see #112055 const sessionListener = this.onDidTerminateDebugSession(s => {

Related discussion:
text: My VScode and Cursor are broken since today's update. I can't use 'Run and debug', it doesn't open a terminal for my web app runs. Only runs work. VS Code Version: 1.93.0 OS Version: MacOS 14.6.1 (23G93)
I have the same issue when trying to run and debug my Electron application. When I change to (or remove since is the default value) I can use 'Run and debug' again. I won't get the output of the main process (only the renderer process), but at least it's working for now.
same here, this launch configuration fails to start on macos when using or . it only works if you have or remove the console configuration. VS Code Version: 1.93.1 OS Version: MacOS Sonoma 14.6.1 Demo:
Exactly the same issue with nx and nest, also for some strange reason the breakpoints are marked as attached (red) even when no process is running. Something definitely was broken in the last version, this was working fine a few days ago. Not happening on WSL2.
were there any terminal-relate changes here? The on the debug side didn't change in the last release. (Or is there a better way to do things side from a 1s timeout now that shell integration is smart?)
I'm experiencing the same issues; I can't debug anything in NodeJS/TypeScript. This started happening after I updated to MacOS Sequoia. The only way to make it work is if I set the value to the property in the . However, that's not the desired behavior. After a few hours of testing, I managed to make it work —although it's not the ideal solution— by adding the property with the value . Additionally, I with the value . In summary, I have the following configuration:
Your case probably duplicates
Nothing comes to mind around recent changes to terminal launch, apart from a different path for SI scripts. The better way to run command is to use shell integration is it's available. There's no helper function for it just yet though. do you know what that issue was we were discussing a helper?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected.
Code change:
} const command = prepareCommand(shell, args.args, !!args.argsCanBeInterpretedByShell, cwdForPrepareCommand, args.env); <del> terminal.sendText(command); </del> <ins> if (terminal.shellIntegration) { terminal.shellIntegration.executeCommand(command); } else { terminal.sendText(command); } </ins> // Mark terminal as unused when its session ends, see #112055 const sessionListener = this.onDidTerminateDebugSession(s => {

Related discussion:
text: If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Looks like it's solved. Waiting for the official release so Vscode + Cursor will be fixed.
fyi I think cursor is quite a bit behind vscode so I would not expect it to be fixed there soon
Weird, the issue was immediate on both ides a week ago.
Marking as verified due to confirmation.