jiebi/CodeConvo huggingface dataset:
Code change:
[UninstallDelete] Type: filesandordirs; Name: "{app}_" <del> Type: filesandordirs; Name: "{app}old" </del> [Tasks] Name: "desktopicon"; Description: "{cm:CreateDesktopIcon}"; GroupDescription: "{cm:AdditionalIcons}"; Flags: unchecked

Related discussion:
text: The log output from the installer is shown below: Feb 12 13:40:40.605 INFO Starting: C:Program FilesMicrosoft VS Code InsidersCode - , true Feb 12 13:40:40.668 INFO Checking for running Code - processes. (attempt 1) Feb 12 13:40:40.681 INFO Code - is running, wait a bit Feb 12 13:40:41.182 INFO Checking for running Code - processes. (attempt 2) Feb 12 13:40:41.193 INFO Code - is running, wait a bit Feb 12 13:40:41.694 INFO Checking for running Code - processes. (attempt 3) Feb 12 13:40:41.706 INFO Code - is running, wait a bit Feb 12 13:40:42.206 INFO Checking for running Code - processes. (attempt 4) Feb 12 13:40:42.218 INFO Code - is running, wait a bit Feb 12 13:40:42.719 INFO Checking for running Code - processes. (attempt 5) Feb 12 13:40:42.729 INFO Code - is running, wait a bit Feb 12 13:40:43.230 INFO Checking for running Code - processes. (attempt 6) Feb 12 13:40:43.240 INFO Code - is running, wait a bit Feb 12 13:40:43.741 INFO Checking for running Code - processes. (attempt 7) Feb 12 13:40:43.749 INFO Code - is running, wait a bit Feb 12 13:40:44.250 INFO Checking for running Code - processes. (attempt 8) Feb 12 13:40:44.258 INFO Code - is not running Feb 12 13:40:44.267 INFO Starting update, silent = true Feb 12 13:40:44.267 INFO doupdate: "C:Program FilesMicrosoft VS Code InsidersCode - ", Feb 12 13:40:44.373 INFO header: Header, id: Inno Setup Uninstall Log (b) 64-bit, app id: {1287CAD5-7C8D-410D-88B9-0D1EE4A83FF2},
Code change:
[UninstallDelete] Type: filesandordirs; Name: "{app}_" <del> Type: filesandordirs; Name: "{app}old" </del> [Tasks] Name: "desktopicon"; Description: "{cm:CreateDesktopIcon}"; GroupDescription: "{cm:AdditionalIcons}"; Flags: unchecked

Related discussion:
text: app name: Visual Studio Code - Insiders, version: 1048, num recs: , end offset: , flags: 0x35, crc: 0x545ea7d9 Feb 12 13:40:44.374 INFO numrecs: Feb 12 13:40:44.374 INFO moveupdate: "C:Program FilesMicrosoft VS Code Insiders", _ Feb 12 13:40:44.374 INFO Delete: "bin" (attempt 1) Feb 12 13:40:44.374 INFO Delete: "Code - " (attempt 1) Feb 12 13:40:44.425 INFO Delete: "Code - " (attempt 2) Feb 12 13:40:44.626 INFO Delete: "Code - " (attempt 3) Feb 12 13:40:45.077 INFO Delete: "Code - " (attempt 4) Feb 12 13:40:45.877 INFO Delete: "Code - " (attempt 5) Feb 12 13:40:47.128 INFO Delete: "Code - " (attempt 6) Feb 12 13:40:48.929 INFO Delete: "Code - " (attempt 7) Feb 12 13:40:51.379 INFO Delete: "Code - " (attempt 8) Feb 12 13:40:54.585 INFO Delete: "Code - " (attempt 9) Feb 12 13:40:58.636 INFO Delete: "Code - " (attempt 10) Feb 12 13:41:03.636 INFO Delete: "Code - " (attempt 11) Feb 12 13:41:03.650 ERRO Access is denied. (os error 5) I suspect that this has quite a bit to do with how this laptop is configured by our IT dept. I am connected to a local domain with standard user privileges. In order to install any software on the laptop I am required to enter my local administrator account privileges. VSCode installs and runs just fine, the issue occurs when VSCode is self-updating. Once VSCode is loaded, it reports that it has an update and I click "Install Update..." when I click on the gear icon. VSCode then downloads the update.
Code change:
[UninstallDelete] Type: filesandordirs; Name: "{app}_" <del> Type: filesandordirs; Name: "{app}old" </del> [Tasks] Name: "desktopicon"; Description: "{cm:CreateDesktopIcon}"; GroupDescription: "{cm:AdditionalIcons}"; Flags: unchecked

Related discussion:
text: When it completes the download, it requests that I restart VSCode and that's when this error is generated. I've tried running VSCode as the local administrator and follow the same steps above, but the issue still persists, any help that you can provide will be much appreciated!
What is your Windows version?
Oh, it looks like is loading up that DLL! Gotta figure out how to prevent it from doing so.
I saw your commit I tried to update my VSCode application after that but it doesn't seems to works. Though, I don't have the same errors. When I hit "Restart", I got this message error: ! The differences between the old problem: There is no more the little window telling that VSCode is updating (see below) ! The log file is different: EDIT: I'm still on the same architcture. Windows 7 Pro x86 (6.1.7601 Service Pack 1 version 7601)
- Windows 10 / Version 1703 / OS Build .850
Easy, I still haven't pushed the fix.
Oh... Indeed! Sorry about this, I thought changes were effective since I didn't get the same errors. I wanted to provide a little more information not putting any pressure on this. Thanks for your involvment in this issue, I'll be more careful next time! :)
OK pushed a fix to . Guys, tomorrow there'll be a new version. The background update step to get that version, from the current one, will still fail. But background updates should work successfully from that build onwards. So, make sure you get that build from tomorrow and try to get a background update Thursday or Friday. Let me know how that goes.
Your issue is separate. Let's move our discussion over here:
Nothing failed, it has simply successfully updated. :+1: !
Alright, I uninstalled VScode yesterday, reinstalled it and today, the background update worked, just as you said. Thanks once again! o/
Marking as verified. I use background update on Windows and it doesn't fail for me.
Code change:
import { IColorTheme } from '../../../platform/theme/common/themeService.js'; import { CompositeBar, ICompositeBarItem, CompositeDragAndDrop } from './compositeBar.js'; import { Dimension, createCSSRule, asCSSUrl, isMouseEvent } from '../../../base/browser/dom.js'; <del> import { IStorageService, StorageScope, StorageTarget, IProfileStorageValueChangeEvent } from '../../../platform/storage/common/storage.js'; </del> <ins> import { IStorageService, StorageScope, StorageTarget } from '../../../platform/storage/common/storage.js'; </ins> import { IExtensionService } from '../../services/extensions/common/extensions.js'; import { URI, UriComponents } from '../../../base/common/uri.js'; import { ToggleCompositePinnedAction, ICompositeBarColors, IActivityHoverOptions, ToggleCompositeBadgeAction, CompositeBarAction, ICompositeBar, ICompositeBarActionItem } from './compositeBarActions.js';

Related discussion:
text: have insiders with settings sync enabled add exploration build to the sync select replace local when prompted so that exploration because just like insiders over time insiders UI state gets ruined, e.g the side bar is populated with views I have carefully hidden and rearranged
This is caused due to the dependency between two states and . Values of both states changed together from outside Change event for first state is triggered. Updating to this change can cause view container changes like (registering or deregistering) This triggers internal change events to update pinned viewlets Updating pinned viewlets is updating the stored value for second state Bug is caused at the last step -pinned viewlets state is getting overriden without refreshing its in-memory state.
How would this be verified?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Since it cannot be reproduced easily, I would ask to verify this.
the steps are as easy as described in or the description of this issue. use settings sync onboard another machine :bug: view state of the main machine get's broken: views reappear, views are reordered etcpp
Can you please verify this? I believe this depends on some pre-existing state therefore not everyone can reproduce. This state is not trivial to set up. Since you have this state already, it might be easier for you to verify.
Code change:
return; } this.onDidRegisterExtensions(); <del> this._register(this.compositeBar.onDidChange(() => this.saveCachedViewContainers())); this._register(this.storageService.onDidChangeValue(StorageScope.PROFILE, this.options.pinnedViewContainersKey, this._store)(e => this.onDidPinnedViewContainersStorageValueChange(e))); </del> <ins> this._register(this.compositeBar.onDidChange(() => { this.updateCompositeBarItemsFromStorage(true); this.saveCachedViewContainers(); })); this._register(this.storageService.onDidChangeValue(StorageScope.PROFILE, this.options.pinnedViewContainersKey, this._store)(() => this.updateCompositeBarItemsFromStorage(false))); </ins> }); }

Related discussion:
text: have insiders with settings sync enabled add exploration build to the sync select replace local when prompted so that exploration because just like insiders over time insiders UI state gets ruined, e.g the side bar is populated with views I have carefully hidden and rearranged
This is caused due to the dependency between two states and . Values of both states changed together from outside Change event for first state is triggered. Updating to this change can cause view container changes like (registering or deregistering) This triggers internal change events to update pinned viewlets Updating pinned viewlets is updating the stored value for second state Bug is caused at the last step -pinned viewlets state is getting overriden without refreshing its in-memory state.
How would this be verified?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Since it cannot be reproduced easily, I would ask to verify this.
the steps are as easy as described in or the description of this issue. use settings sync onboard another machine :bug: view state of the main machine get's broken: views reappear, views are reordered etcpp
Can you please verify this? I believe this depends on some pre-existing state therefore not everyone can reproduce. This state is not trivial to set up. Since you have this state already, it might be easier for you to verify.
Code change:
<ins> { "displayName": "Dart Language Basics", "description": "Provides syntax highlighting & bracket matching in Dart files." } </ins>

Related discussion:
text: Following on from comments at , it would be good to have basic Dart language configuration as a built-in extension in VS Code, allowing things like syntax highlighting to in the case where the Dart extension is not installed (for example a Live Share client that hasn't installed it) or is disabled (for example in an Untrusted workspace). From : There is a Dart Team-owned grammar here that can be used - it's the (except for a small bug fix that I'll file an upstream PR for shortly): Great! Though what's the advantage of depending on the built-in extension? I try to support a few-versions-old VS Code where possible (so wouldn't do that for a few versions) but also the extension is published to open- for use by other clients so the dependency may complicate things (if they don't have the same built-in). I'd probably do some investigation into this before removing anything from Dart-Code then (it sounds like there's no downside to having the grammar/config provided by both for a period anyway). (fyi
It also works without a dependency, but only because the extension is built-in. No problem if the Dart extension keeps the grammar and language configurations for a while until it is all settled. Do you want to look into a PR or should I?
If it's easier/quicker for you to do, feel free. Otherwise I'm happy to do it but may need some pointers for how built-in extensions are set up.
I pushed the PR We have a new built-in language :-)
Super, thanks! For future reference - for changes to the language config I can send a PR to , and for grammar changes I can run (after the changes are landed in the upstream dart-lang repo)?
I just noticed in the it has the path but this doesn't seem to match the location of the file ?
Good catch, thanks. Pushed the fix:
For grammar changes, I'll pull them in about once per month so you can just rely on that if you want. If there's a change that needs to be picked up sooner than that, then feel free to make an issue an @ mention me and I'll pull in the change earlier.
Perfect, thanks!
is this support in the Code May Update (1.57) that just went out?
Yes, in microsoft/vscode you can tell what release an issue is in by looking at the Milestone. !
Yep!
Code change:
<ins> { "displayName": "Dart Language Basics", "description": "Provides syntax highlighting & bracket matching in Dart files." } </ins>

Related discussion:
text: An easy way to test it's working is to disable the Dart/Flutter extensions (accept the prompt to reload), then open a Dart file. You'll now still get syntax highlighting (note: you won't get analysis or much other editor functionality, that requires the Dart extension). <img width="650" alt="Screenshot 2021-06-14 at 15 52 25" src="https://user-"
Yeah I just did, and it works great :-)
Code change:
}, product: { nameShort: product.nameShort, <del> version: product.version, </del> <ins> version: !!product.darwinUniversalAssetId ? `${product.version} (Universal)` : product.version, </ins> commit: product.commit, date: product.date, reportIssueUrl: product.reportIssueUrl

Related discussion:
text: Issue Type: <bBug The following does not indicate that this is from the universal Mac build: VS Code version: Code - Insiders 1.53.0-insider (, 2021-01-26T05:12:23.287Z) OS version: Darwin x64 19.6.0 Remote OS version: Linux x64 5.4.39-linuxkit <details<summarySystem Info</summary </details<details<summaryExtensions (35)</summaryExtensionVersion ------ unique-lines1.0.0 persona0.0.3 regex0.2.0 vscode-eslint2.1.14 ghlink1.2.0 remotehub0.5.0 tsl-problem-matcher0.3.1 EditorConfig0.16.4 vscode-npm-script0.3.13 codespaces0.6.0 vscode-pull-request-github0.22.0 vscode-mocha-test-adapter2.9.1 vscode-test-explorer2.19.5 rest-client0.24.4 graphql-for-vscode1.15.3 template-string-converter0.4.7 git-graph1.28.0 vscode-azureappservice0.20.0 vscode-docker1.9.1 vscode-kubernetes-tools1.2.3 remote-containers0.156.0 remote-ssh0.63.0 remote-ssh-edit0.63.0 remote-wsl0.53.1 azure-account0.9.4 azurecli0.5.0 hexeditor1.3.0 vscode-github-issue-notebooks0.0.60 debugger-for-chrome4.12.11 vscode-versionlens1.0.9 vscode-yaml0.14.0 music-time2.1.0 vscode-open-in-github1.14.0 vscodeintellicode1.2.10 vscode-test-resolver0.0.1 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
To verify. check if the universal apps version information in about dialog as well as issue reporter details have it like <img width="564" alt="Screen Shot 2021-01-27 at 8 32 54 PM" src="https://user-"
Code change:
this.onDidExitOrCrashOrKill(); })); <ins> // V8 Error this._register(Event.fromNodeEventEmitter(process, 'error', (type, location, report) => ({ type, location, report }))(({ type, location, report }) => { this.log(`crashed due to ${type} from V8 at ${location}`, Severity.Info); let addons: string[] = []; try { const reportJSON = JSON.parse(report); addons = reportJSON.sharedObjects .filter((sharedObject: string) => sharedObject.endsWith('.node')) .map((addon: string) => { const index = addon.indexOf('extensions') === -1 ? addon.indexOf('node_modules') : addon.indexOf('extensions'); return addon.substring(index); }); } catch (e) { // ignore } // Telemetry type UtilityProcessV8ErrorClassification = { processtype: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; comment: 'The type of utility process to understand the origin of the crash better.' }; error: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; comment: 'The type of error from the utility process to understand the nature of the crash better.' }; location: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; comment: 'The source location that triggered the crash to understand the nature of the crash better.' }; addons: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; comment: 'The list of addons loaded in the utility process to understand the nature of the crash better' }; owner: 'deepak1556'; comment: 'Provides insight into V8 sandbox FATAL error caused by native addons.'; }; type UtilityProcessV8ErrorEvent = { processtype: string; error: string; location: string; addons: string[]; }; this.telemetryService.publicLog2<UtilityProcessV8ErrorEvent, UtilityProcessV8ErrorClassification>('utilityprocessv8error', { processtype: configuration.type, error: type, location, addons }); })); </ins> // Child process gone this._register(Event.fromNodeEventEmitter<{ details: Details }>(app, 'child-process-gone', (event, details) => ({ event, details }))(({ details }) => { if (details.type === 'Utility' && details.name === serviceName && !this.isNormalExit(details.exitCode)) {

Related discussion:
text: The file-open and directory-open dialogs still do not appear even though built on Electron 30.1.2. This is reproducible 100% of the time in openSUSE Tumbleweed and in Leap.
The file-open/directory-open or save dialog not being shown remains unresolved on Linux in release 1.93.1 built with electron 30.4.0.
Code change:
"config.rebaseWhenSync": "Force git to use rebase when running the sync command.", "config.confirmEmptyCommits": "Always confirm the creation of empty commits for the 'Git: Commit Empty' command.", "config.fetchOnPull": "When enabled, fetch all branches when pulling. Otherwise, fetch just the current one.", <del> "config.fetchBeforeCheckout": "Controls whether a branch that does not have outgoing commits is fast-forwarded before it is checked out.", </del> <ins> "config.pullBeforeCheckout": "Controls whether a branch that does not have outgoing commits is fast-forwarded before it is checked out.", </ins> "config.pullTags": "Fetch all tags when pulling.", "config.pruneOnFetch": "Prune when fetching.", "config.autoStash": "Stash any changes before pulling and restore them after successful pull.",

Related discussion:
text: Testing The feature is called . But it does more than fetch, it also pulls. Fetch typically only 'downloads' commits, but does not update any branches. Maybe the proper name would be:
Code change:
model.setLanguage(provider.options.language); } container.appendChild(this._editorContainer); <del> this._keyListener = this._register(this._editorWidget.onKeyUp((e) => { if (e.keyCode === KeyCode.Escape) { this._contextViewService.hideContextView(); // Delay to allow the context view to hide #186514 setTimeout(() => provider.onClose(), 100); this._keyListener?.dispose(); } else if (e.keyCode === KeyCode.KeyD && this._configurationService.getValue(settingKey)) { this._configurationService.updateValue(settingKey, false); } else if (e.keyCode === KeyCode.KeyH && provider.options.readMoreUrl) { const url: string = provider.options.readMoreUrl!; alert(AccessibilityHelpNLS.openingDocs); this._openerService.open(URI.parse(url)); } e.stopPropagation(); provider.onKeyDown?.(e); })); this._register(this._editorWidget.onDidBlurEditorText(() => this._contextViewService.hideContextView())); this._register(this._editorWidget.onDidContentSizeChange(() => this._layout())); </del> this._editorWidget.updateOptions({ ariaLabel: provider.options.ariaLabel }); this._editorWidget.focus(); }); <del> return toDisposable(() => { }); </del> <ins> const disposableStore = new DisposableStore(); disposableStore.add(this._editorWidget.onKeyUp((e) => { if (e.keyCode === KeyCode.Escape) { this._contextViewService.hideContextView(); // Delay to allow the context view to hide #186514 setTimeout(() => provider.onClose(), 100); } else if (e.keyCode === KeyCode.KeyD && this._configurationService.getValue(settingKey)) { this._configurationService.updateValue(settingKey, false); } e.stopPropagation(); provider.onKeyDown?.(e); })); disposableStore.add(this._editorWidget.onKeyDown((e) => { if (e.keyCode === KeyCode.KeyH && provider.options.readMoreUrl) { const url: string = provider.options.readMoreUrl!; alert(AccessibilityHelpNLS.openingDocs); this._openerService.open(URI.parse(url)); e.preventDefault(); e.stopPropagation(); } })); disposableStore.add(this._editorWidget.onDidBlurEditorText(() => this._contextViewService.hideContextView())); disposableStore.add(this._editorWidget.onDidContentSizeChange(() => this._layout())); return disposableStore; </ins> } private _layout(): void {

Related discussion:
text: It doesn't matter in this case, but note that you collect all the keyListener disposables in the store of the AccessibleView class (even if you dispose them in , but the disposable is still in the disposableStore). This can lead to memory leaks. I can really recommend to compose components according to their life times. I think here the lifetime of the rendered content is owned by the caller of (the caller is supposed to call on the result). So the disposable returned by should be owned by whatever you return in . I suggest to create a DisposableStore in render, push the key listener to it once the text model resolves and return the disposable store at the end of render (also add the to the store). Also, note that the getTextModel promise can resolve after the caller called dispose. Originally posted by in
Code change:
constructor( private readonly editor: ICodeEditor, @ISpeechService private readonly speechService: ISpeechService, <del> @IContextKeyService private readonly contextKeyService: IContextKeyService </del> <ins> @IContextKeyService private readonly contextKeyService: IContextKeyService, @IKeybindingService private readonly keybindingService: IKeybindingService </ins> ) { super(); }

Related discussion:
text: Testing My first reaction for how to stop dictation in the editor was to click the flashing microphone. It would be cool if something happened when the flashing microphone is clicked.
I will turn this into a real with action and hover.
Code change:
if (settingId !== this.currentProductIconTheme.settingsId) { await this.internalSetProductIconTheme(theme.id, undefined); } else if (theme !== this.currentProductIconTheme) { <ins> await theme.ensureLoaded(this.extensionResourceLoaderService, this.logService); </ins> this.applyAndSetProductIconTheme(theme, true); } return true;

Related discussion:
text: Open a new folder Trust the workspace Some of the colors in the window become wrong An editor has the wrong background color Opening the theme picker fixes it !
I originally filed because I encountered this during Settings Sync but think it's not related as I also saw this when opening files: !
Step to verify connect to settings sync install and set the Dracula theme () notice that the remote indicator is violet open a new folder that is not yet trusted the trust dialog shows up, approve verify that the remote indicator is still violet, not blue