jiebi/CodeConvo huggingface dataset:
Code change:
} }); } <del> run(accessor: ServicesAccessor, args?: IOpenSettingsActionOptions) { args = sanitizeOpenSettingsArgs(args); </del> <ins> run(accessor: ServicesAccessor, args?: string | IOpenSettingsActionOptions) { // Match the behaviour of workbench.action.openSettings args = typeof args === 'string' ? { query: args } : sanitizeOpenSettingsArgs(args); </ins> return accessor.get(IPreferencesService).openWorkspaceSettings(args); } });

Related discussion:
text: VSCode Version: 1.41.1 OS Version: Win10 1909 Steps to Reproduce: In an extension: .executeCommand('', 'telemetry'); settings open, but without a search filter <!-- Launch with to check. --No, as there is nothing to run that code
Why do you need this? You can use but I don't really want to provide a ton of commands to control all the different options in the settings UI.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
There is a difference between User settings or Workspace settings, there is different UI and comparable methods in the API to reach them. The openWorkspaceSettings has the same signature as openSettings, but they don’t behave the same way. That’s why I think this needs to be resolved to be consistent. Martin Martin Tirion Microsoft Tel +31 (6) 1250 6153 Blog
Same issue. I just want to open the workspace settings and filter by my extension name.
Same here!
+1
+1
This is exactly what I need to programmatically open the workspace settings for my extension, allowing users to easily make changes. For anyone who needs this feature, execute openSettings with your search, then execute openWorkspaceSettings. It will switch the current settings window over to workspace settings while keeping your search string. Example vscode.commands.executeCommand('', 'telemetry' ); vscode.commands.executeCommand(''); Although this works, I still believe these commands should be consistent. I believe my use case is exactly why we need this, a per project/workspace settings window for extensions at the click of a button rather than multiple quickPicks.
Tried solution by I have the exact same use case for this as a couple of people above, providing a shortcut to my settings from an extension. The solution above didn't work, but reordering the calls worked for me: vscode.commands.executeCommand(''); vscode.commands.executeCommand('', '[search term here]'); Works for now, but I have a feeling this will break on me in the future.
Code change:
} }); } <del> run(accessor: ServicesAccessor, args?: IOpenSettingsActionOptions) { args = sanitizeOpenSettingsArgs(args); </del> <ins> run(accessor: ServicesAccessor, args?: string | IOpenSettingsActionOptions) { // Match the behaviour of workbench.action.openSettings args = typeof args === 'string' ? { query: args } : sanitizeOpenSettingsArgs(args); </ins> return accessor.get(IPreferencesService).openWorkspaceSettings(args); } });

Related discussion:
text: Since the solution provided by already stopped working as of now (at least on my machine/env). So here's my motivated '+1' on this: I think there's a clear use case for this I also subscribe to the argument provided by -- that adding this would make the API more consistent, since then openSettings and openWorkspaceSettings would work the same way.
Thanks and for documenting this workaround I had this same need btw.
Code change:
this.outputElements.get(request.outputId)?.updateScroll(request.outputOffset); if (request.forceDisplay) { <del> this.element.style.visibility = 'visible'; </del> <ins> this.element.style.visibility = ''; </ins> } } }

Related discussion:
text: Collapse an output, it is not hidden in the webview <img width="596" alt="image" src="https://user-"
maybe ?
Code change:
} } <del> private updateCompositeSwitcher(): void { </del> <ins> private updateCompositeSwitcher(donotTrigger?: boolean): void { </ins> const compositeSwitcherBar = this.compositeSwitcherBar; if (!compositeSwitcherBar || !this.dimension) { return; // We have not been rendered yet so there is nothing to update.

Related discussion:
text: have insiders with settings sync enabled add exploration build to the sync select replace local when prompted so that exploration because just like insiders over time insiders UI state gets ruined, e.g the side bar is populated with views I have carefully hidden and rearranged
This is caused due to the dependency between two states and . Values of both states changed together from outside Change event for first state is triggered. Updating to this change can cause view container changes like (registering or deregistering) This triggers internal change events to update pinned viewlets Updating pinned viewlets is updating the stored value for second state Bug is caused at the last step -pinned viewlets state is getting overriden without refreshing its in-memory state.
How would this be verified?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Since it cannot be reproduced easily, I would ask to verify this.
the steps are as easy as described in or the description of this issue. use settings sync onboard another machine :bug: view state of the main machine get's broken: views reappear, views are reordered etcpp
Can you please verify this? I believe this depends on some pre-existing state therefore not everyone can reproduce. This state is not trivial to set up. Since you have this state already, it might be easier for you to verify.
Code change:
return res; } <ins> // we are here when no provider prepared a location which means we can // just rely on the word under cursor and start with the first provider this._providerRenameIdx = 0; </ins> const word = this.model.getWordAtPosition(this.position); if (!word) { return {

Related discussion:
text: Steps to Reproduce: in VS Code, build and run as an extension the debugged VS Code version open a text file some text Rename from the context menu Observe: the rename dialog opens, however the method on the rename provider is never called. The return before however since no other rename provider is registered the provider should still be called according to discussions with
Code change:
private async render() { if (this._previewState !== PreviewState.Disposed) { <del> this.webviewEditor.webview.html = await this.getWebiewContents(); </del> <ins> this.webviewEditor.webview.html = await this.getWebviewContents(); </ins> } }

Related discussion:
text: Issue Type: <bBug</bIf I try to open an image with a name such as 'test-' it says 'An error occurred while loading the image'. In the developer console, the following error is shown: VS Code version: Code 1.44.2 (, 2020-04-16T17:07:18.473Z) OS version: Darwin x64 19.4.0 <details<summarySystem Info</summary </detailsExtensions: none <!-- generated by issue reporter --
Looks like the problem is on the , line 22 We got , which is a string looks like it is correct. Next, when we do it becomes an object and the paths are not correct here. Going down into the () i found that the string is being processed inside the by the This piece of code takes the string, and tries to decode any part started from %, thats why %41 becomes A
I don't think the decoding process is faulty, but the encoding part. Every browser will interpret as . ! So the url should escape in the first place. !
You're right. The percent ("%") character is missed in the encodeTable, and in the encodeURIComponentMinimal() 562 line.
Code change:
font-family: var(--monaco-monospace-font); font-size: 12px; color: var(--vscode-textPreformat-foreground); <del> background-color: var(--vscode-textPreformat-background); </del> padding: 1px 3px; border-radius: 4px; }

Related discussion:
text: Expected ! Actual !
Regressed in
The markdown preview in the chat is also broken for Dark Modern but is fixed by your change: !
And the markdown preview in the settings editor: !
I looked into this some more and have the following findings block rendering is broken for Dark Modern, Light Modern, Dark HC and Light HC What changed: we a new theme token, , adopted it in and , and updated the values for to look good with a different background color But we didn't adopt token for blocks in Markdown previews, which is why is broken for Markdown preview Some options Adopt for blocks in Markdown preview -- this amounts to a rather drastic styling change for Markdown previews ! Revert Revert the change to and drop the usage of so that Markdown preview, chat, and settings UI are in a reasonable state for all themes, which I attempted in
Also affects the Extensions Details page since it is a Markdown preview !
Verification: for Light/Dark Modern and Light/Dark HC, make sure that blocks are properly rendered in Markdown preview, settings UI and chat
Code change:
private async _sync(repository: Repository, rebase: boolean): Promise<void> { const HEAD = repository.HEAD; <del> if (!HEAD || !HEAD.upstream) { </del> <ins> if (!HEAD) { return; } else if (!HEAD.upstream) { const branchName = HEAD.name; const message = localize('confirm publish branch', "The branch '{0}' has no upstream branch. Would you like to publish this branch?", branchName); const yes = localize('ok', "OK"); const pick = await window.showWarningMessage(message, { modal: true }, yes); if (pick === yes) { await this.publish(repository); } </ins> return; }

Related discussion:
text: Issue Type: <bBug</b(or maybe feature) HI! I have a habit that I constantly do and and we have strict rules on doing feature branches, hence creating (& removing) lots of branches per week. (did I just implicitly mentioned that I'm fast : )))) ) So it comes to me a lot that I do and I see no action, and sometimes I even don't understand that no action happened. So it happens a lot that I do code, I do branches, I do sync, I go home happy, I come back tomorrow and I find out that my commits existed only on my local system the whole time. (and, BTW, I have strict inner rules that my codes should always be synced with remote) So, firstly, what I am asking for, is to receive a toast, a popup, an error, or everything that can notify me when I do and my branch is not published yet, so I can remember to publish my branch every time its new. Secondly, I think it wouldn't be bad if VSCode automatically publishes my branch when I do . I'm not sure if this is correct considering git rules/conventions. But If that's OK with Git & VSCode team/community, well, that's OK with me :) +1 Keep up the good work :) VS Code version: Code - Insiders 1.30.0-insider (, 2018-11-30T06:19:37.226Z) OS version: WindowsNT x64 10.0.
Code change:
private async _sync(repository: Repository, rebase: boolean): Promise<void> { const HEAD = repository.HEAD; <del> if (!HEAD || !HEAD.upstream) { </del> <ins> if (!HEAD) { return; } else if (!HEAD.upstream) { const branchName = HEAD.name; const message = localize('confirm publish branch', "The branch '{0}' has no upstream branch. Would you like to publish this branch?", branchName); const yes = localize('ok', "OK"); const pick = await window.showWarningMessage(message, { modal: true }, yes); if (pick === yes) { await this.publish(repository); } </ins> return; }

Related discussion:
text: <details<summarySystem Info</summary </details<details<summaryExtensions (20)</summaryExtensionVersion ------ swagger-viewer2.1.0 npm-intellisense1.3.0 path-intellisense1.4.2 vscode-markdownlint0.21.0 vscode-eslint1.7.0 githistory0.4.4 gitlens9.0.1 tslint1.0.40 vscode-npm-script0.3.5 prettier-vscode1.7.2 vscode-nginx-conf-hint0.1.0 Angular27.0.1 camelcasenavigation0.3.51 Angular-BeastCode7.0.18 vsliveshare0.3.1005 vscode-icons7.28.0 sass-indented1.4.9 vscode-nginx0.6.0 move-ts1.11.3 html-css-class-completion1.17.1 </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.453 --- <!-- score: 0.448 --<!-- potentialduplicatescomment --
Code change:
Hover = 'accessibility.verbosity.hover', Notification = 'accessibility.verbosity.notification', EmptyEditorHint = 'accessibility.verbosity.emptyEditorHint', <del> Comments = 'accessibility.verbosity.comments' </del> <ins> Comments = 'accessibility.verbosity.comments', DiffEditorActive = 'accessibility.verbosity.diffEditorActive' </ins> } export const enum AccessibleViewProviderId {

Related discussion:
text: has said that when switching between editors, it's unclear to him when a diff editor has been entered, though this is clear for sighted users. We should something like to fix this. cc
I think we announce whenever an editor gets focus. Each editor has a title that is announced. So I am not sure what is missing here? I would not like that we just add a new alert. Is the title of the diff editor not descriptive enough? Or is nothing getting announced (which would be a bug)
Good point, the file name is announced and says (Working Tree). is that sufficient to indicate this?
Closing for now, but will reopen based on your feedback
Just discussed with JooYoung and the redundant info is escaped/ignored by screen reader users, so we need to alert with this info
Should we consider a better announcement on focus of the text editor? how does this interact with the existing announcement?
Venkatesh observed that the editor title isn't being read at all, only the accessibility help hint, need to investigate that. EDIT: I explored and this works as expected.
Edit: we use already. This is working as expected. When a new file is opened, the title is read. When a user focuses the document, they hear the hint, if any, along with the "edit text, ...content". If that hint is disabled, they hear "edit text,...content"
which command do you use to switch between editor tabs? Is it ? I believe this issue is about when using that command, indicating if the focused editor is a diff editor via an .
What should I be looking for when verifying this?
Have some editor groups open, including ones with diff editors. Run the command . When a diff editor group is focused, you should hear "diff editor" announced by a screen reader. Disable that setting, and ensure you don't hear that. You should also hear it when navigating the open editors view. !
Using the Open Editors view, I don't see anything read about diff editors when I hit on a diff editor: !
Actually, I do see it when I toggle accessibility mode on
Code change:
} } <del> export class RevertButton implements IGlyphMarginWidget { </del> <ins> export class RevertButton extends Disposable implements IGlyphMarginWidget { </ins> public static counter = 0; private readonly _id: string = `revertButton${RevertButton.counter++}`;

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.0 OS Version: Ubuntu 23.04 a file with contents a file with contents the explorer, right click on file and select the explorer, right click on file and select , opening the diff editor the diff editor that , and event listeners have been but not been removed The issue is not present in VS Code 1.84.2. It seems to be caused by
Code change:
const innerContent = document.createElement('div'); innerContent.classList.add('walkThroughContent'); // only for markdown files const markdown = this.expandMacros(content); <del> safeInnerHtml(innerContent, markdown); </del> <ins> safeInnerHtml(innerContent, markdown, { ALLOW_UNKNOWN_PROTOCOLS: true }); </ins> this.content.appendChild(innerContent); model.snippets.forEach((snippet, i) => {

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.93.0-insider (user setup) Commit: Date: 2024-09-04T13:13:15.344Z Electron: 30.4.0 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0. OS Version: Windows 11 Insiders Steps to Reproduce: in the first paragraph doesn't appear to be a link, which I was surprised about: ! I hover over it, I see it's supposed to be a link, but clicking on it does nothing: ! The other docs links at the bottom of the playground appear correctly as links and do open when I click on them: !
This seems related to the bookmark issue we had in the release notes. The other bookmark links in the interactive playground don't work either.
Fixed the toc links. Need another fix for the documentation link too (which use command uris)
The Editor Playground is not showing at all anymore in the latest insiders. When selecting the Editor Playground menu item, a black editor comes up.
hm working from oss builds. Insiders, it seems like the error is:
Actually unrelated. Seems like a duplicate of and fixed by
Code change:
tags: ['notebookLayout', 'notebookOutputLayout'] }, [NotebookSetting.outputScrolling]: { <del> markdownDescription: nls.localize('notebook.outputScrolling', "Use a scrollable region for notebook output when longer than the limit"), </del> <ins> markdownDescription: nls.localize('notebook.outputScrolling', "Initially render notebook outputs in a scrollable region when longer than the limit"), </ins> type: 'boolean', tags: ['notebookLayout', 'notebookOutputLayout'], default: typeof product.quality === 'string' && product.quality !== 'stable' // only enable as default in insiders

Related discussion:
text: Testing Disable scrolling output via command Select ! The scrolling setting is enabled, which I didn't expect !
The setting is for the initial rendering of all outputs, whereas the command will change a single cell's output. I'll see if I can clarify that in the description
Code change:
if (action.class) { this.label.classList.add(action.class); } if (!action.icon) { const reactionLabel = dom.append(this.label, dom.$('span.reaction-label')); reactionLabel.innerText = action.label; } else { const reactionIcon = dom.append(this.label, dom.$('.reaction-icon')); <del> reactionIcon.style.display = ''; </del> const uri = URI.revive(action.icon); reactionIcon.style.backgroundImage = dom.asCSSUrl(uri); reactionIcon.title = action.label;

Related discussion:
text: Microsoft/vscode Tested using VoiceOver on MacOS Issues The add reaction button on the right side is currently read out atWhen focusing on a reaction in the context menu, it is read as just the emoji name. Github instead reads each option asThe existing reactions do not have helpful voice text. They should be read as the reaction name and number of reactionsThe add reaction button the right of existing reactions also does not have helpful voice over labels
This is now read as "Toggle Reaction" Since this uses a context menu, this is intentional. Menus don't have special aria labels. This now reads a more useful "Toggle reaction, x reactions with y" message. Same as above since this is a menu.
This seems improved but I can't get it to read the menu when I tab from the comment to the react menu button. It doesn't read anything when I use the arrow keys to move focus between menu buttons. If I expand the menu with space, then it reads the menu name. It looks like this, so I guess voiceover is stuck on the full comment context even though focus has moved. Not a voiceover expert though, is that an issue or should I be using other nav keys anyway? <img width="610" alt="image" src="https://user-"
Code change:
}; } async function main(arch = process.arch) { <del> const version = product.electronRepository ? '22.5.3' : util.getElectronVersion(); </del> <ins> const version = product.electronRepository ? '22.5.4' : util.getElectronVersion(); </ins> const electronPath = path.join(root, '.build', 'electron'); const versionFile = path.join(electronPath, 'version'); const isUpToDate = fs.existsSync(versionFile) && fs.readFileSync(versionFile, 'utf8') === `${version}`;

Related discussion:
text: Seeing an increase in issues (such as ) where a mapped network drive or symbolic link points to a UNC path. If you use methods such as or to resolve these paths to their UNC equivalent and use them for further file operations, our UNC allow list might prevent use of these paths until you add them to the allow list. We should discuss if there are options here to make this easier on the impacted users. The issue often goes unnoticed because we do not prompt the user on startup for these paths to add them to the allow list. Workaround Given an exception like this one: Find the resolved file path (here ) and add the hostname of the path (the value between and the first after that) to the setting (here: ). Then restart VS Code. See also:
There are some cases that are a bit difficult to handle: In my company, people always either use the raw path to access files, or map a drive to and then access files using the mapped drive name. However the real path is , which is on a server that most developers have never directly interacted with or even heard of (and there are a number of these file servers depending on the exact path). The TS server and likely many other extensions use this real path in their code, and when it does not have access the server crashes. The only way developers would be able to know the host names causing problems and add them to the allowed host list is by examining the error message of extension host which is extremely user-unfriendly. What is tricky about this is that a user may never know the real hostname until a runtime error occurred. And depending on the extensions a user installs, this may or may not be a problem at all.
Is there a way to get an older version of vscode ? The current version is unusable as long as this bug persists.
This worked for me Note: omit the leading and the at the end.
/fixedWith
Steps for verification: create a that points to a localhost UNC folder which has a Typescript project open the mapped network drive verify TypeScript smartness works and shows no errors in the TS server output logs
For some reason I wish to go back to 1.78 until there is a release which includes the fix. However I cannot find the Windows zip (needed to make VSC ) on the . Any idea where to find it?
The fix for this is in releases.