jiebi/CodeConvo huggingface dataset:
Code change:
} if (instance?.shellType) { this._terminalShellTypeContextKey.set(instance.shellType.toString()); <del> } else if (!instance) { </del> <ins> } else if (!instance || !(instance.shellType)) { </ins> this._terminalShellTypeContextKey.reset(); } }));

Related discussion:
text: Testing This is sort of unrelated to the TPI, but when I inspect context keys on my terminal area, I notice that it has , even when the active terminal isn't using git bash. Here are my repro steps (not sure if this can be simplified): a terminal profile using an extension and launch the extension. git bash, then close it and open the extension-provided terminal profile. context keys on the extension-provided terminal instance. :bug:
I would like to solve this problem, if it is still an issue. Do you mind if I start?
sure!
After scanning some source, there seems no good way to solve this. Because is no way for extension to specify terminal type when (AFAIK) extension register a terminal profile ( ), and Windows, shell type is determined by some heuristic logic, based on executable string, and default to return . (For WSL, the shell type is always "undefined" in my quick experiment.) When terminal service try to update context key, it fallback to NOP if the shell type is , that's the behavior noticed at first place. See: For this issue to be solved, probably there should be a way for builtin terminal profile to specify shell type (so it works for all bultin profile in all platform), and for extension provided terminal profiles, maybe we can add more optional fields to or method to . As for the wierd behavior noticed currently, maybe we can set to "unknown", to make this state less confusing. But since that this behavior is already state in , I wonder this can be changed.
I think the problem is here: It should check if first, then set it even if it's undefined if
do you want to submit a PR since you investigated and found the problem?
Yes, I can submit a PR for this. But, before doing this, I need to confirm some detail. The current behavior is From A. If new terminal instance is created, and shell type of the new terminal istance is defined, update From B. If active terminal instance change, and shell type of the new terminal istance is defined, update C. If there is no terminal instance, reset D. otherwise, do nothing so the editor keeps last known when shell type is undefined during new terminal creation or active terminal change. If so, what value should be set on this case? should we set it to or just call ?
Code change:
} if (instance?.shellType) { this._terminalShellTypeContextKey.set(instance.shellType.toString()); <del> } else if (!instance) { </del> <ins> } else if (!instance || !(instance.shellType)) { </ins> this._terminalShellTypeContextKey.reset(); } }));

Related discussion:
text: like Can you provide the extension that open extension-provided terminal and trigger this issue?
Some commits about the comment/design history of this context key
Code change:
font-family: var(--monaco-monospace-font); font-size: 11px; color: var(--vscode-textPreformat-foreground); <del> background-color: var(--vscode-textPreformat-background); </del> padding: 1px 3px; border-radius: 4px; }

Related discussion:
text: Expected ! Actual !
Regressed in
The markdown preview in the chat is also broken for Dark Modern but is fixed by your change: !
And the markdown preview in the settings editor: !
I looked into this some more and have the following findings block rendering is broken for Dark Modern, Light Modern, Dark HC and Light HC What changed: we a new theme token, , adopted it in and , and updated the values for to look good with a different background color But we didn't adopt token for blocks in Markdown previews, which is why is broken for Markdown preview Some options Adopt for blocks in Markdown preview -- this amounts to a rather drastic styling change for Markdown previews ! Revert Revert the change to and drop the usage of so that Markdown preview, chat, and settings UI are in a reasonable state for all themes, which I attempted in
Also affects the Extensions Details page since it is a Markdown preview !
Verification: for Light/Dark Modern and Light/Dark HC, make sure that blocks are properly rendered in Markdown preview, settings UI and chat
Code change:
const message = dom.append(extraContainer, $(`#${this.idPrefix}message.quick-input-message`)); <ins> const progressBar = new ProgressBar(container, this.styles.progressBar); progressBar.getContainer().classList.add('quick-input-progress'); </ins> const list = this._register(new QuickInputList(container, this.idPrefix + 'list', this.options)); this._register(list.onChangedAllVisibleChecked(checked => { checkAll.checked = checked;

Related discussion:
text: I just now noticed how the progress bar was a the very end of the quick pick but not below input box, I think it should be below input box because the progress is for what I typed. Steps: have some history entries in Cmd+P picker be on a slow OS (Windows) start to type and notice progress bar is below the history entries //cc
Seems like this might have been a regression at some point. for relocating it back near the input.
I like where it is now. To me it says "the results are still populating".
The reason I do not like it: the progress bar is at a non-deterministic location depending on the number of items the progress bar indicator is away from the location that triggers it (the input box)
Code change:
} }, showCommonFindToggles: options.showCommonFindToggles, <del> appendCaseSensitiveLabel: options.appendCaseSensitiveLabel && options.type === 'Terminal' ? this._getKeybinding(TerminalCommandId.ToggleFindCaseSensitive) : undefined, appendRegexLabel: options.appendRegexLabel && options.type === 'Terminal' ? this._getKeybinding(TerminalCommandId.ToggleFindRegex) : undefined, appendWholeWordsLabel: options.appendWholeWordsLabel && options.type === 'Terminal' ? this._getKeybinding(TerminalCommandId.ToggleFindWholeWord) : undefined, </del> <ins> appendCaseSensitiveLabel: options.appendCaseSensitiveActionId ? this._getKeybinding(options.appendCaseSensitiveActionId) : undefined, appendRegexLabel: options.appendRegexActionId ? this._getKeybinding(options.appendRegexActionId) : undefined, appendWholeWordsLabel: options.appendWholeWordsActionId ? this._getKeybinding(options.appendWholeWordsActionId) : undefined, </ins> showHistoryHint: () => showHistoryKeybindingHint(_keybindingService), inputBoxStyles: defaultInputBoxStyles, toggleStyles: defaultToggleStyles

Related discussion:
text: Terminal: <img width="328" alt="image" src=""Editor: <img width="436" alt="image" src=""
Code change:
public focus(): void { this._standaloneColorPickerFocused.set(true); <del> this.body.focus(); </del> <ins> this._body.focus(); </ins> } private async _start(selection: IRange) {

Related discussion:
text: Depending oh how many editors windows are open and the size of them, sometimes the standalone color picker is partially hidden behind other editor panel. vscode version:1.81.0 x64 !
Code change:
public focus(): void { this._standaloneColorPickerFocused.set(true); <del> this.body.focus(); </del> <ins> this._body.focus(); </ins> } private async _start(selection: IRange) {

Related discussion:
text: There is a z-index error: <img width="572" alt="Screenshot 2023-07-25 at 13 56 59" src=""
Code change:
}); } <del> async run(accessor: ServicesAccessor, editSessionId?: string): Promise<void> { await that.progressService.withProgress({ ...resumeProgressOptions, title: resumeProgressOptionsTitle }, async () => await that.resumeEditSession(editSessionId)); </del> <ins> async run(accessor: ServicesAccessor, editSessionId?: string, force?: boolean): Promise<void> { await that.progressService.withProgress({ ...resumeProgressOptions, title: resumeProgressOptionsTitle }, async () => await that.resumeEditSession(editSessionId, undefined, force)); </ins> } })); }

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: Cloud Changes on the button: <img width="713" alt="image" src="https://user-"appears but no changes are made locally at least my change doesn't go away. Logs don't indicate anything interesting
I encountered this issue myself because I had branches that had the same name locally, but their upstream branches were set differently. My local workaround was to to get Cloud Changes to do the right thing, but the only way I figured this out was by looking at logs. It would be nice for Cloud Changes to at the very least show an error message or something when I click "Resume Working Changes" but it intentionally no-ops.
sorry, misclicked a label
Code change:
constructor() { super({ id: ClearRecentFilesAction.ID, <del> title: { value: localize('clearRecentFiles', "Clear Recently Opened"), original: 'Clear Recently Opened' }, </del> <ins> title: { value: localize('clearRecentFiles', "Clear Recently Opened..."), original: 'Clear Recently Opened...' }, </ins> f1: true, category: Categories.File });

Related discussion:
text: Type: <bBug</bany open windows. to File Open Recent and click Clear Recently Opened. VS Code version: Code 1.83.1 (, 2023-10-10T23:46:55.789Z) OS version: Darwin x64 20.6.0
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Code change:
const language = model.getLanguageId(); const languageName = this.languageService.getLanguageName(language); if (importantRecommendations.size && <del> this.promptRecommendedExtensionForFileType(languageName && isImportantRecommendationForLanguage && language !== PLAINTEXT_LANGUAGE_ID ? localize('languageName', "{0} language", languageName) : basename(uri), language, [...importantRecommendations])) { </del> <ins> this.promptRecommendedExtensionForFileType(languageName && isImportantRecommendationForLanguage && language !== PLAINTEXT_LANGUAGE_ID ? localize('languageName', "the {0} language", languageName) : basename(uri), language, [...importantRecommendations])) { </ins> return; } }

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.81.0 (user setup) Commit: Date: 2023-08-02T12:37:13.485Z Electron: 22.3.18 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: a .cpp file (or a .c file). Don't have the C/C++ Extension Pack installed. Bug: The extension recommendation popup uses text "for C++ language", which isn't grammatically correct. It's possible the same issue repros for other languages. I wasn't able to locate the source of the text (maybe it's from a private repo). ! Potential fix 1: It should use "for the C++ language" to be grammatically correct. Potential fix 2: Well, to be even more accurate, for the C/C++ extension pack, it should say "for the C and C++ languages". Potential fix 3: Or, if it can say "for the C++ language" when triggered from a "cpp" language file and a "for the C language" when triggered from a "c" language file.
can I work on this issue?
Are you able to locate where that text is coming from?
been searching the text source for some time but not able to find it. Did you find anything?
Code change:
const language = model.getLanguageId(); const languageName = this.languageService.getLanguageName(language); if (importantRecommendations.size && <del> this.promptRecommendedExtensionForFileType(languageName && isImportantRecommendationForLanguage && language !== PLAINTEXT_LANGUAGE_ID ? localize('languageName', "{0} language", languageName) : basename(uri), language, [...importantRecommendations])) { </del> <ins> this.promptRecommendedExtensionForFileType(languageName && isImportantRecommendationForLanguage && language !== PLAINTEXT_LANGUAGE_ID ? localize('languageName', "the {0} language", languageName) : basename(uri), language, [...importantRecommendations])) { </ins> return; } }

Related discussion:
text: No, but I don't work on VS Code (just an extension) -- I assume someone who works on VS Code would know how to find it.
I was just searching some beginner friendly issue to solve to start my open source journey.
Code change:
version: string; id: string; isTheme: boolean; <ins> isBuiltin: boolean; </ins> displayName: string | undefined; repositoryUrl: string | undefined; bugsUrl: string | undefined;

Related discussion:
text: Feature Request The command takes an extension argument so that extensions can open an issue reporter for that extension. I'd like to use this for the built-in JS/TS extension as well but cannot at the moment: It'd be nice if for VS Code builtin extensions, we automatically changed the field to
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Code change:
resolved "https://registry.yarnpkg.com/vscode-textmate/-/vscode-textmate-9.0.0.tgz#313c6c8792b0507aef35aeb81b6b370b37c44d6c" integrity sha512-Cl65diFGxz7gpwbav10HqiY/eVYTO1sjQpmRmV991Bj7wAoOAjGQ97PpQcXorDE2Uc4hnGWLY17xme+5t6MlSg== <del> xterm-addon-canvas@0.4.0-beta.9: version "0.4.0-beta.9" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.4.0-beta.9.tgz#e570fa4592890f92cc86706f2bba0dd128a8641d" integrity sha512-BWRVWyUW7NY2g4BBMm3ecPQvbdyKXFgABnpmh4m0TVHqFJMNeXdNuTc94KiDbE+cvw8jtAY9NC/OIM4HcgjAIQ== </del> <ins> xterm-addon-canvas@0.4.0-beta.11: version "0.4.0-beta.11" resolved "https://registry.yarnpkg.com/xterm-addon-canvas/-/xterm-addon-canvas-0.4.0-beta.11.tgz#d627050d7e2290ae804c0ec730d5bfc5861afd78" integrity sha512-yfkx0R7wB3L+fWf1doDmEfwYIeNMVq4uXlq7sCvfPQAVA2H4eOH/s+SS1mhyy0A6DDEbM4eEQ7CroRZIsnVtMA== </ins> xterm-addon-search@0.11.0: version "0.11.0"

Related discussion:
text: Does this issue occur when all extensions are disabled?: Yes VS Code Version: OS Version: Steps to Reproduce: a terminal window within vscode and run this command: vscode hangs indefinitely, using 100% CPU on one core. It would be nice if that didn't happen.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.78.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
I'm using web version (Vscode Server) and this code snippet cause the entirely browser tab to crash: ! Wanted to provide profiling info but profiler hanged too
I can reproduce
Nice find
Upstream:
Code change:
private readonly _dropdownMenu: IMenu; private readonly _singleTabMenu: IMenu; private _viewShowing: IContextKey<boolean>; <ins> private _disposableStore = this._register(new DisposableStore()); </ins> constructor( options: IViewPaneOptions,

Related discussion:
text: I was trying to understand the usage of and the lifecycle of actions created while creating it. I think this originated with the terminal, so looked at the terminal code, but it seems like the problem isn't solved here either. instantiates some Actions which extend Disposable, but they are never tracked or disposed. The ActionViewItems returned from are apparently owned by whatever calls that and get disposed, but not these extra actions that we have to create. So, one solution would be for them to be owned and disposed by although that feels unexpected. But otherwise, there isn't a technically correct way for the code in to know when they should be disposed. Wondering whether I'm missing something or if you have any thoughts.
I spent some time investigating this and the issue is that we use in some places and in others. Only the latter is disposable. This would be a bit involved to rework
Code change:
restoreFocus = true; } <ins> let isExpanded = false; </ins> // Handle Rename if (oldParentResource && newParentResource && oldParentResource.toString() === newParentResource.toString()) { const modelElements = this.model.findAll(oldResource); modelElements.forEach(modelElement => { <ins> //Check if element is expanded isExpanded = this.explorerViewer.isExpanded(modelElement); </ins> // Rename File (Model) modelElement.rename(newElement);

Related discussion:
text: Issue Type: Bug folder ! VS Code version: Code - Insiders 1.21.0-insider (, 2018-02-21T09:22:14.399Z) OS version: Windows_NT x64 10.0. Reproduces without extensions <!-- generated by issue reporter --
Code pointer
does it mean that this is the expected behavior?
I m on it.
it is always debatable if something is a feature-request or a bug. I guess this is more of a bug, but I took the artistic freedom and assigned feature-request.
it does not seem to restore the full expansion state, only the first level is that true?
yes, only the first level. could improve the PR and try to restore more.
Yes, i can do that.
great, tree should have api to get the exapnsion state. And once the pr is ready just ping me on it.
Should i make a new method to return all the expanded children as array on treeModel?
Is this ready for verification?
ben already verified and can add a verified label. There are some limitation which will tackle in a pr for next milestone
Code change:
} private _renderMessages(anchor: HoverAnchor, messages: IHoverPart[]): void { <del> // update column from which to show let renderColumn = Constants.MAX_SAFE_SMALL_INTEGER; let highlightRange: Range = messages[0].range; let forceShowAtRange: Range | null = null; for (const msg of messages) { renderColumn = Math.min(renderColumn, msg.range.startColumn); highlightRange = Range.plusRange(highlightRange, msg.range); if (msg.forceShowAtRange) { forceShowAtRange = msg.range; } } </del> <ins> const { showAtPosition, showAtRange, highlightRange } = ContentHoverController.computeHoverRanges(anchor.range, messages); </ins> const disposables = new DisposableStore(); const statusBar = disposables.add(new EditorHoverStatusBar(this._keybindingService));

Related discussion:
text: ! I see this sometimes, but it often gets fixed if I try again, or close and reopen the editor, etc. Right now it keeps happening and it's just impossible to click the hover. I don't know how this API works but I assume this is on vscode's side. Happy to set breakpoints and debug
I couldn't reproduce this so I'm not sure what's the root problem. However, I'm saving here a patch which simulates a hover very similar to the one in the gif: <img width="1141" alt="image" src="https://user-"diffn- editor.focusNotebookCell(newCell, newFocusMode, { focusEditorLine: 1 });n+ await editor.focusNotebookCell(newCell, newFocusMode, { focusEditorLine: 1 });n
I tried for quite a while but couldn't repro. I think there might be some settings that cause the issue reproduce. Does this reproduce when you comment out all your user settings?
Yeah, it reproes with all settings commented out
Thanks to via we could find a repro. Reproduces consistently when hovering at the end of the line: It turns out it has to do with the range the hover provider returns. If the hover provider returns a range that spans one line above the hover request, the hover will render one line above. If the hover provider returns a range that spans two lines above the hover request, the hover will render two lines above, etc. Here's a simplified patch: https://user-
To verify, use gitlens and hover over the end of the line at
Works great but raises the question, why does gitlens return a hover with a multiline range? And I get a highlight in this region, but it blinks and disappears on line 919, and on other lines, no highlight. !
PR to improve the highlight range at
I'm still seeing the original issue at
Code change:
override updateOptions(options: IWorkbenchTableOptionsUpdate): void { super.updateOptions(options); <del> this.updateStyles(options.overrideStyles); </del> <ins> if (options.overrideStyles !== undefined) { this.updateStyles(options.overrideStyles); } </ins> if (options.multipleSelectionSupport !== undefined) { this.listSupportsMultiSelect.set(!!options.multipleSelectionSupport);

Related discussion:
text: I opened the Settings editor, hovered over a setting, and noticed a new grey line appear to the left of the settings. This issue occurs with the default light and dark themes. !
I found that when calling , if we don't pass in the style override anymore, it will be reset to default I put this fix for notebook but I wonder if it's unexpected
Thanks for figuring that out. We shouldn't update options that are not set, that a regression. I fixed that with and updated your code to back what it was. Is different, it's about the indent guides which were disabled previously by not providing any colors. With my change we complete your colors with the default colors, which IMO is the right thing to do. is a simple fix. But I think we should not use the colors for that but the already existing option. I'm working on a follow up PR, but that needs to be reviewed by who is out today.
Code change:
if (getVirtualWorkspaceLocation(this.contextService.getWorkspace()) !== undefined && isNative) { items.push(new ContinueEditSessionItem( <del> localize('continueEditSessionItem.openInLocalFolder', 'Open In Local Folder'), </del> <ins> '$(folder) ' + localize('continueEditSessionItem.openInLocalFolder.v2', 'Open in Local Folder'), </ins> openLocalFolderCommand.id, <ins> localize('continueEditSessionItem.builtin', 'Built-in') </ins> )); }

Related discussion:
text: ! should align more with <img width="672" alt="image" src="https://user-"