jiebi/CodeConvo huggingface dataset:
Code change:
}; } async function main(arch = process.arch) { <del> const version = product.electronRepository ? '22.5.3' : util.getElectronVersion(); </del> <ins> const version = product.electronRepository ? '22.5.4' : util.getElectronVersion(); </ins> const electronPath = path.join(root, '.build', 'electron'); const versionFile = path.join(electronPath, 'version'); const isUpToDate = fs.existsSync(versionFile) && fs.readFileSync(versionFile, 'utf8') === `${version}`;

Related discussion:
text: I am still getting this error while using the extension !
can you give more details, did you configure the setting accordingly?
!
Are we certain this is related to UNC paths? Whats the extension repository, maybe reach out to them as well?
I am on this issue thread from , that points me to then to this one. Repo is See that someone pointed a cucumber issue here: It's a bit confusing honestly.
I see no UNC mentioned in any of these issues, so I consider it unrelated.
, you have a example from this configuration ??
Code change:
} public run(accessor: ServicesAccessor, editor: ICodeEditor, args: any): void { <ins> const useLogicalLine = (args && args.logicalLine === true); </ins> const cursors = editor._getCursors(); const context = cursors.context;

Related discussion:
text: VSCode Version: 0.10.11 OS Version: OS X 10.10.5 Steps to Reproduce: a long line of text that wraps in the editor the cursor on the first line and press Cmd-Option-Down (on OS X). This creates a second cursor on the next visual line, which means it is somewhere on the same logical line depending on how the text is wrapped. When creating multiple cursors on adjacent lines, often it is to perform the same edit on multiple (logical) lines that are aligned with each other. The current behavior having the second cursor appear instead at some situation-specific place on the same logical line throws a wrench in this workflow. I can't think of a good situation where it makes sense (though I do realize it is consistent with pressing the down arrow without cmd-option) Definitions: a logical line is a line in the file on disk. A visual line is a line in the editor. A logical line may span multiple visual lines when there is wrapping.
Code change:
"textCodeBlock.background": "#2B2B2B", "textLink.activeForeground": "#4daafc", "textLink.foreground": "#4daafc", <del> "textPreformat.foreground": "#D0D0D0", </del> <ins> "textPreformat.foreground": "#D7BA7D", </ins> "textPreformat.background": "#3C3C3C", "textSeparator.foreground": "#21262D", "titleBar.activeBackground": "#181818",

Related discussion:
text: Expected ! Actual !
Regressed in
The markdown preview in the chat is also broken for Dark Modern but is fixed by your change: !
And the markdown preview in the settings editor: !
I looked into this some more and have the following findings block rendering is broken for Dark Modern, Light Modern, Dark HC and Light HC What changed: we a new theme token, , adopted it in and , and updated the values for to look good with a different background color But we didn't adopt token for blocks in Markdown previews, which is why is broken for Markdown preview Some options Adopt for blocks in Markdown preview -- this amounts to a rather drastic styling change for Markdown previews ! Revert Revert the change to and drop the usage of so that Markdown preview, chat, and settings UI are in a reasonable state for all themes, which I attempted in
Also affects the Extensions Details page since it is a Markdown preview !
Verification: for Light/Dark Modern and Light/Dark HC, make sure that blocks are properly rendered in Markdown preview, settings UI and chat
Code change:
} } <del> const didCompression = compressStreamBuffer(buffers); const data = formatStreamText(VSBuffer.concat(buffers.map(buffer => VSBuffer.wrap(buffer)))); </del> <ins> let didCompression = compressStreamBuffer(buffers); const concatenated = VSBuffer.concat(buffers.map(buffer => VSBuffer.wrap(buffer))); const data = formatStreamText(concatenated); didCompression = didCompression || data.byteLength !== concatenated.byteLength; </ins> return { data, didCompression }; }

Related discussion:
text: a cell that updates the same line of output continuously :bug: extra character appended at the end and the last update doesn't seem to occur !
Code change:
'use strict'; <del> import { CompletionItemProvider, CompletionItem, CompletionItemKind, CancellationToken, TextDocument, Position, Range, TextEdit } from 'vscode'; </del> <ins> import { CompletionItemProvider, CompletionItem, CompletionItemKind, CancellationToken, TextDocument, Position, Range, TextEdit, workspace } from 'vscode'; </ins> import phpGlobals = require('./phpGlobals'); export default class PHPCompletionItemProvider implements CompletionItemProvider {

Related discussion:
text: There is now a better Intellisense plugins for Vscode PHP: and . In it's known issues it says "There may be duplicate suggestions for functions or variables. This is because VS Code has it's own (very limited) code-completion support for PHP, and there is currently no way to turn this off." This indeed is annoying, the vscode suggestions are too broad and are just noise compared to accurate entries by crane.
It should be possible to uninstall the VS Code php extension.
fyi
I think crane still uses vscode's syntax highlighter for PHP. So if one were to remove VSCode's internal PHP extension, would it also remove the syntax highlighter? P.S. I think simple options would suffice, e.g. "", so it could be turned off.
Yes - but we can also think about splitting our extension into one part that does highlighting and bracket config and another that does completions. That would allow for more freedom.
This is now annoying the testing of proper language server in here : Quote: P.S. I think the option would be a simplest thing to implement for now.
Related
Any update on this?
I have been holding back the PHP IntelliSense release with intelligent completion for over a month now because it is useless if VS Code just spams the completion list with countless functions that do not make sense in the context. When will we get the option to disable or uninstall the built-in PHP completion?
I agree it makes sense to provide a temporary option to disable this. Just submitted a PR here:
Also just checking - at this point in time, is there anything else about the built-in support that is interfering with the experience? (hover, signature help, etc.?)
thanks for looking into this. Signature help is being implemented right now, iirc there is no built-in hover. It would be great if all of them could be disabled (everything except syntax highlighting).
I pushed the PR and changes the setting name for the code completion to "". If disabled, hover and signature help are also disabled.
I don't think the setting achieves the desired result. Setting to I no longer get completion suggestions even from PHP Intellisense extension. If have to use to trigger the completion suggestions list.
I don't think this is related, this only removes the built-in completion provider.
Code change:
'use strict'; <del> import { CompletionItemProvider, CompletionItem, CompletionItemKind, CancellationToken, TextDocument, Position, Range, TextEdit } from 'vscode'; </del> <ins> import { CompletionItemProvider, CompletionItem, CompletionItemKind, CancellationToken, TextDocument, Position, Range, TextEdit, workspace } from 'vscode'; </ins> import phpGlobals = require('./phpGlobals'); export default class PHPCompletionItemProvider implements CompletionItemProvider {

Related discussion:
text: So something else which controls the display of suggestions list from extensions like php intellisense is broken?
Part of the January build. Add to your settings to disable all completions from the built-in PHP extension.
Code change:
SymbolInformation, SymbolKind, CompletionItem, Location, SignatureHelp, SignatureInformation, ParameterInformation, Definition, TextEdit, TextDocument, Diagnostic, DiagnosticSeverity, Range, CompletionItemKind, Hover, MarkedString, DocumentHighlight, DocumentHighlightKind, CompletionList, Position, FormattingOptions, FoldingRange, FoldingRangeKind, SelectionRange, <del> LanguageMode, Settings, SemanticTokenData </del> <ins> LanguageMode, Settings, SemanticTokenData, Workspace </ins> } from './languageModes'; import { getWordAtText, startsWith, isWhitespaceOnly, repeat } from '../utils/strings'; import { HTMLDocumentRegions } from './embeddedSupport';

Related discussion:
text: <!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.43.0 OS Version: n/a I have the set to in my settings: Given a Does not produce any warnings as expected. However in : The linter says
This has the same root cause as : script are owned by the html extension instead of by the JavaScript extension. Fixing that is difficult However we could have a small fix that just makes html understand the setting. Marking this as help-wanted
Hello I'd like to try my hands on fixing this issue. Can you give some pointers as to which files are good places to start?
This change will need to be made in the HTML extension Here's where we configure TypeScript for the html extension: You should: Pass the value for in with the initial configuration Make sure that the language service updates its value for when the VS Code setting changes
Is there another way to get the setting value other than vscode.workspace.getConfiguration()? The 'vscode' module cannot be found when I try to import it into javascriptMode. I think 'vscode' would have to be as a dependency in in order to import 'vscode'.
Right now I'm passing in a default 'false' for experimentalDecorators in the initial configuration and passing the settings into getJavascriptMode.doValidation to update compilerOptions and calling ts.createLanguageService(host) every time doValidation is invoked. It has the expected behavior, but is there a better way to update the compiler options without creating the service every time it runs validation?
Is called when the file is changed? If it is, try updating the object that it returns
I am reproducing this error now with the following code: I realize this is known, but I will add the mention with respect to . Here is the relevant docs page, if a person wanted to make a unit test using If anyone finds this in the future, if is set in , it should suppress this error. Additionally, both and files, in the root of the project, take precedence over that setting.
Code change:
<del> <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16"><defs><style>.icon-canvas-transparent,.icon-vs-out{fill:#f6f6f6;}.icon-canvas-transparent{opacity:0;}.icon-vs-action-green{fill:#388a34;}</style></defs><title>restart</title><g id="canvas"><path class="icon-canvas-transparent" d="M16,0V16H0V0Z"/></g><g id="outline" style="display: none;"><path class="icon-vs-out" d="M8.5,1A7.5,7.5,0,0,0,4,2.527V1H0V9H3.068l-2.057.583.272.962A7.5,7.5,0,1,0,8.5,1Zm0,11A3.515,3.515,0,0,1,5.131,9.455L5,9H8V5.036A3.6,3.6,0,0,1,8.5,5a3.5,3.5,0,0,1,0,7Z"/></g><g id="iconBg"><path class="icon-vs-action-green" d="M15,8.5A6.5,6.5,0,0,1,2.245,10.272l1.924-.544A4.509,4.509,0,1,0,4.764,6H7V8H1V2H3V5.07A6.486,6.486,0,0,1,15,8.5Z"/></g></svg> </del>  No newline at end of file <ins> <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16"><style>.st0{fill:#f6f6f6;fill-opacity:0}.st1{display:none}.st2{display:inline;fill:#f6f6f6}.st3{fill:#388a34}</style><title>restart</title><path class="st0" d="M16 0v16H0V0h16z" id="canvas"/><g id="outline" class="st1" style="display: none;"><path class="st2" d="M8.5 1C6.9 1 5.3 1.5 4 2.5V1H0v8h3.1L1 9.6l.3 1c1.1 4 5.3 6.3 9.3 5.2s6.3-5.3 5.2-9.3C14.8 3.2 11.9 1 8.5 1zm0 11c-1.6 0-2.9-1-3.4-2.5L5 9h3V5h.5C10.4 5 12 6.6 12 8.5S10.4 12 8.5 12z"/></g><path class="st3" d="M15 8c0 3.6-2.9 6.5-6.5 6.5-2.9 0-5.5-1.9-6.3-4.7l1.9-.5c.7 2.4 3.2 3.8 5.6 3.1 2.4-.7 3.8-3.2 3.1-5.6S9.7 3 7.3 3.7c-1 .3-1.9.9-2.5 1.8H7v2H1v-6h2v3.1c1.9-3 5.9-4 8.9-2.1C13.8 3.7 15 5.7 15 8z" id="iconBg"/></svg> </ins>  No newline at end of file

Related discussion:
text: !
when we triage issues assigned to ourselves we usually use the milestone, anything that will be fixed in this milestone we put to june. Appart from that adding the bug label is usually good so this issue gets verified in the endgame (since it is june and bug). Assigning issues to other team members we usually leave with no label and milestone so the owner can triage and assign it. Cheers
thanks, I'll make sure and mark them appropriately next time!
Code change:
"@iktakahiro/markdown-it-katex@mjbvz/markdown-it-katex": version "4.0.3" <del> resolved "https://codeload.github.com/mjbvz/markdown-it-katex/tar.gz/17509eaeb7d48887d62ca02eb5eee9e6372b80ac" </del> <ins> resolved "https://codeload.github.com/mjbvz/markdown-it-katex/tar.gz/58f6637b5883caa8a811f1736bc90b34cd26b395" </ins> dependencies: katex "^0.16.2"

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.62.2 OS Version: Windows 8.1 Steps to Reproduce: a markdown file with the following content: Open a Preview to the side Rendering/Parsing of line 5 goes wrong Parsing of line 6 gives the: I have line 3 and 4 to determine what causes the problem, it is the literal text at the end of line 5: Any literal text (single backtick) of the content: generates the error If there is a tag on a line, any literal text (single backtick) after that is not recognized by the syntax highlighting in the editor
I have just updated the extension that has this piece of Markdown in the README. Github, Marketplace and Extension Bar all render the markdown correct.
I recommend that you disable the built-in , because it turns the Markdown inside VS Code to a flavor much different from GFM that you apparently don't want. The Markdown Math was introduced in . Besides, if you install some VS Code extensions that offer math support someday, you will need to check their documentation to disable the corresponding features. The rendering did not go wrong, to my knowledge. You just discovered the dark side of Markdown. Markdown is not a single rigorous language, but a collection of various flavors (aka "dialect", "variant") that disagree with each other. Let's take a glance at its history first, though there should already be more detailed articles on the Internet. created in 2004. It's the origin of Markdown, and unfortunately ambiguous. Soon, flavors bloomed.
Code change:
"@iktakahiro/markdown-it-katex@mjbvz/markdown-it-katex": version "4.0.3" <del> resolved "https://codeload.github.com/mjbvz/markdown-it-katex/tar.gz/17509eaeb7d48887d62ca02eb5eee9e6372b80ac" </del> <ins> resolved "https://codeload.github.com/mjbvz/markdown-it-katex/tar.gz/58f6637b5883caa8a811f1736bc90b34cd26b395" </ins> dependencies: katex "^0.16.2"

Related discussion:
text: Many years later, a group led by began to develop . The new spec has become the basis of many flavors in recent years. Among these derivatives, the current , , is the one that you're familiar with. Interestingly, a number of Markdown implementations adopt GFM and modify its extensions to create new flavors, for example, . I don't know the very flavor that VS Code's Markdown Math tries to follow, but it ( and . Please correct me. Now we can see that lots of Markdown flavors are technically incompatible. Thus, it's a pity that Markdown users have to configure their processors to get desired results. Here, in VS Code, the built-in ships a GFM-like environment. You can to get a more GFM-like experience as long as you're careful.
Minimal example that demonstrates the issue:
Marking as a good first issue since this should be a fairly scoped bug Here's the relevant repository where this issue should be fixed: The repo includes tests that you can use to confirm the issue is fixed and also check for regressions
I am looking to fix this by not allowing a dangling dollar symbol inside a markdown block to open or close. Do you think I'm on the right path?
I still do not regard the behavior here as a bug. Things just work this way as per the inline parsing strategy of CommonMark. From a CommonMark-compliant parser's view, we can say in a non-normative way that is equivalent to Then, given the enabled rules ( default, CommonMark HTML, pandoc-style math, and something else), it's recognized as This is correct and exactly reflects the philosophy of CommonMark. This issue ought to be marked as flavors are not compatible, . A derivative flavor can inherit the philosophy of its parent, but cannot retain the semantics. In other words, you cannot enable a math plugin and expect GFM-like rendering at the same time. You can only discuss right or wrong within the same flavor. If you want GFM-like rendering, disable the built-in Markdown Math () extension first.
But how do I write in Markdown Math a line that shows me Is there a way to Escape the
Avoid plain HTML-like pieces in Markdown. Use proper syntax whenever possible. In Markdown, HTML-like pieces (leaf block "HTML block" and inline structure "Raw HTML") are nothing, but just a kind of literal content.
Code change:
"@iktakahiro/markdown-it-katex@mjbvz/markdown-it-katex": version "4.0.3" <del> resolved "https://codeload.github.com/mjbvz/markdown-it-katex/tar.gz/17509eaeb7d48887d62ca02eb5eee9e6372b80ac" </del> <ins> resolved "https://codeload.github.com/mjbvz/markdown-it-katex/tar.gz/58f6637b5883caa8a811f1736bc90b34cd26b395" </ins> dependencies: katex "^0.16.2"

Related discussion:
text: CommonMark requires implementations to skip them: There are roughly 7 + 6 rules for recognizing HTML-like pieces; HTML-like pieces are captured, and then emitted as-is to the output, without further touching parser's machine state. This design is a compromise for compatibility, and causes usability and security issues, like your cases. jgm complained about the terrible fact many years ago. As for escaping, if your use case is presenting a character in textual content, you can try "backslash escape" like , and "entity and character reference" like and .
Maybe the wrong example asked, the OP was about some italic (or bold) text inside a code block, it was done with <codefoo<embar</emfoo</codeand when you use a character outside backticks and further down on the line a it goes wrong. I did not know Markdown allowed HTML entities. I have now enabled Markdown Math and replaced all characters inside with and now there is no
Excuse me? I'm confused now. So, you add these dangerous pieces to your Markdown document for formatting? Unfortunately, CommonMark Markdown is not a superset of WHATWG HTML. They actually have almost no intersection, and apply nearly opposite handling when encountering pieces that look like HTML tags. If you decide to have HTML-like things in a Markdown document, you have to be careful, and know how to lead the parser to your desired result. I thought I've made these basic facts clear. But seems no. No one understands my comments above. Before I come up with another way to explain, we can demonstrate something by this sample: If it's treated as HTML, there is one element with a comment and a text node "" inside. However, if you feed it to a CommonMark-compliant renderer, you'll get somewhat illegal HTML output:
If they are so dangerous why do they allow HTML tags in CommonMark Markdown? As soon as you use single or triple backtick all inside is treated as literal, there is AFAIK no way to make something inside italic (or bold) using Markdown syntax. I use HTML tags to get the required rendered output.
Good to know. Then, you only need to be careful when configuring Markdown renderer and authoring Markdown documents. This is for not only performance but also conformance. Avoid using inappropriate parsers, as flavors may hold dramatically different logic.
Code change:
"@iktakahiro/markdown-it-katex@mjbvz/markdown-it-katex": version "4.0.3" <del> resolved "https://codeload.github.com/mjbvz/markdown-it-katex/tar.gz/17509eaeb7d48887d62ca02eb5eee9e6372b80ac" </del> <ins> resolved "https://codeload.github.com/mjbvz/markdown-it-katex/tar.gz/58f6637b5883caa8a811f1736bc90b34cd26b395" </ins> dependencies: katex "^0.16.2"

Related discussion:
text: For example, , , and can give mostly different results for the same input. The Markdown flavor of GitHub is GFM. GitHub processes user content with , and then pipes the HTML output through some "filters" to add GitHub-specific features, such as sanitization, heading anchors, emoji codes, issue references, and diagrams. , VS Code's provides default + , which is a few steps away from GitHub. Basically, you just need to install extensions for emoji and task list, and disable those that don't exist on GitHub (e.g. ). Additionally, since VS Code and GitHub generate heading ID with slightly different methods, a link to heading might work on one and break on the other. It's John Gruber, , that introduced "HTML" (but not real HTML). The world has no choice but to live with it. If you ask me to judge Gruber's decision, I'd say the "HTML" in Markdown is a sign of laziness, besides, thousands of collective developer hours have been wasted due to tons of lazy and ambiguous design of the original Markdown. He should have defined generic construct syntax first, and built language structures on top of it. Probably I'm bad at teaching. But other people have good skill in communication. I recommend their articles: