jiebi/CodeConvo huggingface dataset:
Code change:
} async function main(arch = process.arch): Promise<void> { <del> const version = product.electronRepository ? '22.4.5' : util.getElectronVersion(); </del> <ins> const version = product.electronRepository ? '22.4.6' : util.getElectronVersion(); </ins> const electronPath = path.join(root, '.build', 'electron'); const versionFile = path.join(electronPath, 'version'); const isUpToDate = fs.existsSync(versionFile) && fs.readFileSync(versionFile, 'utf8') === `${version}`;

Related discussion:
text: This works on web e.g. but does not work in desktop, either with a desktop git clone or with RemoteHub. The last time this happened it was due to a regression in the list of enabled codecs for our Electron builds.
Sorry for the breakage, the changes from has not been to Electron = 22 versions yet. It will be addressed in new builds this week.
Addressed in
Reopening because of
Code change:
})); } <ins> private _updateCommandExecutedListener(): void { if (!this._instance.capabilities.has(TerminalCapability.CommandDetection)) { return; } if (!this._configurationService.getValue(TerminalSettingId.AccessibleViewFocusOnCommandExecution)) { this._onCommandExecutedShowListener.clear(); return; } else if (this._onCommandExecutedShowListener.value) { return; } const capability = this._instance.capabilities.get(TerminalCapability.CommandDetection)!; this._onCommandExecutedShowListener.value = this._register(capability.onCommandExecuted(() => { if (this._instance.hasFocus) { this.show(); } })); } </ins> private _isTerminalAccessibleViewOpen(): boolean { return accessibleViewCurrentProviderId.getValue(this._contextKeyService) === AccessibleViewProviderId.Terminal; }

Related discussion:
text: Type: <bFeature Request</bCC Please consider auto-activiating accessible view in terminal when user hit enter key. In most cases, screen reader users want to open accessible view after executing command in terminal. Thus, pressing Enter key can do: the current command to terminal. Accessible View immediately. Rather than having this as the default mode, we could consider adding this as a custom user setting. VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-02T09:02:24.464Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
This makes sense. let us know if you have any thoughts.
I imagine this mode can boost user productivity because VSCode now sends user typing in Accessible View directly to the active terminal. If this mode is , users will experience more seamless round trip between terminal input and accessible view without having to press Alt+F2 and ESC.
To verify, enable . Run a command in the terminal. The accessible view should open.
Code change:
private readonly _onChanged = this._register(new vscode.EventEmitter<{ readonly resource: vscode.Uri, readonly line: number }>()); public readonly onDidChanged = this._onChanged.event; <del> public setPreviousEditorLine(scrollLocation: LastScrollLocation): void { this.previousEditorInfo.set(scrollLocation.uri.toString(), scrollLocation); </del> <ins> public setPreviousStaticEditorLine(scrollLocation: LastScrollLocation): void { this.previousStaticEditorInfo.set(scrollLocation.uri.toString(), scrollLocation); </ins> } <del> public getPreviousEditorLineByUri(resource: vscode.Uri): number | undefined { const scrollLoc = this.previousEditorInfo.get(resource.toString()); </del> <ins> public getPreviousStaticEditorLineByUri(resource: vscode.Uri): number | undefined { const scrollLoc = this.previousStaticEditorInfo.get(resource.toString()); this.previousStaticEditorInfo.delete(resource.toString()); return scrollLoc?.line; } public setPreviousTextEditorLine(scrollLocation: LastScrollLocation): void { this.previousTextEditorInfo.set(scrollLocation.uri.toString(), scrollLocation); } public getPreviousTextEditorLineByUri(resource: vscode.Uri): number | undefined { const scrollLoc = this.previousTextEditorInfo.get(resource.toString()); this.previousTextEditorInfo.delete(resource.toString()); </ins> return scrollLoc?.line; }

Related discussion:
text: Issue Type: <bBug</bI have been using for a long time. Currently I end up with a LOT of inadvertant selections when working in two side-by-side editor groups and switching back and forth between them using the mouse. The reason is that the editor scrolls 5 lines every time I click into it. VS Code version: Code - Insiders 1.58.0-insider (, 2021-06-11T05:22:19.992Z) OS version: Darwin arm64 20.5.0 Restricted Mode: No Remote OS version: Linux x64 5.4.0-1046-azure <!-- generated by issue reporter --
I cannot reproduce. Does this reproduce for you when disabling all extensions? (The editor exposes a API to extensions). I have recently also got which seems incredibly similar, but I am having a hard time reproducing any of the jumping that is described. Here I am trying two side-by-side editor groups: https://user-
This reproduces only when the language mode of the files are set to markdown. I think this has to do with how the markdown extension is using the vscode API. But I think it should not use that API at all if no markdown preview is rendered. But it would also be interesting to test what the experience is when the preview is rendered. Given this doesn't reproduce with txt files, I'm optimistically giving this to you. Steps to reproduce: define open two md files side-by-side (preferably without word wrapping to see the top line number change) click on the editor tab of each one on every click, the editor scrolls up by 5 lines https://user-
Could you please take a look at this since you were looking into markdown syncing last iteration?
It seems like it's a bug coming from the scroll syncing between the static and text editor changes that I made a while ago. I'll try to make a PR to fix this soon.
Code change:
assertSelections(editor, new Selection(1, 4, 1, 4), new Selection(2, 8, 2, 8)); assertContextKeys(contextKeys, true, false, true); <del> // ctrl.next(); // assertSelections(editor, new Selection(1, 7, 1, 7), new Selection(2, 11, 2, 11)); // assertContextKeys(contextKeys, true, true, true); </del> <ins> ctrl.next(); assertSelections(editor, new Selection(1, 7, 1, 7), new Selection(2, 11, 2, 11)); assertContextKeys(contextKeys, true, true, true); </ins> ctrl.next(); assertSelections(editor, new Selection(1, 7, 1, 7), new Selection(2, 11, 2, 11));

Related discussion:
text: <!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.33.1 OS Version: Windows_NT x64 10.0. Steps to Reproduce: a new user snippet file for the project. The one I encounter the issue with is: the snippet and attempt to press TAB after writing the first variable cursor does not move to the next stop, instead a tab character is The desired behavior would be for the cursor to move to the next tab stop. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Seems to work just fine for me... Any special keybinding or setting? !
The action you took is not the problem I encounter and does indeed work the same way for me. Could you try to edit "SystemName", the first tab stop, then press TAB to go to "Required Components"? vsCode just inserts a tab character after whatever I wrote instead of going to the next tab stop.
Ok, thanks for clarifying. For some reason snippet mode stops when making that edit... Not sure why
I have encountered similar issue, however, I could add a single blank space in the snippet which "fixed" the tab navigation. Also, my example is far simpler. See
This is a regression from I will revert that change and re-open the corresponding issue (which is much more rare than these issues)
Thank you for fixing this, looking forward to the next release.
Code change:
endLineNumber: editorSelection.endLineNumber, endColumn: editorSelection.endColumn } : { startLineNumber: 0, endLineNumber: 0, endColumn: 0, startColumn: 0 }; <del> const focusTracker = this._register(dom.trackFocus(this.body)); </del> <ins> const focusTracker = this._register(dom.trackFocus(this._body)); </ins> this._register(focusTracker.onDidBlur(_ => { this.hide(); }));

Related discussion:
text: Depending oh how many editors windows are open and the size of them, sometimes the standalone color picker is partially hidden behind other editor panel. vscode version:1.81.0 x64 !
Code change:
endLineNumber: editorSelection.endLineNumber, endColumn: editorSelection.endColumn } : { startLineNumber: 0, endLineNumber: 0, endColumn: 0, startColumn: 0 }; <del> const focusTracker = this._register(dom.trackFocus(this.body)); </del> <ins> const focusTracker = this._register(dom.trackFocus(this._body)); </ins> this._register(focusTracker.onDidBlur(_ => { this.hide(); }));

Related discussion:
text: There is a z-index error: <img width="572" alt="Screenshot 2023-07-25 at 13 56 59" src=""
Code change:
@IKeybindingService private readonly _keybindingService: IKeybindingService, @IContextKeyService private readonly _contextKeyService: IContextKeyService, @ICommandService private readonly _commandService: ICommandService, <del> @IAccessibilityService private readonly _accessibilityService: IAccessibilityService </del> <ins> @IAccessibilityService private readonly _accessibilityService: IAccessibilityService, @IConfigurationService private readonly _configurationService: IConfigurationService </ins> ) { super(); this._hasShellIntegration = _xterm.shellIntegration.status === ShellIntegrationStatus.VSCode;

Related discussion:
text: Type: <bFeature Request</bCC Please consider auto-activiating accessible view in terminal when user hit enter key. In most cases, screen reader users want to open accessible view after executing command in terminal. Thus, pressing Enter key can do: the current command to terminal. Accessible View immediately. Rather than having this as the default mode, we could consider adding this as a custom user setting. VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-02T09:02:24.464Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
This makes sense. let us know if you have any thoughts.
I imagine this mode can boost user productivity because VSCode now sends user typing in Accessible View directly to the active terminal. If this mode is , users will experience more seamless round trip between terminal input and accessible view without having to press Alt+F2 and ESC.
To verify, enable . Run a command in the terminal. The accessible view should open.
Code change:
matches.forEach(match => { match.matches.forEach((singleMatch, index) => { <del> if ((singleMatch as OutputFindMatch).index !== undefined) { </del> <ins> if ((singleMatch as OutputFindMatch).index === undefined) { </ins> textEdits.push({ edit: { range: (singleMatch as FindMatch).range, text: texts[index] }, resource: match.cell.uri

Related discussion:
text: ! VS Code Version: Version: 1.64.1 Commit: Date: 2022-02-07T17:17:47.733Z Electron: 13.5.2 Chromium: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Linux x64 5.13.0-28-generic OS Version: Ubuntu 20.04 Steps to Reproduce: a Jupyter notebook, just do Ctrl+H and put some strings in find and replace boxes.
Hi - Apology to bother. Is there any update on this issue or any work-around that I can do. Because without the replace-all functionality, it's becoming very hard to manage long notebooks in VSCode.
Just realized this is a regression from previously stable.
NOT Resolved in the latest stable version of code.
Not working on the latest Insiders Version: 1.66.0-insider (user setup) Commit: Date: 2022-03-29T07:31:54.286Z Electron: 17.2.0 Chromium: 98.0.4758.109 16.13.0 V8: 9.8.177.11-electron.0 OS: Windows_NT x64 10.0.
After updating to version 1.66.0 - I get the "Replace All" button activated (as in not grayed-out any more) - But it does NOT work. i.e. after clicking on the button naothing happens.
Hi, this is still not resolved after today's release to Version: 1.67.1 Below my current version details.
can you try again on VS Code Insiders? Otherwise, you'll have to wait for version 1.68.
Great its working in the Insider version. Thanks.
Code change:
} return this.addExtensionToWorkspaceFolderConfig(configurationFile, extensionId, shouldRecommend).then(() => { <del> this.notificationService.info(localize('AddToWorkspaceFolderIgnoredRecommendations.success', 'The extension was successfully added to this workspace folder's unwanted recommendations.')); </del> <ins> this.notificationService.prompt(Severity.Info, localize('AddToWorkspaceFolderIgnoredRecommendations.success', 'The extension was successfully added to this workspace folder's unwanted recommendations.'), [{ label: localize('viewChanges', "View Changes"), run: () => this.openExtensionsFile(configurationFile) }]); </ins> }, err => { this.notificationService.error(localize('AddToWorkspaceFolderRecommendations.failure', 'Failed to write to extensions.json. {0}', err)); });

Related discussion:
text: testing It would be nice to have a link on this prompt to open the workspace . that way i can see what was done. !
Link in the text mostly is not possible, as that works only for actual links. We might have to add a button that says which opens the file that was edited.
Code change:
if (result.confirmed) { await this.hostService.reload(); } <del> return; </del> <ins> } else { await this.extensionService.startExtensionHosts(); </ins> } <del> this.extensionService.stopExtensionHosts(); await this.userDataProfileService.updateCurrentProfile(profile, preserveData); await this.extensionService.startExtensionHosts(); </del> } }

Related discussion:
text: Type: <bBug</bDev Container with default or the prefered profile a new profile from Current Profile Settings After reloading the window you get a message to install the remote containers extension and when opening the profile in a local workspace you can see that no extensions and no settings where copied from the old profile. VS Code version: Code - Insiders 1.70.0-insider (, 2022-07-08T05:20:13.606Z) OS version: WindowsNT x64 10.0. Modes: Restricted Connection to 'vscode-remote' could not be established No remote extension installed to resolve dev-container. <details<summarySystem Info</summary Connection to 'vscode-remote' could not be established No remote extension installed to resolve dev-container. </detailsExtensions: none <!-- generated by issue reporter --
Code change:
result.push(task); }); // always add npm install (without a problem matcher) <del> result.push(createTask('install', 'install', folder, packageJsonUri, undefined, [])); </del> <ins> result.push(createTask('install', 'install', folder, packageJsonUri, 'install dependencies from package', [])); </ins> return result; }

Related discussion:
text: Issue Type: <bBug</bTesting: Steps: a with one or more npm scripts a and add one or more npm tasks but do not add a details field to each task the run tasks command that the npm scripts in have a details field shown but the npm task in does not Expected: All npm tasks/scripts to be rendered consistently. The npm task in should show the script as the detail field just like the ones in ! VS Code version: Code - Insiders 1.40.0-insider (, 2019-10-30T05:39:27.063Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (12)</summaryExtensionVersion ------ tslint1.0.44 vscode-github-releases-updater0.18.0 vscode-docker0.8.1 python2019.10. remote-containers0.82.0 remote-ssh0.47.2 remote-ssh-edit0.47.2 remote-ssh-explorer0.47.2 remote-wsl0.40.0 vscode-remote-extensionpack0.17.0 azure-account0.8.6 test-search-rg0.0.3 </details<!-- generated by issue reporter --
which of the tasks listed in your screen shot are from the If it , you have npm task detection turned on, and the script is also in your then it should show a detail (except for npm:install).
The npm install task is the one in
Sorry, seemed to close the issue by mistake while trying to paste a snippet from { "type": "npm", "script": "install", "problemMatcher": [] }
And this is in "scripts": { "test": "echo "Error: no test specified" && exit 1", "random": "do something else" },
Thank you! There is no detail to provide for install since it's not running a script defined in to pull the detail from. I figured there wasn't a good detail to show for it, but I'm all for it having a detail if there's something relevant we can put there. Is there something in particular that you want to see as the detail for the install task?
I just thought it should do similar to the scripts in the and show the script field?
I see, so it should just show "install" as the detail.
Upcoming behavior: !
Code change:
} private _set(nodes: ITreeNode<T, any>[], silent: boolean, browserEvent?: UIEvent): void { <del> this.nodes = nodes.length > 1 && this.identityProvider ? distinct(nodes, node => this.identityProvider!.getId(node.element).toString()) : [...nodes]; </del> <ins> this.nodes = [...nodes]; </ins> this.elements = undefined; this._nodeSet = undefined;

Related discussion:
text: Hei! Found issue with folder delete operation. The point is, when you delete folder (first time), no matter how, via mouse or keyboard combination, then select another folder and try to delete it, you will get popup message saying "Cannot read property 'isDirectory' of undefined" Only when you select another folder again (second time), delete operation will be successful. Tried several times with same results. And as i remember, this bug i found some time ago, so it is not introduced exactly in last insiders build. Visual Code Insiders 1.41.0 from 2019-12-02, commit: macOS 10.15.1
thanks for filling this great issue. You should have the fix tommorrow in vscode insiders
the problem was that it was happening that the tree would sometimes set the trait on one element two times. In this particular case Selection would be set on the element A and A. So if I say tree.getSelection I would get the same item twice. Instead of the array with one item. I decided to fix this with a workaround on the trait level. Repro steps: set compact tree to true. Go up and down with the focus always ending up with the focus on the one select item. Put a conditional breakpoint tree will try to set the double selection trait
This seems to be coming from Where the selection would already contain the folder, but as oldSelection/oldFocus also has the id, it will push the same object to the selection again. You could also fix it there by doing some sort of duplicate filtering or selection.indexOf to prevent duplciates being I could reproduce it consistently by: Putting a breakpoint there Creating a new folder Focusing on that folder Result: The function ends up setting selection to contain the same object twice.
great pointer. I think you are right, give me a sec and I will push a better fix. Thanks a lot!
I was planning to submit something along the lines of But I'm not sure if this is considered good code, it might be better to create a set of Ids (like oldSelection) does, but as selection is of type T, I could not access the id parameter.
If you would like to create a PR you are more than welcome to! It would be great if you could do it today since we are wrapping up the milestone and we need this fix asap.
Code change:
} private _set(nodes: ITreeNode<T, any>[], silent: boolean, browserEvent?: UIEvent): void { <del> this.nodes = nodes.length > 1 && this.identityProvider ? distinct(nodes, node => this.identityProvider!.getId(node.element).toString()) : [...nodes]; </del> <ins> this.nodes = [...nodes]; </ins> this.elements = undefined; this._nodeSet = undefined;

Related discussion:
text: Just make sure to remove my wokraound introduced with Thanks! And make sure to ping me on the PR
Code change:
} .monaco-workbench .part.basepanel > .composite.title > .panel-switcher-container > .monaco-action-bar .action-item .active-item-indicator { <del> top: -6px; </del> <ins> top: -4px; </ins> left: 10px; width: calc(100% - 20px); } .monaco-workbench .part.basepanel > .composite.title > .panel-switcher-container > .monaco-action-bar .action-item.icon .active-item-indicator { <del> top: -1px; </del> <ins> top: 1px; </ins> left: 2px; width: calc(100% - 4px); }

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.0 OS Version: Windows 10 Steps to Reproduce: Please add some margin there, I've Provided img below and pointed out that place with red clr It's Just Sticking each other !
Sorry can you clarify what you mean?
As, You can see in the img I've pointed out a terminal place with red clr circle where Source Control is there and ahead of it 1 Badge is there. So, Then it's below line and the Badge does not have any space/margin they both are sticking.
I see space between the badge and the active indicator,
I think it's too small.
I think these changes when the panel padding got updated with the secondary side bar. Not sure what else we can do besides add the padding back. It is quite tight right now.
Should be fixed now thanks to <img width="127" src="https://user-"
Code change:
const styles = this.stylesForType(this.message.type); this.element.style.border = styles.border ? `1px solid ${styles.border}` : ''; <del> if (this.hasFocus() || force) { </del> <ins> if (this.message.content && (this.hasFocus() || force)) { </ins> this._showMessage(); } }

Related discussion:
text: Type: <bBug</ba file for which a DocumentSymbolProvider will return some items, for example on the filename in the breadcrumb, then type Ctrl/Cmd+F. The list filter widget looks OK, though it hides the first filename in the list ( ought to help with this once merged). the same but one item to the right in the breadcrumb. The filter widget is transparent. ! VS Code version: Code - Insiders 1.71.0-insider (, 2022-08-22T05:16:19.478Z) OS version: Windows_NT x64 10.0. Modes: Sandboxed: Yes <!-- generated by issue reporter --
/assign
Easier steps: <kbdCtrl F</kbdon an outline breadcrumb
I still see this. It looks like the background of the find widget gets removed, but the contents still scroll up out of the breadcrumbs widget
Did you test this in dev? Because we still didn't get an Insiders build with the fix.
Code change:
const styles = this.stylesForType(this.message.type); this.element.style.border = styles.border ? `1px solid ${styles.border}` : ''; <del> if (this.hasFocus() || force) { </del> <ins> if (this.message.content && (this.hasFocus() || force)) { </ins> this._showMessage(); } }

Related discussion:
text: Originally posted by in
This also happens if step 5 is omitted and Search mode is used. The problem seems to be that to put the 'No elements found.' warning message under the find-in-list's input widget a ContextView is created immediately below it. But when find is occurring in a breadcrumb list, that list is itself in a ContextView which gets hidden and cleared immediately before the one for the warning message is shown. The warning message appears in the top left of the VS Code window in a very narrow column. See below, where I open , click on the filename in the breadcrumb to get a list of sibling filenames, then type "z" which isn't present in any of the filenames. !