jiebi/CodeConvo huggingface dataset:
Code change:
const extension = await this.extensionService.getExtension(extensionId); if (!extension) { <del> await this.handleUnhandledURL(uri, { id: extensionId }); </del> <ins> await this.handleUnhandledURL(uri, { id: extensionId }, options); </ins> return true; }

Related discussion:
text: Open following url Install dialog is shown asking user to install and open extension <img width="275" alt="image" src="https://user-"- After clicking on install, following prompt is shown <img width="454" alt="image" src="https://user-"Second prompt seems to be unnecessary. It is expected to open the URL after installing
Code change:
if (NotebookEdit.isNotebookCellEdit(edit)) { if (edit.newCellMetadata) { this.replaceNotebookCellMetadata(uri, edit.range.start, edit.newCellMetadata); <ins> } else if (edit.newNotebookMetadata) { this.replaceNotebookMetadata(uri, edit.newNotebookMetadata); </ins> } else { this.replaceNotebookCells(uri, edit.range, edit.newCells); }

Related discussion:
text: create a notebook and save it. Run a cell with a kernel. Change the kernel and run another cell reopen the notebook as plain text and note the kernel spec in the metadata. metadata should specify the kernel that was most recently used, but it specifies the original. Seems to repro with both local and remote kernels
impacts microsoft/vscode-jupyter since we're not getting the correct suggestion
I think this is a regression. please could you verify this works as expected in stable.
yes, the kernelspec updates in stable as expected
This is actually a bug in the new metadata API. Transferring to vscode core.
This should've been assigned to since we are adamant in verifying each issue that gets shipped in a recovery release individually. I found this out by looking into . Please find someone to verify this issue in the latest release candidate build.
Oh my bad... this was released already in ... My mistake.
But there's still a recommendation: this should've been assigned to all along so people verify the issue was fixed. Can you find someone to verify and mark it as ?
I had actually verified back when it was fixed, just didn't add the label since it wasn't marked verification needed. I'll do that now tho
Thanks!
Code change:
"tab.unfocusedActiveBorder": "#f8f8f8", "tab.unfocusedActiveBorderTop": "#00000015", "tab.unfocusedHoverBackground": "#6e76811a", <ins> "terminalCursor.foreground": "#005FB8", </ins> "terminal.foreground": "#ffffffc5", "terminal.inactiveSelectionBackground": "#E5EBF1", "terminal.tab.activeBorder": "#005fb8",

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Windows 10 -- Ref: Steps to Reproduce: theme to new terminal cursor is white on a light background which is hard to see for most I'm about 99% sure this is not associated with any customized profile in use for PowerShell session. Starting with no profile shows the same thing. !
Code change:
arg = { forceNewWindow: arg }; } if (!uri) { <del> return executor.executeCommand('_files.pickFolderAndOpen', arg.forceNewWindow); </del> <ins> return executor.executeCommand('_files.pickFolderAndOpen', { forceNewWindow: arg.forceNewWindow }); </ins> } const options: IOpenSettings = { forceNewWindow: arg.forceNewWindow, noRecentEntry: arg.noRecentEntry }; uri = URI.revive(uri);

Related discussion:
text: VSCode Version: 1.34.0-insider (1.34.0-insider) OS Version: macOS mojave 10.14.4 Steps to Reproduce: in activate method of any extension. the developer tools. What is expected? Show the file dialog like following: ! What is actually happening? Following error message shown in the Developer tools. Does this issue occur when all extensions are disabled?: Yes According to the code here: , I think the reason is " is ", then I got as the of see here: If you confirm this is a bug, I'd like to create a pull request to fix it.
I think I find the commit which cause the bug, see: Here we transform the " and " to " and ", but the args that send is still , and because it send undefined in my case, I got as , then the error throws. Since I find the cause of this bug, I feel confident to create a pull request to fix it. : )
Yes, PR is welcome!
Code change:
id: 'inlineChat.quickVoice.start', title: localize2('start', "Start Inline Voice Chat"), category: AbstractInlineChatAction.category, <del> precondition: ContextKeyExpr.and(HasSpeechProvider, CTX_QUICK_CHAT_IN_PROGRESS.toNegated()), </del> <ins> precondition: ContextKeyExpr.and(HasSpeechProvider, CTX_QUICK_CHAT_IN_PROGRESS.toNegated(), EditorContextKeys.focus), </ins> f1: true, keybinding: { primary: KeyChord(KeyMod.CtrlCmd | KeyCode.KeyK, KeyCode.KeyI),

Related discussion:
text: empty profile open terminal, run or any other command that prints something press to clear the terminal :bug: the keyboard system is waiting for chord to be completed
Code change:
.quick-input-titlebar { display: flex; align-items: center; <ins> border-top-left-radius: 5px; /* match border radius of quick input widget */ border-top-right-radius: 5px; </ins> } .quick-input-left-action-bar {

Related discussion:
text: I just now noticed how the progress bar was a the very end of the quick pick but not below input box, I think it should be below input box because the progress is for what I typed. Steps: have some history entries in Cmd+P picker be on a slow OS (Windows) start to type and notice progress bar is below the history entries //cc
Seems like this might have been a regression at some point. for relocating it back near the input.
I like where it is now. To me it says "the results are still populating".
The reason I do not like it: the progress bar is at a non-deterministic location depending on the number of items the progress bar indicator is away from the location that triggers it (the input box)
Code change:
const disposables = new DisposableStore(); try { const userDataProfilesExportState = disposables.add(this.instantiationService.createInstance(UserDataProfileExportState, this.userDataProfileService.currentProfile)); <del> const title = localize('export profile preview', "Export"); const exportProfile = await this.selectProfileResources( userDataProfilesExportState, localize('export title', "{0}: {1} ({2})", PROFILES_CATEGORY.value, title, this.userDataProfileService.currentProfile.name), localize('export description', "Choose what to export") ); if (exportProfile === undefined) { return; } await this.doExportProfile(userDataProfilesExportState, !exportProfile, localize('cancel', "Cancel")); </del> <ins> await this.doExportProfile(userDataProfilesExportState, true, localize('cancel', "Cancel")); </ins> } finally { disposables.dispose(); }

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: MacOS Big Sur latest Steps to Reproduce: Create a new profile Click on the Profile Activity Bar icon, then choose Result: the quick pick comes up... ! Now click on the menu item to bring up the view Click on the menu item again Result: focus just moves to the pane ! Expectation: Show the Quick Pick so the menu works the same regardless of whether or not the content view is open
I was also hit by this - that by clicking on "Export Profile..." it looks like it has no effect, when it fact it just passed the focus. we could always show quick pick as Chris suggests?
What about the contents view when you click on again? Does this has to be closed or remain like this? May I understand what is confusing in navigating to the contents view when you click on export profile button?
I think you can leave the view open, but I would open the Quick Pick right away, not force the user to click on the Export button (again).
Another idea (that was also mentioned in the UX call) is how about always open the view and ditch quick pick? This was initial flow actually.
I think that flow might work. My biggest concern is that users might not notice that the focus moved to the view (especially if the view is already open). Long term - maybe the view becomes a custom editor? fyi
Quick pick is removed and by default we show the contents view now.
Code change:
content.push(`a:hover, .workbenchCommand:hover { color: ${styles.textLinkActiveForeground}; }`); } <del> if (styles.sliderBackgroundColor) { content.push(`::-webkit-scrollbar-thumb { background-color: ${styles.sliderBackgroundColor}; }`); } </del> if (styles.sliderActiveColor) { <del> content.push(`::-webkit-scrollbar-thumb:active { background-color: ${styles.sliderActiveColor}; }`); </del> <ins> content.push(`.issue-reporter-body::-webkit-scrollbar-thumb:active { background-color: ${styles.sliderActiveColor}; }`); </ins> } if (styles.sliderHoverColor) { <del> content.push(`::--webkit-scrollbar-thumb:hover { background-color: ${styles.sliderHoverColor}; }`); </del> <ins> content.push(`.issue-reporter-body::-webkit-scrollbar-thumb { background-color: ${styles.sliderHoverColor}; }`); content.push(`.issue-reporter-body::--webkit-scrollbar-thumb:hover { background-color: ${styles.sliderHoverColor}; }`); </ins> } if (styles.buttonBackground) {

Related discussion:
text: Type: <bBug</bIssue Reporter, e.g. from off Command Palette. the first dropdown to VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-24T07:50:18.385Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
good catch, thanks! looks like an issue with the refactor
Code change:
// Handle empty if (emptyToRestore.length > 0) { emptyToRestore.forEach(emptyWorkspaceBackupFolder => { <del> const configuration = this.toConfiguration(openConfig); </del> <ins> const configuration = this.toConfiguration(openConfig, void 0, filesToOpen, filesToCreate, filesToDiff); </ins> const browserWindow = this.openInBrowserWindow(configuration, true /* new window */, null, emptyWorkspaceBackupFolder); usedWindows.push(browserWindow); <ins> // Reset these because we handled them filesToOpen = []; filesToCreate = []; filesToDiff = []; </ins> openFolderInNewWindow = true; // any other folders to open must open in new window then }); }

Related discussion:
text: Testing have a file that is empty run type the file is dirty close the window run !
This is tricky: on the main side we open one window as instructed from the command line with the file and we also open another window to restore backups. Since we do not actually know the files to restore on the main side (we just rely on the renderer side to do this), we are opening 2 windows without knowing that the same file ends up being opened 2 times. Imho what should happen is this: if we know that we are restoring empty windows with backups, we just add all the files (as instructed from the command line) to one of those empty windows to avoid that we open multiple windows. This should happen in method ideally. We do the same if we are about to open a window with a folder: all other files to open (or create) end up being opened in that window of the folder.
I have a PR up for this via though I am not sure this is the best fix :). Basically what it does is to see if upon startup we have windows opening with hot-exit files to restore (either folder or untitled). If we find any such window to open, we open files to open files to create files to diff inside the first of these windows that upon as a matter of restoring hot-exit data. So instead of getting an extra window opened for the files to open, they would open into the first window that is being opened as a matter of hot-exit restore. what do you think?
I think this is a pretty good fix. It seems to align with how the CLI works when windows are opened as well; instead of opening the files in the last active window, the first window to be restored is selected.
Ok, merged.
Code change:
this._store.add(this._progressBar); let allowRequests = false; <del> this._chatWidget = _instantiationService.createInstance( </del> <ins> const scopedInstaService = _instantiationService.createChild( new ServiceCollection([ IContextKeyService, this._store.add(_contextKeyService.createScoped(this._elements.chatWidget)) ]) ); this._chatWidget = scopedInstaService.createInstance( </ins> ChatWidget, location, { resource: true },

Related discussion:
text: Just asked hi: ! Expected: ! Version: 1.88.0-insider (user setup) Commit: Date: 2024-03-25T05:49:32.344Z Electron: 28.2.6 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0. GitHub Copilot Chat v0.14. (pre-release)
because of
To verify configure have a very wide view port ask AI to change some code make sure the input widget is full width of the zone widget
Code change:
this._store.add(this._progressBar); let allowRequests = false; <del> this._chatWidget = _instantiationService.createInstance( </del> <ins> const scopedInstaService = _instantiationService.createChild( new ServiceCollection([ IContextKeyService, this._store.add(_contextKeyService.createScoped(this._elements.chatWidget)) ]) ); this._chatWidget = scopedInstaService.createInstance( </ins> ChatWidget, location, { resource: true },

Related discussion:
text: cmd+i now cmd+backspace invokes instead of deleting the line in the text editor The ChatWidget is writing its context keys to the editor's ContextKeyService, so we need a scoped CKS at some point, either inside the ChatWidget or outside in the inline widgets
pushing a fix to use a scoped CKS but this does look like debt. Isn't a better fix to reset context keys when hiding/dispose the chat widget?
I don't think those context keys should be applied on the editor at all, they are intended to just be active inside the widget's dom tree.
Code change:
text-overflow: ellipsis; } <ins> .default-preferences-editor-container > .preferences-header-container > .default-preferences-header, .settings-tabs-widget > .monaco-action-bar .action-item .action-label:not([aria-haspopup]) { display: block; } </ins> .settings-tabs-widget > .monaco-action-bar .actions-container { justify-content: flex-start; }

Related discussion:
text: I would expect a "..." overflow behaviour here: !
Fixed in , please review
Code change:
nls.localize('addBreakpoint', "Add Breakpoint"), null, true, <del> () => this.debugService.addBreakpoints(uri, [{ lineNumber }]) </del> <ins> () => this.debugService.addBreakpoints(uri, [{ lineNumber }], `debugEditorContextMenu`) </ins> )); actions.push(new Action( 'addConditionalBreakpoint',

Related discussion:
text: When going over our telemetry for debug actions we have the ability to track usage counts of debug actions triggered from keyboard shortcuts and commands, as they execute commands which we emit telemetry for, but we don't seem to have telemetry in place for breakpoints set in the gutter (click or context menu). This is unfortunate as my hypothesis is that the majority of breakpoints are set this way. Ask Add ability to track breakpoint toggles (add/remove/change) from Gutter click Add ability to track breakpoint toggles from gutter context menu
would you like to contribute a PR for this? It shuold be fairly simple and you already have the nice code pointers.
I'd be happy too, but we should land on an agreement on how to implement it. What's the best approach? 1) Add telemetry directly to the gutter actions 2) Re-wire the gutter actions to execute a command instead?
for the best approach let's first see what you want to get exactly? total amount of all breakpoints set (including the gutter) grained events for breakpoint setting based on the way the user initated that aciton In case of 1 we should just add a telemetry ping in the  since everyone should go through there In case of 2 depends on how fine grained you want it, if for every place then we should add an argument or something like that in the addBreakpoints method and then also report that to telemetry.
I'd like us to be able to contribute a source/initiator to given breakpoint, so we can get an UI usage distributions, etc.
I suggest the following Add a third argument In the implementation of that method use the telemetry service to report the appropriate event with the context. And you should nicely get all the errors of all the callers of , simply pass different string context for each caller and you shuold be good to go. Let me know if you have any questions
Cool, I'l see what I can get cooking!
Removing my assignment for this. feel free to assign me back if you do not have time to tackle this and if we need this for August
hey, would you still like this? If yes I can also look into it in October
I'd still like to do this to get my hands dirty.
cool, unasigning myself and let's leave it for October
Verified by code review, adding verified label
Code change:
if (extensionsSelector) { const { selectedExtension } = this.issueReporterModel.getData(); reset(extensionsSelector, this.makeOption('', localize('selectExtension', "Select extension"), true), ...extensionOptions.map(extension => makeOption(extension, selectedExtension))); <del> extensionsSelector.selectedIndex = 0; </del> <ins> if (!selectedExtension) { extensionsSelector.selectedIndex = 0; } </ins> this.addEventListener('extension-selector', 'change', (e: Event) => { const selectedExtensionId = (<HTMLInputElement>e.target).value;

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: Python issue reporter selects (, instead of )
Code change:
"command": "git.openChange", "title": "%command.openChange%", "category": "Git", <del> "icon": "$(compare-changes)" </del> <ins> "icon": "$(compare-changes)", "enablement": "scmActiveResourceHasChanges" </ins> }, { "command": "git.openAllChanges",

Related discussion:
text: <!-- Do you have a question? Please ask it on --VSCode Version: 1.12.1 OS Version: OS X EI Capitan 10.11.3 Steps to Reproduce: some project from GitHub. a file A.cs which has no fresh changes at all. on the editor of A.cs, and notice the button of on the top right corner above the editor doesn't display as disbled! Clicking it has no effect of course, but it should display as disable in this case just like what in the old versions.
Can't fix without , closing for now.
since it connot be fixed without , should this be kept open and linked to then?
Sure.
To keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed. Thanks for your understanding. Happy coding!
Hoping to re-open this because I got this as a feedback item from a few CS educators. They notice their students clicking it accidentally and being confused when there is no apparent action.
I think this has regressed, I now miss this button when a file is staged.
Fixed regression with
There is another regression (), so I will be reverting this fix for this, and will refactor it.
Code change:
if (settingId !== this.currentFileIconTheme.settingsId) { await this.internalSetFileIconTheme(theme.id, undefined); } else if (theme !== this.currentFileIconTheme) { <ins> await theme.ensureLoaded(this.extensionResourceLoaderService); </ins> this.applyAndSetFileIconTheme(theme, true); } return true;

Related discussion:
text: Open a new folder Trust the workspace Some of the colors in the window become wrong An editor has the wrong background color Opening the theme picker fixes it !
I originally filed because I encountered this during Settings Sync but think it's not related as I also saw this when opening files: !
Step to verify connect to settings sync install and set the Dracula theme () notice that the remote indicator is violet open a new folder that is not yet trusted the trust dialog shows up, approve verify that the remote indicator is still violet, not blue
Code change:
} } <ins> function compareSourceControlHistoryItemRef(ref1: SourceControlHistoryItemRef, ref2: SourceControlHistoryItemRef): number { const getOrder = (ref: SourceControlHistoryItemRef): number => { if (ref.id.startsWith('refs/heads/')) { return 1; } else if (ref.id.startsWith('refs/remotes/')) { return 2; } else if (ref.id.startsWith('refs/tags/')) { return 3; } return 99; }; const ref1Order = getOrder(ref1); const ref2Order = getOrder(ref2); if (ref1Order !== ref2Order) { return ref1Order - ref2Order; } return ref1.name.localeCompare(ref2.name); } </ins> export class GitHistoryProvider implements SourceControlHistoryProvider, FileDecorationProvider, IDisposable { private readonly _onDidChangeDecorations = new EventEmitter<Uri[]>(); readonly onDidChangeFileDecorations: Event<Uri[]> = this._onDidChangeDecorations.event;

Related discussion:
text: Testing I wonder how well it scales to show multiple tag icons, why not find a new icon that resembles multiple tags: !
I like that. Adding as that would require a new Codicon...
!
Or just show one tag in the row, but show all of them on hover like you do now.
How about showing one badge pert type (ex: branch, remote branch, tag) and a number indicating how many they are. That way there is no need create new icons that would cause further confusion.
I am actually not entirely sure what value there is to distinguish 1 tag from N tags? I would just show 1 icon if there is any tag.
Seems reasonable. Let's start with that and see how things go.