jiebi/CodeConvo huggingface dataset:
Code change:
} const actions = this.getFixAllActions(context.only); <del> if (this.client.bufferSyncSupport.hasPendingDiagnostics(document.uri)) { return actions; } </del> const diagnostics = this.diagnosticsManager.getDiagnostics(document.uri); if (!diagnostics.length) { // Actions are a no-op in this case but we still want to return them

Related discussion:
text: can you fix it?
I can confirm this issue, I can trigger the autocomplete for the import with either ctrl+space or ctrl+. however it is not automatically on save even with enabled. This feature was working for me some time ago, but I can no longer get it to work.
Any fix yet?
Changing the order to solved the problem for me.
Code change:
import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey'; import { IExtensionTerminalProfile, ITerminalProfile, TerminalLocation, TerminalSettingId } from 'vs/platform/terminal/common/terminal'; import { ResourceContextKey } from 'vs/workbench/common/contextkeys'; <ins> import { TaskExecutionSupportedContext } from 'vs/workbench/contrib/tasks/common/taskService'; </ins> import { ICreateTerminalOptions, ITerminalLocationOptions, ITerminalService } from 'vs/workbench/contrib/terminal/browser/terminal'; import { TerminalCommandId, TERMINAL_VIEW_ID } from 'vs/workbench/contrib/terminal/common/terminal'; import { TerminalContextKeys, TerminalContextKeyStrings } from 'vs/workbench/contrib/terminal/common/terminalContextKey';

Related discussion:
text: Could look like this, but have and/or tasks entries as well as a one. Hiding it by default is a good way to avoid cluttering the action bar - so people only see it if they want to <img width="285" alt="Screen Shot 2022-09-30 at 12 56 57 PM" src="https://user-"
cc
Talked w Kai and we're thinking to instead add a action to the terminal dropdown which aligns with the menu and will aid in discoverability !
Code change:
provideContent(): string { this._element = document.activeElement as HTMLElement; const content: string[] = []; <ins> content.push(CommentAccessibilityHelpNLS.introWidget); </ins> content.push(CommentAccessibilityHelpNLS.escape); content.push(this._descriptionForCommand(CommentCommandId.Add, CommentAccessibilityHelpNLS.addComment, CommentAccessibilityHelpNLS.addCommentNoKb)); <ins> content.push(this._descriptionForCommand(CommentCommandId.Submit, CommentAccessibilityHelpNLS.submitComment, CommentAccessibilityHelpNLS.submitCommentNoKb)); </ins> content.push(this._descriptionForCommand(CommentCommandId.NextRange, CommentAccessibilityHelpNLS.nextRange, CommentAccessibilityHelpNLS.nextRangeNoKb)); content.push(this._descriptionForCommand(CommentCommandId.PreviousRange, CommentAccessibilityHelpNLS.previousRange, CommentAccessibilityHelpNLS.previousRangeNoKb)); <del> content.push(this._descriptionForCommand(CommentCommandId.Submit, CommentAccessibilityHelpNLS.submitComment, CommentAccessibilityHelpNLS.submitCommentNoKb)); return content.join('nn'); </del> <ins> return content.join('n'); </ins> } onClose(): void { this._element?.focus();

Related discussion:
text: As a result of the discussion in , we should format each command, description, and keybinding more consistently and limit redundancy.
/closedWith though still need to do the same for the chat help dialogs
Code change:
}, }, { <ins> id: 'installGit', title: localize('gettingStarted.installGit.title', "Install Git"), description: localize('gettingStarted.installGit.description.interpolated', "Install Git to track changes in your projects.n{0}", Button(localize('installGit', "Install Git"), 'https://aka.ms/vscode-install-git')), when: 'git.missing', media: { type: 'svg', altText: 'Install Git.', path: 'git.svg', }, }, { </ins> id: 'tasks', title: localize('gettingStarted.tasks.title', "Automate your project tasks"), when: 'workspaceFolderCount != 0 && workspacePlatform != 'webworker'',

Related discussion:
text: <!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --This could include platform specific instructions. Curious to know which platforms we're talking about here... Windows for sure but what else? Does Raspbian ship git?
Hi, I would like to work on this please assign this to me.
thanks! We cannot assign you as you are not a member of this issue, but please feel free to submit a PR. The relevant code is here:
I can take this up if it's not already done. Could you elaborate on what new step needs to be ?
hello guys, i'm really trying to get started in contributing to open how i get started here?
Hello this is my first time contributing to an open source project and I'm willing to work on this issue. I just set this repo up on my machine and its working. I had a look at the file you've shared and there are conditions for few steps which checks if git is missing. So, I tried simulating the inexistence of git just by disabling it in vs code settings. Is that fine? And also, should there be a button which says "Install Git"? If yes, what should it be linked to? !
We can use I recommend testing this by fully removing git if at all possible, otherwise there my be unexpected behaviors when a new users is actually running this for the first time.
Is this complete, or I can still work on this?
I am not aware of any work done here.
Could you assign it to me? I would like to work on this quickly. Edit I guess, Only members can be assigned. So, I will open a PR and link to this issue.
Hello, I'm sorry I should've kept you updated but I've made those changes and I just have to test it out by uninstalling git.
I have tested with uninstalling git. Can I take this?
Omg I just did that to push. What do we do?
Just tested this on Windows, and the "Install Git" item is marked as ticked when you click on the "Install Git" button regardless of whether you have actually installed Git - is this expected?
Code change:
}, }, { <ins> id: 'installGit', title: localize('gettingStarted.installGit.title', "Install Git"), description: localize('gettingStarted.installGit.description.interpolated', "Install Git to track changes in your projects.n{0}", Button(localize('installGit', "Install Git"), 'https://aka.ms/vscode-install-git')), when: 'git.missing', media: { type: 'svg', altText: 'Install Git.', path: 'git.svg', }, }, { </ins> id: 'tasks', title: localize('gettingStarted.tasks.title', "Automate your project tasks"), when: 'workspaceFolderCount != 0 && workspacePlatform != 'webworker'',

Related discussion:
text: Or would it be better to only tick the button when an installation of git is detected? The screenshot below shows that I clicked the button but didn't actually install Git. The item is ticked but attempting to run git in the terminal (or git pane) fails !
good idea, changed so that the item checks off when git is initialized.
Ohh yaa..I did not notice that Thanks for fixing it ! :)
I uninstalled git and reloaded to see the new "Install git" item. Then, I installed git, but the item wasn't checked off, and I wasn't sure what to run to get the item to check off. After reloading again, I didn't see the item. I uninstalled git again and reloaded. The item showed up, but checked off this time. I unchecked the item and reinstalled git, and ran git in the terminal, and the item still wasn't checked off. I switched workspaces, and I didn't see the item again.
Can we have which checks if git is installed when we reach this step?
No, it should work based on context keys, which have change events.
Ohh okay
Hi. What is the current status of this issue? Is there a bug for the current implementation? I can work on it if no one is working and someone gives me the context. Thanks.
Isn't it the expected behavior? If VS Code is open and git is installed, even Source Control tab doesn't notice this change; a reload is required for that. If this is not the expected behavior and automatic discovery of git existence is necessary, then this tab should also be fixed. I assume the item can be checked off by clicking the checkbox or Mark Done text below. This is also an expected behavior, I think. For example; you customized your shortcuts using Customize your shortcuts, then this item is checked off. After then you reset shortcuts but the item is still checked off. You probably doesn't expect the opposite. Because you understand how to configure the option this item provides. I think the key of checking off here is understanding the option. Otherwise most items may be reversed and should not be checked off after the reverse. On the other hand I think your statement shows that the natural flow of the Install Git item doesn't suit well to a checklist.
Code change:
}, }, { <ins> id: 'installGit', title: localize('gettingStarted.installGit.title', "Install Git"), description: localize('gettingStarted.installGit.description.interpolated', "Install Git to track changes in your projects.n{0}", Button(localize('installGit', "Install Git"), 'https://aka.ms/vscode-install-git')), when: 'git.missing', media: { type: 'svg', altText: 'Install Git.', path: 'git.svg', }, }, { </ins> id: 'tasks', title: localize('gettingStarted.tasks.title', "Automate your project tasks"), when: 'workspaceFolderCount != 0 && workspacePlatform != 'webworker'',

Related discussion:
text: I am not able to test this at the moment due to some system issues, but I would consider the following sufficient for marking this complete: a user does not have installed, a tile is shown pointing them to steps for installing git and notifying of a need to reload the window to complete installation. A button/link could be shown to trigger a reload. completing the installation and relaunching VS Code, the tile for installing git is no longer shown, and the tile explaining git use inside VS Code is shown instead. I believe today we have this minus the part where we explain that a reload is required to complete git installation and provide UI to facilitate the reload.
Updated step to include link to .
Code change:
import { Emitter, Event } from 'vs/base/common/event'; import { KeyCode } from 'vs/base/common/keyCodes'; import { Disposable, DisposableStore, dispose, isDisposable, toDisposable } from 'vs/base/common/lifecycle'; <del> import { isIOS, language } from 'vs/base/common/platform'; </del> <ins> import { isIOS } from 'vs/base/common/platform'; </ins> import { escapeRegExpCharacters } from 'vs/base/common/strings'; import { isDefined, isUndefinedOrNull } from 'vs/base/common/types'; import { localize } from 'vs/nls';

Related discussion:
text: <img width="285" alt="image" src="https://user-"
strange as 1000 is a number <img width="1060" alt="Screenshot 2023-01-20 at 3 28 32 PM" src="https://user-"
value is here, not sure why <img width="1246" alt="Screenshot 2023-01-20 at 3 34 09 PM" src="https://user-"
Oh, changed the default value to 10 and it worked. I think 1000 is viewed as too high somewhere so it gets set to '' <img width="1052" alt="Screenshot 2023-01-20 at 3 39 55 PM" src="https://user-"
also tried because some other settings w high default values use that and it still didn't work
I some logging and it's because converts it to , and then the inputbox doesn't know how to handle the comma
Code change:
import { IPartService, Position } from 'vs/workbench/services/part/common/partService'; const SPLIT_PANE_MIN_SIZE = 120; <ins> const TERMINAL_MIN_USEFUL_SIZE = 250; </ins> class SplitPaneContainer { private _height: number;

Related discussion:
text: With latest release (1.21) you can split terminal infinitely. This breaks badly the terminal area. Probably the IDE should limit this to a defined maximum or something?
I considered adding a max value but you would always be able to break it then by sizing down. As a mitigation we could disallow creating terminals if the desired room isn't there but the real fix is proper overflow behavior.
Thanks , I would agree that proper overflow behaviour is the way to go. Thanks!
I think the easiest way to improve this is to only allow terminals to be created if there's a reasonable amount of room. This can exist with our current lack of overflow behavior as it's an improvement on the current and will prevent 100 terminals from being created..
Some terminal can be resized to a small size if they are not important. In some case, showing multiple terminals is just to notify the user whether they are running. Currently the minimum size of terminal is too large.
I suggest the minimum size of a terminal should be an option in Settings.
Code change:
folder?: boolean; skipTrashBin?: boolean; maxSize?: number; <ins> contentsBase64?: string; </ins> } export interface IWorkspaceFileEdit {

Related discussion:
text: Add support for setting the contents of files created by workspace edits My proposed would be to add a option to : For , we want to support copying images from desktop into with drag and drop. Right now we have to use the apis to create the image file Using a workspace edit would let us express the entire operation in a single , which will play more nicely with undo/redo
Looks like support for this may already exist internally: However getting a of new file data from the extension host to the main process may be tricky. We can only efficiently serialize a if it is a top level argument to an RPC call or if the entire object is wrapped in a (which has a perf cost). Open to ideas on how to handle this
I do like the and believe the cost is manageable - we don't send edits is large frequencies and of large sizes. I can take a look at this but it honestly is stretch for June - there is some debt in how workspace edits are represented on the wire and I would take this issue as a reason to clean things up
work started here: I didn't bother with or hoisting the data to the top but instead it uses quick and dirty base64 encoding. I'd suggest we go with that and see how it works out over time.
Code change:
"type": "object", "order": 20, "properties": { <ins> "php.builtInCompletions.enable": { "type": "boolean", "default": true, "description": "%configuration.builtInCompletions.enable%" }, </ins> "php.validate.enable": { "type": "boolean", "default": true,

Related discussion:
text: There is now a better Intellisense plugins for Vscode PHP: and . In it's known issues it says "There may be duplicate suggestions for functions or variables. This is because VS Code has it's own (very limited) code-completion support for PHP, and there is currently no way to turn this off." This indeed is annoying, the vscode suggestions are too broad and are just noise compared to accurate entries by crane.
It should be possible to uninstall the VS Code php extension.
fyi
I think crane still uses vscode's syntax highlighter for PHP. So if one were to remove VSCode's internal PHP extension, would it also remove the syntax highlighter? P.S. I think simple options would suffice, e.g. "", so it could be turned off.
Yes - but we can also think about splitting our extension into one part that does highlighting and bracket config and another that does completions. That would allow for more freedom.
This is now annoying the testing of proper language server in here : Quote: P.S. I think the option would be a simplest thing to implement for now.
Related
Any update on this?
I have been holding back the PHP IntelliSense release with intelligent completion for over a month now because it is useless if VS Code just spams the completion list with countless functions that do not make sense in the context. When will we get the option to disable or uninstall the built-in PHP completion?
I agree it makes sense to provide a temporary option to disable this. Just submitted a PR here:
Also just checking - at this point in time, is there anything else about the built-in support that is interfering with the experience? (hover, signature help, etc.?)
thanks for looking into this. Signature help is being implemented right now, iirc there is no built-in hover. It would be great if all of them could be disabled (everything except syntax highlighting).
I pushed the PR and changes the setting name for the code completion to "". If disabled, hover and signature help are also disabled.
I don't think the setting achieves the desired result. Setting to I no longer get completion suggestions even from PHP Intellisense extension. If have to use to trigger the completion suggestions list.
I don't think this is related, this only removes the built-in completion provider.
Code change:
"type": "object", "order": 20, "properties": { <ins> "php.builtInCompletions.enable": { "type": "boolean", "default": true, "description": "%configuration.builtInCompletions.enable%" }, </ins> "php.validate.enable": { "type": "boolean", "default": true,

Related discussion:
text: So something else which controls the display of suggestions list from extensions like php intellisense is broken?
Part of the January build. Add to your settings to disable all completions from the built-in PHP extension.
Code change:
constructor( private id: string, @IMenuService private readonly menuService: IMenuService <del> ) { super(); } </del> <ins> ) { } </ins> <del> /** * Caller is now responsible for disposing of the menu! */ getResourceActions(element: ITreeItem): { menu?: IMenu; actions: IAction[] } { const actions = this.getActions(MenuId.ViewItemContext, element, true); </del> <ins> getResourceActions(element: ITreeItem, disposableStore: DisposableStore): { menu?: IMenu; actions: IAction[] } { const actions = this.getActions(MenuId.ViewItemContext, element, disposableStore); </ins> return { menu: actions.menu, actions: actions.primary }; }

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: V1.81.1 OS Version: Linux kkuser-virtual-machine 5.15.0-83-generic ~20.04.1-Ubuntu SMP Mon Aug 21 14:00:49 UTC 2023 x8664 x8664 x8664 GNU/Linux Steps to Reproduce: are constant changes in attribute states in the treeview calls to () functions result in memory leakage
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.82.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Code change:
match acquire_singleton(&paths.tunnel_lockfile()).await { Ok(SingletonConnection::Client(stream)) => { debug!(log, "starting as client to singleton"); <ins> if gateway_args.name.is_none() || !gateway_args.install_extension.is_empty() || gateway_args.tunnel.tunnel_id.is_some() { warning!( log, "Command-line options will not be applied until the existing tunnel exits." ); } </ins> let should_exit = start_singleton_client(SingletonClientArgs { log: log.clone(), shutdown: shutdown.clone(),

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (N/A) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.88.1 OS Version: macOS Steps to Reproduce: the shell, run , UPDATE: the system need to have a existing tunnel already running that the machine name is always inferred from Hostname instead of the machine name set through <img width="931" alt="image" src=""
Update: I noticed the "Connected to an existing tunnel..." line, and if I kill the tunnel first using and run the same command, it would correctly set the machine name. I'll update the issue description to reflect that.
Yea, if there's an existing tunnel we just connect to it and never enter the process in which the name would be set. Renaming a running tunnel is also possible but could lead to unpredictable side effects. We should just log a warning in this case.
I'm not seeing any warning:
still no warning. I made sure I was on the latest !
in your screenshot you can see the warning which is what I for this.
Code change:
font-family: var(--monaco-monospace-font); font-size: 12px; color: var(--vscode-textPreformat-foreground); <del> background-color: var(--vscode-textPreformat-background); </del> padding: 2px 5px; border-radius: 4px; }

Related discussion:
text: Expected ! Actual !
Regressed in
The markdown preview in the chat is also broken for Dark Modern but is fixed by your change: !
And the markdown preview in the settings editor: !
I looked into this some more and have the following findings block rendering is broken for Dark Modern, Light Modern, Dark HC and Light HC What changed: we a new theme token, , adopted it in and , and updated the values for to look good with a different background color But we didn't adopt token for blocks in Markdown previews, which is why is broken for Markdown preview Some options Adopt for blocks in Markdown preview -- this amounts to a rather drastic styling change for Markdown previews ! Revert Revert the change to and drop the usage of so that Markdown preview, chat, and settings UI are in a reasonable state for all themes, which I attempted in
Also affects the Extensions Details page since it is a Markdown preview !
Verification: for Light/Dark Modern and Light/Dark HC, make sure that blocks are properly rendered in Markdown preview, settings UI and chat