jiebi/CodeConvo huggingface dataset:
Code change:
type: 'string', description: nls.localize('contributes.preload.entrypoint', 'Path to file loaded in the webview.'), }, <ins> [NotebookPreloadContribution.localResourceRoots]: { type: 'array', items: { type: 'string' }, description: nls.localize('contributes.preload.localResourceRoots', 'Paths to additional resources that should be allowed in the webview.'), }, </ins> } } };

Related discussion:
text: Originally filed here Problem: Notebook kernel pre-load scripts are now defined statically via the contribution However VS Code throws a 401 error when loading resources from within the Jupyter extension, If however we have a dummy script file (in the Jupyter extension directory) that is defined as a in the VS Code API , then all resources from Jupyter extension directory are loaded I.e. using the above API in some way registers the Juptyer extension directory as a supported for scripts, and using the static contribution does not.
I have a work around in the Jupyter extension right now, i've a dummy placeholder script that does nothing,
Can you share steps to reproduce this with the fix in place? Also, does this happen on normal desktop too, or only sshe Unclear why this is not working as we should add preloads to the local resource roots:
Here are the steps Install Python Install VS Code insiders and latest pre-release versions of Jupyter and Python NOTE: Install the pre-release version of Jupyter extension that is 2 days old Add the following setting into vscode Create a python env and install the following dependencies You can use the command to create a directory with Pytohn in a particular workspace folder (optionally you can use Python extension to do this for you) Run the following code in a notebook pointing to the above venv (i.e. select the above venv as a kernel) You might get prompted to enable CDN download, hit cancel for that The widget will not load, network tab in vscode will display a 401 error Note: This is now working in the latest pre-release version of Jupyter extension
I believe the broken version is be but I'm having trouble reproducing this The output either never renders anything (but there is no network error) or renders as an image: ! ! Any other steps?
Not sure which pre-release to use anymore, as the pre-release has changed since Please use the vsixc from this build (check the artifacts for the vsix) here is the Install Python Add the following setting into vscode (reload VSCode) Create a python env and install the following dependencies You can use the command to create a directory with Pytohn in a particular workspace folder (optionally you can use Python extension to do this for you) Run the following code in a notebook pointing to the above venv (i.e.
Code change:
type: 'string', description: nls.localize('contributes.preload.entrypoint', 'Path to file loaded in the webview.'), }, <ins> [NotebookPreloadContribution.localResourceRoots]: { type: 'array', items: { type: 'string' }, description: nls.localize('contributes.preload.localResourceRoots', 'Paths to additional resources that should be allowed in the webview.'), }, </ins> } } };

Related discussion:
text: select the above venv as a kernel) You might get prompted to enable CDN download, hit cancel for that The widget will not load, network tab in vscode will display a 401 error !
I'm still unable to reproduce this issue Are you running the jupyter out of sources by chance or have you patched VS Code/jupyter in some other way? The path to the resource we a trying to load looks weird: . This looks like an extension development path In normal installs, we should load resources from a path that looks more like: If you are able, you can also try and sharing the result of that function compared to the path of the js file we try loading in the webview
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
information was provided
lets you specific an additional set of localResourceRoots that should be allowed when loading the preload. Can you please try adding these for the python static preload contribution? Let me know if fixes the problem!
Thanks , seems to work,
Changes were made upstream in VS Code, marking as verified.
Code change:
.customview-tree .monaco-list .monaco-list-row .custom-view-tree-node-item { display: flex; <ins> align-items: center; </ins> height: 22px; line-height: 22px; flex: 1;

Related discussion:
text: <img width="584" alt="image" src="https://user-"//cc for views
I assume this is nothing to do with the views instead its about how entires are rendered in list/tree. CC
Tree row contents are outside of the tree's jurisdiction, but are in fact responsibility of the widget user.
Timeline doesn't use the extension tree view and instead does it's own thing. I think works on timeline.
curious, do we have an understanding what caused this? it seems relatively recent?
Might be related to . any ideas here?
It was caused by , can you check? I see a visual difference not only with the alignment but also the spacing: Before <img width="254" alt="image" src="https://user-"After <img width="269" alt="image" src="https://user-"
it looks like timeline relies on the custom tree view css. I made a change in the nesting/ordering of elements in the tree view recently and I updated the css to reflect that. Because timeline relies on the css but doesn't actually use the custom tree view, this broke the timeline. I've opened a PR with a timeline specific css fix.
<!-- UNABLETOLOCATECOMMITMESSAGE issue --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
Code change:
export function onDidChangeZoomLevel(callback:(zoomLevel:number)=>void): IDisposable { return ZoomManager.INSTANCE.onDidChangeZoomLevel(callback); } <ins> export function getEditorZoomLevel(): number { return ZoomManager.INSTANCE.getEditorZoomLevel(); } export function setEditorZoomLevel(zoomLevel:number): void { let zoomLevelNormalized = Math.min(Math.max(-9, zoomLevel), 9); ZoomManager.INSTANCE.setEditorZoomLevel(zoomLevelNormalized); } export function onDidChangeEditorZoomLevel(callback:(zoomLevel:number)=>void): IDisposable { return ZoomManager.INSTANCE.onDidChangeEditorZoomLevel(callback); } </ins> const userAgent = navigator.userAgent;

Related discussion:
text: VSCode Version: 1.1.1 OS Version: Windows 7 x64 It would be great if holding the key + spinning the mouse wheel would increase / decrease the VS Code zoom value.
I am not sure we want to zoom the entire UI when you use the mousewhell, I would expect only the editor font to increase. Thereby moving to
yes you are correct.
Didn't this feature used to work, or am I just failing to remember correctly? I was just going to report this as a bug, but maybe it never actually worked. I jump between different computer setups fairly regularly, so maybe I am just not remembering. Anyway, I found this dupe, and didn't want to submit a new issue. Thanks for your efforts By the way, I think I would expect this feature to work the same way that and work. VSCode's UI deviates from many other UIs in that it scales well, so I think I'd expect this to scale the entire UI consistently with the keyboard commands.
If this zooms only the editor, shouldn't it be seperate from ?
I would expect and to zoom only the editor. That behaviour would be consistent with most (all?) other editors and apps. Scaling the entire interface is an accessibility feature IMO, so maybe it doesn't need to use such a commonly used shortcut by default? Beyond Ctrl+Wheel, pinch to zoom should also zoom the editor.
Can this be disabled? I'm constantly accidentally zooming my text to a tiny size when I ctrl-click and accidentally brush my fingers over the trackpad.
This is disabled by default, so you must have enabled it in the past --
Thanks - I came here to vote for this feature, and it turns out I just had to turn it on! Shouldn't this issue be closed?
:+1: Closing since this is implemented. The feature is disabled by default due to numerous issues reported by users using touchpads where we begin to unexpectedly zoom in/zoom out when e.g. using ballistic scrolling and pressing the ctrl/cmd modifier. The root problem is that we cannot differentiate events coming in from a real mouse with a wheel from those coming in from touchpads / trackpads.
Code change:
})); this._register(editor.onDidChangeConfiguration(() => { this._hoverOperation.setHoverTime(this._editor.getOption(EditorOption.hover).delay); <ins> this._preferBelow = this._editor.getOption(EditorOption.hover).below; </ins> })); this._register(TokenizationRegistry.onDidChange(() => { if (this._isVisible && this._lastAnchor && this._messages.length > 0) {

Related discussion:
text: Issue Type: <bFeature Request</bI want the message could display under the variables it refers to. Because the message box blocks the code over the current line. Thank you. VS Code version: Code 1.36.1 (, 2019-07-08T22:59:35.033Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
Can we just change the default to or does this require a setting?
Kind of feel like this is out of scope, but I don't think this should be assigned to me since it's regarding monaco.
Actually I was wrong - it is determined by : I verified if I swap the order then the hovers appear below instead of above (where there's space). I'll make a PR.
Done! Before: <img width="734" alt="Screenshot 2021-06-30 at 08 45 06" src="https://user-"Change the setting: <img width="921" alt="Screenshot 2021-06-30 at 08 45 14" src="https://user-"After: <img width="777" alt="Screenshot 2021-06-30 at 08 45 22" src="https://user-"
Let's continue tracking in
Code change:
this.fallbackMenuHandlers['workbench.action.openWorkspace'] = (menuItem, win, event) => this.nativeHostMainService.pickWorkspaceAndOpen(undefined, { forceNewWindow: this.isOptionClick(event), telemetryExtraData: { from: telemetryFrom } }); // Recent Menu Items <del> this.fallbackMenuHandlers['workbench.action.clearRecentFiles'] = () => this.workspacesHistoryMainService.clearRecentlyOpened(); </del> <ins> this.fallbackMenuHandlers['workbench.action.clearRecentFiles'] = () => this.workspacesHistoryMainService.clearRecentlyOpened({ confirm: true /* ask for confirmation */ }); </ins> // Help Menu Items const youTubeUrl = this.productService.youTubeUrl;

Related discussion:
text: Type: <bBug</bany open windows. to File Open Recent and click Clear Recently Opened. VS Code version: Code 1.83.1 (, 2023-10-10T23:46:55.789Z) OS version: Darwin x64 20.6.0
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Code change:
const inputModel = await input.resolve(); const model = inputModel.model; <del> const viewModel = new MergeEditorViewModel(model, this.input1View, this.input2View, this.inputResultView, this.baseView, this.showNonConflictingChanges, this.configurationService); </del> <ins> const viewModel = this.instantiationService.createInstance( MergeEditorViewModel, model, this.input1View, this.input2View, this.inputResultView, this.baseView, this.showNonConflictingChanges, ); </ins> model.telemetry.reportMergeEditorOpened({

Related discussion:
text: Testing When my cursor isn't inside of a conflict, this command does nothing. Should it only be visible in the quickpick when it does something? Or should there be an error message when you try to run it but it doesn't do anything? Same with the "Toggle Current Conflict from Right". <img width="549" alt="image" src="https://user-"
I fear if we hide it when there is nothing to toggle, users won't discover that there is a (keybindable) command for this functionality. How did you find this command? Was your cursor in a conflicting region?
It wasn't in a conflicting region at the time
Let's show an error message if this command does not do anything.
If I run the toggle command in an invalid region, I get a notification, which is good. But, if I then toggle a valid region after, the notification still stays on the screen for a while. Can the notification be hidden when the user toggles a valid region?
Can notifications be removed? I thought that is not possible. Also, I think this use-case is quite rare. The notification is just to teach that you should be in a conflict.
Code change:
// breakpoint must not be on position (no need for this action). return bps.length === 0; } <ins> public isSupported(): boolean { return super.isSupported() && this.debugService.state === debug.State.Stopped; } </ins> } export class AddWatchExpressionAction extends AbstractDebugAction {

Related discussion:
text: VSCode Version: 1.2.0 OS Version: all Steps to Reproduce: from the command palette while not debugging a error: !
Code change:
const renderLineInput: RenderLineInput = new RenderLineInput(true, true, lineRenderingData.content, lineRenderingData.continuesWithWrappedLine, lineRenderingData.isBasicASCII, lineRenderingData.containsRTL, 0, lineRenderingData.tokens, actualInlineDecorations, lineRenderingData.tabSize, lineRenderingData.startVisibleColumn,

Related discussion:
text: VSCode Version: Code 1.7.2 (, 2016-11-21T22:14:18.217Z) OS Version: Linux x64 4.8.0-26-generic Focus on debug: ! Focus on extensions: ! Can the bright one be on debug as well?
For me all viewlets show the same feedback once focussed: ! Please clarify the issue you see.
Oh I mean via tab focus.
! still they all look the same to me?
I see what you mean, when you focus into the current active viewlet, the orange bar to the left shows up stronger. I am not sure who this, I think might be the one?
This issue has been closed automatically because it needs more information and has not had recent activity. Please refer to our for filing issues. Thank you for your contributions.
Closing as designed, no plans to change it currently.
Code change:
language, ...filteredMetadata }; <ins> // Give preference to the language we have been given. // Metadata can contain `language` due to round-tripping of cell metadata. // I.e. we add it here, and then from SCM when we revert the cell, we get this same metadata back with the `language` property. if (language) { obj.language = language; } </ins> const metadataSource = toFormattedString(obj, {}); return metadataSource;

Related discussion:
text: Testing Before reverting metadata ! After reverting ! language remains . If I try to revert, nothing happens.
I was expecting the revert will revert the content to the version on the left side if the diff editor is opened from the timeline view, but it seems reverting to something different.
I think this can be fixed next month.
Thats a duplicate of Marking as as metadta gets reverted
Yes, the plan is to fix next month, I have a PR, but do not want to merge it just yet Its a slightly convoluted issue,
Code change:
resolved "https://registry.yarnpkg.com/request-light/-/request-light-0.7.0.tgz#885628bb2f8040c26401ebf258ec51c4ae98ac2a" integrity sha512-lMbBMrDoxgsyO+yB3sDcrDuX85yYt7sS8BfQd11jtbW/z5ZWgLZRcEGLsLoYw7I0WSUGQBs8CC8ScIxkTX1+6Q== <del> vscode-json-languageservice@^5.3.1: version "5.3.1" resolved "https://registry.yarnpkg.com/vscode-json-languageservice/-/vscode-json-languageservice-5.3.1.tgz#c36175d05f425fbd8f47dcee6f2a72096bdda36f" integrity sha512-tPRf/2LOBS6uFflFLABdj8T3ol2/QgZ0kpzZHFCs+cbxpnjBNiCo+rfh3th0dtdytq5dSnWo5iFJj99zF6jZWQ== </del> <ins> vscode-json-languageservice@^5.3.2: version "5.3.2" resolved "https://registry.yarnpkg.com/vscode-json-languageservice/-/vscode-json-languageservice-5.3.2.tgz#11e530ba9ec541eaeb421dc274a22efdb5d580ef" integrity sha512-5td6olfoNdtyxnNA4uocq7V9jdTJt63o9mGEntQb6cbD2HiObZW2XgbSj6nRaebWwBCiYdWpFklNjm6Wz6Xy1Q== </ins> dependencies: "@vscode/l10n" "^0.0.11" jsonc-parser "^3.2.0"

Related discussion:
text: On Windows: clone open workspace look at the workspace settings: all files are associated with schema . Note that this is a relative path to the workspace file open both files and check that code completion gives back property . You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated :bug: No code code completion or schema association
76 candidate PR:
Code change:
"@vscode/vscode-languagedetection": "1.0.21", "@vscode/windows-process-tree": "^0.5.0", "@vscode/windows-registry": "^1.1.0", <del> "@xterm/addon-canvas": "0.6.0-beta.16", "@xterm/addon-image": "0.7.0-beta.14", "@xterm/addon-search": "0.14.0-beta.16", "@xterm/addon-serialize": "0.12.0-beta.16", "@xterm/addon-unicode11": "0.7.0-beta.16", "@xterm/addon-webgl": "0.17.0-beta.16", "@xterm/headless": "5.4.0-beta.16", "@xterm/xterm": "5.4.0-beta.16", </del> <ins> "@xterm/addon-canvas": "0.6.0-beta.17", "@xterm/addon-image": "0.7.0-beta.15", "@xterm/addon-search": "0.14.0-beta.17", "@xterm/addon-serialize": "0.12.0-beta.17", "@xterm/addon-unicode11": "0.7.0-beta.17", "@xterm/addon-webgl": "0.17.0-beta.17", "@xterm/headless": "5.4.0-beta.17", "@xterm/xterm": "5.4.0-beta.17", </ins> "cookie": "^0.4.0", "graceful-fs": "4.2.11", "http-proxy-agent": "^7.0.0",

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --VS Code Version: Version: 1.85.0 (Universal) OS Version: Darwin arm64 22.5.0 Terminal input doesn't work ( is too slow almost feels like not working ) when using in Aux Window. Steps to Reproduce: Open Aux Terminal Window In Full Screen Mode or make it Full screen afterwords.
This seems to be working in OSS Dev container.
This looks to me like a case of scheduling something on the main window which gets throttled once hidden. is the terminal using scheduler for rendering such as RAF or ?
I can reproduce and its pretty bad.
off-topic: is there a way to move panel to separate window. e.g. bottom drawer or individually like terminal, debug console ?
PR fixing it
Code change:
private static NLS_UNSUPPORTED = nls.localize('patchedWindowTitle', "[Unsupported]"); private static NLS_EXTENSION_HOST = nls.localize('devExtensionWindowTitlePrefix', "[Extension Development Host]"); private static TITLE_DIRTY = 'u25cf '; <del> private static TITLE_SEPARATOR = ' - '; </del> <ins> private static TITLE_SEPARATOR = ' — '; </ins> private titleContainer: Builder; private title: Builder;

Related discussion:
text: Most macOS apps (like ) use em dash () instead of en dash () as window title separator. I suggest VS Code use em dash for better consistency.
PR welcome.
Can anyone explain a bit about it ? Thanks
Code change:
private clone(uri: Uri): void { const data = querystring.parse(uri.query); <ins> const ref = data.ref; </ins> if (!data.url) { console.warn('Failed to open URI:', uri);

Related discussion:
text: <!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --vscode- a directory to clone your repo into cloned repo :bug: branch context is not preserved This impacts Continue Working On--branch context is preserved for Clone in Container and Create New Codespace. I propose adding a new optional query parameter to the uri handler here: and passing that to the command as an optional argument here Then after cloning here: and before opening the repo in a new window, we would perform the ref checkout:
will you create a test plan item/verification steps for this feature?
yes I will!
Code change:
reset(resourceMarkers: ResourceMarkers[]): void; revealMarkers(activeResource: ResourceMarkers | null, focus: boolean, lastSelectedRelativeTop: number): void; setAriaLabel(label: string): void; <del> setMarkerSelection(marker?: Marker): void; </del> <ins> setMarkerSelection(selection?: Marker[], focus?: Marker[]): void; </ins> toggleVisibility(hide: boolean): void; update(resourceMarkers: ResourceMarkers[]): void; updateMarker(marker: Marker): void;

Related discussion:
text: Testing Not sure if this lack of functionality blocks anything truly useful, but at least in the treeview, you can multi-select problems and copy them to the clipboard. In the table view you can't.
This also has the side effect of losing a multi-select that you may have had in the treeview.
what was the thinking for enabling multi-select in the problems treeview? Was there a particular scenario or this is what the default behaviour is for a treeview? If there is a real scenario, than we should enable multi-select in the table as well.
You can copy multiple problems is the primary use case.
that makes sense. Thanks!
Code change:
} } <ins> export class OpenRawUserSettingsAction extends Action { public static readonly ID = 'workbench.action.openRawUserSettings'; public static readonly LABEL = nls.localize('openRawUserSettings', "Open Raw Global User Settings"); constructor( id: string, label: string, @IPreferencesService private preferencesService: IPreferencesService ) { super(id, label); } public run(event?: any): TPromise<any> { return this.preferencesService.openRawUserSettings(); } } </ins> export class OpenSettings2Action extends Action { public static readonly ID = 'workbench.action.openSettings2';

Related discussion:
text: We have a setting to disable the settings split view, but it might be useful to have a command to open the user outside of the split view for a one-off. From
I am reverting the PR, it actually doesn't work. We intercept the editor open here:
Damn, it's already a part of my workflow . What's wrong with it?
So it opens the raw outside of the split view for you? For me, it actually just acts the same as the normal open settings command and opens the settings split view.
And you don't have ?
I don't have . The command itself works for me. Does it break some other functionality? ! OS version: Windows_NT x64 10.0.
I see now. Opens a split view on linux VM. Was it ever working before on non-Windows environments?
Yeah it only works on Windows, because the == check with fspath can fail due to drive letters being different. I guess that's a separate bug... I'll revert this tomorrow.
We got a good bug out of this:
Now that the settings UI exists, I don't plan on investigating much more on the JSON editor. The split JSON UI will probably go away at some point (the JSON files themselves will always remain)
BUT I CAN'T OPEN SETTINGS FILE (WITHOUT SPLIT) NOW AT ALL BECAUSE IT'S NOT LETTING ME. Are you planning to allow users to see plain json file or to forbid it completely?
We will always allow users to see the json file. Hopefully you can still open the raw json file with .
I know about that option, it's not great.
I'll close this just because I am cleaning up issues that are specific to the JSON split editor. But to be clear, editing the JSON file will never go away :)