jiebi/CodeConvo huggingface dataset:
Code change:
appendWholeWordsLabel: this._keybindingLabelFor(FIND_IDS.ToggleWholeWordCommand), appendRegexLabel: this._keybindingLabelFor(FIND_IDS.ToggleRegexCommand), validation: (value: string): InputBoxMessage | null => { <del> if (value.length === 0) { return null; } if (!this._findInput.getRegex()) { </del> <ins> if (value.length === 0 || !this._findInput.getRegex()) { </ins> return null; } try { <del> /* tslint:disable:no-unused-expression */ </del> <ins> /* tslint:disable-next-line:no-unused-expression */ </ins> new RegExp(value); <del> /* tslint:enable:no-unused-expression */ </del> return null; } catch (e) { return { content: e.message };

Related discussion:
text: We can add the same regex validator for the terminal find widget input box if the underling regex engine is JavaScript regex. Close this one if we are using another regex engine somehow in
So in the terminal widget show things like this and reject the search? <img width="238" alt="screen shot 2018-10-11 at 11 58 06 am" src="https://user-"
I would like to try and work on this feature. Could someone tell me where to start working on this feature?
the terminal find widget code is here: It extends the SimpleFindWidget: Not sure where the validator is but I'd look around the and files.
Code change:
const isXHRResponse = (error: any): error is XHRResponse => typeof error?.status === 'number'; const request = async (uri: string, etag?: string): Promise<string> => { <del> const headers: Headers = { 'Accept-Encoding': 'gzip, deflate' }; </del> <ins> const headers: Headers = { 'Accept-Encoding': 'gzip, deflate', 'User-Agent': `${env.appName} (${env.appHost})` }; </ins> if (etag) { headers['If-None-Match'] = etag; }

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.79.2 OS Version: Darwin x64 22.5.0 Steps to Reproduce: a webserver at serving a single schema at containing (the precise contents don't really matter) a file , and paste in: the cursor between the quotes just after the trailing slash , and look at the webserver logs, observing no user agent was sent
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.80.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
I suggest to verify this in code:
Code change:
/* padding must be on action-label because it has the bottom-border, because that's where the .checked class is */ } <ins> .settings-editor > .settings-header > .settings-header-controls .settings-tabs-widget > .monaco-action-bar .action-item.focused { outline-offset: -1.5px; } </ins> .settings-editor > .settings-header > .settings-header-controls .settings-tabs-widget > .monaco-action-bar .action-item .action-label { text-transform: none; font-size: 13px; <del> padding-bottom: 7px; </del> <ins> padding-bottom: 6.5px; </ins> padding-top: 7px; padding-left: 8px; padding-right: 8px; } <ins> .settings-editor > .settings-header > .settings-header-controls .settings-tabs-widget > .monaco-action-bar .action-item .action-label .dropdown-icon { padding-top: 2px; } </ins> .settings-editor > .settings-header > .settings-header-controls .settings-tabs-widget > .monaco-action-bar .action-item .action-label:not(.checked):not(:focus) { /* Add an extra pixel due to it not getting the outline */ padding-bottom: 8px;

Related discussion:
text: Issue Type: <bBug</bWith the latest update, active and inactive menu in settings UI does not look any different from each other VS Code version: Code 1.66.0 (, 2022-03-30T05:50:14.623Z) OS version: WindowsNT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 3.10.0-1127.10.1.el7.x8664 <details<summarySystem Info</summary </details<details<summaryExtensions (42)</summaryExtensionVersion ------ LogFileHighlighter2.15.0 remotehub0.28.0 better-cpp-syntax1.15.13 blockman1.5.7 jupyter-keymap1.0.0 remote-containers0.231.1 remote-ssh0.78.0 remote-ssh-edit0.78.0 remote-wsl0.66.0 remote-repositories0.4.0 material-icon-theme4.15.0 rewrap1.16.3 vscode-icons11.10.0 vscode-todo-highlight1.0.5 path-intellisense2.8.0 vscode-clock0.0.1 gitlens12.0.5 systemverilog0.12.1 prettier-vscode9.5.0 seito-openfile1.8.8 html-preview-vscode0.2.5 jira-plugin0.22.2 gitlab-workflow3.41.2 gc-excelviewer4.2.54 beautify1.5.0 path-autocomplete1.19.1 svg1.4.17 vscode-jira0.6.0 restructuredtext183.0.0 python2022.4.0 vscode-pylance2022.3.4 jupyter2022.3. jupyter-renderers1.0.6 cpptools1.9.7 veriloghdl1.5.3 subtle-brackets3.0.0 LiveServer5.7.5 code-spell-checker2.1.11 vscode-input-sequence0.2.0 simple-rst1.5.2 vscodeintellicode1.2.17 better-align1.1.6 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
/gifPlease
! ! ! !
Code change:
/* padding must be on action-label because it has the bottom-border, because that's where the .checked class is */ } <ins> .settings-editor > .settings-header > .settings-header-controls .settings-tabs-widget > .monaco-action-bar .action-item.focused { outline-offset: -1.5px; } </ins> .settings-editor > .settings-header > .settings-header-controls .settings-tabs-widget > .monaco-action-bar .action-item .action-label { text-transform: none; font-size: 13px; <del> padding-bottom: 7px; </del> <ins> padding-bottom: 6.5px; </ins> padding-top: 7px; padding-left: 8px; padding-right: 8px; } <ins> .settings-editor > .settings-header > .settings-header-controls .settings-tabs-widget > .monaco-action-bar .action-item .action-label .dropdown-icon { padding-top: 2px; } </ins> .settings-editor > .settings-header > .settings-header-controls .settings-tabs-widget > .monaco-action-bar .action-item .action-label:not(.checked):not(:focus) { /* Add an extra pixel due to it not getting the outline */ padding-bottom: 8px;

Related discussion:
text: By "active and inactive menu" I assume you are referring to the tabs labelled "User", "Remote", "Workspace" etc. Which color theme are you using? Do you also see the issue when using the default themes (Light+ and Dark+)?
Yeah, I am referring to "User", "Remote", "Workspace" etc. I am using Night Owl Light Theme
Does this problem occur when you don't have a multi-root workspace open?
The issue is seen only with a multi-root workspace. Is it a known issue?
Code change:
linuxExecutableName: product.applicationName, winIcon: 'resources/win32/code.ico', token: process.env['GITHUB_TOKEN'], <del> repo: product.electronRepository || undefined </del> <ins> repo: product.electronRepository || undefined, validateChecksum: true, checksumFile: path.join(root, 'build', 'checksums', 'electron.txt'), </ins> }; function getElectron(arch) { return () => {

Related discussion:
text: Today when running out of sources and/or building, we get some components from online resources such as GitHub or our Marketplace. We should add SHA256 checksum verification to these: [x] [x] built-in extensions [x] electron
Adding the foundation for this for and extensions in
Code change:
import { findExecutable, getShellIntegrationInjection, getWindowsBuildNumber, IShellIntegrationConfigInjection } from 'vs/platform/terminal/node/terminalEnvironment'; import { WindowsShellHelper } from 'vs/platform/terminal/node/windowsShellHelper'; import { IPty, IPtyForkOptions, IWindowsPtyForkOptions, spawn } from 'node-pty'; <ins> import { chunkInput } from 'vs/platform/terminal/common/terminalProcess'; </ins> const enum ShutdownConstants { /**

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.77.3 OS Version: Ubuntu 20.04.6 Steps to Reproduce: VSCode on an Ubuntu computer (or on Windows using WSL) the built-in terminal the command and paste the following 39-character string into nano: : nano shows the error message "Unknown Sequence". Can no longer interact with the terminal, need to kill it and open a new one More details: nano version 4.8 This does not happen in nano using an external terminal. Only in VSCode's built-in terminal This does not happen for any other length of string, even other multiples of 39 This does not happen in other CLI text editors, such as vim
I can confirm this issue on Windows using WSL.
It happens with other 39 long strings as well. It also happens when not using WSL. Copying more characters solves the problem. For us it also happens with multiples of 39 (e.g. 156 characters, line breaks included)
When trace logs are enabled this is the exact sequence we send: Compared to 1 less : Note that the 200/201 wrapped around it is bracketed paste mode (which I just a way to disable so that may help ). So this seems to be either a problem with one of nano, conpty or node-pty.
I also just ran into this. I'm on Windows 10, using Remote - SSH plugin to connect to an Ubuntu 22.04 server. Right-click to paste in Nano, terminal locks up, have to Kill it.
Code change:
import { findExecutable, getShellIntegrationInjection, getWindowsBuildNumber, IShellIntegrationConfigInjection } from 'vs/platform/terminal/node/terminalEnvironment'; import { WindowsShellHelper } from 'vs/platform/terminal/node/windowsShellHelper'; import { IPty, IPtyForkOptions, IWindowsPtyForkOptions, spawn } from 'node-pty'; <ins> import { chunkInput } from 'vs/platform/terminal/common/terminalProcess'; </ins> const enum ShutdownConstants { /**

Related discussion:
text: Add/remove one character from the string and try again, works.
We closed this issue because we in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our and . Thanks for your understanding, and happy coding!
i opened a bug on gnu nano's bugtracker:
I think I found a workaround, but haven't tested it: vscode , nano doesn't deal well with across writes and it is apparently difficult to fix in nano. vscode could split writes differently, using this algorithm that keeps escape sequences at the beginning and end unsplit (like bracketed pastes):
great info, we should definitely do this . I'll probably tweak your proposal a little to try catch escape sequences in the middle too.
I don't expect input sizes to be 50 bytes except when pasting, when pasting there should only ever be an escape sequence at the beginning and end, never in the middle (terminal apps are unlikely to deal well with pasting a string containing escape sequences anyway).
unless I missed something in the issue you linked, it's not that they need to be on the boundaries of the text but need to be included entirely in that string and not clipped?
yes, escape sequences need to be contained entirely in one write syscall. basically I am saying you shouldn't have escape sequences in the middle of a long input, so you don't need to look for them to avoid splitting them, they should only occur towards the ends of a long input or in a shorter input.
Nano's workaround was released in Nano 8.0:
Code change:
}); }); <ins> // --- document highlights test('"vscode.executeDocumentHighlights" API has stopped returning DocumentHighlight[]#200056', async function () { disposables.push(extHost.registerDocumentHighlightProvider(nullExtensionDescription, defaultSelector, <vscode.DocumentHighlightProvider>{ provideDocumentHighlights() { return [ new types.DocumentHighlight(new types.Range(0, 17, 0, 25), types.DocumentHighlightKind.Read) ]; } })); await rpcProtocol.sync(); return commands.executeCommand<vscode.DocumentHighlight[]>('vscode.executeDocumentHighlights', model.uri, new types.Position(0, 0)).then(values => { assert.ok(Array.isArray(values)); assert.strictEqual(values.length, 1); const [first] = values; assert.strictEqual(first.range.start.line, 0); assert.strictEqual(first.range.start.character, 17); assert.strictEqual(first.range.end.line, 0); assert.strictEqual(first.range.end.character, 25); }); }); </ins> // --- outline test('Outline, back and forth', function () {

Related discussion:
text: Type: <bBug</bI have an extension that has been making use of the executeCommand API for "vscode.executeDocumentHighlights" to get the for different positions in a file. Essentially calling something like below: After a recent VsCode update, the API is no longer returning any values and simply returns . I'm not sure the best way to provide a reproduce for this. I originally encountered the problem with a custom extension/language server. However the problem also appears to occur when calling the same command on a simple typescript file so I believe it's a general issue rather than any thing specific to my environment. I've had a quick search in the VsCode sources and I have a feeling this commit might be responsible: I think the problem is due to now returning instead of . When it gets to the ApiCommand layer I think the function fails and returns as the function has been given a instead of VS Code version: Code 1.84.2 (, 2023-11-09T10:51:52.184Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (30)</summaryExtensionVersion ------ vscode-markdownlint0.53.0 vscode-eslint2.4.2 mfcobol1.0.53 mfenterprise1.0.53 vscode-language-pack-ja1.84. csdevkit1.0.14 csharp2.12.19 vscode-dotnet-runtime2.0.0 vscodeintellicode-csharp0.1.26 python2023.20.0 vscode-pylance2023.11.10 jupyter2023.10.
Code change:
}); }); <ins> // --- document highlights test('"vscode.executeDocumentHighlights" API has stopped returning DocumentHighlight[]#200056', async function () { disposables.push(extHost.registerDocumentHighlightProvider(nullExtensionDescription, defaultSelector, <vscode.DocumentHighlightProvider>{ provideDocumentHighlights() { return [ new types.DocumentHighlight(new types.Range(0, 17, 0, 25), types.DocumentHighlightKind.Read) ]; } })); await rpcProtocol.sync(); return commands.executeCommand<vscode.DocumentHighlight[]>('vscode.executeDocumentHighlights', model.uri, new types.Position(0, 0)).then(values => { assert.ok(Array.isArray(values)); assert.strictEqual(values.length, 1); const [first] = values; assert.strictEqual(first.range.start.line, 0); assert.strictEqual(first.range.start.character, 17); assert.strictEqual(first.range.end.line, 0); assert.strictEqual(first.range.end.character, 25); }); }); </ins> // --- outline test('Outline, back and forth', function () {

Related discussion:
text: jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-ssh0.107.1 remote-ssh-edit0.86.0 remote-wsl0.81.8 powershell2023.8.0 remote-explorer0.4.1 test-adapter-converter0.1.8 java1.25.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-java-debug0.55.0 vscode-java-dependency0.23.3 vscode-java-pack0.25.15 vscode-java-test0.40.1 vscode-maven0.43.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Thanks This is a good find!
To verify: make sure this test has passed:
Code change:
inputBox.focus(); inputBox.select({ start: 0, end: lastDot > 0 && !stat.isDirectory ? lastDot : value.length }); <del> const done = once(async (success: boolean) => { </del> <ins> const done = once(async (success: boolean, finishEditing: boolean) => { </ins> label.element.style.display = 'none'; const value = inputBox.value; dispose(toDispose); container.removeChild(label.element); <del> // Timeout: once done rendering only then re-render #70902 setTimeout(() => editableData.onFinish(value, success), 0); </del> <ins> if (finishEditing) { // Timeout: once done rendering only then re-render #70902 setTimeout(() => editableData.onFinish(value, success), 0); } </ins> }); let ignoreDisposeAndBlur = true; setTimeout(() => ignoreDisposeAndBlur = false, 100); const blurDisposable = DOM.addDisposableListener(inputBox.inputElement, DOM.EventType.BLUR, () => { if (!ignoreDisposeAndBlur) { <del> done(inputBox.isInputValid()); </del> <ins> done(inputBox.isInputValid(), true); </ins> } });

Related discussion:
text: <!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --Steps to Reproduce: rename on a top level file element in explorer view in single folder workspace in developer tools that the div for that file row contains multiple invisible children elements which are input element containers !
I can not reproduce this issue on my machine. How do you end the rename, with Esc, Enter or some other way? Are you doing anything else that is special?
I just press continuously. I can reproduce this easily on linux(ubuntu) and windows. The setup it's just a folder with a single file and I drag and drop the folder on vscode.
Yes I can reproduce now.
This might happen again on tomorrow's vscode insiders. Thus unlocking converstaion so we can open this issue if needed.
You are right I can repro this again.
Code change:
if (this._currentCommand.commandStartMarker) { this._commandMarkers.push(this._currentCommand.commandStartMarker); } <ins> this._onCommandExecuted.fire(); </ins> } this._evaluateCommandMarkersWindows(); }

Related discussion:
text: Type: <bBug</b I am not sure whether the insiders version reflects the up-to-date patch though, does not seem to work in Powershell. I have noticed that this works in my remote z shell though. VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-03T15:11:12.179Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 4.18.0-477.27.1.el88.x8664 <details<summarySystem Info</summary </details<details<summaryExtensions (104)</summaryExtensionVersion ------ aiprm-lang0.0.2 Bookmarks13.4.2 spellright3.0.118 mermaid-markdown-syntax-highlighting1.5.3 vscode-firefox-debug2.9.10 codespaces1.16.2 remotehub0.62.0 overleaf-workshop0.4.1 easy-snippet0.6.3 scheme0.2.0 better-cpp-syntax1.17.2 lilypond-snippets0.1.1 vscode-edge-devtools2.1.3 jupyter-keymap1.1.2 remote-containers0.322.0 remote-ssh0.108. remote-ssh-edit0.86.0 remote-wsl0.81.8 vscode-remote-extensionpack0.24.0 azure-repos0.38.0 remote-explorer0.5. remote-repositories0.40.0 vscode-serial-monitor0.10.0 vscode-speech0.3.
Code change:
if (this._currentCommand.commandStartMarker) { this._commandMarkers.push(this._currentCommand.commandStartMarker); } <ins> this._onCommandExecuted.fire(); </ins> } this._evaluateCommandMarkersWindows(); }

Related discussion:
text: multi-command1.6.0 errorlens3.15.0 Bookmarks13.4.2 openscad1.2.2 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.3 codium0.7.13 doxdocgen1.4.0 vscode-markdownlint0.52.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.26.0 gitlens14.4.1 EditorConfig0.16.4 prettier-vscode10.1.0 shell-format7.2.5 vscode-google-translate1.4.13 codespaces1.16.2 copilot1.133.531 copilot-chat0.11. remotehub0.62.0 vscode-github-actions0.26.2 vscode-pull-request-github0.77. cslpreview0.2.2 path-autocomplete1.25.0 latex-workshop9.14.1 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 git-graph1.30.0 vscode-docker1.27.0 black-formatter2023.4.1 flake82023.10.0 isort2023.10.1 python2023.20.0 vscode-pylance2023.11.10 jupyter2023.11.
Code change:
if (this._currentCommand.commandStartMarker) { this._commandMarkers.push(this._currentCommand.commandStartMarker); } <ins> this._onCommandExecuted.fire(); </ins> } this._evaluateCommandMarkersWindows(); }

Related discussion:
text: jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 azure-repos0.38.0 cmake-tools1.15.31 cpptools1.17.5 cpptools-extension-pack1.3.0 js-debug-nightly2023.11.217 remote-repositories0.40.0 vscode-github-issue-notebooks0.0.130 vscode-selfhost-test-provider0.3.20 vscode-serial-monitor0.10.0 vsliveshare1.0.5892 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.5 shinyuieditor0.5.0 quarto1.106.3 r-debugger0.5.4 java1.24.0 vscode-xml0.26.1 r2.8.2 multi-command1.6.0 vscode-deepl1.0.6 lua3.7.0 latex-utilities0.4.10 cmake0.0.17 errorlens3.15.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-java-debug0.55.0 vscode-java-dependency0.23.2 vscode-java-pack0.25.15 vscode-java-test0.40.1 vscode-maven0.43.0 markdown-all-in-one3.5.1 grammarly0.24.0 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
it is working for me on windows with PowerShell. could you share a gif?
!
-- Also, I have noticed that sometimes the first letter typed in Accessible View is not bypassed as demonstrated in the z shell.
Thanks for the gif, yeah, it's not working for you. I cannot reproduce even when I use a terminal in the editor area. Could you pls set terminal log level to debug, repro, and provide me with those?
Looks like shell integration isn't working properly for you for some reason, which is why this isn't working. We run the open command , so that's not happening.
And yeah, I can reproduce sometimes the key not getting sent to the terminal.
Code change:
if (this._currentCommand.commandStartMarker) { this._commandMarkers.push(this._currentCommand.commandStartMarker); } <ins> this._onCommandExecuted.fire(); </ins> } this._evaluateCommandMarkersWindows(); }

Related discussion:
text: It's a timing issue related to the context view that is shown.
I'll split that issue out
As expected, your logs do not show , which explains why it's not working for you.
I wonder if is loaded for you. That would be the only way that event wouldn't happen
Can you pls run and provide the output?
!
So is disabled for you, which is why this isn't working.
If you add this line to your , it will work
is disabled by default when screen reader is used, and enabling it does not resolve the issue. Please see the gif: !
oh, seems we'll have to use instead for this case then.
I still cannot repro. I have the likely fix, so you'll be able to verify it tomorrow.
Code change:
// or if no window is open (macOS only) shouldOpenInNewWindow ||= isMacintosh && windowsMainService.getWindowCount() === 0; <del> // Pass along edit session id if (params.get('editSessionId') !== null) { environmentService.editSessionId = params.get('editSessionId') ?? undefined; params.delete('editSessionId'); uri = uri.with({ query: params.toString() }); } </del> // Check for URIs to open in window const windowOpenableFromProtocolLink = app.getWindowOpenableFromProtocolLink(uri); logService.trace('app#handleURL: windowOpenableFromProtocolLink = ', windowOpenableFromProtocolLink);

Related discussion:
text: Originally reported by
Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.
would you mind verifying this one please?