jiebi/CodeConvo huggingface dataset:
Code change:
// ---- end view event handlers <ins> private _updateAnchorsViewPositions(): void { const keys = Object.keys(this._widgets); for (const widgetId of keys) { this._widgets[widgetId].updateAnchorViewPosition(); } } </ins> public addWidget(_widget: IContentWidget): void { const myWidget = new Widget(this._context, this._viewDomNode, _widget); this._widgets[myWidget.id] = myWidget;

Related discussion:
text: Open Set some breakpoints They show in the wrong place and cover a character, but seemingly get fixed when setting a breakpoint on the next line !
It is non-deterministic: ! Maybe that depends on the timing of the debugger. If I add to this statement (effectively removing the condition), I cannot reproduce anymore: Unfortunately that might cause performance problems. I think this is because needs to be called when injected text is inserted before it.
I am currently still reproing it here: <img width="445" alt="image" src="https://user-" btw make sure you add labels and a milestone to issues for verification and tracking
Any chance this could be looked at soon? It comes up pretty often <img width="1018" alt="image" src="https://user-"
Thanks
Code change:
private readonly pendingUpdates = new Map<string, number>(); private readonly throttle = 50; <del> private previousEditorInfo = new Map<string, LastScrollLocation>(); public isPrevEditorCustom = false; </del> <ins> private previousTextEditorInfo = new Map<string, LastScrollLocation>(); private previousStaticEditorInfo = new Map<string, LastScrollLocation>(); </ins> constructor() { super(); if (vscode.window.activeTextEditor) { const line = getVisibleLine(vscode.window.activeTextEditor); <del> this.setPreviousEditorLine({ uri: vscode.window.activeTextEditor.document.uri, line: line ?? 0 }); </del> <ins> this.setPreviousTextEditorLine({ uri: vscode.window.activeTextEditor.document.uri, line: line ?? 0 }); </ins> } this._register(vscode.window.onDidChangeTextEditorVisibleRanges(event => {

Related discussion:
text: Issue Type: <bBug</bI have been using for a long time. Currently I end up with a LOT of inadvertant selections when working in two side-by-side editor groups and switching back and forth between them using the mouse. The reason is that the editor scrolls 5 lines every time I click into it. VS Code version: Code - Insiders 1.58.0-insider (, 2021-06-11T05:22:19.992Z) OS version: Darwin arm64 20.5.0 Restricted Mode: No Remote OS version: Linux x64 5.4.0-1046-azure <!-- generated by issue reporter --
I cannot reproduce. Does this reproduce for you when disabling all extensions? (The editor exposes a API to extensions). I have recently also got which seems incredibly similar, but I am having a hard time reproducing any of the jumping that is described. Here I am trying two side-by-side editor groups: https://user-
This reproduces only when the language mode of the files are set to markdown. I think this has to do with how the markdown extension is using the vscode API. But I think it should not use that API at all if no markdown preview is rendered. But it would also be interesting to test what the experience is when the preview is rendered. Given this doesn't reproduce with txt files, I'm optimistically giving this to you. Steps to reproduce: define open two md files side-by-side (preferably without word wrapping to see the top line number change) click on the editor tab of each one on every click, the editor scrolls up by 5 lines https://user-
Could you please take a look at this since you were looking into markdown syncing last iteration?
It seems like it's a bug coming from the scroll syncing between the static and text editor changes that I made a while ago. I'll try to make a PR to fix this soon.
Code change:
compositeSwitcherBar.push(this.compositeOverflowAction, { label: false, icon: true }); } <del> this._onDidChange.fire(); </del> <ins> if (!donotTrigger) { this._onDidChange.fire(); } </ins> } private getOverflowingComposites(): { id: string; name?: string }[] {

Related discussion:
text: have insiders with settings sync enabled add exploration build to the sync select replace local when prompted so that exploration because just like insiders over time insiders UI state gets ruined, e.g the side bar is populated with views I have carefully hidden and rearranged
This is caused due to the dependency between two states and . Values of both states changed together from outside Change event for first state is triggered. Updating to this change can cause view container changes like (registering or deregistering) This triggers internal change events to update pinned viewlets Updating pinned viewlets is updating the stored value for second state Bug is caused at the last step -pinned viewlets state is getting overriden without refreshing its in-memory state.
How would this be verified?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Since it cannot be reproduced easily, I would ask to verify this.
the steps are as easy as described in or the description of this issue. use settings sync onboard another machine :bug: view state of the main machine get's broken: views reappear, views are reordered etcpp
Can you please verify this? I believe this depends on some pre-existing state therefore not everyone can reproduce. This state is not trivial to set up. Since you have this state already, it might be easier for you to verify.
Code change:
message += 'n'; } } <del> this._currentContent = message + provider.provideContent() + readMoreLink + disableHelpHint; </del> <ins> const exitThisDialogHint = localize('exit', 'nnExit this dialog (Escape).'); this._currentContent = message + provider.provideContent() + readMoreLink + disableHelpHint + exitThisDialogHint; </ins> this._updateContextKeys(provider, true); this._getTextModel(URI.from({ path: `accessible-view-${provider.verbositySettingKey}`, scheme: 'accessible-view', fragment: this._currentContent })).then((model) => {

Related discussion:
text: As a result of the discussion in , we should format each command, description, and keybinding more consistently and limit redundancy.
/closedWith though still need to do the same for the chat help dialogs
Code change:
public provideCompletionItems(document: TextDocument, position: Position, token: CancellationToken): Promise<CompletionItem[]> { let result: CompletionItem[] = []; <ins> let shouldProvideCompletionItems = workspace.getConfiguration('php').get<boolean>('builtInCompletions.enable', true); if (!shouldProvideCompletionItems) { return Promise.resolve(result); } </ins> var range = document.getWordRangeAtPosition(position); var prefix = range ? document.getText(range) : ''; if (!range) {

Related discussion:
text: There is now a better Intellisense plugins for Vscode PHP: and . In it's known issues it says "There may be duplicate suggestions for functions or variables. This is because VS Code has it's own (very limited) code-completion support for PHP, and there is currently no way to turn this off." This indeed is annoying, the vscode suggestions are too broad and are just noise compared to accurate entries by crane.
It should be possible to uninstall the VS Code php extension.
fyi
I think crane still uses vscode's syntax highlighter for PHP. So if one were to remove VSCode's internal PHP extension, would it also remove the syntax highlighter? P.S. I think simple options would suffice, e.g. "", so it could be turned off.
Yes - but we can also think about splitting our extension into one part that does highlighting and bracket config and another that does completions. That would allow for more freedom.
This is now annoying the testing of proper language server in here : Quote: P.S. I think the option would be a simplest thing to implement for now.
Related
Any update on this?
I have been holding back the PHP IntelliSense release with intelligent completion for over a month now because it is useless if VS Code just spams the completion list with countless functions that do not make sense in the context. When will we get the option to disable or uninstall the built-in PHP completion?
I agree it makes sense to provide a temporary option to disable this. Just submitted a PR here:
Also just checking - at this point in time, is there anything else about the built-in support that is interfering with the experience? (hover, signature help, etc.?)
thanks for looking into this. Signature help is being implemented right now, iirc there is no built-in hover. It would be great if all of them could be disabled (everything except syntax highlighting).
I pushed the PR and changes the setting name for the code completion to "". If disabled, hover and signature help are also disabled.
I don't think the setting achieves the desired result. Setting to I no longer get completion suggestions even from PHP Intellisense extension. If have to use to trigger the completion suggestions list.
I don't think this is related, this only removes the built-in completion provider.
Code change:
public provideCompletionItems(document: TextDocument, position: Position, token: CancellationToken): Promise<CompletionItem[]> { let result: CompletionItem[] = []; <ins> let shouldProvideCompletionItems = workspace.getConfiguration('php').get<boolean>('builtInCompletions.enable', true); if (!shouldProvideCompletionItems) { return Promise.resolve(result); } </ins> var range = document.getWordRangeAtPosition(position); var prefix = range ? document.getText(range) : ''; if (!range) {

Related discussion:
text: So something else which controls the display of suggestions list from extensions like php intellisense is broken?
Part of the January build. Add to your settings to disable all completions from the built-in PHP extension.
Code change:
readonly persistentProcessId: number | undefined; /** <del> * The id of a persistent process during the shutdown process */ shutdownPersistentProcessId: number | undefined; /** </del> * Whether the process should be persisted across reloads. */ readonly shouldPersist: boolean;

Related discussion:
text: Type: <bBug</bis enabled. Ensure is set to , or (any option that will restore the last open window after quiting and re-opening VSCode). a terminal in the editor area, e.g. using the command "Terminal: Create New Terminal in Editor Area". Type something into the terminal e.g. . VSCode via "Developer: Reload Window". Note that the terminal tab in the editor area is still there (restored) after the window is reloaded. This is the expected behavior. VSCode then reopen the application. Note that the terminal tab is not present (is not restored) when the window is restored (and since there is no terminal tab, there is also nowhere to restore the session to ) . This is unexpected behavior as previously this terminal tab would be restored into the editor area, with its session history, even after quitting and reopening VSCode. Another terminal persistence bug on 1.74.0, also related to killing terminals: VS Code version: Code 1.74.0 (, 2022-12-05T16:37:54.581Z) OS version: Darwin arm64 22.2.0 Modes: Sandboxed: No <details<summarySystem Info</summary </details<details<summaryExtensions (16)</summaryExtensionVersion ------ vscode-neovim0.0.94 calva2.0.321 file-browser0.2.11 portal0.35.0 viml0.1.7 prettier-vscode9.10.3 vscode-htmlhint1.0.4 vscode-sshfs1.25.0 ssh-config-syntax-highlighter0.0.4 sqltools0.26.0 sqltools-driver-pg0.4.0 errorlens3.6.0 learn-vim0.0.28 vspacecode0.10.10 whichkey0.11.3 markdown-all-in-one3.5.0 </details<!-- generated by issue reporter --
I cannot reproduce that in Insider's https://user-
have you typed in the terminal before reloading? if not, that's by design
Pardon me I was unclear in the original writeup. The problem occurs in step 4 and is now reflected in edits above. Thank you! Regarding the direct question: yes, I have typed in the terminal before reloading.
Code change:
readonly persistentProcessId: number | undefined; /** <del> * The id of a persistent process during the shutdown process */ shutdownPersistentProcessId: number | undefined; /** </del> * Whether the process should be persisted across reloads. */ readonly shouldPersist: boolean;

Related discussion:
text: /duplicate
Reviving editor-area terminals was working great in 1.73.x. This was marked as a duplicate of a feature request. Is it not a regression?
Created a PR with a possible fix
VSCode v1.74.2 occurs the same problem, does the fix takes effect or I need to config some settings?
The fix will be available in 1.75 release or you can try it in insiders
Code change:
} private onModelAdded(model: ITextModel): void { <del> const uri = model.uri; const supportedSchemes = [Schemas.untitled, Schemas.file, Schemas.vscodeRemote, Schemas.vscodeNotebookCell]; </del> <ins> const uri = model.uri.scheme === Schemas.vscodeNotebookCell ? CellUri.parse(model.uri)?.notebook : model.uri; const supportedSchemes = [Schemas.untitled, Schemas.file, Schemas.vscodeRemote]; </ins> if (!uri || !supportedSchemes.includes(uri.scheme)) { return; }

Related discussion:
text: Testing the steps in the test plan item to create an interactive window I get a notification saying there are extensions on the marketplace that can handle . I feel like this is unnecessary noise
Which extension is it recommending?
The marketplace query is ext:interactive when I click on Search Marketplace !
I forgot that we had this but we automatically query show this when there are extensions in the marketplace that match the query . I'm curious about how this works, it seems overly sensitive since these extensions don't use that file extension, seems that it just matches based on keywords? I think the only way to avoid it here is to change the extension that the interactive window uses, which is probably fine.
Discussed with and even if we picked an extension that isn't yet in use, we can't prevent extensions from introducing collisions later. What about the following (essentially, parse the notebook URI from the cell URI, and check if it's an untitled://, file:// or vscode-remote:// URI based on the notebook URI instead)?
What will the interactive window be? It won't pass that check?
Is the motive here is to not show any recommendations for this resource?
Yeah we don't want to show the '.interactive' file recommendation because it's not actually a file on disk. The interactive notebook schema is 'interactive'.
Then we shall be filtering out in our recommendations logic as you recommended above.
Code change:
'libdrm2 (>= 2.4.38)', 'libexpat1 (>= 2.0.1)', 'libgbm1 (>= 8.1~0)', <del> 'libgcc-s1 (>= 3.0)', </del> 'libglib2.0-0 (>= 2.16.0)', 'libglib2.0-0 (>= 2.39.4)', 'libgtk-3-0 (>= 3.9.10)',

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Insiders 1.71 OS Version: Ubuntu 18.04 amd64 Steps to Reproduce: to install latest code-insiders packages from MS repository () The issue is that with the dependency on Debian derivatives changed to which only exists on newer releases (20.04 and later I think). I realise that support for Ubuntu-Ancient is low on the priority list, but I am sadly stuck with it, and would appreciate if there was a workaround. Installing newer libgcc releases as suggested in some places easily leads to a very broken system.
This is a side effect of now using bullseye sysroot, we should apply the following change https://chromium- to our debian calculate package deps.
Code change:
} export default class LinkProvider implements vscode.DocumentLinkProvider { <del> private readonly linkPattern = /([((![[^]]*?](s*)([^s()]+?)s*)]|(?:]|[^]])*])(s*)(([^s()]|(S*?))+)s*(".*?")?)/g; </del> <ins> private readonly linkPattern = /([((![[^]]*?](s*)([^s()]+?)s*)]|(?:]|[^]])*])(s*)(([^s()]|([^s()]*?))+)s*(".*?")?)/g; </ins> private readonly referenceLinkPattern = /([((?:]|[^]])+)][s*?)([^s]]*?)]/g; private readonly definitionPattern = /^([t ]*[(?!^)((?:]|[^]])+)]:s*)(S+)/gm;

Related discussion:
text: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --Pasting the below into a markdown file will cause a cpu thread to be pinned at 100% because of catastrophic backtracking. fixes it.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.947 --<!-- potentialduplicatescomment --
This bug has been fixed in to the latest release of ! you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text to let us know. If not, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified
Code change:
]; return toDisposable(() => { <del> if (!ignoreDisposeAndBlur) { blurDisposable.dispose(); done(false); } </del> <ins> blurDisposable.dispose(); done(false, false); </ins> }); }

Related discussion:
text: <!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --Steps to Reproduce: rename on a top level file element in explorer view in single folder workspace in developer tools that the div for that file row contains multiple invisible children elements which are input element containers !
I can not reproduce this issue on my machine. How do you end the rename, with Esc, Enter or some other way? Are you doing anything else that is special?
I just press continuously. I can reproduce this easily on linux(ubuntu) and windows. The setup it's just a folder with a single file and I drag and drop the folder on vscode.
Yes I can reproduce now.
This might happen again on tomorrow's vscode insiders. Thus unlocking converstaion so we can open this issue if needed.
You are right I can repro this again.
Code change:
body { padding: 10px 20px; line-height: 22px; <del> max-width: 780px; </del> <ins> max-width: 882px; </ins> margin: 0 auto; }

Related discussion:
text: WebView width is limited to 780px. ! It shrinks all images included what makes them barely readable. What's the point of this limit? It should be set to either 100% or more reasonable 1200px, but would be best to manage it through <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.43 OS Version: Windows 10 Steps to Reproduce: any extension page including images in VSCode or hit Help -Release notes <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes and with all themes
Very long lines of text are not readable You can view the web release notes (or the ones on GitHub) if you want a different layout
seriously? Someone having problems with reading lines longer than 780px is the reason for this!? Do you even realise how ridiculous it is? And what exactly is a design problem here that it can't be managed by user settings like almost everything else? Please, reopen this issue.
You are welcome to submit a PR that makes images larger (while keeping the max text line length the same). However even the images should likely have a max width. See how GitHub and many other sites render readmes
My point exactly! GitHub's limit for content width is 882px and I believe it was also like that for VSCode few versions ago. Why it was lowered to 780px is inexplicable. Plus on GitHub you can actually click the image for full size. That's why even Microsoft often adds images 2000px+ width in readmes.
It is now 100px wider :)
Baby steps I'd rather make it 1200px or 100%, but I doubt it would be approved. Maybe someday it will be managed through settings for everyone's content... Thanks
Code change:
registration.dispose(); }); <del> let c = commands.executeCommand('vscode.diff').then(() => assert.ok(false), () => assert.ok(true)); let d = commands.executeCommand('vscode.diff', 1, 2, 3).then(() => assert.ok(false), () => assert.ok(true)); </del> <ins> let c = commands.executeCommand('vscode.diff', Uri.parse('sc:a'), Uri.parse('sc:b'), 'Title', { selection: new Range(new Position(1, 1), new Position(1, 2)) }).then(value => { assert.ok(value === void 0); registration.dispose(); }); </ins> <del> return Promise.all([a, b, c, d]); </del> <ins> let d = commands.executeCommand('vscode.diff').then(() => assert.ok(false), () => assert.ok(true)); let e = commands.executeCommand('vscode.diff', 1, 2, 3).then(() => assert.ok(false), () => assert.ok(true)); return Promise.all([a, b, c, d, e]); </ins> }); test('api-command: vscode.open', function () {

Related discussion:
text: For
Verify: write an extension that exercises the following APIs by passing in a selection as option and verify the selection is revealed and showing up in the opened editor: command API Provide a property of type to get it. !