jiebi/CodeConvo huggingface dataset:
Testing have a file that is empty run type the file is dirty close the window run !
This is tricky: on the main side we open one window as instructed from the command line with the file and we also open another window to restore backups. Since we do not actually know the files to restore on the main side (we just rely on the renderer side to do this), we are opening 2 windows without knowing that the same file ends up being opened 2 times. Imho what should happen is this: if we know that we are restoring empty windows with backups, we just add all the files (as instructed from the command line) to one of those empty windows to avoid that we open multiple windows. This should happen in method ideally. We do the same if we are about to open a window with a folder: all other files to open (or create) end up being opened in that window of the folder.
I have a PR up for this via though I am not sure this is the best fix :). Basically what it does is to see if upon startup we have windows opening with hot-exit files to restore (either folder or untitled). If we find any such window to open, we open files to open files to create files to diff inside the first of these windows that upon as a matter of restoring hot-exit data. So instead of getting an extra window opened for the files to open, they would open into the first window that is being opened as a matter of hot-exit restore. what do you think?
I think this is a pretty good fix. It seems to align with how the CLI works when windows are opened as well; instead of opening the files in the last active window, the first window to be restored is selected.
Ok, merged.
Type: <bBug</bWelcome - Learn the Fyndamentals Safely browse and edit code Workspace Trust Link 404 - page not found VS Code version: Code 1.91.1 (, 2024-07-09T22:06:49.809Z) OS version: Windows_NT x64 10.0. Modes: Restricted <!-- generated by issue reporter --
could you please provide a screenshot of where this broken link is? Thanks!
Got it - issue is in the walkthrough. Fix incoming. Thanks for signaling this
Is this a candidate? The change has been merged to the main branch but not the release branch, and so the fix is not in the latest Insiders.
IMO, it can go with the next one.
<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the label directly, or comment .
<!-- UNABLETOLOCATECOMMITMESSAGE --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.47.0 OS Version: macOS Catalina 10.15.5 Steps to Reproduce: Every time when I click File -New File, vscode always asks to select an Editor, but in the list, there is only one Built-in Text editor. it's just a very annoying unnecessary click. I don't know since when this has been , I believe it's a recent change. Tried to remove all the User settings and start without extensions, didn't help. See the screenshot. <img width="1086" alt="Screen Shot 2020-07-12 at 9 35 03 pm" src="https://user-"<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes
Hi, I would like to work on this issue if no one else is.
Sorry I did't claim before starting, I have fixed it, please correct me if the solution is not ok.
I removed all the User settings and extensions, useless
No worries. Go ahead
Checkout the screen capture below which shows totally broken views. Notice the view title in the bottom panel and the missing icon the secondary sidebar (in my setup the secondary sidebar is left, the primary is right). I suspect this is due to setting/view sync because I have connected a windows VM <img width="1494" alt="Screenshot 2024-01-23 at 12 10 56" src=""
Have you tried clicking on those broken views and found out what those views are?
Analysed the data provided by and this is what happened Windows machine has some obsolete custom view containers state (in pane composite bar) which we are not cleaning up . When sync started, this machine has pushed this state, for eg:Mac machine has accepted this state and started rendering this obsolete view container even though this does not exist. This seems to be a bug in pane composite bar that render view containers - it is rendering obsolete view containers placeholders even though they do not exists in the model.
verified by code review
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --Same issue as , just on a different version. <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.48 OS Version: Windows 10 <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Edit Possible reason: In , is missing. imports this script but it is not there. This might explain why the submit action does nothing. Edit 2 Thanks, for the workaround:  it in
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.803 --- <!-- score: 0.503 --- <!-- score: 0.499 --- <!-- score: 0.459 --- <!-- score: 0.449 --<!-- potentialduplicatescomment --
FYI, I was able to get it working by downloading and placing the following file.
Confirm, an old bug returned.
Where to place it?
Not exactly an old bug. It's more like the devs team forgot to bundle the 1 single script. See my edit of the OP.
I think the easiest workaround is to install the downgraded VSCode from the following link.
same on MacOS. Makes the whole tool useless as you can't click anything than force quit the application.
looks like this file needs to be explicitly listed somewhere here to be included in the build (I think the does not exist anymore and can be removed):
Sorry about the breakage. Thanks for narrowing down the issue.
Steps to verify: Clone cd basic-auth && open code-insiders Settings Proxy http://127.0.0.1:3129 Open developer tools fetch('') or perform any network request play with the auth dialog verify the auth dialog can be opened again once proxy config is changed
VSCode Version: Code 1.13.1 (, 2017-06-14T18:21:47.485Z) OS Version: Windows_NT ia32 10.0. Extensions: ; Steps to Reproduce: color theme "Quiet Light" F something !
What is the expected color? Is the color wrong for the text, the buttons?
I would expect that the color with the current status gets a little bit more contrast...
What do you mean by 'current status'? The box around the 'case sensitive' button?
You actually do not see it, 'cause its contrast is that bad :D ! I see that on a very old monitor, I'm curious it has more contrast than yours. :O
Same issue here. Confirm that the bug exists. It should be instead of Can I send a PR for this? EDIT - Looking at other light theme it should be more of a red color than a gray one. Example - Light( Visual Studio ) has
Testing Scenario: Have a webview editor extension installed that contributes for .txt. Create a new file. Enter something in it so it isn't empty. Save it as What should happen next? Currently, nothing happens. It stays in the default VS Code editor. It might make sense to have the choose editor quick pick open.
Fixing this was more challenging than expected, pushing to November
It looks like renaming works and opens in the custom editor per my preferences, but if I save an untitled file as in the issue, nothing happens.
Marking for April Custom editors use to open a custom editor in place of the default editor. When a untitled editor is saved, is called but this goes directly to which bypasses the . Let me know if there's some other event we can listen to to detect when an untitled editor is saved. I couldn't find anything while debugging through the code
I guess this needs to be wired in, PR welcome.
I believe this will also apply to notebooks. I'll let you know what I come up with
Assigning you since this seems like something we should think about for all editor types, including notebooks
I discussed this issue a bit with Kai and it doesn't sound like we will be fixing this any time soon. The main drive is for notebooks where you see "Hey this is a .ipnyb file, install the jupyter extension" and then the user clicks install but there ipnyb is still plain JSON. The goal for that is to allow rendering of those files without execution if no extension is installed. For the other cases it's not nearly as important as most files have a usable text editor type. We want to reduce the number of notifications as much as possible and switching the file for the user could be extremely jarring.
Since I just came across the relevant code, we have a way to replace an editor when it is saved (to a different path or when saving untitled): This code does not go through any override but rather takes the typed editor input as it was returned from the implementation. If we were to change that logic, we probably would have to ask method to return an untyped input without override, or at least make sure the text based editors don't set the override.
I think that there needs to be better UX if we were to implement this as a saveAs causing an editor type switch can be jarring.
I don't love the notification approach but maybe something along those lines. User gets prompted that there is an ew editor type for this resource -user can choose to switch or set automatic switching -editor switches. If automatic switching enabled we no longer prompt and just switch anyways for that resource type
Yup agreed, didn't mean to ask to solve this now, just wanted to keep track of the location in code where this is currently decided
To verify: an untitled file it as jupyter notebook should be created your setting to have the entry steps 1 and 2 with a different file name shouldn't switch to a notebook, it should stay as a text
I tried above steps with the GitHub issue notebook extension instead and when I come to step 5. and save an untitled editor as "", that editor actually closes.
My settings: My extensions: Video: !
Issue Type: <bBug</bThe cursor after pasting, I'd expect it to be at the end of the pasted text: ! VS Code version: Code - Insiders 1.26.0-insider (, 2018-08-02T05:12:16.245Z) OS version: Darwin x64 17.7.0 <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ 999-pack10.12.6 ssh0.0.4 github-issues-prs0.9.0 vscode-open-in-github1.7.0 </details<!-- generated by issue reporter --
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: Cloud Changes on the button: <img width="713" alt="image" src="https://user-"appears but no changes are made locally at least my change doesn't go away. Logs don't indicate anything interesting
I encountered this issue myself because I had branches that had the same name locally, but their upstream branches were set differently. My local workaround was to to get Cloud Changes to do the right thing, but the only way I figured this out was by looking at logs. It would be nice for Cloud Changes to at the very least show an error message or something when I click "Resume Working Changes" but it intentionally no-ops.
sorry, misclicked a label
While verifying I noticed that if I click on the warning I'm not taken to the size limit setting which I would've expected to be taken to. ! Version: 1.68.0-insider (Universal) Commit: Date: 2022-06-02T05:16:30.515Z Electron: 17.4.6 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Darwin x64 21.5.0 Jupyter Extension version (available under the Extensions sidebar): v2022.5. Python Extension version (available under the Extensions sidebar): v2022.7.
This link is specified in core code.
The issue doesn't seem to be fixed in the latest insiders. Reopening
The issue is now fixed for me in the latest Insiders, at least on Windows 11.
Type: <bBug from Marketplace which is a packaged version of fsprovider-sample Panel, switch to Output tab and choose Tasks channel. no folder or workspace open, run the command. the "Workspace folder was undefined" message. The message come from here: I think the task system is trying to do something (an onFolderOpen task?) for the memfs scheme before the task system for that scheme has been registered. As a minimum change I think the message should become "Task system for ${} is unavailable". Better, the message could be suppressed. Best, the sequencing could be revised so the task system registration for the FSP's scheme happens before it is first used. Further observation is that running does not produce the message again. VS Code version: Code 1.82.0 (, 2023-09-06T22:07:07.438Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
Note, this is not a new 1.82 problem. It also happened in 1.81.1.
I started looking at fixing this, but didn't find a path that calls for any schemes other than and . Should it also be getting called for schemes that s implement?
The "Workspace folder was undefined" message was introduced by Pinging and about what should happen for a scheme contributed by a FSP.
Scratch that - I believe I have answered my own question in the PR I just submitted.
Does this issue occur when all extensions are disabled?: I dont know VS Code Version: 1.88.0-insider OS Version: Windows 10 - 10.0. Build Steps to Reproduce: Start debugging python script. It creates a new "debugging terminal". This should work stop debugging debugging. If you look at the debugging terminal, you will see a input (generated by VS Code) then command for debugging the selected file. path of the is somehow truncated, hence cannot find the file. debugging is however starting: you will be prompted with the message: Timed out waiting for launcher to connect. As seen on the gif below: Path 1st time: (Correct path) Path 2nd time: (truncated path) !
I'm getting similar behaviour when using Git Bash as default profile. First time debugging the Python Debug Console opens and the application runs without issue: the subsequent times I sometimes get: ... which does in fact executes the code, but then I also sometimes get: I don't know what the call to comes from (possible the end of the directory name, but in in the last instance is not called. This inevitable gives this error. ! Which then starts a new Python Debug Console. Similar to what is above. I don't see this behaviour when using PowerShell or Cmd. IMO There's some weird truncation happening. Version: 1.88.0 (user setup) Commit: Date: 2024-04-03T13:26:18.741Z Electron: 28.2.8 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0.
Thank you for adding details! This is the exact same problem that I experience: I didn't try with another terminal (Powershell or Cmd). I will see if that can fix my problem temporary using .
As mentionned by This issue is not here using . However, this is still adding extra command that could be the explanation behind it: ! The first run it is only using: On the second run, it : before the command.
There is still the before this line though (2nd blank line)
I am seeing the problem when I set my default terminal profile to any of the following and run my debug launch script twice. Each shell will fail on the second launch with the same mangled command line. bash command prompt powershell Work around: revert back to vs code 1.87.
I am having a similar problem launching Python from VS.Code with or without debugging (both cmd and wt as terminal.external.windowsExec). If the path to the Python executable contains space as in default I end up with and an error message in the launched terminal window: Yet this works fine if I pick a Python interpreter from venv or somewhere else such that there is no space in path e.g. Curiously - the internal terminal and internal console work with either path
it seems sending the ctrl+c in a separate is not sufficient -- any suggestions?
If you want to execute something again we have a helper on the render process side , this conditionally sends a ^C and may wait for a shell integration prompt. That might work?
It looks like that does the same thing with a 100ms delay. I'll adopt the delay as well, see if that fixes it
please could you confirm when this will be released? It doesn't seem to have gone out in the latest April release. I've tried the insiders version and can't debug anything so it's even worse.
This is available on Insiders. Please open another issue with the details for not being able to debug anything; that's probably not related to this fix...
Can any of you verify that this is fixed in the newest version of VS Code Insiders? Thanks!
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
The external terminal launch is working with space in pythonInterpreter path () using both and as Windows Terminal in current: 1.89.1 and insiders 1.90.0 /verified
Running on version 1.90.0 I can not longer observe the truncation.
Summary: The sign-in link for Github in VSCode running through serve-web rotates ports in the 54xxx range, breaking any pre-set port forwarding for users connecting via SSH. This occurs regardless of any port option set with --port (taken from my comment in ) Does this issue occur when all extensions are disabled?: Yes VS Code Version: Insiders 1.82.0 OS Version: Mac OS 13.3 Steps to Reproduce: to the device hosting code via SSH, with local port forwarding for port 8000 enabled the remote device, launch serve-web with a browser window and navigate to the URL given by serve-web on settings sync, showing a github sign-in URL. Note the port is different than the default, requiring you to reconnect and add a new forwarded port Expected behavior: Setting the port with --port should (a) also determine the port used for sign-in, or (b) be a separate option so that SSH port forwarding does not require updating SSH config and reconnecting each time you need to sign in
is the github sign-in URL in step 4 coming from you?
This flow shouldn't actually happen in the remote case and instead the user should get the device code flow. Fixed this by disabling the local server flow in
Verification: turn on Settings Sync using GitHub when you go through the auth flow, you should get the Device Code Flow first
Testing This is sort of unrelated to the TPI, but when I inspect context keys on my terminal area, I notice that it has , even when the active terminal isn't using git bash. Here are my repro steps (not sure if this can be simplified): a terminal profile using an extension and launch the extension. git bash, then close it and open the extension-provided terminal profile. context keys on the extension-provided terminal instance. :bug:
I would like to solve this problem, if it is still an issue. Do you mind if I start?
sure!
After scanning some source, there seems no good way to solve this. Because is no way for extension to specify terminal type when (AFAIK) extension register a terminal profile ( ), and Windows, shell type is determined by some heuristic logic, based on executable string, and default to return . (For WSL, the shell type is always "undefined" in my quick experiment.) When terminal service try to update context key, it fallback to NOP if the shell type is , that's the behavior noticed at first place. See: For this issue to be solved, probably there should be a way for builtin terminal profile to specify shell type (so it works for all bultin profile in all platform), and for extension provided terminal profiles, maybe we can add more optional fields to or method to . As for the wierd behavior noticed currently, maybe we can set to "unknown", to make this state less confusing. But since that this behavior is already state in , I wonder this can be changed.
I think the problem is here: It should check if first, then set it even if it's undefined if
do you want to submit a PR since you investigated and found the problem?
Yes, I can submit a PR for this. But, before doing this, I need to confirm some detail. The current behavior is From A. If new terminal instance is created, and shell type of the new terminal istance is defined, update From B. If active terminal instance change, and shell type of the new terminal istance is defined, update C. If there is no terminal instance, reset D. otherwise, do nothing so the editor keeps last known when shell type is undefined during new terminal creation or active terminal change. If so, what value should be set on this case? should we set it to or just call ?
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.58.0-Insiders (insiders) OS Version: mac Steps to Reproduce: Cell Execution summary information is not passed to notebook deserializer PR submitted here /cc