jiebi/CodeConvo huggingface dataset:
Hovering inlay hints should show problems "underneath": !
Came here to report the same thing https://user-
This happens because inlay hint have their own hover which are anchored on a . The diagnostics hover explicitly checks for that and . Would be OK to pretend to be a "normal" range hover anchor so that I can get all the hovers together? Or should the diagnostics hover not check for the hover type?
The is used both by inlay hints (via ) and ghost text (directly instantiates it). I think in the case of inlay hints you would want that markers are rendered in the hover, but perhaps ghost text wouldn't want that they appear in the hover, it might want to show only these actions: <img width="598" alt="image" src="https://user-"My suggestion would be to add something to to be able to distinguish the two cases.
Can still repro this
Please update this issue with a real code snippet that allows to reproduce this, please update this issue with what you have tried. Thanks
I just found a reduce function in VS Code sources such as and replace the returned value with the void keyword such as
Something like this only gives a squiggle for the return value, not the arguments or anything with inline hints. To clarify, this will only work for squiggles that spawn across inline hints <img width="699" alt="Screenshot 2023-01-26 at 14 49 07" src="https://user-"
Hmm, maybe it's because it's in a function so the return value becomes incorrect? This in <img width="917" alt="image" src="https://user-"
Thanks for updating
Looks good to me. Version: 1.75.0-insider Commit: !
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- Version: 1.75.0-insider (Universal) Commit: Date: 2023-01-10T05:21:34.436Z Electron: 19.1.9 Chromium: 102.0.5005.194 16.14.2 V8: 10.2.154.23-electron.0 OS: Darwin arm64 22.2.0 Sandboxed: Yes Steps to Reproduce: an existing workspace folder with git a few branches with commits to switch branches list of branches does not display the recent branches on top the same workspace folder in vscode stable and the order is as expected
Issue Type: <bBug</bI remapped command to [Alt + V]. And such keybinding doesn't work. KeybindingService log is as follows. Keybinding seems to pass through vscode to terminal since when I run in terminal it registers keypresses. VS Code version: Code 1.67.2 (, 2022-05-17T18:23:40.286Z) OS version: Linux x64 5.15.41-1-MANJARO Restricted Mode: No Remote OS version: Linux x64 4.19.119-30.2 <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
This is working fine for me, I do see the warning that I don't understand though. any insights into what could be happening here? Could the soft dispatch teh terminal does be causing problems with this ignore single modifier thing?
Yes, I think is not dispatched through the keybinding service in this case. Looking again at the OP log: And comparing it with the output I see when binding to : Notice how the OP's log does not contain the keydown event for (i.e. this line ), but there are logs about being dispatched. I think the logs about being dispatched relate to the call the terminal does, but it looks to me that the keybinding service doesn't really get to dispatch the keyboard event, so it doesn't execute the command. I see how is making the log confusing so I will push a change to improve logging to better distinguish between and the real dispatch.
do you have or set in your
Yes I have enabled, but I didn't override . As far as I understand is included in by default.
It is but when is set to true it overrides as a convenience setting for users who use a lot of shell-based keybindings. If you're getting into needing to customize , I'd recommend setting back to false and tweaking instead. I checked the docs and it looks like this is already explained so I don't think there's anything we need to do on our end: !
ok, thanks a lot for your help
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Something has changed in the latest Insiders so our CI started to fail with errors (any branch but here is an ): Do you have any idea what might cause it so we can make changes on our side? Might it be something with your dependencies?
Runtime has no changes with insiders, this seems like a regression from the recent http proxy changes based on in upstream. Passing onto From a quick look the extension relies on package which makes network connection. it would be great if you can reduce the test case to a minimal extension sample for us to debug this issue further. Thanks!
Unfortunately, we haven't been able to isolate the issue for a minimal extension sample so far. To reproduce the problem, you can follow these steps: the and install the extension. the following commands in the terminal: When running all tests, you may observe multiple failures with the . However, when running the failed tests separately, they randomly may or may not fail again, which makes it hard to identify the cause of the issue. It is possible that your proxy patches might be the right place to look for further investigation.
Maybe a related discussion:
Found it. The place in our code that fails with the latest Insiders is . I created a so you can try it, but here is the code snippet for a quick look:
Thanks for putting together this test! My investigation so far: is called with resulting in the reported error when it calls here: The check at would prevent from being called when , but that is only with in 19.0.0.
Still need to check older versions to see if that check was backported and see if there is a way to test this assessment.
is available in 18.8.0 and 16.18.0, our exploration builds based on Node v18 has this change, you can use the builds from to verify the assessment.
The test does not reproduce the issue in the exploration build. Still trying to understand what is happening (please ignore the above code pointers) by looking at the code at the tag. I see the failing call to being triggered in : What I don't quite understand is that the callstack to with comes from : But at that line is supposed to call not as it appear in the callstack: Could you point me at the source that went into Electron? I believe that is not the exact same as that at
Electron pulls source from when building, what you are looking at is the correct one. I think the async stack is missing a trampoline calll, but you are seeing a write after shutdown stack same as
Thanks This looks like an upstream issue to me, should not be called when is already . I don't see the change in 18.15.0 (the version the exploration build is using) yet that might have fixed it.
We have reverted to the previous way of loading certificates as we are getting close to a release ().
We're seeing this again in our macos and Windows CI jobs for VSCode "Insiders" (not current VSCode stable version 1.82.2). Was node or electron updated in the last 2 days on VSCode Insiders?
There is fix in upstream for the above scenario, I will backport it to relevant release lines.
Could you confirm that todays Insiders build fixes the problem? Thanks!
Confirmed, thanks!
I just now noticed how the progress bar was a the very end of the quick pick but not below input box, I think it should be below input box because the progress is for what I typed. Steps: have some history entries in Cmd+P picker be on a slow OS (Windows) start to type and notice progress bar is below the history entries //cc
Seems like this might have been a regression at some point. for relocating it back near the input.
I like where it is now. To me it says "the results are still populating".
The reason I do not like it: the progress bar is at a non-deterministic location depending on the number of items the progress bar indicator is away from the location that triggers it (the input box)
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.61.0 (I've seen this before and see it on too) OS Version: MacOS 11.6 Steps to Reproduce: Have 2 editor groups in workspace. Open a search editor (Cmd+Shift+F [can't remember if that's a default or my custom keybinding]) it to the other editor group. something to search for. At this point, you have to scroll up to see the results.
I've been looking into this. Any ideas where to start? I see that the following code does get called, but doesn't seem to position it correctly. If I wrap in a for 500ms, it works, but that's not a good long term solution.
Testing Unfiltered notebook noob feedback: ! I was expecting a tooltip to tell me what it meant.
Agreed that we should add tooltip for it.
how would you interpret it if there was a tooltip that said "Execution Order"?
when you run all cells it goes in that order? I was expecting that to be sequential from the top?
It's the order that it was executed it, not the order it will execute in. Hopefully a user would figure that out if they run the cell and see it change.
oh, more explicit would be better then imo I also question why this is useful but I'm guessing this is a common notebooks feature elsewhere?
Yeah it's what people expect from Jupyter and can help you understand the state of the kernel
Thanks that needs to be localized though. btw if you are going to merge your change in, you can just commit directly, no PR needed
Bug ! vscode-inno- VS Code version: Code - Insiders 1.21.0-insider (, 2018-02-09T06:14:31.856Z) OS version: Windows_NT ia32 6.1.7601 <details<summarySystem Info</summary </detailsExtensions: none Reproduces without extensions
Thanks! Very interesting. Can you somehow check which process has an open handle on ? I usually use for this.
I have the same problem. Using Process Hacker, I got this result: !. Even after closing MEGAsync, I still get this problem. ! Here's the content of the log file: The last line means .
!
When VS Code isn't running, I can move/rename this file without problems.
BTW, my OS is Windows 7 Pro x64, not "Windows_NT ia32 6.1.7601" as reported by VS Code. What's your OS?
I'm on Windows 7 Pro x86 (6.1.7601 Service Pack 1 version 7601). I haven't tested on other architectures yet.
Love it that you guys are already collecting stuff for me. I'm getting a Windows 7 image and trying it out. Can you also give me the list of extensions you currently have installed?
It works for me: Windows 10 Home(Build .rs2_release.-1834) I'm paying attention to the next updates, perhaps I can give you the needle of information.
has no extensions it seems (according to his first post). For my part, I have plenty ones: <details<summaryExtensions</summary- Bracket Pair Colorizer C/C++ C# Clang-Format CMake Code Runner cpplint Debugger for Chrome Doxygen Doxygen Documentation Generator Git History Git Project Manager gitignore GitLens - Git supercharged HTML CSS Support HTML Snippets IntelliSense for CSS class names JavaScript (ES6) code snippets jshint LaTeX Compile LaTeX Preview LaTeX Workshop latex-formatter Markdown All In One Markdown PDF Markdown Preview Enhanced markdownlint mssql npm One Dark Pro PHP Debug PHP IntelliSense PowerShell Python Unicode Latex VS Live Share vscode-icons vscode-pdf </details
I could easily reproduce in Windows 7!
Perfect :)
I am having an issue updating Visual Studio Code - Insider's Build,
The log output from the installer is shown below: Feb 12 13:40:40.605 INFO Starting: C:Program FilesMicrosoft VS Code InsidersCode - , true Feb 12 13:40:40.668 INFO Checking for running Code - processes. (attempt 1) Feb 12 13:40:40.681 INFO Code - is running, wait a bit Feb 12 13:40:41.182 INFO Checking for running Code - processes. (attempt 2) Feb 12 13:40:41.193 INFO Code - is running, wait a bit Feb 12 13:40:41.694 INFO Checking for running Code - processes. (attempt 3) Feb 12 13:40:41.706 INFO Code - is running, wait a bit Feb 12 13:40:42.206 INFO Checking for running Code - processes. (attempt 4) Feb 12 13:40:42.218 INFO Code - is running, wait a bit Feb 12 13:40:42.719 INFO Checking for running Code - processes. (attempt 5) Feb 12 13:40:42.729 INFO Code - is running, wait a bit Feb 12 13:40:43.230 INFO Checking for running Code - processes. (attempt 6) Feb 12 13:40:43.240 INFO Code - is running, wait a bit Feb 12 13:40:43.741 INFO Checking for running Code - processes. (attempt 7) Feb 12 13:40:43.749 INFO Code - is running, wait a bit Feb 12 13:40:44.250 INFO Checking for running Code - processes. (attempt 8) Feb 12 13:40:44.258 INFO Code - is not running Feb 12 13:40:44.267 INFO Starting update, silent = true Feb 12 13:40:44.267 INFO doupdate: "C:Program FilesMicrosoft VS Code InsidersCode - ", Feb 12 13:40:44.373 INFO header: Header, id: Inno Setup Uninstall Log (b) 64-bit, app id: {1287CAD5-7C8D-410D-88B9-0D1EE4A83FF2},
app name: Visual Studio Code - Insiders, version: 1048, num recs: , end offset: , flags: 0x35, crc: 0x545ea7d9 Feb 12 13:40:44.374 INFO numrecs: Feb 12 13:40:44.374 INFO moveupdate: "C:Program FilesMicrosoft VS Code Insiders", _ Feb 12 13:40:44.374 INFO Delete: "bin" (attempt 1) Feb 12 13:40:44.374 INFO Delete: "Code - " (attempt 1) Feb 12 13:40:44.425 INFO Delete: "Code - " (attempt 2) Feb 12 13:40:44.626 INFO Delete: "Code - " (attempt 3) Feb 12 13:40:45.077 INFO Delete: "Code - " (attempt 4) Feb 12 13:40:45.877 INFO Delete: "Code - " (attempt 5) Feb 12 13:40:47.128 INFO Delete: "Code - " (attempt 6) Feb 12 13:40:48.929 INFO Delete: "Code - " (attempt 7) Feb 12 13:40:51.379 INFO Delete: "Code - " (attempt 8) Feb 12 13:40:54.585 INFO Delete: "Code - " (attempt 9) Feb 12 13:40:58.636 INFO Delete: "Code - " (attempt 10) Feb 12 13:41:03.636 INFO Delete: "Code - " (attempt 11) Feb 12 13:41:03.650 ERRO Access is denied. (os error 5) I suspect that this has quite a bit to do with how this laptop is configured by our IT dept. I am connected to a local domain with standard user privileges. In order to install any software on the laptop I am required to enter my local administrator account privileges. VSCode installs and runs just fine, the issue occurs when VSCode is self-updating. Once VSCode is loaded, it reports that it has an update and I click "Install Update..." when I click on the gear icon. VSCode then downloads the update.
When it completes the download, it requests that I restart VSCode and that's when this error is generated. I've tried running VSCode as the local administrator and follow the same steps above, but the issue still persists, any help that you can provide will be much appreciated!
What is your Windows version?
Oh, it looks like is loading up that DLL! Gotta figure out how to prevent it from doing so.
I saw your commit I tried to update my VSCode application after that but it doesn't seems to works. Though, I don't have the same errors. When I hit "Restart", I got this message error: ! The differences between the old problem: There is no more the little window telling that VSCode is updating (see below) ! The log file is different: EDIT: I'm still on the same architcture. Windows 7 Pro x86 (6.1.7601 Service Pack 1 version 7601)
- Windows 10 / Version 1703 / OS Build .850
Easy, I still haven't pushed the fix.
Oh... Indeed! Sorry about this, I thought changes were effective since I didn't get the same errors. I wanted to provide a little more information not putting any pressure on this. Thanks for your involvment in this issue, I'll be more careful next time! :)
OK pushed a fix to . Guys, tomorrow there'll be a new version. The background update step to get that version, from the current one, will still fail. But background updates should work successfully from that build onwards. So, make sure you get that build from tomorrow and try to get a background update Thursday or Friday. Let me know how that goes.
Your issue is separate. Let's move our discussion over here:
Nothing failed, it has simply successfully updated. :+1: !
Alright, I uninstalled VScode yesterday, reinstalled it and today, the background update worked, just as you said. Thanks once again! o/
Marking as verified. I use background update on Windows and it doesn't fail for me.
Opening the view menu I only see them screaming at me due to their size. Can we somehow decrease their size. The native mac arrows are slightly smaller. While visual studio on windows uses a much smaller version ! !
VSCode uses Electron's toolbar if I'm not mistaken. It is basically menus in Chromium and the drop down menu in Chrome, which have arrows larger then those shown in the screenshots. So unless the toolbar can be customized, I don't think it's possible to tweak the arrow size without creating a custom toolbar. Please correct me if I get anything wrong. Thank you.
This is the custom toolbar on the windows we are currently working on. So we could customize it here imho
+1 I think the arrow could be reduced a bit
Here's a recording demonstrating Insiders (left) and previous Stable 1.74 (right): https://user- Steps: the SCM view and add a long line the width of the side bar such that the text wraps Notice how: When selecting the entire buffer, the selection expands beyond the text When selecting a subrange, sometimes the start position of the selection moves The rounded corners is generally broken: not all corners are rounded any more. This applies even for 1.74.
points to and a manual bisect points to being the first bad commit
Reverting from the change fixes the rendering problem. This diff fixes the rendering problem: The root problem here is that it is not supported that the editor background color is transparent. The class name ".monaco-editor-background" is used to render rounded corners and that stops working if it is transparent.
Thank you Tested the changes the created a PR.
Thanks for fixing. This has been on my list for weeks and I've just been, well, slammed
Type: <bBug</bwith the following code in a javascript file: the symbol "UserClient" which is missing an import is not automatically imported. if i only remove the JSDoc Comment then it is already working. if i remove the return statement it is also working. i tried it with all extensions disabled, nothing. please fix this. VS Code version: Code 1.72.2 (, 2022-10-12T22:15:18.074Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ lit-html1.11.1 vscode-html-css1.13.1 lit-lang0.0.7 prettier-vscode9.9.0 csharp1.25.0 powershell2022.10.0 vscode-xml0.22.0 lit-plugin1.2.4 markdown-preview-enhanced0.6.3 blueprint3.0.0 markdown-all-in-one3.4.3 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Please share a minimal, self contained project that demonstrates the issue
Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our . Please take the time to review these and update the issue. Happy Coding!
note: is just a bundled version of the lit-html plugin. the project i'm using works has the requirement to work without any kind of build so we bundled the only npm dependency it had into this file. still looking for a better solution though...
I'm facing the same issue. and get executed as expected, but seems to not working. To reproduce, just open a TS project, set the to the option, remove an import from any source file and save. The imports gets organized but the missing imports doesn't get imported.
I even noticed that it still works under certain circumstances. like in my demo project, if you remove the JSDoc comment. something in the code context seems to be killing the import feature. but manual import still works (like with hovering the item, quick fix, import)
any updates, info requests, anything? did you find a lead, can you work on it?
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --This could include platform specific instructions. Curious to know which platforms we're talking about here... Windows for sure but what else? Does Raspbian ship git?
Hi, I would like to work on this please assign this to me.
thanks! We cannot assign you as you are not a member of this issue, but please feel free to submit a PR. The relevant code is here:
I can take this up if it's not already done. Could you elaborate on what new step needs to be ?
hello guys, i'm really trying to get started in contributing to open how i get started here?
Hello this is my first time contributing to an open source project and I'm willing to work on this issue. I just set this repo up on my machine and its working. I had a look at the file you've shared and there are conditions for few steps which checks if git is missing. So, I tried simulating the inexistence of git just by disabling it in vs code settings. Is that fine? And also, should there be a button which says "Install Git"? If yes, what should it be linked to? !
We can use I recommend testing this by fully removing git if at all possible, otherwise there my be unexpected behaviors when a new users is actually running this for the first time.
Is this complete, or I can still work on this?
I am not aware of any work done here.
Could you assign it to me? I would like to work on this quickly. Edit I guess, Only members can be assigned. So, I will open a PR and link to this issue.
Hello, I'm sorry I should've kept you updated but I've made those changes and I just have to test it out by uninstalling git.
I have tested with uninstalling git. Can I take this?
Omg I just did that to push. What do we do?
Just tested this on Windows, and the "Install Git" item is marked as ticked when you click on the "Install Git" button regardless of whether you have actually installed Git - is this expected?