jiebi/CodeConvo huggingface dataset:
Change:
In the comments overview, the date of the last reply is wrong. It looks like it took the date of the first comment: ! (cc
I have a fix for this, I'll send a PR.

Discussion:
templateData.repliesMetadata.container.style.display = ''; templateData.repliesMetadata.count.textContent = this.getCountString(commentCount); <del> templateData.repliesMetadata.lastReplyDetail.textContent = nls.localize('lastReplyFrom', "Last reply from {0}", node.element.replies[node.element.replies.length - 1].comment.userName); templateData.repliesMetadata.timestamp.setTimestamp(originalComment.comment.timestamp ? new Date(originalComment.comment.timestamp) : undefined); </del> <ins> const lastComment = node.element.replies[node.element.replies.length - 1].comment; templateData.repliesMetadata.lastReplyDetail.textContent = nls.localize('lastReplyFrom', "Last reply from {0}", lastComment.userName); templateData.repliesMetadata.timestamp.setTimestamp(lastComment.timestamp ? new Date(lastComment.timestamp) : undefined); </ins> } private getCommentThreadWidgetStateColor(state: CommentThreadState | undefined, theme: IColorTheme): Color | undefined {
Change:
As discussed in , we should let webviews make decisions based on the high contrast theme type. Proposed by cc
How should this be verified?
I think this can be verified by checking the style of the body in a webview? Here's one in stable with high-contrast light theme enabled: ! Here's the same one in insiders with same theme enabled: ! It would allow CSS rules based on the body having that class.
So something like so?
/verified Yeah that works for me. I used the webview-view-sample.
Yeah, in the webview ui toolkit so, hopefully, the vscode-high-contrast-light theme would be reflected there as well.
Which actually now that I look at screenshots more closely, it already is being reflected on the attribute
Also confirmed this works when working on a fix for the webview toolkit last week

Discussion:
<meta charset="UTF-8"> <meta http-equiv="Content-Security-Policy" <del> content="default-src 'none'; script-src 'sha256-xgIcbQmGjpT42GEj54VFSNh6MI15PZ2D1+DdVehfYBI=' 'self'; frame-src 'self'; style-src 'unsafe-inline';"> </del> <ins> content="default-src 'none'; script-src 'sha256-v9xEHcwDE5dc/lU7HYs5bG3LpPWGmQe0w/Vz6kmdd60=' 'self'; frame-src 'self'; style-src 'unsafe-inline';"> </ins> <!-- Disable pinch zooming --> <meta name="viewport"

} if (body) { <del> body.classList.remove('vscode-light', 'vscode-dark', 'vscode-high-contrast', 'vscode-reduce-motion', 'vscode-using-screen-reader'); </del> <ins> body.classList.remove('vscode-light', 'vscode-dark', 'vscode-high-contrast', 'vscode-high-contrast-light', 'vscode-reduce-motion', 'vscode-using-screen-reader'); </ins> if (initData.activeTheme) { body.classList.add(initData.activeTheme); <ins> if (initData.activeTheme === 'vscode-high-contrast-light') { // backwards compatibility body.classList.add('vscode-high-contrast'); } </ins> } if (initData.reduceMotion) {

enum ApiThemeClassName { light = 'vscode-light', dark = 'vscode-dark', <del> highContrast = 'vscode-high-contrast' </del> <ins> highContrast = 'vscode-high-contrast', highContrastLight = 'vscode-high-contrast-light', </ins> } namespace ApiThemeClassName {

switch (theme.type) { case ColorScheme.LIGHT: return ApiThemeClassName.light; case ColorScheme.DARK: return ApiThemeClassName.dark; <del> default: return ApiThemeClassName.highContrast; </del> <ins> case ColorScheme.HIGH_CONTRAST_DARK: return ApiThemeClassName.highContrast; case ColorScheme.HIGH_CONTRAST_LIGHT: return ApiThemeClassName.highContrastLight; </ins> } } }
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --When I start to type a command in the Debug Console, it suggests matching entries from my command history, which is great. However, the suggestions are presented in alphabetical order, instead of chronological order, which would be more intuitive. Most of the time, the debug console history is full of mistyped commands or iterations over the same function calls, and alphabetical order does not make sense here. Moreover, since the display of the preview of the command is shortened in the suggestion list, it is difficult (or impossible) to distinguish between many similar-looking commands. Having them listed from the newest to the oldest would clearly improve usability.
I don't have total control over the order of the filtered contents of the suggest widget currently, so we can't put history in a separate section and set the order. Because of this I find console history to be not that useful and I generally disable it: . However, it seems when commands are otherwise a tie in fuzzy filtering, I can change the order of the tie-breaking. For example, I evaluated in this order the first 3 that tie are sorted in recency order but the last is forced to the bottom due to being a worse match. Does this help at all? <img width="173" alt="image" src="https://user-"If not what you had in mind, maybe give an example

Discussion:
if (this.configurationService.getValue<IDebugConfiguration>('debug').console.historySuggestions) { const history = this.history.getHistory(); <del> history.forEach(h => suggestions.push({ </del> <ins> const idxLength = String(history.length).length; history.forEach((h, i) => suggestions.push({ </ins> label: h, insertText: h, kind: CompletionItemKind.Text, range: computeRange(h.length), <del> sortText: 'ZZZ' </del> <ins> sortText: 'ZZZ' + String(history.length - i).padStart(idxLength, '0') </ins> })); }
Change:
Testing in VS Code the following content Rename , shift + enter to show preview. Accept the preview Rename the same symbol again, shift + enter to show preview. Preview constantly spins. Clicking on the changes opens an empty side by side editor !

Discussion:
// Add opened files (such as untitled files) const openTextDocumentResults = await Promise.all(vscode.workspace.textDocuments <del> .filter(doc => !foundFiles.has(doc.uri.toString()) && isMarkdownFile(doc))); </del> <ins> .filter(doc => !foundFiles.has(doc.uri.toString()) && this.isRelevantMarkdownDocument(doc))); </ins> return coalesce([...onDiskResults, ...openTextDocumentResults]); }

})); this._register(vscode.workspace.onDidChangeTextDocument(e => { <del> if (isMarkdownFile(e.document)) { </del> <ins> if (this.isRelevantMarkdownDocument(e.document)) { </ins> this._onDidChangeMarkdownDocumentEmitter.fire(e.document); } })); } <ins> private isRelevantMarkdownDocument(doc: vscode.TextDocument) { return isMarkdownFile(doc) && doc.uri.scheme !== 'vscode-bulkeditpreview'; } </ins> public async getMarkdownDocument(resource: vscode.Uri): Promise<SkinnyTextDocument | undefined> { <del> const matchingDocument = vscode.workspace.textDocuments.find((doc) => doc.uri.toString() === resource.toString()); </del> <ins> const matchingDocument = vscode.workspace.textDocuments.find((doc) => this.isRelevantMarkdownDocument(doc) && doc.uri.toString() === resource.toString()); </ins> if (matchingDocument) { return matchingDocument; }
Change:
while testing a markdown file with a header a notebook with a markdown cell and link to that header the link in the rendered markdown result: vscode attempts to navigate to a file named note that both auto-complete and find references for the header work correctly for that link.

Discussion:
export type LinkHref = ExternalHref | InternalHref | ReferenceHref; <del> function parseLink( </del> <ins> function resolveLink( </ins> document: ITextDocument, link: string, ): ExternalHref | InternalHref | undefined {

return undefined; } <ins> // If we are in a notebook cell, resolve relative to notebook instead if (resourceUri.scheme === Schemes.notebookCell) { const notebook = vscode.workspace.notebookDocuments .find(notebook => notebook.getCells().some(cell => cell.document === document)); if (notebook) { resourceUri = resourceUri.with({ scheme: notebook.uri.scheme }); } } </ins> return { kind: 'internal', path: resourceUri.with({ fragment: '' }),

const linkStart = document.positionAt(offset); const linkEnd = document.positionAt(offset + link.length); try { <del> const linkTarget = parseLink(document, link); </del> <ins> const linkTarget = resolveLink(document, link); </ins> if (!linkTarget) { return undefined; }

for (const match of text.matchAll(autoLinkPattern)) { const link = match[1]; <del> const linkTarget = parseLink(document, link); </del> <ins> const linkTarget = resolveLink(document, link); </ins> if (linkTarget) { const offset = (match.index ?? 0) + 1; const linkStart = document.positionAt(offset);

if (noLinkRanges.contains(hrefRange.start)) { continue; } <del> const target = parseLink(document, text); </del> <ins> const target = resolveLink(document, text); </ins> if (target) { yield { kind: 'definition',

import { ITextDocument } from './types/textDocument'; import { Disposable } from './util/dispose'; import { isMarkdownFile } from './util/file'; <ins> import { Schemes } from './util/schemes'; </ins> import { MdDocumentInfoCache } from './util/workspaceCache'; import { IMdWorkspace } from './workspace';

} public static async createForDocumentOrNotebook(parser: IMdParser, document: ITextDocument): Promise<TableOfContents> { <del> if (document.uri.scheme === 'vscode-notebook-cell') { </del> <ins> if (document.uri.scheme === Schemes.notebookCell) { </ins> const notebook = vscode.workspace.notebookDocuments .find(notebook => notebook.getCells().some(cell => cell.document === document));

data: 'data:', vscode: 'vscode:', 'vscode-insiders': 'vscode-insiders:', <ins> notebookCell: 'vscode-notebook-cell', </ins> }; const knownSchemes = [
Change:
Version: 1.66.2 (Universal) Commit: Date: 2022-04-11T07:49:20.994Z Electron: 17.2.0 Chromium: 98.0.4758.109 16.13.0 V8: 9.8.177.11-electron.0 OS: Darwin arm64 21.4.0 This is the markdown under editing mode: <img width="1415" alt="image" src="https://user-"This is the markdown after exit editing mode: <img width="1454" alt="image" src="https://user-"
Markdown is actually handled by VS code core. Transferring the issue there.
Thank you
Please share a file (or text) that demonstrates the issue /needsMoreInfo
If the length of the markdown in a single markdown box exceeds a certain amount of volume, when I exit editing, it will show as the image presents: <img width="1430" alt="image" src="https://user-"However, when there are a limited amount of texts, the situation does not exist. <img width="1460" alt="image" src="https://user-"
For the detail part, I am not that sure, but I am sure it has something to do with the number of characters. And this situation doesn't happen when I put texts in separate markdown boxes.
Please share the notebook file itself
This is my notebook file on Google Drive:
Thanks

Discussion:
this.markdownAccessibilityContainer.id = id; // Hide the element from non-screen readers this.markdownAccessibilityContainer.style.height = '1px'; <ins> this.markdownAccessibilityContainer.style.overflow = 'hidden'; </ins> this.markdownAccessibilityContainer.style.position = 'absolute'; <del> this.markdownAccessibilityContainer.style.top = '10000px'; </del> <ins> this.markdownAccessibilityContainer.style.top = '100000px'; this.markdownAccessibilityContainer.style.left = '10000px'; </ins> this.markdownAccessibilityContainer.ariaHidden = 'false'; this.templateData.rootContainer.setAttribute('aria-describedby', id);
Change:
Text in TypeScript file: With the Light High Contrast theme, I don't see the unicode highlighting outline. !

Discussion:
export const editorBracketPairGuideActiveBackground5 = registerColor('editorBracketPairGuide.activeBackground5', { dark: '#00000000', light: '#00000000', hcDark: '#00000000', hcLight: '#00000000' }, nls.localize('editorBracketPairGuide.activeBackground5', 'Background color of active bracket pair guides (5). Requires enabling bracket pair guides.')); export const editorBracketPairGuideActiveBackground6 = registerColor('editorBracketPairGuide.activeBackground6', { dark: '#00000000', light: '#00000000', hcDark: '#00000000', hcLight: '#00000000' }, nls.localize('editorBracketPairGuide.activeBackground6', 'Background color of active bracket pair guides (6). Requires enabling bracket pair guides.')); <del> export const editorUnicodeHighlightBorder = registerColor('editorUnicodeHighlight.border', { dark: '#BD9B03', light: '#CEA33D', hcDark: '#ff0000', hcLight: '' }, nls.localize('editorUnicodeHighlight.border', 'Border color used to highlight unicode characters.')); export const editorUnicodeHighlightBackground = registerColor('editorUnicodeHighlight.background', { dark: '#bd9b0326', light: '#cea33d14', hcDark: '#00000000', hcLight: '' }, nls.localize('editorUnicodeHighlight.background', 'Background color used to highlight unicode characters.')); </del> <ins> export const editorUnicodeHighlightBorder = registerColor('editorUnicodeHighlight.border', { dark: '#BD9B03', light: '#CEA33D', hcDark: '#ff0000', hcLight: '#CEA33D' }, nls.localize('editorUnicodeHighlight.border', 'Border color used to highlight unicode characters.')); export const editorUnicodeHighlightBackground = registerColor('editorUnicodeHighlight.background', { dark: '#bd9b0326', light: '#cea33d14', hcDark: '#00000000', hcLight: '#cea33d14' }, nls.localize('editorUnicodeHighlight.background', 'Background color used to highlight unicode characters.')); </ins> // contains all color rules that used to defined in editor/browser/widget/editor.css
Change:
from Windows to Linux where zshell is installed, with shell integration turned on a new (zsh) terminal. Terminal remains empty a bash terminal. That works shell intergation and create a zsh terminal. That works Left side was created with shell integration on, right side was create  Let me know if there's any addition info to get.
It would be helpful if you could turn on trace logging and provide the logs

Discussion:
// Terminal shell integration 'out-build/vs/workbench/contrib/terminal/browser/media/shellIntegration.ps1', 'out-build/vs/workbench/contrib/terminal/browser/media/shellIntegration-bash.sh', <ins> 'out-build/vs/workbench/contrib/terminal/browser/media/shellIntegration-env.zsh', 'out-build/vs/workbench/contrib/terminal/browser/media/shellIntegration-profile.zsh', </ins> 'out-build/vs/workbench/contrib/terminal/browser/media/shellIntegration.zsh', '!**/test/**'
Change:
From in
Can't verify this because I'm no longer prompted to create a fork when I push to a repo that I don't have write access to.

Discussion:
return false; } <del> const match = /^(?:https://github.com/|git@github.com:)([^/]+)/([^/.]+)(?:.git)?$/i.exec(remoteUrl); </del> <ins> const match = /^(?:https://github.com/|git@github.com:)([^/]+)/([^/.]+)/i.exec(remoteUrl); </ins> if (!match) { return false; }
Change:
reported by
becomes undefined here
to verify: set your default profile to null add something to your such as an statement create a terminal ensure your file has been run

Discussion:
// to hang in resolver extensions if (!this.shellLaunchConfig.customPtyImplementation && this._configHelper.config.shellIntegration?.enabled && !this.shellLaunchConfig.executable) { const os = await this._processManager.getBackendOS(); <del> this.shellLaunchConfig.executable = (await this._terminalProfileResolverService.getDefaultProfile({ remoteAuthority: this.remoteAuthority, os })).path; </del> <ins> const defaultProfile = (await this._terminalProfileResolverService.getDefaultProfile({ remoteAuthority: this.remoteAuthority, os })); this.shellLaunchConfig.executable = defaultProfile.path; this.shellLaunchConfig.args = defaultProfile.args; this.shellLaunchConfig.icon = defaultProfile.icon; this.shellLaunchConfig.color = defaultProfile.color; this.shellLaunchConfig.env = defaultProfile.env; </ins> } await this._createProcess();
Change:
[X] Notebooks (.ipynb files) [ ] Interactive Window and/or Cell Scripts (.py files with #%% markers) I am trying to add an URL to jump to another file named in Chinese in the notebook markdown cell with the following code: But when I click, an error occurs: [![enter image description here][1]][1] There seems no encoding option that can be set for .ipynb file. (I tried to add a file in .vscode folder to set encoding, but it failed.) And there is no error when using jupyter-lab. So I think this might be a bug of vscode. [1]: Version: 1.66.2 (system setup) Commit: Date: 2022-04-11T07:46:01.075Z Electron: 17.2.0 Chromium: 98.0.4758.109 16.13.0 V8: 9.8.177.11-electron.0 OS: WindowsNT x64 10.0. v2022.4. No response No response No response No response_ Local
Excuse me, is this a bug?
Sorry to interrupt again, but the problem still exists. I have uploaded a test folder named GitHub-vscode-issue-, which is constructed as follows. Am I supposed to install the insider version? Open in vscode, and clicking will jump to correctly. ! However, clicking will pop up an error window. ! VS Code Version : 1.67.2 (system setup) : : 2022-05-17T18:15:52.058Z Electron: 17.4.1 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Windows_NT x64 10.0. Jupyter Extension Version v2022.5.
Updating to 1.68.1 solves the problem. Thanks!

Discussion:
linkToOpen = data.href; } else if (!/^[w-]+:/.test(data.href)) { const fragmentStartIndex = data.href.lastIndexOf('#'); <del> const path = fragmentStartIndex >= 0 ? data.href.slice(0, fragmentStartIndex) : data.href; </del> <ins> const path = decodeURI(fragmentStartIndex >= 0 ? data.href.slice(0, fragmentStartIndex) : data.href); </ins> if (this.documentUri.scheme === Schemas.untitled) { const folders = this.workspaceContextService.getWorkspace().folders; if (!folders.length) {
Change:
<img width="1440" alt="image" src="https://user-"If you think this is an issue, I would love to help to fix it. MacOS: 12.3.1 VSCode: 1.67.0-insider Typescript: 4.6.4

Discussion:
"console.error($1);" ], "description": "Log error to the console" <ins> }, "new Promise": { "prefix": "newpromise", "body": [ "new Promise((resolve, reject) => {", "t$TM_SELECTED_TEXT$0", "})" ], "description": "Create a new Promise" </ins> } }
Change:
For step 4 of , when I try publishing the branch, I get the error "Git: remote: Permission to joaomoreno/test-pr- denied to rzhao271." There is no option to create a fork: ! Originally posted by in
says: I got the same issue on the latest Insiders <img width="1202" alt="image" src="https://user-"Command output: Remote URL:
Can you give me exact steps?
I think I figured it out:
Verification: and clone a branch a change to and commit to push/publish that branch. Code should tell you that you can't push to that repo and will offer to fork the repository, accept.

Discussion:
return false; } <del> const match = /^(?:https://github.com/|git@github.com:)([^/]+)/([^/.]+)(?:.git)?$/i.exec(remoteUrl); </del> <ins> const match = /^(?:https://github.com/|git@github.com:)([^/]+)/([^/.]+)/i.exec(remoteUrl); </ins> if (!match) { return false; }
Change:
For step 4 of , when I try publishing the branch, I get the error "Git: remote: Permission to joaomoreno/test-pr- denied to rzhao271." There is no option to create a fork: ! Originally posted by in
says: I got the same issue on the latest Insiders <img width="1202" alt="image" src="https://user-"Command output: Remote URL:
Can you give me exact steps?
I think I figured it out:
Verification: and clone a branch a change to and commit to push/publish that branch. Code should tell you that you can't push to that repo and will offer to fork the repository, accept.

Discussion:
} catch (err) { if (/^error: failed to push some refs tob/m.test(err.stderr || '')) { err.gitErrorCode = GitErrorCodes.PushRejected; <ins> } else if (/Permission.*denied/.test(err.stderr || '')) { err.gitErrorCode = GitErrorCodes.PermissionDenied; </ins> } else if (/Could not read from remote repository/.test(err.stderr || '')) { err.gitErrorCode = GitErrorCodes.RemoteConnectionError; } else if (/^fatal: The current branch .* has no upstream branch/.test(err.stderr || '')) { err.gitErrorCode = GitErrorCodes.NoUpstreamBranch; <del> } else if (/Permission.*denied/.test(err.stderr || '')) { err.gitErrorCode = GitErrorCodes.PermissionDenied; </del> } throw err;
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.0-insider OS Version: Windows 10 Steps to Reproduce: a new VS Code Notebook Renderer using the to the description , it should be possible to override MIME types with built-in renderers, e.g.: tried to create a renderer replacing the renderer, but didn't realize it was buried under the following UI interface: ! ! For the output renderer I am authoring, I am mainly looking to augment the existing HTML renderer (ie. add a button above the existing output) so it wouldn't make sense to have users manually select it as a renderer option. Would it be possible to either make the renderer more discoverable or add some API to allow for the scenario I'm describing where it's mostly an augmentation and therefore should be shown by default? Thanks!
Verifier: when following to create a renderer extension, type in for the mimetype.

Discussion:
const enum ReuseOrder { PreviouslySelected = 1 << 8, SameExtensionAsNotebook = 2 << 8, <del> BuiltIn = 3 << 8, OtherRenderer = 4 << 8, </del> <ins> OtherRenderer = 3 << 8, BuiltIn = 4 << 8, </ins> } const preferred = notebookProviderInfo && this.preferredMimetype.getValue()[notebookProviderInfo.id]?.[mimeType];
Change:
the Settings editor. Notice the "Editor: Tab Size" setting has a link. over the link. :bug: There's no underline text decoration, and the cursor doesn't become a pointer.

Discussion:
margin: 0px; } <del> .settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-trust-description a:focus </del> <ins> .settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-trust-description a:focus, </ins> .settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-markdown a:focus { outline: 1px solid -webkit-focus-ring-color; outline-offset: -1px; text-decoration: underline; } <del> .settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-trust-description a:hover </del> <ins> .settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-trust-description a:hover, </ins> .settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-markdown a:hover { <ins> cursor: pointer; </ins> text-decoration: underline; }