jiebi/CodeConvo huggingface dataset:
Change:
Issue Type: <bBug</bI have noticed that every time I try to open an image on vs code, I get the error stated on the title no matter what image file type VS Code version: Code 1.39.2 (, 2019-10-15T15:33:00.827Z) OS version: Darwin x64 18.7.0 <details<summarySystem Info</summary </details<details<summaryExtensions (21)</summaryExtensionVersion ------ html-snippets0.2.1 vscode-browser-preview0.5.9 rails0.13.1 vscode-gemfile0.0.2 solargraph0.21.1 vscode-eslint1.9.1 code-runner0.9.14 vscode-rufo0.0.1 vscode-gutter-preview0.23.0 atom-keybindings3.0.6 vsliveshare1.0.1056 debugger-for-chrome4.12.0 erb0.1.1 LiveServer5.6.1 ActiveFileInStatusBar1.0.3 slim0.1.2 html-preview-vscode0.2.5 highlight-matching-tag0.9.5 simple-ruby-erb0.2.1 quokka-vscode1.0.257 erb-vscode-snippets0.0.4 </details<!-- generated by issue reporter --
Please share a screenshot of the error. Also, does this reproduce in the with all ?
I'm having the same issue on a feshly installed copy.
Found out the issue to be with the image file name. If the file name has % symbol in it, vscode does not show the image. <img width="708" alt="Screen Shot 2019-10-30 at 12 17 40 PM" src="https://user-"If, i remove the % symbol in my file name, vscode displays the image properly. Tested this both in current stable mac release and the insider build. Do let us know if you observe the same pattern.
Even i am facing the same problem and my image file name does not contain % character , resolve my issue.
My file doesn't contain the % character either and it's not working.

Discussion:
document.body.classList.remove('loading'); }); <del> image.src = decodeURI(settings.src); </del> <ins> image.src = settings.src; </ins> window.addEventListener('message', e => { switch (e.data.type) {

private getResourcePath(webviewEditor: vscode.WebviewPanel, resource: vscode.Uri, version: string) { switch (resource.scheme) { case 'data': <del> return encodeURI(resource.toString(true)); </del> <ins> return resource.toString(true); </ins> case 'git': // Show blank image <del> return encodeURI('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAAEElEQVR42gEFAPr/AP///wAI/AL+Sr4t6gAAAABJRU5ErkJggg=='); </del> <ins> return 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAAEElEQVR42gEFAPr/AP///wAI/AL+Sr4t6gAAAABJRU5ErkJggg=='; </ins> default: // Avoid adding cache busting if there is already a query string if (resource.query) { <del> return encodeURI(webviewEditor.webview.asWebviewUri(resource).toString(true)); </del> <ins> return encodeURI(webviewEditor.webview.asWebviewUri(resource).toString()); </ins> } <del> return encodeURI(webviewEditor.webview.asWebviewUri(resource).toString(true) + `?version=${version}`); </del> <ins> return encodeURI(webviewEditor.webview.asWebviewUri(resource).toString() + `?version=${version}`); </ins> } }
Change:
Notice the status bar in the bottom of the workbench: !
let me know if investigation suggests you are getting the wrong dimensions somehow
Any reliable repo steps?
This is weird, but surely reproducible. I can reproduce on my Windows 10 VM (running in QEMU/KVM, Linux host), screen resolution set to 1440x1050: Code. Make sure window is full screen. If it isn't, make it fullscreen, close it and launch Code again. to extension viewlet, search for Azure Repos extension and open it. for it to load and close it. it again. !
Not only status bar... <img width="1268" alt="2019-11-2211 45 08" src="https://user-"
My console also disappeared. This only happens when opening extensions with suggestions. <img width="987" alt="normal" src="https://user-"on extension that contains suggestions (Star mark in upper right corner). <img width="987" alt="contains-suggestions" src="https://user-"buttons are overwritten if there is too much suggestions text. <img width="810" alt="console-disappeared" src="https://user-"guess the problem is from div . I open the developer tools. add , can make console buttons reappear. <img width="1445" alt="try-to-fix" src="https://user-"
Reproduced using Visual Studio Code for MacOS System Info:
To repo, just open a recommended extension. This causes the page layout to be off since the recommendation makes the header taller

Discussion:
.extension-editor { height: 100%; overflow: hidden; <ins> display: flex; flex-direction: column; </ins> } .extension-editor .clickable {

} .extension-editor > .body { <del> height: calc(100% - 168px); </del> <ins> flex: 1; </ins> overflow: hidden; }
Change:
Steps to Reproduce: from web (Firefox) a file onto itself =the page navigates ! This may be a general tree issue, not sure.
It's 2013 all over again. !
Up for grab.

Discussion:
// Prevent native context menus in web this._register(addDisposableListener(this.domElement, EventType.CONTEXT_MENU, (e) => EventHelper.stop(e, true))); <ins> // Prevent default navigation on drop this._register(addDisposableListener(this.domElement, EventType.DROP, (e) => EventHelper.stop(e, true))); </ins> // Workbench Lifecycle this._register(workbench.onBeforeShutdown(event => { if (storageService.hasPendingUpdate) {
Change:
Similar to GitHub style or Keyboard Shortcuts GUI: <kbdCtrl</kbd

Discussion:
border-color: var(--vscode-textBlockQuote-border); } <ins> kbd { color: var(--vscode-editor-foreground); border-radius: 3px; vertical-align: middle; padding: 1px 3px; background-color: hsla(0,0%,50%,.17); border: 1px solid rgba(71,71,71,.4); border-bottom-color: rgba(88,88,88,.4); box-shadow: inset 0 -1px 0 rgba(88,88,88,.4); } .vscode-light kbd { background-color: hsla(0,0%,87%,.5); border: 1px solid hsla(0,0%,80%,.7); border-bottom-color: hsla(0,0%,73%,.7); box-shadow: inset 0 -1px 0 hsla(0,0%,73%,.7); } </ins> ::-webkit-scrollbar { width: 10px; height: 10px;
Change:
Issue Type: <bBug</b(I have fixed this myself and will send a pull request in a minute) Steps to reproduce: accessibility mode in settings. a new document and type: to the beginning and press Ctrl+Right. Expected behavior: Cursor should jump to the letter w - that is the beginning of the second word. This behavior would be consistent with word navigation in most other Windows programs, e.g. notepad, MS Word, Visual Studio - just to name a few. Actual behavior: Cursor jumps to the space immediately after the first word, and the screenreader announces "Hello". The biggest problem with this behavior is that screenreader users would have to relearn how they make small edits in text files. For example, if I want to delete the word "world" in my example, I would go to the beginning of the line and press Control+Right until my screenreader announces the word I'm interested in. And then, assuming that cursor at this point is at the beginning of the word, I would press delete 5 times. However, in VSCode the cursor would be at the end of the word, and I would end up deleting wrong part of the line. VS Code version: Code - Insiders 1.40.0-insider (, 2019-10-25T14:03:31.497Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </detailsExtensions: none <!-- generated by issue reporter --
FYI, I found related discussion here: , but that thread is now locked.

Discussion:
column = model.getLineMaxColumn(lineNumber); } } else if (wordNavigationType === WordNavigationType.WordAccessibility) { <ins> if (movedDown) { // If we move to the next line, pretend that the cursor is right before the first character. // This is needed when the first word starts right at the first character - and in order not to miss it, // we need to start before. column = 0; } </ins> while ( nextWordOnLine <del> && nextWordOnLine.wordType === WordType.Separator </del> <ins> && (nextWordOnLine.wordType === WordType.Separator || nextWordOnLine.start + 1 <= column ) </ins> ) { // Skip over a word made up of one single separator <ins> // Also skip over word if it begins before current cursor position to ascertain we're moving forward at least 1 character. </ins> nextWordOnLine = WordOperations._findNextWordOnLine(wordSeparators, model, new Position(lineNumber, nextWordOnLine.end + 1)); } if (nextWordOnLine) { <del> column = nextWordOnLine.end + 1; </del> <ins> column = nextWordOnLine.start + 1; </ins> } else { column = model.getLineMaxColumn(lineNumber); }

}); test('cursorWordAccessibilityRight', () => { <del> const EXPECTED = ['   /* Just| some|   more|   text| a|+= 3| +5|-3| + 7| */  |'].join('n'); </del> <ins> const EXPECTED = ['   /* |Just |some   |more   |text |a+= |3 +|5-|3 + |7 */  |'].join('n'); </ins> const [text,] = deserializePipePositions(EXPECTED); const actualStops = testRepeatedActionAndExtractPositions( text,
Change:
Steps to Reproduce: Format Document from command palette when there are multiple formatters placeholder for the box to choose which formatter to use says "Select a default formatter for Flow-files" (in my case, the language is set to "Flow") "Flow-files" is weird, I don't think there should be a hyphen: Also here, but I don't know how to repro this one:
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.537 --- <!-- score: 0.485 --- <!-- score: 0.47 --<!-- potentialduplicatescomment --
I will prepare a PR.

Discussion:
const langName = this._modeService.getLanguageName(document.getModeId()) || document.getModeId(); const silent = mode === FormattingMode.Silent; const message = !defaultFormatterId <del> ? nls.localize('config.needed', "There are multiple formatters for {0}-files. Select a default formatter to continue.", DefaultFormatter._maybeQuotes(langName)) </del> <ins> ? nls.localize('config.needed', "There are multiple formatters for '{0}' files. Select a default formatter to continue.", DefaultFormatter._maybeQuotes(langName)) </ins> : nls.localize('config.bad', "Extension '{0}' is configured as formatter but not available. Select a different default formatter to continue.", defaultFormatterId); return new Promise<T | undefined>((resolve, reject) => {

}; }); const langName = this._modeService.getLanguageName(document.getModeId()) || document.getModeId(); <del> const pick = await this._quickInputService.pick(picks, { placeHolder: nls.localize('select', "Select a default formatter for {0}-files", DefaultFormatter._maybeQuotes(langName)) }); </del> <ins> const pick = await this._quickInputService.pick(picks, { placeHolder: nls.localize('select', "Select a default formatter for '{0}' files", DefaultFormatter._maybeQuotes(langName)) }); </ins> if (!pick || !formatter[pick.index].extensionId) { return undefined; }

} else if (pick === configurePick) { // config default const langName = modeService.getLanguageName(model.getModeId()) || model.getModeId(); <del> const pick = await quickPickService.pick(picks, { placeHolder: nls.localize('select', "Select a default formatter for {0}-files", DefaultFormatter._maybeQuotes(langName)) }); </del> <ins> const pick = await quickPickService.pick(picks, { placeHolder: nls.localize('select', "Select a default formatter for '{0}' files", DefaultFormatter._maybeQuotes(langName)) }); </ins> if (pick && formatters[pick.index].extensionId) { configService.updateValue(DefaultFormatter.configName, formatters[pick.index].extensionId!.value, overrides); }

return commandService.executeCommand('editor.action.formatDocument'); } else { const langName = model.getLanguageIdentifier().language; <del> const message = nls.localize('no.provider', "There is no formatter for '{0}'-files installed.", langName); </del> <ins> const message = nls.localize('no.provider', "There is no formatter for '{0}' files installed.", langName); </ins> const choice = { label: nls.localize('install.formatter', "Install Formatter..."), run: () => showExtensionQuery(viewletService, `category:formatters ${langName}`)
Change:
when split terminal in chinese path,error!
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.609 --- <!-- score: 0.558 --- <!-- score: 0.557 --- <!-- score: 0.499 --- <!-- score: 0.499 --<!-- potentialduplicatescomment --
I think this is language's problem.English path is very well.
It looks like your report is missing some important information, See for more info on how to report actionable terminal issues.
Thanks for your reply! version: 1.39.2 submit: Data Time: 2019-10-15T15:33:00.827Z Electron: 4.2.10 Chrome: 69.0.3497.128 10.11.0 V8: 6.9.427.31-electron.0 OS: Darwin x64 19.0.0 !
Thanks, you can probably workaround this with this setting:
I has try this settings by your suggestion. And it really not error.Thanks!But this way to create a terminal is not my default way.When I create a new terminal.It go to its father's file path , not it is before. If has a way to realize my need? !
Yeah that's what the setting does, you can't get what you're after until we fix this bug.
OK!I understand.Thank you!
I guess this is obvious, but the problem also occurs with European characters (at least french), and very likely with Arabic, Japanese, Indian, Korean characters as well. I also switched to in order to work around the problem.
I had this issue with the project folder itself containing unicode (greek letters). To my surprise, the hack still worked, the new terminal now sucesfully launches in the project folder.
Also happens when the cwd is set via runInTerminal
Note that in the latter case, it's not just the cwd that's affected - it's also all the command line arguments.
good point, this is probably an issue in debug land actually or related to encoding in the shell. Reopening it.
To verifier: When testing make sure shell integration is off

Discussion:
return; } this._logService.trace('IPty#pid'); <del> exec('lsof -OPln -p ' + this._ptyProcess.pid + ' | grep cwd', (error, stdout, stderr) => { </del> <ins> exec('lsof -OPln -p ' + this._ptyProcess.pid + ' | grep cwd', { env: { ...process.env, LANG: 'en_US.UTF-8' } }, (error, stdout, stderr) => { </ins> if (!error && stdout !== '') { resolve(stdout.substring(stdout.indexOf('/'), stdout.length - 1)); } else {
Change:
<!-- Please search existing issues to avoid creating duplicates. --Currently the 'focusSearch' method is called directly after the 'clearSearchResults' method returns. I think they should be called in one function as they get called one after another anyways and effect the same widget. I propose to add the 'focus search' method to the code below.. Also.. there's an extra 'clear search' function in the settings editor that can be replaced by this code. <!-- Describe the feature you'd like. --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.508 --- <!-- score: 0.498 --<!-- potentialduplicatescomment --

Discussion:
clearSearchResults(): void { this.searchWidget.setValue(''); <ins> this.focusSearch(); </ins> } clearSearchFilters(): void {

this.searchWidget.setValue(query.trim()); } <del> clearSearch(): void { this.clearSearchResults(); this.focusSearch(); } </del> private createHeader(parent: HTMLElement): void { this.headerContainer = DOM.append(parent, $('.settings-header')); const searchContainer = DOM.append(this.headerContainer, $('.search-container')); <del> const clearInputAction = new Action(SETTINGS_EDITOR_COMMAND_CLEAR_SEARCH_RESULTS, localize('clearInput', "Clear Settings Search Input"), 'codicon-clear-all', false, () => { this.clearSearch(); return Promise.resolve(null); }); </del> <ins> const clearInputAction = new Action(SETTINGS_EDITOR_COMMAND_CLEAR_SEARCH_RESULTS, localize('clearInput', "Clear Settings Search Input"), 'codicon-clear-all', false, () => { this.clearSearchResults(); return Promise.resolve(null); }); </ins> const searchBoxLabel = localize('SearchSettings.AriaLabel', "Search settings"); this.searchWidget = this._register(this.instantiationService.createInstance(SuggestEnabledInput, `${SettingsEditor2.ID}.searchbox`, searchContainer, {

this._register(DOM.addDisposableListener(clearSearch, DOM.EventType.CLICK, (e: MouseEvent) => { DOM.EventHelper.stop(e, false); this.clearSearchResults(); <del> this.focusSearch(); </del> })); DOM.append(this.noResultsMessage, clearSearchContainer);
Change:
Issue Type: <bBug</bTesting: Steps: a with one or more npm scripts a and add one or more npm tasks but do not add a details field to each task the run tasks command that the npm scripts in have a details field shown but the npm task in does not Expected: All npm tasks/scripts to be rendered consistently. The npm task in should show the script as the detail field just like the ones in ! VS Code version: Code - Insiders 1.40.0-insider (, 2019-10-30T05:39:27.063Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (12)</summaryExtensionVersion ------ tslint1.0.44 vscode-github-releases-updater0.18.0 vscode-docker0.8.1 python2019.10. remote-containers0.82.0 remote-ssh0.47.2 remote-ssh-edit0.47.2 remote-ssh-explorer0.47.2 remote-wsl0.40.0 vscode-remote-extensionpack0.17.0 azure-account0.8.6 test-search-rg0.0.3 </details<!-- generated by issue reporter --
which of the tasks listed in your screen shot are from the If it , you have npm task detection turned on, and the script is also in your then it should show a detail (except for npm:install).
The npm install task is the one in
Sorry, seemed to close the issue by mistake while trying to paste a snippet from { "type": "npm", "script": "install", "problemMatcher": [] }
And this is in "scripts": { "test": "echo "Error: no test specified" && exit 1", "random": "do something else" },
Thank you! There is no detail to provide for install since it's not running a script defined in to pull the detail from. I figured there wasn't a good detail to show for it, but I'm all for it having a detail if there's something relevant we can put there. Is there something in particular that you want to see as the detail for the install task?
I just thought it should do similar to the scripts in the and show the script field?
I see, so it should just show "install" as the detail.
Upcoming behavior: !

Discussion:
result.push(task); }); // always add npm install (without a problem matcher) <del> result.push(createTask('install', 'install', folder, packageJsonUri, undefined, [])); </del> <ins> result.push(createTask('install', 'install', folder, packageJsonUri, 'install dependencies from package', [])); </ins> return result; }
Change:
! I suggest "Filter on Type" becomes "Filter on Typing" or "Filter on Keystrokes" to eliminate the confusion. I'm willing to prepare a PR for this if it's agreed. VS Code version: Code - Insiders 1.40.0-insider (, 2019-10-31T05:42:33.138Z) OS version: Windows_NT x64 10.0.
Actually, perhaps that menu option could reasonably be removed now that the widget appearing when you type also displays a toggle for that feature when hovered over: !
And/or maybe "Sort By: Type" should become "Sort By: Category" so it aligns with the helptext item from the quickopen field (or whatever it's called): !
I have kept the entry event after adopting the new tree because I assumed users would miss it ;-). Aligning the wording between outline and quick outline makes sense. So, two time category or maybe kind?
My vote is for 'Sort By: Type' to become 'Sort By: Category' Shall I go ahead and prepare a PR?
yeah, please go ahead

Discussion:
const group = this._register(new RadioGroup([ new SimpleToggleAction(this._outlineViewState, localize('sortByPosition', "Sort By: Position"), () => this._outlineViewState.sortBy === OutlineSortOrder.ByPosition, _ => this._outlineViewState.sortBy = OutlineSortOrder.ByPosition), new SimpleToggleAction(this._outlineViewState, localize('sortByName', "Sort By: Name"), () => this._outlineViewState.sortBy === OutlineSortOrder.ByName, _ => this._outlineViewState.sortBy = OutlineSortOrder.ByName), <del> new SimpleToggleAction(this._outlineViewState, localize('sortByKind', "Sort By: Type"), () => this._outlineViewState.sortBy === OutlineSortOrder.ByKind, _ => this._outlineViewState.sortBy = OutlineSortOrder.ByKind), </del> <ins> new SimpleToggleAction(this._outlineViewState, localize('sortByKind', "Sort By: Category"), () => this._outlineViewState.sortBy === OutlineSortOrder.ByKind, _ => this._outlineViewState.sortBy = OutlineSortOrder.ByKind), </ins> ])); const result = [ new SimpleToggleAction(this._outlineViewState, localize('followCur', "Follow Cursor"), () => this._outlineViewState.followCursor, action => this._outlineViewState.followCursor = action.checked),
Change:
IMHO using the keyboard modifier name in the action is not good, as IMHO the action name should describe what the action does, not one way in which the action is triggered. This gets very confusing when configuring . In this case, the definition preview is rendered in the editor hover with + hover. Perhaps a better name would be "Show Definition Preview Hover".
Thank you!
Release notes still use the old terminology: ! Version: 1.40.0-insider (user setup) Commit: Date: 2019-11-06T16:58:49.777Z Electron: 6.1.2 Chrome: 76.0.3809.146 12.4.0 V8: 7.6.303.31-electron.0 OS: Windows_NT x64 10.0.
stable release notes should have the updates, thanks for checking it out

Discussion:
} } <del> class ShowCtrlHoverAction extends EditorAction { </del> <ins> class ShowDefinitionPreviewHoverAction extends EditorAction { </ins> constructor() { super({ <del> id: 'editor.action.showCtrlHover', </del> <ins> id: 'editor.action.showDefinitionPreviewHover', </ins> label: nls.localize({ <del> key: 'showCtrlHover', </del> <ins> key: 'showDefinitionPreviewHover', </ins> comment: [ <del> 'Label for action that will trigger the showing of a ctrl+hover in the editor.', 'This allows for users to show the ctrl+hover without using the mouse.' </del> <ins> 'Label for action that will trigger the showing of definition preview hover in the editor.', 'This allows for users to show the definition preview hover without using the mouse.' </ins> ] <del> }, "Show Control Hover"), alias: 'Show Control Hover', </del> <ins> }, "Show Definition Preview Hover"), alias: 'Show Definition Preview Hover', </ins> precondition: undefined }); }

registerEditorContribution(ModesHoverController.ID, ModesHoverController); registerEditorAction(ShowHoverAction); <del> registerEditorAction(ShowCtrlHoverAction); </del> <ins> registerEditorAction(ShowDefinitionPreviewHoverAction); </ins> // theming registerThemingParticipant((theme, collector) => {
Change:
The command identifier passed to has a typo: . Although the method name under is properly spelled as Addressed by <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.39.2 OS Version: All versions Steps to Reproduce: these lines: the typo (lack of a ) when referring to the command identifier. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Does not apply

Discussion:
@IHostService private readonly hostService: IHostService ) { super(); <del> CommandsRegistry.registerCommand('workbench.extensions.installMissingDepenencies', () => this.installMissingDependencies()); </del> <ins> CommandsRegistry.registerCommand('workbench.extensions.installMissingDependencies', () => this.installMissingDependencies()); </ins> MenuRegistry.appendMenuItem(MenuId.CommandPalette, { command: { <del> id: 'workbench.extensions.installMissingDepenencies', </del> <ins> id: 'workbench.extensions.installMissingDependencies', </ins> category: localize('extensions', "Extensions"), title: localize('auto install missing deps', "Install Missing Dependencies") }