jiebi/CodeConvo huggingface dataset:
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.45.1 OS Version: OS X 10.15.5 Beta Steps to Reproduce: a text file whose name is just a number, e.g. , , etc to launch the file from the command line file is opened. If VSCode was closed, it starts and just shows the welcome screen. If VSCode is running, you see another VSCode icon bounce in the dock and go away. to file to something else, it works fine <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
I have a feeling we've seen this before?
yes I remember something was not right with our argv lib (minimist?) with regards to handling numbers?
Hi, was having this problem too and I think I found the cause We were discarding empty args as part of , however this would discard numbers too as they were not strings when the check took place Have made a PR to remedy this if that's ok

Discussion:
const remainingArgs: any = parsedArgs; // https://github.com/microsoft/vscode/issues/58177 <del> cleanedArgs._ = parsedArgs._.filter(arg => arg.length > 0); </del> <ins> cleanedArgs._ = parsedArgs._.filter(arg => String(arg).length > 0); </ins> delete remainingArgs._;
Change:
accepted a couple of update PRs recently. Can you please sync extensions/theme-seti/icons? Meanwhile, I noticed that file was falsely classified as type file. I am not sure if that's a real issue in the latest vscode release candidate, or just a non-reproducible problem caused by some peculiarity in my vscode dev env. Can you please take a look?
Also something worth mentioning is that WebP images lack the image icon whereas WebM videos does indeed have the video icon. Adding lines: and does indeed solves the issue.
can you please file a separate issue? Thanks.
NP sir .
thanks! While testing your PR, can you also please check the icon for file? There shouldn't be no icon assigned to it. Otherwise, that's a regression and I am happy to file an issue.
we don't have any references to files in our seti-ui directory and nearly all of our code is pulled directly from the seti repo, so i'm unsure where this is coming from. Please file a separate issue and can look into it. EDIT: after looking into this, it appears that files are : ! And we have refs for mod files in our built-in xml extension: So there is a clash there. I'd suggest you make a request on the seti-ui theme to set files to a go icon so there are no conflicts.
Verification steps: ensure that the following updates are reflected in the file explorer for file icons: use the new logo files point to the R icon files point to the TypeScript icon !

Discussion:
"git": { "name": "seti-ui", "repositoryUrl": "https://github.com/jesseweed/seti-ui", <del> "commitHash": "8f22764c37feb7f706465f5186132111a2401b6b" </del> <ins> "commitHash": "f3b2775662b0075aab56e5f0c03269f21f3f0f30" </ins> } }, "version": "0.1.0"

"fontCharacter": "E074", "fontColor": "#cc3e44" }, <del> "_rmd_light": { "fontColor": "#498ba7" }, "_rmd": { "fontColor": "#519aba" }, </del> "_rollup_light": { "fontCharacter": "E075", "fontColor": "#b8383d"

"test.tsx": "_react_2", "re": "_reasonml", "r": "_R", <del> "rmd": "_rmd", </del> <ins> "rmd": "_R", </ins> "erb": "_html_erb", "erb.html": "_html_erb", "html.erb": "_html_erb",

"sql": "_db", "swift": "_swift", "typescript": "_typescript", <del> "typescriptreact": "_react", </del> <ins> "typescriptreact": "_typescript", </ins> "xml": "_xml", "yaml": "_yml", "argdown": "_argdown",

"test.tsx": "_react_2_light", "re": "_reasonml_light", "r": "_R_light", <del> "rmd": "_rmd_light", </del> <ins> "rmd": "_R_light", </ins> "erb": "_html_erb_light", "erb.html": "_html_erb_light", "html.erb": "_html_erb_light",

"sql": "_db_light", "swift": "_swift_light", "typescript": "_typescript_light", <del> "typescriptreact": "_react_light", </del> <ins> "typescriptreact": "_typescript_light", </ins> "xml": "_xml_light", "yaml": "_yml_light", "argdown": "_argdown_light",

"npm-debug.log": "_npm_ignored_light" } }, <del> "version": "https://github.com/jesseweed/seti-ui/commit/8f22764c37feb7f706465f5186132111a2401b6b" </del> <ins> "version": "https://github.com/jesseweed/seti-ui/commit/f3b2775662b0075aab56e5f0c03269f21f3f0f30" </ins> }  No newline at end of file
Change:
Issue Type: <bBug</ba WSL window ! It looks similar to . A possible fix might be: cc: VS Code version: Code - Insiders 1.46.0-insider (, 2020-05-22T21:13:15.709Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ vscode-eslint2.1.5 gitlens10.2.1 EditorConfig0.15.1 graphql-for-vscode1.15.3 vscode-emacs-friendly0.9.0 remote-ssh0.51.0 remote-ssh-edit0.51.0 remote-wsl0.44.2 powershell-preview2020.5.0 debugger-for-chrome4.12.8 material-theme3.7.1 </details<!-- generated by issue reporter --
Seeing this too, trying to attach to a dotnet process in WSL 2 in both insiders and stable: ! Version: 1.46.0-insider (user setup) Commit: Date: 2020-05-26T05:47:43.684Z (9 hrs ago) Electron: 8.3.0 Chrome: 80.0.3987.165 12.13.0 V8: 8.0.426.27-electron.0 OS: WindowsNT x64 10.0. Version: 1.45.1 (system setup) Commit: Date: 2020-05-14T08:27:35.169Z Electron: 7.2.4 Chrome: 78.0.3904.130 12.8.1 V8: 7.8.279.23-electron.0 OS: WindowsNT x64 10.0.
Same problem here, right after upgrading from WSL 1 to WSL 2. Might be the same cause as and :
Also experiencing this with WSL 2 trying to debug using gdb (Attach)
I am reproducing this issue when trying to bring up the prompt textbox to select the process ID of the process to attach. Unfortunately, this PR did not fix the original reported issue My environment: WSL2 with Ubuntu 20.04. Omnisharp v1.22.1 Visual Studio Code Insiders: ! Is there a workaround? This issue has been around since at least June 2019.
You had a proposed fix for this a while ago that looked good to me, do you want to go ahead and check that in?

Discussion:
// Set numeric locale to ensure '.' is used as the decimal separator exec(`${ps} ${args}`, { maxBuffer: 1000 * 1024, env: { LC_NUMERIC: 'en_US.UTF-8' } }, (err, stdout, stderr) => { <del> if (err || stderr) { </del> <ins> // Silently ignoring the screen size is bogus error. See https://github.com/microsoft/vscode/issues/98590 if (err || (stderr && !stderr.includes('screen size is bogus'))) { </ins> reject(err || new Error(stderr.toString())); } else { parsePsOutput(stdout, addToTree);

addToTree(parseInt(matches[1]), parseInt(matches[2]), matches[5], parseFloat(matches[3]), parseFloat(matches[4])); } } <del> } </del>  No newline at end of file <ins> } </ins>
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.45.1 commit OS Version: macOS 10.15 Sorry in advance if this is the wrong place for the issue, I'm not sure if this belongs in one of the LSP client library packages. Either way hover boxes, from LSP plugins, seem to render horizontal rules () a bit off: <img width="652" alt="image" src="https://user-"The horizontal rule is slightly cutting through the line beginning with "throw" Steps to Reproduce: a language server that produces a horizontal rule ( uses this) a hover? <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No I'm not sure how to reproduce this without using a language server extension!
the easiest would be if you start with this at the Haskell language server repository. What I would need is the generated markdown of the hover to investigate. You can link to this issue so that the Haskell devs can provide it.
Here's some markdown string we are sending via the hover request haskelln :: SessionException -IO ByteStringnhaskelln :: forall a e. Exception e =e -anhaskellnthrow :: forall a e. Exception e =e -an It looks like there is a blank line between the horizontal rule and where the third markdown block begins
Got a more minimal example <img width="104" alt="image" src="https://user-"from the markdown: haskellnLine 3n
Thanks for the fix!
can you mark the bug as verified since you reviewed and tested the PR.

Discussion:
} .monaco-hover p, <ins> .monaco-hover .code, </ins> .monaco-hover ul { margin: 8px 0; }

.monaco-hover hr { margin-top: 4px; <del> margin-bottom: -6px; </del> <ins> margin-bottom: -4px; </ins> margin-left: -10px; margin-right: -10px; height: 1px; } .monaco-hover p:first-child, <ins> .monaco-hover .code:first-child, </ins> .monaco-hover ul:first-child { margin-top: 0; } .monaco-hover p:last-child, <ins> .monaco-hover .code:last-child, </ins> .monaco-hover ul:last-child { margin-bottom: 0; }
Change:
Testing Currently the command is always in the command palette. I would expect it to appear only when I am in the middle of a rebase. Not sure if we could introduce some context keys which would be true when we are in the middle of the rebase. And then use those context keys as part of the commands clause
Since triggering it outside of a rebase produces this expected error. Do we polish the message, since it looks a bit strange with the double !
Verification steps: Launch VS Code and close existing folder if needed Verify that command is not available in the command palette Open a Git repository Verify that command is not available in the command palette Switch to the SCM viewlet, and click on --- Verify that an information notification is displayed noting that there is no rebase in progress Use the steps from to rebase a topic branch on top of the main branch Verify that command is available in the command palette Invoke the command from the command palette Verify that command is available in the command palette

Discussion:
"when": "config.git.enabled && !git.missing && gitOpenRepositoryCount != 0" }, { <ins> "command": "git.rebaseAbort", "when": "config.git.enabled && !git.missing && gitOpenRepositoryCount != 0 && gitRebaseInProgress" }, { </ins> "command": "git.commitNoVerify", "when": "config.git.enabled && !git.missing && config.git.allowNoVerifyCommit && gitOpenRepositoryCount != 0" },

@command('git.rebaseAbort', { repository: true }) async rebaseAbort(repository: Repository): Promise<void> { <del> await repository.rebaseAbort(); </del> <ins> if (repository.rebaseCommit) { await repository.rebaseAbort(); } else { await window.showInformationMessage(localize('no rebase', "No rebase in progress.")); } </ins> } private createCommand(id: string, key: string, method: Function, options: CommandOptions): (...args: any[]) => any {

import * as fs from 'fs'; import * as path from 'path'; <del> import { CancellationToken, Command, Disposable, Event, EventEmitter, Memento, OutputChannel, ProgressLocation, ProgressOptions, scm, SourceControl, SourceControlInputBox, SourceControlInputBoxValidation, SourceControlInputBoxValidationType, SourceControlResourceDecorations, SourceControlResourceGroup, SourceControlResourceState, ThemeColor, Uri, window, workspace, WorkspaceEdit, FileDecoration } from 'vscode'; </del> <ins> import { CancellationToken, Command, Disposable, Event, EventEmitter, Memento, OutputChannel, ProgressLocation, ProgressOptions, scm, SourceControl, SourceControlInputBox, SourceControlInputBoxValidation, SourceControlInputBoxValidationType, SourceControlResourceDecorations, SourceControlResourceGroup, SourceControlResourceState, ThemeColor, Uri, window, workspace, WorkspaceEdit, FileDecoration, commands } from 'vscode'; </ins> import * as nls from 'vscode-nls'; import { Branch, Change, GitErrorCodes, LogOptions, Ref, RefType, Remote, Status, CommitOptions, BranchQuery } from './api/git'; import { AutoFetcher } from './autofetch';

} this._rebaseCommit = rebaseCommit; <ins> commands.executeCommand('setContext', 'gitRebaseInProgress', !!this._rebaseCommit); </ins> } get rebaseCommit(): Commit | undefined {
Change:
Refs: have a folder with a few files drag and drop into web file explorer drag and drop the folder again Observe: Multiple dialogs appear that ask whether to replace the existing files/folder: first for the folder then for the individual files From this behaviour I assume that the drag and drop is not a "replace" but a "merge". This is confirmed by adding another file into the original folder and then dnd it again. Or empty the original folder and then dnd it only asks for the folder but leaves the existing containing files alone. But this "Merge" semantics needs a completely different UI than "Replace": it is not necessary to ask for replacing the folder because there will be more questions for the individual files inside anyways. the dialog needs three buttons: "replace", "do not replace", and "cancel" Alternatively you could implement the "Replace" logic. In this case there is no need to ask for the individual files inside a folder if the whole folder is replaced anyway. A third option is to ask initially whether to "Replace" or to "Merge" and then have different UI for the two strategies.
Will check how the explorer does this, we may behave the same already for native drops.
The simplest solution is to implement the "Replace" strategy. That's what macOS Finder does. IIRC Windows implements the "Merge" strategy.
Yes this is also how our non web explorer behaves. So we will show a dialog for each conflict. We do not allow to bulk cancel. Since this can be handled in the Explorer, unassigning from and renaming I am opening this up for PRs. Code pointer
via the solution is to ask for each thing that gets uploaded and then delete it upfront. This means, when you are being asked to replace a folder, you will not be asked for each file within. It will be a "Replace" and not "Merge".

Discussion:
title: localize('uploadingFiles', "Uploading") }, async progress => { for (let entry of entries) { <ins> // Confirm overwrite as needed if (target && entry.name && target.getChild(entry.name)) { const { confirmed } = await this.dialogService.confirm(getFileOverwriteConfirm(entry.name)); if (!confirmed) { continue; } await this.workingCopyFileService.delete(joinPath(target.resource, entry.name), { recursive: true }); } // Upload entry </ins> const result = await this.doUploadWebFileEntry(entry, target.resource, target, progress, operation, cts.token); if (result) { results.push(result);

return undefined; } <del> const resource = joinPath(parentResource, entry.name); // Confirm overwrite as needed if (target && target.getChild(entry.name)) { const { confirmed } = await this.dialogService.confirm(getFileOverwriteConfirm(resource.path)); if (!confirmed) { return undefined; } } if (token.isCancellationRequested) { return undefined; } </del> // Report progress let totalBytesUploaded = 0; const reportProgress = (fileSize: number, bytesUploaded: number): void => {

reportProgress(0, 0); // Handle file upload <ins> const resource = joinPath(parentResource, entry.name); </ins> if (entry.isFile) { const file = await new Promise<File>((resolve, reject) => entry.file(resolve, reject));
Change:
Testing I wouldn't expect joining a cell with the next cell to put the next cells first line on the same line at this cells last line. I think in most cases people wont leave trailing newlines, but they would expect joined cells to not mangle themselves. Similarly for splitting, I think we should remove dangling newlines.

Discussion:
if (!above.hasModel()) { return null; } <del> const insertContent = cell.getText(); </del> <ins> const insertContent = (cell.textModel?.getEOL() ?? '') + cell.getText(); </ins> const aboveCellLineCount = above.textModel.getLineCount(); const aboveCellLastLineEndColumn = above.textModel.getLineLength(aboveCellLineCount); above.textModel.applyEdits([

return null; } <del> const insertContent = below.getText(); </del> <ins> const insertContent = (cell.textModel?.getEOL() ?? '') + below.getText(); </ins> const cellLineCount = cell.textModel.getLineCount(); const cellLastLineEndColumn = cell.textModel.getLineLength(cellLineCount);
Change:
Following the discussion in Repro steps on Windows: use a monospace font, make sure ligatures are not used, etc. (i.e. default editor related settings) change the scale setting of the display the editor decorations / selection should render correctly (on top of the correct text) (the problem was that the font measurements done with a certain display scale were used across all display scales).

Discussion:
this.setFullScreen(false); this.setFullScreen(true); } <ins> this.sendWhenReady('vscode:displayChanged'); </ins> }, 100)); const displayChangedListener = () => simpleFullScreenScheduler.schedule();

import { AutoSaveMode, IFilesConfigurationService } from 'vs/workbench/services/filesConfiguration/common/filesConfigurationService'; import { Event } from 'vs/base/common/event'; import { INativeWorkbenchEnvironmentService } from 'vs/workbench/services/environment/electron-browser/environmentService'; <ins> import { clearAllFontInfos } from 'vs/editor/browser/config/configuration'; </ins> export class NativeWindow extends Disposable {

this.notificationService.info(message); }); <ins> ipc.on('vscode:displayChanged', (event: IpcEvent) => { clearAllFontInfos(); }); </ins> // Fullscreen Events ipc.on('vscode:enterFullScreen', async () => { await this.lifecycleService.when(LifecyclePhase.Ready);
Change:
Following the discussion in Repro steps on Windows: use a monospace font, make sure ligatures are not used, etc. (i.e. default editor related settings) change the scale setting of the display the editor decorations / selection should render correctly (on top of the correct text) (the problem was that the font measurements done with a certain display scale were used across all display scales).

Discussion:
<del> 2019-08-30T20:24:23.714Z </del> <ins> 2020-10-05T20:24:23.714Z </ins>

"opn": "^6.0.0", "optimist": "0.3.5", "p-all": "^1.0.0", <del> "playwright": "0.15.0", </del> <ins> "playwright": "1.0.1", </ins> "pump": "^1.0.1", "queue": "3.0.6", "rcedit": "^1.1.0",

dependencies: find-up "^3.0.0" <del> playwright-core@=0.15.0: version "0.15.0" resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-0.15.0.tgz#c605c98a13c81d5a2e2691f15d04758cf302c20a" integrity sha512-uTm4PoF2U3iXkLMMG9vlTxlGfO8atQGAHDxqi8xV7hEjNSYeLTU7c6HN5zwadeHRVuBbNsZ4yqu9u4hoqC7uxQ== </del> <ins> playwright-core@=1.0.1: version "1.0.1" resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.0.1.tgz#823b6f1afa16917ffd418f3cec0c14688a985738" integrity sha512-a71FjUDRFqWLG3VBAojVen2TaZiXkuog+ZmI0Nh0+/QndFUbbW3kameOfUTMXFvLUGWx2ipERZx6EQTJMEQDMA== </ins> dependencies: debug "^4.1.1" extract-zip "^2.0.0"

rimraf "^3.0.2" ws "^6.1.0" <del> playwright@0.15.0: version "0.15.0" resolved "https://registry.yarnpkg.com/playwright/-/playwright-0.15.0.tgz#bf5c3bb8404975aba78459310742388c08438431" integrity sha512-UGHkQz8DT43uJ0KgMh2rmj8BI4FE5ReQJ9nm5mG68tt1Cj2sXPdM2b05qptfYYBPtQRetQqtJTauZ6rlCDemaQ== </del> <ins> playwright@1.0.1: version "1.0.1" resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.0.1.tgz#326d479829a3505799ddc9988cc8decf5a7f8376" integrity sha512-kVTE7uvZ7OcDVOBx7MVArUm2nbzzzpauKV9tuVIAH6vWGsOWbGGALUoTWMzNDzsPPTBJXXmxzC4KgI2zN+kVhw== </ins> dependencies: <del> playwright-core "=0.15.0" </del> <ins> playwright-core "=1.0.1" </ins> plist@^3.0.1: version "3.0.1"
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --Version: 1.46.0-insider Commit: Date: 2020-06-05T12:27:56.662Z (2 days ago) Electron: 7.3.1 Chrome: 78.0.3904.130 12.8.1 V8: 7.8.279.23-electron.0 OS: Darwin x64 18.7.0 Running "Run Start Debugging" after running "Run Start Without Debugging" does not start debugging. Close inspection revealed that of the passed to DebugConfigurationProvider's remains . Steps to Reproduce: the vscode debug adapter sample the mock extension . a breakpoint at  the extension (F5) a in the extension development host. "Run Start Without Debugging" (Ctrl+F5) from the extension development host, and select . the breakpoint hit, and evaluate . ! back to the extension development host, and stop the task. "Run Start Debugging" (F5) from the extension development host this time, and select . the breakpoint hit, and evaluate 'config'. ! You can see (the second row) is set true even though it's requested to debug. Actually, I see that if I start with F5 first, and try Ctrl+F5 later, the second run receives DebugConfiguration without property. So, it seems like the value chosen in the very first run remains unchanged in the subsequent task runs.
great catch! I have pushed a fix for this which will be available in vscode insiders tomorrow.
The fix works for me in Insiders when using . The new seems to ignore the property in launch configs.

Discussion:
config = Object.create(null); } const unresolvedConfig = deepClone(config); if (options && options.noDebug) { config!.noDebug = true; <ins> } else { delete config!.noDebug; </ins> } if (!type) {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.35.0 OS Version: OSX 10.15.5 Steps to Reproduce: the 'forin' code snippet. Watch as hasOwnProperty is employed. eslint with eslint:recommended and watch the lint tool fail. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes

Discussion:
"prefix": "forin", "body": [ "for (const ${1:key} in ${2:object}) {", <del> "tif (${2:object}.hasOwnProperty(${1:key})) {", </del> <ins> "tif (Object.prototype.hasOwnProperty.call(${2:object}, ${1:key})) {", </ins> "ttconst ${3:element} = ${2:object}[${1:key}];", "tt$0", "t}",