Change:
Sometimes the tree sticky show shadow does not show. Make sure they use the proper overrides and that there is a default color if none is provided
are there any validation steps here?
verified- the scm sticky scroll showed on insiders, but not stable.

Discussion:
treeInactiveIndentGuidesStroke: asCssVariable(treeInactiveIndentGuidesStroke), treeStickyScrollBackground: undefined, treeStickyScrollBorder: undefined, <del> treeStickyScrollShadow: undefined, </del> <ins> treeStickyScrollShadow: asCssVariable(scrollbarShadow), </ins> tableColumnsBorder: asCssVariable(tableColumnsBorder), tableOddRowsBackgroundColor: asCssVariable(tableOddRowsBackgroundColor), };

import { IProductService } from 'vs/platform/product/common/productService'; import { SeverityIcon } from 'vs/platform/severityIcon/browser/severityIcon'; import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; <del> import { SIDE_BAR_BACKGROUND } from 'vs/workbench/common/theme'; </del> import { IViewDescriptorService, ViewContainerLocation } from 'vs/workbench/common/views'; import { IOpenerService } from 'vs/platform/opener/common/opener'; import { IPreferencesService } from 'vs/workbench/services/preferences/common/preferences';

return localize('extensions', "Extensions"); } }, <del> overrideStyles: { listBackground: SIDE_BAR_BACKGROUND }, </del> <ins> overrideStyles: this.getLocationBasedColors().listOverrideStyles, </ins> openOnSingleClick: true }) as WorkbenchPagedList<IExtension>; this._register(this.list.onContextMenu(e => this.onContextMenu(e), this));

import { WorkbenchList } from 'vs/platform/list/browser/listService'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IViewDescriptorService } from 'vs/workbench/common/views'; <del> import { SIDE_BAR_BACKGROUND } from 'vs/workbench/common/theme'; </del> import { IOpenerService } from 'vs/platform/opener/common/opener'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; import { RepositoryActionRunner, RepositoryRenderer } from 'vs/workbench/contrib/scm/browser/scmRepositoryRenderer';

this.list = this.instantiationService.createInstance(WorkbenchList, `SCM Main`, listContainer, delegate, [renderer], { identityProvider, horizontalScrolling: false, <del> overrideStyles: { listBackground: SIDE_BAR_BACKGROUND }, </del> <ins> overrideStyles: this.getLocationBasedColors().listOverrideStyles, </ins> accessibilityProvider: { getAriaLabel(r: ISCMRepository) { return r.provider.label;

import { FileKind } from 'vs/platform/files/common/files'; import { compareFileNames, comparePaths } from 'vs/base/common/comparers'; import { FuzzyScore, createMatches, IMatch } from 'vs/base/common/filters'; <del> import { IViewDescriptorService, ViewContainerLocation } from 'vs/workbench/common/views'; </del> <ins> import { IViewDescriptorService } from 'vs/workbench/common/views'; </ins> import { localize } from 'vs/nls'; import { IStorageService, StorageScope, StorageTarget } from 'vs/platform/storage/common/storage'; import { EditorResourceAccessor, SideBySideEditor } from 'vs/workbench/common/editor'; <del> import { SIDE_BAR_BACKGROUND, PANEL_BACKGROUND } from 'vs/workbench/common/theme'; </del> import { CodeEditorWidget, ICodeEditorWidgetOptions } from 'vs/editor/browser/widget/codeEditor/codeEditorWidget'; import { IEditorConstructionOptions } from 'vs/editor/browser/config/editorConfiguration'; import { getSimpleEditorOptions } from 'vs/workbench/contrib/codeEditor/browser/simpleEditorOptions';

identityProvider: new SCMResourceIdentityProvider(), sorter: new SCMTreeSorter(() => this.viewMode, () => this.viewSortKey), keyboardNavigationLabelProvider: this.instantiationService.createInstance(SCMTreeKeyboardNavigationLabelProvider, () => this.viewMode), <del> overrideStyles: { listBackground: this.viewDescriptorService.getViewLocationById(this.id) === ViewContainerLocation.Panel ? PANEL_BACKGROUND : SIDE_BAR_BACKGROUND }, </del> <ins> overrideStyles: this.getLocationBasedColors().listOverrideStyles, </ins> collapseByDefault: (e: unknown) => { // Repository, Resource Group, Resource Folder (Tree), History Item Change Folder (Tree) if (isSCMRepository(e) || isSCMResourceGroup(e) || isSCMResourceNode(e) || isSCMHistoryItemChangeNode(e)) {