jiebi/CodeConvo huggingface dataset:
Change:
Started up for the first time in awhile and received the following error <img width="576" alt="image" src="https://user-"Seems to come from here. This only repros when I use the provided. Opening the file myself seems to work
do you see this every time when opening the link? It seems that it throws with an undefined error but we failed to read the error message. It didn't explain why the file opening fails though.
I see it every time. I can try again tomorrow when this change goes in to see if there is a more detailed error message.
I just hit this as well twice but third time didn't repro
This will fail This is OK We think it's because C22 is a markdown cell and C23 is a code cell How it looks: the editor progress bar spins forever, when you start scrolling the error modal dialog pops up It's quite possible this was always there but is more visible now that we're using notebook cell deeplinks
I prepared a fix for this one, by turning the cell into editing mode if there is a selection in the link If we drop from the link, you can find it open successfully. However currently whenever we copy a link from a markdown cell preview, we always append ion the link, we should probably only append line number when the cell is in editing mode, tracked in

Discussion:
} } } catch (e) { <del> const error = createErrorWithActions(e instanceof Error ? e : new Error(e.message), [ </del> <ins> console.warn(e); const error = createErrorWithActions(e instanceof Error ? e : new Error((e ? e.message : '')), [ </ins> toAction({ id: 'workbench.notebook.action.openInTextEditor', label: localize('notebookOpenInTextEditor', "Open in Text Editor"), run: async () => { const activeEditorPane = this._editorService.activeEditorPane;
Change:
Type: <bBug</bThere are missing completions inside files which do appear inside the folder. For example, here are the completions in a file: ! Versus the one in a file: ! VS Code version: Code - Insiders 1.73.0-insider (, 2022-10-24T05:31:12.081Z) OS version: WindowsNT x64 10.0. Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (9)</summaryExtensionVersion ------ vscode-eslint2.2.6 todo-tree0.0.219 reg1.1.0 csharp1.25.0 material-icon-theme4.21.0 msbuild-project-tools0.4.9 intellicode-api-usage-examples0.2.6 vscodeintellicode1.2.29 volar1.0.9 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
do you know where these variable completions come from? I think they are sort of generic for every string in and I think they should show up in the workspace config too.
they come from here: Makes sense to me to add them in .code-workspace.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!
Was there any information you wanted me to provide? It seems like a solution was proposed by

Discussion:
// task.json variable suggestions context.subscriptions.push(registerVariableCompletions('**/tasks.json')); <ins> // Workspace file launch/tasks variable completions context.subscriptions.push(registerVariableCompletions('**/*.code-workspace')); </ins> // keybindings.json/package.json context key suggestions context.subscriptions.push(registerContextKeyCompletions()); }

provideCompletionItems(document, position, _token) { const location = getLocation(document.getText(), document.offsetAt(position)); if (isCompletingInsidePropertyStringValue(document, location, position)) { <ins> if (document.fileName.endsWith('.code-workspace') && !isLocationInsideTopLevelProperty(location, ['launch', 'tasks'])) { return []; } </ins> let range = document.getWordRangeAtPosition(position, /${[^"}]*}?/); if (!range || range.start.isEqual(position) || range.end.isEqual(position) && document.getText(range).endsWith('}')) { range = new vscode.Range(position, position);

return false; } <ins> function isLocationInsideTopLevelProperty(location: Location, values: string[]) { return values.includes(location.path[0] as string); } </ins> interface IExtensionsContent { recommendations: string[]; }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.73.0-insider OS Version: macOS 12.6 Steps to Reproduce: VSCode, click on the Getting Started walkthrough Voice Control with Hints Able to focus on the options, but unable to click on the checkbox ! with the Accessibility Inspector: Looks like the checkbox is a rather than a button: !

Discussion:
{ 'data-done-step-id': step.id, 'x-dispatch': 'toggleStepCompletion:' + step.id, <ins> 'role': 'checkbox', 'tabindex': '0', </ins> }); const container = $('.step-description-container', { 'x-step-description-for': step.id });
Change:
enable CPU profiling reload window (explorer, text editor, terminal) stop CPU profiling look at "Heavy bottom up" samples the top five of slow things contains this regex:  <img width="1258" alt="Screenshot 2022-10-27 at 16 13 30" src="https://user-"

Discussion:
*/ function anonymizeFilePaths(stack: string, cleanupPatterns: RegExp[]): string { <ins> // Fast check to see if it is a file path to avoid doing unnecessary heavy regex work if (!stack || (!stack.includes('/') && !stack.includes(''))) { return stack; } </ins> let updatedStack = stack; const cleanUpIndexes: [number, number][] = [];
Change:
The resource performance markers are now PII cleansed - e.g all paths are removed which defeats the purpose of collecting them... We should do something smarter and send only selected information that isn't cleansed
cc
Adding to October for collecting the basenames-only
cc that we have this and that it is being fixed for this milestone
if I read it correct it's now fixed via

Discussion:
import { Registry } from 'vs/platform/registry/common/platform'; import { Extensions, IWorkbenchContributionsRegistry } from 'vs/workbench/common/contributions'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; <ins> import { posix } from 'vs/base/common/path'; import { hash } from 'vs/base/common/hash'; </ins> class ResourcePerformanceMarks { constructor(@ITelemetryService telemetryService: ITelemetryService) { <del> type Entry = { name: string; duration: number }; </del> <ins> type Entry = { hosthash: string; name: string; duration: number; }; </ins> type EntryClassifify = { owner: 'jrieken'; comment: 'Resource performance numbers'; <del> name: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; comment: 'Resource name' }; </del> <ins> hosthash: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; comment: 'Hash of the hostname' }; name: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; comment: 'Resource basename' }; </ins> duration: { classification: 'SystemMetaData'; purpose: 'PerformanceAndHealth'; isMeasurement: true; comment: 'Resource duration' }; }; for (const item of performance.getEntriesByType('resource')) { <del> telemetryService.publicLog2<Entry, EntryClassifify>('startup.resource.perf', { name: item.name, duration: item.duration }); </del> <ins> try { const url = new URL(item.name); const name = posix.basename(url.pathname); telemetryService.publicLog2<Entry, EntryClassifify>('startup.resource.perf', { hosthash: `H${hash(url.host).toString(16)}`, name, duration: item.duration }); } catch { // ignore } </ins> } } }
Change:
Type: <bBug</bwith the following code in a javascript file: the symbol "UserClient" which is missing an import is not automatically imported. if i only remove the JSDoc Comment then it is already working. if i remove the return statement it is also working. i tried it with all extensions disabled, nothing. please fix this. VS Code version: Code 1.72.2 (, 2022-10-12T22:15:18.074Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: No <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ lit-html1.11.1 vscode-html-css1.13.1 lit-lang0.0.7 prettier-vscode9.9.0 csharp1.25.0 powershell2022.10.0 vscode-xml0.22.0 lit-plugin1.2.4 markdown-preview-enhanced0.6.3 blueprint3.0.0 markdown-all-in-one3.4.3 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Please share a minimal, self contained project that demonstrates the issue
Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our . Please take the time to review these and update the issue. Happy Coding!
note: is just a bundled version of the lit-html plugin. the project i'm using works has the requirement to work without any kind of build so we bundled the only npm dependency it had into this file. still looking for a better solution though...
I'm facing the same issue. and get executed as expected, but seems to not working. To reproduce, just open a TS project, set the to the option, remove an import from any source file and save. The imports gets organized but the missing imports doesn't get imported.
I even noticed that it still works under certain circumstances. like in my demo project, if you remove the JSDoc comment. something in the code context seems to be killing the import feature. but manual import still works (like with hovering the item, quick fix, import)
any updates, info requests, anything? did you find a lead, can you work on it? can you fix it?
I can confirm this issue, I can trigger the autocomplete for the import with either ctrl+space or ctrl+. however it is not automatically on save even with enabled. This feature was working for me some time ago, but I can no longer get it to work.
Any fix yet?
Changing the order to solved the problem for me.

Discussion:
} const actions = this.getFixAllActions(context.only); <del> if (this.client.bufferSyncSupport.hasPendingDiagnostics(document.uri)) { return actions; } </del> const diagnostics = this.diagnosticsManager.getDiagnostics(document.uri); if (!diagnostics.length) { // Actions are a no-op in this case but we still want to return them
Change:
This was apparently by but I haven't found anywhere in the codebase that uses it.
/assign

Discussion:
description: nls.localize('vscode.extension.activationEvents.onView', 'An activation event emitted whenever the specified view is expanded.'), }, { <del> label: 'onIdentity', body: 'onIdentity:${8:identity}', description: nls.localize('vscode.extension.activationEvents.onIdentity', 'An activation event emitted whenever the specified user identity.'), }, { </del> label: 'onUri', body: 'onUri', description: nls.localize('vscode.extension.activationEvents.onUri', 'An activation event emitted whenever a system-wide Uri directed towards this extension is open.'),
Change:
latest insiders dev tools console :bug: see several of these messages:
called here non-existent in the repo
Think this is fine to wait until November as I don't see this in dev tools - has this repro'd for you?
Yeah I see it as soon as I open the terminal panel. It's an ugly dev tools message but agree it can probably wait

Discussion:
_renderer: { _renderLayers?: any[]; }; <del> _onIntersectionChange: any; </del> <ins> _handleIntersectionChange: any; </ins> }; }

// maximize on Windows/Linux would fire an event saying that the terminal was not // visible. if (!!this._canvasAddon) { <del> this._core._renderService?._onIntersectionChange({ intersectionRatio: 1 }); </del> <ins> this._core._renderService?._handleIntersectionChange({ intersectionRatio: 1 }); </ins> // HACK: Force a refresh of the screen to ensure links are refresh corrected. // This can probably be removed when the above hack is fixed in Chromium. this.raw.refresh(0, this.raw.rows - 1);
Change:
Type: <bBug</bworkspace: : to top level of workspace bug The link is incorrectly rewritten to include the file name VS Code version: Code - Insiders 1.73.0-insider (Universal) (, 2022-10-27T21:41:11.954Z) OS version: Darwin x64 21.6.0 Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<!-- generated by issue reporter --

Discussion:
"vscode-languageserver": "^8.0.2", "vscode-languageserver-textdocument": "^1.0.5", "vscode-languageserver-types": "^3.17.1", <del> "vscode-markdown-languageservice": "^0.2.0-alpha.7", </del> <ins> "vscode-markdown-languageservice": "^0.2.0-alpha.8", </ins> "vscode-nls": "^5.2.0", "vscode-uri": "^3.0.3" },

} hasInMemoryDoc(): boolean { <del> return !this.inMemoryDoc; </del> <ins> return !!this.inMemoryDoc; </ins> } isDetached(): boolean {

// Check that if file has been deleted on disk. // This can happen when directories are renamed / moved. VS Code's file system watcher does not // notify us when this happens. <del> if (await this.statBypassingCache(uri) === undefined) { </del> <ins> if (!(await this.statBypassingCache(uri))) { </ins> if (this._documentCache.get(uri) === doc && !doc.hasInMemoryDoc()) { this.doDeleteDocument(uri); return;

if (this.documents.get(uri)) { return { isDirectory: false }; } <del> return this.connection.sendRequest(protocol.fs_stat, { uri }); </del> <ins> const fsResult = await this.connection.sendRequest(protocol.fs_stat, { uri }); return fsResult ?? undefined; // Force convert null to undefined </ins> } async readDirectory(resource: URI): Promise<[string, md.FileStat][]> {

dependencies: vscode-languageserver-protocol "3.17.2" <del> vscode-markdown-languageservice@^0.2.0-alpha.7: version "0.2.0-alpha.7" resolved "https://registry.yarnpkg.com/vscode-markdown-languageservice/-/vscode-markdown-languageservice-0.2.0-alpha.7.tgz#1f5fd345630e9d0d585cb00155d433c2320fa9c2" integrity sha512-5QYz1+LpvazK21Hphx8wZiZIXE9cQ9R3jzhQr+I89xNHJi+NWTEBA555ZFkaaYR68B7SI7OQ4jihjkGLZTUTnw== </del> <ins> vscode-markdown-languageservice@^0.2.0-alpha.8: version "0.2.0-alpha.8" resolved "https://registry.yarnpkg.com/vscode-markdown-languageservice/-/vscode-markdown-languageservice-0.2.0-alpha.8.tgz#f77c20adea2ddafdad88b99b09be1778c358ca42" integrity sha512-kydgGkSarjFk71culFover7lBym82wmJdvuqCzS3IPZV+fhW1l0poca/Dt4bDku3ioda0kNH9xdmi0fiHkIDUQ== </ins> dependencies: picomatch "^2.3.1" vscode-languageserver-textdocument "^1.0.5"
Change:
In OSS not insiders (so not a candidate) Steps to Reproduce: shows error This is because the gets run in a separate process than the Extension Host and so the vscode.l10n API isn't available. Proposed fix is to not localize the single error message being localized since it's not surfaced to the user.

Discussion:
*--------------------------------------------------------------------------------------------*/ import * as fs from 'fs'; <del> import { l10n } from 'vscode'; </del> import { IPCClient } from './ipc/ipcClient'; function fatal(err: any): void { <del> console.error(l10n.t('Missing or invalid credentials.')); </del> <ins> console.error('Missing or invalid credentials.'); </ins> console.error(err); process.exit(1); }
Change:
Build from last Friday was ignored: This started happening since It only happens on full Product builds, since only those run the Alpine jobs, and whenever the nodemodules cache is warm. The reason for this is due to the Pipeline step which always runs .

Discussion:
condition: and(succeeded(), ne(variables['NPM_REGISTRY'], 'none')) displayName: Setup NPM Registry <ins> # In Alpine, we always want to setup and authenticate against the NPM_REGISTRY # because of the Prebuild step, since it always runs `yarn` from inside an alpine # container - script: | set -e npm config set registry "$NPM_REGISTRY" --location=project npm config set always-auth=true --location=project yarn config set registry "$NPM_REGISTRY" condition: and(succeeded(), ne(variables['NPM_REGISTRY'], 'none')) displayName: Setup NPM & Yarn - task: npmAuthenticate@0 inputs: workingFile: .npmrc condition: and(succeeded(), ne(variables['NPM_REGISTRY'], 'none')) displayName: Setup NPM Authentication </ins> - script: | mkdir -p .build node build/azure-pipelines/common/computeNodeModulesCacheKey.js "alpine" > .build/yarnlockhash

- script: | set -e <del> npm config set registry "$NPM_REGISTRY" --location=project npm config set always-auth=true --location=project yarn config set registry "$NPM_REGISTRY" condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'), ne(variables['NPM_REGISTRY'], 'none')) displayName: Setup NPM & Yarn - task: npmAuthenticate@0 inputs: workingFile: .npmrc condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'), ne(variables['NPM_REGISTRY'], 'none')) displayName: Setup NPM Authentication - script: | set -e </del> for i in {1..3}; do # try 3 times yarn --frozen-lockfile --check-files --check-files && break if [ $i -eq 3 ]; then
Change:
Another one:
Another one:
This is actually preventing a bunch of PRs to make it into . !
Skipped this test:
Decided to comment out the entire test suite:
Thanks for reverting it, this failure is what I was expecting to see but didn't realize it's so common. Previously we often have NPE for as after , we guarantee the model is a . is not undefined, however our check previously only checked for instead of . Not we fixed condition, it starts to fail when we do the type assert can you help take a look at this?
This might actually be interesting for your. AFAIK we simply call resolve on the working copy manager but working copy actually isn't resolved. This is all happening here The working copy doc says that the model is defined once resolve is called but it seems not so (at times)
Maybe running with in that flaky test gives more info, we print a good amount of details for what is going on in the working copy when resolving or saving: <img width="796" alt="image" src="https://user-"
brings the tests back and sets verbose logging for the failing one (I am not sure why the entire suite was disabled). There is cases where can return early and maybe that happens here in this case. For example, when a disposed working copy is resolved: Or when providing contents for resolving but the working copy is dirty with user changes: Anyway, any of these cases should appear in the logs now with verbose logging enabled.
Does not seem to fail anymore <img width="1549" alt="image" src="https://user-"

Discussion:
import * as vscode from 'vscode'; import * as utils from '../utils'; <del> (vscode.env.uiKind === vscode.UIKind.Web ? suite.skip : suite)('Notebook Editor', function () { </del> <ins> (vscode.env.uiKind === vscode.UIKind.Web ? suite.skip : suite.skip)('Notebook Editor', function () { </ins> const contentSerializer = new class implements vscode.NotebookSerializer { deserializeNotebook() {
Change:
Type: <bBug</b! padding (see "Last released" running directly onto the date. hanging indent (see "Last", "updated" and "Identifier" all with same left start position) VS Code version: Code - Insiders 1.73.0-insider (, 2022-11-01T15:30:14.729Z) OS version: Windows_NT x64 10.0. Modes: Sandboxed: Yes <!-- generated by issue reporter --
We closed this issue because we in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our and . Thanks for your understanding, and happy coding!
Reopening as I have a PR for the first issue at least
Issue closed
Rendered like table with bg color for alternate colors !
! ! ! When the insiders comes out is there a particular theme to test this with. I don't see this even without the fix.
I see the fix. Before: <img width="147" alt="image" src=""After: <img width="138" alt="image" src=""

Discussion:
.extension-editor > .body > .content > .details > .additional-details-container .more-info-container > .more-info > .more-info-entry { font-size: 90%; <del> display: flex; } .extension-editor > .body > .content > .details > .additional-details-container .more-info-container > .more-info > .more-info-entry :first-child { width: 40%; } .extension-editor > .body > .content > .details > .additional-details-container .more-info-container > .more-info > .more-info-entry :last-child { width: 60%; </del> <ins> display: grid; grid-template-columns: 40% 60%; gap: 4px; </ins> } .extension-editor > .body > .content > .details > .additional-details-container .more-info-container > .more-info > .more-info-entry code {
Change:
Type: <bBug</b! padding (see "Last released" running directly onto the date. hanging indent (see "Last", "updated" and "Identifier" all with same left start position) VS Code version: Code - Insiders 1.73.0-insider (, 2022-11-01T15:30:14.729Z) OS version: Windows_NT x64 10.0. Modes: Sandboxed: Yes <!-- generated by issue reporter --
We closed this issue because we in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our and . Thanks for your understanding, and happy coding!
Reopening as I have a PR for the first issue at least
Issue closed
Rendered like table with bg color for alternate colors !
! ! ! When the insiders comes out is there a particular theme to test this with. I don't see this even without the fix.
I see the fix. Before: <img width="147" alt="image" src=""After: <img width="138" alt="image" src=""

Discussion:
font-size: 90%; display: grid; grid-template-columns: 40% 60%; <del> gap: 4px; </del> <ins> gap: 6px; padding: 2px 4px; } .extension-editor > .body > .content > .details > .additional-details-container .more-info-container > .more-info > .more-info-entry:nth-child(odd) { background-color: rgba(130, 130, 130, 0.04); </ins> } .extension-editor > .body > .content > .details > .additional-details-container .more-info-container > .more-info > .more-info-entry code {