jiebi/CodeConvo huggingface dataset:
Change:
We have learnt (the hard way) that when running extension/integration tests that EXP is enabled. This means some build (and user) machines might behave different to how they run locally. Also, it seems wasteful to contact the service when running tests

Discussion:
import { getTelemetryLevel } from 'vs/platform/telemetry/common/telemetryUtils'; import { AssignmentFilterProvider, ASSIGNMENT_REFETCH_INTERVAL, ASSIGNMENT_STORAGE_KEY, IAssignmentService, TargetPopulation } from 'vs/platform/assignment/common/assignment'; import { importAMDNodeModule } from 'vs/amdX'; <ins> import { IEnvironmentService } from 'vs/platform/environment/common/environment'; </ins> export abstract class BaseAssignmentService implements IAssignmentService { _serviceBrand: undefined;

private readonly machineId: string, protected readonly configurationService: IConfigurationService, protected readonly productService: IProductService, <ins> protected readonly environmentService: IEnvironmentService, </ins> protected telemetry: IExperimentationTelemetry, private keyValueStorage?: IKeyValueStorage ) { <del> if (productService.tasConfig && this.experimentsEnabled && getTelemetryLevel(this.configurationService) === TelemetryLevel.USAGE) { </del> <ins> const isTesting = environmentService.extensionTestsLocationURI !== undefined; if (!isTesting && productService.tasConfig && this.experimentsEnabled && getTelemetryLevel(this.configurationService) === TelemetryLevel.USAGE) { </ins> this.tasClient = this.setupTASClient(); }

import { BaseAssignmentService } from 'vs/platform/assignment/common/assignmentService'; import { workbenchConfigurationNodeBase } from 'vs/workbench/common/configuration'; import { IConfigurationRegistry, Extensions as ConfigurationExtensions, ConfigurationScope } from 'vs/platform/configuration/common/configurationRegistry'; <ins> import { IEnvironmentService } from 'vs/platform/environment/common/environment'; </ins> export const IWorkbenchAssignmentService = createDecorator<IWorkbenchAssignmentService>('WorkbenchAssignmentService');

@ITelemetryService private telemetryService: ITelemetryService, @IStorageService storageService: IStorageService, @IConfigurationService configurationService: IConfigurationService, <del> @IProductService productService: IProductService </del> <ins> @IProductService productService: IProductService, @IEnvironmentService environmentService: IEnvironmentService </ins> ) { super( telemetryService.machineId, configurationService, productService, <ins> environmentService, </ins> new WorkbenchAssignmentServiceTelemetry(telemetryService, productService), new MementoKeyValueStorage(new Memento('experiment.service.memento', storageService)) );
Change:
From <img width="777" alt="image" src=""Seems less useful to see the middle of the editor name, instead of the beginning
Looks like I need a CSS style that says "center unless too wide"
I didn't try it but I think that is a valid strategy <img width="422" alt="image" src=""
But what if github copilot would just automatically show up in this issue like "hey, I have an idea..."

Discussion:
.monaco-workbench .part.titlebar > .titlebar-container > .titlebar-center > .window-title > .command-center .action-item.command-center-center .action-item.command-center-quick-pick { display: flex; <ins> justify-content: start; overflow: hidden; margin: auto; max-width: 600px; </ins> } .monaco-workbench .part.titlebar > .titlebar-container > .titlebar-center > .window-title > .command-center .action-item.command-center-center .action-item.command-center-quick-pick .search-icon {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.2 OS Version: Windows 11 Enterprise (Windows_NT x64 10.0..3007) Description During an accessibility test, we found the contrast ratio between the placeholder text and the background is not high enough under "Default Dark Modern" theme. Placeholder Text Color: Background Color: Contrast Ratio: 3.339:1 Required Contrast Ratio: 4.5:1 !
A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Aug2023; #WCAG1.4.3; #Contrast (Minimum);

Discussion:
"input.background": "#313131", "input.border": "#3C3C3C", "input.foreground": "#CCCCCC", <del> "input.placeholderForeground": "#818181", </del> <ins> "input.placeholderForeground": "#989898", </ins> "inputOption.activeBackground": "#2489DB82", "inputOption.activeBorder": "#2488DB", "keybindingLabel.foreground": "#CCCCCC",

"input.background": "#FFFFFF", "input.border": "#CECECE", "input.foreground": "#3B3B3B", <del> "input.placeholderForeground": "#868686", </del> <ins> "input.placeholderForeground": "#767676", </ins> "inputOption.activeBackground": "#BED6ED", "inputOption.activeBorder": "#005FB8", "inputOption.activeForeground": "#000000",
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.2 OS Version: Windows 11 Enterprise (Windows_NT x64 10.0..3007) Description During an accessibility test, we found the contrast ratio between the highlight color of the focused button in "More Actions..." in notification popup and its background is not high enough under "Default Dark Modern" theme. Highlight Color: Background Color: Contrast Ratio: 1.346:1 Required Contrast Ratio: 3:1 !
I think this refers to the background color of the gear icon in the toolbar of a notification relative to the background color of the notification.
The bug reported on my side particularly specified the "Manage Extension" button highlight color and the background color of that actions popup under settings icon in the notification.
Looks like it's about the blue on black bg, in that case this applies to all the web menus in VS Code.
yes, it's about the blue highlight and black background.
A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Aug2023; #WCAG1.4.11; #Non-text Contrast;
Hi, is there any update on the plan of fixing this accessibility bug?
putting this on the March plan.
Hi, may I check if the fix is included in v1.88.0?
Hi, I have checked v1.88.0 but it seems the active color is still not the one you changed to in your PR. Did I miss something?
Verified with the Dark Modern theme, but do we also have to fix this with the Dark+ or Dark (Visual Studio) themes?
Thanks, I think it's fine we only fix it in default dark theme for now. The test team doesn't require that in other themes so far.

Discussion:
"inputOption.activeBorder": "#2488DB", "keybindingLabel.foreground": "#CCCCCC", "menu.background": "#1F1F1F", <ins> "menu.selectionBackground": "#0078d4", </ins> "notificationCenterHeader.background": "#1F1F1F", "notificationCenterHeader.foreground": "#CCCCCC", "notifications.background": "#1F1F1F",

"list.hoverBackground": "#F2F2F2", "list.focusAndSelectionOutline": "#005FB8", "menu.border": "#CECECE", <ins> "menu.selectionBackground": "#005FB8", "menu.selectionForeground": "#ffffff", </ins> "notebook.cellBorderColor": "#E5E5E5", "notebook.selectedCellBackground": "#C8DDF150", "notificationCenterHeader.background": "#FFFFFF",
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.2 OS Version: Windows 11 Steps to Reproduce: clone the repository. in VSCode's Preview Mode. one of links to . Hello, VSCode Team. I've recently been experimenting with creating a language switcher in , allowing it to switch to different language versions of . Below is the code snippet I've created: However, I found that when I open the preview of *.md files in VSCode using "Markdown: Open Preview" and try to click those hyperlinks to switch to other languages of README, the system automatically opens the default browser. The content in the URL bar is: But when I upload the folder's content to GitHub, clicking those hyperlinks indeed switches normally. It means that it might be an issue with VSCode, right? If this behavior is the default in VSCode, then: should I modify the HTML syntax to enable normal switching in VSCode's preview mode? , is there a way to change this default behavior in VSCode? !
I read about it and got to know that the default behavior of Visual Studio Code's built-in Markdown preview mode is to open links in an external browser buy If you want to change this behavior specifically for your local preview while using Visual Studio Code, you might consider looking for a VSCode extension that customizes the behavior of the markdown preview renderer. I checked and used Markdown Preview Enhanced by Yiyi Wang to get result.

Discussion:
let hrefText = node.getAttribute('data-href'); if (!hrefText) { <ins> hrefText = node.getAttribute('href'); </ins> // Pass through known schemes <del> if (passThroughLinkSchemes.some(scheme => node.href.startsWith(scheme))) { </del> <ins> if (passThroughLinkSchemes.some(scheme => hrefText.startsWith(scheme))) { </ins> return; } <del> hrefText = node.getAttribute('href'); </del> } // If original link doesn't look like a url, delegate back to VS Code to resolve
Change:
I had multiple editors open, one of them was a notebook. At some point when I saved the file I was in the notebook suddenly appeared over the typescript file. This happened twice, once when in the typescript file and once in the multi diff editor. <img width="1921" alt="Code-Insiders_G5CU0Db9YP" src=""
Maybe a regression from the work to support notebooks in floating windows?

Discussion:
return; } <del> if (this._dimension) { </del> <ins> if (this._dimension && this._isVisible) { </ins> if (sizeDelta > 0) { // delta > 0 ==> sticky is growing, cell list shrinking this.layout(this._dimension); this.setScrollTop(this.scrollTop + sizeDelta);
Change:
Verification set to enable native title bar in settings open a floating window ensure you see no custom title below the native title

Discussion:
import { ServiceCollection } from 'vs/platform/instantiation/common/serviceCollection'; import { IStorageService } from 'vs/platform/storage/common/storage'; import { IThemeService } from 'vs/platform/theme/common/themeService'; <del> import { hasCustomTitlebar } from 'vs/platform/window/common/window'; </del> <ins> import { hasNativeTitlebar } from 'vs/platform/window/common/window'; </ins> import { IEditorGroupView, IEditorPartsView } from 'vs/workbench/browser/parts/editor/editor'; import { EditorPart, IEditorPartUIState } from 'vs/workbench/browser/parts/editor/editorPart'; import { IAuxiliaryTitlebarPart } from 'vs/workbench/browser/parts/titlebar/titlebarPart';

// Titlebar let titlebarPart: IAuxiliaryTitlebarPart | undefined = undefined; let titlebarPartVisible = false; <del> const useCustomTitle = isNative && hasCustomTitlebar(this.configurationService); // custom title in aux windows only enabled in native </del> <ins> const useCustomTitle = isNative && !hasNativeTitlebar(this.configurationService); // custom title in aux windows only enabled in native </ins> if (useCustomTitle) { titlebarPart = disposables.add(this.titleService.createAuxiliaryTitlebarPart(auxiliaryWindow.container, editorPart)); titlebarPartVisible = true;
Change:
Inline chat is typically nicely aligned to the line it covers but when I jump to another editor and then back, that alignment is lost: !

Discussion:
this._zone.value.setWidgetMargins(widgetPosition); this._zone.value.show(widgetPosition); } else { <ins> this._zone.value.setWidgetMargins(widgetPosition); </ins> this._zone.value.updatePositionAndHeight(widgetPosition); } }
Change:
We still have the check in place to disable these in the stable build...
Can be verified by code review, or once we have a stable build.
Verifying on 0.11.1 Edit: I see the suggestion is enabled, but the behaviour is off to me. Discussing offline. Edit 2: Discussed. Marking as verified.

Discussion:
import { localize } from 'vs/nls'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; <del> import { IProductService } from 'vs/platform/product/common/productService'; </del> import { Registry } from 'vs/platform/registry/common/platform'; import { inputPlaceholderForeground } from 'vs/platform/theme/common/colorRegistry'; import { IThemeService } from 'vs/platform/theme/common/themeService';

constructor( @ILanguageFeaturesService private readonly languageFeaturesService: ILanguageFeaturesService, @IChatWidgetService private readonly chatWidgetService: IChatWidgetService, <del> @IConfigurationService private readonly configurationService: IConfigurationService, @IProductService private readonly productService: IProductService, </del> ) { super();

_debugDisplayName: 'chatDynamicCompletions', triggerCharacters: [chatVariableLeader], provideCompletionItems: async (model: ITextModel, position: Position, _context: CompletionContext, _token: CancellationToken) => { <del> const fileVariablesEnabled = this.configurationService.getValue('chat.experimental.fileVariables') ?? this.productService.quality !== 'stable'; if (!fileVariablesEnabled) { return; } </del> const widget = this.chatWidgetService.getWidgetByInputUri(model.uri); if (!widget || !widget.supportsFileReferences) { return null;
Change:
We still have the check in place to disable these in the stable build...
Can be verified by code review, or once we have a stable build.
Verifying on 0.11.1 Edit: I see the suggestion is enabled, but the behaviour is off to me. Discussing offline. Edit 2: Discussed. Marking as verified.

Discussion:
@IKeybindingService private readonly keybindingService: IKeybindingService, @ILabelService private readonly labelService: ILabelService, @ILogService private readonly logService: ILogService <del> ) { } </del> <ins> ) { } </ins> convertParsedRequestToMarkdown(parsedRequest: IParsedChatRequest): string { let result = '';

} else { const uri = part instanceof ChatRequestDynamicVariablePart && part.data.map(d => d.value).find((d): d is URI => d instanceof URI) || undefined; <del> const title = uri ? this.labelService.getUriLabel(uri, { relative: true }) : ''; </del> <ins> const title = uri ? encodeURIComponent(this.labelService.getUriLabel(uri, { relative: true })) : ''; </ins> <del> result += `[${part.text}](${variableRefUrl}${title})`; </del> <ins> result += `[${part.text}](${variableRefUrl}?${title})`; </ins> } }

const href = a.getAttribute('data-href'); if (href) { if (href.startsWith(variableRefUrl)) { <del> const title = href.slice(variableRefUrl.length); </del> <ins> const title = decodeURIComponent(href.slice(variableRefUrl.length + 1)); </ins> a.parentElement!.replaceChild( this.renderResourceWidget(a.textContent!, title), a);

import { localize } from 'vs/nls'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; <del> import { IProductService } from 'vs/platform/product/common/productService'; </del> import { Registry } from 'vs/platform/registry/common/platform'; import { inputPlaceholderForeground } from 'vs/platform/theme/common/colorRegistry'; import { IThemeService } from 'vs/platform/theme/common/themeService';

constructor( @ILanguageFeaturesService private readonly languageFeaturesService: ILanguageFeaturesService, @IChatWidgetService private readonly chatWidgetService: IChatWidgetService, <del> @IConfigurationService private readonly configurationService: IConfigurationService, @IProductService private readonly productService: IProductService, </del> ) { super();

_debugDisplayName: 'chatDynamicCompletions', triggerCharacters: [chatVariableLeader], provideCompletionItems: async (model: ITextModel, position: Position, _context: CompletionContext, _token: CancellationToken) => { <del> const fileVariablesEnabled = this.configurationService.getValue('chat.experimental.fileVariables') ?? this.productService.quality !== 'stable'; if (!fileVariablesEnabled) { return; } </del> const widget = this.chatWidgetService.getWidgetByInputUri(model.uri); if (!widget || !widget.supportsFileReferences) { return null;
Change:
<img width="377" alt="image" src=""
Verification step- just use a variable in a multiroot workspace, and check that you have the right blue background when it's rendered in the request.
Works great. Slightly related - why do we just render the blue background while I am typing the request, but do not render it blue when the request is sent. This was always the behaviour and is unrelated to MR workspace. I am just curious !
If it was used correctly, it will have the blue background. Did you pick the file from the picker, or just type the text?
Picked from file picker.
Oh no!
Apparently I didn't test this as thoroughly as I should have. Some files now break the markdown link. Need to rework this in main for debt week but there is an easy fix for now.
For verification, we should test with Files in a multiroot workspace In single folder window Files at the top level of the workspace And under a folder
Since the PR has been merged yesterday, this issue will be closed, for verification.

Discussion:
const labelService = accessor.get(ILabelService); const uri = part instanceof ChatRequestDynamicVariablePart && part.data.map(d => d.value).find((d): d is URI => d instanceof URI) || undefined; <del> const title = uri ? labelService.getUriLabel(uri, { relative: true }) : ''; </del> <ins> const title = uri ? encodeURIComponent(labelService.getUriLabel(uri, { relative: true })) : ''; </ins> result += `[${part.text}](${variableRefUrl}${title})`; }

const href = a.getAttribute('data-href'); if (href) { if (href.startsWith(variableRefUrl)) { <del> const title = href.slice(variableRefUrl.length); </del> <ins> const title = decodeURIComponent(href.slice(variableRefUrl.length)); </ins> a.parentElement!.replaceChild( renderResourceWidget(a.textContent!, title), a);
Change:
High Contrast themes display both dark and light mode markdown content simultaneously. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.2 OS Version: MacOS 14.2.1 Steps to Reproduce: a markdown document an image with both a light and dark variant to a high-contrast theme if both light and dark variants are displayed
works, but causes the image to never show.

Discussion:
*--------------------------------------------------------------------------------------------*/ .vscode-dark img[src$=#gh-light-mode-only], <del> .vscode-light img[src$=#gh-dark-mode-only] { </del> <ins> .vscode-light img[src$=#gh-dark-mode-only], .vscode-high-contrast img[src$=#gh-light-mode-only], .vscode-high-contrast-light img[src$=#gh-dark-mode-only] { </ins> display: none; }
Change:
High Contrast themes display both dark and light mode markdown content simultaneously. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.2 OS Version: MacOS 14.2.1 Steps to Reproduce: a markdown document an image with both a light and dark variant to a high-contrast theme if both light and dark variants are displayed
works, but causes the image to never show.

Discussion:
.vscode-dark img[src$=#gh-light-mode-only], .vscode-light img[src$=#gh-dark-mode-only], <del> .vscode-high-contrast img[src$=#gh-light-mode-only], </del> <ins> .vscode-high-contrast:not(.vscode-high-contrast-light) img[src$=#gh-light-mode-only], </ins> .vscode-high-contrast-light img[src$=#gh-dark-mode-only] { display: none; }