jiebi/CodeConvo huggingface dataset:
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Current Behavior: I have staged changes and typed a commit message. I choose Stash Stash I am prompted to enter a stash description Desired Behavior: If commit message is entered, automatically use it as the stash description instead of prompting.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.767 --- <!-- score: 0.663 --- <!-- score: 0.586 --- <!-- score: 0.559 --- <!-- score: 0.54 --<!-- potentialduplicatescomment --
Is this issue available to work on?
perhaps the simplest implementation is just to default the stash description prompt to the commit message?
! doesn't work for me
Sorry for the hassle but we decided to go and put this behind a setting instead: .
A little overkill if you ask me. But it works
I know... explanation is here: I guess the PR author didn't want to go with option 2 ;)

Discussion:
"default": true, "description": "%config.terminalAuthentication%" }, <ins> "git.defaultStashMessage": { "type": "boolean", "scope": "resource", "default": false, "description": "%config.defaultStashMessage%" }, </ins> "git.githubAuthentication": { "deprecationMessage": "This setting is now deprecated, please use `github.gitAuthentication` instead." },

"config.timeline.date": "Controls which date to use for items in the Timeline view", "config.timeline.date.committed": "Use the committed date", "config.timeline.date.authored": "Use the authored date", <ins> "config.defaultStashMessage": "Controls whether to use message from commit input box (if populated) as default stash messages", </ins> "submenu.commit": "Commit", "submenu.commit.amend": "Amend", "submenu.commit.signoff": "Sign Off",

} } <del> const message = await this.getStashMessage(); </del> <ins> let defaultStashMessage = ''; if (config.get<boolean>('defaultStashMessage')) { const commitTemplate = repository.sourceControl.commitTemplate; if (commitTemplate === undefined) { defaultStashMessage = repository.inputBox.value; } else { defaultStashMessage = repository.inputBox.value.replace(commitTemplate, ''); } } const message = await this.getStashMessage(defaultStashMessage); </ins> if (typeof message === 'undefined') { return;

await repository.createStash(message, includeUntracked); } <del> private async getStashMessage(): Promise<string | undefined> { </del> <ins> private async getStashMessage(defaultStashMessage: string): Promise<string | undefined> { </ins> return await window.showInputBox({ <ins> value: defaultStashMessage, </ins> prompt: localize('provide stash message', "Optionally provide a stash message"), placeHolder: localize('stash message', "Stash message") });
Change:
I see that is called very early here: Even though only used in some method later. Can we please move it where it is being used only to ensure we do not block startup?
Sure this can move it further down. It will only save ~5ms on Windows and only if the terminal is restored on start up.

Discussion:
} private async _startMonitoringShell(): Promise<void> { <del> if (!windowsProcessTree) { windowsProcessTree = await import('windows-process-tree'); } </del> if (this._isDisposed) { return; }

if (this._currentRequest) { return this._currentRequest; } <del> this._currentRequest = new Promise<string>(resolve => { </del> <ins> this._currentRequest = new Promise<string>(async resolve => { if (!windowsProcessTree) { windowsProcessTree = await import('windows-process-tree'); } </ins> windowsProcessTree.getProcessTree(this._rootProcessId, (tree) => { const name = this.traverseTree(tree); this._currentRequest = undefined;
Change:
VSCode Version: 1.49.1 OS Version: Windows 10 Steps to Reproduce: this on VSCode settings: a folder with an and another the folder in VSCode () You'll notice that the file was opened automatically, but the right file would be . <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes It also occurs with VSCode Insiders current version.
Thanks, for pointing out. I made a PR:
Confirmed that it's working as expected in today's build.

Discussion:
const folderUri = folder.uri; return fileService.resolve(folderUri) .then(folder => { <del> const files = folder.children ? folder.children.map(child => child.name) : []; </del> <ins> const files = folder.children ? folder.children.map(child => child.name).sort() : []; const file = files.find(file => file.toLowerCase() === 'readme.md') || files.find(file => file.toLowerCase().startsWith('readme')); </ins> <del> const file = files.sort().find(file => file.toLowerCase().startsWith('readme')); </del> if (file) { return joinPath(folderUri, file); }
Change:
Would it be possible to implement support for Typographer mode in the Markdown preview? has support for a typographer option to "enable some language-neutral replacement + quotes beautification". A live comparison is available on . I've listed some of the most common examples below: Name Typographer -- -- Left single quote Left double quote Right single quote Right double quote Ellipsis En-dash Em-dash Copyright Trademark It'd be ideal to add a config setting such that Typographer replacements are done on-the-fly, similarly to the existing implementation of . Thank you for your time.

Discussion:
"description": "%markdown.preview.linkify%", "scope": "resource" }, <ins> "markdown.preview.typographer": { "type": "boolean", "default": false, "description": "%markdown.preview.typographer%", "scope": "resource" }, </ins> "markdown.preview.fontFamily": { "type": "string", "default": "-apple-system, BlinkMacSystemFont, 'Segoe WPC', 'Segoe UI', system-ui, 'Ubuntu', 'Droid Sans', sans-serif",

"description": "Provides rich language support for Markdown.", "markdown.preview.breaks.desc": "Sets how line-breaks are rendered in the Markdown preview. Setting it to 'true' creates a <br> for newlines inside paragraphs.", "markdown.preview.linkify": "Enable or disable conversion of URL-like text to links in the Markdown preview.", <ins> "markdown.preview.typographer": "Enable or disable some language-neutral replacement and quotes beautification in the Markdown preview.", </ins> "markdown.preview.doubleClickToSwitchToEditor.desc": "Double click in the Markdown preview to switch to the editor.", "markdown.preview.fontFamily.desc": "Controls the font family used in the Markdown preview.", "markdown.preview.fontSize.desc": "Controls the font size in pixels used in the Markdown preview.",

interface MarkdownItConfig { readonly breaks: boolean; readonly linkify: boolean; <ins> readonly typographer: boolean; </ins> } class TokenCache {

const config = vscode.workspace.getConfiguration('markdown', resource); return { breaks: config.get<boolean>('preview.breaks', false), <del> linkify: config.get<boolean>('preview.linkify', true) </del> <ins> linkify: config.get<boolean>('preview.linkify', true), typographer: config.get<boolean>('preview.typographer', false) </ins> }; }
Change:
The context is: and the deprecation of I noticed 2 uses of that ideally we can replace with and : I would have done it but wasn't exactly sure, my guess would be to use the variant here since we are in context.
Right now it looks like returns a uri. Will it instead return a uri as part of ?
sorry, forgot to mention: currently on I have just put stubs that do nothing, but in the branch, you will: get a scheme when using get a scheme when using As long as you are in environments, it should be unless you add this to a renderer (e.g. DOM).

Discussion:
import { Readable } from 'stream'; import { bufferToStream, VSBuffer, VSBufferReadableStream } from 'vs/base/common/buffer'; import { Disposable, toDisposable } from 'vs/base/common/lifecycle'; <del> import { Schemas } from 'vs/base/common/network'; </del> <ins> import { FileAccess, Schemas } from 'vs/base/common/network'; </ins> import { URI } from 'vs/base/common/uri'; import { FileOperationError, FileOperationResult, IFileService } from 'vs/platform/files/common/files'; import { IRemoteConnectionData } from 'vs/platform/remote/common/remoteAuthorityResolver';

const uri = URI.parse(request.url); const entry = WebviewProtocolProvider.validWebviewFilePaths.get(uri.path); if (typeof entry === 'string') { <del> let url: string; if (uri.path.startsWith('/electron-browser')) { url = require.toUrl(`vs/workbench/contrib/webview/electron-browser/pre/${entry}`); } else { url = require.toUrl(`vs/workbench/contrib/webview/browser/pre/${entry}`); } return callback(decodeURIComponent(url.replace(`${Schemas.file}://`, ''))); </del> <ins> const relativeResourcePath = uri.path.startsWith('/electron-browser') ? `vs/workbench/contrib/webview/electron-browser/pre/${entry}` : `vs/workbench/contrib/webview/browser/pre/${entry}`; const url = FileAccess.asFileUri(relativeResourcePath, require); return callback(decodeURIComponent(url.fsPath)); </ins> } } catch { // noop
Change:
(Apologize in advance if this is the wrong place to file this, I'm having trouble tracking down the right place.) When I make a Markdown footnote, like the first word or letter is underlined and when I right-click it it offers to . <img width="473" alt="image" src="https://user-"
VS Code's built-in markdown extension targets standard markdown, which doesn't include footnote support. As a compromise, we could update the regular expression the built-in markdown extension uses to find clickable links to exclude links starting with Starting point in code:
Yeah, thanks. That's an understandable perspective. I might do a PR for this myself. One question that still confuses me though, why does it say "Execute command" (and not "Follow link" like other links show)? <img width="597" alt="Follow Link" src="https://user-"
First day looking at the code base, so I could be off on this, but looks like the logic for when "Execute Command" is displayed is in this function: Also, are you planning on doing a PR for this still? If not I can do it.
Thanks for the additional info! Please go ahead if you're ready to work on a PR now.
I may be wrong about this, however it seems to me the problem is with how validates a definition link. In the image below notice how the last line is considered valid, and would have a tooltip and underline in the editor. ! The regex produces a valid match since the last capture group ignores everything past the first space after the link. What if we modified the expression to something like this? (tests pass) !
Yes looks like the regular expression may just need to be updated, either to check that there are not multiple words after the references or to check that the definition does not start with

Discussion:
export default class LinkProvider implements vscode.DocumentLinkProvider { private readonly linkPattern = /([((![[^]]*?](s*)([^s()]+?)s*)]|(?:]|[^]])*])(s*)(([^s()]|(S*?))+)s*(".*?")?)/g; private readonly referenceLinkPattern = /([((?:]|[^]])+)][s*?)([^s]]*?)]/g; <del> private readonly definitionPattern = /^([t ]*[((?:]|[^]])+)]:s*)(S+)/gm; </del> <ins> private readonly definitionPattern = /^([t ]*[(?!^)((?:]|[^]])+)]:s*)(S+)/gm; </ins> public provideDocumentLinks( document: vscode.TextDocument,

assertRangeEqual(link4.range, new vscode.Range(0, 50, 0, 59)); } }); <ins> // #107471 test('Should not consider link references starting with ^ character valid', () => { const links = getLinksForFile('[^reference]: https://example.com'); assert.strictEqual(links.length, 0); }); </ins> });
Change:
Issue Type: <bBug</bwrite as html: "<div class="center"<div<h1<spanВведите имя статьи:</span</h1</div<div<input class="newPageName" type="text" placeholder="Введите имя статьи" /</div</div { padding: 0 auto; } .center h1{ text-align: center; } .center input.newPageName </style" while typing '' we can see emmet help window with 'Nanew...' VS Code version: Code 1.49.2 (, 2020-09-24T16:29:41.983Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (20)</summaryExtensionVersion ------ better-comments2.1.0 vscode-standardjs1.3.0 jshint0.10.21 vscode-eslint2.1.8 jquerysnippets0.0.1 xml2.5.1 gitlens10.2.2 LogFileHighlighter2.9.0 vsc-material-theme33.0.0 vsc-material-theme-icons1.2.0 prettier-vscode5.7.1 vscode-firefox-debug2.9.1 vscode-npm3.3.0 vscode-gutter-preview0.26.2 vs-color-picker1.0.0 metago4.2.0 MetaJump1.1.1 MetaWord1.2.1 debugger-for-chrome4.12.11 vscode-css-peek4.0.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.564 --<!-- potentialduplicatescomment --
Duplicate of
Deduplicating since this only occurs in HTML files
It doesn't suggest now in the latest Insiders, but it's still making a suggestion when it's not supposed to. Leaving this issue open.
can you please give some clarity on this issue. I would like to contribute here. I have a VS code setup with Version: 1.53.0 and I am not able to repro the Nan issue here Following are the changes that I made to repro the issue - Vs code , created an Html file this code snippet - Did not encounter the Nan issue mentioned in the bug description
the issue is that if you type manually into an HTML file, after typing you'll notice is suggested. That suggestion should not happen, because we're not in an actual CSS body.
closedWith
I see this: ! Is that the issue still?
Not exactly, but I'll reopen it still.

Discussion:
const currentHtmlNode = <HtmlFlatNode>currentNode; if (currentHtmlNode && currentHtmlNode.open && currentHtmlNode.close) { const offset = document.offsetAt(position); <del> if (currentHtmlNode.open.end <= offset && offset <= currentHtmlNode.close.start) { if (currentHtmlNode.name === 'style' && currentHtmlNode.open.end < offset && currentHtmlNode.close.start > offset) { </del> <ins> if (currentHtmlNode.open.end < offset && offset <= currentHtmlNode.close.start) { if (currentHtmlNode.name === 'style') { </ins> const buffer = ' '.repeat(currentHtmlNode.open.end) + document.getText().substring(currentHtmlNode.open.end, currentHtmlNode.close.start); return parseStylesheet(buffer); }
Change:
Cannot reproduce it locally. Will check how often this is failing.
I was able to reproduce this same bug locally with just using the . Reproduction: and select TypeScript (I also used and no ) Open and change the test to only have debugger for tests Output: ! VSCode install version: ! Happy to send along the reproduction project if needed edit: after more exploration, I found that all the other areas of worked. So using instead of is a workaround.+

Discussion:
}); }); <del> test.skip('ExtensionRecommendationsService: Able to retrieve collection of all ignored recommendations', async () => { </del> <ins> test('ExtensionRecommendationsService: Able to retrieve collection of all ignored recommendations', async () => { </ins> const storageService = instantiationService.get(IStorageService); const workspaceIgnoredRecommendations = ['ms-dotnettools.csharp']; // ignore a stored recommendation and a workspace recommendation.

await testObject.activationPromise; const recommendations = testObject.getAllRecommendationsWithReason(); <del> assert.ok(recommendations['ms-python.python'], 'ms-python.python extension shall exist'); assert.ok(!recommendations['mockpublisher2.mockextension2'], 'mockpublisher2.mockextension2 extension shall not exist'); assert.ok(!recommendations['ms-dotnettools.csharp'], 'ms-dotnettools.csharp extension shall not exist'); </del> <ins> assert.deepStrictEqual(Object.keys(recommendations), ['ms-python.python', 'mockpublisher1.mockextension1']); </ins> }); test('ExtensionRecommendationsService: Able to dynamically ignore/unignore global recommendations', async () => {
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --VSCode version: 1.49.2 Theme used: "Default Dark+" with some color customizations Specific relevant settings: I've enabled the recently "trailing" whitespace rendering option, and set the foreground colour to make any trailing whitespace stand out clearly. That works fine. I like the new configuration option, thanks! Since changing the whitespace foreground colour, I have noticed that whitespace rendering is applied in the SCM commit message box when text is selected. For example: <img width="389" alt="image" src="https://user-"As can be seen, some kind of rendering or overlay is being applied to spaces in the middle line, making it very difficult to read. I have confirmed by experiment that the "editorWhitespace.foreground" color is being used. When a less obtrusive color was used (as per the default, and a typical choice when all whitespace is rendered), the impact was less noticeable. I don't think that any whitespace rendering should be being applied in this box at all. If some users do desire it, I would expect them to want it at all times, not only for selected text. I attempted to track down a location in the code where the rendering and associated color settings are applied for a SourceControlInputBox and thus be able to make a PR, however I don't have any knowledge of js/ts and it was taking me a lot longer than is reasonable.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.626 --- <!-- score: 0.473 --- <!-- score: 0.445 --<!-- potentialduplicatescomment --
None of the duplicate suggestions apply. was the issue that the "trailing" option mentioned in the description.
Let's just disable render whitespace in the scm editor.
I think I found the right location for a fix (disabling whitespace rendering altogether) and tested it locally already, would you mind if I sent a pull request?

Discussion:
padding: { top: 3, bottom: 3 }, quickSuggestions: false, scrollbar: { alwaysConsumeMouseWheel: false }, <del> overflowWidgetsDomNode </del> <ins> overflowWidgetsDomNode, renderWhitespace: 'none' </ins> }; const codeEditorWidgetOptions: ICodeEditorWidgetOptions = {
Change:
Issue Type: <bBug</bRepro the references code lens for JS/TS a JS/TS file with a references code lens. down and drag to make a selection the mouse while the pointer is over one of the references code lenses Bug This activates the code lens. My expectation is that the code lens would only be activated if I clicked on it, not on mouse up VS Code version: Code - Insiders 1.50.0-insider (, 2020-09-29T09:05:00.729Z) OS version: Darwin x64 19.6.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Hi! I would like to try this issue. Do you think it is beginner friendly? Any ideas where to start?
Great. This is the pointer: There is two ways to fix this: of listening for "mouse up" listen for "mouse down". This is simple but makes code lenses also very eager, alternatively that on "mouse up" you still on the right element. On line 230 there is already a check but it seems to be not enough
Hi! Worked on it a little. I think on mouseup will trigger the tagname == 'A', if the target is a code lens regardless of whether you have selected other text. Is there an editor mouse event that is equivalent to a click, such that it will only trigger if the mouse is pressed up and down on the same target? Because that would be ideal for only having the code lens open on click rather than on accident when other text is being selected.
This is the bug we're trying to fix correct (we don't want the code lens reference to create a pop up in this case)? !
Yeah. So option 1 should fix it, option 2 needs knowledge about what happened in "mouse down"
Cool! Got it : ) I tried both options and I think option 1 looks good. I'm going to create a pull request!

Discussion:
this._disposeAllLenses(undefined, undefined); } })); <del> this._localToDispose.add(this._editor.onMouseUp(e => { </del> <ins> this._localToDispose.add(this._editor.onMouseDown(e => { </ins> if (e.target.type !== MouseTargetType.CONTENT_WIDGET) { return; }
Change:
Issue Type: <bBug</bRepro the standard dark+ theme the 'select service' UI for setting sync bug This input has a blue boarder around it, however the two input options cut off this boarder on the sides: <img width="1298" alt="Screen Shot 2020-09-29 at 12 01 53 PM" src="https://user-"VS Code version: Code - Insiders 1.50.0-insider (, 2020-09-29T09:05:00.729Z) OS version: Darwin x64 19.6.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
How do I trigger this UI?
Stop Settings Sync if it is On. Turn on Settings Sync and you will see this UI in the turn on flow. This is available only in insiders
I can't trigger it. When I'm turning on setting sync, I get the 'select an account to sign in' UI, and not the 'select service'. I need to set it to 'stable' so I could sync my settings. Can it be done in another way? !
it looks like the UI for this has changed now so I'm going to close this
Actually, I was able to repro after signing in and clicking on the quick pick
test steps: turn off settings sync if it's on turn on settings sync you may need to log in to settings first click on the title of the quick pick You should see the blue border around the entire quick pick !

Discussion:
position: absolute; width: 600px; z-index: 2000; <del> padding-bottom: 6px; </del> <ins> padding: 0 1px 6px 1px; </ins> left: 50%; margin-left: -300px; }
Change:
Testing Focus on a setting that is ignored to sync Voice over does not read that setting is ignored to sync <img width="647" alt="image" src="https://user-"
One setting to check this issue with is . It is one of those settings that settings sync ignores.
I still see Voice Over not reading it <img width="882" alt="image" src="https://user-"<img width="774" alt="Screenshot 2022-02-02 at 16 02 23" src="https://user-"I am reopening it as verification found. Since it is not a blocker moving this to next milestone.

Discussion:
const syncIgnoredElement = DOM.append(container, $('span.setting-item-ignored')); const syncIgnoredLabel = new SimpleIconLabel(syncIgnoredElement); syncIgnoredLabel.text = `($(sync-ignored) ${localize('extensionSyncIgnoredLabel', 'Sync: Ignored')})`; <ins> syncIgnoredLabel.title = localize('syncIgnoredTitle', "Settings sync does not sync this setting"); </ins> return syncIgnoredElement; }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.49.2 OS Version: Win10 host using WSL2 docker dev container Steps to Reproduce: the Code - OSS Development Container docker setup instructions, first thing to happen on fresh container checkout <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes

Discussion:
* text eol=lf <ins> *.exe binary *.dll binary </ins>