jiebi/CodeConvo huggingface dataset:
Change:
! !
I think this was the result of moving the progress bar below the input. Since the progress bar use to provide the padding.
let's just call it an exploration of compact mode :) /s
This is partially as designed, but it still needs improvement. The latest changes make it so we have a nice cutoff when the quick pick list is scrolling: <img width="653" alt="CleanShot 2022-12-16 at 09 23 10 src="https://user-"However it should probably still use padding at the bottom of the list, rather than the container, to ensure this doesn't happen when the entire list is visible/not scrollable.
I dont want to be the annoying guy at the party here, but an empty quick pick now looks like this: <img width="647" alt="image" src="https://user-"vs before <img width="633" alt="image" src="https://user-"
Haha, whoops. I'll have another go at this then.
verified the original issue here, but we'll continue the next issue in:

Discussion:
.quick-input-list .monaco-list { overflow: hidden; max-height: calc(20 * 22px); <ins> padding-bottom: 5px; </ins> } .quick-input-list .monaco-scrollable-element {
Change:
Type: <bBug</b- VS Code Version: 1.74.1 OS Version: Windows NT x64 10.0. Issue appeared just after upgrading VSCode to ver. 1.74.1 Currently, it is impossible to go to the function definition by clicking Ctrl+Click on the function name or using the F12 button. Also, the Go to definition option in Top Menu-Go-Go to Definition is disabled. VS Code version: Code 1.74.1 (, 2022-12-14T10:30:51.966Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
What code language? Is the option also disabled in the context menu? was a previous issue about this and related options not getting enabled in the top-level Go menu. Maybe this has come back. Do you think this didn't happen in 1.74.0?
- maybe caused by
Yeah, looks like the precondition for the command is too strong
Javascript I don't have such an option in the context menu I'm not 100% sure, which version I had previously installed, but I'm using VSCode almost every day, so I'm pretty sure I was using 1.74.0 or 1.73.1, and that behavior has occurred after auto-upgrade to 1.74.1. I've never noticed anything like it before.
After a clean uninstall (Uninstalled and deleted %APPDATA%Code and %USERPROFILE%.vscode), and installing 1.74.1 again, the problem does not occur anymore.

Discussion:
order: 1.1 }, { id: MenuId.MenubarGoMenu, <ins> precondition: null, </ins> group: '4_symbol_nav', order: 2, }]

order: 1.3 }, { id: MenuId.MenubarGoMenu, <ins> precondition: null, </ins> group: '4_symbol_nav', order: 3, }],

order: 1.4 }, { id: MenuId.MenubarGoMenu, <ins> precondition: null, </ins> group: '4_symbol_nav', order: 3, }]

order: 1.45 }, { id: MenuId.MenubarGoMenu, <ins> precondition: null, </ins> group: '4_symbol_nav', order: 4, }]

order: 1.45 }, { id: MenuId.MenubarGoMenu, <ins> precondition: null, </ins> group: '4_symbol_nav', order: 5, }]

/** * One or many menu items. */ <del> menu?: OneOrN<{ id: MenuId } & Omit<IMenuItem, 'command'>>; </del> <ins> menu?: OneOrN<{ id: MenuId; precondition?: null } & Omit<IMenuItem, 'command'>>; </ins> /** * One keybinding.

// menu if (Array.isArray(menu)) { for (const item of menu) { <del> disposables.add(MenuRegistry.appendMenuItem(item.id, { command, ...item })); </del> <ins> disposables.add(MenuRegistry.appendMenuItem(item.id, { command: { ...command, precondition: item.precondition === null ? undefined : command.precondition }, ...item })); </ins> } } else if (menu) { <del> disposables.add(MenuRegistry.appendMenuItem(menu.id, { command, ...menu })); </del> <ins> disposables.add(MenuRegistry.appendMenuItem(menu.id, { command: { ...command, precondition: menu.precondition === null ? undefined : command.precondition }, ...menu })); </ins> } if (f1) { disposables.add(MenuRegistry.appendMenuItem(MenuId.CommandPalette, { command, when: command.precondition }));
Change:
This is a regression of <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.1 arm64 OS Version: macOS 13.0.1 Steps to Reproduce: Set this settings Trigger the hover via keyboard cmd + k, cmd + I The hover disappears on minimal movement. I'm expecting to disable the hover via mouse and use only with keyboard. refs

Discussion:
return; } <ins> if (this._isHoverSticky && this._contentWidget?.isVisibleFromKeyboard()) { // Sticky mode is on and the hover has been shown via keyboard // so moving the mouse has no effect return; } </ins> if (!this._isHoverEnabled) { this._hideWidgets(); return;

const contentWidget = this._getOrCreateContentWidget(); <del> if (this._isHoverSticky && contentWidget.isVisibleFromKeyboard()) { // Sticky mode is on and the hover has been shown via keyboard // so moving the mouse has no effect return; } </del> if (contentWidget.maybeShowAt(mouseEvent)) { this._glyphWidget?.hide(); return;
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.75.0-insider OS Version: Linux Hello, Thanks for the new color themes. I have few observations related to whitespace character visibility. Can you please take a look into these? (default) option, the whitespace characters are hard to see. Default Dark+ Experimental (v2): ! Default Dark+: ! the whitespace foreground could use some alpha Default Dark+ Experimental (v2): ! Default Dark+ Experimental (v2): with some alpha ! Default Dark+: ! Thanks

Discussion:
"editorLineNumber.activeForeground": "#ffffffc5", "editorLineNumber.foreground": "#6e7681", "editorOverviewRuler.border": "#010409", <del> "editorWhitespace.foreground": "#484f58", </del> "editorWidget.background": "#1f1f1f", "errorForeground": "#f85149", "focusBorder": "#2488d8",

"editorLineNumber.foreground": "#6e7681", "editorOverviewRuler.border": "#0000001a", "editorSuggestWidget.background": "#f8f8f8", <del> "editorWhitespace.foreground": "#484f58", </del> "editorWidget.background": "#ffffff", "errorForeground": "#f85149", "focusBorder": "#005FB8",
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.75.0-insider Commit: Date: 2022-12-16T05:22:34.551Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin x64 22.2.0 Sandboxed: Yes Steps to reproduce: a TypeScript file and insert , insert or enough to get a GitHub Copilot inline suggestion of , and press <kbdtab</kbdto accept. (I assume other inline suggestion providers can trigger the same behavior.) that the rendered error span has moved to the curly brace. that TS Server logs show the text insertion and subsequent results with proper spans: https://user-
Full ts server log:
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

Discussion:
} const existing = this._diagnostics.get(kind); <del> if (arrays.equals(existing || arrays.empty, diagnostics, diagnosticsEquals)) { </del> <ins> if (existing?.length === 0 && diagnostics.length === 0) { </ins> // No need to update return false; }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: Have setting or e.g. Ctrl - Option - Command - Shift (aka. Hyper-Key) Expected: The inlay hints don't show or hide because the shortcut is configured to work for modifiers - only and gets ignored when any other modifier is pressed. Experienced: The inlay hints show or hide even if other modifiers are pressed at the same time. Note I tested with VS Code Insiders but inlay hints did not show at all when using it.
Honest question: How this supposed to work? When pressing the ctrl-option subsequence for how long should we wait to await more keys? Or do you specifically mean the sequence (1) ctrl, (2) options, (3) command, 4(shift)?
In my (naive) thought (naive because I have absolutely no idea how the VS Code key handling works), there was no awaiting for more keys involved. I thought that adding a modifier to an existing combination gets detected/handled the same way as removing a modifier. Because this is something that currently works: Pressing shows the inlay hints, removing the so only pressing hides the inlay hints again regardless of how long it takes to remove this second modifier. What does not work is pressing (to enable) and adding another modifier to disable.
Yeah, that could actually work but it might mean that pressing (1) ctrl, (2) options, (3) shift will cause a short flicker because between (2) and (3) inlay hints will be active
Ok, that was actually quite easy https://user-
Very cool. Thanks for looking into and implementing it.

Discussion:
if (!this._editor.hasModel()) { return; } <del> const newRenderMode = e.altKey && e.ctrlKey ? altMode : defaultMode; </del> <ins> const newRenderMode = e.altKey && e.ctrlKey && !(e.shiftKey || e.metaKey) ? altMode : defaultMode; </ins> if (newRenderMode !== this._activeRenderMode) { this._activeRenderMode = newRenderMode; const model = this._editor.getModel();
Change:
would you be able to help route this issue to the correct owner? Thanks!
Not sure if Sandy or SteVen.

Discussion:
this._register(addDisposableListener(actions, EventType.CLICK, e => e.preventDefault())); <del> this._register(this.viewDescriptorService.getViewContainerModel(this.viewDescriptorService.getViewContainerByViewId(this.id)!)!.onDidChangeContainerInfo(({ title }) => { this.updateTitle(this.title); })); </del> <ins> const viewContainerModel = this.viewDescriptorService.getViewContainerByViewId(this.id); if (viewContainerModel) { this._register(this.viewDescriptorService.getViewContainerModel(viewContainerModel).onDidChangeContainerInfo(({ title }) => this.updateTitle(this.title))); } else { console.error(`View container model not found for view ${this.id}`); } </ins> const onDidRelevantConfigurationChange = Event.filter(this.configurationService.onDidChangeConfiguration, e => e.affectsConfiguration(ViewPane.AlwaysShowActionsConfig)); this._register(onDidRelevantConfigurationChange(this.updateActionsVisibility, this));
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.1, commit VS Code Insiders Version: 1.75.0, commit . I discovered the following bug while investigating (and fixing) To summarize, the issue is that if a code action has both the and properties set, then the command isn't executed. I created the following repo with a minimal reproduction:
I'm not sure this is accurate on the VS Code side since JS/TS uses edits + commands without issue Made code actions skip running commands if applying the edit fails. Are you perhaps supplying an empty or invalid edit?
Is an empty edit considered invalid? Because that's what the Rust language service does: It provides an empty edit so that the editor doesn't resolve the code action and ask for the missing property.
When you say empty, do you mean the edit is or do you return an edit object without any edits?
I mean a .
likely fixes that but returning empty edits to force a resolve seems suspicious. On the VS Code side, should only be called . If LSP is doing something different, please file an issue against them
Yep the Rust issue is now fixed in Insiders. Note that it's the other way around: The Rust client returns empty edits so that VS Code doesn't invoke .

Discussion:
return; } <del> if (item.action.edit) { </del> <ins> if (item.action.edit?.edits.length) { </ins> const result = await bulkEditService.apply(item.action.edit, { editor: options?.editor, label: item.action.title,
Change:
These flakes are a bit odd, not sure what could cause them and the failures seem a bit all over the place
I some logs that will help with debugging future failures. Closing in the meantime until a new one pops up.

Discussion:
import { TerminalCapabilityStore } from 'vs/platform/terminal/common/capabilities/terminalCapabilityStore'; import { assertLinkHelper, resolveLinkForTest } from 'vs/workbench/contrib/terminal/test/browser/links/linkTestUtils'; import { Terminal } from 'xterm'; <ins> import { timeout } from 'vs/base/common/async'; import { strictEqual } from 'assert'; </ins> const unixLinks = [ '/foo',

text: string, expected: (Pick<ITerminalSimpleLink, 'text'> & { range: [number, number][] })[] ) { <del> await assertLinkHelper(text, expected, detector, type); </del> <ins> const race = await Promise.race([ assertLinkHelper(text, expected, detector, type).then(() => 'success'), timeout(2).then(() => 'timeout') ]); strictEqual(race, 'success', `Awaiting link assertion for "${text}" timed out`); </ins> } setup(() => {

suite(`Link: ${baseLink}`, () => { for (let i = 0; i < supportedLinkFormats.length; i++) { const linkFormat = supportedLinkFormats[i]; <del> test(`Format: ${linkFormat.urlFormat}`, async () => { const formattedLink = format(linkFormat.urlFormat, baseLink, linkFormat.line, linkFormat.column); </del> <ins> const formattedLink = format(linkFormat.urlFormat, baseLink, linkFormat.line, linkFormat.column); test(`should detect in "${formattedLink}"`, async () => { </ins> await assertLink(TerminalBuiltinLinkType.LocalFile, formattedLink, [{ text: formattedLink, range: [[1, 1], [formattedLink.length, 1]] }]); await assertLink(TerminalBuiltinLinkType.LocalFile, ` ${formattedLink} `, [{ text: formattedLink, range: [[2, 1], [formattedLink.length + 1, 1]] }]); await assertLink(TerminalBuiltinLinkType.LocalFile, `(${formattedLink})`, [{ text: formattedLink, range: [[2, 1], [formattedLink.length + 1, 1]] }]);

suite(`Link "${baseLink}"`, () => { for (let i = 0; i < supportedLinkFormats.length; i++) { const linkFormat = supportedLinkFormats[i]; <del> test(`Format: ${linkFormat.urlFormat}`, async () => { const formattedLink = format(linkFormat.urlFormat, baseLink, linkFormat.line, linkFormat.column); </del> <ins> const formattedLink = format(linkFormat.urlFormat, baseLink, linkFormat.line, linkFormat.column); test(`should detect in "${formattedLink}"`, async () => { </ins> await assertLink(TerminalBuiltinLinkType.LocalFile, formattedLink, [{ text: formattedLink, range: [[1, 1], [formattedLink.length, 1]] }]); await assertLink(TerminalBuiltinLinkType.LocalFile, ` ${formattedLink} `, [{ text: formattedLink, range: [[2, 1], [formattedLink.length + 1, 1]] }]); await assertLink(TerminalBuiltinLinkType.LocalFile, `(${formattedLink})`, [{ text: formattedLink, range: [[2, 1], [formattedLink.length + 1, 1]] }]);
Change:
Version: 1.75.0 from main set "diffEditor.ignoreTrimWhitespace": falseFile 1, using 4 spaces as indentationFile 2, using tab as indentationSelect both files and invoke Dev tools pop up on debugger statement `
I'm having trouble reproducing. Have you customized other settings? <img width="866" alt="image" src="https://user-"
Blocks
I can reproduce when typing a in one of the sides: <img width="865" alt="image" src="https://user-"
It looks like there's an assertion checking that these produced diffs should be reported in a different shape (introduced via )
You are correct, there needs to be additional spaces in file 2 after . Sorry for that. I fixed the description

Discussion:
return false; } <ins> if (prevChange.originalEndLineNumber === originalLineNumber && prevChange.modifiedEndLineNumber === modifiedLineNumber) { if (this.shouldComputeCharChanges && prevChange.charChanges) { prevChange.charChanges.push(new CharChange( originalLineNumber, originalStartColumn, originalLineNumber, originalEndColumn, modifiedLineNumber, modifiedStartColumn, modifiedLineNumber, modifiedEndColumn )); } return true; } </ins> if (prevChange.originalEndLineNumber + 1 === originalLineNumber && prevChange.modifiedEndLineNumber + 1 === modifiedLineNumber) { prevChange.originalEndLineNumber = originalLineNumber; prevChange.modifiedEndLineNumber = modifiedLineNumber;

]; assertDiff(original, modified, expected, false, false, false); }); <ins> test('issue #169552: Assertion error when having both leading and trailing whitespace diffs', () => { const original = [ 'if True:', '    print(2)', ]; const modified = [ 'if True:', 'tprint(2) ', ]; const expected = [ createLineChange( 2, 2, 2, 2, [ createCharChange(2, 1, 2, 5, 2, 1, 2, 2), createCharChange(2, 13, 2, 13, 2, 10, 2, 11), ] ), ]; assertDiff(original, modified, expected, true, false, false); }); </ins> });
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --There is an extra at the end of on L141.

Discussion:
'properties': { [FILES_EXCLUDE_CONFIG]: { 'type': 'object', <del> 'markdownDescription': nls.localize('exclude', "Configure [glob patterns](https://code.visualstudio.com/docs/editor/codebasics#_advanced-search-options) for excluding files and folders. For example, the File Explorer decides which files and folders to show or hide based on this setting. Refer to the `#search.exclude#` setting to define search-specific excludes. Refer to the `#explorer.excludeGitIgnore#` setting for ignorings files based on your `.gitignore`."), </del> <ins> 'markdownDescription': nls.localize('exclude', "Configure [glob patterns](https://code.visualstudio.com/docs/editor/codebasics#_advanced-search-options) for excluding files and folders. For example, the File Explorer decides which files and folders to show or hide based on this setting. Refer to the `#search.exclude#` setting to define search-specific excludes. Refer to the `#explorer.excludeGitIgnore#` setting for ignoring files based on your `.gitignore`."), </ins> 'default': { ...{ '**/.git': true, '**/.svn': true, '**/.hg': true, '**/CVS': true, '**/.DS_Store': true, '**/Thumbs.db': true }, ...(isWeb ? { '**/*.crswap': true /* filter out swap files used for local file access */ } : undefined)
Change:
Telemetry extractor job fails: !
And I saw this and investigated, but have no idea why it fails. The extractor outputs debug info as it runs and there is no output here leading me to think what is failing is actually the package download from the npm registry. any thoughts?
Maybe could help track down the root cause?
Thanks for the tip, I haven't enabled this just because of how noisy things will be, but if you see this fail please check the option when re-running the failed job. So far I have not seen it fail after a re-run so still am unsure of the error.

Discussion:
- name: 'Run vscode-telemetry-extractor' run: 'npx --package=@vscode/telemetry-extractor --yes vscode-telemetry-extractor -s .' <ins> with: GITHUB_TOKEN: ${{secrets.VSCODE_ISSUE_TRIAGE_BOT_PAT}} </ins>