Change:
Type: <bBug</bthe search side panel a search term search returns results and click the 'collapse all' button at the top right of the search panel : nothing happens. Also, the icon shows a '+'. It should show a '-' because the list is already expanded. Before the latest update, this worked as expected. VS Code version: Code 1.86.0 (, 2024-01-31T10:28:19.990Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (32)</summaryExtensionVersion ------ Bookmarks13.4.2 path-intellisense2.8.5 vscode-markdownlint0.54.0 vscode-eslint2.4.4 githistory0.6.20 prettier-vscode10.1.0 auto-close-tag0.5.15 copilot1.156.0 copilot-chat0.12.0 remotehub0.62.0 vscode-pull-request-github0.80.0 vscode-graphql-syntax1.3.1 path-autocomplete1.25.0 vscode-env0.1.0 rainbow-csv3.11.0 debugpy2024.0.0 remote-wsl0.86.0 remote-repositories0.40.0 vsliveshare1.0.5905 peggy-language2.4.1 language-plan0.0.1 excalidraw-editor3.7.1 quicktype12.0.46 vscode-yaml1.14.0 vscode-paste-and-indent0.0.8 partial-diff1.4.3 multi-command1.6.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-icons12.7.0 gitblame10.7.1 copy-hover-type0.0.7 </details<!-- generated by issue reporter --
!
This is a pretty significant bug, because it makes the search near useless when there are a large number of files containing hits, or when there are many hits in a single file. It makes the list very tall to scroll through, and file names are harder to pick out.
Hmm, I can't seem to repro this issue. What value do you have for ? Do you have any other search-related settings?
I am able to reproduce: Version: 1.86.0 (Universal) Commit: Date: 2024-01-31T10:29:15.765Z Electron: 27.2.3 ElectronBuildId: Chromium: 118.0.5993.159 18.17.1 V8: 11.8.172.18-electron.0 OS: Darwin arm64 23.2.0 Looking at the option that was mentioned: When I search, after results are populated I am not able to collapse them using the button shown in the screenshot. Workaround I seem to have restored functionality by modifying the to a different value than . I unfortunately don't know which specific value fix things, so would recommend trying them each, redo the search, and then attempt to click the collapse button. I am now able to toggle the button regardless of what option is set to
Hmm. Does your explicitly say now? and if you remove it, can you reproduce the bug?
It does not have that explicitly defined in my case and I don't believe I had it explicitly set previously. I also have since updated to 1.86.1. I'm having a hard time reliably reproducing the bug unfortunately. I will make sure to report back if I reproduce. I do wonder if some of the behavior was less due to the button and maybe the search still loading?
I have submitted a PR that I think fixes the issue.
Waiting for this since a few days. I assume the fix is isn't in 1.86.2.
no, it's in 1.87 which should be published this week.

Discussion:
const updateHasSomeCollapsible = () => this.toggleCollapseStateDelayer.trigger(() => this.hasSomeCollapsibleResultKey.set(this.hasSomeCollapsible())); updateHasSomeCollapsible(); this._register(this.tree.onDidChangeCollapseState(() => updateHasSomeCollapsible())); <ins> this._register(this.tree.onDidChangeModel(() => updateHasSomeCollapsible())); </ins> this._register(Event.debounce(this.tree.onDidOpen, (last, event) => event, DEBOUNCE_DELAY, true)(options => { if (options.element instanceof Match) {