jiebi/CodeConvo huggingface dataset:
Change:
GitHub Tags: #A11yMAS; #A11yTCS; #A11ySev2; #Device; #Visual Studio Code Client; #BM-VisualStudioCodeClient-MAC-Oct2022; WCAG1.3.1; #Voiceover; #Screenreader; #Info and Relationships; Visual Studio Code Insiders Screenreader: Voiceover Visual studio code editor the command Pallet and type "setting". down-arrow key select user setting. the word "Auto " and select one of the suggestion given by the vs code editor. the "Tab size" and select the option from the auto suggestion. that Voiceover is not announcing the message which appears when focus comes on "Auto". Voiceover is not announcing the message (Remove adjacent quotes ....) which appears when focus comes on "Auto". Voiceover should announce the message (Remove adjacent quotes ....) which appears when focus comes on "Auto". ! !
Reference bug:
I noticed that on macOS on Chromium-based browsers, VoiceOver doesn't read the aria-label of a div if the role of the div is set to "option". I'm wondering whether we could remove the "option" role of the div elements for this specific case, i.e. custom selectboxes on macOS, as a workaround? I can also file an upstream issue with Chromium in the meantime.
I have filed an upstream issue with a min repro (minimal reproducible case)
Verified the bug in the environment: Version: 1.45.0-insider (Universal) Commit: Date: 2023-05-22T05:32:52.588Z VS Code: 1.70.0 Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 22.4.0 Bug is not fixed and still repro'ing. Could you please reopen this issue.
please try again with today's Insiders.
Tried to download latest insiders but still we get the same version. Version: 1.45.0-insider (Universal) Commit: Date: 2023-05-26T05:31:07.551Z VS Code: 1.70.0 Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 22.4.0 Issue is still repro'ing. PFA for reference Could you please share the downloading link for the latest insiders where fixes are available for this issue.
regressed:05-29-23;
Hi that doesn't look like the right version of Insiders to me. Please try again after downloading the latest Insiders from
GithubTags:#Regressed:05-31-23;#Closed; Verified the bug in the environment: Version: 1.79.0-insider (Universal) Commit: Date: 2023-05-31T03:12:18.068Z Electron: 22.5.4 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin arm64 22.5.0 Bug is fixed and does not repro. Hence closing the bug. PFA for reference.

Discussion:
return label; }, getWidgetAriaLabel: () => localize({ key: 'selectBox', comment: ['Behave like native select dropdown element.'] }, "Select Box"), <del> getRole: () => 'option', </del> <ins> getRole: () => isMacintosh ? '' : 'option', </ins> getWidgetRole: () => 'listbox' } });
Change:
This code inserts a snippet with some dollars but no backslashes: But it shows up with backslashes: !

Discussion:
const actual3 = snippet3.toString(); assert.strictEqual(actual3, '.two.one.two.one <> .one.two.one.two'); }); <ins> test('Snippet choices are incorrectly escaped/applied #180132', function () { assertTextAndMarker('${1|aaa$aaa|}bbb$bbb', 'aaa$aaabbb$bbb', Placeholder, Text); }); </ins> });

} appendChoice(values: string[], number: number = this._tabstop++): SnippetString { <del> const value = values.map(s => s.replace(/$|}||,/g, '$&')).join(','); </del> <ins> const value = values.map(s => s.replaceAll(/[|,]/g, '$&')).join(','); </ins> this.value += '${'; this.value += number;

string = new types.SnippetString(); string.appendText('foo').appendChoice(['far', '$boo']).appendText('bar'); <del> assert.strictEqual(string.value, 'foo${1|far,$boo|}bar'); </del> <ins> assert.strictEqual(string.value, 'foo${1|far,$boo|}bar'); </ins> string = new types.SnippetString(); string.appendText('foo').appendPlaceholder('farboo').appendChoice(['far', 'boo']).appendText('bar'); assert.strictEqual(string.value, 'foo${1:farboo}${2|far,boo|}bar'); }); <ins> test('Snippet choices are incorrectly escaped/applied #180132', function () { { const s = new types.SnippetString(); s.appendChoice(["aaa$aaa"]); s.appendText("bbb$bbb"); assert.strictEqual(s.value, '${1|aaa$aaa|}bbb$bbb'); } { const s = new types.SnippetString(); s.appendChoice(["aaa,aaa"]); s.appendText("bbb$bbb"); assert.strictEqual(s.value, '${1|aaa,aaa|}bbb$bbb'); } { const s = new types.SnippetString(); s.appendChoice(["aaa|aaa"]); s.appendText("bbb$bbb"); assert.strictEqual(s.value, '${1|aaa|aaa|}bbb$bbb'); } { const s = new types.SnippetString(); s.appendChoice(["aaaaaa"]); s.appendText("bbb$bbb"); assert.strictEqual(s.value, '${1|aaaaaa|}bbb$bbb'); } }); </ins> test('instanceof doesn't work for FileSystemError #49386', function () { const error = types.FileSystemError.Unavailable('foo'); assert.ok(error instanceof Error);
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.77.3 OS Version: macOS Ventura 13.3.1 Steps to Reproduce: Git repository that has at least one tag any tag Expected: Do not show button when not on a branch Actual: <img width="391" alt="image" src="https://user-"Clicking this button runs and the button does not disappear after clicking

Discussion:
*--------------------------------------------------------------------------------------------*/ import { Command, Disposable, Event, EventEmitter, SourceControlActionButton, Uri, workspace, l10n } from 'vscode'; <del> import { Branch, Status } from './api/git'; </del> <ins> import { Branch, RefType, Status } from './api/git'; </ins> import { OperationKind } from './operation'; import { CommitCommandsCenter } from './postCommitCommands'; import { Repository } from './repository';

const showActionButton = config.get<{ publish: boolean }>('showActionButton', { publish: true }); // Not a branch (tag, detached), branch does have an upstream, commit/merge/rebase is in progress, or the button is disabled <del> if (!this.state.HEAD?.name || this.state.HEAD?.upstream || this.state.isCommitInProgress || this.state.isMergeInProgress || this.state.isRebaseInProgress || !showActionButton.publish) { return undefined; } </del> <ins> if (this.state.HEAD?.type === RefType.Tag || !this.state.HEAD?.name || this.state.HEAD?.upstream || this.state.isCommitInProgress || this.state.isMergeInProgress || this.state.isRebaseInProgress || !showActionButton.publish) { return undefined; } </ins> // Button icon const icon = this.state.isSyncInProgress ? '$(sync~spin)' : '$(cloud-upload)';
Change:
Here I have installed the extension but not enabled, so I suggest to change the wording of the button. !

Discussion:
throw new Error(localize('fail.noEditor', "Cannot open resource with notebook editor type '{0}', please check if you have the right extension installed and enabled.", input.viewType)); } <ins> await this._extensionsWorkbenchService.whenInitialized; const extensionInfo = this._extensionsWorkbenchService.local.find(e => e.identifier.id === knownProvider); </ins> throw createEditorOpenError(new Error(localize('fail.noEditor.extensionMissing', "Cannot open resource with notebook editor type '{0}', please check if you have the right extension installed and enabled.", input.viewType)), [ toAction({ <del> id: 'workbench.notebook.action.installOrEnableMissing', label: localize('notebookOpenInstallOrEnableMissingViewType', "Install and enable extension for '{0}'", input.viewType), run: async () => { </del> <ins> id: 'workbench.notebook.action.installOrEnableMissing', label: extensionInfo ? localize('notebookOpenEnableMissingViewType', "Enable extension for '{0}'", input.viewType) : localize('notebookOpenInstallMissingViewType', "Install extension for '{0}'", input.viewType) , run: async () => { </ins> const d = this._notebookService.onAddViewType(viewType => { if (viewType === input.viewType) { // serializer is registered, try to open again
Change:
A similar error has appeared for other Azure Pipelines tasks
Odd: one is about extracting first one shows no error at all (copy paste mistake?) second one is about creating a zip
This might actually be a bug on AZDO:
And we might be hitting it due to logging every single file. Let's stop doing that.
I reran the failure for the first one which is why it no longer shows an error here's the precise link to the failure
Thanks!

Discussion:
cacheHitVar: NODE_MODULES_RESTORED displayName: Restore node_modules cache <del> - script: tar -xvzf .build/node_modules_cache/cache.tgz </del> <ins> - script: tar -xzf .build/node_modules_cache/cache.tgz </ins> condition: and(succeeded(), eq(variables.NODE_MODULES_RESTORED, 'true')) displayName: Extract node_modules cache

set -e node build/azure-pipelines/common/listNodeModules.js .build/node_modules_list.txt mkdir -p .build/node_modules_cache <del> tar -cvzf .build/node_modules_cache/cache.tgz --files-from .build/node_modules_list.txt </del> <ins> tar -czf .build/node_modules_cache/cache.tgz --files-from .build/node_modules_list.txt </ins> condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true')) displayName: Create node_modules archive

cacheHitVar: NODE_MODULES_RESTORED displayName: Restore node_modules cache <del> - powershell: 7z.exe x .build/node_modules_cache/cache.7z -aoa -bb </del> <ins> - powershell: 7z.exe x .build/node_modules_cache/cache.7z -aoa </ins> condition: and(succeeded(), eq(variables.NODE_MODULES_RESTORED, 'true')) displayName: Extract node_modules cache

$ErrorActionPreference = "Stop" exec { node build/azure-pipelines/common/listNodeModules.js .build/node_modules_list.txt } exec { mkdir -Force .build/node_modules_cache } <del> exec { 7z.exe a .build/node_modules_cache/cache.7z -mx3 -bb `@.build/node_modules_list.txt } </del> <ins> exec { 7z.exe a .build/node_modules_cache/cache.7z -mx3 `@.build/node_modules_list.txt } </ins> condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true')) displayName: Create node_modules archive
Change:
copy the contents of paste into a untitled editor it takes seconds for me before the content appears, sometimes not at all !
Oh, there is this in the console:

Discussion:
this._itemsConstructed = 0; this._itemsFromCache = 0; <del> let result = this.parseList(SmallImmutableSet.getEmpty()); </del> <ins> let result = this.parseList(SmallImmutableSet.getEmpty(), 0); </ins> if (!result) { result = ListAstNode.getEmpty(); }

private parseList( openedBracketIds: SmallImmutableSet<OpeningBracketId>, <ins> level: number, </ins> ): AstNode | null { const items: AstNode[] = [];

break; } <del> child = this.parseChild(openedBracketIds); </del> <ins> child = this.parseChild(openedBracketIds, level + 1); </ins> } if (child.kind === AstNodeKind.List && child.childrenLength === 0) {

private parseChild( openedBracketIds: SmallImmutableSet<number>, <ins> level: number, </ins> ): AstNode { this._itemsConstructed++;

return token.astNode as TextAstNode; case TokenKind.OpeningBracket: { <ins> if (level > 300) { // To prevent stack overflows return new TextAstNode(token.length); } </ins> const set = openedBracketIds.merge(token.bracketIds); <del> const child = this.parseList(set); </del> <ins> const child = this.parseList(set, level + 1); </ins> const nextToken = this.tokenizer.peek(); if (
Change:
It would be nice to have a entry in the configuration section of markdown-math extension. A place where users could put their custom math macros.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified

Discussion:
"type": "boolean", "default": true, "description": "%config.markdown.math.enabled%" <ins> }, "markdown.math.macros": { "type": "object", "additionalProperties": { "type": "string" }, "default": {}, "description": "%config.markdown.math.macros%", "scope": "resource" </ins> } } }

{ "displayName": "Markdown Math", "description": "Adds math support to Markdown in notebooks.", <del> "config.markdown.math.enabled": "Enable/disable rendering math in the built-in Markdown preview." </del> <ins> "config.markdown.math.enabled": "Enable/disable rendering math in the built-in Markdown preview.", "config.markdown.math.macros": "A collection of custom macros. Each macro is a key-value pair where the key is a new command name and the value is the expansion of the macro." </ins> }

declare function require(path: string): any; <del> const enabledSetting = 'markdown.math.enabled'; </del> <ins> const markdownMathSetting = 'markdown.math'; </ins> export function activate(context: vscode.ExtensionContext) { function isEnabled(): boolean {

return config.get<boolean>('math.enabled', true); } <ins> function getMacros(): { [key: string]: string } { const config = vscode.workspace.getConfiguration('markdown'); return config.get<{ [key: string]: string }>('math.macros', {}); } </ins> vscode.workspace.onDidChangeConfiguration(e => { <del> if (e.affectsConfiguration(enabledSetting)) { </del> <ins> if (e.affectsConfiguration(markdownMathSetting)) { </ins> vscode.commands.executeCommand('markdown.api.reloadPlugins'); } }, undefined, context.subscriptions);

extendMarkdownIt(md: any) { if (isEnabled()) { const katex = require('@vscode/markdown-it-katex'); <del> const options = { globalGroup: true, macros: {} }; md.core.ruler.push('reset-katex-macros', () => { options.macros = {}; }); </del> <ins> const settingsMacros = getMacros(); const options = { globalGroup: true, macros: { ...settingsMacros } }; md.core.ruler.push('reset-katex-macros', () => { options.macros = { ...settingsMacros }; }); </ins> return md.use(katex, options); } return md;
Change:
VS Code Version: 1.78 Insiders OS Version: Windows 11 Steps to Reproduce: at the Create Profiles drop down. ! "Create" and "Profile" shown 10 times. Suggestion to remove most instances of "Create" and "Profile". Maybe:
I like this suggestion. what do you think?
<img width="630" alt="image" src="https://user-"Do you think word is a repetition? Is this good or shall I add word to template entries too?
Looks good! I think that is just the right number of "Profile" words since "Empty Profile", "Current Profile", and "Profile Template" are "things" we talk about elsewhere. The profile template list looks clear to me
I also like this! Great improvement.

Discussion:
const userDataProfileImportExportService = accessor.get(IUserDataProfileImportExportService); const quickPickItems: QuickPickItem[] = [{ id: CREATE_EMPTY_PROFILE_ACTION_ID, <del> label: CREATE_EMPTY_PROFILE_ACTION_TITLE.value, </del> <ins> label: localize('empty', "Empty Profile"), </ins> }, { id: CREATE_FROM_CURRENT_PROFILE_ACTION_ID, <del> label: CREATE_FROM_CURRENT_PROFILE_ACTION_TITLE.value, </del> <ins> label: localize('using current', "Using Current Profile"), </ins> }]; const profileTemplateQuickPickItems = await that.getProfileTemplatesQuickPickItems(); if (profileTemplateQuickPickItems.length) {

{ hideInput: true, canPickMany: false, <del> title: localize('create profile title', "{0}: Create...", PROFILES_CATEGORY.value) </del> <ins> title: localize('create profile title', "Create Profile...") </ins> }); if (pick) { if (pick.id) {

{ hideInput: true, canPickMany: false, <del> title: localize('create profile title', "{0}: Create...", PROFILES_CATEGORY.value) </del> <ins> title: localize('create profile from template title', "{0}: Create...", PROFILES_CATEGORY.value) </ins> }); if ((<IProfileTemplateQuickPickItem>pick)?.url) { const uri = URI.parse((<IProfileTemplateQuickPickItem>pick).url);

const profileTemplates = await this.getProfileTemplatesFromProduct(); for (const template of profileTemplates) { quickPickItems.push({ <del> label: localize('create from template', "Create {0} Profile...", template.name), </del> <ins> label: template.name, </ins> ...template }); }
Change:
an active debug session a bookmark to one line a breakpoint to the same line where the breakpoint ends up being an inline breakpoint :bug: the margin resizes so that the bookmark on the line in step 2 is also gone Debugging this in devtools, this appears to be because the breakpoint does not appear in the result of . Therefore it's not taken into account when calculating the size of the margin. When we actually go to render the decorations, we use a different source of information , where the breakpoint does show up, so we end up rendering it even though no lane space was allocated for it. ! Those inline breakpoints appear by using injected text: I think the problem is that the fast path for getting just margin decorations doesn't search the injected text interval tree for margin decorations (because I didn't realize that margin decorations could appear in the injected text interval tree when implementing ). Only caught this now because inline breakpoints only show up when there are active debug sessions, and I didn't have a case where I set a breakpoint on a line with another decoration in a debug session till today :/

Discussion:
private _search(filterOwnerId: number, filterOutValidation: boolean, overviewRulerOnly: boolean, cachedVersionId: number, onlyMarginDecorations: boolean): IntervalNode[] { if (overviewRulerOnly) { return this._decorationsTree1.search(filterOwnerId, filterOutValidation, cachedVersionId, onlyMarginDecorations); <del> } else if (onlyMarginDecorations) { const r0 = this._decorationsTree0.search(filterOwnerId, filterOutValidation, cachedVersionId, onlyMarginDecorations); const r1 = this._decorationsTree1.search(filterOwnerId, filterOutValidation, cachedVersionId, onlyMarginDecorations); return r0.concat(r1); </del> } else { const r0 = this._decorationsTree0.search(filterOwnerId, filterOutValidation, cachedVersionId, onlyMarginDecorations); const r1 = this._decorationsTree1.search(filterOwnerId, filterOutValidation, cachedVersionId, onlyMarginDecorations);
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Actions like current only accepts options in . Allowing setting other options from like allows extensions directly open json setting editor with specific setting keys (when the extension is asking user to edit some custon json settings)
Leaving this to you for the action to be taken.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!

Discussion:
import { KeyChord, KeyCode, KeyMod } from 'vs/base/common/keyCodes'; import { Disposable, DisposableStore, MutableDisposable } from 'vs/base/common/lifecycle'; import { Schemas } from 'vs/base/common/network'; <del> import { isObject } from 'vs/base/common/types'; </del> <ins> import { isBoolean, isObject, isString } from 'vs/base/common/types'; </ins> import { URI } from 'vs/base/common/uri'; import 'vs/css!./media/preferences'; import { EditorContributionInstantiation, registerEditorContribution } from 'vs/editor/browser/editorExtensions';

interface IOpenSettingsActionOptions { openToSide?: boolean; query?: string; <ins> revealSetting?: { key: string; edit?: boolean; }; focusSearch?: boolean; } function sanitizeBoolean(arg: any): boolean | undefined { return isBoolean(arg) ? arg : undefined; } function sanitizeString(arg: any): string | undefined { return isString(arg) ? arg : undefined; </ins> } function sanitizeOpenSettingsArgs(args: any): IOpenSettingsActionOptions {

args = {}; } <del> return { openToSide: args.openToSide, query: args.query </del> <ins> let sanitizedObject: IOpenSettingsActionOptions = { focusSearch: sanitizeBoolean(args?.focusSearch), openToSide: sanitizeBoolean(args?.openToSide), query: sanitizeString(args?.query) </ins> }; <ins> if (isString(args?.revealSetting?.key)) { sanitizedObject = { ...sanitizedObject, revealSetting: { key: args.revealSetting.key, edit: sanitizeBoolean(args.revealSetting?.edit) } }; } return sanitizedObject; </ins> } class PreferencesActionsContribution extends Disposable implements IWorkbenchContribution {
Change:
an error notification it Error icon goes grey. https://user-
Could this be fallback from list color changes? cc
Similar to

Discussion:
/* Icons */ .monaco-workbench > .notifications-center .codicon.codicon-error { <del> color: var(--vscode-notificationsErrorIcon-foreground); </del> <ins> color: var(--vscode-notificationsErrorIcon-foreground) !important; </ins> } .monaco-workbench > .notifications-center .codicon.codicon-warning { <del> color: var(--vscode-notificationsWarningIcon-foreground); </del> <ins> color: var(--vscode-notificationsWarningIcon-foreground) !important; </ins> } .monaco-workbench > .notifications-center .codicon.codicon-info { <del> color: var(--vscode-notificationsInfoIcon-foreground); </del> <ins> color: var(--vscode-notificationsInfoIcon-foreground) !important; </ins> }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --I get this sticky scroll exception (note how one of the callers is ): I don't have a better repro steps, sorry. But I have seen this error in other contexts as well, just don't have exact steps. With an editor open, switch between panel views fast. Here's the gif of me doing this https://user-
Thanks for filing the issue, I'll look into it, when I have time.

Discussion:
public abstract get provider(): LanguageFeatureRegistry<object> | null; public computeStickyModel(textModel: ITextModel, modelVersionId: number, token: CancellationToken): { statusPromise: Promise<Status> | Status; modelPromise: CancelablePromise<T | null> | null } { <del> if (!this.isProviderValid(textModel)) { </del> <ins> if (token.isCancellationRequested || !this.isProviderValid(textModel)) { </ins> return { statusPromise: this._invalid(), modelPromise: null }; } const providerModelPromise = createCancelablePromise(token => this.createModelFromProvider(textModel, modelVersionId, token));