jiebi/CodeConvo huggingface dataset:
Change:
Type: Bug Version: 1.81.0 Commit: Date: 2023-08-02T12:36:11.334Z Electron: 22.3.18 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Linux x64 5.15.0-76-generic Steps to Reproduce: the "Test Results" Panel command "Test: Run Tests in Current File" very quickly for several times "Test Results" Panel now displays two terminals, with the top one acting like phantom, and the bottom one displaying the real messages. After some investigation, I found the culprit to be that is not concurrently safe. Under certain cases, multiple calls to may happen concurrently within a short time period, which further leads to concurrent calls to , in which multiple instances of terminal are created and attached to the panel. This bug was largely improved by commit introduced by , which changed into This change reduces the possibility of concurrently calling to some extent and thus this bug may be harder to reproduce in the latest main branch. That being said, there's still a chance for this to happen. To thoroughly eliminate the risk, I fix it in PR .

Discussion:
import { ICompressibleTreeRenderer } from 'vs/base/browser/ui/tree/objectTree'; import { ITreeContextMenuEvent, ITreeNode } from 'vs/base/browser/ui/tree/tree'; import { Action, IAction, Separator } from 'vs/base/common/actions'; <del> import { Delayer, RunOnceScheduler } from 'vs/base/common/async'; </del> <ins> import { Delayer, Limiter, RunOnceScheduler } from 'vs/base/common/async'; </ins> import { Codicon } from 'vs/base/common/codicons'; import { Color } from 'vs/base/common/color'; import { Emitter, Event } from 'vs/base/common/event';

private dimension?: dom.Dimension; private splitView!: SplitView; private contentProviders!: IPeekOutputRenderer[]; <ins> private contentProvidersUpdateLimiter = this._register(new Limiter(1)); </ins> public current?: InspectSubject;

if (!this.current || !equalsSubject(this.current, opts.subject)) { this.current = opts.subject; <del> await Promise.all(this.contentProviders.map(p => p.update(opts.subject))); </del> <ins> await this.contentProvidersUpdateLimiter.queue(() => Promise.all( this.contentProviders.map(p => p.update(opts.subject)))); </ins> } }
Change:
Type: <bBug</bTerminal buffer does not have aria label and currently being read as "Editor content edit" to screen readers. Please add aria-label, such as "terminal buffer." VS Code version: Code - Insiders 1.82.0-insider (, 2023-08-04T05:35:09.023Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (91)</summaryExtensionVersion ------ android-dev-ext1.3.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.116 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 dscodegpt2.1.15 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.20.0 gitlens14.2.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.14.14 copilot1.100.313 copilot-chat0.7. remotehub0.60.0 vscode-github-actions0.26.1 vscode-pull-request-github0.70.0 easy-snippet0.6.3 path-autocomplete1.24.1 latex-workshop9.13.4 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.14.0 vscode-pylance2023.8.10 jupyter2023.7. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.305.0 remote-ssh0.102.0 remote-ssh-edit0.86.0 remote-wsl0.81.0 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.14.34 cpptools1.16.3 cpptools-extension-pack1.3.0 js-debug-nightly2023.8.417 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.15 vscode-serial-monitor0.10.0 vsliveshare1.0.5877 resourcemonitor1.0.7 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.2 shinyuieditor0.4.3 quarto1.91.0 r-debugger0.5.4 java1.21.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.6.26 latex-utilities0.4.10 chatgpt1.1.2 cmake0.0.17 errorlens3.12.0 intellicode-api-usage-examples0.2.7 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.53.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.13 vscode-java-test0.39.1 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --

Discussion:
import type { Terminal } from 'xterm'; import { IContextKey, IContextKeyService, RawContextKey } from 'vs/platform/contextkey/common/contextkey'; import { CodeActionController } from 'vs/editor/contrib/codeAction/browser/codeActionController'; <ins> import { localize } from 'vs/nls'; </ins> const enum ClassName { Active = 'active',

quickSuggestions: false, renderWhitespace: 'none', dropIntoEditor: { enabled: true }, <del> readOnly: true </del> <ins> readOnly: true, ariaLabel: localize('terminalAccessibleBuffer', "Terminal Buffer") </ins> }; this._editorWidget = this.add(this._instantiationService.createInstance(CodeEditorWidget, this._editorContainer, editorOptions, codeEditorWidgetOptions)); this._element.replaceChildren(this._editorContainer);
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.81.0 (user setup) Commit: Date: 2023-08-02T12:37:13.485Z Electron: 22.3.18 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: a .cpp file (or a .c file). Don't have the C/C++ Extension Pack installed. Bug: The extension recommendation popup uses text "for C++ language", which isn't grammatically correct. It's possible the same issue repros for other languages. I wasn't able to locate the source of the text (maybe it's from a private repo). ! Potential fix 1: It should use "for the C++ language" to be grammatically correct. Potential fix 2: Well, to be even more accurate, for the C/C++ extension pack, it should say "for the C and C++ languages". Potential fix 3: Or, if it can say "for the C++ language" when triggered from a "cpp" language file and a "for the C language" when triggered from a "c" language file.
can I work on this issue?
Are you able to locate where that text is coming from?
been searching the text source for some time but not able to find it. Did you find anything?
No, but I don't work on VS Code (just an extension) -- I assume someone who works on VS Code would know how to find it.
I was just searching some beginner friendly issue to solve to start my open source journey.

Discussion:
const language = model.getLanguageId(); const languageName = this.languageService.getLanguageName(language); if (importantRecommendations.size && <del> this.promptRecommendedExtensionForFileType(languageName && isImportantRecommendationForLanguage && language !== PLAINTEXT_LANGUAGE_ID ? localize('languageName', "{0} language", languageName) : basename(uri), language, [...importantRecommendations])) { </del> <ins> this.promptRecommendedExtensionForFileType(languageName && isImportantRecommendationForLanguage && language !== PLAINTEXT_LANGUAGE_ID ? localize('languageName', "the {0} language", languageName) : basename(uri), language, [...importantRecommendations])) { </ins> return; } }
Change:
Currently, one can have a task that runs on folder open (startup), but if window is reloaded, they get a notification "The task '<myTask' is already active." with options to terminate or restart the task. It would be great to have an option to never see this notification either as a button or within gear-icon context menu on the notification.
Yeah this is happening because of automatic tasks / reconnected tasks each trying to start the same one. We should ignore the request if it's coming from one or the other source (reconnection or automatic) and the task is already running
Workaround for now is to remove the folderOpen property or disable reconnection
I do not see my task getting run either on first open or window reload
found that this does not work in old Codespaces, which we are tracking here .

Discussion:
private _onDidChangeTaskSystemInfo: Emitter<void> = new Emitter(); private _willRestart: boolean = false; public onDidChangeTaskSystemInfo: Event<void> = this._onDidChangeTaskSystemInfo.event; <ins> private _onDidReconnectToTasks: Emitter<void> = new Emitter(); public onDidReconnectToTasks: Event<void> = this._onDidReconnectToTasks.event; </ins> constructor( @IConfigurationService private readonly _configurationService: IConfigurationService,

} this.getWorkspaceTasks(TaskRunSource.Reconnect).then(async () => { this._tasksReconnected = await this._reconnectTasks(); <ins> this._onDidReconnectToTasks.fire(); </ins> }); }

} if (executeResult.kind === TaskExecuteKind.Active) { const active = executeResult.active; <ins> if (active && active.same && runSource === TaskRunSource.FolderOpen) { // ignore, the task is already active, likely from being reconnected. this._logService.debug('Ignoring task that is already active', executeResult.task); return executeResult.promise; } </ins> if (active && active.same) { if (this._taskSystem?.isTaskVisible(executeResult.task)) { const message = nls.localize('TaskSystem.activeSame.noBackground', 'The task '{0}' is already active.', executeResult.task.getQualifiedLabel());

@IWorkspaceTrustManagementService private readonly _workspaceTrustManagementService: IWorkspaceTrustManagementService, @ILogService private readonly _logService: ILogService) { super(); <del> if (this._workspaceTrustManagementService.isWorkspaceTrusted()) { this._tryRunTasks(); } </del> <ins> this._taskService.onDidReconnectToTasks((() => { if (this._workspaceTrustManagementService.isWorkspaceTrusted()) { this._tryRunTasks(); } })); </ins> this._register(this._workspaceTrustManagementService.onDidChangeTrust(async trusted => { if (trusted) { await this._tryRunTasks();

export interface ITaskService { readonly _serviceBrand: undefined; onDidStateChange: Event<ITaskEvent>; <ins> onDidReconnectToTasks: Event<void>; </ins> supportsMultipleTaskExecutions: boolean; configureAction(): Action;
Change:
When enabling the feature "Apply Extensions to all Profiles" for extensions with dependencies, these extensions produce an error and get uninstalled from all profiles when a new profile is imported. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Bug is also present on latest Insiders build. Does this issue occur when all extensions are disabled?: Problem involves extensions. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.81.0 OS Version: Windows 11 Pro 22H2 Steps to Reproduce: any extension with a dependency, e.g. . This will install as well. "Apply Extension to all Profiles" for both extensions any profile, e.g. the Python profile the error: ! extension get's removed from all profiles, even the default profile!
Logs: <details<summaryShared</summary<p</p</details<details<summaryWindow</summary<p</p</details
/assign
I confirm and can reproduce. Example steps: start with no profiles install isort, Pylance and Python for each one of them, choose "Apply Extension to all Profiles" Import a builtin profile, like nodejs extensions get uninstalled and an error message is shown. This might share the same root cause as and could also be caused by . That commit already caused a candidate at
I have slightly simplified steps with no profiles isort isort, choose "Apply Extension to All Profiles" a builtin profile like nodejs get uninstalled I also see settings sync log errors which may be related, including for posterity <details</details
Reopening to consider as a candidate.
this should be fixed in the latest insiders build, can you please try it out there and let us know if it still repros for you or if you see other extension bugs?
Verified in insiders.
The bug seems to be fixed. Thank you very much!

Discussion:
extensionsToEnableOrDisable.push({ extension: e.identifier, enable: !e.disabled }); } } <del> const extensionsToUninstall: ILocalExtension[] = installedExtensions.filter(extension => !extension.isBuiltin && !profileExtensions.some(({ identifier }) => areSameExtensions(identifier, extension.identifier))); </del> <ins> const extensionsToUninstall: ILocalExtension[] = installedExtensions.filter(extension => !extension.isBuiltin && !profileExtensions.some(({ identifier }) => areSameExtensions(identifier, extension.identifier)) && !extension.isApplicationScoped); </ins> for (const { extension, enable } of extensionsToEnableOrDisable) { if (enable) { this.logService.trace(`Importing Profile (${profile.name}): Enabling extension...`, extension.id);
Change:
This issue appears to occur under the following conditions: two files that render sticky lines in one file to the right so that sticky scroll is sideways scrolled (you may need to enable the sideways scrolling setting on sticky scroll) the second file, observe that the sticky lines are not there

Discussion:
this._updateWidgetWidth(); } })); <ins> this._register(this._editor.onDidChangeModel(() => updateScrollLeftPosition())); </ins> updateScrollLeftPosition(); this._register(this._editor.onDidLayoutChange((e) => {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Type: Bug Missing pricing parameter in extension manifest. The attribute is not included in the and so does not show up in IntelliSense. Related docs issue: I'm working on the fix. FYI: <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --

Discussion:
'{Locked="vscode.l10n API"}' ] }, 'The relative path to a folder containing localization (bundle.l10n.*.json) files. Must be specified if you are using the vscode.l10n API.') <ins> }, pricing: { type: 'string', markdownDescription: nls.localize('vscode.extension.pricing', 'The pricing information for the extension. Can be Free (default) or Trial. For more details visit: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#extension-pricing-label'), enum: ['Free', 'Trial'], default: 'Free' </ins> } } };
Change:
The : This doesn't currently work in VSCode. It does support a very wide range of formats and I don't recall ever seeing this format before (even from GNU tools) so I suspect nobody else uses it. Nonetheless it's easy to add support in VSCode. See
Doesn't seem to work, see <img width="825" alt="Screenshot 2023-08-29 at 14 41 05" src=""
The PR intentionally left that out: But it should be easy to add so will leave this open.

Discussion:
const lineAndColumnRegexClauses = [ // foo:339 // foo:339:12 <ins> // foo:339.12 </ins> // foo 339 // foo 339:12                             [#140780] <ins> // foo 339.12 </ins> // "foo",339 // "foo",339:12 <del> `(?::| |['"],)${r()}(:${c()})?` + eolSuffix, </del> <ins> // "foo",339.12 `(?::| |['"],)${r()}([:.]${c()})?` + eolSuffix, </ins> // The quotes below are optional          [#171652] // "foo", line 339                        [#40468] // "foo", line 339, col 12

{ link: 'foo', prefix: undefined, suffix: undefined, hasRow: false, hasCol: false }, { link: 'foo:339', prefix: undefined, suffix: ':339', hasRow: true, hasCol: false }, { link: 'foo:339:12', prefix: undefined, suffix: ':339:12', hasRow: true, hasCol: true }, <ins> { link: 'foo:339.12', prefix: undefined, suffix: ':339.12', hasRow: true, hasCol: true }, </ins> { link: 'foo 339', prefix: undefined, suffix: ' 339', hasRow: true, hasCol: false }, { link: 'foo 339:12', prefix: undefined, suffix: ' 339:12', hasRow: true, hasCol: true }, <ins> { link: 'foo 339.12', prefix: undefined, suffix: ' 339.12', hasRow: true, hasCol: true }, </ins> // Double quotes { link: '"foo",339', prefix: '"', suffix: '",339', hasRow: true, hasCol: false }, { link: '"foo",339:12', prefix: '"', suffix: '",339:12', hasRow: true, hasCol: true }, <ins> { link: '"foo",339.12', prefix: '"', suffix: '",339.12', hasRow: true, hasCol: true }, </ins> { link: '"foo", line 339', prefix: '"', suffix: '", line 339', hasRow: true, hasCol: false }, { link: '"foo", line 339, col 12', prefix: '"', suffix: '", line 339, col 12', hasRow: true, hasCol: true }, { link: '"foo", line 339, column 12', prefix: '"', suffix: '", line 339, column 12', hasRow: true, hasCol: true },

// Single quotes { link: ''foo',339', prefix: ''', suffix: '',339', hasRow: true, hasCol: false }, { link: ''foo',339:12', prefix: ''', suffix: '',339:12', hasRow: true, hasCol: true }, <ins> { link: ''foo',339.12', prefix: ''', suffix: '',339.12', hasRow: true, hasCol: true }, </ins> { link: ''foo', line 339', prefix: ''', suffix: '', line 339', hasRow: true, hasCol: false }, { link: ''foo', line 339, col 12', prefix: ''', suffix: '', line 339, col 12', hasRow: true, hasCol: true }, { link: ''foo', line 339, column 12', prefix: ''', suffix: '', line 339, column 12', hasRow: true, hasCol: true },
Change:
The : This doesn't currently work in VSCode. It does support a very wide range of formats and I don't recall ever seeing this format before (even from GNU tools) so I suspect nobody else uses it. Nonetheless it's easy to add support in VSCode. See
Doesn't seem to work, see <img width="825" alt="Screenshot 2023-08-29 at 14 41 05" src=""
The PR intentionally left that out: But it should be easy to add so will leave this open.

Discussion:
// The comments in the regex below use real strings/numbers for better readability, here's // the legend: <del> // - Path = foo // - Row  = 339 // - Col  = 12 </del> <ins> // - Path    = foo // - Row     = 339 // - Col     = 12 // - RowEnd  = 341 // - ColEnd  = 14 </ins> // // These all support single quote ' in the place of " and [] in the place of () const lineAndColumnRegexClauses = [

// "foo",339 // "foo",339:12 // "foo",339.12 <del> `(?::| |['"],)${r()}([:.]${c()})?` + eolSuffix, </del> <ins> // "foo",339.12-14 // "foo",339.12-341.14 `(?::| |['"],)${r()}([:.]${c()}(?:-(?:${re()}.)?${ce()})?)?` + eolSuffix, </ins> // The quotes below are optional          [#171652] // "foo", line 339                        [#40468] // "foo", line 339, col 12

{ link: 'foo 339', prefix: undefined, suffix: ' 339', hasRow: true, hasCol: false }, { link: 'foo 339:12', prefix: undefined, suffix: ' 339:12', hasRow: true, hasCol: true }, { link: 'foo 339.12', prefix: undefined, suffix: ' 339.12', hasRow: true, hasCol: true }, <ins> { link: 'foo 339.12-14', prefix: undefined, suffix: ' 339.12-14', hasRow: true, hasCol: true, hasRowEnd: false, hasColEnd: true }, { link: 'foo 339.12-341.14', prefix: undefined, suffix: ' 339.12-341.14', hasRow: true, hasCol: true, hasRowEnd: true, hasColEnd: true }, </ins> // Double quotes { link: '"foo",339', prefix: '"', suffix: '",339', hasRow: true, hasCol: false },
Change:
This is a regression due to the work done on making sticky scroll sideways scrollable
Hi, what are some verification steps for this issue?
Hi ! Apologies for the lack of steps. So previously when you would sideways scroll, jump from file to file, this would cause the sticky widget to not have lines. It would be blank. So some verifications steps are: sticky scroll with several files which create sticky lines sideways in these files using the editor horizontal scrollbar. You may have to enable from file to file that the sticky lines are rendered correctly

Discussion:
this._updateWidgetWidth(); } })); <del> this._register(this._editor.onDidChangeModel(() => updateScrollLeftPosition())); </del> <ins> this._register(this._editor.onDidChangeModel(() => { updateScrollLeftPosition(); this._updateWidgetWidth(); })); </ins> updateScrollLeftPosition(); this._register(this._editor.onDidLayoutChange((e) => {
Change:
In stable: In today's insiders: is too small for its contents second resize, I can't extend the hover to the right enough to fit the content, so I have to also resize up , note how resizing is difficult because hover disappears too easily
I put the important label because hover became very hard to use. Feel free to remove it

Discussion:
width = dom.getTotalWidth(containerDomNode); this._contentWidth = width; this._updateMinimumWidth(); <del> this._updateResizableNodeMaxDimensions(); </del> this._resizableNode.layout(height, width); if (this._hasHorizontalScrollbar()) {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: Relatively niche but: refactor menu (action widget) over a disabled action either arrow keys or typing filter to select an item. that the disabled action becomes highlighted !

Discussion:
.action-widget .monaco-list-row.action.option-disabled, .action-widget .monaco-list:focus .monaco-list-row.focused.action.option-disabled, <del> .action-widget .monaco-list-row.action.option-disabled .codicon { </del> <ins> .action-widget .monaco-list-row.action.option-disabled .codicon, .action-widget .monaco-list:not(.drop-target):not(.dragging) .monaco-list-row:hover:not(.selected):not(.focused).option-disabled { </ins> color: var(--vscode-disabledForeground); }