jiebi/CodeConvo huggingface dataset:
Change:
Started in first 1.72 insider build !
It's related to not being and going this route: Probably more fallout from the change in and
View visibility changes before the backend is registered:

Discussion:
isProcessSupportRegistered: boolean; readonly connectionState: TerminalConnectionState; readonly defaultLocation: TerminalLocation; <ins> readonly primaryBackendRegistered: Promise<void>; </ins> initializeTerminals(): Promise<void>; onDidChangeActiveGroup: Event<ITerminalGroup | undefined>;

*--------------------------------------------------------------------------------------------*/ import * as dom from 'vs/base/browser/dom'; <del> import { timeout } from 'vs/base/common/async'; </del> <ins> import { Barrier, timeout } from 'vs/base/common/async'; </ins> import { debounce } from 'vs/base/common/decorators'; import { Emitter, Event } from 'vs/base/common/event'; import { dispose, IDisposable, toDisposable } from 'vs/base/common/lifecycle';

return this._terminalGroupService.instances.concat(this._terminalEditorService.instances); } <ins> private _primaryBackendRegistered: Barrier = new Barrier(); get primaryBackendRegistered(): Promise<void> { return this._primaryBackendRegistered.wait().then(() => { }); } </ins> private _reconnectedTerminals: Map<string, ITerminalInstance[]> = new Map(); getReconnectedTerminals(reconnectionOwner: string): ITerminalInstance[] | undefined {

this._connectionState = TerminalConnectionState.Connected; } <ins> // Open the primary backend registered barrier to allow ITerminalService consumers to // start using the backend this._primaryBackendRegistered.open(); </ins> backend.onDidRequestDetach(async (e) => { const instanceToDetach = this.getInstanceFromResource(getTerminalUri(e.workspaceId, e.instanceId)); if (instanceToDetach) {

} })); <del> this._register(this.onDidChangeBodyVisibility(visible => { </del> <ins> this._register(this.onDidChangeBodyVisibility(async visible => { </ins> this._viewShowing.set(visible); if (visible) { const hadTerminals = !!this._terminalGroupService.groups.length; <ins> // Ensure the primary backend is registered as it's important to do before // initializeTerminals is called. await this._terminalService.primaryBackendRegistered; </ins> if (this._terminalService.isProcessSupportRegistered) { if (this._terminalsInitialized) { if (!hadTerminals) {
Change:
<!-- Do Not Delete This! bugreporttemplate --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.72.0-insiders OS Version: mac latest Steps to Reproduce: completion provider like so and then execute command to call it: Execute code above. output log of : However Some devs can rely on that type explicitly by doing checks like . So, there should be no way to get To sum up things:
Good test. Thank you so much!
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified

Discussion:
}; const resolving: Promise<any>[] = []; <del> const completions = await provideSuggestionItems(completionProvider, ref.object.textEditorModel, Position.lift(position), undefined, { triggerCharacter, triggerKind: triggerCharacter ? languages.CompletionTriggerKind.TriggerCharacter : languages.CompletionTriggerKind.Invoke }); </del> <ins> const completions = await provideSuggestionItems(completionProvider, ref.object.textEditorModel, Position.lift(position), undefined, { triggerCharacter: triggerCharacter ?? undefined, triggerKind: triggerCharacter ? languages.CompletionTriggerKind.TriggerCharacter : languages.CompletionTriggerKind.Invoke }); </ins> for (const item of completions.items) { if (resolving.length < (maxItemsToResolve ?? 0)) { resolving.push(item.resolve(CancellationToken.None));

// --- suggest <ins> test('triggerCharacter is null when completion provider is called programmatically #159914', async function () { let actualContext: vscode.CompletionContext | undefined; disposables.push(extHost.registerCompletionItemProvider(nullExtensionDescription, defaultSelector, <vscode.CompletionItemProvider>{ provideCompletionItems(_doc, _pos, _tok, context): any { actualContext = context; return []; } }, [])); await rpcProtocol.sync(); await commands.executeCommand<vscode.CompletionList>('vscode.executeCompletionItemProvider', model.uri, new types.Position(0, 4)); assert.ok(actualContext); assert.deepStrictEqual(actualContext, { triggerKind: types.CompletionTriggerKind.Invoke, triggerCharacter: undefined }); }); </ins> test('Suggest, back and forth', function () { disposables.push(extHost.registerCompletionItemProvider(nullExtensionDescription, defaultSelector, <vscode.CompletionItemProvider>{ provideCompletionItems(): any {
Change:
See comments in Workaround for anyone hitting this is to set to one of , , in your .
See earlier report on
/duplicate

Discussion:
builtin printf "x1b]633;P;IsWindows=Truex07" fi <ins> # Allow verifying $BASH_COMMAND doesn't have aliases resolved via history when the right HISTCONTROL # configuration is used if [[ "$HISTCONTROL" =~ .*(erasedups|ignoreboth|ignoredups).* ]]; then __vsc_history_verify=0 else __vsc_history_verify=1 fi </ins> __vsc_initialized=0 __vsc_original_PS1="$PS1" __vsc_original_PS2="$PS2"

__vsc_preexec() { __vsc_initialized=1 if [[ ! "$BASH_COMMAND" =~ ^__vsc_prompt* ]]; then <del> __vsc_current_command=$BASH_COMMAND </del> <ins> # Use history if it's available to verify the command as BASH_COMMAND comes in with aliases # resolved if [ "$__vsc_history_verify" = "1" ]; then __vsc_current_command="$(builtin history 1 | sed -r 's/ *[0-9]+ +//')" else __vsc_current_command=$BASH_COMMAND fi </ins> else __vsc_current_command="" fi
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Setting up the problem scenario: At this stage, there are two branches. One has changes committed, one has changes to the working directory that can be discarded, stashed, or committed. If you try to use the VSCode interface to simply switch to newbranch, you get a popup alerting you that local changes would be overwritten by checkout. It gives the options "Stash & Checkout", "Cancel", and "Force Checkout". The Cancel and Force Checkout buttons work as one would expect, cancelling the process or forcing it to proceed with destructive side effects respectively. The Stash & Checkout button is problematic. Based on the presented information, I would expect a call to followed by a call to . End of process. This would leave me in a very sensible position where I am looking at a clean working tree reflecting new_branch, and a stash on master containing the working tree changes associated with that branch. Instead, VSCode attempts to apply the stash to the current working tree, resulting in conflicts that have to be resolved before anything else can happen. I think either the behavior should be modified to do exactly as described, or the prompts should better reflect what will happen. Perhaps "Migrate Working Tree Edits" would be appropriate. Personally I think changing the behavior is the better solution, as I encounter many more instances of "oh I need to see what was done in that other branch real quick" vs "I'm on the wrong branch and should blindly migrate my edits to a different branch via a stash".
would love to get your thoughts on this one. Thank you!
Yeah that seems wrong. I think we should just remove the pop after checkout behavior.
I have looked into this a bit further and I see that for the action was "Smart Checkout". I do agree that if we were to use "Stash & Checkout" as the label, we should remove the code that pops the most recent stash.
Will this change of behaviour be obvious to someone who previously took advantage of how it used to conclude by popping the stash? Or should suggested "Migrate Working Tree Edits" button be to the dialog?
Yes, this will a change in behaviour, though I would prefer not adding a third option to the dialog. thoughts?
Up to you
Without an extra button I predict at least one complaint from a person who didn't spot a release notes announcement and doesn't notice that their stashed changes now remain stashed.
I have a button "Migrate Changes". Opted to use the "Changes" terminology to be consistent I have moved the "Force Checkout" button to the end so that it is not not the primary button in the dialog. <img width="274" alt="image" src="https://user-"

Discussion:
} else if (choice === stash) { await this.stash(repository); await item.run(opts); <del> await this.stashPopLatest(repository); </del> } } }
Change:
Type: <bBug</bWith the previous native menu on macOS, Ctrl+N and Ctrl+P could be used to select code actions. This doesn't seem to work with the new custom one. I tried setting / , but that breaks Ctrl+N/P in the Command Palette. VS Code version: Code 1.71.0 (Universal) (, 2022-09-01T07:25:38.437Z) OS version: Darwin arm64 21.6.0 Modes: Sandboxed: No <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Did you add a when-clause to your keybindings?
Is correct for how you can add your own keybindings I'll add them by default too since they also exist for the suggest widget

Discussion:
weight: weight + 100000, primary: KeyCode.UpArrow, secondary: [KeyMod.CtrlCmd | KeyCode.UpArrow], <ins> mac: { primary: KeyCode.UpArrow, secondary: [KeyMod.CtrlCmd | KeyCode.UpArrow, KeyMod.WinCtrl | KeyCode.KeyP] }, </ins> } }));

weight: weight + 100000, primary: KeyCode.DownArrow, secondary: [KeyMod.CtrlCmd | KeyCode.DownArrow], <ins> mac: { primary: KeyCode.DownArrow, secondary: [KeyMod.CtrlCmd | KeyCode.DownArrow, KeyMod.WinCtrl | KeyCode.KeyN] } </ins> } }));

primary: KeyMod.CtrlCmd | KeyCode.Enter, } }));
Change:
<img width="923" alt="image" src="https://user-"
ops

Discussion:
protected _isDisposed: boolean; protected _myContextId: number; <del> protected _onDidChangeContext = new MicrotaskEmitter<IContextKeyChangeEvent>({ merge: input => new CompositeContextKeyChangeEvent(input), _profName: 'onDidChangeContextKey' }); // protected _onDidChangeContext = new PauseableEmitter<IContextKeyChangeEvent>({ merge: input => new CompositeContextKeyChangeEvent(input), _profName: 'onDidChangeContextKey' }); </del> <ins> protected _onDidChangeContext = new MicrotaskEmitter<IContextKeyChangeEvent>({ merge: input => new CompositeContextKeyChangeEvent(input) }); </ins> readonly onDidChangeContext = this._onDidChangeContext.event; constructor(myContextId: number) {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: I was also able to reproduce the issue in the latest Insiders build as of 6 Sept 2022 OS Version: RHEL 8.6, kernel 4.18.0, using Gnome 3 with X11 Steps to Reproduce: a folder with a VS Code debug configuration (I used redhat-developer/vscode-xml) Ctrl+Shift+D to focus the "Start Debugging" button Enter debug task is launched twice In my case, I have a warning "no problem matchers defined" that I manually select "launch anyways" for. I know the debug task is being launched twice since the warning appears twice, and two instances of the I've defined are started in the terminal.
This should be reproducible on Windows as well
Quick analysis - seems like the debug service status checks in are supposed to prevent this, but the keydown handlers must happen in a different order now. do you know why the Enter handler in is needed since the ActionBar handles enter? It all seems to work for me if I just delete that block
maybe in the past ActionBar did not handle enter for . If it seems to work fine if we delete it then I suggest we just remove that code :) Thanks

Discussion:
this.toDispose.push(dom.addDisposableListener(this.start, dom.EventType.KEY_DOWN, (e: KeyboardEvent) => { const event = new StandardKeyboardEvent(e); <del> if (event.equals(KeyCode.Enter) && this.debugService.state !== State.Initializing) { this.actionRunner.run(this.action, this.context); } </del> if (event.equals(KeyCode.RightArrow)) { this.start.tabIndex = -1; this.selectBox.focus();
Change:
Honestly you might want to avoid touching a notebook (or maybe any webview editor) in an integration test. We have had a lot of issues with webviews in integration tests and don't run notebook tests in the web. Test that with a unit test if possible
It's hard to easily test this with unit tests because there are a lot of editor setup and other stuff that goes on to ensure the end to end tab model is correct. I can remove the notebook piece but then I worry if notebooks or any other non-text type could regress and we wouldn't know
You could also just skip the test in web
Again, in web
Also in web for
/closedWith

Discussion:
import * as assert from 'assert'; import { join } from 'path'; <del> import { CancellationTokenSource, commands, MarkdownString, TabInputNotebook, Position, QuickPickItem, Selection, StatusBarAlignment, TextEditor, TextEditorSelectionChangeKind, TextEditorViewColumnChangeEvent, TabInputText, Uri, ViewColumn, window, workspace, TabInputTextDiff } from 'vscode'; </del> <ins> import { CancellationTokenSource, commands, MarkdownString, TabInputNotebook, Position, QuickPickItem, Selection, StatusBarAlignment, TextEditor, TextEditorSelectionChangeKind, TextEditorViewColumnChangeEvent, TabInputText, Uri, ViewColumn, window, workspace, TabInputTextDiff, UIKind, env } from 'vscode'; </ins> import { assertNoRpc, closeAllEditors, createRandomFile, pathEquals } from '../utils';

assert.strictEqual(tabs[3].input.uri.toString(), commandFile.toString()); }); <del> test('Tabs - Ensure tabs getter is correct', async function () { </del> <ins> (env.uiKind === UIKind.Web ? test.skip : test)('Tabs - Ensure tabs getter is correct', async function () { </ins> // Reduce test timeout as this test should be quick, so even with 3 retries it will be under 60s. this.timeout(10000); // This test can be flaky because of opening a notebook
Change:
Ref Thinking about various ways to reduce clutter and noise. Not sure if there's any reason to keep the branch aligned right and the commit to the left. Especially since we're looking at adding more actions via . What if we just combined them with a separator e.g. <img width="1148" alt="CleanShot 2022-09-07 at 15 18 17 src="https://user-"cc
It would also be nice if we could show more information about the commits somehow (maybe a hover or a clickable label). The hash doesn't really help, unless I have a different tool to look it up.
Here's what we explored in earlier design iterations: <img width="542" alt="CleanShot 2022-09-08 at 08 36 49 src="https://user-"

Discussion:
) { super(instantiationService, viewModel); <ins> this.htmlElements.root.classList.add(`input`); </ins> this._register( new EditorGutter(this.editor, this.htmlElements.gutterDiv, { getIntersectingGutterItems: (range, reader) => {

color: var(--vscode-descriptionForeground); } <ins> /* for input1|2 -> align details to the left  */ .monaco-workbench .merge-editor .code-view.input>.title>SPAN.detail::before { content: '•'; opacity: .5; padding-right: 3px; } .monaco-workbench .merge-editor .code-view.input>.title>SPAN.detail { margin-left: 0; } .monaco-workbench .merge-editor .code-view.input>.title>SPAN.toolbar { margin-left: auto; } </ins> .monaco-workbench .merge-editor .code-view>.title>SPAN.detail .codicon { font-size: 13px; }
Change:
A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Aug2022; #WCAG4.1.2; #Name Role Value Visual Studio Code Windows 11 Pro version 21H2 (OS Build .856) 1)Open Visual studio code editor 2)Using "Alt+H" key navigate to the "Help" menu bar option . 3)Using "Down" arrow key navigate to the "Welcome" item. 4) Make sure you have the following setting in "workbench.startupEditor": "gettingStarted" 5)Using "Alt+H" navigate to "Help" menu bar option and use "down" arrow key to navigate to "Getting started" and observe that the correct name is defined for the "cancel" or "hide" button. The Correct name is not defined for the "cancel" or "hide" button. The correct name should be defined for the "cancel" or "hide" button. !
For me the correct title gets read out by VoiceOver or NVDA - it is Hide. can you just make sure to also set the on the element? This is affecting our Accessibility Grade and I think it is a very low hanging fix - thus assigning to November for now.
has planned the accessibility work for the welcome view for the new team member. I'll ask them to verify this fix

Discussion:
'tabindex': 0, 'x-dispatch': 'hideCategory:' + category.id, 'title': localize('close', "Hide"), <ins> 'role': 'button', 'aria-label': localize('closeAriaLabel', "Hide"), </ins> }), ), descriptionContent,
Change:
A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Aug2022; #WCAG4.1.1; #Parsing Visual Studio Code Windows 11 Pro version 21H2 (OS Build .856) 1)Open Visual studio code editor 2)Using "Alt+H" key navigate to the "Help" menu bar option . 3)Using "Down" arrow key navigate to the "Welcome" item. 4) Make sure you have the following setting in "workbench.startupEditor": "gettingStarted" 5)Using "Alt+H" navigate to "Help" menu bar option and use "down" arrow key to navigate to "Getting started" and observe that the Get started with VS Code button has a link inside it or not. Get started with VS Code button has a link inside it. There should not be any link inside the Get started with VS Code button. !
can we make sure that we set the on the x in the welcome view. I believe it is very low hanging and is affecting our grade thus assigning to November. Thanks!

Discussion:
'tabindex': 0, 'x-dispatch': 'hideCategory:' + category.id, 'title': localize('close', "Hide"), <ins> 'role': 'button', 'aria-label': localize('closeAriaLabel', "Hide"), </ins> }), ), descriptionContent,
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.0 () OS Version: macOS 12.5.1 (21G83) Steps to Reproduce: any file on . the filename tab on the "Editor", hold + Click on it (the same as a right-click or two-finger click on macOS). See the image below ! Expected: it opens the context menu with options about the file. Actual: it blinks the context menu for a fraction of a second. A screencast of the problem: ! The problem doesn't happen on VS Code desktop.
I can reproduce, and maybe is an issue that would reproduce on desktop too but we use native menus there and not custom menus.
is this ctrl+click behavior mac specific?
I am not entirely sure, but so far, we have only seen reports about this issue on macOS.
Yes, Macs by default consider CTRL+Click a right click. This works across the entire OS.
This is great, thanks for the fix!

Discussion:
import { withNullAsUndefined } from 'vs/base/common/types'; import { URI } from 'vs/base/common/uri'; import { IUriIdentityService } from 'vs/platform/uriIdentity/common/uriIdentity'; <del> import { isLinux, isNative, isWindows } from 'vs/base/common/platform'; </del> <ins> import { isLinux, isMacintosh, isNative, isWindows } from 'vs/base/common/platform'; </ins> import { ILogService } from 'vs/platform/log/common/log'; import { getProgressBarStyles } from 'vs/platform/theme/browser/defaultStyles';

const handleTitleClickOrTouch = (e: MouseEvent | GestureEvent): void => { let target: HTMLElement; if (e instanceof MouseEvent) { <del> if (e.button !== 0) { return undefined; // only for left mouse click </del> <ins> if (e.button !== 0 || (isMacintosh && e.ctrlKey)) { return undefined; // only for left mouse click (ctrl+click on macos is right-click) </ins> } target = e.target as HTMLElement;