jiebi/CodeConvo huggingface dataset:
Change:
! quick search. over a file name pick item and click the button to open the file. happens :bug:

Discussion:
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { ILabelService } from 'vs/platform/label/common/label'; import { WorkbenchCompressibleObjectTree, getSelectionKeyboardEvent } from 'vs/platform/list/browser/listService'; <del> import { FastAndSlowPicks, IPickerQuickAccessItem, PickerQuickAccessProvider, Picks, TriggerAction } from 'vs/platform/quickinput/browser/pickerQuickAccess'; </del> <ins> import { FastAndSlowPicks, IPickerQuickAccessItem, IPickerQuickAccessSeparator, PickerQuickAccessProvider, Picks, TriggerAction } from 'vs/platform/quickinput/browser/pickerQuickAccess'; </ins> import { DefaultQuickAccessFilterValue, IQuickAccessProviderRunOptions } from 'vs/platform/quickinput/common/quickAccess'; <del> import { IKeyMods, IQuickPick, IQuickPickItem, IQuickPickSeparator, QuickInputHideReason } from 'vs/platform/quickinput/common/quickInput'; </del> <ins> import { IKeyMods, IQuickPick, IQuickPickItem, QuickInputHideReason } from 'vs/platform/quickinput/common/quickInput'; </ins> import { IWorkspaceContextService, IWorkspaceFolder } from 'vs/platform/workspace/common/workspace'; import { IWorkbenchEditorConfiguration } from 'vs/workbench/common/editor'; import { searchDetailsIcon, searchOpenInFileIcon, searchActivityBarIcon } from 'vs/workbench/contrib/search/browser/searchIcons';

} } <del> private _getPicksFromMatches(matches: FileMatch[], limit: number): (IQuickPickSeparator | ITextSearchQuickAccessItem)[] { </del> <ins> private _getPicksFromMatches(matches: FileMatch[], limit: number): (IPickerQuickAccessSeparator | ITextSearchQuickAccessItem)[] { </ins> matches = matches.sort(searchComparer); const files = matches.length > limit ? matches.slice(0, limit) : matches; <del> const picks: Array<ITextSearchQuickAccessItem | IQuickPickSeparator> = []; </del> <ins> const picks: Array<ITextSearchQuickAccessItem | IPickerQuickAccessSeparator> = []; </ins> for (let fileIndex = 0; fileIndex < matches.length; fileIndex++) { if (fileIndex === limit) {

iconClass: ThemeIcon.asClassName(searchOpenInFileIcon), tooltip: localize('QuickSearchOpenInFile', "Open File") }], <ins> trigger: async (): Promise<TriggerAction> => { await this.handleAccept(fileMatch, {}); return TriggerAction.CLOSE_PICKER; }, </ins> }); const results: Match[] = fileMatch.matches() ?? [];
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.88.0-insider OS Version: Darwin arm64 23.2.0 Steps to Reproduce: folder text View as Tree View as Tree ! View as List ! Mysteriously, some of them do show up when run in a project with many folders...
Did not reproduce in
Same for me: Version: 1.88.0-insider (user setup) Commit: Date: 2024-02-29T22:51:22.369Z Electron: 28.2.2 ElectronBuildId: Chromium: 120.0.6099.276 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0.
Also for non-tree view it doesn't show the single result: 3 results shown: ! 1 result isn't shown: !
watching :
There is no way to set aiResultsVisible and it always returns false now. The hasDownstreamNonAIResults called here should also only contain NonAIResults, so it is false and should not be in the if statement, but it is now. Upon deeper investigation, we found that it occurs under the following conditions. It seems that the deepest part of the TREE is not displayed in this way. This is because the folderMatchesIterator is retrieved, but the deepest point is always [] and [].some() =false. You also need to look into fileMatches iterators.
Apologies for the inconvenience, and thanks for finding the fix!

Discussion:
} } <ins> // FolderMatch on a leaf node does not always run the for-loop of folderMatch because it does not have a FolderMatch as a child. // Therefore, FileMatch is also searched to check for the existence of AIResults const fileIterator = this.fileMatchesIterator(); for (const elem of fileIterator) { if (elem.hasDownstreamNonAIResults()) { return true; } } </ins> return false; }
Change:
!
is this in OSS or in insiders?
This was oss
yep, this is a known issue in OSS with the css bundling. it ends up fine in Insiders and stable, but unsure why this has been the case for a while now. same as i believe
They still happen in insiders, just the button width isn't the same for some reason (you could inspect the element in devtools to diff the styles): !

Discussion:
} } <ins> // TODO @justschen: After migration to Aux Window, switch to dedicated css. </ins> private applyStyles(styles: IssueReporterStyles) { const styleTag = document.createElement('style'); const content: string[] = [];

width: auto; padding: 4px 10px; align-self: flex-end; <del> margin-bottom: 10px; </del> <ins> margin-bottom: 1em; </ins> font-size: 13px; }

padding-bottom: 2em; display: flex; flex-direction: column; <del> height: 100%; </del> <ins> min-height: 100%; overflow: visible; </ins> } .description-section {

border-top: 0px !important; } <ins> #issue-reporter .system-info { margin-bottom: 10px; } </ins> input[type="checkbox"] { width: auto;

} .issues-container > .issue > .issue-state { <ins> display: flex; </ins> width: 77px; padding: 3px 6px; margin-right: 5px;

} .issues-container > .issue .label { <ins> padding-top: 2px; </ins> margin-left: 5px; width: 44px; text-overflow: ellipsis; overflow: hidden; } <ins> .issues-container > .issue .issue-icon{ padding-top: 2px; } </ins>
Change:
a status bar contribution with an actionable tooltip, like Rust Analyzer's contribution in a repo with Rust code (like vscode) or Joh's PR pinger over the status bar entry and try to move your mouse to interact with it disappears !
This seems like a recent regression to me because for the window zoom status entry this used to work recently. can you see if its maybe something you changed?
Unless it's explicitly indicated as not hoverable any hover with markdown will allow it. I do notice is set to true in the new workbench hover delegate which is surprising to me, not sure why it wouldn't be using the default which is dynamically selected: has been making a lot of hover changes recently.
please cc me on workbench hover-related PRs so I can track changes going in. It's good you're taking some ownership but I just want to make sure I'm kept up to date
So this is a bug. I noticed it a while ago and just got used to pressing and keeping pressed (using Windows) to be able to click on things inside the hover.
some hovers intentionally cannot be moused over so I'm glad you discovered alt
Initially the new was introduced to have a simple way to replace the native hover. Due to this it made sense to set to make sure the behaviour is similar to the native one. It afterwards turned out that using the was a nice way to clean up some of the existing custom hover code such as the one in the status bar. It makes sense to switch back to the default behaviour for .

Discussion:
...options, ...overrideOptions, persistence: { <del> hideOnHover: true, </del> hideOnKeyDown: true, ...overrideOptions.persistence },

@IInstantiationService instantiationService: IInstantiationService, ) { super(); <del> this._hoverDelegate = this._register(instantiationService.createInstance(WorkbenchHoverDelegate, 'mouse', false, { persistence: undefined /* use default persistence behaviour */ })); </del> <ins> this._hoverDelegate = this._register(instantiationService.createInstance(WorkbenchHoverDelegate, 'mouse', false, {})); </ins> this._register(this.themeService.onDidFileIconThemeChange(() => this.rerender())); this._register(this.themeService.onDidColorThemeChange(() => this.rerender())); this._register(checkboxStateHandler.onDidChangeCheckboxState(items => {
Change:
Type: <bBug</bThank you for all the improvements to walkthroughs in the latest release, however I noticed that the following issue started popping up after the changes to "save" your place in a walkthrough when changing tabs. When you have a walkthrough open: to a different tab in the same editor window back to the walkthrough that the media on the right side of the walkthrough is no longer present steps 1. and 2., note that the media has reappeared. If you repeat steps 1. and 2. once more, the media will dissapear again. This process can be repeated any number of times to "toggle" the media's visibility. Jumping between steps will also cause the media to reappear. Screen recording: VS Code version: Code 1.87.0 (Universal) (, 2024-02-27T23:42:56.944Z) OS version: Darwin arm64 22.6.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (34)</summaryExtensionVersion ------ vscode-markdownlint0.54.0 vscode-eslint2.4.4 gitlens14.8.2 EditorConfig0.16.4 prettier-vscode10.1.0 go0.41.1 vscode-drawio1.6.6 debugpy2024.2.0 isort2023.10.1 python2024.2.1 vscode-pylance2024.2.3 jupyter2024.2.0 jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.348.0 makefile-tools0.8.22 vsliveshare1.0.5918 ansible2.13.148 java1.28.1 vscode-yaml1.14.0 sonarlint-vscode4.3.0 code-spell-checker3.0.1 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-java-debug0.56.2 vscode-java-dependency0.23.5 vscode-java-pack0.25.15 vscode-java-test0.40.1 vscode-maven0.44.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --

Discussion:
private currentMediaComponent: string | undefined = undefined; private currentMediaType: string | undefined = undefined; <del> private async buildMediaComponent(stepId: string) { </del> <ins> private async buildMediaComponent(stepId: string, forceRebuild: boolean = false) { </ins> if (!this.currentWalkthrough) { throw Error('no walkthrough selected'); } const stepToExpand = assertIsDefined(this.currentWalkthrough.steps.find(step => step.id === stepId)); <del> if (this.currentMediaComponent === stepId) { return; } </del> <ins> if (!forceRebuild && this.currentMediaComponent === stepId) { return; } </ins> this.currentMediaComponent = stepId; this.stepDisposables.clear();

stepElement.classList.add('expanded'); stepElement.setAttribute('aria-expanded', 'true'); <del> this.buildMediaComponent(id); </del> <ins> this.buildMediaComponent(id, true); </ins> this.gettingStartedService.progressByEvent('stepSelected:' + id); } else { this.editorInput.selectedStep = undefined;
Change:
Type: <bBug</bSince I've upgraded from Ventura to Sonoma, files must be deleted permanently. They can no longer be moved to trash. I'm seeing the following in the dev console: <img width="498" alt="Screenshot 2024-03-06 at 12 26 09 PM" src=""VS Code version: Code 1.87.0 (, 2024-02-27T23:42:51.279Z) OS version: Darwin arm64 23.3.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (13)</summaryExtensionVersion ------ theme-verdandi2.0.1 markdown-preview-github-styles2.0.3 vscode-eslint2.4.4 gitlens14.8.2 prettier-vscode10.1.0 copilot1.172.0 copilot-chat0.13.0 vscode-graphql-syntax1.3.4 vscode-scss0.10.0 debugpy2024.2.0 python2024.2.1 scala0.5.7 errorlens3.16.0 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
unfortunately we failed to log the actual error, but I have pushed a change for that. Can you test this scenario using latest insiders and report what you get as error? You can give our preview releases a try from:
Gahhh and, of course, now it works fine. I'm unaware of what changed since I logged this bug? I haven't had any system updates or VSCode updates that I'm aware of. Chrome has been updated, and I don't know if Electron shares code with it that might have impacted anything but I doubt it, given this was a file system issue... Thank you so much for trying to run this down, though. I appreciate you adding logging on a quick turnaround into the insiders edition. I'm not sure if there's anything else you might want to explore with this, but I'm happy to call this closed and write it off to the gods.

Discussion:
import { AbstractDiskFileSystemProviderChannel, AbstractSessionFileWatcher, ISessionFileWatcher } from 'vs/platform/files/node/diskFileSystemProviderServer'; import { DefaultURITransformer, IURITransformer } from 'vs/base/common/uriIpc'; import { IEnvironmentService } from 'vs/platform/environment/common/environment'; <ins> import { toErrorMessage } from 'vs/base/common/errorMessage'; </ins> export class DiskFileSystemProviderChannel extends AbstractDiskFileSystemProviderChannel<unknown> {

try { await shell.trashItem(filePath); } catch (error) { <del> throw createFileSystemProviderError(isWindows ? localize('binFailed', "Failed to move '{0}' to the recycle bin", basename(filePath)) : localize('trashFailed', "Failed to move '{0}' to the trash", basename(filePath)), FileSystemProviderErrorCode.Unknown); </del> <ins> throw createFileSystemProviderError(isWindows ? localize('binFailed', "Failed to move '{0}' to the recycle bin ({1})", basename(filePath), toErrorMessage(error)) : localize('trashFailed', "Failed to move '{0}' to the trash ({1})", basename(filePath), toErrorMessage(error)), FileSystemProviderErrorCode.Unknown); </ins> } }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.87.0 OS Version: MacOS Sonoma, 14.3.1 (23D60). Steps to Reproduce: VSCode with one editor group. a new empty document and enter some text. a new terminal in the editor area ("Terminal: Create New Terminal in Editor Area"). the terminal to the editor group on the right ("View: Move Editor into Right Group") some text in the editor (left group). on the second editor group ("" or CMD+2 on MacOS). Screencast: ! Additional notes: bug showed up a few months ago. It is not new to 1.87. gets focus just fine. The problem is only with the terminal. terminal in the panel (CMD+J) works fine. my settings:
We rely on being implemented properly on the editor pane.
Seems we do that here
Thank you!

Discussion:
override focus() { super.focus(); <del> this._editorInput?.terminalInstance?.focus(); </del> <ins> this._editorInput?.terminalInstance?.focus(true); </ins> } // eslint-disable-next-line @typescript-eslint/naming-convention
Change:
VS Code Version: Version : 1.87.1 Validation : Date : 2024-03-06T00:22:39.156Z Electron : 27.3.2 ElectronBuildId : Chromium : 118.0.5993.159 : 18.17.1 V8 : 11.8.172.18-electron.0 Système d’exploitation : Darwin arm64 23.3.0 Steps to Reproduce: Just launch VS Code and get an error message like in picture joined. I don't know how to not get them <img width="582" alt="Capture d’écran 2024-03-07 à 19 40 25" src=""
any ideas here ? rough translation: "Unable to be described in folder settings because does not support the scope of folder resources"
Repro steps a multi-root workspace. the setting to the files of one of those workspaces. the window. :bug: The dialogs show up.
and what should I do to remove this error message ???
A workaround would be: which root folder in the multi-root workspace has defined in . the multi-root workspace, and open that root folder in a separate VS Code window. The editor should automatically migrate over the outdated setting. the multi-root workspace again.
Hi, i am sorry i don't think that i understood precisely what you meant by: Check which root folder in the multi-root workspace has defined in Close the multi-root workspace, and open that root folder in a separate VS Code window. The editor should automatically migrate over the outdated setting. Open the multi-root workspace again. Can you be clearer please ? I am relatively new to VsCode Thanks
how can I do to get rid off the error message ? Thx
English repro looks like this: <img width="402" alt="Screenshot 2024-04-04 at 6 50 20 AM" src=""

Discussion:
const configuration: IConfigurationNode = { ...accessibilityConfigurationNodeBase, <ins> scope: ConfigurationScope.RESOURCE, </ins> properties: { [AccessibilityVerbositySettingId.Terminal]: { description: localize('verbosity.terminal.description', 'Provide information about how to access the terminal accessibility help menu when the terminal is focused.'),

import { ShowAccessibilityAnnouncementHelp, ShowSignalSoundHelp } from 'vs/workbench/contrib/accessibilitySignals/browser/commands'; import { localize } from 'vs/nls'; import { registerAction2 } from 'vs/platform/actions/common/actions'; <del> import { Extensions as ConfigurationExtensions, IConfigurationPropertySchema, IConfigurationRegistry } from 'vs/platform/configuration/common/configurationRegistry'; </del> <ins> import { Extensions as ConfigurationExtensions, ConfigurationScope, IConfigurationPropertySchema, IConfigurationRegistry } from 'vs/platform/configuration/common/configurationRegistry'; </ins> import { InstantiationType, registerSingleton } from 'vs/platform/instantiation/common/extensions'; import { Registry } from 'vs/platform/registry/common/platform'; import { Extensions as WorkbenchExtensions, IWorkbenchContributionsRegistry } from 'vs/workbench/common/contributions';

}; Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration).registerConfiguration({ <ins> scope: ConfigurationScope.RESOURCE, </ins> 'properties': { 'audioCues.enabled': { markdownDeprecationMessage: 'Deprecated. Use the specific setting for each audio cue instead (`audioCues.*`).',
Change:
Type: <bFeature Request</bWorkflow example: Currently, (AFAIK) there is no command to add a breakpoint at the cursor, so I have to move my hand over to the mouse (yuck) and click at the space left of the line number to add a breakpoint. It would be nice if there was a "add breakpoint at cursor" command here: ! VS Code version: Code 1.87.0 (, 2024-02-27T23:42:16.599Z) OS version: Linux x64 6.6.10--generic Modes: <!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.87.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
It's called "Toggle breakpoint", and F9 is bound to it by default
Thanks for providing the hotkey, but the command doesn't show in the command palette. !
Sorry for the slow response but you're right and I will add it to the command palette

Discussion:
...nls.localize2('toggleBreakpointAction', "Debug: Toggle Breakpoint"), mnemonicTitle: nls.localize({ key: 'miToggleBreakpoint', comment: ['&& denotes a mnemonic'] }, "Toggle &&Breakpoint"), }, <ins> f1: true, </ins> precondition: CONTEXT_DEBUGGERS_AVAILABLE, keybinding: { when: ContextKeyExpr.or(EditorContextKeys.editorTextFocus, CONTEXT_DISASSEMBLY_VIEW_FOCUS),
Change:
! I can click on them
Took a different approach with this... instead they are clickable, but they cause the list to scroll that separator up to the top (and they also clear focus).
Fixed in

Discussion:
overflow: hidden; max-height: calc(20 * 22px); padding-bottom: 5px; <ins> /* match border radius of quick input widget */ border-top-left-radius: 5px; border-top-right-radius: 5px; </ins> } .quick-input-list .quick-input-list-entry {

.quick-input-list .monaco-highlighted-label .highlight { font-weight: bold; <ins> /* preserve list-like styling instead of tree-like styling */ color: var(--vscode-list-focusHighlightForeground) !important; background-color: transparent; </ins> } .quick-input-list .quick-input-list-entry .quick-input-list-separator {

.quick-input-list .quick-input-list-entry .quick-input-list-entry-action-bar .action-label.always-visible, .quick-input-list .quick-input-list-entry:hover .quick-input-list-entry-action-bar .action-label, <del> .quick-input-list .monaco-list-row.focused .quick-input-list-entry-action-bar .action-label { </del> <ins> .quick-input-list .monaco-list-row.focused .quick-input-list-entry-action-bar .action-label, .quick-input-list .monaco-list-row.passive-focused .quick-input-list-entry-action-bar .action-label { </ins> display: flex; }

.quick-input-list .monaco-tree-sticky-row .quick-input-list-entry.quick-input-list-separator-as-item.quick-input-list-separator-border { border-top-style: none; } <del> /* TODO: This seems to be the best way to do this... is there a better way? */ .quick-input-list .monaco-tl-twistie { display: none !important; } </del>

data.entry.classList.remove('has-actions'); } } <ins> renderTwistie(element: IQuickPickElement, twistieElement: HTMLElement): boolean { // Force the twistie to be hidden twistieElement.setAttribute('style', 'display:none !important'); return false; } </ins> disposeElement?(_element: ITreeNode<IQuickPickElement, void>, _index: number, data: IQuickInputItemTemplateData): void { data.toDisposeElement.clear(); data.actionBar.clear();

this._registerOnElementChecked(); this._registerOnContextMenu(); this._registerHoverListeners(); <ins> this._registerSelectionChangeListener(); </ins> } private _registerOnKeyDown() {

})); } <ins> private _registerSelectionChangeListener() { // When the user selects a separator, the separator will move to the top and focus will be // set to the first element after the separator. this._register(this._tree.onDidChangeSelection(e => { const elementsWithoutSeparators = e.elements.filter((e): e is QuickPickItemElement => e instanceof QuickPickItemElement); if (elementsWithoutSeparators.length !== e.elements.length) { if (e.elements.length === 1 && e.elements[0] instanceof QuickPickSeparatorElement) { this._tree.setFocus([e.elements[0].children[0]]); this._tree.reveal(e.elements[0], 0); } this._tree.setSelection(elementsWithoutSeparators); } })); } </ins> //#endregion //#region public methods
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.87.1 OS Version: Steps to Reproduce: the icon theme a terminal with the function from the VS Code API, setting the to a file. the terminal into the editor area Example: ! The extension defined (!).

Discussion:
if (uri instanceof URI && iconClasses && iconClasses.length > 1) { css += ( `.monaco-workbench .terminal-tab.${iconClasses[0]}::before` + <del> `{background-image: ${dom.asCSSUrl(uri)};}` </del> <ins> `{content: ''; background-image: ${dom.asCSSUrl(uri)};}` </ins> ); } if (ThemeIcon.isThemeIcon(icon)) {