jiebi/CodeConvo huggingface dataset:
Change:
Not sure if this was intentional but it's very small now: ! They are invisible when zooming out once: ! Version: 1.71.0-insider (user setup) Commit: Date: 2022-08-16T05:18:32.502Z Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: WindowsNT x64 10.0. Sandboxed: Yes I preferred the old style: ! Version: 1.69.2 (user setup) Commit: Date: 2022-07-18T16:12:52.460Z Electron: 18.3.5 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: WindowsNT x64 10.0.
The mouse target is also 1 pixel wide now
Deleted lines are much harder to see and use now !
do you have any repro steps? I can't seem to see that, assume it was unintentional: ! !
This is in a PR so likely related to the comments changes
Still an issue after and fixes: !
This does seem likely to be related to the comments changes. I'm looking into it.
I have set, it works fine when I enable folding again

Discussion:
const options = this.editor.getOptions(); if (options.get(EditorOption.folding) && options.get(EditorOption.showFoldingControls) !== 'never') { <del> lineDecorationsWidth -= 16; </del> <ins> lineDecorationsWidth -= 27; </ins> } <del> lineDecorationsWidth += 15; </del> <ins> lineDecorationsWidth += 24; </ins> extraEditorClassName.push('inline-comment'); this.editor.updateOptions({ extraEditorClassName: extraEditorClassName.join(' '),

.monaco-editor.inline-comment .margin-view-overlays .codicon-folding-expanded, .monaco-editor.inline-comment .margin-view-overlays .codicon-folding-collapsed { <del> margin-left: 14px; </del> <ins> margin-left: 11px; </ins> } .monaco-editor.inline-comment .margin-view-overlays .dirty-diff-glyph { <del> margin-left: 24px; </del> <ins> margin-left: 25px; </ins> }
Change:
I'm seeing the following message in Insiders: The setting is also not in the user tab of the Settings editor with profiles enabled.
Fixed in commit, github just didn't close this issue :(

Discussion:
id: 'features/audioCues', label: localize('audioCues', 'Audio Cues'), settings: ['audioCues.*'] <ins> }, { id: 'features/mergeEditor', label: localize('mergeEditor', 'Merge Editor'), settings: ['mergeEditor.*'] </ins> } ] },
Change:
Originally reported by
Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.
would you mind verifying this one please?

Discussion:
// or if no window is open (macOS only) shouldOpenInNewWindow ||= isMacintosh && windowsMainService.getWindowCount() === 0; <del> // Pass along edit session id if (params.get('editSessionId') !== null) { environmentService.editSessionId = params.get('editSessionId') ?? undefined; params.delete('editSessionId'); uri = uri.with({ query: params.toString() }); } </del> // Check for URIs to open in window const windowOpenableFromProtocolLink = app.getWindowOpenableFromProtocolLink(uri); logService.trace('app#handleURL: windowOpenableFromProtocolLink = ', windowOpenableFromProtocolLink);

configuration.isInitialStartup = false; // since this is a reload configuration.policiesData = this.policyService.serialize(); // set policies data again <del> configuration.editSessionId = this.environmentMainService.editSessionId; // set latest edit session id </del> configuration.profiles = { all: this.userDataProfilesService.profiles, current: this.profile || this.userDataProfilesService.defaultProfile,

accessibilitySupport: app.accessibilitySupportEnabled, colorScheme: this.themeMainService.getColorScheme(), policiesData: this.policyService.serialize(), <del> editSessionId: this.environmentMainService.editSessionId, </del> }; let window: ICodeWindow | undefined;
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.2 OS Version: Windows just want to bring this issue to your attention: -- the failed for a PowerShell user because PowerShell was running in mode, where method invocation is not allowed. I'm not sure if the integration script could work in the restricted language mode. If it's just the method call causing the problem, maybe just replace them with . If the script wouldn't work in that language mode, then it's better to not inject to the profile by checking (maybe only run the integration script when PowerShell is running in ).
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.70.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Hopefully is enough to fix it. If not, be aware that checking that variable will throw in and . Restricted also blocks try/catch.

Discussion:
return; } <ins> # Disable shell integration when the language mode is restricted if ($ExecutionContext.SessionState.LanguageMode -ne "FullLanguage") { return; } </ins> $Global:__VSCodeOriginalPrompt = $function:Prompt $Global:__LastHistoryId = -1
Change:
Type: <bBug</bGo to Settings Editor, search for 'customcodeactionmenu', then use gearwheel menu on the first item to reset its default. Observe that the checkbox of the second item changes. Repeat the reset on the first item and the second one changes again. ! VS Code version: Code - Insiders 1.71.0-insider (, 2022-08-19T05:17:14.894Z) OS version: Windows_NT x64 10.0. Modes: Sandboxed: Yes <!-- generated by issue reporter --
Secondary comment: I think the second setting is poorly named. Setting the option true disables headers. I think it would be better named something like with a default of rather than with a default of .

Discussion:
* Checks if the settings have enabled the new code action widget. */ private isCodeActionWidgetEnabled(model: ITextModel): boolean { <del> return this._configurationService.getValue('editor.experimental.useCustomCodeActionMenu', { </del> <ins> return this._configurationService.getValue('editor.useCustomCodeActionMenu', { </ins> resource: model.uri }); }

.codeActionMenuWidget .monaco-list .monaco-list-row:hover:not(.option-disabled), .codeActionMenuWidget .monaco-list .monaco-list-row.focused:not(.option-disabled) { background-color: var(--vscode-list-hoverBackground) !important; <ins> color: var(--vscode-list-activeSelectionForeground) !important; </ins> } .codeActionMenuWidget .monaco-list .monaco-list-row.focused:not(.option-disabled)  {
Change:
Device pixel ratio = 1, zoom level = 0 ! Version: 1.71.0-insider (user setup) Commit: Date: 2022-08-19T05:17:14.894Z Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes
Can I work for this
go for it
hi , this problem seems to be due to the fact that the button is set to 27.5 height, but the search input is 25 height, I also found in another function that the button will be a little bit down because of the height. <img width="642" alt="image" src="https://user-"<img width="367" alt="image" src="https://user-"But according to the screenshot of , the difference is not as big as between 25 and 27.5, I didn't find the exact value of the input control to set the height, maybe it is set dynamically? And I found a place where the height of the input might be updated, so I feel like I need to refresh the height of the button here too
The decimal height seems suspicious. The pixels in my screenshot are actually 28, so the 27.5 is getting rounded up.
Introduced here: I think we can start with the tactical fix of just lowering that height to 26 or 27... whatever looks correct. I don't expect the input of the quick pick to change at all especially since it doesn't support multi-line. wanna give it a go?
I experimented with the result that setting it to 25 is appropriate, omewhat surprisingly, I initially also feel that maybe 26, 27 is about the same This is with a setting of 26: <img width="610" alt="image" src="https://user-"The height of the input box is 26, but the height of the button, if set to 26, will look slightly more <img width="524" alt="image" src="https://user-"This is with a setting of 25: <img width="630" alt="image" src="https://user-"From the code, it should be 26, but I don't know why 25 works best, and the input box has no border, some strange

Discussion:
font-size: 11px; padding: 0 6px; display: flex; <del> height: 27.5px; </del> <ins> height: 25px; </ins> align-items: center; }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.2 OS Version: macOS 12.5 Steps to Reproduce: to at the tab's close button - it's too far to the left, butting up against the start of the tab (especially noticeable when hovered over) compared to when set to Comparison: <img width="148" alt="image" src="https://user-"<img width="137" alt="image" src="https://user-"
Agree it looks too far to the beginning of the tab. I think the change in pushes the close button more to the left, can you elaborate why that was done? Today: <img width="178" alt="image" src="https://user-"After removing the 4px: <img width="175" alt="image" src="https://user-"
I'm trying to remember why that was changed and can't remember, happy to remove if it doesn't appear to break anything.

Discussion:
position: static; /** disable sticky positions for sticky compact/shrink tabs if the available space is too little */ } <del> .monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container > .tab.tab-actions-left .action-label { margin-right: 4px !important; } </del> .monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container > .tab.sizing-shrink.tab-actions-left::after, .monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container > .tab.sizing-shrink.tab-actions-off::after { content: '';
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: In some color themes, like the Default Light themes, the selected object's text is hard to read in the code action widget. !

Discussion:
* Checks if the settings have enabled the new code action widget. */ private isCodeActionWidgetEnabled(model: ITextModel): boolean { <del> return this._configurationService.getValue('editor.experimental.useCustomCodeActionMenu', { </del> <ins> return this._configurationService.getValue('editor.useCustomCodeActionMenu', { </ins> resource: model.uri }); }

.codeActionMenuWidget .monaco-list .monaco-list-row:hover:not(.option-disabled), .codeActionMenuWidget .monaco-list .monaco-list-row.focused:not(.option-disabled) { background-color: var(--vscode-list-hoverBackground) !important; <ins> color: var(--vscode-list-activeSelectionForeground) !important; </ins> } .codeActionMenuWidget .monaco-list .monaco-list-row.focused:not(.option-disabled)  {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Insiders 1.71 OS Version: Ubuntu 18.04 amd64 Steps to Reproduce: to install latest code-insiders packages from MS repository () The issue is that with the dependency on Debian derivatives changed to which only exists on newer releases (20.04 and later I think). I realise that support for Ubuntu-Ancient is low on the priority list, but I am sadly stuck with it, and would appreciate if there was a workaround. Installing newer libgcc releases as suggested in some places easily leads to a very broken system.
This is a side effect of now using bullseye sysroot, we should apply the following change https://chromium- to our debian calculate package deps.

Discussion:
depsStr = line.substring(shlibsDependsPrefix.length); } } <del> const requires = new Set(depsStr.split(', ').sort()); </del> <ins> // Refs https://chromium-review.googlesource.com/c/chromium/src/+/3572926 // Chromium depends on libgcc_s, is from the package libgcc1.  However, in // Bullseye, the package was renamed to libgcc-s1.  To avoid adding a dep // on the newer package, this hack skips the dep.  This is safe because // libgcc-s1 is a dependency of libc6.  This hack can be removed once // support for Debian Buster and Ubuntu Bionic are dropped. const filteredDeps = depsStr.split(', ').filter(dependency => { return !dependency.startsWith('libgcc-s1'); }).sort(); const requires = new Set(filteredDeps); </ins> return requires; }

'libdrm2 (>= 2.4.38)', 'libexpat1 (>= 2.0.1)', 'libgbm1 (>= 8.1~0)', <del> 'libgcc-s1 (>= 3.0)', </del> 'libglib2.0-0 (>= 2.16.0)', 'libglib2.0-0 (>= 2.39.4)', 'libgtk-3-0 (>= 3.9.10)',

'libdrm2 (>= 2.4.38)', 'libexpat1 (>= 2.0.1)', 'libgbm1 (>= 8.1~0)', <del> 'libgcc-s1 (>= 3.0)', 'libgcc-s1 (>= 3.5)', </del> 'libglib2.0-0 (>= 2.16.0)', 'libglib2.0-0 (>= 2.39.4)', 'libgtk-3-0 (>= 3.9.10)',
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.1 OS Version: Windows_NT x64 10.0. From some versions until now, I noticed that the copy and paste behavior of the TreeView component's markdown tooltips stopped working. Simply when I click on CTRL the tooltip disappears, and does not perform the action. In the GIF below you can also see issue occurring sporadically when hovering over the item. !
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.70.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Yes, problem persists in 1.70.2.
does this ring any bells, or should I investigate?
This seems to be a regression. Adding to this iteration, if you have any time to look into this it would be appreciated as I'll be pretty busy this week.
thanks for fix!
Verified on mac - not sure if this was windows specific
The issue was not Windows specific, verifying on mac is good.

Discussion:
import { IContextViewProvider, IDelegate } from 'vs/base/browser/ui/contextview/contextview'; import { DisposableStore, IDisposable, toDisposable } from 'vs/base/common/lifecycle'; import { addDisposableListener, EventType } from 'vs/base/browser/dom'; <ins> import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent'; </ins> export class HoverService implements IHoverService { declare readonly _serviceBrand: undefined;

constructor( @IInstantiationService private readonly _instantiationService: IInstantiationService, @IContextViewService private readonly _contextViewService: IContextViewService, <del> @IContextMenuService contextMenuService: IContextMenuService </del> <ins> @IContextMenuService contextMenuService: IContextMenuService, @IKeybindingService private readonly _keybindingService: IKeybindingService </ins> ) { contextMenuService.onDidShowContextMenu(() => this.hideHover()); }

hover.isLocked = true; return; } <ins> const event = new StandardKeyboardEvent(e); const keybinding = this._keybindingService.resolveKeyboardEvent(event); if (keybinding.getSingleModifierDispatchParts().some(value => !!value) || this._keybindingService.softDispatch(event, event.target)) { return; } </ins> this.hideHover(); }
Change:
Originally posted by in
This also happens if step 5 is omitted and Search mode is used. The problem seems to be that to put the 'No elements found.' warning message under the find-in-list's input widget a ContextView is created immediately below it. But when find is occurring in a breadcrumb list, that list is itself in a ContextView which gets hidden and cleared immediately before the one for the warning message is shown. The warning message appears in the top left of the VS Code window in a very narrow column. See below, where I open , click on the filename in the breadcrumb to get a list of sibling filenames, then type "z" which isn't present in any of the filenames. !

Discussion:
} export interface IMessage { <del> readonly content: string; </del> <ins> readonly content?: string; </ins> readonly formatContent?: boolean; // defaults to false readonly type?: MessageType; }

const styles = this.stylesForType(this.message.type); this.element.style.border = styles.border ? `1px solid ${styles.border}` : ''; <del> if (this.hasFocus() || force) { </del> <ins> if (this.message.content && (this.hasFocus() || force)) { </ins> this._showMessage(); } }

}; const spanElement = (this.message.formatContent <del> ? renderFormattedText(this.message.content, renderOptions) : renderText(this.message.content, renderOptions)); </del> <ins> ? renderFormattedText(this.message.content!, renderOptions) : renderText(this.message.content!, renderOptions)); </ins> spanElement.classList.add(this.classForType(this.message.type)); const styles = this.stylesForType(this.message.type);

const noMatches = this.filter.totalCount > 0 && this.filter.matchCount === 0; if (this.pattern && noMatches) { <del> this.widget?.showMessage({ type: MessageType.WARNING, content: localize('not found', "No elements found.") }); </del> <ins> if (this.tree.options.showNotFoundMessage ?? true) { this.widget?.showMessage({ type: MessageType.WARNING, content: localize('not found', "No elements found.") }); } else { this.widget?.showMessage({ type: MessageType.WARNING }); } </ins> } else { this.widget?.clearMessage(); }

readonly typeNavigationEnabled?: boolean; readonly typeNavigationMode?: TypeNavigationMode; readonly defaultFindMode?: TreeFindMode; <ins> readonly showNotFoundMessage?: boolean; </ins> readonly smoothScrolling?: boolean; readonly horizontalScrolling?: boolean; readonly mouseWheelScrollSensitivity?: number;

updateStyleOverrides(overrideStyles?: IColorMapping): void { dispose(this.styler); <del> this.styler = overrideStyles ? attachListStyler(this.tree, this.themeService, overrideStyles) : Disposable.None; </del> <ins> this.styler = attachListStyler(this.tree, this.themeService, overrideStyles); </ins> } dispose(): void {

identityProvider: new FileIdentityProvider(), keyboardNavigationLabelProvider: new FileNavigationLabelProvider(), accessibilityProvider: this._instantiationService.createInstance(FileAccessibilityProvider), <ins> showNotFoundMessage: false, </ins> overrideStyles: { listBackground: breadcrumbsPickerBackground },

collapseByDefault: true, expandOnlyOnTwistieClick: true, multipleSelectionSupport: false, <ins> showNotFoundMessage: false </ins> } ); }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.2 Local OS Version: Windows 10 Pro for Workstations 21H2 .1889 Remote OS Version: WSL1 - Debian 11 / SSH - Debian 9 Steps to Reproduce: -WSL/SSH to a server. the integrated terminal and type a path start with like then left click to the path in terminal. VSCode shows that no matching results. if we type an absolute path like then it works. Considering that there may be files or directories starting with in the current directory, VSCode has changed the file path parsing method since v1.69 (If I remember correctly). But can we continue to parse as home directory(like as , as ) after judging that the files or directories in the current directory does not exist?
I see 2 problems with ~ in links, first is files aren't resolving and auto-selecting the first entry if there is only one: ! Second is folder aren't recognized: !
This actually happens on local workspaces as well, at least on Windows
It's being treated as a search link because of this: !

Discussion:
// Get a single link candidate if the cwd of the line is known const linkCandidates: string[] = []; <del> if (osPathModule(this._os).isAbsolute(link)) { </del> <ins> if (osPathModule(this._os).isAbsolute(link) || link.startsWith('~')) { </ins> linkCandidates.push(link); } else { if (this._capabilities.has(TerminalCapability.CommandDetection)) {