jiebi/CodeConvo huggingface dataset:
Change:
To support voice in terminal, there is an adapter: I think it works great for the most part, but I noticed does not immediately fire, only when the response has been generated. The visible impact is that the animation only stops when the response has landed, as opposed to finishing right away: !

Discussion:
throw new Error('Could not start chat session'); } } <ins> this._messages.fire(Message.ACCEPT_INPUT); </ins> const model = this._model.value; this._lastInput = this._chatWidget?.value?.input();

this._chatWidget?.value.inlineChatWidget.updateChatMessage({ message: new MarkdownString(responseContent), requestId: this._currentRequest.id, providerId: 'terminal' }, false, containsCode); this._responseContainsCodeBlockContextKey.set(containsCode); this._chatWidget?.value.inlineChatWidget.updateToolbar(true); <del> this._messages.fire(Message.ACCEPT_INPUT); </del> } const supportIssueReporting = this._currentRequest?.response?.agent?.metadata?.supportIssueReporting; if (supportIssueReporting !== undefined) {
Change:
in VS Code stable and VS Code insiders all cells in each quickly up and down through the notebook :bug: in VS Code insiders scrolling over notebook outputs is not smooth anymore; scrolling appears to stutter and halt over notebook outputs I took performance profiles in stable and insiders but devtools won't let me save them unfortunately. Nothing stood out though in terms of memory usage or a particular function call increasing in percentage across profiles. LMK if I can provide more info
Is this with a trackpad? I might be seeing this. Could be a regression from
I've the same issue with a trackpad on Windows.
Yeah, trackpad on Windows for me as well

Discussion:
let lastTimeScrolled: number | undefined; function flagRecentlyScrolled(node: Element, deltaY?: number) { scrolledElement = node; <del> if (!deltaY) { </del> <ins> if (deltaY === undefined) { </ins> lastTimeScrolled = Date.now(); previousDelta = undefined; node.setAttribute('recentlyScrolled', 'true');
Change:
After has been fixed by add . Now it's offset to the left by 8px. ! <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.86.2 OS Version: Win10 20H2 Steps to Reproduce: SVN and the SVN extension svn co to checkout that repository the release-notes folder in VS Code some changes
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.87.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
thank you very much for reporting this issue. You can reproduce this issue with the extension as well if you disable the setting and reload the window. I will look at this and will push a fix later this week.

Discussion:
height: 100%; background-repeat: no-repeat; background-position: 50% 50%; <del> margin-right: 8px; </del> <ins> margin-left: 5px; </ins> } .scm-view .monaco-list-row .resource > .decoration-icon.codicon {
Change:
Reloading a window seems to reset the view state, I think thats not really needed, but not sure how this is triggered? !
This is from here: Arguably that listener should not run when we dispose the workbench, but maybe we cannot address this, will see.

Discussion:
import { defaultButtonStyles, defaultProgressBarStyles } from 'vs/platform/theme/browser/defaultStyles'; import { ICustomHover, setupCustomHover } from 'vs/base/browser/ui/hover/updatableHoverWidget'; import { getDefaultHoverDelegate } from 'vs/base/browser/ui/hover/hoverDelegateFactory'; <ins> import { ILifecycleService } from 'vs/workbench/services/lifecycle/common/lifecycle'; </ins> export enum ViewPaneShowActions { /** Show the actions when the view is hovered. This is the default behavior. */

@IOpenerService protected openerService: IOpenerService, @ITelemetryService protected telemetryService: ITelemetryService, @IContextKeyService private contextKeyService: IContextKeyService, <ins> @ILifecycleService lifecycleService: ILifecycleService </ins> ) { <del> this.delegate.onDidChangeViewWelcomeState(this.onDidChangeViewWelcomeState, this, this.disposables); this.onDidChangeViewWelcomeState(); </del> <ins> this.disposables.add(Event.runAndSubscribe(this.delegate.onDidChangeViewWelcomeState, () => this.onDidChangeViewWelcomeState())); this.disposables.add(lifecycleService.onWillShutdown(() => this.dispose())); // Fixes https://github.com/microsoft/vscode/issues/208878 </ins> } layout(height: number, width: number) {

} protected renderBody(container: HTMLElement): void { <del> this.viewWelcomeController = this._register(new ViewWelcomeController(container, this, this.instantiationService, this.openerService, this.telemetryService, this.contextKeyService)); </del> <ins> this.viewWelcomeController = this._register(this.instantiationService.createInstance(ViewWelcomeController, container, this)); </ins> } protected layoutBody(height: number, width: number): void {
Change:
Repro: vscode on (wide) external monitor inline chat - Additional info: Resizing vscode to half of screen fixes the problem Version: 1.88.0-insider Commit: Date: 2024-03-27T05:51:26.826Z Electron: 28.2.6 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Darwin arm64 23.4.0

Discussion:
import { Emitter, Event } from 'vs/base/common/event'; import { DisposableStore } from 'vs/base/common/lifecycle'; import { IPosition, Position } from 'vs/editor/common/core/position'; <del> import { clamp } from 'vs/base/common/numbers'; </del> import { renderLabelWithIcons } from 'vs/base/browser/ui/iconLabel/iconLabels'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { inlineChatBackground } from 'vs/workbench/contrib/inlineChat/common/inlineChat';

import { Range } from 'vs/editor/common/core/range'; import { ServiceCollection } from 'vs/platform/instantiation/common/serviceCollection'; import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; <ins> import { EditorOption } from 'vs/editor/common/config/editorOptions'; </ins> export class InlineChatContentWidget implements IContentWidget {

beforeRender(): IDimension | null { <del> const contentWidth = this._editor.getLayoutInfo().contentWidth; const minWidth = Math.round(contentWidth * 0.38); const maxWidth = Math.round(contentWidth * 0.82); const width = clamp(220, minWidth, maxWidth); </del> <ins> const maxHeight = this._widget.input.inputEditor.getOption(EditorOption.lineHeight) * 5; </ins> const inputEditorHeight = this._widget.inputEditor.getContentHeight(); <del> this._widget.inputEditor.layout(new dom.Dimension(width, inputEditorHeight)); </del> <ins> this._widget.inputEditor.layout(new dom.Dimension(360, Math.min(maxHeight, inputEditorHeight))); </ins> // const actualHeight = this._widget.inputPartHeight; // return new dom.Dimension(width, actualHeight);

display: none; } <ins> .monaco-workbench .inline-chat-content-widget.interactive-session .interactive-session { max-width: unset; } </ins> .monaco-workbench .inline-chat-content-widget.interactive-session .interactive-input-part .interactive-execute-toolbar { margin-bottom: 1px; }
Change:
Version: 1.88.0-insider (user setup) Commit: Date: 2024-03-27T05:50:10.528Z Electron: 28.2.6 ElectronBuildId: Chromium: 120.0.6099.291 18.18.2 V8: 12.0.267.19-electron.0 OS: Windows_NT x64 10.0. Theme: ! Steps to Reproduce: +Shift+P VSIX !
Caused by:

Discussion:
// Import the effects we need import { Color } from 'vs/base/common/color'; <del> import { registerColor, darken, lighten, transparent } from 'vs/platform/theme/common/colorUtils'; </del> <ins> import { registerColor, darken, lighten, transparent, ifDefinedThenElse } from 'vs/platform/theme/common/colorUtils'; </ins> // Import the colors we need import { foreground, contrastBorder, activeContrastBorder, focusBorder, iconForeground } from 'vs/platform/theme/common/colors/baseColors';

nls.localize('highlight', 'List/Tree foreground color of the match highlights when searching inside the list/tree.')); export const listFocusHighlightForeground = registerColor('list.focusHighlightForeground', <del> { dark: listHighlightForeground, light: listHighlightForeground, hcDark: listHighlightForeground, hcLight: listHighlightForeground }, </del> <ins> { dark: listHighlightForeground, light: ifDefinedThenElse(listActiveSelectionBackground, listHighlightForeground, '#BBE7FF'), hcDark: listHighlightForeground, hcLight: listHighlightForeground }, </ins> nls.localize('listFocusHighlightForeground', 'List/Tree foreground color of the match highlights on actively focused items when searching inside the list/tree.')); export const listInvalidItemForeground = registerColor('list.invalidItemForeground',
Change:
default light theme trigger intellisense and type some matching characters bad colors <img width="1142" alt="Screenshot 2024-03-27 at 18 29 42" src=""

Discussion:
// Import the effects we need import { Color } from 'vs/base/common/color'; <del> import { registerColor, darken, lighten, transparent } from 'vs/platform/theme/common/colorUtils'; </del> <ins> import { registerColor, darken, lighten, transparent, ifDefinedThenElse } from 'vs/platform/theme/common/colorUtils'; </ins> // Import the colors we need import { foreground, contrastBorder, activeContrastBorder, focusBorder, iconForeground } from 'vs/platform/theme/common/colors/baseColors';

nls.localize('highlight', 'List/Tree foreground color of the match highlights when searching inside the list/tree.')); export const listFocusHighlightForeground = registerColor('list.focusHighlightForeground', <del> { dark: listHighlightForeground, light: listHighlightForeground, hcDark: listHighlightForeground, hcLight: listHighlightForeground }, </del> <ins> { dark: listHighlightForeground, light: ifDefinedThenElse(listActiveSelectionBackground, listHighlightForeground, '#BBE7FF'), hcDark: listHighlightForeground, hcLight: listHighlightForeground }, </ins> nls.localize('listFocusHighlightForeground', 'List/Tree foreground color of the match highlights on actively focused items when searching inside the list/tree.')); export const listInvalidItemForeground = registerColor('list.invalidItemForeground',
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: type and enter that issue reporter is opened with correct extension selected. !

Discussion:
}, dataOverrides); if (issueReporterData.extensionId) { <del> const extensionExists = extensionData.some(extension => extension.id === issueReporterData.extensionId); </del> <ins> const extensionExists = extensionData.some(extension => extension.id.toLowerCase() === issueReporterData.extensionId?.toLowerCase()); </ins> if (!extensionExists) { console.error(`Extension with ID ${issueReporterData.extensionId} does not exist.`); }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.88.0-insider (Universal) OS Version: MacOS 13.1 Steps to Reproduce (see video for details): Command Palette export profile and then press enter Export button on the slide menu a name Github (gist) option from the dropdown on cancel button the Export button in the side menu is still disabled The Export button should not disabled when its a github error , because if the user wants to export profile locally, they can only click on Close button first and then redo the entire step.

Discussion:
try { await this.doExportProfile(userDataProfilesExportState); } catch (error) { <ins> exportAction.enabled = true; </ins> this.notificationService.error(error); throw error; }
Change:
Type: <bBug</ban image file from the VS Code explorer into a md file Bug No markdown image inserted, just the file name VS Code version: Code - Insiders 1.88.0-insider (Universal) (, 2024-03-29T22:24:49.191Z) OS version: Darwin arm64 23.4.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Closing for verification.

Discussion:
return; } <del> // Disable ourselves if there's also a text entry with the same content as our list, </del> <ins> // In some browsers, copying from the address bar sets both text/uri-list and text/plain. // Disable ourselves if there's also a text entry with the same http(s) uri as our list, </ins> // unless we are explicitly requested. <del> if (uriList.entries.length === 1 && !context?.only?.contains(ResourcePasteOrDropProvider.kind)) { </del> <ins> if ( uriList.entries.length === 1 && (uriList.entries[0].uri.scheme === Schemes.http || uriList.entries[0].uri.scheme === Schemes.https) && !context?.only?.contains(ResourcePasteOrDropProvider.kind) ) { </ins> const text = await dataTransfer.get(Mime.textPlain)?.asString(); if (token.isCancellationRequested) { return;

return; } const edits: vscode.SnippetTextEdit[] = []; let insertedLinkCount = 0;
Change:
Type: <bBug</ban image file from the VS Code explorer into a md file Bug No markdown image inserted, just the file name VS Code version: Code - Insiders 1.88.0-insider (Universal) (, 2024-03-29T22:24:49.191Z) OS version: Darwin arm64 23.4.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Closing for verification.

Discussion:
return; } <del> // Disable ourselves if there's also a text entry with the same content as our list, </del> <ins> // In some browsers, copying from the address bar sets both text/uri-list and text/plain. // Disable ourselves if there's also a text entry with the same http(s) uri as our list, </ins> // unless we are explicitly requested. <del> if (uriList.entries.length === 1 && !context?.only?.contains(ResourcePasteOrDropProvider.kind)) { </del> <ins> if ( uriList.entries.length === 1 && (uriList.entries[0].uri.scheme === Schemes.http || uriList.entries[0].uri.scheme === Schemes.https) && !context?.only?.contains(ResourcePasteOrDropProvider.kind) ) { </ins> const text = await dataTransfer.get(Mime.textPlain)?.asString(); if (token.isCancellationRequested) { return;
Change:
There is more wasted space between the buttons and text in the search panel's find input than on today's stable. I might need to make this a candidate. ! Related

Discussion:
this.setAdditionalToggles([this._aiButton]); <del> this.inputBox.paddingRight = (this.caseSensitive?.width() ?? 0) + (this.wholeWords?.width() ?? 0) + (this.regex?.width() ?? 0) + this._findFilter.width + (this._aiButton?.width() ?? 0); </del> <ins> this.inputBox.paddingRight = (this.caseSensitive?.width() ?? 0) + (this.wholeWords?.width() ?? 0) + (this.regex?.width() ?? 0) + this._findFilter.width; </ins> this.controls.appendChild(this._findFilter.container); this._findFilter.container.classList.add('monaco-custom-toggle');
Change:
Type: <bBug</bI'm using a custom widget built using AnyWidget. It has a text input area. In the latest Code Insiders, I can no longer type text in the input area. The text field is selected, but no input appears. Extension version: 2024.2.0 VS Code version: Code - Insiders 1.88.0-insider (Universal) (, 2024-03-29T22:24:49.191Z) OS version: Darwin arm64 23.4.0 Modes: <details<summarySystem Info</summary </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Can you confirm this works with a regular input element, E.g. run the following code and verify this works Now try typing into the textbox.
That reproduces the issue, i.e. typing in that field produces no text.

Discussion:
} const activeElement = window.document.activeElement; if (activeElement?.tagName === 'INPUT' || activeElement?.tagName === 'TEXTAREA') { <del> e.preventDefault(); // We will handle selection in editor code. </del> <ins> // The input element will handle this. </ins> return; }
Change:
Register a code lens provider: Put a breakpoint at Debug the extension and open a javascript document Wait for the breakpoint to be hit. Then, wait for 30 seconds (e.g. because stepping through the implementation takes a while) Then modify the javascript document to trigger another call to Notice it takes about 30 seconds until is called again. This is quite surprising. I think this happens because of the dynamic debouncing of language features. I suggest that dynamic debouncing of language features is set to a maximum of 2 seconds when an extension is debugged (i.e. when the process arg is present), so it should not have any production impact. What do you think?
d'oh
Interesting. I can consistently reproduce with yesterdays VS Code build. This is my launch config:
Read the whole snippet... I works the wrong way around

Discussion:
const key = `${IdentityHash.of(feature)},${min}${extra ? ',' + extra : ''}`; let info = this._data.get(key); if (!info) { <del> if (!this._isDev) { </del> <ins> if (this._isDev) { </ins> this._logService.debug(`[DEBOUNCE: ${name}] is disabled in developed mode`); info = new NullDebounceInformation(min * 1.5); } else {
Change:
Type: <bBug</bObserved on SCM view: ! VS Code version: Code - Insiders 1.89.0-insider (, 2024-04-05T05:52:23.778Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (52)</summaryExtensionVersion ------ Bookmarks13.5.0 tsl-problem-matcher0.6.2 open-in-github-button0.1.1 vscode-opennewinstance0.0.12 vscode-eslint2.4.4 githistory0.6.20 prettier-vscode10.4.0 vscode-open-in-github2.2.1 intersystems-dxjetpack0.1.2 searchable-debug-console0.0.2 thefoldingstuff0.2.1 codespaces1.16.18 copilot1.178.0 copilot-chat0.15. vscode-github-actions0.26.2 vscode-pull-request-github0.86.0 vscode-memfs0.0.3- vscode-favorites1.11.0 rest-client0.25.1 vscode-pr-pinger0.0.6 workspace-storage-cleanup1.1.5 vscode-docker1.29.0 debugpy2024.4.0 python2024.4.0 vscode-pylance2024.4.1 jupyter2024.3.0 jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.9 vscode-jupyter-powertoys0.1.1 vscode-jupyter-slideshow0.1.6 remote-containers0.354.0 remote-ssh0.110.1 remote-ssh-edit0.86.0 remote-wsl0.88.0 azure-account0.11.6 extension-test-runner0.0.9 hexeditor1.9.14 live-server0.4.13 remote-explorer0.4.3 remote-server1.5.1 vscode-github-issue-notebooks0.0.130 vscode-js-profile-flame1.0.9 vscode-markdown-notebook0.0.26 vscode-selfhost-test-provider0.3.25 vscode-speech0.8.0 material-icon-theme4.34.0 material-product-icons1.7.0 vscode-thunder-client2.20.3 vscode-xml0.26.1 rest-book6.2.1 luna-paint0.16.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
I used Culprit is by

Discussion:
.monaco-menu .monaco-action-bar.vertical .keybinding { font-size: inherit; padding: 0 2em; <del> overflow: hidden; </del> max-height: 100%; }

let testSubmenus: IAction[] = testItems.map(({ currentLabel, testItem }) => { const actions = this.getTestContextMenuActions(testItem.test, testItem.resultItem); disposable.add(actions); <del> return new SubmenuAction(testItem.test.item.extId, stripIcons(currentLabel), actions.object); </del> <ins> let label = stripIcons(currentLabel); const lf = label.indexOf('n'); if (lf !== -1) { label = label.slice(0, lf); } return new SubmenuAction(testItem.test.item.extId, label, actions.object); </ins> });
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.88.0 (Universal) OS Version: Darwin arm64 23.2.0 Version: 1.88.0 (Universal) Steps to Reproduce: now json file color is this: <img width="906" alt="image" src=""it is different with before because i updated, i can't find the before color
Here is how it looks in 1.87: !
The JSON grammar has not changed in the last 4 years: And also the Monokai Dimmed theme has not changed recently:
Please give more inform about what has changed. Make sure you have to customised the theme in the settings.
Can you check the colors of v1.86.0? Perhaps it's a similar issue to this one:
<img width="517" alt="image" src=""
Please give more information about what has changed. The colors look the same to me.
Sorry, I made a mistake. There is also an issue with v1.86.0. Please take a look at v1.85.2
Please provide a screenshot of the version where it worked.
<img width="668" alt="image" src=""Version: 1.85.2

Discussion:
}, { "name": "CSS Property Name", <del> "scope": "support.type.property-name", </del> <ins> "scope": "source.css support.type.property-name", </ins> "settings": { "fontStyle": "", "foreground": "#676867"
Change:
Tracks updating the TS 5.4.4. recovery build
Actually may wait for TS 5.4.5 with a fix for auto imports
Merging 5.4.4 for now

Discussion:
"license": "MIT", "description": "Dependencies shared by all extensions", "dependencies": { <del> "typescript": "5.4.3" </del> <ins> "typescript": "5.4.4" </ins> }, "scripts": { "postinstall": "node ./postinstall.mjs"

dependencies: is-number "^7.0.0" <del> typescript@5.4.3: version "5.4.3" resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.4.3.tgz#5c6fedd4c87bee01cd7a528a30145521f8e0feff" integrity sha512-KrPd3PKaCLr78MalgiwJnA25Nm8HAmdwN3mYUYZgG/wizIo9EainNVQI9/yDavtVFRN2h3k8uf3GLHuhDMgEHg== </del> <ins> typescript@5.4.4: version "5.4.4" resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.4.4.tgz#eb2471e7b0a5f1377523700a21669dce30c2d952" integrity sha512-dGE2Vv8cpVvw28v8HCPqyb08EzbBURxDpuhJvTrusShUfGnhHBafDsLdS1EhhxyL6BJQE+2cT3dDPAv+MQ6oLw== </ins> vscode-grammar-updater@^1.1.0: version "1.1.0"