Change:
Issue Type: <bBug</bRelease Notes from Help menu it Release Notes doesn't show an icon on its normal tab, the pinned one is empty. VS Code version: Code - Insiders 1.46.0-insider (, 2020-05-07T16:19:54.327Z) OS version: Windows_NT x64 10.0. ! Compare its appearance to that of my adjacent pinned tab, which is my file (very handy to be able to pin it, kudos to ) <!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.669 --- <!-- score: 0.543 --- <!-- score: 0.532 --- <!-- score: 0.455 --<!-- potentialduplicatescomment --
This actually looks like a bug to me, because release notes should have the product icon. Looking into devtools I see it being referenced: ! However, this file does not exist on disk likely because it gets inlined, as you can see in the welcome tab where the icon appears properly: ! Assigning a couple of people to check this.
I should add that I indeed moved this icon to a new place (we had many copies of it). So it could be a regression from that work.
so this is a regression from my push but I think the way the icon is used in here is not ideal because it prevents the image from being inlined: A better solution would be to have it referenced from CSS like we do e.g. in the welcome page: However this would require some name to appear as part of the label we could override. I am not sure how to pass a resource name to the webview? Currently it looks like we add a UUID: ! Open for ideas. Last resort is to just bring back that icon, but then we have it duplicate as before.
This actually has nothing to do with pinned tabs as it appears blank normally: !

Discussion:
<ins> /*--------------------------------------------------------------------------------------------- *  Copyright (c) Microsoft Corporation. All rights reserved. *  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ .file-icons-enabled .show-file-icons .webview-vs_code_release_notes-name-file-icon.file-icon::before { content: ' '; background-image: url('../../../../browser/media/code-icon.svg'); } </ins>

*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <ins> import 'vs/css!./media/releasenoteseditor'; </ins> import { onUnexpectedError } from 'vs/base/common/errors'; import { OS } from 'vs/base/common/platform'; import { URI } from 'vs/base/common/uri';

this._webviewWorkbenchService.revealWebview(this._currentReleaseNotes, activeEditorPane ? activeEditorPane.group : this._editorGroupService.activeGroup, false); } else { this._currentReleaseNotes = this._webviewWorkbenchService.createWebview( <del> generateUuid(), </del> <ins> 'vs_code_release_notes', </ins> 'releaseNotes', title, { group: ACTIVE_GROUP, preserveFocus: false },

this._currentReleaseNotes.webview.onDidClickLink(uri => this.onDidClickLink(URI.parse(uri))); this._currentReleaseNotes.onDispose(() => { this._currentReleaseNotes = undefined; }); <del> const iconPath = URI.parse(require.toUrl('vs/workbench/browser/media/code-icon.svg')); this._currentReleaseNotes.iconPath = { light: iconPath, dark: iconPath }; </del> this._currentReleaseNotes.webview.html = html; }