jiebi/CodeConvo huggingface dataset:
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.77.3 OS Version: Ubuntu 22.04.2 LTS Steps to Reproduce: the open dialog options filter to accept files: const openDialogOptions: vscode.OpenDialogOptions = { canSelectFiles: true, canSelectFolders: false, canSelectMany: false, openLabel: 'Select', filters: { 'targz': [''] } }; await (openDialogOptions); the extension in Remote-SSH mode and try to select a file
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.81.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Reproducible in VS Code 1.81.1 as well.

Discussion:
return sorted; } <del> private extname(file: URI): string { const ext = resources.extname(file); if (ext.length === 0) { const basename = resources.basename(file); if (basename.startsWith('.')) { return basename; } } else { return ext; } return ''; } </del> private filterFile(file: URI): boolean { if (this.options.filters) { <del> const ext = this.extname(file); </del> for (let i = 0; i < this.options.filters.length; i++) { for (let j = 0; j < this.options.filters[i].extensions.length; j++) { const testExt = this.options.filters[i].extensions[j]; <del> if ((testExt === '*') || (ext === ('.' + testExt))) { </del> <ins> if ((testExt === '*') || (file.path.endsWith('.' + testExt))) { </ins> return true; } }
Change:
I have a configuration property in my extension's with the following definition: That regex is a valid unicode regex that works in the node REPL, but it doesn't work properly in the VS Code settings editor: <img width="474" alt="Screenshot 2023-08-31 at 9 11 30 AM" src=""Are these patterns evaluated with the unicode flag on? If not, can that feature be or enabled?
The Unicode flag isn't used at this time. Code pointer
Is this something that is going to be picked up in an upcoming release?
Thanks for fixing this so quickly! It works for me on: Version: 1.83.0-insider Commit: Date: 2023-09-25T10:44:46.038Z Electron: 25.8.2 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Darwin arm64 22.6.0
Marking this as verified based on author's comment

Discussion:
const uriRegex = /^(([^:/?#]+?):)?(//([^/?#]*))?([^?#]*)(?([^#]*))?(#(.*))?/; let patternRegex: RegExp | undefined; if (typeof prop.pattern === 'string') { <del> patternRegex = new RegExp(prop.pattern); </del> <ins> patternRegex = new RegExp(prop.pattern, 'u'); </ins> } return [

} if (typeof propItems.pattern === 'string') { <del> const patternRegex = new RegExp(propItems.pattern); </del> <ins> const patternRegex = new RegExp(propItems.pattern, 'u'); </ins> arrayValue.forEach(v => { if (!patternRegex.test(v)) { message +=
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Todays insider OS Version: Win11 Steps to Reproduce: ! Be in a devcontainer (here on a remote ssh host, if that matters). Try to set a new local port for an existing port forwarding. Enter -does not work Enter -does work.
Enter 5000 -does work. This is correct, we only allow you to change the port number, not the host.
The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our . Happy Coding!
Hello I'm not trying to change the host - I'm just following what's outlined in the help text on change: !
Thanks the error message there is incorrect. I'm fixing the message.
Thank you very much - this is way better!

Discussion:
function validateInput(tunnelService: ITunnelService, value: string, canElevate: boolean): { content: string; severity: Severity } | null { if (!value.match(/^[0-9]+$/)) { <del> return { content: invalidPortString, severity: Severity.Error }; </del> <ins> return { content: nls.localize('remote.tunnelsView.portShouldBeNumber', "Local port should be a number."), severity: Severity.Error }; </ins> } else if (Number(value) >= maxPortNumber) { return { content: invalidPortNumberString, severity: Severity.Error }; } else if (canElevate && tunnelService.isPortPrivileged(Number(value))) {
Change:
These moves could be one: ! And this move could be bigger: ! (click on "use latest dev" to verify a future bug-fix)

Discussion:
import * as assert from 'assert'; import { Range } from 'vs/editor/common/core/range'; import { RangeMapping } from 'vs/editor/common/diff/rangeMapping'; <del> import { LinesSliceCharSequence, getLineRangeMapping } from 'vs/editor/common/diff/defaultLinesDiffComputer/defaultLinesDiffComputer'; </del> <ins> import { getLineRangeMapping } from 'vs/editor/common/diff/defaultLinesDiffComputer/defaultLinesDiffComputer'; </ins> import { OffsetRange } from 'vs/editor/common/core/offsetRange'; <ins> import { LinesSliceCharSequence } from 'vs/editor/common/diff/defaultLinesDiffComputer/linesSliceCharSequence'; </ins> suite('lineRangeMapping', () => { test('1', () => {
Change:
not sure if it a bug report or question, but I notcied that moved lines range is not correct: ! why it is written that lines are moved from 16-21? Shouldn't they be marked as "moved from 16-20"? The same question is about "moved to".
Verification steps: Notice that the line numbers are correct (click on compare with latest-dev).

Discussion:
'codeMovedToWithChanges', 'Code moved with changes to line {0}-{1}', this._move.lineRangeMapping.modified.startLineNumber, <del> this._move.lineRangeMapping.modified.endLineNumberExclusive </del> <ins> this._move.lineRangeMapping.modified.endLineNumberExclusive - 1, </ins> ) : localize( 'codeMovedFromWithChanges', 'Code moved with changes from line {0}-{1}', this._move.lineRangeMapping.original.startLineNumber, <del> this._move.lineRangeMapping.original.endLineNumberExclusive </del> <ins> this._move.lineRangeMapping.original.endLineNumberExclusive - 1, </ins> ); } else { text = this._kind === 'original' ? localize( 'codeMovedTo', 'Code moved to line {0}-{1}', this._move.lineRangeMapping.modified.startLineNumber, <del> this._move.lineRangeMapping.modified.endLineNumberExclusive </del> <ins> this._move.lineRangeMapping.modified.endLineNumberExclusive - 1, </ins> ) : localize( 'codeMovedFrom', 'Code moved from line {0}-{1}', this._move.lineRangeMapping.original.startLineNumber, <del> this._move.lineRangeMapping.original.endLineNumberExclusive </del> <ins> this._move.lineRangeMapping.original.endLineNumberExclusive - 1, </ins> ); }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.81.1 OS Version: any Steps to Reproduce: The code in does not handle DAP event This looks like a typo error.

Discussion:
case 'terminated': this._onDidTerminateDebugee.fire(<DebugProtocol.TerminatedEvent>event); break; <del> case 'exit': </del> <ins> case 'exited': </ins> this._onDidExitDebugee.fire(<DebugProtocol.ExitedEvent>event); break; case 'progressStart':
Change:
generate an answer tweak it press Send again (by accident) press Stop generating the Accept button is no longer visible !

Discussion:
this._ctxHasActiveRequest.set(false); this._zone.value.widget.updateProgress(false); this._zone.value.widget.updateInfo(''); <ins> this._zone.value.widget.updateToolbar(true); </ins> this._log('request took', sw.elapsed(), this._activeSession.provider.debugName); }

const renderedMarkdown = renderMarkdown(response.raw.message, { inline: true }); this._zone.value.widget.updateStatus(''); this._zone.value.widget.updateMarkdownMessage(renderedMarkdown.element); <del> this._zone.value.widget.updateToolbar(true); </del> const content = renderedMarkdown.element.textContent; if (content) { status = localize('markdownResponseMessage', "{0}", content);

} else if (response instanceof EditResponse) { // edit response -> complex... this._zone.value.widget.updateMarkdownMessage(undefined); <del> this._zone.value.widget.updateToolbar(true); </del> const canContinue = this._strategy.checkChanges(response); if (!canContinue) {
Change:
Build: Changes:
does the error ring a bell? Should we be running with ? Besides, many crash dumps again, such as:
Crashes are tracked in As for GPU initialization failure, it could be due to various reasons depending on the hardware. Need additional logging to identify the cause . I would suggest to disable gpu, since it is not worth addressing them for CI.

Discussion:
// this partition for shared memory. // Refs https://github.com/microsoft/vscode/issues/152143 args.push('--disable-dev-shm-usage'); <ins> // Refs https://github.com/microsoft/vscode/issues/192206 args.push('--disable-gpu'); </ins> } if (process.platform === 'darwin') {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: a breakpoint in a cell the cell the cell out of view the cell the run button is rendered, other than the stop button Digging into this a bit and I found that the context key service/update is correct, the problem is we receive an execution message from the extension host right after initializing the debug session so the cell execution state is instead of or . That's why when we re-render the cell, the run button is rendered.

Discussion:
getCellExecutionsByHandleForNotebook(notebook: URI): Map<number, INotebookCellExecution> | undefined { const exeMap = this._executions.get(notebook); <del> return exeMap ?? undefined; </del> <ins> return exeMap ? new Map(exeMap.entries()) : undefined; </ins> } private _onCellExecutionDidChange(notebookUri: URI, cellHandle: number, exe: CellExecution): void {
Change:
[x] Indicate when a document has commentable ranges Aria status when a document is opened [x] Add keyboard shortcut for adding a comment [x] Provide commands to go to next and previous commentable range [x] Add an accessible help menu to the comment widget Esc dismisses widget Lists go to next/previous commentable range commands + keyboard shortcuts Lists command and keyboard shortcut to add a comment Lists keyboard shortcut to execute the comment primary action and what the primary action is [x] The Comments view should respect the enter/space = reveal+focus/reveal [x] Make the comment widget toolbar always visible when in screen reader mode
Related to
is the last part of this, and it's almost done!
Mr.KITSANAPAN MEEKEAW

Discussion:
import { CommentThreadRangeDecorator } from 'vs/workbench/contrib/comments/browser/commentThreadRangeDecorator'; import { ICursorSelectionChangedEvent } from 'vs/editor/common/cursorEvents'; import { CommentsPanel } from 'vs/workbench/contrib/comments/browser/commentsView'; <ins> import { status } from 'vs/base/browser/ui/aria/aria'; </ins> export const ID = 'editor.contrib.review';

private _pendingEditsCache: { [key: string]: { [key: string]: { [key: number]: string } } }; // owner -> threadId -> uniqueIdInThread -> pending comment private _editorDisposables: IDisposable[] = []; private _activeCursorHasCommentingRange: IContextKey<boolean>; <ins> private _hasProvidedAriaStatus: boolean = false; </ins> constructor( editor: ICodeEditor,

} this.beginCompute(); })); <del> this.globalToDispose.add(this.commentService.onDidSetDataProvider(_ => this.beginCompute())); this.globalToDispose.add(this.commentService.onDidUpdateCommentingRanges(_ => this.beginCompute())); </del> <ins> this.globalToDispose.add(this.commentService.onDidSetDataProvider(_ => this.beginComputeAndProvideStatus())); this.globalToDispose.add(this.commentService.onDidUpdateCommentingRanges(_ => this.beginComputeAndProvideStatus())); </ins> this.globalToDispose.add(this.commentService.onDidSetResourceCommentInfos(e => { const editorURI = this.editor && this.editor.hasModel() && this.editor.getModel().uri;

return; } <ins> this._hasProvidedAriaStatus = false; </ins> this.localToDispose.add(this.editor.onMouseDown(e => this.onEditorMouseDown(e))); this.localToDispose.add(this.editor.onMouseUp(e => this.onEditorMouseUp(e))); if (this._editorDisposables.length) {

this._commentThreadRangeDecorator.update(this.editor, commentInfo); })); <del> this.beginCompute(); </del> <ins> this.beginComputeAndProvideStatus(); } private beginComputeAndProvideStatus(): void { this.beginCompute().then(() => { if (!this._hasProvidedAriaStatus && this._commentInfos.some(commentInfo => commentInfo.commentingRanges.ranges.length > 0 || commentInfo.commentingRanges.fileComments)) { this._hasProvidedAriaStatus = true; status(nls.localize('hasCommentRanges', "Editor has commenting ranges.")); } }); </ins> } private async openCommentsView(thread: languages.CommentThread) {
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The actions "Show Previous Change" and "Show Next Change" are pretty handy to jump to changed but not yet committed code locations in a file. It's not nicely usable with keyboard navigation only, because it does not set the cursor to that changed code block. It's necessary to click with the mouse to set the cursor there. IntelliJ has the same feature, but it directly sets the cursor which makes it much more helpful.
could you please take a look at this one? Thanks!
To verify: a diff the commands "Show Previous Change" and "Show Next Change" that your cursor is moved to the change.
]() This still does not set the cursor for the left side of the diff, only the right side for me.
My verification steps were incorrect: a file in a git repo some changes to the file the quick diff. Example: <img width="1562" alt="image" src=""the up and down arrows to show next and previous changes. Verify that the cursor gets placed just above the quick diff.
Verified with latest steps

Discussion:
if (usePosition) { this.show(position, height); } <ins> this.editor.setPosition(position); </ins> this.editor.focus(); }
Change:
Steps to Reproduce: I use the default build task in on a multi root workspace see a "2" appearing in the status bar, indicating the 2 runs (see pic [1]) reload the window is fine open 2 more terminals (see pic [2]) hide the panel reload window = there is no more a "2" in my status bar [1] ! ! [2] !
/duplicate
This is slightly different
and I have investigated this in the past. the panel will need to open for this to work

Discussion:
if (this._terminalService.getReconnectedTerminals('Task')?.length) { this._attemptTaskReconnection(); } else { <del> this._register(this._terminalService.onDidChangeConnectionState(() => { </del> <ins> this._register(this._terminalService.onDidChangeConnectionState(async () => { await this._terminalService.whenConnected; </ins> if (this._terminalService.getReconnectedTerminals('Task')?.length) { this._attemptTaskReconnection(); }
Change:
When running unit tests:
Similar problem in
This is not coming from those tests, the ugly part is these errors just report async. I found the following tests to be the underlying cause: The best is to run and add a breakpoint here:
I think I may have found a central fix...

Discussion:
private cache = new Map<string, string>(); <del> private readonly flushDelayer = new ThrottledDelayer<void>(Storage.DEFAULT_FLUSH_DELAY); </del> <ins> private readonly flushDelayer = this._register(new ThrottledDelayer<void>(Storage.DEFAULT_FLUSH_DELAY)); </ins> private pendingDeletes = new Set<string>(); private pendingInserts = new Map<string, string>();

isInMemory(): boolean { return this.options.hint === StorageHint.STORAGE_IN_MEMORY; } <del> override dispose(): void { this.flushDelayer.dispose(); super.dispose(); } </del> } export class InMemoryStorageDatabase implements IStorageDatabase {
Change:
This: Now results in 1/2 the minimum contrast requirements which is a soft accessibility issue. It seems like these messages are special vscode messages which use special formatting in the real terminal:

Discussion:
.test-output-peek-tree { color: var(--vscode-editor-foreground); <ins> border-left: 1px solid var(--vscode-panelSection-border); </ins> } .test-output-peek-tree .monaco-list-row .monaco-action-bar,

import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; import { TerminalCapability } from 'vs/platform/terminal/common/capabilities/capabilities'; import { TerminalCapabilityStore } from 'vs/platform/terminal/common/capabilities/terminalCapabilityStore'; <ins> import { formatMessageForTerminal } from 'vs/platform/terminal/common/terminalStrings'; </ins> import { IColorTheme, IThemeService } from 'vs/platform/theme/common/themeService'; import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace'; import { IViewPaneOptions, ViewPane } from 'vs/workbench/browser/parts/views/viewPane';

terminal.xterm.write(chunk.buffer, () => pendingWrites.value--); } } else { <ins> didWriteData = true; </ins> this.writeNotice(terminal, localize('runNoOutputForPast', 'Test output is only available for new test runs.')); }

} private writeNotice(terminal: IDetachedTerminalInstance, str: string) { <del> terminal.xterm.write(`x1b[2m${str}x1b[0m`); </del> <ins> terminal.xterm.write(formatMessageForTerminal(str)); </ins> } private attachTerminalToDom(terminal: IDetachedTerminalInstance) {
Change:
Type: <bBug</bThe VS Code update process appears to write to log files named . It appends a new line once every second as it waits for a running instance of VS Code to be closed. Here's a snippet from a current file on my machine: I basically always have VS Code running, and sometimes don't close it for weeks at a time, and just found that I had over 200MB of log files mostly filled with lines like the above. VS Code version: Code 1.81.1 (, 2023-08-09T22:22:42.175Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.82.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!

Discussion:
begin CreateMutex('{#AppMutex}-ready'); <ins> Log('Checking whether application is still running...'); </ins> while (CheckForMutexes('{#AppMutex}')) do begin <del> Log('Application is still running, waiting'); </del> Sleep(1000) end; <ins> Log('Application appears not to be running.'); </ins> StopTunnelServiceIfNeeded();
Change:
Type: <bBug from Marketplace which is a packaged version of fsprovider-sample Panel, switch to Output tab and choose Tasks channel. no folder or workspace open, run the command. the "Workspace folder was undefined" message. The message come from here: I think the task system is trying to do something (an onFolderOpen task?) for the memfs scheme before the task system for that scheme has been registered. As a minimum change I think the message should become "Task system for ${} is unavailable". Better, the message could be suppressed. Best, the sequencing could be revised so the task system registration for the FSP's scheme happens before it is first used. Further observation is that running does not produce the message again. VS Code version: Code 1.82.0 (, 2023-09-06T22:07:07.438Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
Note, this is not a new 1.82 problem. It also happened in 1.81.1.
I started looking at fixing this, but didn't find a path that calls for any schemes other than and . Should it also be getting called for schemes that s implement?
The "Workspace folder was undefined" message was introduced by Pinging and about what should happen for a scheme contributed by a FSP.
Scratch that - I believe I have answered my own question in the PR I just submitted.

Discussion:
} const taskSystemInfo: ITaskSystemInfo | undefined = this._getTaskSystemInfo(workspaceFolder.uri.scheme); const problemReporter = new ProblemReporter(this._outputChannel); <del> if (!taskSystemInfo) { problemReporter.fatal(nls.localize('TaskSystem.workspaceFolderError', 'Workspace folder was undefined')); return true; } </del> const parseResult = TaskConfig.parse(workspaceFolder, this._workspace, taskSystemInfo ? taskSystemInfo.platform : Platform.platform, config, problemReporter, source, this._contextKeyService, isRecentTask); let hasErrors = false; if (!parseResult.validationStatus.isOK() && (parseResult.validationStatus.state !== ValidationState.Info)) {