jiebi/CodeConvo huggingface dataset:
Change:
was broken for some time and I re-enabled it today. However eslint failures were reported in and and I disabled them. Please have a look and fix the corresponding errors.
- I'm not sure what that rule is - do you know if it's documented somewhere? Also, when I remove that comment and run locally, I don't see any failures.
Tyler helped me find it. I don't see lint warnings for this for some reason, even though I have the installled and enabled

Discussion:
{ "name": "vs/workbench/contrib/authentication", "project": "vscode-workbench" <ins> }, { "name": "vs/workbench/contrib/replNotebook", "project": "vscode-workbench" </ins> } ] }

import { Registry } from 'vs/platform/registry/common/platform'; import { EditorPaneDescriptor, IEditorPaneRegistry } from 'vs/workbench/browser/editor'; import { EditorExtensions, IEditorFactoryRegistry, IEditorSerializer, IUntypedEditorInput } from 'vs/workbench/common/editor'; <del> // is one contrib allowed to import from another? </del> import { parse } from 'vs/base/common/marshalling'; import { assertType } from 'vs/base/common/types'; import { URI } from 'vs/base/common/uri';

import { IWorkingCopyEditorHandler, IWorkingCopyEditorService } from 'vs/workbench/services/workingCopy/common/workingCopyEditorService'; import { extname, isEqual } from 'vs/base/common/resources'; import { INotebookService } from 'vs/workbench/contrib/notebook/common/notebookService'; <del> // eslint-disable-next-line local/code-translation-remind </del> import { localize2 } from 'vs/nls'; import { Action2, registerAction2 } from 'vs/platform/actions/common/actions'; import { IEditorResolverService, RegisteredEditorPriority } from 'vs/workbench/services/editor/common/editorResolverService';

*--------------------------------------------------------------------------------------------*/ import 'vs/css!./media/interactive'; <del> // eslint-disable-next-line local/code-translation-remind </del> import * as nls from 'vs/nls'; import * as DOM from 'vs/base/browser/dom'; import { CancellationToken } from 'vs/base/common/cancellation';
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled? Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.91.0.0 OS Version: Windows 10 build .4598 Steps to Reproduce: a header with a raw HTML element HTML is included in markdown header anchors ( is included!)
Note: links without the HTML tag work in editor mode only
This is for path completions, right? Seems to work fine for me ! Does this reproduce in the with all ?
I'm not referring to autocompletion, but what I mean is for the anchor links to work in preview mode (editor mode is fine) they have to include raw HTML tags I.e., the attribute values generated for headers include raw HTML tags I tested it in with all extensions disabled and same result, but still I will test it in insiders build
tested at (clean), same results

Discussion:
private _addNamedHeaders(md: MarkdownIt): void { const original = md.renderer.rules.heading_open; md.renderer.rules.heading_open = (tokens: Token[], idx: number, options, env, self) => { <del> const title = tokens[idx + 1].children!.reduce<string>((acc, t) => acc + t.content, ''); </del> <ins> const title = this._tokenToPlainText(tokens[idx + 1]); </ins> let slug = this.slugifier.fromHeading(title); if (this._slugCount.has(slug.value)) {

}; } <ins> private _tokenToPlainText(token: Token): string { if (token.children) { return token.children.map(x => this._tokenToPlainText(x)).join(''); } switch (token.type) { case 'text': case 'emoji': case 'code_inline': return token.content; default: return ''; } } </ins> private _addLinkRenderer(md: MarkdownIt): void { const original = md.renderer.rules.link_open;

default: return lang; } <del> } </del>  No newline at end of file <ins> } </ins>
Change:
Type: <bBug</b- Make a change to a file in a directory with Git setup Without staging it manually, write a commit message and press the commit button A popup will show up. Confirm that you'd like to stage all files. Observe how you get an error message and no changes get staged VS Code version: Code - Insiders 1.92.0-insider (, 2024-07-05T00:00:00.000Z) OS version: Darwin arm64 23.5.0 <details<summarySystem Info</summary </details<details<summaryExtensions (22) - also tested with all extensions disabled and same result</summaryExtensionVersion ------ ruff2024.30.0 gitlens15.1.0 copilot1.211.0 copilot-chat0.17.0 discord-vscode5.8.0 debugpy2024.7. python2024.11. vscode-pylance2024.6.104 jupyter2024.6.0 jupyter-keymap1.1.2 remote-containers0.377.0 remote-ssh0.113. remote-ssh-edit0.86.0 remote-wsl0.88.2 remote-explorer0.5. material-icon-theme5.4.2 run-on-save1.9.0 developer-theme-dark5.0.0 svelte-vscode108.5.4 highlight-matching-tag0.11.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.3.1 (3 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Thank you very much for reporting this issue. Fix should be available in tomorrow's VS Code Insiders release.

Discussion:
promptToSaveFilesBeforeCommit = 'never'; } <del> const enableSmartCommit = config.get<boolean>('enableSmartCommit') === true; </del> <ins> let enableSmartCommit = config.get<boolean>('enableSmartCommit') === true; </ins> const enableCommitSigning = config.get<boolean>('enableCommitSigning') === true; let noStagedChanges = repository.indexGroup.resourceStates.length === 0; let noUnstagedChanges = repository.workingTreeGroup.resourceStates.length === 0;

const pick = await window.showWarningMessage(message, { modal: true }, yes, always, never); if (pick === always) { <ins> enableSmartCommit = true; </ins> config.update('enableSmartCommit', true, true); } else if (pick === never) { config.update('suggestSmartCommit', false, true); return; <del> } else if (pick !== yes) { return; // do not commit on cancel </del> <ins> } else if (pick === yes) { enableSmartCommit = true; } else { // Cancel return; </ins> } }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.91.0 OS Version: WindowsNTx64 10.0. Steps to Reproduce: powershell 7.x external terminal by the terminal title showing Additional Info: this happens not only with powershell 7.x it may happen with all terminal which path contains space I found relate code: , the code converted to node command is the comment for said used to solve something, but now it cause showing,
To verify make sure you can still open a pwsh+cmd external terminal on Windows

Discussion:
const cmdArgs = ['/c', 'start', '/wait']; if (exec.indexOf(' ') >= 0) { // The "" argument is the window title. Without this, exec doesn't work when the path <del> // contains spaces cmdArgs.push('""'); </del> <ins> // contains spaces. #6590 // Title is Execution Path. #220129 cmdArgs.push(exec); </ins> } cmdArgs.push(exec); // Add starting directory parameter for Windows Terminal (see #90734)
Change:
Currently only the secondary sidebar has the close button. It should align with when the activity bar is at the top with the primary sidebar.
With the change that's about to land in 1.92 it's now less convenient for a right-side Activity Bar person like me to close the Secondary Side Bar that appears on the left when I use (for example) from a code editor context menu. Either I move my mouse all the way to the right-hand end of the window title and untoggle the relevant WCO button, or I go to the top menubar, choose View, then Appearance, then untoggle Secondary Side Bar there. Personally I think the opposite change would have been preferable, i.e. show an [X] button at the right-hand end of the Primary Side Bar's tabs when Activity Bar is at the top. This would make it consistent with Panel, which always has an [X] top-right.
My god, today I open vscode and I find that the X is not there, and I find that they took it out deliberately, not even a setting to toggle it
do you use the layout controls to hide and show the primary sidebar when the activity bar is at the top?
I know I can do that. In reality I tend to leave my right-positioned top-tabbed primary sidebar visible all the time. It's the secondary sidebar that I typically hide when I don't need it, e.g. after a References search caused it to appear. I didn't mind the inconsistency of there being an [X] on the secondary sidebar but not the primary.

Discussion:
return headerArea; } <del> protected override getToolbarWidth(): number { if (this.getCompositeBarPosition() === CompositeBarPosition.TOP) { return 22; } return super.getToolbarWidth(); } </del> private headerActionViewItemProvider(action: IAction, options: IActionViewItemOptions): IActionViewItem | undefined { if (action.id === ToggleAuxiliaryBarAction.ID) { return this.instantiationService.createInstance(ActionViewItem, undefined, action, options);

group: 'navigation', order: 2, when: ContextKeyExpr.notEquals(`config.${LayoutSettings.ACTIVITY_BAR_LOCATION}`, ActivityBarPosition.TOP) <del> }, { id: MenuId.AuxiliaryBarHeader, group: 'navigation', when: ContextKeyExpr.equals(`config.${LayoutSettings.ACTIVITY_BAR_LOCATION}`, ActivityBarPosition.TOP) </del> }] }); }
Change:
Notice the white hair lines between the list rows: ! It turns out that if the IconLabel has a description the height of the row is instead of .

Discussion:
line-height: 22px; } <ins> .scm-view .monaco-list-row .monaco-icon-label-container { height: 22px; } </ins> .scm-view .monaco-list-row .history, .scm-view .monaco-list-row .history-item-group, .scm-view .monaco-list-row .resource-group {
Change:
Type: <bBug</bstep 1 - Run any command or project whose lines does'nt fit in single line step 2 - Your terminal can be full sized or small size does'nt matter step 3- Presss Alt + z to wrap line in terminal Step 4 - Resize your terminal window Example - If initially terminal window height is 100px from the bottom then word wrap using Alt + z and after that increase or discrease the size of terminal window. You will find that content is still showing in 100px of height VS Code version: Code 1.91.0 (, 2024-07-01T18:52:41.959Z) OS version: Linux x64 5.15.0-113-generic Modes: <!-- generated by issue reporter --
!
Thanks for fixing the issue One more questions Is there any way to off wrap word in terminal parmanent. I have to use Alt + z each time when I run my project
there is not
Can you make it happen like Eclipse Please
i haven't seen it in eclipse but I'm guessing they're using the old console api on windows which isn't really compatible with the pty based system that we use.
Works, but I never see a horizontal scrollbar with word wrap disabled, should I expect to? I see it in the screenshot above.

Discussion:
this._wrapperElement.classList.add('fixed-dims'); this._hasScrollBar = true; this._initDimensions(); <del> // Always remove a row to make room for the scroll bar this._fixedRows = this._rows - 1; </del> await this._resize(); this._terminalHasFixedWidth.set(true); if (!this._horizontalScrollbar) {
Change:
This was unexpected for me where I open a file (not focus the editor) and the light bulb shows up randomly depending on where the cursor happened to have been restored: !
cc

Discussion:
return this.hide(); } <ins> const hasTextFocus = this._editor.hasTextFocus(); if (!hasTextFocus) { this.gutterHide(); return this.hide(); } </ins> const options = this._editor.getOptions(); if (!options.get(EditorOption.lightbulb).enabled) { this.gutterHide();

return lineNumber > 2 && this._editor.getTopForLineNumber(lineNumber) === this._editor.getTopForLineNumber(lineNumber - 1); }; <ins> // Check for glyph margin decorations of any kind const currLineDecorations = this._editor.getLineDecorations(lineNumber); let hasDecoration = false; if (currLineDecorations) { for (const decoration of currLineDecorations) { if (decoration.options.glyphMarginClassName) { hasDecoration = true; break; } } } </ins> let effectiveLineNumber = lineNumber; let effectiveColumnNumber = 1; if (!lineHasSpace) {

const currLineEmptyOrIndented = isLineEmptyOrIndented(lineNumber); const notEmpty = !nextLineEmptyOrIndented && !prevLineEmptyOrIndented; <del> const currLineDecorations = this._editor.getLineDecorations(lineNumber); const hasDecoration = !!(currLineDecorations?.length); </del> // check above and below. if both are blocked, display lightbulb in the gutter. if (!nextLineEmptyOrIndented && !prevLineEmptyOrIndented && !hasDecoration) {

position: { lineNumber: effectiveLineNumber, column: effectiveColumnNumber }, preference: LightBulbWidget._posPref }); <del> this.renderGutterLightbub(); return this.hide(); </del> <ins> if (hasDecoration) { this.gutterHide(); } else { this.renderGutterLightbub(); return this.hide(); } </ins> } else if ((lineNumber < model.getLineCount()) && !isFolded(lineNumber + 1)) { effectiveLineNumber += 1; } else if (column * fontInfo.spaceWidth < 22) {
Change:
Type: <bBug</bThe issue shows up if I have a custom PS1 prompt that looks at the exit code of the previous command (using ). Here's a minimal configuration in the .bashrc file on my remote Linux host: Expected results: When I run in a terminal outside vscode or disable automatic script injection in the integrated terminal, I get this: Actual results: when I enable integrated terminal shell injection, I instead see this output running the same commands: That is, the exit code is now always 0. I tried manually injecting the scripts using the command from ; no change in behavior. Looking at the script that gets loaded (.../server/out/vs/workbench/contrib/terminal/browser/media/shellIntegration-), I see these lines: As an experiment, I tried moving the call later and opening a new terminal, which fixed the issue for me: So it looks like the step that clobbers the exit code is the step. Remote OS: RHEL 8.10, bash 4.4.20 VS Code version: Code 1.91.0 (, 2024-07-01T18:52:22.949Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 4.18.0-553.5.1.el810.x8664 Remote OS version: Linux x64 4.18.0-553.5.1.el810.x8664 Remote OS version: Linux x64 4.18.0-553.5.1.el810.x86_64 <details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
In VS Code version 1.92.0, I still see this issue. In this version I now see that the method calls instead of just , but running this after the function still clobbers out the return code to zero. says this about running :

Discussion:
__vsc_prompt_cmd_original() { __vsc_status="$?" <ins> builtin local cmd </ins> __vsc_restore_exit_code "${__vsc_status}" # Evaluate the original PROMPT_COMMAND similarly to how bash would normally # See https://unix.stackexchange.com/a/672843 for technique <del> builtin local cmd </del> for cmd in "${__vsc_original_prompt_command[@]}"; do eval "${cmd:-}" done
Change:
I notice on the latest insiders now when I start and stop debugging the breakpoints are ending up below the line numbers instead of the gutter !
this CSS rule applies to all glyph margin widgets, maybe you want to scope it more specifically for the lightbulb widget? This is overriding what was the for glyph margin widgets.

Discussion:
} /* gutter decoration */ <del> .monaco-editor .glyph-margin-widgets .cgmr { </del> <ins> .monaco-editor .glyph-margin-widgets .cgmr[class*="codicon-gutter-lightbulb"] { </ins> display: block; cursor: pointer; <del> opacity: 1; transition: opacity .2s ease-in-out; </del> } .monaco-editor .glyph-margin-widgets .cgmr.codicon-gutter-lightbulb,
Change:
Type: <bBug</bAfter updating for this new version, the Source Control tab is not showing the badge even with the option "Show badge" activated. VS Code version: Code 1.91.0 (Universal) (, 2024-07-01T18:54:18.541Z) OS version: Darwin arm64 23.4.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (16)</summaryExtensionVersion ------ flutter-snippets3.0.0 dart-code3.92.0 flutter3.92.0 flutter-find-unused-assets-and-dart-files1.0.2 bloc6.6.6 flutter-coverage0.0.4 kotlin0.2.34 copilot1.212.0 copilot-chat0.17.1 todo-tree0.0.226 live-server0.4.14 material-icon-theme5.4.2 vscode-coverage-gutters2.11.1 lcov-lang1.0.1 vscode-conventional-commits1.25.0 vscode-icons12.8.0 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.91.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
I've updated to latest version because of the fix and the problem persists. !
thank you very much for reporting this issue. Fix will be available in Insiders and in the next Stable release.

Discussion:
switch (this._countBadgeConfig.read(reader)) { case 'all': { const repositories = this._repositories.read(reader); <del> return [...Iterable.map(repositories, r => ({ ...r.provider, resourceCount: this._getRepositoryResourceCount(r) }))]; </del> <ins> return [...Iterable.map(repositories, r => ({ provider: r.provider, resourceCount: this._getRepositoryResourceCount(r) }))]; </ins> } case 'focused': { const repository = this._activeRepository.read(reader); <del> return repository ? [{ ...repository.provider, resourceCount: this._getRepositoryResourceCount(repository) }] : []; </del> <ins> return repository ? [{ provider: repository.provider, resourceCount: this._getRepositoryResourceCount(repository) }] : []; </ins> } case 'off': return [];

let total = 0; for (const repository of this._countBadgeRepositories.read(reader)) { <del> const count = repository.count?.read(reader); </del> <ins> const count = repository.provider.count?.read(reader); </ins> const resourceCount = repository.resourceCount.read(reader); total = total + (count ?? resourceCount);
Change:
A11yWCAG2.1; #A11yTCS; #A11ySev4; #Visual Studio Code Client; #BMVisual Studio Code ClientMAC_JULY2024; #DesktopApp; #WCAG4.1.3; #FTP; #A11yMAS; #Status Message; #MAC; #Device; #Voiceover; #A11yUsable; MAC Book Pro MAC OS Sonoma Version 14.5 Visual Studio code Insider version 1.92.0 Visual Studio Code Insiders editor Navigate to setting icon. "Keyboard shortcuts options" and press enter or Press keyboard shortcut as command K, Command S shortcut table gets opened. till "Keyboard Shortcut Edit field". any Text or Key and Observe that Voiceover is not announcing Number of suggestions were found while searching any key in "keyboard shortcut edit field". Voiceover is not announcing Number of suggestions were found while searching any key in "keyboard shortcut edit field". Voiceover should be announcing Number of suggestions were found while searching any key in "keyboard shortcut edit field". Screen reader users will face difficulty if Voiceover is not announcing Number of suggestions were found while searching any key in "keyboard shortcut edit field".
do you know if we have ever had support for this?
Rev:poojanamde;
Decreasing to Sev4 according to Review of Indu Priya Setty. Thanks!!

Discussion:
import { IEditorGroup } from 'vs/workbench/services/editor/common/editorGroupsService'; import type { IManagedHover } from 'vs/base/browser/ui/hover/hover'; import { IHoverService } from 'vs/platform/hover/browser/hover'; <ins> import { IAccessibilityService } from 'vs/platform/accessibility/common/accessibility'; </ins> const $ = DOM.$;

@IInstantiationService private readonly instantiationService: IInstantiationService, @IEditorService private readonly editorService: IEditorService, @IStorageService storageService: IStorageService, <del> @IConfigurationService private readonly configurationService: IConfigurationService </del> <ins> @IConfigurationService private readonly configurationService: IConfigurationService, @IAccessibilityService private readonly accessibilityService: IAccessibilityService </ins> ) { super(KeybindingsEditor.ID, group, telemetryService, themeService, storageService); this.delayedFiltering = new Delayer<void>(300);

if (this.keybindingsEditorModel) { const filter = this.searchWidget.getValue(); const keybindingsEntries: IKeybindingItemEntry[] = this.keybindingsEditorModel.fetch(filter, this.sortByPrecedenceAction.checked); <ins> this.accessibilityService.alert(localize('foundResults', "{0} results", keybindingsEntries.length)); </ins> this.ariaLabelElement.setAttribute('aria-label', this.getAriaLabel(keybindingsEntries)); if (keybindingsEntries.length === 0) {