jiebi/CodeConvo huggingface dataset:
Change:
VSCode Version: 1.26.0 OS Version: macOS Steps to Reproduce: in command line. Code seems opened a workspace of current directory folder, like Does this issue occur when all extensions are disabled?: Yes When I run some command like (e.g. in Linux), if the inner command failed, it return empty string as argument. VSCode shouldn't open current directory and replace the workspace (which is annoying), but should just open or focus the application instead.
Note: Neither Notepad++ or Sublime Text will open a folder wrongly with empty string argument.
what would you expect to happen, open an empty window?
Yes. Or focus existing window only. Just like running .
Wrong press "close"
Can I be assigned to this? I'd like to take a stab at it.
I've code that should do the trick. I've tested that it removes an empty argument. I wasn't able to test the actual functionality though because both and change the current directory. I couldn't figure out how to mimic production without hacking the startup scripts.
I just edited the main description to add an example usage - - which open a script file in environment PATH by VS Code to edit it. If the argument "$1" (for the script name) have typo, VS Code open a big slow workspace folder annoyingly. The existing behavior has no use, and it put the burden to user to write extra lines of if-else to avoid it, resulting in a big command & more typings.

Discussion:
"type": "node", "request": "launch", "name": "Launch VS Code (Main Process)", <del> "runtimeExecutable": "${workspaceFolder}/scripts/code.sh", </del> <ins> "windows": { "runtimeExecutable": "${workspaceFolder}/scripts/code.bat" }, "osx": { "runtimeExecutable": "${workspaceFolder}/scripts/code.sh" }, "linux": { "runtimeExecutable": "${workspaceFolder}/scripts/code.sh" }, </ins> "runtimeArgs": [ <del> "--no-cached-data" </del> <ins> "", "--no-cached-data" </ins> ], "smartStep": true, "outFiles": [ "${workspaceFolder}/out/**/*.js" <del> ] </del> <ins> ] </ins> }, { "type": "node",

return args; } <ins> function stripEmptyPath(argv: string[]): string[] | undefined { const index = firstIndex(argv, a => !/^-/.test(a)); if (index > -1 && argv[index] === '') { argv.splice(index, 1); } return argv; } </ins> function stripAppPath(argv: string[]): string[] | undefined { const index = firstIndex(argv, a => !/^-/.test(a));

args = stripAppPath(args) || []; } <ins> // Ignore empty path arg stripEmptyPath(args); </ins> return validate(parseArgs(args)); }
Change:
Issue Type: <bBug</bWhe connected to a version control repo, differences are visible as a green/yellow/red colored indicator next to the line number. Clicking the colored indicator opens the inline diff viewer that still shows the indicator as you could recursively open diff viewers. Screenshot: ! VS Code version: Code - Insiders 1.28.0-insider (, 2018-09-07T05:20:29.346Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (2)</summaryExtensionVersion ------ Ionide-fsharp3.25.4 svn-scm1.34.0 </details<!-- generated by issue reporter --

Discussion:
bottom: 0; border-top-width: 0; border-bottom-width: 0; <ins> } .monaco-editor.modified-in-monaco-diff-editor .margin-view-overlays > div > .dirty-diff-glyph { display: none; </ins> }  No newline at end of file
Change:
VSCode Version: 1.27.1 OS Version: Windows 10 (Build ) Steps to Reproduce: a simple (build) task setting presentation.showReuseMessage to false the task a blank line where the reuse message used to show up, instead of no extra line displayed at all Does this issue occur when all extensions are disabled?: Yes I was expecting this setting to reduce the overall lines printed by running the task, but all it does is prints an empty line instead of removing the line completely.
Able to reproduce.
I currently set . I can't simply set it to false since this would close the terminal. Any advice how to avoid the blank line?
I guess you want to pass in and handle it here:
OK. I will change the code as follows: if waitOnExit is a boolean honor it and never print a message if it is a string wait and print the provided message. Is this OK for you ?

Discussion:
} else if (task.command.presentation.showReuseMessage) { waitOnExit = nls.localize('reuseTerminal', 'Terminal will be reused by tasks, press any key to close it.'); } else { <del> waitOnExit = 'u200B'; </del> <ins> waitOnExit = true; </ins> } } let shellLaunchConfig: IShellLaunchConfig | undefined = undefined;

if (exitCode) { this._xterm.writeln(exitCodeMessage); } <del> let message = typeof this._shellLaunchConfig.waitOnExit === 'string' ? this._shellLaunchConfig.waitOnExit : nls.localize('terminal.integrated.waitOnExit', 'Press any key to close the terminal'); // Bold the message and add an extra new line to make it stand out from the rest of the output message = `nx1b[1m${message}x1b[0m`; this._xterm.writeln(message); </del> <ins> if (typeof this._shellLaunchConfig.waitOnExit === 'string') { let message = this._shellLaunchConfig.waitOnExit; // Bold the message and add an extra new line to make it stand out from the rest of the output message = `nx1b[1m${message}x1b[0m`; this._xterm.writeln(message); } </ins> // Disable all input if the terminal is exiting and listen for next keypress this._xterm.setOption('disableStdin', true); if (this._xterm.textarea) {
Change:
VSCode Version: 1.27.1 OS Version: Windows 10 Build: 1607 Steps to Reproduce: to launch VSCode (Portable or Other) on a computer with blocked. Fix: The issue is resolved by killing the process spawned at start. After doing this one the issue appears to go away. Does this issue occur when all extensions are disabled?: Yes
What do you mean by " blocked"?
Sorry should have been more descriptive. What I mean by " blocked" is when access to is restricted by an administrator. For context I am trying to get vscode working on laptops at my school at which they restrict access to
What if you download the ZIP installer and simply double click
Running from the zip results in the same hang
Can you confirm that is spawned when you double click that zip? Can you figure out any more details?
It is difficult to gather any more information as this issue is because we have no administrative rights on the computer. If there is any information I can provide without admin privileges however feel free to ask for it. Update: is not spawned when the zip is double clicked it is spawned post extraction upon running
Did some additional digging. Here is a screenshot of the the process spawned: It appears to be trying to get the MAC Address.
the getmac npm package we use calls getmac by opening as indicated by I've created an upstream issue to pass when spawning getmac to avoid creation. For now we can timeout the call in the event that getmac isn't responding

Discussion:
resolve(undefined); } }); <ins> // Timeout due to hang with reduced privileges #58392 // TODO@sbatten: Remove this when getmac is patched setTimeout(() => { resolve(undefined); }, 1000); </ins> } catch (err) { errors.onUnexpectedError(err); resolve(undefined);
Change:
Repro: Open DevTools: !
This started occurring recently due to It is now possible to get this warning from various parts of the product.
Yes. That's on purpose and the goal is to get rid of invalid URIs in our system. So, when your code causes such warnings, you need to change it ;-). I can consult. The background is that an URI must have a scheme but we never enforced that. The warning I have is the first step into that direction.
The warning is valid. We're passing a path to , which is wrong. Git remote addresses are not always uris, they can be paths; even relative paths.
So the consumers of should beforehand check if what they are passing is valid uri or not? Doesnt that fail the purpose of ? is used to parse json content. We can pass non json to it as well. It throws an error. Can we not expect something similar from ? If we are worried that throwing errors will break existing code, then can we have a stricter that we can use?
Yes, parse will throw an error but it never used to do that for missing scheme. I didn't think it's a good idea to now start throwing errors at first because not everyone encloses in a try catch block and also often people confuse and .

Discussion:
let match = url.match(SshProtocolMatcher); if (match) { return stripLowLevelDomains(match[2]); <ins> } else { return null; </ins> } } try {
Change:
Problem The time you search for the branch and not find any, there are no other options to proceed. <img width="682" alt="screen shot 2018-09-15 at 11 06 09" src="https://user-"I as a developer would need to delete the search and then click on "create a new branch". Solution Keep "create a new branch" option always. <img width="656" alt="screen shot 2018-09-15 at 11 22 56" src="https://user-"
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.617 --- <!-- score: 0.587 --- <!-- score: 0.552 --- <!-- score: 0.547 --- <!-- score: 0.529 --<!-- potentialduplicatescomment --
Is this supported from an extension? Eg: keep an option always visible.
Dang, just noticed that you already submitted a PR to address this. Closed my PR, feel free to grab the integration test I if you want
since my PR is merged already, feel free to create a PR with tests :)
I a PR to add tests and also fix a small bug (when explicitly settings items on a the field was not properly propagated). Additional thoughts I had (should open another issue for discussion?): In my opinion, items that should always be shown shouldn't display search highlights. The highlights are possibly redundant and IMO it would look more elegant without I feel like after accepting the option, the input text should be preserved. Would a PR to address this be accepted? Also, possibly should this behavior be exposed for user control? (i.e. similarly to a field, a field.)
:+1: Nah, sounds like a very good default value.

Discussion:
get label(): string { return localize('create branch', '$(plus) Create new branch'); } get description(): string { return ''; } <ins> get shouldAlwaysShow(): boolean { return true; } </ins> async run(repository: Repository): Promise<void> { await this.cc.branch(repository); }

detail?: string; /** <ins> * Show this item always */ shouldAlwaysShow?: boolean; /** </ins> * Optional flag indicating if this item is picked initially. * (Only honored when the picker allows multiple selections.) *

* in arbitrary order and the initial debug configuration is piped through the chain. * Returning the value 'undefined' prevents the debug session from starting. * Returning the value 'null' prevents the debug session from starting and opens the underlying debug configuration instead. <del> * </del> <ins> * </ins> * @param folder The workspace folder from which the configuration originates from or undefined for a folderless setup. * @param debugConfiguration The [debug configuration](#DebugConfiguration) to resolve. * @param token A cancellation token.

let description: string; let detail: string; let picked: boolean; <ins> let alwaysShow: boolean; </ins> if (typeof item === 'string') { label = item;

description = item.description; detail = item.detail; picked = item.picked; <ins> alwaysShow = item.shouldAlwaysShow; </ins> } pickItems.push({ label, description, handle, detail, <del> picked </del> <ins> picked, alwaysShow </ins> }); }
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: ! OS Version: win7 pro Steps to Reproduce: the create branch ! a brunch ! a result, the wrong brunch was created !
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.488 --- <!-- score: 0.454 --- <!-- score: 0.45 --- <!-- score: 0.448 --<!-- potentialduplicatescomment --

Discussion:
return name; } <del> return name.replace(/^.|/.|..|~|^|:|/$|.lock$|.lock/||*|s|^s*$|.|[|]$/g, branchWhitespaceChar); </del> <ins> return name.replace(/^.|/.|..|~|^|:|/$|.lock$|.lock/||*|s|^s*$|.$|[|]$/g, branchWhitespaceChar); </ins> }; const result = await window.showInputBox({
Change:
Issue Type: <bBug</bI think this change appeared in VS Code Insiders couple builds ago. New background for dropdowns in title menu bar and context menus ( is set to ) now have brighter background, which has to much contrast with editor background and makes it harder to read text on it. Also it appears much brighter than backgrounds for auto-suggestions dropdown and peek view. Is it intended change in Dark+ color theme or is it possible to revert it back to the same color as in current stable version (1.27)? Insider (left) and stable (right) ! VS Code version: Code - Insiders 1.28.0-insider (, 2018-09-19T09:34:25.276Z) OS version: Windows_NT x64 10.0. Issue is reproducible without extensions. <details<summaryExtensions (26)</summaryExtensionVersion ------ markdown-toc1.5.6 vscode-css-modules1.0.1 spellright2.5.32 markdown-preview-github-styles0.1.3 vscode-css-modules0.2.3 bracket-pair-colorizer1.0.60 vscode-eslint1.6.0 gitlens8.5.6 remotehub0.2.0 EditorConfig0.12.4 tslint1.0.39 vscode-pull-request-github0.1.5 beautify1.4.3 rest-client0.19.1 code-fragments1.2.0 vsliveshare0.3.709 debugger-for-chrome4.10.1 debugger-for-edge1.0.5 vscode-docker0.2.0 material-icon-theme3.6.0 quicktype12.0.42 gi0.2.11 code-settings-sync3.1.2 dot0.0.1 quokka-vscode1.0.149 markdown-pdf1.2.0 </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.459 --<!-- potentialduplicatescomment --

Discussion:
"sideBarTitle.foreground": "#BBBBBB", "input.placeholderForeground": "#A6A6A6", "settings.textInputBackground": "#292929", <del> "settings.numberInputBackground": "#292929" </del> <ins> "settings.numberInputBackground": "#292929", "menu.background": "#252526", "menu.foreground": "#CCCCCC" </ins> } }  No newline at end of file

"activityBar.background": "#221a0f", "activityBar.foreground": "#d3af86", "sideBar.background": "#362712", <ins> "menu.background": "#362712", "menu.foreground": "#CCCCCC", </ins> "editor.lineHighlightBackground": "#5e452b", "editorCursor.foreground": "#d3af86", "editorWhitespace.foreground": "#a57a4c",

"activityBarBadge.background": "#3655b5", "sideBar.background": "#272727", "sideBarSectionHeader.background": "#505050", <ins> "menu.background": "#272727", "menu.foreground": "#CCCCCC", </ins> "pickerGroup.foreground": "#b0b0b0", "terminal.ansiWhite": "#ffffff", "inputOption.activeBorder": "#3655b5",

"activityBar.dropBackground": "#414339", "sideBar.background": "#1e1f1c", "sideBarSectionHeader.background": "#272822", <ins> "menu.background": "#1e1f1c", "menu.foreground": "#cccccc", </ins> "pickerGroup.foreground": "#75715E", "input.background": "#414339", "inputOption.activeBorder": "#75715E",
Change:
Separator after single entry (No Configurations) should not appear If no objections, I will PR. !

Discussion:
if (this.options.length === 0) { this.options.push({ label: nls.localize('noConfigurations', "No Configurations"), handler: () => false }); <ins> } else { this.options.push({ label: StartDebugActionItem.SEPARATOR, handler: undefined }); </ins> } <del> this.options.push({ label: StartDebugActionItem.SEPARATOR, handler: undefined }); </del> const disabledIdx = this.options.length - 1; launches.filter(l => !l.hidden).forEach(l => {
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --When dark mode is enabled on macOS the native tabs should be dark. i.e. maps app <img width="1002" alt="screen shot 2018-09-24 at 10 51 06 pm" src="https://user-"Instead of this <img width="1213" alt="screen shot 2018-09-24 at 10 50 05 pm" src="https://user-"
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.501 --- <!-- score: 0.485 --<!-- potentialduplicatescomment --
please also report this to
There is a open PR for adding dark mode support
I am not sure that PR fixes all of the issues, I have asked the developer.
You should be able to test this out on the latest nightly
Via

Discussion:
name: product.nameLong, urlSchemes: [product.urlProtocol] }], <ins> darwinForceDarkModeSupport: true, </ins> darwinCredits: darwinCreditsTemplate ? Buffer.from(darwinCreditsTemplate({ commit: commit, date: new Date().toISOString() })) : void 0, linuxExecutableName: product.applicationName, winIcon: 'resources/win32/code.ico',
Change:
re Keep pressing the split button At one point the warning shows I think we can do better than that... Why don't we disable the action instead of showing the warning? Also, why is this a warning and not an information message? <img width="618" alt="screen shot 2018-09-25 at 11 10 18" src="https://user-"
Yeah also found this a bit weird. Fyi we do not prevent splitting of editors in the grid widget and have not heard complaints so far. So I am not sure why we need it here (cc
We had one complaint about infinite splitting which is why I this. I agree that behavior should generally be consistent between editor and terminal for splitting but at the same time allowing the user to put their terminal into a broken state isn't great either. I was concerned that simply disabling the split operation wouldn't make why it's disabled clear, but it is more intrusive than just disabling it! This issue has already gotten more thumbs ups than the original (), so clearly something needs to be done let me know what you think!
I think disabling the split action when we think it should be prevented is the best solution.
I guess we could watch for when the panel resizes and disable/enable if there's room.
I've created PR for changing the warn to info. The disable/enable for split is more complicated so it would be better to do during the next milestone. Issue tracks that!

Discussion:
} protected _showNotEnoughSpaceToast(): void { <del> this._notificationService.warn(nls.localize('terminal.minWidth', "Not enough space to split terminal.")); </del> <ins> this._notificationService.info(nls.localize('terminal.minWidth', "Not enough space to split terminal.")); </ins> } public setContainers(panelContainer: HTMLElement, terminalContainer: HTMLElement): void {
Change:
Issue Type: <bBug</bThe arguments of my task command are merely ignored whenever there are quotes inside them. Steps to reproduce an executable script that shows the number of arguments that are passed to it. I called it some task in the task the output Even the hello argument is ignored. Remove the quotes around world and the script will work: This bug makes the task feature unusable when quotes are required VS Code version: Code - Insiders 1.28.0-insider (, 2018-09-25T05:31:33.193Z) OS version: WindowsNT x64 10.0. <!-- generated by issue reporter --
which shell (bash) are you using? WSL?
if the default task shell is the same as the default integrated terminal shell, then I am using Git Bash. I have this in
I am able to reproduce this using the following setup: Using ' around world works as expected. here is the shell launch config I use to start the terminal: <img width="1190" alt="capture" src="https://user-"Any advice you can give to make this work for " as quotes. In general the data looks good to me.
recently made a change in this area and might have an idea what's going on with this case.
Possible candidate, marking with September.

Discussion:
"native-is-elevated": "^0.2.1", "native-keymap": "1.2.5", "native-watchdog": "1.0.0", <del> "node-pty": "0.7.7", </del> <ins> "node-pty": "0.7.8", </ins> "semver": "^5.5.0", "spdlog": "0.7.2", "sudo-prompt": "8.2.0",

semver "^5.3.0" tar "^4" <del> node-pty@0.7.7: version "0.7.7" resolved "https://registry.yarnpkg.com/node-pty/-/node-pty-0.7.7.tgz#919a9de7f0462ee72b260a6e4d5459d28fde2d25" </del> <ins> node-pty@0.7.8: version "0.7.8" resolved "https://registry.yarnpkg.com/node-pty/-/node-pty-0.7.8.tgz#9ed2f01f84263acc96982876e734aa75490bf3d8" </ins> dependencies: nan "2.10.0"
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.27.2(lang:ja), 1.28(insider, lang:en) OS Version: Windows, Mac Steps to Reproduce: this code in extension ! ! Result: The display of octicon will be broken and the wrong place will be selected and displayed. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No( this problem is at api for extensions )
I have encountered this problem with .
I am quite sure I fixed this a while back for normal quick open, maybe it is a regression from the new quick input widget?
My change was:

Discussion:
// Map matches back to offsets with octicons and trimming if (matches) { for (let i = 0; i < matches.length; i++) { <del> const octiconOffset = octiconOffsets[matches[i].start] /* octicon offsets at index */ + leadingWhitespaceOffset /* overall leading whitespace offset */; </del> <ins> const octiconOffset = octiconOffsets[matches[i].start + leadingWhitespaceOffset] /* octicon offsets at index */ + leadingWhitespaceOffset /* overall leading whitespace offset */; </ins> matches[i].start += octiconOffset; matches[i].end += octiconOffset; }

filterOk(matchesFuzzyOcticonAware, 'indent', parseOcticons('This $octicon Indent Using Spaces'), [ { start: 14, end: 20 }, ]); <ins> // Testing #59343 filterOk(matchesFuzzyOcticonAware, 'unt', parseOcticons('$(primitive-dot) $(file-text) Untitled-1'), [ { start: 30, end: 33 }, ]); </ins> }); });
Change:
We can add the same regex validator for the terminal find widget input box if the underling regex engine is JavaScript regex. Close this one if we are using another regex engine somehow in
So in the terminal widget show things like this and reject the search? <img width="238" alt="screen shot 2018-10-11 at 11 58 06 am" src="https://user-"
I would like to try and work on this feature. Could someone tell me where to start working on this feature?
the terminal find widget code is here: It extends the SimpleFindWidget: Not sure where the validator is but I'd look around the and files.

Discussion:
appendWholeWordsLabel: this._keybindingLabelFor(FIND_IDS.ToggleWholeWordCommand), appendRegexLabel: this._keybindingLabelFor(FIND_IDS.ToggleRegexCommand), validation: (value: string): InputBoxMessage | null => { <del> if (value.length === 0) { return null; } if (!this._findInput.getRegex()) { </del> <ins> if (value.length === 0 || !this._findInput.getRegex()) { </ins> return null; } try { <del> /* tslint:disable:no-unused-expression */ </del> <ins> /* tslint:disable-next-line:no-unused-expression */ </ins> new RegExp(value); <del> /* tslint:enable:no-unused-expression */ </del> return null; } catch (e) { return { content: e.message };

import { Delayer } from 'vs/base/common/async'; import { KeyCode, KeyMod } from 'vs/base/common/keyCodes'; import { FindReplaceState } from 'vs/editor/contrib/find/findState'; <ins> import { IMessage as InputBoxMessage } from 'vs/base/browser/ui/inputbox/inputBox'; </ins> import { SimpleButton } from 'vs/editor/contrib/find/findWidget'; import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { IContextViewService } from 'vs/platform/contextview/browser/contextView';

this._findInput = this._register(new ContextScopedFindInput(null, this._contextViewService, { label: NLS_FIND_INPUT_LABEL, placeholder: NLS_FIND_INPUT_", <ins> validation: (value: string): InputBoxMessage | null => { if (value.length === 0 || !this._findInput.getRegex()) { return null; } try { /* tslint:disable-next-line:no-unused-expression */ new RegExp(value); return null; } catch (e) { return { content: e.message }; } } </ins> }, contextKeyService, showOptionButtons)); // Find History with update delayer