jiebi/CodeConvo huggingface dataset:
Change:
Related to a folder with in name a file to it it ! It will duplicate itself: !
Forgot to update the method in :man_facepalming:
Verification: Follow steps in first comment.

Discussion:
delete(uri: URI): T | undefined { const key = relativePath(this.root.uri, uri) || uri.fsPath; <del> const parts = key.split(/[/]/).filter(p => !!p); return this._delete(this.root, parts, 0); </del> <ins> const iterator = new PathIterator(false).reset(key); return this._delete(this.root, iterator); </ins> } <del> private _delete(node: BranchNode<T, C>, parts: string[], index: number): T | undefined { const name = parts[index]; </del> <ins> private _delete(node: BranchNode<T, C>, iterator: PathIterator): T | undefined { const name = iterator.value(); </ins> const child = node.get(name); if (!child) {

} // not at end <del> if (index < parts.length - 1) { </del> <ins> if (iterator.hasNext()) { </ins> if (child instanceof BranchNode) { <del> const result = this._delete(child, parts, index + 1); </del> <ins> const result = this._delete(child, iterator.next()); </ins> if (typeof result !== 'undefined' && child.size === 0) { node.delete(name);
Change:
In Markdown preview with light theme, numbers in code blocks are not clearly distinguishable because of their color. It will be good if a different color can be switched in light theme mode ! It seems that in , the following part may add a switch. Thank you!
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.474 --- <!-- score: 0.457 --- <!-- score: 0.456 --- <!-- score: 0.451 --<!-- potentialduplicatescomment --
Please share the text of the code along with screenshots
Actually, code itself does't matter this issue. It influences on many kinds of code with numbers.
Hey, I am a new contributor here. I want to give a try on this issue.

Discussion:
*/ .vscode-light .hljs-function, <del> .vscode-light .hljs-params { </del> <ins> .vscode-light .hljs-params, .vscode-light .hljs-number, .vscode-light .hljs-class  { </ins> color: inherit; }
Change:
For details pls see I've updated the of insider/stable to define the extension as a UI extension Candidate since the bracket pair colorizer is a popular extension and we should also enable users that use the V2 version.
I also previously pinged the extension about fixing this:

Discussion:
{ "name": "code-oss-dev", "version": "1.39.0", <del> "distro": "31c935c255c1aa77e9be7eb491bb232c05fd61f3", </del> <ins> "distro": "0384a381913bc4775eb0c45632f2e0d66f8b7f1d", </ins> "author": { "name": "Microsoft Corporation" },

"windows-mutex": "0.3.0", "windows-process-tree": "0.2.4" } <del> } </del> <ins> } </ins>  No newline at end of file
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.39.0 OS Version: Linux RHEL 7 Steps to Reproduce: code with --no-proxy-server flag "Option 'proxy-server' is unknown. Ignoring." error appears. I think the proxy is still disabled, the error message is simply wrong? If I run without the flag, I get prompted to log into the proxy, if I run with the flag, the proxy appears disabled (no log in prompting) but the error appears on the command line.
I suggest to include that fix in the recovery builds to avoid any confusion due to the message printed by the cli. The cli says for all chromium options, but in fact, they are used. My understanding is that most of the chromium options are not for the end-user except and the proxy settings, so I these to the list of the valid (supported) args. Please speak up if I missed one of the options. PR is
This is not fixed in the latest stable release candidate. The reason is that the PR was actually not merged and this issue was closed erroneously
The discussion in yesterday's standup was to take this, so we've now merged the PR...

Discussion:
'force'?: boolean; 'force-user-env'?: boolean; <del> // node flags </del> <ins> // chromium command line args: https://electronjs.org/docs/all#supported-chrome-command-line-switches 'no-proxy-server'?: boolean; 'proxy-server'?: string; 'proxy-bypass-list'?: string; 'proxy-pac-url'?: string; 'inspect'?: string; 'inspect-brk'?: string; </ins> 'js-flags'?: string; 'disable-gpu'?: boolean; 'nolazy'?: boolean;

'disable-inspect': { type: 'boolean' }, 'force-user-env': { type: 'boolean' }, <ins> // chromium flags 'no-proxy-server': { type: 'boolean' }, 'proxy-server': { type: 'string' }, 'proxy-bypass-list': { type: 'string' }, 'proxy-pac-url': { type: 'string' }, </ins> 'js-flags': { type: 'string' }, // chrome js flags <ins> 'inspect': { type: 'string' }, 'inspect-brk': { type: 'string' }, </ins> 'nolazy': { type: 'boolean' }, // node inspect '_urls': { type: 'string[]' },
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.40.0-insider () OS Version: macOSX 10.15 Steps to Reproduce: auto-complete and press tab <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes 40.0-insider () ! 1.38.1 () !
works fine seems to be broken
thanks for bisecting. was authered by thus assigning to him
Yup, this is bad: ! Though it only happens on auto suggest, not manual trigger.
I've merged the fix by thanks a lot for that! We'll get the fixed Insiders build next Monday morning CET. Sorry for the disturbance everyone!
Thanks everyone!
Still seeing this pretty consistently on Version: 1.40.0-insider (user setup) Commit: Date: 2019-10-15T05:26:38.861Z Electron: 6.0.12 Chrome: 76.0.3809.146 12.4.0 V8: 7.6.303.31-electron.0 OS: Windows_NT x64 10.0. ! Unless this is now the correct behavior? In which case, how do I stop it and get it to insert as before, not replace?
I'm seeing weird behavior on quotes as well. if you type inside , the last quote is removed, like in becomes Version: 1.40.0-insider (user setup) Commit: Date: 2019-10-15T05:26:38.861Z Electron: 6.0.12 Chrome: 76.0.3809.146 12.4.0 V8: 7.6.303.31-electron.0 OS: Windows_NT x64 10.0.
What language is that?
Oh, I see . Yeah, that's very likely because JSON uses a more than bogous word definition
I have created and I aiming to push a fix today
What's the correct behavior here? If replacing the text is correct, that's fine, but if the current solution is going to be a whack-a-mole fix for each language maybe there's something else that should be done.
Another example. On this one, the comma is removed: !
We appreciate constructive feedback, if you want to report an issue then please file a new issue, stating the version of vscode, the language, and exact repo steps.
It's not a different issue though, this one just isn't fixed regardless of my preference for replace vs insert. If you'd prefer, I can open a new one.
Things seem to be working in the latest insiders. I'm no longer able to repro issue--can you confirm that this still occurs on the latest build of insiders? 
Yeah I haven't noticed any weird behavior in the past few days. I'll certainly comment here if I see it again.

Discussion:
let overwriteBefore = position.column - suggestion.range.startColumn; let overwriteAfter = suggestion.range.endColumn - position.column; <del> let suffixDelta = this._lineSuffix.value ? this._lineSuffix.value.delta(position) : 0; </del> <ins> let suffixDelta = this._lineSuffix.value ? this._lineSuffix.value.delta(editorPosition) : 0; </ins> let word: IWordAtPosition | null; if (!keepSuffix) { // don't overwrite anything right of the cursor

} else if (overwriteAfter === 0 && (word = model.getWordAtPosition(position))) { // compute fallback overwrite length <del> overwriteAfter = word.endColumn - position.column; </del> <ins> overwriteAfter = word.endColumn - editorPosition.column; </ins> } SnippetController2.get(this._editor).insert(insertText, {
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.39.1 OS Version: Fedora 30 Steps to Reproduce: a markdown file the Mardown preview on the side (<kbdCtrl+k v</kbd). This opens a Markdow preview tab, in a new tabs group at the right of the window. the focus to the left tabs group, by clicking inside the markdow file (source) another file (<kbdCtrl+o</kbd). This opens a new tab in the left tabs group. -click on a line of text in the Markdown preview This opens a new tab, in the right tabs group, to show the Markdow source. It should have focused the existing tab, in the left tabs group. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes

Discussion:
} private async onDidClickPreview(line: number): Promise<void> { <ins> // fix #82457, find currently opened but unfocused source tab await vscode.commands.executeCommand('markdown.showSource'); </ins> for (const visibleEditor of vscode.window.visibleTextEditors) { if (this.isPreviewOf(visibleEditor.document.uri)) { const editor = await vscode.window.showTextDocument(visibleEditor.document, visibleEditor.viewColumn);
Change:
Issue Type: <bBug</bOpen a new window, close the Untitled tab, open Release notes and press Ctrl+W (or Cmd+W) on macOS. Expected: Release notes tab is closed. Actual: Release notes tab is closed as well as the current window. You can also open a file, open Release notes and press Ctrl+W. Release notes and the last file will close. VS Code version: Code 1.39.2 (, 2019-10-15T15:33:40.634Z) OS version: Linux x64 4.15.0-65-generic
I tried reproducing the issue, seems everything is working fine.
The same happened when closing opened images. Using "Ctrl+W" to close an image would 1)close another file if there is, 2) otherwise close current VSCODE window OS version: Linux Mint 19.2 Tina (Cinnamon)/ XM Linux live(XFCE) image on VM VS Code version: 1.40.0 and the insider version Also I tried to reproduce it on a Windows 7 VM, and it was not there. Is it caused by Electron by any chance? I'd love to try to fix it. However, yet have no clue on where the related lines of codes are located. Any hints or suggestions? Thanks
Reopening since the fix caused regressions and had to be reverted
I confirm this is still happening with vscode v1.44.0 and Ubuntu 18.04. Many similar issues are opened already: ,
Should be fixed by

Discussion:
import { areWebviewInputOptionsEqual } from 'vs/workbench/contrib/webview/browser/webviewWorkbenchService'; import { WebviewThemeDataProvider } from 'vs/workbench/contrib/webview/common/themeing'; import { IWorkbenchEnvironmentService } from 'vs/workbench/services/environment/common/environmentService'; <ins> import { isLinux } from 'vs/base/common/platform'; </ins> export const enum WebviewMessageChannels { onmessage = 'onmessage',

this.handleFocusChange(false); })); <del> this._register(this.on('did-keydown', (data: KeyboardEvent) => { // Electron: workaround for https://github.com/electron/electron/issues/14258 // We have to detect keyboard events in the <webview> and dispatch them to our // keybinding service because these events do not bubble to the parent window anymore. this.handleKeyDown(data); })); </del> <ins> if (!isLinux) { // Fixes #82670 webview responding shortcuts twice on linux. this._register(this.on('did-keydown', (data: KeyboardEvent) => { // Electron: workaround for https://github.com/electron/electron/issues/14258 // We have to detect keyboard events in the <webview> and dispatch them to our // keybinding service because these events do not bubble to the parent window anymore. this.handleKeyDown(data); })); } </ins> this.style(); this._register(webviewThemeDataProvider.onThemeDataChanged(this.style, this));
Change:
Environment Details: Application Name: Visual Studio Code Application Version: 1.38.1 (user setup) Commit: Electron: 4.2.10 10.11.0 OS: Windows_NT x64 10.0. Steps to Reproduce: any workspace with Extensions recommendations notification pops up Accessibility insights and track the control type for toast notification. type is tree when it is expected to be a dialog. Accessibility Impact: the control is called out as tree by screen reader which might be confusing.
It is true that each notification toast is a tree itself because that is the underlying widget we are using. We can possible change that if there is API from the tree level.
There is already a  in the AriaProvider which should be exposed in the . Not sure if you can use that one, or you need to introduce a new one or the current one will be enough? can you try it out?
this was not possible without tree changes (and also a bugfix where the tree would always set the aria role "tree", even if options were provided). Please review
I was able to verify this change, the toast now has a dialog role. One thing I noticed is that the contained still has . This doesn't cause issues with OS X voiceover, but we should keep an eye out on whether it confuses other screen readers.
Yeah, to change that would need additional support from the tree widget I think.
Please note that this should now be fixed properly via So the parent is a and each toast is a

Discussion:
readonly automaticKeyboardNavigation?: boolean; readonly keyboardNavigationLabelProvider?: IKeyboardNavigationLabelProvider<T>; readonly keyboardNavigationDelegate?: IKeyboardNavigationDelegate; <del> readonly ariaRole?: ListAriaRootRole; </del> <ins> readonly ariaRole?: ListAriaRootRole | string; </ins> readonly ariaLabel?: string; readonly keyboardSupport?: boolean; readonly multipleSelectionSupport?: boolean;

this.view = new ListView(container, virtualDelegate, renderers, viewOptions); <del> if (typeof _options.ariaRole !== 'string') { this.view.domNode.setAttribute('role', ListAriaRootRole.TREE); } else { this.view.domNode.setAttribute('role', _options.ariaRole); } </del> <ins> this.updateAriaRole(); </ins> this.styleElement = DOM.createStyleSheet(this.view.domNode);

this.view.domNode.removeAttribute('aria-activedescendant'); } <del> this.view.domNode.setAttribute('role', 'tree'); </del> <ins> this.updateAriaRole(); </ins> DOM.toggleClass(this.view.domNode, 'element-focused', focus.length > 0); } <ins> private updateAriaRole(): void { if (typeof this.options.ariaRole !== 'string') { this.view.domNode.setAttribute('role', ListAriaRootRole.TREE); } else { this.view.domNode.setAttribute('role', this.options.ariaRole); } } </ins> private _onSelectionChange(): void { const selection = this.selection.get();

// Create toast with item and show const notificationList = this.instantiationService.createInstance(NotificationsList, notificationToast, { <ins> ariaRole: 'dialog', // https://github.com/microsoft/vscode/issues/82728 </ins> ariaLabel: localize('notificationsToast', "Notification Toast"), verticalScrollMode: ScrollbarVisibility.Hidden });
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.39.2 (user setup) OS Version: WindowsNT x64 10.0. Steps to Reproduce: menu -Help -Interactive Editor Playground. to section on Emmet. on the link to the Emmet Cheat sheet in the tip section on Emmet. confirmation box opens, with a link to a HTTP page. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes What I expected to see: Link uses HTTPS. What I actually saw: Link uses HTTP. Screenshot of box: !

Discussion:
ul>li.item$*5 ||| <del> >**Tip:** The [Emmet cheat sheet](http://docs.emmet.io/cheat-sheet/) is a great source of Emmet syntax suggestions. To expand Emmet abbreviations and snippets using the |tab| key use the |emmet.triggerExpansionOnTab| [setting](command:workbench.action.openGlobalSettings). Check out the docs on [Emmet in VS Code](https://code.visualstudio.com/docs/editor/emmet) to learn more. </del> <ins> >**Tip:** The [Emmet cheat sheet](https://docs.emmet.io/cheat-sheet/) is a great source of Emmet syntax suggestions. To expand Emmet abbreviations and snippets using the |tab| key use the |emmet.triggerExpansionOnTab| [setting](command:workbench.action.openGlobalSettings). Check out the docs on [Emmet in VS Code](https://code.visualstudio.com/docs/editor/emmet) to learn more. </ins>
Change:
Issue Type: <bBug</bSteps to Reproduce: any file to open the Search and Replace bar the Replace field, hit to add a line return the bar --The bottom of the bar is visible while closed. ! VS Code version: Code 1.39.2 (, 2019-10-15T15:33:40.634Z) OS version: Linux x64 5.0.0-32-generic <details<summarySystem Info</summary </details<details<summaryExtensions (18)</summaryExtensionVersion ------ vscode-intelephense-client1.2.3 vscode-tailwindcss0.2.0 gitlens10.1.1 auto-rename-tag0.1.0 gc-excelviewer2.1.32 todo-tree0.0.160 graphql-for-vscode1.15.1 rainbow-csv1.3.1 git-graph1.17.0 dotenv1.0.1 language-gettext0.1.1 vscode-typescript-tslint-plugin1.2.2 vsliveshare1.0.988 debugger-for-chrome4.12.0 material-icon-theme3.9.1 partial-diff1.4.0 ayu0.18.0 change-case1.0.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.467 --<!-- potentialduplicatescomment --
This is not a duplicate.
I hope you don't mind but I had a look into this and I've fixed it. Should I bother with a PR or leave it to you? It only adds if the contains , it doesn't check . However, I noticed that if is , you don't get the animation (slide down/up). I think a better solution may be to animate on transform.
not at all, feel free to send out your work and thanks for your contribution!

Discussion:
.monaco-editor .find-widget { position: absolute; z-index: 10; <del> top: -44px; </del> height: 33px; overflow: hidden; line-height: 19px; <del> transition: top 200ms linear; </del> <ins> transition: transform 200ms linear; </ins> padding: 0 4px; box-sizing: border-box; <ins> transform: translateY(Calc(-100% - 10px)); /* shadow (10px) */ </ins> } .monaco-editor .find-widget.hiddenEditor {

} /* Find widget when replace is toggled on */ <del> .monaco-editor .find-widget.replaceToggled { top: -74px; /* find input height + replace input height + shadow (10px) */ } </del> .monaco-editor .find-widget.replaceToggled > .replace-part { display: flex; display: -webkit-flex; } <del> .monaco-editor .find-widget.visible, .monaco-editor .find-widget.replaceToggled.visible { top: 0; } /* Multiple line find widget */ .monaco-editor .find-widget.multipleline { top: unset; bottom: 10px; } .monaco-editor .find-widget.multipleline.visible, .monaco-editor .find-widget.multipleline.replaceToggled.visible { top: 0px; bottom: unset; </del> <ins> .monaco-editor .find-widget.visible  { transform: translateY(0); </ins> } .monaco-editor .find-widget .monaco-inputbox.synthetic-focus {

private _onStateChanged(e: FindReplaceStateChangedEvent): void { if (e.searchString) { <del> if (this._state.searchString.indexOf('n') >= 0) { dom.addClass(this._domNode, 'multipleline'); } else { dom.removeClass(this._domNode, 'multipleline'); } </del> try { this._ignoreChangeEvent = true; this._findInput.setValue(this._state.searchString);
Change:
Issue Type: <bBug</bRepo interactive playground and trigger suggest widget Bug The styling of the suggest widget shows everything in blue: ! Here's a normal suggest widget for comparison: ! VS Code version: Code - Insiders 1.40.0-insider (, 2019-10-21T05:39:31.415Z) OS version: Darwin x64 18.7.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Ok. I found the line of code that causes this. This CSS rule has a larger priority than CSS rules that style highlighted labels. So here are two ways to fix this: the priority, e.g. this rule so that it only applies to such tags that have a non-empty href attribute
duplicate of
Actually will mark the other as duplicate as this one has a PR. Thanks I will take a look.

Discussion:
} const link = theme.getColor(textLinkForeground); if (link) { <del> collector.addRule(`.monaco-workbench .part.editor > .content .walkThroughContent a { color: ${link}; }`); </del> <ins> collector.addRule(`.monaco-workbench .part.editor > .content .walkThroughContent a[href] { color: ${link}; }`); </ins> } const activeLink = theme.getColor(textLinkActiveForeground); if (activeLink) { collector.addRule(`.monaco-workbench .part.editor > .content .walkThroughContent a:hover, <del> .monaco-workbench .part.editor > .content .walkThroughContent a:active { color: ${activeLink}; }`); </del> <ins> .monaco-workbench .part.editor > .content .walkThroughContent a[href]:active { color: ${activeLink}; }`); </ins> } const focusColor = theme.getColor(focusBorder); if (focusColor) { <del> collector.addRule(`.monaco-workbench .part.editor > .content .walkThroughContent a:focus { outline-color: ${focusColor}; }`); </del> <ins> collector.addRule(`.monaco-workbench .part.editor > .content .walkThroughContent a[href]:focus { outline-color: ${focusColor}; }`); </ins> } const shortcut = theme.getColor(textPreformatForeground); if (shortcut) {
Change:
Currently seems to not set the extension tests path properly.
There are two issues: the environment attribute 'extensionTestsPath' needs to be passed properly. when running VS Code in the web UI or in a remote setup, the value of the attribute must be a valid path that exists in the filesystem. This is a problem because for historical reasons the path generated by yeoman is which does not exist in the filesystem (because it lacks the file extension ). When running tests locally, the non-existing path is not an issue because mocha will find the tests anyway. The first problem has been fixed in VS Code. The second problem requires a change in "node-debug2": we have to cope with paths that lack a ".js" extension. I've created to address this. Without the second fix a workaround is needed in order to run extension tests in the Web or remote scenarios successfully: just append the ".js" extension to the path.
Verification: open a hello world extension in the web and run its unit tests.
One issue left: the tab where the VS Code instance runs the tests is not closed automatically at the end. See bug .
I hadn't published node2 with the fix. Doing that now, we can reverify this tomorrow.
Verification is trivial: open a hello world extension in the web and run its unit tests.
Verified using and running the tests.

Discussion:
<ins> sudo: false language: node_js node_js: - "0.12" addons: apt: sources: - ubuntu-toolchain-r-test packages: - gcc-4.9 - g++-4.9 - gcc-4.9-multilib - g++-4.9-multilib - zip - libgtk2.0-0 before_install: - export CXX="g++-4.9" CC="gcc-4.9" install: - ./scripts/npm.sh install - gulp electron compile </ins>

darwinBundleDocumentTypes: product.darwinBundleDocumentTypes, darwinCredits: darwinCreditsTemplate ? new Buffer(darwinCreditsTemplate({ commit: commit, date: new Date().toISOString() })) : void 0, winIcon: product.icons.application.ico, <del> win32ExeBasename: product.win32ExeBasename </del> <ins> win32ExeBasename: product.win32ExeBasename, token: process.env['GITHUB_TOKEN'] || void 0 </ins> }; gulp.task('electron', function () {

"node": ">= 0.10.0 < 0.11.0" }, "scripts": { <ins> "test": "node node_modules/mocha/bin/_mocha", </ins> "postinstall": "npm --prefix extensions/csharp-o/ install extensions/csharp-o/" }, "dependencies": {