jiebi/CodeConvo huggingface dataset:
Change:
Steps: open 2 empty groups pick "Open Previous Editor" or "Open Next Editor" Endless loop.

Discussion:
} // Otherwise try in next group that has editors <ins> const handledGroups = new Set<number>(); </ins> let currentGroup: IEditorGroup | undefined = this.editorGroupService.activeGroup; <del> while (currentGroup) { </del> <ins> while (currentGroup && !handledGroups.has(currentGroup.id)) { </ins> currentGroup = this.editorGroupService.findGroup({ location: GroupLocation.NEXT }, currentGroup, true); if (currentGroup) { <ins> handledGroups.add(currentGroup.id); </ins> const groupEditors = currentGroup.getEditors(EditorsOrder.SEQUENTIAL); if (groupEditors.length > 0) { return { editor: groupEditors[0], groupId: currentGroup.id };

} // Otherwise try in previous group that has editors <ins> const handledGroups = new Set<number>(); </ins> let currentGroup: IEditorGroup | undefined = this.editorGroupService.activeGroup; <del> while (currentGroup) { </del> <ins> while (currentGroup && !handledGroups.has(currentGroup.id)) { </ins> currentGroup = this.editorGroupService.findGroup({ location: GroupLocation.PREVIOUS }, currentGroup, true); if (currentGroup) { <ins> handledGroups.add(currentGroup.id); </ins> const groupEditors = currentGroup.getEditors(EditorsOrder.SEQUENTIAL); if (groupEditors.length > 0) { return { editor: groupEditors[groupEditors.length - 1], groupId: currentGroup.id };
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: current development branch OS Version: MacOS 12.5.1 Steps to Reproduce: sure setting is set to all editors a task that the editor asks whether to save all editors When no editor is dirty, it is disconcerting when trying to run a task asks me whether I should save all editors – I need to stop and think what is unsaved and whether I should save it. This can be avoided if the code checks that any editor is dirty before asking. PR submitted:

Discussion:
if (saveBeforeRunTaskConfig === SaveBeforeRunConfigOptions.Never) { return false; <del> } else if (saveBeforeRunTaskConfig === SaveBeforeRunConfigOptions.Prompt) { </del> <ins> } else if (saveBeforeRunTaskConfig === SaveBeforeRunConfigOptions.Prompt && this._editorService.editors.some(e => e.isDirty())) { </ins> const dialogOptions = await this._dialogService.show( Severity.Info, nls.localize('TaskSystem.saveBeforeRun.prompt.title', 'Save all editors?'),
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.2 OS Version: 12.15.1 Steps to Reproduce: to define a for Vite. Vite prints colors, which unlike problems matchers, are not stripped while matching the output. This makes it difficult to define a proper pattern for it.
Please provide a screenshot or illustrating the problem (attaching images won't work via email, you need to go to ). See for more general info on how to report actionable terminal issues. /label info-needed terminal
Sorry for the zip. The gif came out 1MiB bigger than GitHub will like to allow to upload.
Thanks - based on the gif, the problem is that is not taking effect - in your case, the property
It is taking effect. I'm purposefully disabling it by commenting it at first. At the start I run without it to show that is not working with colors enabled. I then uncomment it which disables colors and show that without colors does work.

Discussion:
killOnServerStop?: boolean; } <ins> // Escape codes // http://en.wikipedia.org/wiki/ANSI_escape_code const EL = /x1Bx5B[12]?K/g; // Erase in line const COLOR_START = /x1b[d+m/g; // Color const COLOR_END = /x1b[0?m/g; // Color /** * Froms vs/base/common/strings.ts in core * @see https://github.com/microsoft/vscode/blob/22a2a0e833175c32a2005b977d7fbd355582e416/src/vs/base/common/strings.ts#L736 */ function removeAnsiEscapeCodes(str: string): string { if (str) { str = str.replace(EL, ''); str = str.replace(COLOR_START, ''); str = str.replace(COLOR_END, ''); } return str; } </ins> class Trigger { private _fired = false;

// first find the detector with a matching pid const pid = await e.terminal.processId; <ins> const str = removeAnsiEscapeCodes(e.data); </ins> for (const [, detector] of this.detectors) { if (detector.shellPid === pid) { <del> detector.detectPattern(e.data); </del> <ins> detector.detectPattern(str); </ins> return; } } // if none found, try all detectors until one matches for (const [, detector] of this.detectors) { <del> if (detector.detectPattern(e.data)) { </del> <ins> if (detector.detectPattern(str)) { </ins> return; } }
Change:
A11yMAS; #A11yWCAG2.1; #A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Aug2022; #WCAG4.1.3; #NVDA; #ScreenReader; #Narrator; #Closed Visual Studio Code Version: 1.70.2 (user setup) Windows 11 Pro version 21H2 (OS Build .856) on NVDA Visual studio code editor. till setting icon and Select "Keyboard shortcuts options" that Key bending status message "1 existing command has this key bending" is announced by screen reader or not. Key bending status message "1 existing command has this key bending" is not announced by NVDA/Narrator screen readers. NVDA/Narrator should announce the status message "1 existing command has this key bending" ! !
can we just do an aria alert when there are existing keybindings? This issue we have to fix since it is severity 2, though it sounds law hanging.
PO should not close the bug. Only trusted tester closes the bug. This bug is not fixed. So, please provide the reason for closing the bug. Thanks
make sure to use VS Code insiders
Issue is fixed. So,Closing the bug. !

Discussion:
import { KeyCode } from 'vs/base/common/keyCodes'; import { ResolvedKeybinding } from 'vs/base/common/keybindings'; import * as dom from 'vs/base/browser/dom'; <ins> import * as aria from 'vs/base/browser/ui/aria/aria'; </ins> import { IKeyboardEvent, StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent'; import { FastDomNode, createFastDomNode } from 'vs/base/browser/fastDomNode'; import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';

const existingElement = dom.$('span.existingText'); const text = numberOfExisting === 1 ? nls.localize('defineKeybinding.oneExists', "1 existing command has this keybinding", numberOfExisting) : nls.localize('defineKeybinding.existing', "{0} existing commands have this keybinding", numberOfExisting); dom.append(existingElement, document.createTextNode(text)); <ins> aria.alert(text); </ins> this._showExistingKeybindingsNode.appendChild(existingElement); existingElement.onmousedown = (e) => { e.preventDefault(); }; existingElement.onmouseup = (e) => { e.preventDefault(); };
Change:
On a non-default profile, settings like , which are machine-overridable, do not have their value read properly by the configurationService even when the user specifies the value in the current profile
It seems to work now. I see the profile specific value being shown in the UI.
It still doesn't seem to work. I have a small extension that inspects the setting. When I run the command, it inspects the setting, and it doesn't pick up the profile setting there. I'll see if I can upload the test extension soon. Edit: I think what's happening is that profile changes aren't being picked up by the VS Code extension API. When I reload the window on a non-default profile and run the command, it gives me the correct globalValue, but if I then change to another non-default profile, it clears out the globalValue key and doesn't give it the new profile's value. !
I tried this with my sample extension (following) and it works as expected for me Edit: Sorry, I can repro it, forgot to set value for the setting in non-default profile.

Discussion:
export const tasksSchemaId = 'vscode://schemas/tasks'; export const APPLICATION_SCOPES = [ConfigurationScope.APPLICATION]; <del> export const PROFILE_SCOPES = [ConfigurationScope.MACHINE, ConfigurationScope.WINDOW, ConfigurationScope.RESOURCE, ConfigurationScope.LANGUAGE_OVERRIDABLE]; </del> <ins> export const PROFILE_SCOPES = [ConfigurationScope.MACHINE, ConfigurationScope.WINDOW, ConfigurationScope.RESOURCE, ConfigurationScope.LANGUAGE_OVERRIDABLE, ConfigurationScope.MACHINE_OVERRIDABLE]; </ins> export const LOCAL_MACHINE_PROFILE_SCOPES = [ConfigurationScope.WINDOW, ConfigurationScope.RESOURCE, ConfigurationScope.LANGUAGE_OVERRIDABLE]; export const LOCAL_MACHINE_SCOPES = [ConfigurationScope.APPLICATION, ...LOCAL_MACHINE_PROFILE_SCOPES]; export const REMOTE_MACHINE_SCOPES = [ConfigurationScope.MACHINE, ConfigurationScope.WINDOW, ConfigurationScope.RESOURCE, ConfigurationScope.LANGUAGE_OVERRIDABLE, ConfigurationScope.MACHINE_OVERRIDABLE];
Change:
<img width="423" alt="image" src="https://user-"
I am unable to repro this - could you pls provide the steps that you take?
I have not found a pattern so far, might be timing related. It is not happening everytime I reload the window... However, one thing to keep in mind is that I often use and not . That command kills the build task and relaunches it: So that may well be related to the issue.
Thanks for the idea, but seems unrelated to that command as has reproduced this with

Discussion:
protected _taskRunningState: IContextKey<boolean>; <ins> private _inProgressTasks: Set<string> = new Set(); </ins> protected _outputChannel: IOutputChannel; protected readonly _onDidStateChange: Emitter<ITaskEvent>; private _waitForSupportedExecutions: Promise<void>;

if (!task) { throw new TaskError(Severity.Info, nls.localize('TaskServer.noTask', 'Task to execute is undefined'), TaskErrors.TaskNotFound); } <ins> if (this._inProgressTasks.has(task._label)) { this._logService.info('Prevented duplicate task from running', task._label); return; } this._inProgressTasks.add(task._label); </ins> const resolver = this._createResolver(); let executeTaskResult: ITaskSummary | undefined; try {

} catch (error) { this._handleError(error); return Promise.reject(error); <ins> } finally { this._inProgressTasks.delete(task._label); </ins> } }
Change:
a desktop clone open with some uncommitted changes Continue Edit Session open on :bug: edit session is not applied The reason for this is that we are opening a permalink instead of preserving the current branch checkout so the edit session identifier doesn't match up and the edit session doesn't get applied. This used to work and regressed with the edit session identifier API work, which applies stricter checks to edit session identities. Thanks for finding this in !
not seeing a command
sorry, that should have been , not

Discussion:
import { API as GitAPI } from './typings/git'; import { publishRepository } from './publish'; import { DisposableStore } from './util'; <del> import { getPermalink } from './links'; </del> <ins> import { getLink } from './links'; </ins> function getVscodeDevHost(): string { return `https://${vscode.env.appName.toLowerCase().includes('insiders') ? 'insiders.' : ''}vscode.dev/github`;

async function copyVscodeDevLink(gitAPI: GitAPI, useSelection: boolean) { try { <del> const permalink = getPermalink(gitAPI, useSelection, getVscodeDevHost()); </del> <ins> const permalink = getLink(gitAPI, useSelection, getVscodeDevHost()); </ins> if (permalink) { return vscode.env.clipboard.writeText(permalink); }

async function openVscodeDevLink(gitAPI: GitAPI): Promise<vscode.Uri | undefined> { try { <del> const permalink = getPermalink(gitAPI, true, getVscodeDevHost()); return permalink ? vscode.Uri.parse(permalink) : undefined; </del> <ins> const headlink = getLink(gitAPI, true, getVscodeDevHost(), 'headlink'); return headlink ? vscode.Uri.parse(headlink) : undefined; </ins> } catch (err) { vscode.window.showErrorMessage(err.message); return undefined;

return hash; } <del> export function getPermalink(gitAPI: GitAPI, useSelection: boolean, hostPrefix?: string): string | undefined { </del> <ins> export function getLink(gitAPI: GitAPI, useSelection: boolean, hostPrefix?: string, linkType: 'permalink' | 'headlink' = 'permalink'): string | undefined { </ins> hostPrefix = hostPrefix ?? 'https://github.com'; const fileAndPosition = getFileAndPosition(); if (!fileAndPosition) {

return; } <del> const commitHash = (gitRepo.state.HEAD?.ahead === 0) ? `/blob/${gitRepo.state.HEAD?.commit}` : ''; </del> <ins> const blobSegment = (gitRepo.state.HEAD?.ahead === 0) ? `/blob/${linkType === 'headlink' ? gitRepo.state.HEAD.name : gitRepo.state.HEAD?.commit}` : ''; </ins> const fileSegments = fileAndPosition.type === LinkType.File ? (useSelection ? `${uri.path.substring(gitRepo.rootUri.path.length)}${rangeString(fileAndPosition.range)}` : '') : (useSelection ? `${uri.path.substring(gitRepo.rootUri.path.length)}${notebookCellRangeString(fileAndPosition.cellIndex, fileAndPosition.range)}` : ''); <del> return `${hostPrefix}/${repo.owner}/${repo.repo}${commitHash </del> <ins> return `${hostPrefix}/${repo.owner}/${repo.repo}${blobSegment </ins> }${fileSegments}`; }
Change:
edit sessions enabled in settings Continue Working On command in 't pick a destination, esc to dismiss the quickpick Show Edit Sessions command :bug: edit session was created anyway
I'm seeing no options !
Prior to that, I saw this prompt and clicked cancel, then saw an error notification related to that about not being able to save files. !
worked in

Discussion:
}; that.telemetryService.publicLog2<ContinueEditSessionEvent, ContinueEditSessionClassification>('editSessions.continue.store'); <del> // Run the store action to get back a ref const ref = await that.storeEditSession(false); </del> let uri = workspaceUri ?? await that.pickContinueEditSessionDestination(); if (uri === undefined) { return; } <ins> // Run the store action to get back a ref const ref = await that.storeEditSession(false); </ins> // Append the ref to the URI if (ref !== undefined) { const encodedRef = encodeURIComponent(ref);
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.71.0 OS Version: Windows 10 BEFORE UPDATING: ! AFTER UPDATING: ! Steps to Reproduce: vscode to version 1.71.0 decides to move the closing button location
Are you using a right-to-left language for your OS? Mitigation: Disable the setting and reload the window.
yes, I am using an RTL language for my OS but this has never been an issue in previous versions. edit: I tried your suggestion of disabling and it was indeed disabled by default in v1.70.2 but was enabled by default in v1.71.0
I'm curious whether native Windows apps show their controls at top-left when using an RTL language?
This is expected since the controls are drawn natively by the runtime rather than the application drawing it before . Other native windows application also move the controls to for RTL languages. We should adjust the rest of titlebar contents to match this behavior.
! This is what Google Chrome title bar looks like if that answers your question ! And windows file explorer Edit: Whoever set this issue as win11, I'm using windows 10...
I have the same bug. How can I solve this problem?
Disable the setting
I don't think VS Code should move the titlebar contents if it is still displaying the text in English. In the screenshot below, I have VS Code, Notepad++, Paint, and Outlook loaded, and Paint is the only one with both RTL text and mirrored controls. ! P.S. I can't read Farsi.
open setting by search about uncheck it.
I agree. I was under the impression this bug also affected users who had RTL display language set in VSCode. Native applications I had tested was when application also had the same display language as the system. I can confirm the alignment behavior of WCO when application has LTR while system has RTL.
As suggested above, disabling window.experimental.windowControlsOverlay.enabled solved the issue.

Discussion:
return configuredUseWindowControlsOverlay; } <del> return true; // enabled by default </del> <ins> return false; // disable by default </ins> } export interface IPath<T = IEditorOptions> extends IPathData<T> {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.72.0-insider (Universal) Commit: OS Version: macOS 12.5.121G83 Steps to Reproduce: latest VSCode Insiders cmd + , <img width="299" alt=" 2022-09-02 18 41 29" src="https://user-"<img width="268" alt=" 2022-09-02 18 41 41" src="https://user-"
Keybinding is missing on today's Insiders: ! could have caused this?
Added macos label because it seems to work fine on Windows.
my screenshot was from a Windows instance of Insiders.
It might be caused by that commit, but I'm still unable to repro the issue on Windows 10 or macOS Big Sur.
When I downloaded the latest Insiders to the Download folder and ran it, this did not reproduce. It may happen when updating a global install, but I have not been able to verify this yet.

Discussion:
} const workbenchContributionsRegistry = Registry.as<IWorkbenchContributionsRegistry>(WorkbenchExtensions.Workbench); <del> // PreferencesActionsContribution is heavy because it runs through various details to determine which actions to render. // We don't need it to start so early. workbenchContributionsRegistry.registerWorkbenchContribution(PreferencesActionsContribution, 'PreferencesActionsContribution', LifecyclePhase.Restored); </del> <ins> workbenchContributionsRegistry.registerWorkbenchContribution(PreferencesActionsContribution, 'PreferencesActionsContribution', LifecyclePhase.Starting); </ins> workbenchContributionsRegistry.registerWorkbenchContribution(PreferencesContribution, 'PreferencesContribution', LifecyclePhase.Starting); registerEditorContribution(SettingsEditorContribution.ID, SettingsEditorContribution);
Change:
Type: <bBug</bI tried to run the debugger and it's just did not start the server, it just freezed. VS Code version: Code 1.71.0 (Universal) (, 2022-09-01T07:25:38.437Z) OS version: Darwin arm64 21.6.0 Modes: Sandboxed: No <details<summarySystem Info</summary </details<details<summaryExtensions (68)</summaryExtensionVersion ------ better-comments3.0.2 codesnap1.3.4 toggle-block-comments1.3.0 laravel-extra-intellisense0.6.2 laravel-blade-spacer2.1.3 vscode-intelephense-client1.8.2 npm-intellisense1.4.2 vscode-sql-beautify0.3.15 laravel-goto-view1.3.7 dart-code3.48.0 flutter3.48.0 vscode-markdownlint0.48.1 vscode-eslint2.2.6 javascript-ejs-support1.3.1 es7-react-js-snippets4.4.3 vscode-babel-coloring0.0.4 gitlens12.2.1 vscode-html-css1.13.1 tslint1.0.47 vscode-npm-script0.3.28 prettier-vscode9.8.0 comment-anchors1.9.6 auto-rename-tag0.1.10 copilot1.43.6621 laravel-create-view0.0.6 php-awesome-snippets1.1.3 helium-icon-theme1.0.0 rest-client0.25.1 laravel-blade-wrapper1.0.1 vue0.1.5 JavaScriptSnippetsStandard1.8.0 auto-comment-blocks1.0.1 vscode-phpfmt1.0.31 php-namespace-resolver1.1.9 vscode-language-babel0.0.36 dotenv1.0.1 djlint2022.7.2 vscode-docker1.22.1 remote-containers0.252.0 vscode-typescript-tslint-plugin1.3.4 laravel-goto-components1.2.0 vetur0.36.0 laravel-blade1.32.0 laravel-extension-pack1.1.0 laravel5-snippets1.15.0 docker-compose0.3.5 live-sass3.0.0 LiveServer5.7.9 nunjucks0.3.1 laravel-artisan0.0.28 vscode-javascript-booster14.0.1 vue-vscode-snippets3.1.1 vscode-blade-formatter0.17.3 js-jsx-snippets11.0.0 comment-divider0.4.0 autoimport1.5.4 code-spell-checker2.7.0 svelte-vscode105.22.1 ayu1.0.5 volar0.40.5 phaser-snippets0.0.6 JavaScriptSnippets1.8.0 php-debug1.28.0 txt-syntax0.2.0 vscode-yseopml1.16.0 json2.0.2 material-theme3.15.2 html-css-class-completion1.20.0 (4 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
the same on me. and 2 team members on VS code version 1.70 + working fine on vs code 1.71 for intel and M1 broken (for the same project ) nodejs +typescript +nestjs
/jsDebugLogs
Please collect trace logs using the following instructions:
debug console doesn't show path to log. just show 1 line (with and without ) info similar issue here
!
Same issue here. I can't launch any of the automatic debug configurations that start my npm scripts (npm start, etc.). They just get stuck with the same terminal output in 's screenshot.
are you also on arm64/M1 macOS?
Same issue on Windows 10 Pro 21H2
Thanks, I can reproduce it. For now, you can create an entry in your that manually runs the script, like so:
Verification steps: a folder with npm scripts the debug dropdown or quick access, choose the "" option Select and verify you can debug one of the npm scripts

Discussion:
}, { "name": "ms-vscode.js-debug", <del> "version": "1.71.0", </del> <ins> "version": "1.71.1", </ins> "repo": "https://github.com/microsoft/vscode-js-debug", "metadata": { "id": "25629058-ddac-4e17-abba-74678e126c5d",