jiebi/CodeConvo huggingface dataset:
Change:
You could resolve these so it would search for the right file. Or do you not want to make assumptions about the format of the thing? ! !
Started a discussion in , if that's no good I can just normalize the path which isn't super smart but it will find results.
Open to PRs, more detailed repro in
I would like to work on this issue. We only want to normalize the path in the filter string, right? So: - a/../b/./c -b/c
yes, but just for the
I have raised a PR for this issue. Please review it.

Discussion:
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { XtermLinkMatcherHandler } from 'vs/workbench/contrib/terminal/browser/links/terminalLinkManager'; import { TerminalBaseLinkProvider } from 'vs/workbench/contrib/terminal/browser/links/terminalBaseLinkProvider'; <ins> import { normalize } from 'vs/base/common/path'; </ins> export class TerminalWordLinkProvider extends TerminalBaseLinkProvider { private readonly _fileQueryBuilder = this._instantiationService.createInstance(QueryBuilder);

} private async _activate(link: string) { <ins> // Normalize the link and remove any leading ./ or ../ since quick access doesn't understand // that format link = normalize(link).replace(/^(.+/)+/, ''); </ins> const results = await this._searchService.fileSearch( this._fileQueryBuilder.file(this._workspaceContextService.getWorkspace().folders, { filePattern: link,
Change:
Issue Type: <bBug</bWith the change from , the data fired from an event emitter is no longer optional. For extensions using the API, firing an emitter for without any arguments is now a compilation error. We should add to the type list here. VS Code version: Code - Insiders 1.45.0-insider (, 2020-05-04T09:21:17.770Z) OS version: Darwin x64 18.7.0 <!-- generated by issue reporter --
Hi, has this been implemented? I am on VSCode 1.45.1 and I still get this error when trying to compile. !
Yes, but the EventEmitter still needs to be defined with type ,

Discussion:
* This will trigger the view to update the changed element/root and its children recursively (if shown). * To signal that root has changed, do not pass any argument or pass `undefined` or `null`. */ <del> onDidChangeTreeData?: Event<T | undefined | null>; </del> <ins> onDidChangeTreeData?: Event<T | undefined | null | void>; </ins> /** * Get [TreeItem](#TreeItem) representation of the `element`

} } <del> type Root = null | undefined; </del> <ins> type Root = null | undefined | void; </ins> type TreeData<T> = { message: boolean, element: T | Root | false }; interface TreeNode extends IDisposable {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --Steps to Reproduce: long variables that cause scroll them that the scrollbar gets in the way of the "relaunch terminal" button

Discussion:
const actionsElement = $('div.actions'); this._actions.forEach(action => this._renderAction(actionsElement, action)); statusBarElement.appendChild(actionsElement); <del> this._domNode.appendChild(statusBarElement); </del> <ins> this._containerDomNode.appendChild(statusBarElement); </ins> } this._mouseTracker = new CompositeMouseTracker([this._containerDomNode, ..._target.targetElements]);
Change:
I a warning about task providers that don't provide the task type they say they will in April. It looks like the C++ extension is hitting this.
This isn't really a bug, so much as the system implicitly allowed a behavior that now it does not.
To verify: Install version 0.27.1 the C/C++ extension. (Extension viewlet -right click on extension -install another version) Open a folder Open a C++ file. It can be empty. From the command palette Tasks: Run Task Choose the "Show All..." option Verify that you don't get a warning notification about task errors. (no need to run a task)
In 1.45.0 I get: Tn 1.45.1 this message no longer appears.

Discussion:
for (const task of taskSet.tasks) { if (task.type !== this._providerTypes.get(handle)) { this._outputChannel.append(nls.localize('unexpectedTaskType', "The task provider for "{0}" tasks unexpectedly provided a task of type "{1}".n", this._providerTypes.get(handle), task.type)); <del> this.showOutput(); </del> <ins> if ((task.type !== 'shell') && (task.type !== 'process')) { this.showOutput(); } </ins> break; } }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.45.0 OS Version: macOS Catalina 10.15.4 ! My file: The setting does work, it just shows that warning. Steps to Reproduce: on "Edit in " under "Editor: Rulers" any number inside of the array for the field "" <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Bug in my validation !
This affects all numeric array settings, and also numeric values in "string" type settings.
Any idea why this is just now showing up? Looks like the code is old and I'm pretty sure I've use the UI for rulers before.
I only those validations last month.
My bad, read the "a month ago" as "8 month ago".
Better fix in
as of firiday may 15 this issue is NOT corrected ! !
looks like settings with type and default still error in Stable. It's already fixed in Insiders.
Dang. Sorry it will be fixed in the next release.
I am getting this for certain "boolean", will the fix address them too?
Can you try downloading the Insiders' build and tell me whether it happens there? If so, can you tell me which setting it is?
Hi Rob, it works fine with insiders version Rob Lourens <:

Discussion:
(valueType === 'boolean' && !canBeType(typeArr, 'boolean')) || (valueType === 'object' && !canBeType(typeArr, 'object', 'null', 'array')) || (valueType === 'string' && !canBeType(typeArr, 'string', 'number', 'integer')) || <del> (typeof parseFloat(value) === 'number' && !isNaN(parseFloat(value)) && !canBeType(typeArr, 'number', 'integer')) || </del> (Array.isArray(value) && !canBeType(typeArr, 'array')) ) { if (typeof type !== 'undefined') {
Change:
This started only with todays build: Start it and be greeted with:
Exception seems to indicate an issue with code signing? Could this be related to the recent entitlements change? //cc

Discussion:
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> <plist version="1.0"> <dict> <ins> <key>com.apple.security.cs.allow-jit</key> <true/> <key>com.apple.security.cs.allow-unsigned-executable-memory</key> <true/> <key>com.apple.security.cs.disable-library-validation</key> <true/> <key>com.apple.security.cs.allow-dyld-environment-variables</key> <true/> </ins> </dict> </plist>

<ins> <?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> <plist version="1.0"> <dict> <key>com.apple.security.cs.disable-library-validation</key> <true/> </dict> </plist> </ins>

security import $(agent.tempdirectory)/cert.p12 -k $(agent.tempdirectory)/buildagent.keychain -P "$(macos-developer-certificate-key)" -T /usr/bin/codesign security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k pwd $(agent.tempdirectory)/buildagent.keychain codesign -s 99FM488X57 --deep --force --options runtime --entitlements build/azure-pipelines/darwin/entitlements.plist "$APP_ROOT"/*.app <ins> codesign -s 99FM488X57 --force --options runtime --entitlements build/azure-pipelines/darwin/helper-entitlements.plist "$APP_FRAMEWORK_PATH/$HELPER_APP_NAME Helper.app" </ins> codesign -s 99FM488X57 --force --options runtime --entitlements build/azure-pipelines/darwin/helper-gpu-entitlements.plist "$APP_FRAMEWORK_PATH/$HELPER_APP_NAME Helper (GPU).app" codesign -s 99FM488X57 --force --options runtime --entitlements build/azure-pipelines/darwin/helper-plugin-entitlements.plist "$APP_FRAMEWORK_PATH/$HELPER_APP_NAME Helper (Plugin).app" codesign -s 99FM488X57 --force --options runtime --entitlements build/azure-pipelines/darwin/helper-renderer-entitlements.plist "$APP_FRAMEWORK_PATH/$HELPER_APP_NAME Helper (Renderer).app"
Change:
Webviews appear to not restore via or running the command: a webview, like a PR/welcome page/release notes tab tab :bug: tab is skipped and goes to next This is also affected by pinned tabs but I assume it's related to the reopen command.
This is intentional because there is no way currently a non-file based editor can signal that it can simply be restored. Check is here: However this could possibly be improved by simply asking the editor input factory to serialize the editor and then bring it back, I can play around with that approach. not sure that makes sense to you, is it safe to serialize any webview via its factory and bring it back from that state?
Upon second thought, I think my proposed idea is also not good because when an editor closes, assuming that you can serialize it may be risky. I think we would need some new infrastructure to support this scenario.
with the change in , we are now asking the editor input factory to serialise an editor when it closes to support for opening it again. However it looks like webviews are not being serialized when they got closed, which maybe is for a good reason. If we cannot support this easily, then I suggest to close this feature, otherwise please try it out and see what is missing.
Just want to throw my two cents in/use case in. I came here because I updated to 1.47.0-insider from 1.46.0-insider, the initial launch opened the Release Notes: 1.47.0-insider tab, I closed it by accident, then tried to open it again with Ctrl+Shift+T. Presumably that page is a webview and suffers from this. Easy enough to get it back via Help -Release Notes, but the expected actions did not work. Edit: Seems release notes are a different problem, my bad!
Not enabled for the release notes at the moment but should now work for markdown previews

Discussion:
} function canRevive(reviver: WebviewResolver, webview: WebviewInput): boolean { <del> if (webview.isDisposed()) { return false; } </del> return reviver.canResolve(webview); }
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Let's expand the file patterns recognized as POSIZy shell scripts: Files with ash, dash, posh, yash shebangs zsh core configuration files (, , , , , , , , , , , , , , ) Slant rhyme filenames like , This last one is going to trigger some false positives, but perhaps that is better than highlighting as TXT files.
Also see . PRs are welcome!
Hey I can take this. Any tips on where to start looking? :slightlysmilingface:
Cool. Have a look here:

Discussion:
"languages": [{ "id": "shellscript", "aliases": ["Shell Script", "shellscript", "bash", "sh", "zsh", "ksh", "csh"], <del> "extensions": [".sh", ".bash", ".bashrc", ".bash_aliases", ".bash_profile", ".bash_login", ".ebuild", ".install", ".profile", ".bash_logout", ".zsh", ".zshrc", ".zprofile", ".zlogin", ".zlogout", ".zshenv", ".zsh-theme", ".ksh", ".csh", ".cshrc"], </del> <ins> "extensions": [ ".sh", ".bash", ".bashrc", ".bash_aliases", ".bash_profile", ".bash_login", ".ebuild", ".install", ".profile", ".bash_logout", ".zsh", ".zshrc", ".zprofile", ".zlogin", ".zlogout", ".zshenv", ".zsh-theme", ".ksh", ".csh", ".cshrc", ".tcshrc", ".yashrc", ".yash_profile" ], </ins> "filenames": [ <del> "APKBUILD", "PKGBUILD", ".envrc" ], "firstLine": "^#!.*b(bash|zsh|sh|tcsh|ksh|ash|qsh|csh).*|^#s*-*-[^*]*mode:s*shell-script[^*]*-*-", </del> <ins> "APKBUILD", "PKGBUILD", ".envrc", ".hushlogin", "zshrc", "zshenv", "zlogin", "zprofile", "zlogout", "bashrc_Apple_Terminal", "zshrc_Apple_Terminal" ], "firstLine": "^#!.*b(bash|zsh|sh|ksh|dtksh|pdksh|mksh|ash|dash|yash|sh|csh|jcsh|tcsh|itcsh).*|^#s*-*-[^*]*mode:s*shell-script[^*]*-*-", </ins> "configuration": "./language-configuration.json", "mimetypes": ["text/x-shellscript"] }],
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.45.0 OS Version: Ubuntu 19.10 Steps to Reproduce: add: { "git.enabled": false, "git.terminalAuthentication": false, "git.githubAuthentication": false, } to push from the integrated terminal <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes Error text: Missing or invalid credentials. Error: connect ENOENT at PipeConnectWrap.afterConnect [as oncomplete] () { errno: 'ENOENT', code: 'ENOENT', syscall: 'connect', address: '' }
Did you restart the terminal after your disabled it?
Yes, I've both killed the terminal and restarted the VM. Not sure if this is helpful, but before I the two new settings vscode was trying to handle the authentication even though I had set (requesting username and password from the command palette). That's what sent me looking for the new settings in the first place.

Discussion:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { window, InputBoxOptions, Uri, OutputChannel, Disposable } from 'vscode'; </del> <ins> import { window, InputBoxOptions, Uri, OutputChannel, Disposable, workspace } from 'vscode'; </ins> import { IDisposable, EmptyDisposable, toDisposable } from './util'; import * as path from 'path'; import { IIPCHandler, IIPCServer, createIPCServer } from './ipc/ipcServer';

} async handle({ request, host }: { request: string, host: string }): Promise<string> { <ins> const config = workspace.getConfiguration('git', null); const enabled = config.get<boolean>('enabled'); if (!enabled) { return ''; } </ins> const uri = Uri.parse(host); const authority = uri.authority.replace(/^.*@/, ''); const password = /password/i.test(request);

} private refresh(): void { <del> this.enabled = workspace.getConfiguration('git', null).get('githubAuthentication', true); </del> <ins> const config = workspace.getConfiguration('git', null); this.enabled = config.get<boolean>('enabled', true) && config.get('githubAuthentication', true); </ins> } dispose(): void {

} private refresh(): void { <del> this.enabled = workspace.getConfiguration('git', null).get('terminalAuthentication', true); </del> <ins> const config = workspace.getConfiguration('git', null); this.enabled = config.get<boolean>('enabled', true) && config.get('terminalAuthentication', true); </ins> } dispose(): void {
Change:
Issue Id: <-7afa-11a3-927f-</b<br /<br /Versions <br /- 1.45.0<br /Stack <br /TypeError: Cannot read property 'important' of undefined<br /)<br /at processTicksAndRejections ()<br /<br /at async (index 2)<br /<br /

Discussion:
}); } }); <del> const remotes = getDomainsOfRemotes(content.value.toString(), keys(recommendationByRemote)); remotes.forEach(remote => result.push(recommendationByRemote.get(remote)!)); </del> <ins> const domains = getDomainsOfRemotes(content.value.toString(), keys(recommendationByRemote)); for (const domain of domains) { const remote = recommendationByRemote.get(domain); if (remote) { result.push(remote); } } </ins> } catch (error) { /* Ignore */ } } return result;
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.46.0-Insider OS Version: Ubuntu 20.04 Steps to Reproduce: any folder or workspace terminal to any nested directories. over the path in the terminal. path becomes black. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No ! !
I'm guessing you have a non-transparent color set as in your theme.
How can I override it ?
This setting:
Thank you
Following the instructions you provided I still cannot reproduce this.
The proper fix for this to draw the highlight under the text probably needs to happen. We could do a workaround to make the color partially transparent if it's detected as opaque.
Cool, thanks for the update Just went ahead and merged workaround in dracula theme for the time being. I was finally able to repro on my end :+1:
Can I work on this?
I'll have to do a quick fix on this to squeeze it in for this release.
I have made a quick fix myself. I can push it now and you can take a look.
if it's ready now, sure!

Discussion:
registerThemingParticipant((theme, collector) => { <del> const editorHoverHighlightColor = theme.getColor(editorHoverHighlight); </del> <ins> let editorHoverHighlightColor = theme.getColor(editorHoverHighlight); </ins> if (editorHoverHighlightColor) { <ins> if (editorHoverHighlightColor.isOpaque()) { editorHoverHighlightColor = editorHoverHighlightColor.transparent(0.5); } </ins> collector.addRule(`.integrated-terminal .hoverHighlight { background-color: ${editorHoverHighlightColor}; }`); } const hoverBackground = theme.getColor(editorHoverBackground);
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I would like to drag and drop folders from my local computer in the file explorer of the web-based version of VSCode.
Created this test plan item feel free to edit it.
Cool, I did a few tweaks and increased complexity to 3 by asking to test in all our browsers. Great to see this can be verified in

Discussion:
} private async handleWebExternalDrop(data: DesktopDragAndDropData, target: ExplorerItem, originalEvent: DragEvent): Promise<void> { <del> data.files.forEach(file => { </del> <ins> const items = (originalEvent as any).dataTransfer.items; for (let item of items) { const entry = item.webkitGetAsEntry(); await this.uploadFileEntry(entry, target.resource, target); if (items.length === 1) { await this.editorService.openEditor({ resource: joinPath(target.resource, entry.name), options: { pinned: true } }); } } } private async uploadFileEntry(entry: any, parentResource: URI, target: ExplorerItem | undefined): Promise<void> { const resource = joinPath(parentResource, entry.name); if (entry.isFile) { // Handle file upload if (target && target.getChild(entry.name)) { const { confirmed } = await this.dialogService.confirm(getFileOverwriteConfirm(resource.path)); if (!confirmed) { return; } } const file = await new Promise<File>((resolve, reject) => entry.file(resolve, reject)); </ins> const reader = new FileReader(); reader.readAsArrayBuffer(file); reader.onload = async (event) => { const name = file.name; if (typeof name === 'string' && event.target?.result instanceof ArrayBuffer) { <del> if (target.getChild(name)) { const { confirmed } = await this.dialogService.confirm(getFileOverwriteConfirm(name)); if (!confirmed) { return; } } const resource = joinPath(target.resource, name); </del> await this.fileService.writeFile(resource, VSBuffer.wrap(new Uint8Array(event.target.result))); <del> if (data.files.length === 1) { await this.editorService.openEditor({ resource, options: { pinned: true } }); } </del> } }; <del> }); </del> <ins> } else if (entry.isDirectory) { // Handle folder upload await this.fileService.createFolder(resource); // Recursive upload files in this directory const folderTarget = target && target.getChild(entry.name) || undefined; const dirReader = entry.createReader(); const childEntries = await new Promise<any[]>((resolve, reject) => { dirReader.readEntries(resolve, reject); }); for (let childEntry of childEntries) { await this.uploadFileEntry(childEntry, resource, folderTarget); } } </ins> } private async handleExternalDrop(data: DesktopDragAndDropData, target: ExplorerItem, originalEvent: DragEvent): Promise<void> {
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The [NPM support for VS Code built-in extension][extension] (which automatically detects NPM scripts and provides a UI to run them in the sidebar) has an settting. Currently, this setting only supports the options or . This means it won't work with the [pnpm package manager][pnpm]. Adding a option would be really helpful to users who use pnpm rather than npm or yarn. Both [vscode-eslint][] and [typescript-tslint-plugin][] also already support using pnpm as the preferred Node package manager. I personally use pnpm because its reduced disk space/bandwidth footprint and its architecture both work better for me. I've experimented with just overwriting the value in with , and ignoring the warning from the linter. This seems to work (on macOS), so I'm guessing it might be as simple as adding to the array here: I just don't understand the extensions well enough to be sure that's correct / enough to properly add pnpm. [extension]: [pnpm]: [vscode-eslint]: [typescript-tslint-plugin]: [source]:

Discussion:
- `npm.autoDetect` - Enable detecting scripts as tasks, the default is `on`. - `npm.runSilent` - Run npm script with the `--silent` option, the default is `false`. <del> - `npm.packageManager` - The package manager used to run the scripts: `npm` or `yarn`, the default is `npm`. </del> <ins> - `npm.packageManager` - The package manager used to run the scripts: `npm`, `yarn` or `pnpm`, the default is `npm`. </ins> - `npm.exclude` - Glob patterns for folders that should be excluded from automatic script detection. The pattern is matched against the **absolute path** of the package.json. For example, to exclude all test folders use '&ast;&ast;/test/&ast;&ast;'. - `npm.enableScriptExplorer` - Enable an explorer view for npm scripts. - `npm.scriptExplorerAction` - The default click action: `open` or `run`, the default is `open`.

"type": "string", "enum": [ "npm", <del> "yarn" </del> <ins> "yarn", "pnpm" </ins> ], "default": "npm", "description": "%config.npm.packageManager%"
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: Version: 1.46.0-insider (system setup) OS Version: Windows_NT x64 10.0. Steps to Reproduce: : Configure User Snippets .json example code block 'Print to console' over "prefix" element for tooltip "The prefix to used..." should say "The prefix to use..." <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes

Discussion:
const snippetSchemaProperties: IJSONSchemaMap = { prefix: { <del> description: nls.localize('snippetSchema.json.prefix', 'The prefix to used when selecting the snippet in intellisense'), </del> <ins> description: nls.localize('snippetSchema.json.prefix', 'The prefix to use when selecting the snippet in intellisense'), </ins> type: ['string', 'array'] }, body: {