jiebi/CodeConvo huggingface dataset:
Change:
!
In the chat view responses, users can hit on the link, so we will do the same here.
to verify: run an command that produces file links open the accessible view by focusing that chat response and using move your cursor to the link and press the file should be opened

Discussion:
import { createAndFillInActionBarActions } from 'vs/platform/actions/browser/menuEntryActionViewItem'; import { WorkbenchToolBar } from 'vs/platform/actions/browser/toolbar'; import { IMenuService, MenuId } from 'vs/platform/actions/common/actions'; <ins> import { ICommandService } from 'vs/platform/commands/common/commands'; </ins> import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { IContextViewDelegate, IContextViewService } from 'vs/platform/contextview/browser/contextView';

@IAccessibilityService private readonly _accessibilityService: IAccessibilityService, @IKeybindingService private readonly _keybindingService: IKeybindingService, @ILayoutService private readonly _layoutService: ILayoutService, <del> @IMenuService private readonly _menuService: IMenuService </del> <ins> @IMenuService private readonly _menuService: IMenuService, @ICommandService private readonly _commandService: ICommandService </ins> ) { super();

} } showLastProvider(id: AccessibleViewProviderId): void { if (!this._lastProvider || this._lastProvider.options.id !== id) { return;

}; const disposableStore = new DisposableStore(); disposableStore.add(this._editorWidget.onKeyDown((e) => { <del> if (e.keyCode === KeyCode.Escape || shouldHide(e.browserEvent, this._keybindingService, this._configurationService)) { </del> <ins> if (e.keyCode === KeyCode.Enter) { this._commandService.executeCommand('editor.action.openLink'); } else if (e.keyCode === KeyCode.Escape || shouldHide(e.browserEvent, this._keybindingService, this._configurationService)) { </ins> hide(e); } else if (e.keyCode === KeyCode.KeyH && provider.options.readMoreUrl) { const url: string = provider.options.readMoreUrl;
Change:
New cells being scrolled into view momentarily have widget focus, fire a model change event and picks up an editor selection with all values of .

Discussion:
private _stopAll(): void { // Remove any existing decorations <ins> // TODO: @Yoyokrazy - this triggers as notebooks scroll, causing highlights to disappear momentarily. </ins> this._removeAllDecorations(); // Cancel any renderDecorationsTimer

private _run(): void { let workerRequestIsValid; <del> if (!this.editor.hasWidgetFocus()) { // no focus (new nb cell, etc) </del> <ins> if (!this.editor.hasTextFocus()) { // no focus (new nb cell, etc) </ins> if (WordHighlighter.query === null) { // no previous query, nothing to highlight return;
Change:
]- Identify accessibility bugs before check-in and make bug fixing faster and easier. #A11yTCS; #A11ySev2; #DesktopApp; #Win32; #Visual Studio Code Client; #BM-VisualStudioCodeClient-Win32-Jan2024; #WCAG1.4.11; #Non-text Contrast; #A11yWCAG2.1; Visual Studio Code insider version 1.86.0 Microsoft Windows 11 Enterprise (22H2) OS Build .3007 Visual studio insider the Visual Studio Code Marketplace, go to the GitHub Copilot extension page and click Install. a sample code and press CTRL+I to open the Copilot inline chat. that the contrast ratio of focus is on "Make request" button is (1.787:1) which is less than required. While navigating with Keyboard tab key to the "Make request" button the contrast ratio of focus is (1.787:1) which is less than required. While navigating with Keyboard Tab key to "Make request" button the contrast ratio of focus should be greater than or equal to required (3:1). Keyboard users will face difficulty while navigating through keyboard if the focus is not clearly visible to the user and ratio is less than required. !
Verified the issue in below environment: Visual Studio Code Insider Version: 1.87.0-insider (user setup) Issue is not fixed. Please find attachment for reference. Could you please confirm us in which build the fixes will be available. <img width="785" alt="203773_not fixed" src=""
The focus border now has increased contrast and is now the same colour as everywhere else in VS Code. We don't have any indication from users that this accent colour is a problem anywhere in the dark theme.

Discussion:
.monaco-action-bar .action-item.disabled .action-label, .monaco-action-bar .action-item.disabled .action-label::before, .monaco-action-bar .action-item.disabled .action-label:hover { <del> opacity: 0.6; </del> <ins> color: var(--vscode-disabledForeground); </ins> } /* Vertical actions */
Change:
Type: <bBug</bAn extension that contributes a submenu with a valid icon to is rendered without the icon (screenshot made on mouse hover, without hovering it's not even visible): ! For comparison, the same submenu icon shows fine as a contribution to : ! To reproduce this, I created an empty extension with a simple set of menu contributions. [1] [2] VS Code version: Code - Insiders 1.86.0-insider (, 2024-01-30T03:56:13.017Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 4.18.0-372.19.1.el86.x8664 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
Can you look into why this happens?
I will give it a try.
Since I'm not familiar with either TypeScript or the vscode structure, I don't have a fix, only some random findings. Inspecting the 2 HTML elements (the submenu which does have an icon and the which does not): the working one has an element with ; the broken one has an element with (note the instead of ); For both of these, we eventually construct a , but the call trace for getting there is a bit different: rendering (working fine) in created with an that calls ; calls creates an instance of is set to the expected value based on the object before calling the super () constructor: (not working fine) is created constructor calls the constructor of the super () constructor calls the constructor of the super () the constructor can set a classname for the "More" codicon , but doesn't know what to do for our submenu: so we end up with an untouched class name ("submenu") that was set at the beginning: The difference between the two is that the first one creates an instance of (which extends ), while the second creates directly a . Now, given the separation between and , I'm not sure whether we should just handle the classes for the submenu along the calls in or not. But once we get to the class in , we no longer hold a reference to the that contains the we are interested in. What does work and is probably not how we should handle this is setting the class name from the start in Like I said, I'm a bit out of my depth here, I'm not familiar with the design and how this should be handled, I'm just writing this down in case it helps.
Thank you, that is a very detailed analysis! Will look into it

Discussion:
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { IObjectData, IPooledObject } from './objectPool'; import { ActionRunnerWithContext } from './utils'; <ins> import { createActionViewItem } from 'vs/platform/actions/browser/menuEntryActionViewItem'; </ins> export class TemplateData implements IObjectData { constructor(

shouldForwardArgs: true, }, toolbarOptions: { primaryGroup: g => g.startsWith('navigation') }, <ins> actionViewItemProvider: action => createActionViewItem(_instantiationService, action), </ins> })); }
Change:
Type: <bBug</bCC Screen reader users need to hear redundant information when landed in the comment thread. The following transcript demonstrates what it sounds like: In this message, "Comment from" is redundant because users already know they are interacting with the comment thread. Minimizing the redundant info is cruicial for screen reader users who have to process much information via speech output in a linear fashion. ! Extension version: 0.79. VS Code version: Code - Insiders 1.86.0-insider (, 2024-01-31T03:29:50.526Z) OS version: WindowsNT x64 10.0. Modes: Restricted Connection to 'ssh-remote+' could not be established <details<summarySystem Info</summary Connection to 'ssh-remote+' could not be established </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --

Discussion:
if (element instanceof CommentNode) { if (element.range) { return nls.localize('resourceWithCommentLabel', <del> "Comment from ${0} at line {1} column {2} in {3}, source: {4}", </del> <ins> "${0} at line {1} column {2} in {3}, source: {4}", </ins> element.comment.userName, element.range.startLineNumber, element.range.startColumn,

); } else { return nls.localize('resourceWithCommentLabelFile', <del> "Comment from ${0} in {1}, source: {2}", </del> <ins> "${0} in {1}, source: {2}", </ins> element.comment.userName, basename(element.resource), (typeof element.comment.body === 'string') ? element.comment.body : element.comment.body.value
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.2 OS Version: macos 12.7.3 Steps to Reproduce: Open a file managed by git and split the window by into two parts, A and B. After editing the file on the B side and checking the changes with vscode's git function, and doing other edits on the A side, the cursor will finally jump to the B side.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
I upgraded vscode to the latest version 1.86 and the problem is still there
any idea what is happening here? Is the quick diff widget "moving" the focus to the B side?
I wonder if this issue is being caused by an installed extension. Can you try to run VS Code without extensions? From the command line (NOT the integrated terminal in Code), execute: and try your steps again to see if it reproduces. If you see it is an issue with the extension, please file it against the extension repository itself.
It comes from here:
is this something that you can look at? Thank you!
Do I still need to start vscode with --disable-extensions to test it? I have tried this before, disabling all extensions (all extensions are not disabled), and it all comes up with this problem.
no need. I think that we have all the information for now to further investigate the issue.
Yes, I can look at this.

Discussion:
this._actionbarWidget!.context = [diffEditorModel.modified.uri, providerSpecificChanges, contextIndex]; if (usePosition) { this.show(position, height); <ins> this.editor.setPosition(position); this.editor.focus(); </ins> } <del> this.editor.setPosition(position); this.editor.focus(); </del> } private renderTitle(label: string): void {
Change:
CC <!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Currently vscode will exit 0 if there was a problem using the --install-extension command switch, this makes tools that rely on it forced to parse stderr to verify the result. It should exit 1.
I just tried this and it exits with exit code 1 when there is an error installing extension. Can you please give us more information where it is not happening for you?
!
I clearly see the exit code 1 and installation feature is throwing an error in this case. Hence assigning to to check if he is propagating this error correctly or not
This is running through VS Code's shell scripts, I don't own anything in the pipeline that touches the code here Maybe doesn't propagate Electron's exit code -- I also see the exit code correctly on macOS
I should have clarified this is on Windows and it is in fact using so the problem is likely there. !
thank you! :)

Discussion:
set VSCODE_DEV= set ELECTRON_RUN_AS_NODE=1 "%~dp0..@@NAME@@.exe" "%~dp0..resourcesappoutcli.js" %* <ins> IF %ERRORLEVEL% NEQ 0 EXIT /b %ERRORLEVEL% </ins> endlocal
Change:
Regression from I haven't identified when the issue started happening again. Repro steps: to the Settings editor down on a checkbox or edit an inputbox on an unmodified setting, and wait for the setting to become modified, or click another nearby setting. :bug: The Settings editor settings tree jumps.
I noticed the following: Not rendering the Settings indicator labels does not fix the issue After a setting value changes, is called. Then, when is called during , the setting tree elements are all smushed together. That behaviour is even more dramatic when a setting has a multi-line description. calls , which sets the top of the DOM node to an incorrect value. It looks like the value that is used is an estimate. I believe this estimation process is what causes the settings tree elements to shift upwards and smush together.
Note, the jittering is on the right side, not the tree on the left. Regardless, this looks good to me. I could only repro in Stable on checkboxes, other types of settings didn't show the "jump".

Discussion:
keys.forEach(key => this.settingsTreeModel.updateElementsByName(key)); } <del> // Attempt to render the tree once rather than // once for each key to avoid redundant calls to this.refreshTree() this.renderTree(); </del> <ins> keys.forEach(key => this.renderTree(key)); </ins> } else { this.renderTree(); }

// update `list`s live, as they have a separate "submit edit" step built in before this (focusedSetting.parentElement && !focusedSetting.parentElement.classList.contains('setting-item-list')) ) { this.updateModifiedLabelForKey(key); this.scheduleRefresh(focusedSetting, key); return;

if (key) { const elements = this.currentSettingsModel.getElementsByName(key); if (elements && elements.length) { <del> // TODO https://github.com/microsoft/vscode/issues/57360 this.refreshTree(); </del> <ins> if (elements.length >= 2) { console.warn('More than one setting with key ' + key + ' found'); } this.refreshSingleElement(elements[0]); </ins> } else { // Refresh requested for a key that we don't know about return;

return !!DOM.findParentWithClass(<HTMLElement>this.rootElement.ownerDocument.activeElement, 'context-view'); } <ins> private refreshSingleElement(element: SettingsTreeSettingElement): void { if (this.isVisible()) { this.settingsTree.rerender(element); } } </ins> private refreshTree(): void { if (this.isVisible()) { this.settingsTree.setChildren(null, createGroupIterator(this.currentSettingsModel.root));
Change:
Type: <bBug</bHi, After the recent update on vscode on macOS, I am seeing the debug toolbar stuck to the top left corner of the window when I debug a .java file. And I cannot move it. The options overlap the window maximize, minimize and cancel buttons at the top left corner and are preventing me from clicking the options on the debug toolbar. Please fix this. Thank you. VS Code version: Code 1.86.0 (Universal) (, 2024-01-31T10:29:15.765Z) OS version: Darwin x64 23.2.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ live-sass6.1.2 intellij-idea-keybindings1.5.13 java1.27.0 LiveServer5.7.9 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-java-debug0.56.0 vscode-java-dependency0.23.4 vscode-java-pack0.25.15 vscode-java-test0.40.1 vscode-maven0.44.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Could you share a screenshot? Maybe related to but I wouldn't expect this on mac
It was working correctly (toolbar at the centre of the screen) just before the latest update. Here is what it looks like now: <img width="434" alt="vscode1" src=""
Same problem after the latest update.
same
Same here. Using 1.86. This is incredible annoying to work with.
I've run into the same thing on 1.86 although I was able to grab/move the debug toolbar to the center of my screen (ever so gingerly trying to grab the dots without touching the close window button, it felt like playing the game Operation). It has stayed there since (my is ), but it may not work for you and clearly was something that changed with the update for me as well

Discussion:
const positionPercentage = isMainWindow ? Number(this.storageService.get(DEBUG_TOOLBAR_POSITION_KEY, StorageScope.PROFILE)) : this.auxWindowCoordinates.get(currentWindow)?.x; <del> x = positionPercentage !== undefined </del> <ins> x = positionPercentage !== undefined && !isNaN(positionPercentage) </ins> ? positionPercentage * currentWindow.innerWidth : (0.5 * currentWindow.innerWidth - 0.5 * widgetWidth); }
Change:
Extracted from Electron 27 no longer supports , backend values, refs https://chromium-
Marking as verified based on

Discussion:
// Append Electron flags to Electron if (SUPPORTED_ELECTRON_SWITCHES.indexOf(argvKey) !== -1) { <del> if ( // Color profile argvKey === 'force-color-profile' || // Password store argvKey === 'password-store' ) { if (argvValue) { app.commandLine.appendSwitch(argvKey, argvValue); } } // Others else if (argvValue === true || argvValue === 'true') { </del> <ins> if (argvValue === true || argvValue === 'true') { </ins> if (argvKey === 'disable-hardware-acceleration') { app.disableHardwareAcceleration(); // needs to be called explicitly } else { app.commandLine.appendSwitch(argvKey); } <ins> } else if (argvValue) { if (argvKey === 'force-color-profile') { // Color profile app.commandLine.appendSwitch(argvKey, argvValue); } else if (argvKey === 'password-store') { // Password store let migratedArgvValue = argvValue; if (argvValue === 'gnome' || argvValue === 'gnome-keyring') { migratedArgvValue = 'gnome-libsecret'; } app.commandLine.appendSwitch(argvKey, migratedArgvValue); } </ins> } }
Change:
We believe is better than livePreview and therefore the default should change. Also we want to retire livePreview gracefully, e.g remove the option and then the implementation
Verify that defaults to

Discussion:
// create a new strategy switch (session.editMode) { <del> case EditMode.Live: this._strategy = this._instaService.createInstance(LiveStrategy, session, this._editor, this._zone.value); break; </del> case EditMode.Preview: this._strategy = this._instaService.createInstance(PreviewStrategy, session, this._editor, this._zone.value); break; case EditMode.LivePreview: <del> default: </del> this._strategy = this._instaService.createInstance(LivePreviewStrategy, session, this._editor, this._zone.value); break; <ins> case EditMode.Live: default: this._strategy = this._instaService.createInstance(LiveStrategy, session, this._editor, this._zone.value); break; </ins> } this._session = session;

export const enum EditMode { Live = 'live', <ins> Preview = 'preview', /** @deprecated */ </ins> LivePreview = 'livePreview', <del> Preview = 'preview' </del> } Registry.as<IConfigurationMigrationRegistry>(ExtensionsMigration.ConfigurationMigration).registerConfigurationMigrations(

properties: { [InlineChatConfigKeys.Mode]: { description: localize('mode', "Configure if changes crafted with inline chat are applied directly to the document or are previewed first."), <del> default: EditMode.LivePreview, </del> <ins> default: EditMode.Live, </ins> type: 'string', <del> enum: [EditMode.LivePreview, EditMode.Preview, EditMode.Live], </del> <ins> enum: [EditMode.Live, EditMode.Preview], </ins> markdownEnumDescriptions: [ <del> localize('mode.livePreview', "Changes are applied directly to the document and are highlighted visually via inline or side-by-side diffs. Ending a session will keep the changes."), localize('mode.preview', "Changes are previewed only and need to be accepted via the apply button. Ending a session will discard the changes."), </del> localize('mode.live', "Changes are applied directly to the document, can be highlighted via inline diffs, and accepted/discarded by hunks. Ending a session will keep the changes."), <ins> localize('mode.preview', "Changes are previewed only and need to be accepted via the apply button. Ending a session will discard the changes."), </ins> ], tags: ['experimental'] },

const session = await this._inlineChatSessionService.createSession( editor, <del> { editMode: EditMode.LivePreview }, </del> <ins> { editMode: EditMode.Live }, </ins> token );
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.2 OS Version: MacOS ventura 13.4.1 According to it appears that I should be able to execute the command: or This should open up a specific step of my extension's walkthrough. However whenever I include my I am getting this error when executing the command: <img width="1050" alt="image" src=""As a side note, not including a step id is working just fine, however I would like to be able to open a specific step for this case.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
I don't believe we ever supported this args format for opening a walkthrough step. You can try this instead: vscode.commands.executeCommand('', { category: 'extensionId#walkthroughId', step: 'stepId' }, false);
Tried this and it will open the walkthrough, however it will not open the step that is specified.
Could you please share the code snippet you used to execute this command?
here it is! (sorry for the delay) EDIT: this may be related or not but throughout tesing with this snippet I somehow managed to get two welcome pages at once in the editor <img width="264" alt="image" src=""
vscode.commands.executeCommand('', , false);
! !

Discussion:
if (walkthroughID) { const selectedCategory = typeof walkthroughID === 'string' ? walkthroughID : walkthroughID.category; <del> const selectedStep = typeof walkthroughID === 'string' ? undefined : walkthroughID.step; </del> <ins> const selectedStep = typeof walkthroughID === 'string' ? undefined : walkthroughID.category + '#' + walkthroughID.step; </ins> // We're trying to open the welcome page from the Help menu if (!selectedCategory && !selectedStep) {

this.editorInput.selectedCategory = categoryID; this.editorInput.selectedStep = stepId; this.currentWalkthrough = ourCategory; <del> this.buildCategorySlide(categoryID); </del> <ins> this.buildCategorySlide(categoryID, stepId); </ins> this.setSlide('details'); }); }