jiebi/CodeConvo huggingface dataset:
Change:
Notebooks: ! Editor: ! Version: 1.90.0-insider Commit: Date: 2024-05-28T05:48:32.492Z Electron: 29.4.0 ElectronBuildId: Chromium: 122.0.6261.156 20.9.0 V8: 12.2.281.27-electron.0 OS: Darwin arm64 23.4.0

Discussion:
const NLS_FIND_INPUT_LABEL = nls.localize('label.find', "Find"); const NLS_FIND_INPUT_" = nls.localize('placeholder.find', "Find"); const NLS_PREVIOUS_MATCH_BTN_LABEL = nls.localize('label.previousMatchButton', "Previous Match"); <del> // const NLS_FILTER_BTN_LABEL = nls.localize('label.findFilterButton', "Search in View"); </del> const NLS_NEXT_MATCH_BTN_LABEL = nls.localize('label.nextMatchButton', "Next Match"); <del> const NLS_FIND_IN_CELL_SELECTION_BTN_LABEL = nls.localize('label.findInCellSelectionButton', "Find in Cell Selection"); </del> <ins> const NLS_TOGGLE_SELECTION_FIND_TITLE = nls.localize('label.toggleSelectionFind', "Find in Selection"); </ins> const NLS_CLOSE_BTN_LABEL = nls.localize('label.closeButton', "Close"); const NLS_TOGGLE_REPLACE_MODE_BTN_LABEL = nls.localize('label.toggleReplaceButton', "Toggle Replace"); const NLS_REPLACE_INPUT_LABEL = nls.localize('label.replace', "Replace");

const NOTEBOOK_FIND_IN_CODE_INPUT = nls.localize('notebook.find.filter.findInCodeInput', "Code Cell Source"); const NOTEBOOK_FIND_IN_CODE_OUTPUT = nls.localize('notebook.find.filter.findInCodeOutput', "Code Cell Output"); <del> const NOTEBOOK_FIND_WIDGET_INITIAL_WIDTH = 318; </del> <ins> const NOTEBOOK_FIND_WIDGET_INITIAL_WIDTH = 419; </ins> const NOTEBOOK_FIND_WIDGET_INITIAL_HORIZONTAL_PADDING = 4; class NotebookFindFilterActionViewItem extends DropdownMenuActionViewItem { constructor(readonly filters: NotebookFindFilters, action: IAction, options: IActionViewItemOptions, actionRunner: IActionRunner, @IContextMenuService contextMenuService: IContextMenuService) {

null, this._contextViewService, { <ins> // width:FIND_INPUT_AREA_WIDTH, </ins> label: NLS_FIND_INPUT_LABEL, placeholder: NLS_FIND_INPUT_", validation: (value: string): InputBoxMessage | null => {

this.inSelectionToggle = this._register(new Toggle({ icon: findSelectionIcon, <del> title: NLS_FIND_IN_CELL_SELECTION_BTN_LABEL, </del> <ins> title: NLS_TOGGLE_SELECTION_FIND_TITLE, </ins> isChecked: false, inputActiveOptionBackground: asCssVariable(inputActiveOptionBackground), inputActiveOptionBorder: asCssVariable(inputActiveOptionBorder),
Change:
Testing Used Cat sample extension to test this. Please correct me if I misunderstood something the following code to the end of the method (so it runs on activation) extension Log: =This is expected, consent has not been given yet a chat message using the participant () Consent is requested =Accept the extension Log: Consent has been given by now, so the expected response would be ? When sending another message, consent is not requested again.
Nice find!
<!-- UNABLETOLOCATECOMMITMESSAGE issue --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased

Discussion:
continue; } <ins> // make sure auth information is correct if (this._isUsingAuth(extension.identifier, data.metadata)) { await this._fakeAuthPopulate(data.metadata); } </ins> let apiObject = data.apiObjects.get(extension.identifier); if (!apiObject) {

private async _fakeAuthPopulate(metadata: ILanguageModelChatMetadata): Promise<void> { <ins> if (!metadata.auth) { return; } </ins> for (const from of this._languageAccessInformationExtensions) { try { await this._getAuthAccess(from, { identifier: metadata.extension, displayName: '' }, undefined, true);
Change:
Testing ubuntu chromium 125.0.6422.76 (Official Build) snap (64-bit) F1 Report Issue :bug: the initial size is too small, there are no scrollbars :bug: when resizing the input field grows so that I never see a full submit button <img width="1938" alt="Screenshot 2024-05-28 at 12 05 11" src=""
Same issue on Edge on Windows.
noted! realized i styles only for

Discussion:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> .mac.web.issue-reporter-body { </del> <ins> .web.issue-reporter-body { </ins> position: absolute; overflow-y: scroll; }
Change:
The icon should be right above line 2, but it's all the way up at the beginning of line 1. !
this should be fixed with the new lightbulb changes!
Still able to reproduce this. long text and enable word wrap the cursor on line 2 and press Ctrl + . ! ESC Ctrl + . again !
Still able to repro. If I repeat steps 3 and 4, I notice that the sparkle alternates between the two lines. Edit: might have to wait for new Insiders.
I see similar to what saw, but the second time it didn't show at all: ! ! I'll push this to September as it doesn't meet the bar to fix at this point imo.
not sure why it removed the unreleased since this commit hasn't been released yet
It's good now

Discussion:
private _gutterState: LightBulbState.State = LightBulbState.Hidden; private _iconClasses: string[] = []; <ins> private readonly lightbulbClasses = [ 'codicon-' + GUTTER_LIGHTBULB_ICON.id, 'codicon-' + GUTTER_LIGHTBULB_AIFIX_AUTO_FIX_ICON.id, 'codicon-' + GUTTER_LIGHTBULB_AUTO_FIX_ICON.id, 'codicon-' + GUTTER_LIGHTBULB_AIFIX_ICON.id, 'codicon-' + GUTTER_SPARKLE_FILLED_ICON.id ]; </ins> private _preferredKbLabel?: string; private _quickFixKbLabel?: string;

})); this._register(this._editor.onMouseDown(async (e: IEditorMouseEvent) => { <del> const lightbulbClasses = [ 'codicon-' + GUTTER_LIGHTBULB_ICON.id, 'codicon-' + GUTTER_LIGHTBULB_AIFIX_AUTO_FIX_ICON.id, 'codicon-' + GUTTER_LIGHTBULB_AUTO_FIX_ICON.id, 'codicon-' + GUTTER_LIGHTBULB_AIFIX_ICON.id, 'codicon-' + GUTTER_SPARKLE_FILLED_ICON.id ]; if (!e.target.element || !lightbulbClasses.some(cls => e.target.element && e.target.element.classList.contains(cls))) { </del> <ins> if (!e.target.element || !this.lightbulbClasses.some(cls => e.target.element && e.target.element.classList.contains(cls))) { </ins> return; }

let hasDecoration = false; if (currLineDecorations) { for (const decoration of currLineDecorations) { <del> if (decoration.options.glyphMarginClassName) { </del> <ins> const glyphClass = decoration.options.glyphMarginClassName; if (glyphClass && !this.lightbulbClasses.some(className => glyphClass.includes(className))) { </ins> hasDecoration = true; break; }
Change:
Testing I found "Find in Cell Selection" confusing label for the button given it is to find in selected cells. Does it make sense? Would "Find in Selected Cells" be a bit easier? !
Yeah, agreed that the labeling isn't perfect. Will workshop this in the next iteration, as this button will be serving dual purpose as a way to search in textual selections within a cell, as well as searching in multi-cell selections as the feature is currently. Thanks for the feedback!

Discussion:
const NLS_FIND_INPUT_LABEL = nls.localize('label.find', "Find"); const NLS_FIND_INPUT_" = nls.localize('placeholder.find', "Find"); const NLS_PREVIOUS_MATCH_BTN_LABEL = nls.localize('label.previousMatchButton', "Previous Match"); <del> // const NLS_FILTER_BTN_LABEL = nls.localize('label.findFilterButton', "Search in View"); </del> const NLS_NEXT_MATCH_BTN_LABEL = nls.localize('label.nextMatchButton', "Next Match"); <del> const NLS_FIND_IN_CELL_SELECTION_BTN_LABEL = nls.localize('label.findInCellSelectionButton', "Find in Cell Selection"); </del> <ins> const NLS_TOGGLE_SELECTION_FIND_TITLE = nls.localize('label.toggleSelectionFind', "Find in Selection"); </ins> const NLS_CLOSE_BTN_LABEL = nls.localize('label.closeButton', "Close"); const NLS_TOGGLE_REPLACE_MODE_BTN_LABEL = nls.localize('label.toggleReplaceButton', "Toggle Replace"); const NLS_REPLACE_INPUT_LABEL = nls.localize('label.replace', "Replace");

const NOTEBOOK_FIND_IN_CODE_INPUT = nls.localize('notebook.find.filter.findInCodeInput', "Code Cell Source"); const NOTEBOOK_FIND_IN_CODE_OUTPUT = nls.localize('notebook.find.filter.findInCodeOutput', "Code Cell Output"); <del> const NOTEBOOK_FIND_WIDGET_INITIAL_WIDTH = 318; </del> <ins> const NOTEBOOK_FIND_WIDGET_INITIAL_WIDTH = 419; </ins> const NOTEBOOK_FIND_WIDGET_INITIAL_HORIZONTAL_PADDING = 4; class NotebookFindFilterActionViewItem extends DropdownMenuActionViewItem { constructor(readonly filters: NotebookFindFilters, action: IAction, options: IActionViewItemOptions, actionRunner: IActionRunner, @IContextMenuService contextMenuService: IContextMenuService) {

null, this._contextViewService, { <ins> // width:FIND_INPUT_AREA_WIDTH, </ins> label: NLS_FIND_INPUT_LABEL, placeholder: NLS_FIND_INPUT_", validation: (value: string): InputBoxMessage | null => {

this.inSelectionToggle = this._register(new Toggle({ icon: findSelectionIcon, <del> title: NLS_FIND_IN_CELL_SELECTION_BTN_LABEL, </del> <ins> title: NLS_TOGGLE_SELECTION_FIND_TITLE, </ins> isChecked: false, inputActiveOptionBackground: asCssVariable(inputActiveOptionBackground), inputActiveOptionBorder: asCssVariable(inputActiveOptionBorder),
Change:
Testing There no documentation on signalOptions: ! There is some documentation on the leaf properties in the JSON, but it is unclear what refers to.
I think the request was to have an overall description for the setting, as right now there's nothing until a user starts to complete properties in the <img width="636" alt="image" src=""

Discussion:
'properties': { 'general': { 'type': 'object', <ins> 'description': 'Delays for all signals besides error and warning at position', </ins> 'additionalProperties': false, 'properties': { 'announcement': {

mac: { primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.PageDown, }, weight: KeybindingWeight.WorkbenchContrib, }, <ins> // to </ins> icon: Codicon.arrowRight, menu: {
Change:
Testing There no documentation on signalOptions: ! There is some documentation on the leaf properties in the JSON, but it is unclear what refers to.
I think the request was to have an overall description for the setting, as right now there's nothing until a user starts to complete properties in the <img width="636" alt="image" src=""

Discussion:
default: true }, 'accessibility.signalOptions': { <ins> description: 'Configures the behavior of signals (audio cues and announcements) in the workbench. Includes volume, debounce position changes, and delays for different types of signals.', </ins> type: 'object', additionalProperties: false, properties: {
Change:
Follow the setup in to trigger hover to focus into hover to focus a hover part to trigger accessibility help wording makes it sound like I can use from within the accessible view to cycle through the hover parts, but in reality I need to be focused on the hover first. !
Hi yes you are absolutely right. I will change the wording of that string.

Discussion:
import { Disposable, IDisposable } from 'vs/base/common/lifecycle'; namespace HoverAccessibilityHelpNLS { <del> export const intro = localize('intro', "The hover widget is focused. Press the Tab key to cycle through the hover parts."); </del> <ins> export const intro = localize('intro', "Focus on the hover widget to cycle through the hover parts with the Tab key."); </ins> export const increaseVerbosity = localize('increaseVerbosity', "- The focused hover part verbosity level can be increased with the Increase Hover Verbosity command<keybinding:{0}>.", INCREASE_HOVER_VERBOSITY_ACTION_ID); export const decreaseVerbosity = localize('decreaseVerbosity', "- The focused hover part verbosity level can be decreased with the Decrease Hover Verbosity command<keybinding:{0}>.", DECREASE_HOVER_VERBOSITY_ACTION_ID); export const hoverContent = localize('contentHover', "The last focused hover content is the following.");
Change:
doesn't seem to exist in any of our 'es
Are you looking at an old version of
Oops, no it's right there
guess I'm not sure whether to link or just remove it since it's not the first entrypoint to making a request
<!-- UNABLETOLOCATECOMMITMESSAGE repo --Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the label directly, or comment .

Discussion:
/** * An object that keeps information about how this extension can use language models. * <del> * @see {@link lm.sendChatRequest} </del> <ins> * @see {@link LanguageModelChat.sendRequest} </ins> */ readonly languageModelAccessInformation: LanguageModelAccessInformation; }
Change:
When hovering over any setting with the "object" structure there is a rendering issue on the right side of the row. See screenshot attached. !
Edit: this effects all settings with type "object", not related to screen readers. Repros with all screen reader related apps turned off.
I now but this is it intel they give my money

Discussion:
class: ThemeIcon.asClassName(settingsEditIcon), enabled: true, id: 'workbench.action.editListItem', <del> label: this.getLocalizedStrings().editActionTooltip, </del> <ins> label: '', </ins> tooltip: this.getLocalizedStrings().editActionTooltip, run: () => this.editSetting(idx) },

class: ThemeIcon.asClassName(settingsRemoveIcon), enabled: true, id: 'workbench.action.removeListItem', <del> label: this.getLocalizedStrings().deleteActionTooltip, </del> <ins> label: '', </ins> tooltip: this.getLocalizedStrings().deleteActionTooltip, run: () => this._onDidChangeList.fire({ originalItem: item, item: undefined, targetIndex: idx }) });

class: ThemeIcon.asClassName(settingsDiscardIcon), enabled: true, id: 'workbench.action.resetListItem', <del> label: this.getLocalizedStrings().resetActionTooltip, </del> <ins> label: '', </ins> tooltip: this.getLocalizedStrings().resetActionTooltip, run: () => this._onDidChangeList.fire({ originalItem: item, item: undefined, targetIndex: idx }) });
Change:
Testing Alt+k should open a quickpick which allows us to configure the keybindings but it's not working on Windows: !
reverting fixes this issue for me. Would you pls take a look?
It looks like the issue is now we call when the editor widget is blurred. Commenting out this code fixes the issue:
Hi thank you for taking the time to look into it.

Discussion:
private _accessibleViewInCodeBlock: IContextKey<boolean>; private _accessibleViewContainsCodeBlocks: IContextKey<boolean>; private _codeBlocks?: ICodeBlock[]; <ins> private _inQuickPick: boolean = false; </ins> get editorWidget() { return this._editorWidget; } private _container: HTMLElement;

} configureKeybindings(): void { <del> const items = this._currentProvider?.options?.configureKeybindingItems; const provider = this._currentProvider; </del> <ins> this._inQuickPick = true; const provider = this._updateLastProvider(); const items = provider?.options?.configureKeybindingItems; </ins> if (!items) { return; }

this.show(provider); } quickPick.dispose(); <ins> this._inQuickPick = false; </ins> }); }

this._updateToolbar(this._currentProvider.actions, provider.options.type); const hide = (e?: KeyboardEvent | IKeyboardEvent): void => { <del> provider.onClose(); </del> <ins> if (!this._inQuickPick) { provider.onClose(); } </ins> e?.stopPropagation(); this._contextViewService.hideContextView(); this._updateContextKeys(provider, false);
Change:
Abort was from a network timeout, re-run should be fine for this case. However, the following is an error which has been present for a while unnoticed I will use this issue to address it.

Discussion:
let expectedName; switch (platform) { case 'win32': <del> expectedName = `win-${arch}/node.exe`; </del> <ins> expectedName = product.nodejsRepository !== 'https://nodejs.org' ? `win-${arch}-node.exe` : `win-${arch}/node.exe`; </ins> break; case 'darwin':
Change:
! Version: 1.90.0-insider Commit: Date: 2024-05-29T05:50:53.996Z Electron: 29.4.0 ElectronBuildId: Chromium: 122.0.6261.156 20.9.0 V8: 12.2.281.27-electron.0 OS: Darwin arm64 23.5.0
hey yes thank you for posting this issue. I am precisely investigating this issue right now, it is likely to be caused by the following PR
Feel free to close if it's a duplicate or something

Discussion:
background-color: var(--vscode-editor-hoverHighlightBackground); } <ins> .monaco-editor .monaco-hover-content { padding-right: 2px; box-sizing: border-box; } </ins> .monaco-editor .monaco-hover { color: var(--vscode-editorHoverWidget-foreground); background-color: var(--vscode-editorHoverWidget-background);
Change:
Can this support right click to toggle the setting to hidden? !
right click shows our terminal context menu, perhaps we should just put it in there rather than adding a new one? !
this isn't a feature the others offer, thus not a bug IMO

Discussion:
import { TerminalInitialHintSettingId } from 'vs/workbench/contrib/terminalContrib/chat/common/terminalInitialHintConfiguration'; import { ChatAgentLocation, IChatAgent, IChatAgentService } from 'vs/workbench/contrib/chat/common/chatAgents'; import { IStorageService, StorageScope, StorageTarget } from 'vs/platform/storage/common/storage'; <ins> import { IContextMenuService } from 'vs/platform/contextview/browser/contextView'; import { StandardMouseEvent } from 'vs/base/browser/mouseEvent'; </ins> const $ = dom.$;

} registerTerminalContribution(TerminalInitialHintContribution.ID, TerminalInitialHintContribution, false); class TerminalInitialHintWidget extends Disposable {

@ITelemetryService private readonly telemetryService: ITelemetryService, @IProductService private readonly productService: IProductService, @ITerminalService private readonly terminalService: ITerminalService, <del> @IStorageService private readonly _storageService: IStorageService </del> <ins> @IStorageService private readonly _storageService: IStorageService, @IContextMenuService private readonly contextMenuService: IContextMenuService </ins> ) { super(); this.toDispose.add(_instance.onDidFocus(() => {

this.domNode = undefined; })); <ins> this.toDispose.add(dom.addDisposableListener(this.domNode, dom.EventType.CONTEXT_MENU, (e) => { this.contextMenuService.showContextMenu({ getAnchor: () => { return new StandardMouseEvent(dom.getActiveWindow(), e); }, getActions: () => { return [{ id: 'workench.action.disableTerminalInitialHint', label: localize('disableInitialHint', "Disable Initial Hint"), tooltip: localize('disableInitialHint', "Disable Initial Hint"), enabled: true, class: undefined, run: () => this.configurationService.updateValue(TerminalInitialHintSettingId.Enabled, false) } ]; } }); })); </ins> } return this.domNode; }

import { IStringDictionary } from 'vs/base/common/collections'; import { localize } from 'vs/nls'; import { IConfigurationPropertySchema } from 'vs/platform/configuration/common/configurationRegistry'; <del> import product from 'vs/platform/product/common/product'; </del> export const enum TerminalInitialHintSettingId { Enabled = 'terminal.integrated.initialHint'

restricted: true, markdownDescription: localize('terminal.integrated.initialHint', "Controls if the first terminal without input will show a hint about available actions when it is focused."), type: 'boolean', <del> default: product.quality !== 'stable' </del> <ins> default: true </ins> } };
Change:
With the new REPL from Python extension merged, user has to explicitly set in their in order to execute via Enter Keypress when using interactive Native REPL. They won't have to manually change this setting once the default value for interactiveWindow.execute is changed to True in core. In order to provide closer experience to the traditional Python interactive interpreter experience (pressing enter would smartly execute or wait for more complete code), we should change the default value for interative.execute to be True. Users who explicitly set their are respected at the current moment in a way that their settings are respected when using Python extension's native REPL to shift+enter or enter. Related:

Discussion:
}, ['interactiveWindow.executeWithShiftEnter']: { type: 'boolean', <del> default: true, </del> <ins> default: false, </ins> markdownDescription: localize('interactiveWindow.executeWithShiftEnter', "Execute the interactive window (REPL) input box with shift+enter, so that enter can be used to create a newline.") } }
Change:
Steps to Reproduce: an pre-release version of an extension to release version and restart extension host back to pre-release version and refresh extensions view Extension is still release version

Discussion:
source: this.source instanceof URI ? 'vsix' : 'gallery', }; <ins> let local: ILocalExtension | undefined; </ins> // VSIX if (this.source instanceof URI) { if (existingExtension) {

: this.options.installPreReleaseVersion || this.source.properties.isPreReleaseVersion || existingExtension?.preRelease; if (existingExtension && existingExtension.type !== ExtensionType.System && existingExtension.manifest.version === this.source.version) { <del> return this.extensionsScanner.updateMetadata(existingExtension, metadata); } // Unset if the extension is uninstalled and return the unset extension. const local = await this.unsetIfUninstalled(this.extensionKey); if (local) { return local; </del> <ins> local = await this.extensionsScanner.updateMetadata(existingExtension, metadata); } else { // Unset if the extension is uninstalled and return the unset extension. local = await this.unsetIfUninstalled(this.extensionKey); </ins> } }

throw toExtensionManagementError(new CancellationError()); } <del> const { local, verificationStatus } = await this.extractExtensionFn(this.operation, token); this._verificationStatus = verificationStatus; </del> <ins> if (!local) { const result = await this.extractExtensionFn(this.operation, token); local = result.local; this._verificationStatus = result.verificationStatus; } </ins> if (this.uriIdentityService.extUri.isEqual(this.userDataProfilesService.defaultProfile.extensionsResource, this.options.profileLocation)) { try {
Change:
Steps to Reproduce: an pre-release version of an extension to release version and restart extension host back to pre-release version and refresh extensions view Extension is still release version

Discussion:
source: this.source instanceof URI ? 'vsix' : 'gallery', }; <ins> let local: ILocalExtension | undefined; </ins> // VSIX if (this.source instanceof URI) { if (existingExtension) {

: this.options.installPreReleaseVersion || this.source.properties.isPreReleaseVersion || existingExtension?.preRelease; if (existingExtension && existingExtension.type !== ExtensionType.System && existingExtension.manifest.version === this.source.version) { <del> return this.extensionsScanner.updateMetadata(existingExtension, metadata); </del> <ins> return this.extensionsScanner.updateMetadata(existingExtension, metadata, this.options.profileLocation); </ins> } // Unset if the extension is uninstalled and return the unset extension. <del> const local = await this.unsetIfUninstalled(this.extensionKey); if (local) { return local; } </del> <ins> local = await this.unsetIfUninstalled(this.extensionKey); </ins> } if (token.isCancellationRequested) { throw toExtensionManagementError(new CancellationError()); } <del> const { local, verificationStatus } = await this.extractExtensionFn(this.operation, token); this._verificationStatus = verificationStatus; </del> <ins> if (!local) { const result = await this.extractExtensionFn(this.operation, token); local = result.local; this._verificationStatus = result.verificationStatus; } </ins> if (this.uriIdentityService.extUri.isEqual(this.userDataProfilesService.defaultProfile.extensionsResource, this.options.profileLocation)) { try {
Change:
<img width="589" alt="image" src=""We have padding on codespans in some other places where they have a background color. Here, the padding just adds extra space that looks wrong.

Discussion:
margin-top: 0; } <del> .review-widget .body .comment-body code { border-radius: 3px; padding: 0 0.4em; } </del> .review-widget .body .comment-body span { white-space: pre; }