jiebi/CodeConvo huggingface dataset:
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Use Help Report Issue to prefill these. --- Extension version: v0.58.0 VSCode Version: 1.75.0 (system setup) OS: Windows_NT x64 10.0. Steps to Reproduce: a comment during a review with the contents "2." (as in: please do the second option among your suggestions) the comment in the extension and it will show "1." (probably because it is rendered as a markdown list) This small/simple issue would have lead to a huge misunderstanding if I would not have been suspicious of the answer and not checked the comment on the web UI.
can you share a screen shot of what you're describing?
Hey thanks for looking into this. Here are the screenshots you have requested. View within GitHub Web ! View within the Extension ! Hope it helps.
I looked at the markdown renderer options but I don't see a way to prevent this behavior. Does this seem like a bug in to you?

Discussion:
const defaultDomPurifyConfig = Object.freeze<dompurify.Config & { RETURN_TRUSTED_TYPE: true }>({ ALLOWED_TAGS: ['a', 'button', 'blockquote', 'code', 'div', 'h1', 'h2', 'h3', 'h4', 'h5', 'h6', 'hr', 'input', 'label', 'li', 'p', 'pre', 'select', 'small', 'span', 'strong', 'textarea', 'ul', 'ol'], <del> ALLOWED_ATTR: ['href', 'data-href', 'data-command', 'target', 'title', 'name', 'src', 'alt', 'class', 'id', 'role', 'tabindex', 'style', 'data-code', 'width', 'height', 'align', 'x-dispatch', 'required', 'checked', 'placeholder', 'type'], </del> <ins> ALLOWED_ATTR: ['href', 'data-href', 'data-command', 'target', 'title', 'name', 'src', 'alt', 'class', 'id', 'role', 'tabindex', 'style', 'data-code', 'width', 'height', 'align', 'x-dispatch', 'required', 'checked', 'placeholder', 'type', 'start'], </ins> RETURN_DOM: false, RETURN_DOM_FRAGMENT: false, RETURN_TRUSTED_TYPE: true

'target', 'title', 'width', <ins> 'start', </ins> ]; function getSanitizerOptions(options: { readonly isTrusted?: boolean | MarkdownStringTrustedOptions }): { config: dompurify.Config; allowedSchemes: string[] } {
Change:
Type: <bBug</b! VS Code version: Code - Insiders 1.76.0-insider (, 2023-02-16T05:23:44.671Z) OS version: Windows_NT x64 10.0. Modes: Sandboxed: Yes /assign <!-- generated by issue reporter --
Thanks! This is also a regression because we are only supposed to show it on files with decorations (such as source control) or overflowing text (such as ).
I don't get this custom hover ever. Can you please add steps to verify?
These custom hovers have been removed from product due to being too buggy at the moment. I will just mark this as verified as this feature isn't ready for testing yet.

Discussion:
let hoverWidget: UpdatableHoverWidget | undefined; const hideHover = (disposeWidget: boolean, disposePreparation: boolean) => { <ins> const hadHover = hoverWidget !== undefined; </ins> if (disposeWidget) { hoverWidget?.dispose(); hoverWidget = undefined;

hoverPreparation?.dispose(); hoverPreparation = undefined; } <del> hoverDelegate.onDidHideHover?.(); </del> <ins> if (hadHover) { hoverDelegate.onDidHideHover?.(); } </ins> }; const triggerShowHover = (delay: number, focus?: boolean, target?: IHoverDelegateTarget) => {

get delay() { // Delay implementation borrowed froms src/vs/workbench/browser/parts/statusbar/statusbarPart.ts <del> if (Date.now() - this.lastHoverHideTime < 200) { </del> <ins> if (Date.now() - this.lastHoverHideTime < 500) { </ins> return 0; // show instantly when a hover was recently shown }

overflowed = width <= childWidth; } <del> const hasDecoration = element.classList.toString().includes('monaco-decoration-iconBadge'); </del> <ins> // Only count decorations that provide additional info, as hover overing decorations such as git excluded isn't helpful const hasDecoration = options.content.toString().includes('•'); </ins> // If it's overflowing or has a decoration show the tooltip overflowed = overflowed || hasDecoration;

...options, target: indentGuideElement, compact: true, <ins> container: row, </ins> additionalClasses: ['explorer-item-hover'], skipFadeInAnimation: true, showPointer: false,
Change:
a notebook cell that will create a long stacktrace :bug: "Output exceeds the size limit" message is shown on a non-scrollable element

Discussion:
stack.style.margin = '8px 0'; const element = document.createElement('span'); <del> insertOutput(outputInfo.id, [err.stack ?? ''], ctx.settings.lineLimit, false, element, true); </del> <ins> insertOutput(outputInfo.id, [err.stack ?? ''], ctx.settings.lineLimit, ctx.settings.outputScrolling, element, true); </ins> stack.appendChild(element); container.appendChild(stack); } else {
Change:
Type: <bBug</bClose all editor windows/processes In any arbitrary directory that does not contain , start vscode to create , e.g. Objserve that an empty tag named is also opened. VS Code version: Code 1.75.1 (, 2023-02-08T21:32:34.589Z) OS version: WindowsNT x64 10.0. Modes: Restricted Sandboxed: No <details<summarySystem Info</summary </detailsExtensions disabled<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
This originates from here: The editor just makes sure that dirty documents are made visible.

Discussion:
import { languages, workspace, Disposable, TextDocument, Uri, Diagnostic, Range, DiagnosticSeverity, Position, env, l10n } from 'vscode'; import { INormalizedVersion, normalizeVersion, parseVersion } from './extensionEngineValidation'; <ins> import { TextDecoder } from 'util'; </ins> const product = JSON.parse(fs.readFileSync(path.join(env.appRoot, 'product.json'), { encoding: 'utf-8' })); const allowedBadgeProviders: string[] = (product.extensionAllowedBadgeProviders || []).map((s: string) => s.toLowerCase());

private timer: NodeJS.Timer | undefined; private markdownIt: MarkdownItType.MarkdownIt | undefined; private parse5: typeof import('parse5') | undefined; <ins> private textDecoder = new TextDecoder(); </ins> constructor() { this.disposables.push(

} const file = folder.with({ path: path.posix.join(folder.path, 'package.json') }); try { <del> const document = await workspace.openTextDocument(file); return parseTree(document.getText()); </del> <ins> const fileContents = await workspace.fs.readFile(file); // #174888 return parseTree(this.textDecoder.decode(fileContents)); </ins> } catch (err) { return undefined; }
Change:
Testing open search viewlet drag explorer (activity icon) into search pane all explorer views are now in the search pane it is not possible to drag the file/folder view back into the explorer https://user-
verified since the empty explorer is gone

Discussion:
storageId: 'workbench.explorer.views.state', icon: explorerViewIcon, alwaysUseContainerInfo: true, <ins> hideIfEmpty: true, </ins> order: 0, openCommandActionDescriptor: { id: VIEWLET_ID,
Change:
Testing Have the following notebook cell Notice that the output is the text editor. Cursor should be an editor cursor, and not the default cursor.
Thanks for the fix. Works nicely -verified

Discussion:
box-sizing: border-box; border-width: 1px; border-color: transparent; <ins> cursor: text; } #container div.output .scrollable a { cursor: pointer; </ins> } #container div.output .scrollable.more-above { box-shadow: var(--vscode-scrollbar-shadow) 0 6px 6px -6px inset
Change:
Testing nothing in the dev tools console indicates there's an issue though
I think a good fix would be to not show the action when utility process is used. But there is no counter part unfortunately.

Discussion:
import { IFileService } from 'vs/platform/files/common/files'; import { INativeWorkbenchEnvironmentService } from 'vs/workbench/services/environment/electron-sandbox/environmentService'; import { URI } from 'vs/base/common/uri'; <ins> import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey'; </ins> export class ToggleDevToolsAction extends Action2 {

id: 'workbench.action.toggleSharedProcess', title: { value: localize('toggleSharedProcess', "Toggle Shared Process"), original: 'Toggle Shared Process' }, category: Categories.Developer, <ins> precondition: ContextKeyExpr.has('config.window.experimental.sharedProcessUseUtilityProcess').negate(), </ins> f1: true }); }
Change:
Testing Testing with the native dialog on mac and seeing two cancel buttons when I am asked for workspace trust. This occurred when I did the following steps a trusted workspace the command palette to change to change that workspace to untrusted the window <img width="1521" alt="Screenshot 2023-02-21 at 10 59 05 AM" src="https://user-"after clicking "cancel" it then showed this error prompt: <img width="1728" alt="Screenshot 2023-02-21 at 10 59 21 AM" src="https://user-"
Ok I tried to reproduce this issue again following the steps I outlined above and it didn't work so feel free to close the issue if it doesn't come up for you.
Good catch, looking at the code I see that this might happen.

Discussion:
{ markdown: new MarkdownString(localize('immediateTrustRequestLearnMore', "If you don't trust the authors of these files, we do not recommend continuing as the files may be malicious. See [our docs](https://aka.ms/vscode-workspace-trust) to learn more.")) } ] }, <del> buttons: buttons.map(button => { </del> <ins> buttons: buttons.filter(b => b.type !== 'Cancel').map(button => { </ins> return { label: button.label, run: () => button.type
Change:
Testing ! Is this expected?
it looks like 8 should still be a multiplier from the description. good catch
! now I have ALL THE SPACE... I think this is verified

Discussion:
markdownDescription: nls.localize('notebook.textOutputLineLimit', "Controls how many lines of text are displayed in a text output. If {0} is enabled, this setting is used to determine the scroll height of the output.", '`#notebook.output.scrolling#`'), type: 'number', default: 30, <del> tags: ['notebookLayout', 'notebookOutputLayout'] </del> <ins> tags: ['notebookLayout', 'notebookOutputLayout'], minimum: 1, </ins> }, [NotebookSetting.markupFontSize]: { markdownDescription: nls.localize('notebook.markup.fontSize', "Controls the font size in pixels of rendered markup in notebooks. When set to {0}, 120% of {1} is used.", '`0`', '`#editor.fontSize#`'),

} private _computeOutputLineHeight(lineHeight: number, outputFontSize: number): number { <del> const minimumLineHeight = 8; </del> <ins> const minimumLineHeight = 9; </ins> if (lineHeight === 0) { // use editor line height
Change:
<img width="425" alt="image" src="https://user-""wether" should be "whether"

Discussion:
'workbench.editor.centeredLayoutFixedWidth': { 'type': 'boolean', 'default': false, <del> 'description': localize('centeredLayoutDynamicWidth', "Controls wether the centered layout tries to maintain constant width when the window is resized.") </del> <ins> 'description': localize('centeredLayoutDynamicWidth', "Controls whether the centered layout tries to maintain constant width when the window is resized.") </ins> }, 'workbench.editor.limit.enabled': { 'type': 'boolean',
Change:
use safari open open TS initialises forever, console shows the error below
After , this now works fine in Safari tech preview. I suspect there's an issue with our nested worker polyfil but am still looking into this
I've tried debugging what is going on here but can't figure it out (and safari's dev tools are certainly not helping) What I suspect is that our nested worker polyfill causes a message to be dropped somewhere, possibly because a message port is started early or never started Given that everything works in safari tech preview though and given that don't plan on shipping project wide intellisense until cross origin isolation is enabled, this is a lower priority. Un-assigning from this month
I believe this all works in Safari 16.4 which nested worker support. Not sure what the issue was with our nested worker polyfill (note that needs to be merged too to see this working end to end)

Discussion:
} protected readWatchOptions(configuration: vscode.WorkspaceConfiguration): Proto.WatchOptions | undefined { <del> return configuration.get<Proto.WatchOptions>('typescript.tsserver.watchOptions'); </del> <ins> const watchOptions = configuration.get<Proto.WatchOptions>('typescript.tsserver.watchOptions'); // Returned value may be a proxy. Clone it into a normal object return { ...(watchOptions ?? {}) }; </ins> } protected readIncludePackageJsonAutoImports(configuration: vscode.WorkspaceConfiguration): 'auto' | 'on' | 'off' | undefined {

}); port.addEventListener('message', msg => { <del> globalThis.dispatchEvent(new MessageEvent('message', { data: msg.data })); </del> <ins> globalThis.dispatchEvent(new MessageEvent('message', { data: msg.data, ports: msg.ports ? [...msg.ports] : undefined })); </ins> }); port.start();
Change:
Looks like has some statements. This is fair for local development but shouldn't be shipping in the product.

Discussion:
private static _deserializeRegexValue(serializedValue: string): RegExp | null { if (isFalsyOrWhitespace(serializedValue)) { <del> console.warn('missing regexp-value for =~-expression'); </del> return null; } const start = serializedValue.indexOf('/'); const end = serializedValue.lastIndexOf('/'); <del> if (start === end || start < 0 /* || to < 0 */) { console.warn(`bad regexp-value '${serializedValue}', missing /-enclosure`); </del> <ins> if (start === end || start < 0) { </ins> return null; }

const caseIgnoreFlag = serializedValue[end + 1] === 'i' ? 'i' : ''; try { return new RegExp(value, caseIgnoreFlag); <del> } catch (e) { console.warn(`bad regexp-value '${serializedValue}', parse error: ${e}`); </del> <ins> } catch (_e) { </ins> return null; } }

let regex: RegExp | null = null; <del> if (isFalsyOrWhitespace(serializedValue)) { console.warn('missing regexp-value for =~-expression'); } else { </del> <ins> if (!isFalsyOrWhitespace(serializedValue)) { </ins> const start = serializedValue.indexOf('/'); const end = serializedValue.lastIndexOf('/'); <del> if (start === end || start < 0 /* || to < 0 */) { console.warn(`bad regexp-value '${serializedValue}', missing /-enclosure`); } else { </del> <ins> if (start !== end && start >= 0) { </ins> const value = serializedValue.slice(start + 1, end); const caseIgnoreFlag = serializedValue[end + 1] === 'i' ? 'i' : ''; try { regex = new RegExp(value, caseIgnoreFlag); <del> } catch (e) { console.warn(`bad regexp-value '${serializedValue}', parse error: ${e}`); } </del> <ins> } catch (_e) { } </ins> } } <ins> if (regex === null) { throw this._errExpectedButGot('REGEX', expr); } </ins> return ContextKeyRegexExpr.create(key, regex); }
Change:
Type: <bBug</b! VS Code version: Code - Insiders 1.76.0-insider (, 2023-02-22T05:24:32.270Z) OS version: Windows_NT x64 10.0. Modes: Sandboxed: Yes <!-- generated by issue reporter --
This part of in-preparation release notes will also need updating:

Discussion:
*/ readonly uri: string; /** <del> * The format options </del> <ins> * The sort options </ins> */ readonly options: SortOptions; }

"json.maxItemsComputed.desc": "The maximum number of outline symbols and folding regions computed (limited for performance reasons).", "json.maxItemsExceededInformation.desc": "Show notification when exceeding the maximum number of outline symbols and folding regions.", "json.enableSchemaDownload.desc": "When enabled, JSON schemas can be fetched from http and https locations.", <del> "json.command.clearCache": "Clear schema cache", "json.command.sort": "Sort document" </del> <ins> "json.command.clearCache": "Clear Schema Cache", "json.command.sort": "Sort Document" </ins> }

*/ uri: string; /** <del> * The format options </del> <ins> * The sort options </ins> */ options: SortOptions; }
Change:
an untitled workspace (e.g. open and use to add ) browser URI to clipboard <img width="746" alt="image" src="https://user-"url into browser :bug: fails to open workspace <img width="509" alt="image" src="https://user-"Should this command prompt to save the open workspace if it's not saved already (or just point to the user root directory)?
Also, this action always copies a url-encoded filepath, e.g. becomes , which also yields a "Workspace does not exist" warning message.

Discussion:
import { IOpenerService } from 'vs/platform/opener/common/opener'; import { Action } from 'vs/base/common/actions'; import { IClipboardService } from 'vs/platform/clipboard/common/clipboardService'; <del> import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace'; </del> <ins> import { IWorkspaceContextService, isUntitledWorkspace } from 'vs/platform/workspace/common/workspace'; </ins> import { Schemas } from 'vs/base/common/network'; import { URI } from 'vs/base/common/uri'; import { joinPath } from 'vs/base/common/resources';

let resource; if (folders.length === 1) { resource = folders[0].uri; <del> } else if (workspace.configuration) { </del> <ins> } else if (workspace.configuration && !isUntitledWorkspace(workspace.configuration, this.environmentService)) { </ins> resource = workspace.configuration; } const link = URI.parse(connectionInfo.link);
Change:
CC With today's insider update, no longer able to precisely identify the starting and ending point of an error via Left/RightArrows because you will hear error audio cues in the whole columns instead of the specific error columns. -by-column (Left/RightArrow) navigation: previous behavior is ideal. Error audio cue needs to be played only on the error-causing columns instead of the whole columns. -by-line (Up/DownArrow) navigation: current behavior is good. If there is an error in the currently focused line (even though current column focus is not at the error column position), error audio cue needs to be played. I now understand that 1. and 2. may not be addressed altogether because VSCode does not know whether users have approached the current cursor position via "line-by-line" or "column-by-column" navigation. In any event that you need to take only one method, 1. (the previous approach) is more logical and robust. Version: 1.76.0-insider (system setup) Commit: Date: 2023-02-24T06:18:04.880Z Electron: 19.1.10 Chromium: 102.0.5005.196 16.14.2 V8: 10.2.154.26-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes
we only play the audio cue when 1) the line changes and there's an error on the line or 2) when the column changes and there's an error at the current column position. Can you pls indicate a scenario you've encountered where the behavior is not ideal/unexpected?
related
Here's how it works currently: Left/right arrow navigation plays the error audio cue when within an error range when right arrow is used on the last column of the line and the line it jumps to contains an error Up /down arrow navigation plays an audio cue when it lands on an error line
column position. As far as I tested with today's insiders, I hear audio cue even outside the error range in any column positions when I use Left/RightArrows as long as the line contains an error. This is unexpected.
That is unexpected and I cannot reproduce on mac. I'll try windows
works for me on windows. here's an example that works for me - where the error is just
found a way to reproduce the issue
repro: insert and navigate via left and right arrow keys. you should only hear the error for the underlined section IE

Discussion:
.some( (m) => { const onLine = m.severity === this.severity && m.startLineNumber <= position.lineNumber && position.lineNumber <= m.endLineNumber; <del> return lineChanged ? onLine : onLine && (position.lineNumber <= m.endLineNumber && m.startColumn <= position.column); </del> <ins> return lineChanged ? onLine : onLine && (position.lineNumber <= m.endLineNumber && m.startColumn <= position.column && m.endColumn >= position.column); </ins> }); return hasMarker; },
Change:
<!-- Do Not Delete This! bugreporttemplate --Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.76.0 Insiders OS Version: Windows 11, macOS 12.6.3 Steps to Reproduce: the vscode-docs repo and open the release notes file Markdown Preview .mp4 videos such as used in the "Rich Content Notebook Search" section don't render. ! 75.1 Stable still show .mp4 videos with auto start rendering correctly. !
I'm able to reproduce with the same OS and VS Code versions.
Repro's on macOS as well
this works for me in .dev <img width="1334" alt="image" src="https://user-"But doesn't work on desktop
looks like the initiators are different for the network requests in / insider's network request in ! network request in insider's !
Confirmed that this issue also affects the in-product release notes. !
When refactoring the patches on how ffmpeg build flavors are produced for different flavors of internal builds, was removed from the list of supported demuxers leading to the above regression.
closedWith

Discussion:
}); } exports.config = { <del> version: product.electronRepository ? '19.1.10' : util.getElectronVersion(), </del> <ins> version: product.electronRepository ? '19.1.11' : util.getElectronVersion(), </ins> productAppName: product.nameLong, companyName: 'Microsoft Corporation', copyright: 'Copyright (C) 2022 Microsoft. All rights reserved',

}; } async function main(arch = process.arch) { <del> const version = product.electronRepository ? '19.1.10' : util.getElectronVersion(); </del> <ins> const version = product.electronRepository ? '19.1.11' : util.getElectronVersion(); </ins> const electronPath = path.join(root, '.build', 'electron'); const versionFile = path.join(electronPath, 'version'); const isUpToDate = fs.existsSync(versionFile) && fs.readFileSync(versionFile, 'utf8') === `${version}`;

} export const config = { <del> version: product.electronRepository ? '19.1.10' : util.getElectronVersion(), </del> <ins> version: product.electronRepository ? '19.1.11' : util.getElectronVersion(), </ins> productAppName: product.nameLong, companyName: 'Microsoft Corporation', copyright: 'Copyright (C) 2022 Microsoft. All rights reserved',

} async function main(arch = process.arch): Promise<void> { <del> const version = product.electronRepository ? '19.1.10' : util.getElectronVersion(); </del> <ins> const version = product.electronRepository ? '19.1.11' : util.getElectronVersion(); </ins> const electronPath = path.join(root, '.build', 'electron'); const versionFile = path.join(electronPath, 'version'); const isUpToDate = fs.existsSync(versionFile) && fs.readFileSync(versionFile, 'utf8') === `${version}`;

"git": { "name": "chromium", "repositoryUrl": "https://chromium.googlesource.com/chromium/src", <del> "commitHash": "a8a8309404d39efa9c624d7aee0e27562721e522" </del> <ins> "commitHash": "61305fe71c4357662f161ba689fd9a1828d5e4f7" </ins> } }, "licenseDetail": [

"SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE." ], "isOnlyProductionDependency": true, <del> "version": "102.0.5005.194" </del> <ins> "version": "102.0.5005.196" </ins> }, { "component": {