Change:
Testing It doesn't seem to matter what I set the new settings to. They are never mentioned in the editor accessbility help. ! !
By design, you have to enable screen reader mode to see this
Maybe we shld also include it when not in screen reader mode?
Might be worth updating the TPI then, since I assumed it should always be there. The language seems backwards: <img width="478" alt="image" src=""
It also doesn't mention the settings, and my understanding is that if the settings are disabled, then the settings will take effect. I have those still turned on.
The reason I didn't mention those here is they're linked to in the ones I do mention, so a user will discover them.
I will use this issue to track making sure these show up in the help dialog regardless of screen reader optimized mode

Discussion:
import { CommentCommandId } from 'vs/workbench/contrib/comments/common/commentCommandIds'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { AudioCue } from 'vs/platform/audioCues/browser/audioCueService'; <del> import { AccessibleNotificationEvent, IAccessibilityService, IAccessibleNotificationService } from 'vs/platform/accessibility/common/accessibility'; </del> <ins> import { AccessibleNotificationEvent, IAccessibleNotificationService } from 'vs/platform/accessibility/common/accessibility'; </ins> export class EditorAccessibilityHelpContribution extends Disposable { static ID: 'editorAccessibilityHelpContribution';

private readonly _editor: ICodeEditor, @IKeybindingService private readonly _keybindingService: IKeybindingService, @IContextKeyService private readonly _contextKeyService: IContextKeyService, <del> @IConfigurationService private readonly _configurationService: IConfigurationService, @IAccessibilityService private readonly _accessibilityService: IAccessibilityService </del> <ins> @IConfigurationService private readonly _configurationService: IConfigurationService </ins> ) { }

content.push(AccessibilityHelpNLS.editableEditor); } } <del> const screenReaderOptimized = this._accessibilityService.isScreenReaderOptimized(); if (screenReaderOptimized) { const saveAudioCue = this._configurationService.getValue(AudioCue.save.settingsKey); switch (saveAudioCue) { case 'never': content.push(AccessibilityHelpNLS.saveAudioCueDisabled); break; case 'always': content.push(AccessibilityHelpNLS.saveAudioCueAlways); break; case 'userGesture': content.push(AccessibilityHelpNLS.saveAudioCueUserGesture); break; } const formatAudioCue = this._configurationService.getValue(AudioCue.format.settingsKey); switch (formatAudioCue) { case 'never': content.push(AccessibilityHelpNLS.formatAudioCueDisabled); break; case 'always': content.push(AccessibilityHelpNLS.formatAudioCueAlways); break; case 'userGesture': content.push(AccessibilityHelpNLS.formatAudioCueUserGesture); break; } </del> <ins> const saveAudioCue = this._configurationService.getValue(AudioCue.save.settingsKey); switch (saveAudioCue) { case 'never': content.push(AccessibilityHelpNLS.saveAudioCueDisabled); break; case 'always': content.push(AccessibilityHelpNLS.saveAudioCueAlways); break; case 'userGesture': content.push(AccessibilityHelpNLS.saveAudioCueUserGesture); break; } const formatAudioCue = this._configurationService.getValue(AudioCue.format.settingsKey); switch (formatAudioCue) { case 'never': content.push(AccessibilityHelpNLS.formatAudioCueDisabled); break; case 'always': content.push(AccessibilityHelpNLS.formatAudioCueAlways); break; case 'userGesture': content.push(AccessibilityHelpNLS.formatAudioCueUserGesture); break; </ins> } const commentCommandInfo = getCommentCommandInfo(this._keybindingService, this._contextKeyService, this._editor);