jiebi/CodeConvo huggingface dataset:
Change:
Issue Type: <bBug</bRepro settings editor, search for Bugs <img width="588" alt="Screen Shot 2020-03-16 at 10 04 28 PM" src="https://user-"In the settings UI: If I don't know what ligatures are, the description is not useful. Maybe link to our documentation? The description also does not explain the font features part. Maybe have an example? I have to use the settings json editor to actually change this setting. I suspect the most common use of this setting is turning it on or off In the settings json editor: It was not clear to me at first how to configure the font features (for a while, I thought it was supposed to be an object instead of a string) If you have and hover over the string, the description of what this string does is very generic VS Code version: Code - Insiders 1.44.0-insider (, 2020-03-16T07:10:59.884Z) OS version: Darwin x64 19.3.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
I'm moving this to backlog since this is more of debt/polish item (it's not one we'd expect users to search out and vote for)

Discussion:
anyOf: [ { type: 'boolean', <del> description: nls.localize('fontLigatures', "Enables/Disables font ligatures."), </del> <ins> description: nls.localize('fontLigatures', "Enables/Disables font ligatures ('calt' and 'liga' font features). Change this to a string for fine-grained control of the 'font-feature-settings' CSS property."), </ins> }, { type: 'string', <del> description: nls.localize('fontFeatureSettings', "Explicit font-feature-settings.") </del> <ins> description: nls.localize('fontFeatureSettings', "Explicit 'font-feature-settings' CSS property. A boolean can be passed instead if one only needs to turn on/off ligatures.") </ins> } ], <del> description: nls.localize('fontLigaturesGeneral', "Configures font ligatures or font features."), </del> <ins> description: nls.localize('fontLigaturesGeneral', "Configures font ligatures or font features. Can be either a boolean to enable/disable ligatures or a string for the value of the CSS 'font-feature-settings' property."), </ins> default: false } );
Change:
Create UI extension with a 'machine' scoped setting Load that UI extension in a remote window See a message in local settings that this setting can only be set on the remote If I understand correctly, since the extension is local, the setting should be set locally, right?
Irrespective of where extension is running, machine scoped settings are always ignored from local settings and can be applied only from remote settings. Closing this as designed. If there is a reason or use case to allow in local settings, let me know.
Ok, the scope description needs to be fixed then: I guess it should say "in a remote/local window" instead of referencing where the extension is running. My use case was that there are remote resolver settings which should not be synced because they reference local paths, and I don't think there is a way to do that.
Yup, you are right. Description needs to be fixed.
Should this be a feature request?
I see.. you cannot tag them as machine settings because in the remote window they are not respected. I will reopen this as a feature request for this use case.
You can already do this by setting property on the setting. This is not shown in the intellisense though - it.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

Discussion:
{ type: 'object', properties: { <del> isExecutable: { type: 'boolean', markdownDeprecationMessage: 'This property is deprecated. Instead use `scope` property and set it to `machine` value.' }, </del> scope: { type: 'string', enum: ['application', 'machine', 'window', 'resource', 'language-overridable', 'machine-overridable'],

order: { type: 'integer', description: nls.localize('scope.order', 'When specified, gives the order of this setting relative to other settings within the same category. Settings with an order property will be placed before settings without this property set.') <del> } </del> <ins> }, ignoreSync: { type: 'boolean', description: nls.localize('scope.ignoreSync', 'When enabled, Settings Sync will not sync the user value of this configuration by default.') }, </ins> } } ]
Change:
Git extension needs to use the context and add keybindings only when that context is set. Ctrl/Cmd + K, Cltr/Cmd + S / R / U makes good sense for defaults. fyi
Some shortcut confilcts: <kbdCmd</kbd<kbdK</kbd<kbdCmd</kbd<kbdS</kbdis used by show keyboard shortcuts. <kbdCmd</kbd<kbdK</kbd<kbdCmd</kbd<kbdU</kbdis used by remove line comment.
thanks for pointing out. Yeah we need to find some free keybindings. However this would only be in the diff editor view. So even if we overwrite some like those I think it is fine.
I suppose we could overwrite , but I don't think it'd be best to overwrite, as that's a settings page and we'll probably get an issue or too about that sometime down the road. <kbdCmd</kbd<kbdK</kbd<kbdCmd</kbd<kbdG</kbdis free, perhaps implement another chord? But maybe another accessibility issue for nested chords...
Following discussion at , I would like to work on this issue, too. I also think that we should not override "Open Keyboard Shortcuts". Since staging, is (in my mind) connected with "git add", maybe we could use Ctrl/Cmd + K,Ctrl/Cmd + A While Ctrl/Cmd + K,Ctrl/Cmd + G is also free, but the 'G' key is close to the 'R' key, so it's easier to call the Revert command by mistake.
Forgive my ignorance, but would it be possible to use something like ctrl + k ctrl + shift + s or ctrl + k alt + s? Thanks.
OK, so I am sending a PR with the following keybindings: git: Stage selected ranges ctrl + k, ctrl + shift + s git: Unstage selected ranges ctrl + k, ctrl + u git: Revert selected ranges ctrl + k, ctrl + r
Actually git: Stage selected ranges ctrl + k, ctrl + alt + s is better because ctrl + k, ctrl + shift + s is used for Saving without Formatting.
Great, thanks a lot. I have commented on the PR. As mentioned in the PR is back from vacation and this is not urgent, thus assigning to him and April milestone.
Thanks for the quick review. However I found another possible conflict with the default keybindings. On my VS Code version which I have downloaded and installed, Ctrl + K Ctrl + R - the keybinding we want to assign to Revert Selected Ranges- is used by the command "Help: Keyboard Shortcuts Reference". However this command is not available on the version of VSCode I built from the source code, that's why I did not notice it at first. For some reason KeybindingsReferenceAction.AVAILABLE is false and the command is not registered: Also I don't understand why the GitHub CI threw an error. Should I worry about it?
Please note that due to conflict with the uncomment line which mentioned I had to change the unstange from to

Discussion:
"category": "Git" } ], <ins> "keybindings": [ { "command": "git.stageSelectedRanges", "key": "ctrl+k ctrl+alt+s", "mac": "cmd+k cmd+alt+s", "when": "isInDiffEditor" }, { "command": "git.unstageSelectedRanges", "key": "ctrl+k ctrl+u", "mac": "cmd+k cmd+u", "when": "isInDiffEditor" }, { "command": "git.revertSelectedRanges", "key": "ctrl+k ctrl+r", "mac": "cmd+k cmd+r", "when": "isInDiffEditor" } ], </ins> "menus": { "commandPalette": [ {
Change:
Version: 1.44.0-insider (user setup) Commit: Date: 2020-03-31T08:23:56.446Z Electron: 7.1.11 Chrome: 78.0.3904.130 12.8.1 V8: 7.8.279.23-electron.0 OS: Windows_NT x64 10.0. Minor issue obviously but it's would probably feel smoother if the top didn't flash whenever you press page down. This indicates to me that rendering is happening between the selection and scroll values are updated as a result of page down firing. Shouldn't they be done at the same time? Holding page down showing the problem: ! Pressing page down showing the problem: !
It's pretty much the same what happens with the Windows file explorer. We can do better, tho! I suggest to clear focus, scroll, set focus iff there is space left to scroll.

Discussion:
this.setFocus([lastPageIndex], browserEvent); } } else { <ins> this.setFocus([]); </ins> const previousScrollTop = this.view.getScrollTop(); this.view.setScrollTop(previousScrollTop + this.view.renderHeight - this.view.elementHeight(lastPageIndex));

this.setFocus([firstPageIndex], browserEvent); } } else { <ins> this.setFocus([]); </ins> const previousScrollTop = scrollTop; this.view.setScrollTop(scrollTop - this.view.renderHeight);
Change:
testing I signed into two accounts (cdias @ and chris @ ), and then signed out of the account. The result: !
I'm getting this error on Ubuntu 20.04 with my GitHub sign-in. I've only used the single account on this machine, so no idea why this started occurring.
Using Ubuntu 20.04 with the latest VS code build. Although the error is slightly different. !
Hi I'm in the same situation Any help will be apreciated King regards Version: 1.50.1 Commit: Date: 2020-10-13T14:44:48.716Z Electron: 9.2.1 Chrome: 83.0.4103.122 12.14.1 V8: 8.3.110.13-electron.0 OS: Linux x64 5.4.0-52-generic snap (Ubuntu 20.04.1 LTS)
Try
it's already installed. I have Ubuntu 20.04.1 LTS !
I UPDATE... Magically solved for me. The way... first I login into official addon Github Pull Request and after enable sync for Github
I think the best we can do here is just add some retry logic as I've seen this every once and a while and reloading the window seems to work.
verification steps: Turn on settings sync and log in with your Microsoft account... then log out... then log in... then log out... (repeat until you don't wanna do it anymore). You shouldn't see the error above.

Discussion:
async setPassword(windowId: number | undefined, service: string, account: string, password: string): Promise<void> { const keytar = await this.withKeytar(); <ins> const MAX_SET_ATTEMPTS = 3; // Sometimes Keytar has a problem talking to the keychain on the OS. To be more resilient, we retry a few times. const setPasswordWithRetry = async (service: string, account: string, password: string) => { let attempts = 0; let error: any; while (attempts < MAX_SET_ATTEMPTS) { try { await keytar.setPassword(service, account, password); return; } catch (e) { error = e; this.logService.warn('Error attempting to set a password: ', e); attempts++; await new Promise(resolve => setTimeout(resolve, 200)); } } // throw last error throw error; }; </ins> if (isWindows && password.length > NativeHostMainService.MAX_PASSWORD_LENGTH) { let index = 0;

hasNextChunk: hasNextChunk }; <del> await keytar.setPassword(service, chunk ? `${account}-${chunk}` : account, JSON.stringify(content)); </del> <ins> await setPasswordWithRetry(service, chunk ? `${account}-${chunk}` : account, JSON.stringify(content)); </ins> chunk++; } } else { <del> await keytar.setPassword(service, account, password); </del> <ins> await setPasswordWithRetry(service, account, password); </ins> } this._onDidChangePassword.fire({ service, account });
Change:
Version: 1.44.0-insider Commit: Date: 2020-03-31T08:28:37.335Z The extensions view header has all the important information about an extension, but not the installed or latest version number. I often need this when filing issues to a extension. !

Discussion:
preview: HTMLElement; builtin: HTMLElement; license: HTMLElement; <ins> version: HTMLElement; </ins> publisher: HTMLElement; installCount: HTMLElement; rating: HTMLElement;

license.style.display = 'none'; license.tabIndex = 0; <ins> const version = append(subtitle, $('span.version')); version.textContent = localize('version', 'Version'); version.style.display = 'none'; version.tabIndex = 0; </ins> const description = append(details, $('.description')); const extensionActions = append(details, $('.actions'));

icon, iconContainer, identifier, <ins> version, </ins> ignoreActionbar, installCount, license,

template.name.textContent = extension.displayName; template.identifier.textContent = extension.identifier.id; <ins> template.version.textContent = extension.version; template.version.style.display = 'inherit'; </ins> template.preview.style.display = extension.preview ? 'inherit' : 'none'; template.builtin.style.display = extension.type === ExtensionType.System ? 'inherit' : 'none';
Change:
Refs ! the topmost three events are in the future, but they're all shown as "now" admittedly lunar calendar is a bit of a silly example, but I think its reasonable for people to try to use this to show, for instance, "code freeze in 7 days", "sprint ends in 3 days", "endgame week starts in 2 weeks", etc.

Discussion:
} const seconds = Math.round((new Date().getTime() - date) / 1000); <del> if (seconds < 30) { </del> <ins> if (seconds < -30) { return `in ${fromNow(new Date().getTime() + seconds * 1000, false)}`; } else if (seconds < 30) { </ins> return localize('date.fromNow.now', 'now'); }
Change:
re This uses VS Code as hard-coded name, not the product name This reads a little cumbersome, why not "Text Editor" and as description (built-in) <img width="361" alt="Screenshot 2020-04-03 at 13 46 27" src="https://user-"
Fixed by

Discussion:
export const defaultEditorId = 'default'; <ins> const builtinProviderDisplayName = nls.localize('builtinProviderDisplayName', "Built-in"); </ins> const defaultEditorInfo = new CustomEditorInfo({ id: defaultEditorId, <del> displayName: nls.localize('promptOpenWith.defaultEditor', "VS Code's standard text editor"), </del> <ins> displayName: nls.localize('promptOpenWith.defaultEditor.displayName', "Text Editor"), providerDisplayName: builtinProviderDisplayName, </ins> selector: [ { filenamePattern: '*' } ],

this.add(new CustomEditorInfo({ id: webviewEditorContribution.viewType, displayName: webviewEditorContribution.displayName, <ins> providerDisplayName: extension.description.isBuiltin ? builtinProviderDisplayName : extension.description.displayName || extension.description.identifier.value, </ins> selector: webviewEditorContribution.selector || [], priority: getPriorityFromContribution(webviewEditorContribution, extension.description), }));

description: editorDescriptor.id === currentlyOpenedEditorType ? nls.localize('openWithCurrentlyActive', "Currently Active") : undefined, <ins> detail: editorDescriptor.providerDisplayName, </ins> buttons: resourceExt ? [{ iconClass: 'codicon-settings-gear', tooltip: nls.localize('promptOpenWith.setDefaultTooltip', "Set as default editor for '{0}' files", resourceExt)

public readonly id: string; public readonly displayName: string; <ins> public readonly providerDisplayName: string | undefined; </ins> public readonly priority: CustomEditorPriority; public readonly selector: readonly CustomEditorSelector[]; constructor(descriptor: { readonly id: string; readonly displayName: string; <ins> readonly providerDisplayName: string | undefined; </ins> readonly priority: CustomEditorPriority; readonly selector: readonly CustomEditorSelector[]; }) { this.id = descriptor.id; this.displayName = descriptor.displayName; <ins> this.providerDisplayName = descriptor.providerDisplayName; </ins> this.priority = descriptor.priority; this.selector = descriptor.selector; }
Change:
have a custom editor that is registered for -files play with it change its selector to :bug: still open all JSON files... <img width="1044" alt="Screenshot 2020-04-03 at 16 12 20" src="https://user-"
Yes for the contribution, looks like we handle that contain a slash specially: We should do the same here

Discussion:
import { Event } from 'vs/base/common/event'; import * as glob from 'vs/base/common/glob'; import { IDisposable, IReference } from 'vs/base/common/lifecycle'; <ins> import { posix } from 'vs/base/common/path'; </ins> import { basename } from 'vs/base/common/resources'; import { URI } from 'vs/base/common/uri'; import { RawContextKey } from 'vs/platform/contextkey/common/contextkey';

static selectorMatches(selector: CustomEditorSelector, resource: URI): boolean { if (selector.filenamePattern) { <del> if (glob.match(selector.filenamePattern.toLowerCase(), basename(resource).toLowerCase())) { </del> <ins> const matchOnPath = selector.filenamePattern.indexOf(posix.sep) >= 0; const target = matchOnPath ? resource.path : basename(resource); if (glob.match(selector.filenamePattern.toLowerCase(), target.toLowerCase())) { </ins> return true; } }
Change:
<!-- Do Not Delete This! bugreporttemplate --- VSCode Version: 1.44 Insiders OS Version: Windows 10 CodeLens should be one word. The new command display name should be changed from: "Show Code Lens Commands For Current Line" to: "Show CodeLens Commands For Current Line"

Discussion:
"command.compare": "Compare Current Conflict", "config.title": "Merge Conflict", "config.autoNavigateNextConflictEnabled": "Whether to automatically navigate to the next merge conflict after resolving a merge conflict.", <del> "config.codeLensEnabled": "Create a Code Lens for merge conflict blocks within editor.", </del> <ins> "config.codeLensEnabled": "Create a CodeLens for merge conflict blocks within editor.", </ins> "config.decoratorsEnabled": "Create decorators for merge conflict blocks within editor.", "config.diffViewPosition": "Controls where the diff view should be opened when comparing changes in merge conflicts.", "config.diffViewPosition.current": "Open the diff view in the current editor group.", "config.diffViewPosition.beside": "Open the diff view next to the current editor group.", "config.diffViewPosition.below": "Open the diff view below the current editor group." <del> } </del>  No newline at end of file <ins> } </ins>

export const editorRuler = registerColor('editorRuler.foreground', { dark: '#5A5A5A', light: Color.lightgrey, hc: Color.white }, nls.localize('editorRuler', 'Color of the editor rulers.')); <del> export const editorCodeLensForeground = registerColor('editorCodeLens.foreground', { dark: '#999999', light: '#999999', hc: '#999999' }, nls.localize('editorCodeLensForeground', 'Foreground color of editor code lenses')); </del> <ins> export const editorCodeLensForeground = registerColor('editorCodeLens.foreground', { dark: '#999999', light: '#999999', hc: '#999999' }, nls.localize('editorCodeLensForeground', 'Foreground color of editor CodeLens')); </ins> export const editorBracketMatchBackground = registerColor('editorBracketMatch.background', { dark: '#0064001a', light: '#0064001a', hc: '#0064001a' }, nls.localize('editorBracketMatchBackground', 'Background color behind matching brackets')); export const editorBracketMatchBorder = registerColor('editorBracketMatch.border', { dark: '#888', light: '#B9B9B9', hc: contrastBorder }, nls.localize('editorBracketMatchBorder', 'Color for matching brackets boxes'));

super({ id: 'codelens.showLensesInCurrentLine', precondition: EditorContextKeys.hasCodeLensProvider, <del> label: localize('showLensOnLine', "Show Code Lens Commands For Current Line"), alias: 'Show Code Lens Commands For Current Line', </del> <ins> label: localize('showLensOnLine', "Show CodeLens Commands For Current Line"), alias: 'Show CodeLens Commands For Current Line', </ins> }); }
Change:
Issue Type: <bBug</bBug does not provide a default setting snippet has a property that is no longer used VS Code version: Code - Insiders 1.44.0-insider (, 2020-04-03T22:09:44.908Z) OS version: Darwin x64 19.3.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --

Discussion:
'properties': { [customEditorsAssociationsKey]: { type: 'array', <del> markdownDescription: nls.localize('editor.editorAssociations', "Configure which editor to use for a resource."), </del> <ins> markdownDescription: nls.localize('editor.editorAssociations', "Configure which editor to use for specific file types."), </ins> items: { type: 'object', <ins> defaultSnippets: [{ body: { 'viewType': '$1', 'filenamePattern': '$2' } }], </ins> properties: { 'viewType': { type: 'string', <del> description: nls.localize('editor.editorAssociations.viewType', "Editor view type."), }, 'mime': { type: 'string', description: nls.localize('editor.editorAssociations.mime', "Mime type the editor should be used for. This is used for binary files."), </del> <ins> description: nls.localize('editor.editorAssociations.viewType', "The unique id of the editor to use."), </ins> }, 'filenamePattern': { type: 'string', <del> description: nls.localize('editor.editorAssociations.filenamePattern', "Glob pattern the editor should be used for."), </del> <ins> description: nls.localize('editor.editorAssociations.filenamePattern', "Glob pattern specifying which files the editor should be used for."), </ins> } } }
Change:
see: ! //cc
Good catch
To Verify: Panel to Right/Left dropping a view into the panel. feedback is horizontally split instead of vertically.

Discussion:
return; } <del> overlay = new ViewPaneDropOverlay(pane.dropTargetElement, this.options.orientation ?? Orientation.VERTICAL, this.themeService); </del> <ins> overlay = new ViewPaneDropOverlay(pane.dropTargetElement, this.orientation ?? Orientation.VERTICAL, this.themeService); </ins> } if (dropData.type === 'composite' && dropData.id !== this.viewContainer.id) {

const viewsToMove = this.viewDescriptorService.getViewDescriptors(container).allViewDescriptors; if (viewsToMove.length === 1 && viewsToMove[0].canMoveView) { <del> overlay = new ViewPaneDropOverlay(pane.dropTargetElement, this.options.orientation ?? Orientation.VERTICAL, this.themeService); </del> <ins> overlay = new ViewPaneDropOverlay(pane.dropTargetElement, this.orientation ?? Orientation.VERTICAL, this.themeService); </ins> } }