jiebi/CodeConvo huggingface dataset:
Change:
VSCode Version: 1.27.2 OS Version: Windows 10 Enterprise 1803 Build .345 Steps to Reproduce: Pre Condition: Dual monitor setup. Screen 1 on top of Screen 2. Screen 1 Scale set to 150% Screen 2 Scale set to 125% Visual studio code open with a python script on Screen 1. down some p-thon the cursor back a few char positions and make note. the vs code app from Screen 1 to Screen 2 where it resizes. the relocation of the cursor. your code and note that the cursor does not match the output text. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Unsure. Note: I am unsure if this is a Windows 10 bug or Visual Studio code bug but I have not noticed this on other software at the time of this bug report. In the meantime I have aligned my screen scaling as a work around for this issue.
This is caused by scaling difference. The bigger the scaling difference, the more evident. I have my surface book 2's main monitor set to 150% scaling, and my external monitor set to 100% scaling. Leaving VSCode open after the monitor switch will result in bad the cursor alignment. The workaround is to restart VSCode.

Discussion:
this.setFullScreen(false); this.setFullScreen(true); } <ins> this.sendWhenReady('vscode:displayChanged'); </ins> }, 100)); const displayChangedListener = () => simpleFullScreenScheduler.schedule();

import { AutoSaveMode, IFilesConfigurationService } from 'vs/workbench/services/filesConfiguration/common/filesConfigurationService'; import { Event } from 'vs/base/common/event'; import { INativeWorkbenchEnvironmentService } from 'vs/workbench/services/environment/electron-browser/environmentService'; <ins> import { clearAllFontInfos } from 'vs/editor/browser/config/configuration'; </ins> export class NativeWindow extends Disposable {

this.notificationService.info(message); }); <ins> ipc.on('vscode:displayChanged', (event: IpcEvent) => { clearAllFontInfos(); }); </ins> // Fullscreen Events ipc.on('vscode:enterFullScreen', async () => { await this.lifecycleService.when(LifecyclePhase.Ready);
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.29.0-insider () OS Version: Windows 10 October 2018 update (x64) Steps to Reproduce: the terminal panel on the split icon to split the terminal panel The tab terminal select widget briefly shows before showing : ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes

Discussion:
public get title(): string { let title = this.terminalInstances[0].title; for (let i = 1; i < this.terminalInstances.length; i++) { <del> title += `, ${this.terminalInstances[i].title}`; </del> <ins> if (this.terminalInstances[i].title) { title += `, ${this.terminalInstances[i].title}`; } </ins> } return title; }
Change:
In approx 1/4 of my installed themes this badge looks awful: ! Having no-results just doesn't feel like an error. Standard badge color (Like white here on github badge) is fine(because it's usually made for it). P.S. no need for a new color, already too many of them. P.P.S. actually new settings editor doing exactly that: ! So, it just needs to be aligned with the GUI version of settings.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.532 --- <!-- score: 0.51 --- <!-- score: 0.491 --<!-- potentialduplicatescomment --

Discussion:
this.sideBySidePreferencesWidget.setResultCount(count.target, count.count); } else if (this.searchWidget.getValue()) { if (countValue === 0) { <del> this.searchWidget.showMessage(nls.localize('noSettingsFound', "No Results"), countValue); </del> <ins> this.searchWidget.showMessage(nls.localize('noSettingsFound', "No Settings Found"), countValue); </ins> } else if (countValue === 1) { this.searchWidget.showMessage(nls.localize('oneSettingFound', "1 Setting Found"), countValue); } else {

import { IContextKey } from 'vs/platform/contextkey/common/contextkey'; import { IContextMenuService, IContextViewService } from 'vs/platform/contextview/browser/contextView'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; <del> import { activeContrastBorder, badgeBackground, badgeForeground, contrastBorder, errorForeground, focusBorder } from 'vs/platform/theme/common/colorRegistry'; </del> <ins> import { activeContrastBorder, badgeBackground, badgeForeground, contrastBorder, focusBorder } from 'vs/platform/theme/common/colorRegistry'; </ins> import { attachInputBoxStyler, attachStylerCallback } from 'vs/platform/theme/common/styler'; import { ICssStyleCollector, ITheme, IThemeService, registerThemingParticipant } from 'vs/platform/theme/common/themeService'; import { IWorkspaceContextService, IWorkspaceFolder, WorkbenchState } from 'vs/platform/workspace/common/workspace';

this.countElement.style.borderStyle = border ? 'solid' : null; this.countElement.style.borderColor = border; <del> this.styleCountElementForeground(); </del> <ins> const color = this.themeService.getTheme().getColor(badgeForeground); this.countElement.style.color = color ? color.toString() : null; </ins> })); }

if (this.countElement && message !== this.countElement.textContent) { this.countElement.textContent = message; this.inputBox.inputElement.setAttribute('aria-label', message); <del> DOM.toggleClass(this.countElement, 'no-results', count === 0); </del> this.inputBox.inputElement.style.paddingRight = this.getControlsWidth() + 'px'; <del> this.styleCountElementForeground(); </del> } } <del> private styleCountElementForeground() { const colorId = DOM.hasClass(this.countElement, 'no-results') ? errorForeground : badgeForeground; const color = this.themeService.getTheme().getColor(colorId); this.countElement.style.color = color ? color.toString() : null; } </del> public layout(dimension: DOM.Dimension) { if (dimension.width < 400) { if (this.countElement) {
Change:
VSCode Version: 1.27.2 (OSS Code, but also happens in the latest VS Code on Ubuntu) OS Version: Arch Linux (kernel 4.18.12-arch1-1-ARCH) When adding Code to the favorite applications in the GNOME environment, a duplicate icon spawns when launching the application. ! Steps to Reproduce: Code to favorite applications in GNOME an instance of Code and switch to the activities overview Does this issue occur when all extensions are disabled?: Yes I'm willing to try to solve the issue if you confirm that it is related to the application.
This also happens on Ubuntu 18.04.1, running GNOME and code . Hovering mouse on top, the favorite icon in the dock says , whereas the duplicate icon, that appears when starting code, says .
Can reproduce. Kubuntu 18.10, kernel 4.18.0, KDE 5.14.3, Code 1.29.1. Steps to reproduce: pin Code to the taskbar. The hover menu shows "Visual Studio Code." Open the application. Instead of opening under the pinned icon, a new icon shows up with description "Visual Studio Code - URL Handler." It sometimes goes away after a reboot, but is mostly unpredictable. I have experienced this problem since Code 1.28.1.
Have same problem
I'm having the same problem - worth noting that someone has asked a question about this behaviour on Ask Ubuntu here: I'm using the latest Code (1.29.1) on Ubuntu 18.10

Discussion:
Type=Application NoDisplay=true StartupNotify=true <del> StartupWMClass=@@NAME_SHORT@@ </del> Categories=Utility;TextEditor;Development;IDE; MimeType=x-scheme-handler/@@URLPROTOCOL@@; Keywords=vscode;
Change:
Since we already have the command in the pallet, it would be nice to expose it in the UI. Here: <img width="302" alt="screenshot 2018-10-29 at 09 51 10" src="https://user-"

Discussion:
"when": "scmProvider == git" }, { <ins> "command": "git.pushToForce", "group": "1_sync", "when": "scmProvider == git && config.git.allowForcePush" }, { </ins> "command": "git.publish", "group": "2_publish", "when": "scmProvider == git"
Change:
Issue Type: <bBug</bWhile testing steps windows an html file called the file the terminal menu, select bug This command executes in the terminal. For powershell at least, this does nothing. If the file does not have a space, then we run which opens a web browser VS Code version: Code - Insiders 1.29.0-insider (, 2018-10-31T06:19:46.141Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<!-- generated by issue reporter --
do you have a suggestion of what should happen for powershell?
You'll want the which should do what you want:
This issue doesn't just apply to Windows but any OS that uses PowerShell.
thanks for the info

Discussion:
c(this._escapeNonWindowsPath(stdout.trim())); }); return; <ins> } else if (hasSpace && (exe.indexOf('powershell') !== -1)) { c('& '' + path + '''); </ins> } else if (hasSpace) { c('"' + path + '"'); } else {
Change:
Testing Enable After merging the last conflict following warning is shown ! If auto navigation is enabled then I do not think this warning is needed
Would like to pick this up

Discussion:
let navigationResult = await this.findConflictForNavigation(editor, direction); if (!navigationResult) { <ins> // Check for autoNavigateNextConflict, if it's enabled(which indicating no conflict remain), then do not show warning const mergeConflictConfig = vscode.workspace.getConfiguration('merge-conflict'); if (mergeConflictConfig.get<boolean>('autoNavigateNextConflict.enabled')) { return; } </ins> vscode.window.showWarningMessage(localize('noConflicts', 'No merge conflicts found in this file')); return; }
Change:
Open some See that it's in the "Open Recent..." list Close vscode Delete that code-workspace Open vscode Use Open Recent to select that deleted workspace Get a message that doesn't exist anymore See Open Recent again - the workspace is still in that list If I follow the same steps with a folder instead of a workspace, then the folder is removed from the list as I'd expect.
I cannot reproduce, tried with insiders on macOS. Here is what I did: open a workspace saved it as another workspace on my desktop closed vscode deleted that workspace opened vscode (opens empty) try to open that deleted workspace via file open recent dismiss the dialog try to find the entry again =it is gone Since this involves a menu update, could it be that you opened the menu too fast for the menu to update? I think the current delay is like 800ms?
Interesting, I am using the "File: Open Recent..." command. When I use that, it isn't removed from the list, but when I use the File Open Recent menu, it is removed.
I can reproduce and it seems to be a regression from the work to support URIs on the main side. The flow is: opening the workspace fails and we call remove from recently opened () since we pass over a URI we think this is a single folder workspace (which it is not) and fail to remove it moving to (cc
This was the change from adopting URIs for files.

Discussion:
} } } catch (error) { <del> const fileUri = URI.file(candidate); this.historyMainService.removeFromRecentlyOpened([fileUri]); // since file does not seem to exist anymore, remove from recent </del> <ins> this.historyMainService.removeFromRecentlyOpened([candidate]); // since file does not seem to exist anymore, remove from recent const fileUri = URI.file(candidate); </ins> if (options && options.ignoreFileNotFound) { return { fileUri, createFilePath: true, remoteAuthority }; // assume this is a file that does not yet exist }
Change:
To reproduce: Observe: terminal is not cleared. To make this work we need to add the clear here: Sorry for not catching this when reviewing.
Reopening until this is merged into release.
Following the steps above, I'm still seeing the task output left in the terminal with the final message "Terminal will be reused by tasks, press any key to close it.". I assume this is what should be cleared. VSCode version: Version: 1.29.0-insider Commit: Date: 2018-11-09T14:55:36.370Z

Discussion:
namespace CommandConfiguration { export namespace PresentationOptions { <del> const properties: MetaData<Tasks.PresentationOptions, void>[] = [{ property: 'echo' }, { property: 'reveal' }, { property: 'focus' }, { property: 'panel' }, { property: 'showReuseMessage' }]; </del> <ins> const properties: MetaData<Tasks.PresentationOptions, void>[] = [{ property: 'echo' }, { property: 'reveal' }, { property: 'focus' }, { property: 'panel' }, { property: 'showReuseMessage' }, { property: 'clear' }]; </ins> interface PresentationOptionsShape extends LegacyCommandProperties { presentation?: PresentationOptions;
Change:
Afaik, electron should build with dconf instead of gconf.
See also
Please report here:
electron now (3.x) works without gconf. All you have to do is
I can confirm that Insiders 1.31 works without gconf. Can gconf be dropped for insiders?

Discussion:
- script: | set -e sudo apt-get update <del> sudo apt-get install -y libxkbfile-dev pkg-config libsecret-1-dev libxss1 libgconf-2-4 dbus xvfb libgtk-3-0 </del> <ins> sudo apt-get install -y libxkbfile-dev pkg-config libsecret-1-dev libxss1 dbus xvfb libgtk-3-0 </ins> sudo cp build/azure-pipelines/linux/xvfb.init /etc/init.d/xvfb sudo chmod +x /etc/init.d/xvfb sudo update-rc.d xvfb defaults

Package: @@NAME@@ Version: @@VERSION@@ Section: devel <del> Depends: libnotify4, libnss3 (>= 2:3.26), gnupg, apt, libxkbfile1, libgconf-2-4, libsecret-1-0, libgtk-3-0 (>= 3.10.0), libxss1 </del> <ins> Depends: libnotify4, libnss3 (>= 2:3.26), gnupg, apt, libxkbfile1, libsecret-1-0, libgtk-3-0 (>= 3.10.0), libxss1 </ins> Priority: optional Architecture: @@ARCHITECTURE@@ Maintainer: Microsoft Corporation <vscode-linux@microsoft.com>

"libX11.so.6()(64bit)", "libXss.so.1()(64bit)", "libXtst.so.6()(64bit)", <del> "libgconf-2.so.4()(64bit)", </del> "libgmodule-2.0.so.0()(64bit)", "librt.so.1()(64bit)", "libglib-2.0.so.0()(64bit)",

"libgcc_s.so.1", "libgcc_s.so.1(GCC_4.0.0)", "libgcc_s.so.1(GLIBC_2.0)", <del> "libgconf-2.so.4", </del> "libgdk-x11-2.0.so.0", "libgdk_pixbuf-2.0.so.0", "libgio-2.0.so.0",

stage-packages: - libasound2 - libc++1 <del> - libgconf2-4 </del> - libnotify4 - libnspr4 - libnss3
Change:
Issue Type: <bBug</bAutocomplete works fine for & (after you accept suggestion) ==Can this be anything else beside string type? actual: =expected: <sCan this be anything else beside object? actual: =expected: </sOk, can be object or string. VS Code version: Code 1.28.2 (, 2018-10-17T00:23:51.859Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --

Discussion:
'description': nls.localize('keybindings.json.key', "Key or key sequence (separated by space)"), }, 'command': { <ins> 'type': 'string', </ins> 'description': nls.localize('keybindings.json.command', "Name of the command to execute"), }, 'when': {
Change:
Problem A fair number of extensions are shipping , , and files. Except for a few exceptional circumstances, these files are not needed in the extension bundle itself. A few also include test code Proposal For the for , add:For existing extensions, can we add a linter alert or vsce alert for these cases?Use bot to go through offending extensions and open issues?
Probably should also add . A good number of the top 500 extensions also include that
Manually opened a few PRs against larger offenders of including files Opened to improve the starter
Created
Can you please take a look at too

Discussion:
'union', 'unsigned', 'using', <del> 'value', </del> 'virtual', 'void', 'volatile',
Change:
Issue Type: <bBug</bRelated to Repo a js file with cursor at : ` (backtick) Expected Backtick is closed since we have set the mode to Actual Quote is not closed VS Code version: code-oss-dev 1.30.0 (Commit unknown, Date unknown) OS version: Darwin x64 18.2.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
I still have this issue. Applied the setting, and even tried reloading window with extensions disabled. Tried in both "javascript" and "javascriptreact". VS Code: 1.32.3 (1.32.3) OS: MacOS High Sierra 10.13.6
I'm wondering if can you try and replicate this issue on VSCode Insiders?
It seems to autoclose as expected on Insiders However, it'd be helpful to have it auto-indent on enter, since template literals allow expressions, such as in use with graphql. ! VS Code: 1.34.0-insider (1.34.0-insider)

Discussion:
const lineText = model.getLineContent(position.lineNumber); // Do not auto-close ' or " after a word character <del> if (chIsQuote && position.column > 1) { </del> <ins> if ((chIsQuote && position.column > 1) && autoCloseConfig !== 'always') { </ins> const wordSeparators = getMapForWordSeparators(config.wordSeparators); const characterBeforeCode = lineText.charCodeAt(position.column - 2); const characterBeforeType = wordSeparators.get(characterBeforeCode);
Change:
Issue Type: <bBug</bRepo VS Code code base launch the debug configuration Bug In the debug console, see the following error: I've tried a clean and rebuild but haven't been able to get this working VS Code version: Code - Insiders 1.30.0-insider (, 2018-11-19T19:59:44.607Z) OS version: Darwin x64 18.2.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
After disabling the uri check temporarily, I now get:
Not my launch-config. TBH - I have never used our debugger for tests, I use
I didn't know about the --debug option. I've never understood why the debug config setup is totally different than the typical running setup. Why don't we launch in the same way as --debug but attach the vscode debugger? I'll take a look when I get a chance.

Discussion:
{ "type": "node", "request": "launch", <del> "name": "Unit Tests", "program": "${workspaceFolder}/node_modules/mocha/bin/_mocha", </del> <ins> "name": "Run Unit Tests", "program": "${workspaceFolder}/test/electron/index.js", </ins> "runtimeExecutable": "${workspaceFolder}/.build/electron/Code - OSS.app/Contents/MacOS/Electron", "windows": { "runtimeExecutable": "${workspaceFolder}/.build/electron/Code - OSS.exe"

}, "outputCapture": "std", "args": [ <del> "--delay", "--timeout", "2000" </del> <ins> "--remote-debugging-port=9222" </ins> ], "cwd": "${workspaceFolder}", <del> "env": { "ELECTRON_RUN_AS_NODE": "true" }, </del> "outFiles": [ "${workspaceFolder}/out/**/*.js" ]

"Launch VS Code", "Attach to Extension Host" ] <del> } </del> <ins> }, { "name": "Debug Unit Tests", "configurations": [ "Attach to VS Code", "Run Unit Tests" ] }, </ins> ] }
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.29.2 OS Version: linux Steps to Reproduce: some .cpp files with errors or as suggested in hover from these files are still there My use case: I use gitlens extension. It downloads older versions of files to /tmp/ and of course they produce a lot of errors and warnings. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No
Are you saying errors/warnings are in older versions of files that gitlens is downloading? Or the errors/warnings are occuring in the file that you edited with ?
Also, can you provide an example small cpp file that will have these errors?
Sorry, let me clarify. vscode has warnings and errors pane, it groups all errors from the project. And there is an input bar that lets you exclude some files. Here I want to exclude all ts files, but it doesn't work: !
This seems to be a regression from new tree adoption. It's because tree is marking the parent node as visible always.

Discussion:
if (typeof result === 'boolean') { node.filterData = undefined; <del> return TreeVisibility.Visible; </del> <ins> return result ? TreeVisibility.Visible : TreeVisibility.Hidden; </ins> } else if (isFilterResult<TFilterData>(result)) { node.filterData = result.data; return getVisibleState(result.visibility);
Change:
Testing should focus on resizing the terminal as well as inputting emoji, CJK and "high plane chars" (those with a char code above ).
Been playing with this option. I have to say the perf is quite amazing. I'm very impressed that the vscode terminal is actually faster than than both iTerm and built-in Mac OSX terminal. That's what I love about vscode. It's attention to perf. Thank you!
glad to hear you've been testing it out! Much more in the works This particular one was pretty much all
Thx We still have a few more perf gems to come with the next releases, stay tuned :smiley_cat: And thx for testing, we need every helping hand to cover the edge cases, esp. for those bigger changes.
Btw I used vscode terminal extensively to test v2 of matrix-rain. You can try it at Vscode terminal is the fastest out of iTerm and macOS Terminal app. So looking forward to a super fast terminal (hopefully standalone someday).
nice! will make it even better when that eventually goes in
I removed the JsArray completely as TypedArray is very stable at this point.

Discussion:
description: nls.localize('terminal.integrated.experimentalBufferImpl', "Controls the terminal's internal buffer implementation. This setting is picked up on terminal creation and will not apply to existing terminals."), type: 'string', enum: ['JsArray', 'TypedArray'], <del> default: 'JsArray' </del> <ins> default: 'TypedArray' </ins> }, 'terminal.integrated.splitCwd': { description: nls.localize('terminal.integrated.splitCwd', "Controls the working directory a split terminal starts with."),
Change:
We have no documentation for HTML attribute completions: ! No documentation for HTML attribute value completions either: ! As we progress in , these should be implemented so custom tag/attribute providers could offer a good experience. MDN actually has neat descriptions for all of them:
The support is available, but we still need pulling more data:
Attribute description is there in , attribute value not yet. Will continue on March.
Fixed.

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
The type was updated for . Unfortunately, the constructor was not updated, so this would require that you still construct the object with a and subsequently update the with the tuple.
, looking into this :)

Discussion:
/** * Creates a new parameter information object. * <del> * @param label A label string. </del> <ins> * @param label A label string or inclusive start and exclusive end offsets within its containing. </ins> * @param documentation A doc string. */ <del> constructor(label: string, documentation?: string | MarkdownString); </del> <ins> constructor(label: string | [number, number], documentation?: string | MarkdownString); </ins> } /**