Change:
I am sure by now everyone got this: !
I used to get issues about people not sure whether settings were saved, now I don't. You should only see it once in a new user data dir. I think it's useful, I'd prefer to keep it.
I think given our latest move to reduce notifications we should revisit this. //cc
Agree. would you be open to remove this notification now? This only happens in JSON settings? This one is advanced and maybe those users do not need help?
This happens with our standard settings editor: !
Oh I misunderstood, then I would definitely remove this notification. Most UI now days do not have an Apply button and none of the notify that you do not have to click apply for the setting to be applied. did we run some user studies where participants would get confused if their settings get saved? Could we maybe remove this notification and run a short study to gather some impressions. Reopening this issue for discussion
As I remember, this came directly from user studies. But that was 3 years ago and maybe we can just assume that people are used to it now? You will also only get it once.
I don't remember the details from the user study but I think it would be fine to remove this and then also follow up with a short study.
cool. do you mind if we remove this in May debt week, so we have the whole May milestone to gather feedback and maybe do a short study?
Since I noticed this again now in endgame week with fresh installs, decided to put up a PR with the notification removed in
Awesome, thanks for doing that
verified

Discussion:
import { IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { ILogService } from 'vs/platform/log/common/log'; <del> import { INotificationService } from 'vs/platform/notification/common/notification'; import { IStorageService, StorageScope, StorageTarget } from 'vs/platform/storage/common/storage'; </del> <ins> import { IStorageService } from 'vs/platform/storage/common/storage'; </ins> import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; import { badgeBackground, badgeForeground, contrastBorder, editorForeground } from 'vs/platform/theme/common/colorRegistry'; import { attachButtonStyler, attachStylerCallback } from 'vs/platform/theme/common/styler';

const searchBoxLabel = localize('SearchSettings.AriaLabel', "Search settings"); <del> const SETTINGS_AUTOSAVE_NOTIFIED_KEY = 'hasNotifiedOfSettingsAutosave'; </del> const SETTINGS_EDITOR_STATE_KEY = 'settingsEditorState'; export class SettingsEditor2 extends EditorPane {

@IPreferencesSearchService private readonly preferencesSearchService: IPreferencesSearchService, @ILogService private readonly logService: ILogService, @IContextKeyService contextKeyService: IContextKeyService, <del> @IStorageService private readonly storageService: IStorageService, @INotificationService private readonly notificationService: INotificationService, </del> <ins> @IStorageService storageService: IStorageService, </ins> @IEditorGroupsService protected editorGroupService: IEditorGroupsService, @IUserDataSyncWorkbenchService private readonly userDataSyncWorkbenchService: IUserDataSyncWorkbenchService, @IUserDataAutoSyncEnablementService private readonly userDataAutoSyncEnablementService: IUserDataAutoSyncEnablementService,

})); } <del> private notifyNoSaveNeeded() { if (!this.storageService.getBoolean(SETTINGS_AUTOSAVE_NOTIFIED_KEY, StorageScope.GLOBAL, false)) { this.storageService.store(SETTINGS_AUTOSAVE_NOTIFIED_KEY, true, StorageScope.GLOBAL, StorageTarget.USER); this.notificationService.info(localize('settingsNoSaveNeeded', "Changes to settings are saved automatically.")); } } </del> private onDidChangeSetting(key: string, value: any, type: SettingValueType | SettingValueType[]): void { <del> this.notifyNoSaveNeeded(); </del> if (this.pendingSettingUpdate && this.pendingSettingUpdate.key !== key) { this.updateChangedSetting(key, value); }