jiebi/CodeConvo huggingface dataset:
Change:
from
A possible regression from
No, actually was reported before:
/duplicate
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!

Discussion:
suite('vscode API - commands', () => { <del> teardown(assertNoRpc); </del> <ins> teardown(async function () { assertNoRpc(); await closeAllEditors(); }); </ins> test('getCommands', function (done) {

const uri = Uri.parse(workspace.workspaceFolders![0].uri.toString() + '/far.js'); await commands.executeCommand('vscode.open', uri); <del> assert.strictEqual(window.activeTextEditor?.viewColumn, ViewColumn.One); </del> assert.strictEqual(window.tabGroups.all[0].activeTab?.group.viewColumn, ViewColumn.One); <ins> assert.strictEqual(window.activeTextEditor?.viewColumn, ViewColumn.One); </ins> await commands.executeCommand('vscode.open', uri, ViewColumn.Two); <del> assert.strictEqual(window.activeTextEditor?.viewColumn, ViewColumn.Two); </del> assert.strictEqual(window.tabGroups.all[1].activeTab?.group.viewColumn, ViewColumn.Two); <ins> assert.strictEqual(window.activeTextEditor?.viewColumn, ViewColumn.Two); </ins> await commands.executeCommand('vscode.open', uri, ViewColumn.One); <del> assert.strictEqual(window.activeTextEditor?.viewColumn, ViewColumn.One); </del> assert.strictEqual(window.tabGroups.all[0].activeTab?.group.viewColumn, ViewColumn.One); <ins> assert.strictEqual(window.activeTextEditor?.viewColumn, ViewColumn.One); </ins> let e1: Error | undefined = undefined; try {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.0 (Universal) OS Version: Darwin x64 19.6.0 Steps to Reproduce: to delete a file with nested files When you right click and hit "delete", vscode does nothing and the file and its nested files remain. You must open the parent and delete each nested file and then you are able to delete the parent file.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.70.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Also, I think it would be a good idea for an option to rename all nested files when the parent is renamed.
based on the setting description for file nesting, I expected a file I created in a folder to be nested under the that is in that same folder. Is that the wrong expectation here?
That is correct. I'm seeing that here <img width="457" alt="image" src="https://user-"

Discussion:
const items = new Set<ExplorerItem>(this.view.getContext(respectMultiSelection)); items.forEach(item => { <del> if (respectMultiSelection && this.view?.isItemCollapsed(item) && item.nestedChildren) { for (const child of item.nestedChildren) { items.add(child); </del> <ins> try { if (respectMultiSelection && this.view?.isItemCollapsed(item) && item.nestedChildren) { for (const child of item.nestedChildren) { items.add(child); } </ins> } <ins> } catch { // We will error out trying to resolve collapsed nodes that have not yet been resolved. // So we catch and ignore them in the multiSelect context return; </ins> } });
Change:
Open a notebook Sometimes the focused cell doesn't have the dropdown chevron with the "Debug Cell" action Or, after debugging or using RBL, sometimes this button doesn't come back pointed this out and I can repro it

Discussion:
super(); const menu = this._register(menuService.createMenu(this.notebookEditor.creationOptions.menuIds.cellExecutePrimary!, contextKeyService)); <ins> const secondaryMenu = this._register(menuService.createMenu(this.notebookEditor.creationOptions.menuIds.cellExecuteToolbar, contextKeyService)); </ins> this.createRunCellToolbar(runButtonContainer, cellContainer, contextKeyService); const updateActions = () => { const actions = this.getCellToolbarActions(menu);

}; updateActions(); this._register(menu.onDidChange(updateActions)); <ins> this._register(secondaryMenu.onDidChange(updateActions)); </ins> this._register(this.notebookEditor.notebookOptions.onDidChangeOptions(updateActions)); }
Change:
Issue Type: <bBug</bI believe there is an issue with parsing the '.gitmodules' file. If the value of the 'path' parameter of a submodules is enclosed in quotation marks ", the submodule is not detected as git repository. The quotation marks are necessary, because the parameter value contains the character # and the remaining content of the line is otherwise interpreted as comment by git. Without the quotaion marks Visual Studio Code detects the submodules as repositories, but git cannot perform submodule commands. Examplary content of '.gitmodules' - file where detection is not working, but git is: Examplary content of '.gitmodules' - file where detection is working, but git is not: VS Code version: Code 1.69.2 (, 2022-07-18T16:12:52.460Z) OS version: WindowsNT x64 10.0. Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (17)</summaryExtensionVersion ------ gitignore0.9.0 doxdocgen1.4.0 xml2.5.1 gitlens12.1.2 auto-close-tag0.5.14 auto-complete-tag0.1.0 auto-rename-tag0.1.10 better-cpp-syntax1.15.19 git-graph1.30.0 csharp1.25.0 python2022.12.0 vscode-pylance2022.8.10 cmake-tools1.11.26 cpptools1.11.5 cpptools-extension-pack1.2.0 vscode-fileutils3.5.0 cmake0.0.17 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.70.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Hello, I have updated the Visual Studio Code to version 1.70.1 and the issue still exists. Version: 1.70.1 (user setup) Commit: Date: 2022-08-10T06:08:33.642Z Electron: 18.3.5 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0.

Discussion:
class GitConfigParser { private static readonly _lineSeparator = /r?n/; <del> private static readonly _propertyRegex = /^s*(w+)s*=s*(.*)$/; </del> <ins> private static readonly _propertyRegex = /^s*(w+)s*=s*"?([^"]+)"?$/; </ins> private static readonly _sectionRegex = /^s*[s*([^]]+?)s*("[^"]+")*]s*$/; static parse(raw: string): GitConfigSection[] {
Change:
Failed in
Again, could be a regression from , looks like this test failure is relatively new. One actual change from is that will not reach without yielding once, due to the new here: Since we no longer disable the editor override here: If there is any code in the renderer that relied on the previous behaviour, maybe that change made the tests more flaky now?
My theory is that possibly is actually and so pushing a change to assert it is there.
This failed again for web in: Given my change is in, it looks like literally even though we have document from the event, it is not the same as : I am pushing a change to compare the URIs of the two and see what they are.
I see no failure since, let's close until we hit this again.
Failed again in: This looks as if a document from a previous test run appears in our event listener here: I guess we cannot guarantee that the event that comes in is for the closed editor, there maybe multiple. So an idea to fix this is to keep closed documents in an array for the test and try to find the one we expect:

Discussion:
assert.strictEqual(didSave, true, `FAILED to save${doc.uri.toString()}`); <ins> assert.ok(closed); </ins> assert.ok(closed === doc); assert.ok(!doc.isDirty); assert.ok(fs.existsSync(path));
Change:
I guess the reload/refresh logic that we isn't working...
This is what I am reproducing enabled -disabled: works disabled -enabled: fails
I will push a workaround, refresh the SCM view when the config changes, because re-setting the merge group () doesn't seem to work reliably. I debugged this in to  but wasn't able to get to the bottom of this. When calling the method it seems that is already updated with what I am expecting to be updating now... fyi

Discussion:
return this.resources[1]; } <ins> @memoize </ins> get command(): Command { return this._commandResolver.resolveDefaultCommand(this); }

workspace.onDidChangeConfiguration(e => { if (e.affectsConfiguration('git.mergeEditor')) { <del> // this.mergeGroup.resourceStates = this.mergeGroup.resourceStates.map(r => r.clone()); this.status(); </del> <ins> this.mergeGroup.resourceStates = this.mergeGroup.resourceStates.map(r => r.clone()); </ins> } }, undefined, this.disposables);
Change:
Found this stack while scanning through some failing smoke test runs From Deepak:
What are some verification steps for this issue?
I did check logs last week and could no longer find this.

Discussion:
disturl "https://electronjs.org/headers" <del> target "19.0.11" </del> <ins> target "19.0.12" </ins> runtime "electron" build_from_source "true"

"git": { "name": "electron", "repositoryUrl": "https://github.com/electron/electron", <del> "commitHash": "a5cafd174d2027529d0b251e5b8e58da2b364e5b" </del> <ins> "commitHash": "b05ccd812e3bb3de5b1546a313e298961653e942" </ins> } }, "isOnlyProductionDependency": true, "license": "MIT", <del> "version": "19.0.11" </del> <ins> "version": "19.0.12" </ins> }, { "component": {

"cssnano": "^4.1.11", "debounce": "^1.0.0", "deemon": "^1.4.0", <del> "electron": "19.0.11", </del> <ins> "electron": "19.0.12", </ins> "eslint": "8.7.0", "eslint-plugin-header": "3.1.1", "eslint-plugin-jsdoc": "^39.3.2",

constructor(modulePath: string, args?: string[] | undefined, options?: UtilityProcessOptions); postMessage(channel: string, message: any, transfer?: Electron.MessagePortMain[]): void; kill(signal?: number | string): boolean; <del> on(event: 'exit', listener: (code: number | undefined) => void): this; </del> <ins> on(event: 'exit', listener: (event: Electron.Event, code: number) => void): this; </ins> on(event: 'spawn', listener: () => void): this; } }

this._register(Event.fromNodeEventEmitter<void>(this._process, 'spawn')(() => { this._logService.info(`UtilityProcess<${this.id}>: received spawn event.`); })); <del> this._register(Event.fromNodeEventEmitter<number | undefined>(this._process, 'exit')((code: number | undefined) => { code = code || 0; </del> <ins> const onExit = Event.fromNodeEventEmitter<number>(this._process, 'exit', (_, code: number) => code); this._register(onExit((code: number) => { </ins> this._logService.info(`UtilityProcess<${this.id}>: received exit event with code ${code}.`); this._hasExited = true; this._onExit.fire({ pid: this._process!.pid!, code, signal: '' });

resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.207.tgz#9c3310ebace2952903d05dcaba8abe3a4ed44c01" integrity sha512-piH7MJDJp4rJCduWbVvmUd59AUne1AFBJ8JaRQvk0KzNTSUnZrVXHCZc+eg+CGE4OujkcLJznhGKD6tuAshj5Q== <del> electron@19.0.11: version "19.0.11" resolved "https://registry.yarnpkg.com/electron/-/electron-19.0.11.tgz#0c0a52abc08694fd38916d9270baf45bb7752a27" integrity sha512-GPM6C1Ze17/gR4koTE171MxrI5unYfFRgXQdkMdpWM2Cd55LMUrVa0QHCsfKpsaloufv9T65lsOn0uZuzCw5UA== </del> <ins> electron@19.0.12: version "19.0.12" resolved "https://registry.yarnpkg.com/electron/-/electron-19.0.12.tgz#73d11cc2a3e4dbcd61fdc1c39561e7a7911046e9" integrity sha512-GOvG0t2NCeJYIfmC3g/dnEAQ71k3nQDbRVqQhpi2YbsYMury0asGJwqnVAv2uZQEwCwSx4XOwOQARTFEG/msWw== </ins> dependencies: "@electron/get" "^1.14.1" "@types/node" "^16.11.26"
Change:
! 'void' should not as column num Version: 1.70.0-insider (user setup) Commit: Date: 2022-07-26T05:16:55.337Z Electron: 18.3.5 Chromium: 100.0.4896.160 16.13.2 V8: 10.0.139.17-electron.0 OS: Windows_NT x64 10.0.
Your Insiders is outdated. Please update and retest.
Version: 1.71.0-insider (user setup) Commit: Date: 2022-08-12T05:17:00.323Z Electron: 19.0.11 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes still have problem
sorry for mistake close
Tricky edge case, perhaps we should parse the col/row and remove col if invalid and col+row if they're both invalid?

Discussion:
let text = link.text.replace(/^file:///?/, ''); text = osPathModule(this._os).normalize(text).replace(/^(.+[/])+/, ''); <del> // Remove `:in` from the end which is how Ruby outputs stack traces text = text.replace(/:in$/, ''); </del> <ins> // Remove `:<one or more non number characters>` from the end of the link. // Examples: // - Ruby stack traces: <link>:in ... // - Grep output: <link>:<result line> text = text.replace(/:[^d]+$/, ''); </ins> // If any of the names of the folders in the workspace matches // a prefix of the link, remove that prefix and continue this._workspaceContextService.getWorkspace().folders.forEach((folder) => {
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --When I select a file in the left side bar and hit the file prefix is selected. ! I would like to hit a second time to select the whole file name. ! When I press a third time the prefix should be selected again. So pressing should just toggle between "prefix" and "whole name". This is a feature I use very often in Total Commander. It is usefull if you want to copy the complete file name.
Interesting idea. Maybe the second press could select just the suffix, and the third press cycle around to just the prefix.
I like Personally I would think cycling from left to right would be best 1st press =prefix 2nd press =all 3rd press =suffix 4th press =cycles back around to prefix when highlighting the suffix, should it also include the seperating dot?
I think the dot should only be selected, wenn all is selected.
that's actually what I meant. I forgot to count the initial F2 that begins the rename operation.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
! Coming to a VS Code near you. There's still some quirks to work out as right now it is hardcoded to F2 but technically you can set the rename keybinding to anything. It's especially not clear on macOS where the default keybinding is but clicking and having your selection change would be infuriating
Great. But I would still prefer if the dot was not selected in combination with the suffix. When you select the suffix you usually want to change it something else. This means you would have to type the dot again.
To verify ensure that pressing after entering rename mode cycles between different segments of the file name

Discussion:
const styler = attachInputBoxStyler(inputBox, this.themeService); const lastDot = value.lastIndexOf('.'); <ins> let currentSelectionState = 'prefix'; </ins> inputBox.value = value; inputBox.focus();

label.setFile(joinPath(parent, value || ' '), labelOptions); // update label icon while typing! }), DOM.addStandardDisposableListener(inputBox.inputElement, DOM.EventType.KEY_DOWN, (e: IKeyboardEvent) => { <del> if (e.equals(KeyCode.Enter)) { </del> <ins> if (e.equals(KeyCode.F2)) { const dotIndex = inputBox.value.lastIndexOf('.'); if (stat.isDirectory || dotIndex === -1) { return; } if (currentSelectionState === 'prefix') { currentSelectionState = 'all'; inputBox.select({ start: 0, end: inputBox.value.length }); } else if (currentSelectionState === 'all') { currentSelectionState = 'suffix'; inputBox.select({ start: dotIndex + 1, end: inputBox.value.length }); } else { currentSelectionState = 'prefix'; inputBox.select({ start: 0, end: dotIndex }); } } else if (e.equals(KeyCode.Enter)) { </ins> if (!inputBox.validate()) { done(true, true); }
Change:
Type: <bBug</bWhen I click the light bulb instead of getting a menu I see a thin, dark gray, horizontal bar. I have tried restarting the application. VS Code version: Code - Insiders 1.71.0-insider (, 2022-08-12T05:17:00.323Z) OS version: WindowsNT x64 10.0. Modes: Sandboxed: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (22)</summaryExtensionVersion ------ code-gnu-global0.2.2 vscode-markdownlint0.47.0 vscode-eslint2.2.6 gitlens12.1.2 prettier-vscode9.5.0 dotnet-test-explorer0.7.7 vscode-guid1.4.20 vscode-azurefunctions1.7.4 vscode-azureresourcegroups0.5.5 csharp1.25.0 python2022.12.0 vscode-pylance2022.8.20 jupyter2022.7. remote-wsl0.66.3 azure-account0.11.1 cmake-tools1.11.26 cpptools1.11.5 powershell2022.7.2 test-adapter-converter0.1.6 rust0.7.8 code-spell-checker2.5.4 cmake0.0.17 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
! Here is an image of what I am seeing.
Please use the Start Extension Bisect command to investigate whether the problem is being caused by one of your extensions.
Related to: This is most likely because of an extension which uses non-VS Code specific code actions. PR for this is out rn!
Confirming fixed on: Version: 1.71.0-insider (user setup) Commit: Date: 2022-08-18T05:15:52.904Z Electron: 19.0.12 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes Thank you!

Discussion:
} else if (optionKind === CodeActionMenu.documentationID) { documentationGroup.push(item); } else { <ins> // Pushes all the other actions to the "Other" group </ins> otherGroup.push(item); }

} else if (firstAction === CodeActionMenu.documentationID) { totalActionEntries.push(...entry); <ins> } else { // Takes and flattens all the `other` actions menuEntriesToPush(localize('codeAction.widget.id.more', 'More Actions...'), entry); </ins> } } else { // case for separator - not a code action action
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Describe the bug The refactor options like "Wrap with...", "Remove this widget", etc. do not show up in the new code action menu. To Reproduce Steps to reproduce the behavior: editor.experimental.useCustomCodeActionMenu the refactor menu somewhere Expected behavior The refactor options should appear in the new menu. From
For me too, I'll have to migrate to normal vscode... !
Thanks! :)

Discussion:
} else if (optionKind === CodeActionMenu.documentationID) { documentationGroup.push(item); } else { <ins> // Pushes all the other actions to the "Other" group </ins> otherGroup.push(item); }

} else if (firstAction === CodeActionMenu.documentationID) { totalActionEntries.push(...entry); <ins> } else { // Takes and flattens all the `other` actions menuEntriesToPush(localize('codeAction.widget.id.more', 'More Actions...'), entry); </ins> } } else { // case for separator - not a code action action
Change:
Drive letter on Windows are uppsercase: <img width="393" alt="image" src="https://user-"
we are not using the label service for the path portion because the path needs to be editable by the user. i.e. They should be able to edit the string directly and we should be able save that into our list. In the local case, the default behavior is to use the file picker, but if you are editing a remote path that you are not connected to, you need to be able to edit the string. I consider this change but I'm a little nervous that we might get some UI representation that is not safe for editing. <img width="720" alt="image" src="https://user-"
Fair, we have methods to only fix the drive letter casing, so maybe safer to just do that.
I believe I solved this a part of a separate issue.
Assigning to Jan for verification
I still see lowercase drive letters: <img width="613" alt="image" src="https://user-"

Discussion:
import { IProductService } from 'vs/platform/product/common/productService'; import { registerIcon } from 'vs/platform/theme/common/iconRegistry'; import { defaultButtonStyles, defaultInputBoxStyles } from 'vs/platform/theme/browser/defaultStyles'; <del> import { isMacintosh } from 'vs/base/common/platform'; </del> <ins> import { isMacintosh, isWindows } from 'vs/base/common/platform'; </ins> import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; import { ResolvedKeybinding } from 'vs/base/common/keybindings';

private formatPath(uri: URI): string { if (uri.scheme === Schemas.file) { <ins> if (hasDriveLetter(uri.fsPath, isWindows)) { return uri.fsPath.charAt(0).toUpperCase() + uri.fsPath.substring(1); } </ins> return uri.fsPath; }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.70.1 OS Version: OSX I've cloned the Visual Studio Code repo, and built it (via and ), and from the CLI I can run the smoke tests (via ). However, when I attempt to debug any of the smoke tests, I get the error, Steps to Reproduce: VSC VSC not already open, open the project up the VSC a smoke test file (like ) to the Debug view the configuration to, "Launch Smoke Test" the Debug button Result: The debugger starts, but then quickly exits. In the Debug Console, there is: "Uncaught ReferenceError ReferenceError: before is not defined"
The "Launch Smoke Test" debug config is no longer up-to-date. I'm seeing this: <img width="1040" alt="CleanShot 2022-08-16 at 12 39 49 src="https://user-" for running smoketests please see: I've assigned this item to you because you've created the "Launch Smoke Test" debug config.

Discussion:
"type": "node", "request": "launch", "name": "Launch Smoke Test", <del> "program": "${workspaceFolder}/test/smoke/out/main.js", </del> <ins> "program": "${workspaceFolder}/test/smoke/test/index.js", </ins> "cwd": "${workspaceFolder}/test/smoke", "timeout": 240000, <del> "port": 9999, </del> "args": [ "-l", "${workspaceFolder}/.build/electron/Code - OSS.app/Contents/MacOS/Electron"