jiebi/CodeConvo huggingface dataset:
Change:
Testing It shows the error's message, but doesn't make explicit that there was an error thrown. ! This is from:

Discussion:
.add_port_raw(&TunnelPort { port_number, protocol: Some(TUNNEL_PROTOCOL_AUTO.to_owned()), <ins> access_control: Some(privacy_to_tunnel_acl(PortPrivacy::Private)), </ins> ..Default::default() }) .await

} fn privacy_to_tunnel_acl(privacy: PortPrivacy) -> TunnelAccessControl { <del> let mut acl = TunnelAccessControl { entries: vec![] }; if privacy == PortPrivacy::Public { acl.entries .push(tunnels::contracts::TunnelAccessControlEntry { </del> <ins> TunnelAccessControl { entries: vec![match privacy { PortPrivacy::Public => tunnels::contracts::TunnelAccessControlEntry { </ins> kind: tunnels::contracts::TunnelAccessControlEntryType::Anonymous, provider: None, is_inherited: false,

expiration: None, subjects: vec![], scopes: vec![TUNNEL_ACCESS_SCOPES_CONNECT.to_string()], <del> }); </del> <ins> }, // Ensure private ports are actually private and do not inherit any // default visibility that may be set on the tunnel: PortPrivacy::Private => tunnels::contracts::TunnelAccessControlEntry { kind: tunnels::contracts::TunnelAccessControlEntryType::Anonymous, provider: None, is_inherited: false, is_deny: true, is_inverse: false, organization: None, expiration: None, subjects: vec![], scopes: vec![TUNNEL_ACCESS_SCOPES_CONNECT.to_string()], }, }], </ins> } <del> acl </del> } #[cfg(test)]

: { element, collapsible: element.test.expand !== TestItemExpandState.NotExpandable, <del> collapsed: isCollapsedInSerializedTestTree(serialized, element.test.item.extId) ?? element.depth > 0 ? ObjectTreeElementCollapseState.PreserveOrCollapsed : ObjectTreeElementCollapseState.PreserveOrExpanded, </del> <ins> collapsed: element.test.item.error ? ObjectTreeElementCollapseState.PreserveOrExpanded : (isCollapsedInSerializedTestTree(serialized, element.test.item.extId) ?? element.depth > 0 ? ObjectTreeElementCollapseState.PreserveOrCollapsed : ObjectTreeElementCollapseState.PreserveOrExpanded), </ins> children: getChildrenForParent(serialized, rootsWithChildren, element), } ));

display: none; } <ins> .test-explorer .monaco-list-row .error { outline: 1px solid var(--vscode-inputValidation-errorBorder); background: var(--vscode-inputValidation-errorBackground); padding: 2px 4px; border-radius: 2px; margin: 3px 12px 3px 3px; line-height: 17px; font-size: 12px; } </ins> .test-explorer .monaco-list-row .error p { margin: 0; }

} class ListDelegate implements IListVirtualDelegate<TestExplorerTreeElement> { <del> getHeight(_element: TestExplorerTreeElement) { return 22; </del> <ins> getHeight(element: TestExplorerTreeElement) { return element instanceof TestTreeErrorMessage ? 17 + 10 : 22; </ins> } getTemplateId(element: TestExplorerTreeElement) {
Change:
Testing This would also enable IntelliSense. The only way I could get it working is by changing the to an , but that then fails at runtime suggesting to use in the
I think this is something in TS. It seems like types recently(?) stopped working in commonjs .js files. For instance, making a new file in the vscode repo doesn't get types for requiring TypeScript. It also doesn't get types for built-in Node modules, in spite of them appearing as completions, even with . ! Intellisense did work in commonjs files when I first made it a few weeks ago.

Discussion:
): Proto.ExternalProjectCompilerOptions { const projectConfig: Proto.ExternalProjectCompilerOptions = { module: 'ESNext' as Proto.ModuleKind, <del> moduleResolution: (version.gte(API.v500) ? 'Bundler' : 'Node') as Proto.ModuleResolutionKind, </del> <ins> moduleResolution: 'Node' as Proto.ModuleResolutionKind, </ins> target: 'ES2022' as Proto.ScriptTarget, jsx: 'react' as Proto.JsxEmit, };
Change:
select a symbol wait for its occurrences to get highlighted press F7 to go to the next highlight :bug: doesn't work, error shows
adding label so that this gets verified

Discussion:
WordHighlighter.storedDecorations = WordHighlighter.storedDecorations.set(uri, newDecorationIDs); if (newDecorations.length > 0) { <ins> editorHighlighterContrib.wordHighlighter?.decorations.set(newDecorations); </ins> editorHighlighterContrib.wordHighlighter?._hasWordHighlights.set(true); } }
Change:
Testing It seems like the accessible buffer always open in screen reader accessibility mode after the link quickpick is closed, even if it was not open before. This seems like a bug. Also: it seems like Gitlens uses Ctrl+Shift+G as the start of its chords. With Gitlens installed, it overrides the keybinding, causing the editor to wait for another keypress.
Can you pls provide the exact repro steps?
For the first case: "Open Detected Link" from the command palette escape the accessible buffer is opened For the second issue, try using the Ctrl+Shift+G in the accessible buffer with Gitlens installed (on Windows at least)
Re the gitlens issue, most keybindings are taken, so I don't think I'll do anything about this.
In your steps above, if focus was in the accessible view before step 1, this is as designed. I cannot repro when I first focus the terminal.
Also assuming you pressed escape rather than going to a link
Also assuming you pressed escape rather than going to a link That's right Before step 1, I can have my focus in an editor or a terminal and the accessible view still opens. I noticed this only happens after I open the accessible view once:

Discussion:
e.stopPropagation(); this._contextViewService.hideContextView(); this._updateContextKeys(provider, false); <ins> this._lastProvider = undefined; </ins> }; const disposableStore = new DisposableStore(); disposableStore.add(this._editorWidget.onKeyDown((e) => {
Change:
Repro: (maybe not needed?) terminal some text, note the cursor location an editor the terminal, the cursor is at the start of the textbox !
Works on mac
It also works for me on Windows
any other steps required?
I think the repro is fill the viewport such that there's a scroll bar, then type
Ctrl+c helps make it happen too
Some other repros too: ! ! !
I'm hitting this: Looking into it

Discussion:
// Conpty could have the wrong cursor position at this point. if (!this._cursorOnNextLine() || !prompt) { this._windowsPromptPollingInProcess = true; <del> // Poll for 200ms until the cursor position is correct. </del> <ins> // Poll for 1000ms until the cursor position is correct. </ins> let i = 0; <del> for (; i < 20; i++) { await timeout(10); </del> <ins> for (; i < 50; i++) { await timeout(20); </ins> prompt = this._getWindowsPrompt(); if (this._store.isDisposed || !this._windowsPromptPollingInProcess || this._cursorOnNextLine() && prompt) { if (!this._windowsPromptPollingInProcess) {

} } this._windowsPromptPollingInProcess = false; <del> if (i === 20) { </del> <ins> if (i >= 50) { </ins> this._logService.debug('CommandDetectionCapability#_handleCommandStartWindows reached max attempts, ', this._cursorOnNextLine(), this._getWindowsPrompt()); } else if (prompt) { // use the regex to set the position as it's possible input has occurred

private _cursorOnNextLine(): boolean { const lastCommand = this.commands.at(-1); <ins> // There is only a single command, so this check is unnecessary </ins> if (!lastCommand) { <del> return false; </del> <ins> return true; </ins> } const cursorYAbsolute = this._terminal.buffer.active.baseY + this._terminal.buffer.active.cursorY; // If the cursor position is within the last command, we should poll. const lastCommandYAbsolute = (lastCommand.endMarker ? lastCommand.endMarker.line : lastCommand.marker?.line) ?? -1;

if (!line) { return; } <del> // TODO: fine tune prompt regex to accomodate for unique configurtions. return line.translateToString(true)?.match(/^(?<prompt>((.+)s)?(?:PS.+>s)|(?:[A-Z]:.*>))/)?.groups?.prompt; </del> <ins> // TODO: fine tune prompt regex to accomodate for unique configurations. const lineText = line.translateToString(true); if (!lineText) { return; } // PowerShell const pwshMatch = lineText.match(/(?<prompt>((.+)s)?(?:PS.+>s?))/); if (pwshMatch) { let prompt = pwshMatch?.groups?.prompt; if (lineText === prompt && prompt.endsWith('>')) { // Conpty may not 'render' the space at the end of the prompt prompt += ' '; } return prompt; } // Command Prompt const cmdMatch = lineText.match(/^(?<prompt>((.+)s)?(?:[A-Z]:.*>))/); return cmdMatch?.groups?.prompt; </ins> } handleGenericCommand(options?: IHandleCommandOptions): void {
Change:
a repo in click on the gutter :bug: Toggle Inline Chat Icon is present in the context menu
Also
Good catch thanks
It has been decided to mark this fix as a candidate and include it in the next recovery release

Discussion:
} GutterActionsRegistry.registerGutterActionsGenerator(({ lineNumber, editor, accessor }, result) => { <ins> const inlineChatService = accessor.get(IInlineChatService); const noProviders = Iterable.isEmpty(inlineChatService.getAllProvider()); if (noProviders) { return; } </ins> const configurationService = accessor.get(IConfigurationService); result.push(new Action( 'inlineChat.toggleShowGutterIcon',
Change:
Small typo in the method of aux windows. Steps: open an aux window with an editor go back to main window and show "Open Editors" double click into the editor of the aux window the aux window does not get window focus

Discussion:
auxiliaryWindow.focus = async function () { originalWindowFocus(); <del> if (getActiveWindow() === auxiliaryWindow) { </del> <ins> if (getActiveWindow() !== auxiliaryWindow) { </ins> that.nativeHostService.focusWindow({ targetWindowId: await windowId.p }); } };
Change:
something in a cell that will add a highlight to the cell above somewhere else to remove the highlight the top cell out of view then back in highlight is re- repro'd on the 1.84 RC and OSS !

Discussion:
// The selection must be inside a word or surround one word at most if (!word || word.startColumn > startColumn || word.endColumn < endColumn) { // no previous query, nothing to highlight <ins> WordHighlighter.query = null; </ins> this._stopAll(); return; }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: Have multiple quick fixes in a line, enabled. that AI quick fixes are above other quick fixes. !

Discussion:
return -1; } else if (!a.action.isPreferred && b.action.isPreferred) { return 1; <ins> } else if (a.action.isAI && !b.action.isAI) { return 1; } else if (!a.action.isAI && b.action.isAI) { return -1; </ins> } else { return 0; }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.84.0 (user setup) Commit: Date: 2023-11-01T11:29:04.398Z Electron: 25.9.2 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: VS Code (with an open folder) explorer view if not already visible view will be visible/expanded the Timeline view and relaunch VS Code view is visible/expanded again (expected behavior: it shall remain collapsed)
After a few days of working with it, I find this thing extremely annoying and it has almost become something I despise !
Very annoying!
Same issue
For now I just hide the Timeline completely from the Explorer view (right click on the Timeline bar and de-select it from the menu): !
Related on r/vscode:
I think this was caused by , specifically this code: I can repro it reliably if I first move the Outline view out of the Explorer view container, for example by dragging it onto the Secondary Side Bar. Here's what I see happening. startup the Timeline view initially gets alone to the empty Explorer view container, causing the code above to expand it (and also set it non-collapsible). soon after, the Explorer view (and maybe the Open Editors view) get . Now there's more that one view in the container, so the else-block immediately after the fragment shown above sets them all collapsible, but Timeline remains expanded. pinging
I have submitted a PR.
Related on Stack Overflow:

Discussion:
} else { if (this.paneItems.length === 1) { this.paneItems[0].pane.headerVisible = true; <del> this.paneItems[0].pane.setExpanded(true); </del> <ins> if (this.paneItems[0].pane === this.lastMergedCollapsedPane) { this.paneItems[0].pane.setExpanded(false); } </ins> this.paneItems[0].pane.collapsible = false; } else { this.paneItems.forEach(i => {
Change:
I noticed how we seem to be having a that is only used in : In that case we seem to not be using a for writing. But that will have pretty bad consequences because it can leave calls hanging even after . The unit test failure here actually shows it: I think this might have been introduced via
This strategy was introduced by I do not remember why we need immediate in server. I saw your change and I hope flush delayer for immediate should work.
I think the importance here is to always use the delayer, even when its with a delay of , because it was not only used to delay the saves, but also to aggregate them

Discussion:
private storage: StorageDatabase = Object.create(null); private lastSavedStorageContents = ''; <del> private readonly flushDelayer: ThrottledDelayer<void> | undefined; </del> <ins> private readonly flushDelayer = this._register(new ThrottledDelayer<void>(this.saveStrategy === SaveStrategy.IMMEDIATE ? 0 : 100 /* buffer saves over a short time */)); </ins> private initializing: Promise<void> | undefined = undefined; private closing: Promise<void> | undefined = undefined; constructor( private readonly storagePath: URI, <del> saveStrategy: SaveStrategy, </del> <ins> private readonly saveStrategy: SaveStrategy, </ins> private readonly logService: ILogService, private readonly fileService: IFileService, ) { super(); <del> this.flushDelayer = saveStrategy === SaveStrategy.IMMEDIATE ? undefined : this._register(new ThrottledDelayer<void>(100 /* buffer saves over a short time */)); </del> } init(): Promise<void> {

return; // already about to close } <del> if (this.flushDelayer) { return this.flushDelayer.trigger(() => this.doSave()); } return this.doSave(); </del> <ins> return this.flushDelayer.trigger(() => this.doSave()); </ins> } private async doSave(): Promise<void> {

async close(): Promise<void> { if (!this.closing) { <del> this.closing = this.flushDelayer ? this.flushDelayer.trigger(() => this.doSave(), 0 /* as soon as possible */) : this.doSave(); </del> <ins> this.closing = this.flushDelayer.trigger(() => this.doSave(), 0 /* as soon as possible */); </ins> } return this.closing;
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.84.0 OS Version: Windows 22H2 When a hidden task that has a "dependson" with a non-hidden task, it will hide that task too after being ran. Steps to Reproduce: example "Tasks: Run Task" in the command pallet "nonhidden task" and "Run hidden task" are available to run "Run hidden task" "Tasks: Run Task" in the command pallet Observe "nonhidden task" is now missing. Only "Run hidden task" is available

Discussion:
} else { dependencyTask.configurationProperties.icon = task.configurationProperties.icon; } <del> if (dependencyTask.configurationProperties.hide) { dependencyTask.configurationProperties.hide ||= task.configurationProperties.hide; } else { dependencyTask.configurationProperties.hide = task.configurationProperties.hide; } </del> } private async _getDependencyPromise(task: IActiveTerminalData): Promise<ITaskSummary> {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.84.0 (Universal) Commit: Date: 2023-11-01T11:30:19.406Z Electron: 25.9.2 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Darwin arm64 23.1.0 OS Version: macOS Sonoma 14.1 Steps to Reproduce: a task in with this format an editor window if not already open the task that the cursor stays in the editor so the terminal must be clicked on to press enter and dismiss the task
I have the same fault in the same version of VSCode.
Same problem with: My task looks like this:
Exactly the same here.
Same issue here.
Same here: In the 1.83 version it worked perfectly.
The same for me:

Discussion:
} else if (task.command.presentation && (task.command.presentation.focus || task.command.presentation.reveal === RevealKind.Always)) { this._terminalService.setActiveInstance(terminal); await this._terminalService.revealActiveTerminal(); <ins> if (task.command.presentation.focus) { this._terminalService.focusActiveInstance(); } </ins> } this._activeTasks[task.getMapKey()].terminal = terminal; this._fireTaskEvent(TaskEvent.changed());
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.84.1 OS Version: macOS (I'm using 14.1 but not specific to this version) Note that this issue is specific to Mac VoiceOver. Not a problem on Windows using NVDA or JAWS . Steps to Reproduce: VoiceOver on macOS via <kbdCmd</kbd+<kbdF5</kbdVisual Studio code <kbdCtrl</kbd+<kbdOption</kbd+<kbdShift</kbd+<kbdUp Arrow</kbdto move up until "Application" is announced (might take several times depending on starting location) <kbdCtrl</kbd+<kbdOption</kbd+<kbdShift</kbd+<kbdDown Arrow</kbdto enter the "Application", should announce you are on a toolbar (the one with the left/right arrows and search) <kbdCtrl</kbd+<kbdOption</kbd+<kbdShift</kbd+<kbdDown Arrow</kbdto enter the toolbar forward using VoiceOver cursor until the magnifying glass icon is selected (using <kbdCtrl</kbd+<kbdOption</kbd+<kbdRight Arrow</kbd) element is selectable via VoiceOver, but says nothing (no accessible text) <img width="1032" alt="Screenshot of top toolbar with arrow pointing at the magnifying glass icon" src=""Expected: I'd lean towards making this icon aria-hidden. It's already that way with other screen readers and you can't just add an aria-label to it (it would need a for that to be fully supported).
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.84.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
FYI (looks like you do a lot of a11y work).

Discussion:
// icon (search) const searchIcon = document.createElement('span'); <ins> searchIcon.ariaHidden = 'true'; </ins> searchIcon.className = action.class ?? ''; searchIcon.classList.add('search-icon');
Change:
Run "Show task log" command Get a notification, "there are task errors", click "show output" I don't see any log or errors ! Heard something about task logging during standup and noticed this.
Oh actually, the task changes didn't make it into insider's today. So not convinced this is a bug or related to the changes. Will investigate
Anything interesting with your task config/ had you made changes to it?
No, I see this in every window currently. for example, in a single-folder window with the vscode repo
My task changes went in 10 hrs ago and the latest build was 18 hrs ago.
I can reproduce in an old stable

Discussion:
} }); CommandsRegistry.registerCommand('workbench.action.tasks.showLog', () => { <del> this._showOutput(); </del> <ins> this._showOutput(undefined, true); </ins> }); CommandsRegistry.registerCommand('workbench.action.tasks.build', async () => {

this._workspace = setup[4]; } <del> protected _showOutput(runSource: TaskRunSource = TaskRunSource.User): void { </del> <ins> protected _showOutput(runSource: TaskRunSource = TaskRunSource.User, userRequested?: boolean): void { </ins> if (!VirtualWorkspaceContext.getValue(this._contextKeyService) && ((runSource === TaskRunSource.User) || (runSource === TaskRunSource.ConfigurationChange))) { <del> this._notificationService.prompt(Severity.Warning, nls.localize('taskServiceOutputPrompt', 'There are task errors. See the output for details.'), [{ label: nls.localize('showOutput', "Show output"), run: () => { this._outputService.showChannel(this._outputChannel.id, true); } }]); </del> <ins> if (userRequested) { this._outputService.showChannel(this._outputChannel.id, true); } else { this._notificationService.prompt(Severity.Warning, nls.localize('taskServiceOutputPrompt', 'There are task errors. See the output for details.'), [{ label: nls.localize('showOutput', "Show output"), run: () => { this._outputService.showChannel(this._outputChannel.id, true); } }]); } </ins> } }