jiebi/CodeConvo huggingface dataset:
Change:
Testing I find it a little weird how there is a cloud badge on the list item and that represents 2 different items origin/main and origin/HEAD in the hover? <img width="1031" alt="Screenshot 2024-08-27 at 10 31 23 AM" src=""Should these be different icons? Should it be a single item ? Should they be the same color?

Discussion:
return []; } <del> return [currentHistoryItemGroup.name, currentHistoryItemGroup.remote?.name ?? '', currentHistoryItemGroup.base?.name ?? '']; </del> <ins> return [ currentHistoryItemGroup.name, currentHistoryItemGroup.remote?.name, currentHistoryItemGroup.base?.name] .filter(l => l !== undefined); </ins> } private getTooltip(element: SCMHistoryItemViewModelTreeElement): IManagedHoverTooltipMarkdownString {

} } <del> if (historyItem.labels) { </del> <ins> const labels = this.getLabels(element.repository); const historyItemLabels = (historyItem.labels ?? []) .filter(l => labels.includes(l.title)); if (historyItemLabels) { </ins> const historyItemGroupLocalColor = colorTheme.getColor(historyItemGroupLocal); const historyItemGroupRemoteColor = colorTheme.getColor(historyItemGroupRemote); const historyItemGroupBaseColor = colorTheme.getColor(historyItemGroupBase);

const historyItemGroupHoverLabelForegroundColor = colorTheme.getColor(historyItemGroupHoverLabelForeground); markdown.appendMarkdown(`nn---nn`); <del> markdown.appendMarkdown(historyItem.labels.map(label => { </del> <ins> markdown.appendMarkdown(historyItemLabels.map(label => { </ins> const historyItemGroupHoverLabelBackgroundColor = label.title === currentHistoryItemGroup?.name ? historyItemGroupLocalColor : label.title === currentHistoryItemGroup?.remote?.name ? historyItemGroupRemoteColor :
Change:
have a code block in panel chat select Apply in Editor notice accept, discard, toggle lenses switch to another file (in the same editor group) :bug: the lenses are still there

Discussion:
data.lensActionsViewZoneIds?.forEach(viewZoneAccessor.removeZone); data.lensActionsViewZoneIds = undefined; <del> lensActions?.dispose(); </del> }); <ins> lensActions?.dispose(); </ins> overlay?.dispose(); };
Change:
Currently: If it's disabled and I enable it, nothing changes. I must reload the window. If it's enabled and I disable it, all colors are gone. Enabling it back again does nothing. I must reload the window. Let's make this setting work dynamically at runtime, so ease experimentation. Bonus: remove the from the setting name. Related:
This should already be working, and I do see it working. The colors being gone is not related to disabling it, it's actually still running but you've hit the bug where the tree is getting messed up. I removed disabling without reload as part of some structural changes. I'll see if it can be re-.
I am not sure this works, is it setting?
Looks like I need this:
Was just adding steps, yes that's it. Thanks for verifying!
Can I ask what languages treesister supports now? Or just only support typescript
Just typescript, and it's a work in progress: it is not yet performant, we don't support injected languages, and its missing a lot of the tricks we do to make syntax highlighting for the viewport fast. We're starting with typescript for selfhosting purposes.

Discussion:
TreeSitterTokenizationRegistry.getOrCreate(languageId); } } <ins> const languagesToUnregister = [...this._tokenizersRegistrations.keys()].filter(languageId => !setting.includes(languageId)); for (const languageId of languagesToUnregister) { this._tokenizersRegistrations.deleteAndDispose(languageId); } </ins> } private async _fetchQueries(newLanguage: string): Promise<TreeSitterQueries> {
Change:
branch from a non-default branch using the git extension's branch picker, e.g. from in PR :bug: previously was automatically picked as the base IIRC, but this time the base was Maybe related, I hadn't fetched so it was a remote branch at the time that I created a branch from it
I can repro this. If you create a branch from the "create from..." picker and choose a from that you don't have locally, then the ends up getting set to .

Discussion:
// Reflog const branchFromReflog = await this.getBranchBaseFromReflog(ref); <del> const branchFromReflogUpstream = branchFromReflog ? await this.getUpstreamBranch(branchFromReflog) : undefined; </del> <ins> let branchFromReflogUpstream: Branch | undefined = undefined; if (branchFromReflog?.type === RefType.RemoteHead) { branchFromReflogUpstream = branchFromReflog; } else if (branchFromReflog?.type === RefType.Head) { branchFromReflogUpstream = await this.getUpstreamBranch(branchFromReflog); } </ins> if (branchFromReflogUpstream) { await this.setConfig(mergeBaseConfigKey, `${branchFromReflogUpstream.remote}/${branchFromReflogUpstream.name}`); return branchFromReflogUpstream;
Change:
Steps to repro Open a notebook with some widget output (see here for more details and instructions ) Run the cell to generate the widget output Stage the notebook Run the cell again to generate the widget output once again Diff the changes No output is displayed in the diff viewer Ideally we should fallback to the image output instead of ipywidgets. This is what we get today (nothing is rendered) ! Expected behaviour !
getting this error, not really sure what I missed. or do you know since you had this TPI a while back? !
output still isn't displayed for me in the diff view (it does show for me in the notebook, and I confirmed a png image output is available) !

Discussion:
id: renderer.id, entrypoint, mimeTypes: renderer.mimeTypes, <del> messaging: renderer.messaging !== RendererMessagingSpec.Never, </del> <ins> messaging: renderer.messaging !== RendererMessagingSpec.Never && !!this.rendererMessaging, </ins> isBuiltin: renderer.isBuiltin }; });
Change:
Long lines with Word Wrap on can cause Sticky Scroll to increase in height relative to the long line However the content of the line isn't displayed and it simply covers the screen Steps to Reproduce: file and assign JSON code View -Word Wrap on one/three clicks down ! ! VS Code Version: 1.92.0 OS Version: Windows 11
I see this in markdown too. I came here to report it. With word wrap on the sticky headers cover a good bit of the editor window with blank space. It switches back and forth with normal view as you scroll or resize the pane. !
Same problem in CSS files, when I scroll to the second line that's wrapped, whole file code goes blank <img width="655" alt="Screenshot 2024-09-16 at 10 50 02" src=""
Hi thanks for filing this issue. This happens due to the incorrect calculation of one of the fields in the logic. This should be fixed by

Discussion:
if (topOfElementAtDepth > topOfEndLine && topOfElementAtDepth <= bottomOfEndLine) { startLineNumbers.push(start); endLineNumbers.push(end + 1); <del> lastLineRelativePosition = bottomOfEndLine - bottomOfElementAtDepth; </del> <ins> if (topOfElementAtDepth > bottomOfEndLine - lineHeight) { lastLineRelativePosition = bottomOfEndLine - bottomOfElementAtDepth; } </ins> break; } else if (bottomOfElementAtDepth > bottomOfBeginningLine && bottomOfElementAtDepth <= bottomOfEndLine) {
Change:
Type something so that the suggest widget appears Once it appeared and an item is selected, press on the left arrow key The text in the suggest widget disappears There remains a black box with nothing inside where the widget was positioned
hm... doesn't reproduce for me. can you check devtools console for errors?
nvm - I can reproduce running out of sources
regression from
Hi sorry, I just saw your messages. I think I didn't receive the notifications because the tab with this issue was open in chrome, and notifications were not sent. Anyway thanks for looking into this.

Discussion:
return; } <del> // This can happen when focus is in the details-panel and when // arrow keys are pressed to select next/prev items this._setState(State.Open); </del> <ins> if (this._state === State.Details) { // This can happen when focus is in the details-panel and when // arrow keys are pressed to select next/prev items this._setState(State.Open); } </ins> if (!e.elements.length) { if (this._currentSuggestionDetails) {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.93.0 OS Version: Steps to Reproduce: to ALL editors. LAST closed editor, no breadcrumbs shown. !

Discussion:
beforeCloseEditor(editor: EditorInput): void { } <del> closeEditor(editor: EditorInput): void { } </del> <ins> closeEditor(editor: EditorInput): void { this.handleClosedEditors(); } closeEditors(editors: EditorInput[]): void { this.handleClosedEditors(); } </ins> <del> closeEditors(editors: EditorInput[]): void { } </del> <ins> private handleClosedEditors(): void { this.activeEditor = this.tabsModel.activeEditor; } </ins> moveEditor(editor: EditorInput, fromIndex: number, targetIndex: number): void { }
Change:
Version: 1.94.0-insider Commit: Date: 2024-09-09T17:10:54.809Z Electron: 30.4.0 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Darwin arm64 23.6.0 Steps to Reproduce:
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

Discussion:
// Extensions Management else if (shouldSpawnCliProcess(args)) { <del> const cli = await import(['vs', 'code', 'node', 'cliProcessMain'].join('/') /* TODO@esm workaround to prevent esbuild from inlining this */); </del> <ins> const cli = await import(['./cliProcessMain.js'].join('/') /* TODO@esm workaround to prevent esbuild from inlining this */); </ins> await cli.main(args); return;
Change:
Version: 1.94.0-insider Commit: Date: 2024-09-09T17:10:54.809Z Electron: 30.4.0 ElectronBuildId: Chromium: 124.0.6367.243 20.15.1 V8: 12.4.254.20-electron.0 OS: Darwin arm64 22.6.0 If , typing doesn't accept the selected suggestion even when . Steps to Reproduce: as follows: a TypeScript file, show suggestions, and type . The selected suggestion is not accepted.
Hi thank you for filing this issue. I have traced the source of the issue and this should be fixed by: Thanks a lot for filing the issue, this code is in an experimental stage and contains certain bugs that need to be fixed as we go on.

Discussion:
if (standardKeyboardEvent.keyCode === KeyCode.KEY_IN_COMPOSITION) { standardKeyboardEvent.stopPropagation(); } <del> // Enter key presses are not sent as text update events, hence we need to handle them outside of the text update event // The beforeinput and input events send `insertParagraph` and `insertLineBreak` events but only on input elements // Hence we handle the enter key press in the keydown event if (standardKeyboardEvent.keyCode === KeyCode.Enter) { </del> <ins> viewController.emitKeyDown(standardKeyboardEvent); })); this._register(addDisposableListener(this.domNode.domNode, 'beforeinput', async (e) => { if (e.inputType === 'insertParagraph') { </ins> this._onType(viewController, { text: 'n', replacePrevCharCnt: 0, replaceNextCharCnt: 0, positionDelta: 0 }); } <del> viewController.emitKeyDown(standardKeyboardEvent); </del> })); // Edit context events
Change:
Type: <bBug</b! I expected an upstream/main badge on the tree, and that badge on the hover tip to have a colour. VS Code version: Code - Insiders 1.94.0-insider (, 2024-09-10T05:04:21.546Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
/assign
Nice catch! Fix should be in tomorrow's Insiders release.

Discussion:
switch (ref.type) { case RefType.RemoteHead: return { <del> id: `refs/remotes/${ref.remote}/${ref.name}`, </del> <ins> id: `refs/remotes/${ref.name}`, </ins> name: ref.name ?? '', description: ref.commit ? l10n.t('Remote branch at {0}', ref.commit.substring(0, 8)) : undefined, revision: ref.commit,

import { IActionViewItem } from '../../../../base/browser/ui/actionbar/actionbar.js'; import { IDropdownMenuActionViewItemOptions } from '../../../../base/browser/ui/dropdown/dropdownActionViewItem.js'; import { ActionViewItem } from '../../../../base/browser/ui/actionbar/actionViewItems.js'; <del> import { renderLabelWithIcons } from '../../../../base/browser/ui/iconLabel/iconLabels.js'; </del> import { IQuickInputService, IQuickPickItem, IQuickPickSeparator } from '../../../../platform/quickinput/common/quickInput.js'; import { Event } from '../../../../base/common/event.js'; import { Iterable } from '../../../../base/common/iterator.js';

name.textContent = localize('auto', "Auto"); } else if (this._historyItemsFilter.length === 1) { name.textContent = this._historyItemsFilter[0].name; <del> reset(this.label, ...renderLabelWithIcons(`$(git-branch) ${this._historyItemsFilter[0].name}`)); </del> } else { name.textContent = localize('items', "{0} Items", this._historyItemsFilter.length); }
Change:
Type: <bFeature Request</bI have selected , and but when I bring up the picker again I can't see this until I filter. ! Workaround (assuming the items I previously selected have a string in common): ! VS Code version: Code - Insiders 1.94.0-insider (, 2024-09-10T05:04:21.546Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
/assign

Discussion:
quickPick.busy = true; quickPick.show(); <del> quickPick.items = await this._createQuickPickItems(); quickPick.busy = false; </del> <ins> const items = await this._createQuickPickItems(); </ins> // Set initial selection let selectedItems: HistoryItemRefQuickPickItem[] = []; if (this._historyItemsFilter === 'all') { selectedItems.push(this._allQuickPickItem); <del> quickPick.selectedItems = [this._allQuickPickItem]; </del> } else if (this._historyItemsFilter === 'auto') { selectedItems.push(this._autoQuickPickItem); <del> quickPick.selectedItems = [this._autoQuickPickItem]; </del> } else { <del> for (const item of quickPick.items) { if (item.type === 'separator') { </del> <ins> let index = 0; while (index < items.length) { if (items[index].type === 'separator') { index++; </ins> continue; } <del> if (this._historyItemsFilter.some(ref => ref.id === item.id)) { selectedItems.push(item); </del> <ins> if (this._historyItemsFilter.some(ref => ref.id === items[index].id)) { const item = items.splice(index, 1) as HistoryItemRefQuickPickItem[]; selectedItems.push(...item); } else { index++; </ins> } } <del> quickPick.selectedItems = selectedItems; </del> <ins> // Insert the selected items after `All` and `Auto` items.splice(2, 0, { type: 'separator' }, ...selectedItems); </ins> } <ins> quickPick.items = items; quickPick.selectedItems = selectedItems; quickPick.busy = false; </ins> return new Promise<'all' | 'auto' | ISCMHistoryItemRef[] | undefined>(resolve => { this._store.add(quickPick.onDidChangeSelection(items => { const { added } = delta(selectedItems, items, (a, b) => compare(a.id ?? '', b.id ?? ''));
Change:
Type: <bBug</ba folder open. sure that the Secondary Side Bar is hidden. VS Code Insiders. it again. Secondary Side Bar displays VS Code version: Code - Insiders 1.94.0-insider (, 2024-09-10T05:04:21.546Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
The idea here was that when the activity bar is a the top, we would show the sidebars if they were open when you closed vscode as the activity bar is otherwise not visible. Thoughts? Do you think we should not do it at all or just for the primary side bar?
Is one (the primary) having been open at shutdown causing both (previously-hidden secondary as well as primary) to show on next startup? This doesn't seem right to me.
No, should be individually. We check if primary was open at shutdown, then we open primary and we check if secondary was closed at shutdown, if so, we open secondary
Did you write closed intentionally? That's indeed the behaviour I'm seeing, but I think secondary should only open at startup if it was open at shutdown.

Discussion:
} // Auxiliary Panel to restore <del> const auxiliaryBarVisible = this.isVisible(Parts.AUXILIARYBAR_PART); if (auxiliaryBarVisible || (isNewWindow && activityBarNotDefault)) { </del> <ins> if (this.isVisible(Parts.AUXILIARYBAR_PART)) { </ins> const viewContainerToRestore = this.storageService.get(AuxiliaryBarPart.activePanelSettingsKey, StorageScope.WORKSPACE, this.viewDescriptorService.getDefaultViewContainer(ViewContainerLocation.AuxiliaryBar)?.id); if (viewContainerToRestore) { this.state.initialization.views.containerToRestore.auxiliaryBar = viewContainerToRestore; <del> } if (auxiliaryBarVisible !== !!viewContainerToRestore) { this.stateModel.setRuntimeValue(LayoutStateKeys.AUXILIARYBAR_HIDDEN, !auxiliaryBarVisible); </del> <ins> } else { this.stateModel.setRuntimeValue(LayoutStateKeys.AUXILIARYBAR_HIDDEN, true); </ins> } }
Change:
Add the following settings into user settings Create a Notebook (e.g. github issues notebook) Add a few cells, run (its ok if there are failures) Save and stage the notebook Make changes to at least one of the cells View differences using Notebook Diff view You'll notice that the screen flickers, This is because the heights of the cells are computed by taking the height of output & metadata sections After a few ms, these are hidden and the cells move up a few pixes.
hit this and wasn't able to test:
Should be available for testing with next Insiders, thanks1

Discussion:
return this.configurationService.getValue<boolean>('notebook.diff.ignoreOutputs') || !!(this.mainDocumentTextModel?.transientOptions.transientOutputs); } <ins> private get ignoreMetadata() { return this.configurationService.getValue<boolean>('notebook.diff.ignoreMetadata'); } </ins> private _sourceEditorViewState: editorCommon.ICodeEditorViewState | editorCommon.IDiffEditorViewState | null = null; private _outputEditorViewState: editorCommon.ICodeEditorViewState | editorCommon.IDiffEditorViewState | null = null; private _metadataEditorViewState: editorCommon.ICodeEditorViewState | editorCommon.IDiffEditorViewState | null = null;

editorMargin: 0, metadataHeight: 0, cellStatusHeight, <del> metadataStatusHeight: 25, </del> <ins> metadataStatusHeight: this.ignoreMetadata ? 0 : 25, </ins> rawOutputHeight: 0, outputTotalHeight: 0, <del> outputStatusHeight: 25, </del> <ins> outputStatusHeight: this.ignoreOutputs ? 0 : 25, </ins> outputMetadataHeight: 0, bodyMargin: 32, totalHeight: 82 + cellStatusHeight + editorHeight,
Change:
Type: <bBug</bSteps to reproduce: window right click in editor area - it's hidden almost immediately (in come cases recording didn't catch it) right click in explorer tree, tabs, status bar - works as expected VS Code version: Code - Insiders 1.94.0-insider (, 2024-09-11T05:04:03.124Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --
Seems to happen on Windows but not on MacOS
The source of this bug has been found. After the context menu is shown, the screen reader content of the native edit context is updated, the document range is set. The context menu loses focus and is hidden. This issue happens in Windows but not on MacOS because Windows uses a different context menu logic. A fix will be found.
Works on my machine now Version: 1.94.0-insider Commit: Date: 2024-09-16T05:03:40.122Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.94.0-insider Chrome/124.0.6367.243 Electron/30.4.0 Safari/537.36
Thank you for verifying

Discussion:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { getActiveWindow, isHTMLElement } from '../../../../../base/browser/dom.js'; </del> <ins> import { getActiveWindow } from '../../../../../base/browser/dom.js'; </ins> import { FastDomNode } from '../../../../../base/browser/fastDomNode.js'; import { AccessibilitySupport } from '../../../../../platform/accessibility/common/accessibility.js'; import { IKeybindingService } from '../../../../../platform/keybinding/common/keybinding.js';

public setAriaOptions(): void { } public writeScreenReaderContent(): void { <ins> const focusedElement = getActiveWindow().document.activeElement; if (!focusedElement || focusedElement !== this._domNode.domNode) { return; } </ins> this._screenReaderContentState = this._getScreenReaderContentState(); if (!this._screenReaderContentState) { return;

if (!textContent) { return; } <del> const focusedElement = getActiveWindow().document.activeElement; </del> const range = new globalThis.Range(); range.setStart(textContent, selectionOffsetStart); range.setEnd(textContent, selectionOffsetEnd); activeDocumentSelection.removeAllRanges(); activeDocumentSelection.addRange(range); <del> if (isHTMLElement(focusedElement)) { focusedElement.focus(); } </del> } }
Change:
I believe the property is to the notebook metadata only for internal usage, hence this should probably be marked as transient. !

Discussion:
keepNotebookModelStoreInSync(context); const notebookSerializerOptions: OptionsWithCellContentMetadata = { transientOutputs: false, <ins> transientDocumentMetadata: { cells: true, indentAmount: true }, </ins> transientCellMetadata: { breakpointMargin: true, id: false,
Change:
Type: <bBug</bDelete a notebook file in a git repo Open it from the SCM view It's editable ;( VS Code version: Code - Insiders 1.94.0-insider (Universal) (, 2024-09-11T05:04:03.124Z) OS version: Darwin arm64 23.6.0 Modes: <!-- generated by issue reporter --
Fixed by

Discussion:
readonly outputScrolling?: boolean; readonly outputLinkifyFilePaths?: boolean; readonly minimalError?: boolean; <ins> readonly readonly?: boolean; </ins> } const defaultConfigConstants = Object.freeze({

} private _isDisposed = false; <ins> private _isReadonly = false; </ins> constructor( readonly viewType: string,

} <del> abstract updateOptions(e: NotebookOptionsChangeEvent): void; </del> <ins> updateOptions(e: NotebookOptionsChangeEvent): void { if (this._textEditor && typeof e.readonly === 'boolean') { this._textEditor.updateOptions({ readOnly: e.readonly }); } if (typeof e.readonly === 'boolean') { this._isReadonly = e.readonly; } } </ins> abstract getHeight(lineHeight: number): number; abstract onDeselect(): void; abstract layoutChange(change: CellLayoutChangeEvent, source?: string): void;

} this._textEditor = editor; <ins> if (this._isReadonly) { editor.updateOptions({ readOnly: this._isReadonly }); } </ins> if (this._editorViewStates) { this._restoreViewState(this._editorViewStates); } else {

} } <del> updateOptions(e: NotebookOptionsChangeEvent) { </del> <ins> override updateOptions(e: NotebookOptionsChangeEvent) { super.updateOptions(e); </ins> if (e.cellStatusBarVisibility || e.insertToolbarPosition || e.cellToolbarLocation) { this.layoutChange({}); }

0 : this.viewContext.notebookOptions.getLayoutConfiguration().markdownFoldHintHeight; } <del> updateOptions(e: NotebookOptionsChangeEvent) { </del> <ins> override updateOptions(e: NotebookOptionsChangeEvent) { super.updateOptions(e); </ins> if (e.cellStatusBarVisibility || e.insertToolbarPosition || e.cellToolbarLocation) { this._updateTotalHeight(this._computeTotalHeight()); }

updateOptions(newOptions: Partial<NotebookViewModelOptions>) { this._options = { ...this._options, ...newOptions }; <ins> this._viewCells.forEach(cell => cell.updateOptions({ readonly: this._options.isReadOnly })); </ins> this._onDidChangeOptions.fire(); }