jiebi/CodeConvo huggingface dataset:
Change:
Type: <bBug</byour mouse pointer over the minimize, maximize/restore window buttons. the absence of the button hover animation. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-20T06:55:34.457Z) OS version: Linux x64 6.2.0-35-generic snap Modes: <details<summarySystem Info</summary </detailsExtensions: none<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
I was not able to reproduce with the latest snap release on ubuntu. please let me know if you continue to reproduce.
I have the same issue as OP and I'm using the PPA install method under KDE Neon (Ubuntu 22.04 based). Please consider reopening the issue. System info below: Version: 1.85.1 Commit: Date: 2023-12-13T09:47:11.635Z Electron: 25.9.7 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Linux x64 6.2.0-39-generic
I can still reproduce the issue, but only using the default "Light Modern" theme. So, it looks like this is the problem of the default "Light Modern" theme. Initially, I thought the animation was missing, but if you look closely it's there. However, the transition states are so subtle, they're barely visible. VS Code Version: VS Code Insiders Version:
True looks like a theming issue and on my end all light mode themes exhibit this issue. All dark mode ones work well.
I couldn't repro this with stable, but I also couldn't repro with insiders, so marking as verified.
The issue still persists as of today and will hopefully be resolved in a future release. Until then, if you're using a light theme, you can add something like this to your file: This will make the title bar a bit darker and the hover animation will show even if slightly.

Discussion:
background-color: rgba(255, 255, 255, 0.1); } <del> .monaco-workbench .part.titlebar.light > .window-controls-container > .window-icon:hover { </del> <ins> .monaco-workbench .part.titlebar.light .window-controls-container > .window-icon:hover { </ins> background-color: rgba(0, 0, 0, 0.1); }
Change:
Type: <bBug</bWhen there is only one instance and the Source Control Providers and Source Control Sync views are not showing, the toolbar moves to the SCM view container titlebar, and the callback of a command contributed to that menu does not receive the instance as a parameter. In other circumstances the command callback does receive the parameter. Repro: source-control-sample, build it and run it. Follow its README steps to get it contributing to the SCM view container. for the zap icon this branch adds to scm/title. it when that menu is not merged to the view container window because another view is visible too. Note the message in the modal information dialog, then dismiss it. the other view(s) and click zap again. The message is different. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-20T05:34:58.027Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
Looks like this was previously reported in and subsequently fixed. are you also seeing this regression? For me it's also broken in 1.83, so not a reason to hold up the current iteration.
thank you very much for the detailed repro steps. I am also able to reproduce this the commands that the extension contributes to the menu.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified

Discussion:
import 'vs/css!./media/scm'; import { localize } from 'vs/nls'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; <del> import { VIEWLET_ID } from 'vs/workbench/contrib/scm/common/scm'; </del> <ins> import { ISCMViewService, VIEWLET_ID } from 'vs/workbench/contrib/scm/common/scm'; </ins> import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { IContextMenuService } from 'vs/platform/contextview/browser/contextView'; import { IThemeService } from 'vs/platform/theme/common/themeService';

export class SCMViewPaneContainer extends ViewPaneContainer { constructor( <ins> @ISCMViewService private readonly scmViewService: ISCMViewService, </ins> @IWorkbenchLayoutService layoutService: IWorkbenchLayoutService, @ITelemetryService telemetryService: ITelemetryService, @IInstantiationService instantiationService: IInstantiationService,

override getTitle(): string { return localize('source control', "Source Control"); } <ins> override getActionsContext(): unknown { return this.scmViewService.visibleRepositories.length === 1 ? this.scmViewService.visibleRepositories[0].provider : undefined; } </ins> }
Change:
Type: <bBug</bCC When I type something in terminal Accessible View, the first letter simply distroys the open Accessible View and it is not passed onto terminal. Instead, the second letter typing is passed to the terminal. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-20T05:34:58.027Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (93)</summaryExtensionVersion ------ android-dev-ext1.3.2 aiprm-lang0.0.2 Bookmarks13.4.2 openscad1.2.2 spellright3.0.118 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.3 doxdocgen1.4.0 vscode-markdownlint0.52.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.26.0 gitlens14.4.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.16.0 copilot1.128.504 copilot-chat0.9. remotehub0.62.0 vscode-github-actions0.26.2 vscode-pull-request-github0.74.0 overleaf-workshop0.3.1 cslpreview0.2.2 easy-snippet0.6.3 path-autocomplete1.25.0 latex-workshop9.14.1 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 vscode-bard0.0.10 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.27.0 black-formatter2023.5. flake82023.8.0 isort2023.11. python2023.19. vscode-pylance2023.10.41 jupyter2023.10. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.318.0 remote-ssh0.107. remote-ssh-edit0.86.0 remote-wsl0.81.8 vscode-remote-extensionpack0.24.0 azure-repos0.38.0 cmake-tools1.15.31 cpptools1.17.5 cpptools-extension-pack1.3.0 js-debug-nightly2023.10.1717 powershell2023.9.5 remote-explorer0.5. remote-repositories0.40.0 vscode-github-issue-notebooks0.0.130 vscode-selfhost-test-provider0.3.19 vscode-serial-monitor0.10.0 vsliveshare1.0.5883 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.5 shinyuieditor0.5.0 quarto1.105.0 r-debugger0.5.4 java1.23.0 vscode-xml0.26.1 r2.8.2 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.7.0 latex-utilities0.4.10 cmake0.0.17 errorlens3.14.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.54.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.14 vscode-java-test0.40.0 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Thanks for reporting!

Discussion:
{ "version": "2.0.0", "tasks": [ { "type": "npm", "script": "watch-clientd",

this._contextViewService.hideContextView(); this._updateContextKeys(provider, false); // HACK: Delay to allow the context view to hide #186514 <del> setTimeout(() => provider.onClose(), 100); </del> <ins> if (provider.id === AccessibleViewProviderId.Terminal) { provider.onClose(); } else { setTimeout(() => provider.onClose(), 100); } </ins> }; const disposableStore = new DisposableStore(); disposableStore.add(this._editorWidget.onKeyDown((e) => {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Version: 1.84.0-insider (user setup) Commit: Date: 2023-10-23T05:34:05.496Z Electron: 25.9.1 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: two workspaces a couple of files Active Editor into a New Window on the new window and Press Alt+F4 : aux window closes. Actual: VS Code closes the workspace and both windows associated with it.
Can you see if is assigned as keybinding? I assume this goes through our global window close handler that has not yet adopted aux windows.
I have default keybindings { "key": "alt+f4", "command": "" },

Discussion:
override async run(accessor: ServicesAccessor): Promise<void> { const nativeHostService = accessor.get(INativeHostService); <ins> const window = getActiveWindow(); if (isAuxiliaryWindow(window)) { return nativeHostService.closeWindowById(await window.vscodeWindowId); } </ins> return nativeHostService.closeWindow(); } }
Change:
Type: <bBug</bWhen a notebook updates text in a collapsed cells unexpected things happen. The Jupyter Notebook renders the output while still showing that the output is collapsed. Node.JS Notebooks and httpBook show empty cells and will only show the output again when expanded, collapsed, expanded again In the the result looks like this: ! Issue created to hopefully follow up Extension version: 2023.9. VS Code version: Code 1.83.1 (Universal) (, 2023-10-10T23:46:55.789Z) OS version: Darwin arm64 23.0.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --

Discussion:
async updateOutput(cell: CodeCellViewModel, output: IInsetRenderOutput, offset: number): Promise<void> { this._insetModifyQueueByOutputId.queue(output.source.model.outputId, async () => { <del> if (this._isDisposed || !this._webview) { </del> <ins> if (this._isDisposed || !this._webview || cell.isOutputCollapsed) { </ins> return; }

const index = this.viewCell.outputsViewModels.indexOf(this.output); if (this.viewCell.isOutputCollapsed || !this.notebookEditor.hasModel()) { <ins> this.cellOutputContainer.flagAsStale(); </ins> return undefined; }

export class CellOutputContainer extends CellContentPart { private _outputEntries: OutputEntryViewHandler[] = []; <ins> private _hasStaleOutputs: boolean = false; </ins> get renderedOutputEntries() { return this._outputEntries;

} } <ins> /** * Notify that an output may have been swapped out without the model getting rendered. */ flagAsStale() { this._hasStaleOutputs = true; } </ins> private _doRender() { if (this.viewCell.outputsViewModels.length > 0) { if (this.viewCell.layoutInfo.outputTotalHeight !== 0) {

} viewUpdateShowOutputs(initRendering: boolean): void { <ins> if (this._hasStaleOutputs) { this._hasStaleOutputs = false; this._outputEntries.forEach(entry => { entry.element.rerender(); }); } </ins> for (let index = 0; index < this._outputEntries.length; index++) { const viewHandler = this._outputEntries[index]; const outputEntry = viewHandler.element;
Change:
I suggest to have the sub-menu with the 3 options also in the view menu "Appearance" <img width="532" alt="image" src=""

Discussion:
} registerAction2(ShowSingleEditorTabAction); <ins> // --- Tab Bar Submenu in View Appearance Menu MenuRegistry.appendMenuItem(MenuId.MenubarAppearanceMenu, { submenu: MenuId.EditorTabsBarShowTabsSubmenu, title: localize('tabBar', "Tab Bar"), group: '4_editor', order: 6 }); </ins> // --- Toggle Pinned Tabs On Separate Row registerAction2(class extends Action2 {
Change:
Testing enable open and side by side select click on occurrences :bug: whenever an occurrence is selected for the first time all highlights disappear and reappear This also happens in the single document highlight case and I am sure is a regression
Looks like this is fixed with Seems like two birds, one stone. Cannot repro in OSS with latest . Insiders behavior (broken) latest OSS (fixed)
bug label for verification
Also the milestone should be set.

Discussion:
WordHighlighter.storedDecorations = WordHighlighter.storedDecorations.set(uri, newDecorationIDs); if (newDecorations.length > 0) { <ins> editorHighlighterContrib.wordHighlighter?.decorations.set(newDecorations); </ins> editorHighlighterContrib.wordHighlighter?._hasWordHighlights.set(true); } }
Change:
Testing When I dragged one of the icons to the second side bar, I wanted it to be placed before the other icon, however, it was placed behind it even though the bar indicating where it would be placed was in front of the icon. Also I noticed it's not possible to drop an icon on the top part of the side bar when the side bar is empty. It's only possible to drop it on the view part of the side bar. I think it should be possible to drop it everywhere in the second side bar when it is empty. !
I cannot reproduce this. I see it is happening in the recording, but it would be great if you can give me steps you followed to repro. Agreed. This is not new and has been like this before. But, I observed another bug in your recording that dropping the view container is not activating it - this used to be getting activated in older versions. Fixed that.

Discussion:
@IWorkbenchEnvironmentService environmentService: IWorkbenchEnvironmentService, @IConfigurationService private readonly configurationService: IConfigurationService, @IMenuService private readonly menuService: IMenuService, <del> @IWorkbenchLayoutService private readonly layoutService: IWorkbenchLayoutService, </del> <ins> @IWorkbenchLayoutService layoutService: IWorkbenchLayoutService, </ins> ) { super({ ...options,

options.fillExtraContextMenuActions(actions, e); this.fillContextMenuActions(actions, e); } <del> }, part, paneCompositePart, instantiationService, storageService, extensionService, viewDescriptorService, contextKeyService, environmentService); </del> <ins> }, part, paneCompositePart, instantiationService, storageService, extensionService, viewDescriptorService, contextKeyService, environmentService, layoutService); </ins> if (showGlobalActivities) { this.globalCompositeBar = this._register(instantiationService.createInstance(GlobalCompositeBar, () => this.getContextMenuActions(), (theme: IColorTheme) => this.options.colors(theme), this.options.activityHoverOptions));

@IViewDescriptorService private readonly viewDescriptorService: IViewDescriptorService, @IContextKeyService protected readonly contextKeyService: IContextKeyService, @IWorkbenchEnvironmentService private readonly environmentService: IWorkbenchEnvironmentService, <ins> @IWorkbenchLayoutService protected readonly layoutService: IWorkbenchLayoutService, </ins> ) { super(); this.location = paneCompositePart.partId === Parts.PANEL_PART

if (to === this.location) { this.onDidRegisterViewContainers([container]); <ins> // Open view container if part is visible and there is no other view container opened const visibleComposites = this.compositeBar.getVisibleComposites(); if (!this.paneCompositePart.getActivePaneComposite() && this.layoutService.isVisible(this.paneCompositePart.partId) && visibleComposites.length) { this.paneCompositePart.openPaneComposite(visibleComposites[0].id); } </ins> } }
Change:
Type: <bBug</bextensions view, search Bug No results ! ! I'd expect to see autopep8 listed as the word appears in its description is shown in the normal extension results without using VS Code version: Code - Insiders 1.84.0-insider (Universal) (, 2023-10-24T05:35:10.309Z) OS version: Darwin arm64 23.0.0 Modes: <details<summarySystem Info</summary </details<!-- generated by issue reporter --

Discussion:
value = value.replace(/@installed/g, '').replace(/@sort:(w+)(-w*)?/g, '').trim().toLowerCase(); <del> const matchingText = (e: IExtension) => (e.name.toLowerCase().indexOf(value) > -1 || e.displayName.toLowerCase().indexOf(value) > -1) </del> <ins> const matchingText = (e: IExtension) => (e.name.toLowerCase().indexOf(value) > -1 || e.displayName.toLowerCase().indexOf(value) > -1 || e.description.toLowerCase().indexOf(value) > -1) </ins> && (!categories.length || categories.some(category => (e.local && e.local.manifest.categories || []).some(c => c.toLowerCase() === category))); let result;
Change:
Testing Extension Event Log
I actually wasn't sure if the glob pattern was supposed to be excluding this file in the default watcher excludes but even specifying the glob directly like this doesn't exclude:
the default exclude is actually so that we can still detect changes to top level folder. So your first observation is actually expected. It would only ignore for deeper folder structures within .
Your second case is a nice find though: you provide an explicit exclude list and the events that you see are actually from the default workspace file watcher. should address that.

Discussion:
async $watch(extensionId: string, session: number, resource: UriComponents, unvalidatedOpts: IWatchOptions): Promise<void> { const uri = URI.revive(resource); <del> const correlate = Array.isArray(unvalidatedOpts?.excludes) && unvalidatedOpts.excludes.length > 0; // TODO@bpasero for now only correlate proposed new file system watcher API with excludes </del> const opts: IWatchOptions = { ...unvalidatedOpts

} } <del> // Correlated file watching is taken as is </del> <ins> // Correlated file watching is taken as is (for now we only opt into correlating with proposed new file system watcher API with excludes) const correlate = Array.isArray(unvalidatedOpts?.excludes) && unvalidatedOpts.excludes.length > 0; </ins> if (correlate) { this._logService.trace(`MainThreadFileSystemEventService#$watch(): request to start watching correlated (extension: ${extensionId}, path: ${uri.toString(true)}, recursive: ${opts.recursive}, session: ${session})`);

// https://github.com/microsoft/vscode/issues/3025 const excludeOutOfWorkspaceEvents = typeof globPattern === 'string'; <ins> // 1.84.x introduces new proposed API for a watcher to set exclude // rules. When this is provided, we turn the file watcher into correlation // mode and ignore any event that does not match the correlation ID. const excludeUncorrelatedEvents = Array.isArray(options?.excludes) && options.excludes.length > 0; </ins> const subscription = dispatcher(events => { if (typeof events.session === 'number' && events.session !== this.session) { <del> return; // ignore events from other file watchers </del> <ins> return; // ignore events from other file watchers that are in correlation mode } if (excludeUncorrelatedEvents && typeof events.session === 'undefined') { return; // ignore events from other non-correlating file watcher when we are in correlation mode </ins> } if (!options?.ignoreCreateEvents) {
Change:
Testing Seems somewhat random... but doesn't seem to work between cell 1 and 2... but it works between cell 2 and 3. Cell 1: Cell 2: Cell 3:
I see the same behavior after resizing my window to a smaller size. In full screen mode, it works as expected

Discussion:
const firstIndex = this.view.firstVisibleIndex; const elementHeight = this.view.elementHeight(viewIndex); <del> if (viewIndex <= firstIndex || elementHeight >= this.view.renderHeight) { this._revealInternal(viewIndex, true, CellRevealPosition.Top, firstLine); </del> <ins> if (viewIndex <= firstIndex || (!firstLine && elementHeight >= this.view.renderHeight)) { this._revealInternal(viewIndex, true, CellRevealPosition.Top); </ins> } else { this._revealInternal(viewIndex, true, CellRevealPosition.Bottom, firstLine); }
Change:
Testing a file and test that gutter sparkle icon appears when the cursor is on an empty line. the file to the side or bottom of the editor to start a new editor group. the cursor to an empty line. No gutter sparkle icon is visiable. Note that moving a second editor into the new editor group correctly displays the sparkle icon. Also going back to the original first file in the editor group now shows the sparkle icon.

Discussion:
})); this._register(this._inlineChatService.onDidChangeProviders(() => this._onEnablementOrModelChanged())); this._register(this._editor.onDidChangeModel(() => this._onEnablementOrModelChanged())); <ins> this._onEnablementOrModelChanged(); </ins> } private _onEnablementOrModelChanged(): void {
Change:
Testing a file and see gutter sparkle icon displayed on empty line. either View: Split in Group or View: Toggle Split in Group cursor to a line where there gutter sparkle icon should be displayed. No gutter sparkle icon is visible. Split in Group again and gutter sparkle icon is displayed as expected

Discussion:
})); this._register(this._inlineChatService.onDidChangeProviders(() => this._onEnablementOrModelChanged())); this._register(this._editor.onDidChangeModel(() => this._onEnablementOrModelChanged())); <ins> this._onEnablementOrModelChanged(); </ins> } private _onEnablementOrModelChanged(): void {
Change:
This ask is from the Copilot team in response to feedback they've received. When something is represented via only an icon, and is focused via keyboard, we should automatically focus the tooltip.
cc
related
we would also want to do this for all toolbars <img width="202" alt="Screenshot 2023-11-01 at 10 12 16 AM" src=""
Just out of curiosity, what does "focus the tooltip mean"? Does it mean "make the tooltip visible"? (sorry- the language is a bit confusing. tooltips are not actually focusable, right?)
yes I think meant to show the hover, not focus it as that would break left/right navigation.
Yep, it just shows the hover, doesn't focus it.

Discussion:
isEnabled(): boolean; focus(fromRight?: boolean): void; // TODO@isidorn what is this? blur(): void; <ins> showHover?(): void; </ins> } export interface IActionViewItemProvider {

const elem = this.actionsList.children[i]; if (DOM.isAncestor(DOM.getActiveElement(), elem)) { this.focusedItem = i; <ins> this.viewItems[this.focusedItem]?.showHover?.(); </ins> break; } }

if (this.previouslyFocusedItem !== undefined && this.previouslyFocusedItem !== this.focusedItem) { this.viewItems[this.previouslyFocusedItem]?.blur(); } <del> const actionViewItem = this.focusedItem !== undefined && this.viewItems[this.focusedItem]; </del> <ins> const actionViewItem = this.focusedItem !== undefined ? this.viewItems[this.focusedItem] : undefined; </ins> if (actionViewItem) { let focusItem = true;

if (actionViewItem.action.id === Separator.ID) { focusItem = false; } <ins> if (focusItem) { actionViewItem.showHover?.(); } </ins> if (!focusItem) { this.actionsList.focus({ preventScroll }); this.previouslyFocusedItem = undefined;

})); } <del> private showHover(skipFadeInAnimation: boolean = false): void { </del> <ins> showHover(skipFadeInAnimation: boolean = false): void { </ins> if (this.lastHover && !this.lastHover.isDisposed) { return; }
Change:
Testing a New Text File and add some empty lines. around the file. No gutter sparkle icons shown. ! the file Still no gutter sparkle icons. Sparkle icons show up after some text is entered. If you remove the text in that session with the file, the sparkle icons are displayed but if you close and reopen the empty file, no sparkle icons. !

Discussion:
})); this._register(this._inlineChatService.onDidChangeProviders(() => this._onEnablementOrModelChanged())); this._register(this._editor.onDidChangeModel(() => this._onEnablementOrModelChanged())); <ins> this._onEnablementOrModelChanged(); </ins> } private _onEnablementOrModelChanged(): void {