Change:
Currently in SCM we render the hidden action bar when an item has focus, hover or if it is selected. This is unlike other view where we render the action bar only when an item has focus or is hovered. I suggest that we change the SCM to behave like the other views. Apart from consistency this should also improve focus navigation fyi to see if he did this behaviour on purpose !
This is because you can click those actions and they will execute for all selected items. We can't really change that. In your screenshot, for example, there wouldn't be a way to stage those 3 selected changes, if we hide those actions, other than the context menu.
we still show the action bar on hover. So if you would hover you would get it and you could trigger.
Oh right! I guess then yeah we could definitely do it.
Perhaps I'm not understanding this issue title. I would expect the , but in the latest insiders, the action bar shows always, whether its selected or not, whether we're hovering or not, Is this what's expected? /cc ! |
I just verified and this works well for me. Adding verified label. can you still reproduce that all the toolbars are shown. Do you have repro steps? I can not see this.
Yes still the same as per the screenshot. Repro steps are simple, just make changes in a folder with git as scm btw, I have updated to the latest version of VS Code insiders as well.
Ok. Feel free to reopen this issue, or create a new one then. I know Lad is out today though
let me know what you need, versions, logs, etc. THis is the latest version of VS Code I have installed and here's a screenshot Version: 1.87.0-insider Commit: Date: 2024-02-22T05:59:28.380Z Electron: 27.3.2 ElectronBuildId: Chromium: 118.0.5993.159 18.17.1 V8: 11.8.172.18-electron.0 OS: Darwin arm64 23.3.0 <img width="335" alt="Screenshot 2024-02-23 at 00 29 39" src=""
based on the screenshots it seems to me that in Insiders you have the setting enabled while that is not the case for Stable. I will "restore" the label but if you do not have the setting enabled please reopen the issue. Thanks!
Spot on, yes, thanks. Not sure how that got set though.

Discussion:
} .scm-view .monaco-list .monaco-list-row:hover .resource-group > .actions, <del> .scm-view .monaco-list .monaco-list-row.selected .resource-group > .actions, </del> .scm-view .monaco-list .monaco-list-row.focused .resource-group > .actions, .scm-view .monaco-list .monaco-list-row:hover .resource > .name > .monaco-icon-label > .actions, <del> .scm-view .monaco-list .monaco-list-row.selected .resource > .name > .monaco-icon-label > .actions, </del> .scm-view .monaco-list .monaco-list-row.focused .resource > .name > .monaco-icon-label > .actions, .scm-view .monaco-list:not(.selection-multiple) .monaco-list-row .resource:hover > .actions, .scm-view .monaco-list .monaco-list-row:hover .separator-container > .actions, <del> .scm-view .monaco-list .monaco-list-row.selected .separator-container > .actions, </del> .scm-view .monaco-list .monaco-list-row.focused .separator-container > .actions, .scm-view .monaco-list .monaco-list-row:hover .history-item-group > .actions, <del> .scm-view .monaco-list .monaco-list-row.selected .history-item-group > .actions, </del> .scm-view .monaco-list .monaco-list-row.focused .history-item-group > .actions, .scm-view .monaco-list .monaco-list-row:hover .history-item > .actions, <del> .scm-view .monaco-list .monaco-list-row.selected .history-item > .actions, </del> .scm-view .monaco-list .monaco-list-row.focused .history-item > .actions { display: block; }