Change:
I like the improved "All done. You can close this tab now."-dialog but I think it is missing a "Close Tab" option. Today, when everything works you need to hit "Cancel" but I don't have the close tab option - which is what the title suggests
what are the steps to trigger this?
Use Continue On Reopen on the Desktop from

Discussion:
import { IWorkbenchLayoutService } from 'vs/workbench/services/layout/browser/layoutService'; import { BrowserLifecycleService } from 'vs/workbench/services/lifecycle/browser/lifecycleService'; import { ILifecycleService } from 'vs/workbench/services/lifecycle/common/lifecycle'; <ins> import { IHostService } from 'vs/workbench/services/host/browser/host'; </ins> export class BrowserWindow extends Disposable {

@ILabelService private readonly labelService: ILabelService, @IProductService private readonly productService: IProductService, @IBrowserWorkbenchEnvironmentService private readonly environmentService: IBrowserWorkbenchEnvironmentService, <del> @IWorkbenchLayoutService private readonly layoutService: IWorkbenchLayoutService </del> <ins> @IWorkbenchLayoutService private readonly layoutService: IWorkbenchLayoutService, @IHostService private readonly hostService: IHostService </ins> ) { super();

invokeProtocolHandler(); const showProtocolUrlOpenedDialog = async () => { <ins> const { downloadUrl } = this.productService; let detail = localize( 'openExternalDialogDetail.v2', "We launched {0} on your computer.nnIf {1} did not launch, try again or install it below.", this.productService.nameLong, this.productService.nameLong ); const options = [ localize('openExternalDialogButtonClose', "Close tab"), localize('openExternalDialogButtonRetry', "Try again"), localize('openExternalDialogButtonInstall.v3', "Install"), localize('openExternalDialogButtonCancel', "Cancel") ]; if (downloadUrl === undefined) { options.splice(2, 1); detail = localize( 'openExternalDialogDetailNoInstall', "We launched {0} on your computer.nnIf {1} did not launch, try again below.", this.productService.nameLong, this.productService.nameLong ); } </ins> const showResult = await this.dialogService.show( Severity.Info, localize('openExternalDialogTitle', "All done. You can close this tab now."), <del> [ localize('openExternalDialogButtonRetry', "Try again"), localize('openExternalDialogButtonInstall', "Install {0}", this.productService.nameLong), localize('openExternalDialogButtonCancel', "Cancel") ], </del> <ins> options, </ins> { <del> cancelId: 2, detail: localize( 'openExternalDialogDetail.v2', "We launched {0} on your computer.nnIf {1} did not launch, try again or install it below.", this.productService.nameLong, this.productService.nameLong, ) </del> <ins> cancelId: downloadUrl === undefined ? 2 : 3, detail </ins> }, ); if (showResult.choice === 0) { <del> invokeProtocolHandler(); </del> <ins> this.hostService.close(); </ins> } else if (showResult.choice === 1) { <del> // Route the user to the appropriate install link await this.openerService.open(URI.parse( this.productService.quality === 'stable' ? `http://aka.ms/vscode-install` : `http://aka.ms/vscode-install-insiders` )); </del> <ins> invokeProtocolHandler(); } else if (showResult.choice === 2 && downloadUrl !== undefined) { await this.openerService.open(URI.parse(downloadUrl)); </ins> // Re-show the dialog so that the user can come back after installing and try again showProtocolUrlOpenedDialog();