Change:
Investigate removing Max results limitation for Search and replace results Currently we set max limit to . We need to investigate on lifting this.
Assigning this to you. I see that you are working on improving the performance for Search results. Currently we have an hard limitation of 2048. But we never measure what is the threshold. Since you are already exercising Search performance this would be a good one to look at. Thanks
I noticed . An improvement may be to not open all files in which terms were found and replaced. As a software engineer myself I sometimes have to make many changes (just today some 33k machine names in 280 XML files). Version 1.3.1 crashed on me, but even if it had worked, I would have stared at many open files. And there's no shortcut to "save all" and "close all" :( I had to revert to Notepad++, which simply makes the changes in-place on disk, without opening all files. Maybe doing something similar is an option?
This would be nice to fix/improve. I have to open Atom just to do find/replace.
There should at least be a warning telling the user that not all the occurrences have been replaced. It is very misleading when "Replace All" only replaces the first items.
Please increase this number or make it configurable
Same here. I'd like you to make the number configurable. I'd like to set this to "No Limit" also, hopefully.
The current upper bound for search in VSCode is occurrences. Is there a way to change it?
Please make this maximum / upper boundary configurable.
I wonder what is measuring? ! Also, when I set it to 2000, I see 4000 results show up when I search a single letter.
You will also get results in open files beyond the limit
This is a bit of a foot gun... Using some ridicules high value freeses VS Code eventually. Will create a separate issue for that

Discussion:
description: nls.localize('search.location', "Controls whether the search will be shown as a view in the sidebar or as a panel in the panel area for more horizontal space."), deprecationMessage: nls.localize('search.location.deprecationMessage', "This setting is deprecated. You can drag the search icon to a new location instead.") }, <ins> 'search.maxResults': { type: ['number', 'null'], default: 20000, markdownDescription: nls.localize('search.maxResults', "Controls the maximum number of search results, this can be set to `null` (empty) to return unlimited results.") }, </ins> 'search.collapseResults': { type: 'string', enum: ['auto', 'alwaysCollapse', 'alwaysExpand'],

import { Disposable, DisposableStore, dispose } from 'vs/base/common/lifecycle'; import * as env from 'vs/base/common/platform'; import * as strings from 'vs/base/common/strings'; <ins> import { withNullAsUndefined } from 'vs/base/common/types'; </ins> import { URI } from 'vs/base/common/uri'; import 'vs/css!./media/searchview'; import { getCodeEditor, ICodeEditor, isCodeEditor, isDiffEditor } from 'vs/editor/browser/editorBrowser';

const SEARCH_CANCELLED_MESSAGE = nls.localize('searchCanceled', "Search was canceled before any results could be found - "); export class SearchView extends ViewPane { <del> private static readonly MAX_TEXT_RESULTS = 10000; </del> private static readonly ACTIONS_RIGHT_CLASS_NAME = 'actions-right'; private isDisposed = false;

const options: ITextQueryBuilderOptions = { _reason: 'searchView', extraFileResources: this.instantiationService.invokeFunction(getOutOfWorkspaceEditorResources), <del> maxResults: SearchView.MAX_TEXT_RESULTS, </del> <ins> maxResults: withNullAsUndefined(this.searchConfig.maxResults), </ins> disregardIgnoreFiles: !useExcludesAndIgnoreFiles || undefined, disregardExcludeSettings: !useExcludesAndIgnoreFiles || undefined, onlyOpenEditors: onlySearchInOpenEditors,

usePCRE2: boolean; actionsPosition: 'auto' | 'right'; maintainFileSearchCache: boolean; <ins> maxResults: number | null; </ins> collapseResults: 'auto' | 'alwaysCollapse' | 'alwaysExpand'; searchOnType: boolean; seedOnFocus: boolean;