jiebi/CodeConvo huggingface dataset:
Change:
Just to confirm that if you are aware that this change will not show the keybinding for Search view anymore at following places: <img width="367" alt="image" src="https://user-"<img width="161" alt="image" src="https://user-"Not sure if it is intended. Originally posted by in

Discussion:
import { CommandsRegistry, ICommandHandler, ICommandService } from 'vs/platform/commands/common/commands'; import { ConfigurationTarget, IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { ConfigurationScope, Extensions as ConfigurationExtensions, IConfigurationRegistry } from 'vs/platform/configuration/common/configurationRegistry'; <del> import { ContextKeyEqualsExpr, ContextKeyExpr, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; </del> <ins> import { ContextKeyAndExpr, ContextKeyEqualsExpr, ContextKeyExpr, IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; </ins> import { IFileService } from 'vs/platform/files/common/files'; import { SyncDescriptor } from 'vs/platform/instantiation/common/descriptors'; import { registerSingleton } from 'vs/platform/instantiation/common/extensions';

// Actions const registry = Registry.as<IWorkbenchActionRegistry>(ActionExtensions.WorkbenchActions); <del> // Show Search and Find in Files are redundant, but we can't break keybindings by removing one. So it's the same action, same keybinding, registered to different IDs. // Show Search 'when' is redundant but if the two conflict with exactly the same keybinding and 'when' clause, then they can show up as "unbound" - #51780 registry.registerWorkbenchAction(SyncActionDescriptor.from(OpenSearchViewletAction), 'View: Show Search', CATEGORIES.View.value); </del> <ins> // View: Show Search is used for the keybindings in the View menu and the sidebar #115556, but it should only be enabbled when search.mode == view, or else it will steal priority over opening a search editor #115511 const SEARCH_MODE_CONFIG = 'search.mode'; registry.registerWorkbenchAction( SyncActionDescriptor.from( OpenSearchViewletAction, { primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.KEY_F }, ContextKeyAndExpr.create([Constants.SearchViewVisibleKey.toNegated(), ContextKeyEqualsExpr.create(`config.${SEARCH_MODE_CONFIG}`, 'view')])), 'View: Show Search', CATEGORIES.View.value); // Find in Files by default is the same as View: Show Search, but can be configured to open a search editor instead with the `search.mode` binding </ins> KeybindingsRegistry.registerCommandAndKeybindingRule({ description: { description: nls.localize('findInFiles.description', "Open the search viewlet"),

}, scope: ConfigurationScope.RESOURCE }, <del> 'search.mode': { </del> <ins> [SEARCH_MODE_CONFIG]: { </ins> type: 'string', enum: ['view', 'reuseEditor', 'newEditor'], default: 'view',
Change:
Open a remote window Make sure Settings Sync is not enabled Install any workspace extension (say Python Extension) Also gets installed locally

Discussion:
const isMachineScoped = await this.hasToFlagExtensionsMachineScoped([gallery]); installOptions = { isMachineScoped, isBuiltin: false }; } <del> if (!installOptions.isMachineScoped) { </del> <ins> if (!installOptions.isMachineScoped && this.isExtensionsSyncEnabled()) { </ins> if (this.extensionManagementServerService.localExtensionManagementServer && !servers.includes(this.extensionManagementServerService.localExtensionManagementServer)) { servers.push(this.extensionManagementServerService.localExtensionManagementServer); }

return this.extensionManagementServerService.localExtensionManagementServer; } <ins> private isExtensionsSyncEnabled(): boolean { return this.userDataAutoSyncEnablementService.isEnabled() && this.userDataSyncResourceEnablementService.isResourceEnabled(SyncResource.Extensions); } </ins> private async hasToFlagExtensionsMachineScoped(extensions: IGalleryExtension[]): Promise<boolean> { <del> if (!this.userDataAutoSyncEnablementService.isEnabled() || !this.userDataSyncResourceEnablementService.isResourceEnabled(SyncResource.Extensions)) { return false; } const result = await this.dialogService.show( Severity.Info, extensions.length === 1 ? localize('install extension', "Install Extension") : localize('install extensions', "Install Extensions"), [ localize('install', "Install"), localize('install and do no sync', "Install (Do not sync)"), localize('cancel', "Cancel"), ], { cancelId: 2, detail: extensions.length === 1 ? localize('install single extension', "Would you like to install and synchronize '{0}' extension across your devices?", extensions[0].displayName) : localize('install multiple extensions', "Would you like to install and synchronize extensions across your devices?") </del> <ins> if (this.isExtensionsSyncEnabled()) { const result = await this.dialogService.show( Severity.Info, extensions.length === 1 ? localize('install extension', "Install Extension") : localize('install extensions', "Install Extensions"), [ localize('install', "Install"), localize('install and do no sync', "Install (Do not sync)"), localize('cancel', "Cancel"), ], { cancelId: 2, detail: extensions.length === 1 ? localize('install single extension', "Would you like to install and synchronize '{0}' extension across your devices?", extensions[0].displayName) : localize('install multiple extensions', "Would you like to install and synchronize extensions across your devices?") } ); switch (result.choice) { case 0: return false; case 1: return true; </ins> } <del> ); switch (result.choice) { case 0: return false; case 1: return true; </del> <ins> throw canceled(); </ins> } <del> throw canceled(); </del> <ins> return false; </ins> } getExtensionsReport(): Promise<IReportedExtension[]> {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: OS Version: Steps to Reproduce: Jupyter extension all cells Ctrl+Z in a cell icon in toolbar changes to No way to recover from this. Similar to However this reverts the Notebook Metadata (instead of cell metadata). <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.542 --- <!-- score: 0.483 --<!-- potentialduplicatescomment --
Validated, works now, closing this issue

Discussion:
} readonly label = 'Update Notebook Metadata'; undo() { <del> that._updateNotebookMetadata(oldMetadata, false); </del> <ins> that._updateNotebookMetadata({ ...oldMetadata, runState: that.metadata.runState }, false); </ins> } redo() { <del> that._updateNotebookMetadata(metadata, false); </del> <ins> that._updateNotebookMetadata({ ...metadata, runState: that.metadata.runState }, false); </ins> } }(), undefined, undefined); }
Change:
Issue Type: <bBug</bSince the latest update, I am seeing really weird Emmet suggestions in SASS files (not SCSS) with a higher priority than my SASS suggestions. For example I have got used to writing with . But now if I hit tab with it will give me rather than the expected like it used to. ! VS Code version: Code 1.53.0 (, 2021-02-03T16:01:04.046Z) OS version: Darwin x64 19.4.0 <details<summaryExtensions (15)</summaryExtensionVersion ------ vscode-css-formatter1.0.1 project-manager12.0.1 save-as-snippet0.0.1 vscode-icontheme-nomo-dark1.3.6 glsl-canvas0.2.11 vs-code-xml-format0.1.5 discord-vscode4.1.0 vscode-peacock3.9.1 vsliveshare1.0.3629 vsliveshare-audio0.1.91 vsliveshare-pack0.4.0 vscode-extension-auto-import1.4.3 shader1.1.4 sass-indented1.8.15 better-align1.1.6 </details<!-- generated by issue reporter --
The current Emmet snippet for background-color is . definitely shouldn't be suggested, though. I also confirmed that I'm only able to reproduce the issue with SASS files. Also, I just realized the other suggestions that show up aren't part of Emmet. However, I don't see the other suggestions (such as background-color) when I try typing in into a SASS file, even though I do see them on CSS and SCSS files. Wondering if I have a setting misconfigured.
Verifier: First, install the extension for SASS support. Then, set up a .sass document with the following content: Within the braces, type . Confirm that there is no suggestion of the form Edit: just realized SASS documents don't need braces. Least it helped with verification.

Discussion:
"@emmetio/html-matcher": "^0.3.3", "@emmetio/math-expression": "^1.0.4", "image-size": "^0.5.2", <del> "vscode-emmet-helper": "2.2.4-2", </del> <ins> "vscode-emmet-helper": "2.2.4", </ins> "vscode-languageserver-textdocument": "^1.0.1" } }

resolved "https://registry.yarnpkg.com/jsonc-parser/-/jsonc-parser-2.3.1.tgz#59549150b133f2efacca48fe9ce1ec0659af2342" integrity sha512-H8jvkz1O50L3dMZCsLqiuB2tA7muqbSg1AtGEkN0leAqGjsUzDJir3Zwr02BhqdcITPg3ei3mZ+HjMocAknhhg== <del> vscode-emmet-helper@2.2.4-2: version "2.2.4-2" resolved "https://registry.yarnpkg.com/vscode-emmet-helper/-/vscode-emmet-helper-2.2.4-2.tgz#8019188077a91dbe9a8d8c10c0b79369bb5c24d6" integrity sha512-7UTZXwt9M1xwaV72o2YgSBVoghtDtscTgYTOl1kiPkXN9OKiM4N52hcHFA1LlRtdTvIQd4PEkgaz57F9ZT/4kg== </del> <ins> vscode-emmet-helper@2.2.4: version "2.2.4" resolved "https://registry.yarnpkg.com/vscode-emmet-helper/-/vscode-emmet-helper-2.2.4.tgz#8ab86d2b7fe9e6270b4c77c9fd8d1eb8f3f4c401" integrity sha512-1N6bMzP1ZzkDGzamvsKxQ/lOmBc4+OQdj0dA2C9A5PSeYV9gh5xbJ061sm+VyFHOGZE+VyUQq5m/WFmFsLbKnA== </ins> dependencies: emmet "https://github.com/rzhao271/emmet.git#1b2df677d8925ef5ea6da9df8845968403979a0a" jsonc-parser "^2.3.0"
Change:
Issue Type: <bBug Before the latest update, after typing in File Explorer, the tree will scroll to the first match, and up/down key will jump between matches. With the latest version, none of the above would happen. VS Code version: Code 1.53.0 (, 2021-02-03T20:36:38.611Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </detailsExtensions: none <!-- generated by issue reporter --
Are you sure that focus is on an item in the tree when you start typing?
The brown filter text box appears and displays what I'm typing the same way as before, so yes I am pretty sure the focus is correct. The only thing missing is the scrolling and the subsequent ability to navigate with arrow keys on the keyboard in the latest version.
To clarify, the "Filter on Type" is off, i.e. files items won't disappear while I type, merely highlighting the matching items and allowing me to jump between them using up/down keys. And that is what works previously but not so in the latest version.
/confirm Thanks for the additional information. One of the dev team now needs to investigate when the regression occurred.
This is a regression from where the wasn't updated. Created a PR fixing it
thanks a lot for fixing! Assigning this one to since his commit caused the regression it seems
your call whether this is severe enough to be a recovery candidate or not
I think it is fine not to do this as part of recovery, since I think most users are not aware of this feature (it is a bit hidden). Having a fix in insiders is great, so if somebody is reliying on this behavior he or she can switch to insiders. Thus assigning to February milestone.
just came in from another user affected by this regression. I think the fix should go into the upcoming recovery release.
thanks for letting us know. I try to be very strict when it comes to choosing what goes in the recovery release - I usually only pick regressions in highly used features, data loss or big ux glitches. Since this is none of those I still prefer to not ship it as part of the recovery.
I'd appreciate if it would be fixed asap since it's very annoying that it doesn't work :-) If you don't prioritize it very high, I understand that though ;-)

Discussion:
*/ export const Default: FuzzyScore = ([-100, 0]); <del> export function isDefault(score?: FuzzyScore): score is [-100, 0, 0] { return !score || (score[0] === -100 && score[1] === 0 && score[2] === 0); </del> <ins> export function isDefault(score?: FuzzyScore): score is [-100, 0] { return !score || (score.length === 2 && score[0] === -100 && score[1] === 0); </ins> } }
Change:
I was testing in VS Code and then realized it didn't expand. For example: abbreviation: expected: actual: This issue is likely due to us rejecting the abbreviation within our own repo, even though it's valid.
Hi, I'm inspecting the issue and having trouble finding out why character doesn't trigger emmet's completion provider. Do you have some idea? Potentially this issue comes from ?

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.53.0 (commit id: ) OS Version: Ubuntu 20.04.2 LTS (Kernel: Linux 5.4.0-65-generic) I stumbled upon this bug by accident when I had the contents of some large file in my clipboard and (not realizing I had these file contents in the clipboard) when I pasted it in the filename of the file explorer of VSCode, it became unresponsive to the point I had to force kill it. In my opinion it is not very critical, not many people with encounter this issue, it was just surprising that my vscode became unresponsive due to this. I tried to locate the source of the issue in the code, but I couldn't find it myself. Steps to Reproduce: a directory in VSCode such that you have some file existing in the Explorer some filename with many dots to the clipboard. I use for this the file and click rename , followed by to paste the string vscode is unresponsive for more than 30 seconds, after which I force kill it. I found out that when you would paste 100.000 characters without using dots (i.e. ), then VSCode responds very quickly and lets me know the filename is invalid. Since the maximum allowed length of a filename is 255 characters, I think it would suffice to limit the filename to 255 characters before any further parsing is done. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes /
I can reproduce. Looks like the -function is causing this. <img width="734" alt="Screenshot 2021-02-09 at 16 17 22" src="https://user-"
my "fill clipboard snippet" is this . Open dev-tools, paste and run, and within the 3sec focus the content window
Since it happens inside the method, like something that was around here:
I'll take a look at this
Still quite slow but not freezing anymore

Discussion:
// Name & Extension(s) if (name) { classes.push(`${name}-name-file-icon`); <del> const dotSegments = name.split('.'); for (let i = 1; i < dotSegments.length; i++) { classes.push(`${dotSegments.slice(i).join('.')}-ext-file-icon`); // add each combination of all found extensions if more than one </del> <ins> // Avoid doing an explosive combination of extensions for very long filenames // (most file systems do not allow files > 255 length) with lots of `.` characters // https://github.com/microsoft/vscode/issues/116199 if (name.length <= 255) { const dotSegments = name.split('.'); for (let i = 1; i < dotSegments.length; i++) { classes.push(`${dotSegments.slice(i).join('.')}-ext-file-icon`); // add each combination of all found extensions if more than one } </ins> } classes.push(`ext-file-icon`); // extra segment to increase file-ext score }
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --See for context the tsec-compile-check action currently has a many outputs, making it difficult to notice when new security-sensitive code is . by listing all of the current violations in the tsec exemption file we can ensure that the output of tsec-compile-check stays empty unless someone adds code with a new violation.
wow. chrismas-clean
Thanks for this. I believe it's again time to enable this in the CI pipelines and to bring back the tsserver integration. The only remaining worry is our aggressive TS adoption strategy which can often mean that tsec is facing TS features is doesn't understand yet.
tsec is part of our CI pipeline I also tried to configure the tsserver plugin but I couldn't get it to accept the exemptions list. I have tried with below snippet in
for visibility on the tssever plugin issue
There is a bug in the plugin. Fix is on the way.
The bug in the plugin should have been fixed in 0.1.4.
Thanks. Adopted and enabled

Discussion:
"source-map-support": "^0.3.2", "style-loader": "^1.0.0", "ts-loader": "^6.2.1", <del> "tsec": "0.1.1", </del> <ins> "tsec": "0.1.3", </ins> "typescript": "4.2.0-dev.20201207", "typescript-formatter": "7.1.0", "underscore": "^1.8.2",

{ <ins> "ban-eval-calls": [ "vs/workbench/api/worker/extHostExtensionService.ts" ], "ban-function-calls": [ "vs/workbench/api/worker/extHostExtensionService.ts", "vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts", "vs/workbench/services/keybinding/test/electron-browser/keyboardMapperTestUtils.ts" ], </ins> "ban-trustedtypes-createpolicy": [ <del> "**/*.ts" </del> <ins> "vs/base/browser/dom.ts", "vs/base/browser/markdownRenderer.ts", "vs/base/worker/defaultWorkerFactory.ts", "vs/base/worker/workerMain.ts", "vs/editor/browser/core/markdownRenderer.ts", "vs/editor/browser/view/domLineBreaksComputer.ts", "vs/editor/browser/view/viewLayer.ts", "vs/editor/browser/widget/diffEditorWidget.ts", "vs/editor/browser/widget/diffReview.ts", "vs/editor/standalone/browser/colorizer.ts", "vs/workbench/api/worker/extHostExtensionService.ts", "vs/workbench/contrib/notebook/browser/view/renderers/cellRenderer.ts", "vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts", "vs/workbench/services/extensions/browser/webWorkerExtensionHost.ts", "vs/workbench/services/extensions/worker/extensionHostWorkerMain.ts" ], "ban-worker-calls": [ "vs/base/worker/defaultWorkerFactory.ts", "vs/workbench/services/extensions/browser/webWorkerExtensionHost.ts" </ins> ] }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: OS Version: macOS Big Sur (Version ) Steps to Reproduce: an extension from the Extensions view. For example, this is what the extension README looks like: <img width="1277" alt="Debugger for Chrome README" src="https://user-"The README for this extension specifies for the image and the heading, however, that is not reflected when displaying the README in the Extensions panel. Does this issue occur when all extensions are disabled?: Yes
Fixed by
closedWith
/verified
The issue has been fixed, but there's another issue related to extension READMEs not correctly displaying HTML content. When an img tag specifies the attribute, it seems like that attribute is ignored and the true width of the image is used. Here's an example: <img width="1193" alt="Screen Shot 2021-02-27 at 2 07 49 PM" src="https://user-"The attribute of the image is 200, however the real width of the image is larger, and it seems that the real width is used rather than the attribute. Any help on this issue would be great!
We'll consider allowing specific attributes on a case-by–case basis. If you want to see width and heigh also supported (and they already work in the marketplace) please open a new issue
New issue opened:

Discussion:
function removeEmbeddedSVGs(documentContent: string): string { return insane(documentContent, { <ins> allowedTags: [ 'h1', 'h2', 'h3', 'h4', 'h5', 'h6', 'h7', 'h8', 'br', 'b', 'i', 'strong', 'em', 'a', 'pre', 'code', 'img', 'tt', 'div', 'ins', 'del', 'sup', 'sub', 'p', 'ol', 'ul', 'table', 'thead', 'tbody', 'tfoot', 'blockquote', 'dl', 'dt', 'dd', 'kbd', 'q', 'samp', 'var', 'hr', 'ruby', 'rt', 'rp', 'li', 'tr', 'td', 'th', 's', 'strike', 'summary', 'details', 'caption', 'figure', 'figcaption', 'abbr', 'bdo', 'cite', 'dfn', 'mark', 'small', 'span', 'time', 'wbr' ], allowedAttributes: { '*': [ 'align', ] }, </ins> filter(token: { tag: string, attrs: { readonly [key: string]: string } }): boolean { return token.tag !== 'svg'; }
Change:
Run "Remote-SSH: Connect to Host" An empty remote window opens The terminal is shown (We force this for empty remote windows) After a second, the panel is closed Setting a bp shows that this happens because the terminal process died
Any OS info? Curious why this is forced?
Just Ubuntu. I think we did that to help avoid people being confused in an empty remote window. It just shows them what they are connected to.
Enabling trace logs should show how the terminal was created, maybe an invalid launch config is passed in initially before the connectionis ready?

Discussion:
); // Apply extension environment variable collections to the environment <del> if (!shellLaunchConfig.strictEnv) { </del> <ins> if (!shellLaunchConfig.strictEnv && !shellLaunchConfig.hideFromUser) { </ins> const mergedCollection = new MergedEnvironmentVariableCollection(this._environmentVariableCollections); mergedCollection.applyToProcessEnvironment(env, variableResolver); }

const variableResolver = terminalEnvironment.createVariableResolver(lastActiveWorkspace, this._configurationResolverService); const env = terminalEnvironment.createTerminalEnvironment(shellLaunchConfig, envFromConfigValue, variableResolver, isWorkspaceShellAllowed, this._productService.version, this._configHelper.config.detectLocale, baseEnv); <del> if (!shellLaunchConfig.strictEnv) { </del> <ins> if (!shellLaunchConfig.strictEnv && !shellLaunchConfig.hideFromUser) { </ins> this._extEnvironmentVariableCollection = this._environmentVariableService.mergedCollection; this._register(this._environmentVariableService.onDidChangeCollections(newCollection => this._onEnvironmentVariableCollectionChange(newCollection))); // For remote terminals, this is a copy of the mergedEnvironmentCollection created on
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I program in Windows Subsystem for Linux (WSL) but sometimes also in Windows 10 directly, I want to add custom snippets to emmet but the emmet.extensionPath variable only allows 1 path, It would be nice to add a secondary path if the first one is not found, so I can use the snippets in both systems, WSL and Windows 10 directly

Discussion:
"emmet.extensionsPath": { "type": [ "string", <ins> "array", </ins> "null" ], "default": null,