Change:
CC In , you type something in the input field and hit enter. When search result pops up, you need to press tab key tediously mutiple times to land in the search result treeview. It would be better if the search result tabindex could be adjusted so that users can quickly jump into the treeview after providing the search term (e.g., pressing from the search input field goes to the result treeview). Another way is pressing key in the search input field moves user focus to the search result treeview directly. Version: 1.78.0-insider (system setup) Commit: Date: 2023-04-04T09:32:52.453Z Electron: 22.4.3 Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0. Sandboxed: Yes
The latter option is preferred for a screen reader user's better navigability.
what do you think of this suggestion?
You can press ctrl+down/up to move between the input and the tree immediately, does that help? I don't quite understand the suggestion, that the tree come before the search input in the the tab order? And with pressing enter to move focus to the tree, I think that doing multiple searches while tweaking your search query is a common workflow, and this would interrupt that, but maybe something like that could be configurable.
If you want to jump directly to the results, you could add a keybinding like The command will focus the results view.
and -- Thanks for sharing great tips! I did not even know that I could use Ctrl+Down/Up Arrows. This is working very well. -- I think this is now a "discoverability" issue. I recommend adding an aria-label or other similar techniques to remind screen reader users of these Ctrl+Down/Up key commands.
I did not know that either, so agree that this is a discoverability problem. does it make sense to you to add this hint to the ?
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Yes, I could add it as an on the search text box. Is there an example elsewhere that I can follow in terms of adding a hint?
Here's what we do for the terminal's
I have found that Ctrl+UpArrow does not work when the keyboard focus is on the last item in the search result. Ctrl+Up only works in the first search result item.
The context key is why it only works for the first item: . Removing will do what you want
-- Shouldn't it be removed by default for other users? It does not make sense it only works in the first item if we want to generalize this behavior.
do you know why was applied here?
I'm guessing that it's because users wanted a keybinding that allowed them to move to the query fields when there were no more results to see. do you happen to know why it's like this and whether we can remove the check for ?
That keybinding also does other things- on mac. I didn't want to interfere with normal list keybindings. If this would be really useful, we could add a new keybinding which doesn't have that context key? Or users can customize it that way for themselves too?
On mac when the search results are focused, does not do anything.
It works for me
Ah yeah I see it working now. hb as it seems like it is more important to be able to get back to the search box in this case than to scroll one line up?
I think I'd rather leave the typical list navigation commands alone, but if it's just behind tbh I'll defer to you. But I also remember that the ctrl+shift+F shortcut should just focus the search input too, if that helps.
Since is a pattern we use elsewhere and screen reader users already have a high cognitive load placed upon them, I think we should follow suit here behind that flag.
To verify: With , search for something, navigate in the search results, and use to return to the search input fields

Discussion:
import { KeyCode, KeyMod } from 'vs/base/common/keyCodes'; import { ToggleCaseSensitiveKeybinding, TogglePreserveCaseKeybinding, ToggleRegexKeybinding, ToggleWholeWordKeybinding } from 'vs/editor/contrib/find/browser/findModel'; import { category, getSearchView, openSearchView } from 'vs/workbench/contrib/search/browser/searchActionsBase'; <ins> import { CONTEXT_ACCESSIBILITY_MODE_ENABLED } from 'vs/platform/accessibility/common/accessibility'; </ins> //#region Actions: Changing Search Input Options registerAction2(class ToggleQueryDetailsAction extends Action2 {

category, keybinding: { weight: KeybindingWeight.WorkbenchContrib, <del> when: ContextKeyExpr.and(Constants.SearchViewVisibleKey, Constants.FirstMatchFocusKey), </del> <ins> when: ContextKeyExpr.and(Constants.SearchViewVisibleKey, ContextKeyExpr.or(Constants.FirstMatchFocusKey, CONTEXT_ACCESSIBILITY_MODE_ENABLED)), </ins> primary: KeyMod.CtrlCmd | KeyCode.UpArrow, }, });