jiebi/CodeConvo huggingface dataset:
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: OS Version: Version: 1.50.0 Commit: Date: 2020-10-07T06:10:52.432Z Electron: 9.2.1 Chrome: 83.0.4103.122 12.14.1 V8: 8.3.110.13-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: use C++ extension and configured to use task to get my source code compiled. The part of the relatives to this issue is basically like this: now synthesizes this command as , rather than previously in VSCode version 1.49.3, . compiler will get for trying to write to root folder, of course. Should still be under such cases or not? Currently I reverted to 1.49.3.
To verify: Open a folder with some files in VS Code Add the following task:Open a file in from your folder that is at the top level of your folder, not in a subfolder Run the task Verify that the task outputs and not

Discussion:
} const dirname = paths.dirname(getFilePath()); if (folderUri || argument) { <del> return paths.relative(this.fsPath(getFolderUri()), dirname); </del> <ins> const relative = paths.relative(this.fsPath(getFolderUri()), dirname); return relative.length === 0 ? '.' : relative; </ins> } return dirname;
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.48.2 to latest insiders OS Version: linux kernel 4.18 Steps to Reproduce: an extension, create a webview which uses FileSaver js library , to save something in a file from a "save" button within the webview sure you load the webview with the extension. In VSCode before 1.48, there was no problem The extension where I discovered the problem is , in the WarpScript . <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No It seems Chrome engine another layer to sandbox default security in the meantime, now allow-downloads is necessary within the iframe sandbox settings. PR coming soon.
PS: Reverting VSCode back to 1.47 make the same extension working great. That's what I did during a few weeks before digging into the problem.

Discussion:
const newFrame = document.createElement('iframe'); newFrame.setAttribute('id', 'pending-frame'); newFrame.setAttribute('frameborder', '0'); <del> newFrame.setAttribute('sandbox', options.allowScripts ? 'allow-scripts allow-forms allow-same-origin allow-pointer-lock' : 'allow-same-origin allow-pointer-lock'); </del> <ins> newFrame.setAttribute('sandbox', options.allowScripts ? 'allow-scripts allow-forms allow-same-origin allow-pointer-lock allow-downloads' : 'allow-same-origin allow-pointer-lock'); </ins> if (host.fakeLoad) { // We should just be able to use srcdoc, but I wasn't // seeing the service worker applying properly.

// Wait the end of the ctor when all listeners have been hooked up. const element = document.createElement('iframe'); element.className = `webview ${options.customClasses || ''}`; <del> element.sandbox.add('allow-scripts', 'allow-same-origin', 'allow-forms', 'allow-pointer-lock'); </del> <ins> element.sandbox.add('allow-scripts', 'allow-same-origin', 'allow-forms', 'allow-pointer-lock', 'allow-downloads'); </ins> element.style.border = 'none'; element.style.width = '100%'; element.style.height = '100%';
Change:
No a "choose intentation type" entry in status bar when editing in a notebook. I have a notebook with tab indentation but it seems theres some global spaces setting that overrides it... even pasting a literal tab charachter inserts spaces :/ !
False alarm. The status bar entry just moved so much that I didn't see it right away, and it has a different name in the status bar entries context menu.
Actually, looks like the status bar is really slow to update. I saw it update eventually, but I'm not sure what caused it to finally show the correct thing. !

Discussion:
this._accessor.clear(); return; } <del> const indentSize = cellOptions?.indentSize; const tabSize = cellOptions?.tabSize; const insertSpaces = cellOptions?.insertSpaces; </del> <ins> const cellEditorOverridesRaw = editor.notebookOptions.getDisplayOptions().editorOptionsCustomizations; const indentSize = cellEditorOverridesRaw['editor.indentSize'] ?? cellOptions?.indentSize; const insertSpaces = cellEditorOverridesRaw['editor.insertSpaces'] ?? cellOptions?.tabSize; const tabSize = cellEditorOverridesRaw['editor.tabSize'] ?? cellOptions?.insertSpaces; </ins> const width = typeof indentSize === 'number' ? indentSize : tabSize;

constructor() { super({ <del> id: NotebookIndentUsingSpaces.ID, </del> <ins> id: NotebookIndentUsingTabs.ID, </ins> title: nls.localize('indentUsingTabs', "Indent Using Tabs"), precondition: undefined, });

constructor() { super({ <del> id: NotebookIndentUsingSpaces.ID, </del> <ins> id: NotebookChangeTabDisplaySize.ID, </ins> title: nls.localize('changeTabDisplaySize', "Change Tab Display Size"), precondition: undefined, });

constructor() { super({ <del> id: NotebookIndentUsingSpaces.ID, </del> <ins> id: NotebookIndentationToSpacesAction.ID, </ins> title: nls.localize('convertIndentationToSpaces', "Convert Indentation to Spaces"), precondition: undefined, });

override run(accessor: ServicesAccessor, ...args: any[]): void { convertNotebookIndentation(accessor, true); } }

constructor() { super({ <del> id: NotebookIndentUsingSpaces.ID, </del> <ins> id: NotebookIndentationToTabsAction.ID, </ins> title: nls.localize('convertIndentationToTabs', "Convert Indentation to Tabs"), precondition: undefined, });

bulkEditService.apply(edits, { label: nls.localize('convertIndentation', "Convert Indentation"), code: 'undoredo.convertIndentation', }); <del> })).then((notebookEdits) => { </del> <ins> })).then(() => { </ins> // store the initial values of the configuration const initialConfig = configurationService.getValue(NotebookSetting.cellEditorOptionsCustomizations) as any; const initialIndentSize = initialConfig['editor.indentSize'];

} registerAction2(NotebookIndentUsingSpaces); <ins> registerAction2(NotebookIndentUsingTabs); registerAction2(NotebookChangeTabDisplaySize); registerAction2(NotebookIndentationToSpacesAction); registerAction2(NotebookIndentationToTabsAction); </ins>
Change:
Issue Type: <bBug</b- Open a new file (!important) Set file type to Markdown Create a markdown link with a query string name-value pair containing an equals sign ("=") like Hover over the url (i.e. "") to engage the Follow Link tooltip Click "Follow link" link Observe that the browser address bar shows an encoded equals sign ("=") in the url (i.e. "") I cannot reproduce this issue with online monarch-editor () if that helps. VS Code version: Code 1.50.0 (, 2020-10-07T06:10:52.432Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (7)</summaryExtensionVersion ------ gitlens10.2.2 prettier-vscode5.7.1 vscode-docker1.6.0 remote-containers0.145.0 vscode-typescript-tslint-plugin1.2.3 debugger-for-chrome4.12.11 debugger-for-edge1.0.15 </details<!-- generated by issue reporter --
Hello, I would like to work on this bug. I have done a small amount of investigating so far, I am concluded that this only happens with the prompt and not when the command/control click shortcut is used. I also concluded that this only happens with markdown and not other extensions. This leaves me to believe that the issue lies within the "markdown-language-features" extension. I was hoping I might be able to get some guidance on how to find the code responsible for executing after the prompt is clicked on. I am thinking that I need to work on or but from the debugging I have conducted so far I cant get any breakpoints to break. Thank you!
I think this is a duplicate of
YouTube links in Markdown don't longer work because of this bug. YouTube will redirect you to their homepage because it can't find the video.
The reason for this problem is that if you pass in a URI link, it'll call the toString function to display it .And the toString function of the URI will by default encode. ! ! So is there a need for encode? If not, we can solve this problem by toString(true). !

Discussion:
nativeLabel = ` "${nativeLabelText}"`; } } <del> const hoverMessage = new MarkdownString('', true).appendMarkdown(`[${label}](${link.url.toString()}${nativeLabel}) (${kb})`); </del> <ins> const hoverMessage = new MarkdownString('', true).appendMarkdown(`[${label}](${link.url.toString(true)}${nativeLabel}) (${kb})`); </ins> return hoverMessage; } else { return new MarkdownString().appendText(`${label} (${kb})`);
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Some MacOS users have full-size keyboards with a forward delete key. Even Apple-provided keyboards have forward delete via the key. This key should delete files by default.
This is a fair feature request, however you can customise this. Let's leave this open for now and if more users request this we might change in the future.
This bug has been fixed in to the latest release of ! you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text to let us know. If not, please ensure you're on version of Insiders (today's or later - you can use in the command pallete to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

Discussion:
when: ContextKeyExpr.and(FilesExplorerFocusCondition, ExplorerResourceNotReadonlyContext, ExplorerResourceMoveableToTrash), primary: KeyCode.Delete, mac: { <del> primary: KeyMod.CtrlCmd | KeyCode.Backspace </del> <ins> primary: KeyMod.CtrlCmd | KeyCode.Backspace, secondary: [KeyCode.Delete] </ins> }, handler: moveFileToTrashHandler });
Change:
! Two problems: has no contrast and is being displayed over text mouse cursor over it should be Is this you?
We've always had this problem, the bottom part of the icon has no fill hence why the text shows through. The only alternative is to show this in the gutter when the first column of the row has text, but I'm not sure if that is technically possible.
Could we add a white trace outline to the icon, making it popup in messy locations?
Unfortunately strokes don't work on icons: ! We could try to add the same editor bg color with a slight opacity to account for this: !
Oh man, that looks good.

Discussion:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> .monaco-editor .lightbulb-glyph, .monaco-editor .codicon-lightbulb { </del> <ins> .monaco-editor .contentWidgets .codicon-light-bulb, .monaco-editor .contentWidgets .codicon-lightbulb-autofix { </ins> display: flex; align-items: center; justify-content: center; <del> height: 16px; width: 20px; padding-left: 2px; </del> } <del> .monaco-editor .lightbulb-glyph:hover, .monaco-editor .codicon-lightbulb:hover { </del> <ins> .monaco-editor .contentWidgets .codicon-light-bulb:hover, .monaco-editor .contentWidgets .codicon-lightbulb-autofix:hover { </ins> cursor: pointer; <del> /* transform: scale(1.3, 1.3); */ </del> }

import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding'; import { EditorOption } from 'vs/editor/common/config/editorOptions'; import { registerThemingParticipant, IColorTheme, ICssStyleCollector } from 'vs/platform/theme/common/themeService'; <del> import { editorLightBulbForeground, editorLightBulbAutoFixForeground } from 'vs/platform/theme/common/colorRegistry'; </del> <ins> import { editorLightBulbForeground, editorLightBulbAutoFixForeground, editorBackground } from 'vs/platform/theme/common/colorRegistry'; </ins> import { Gesture } from 'vs/base/browser/touch'; import type { CodeActionTrigger } from 'vs/editor/contrib/codeAction/types'; import { Codicon } from 'vs/base/common/codicons';

registerThemingParticipant((theme: IColorTheme, collector: ICssStyleCollector) => { <ins> const editorBackgroundColor = theme.getColor(editorBackground)?.transparent(0.7); </ins> // Lightbulb Icon const editorLightBulbForegroundColor = theme.getColor(editorLightBulbForeground); if (editorLightBulbForegroundColor) { collector.addRule(` .monaco-editor .contentWidgets ${Codicon.lightBulb.cssSelector} { color: ${editorLightBulbForegroundColor}; <ins> background-color: ${editorBackgroundColor}; </ins> }`); }

collector.addRule(` .monaco-editor .contentWidgets ${Codicon.lightbulbAutofix.cssSelector} { color: ${editorLightBulbAutoFixForegroundColor}; <ins> background-color: ${editorBackgroundColor}; </ins> }`); }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.50.1 OS Version: Windows_NT x64 10.0. Steps to Reproduce: . UI items are incorrect order when applying the language pack. UI items are sorted in ASC item name of after translation order. Case: <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (only Japanese Language Pack)
Changes button UI, too...
I believe this was a purposeful menu API decision.
Nope. See
Nope. See Thanks! I want to try doing fix this.
I know I can manually sort these, but there are two problems I see: 's an exhaustive process to sort and maintain proper sorting for each menu, as time goes by. would only fix one menu at the time. I can fix the git menus, but what about the others? While the user first submitted the issue about the Git menus, they then rewrote the issue to be about general UI menus. Notice the user is talking about menus in general, so this applies to the default sort. If we don't want to change the default sort order, we should just close this issue.
I get it, Thanks! If name of translation is changed, UI order would be unexpectedly changed. As far as I'm concerned, It would be better to change the default so that UI items are inserted in the order they exist in the object.
This bug has been fixed in to the latest release of ! you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text to let us know. If not, please ensure you're on version of Insiders (today's or later - you can use in the command pallete to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified It works! ! ! VS Code version: Code - Insiders 1.51.0-insider (, 2020-10-29T06:01:21.160Z) OS version: Windows_NT x64 10.0.

Discussion:
} private static _compareTitles(a: string | ILocalizedString, b: string | ILocalizedString) { <del> const aStr = typeof a === 'string' ? a : a.value; const bStr = typeof b === 'string' ? b : b.value; </del> <ins> const aStr = typeof a === 'string' ? a : a.original; const bStr = typeof b === 'string' ? b : b.original; </ins> return aStr.localeCompare(bStr); } }
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Vscode snippets support - e.g. variables related to filepaths, timestamps etc. Could you please add a new variable called something like that will auto-generate a version 4 UUID? (random) e.g. When executing the snippet, the placeholder would be replaced with a value like:
, that's a wrap! Now put it on the backlog, and in the software :D
could the generateUuid function be used with a snippet variable? I don't know how different the uuid and uuidv4 are, or if that matters here. I can submit a PR if that function works, or if you have any input on how to go about this.
Yeah, that function should be OK to be used
To verify make sure that you can have a snippet like this:

Discussion:
import { normalizeDriveLetter } from 'vs/base/common/labels'; import { URI } from 'vs/base/common/uri'; import { OvertypingCapturer } from 'vs/editor/contrib/suggest/suggestOvertypingCapturer'; <ins> import { generateUuid } from 'vs/base/common/uuid'; </ins> export const KnownSnippetVariableNames: { [key: string]: true } = Object.freeze({ 'CURRENT_YEAR': true,

'WORKSPACE_FOLDER': true, 'RANDOM': true, 'RANDOM_HEX': true, <ins> 'UUID': true </ins> }); export class CompositeSnippetVariableResolver implements VariableResolver {

if (name === 'RANDOM') { return Math.random().toString().slice(-6); <del> } else if (name === 'RANDOM_HEX') { </del> <ins> } else if (name === 'RANDOM_HEX') { </ins> return Math.random().toString(16).slice(-6); <ins> } else if (name === 'UUID') { return generateUuid(); </ins> } return undefined;
Change:
see gif have the debug hover above the cursor expand some objects the hover grows over the current line/cursor !
Yeah, this is a consequence of the change to not make it jump. Since in this scenario it does not have enough space above to grow, it can only grow over the line and below. Alternative would be to show it down, which would cause a jump. Or to limit the size, that it does not grow over the current line. That I think makes sense. However will not tackle during endgame.
How about not growing and use the scrollbar sooner? Just measure the max size above the cursor and don't go over that
I think this makes sense. My current max height is 70% of the editor height. Idealy as you suggest the max height should be the size above the cursor if I am placed above, or max size below the cursor if I am placed below. However I am not aware of editor API that gives me height above or below the cursor. Are you already using something like this for the suggest?
I am using and some math:

Discussion:
private layoutTree(): void { const scrollBarHeight = 10; <del> const treeHeight = Math.min(Math.max(266, this.editor.getLayoutInfo().height * 0.55), this.tree.contentHeight + scrollBarHeight); </del> <ins> let maxHeightToAvoidCursorOverlay = Infinity; if (this.showAtPosition) { const editorTop = this.editor.getDomNode()?.offsetTop || 0; const containerTop = this.treeContainer.offsetTop + editorTop; const hoveredCharTop = this.editor.getTopForLineNumber(this.showAtPosition.lineNumber, true) - this.editor.getScrollTop(); if (containerTop < hoveredCharTop) { maxHeightToAvoidCursorOverlay = hoveredCharTop + editorTop - 22; // 22 is monaco top padding https://github.com/microsoft/vscode/blob/a1df2d7319382d42f66ad7f411af01e4cc49c80a/src/vs/editor/browser/viewParts/contentWidgets/contentWidgets.ts#L364 } } const treeHeight = Math.min(Math.max(266, this.editor.getLayoutInfo().height * 0.55), this.tree.contentHeight + scrollBarHeight, maxHeightToAvoidCursorOverlay); </ins> const realTreeWidth = this.tree.contentWidth; const treeWidth = clamp(realTreeWidth, 400, 550);
Change:
Related to If you have a command in an action bar (say in ) that is a submenu with no items (or no visible items), there is no visible indication -- the icon is there, but does nothing if you click on it. I would expect similar behavior to

Discussion:
cursor: pointer; height: 100%; } <ins> .monaco-dropdown > .dropdown-label > .action-label.disabled { cursor: default; } </ins>

private menuActionsOrProvider: readonly IAction[] | IActionProvider; private dropdownMenu: DropdownMenu | undefined; private contextMenuProvider: IContextMenuProvider; <ins> private actionItem: HTMLElement | null = null; </ins> private _onDidChangeVisibility = this._register(new Emitter<boolean>()); readonly onDidChangeVisibility = this._onDidChangeVisibility.event;

} render(container: HTMLElement): void { <ins> this.actionItem = container; </ins> const labelRenderer: ILabelRenderer = (el: HTMLElement): IDisposable | null => { this.element = append(el, $('a.action-label'));

} }; } <ins> this.updateEnabled(); </ins> } setActionContext(newContext: unknown): void {

this.dropdownMenu.show(); } } <ins> protected updateEnabled(): void { const disabled = !this.getAction().enabled; this.actionItem?.classList.toggle('disabled', disabled); this.element?.classList.toggle('disabled', disabled); } </ins> } export interface IActionWithDropdownActionViewItemOptions extends IActionViewItemOptions {

})); } <ins> updateEnabled(): void { // override on submenu entry // native menus do not observe enablement on sumbenus // we mimic that behavior } </ins> open(selectFirst?: boolean): void { this.cleanupExistingSubmenu(false); this.createSubmenu(selectFirst);

} constructor(id: string, label: string, private _actions: IAction[], cssClass?: string) { <del> super(id, label, cssClass, true); </del> <ins> super(id, label, cssClass, !!_actions?.length); </ins> } }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: OS Version: Steps to Reproduce: vscode the welcome screen, focus on the checkbox at the bottom left of the page with the label "Show welcome page on startup" focus is not visible. You cannot see the focus: ! This is related to an accessibility issue filed on the azure data studio , issue <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes

Discussion:
opacity: 1 !important; } <ins> .monaco-workbench input[type="checkbox"]:focus { outline-offset: 2px; } </ins> .monaco-workbench [tabindex="0"]:active, .monaco-workbench [tabindex="-1"]:active, .monaco-workbench select:active,
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: stable and from sources Steps to Reproduce: terminal and run a program that prints a really long line. For example the mouse over the text in the terminal and start scrolling up and down :bug: observe the terminal lags while scrolling
I believe this is already fixed, can you see if you can reproduce in the ? !
it's an issue in the terminal not in the debug console
I see. Could you pls send a gif of this? I tried scrolling in the terminal and wasn't seeing any lag.
Sure, notice int the gif I'm scrolling up ! I created a PR with a fix you can check the root cause is while executing a regex in
I verified that your PR fixes this bug , but will await 's approval of the changes.
/duplicate

Discussion:
// Each line and column clause have 6 groups (ie no. of expressions in round brackets) export const lineAndColumnClauseGroupCount = 6; <ins> const MAX_LENGTH = 2000; </ins> export class TerminalValidatedLocalLinkProvider extends TerminalBaseLinkProvider { constructor( private readonly _xterm: Terminal,

} const text = getXtermLineContent(this._xterm.buffer.active, startLine, endLine, this._xterm.cols); <ins> if (text.length > MAX_LENGTH) { return []; } </ins> // clone regex to do a global search on text const rex = new RegExp(this._localLinkRegex, 'g');