jiebi/CodeConvo huggingface dataset:
Change:
This is a tiny suggestion but I run into it constantly. Often, I instinctively hit the up arrow to scroll through suggestions only for the little dialog/popup to disappear entirely rather than wrapping around to the other side of the list. For instance, if a function has 8+ overloads, I have to hit down arrow 7 times exactly. If I hit more than that, the whole thing closes and I have to start over. Talking about this popup specifically: Would be nice if it wrapped around, so I can access the last suggestion just by hitting up arrow, or don't accidentally lose my place by going too far.
Repro after pressing down a few times: !
TIL exists for this.
Huh. Why is it defaulted to off? That seems counter-intuitive, since it is by default cycle in VS.
I prefer true as well and just set it. thoughts on whether this should be off by default?
I think parameter hints is owned by
it actually moved to me when Pine left, I haven't done much on it though.
Aha! I wasn't sure anymore and just looked at who has the most items assigned with that label :). Yes, I think changing to be by default would be an improvement. Other places like suggestions (arrow down) or find matches (F3) cycle by default.
To verify: The default should be true Switch it and ensure both values work

Discussion:
constructor() { const defaults: InternalParameterHintOptions = { enabled: true, <del> cycle: false </del> <ins> cycle: true </ins> }; super( EditorOption.parameterHints, 'parameterHints', defaults,
Change:
re focus SCM input show context menu the is a entry "Command Palette..." which is awkward <img width="703" alt="image" src="https://user-"
Related to this, on my system that context menu also gives me entries that have been contributed by a couple of my extensions.
Same issue on macOS as well
This happens across all our inputs which use the Editor. IMO we should not include all those contributions and should just have , & in that menu. What's the simplest way towards this
The "Command Palette..." should potentially have a better context key for , not :
Thanks! But this is actually only half of the story. As mentions, extension contributed commands show up: ! Should we file issues to these extensions, suggesting to change their clauses?
It might be better/simpler to have another menu id, something like or even something SCM specific
To reproduce, you can use:

Discussion:
group: '', title: nls.localize('actions.clipboard.cutLabel', "Cut"), order: 1 <ins> }, { menuId: MenuId.SimpleEditorContext, group: CLIPBOARD_CONTEXT_MENU_GROUP, title: nls.localize('actions.clipboard.cutLabel', "Cut"), when: EditorContextKeys.writable, order: 1, </ins> }] })) : undefined;

group: '', title: nls.localize('actions.clipboard.copyLabel', "Copy"), order: 1 <ins> }, { menuId: MenuId.SimpleEditorContext, group: CLIPBOARD_CONTEXT_MENU_GROUP, title: nls.localize('actions.clipboard.copyLabel', "Copy"), order: 2, </ins> }] })) : undefined;

group: '', title: nls.localize('actions.clipboard.pasteLabel', "Paste"), order: 1 <ins> }, { menuId: MenuId.SimpleEditorContext, group: CLIPBOARD_CONTEXT_MENU_GROUP, title: nls.localize('actions.clipboard.pasteLabel', "Paste"), when: EditorContextKeys.writable, order: 4, </ins> }] })) : undefined;

} // Find actions available for menu <del> const menuActions = this._getMenuActions(this._editor.getModel(), MenuId.EditorContext); </del> <ins> const menuActions = this._getMenuActions(this._editor.getModel(), this._editor.isSimpleWidget ? MenuId.SimpleEditorContext : MenuId.EditorContext); </ins> // Show menu if we have actions to show if (menuActions.length > 0) {

static readonly DebugWatchContext = new MenuId('DebugWatchContext'); static readonly DebugToolBar = new MenuId('DebugToolBar'); static readonly EditorContext = new MenuId('EditorContext'); <ins> static readonly SimpleEditorContext = new MenuId('SimpleEditorContext'); </ins> static readonly EditorContextCopy = new MenuId('EditorContextCopy'); static readonly EditorContextPeek = new MenuId('EditorContextPeek'); static readonly EditorTitle = new MenuId('EditorTitle');
Change:
Refs: ! vs ! We probably need some generic way (via ?) to have the classes detect the editor that is opened. Currently that one is probably probing for file editor and untitled editor inputs.
What all should be present? Position makes sense, possibly tab size. I'm not sure if encoding or line ending make sense, and mode probably doesn't make sense (one wouldn't change the mode).
Yeah, likely only a subset - those that make sense.
Added the status bar entries, but no clean way to configure which entries show for a given editor. Currently the "Search Result" mode will show and be clickable, but choosing results doesn't actually do anything. (aborts out at ) put up to fix that.

Discussion:
} private updateStatusBar(): void { <ins> const activeInput = this.editorService.activeEditor; </ins> const activeControl = this.editorService.activeControl; const activeCodeEditor = activeControl ? withNullAsUndefined(getCodeEditor(activeControl.getControl())) : undefined; // Update all states this.onScreenReaderModeChange(activeCodeEditor); this.onSelectionChange(activeCodeEditor); <del> this.onModeChange(activeCodeEditor); </del> <ins> this.onModeChange(activeCodeEditor, activeInput); </ins> this.onEOLChange(activeCodeEditor); this.onEncodingChange(activeControl, activeCodeEditor); this.onIndentationChange(activeCodeEditor);

// Hook Listener for mode changes this.activeEditorListeners.add(activeCodeEditor.onDidChangeModelLanguage((event: IModelLanguageChangedEvent) => { <del> this.onModeChange(activeCodeEditor); </del> <ins> this.onModeChange(activeCodeEditor, activeInput); </ins> })); // Hook Listener for content changes

} } <del> private onModeChange(editorWidget: ICodeEditor | undefined): void { </del> <ins> private onModeChange(editorWidget: ICodeEditor | undefined, editorInput: IEditorInput | undefined): void { </ins> let info: StateDelta = { mode: undefined }; // We only support text based editors <del> if (editorWidget) { </del> <ins> if (editorWidget && editorInput && toEditorWithModeSupport(editorInput)) { </ins> const textModel = editorWidget.getModel(); if (textModel) { const modeId = textModel.getLanguageIdentifier().language;
Change:
mentions that it's deprecated, but it still shows up in intellisense: !

Discussion:
description: nls.localize('search.globalFindClipboard', "Controls whether the search view should read or modify the shared find clipboard on macOS."), included: platform.isMacintosh }, <del> 'search.location': { type: 'string', enum: ['sidebar', 'panel'], default: 'sidebar', description: nls.localize('search.location', "Controls whether the search will be shown as a view in the sidebar or as a panel in the panel area for more horizontal space."), }, </del> 'search.collapseResults': { type: 'string', enum: ['auto', 'alwaysCollapse', 'alwaysExpand'],
Change:
The configuration peekWidgetDefaultFocus has it's description mispelled on Settings screen. It shows openeing when the correct is opening. I'll make a pull request to fix this. Version: 1.42.0-insider Commit: Date: 2020-01-29T05:36:49.901Z Electron: 6.1.6 Chrome: 76.0.3809.146 12.4.0 V8: 7.6.303.31-electron.0 OS: Linux x64 5.3.0-29-generic Steps to Reproduce: settings for 'Peek Widget Default Focus'. ! Does this issue occur when all extensions are disabled?: Yes

Discussion:
['tree', 'editor'] as const, { enumDescriptions: [ <del> nls.localize('peekWidgetDefaultFocus.tree', "Focus the tree when openeing peek"), </del> <ins> nls.localize('peekWidgetDefaultFocus.tree', "Focus the tree when opening peek"), </ins> nls.localize('peekWidgetDefaultFocus.editor', "Focus the editor when opening peek") ], description: nls.localize('peekWidgetDefaultFocus', "Controls whether to focus the inline editor or the tree in the peek widget.")
Change:
Issue Type: <bFeature Request</bI never used the "Contributions" tab in extensions, thinking it was for recent github contributions to the extension. I accidentially pressed it once, and found it very useful. I think the name "Contributions" is confusing and that "Details", "Internals" , "Technical Details", or something similar would make it much clearer. VS Code version: Code 1.41.1 (, 2019-12-18T15:04:31.999Z) OS version: Linux x64 5.4.14-200.fc31.x86_64 <!-- generated by issue reporter --
These are in fact contributions to VS Code. How about ?
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!

Discussion:
const NavbarSection = { Readme: 'readme', <del> Contributions: 'contributions', </del> <ins> FeatureContributions: 'contributions', </ins> Changelog: 'changelog', Dependencies: 'dependencies', ExtensionPack: 'extensionPack'

template.navbar.push(NavbarSection.ExtensionPack, localize('extensionPack', "Extension Pack"), localize('extensionsPack', "Set of extensions that can be installed together")); } if (manifest && manifest.contributes) { <del> template.navbar.push(NavbarSection.Contributions, localize('contributions', "Contributions"), localize('contributionstooltip', "Lists contributions to VS Code by this extension")); </del> <ins> template.navbar.push(NavbarSection.FeatureContributions, localize('contributions', "Feature Contributions"), localize('contributionstooltip', "Lists contributions to VS Code by this extension")); </ins> } if (extension.hasChangelog()) { template.navbar.push(NavbarSection.Changelog, localize('changelog', "Changelog"), localize('changelogtooltip', "Extension update history, rendered from the extension's 'CHANGELOG.md' file"));

private open(id: string, extension: IExtension, template: IExtensionEditorTemplate): Promise<IActiveElement | null> { switch (id) { case NavbarSection.Readme: return this.openReadme(template); <del> case NavbarSection.Contributions: return this.openContributions(template); </del> <ins> case NavbarSection.FeatureContributions: return this.openContributions(template); </ins> case NavbarSection.Changelog: return this.openChangelog(template); case NavbarSection.Dependencies: return this.openDependencies(extension, template); case NavbarSection.ExtensionPack: return this.openExtensionPack(extension, template);
Change:
This was nicely uncovered by our internally implements a logic that throws an error in case multiple calls are made in parallel and a folder was created in the meantime. This is due to the fact that throws when a directory already exists. However, node's own implementation does not throw with the recurse option set to . We should align our implementation and not throw when a folder already exists.
Verification: run our smoke test and see how the hot-exit tests succeed.

Discussion:
// Create directories as needed for (let i = directoriesToCreate.length - 1; i >= 0; i--) { directory = joinPath(directory, directoriesToCreate[i]); <del> await provider.mkdir(directory); </del> <ins> try { await provider.mkdir(directory); } catch (error) { if (toFileSystemProviderErrorCode(error) !== FileSystemProviderErrorCode.FileExists) { // For mkdirp() we tolerate that the mkdir() call fails // in case the folder already exists. This follows node.js // own implementation of fs.mkdir({ recursive: true }) and // reduces the chances of race conditions leading to errors // if multiple calls try to create the same folders // As such, we only throw an error here if it is other than // the fact that the file already exists. // (see also https://github.com/microsoft/vscode/issues/89834) throw error; } } </ins> } }
Change:
! "strategy". No. Method. "Language specific". Missing hyphen. "indentation based". Missing hyphen. Also "if available" fails to say that if not, indentation method is used.
We're programmers, not spell checkers
Which is why you welcome reports such as this, right?

Discussion:
EditorOption.foldingStrategy, 'foldingStrategy', 'auto' as 'auto' | 'indentation', ['auto', 'indentation'] as const, <del> { markdownDescription: nls.localize('foldingStrategy', "Controls the strategy for computing folding ranges. `auto` uses a language specific folding strategy, if available. `indentation` uses the indentation based folding strategy.") } </del> <ins> { enumDescriptions: [ nls.localize('foldingStrategy.auto', "Use a language-specific folding strategy if available, else the indentation-based one."), nls.localize('foldingStrategy.indentation', "Use the indentation-based folding strategy."), ], description: nls.localize('foldingStrategy', "Controls the strategy for computing folding ranges.") } </ins> )), foldingHighlight: register(new EditorBooleanOption( EditorOption.foldingHighlight, 'foldingHighlight', true,
Change:
VSCode Version: master OS Version: macOS Steps to Reproduce: a normal (non-inline-editor) webview which contains an element into the input to to undo, but it doesn't do anything with to redo. Does this issue occur when all extensions are disabled?: Yes, but you need an extension that provides a webview to repro.

Discussion:
]; this._hasCustomEditor.set(possibleEditors.length > 0); this._focusedCustomEditorIsEditable.set(activeControl?.input instanceof CustomFileEditorInput); <del> this._webviewHasOwnEditFunctions.set(true); </del> <ins> this._webviewHasOwnEditFunctions.set(possibleEditors.length > 0); </ins> } private handleMovedFileInOpenedFileEditors(oldResource: URI, newResource: URI): void {
Change:
Issue Type: <bBug</bGitHub Pull Request Extension and focus the viewlet out a pull request so that the "Changes in Pull Request" view shows up the view the window the "Changes in Pull Request" view, expand "Files" or "Commits" No children are shown under these nodes. From the extension side, I saw that "getChildren" was not being called at all on the tree. This seems to have started happening after I'm not sure if this is the fault of the tree itself - I haven't seen this with other trees. What specifically seems to impact whether "getChildren" is called is this: The view is made visible by the change to the a context key. When this is followed by an event, "getChildren" is called on the context key change, but not when "onDidChange" is fired and expanding/collapsing the nodes does nothing. If the "onDidChange" is removed from there, or put before the context key change, then "getChildren" gets called twice and there is no issue with expanding/collapsing the children. Since changing the context key causes the tree to re-render anyway, I can remove the "onDidChange" being fired there. But I'm worried there's still an underlying timing issue. VS Code version: Code - Insiders 1.42.0-insider (, 2020-02-03T13:59:34.701Z) OS version: Darwin x64 18.7.0 <!-- generated by issue reporter --
Accepted as candidate as it is a regression

Discussion:
result.message = true; } return result; <del> }, 200, true)(({ message, elements }) => { </del> <ins> }, 200)(({ message, elements }) => { </ins> if (elements.length) { this.refreshQueue = this.refreshQueue.then(() => { const _promiseCallback = promiseCallback;
Change:
Issue Type: <bBug</bclick folder some chars and drag to the left to release GIF ! VS Code version: Code 1.41.1 (, 2019-12-18T14:58:56.166Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (29)</summaryExtensionVersion ------ vscode-css-formatter1.0.1 markdown-preview-github-styles0.1.6 vscode-intelephense-client1.3.9 vscode-markdownlint0.34.0 vscode-html-css0.2.3 php-debug1.13.0 auto-js-vscodeext0.2.3 composer0.7.1 markdown-shortcuts0.12.0 hex-rgba-converter1.0.4 php-namespace-resolver1.1.8 code-beautifier2.3.3 vscode-language-pack-zh-hans1.41.2 remote-ssh0.48.0 remote-ssh-edit0.49.0 remote-ssh-explorer0.49.0 cpptools0.26.3 Go0.13.0 php-docblocker2.1.0 vetur0.23.0 vscode-php-getters-setters1.2.3 minapp-vscode2.2.2 java0.55.1 vscode-xml0.10.1 datetime1.0.5 code-settings-sync3.4.3 vscode-java-pack0.8.1 vscode-preview-server1.3.0 html-css-class-completion1.19.0 </details<!-- generated by issue reporter --
I can not reproduce this. Thanks for filling this issue. Can you reproduce using Visual Studio Code Insiders
reproduce too !
I can not reproduce this both on macOS and Windows and I am doing the same thing as you. Let's leave this open as see if more users hit this. If you are interested in providing a PR which fixes this, here's a code poitner
reproduced as well, make sure you release the drag on the arrow icon.
pushed a fix for this. Please try it out in VS Code insiders from Wednesday and let us know if you still see the issue. Thanks
Thanks, but have a new problem: Input is cleared !
Yeah I also saw that, it's caused because when "expanding" the row element the tree refreshes and the previous value in the input is lost. But I think that doesn't look as bad as the previous behavior where the children got duplicated

Discussion:
} export class ExplorerItem { <del> private _isDirectoryResolved: boolean; </del> <ins> protected _isDirectoryResolved: boolean; </ins> private _isDisposed: boolean; public isError = false;

export class NewExplorerItem extends ExplorerItem { constructor(fileService: IFileService, parent: ExplorerItem, isDirectory: boolean) { super(URI.file(''), fileService, parent, isDirectory); <ins> this._isDirectoryResolved = true; </ins> } }
Change:
Used the stable built on v1.42 for sanity test and I see following error ! I suspect this is because we removed the search location setting and trying to remove its value as migration
Instead of removing the setting, please deprecate it.
BTW I see this error in every window until I manually remove the setting.
To verify: to and manually set to . the window ensure that: no error notification appears search is in the panel upon reload the setting is removed from your

Discussion:
description: nls.localize('search.globalFindClipboard', "Controls whether the search view should read or modify the shared find clipboard on macOS."), included: platform.isMacintosh }, <ins> 'search.location': { type: 'string', enum: ['sidebar', 'panel'], default: 'sidebar', description: nls.localize('search.location', "Controls whether the search will be shown as a view in the sidebar or as a panel in the panel area for more horizontal space."), deprecationMessage: nls.localize('search.location.deprecationMessage', "This setting is deprecated. Please use the search view's context menu instead.") }, </ins> 'search.collapseResults': { type: 'string', enum: ['auto', 'alwaysCollapse', 'alwaysExpand'],
Change:
VSCode Version: 1.41.1 OS Version: Win10 1909 Steps to Reproduce: In an extension: .executeCommand('', 'telemetry'); settings open, but without a search filter <!-- Launch with to check. --No, as there is nothing to run that code
Why do you need this? You can use but I don't really want to provide a ton of commands to control all the different options in the settings UI.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
There is a difference between User settings or Workspace settings, there is different UI and comparable methods in the API to reach them. The openWorkspaceSettings has the same signature as openSettings, but they don’t behave the same way. That’s why I think this needs to be resolved to be consistent. Martin Martin Tirion Microsoft Tel +31 (6) 1250 6153 Blog
Same issue. I just want to open the workspace settings and filter by my extension name.
Same here!
+1
+1
This is exactly what I need to programmatically open the workspace settings for my extension, allowing users to easily make changes. For anyone who needs this feature, execute openSettings with your search, then execute openWorkspaceSettings. It will switch the current settings window over to workspace settings while keeping your search string. Example vscode.commands.executeCommand('', 'telemetry' ); vscode.commands.executeCommand(''); Although this works, I still believe these commands should be consistent. I believe my use case is exactly why we need this, a per project/workspace settings window for extensions at the click of a button rather than multiple quickPicks.
Tried solution by I have the exact same use case for this as a couple of people above, providing a shortcut to my settings from an extension. The solution above didn't work, but reordering the calls worked for me: vscode.commands.executeCommand(''); vscode.commands.executeCommand('', '[search term here]'); Works for now, but I have a feeling this will break on me in the future. Since the solution provided by already stopped working as of now (at least on my machine/env). So here's my motivated '+1' on this: I think there's a clear use case for this I also subscribe to the argument provided by -- that adding this would make the API more consistent, since then openSettings and openWorkspaceSettings would work the same way.
Thanks and for documenting this workaround I had this same need btw.

Discussion:
} }); } <del> run(accessor: ServicesAccessor, args?: IOpenSettingsActionOptions) { args = sanitizeOpenSettingsArgs(args); </del> <ins> run(accessor: ServicesAccessor, args?: string | IOpenSettingsActionOptions) { // Match the behaviour of workbench.action.openSettings args = typeof args === 'string' ? { query: args } : sanitizeOpenSettingsArgs(args); </ins> return accessor.get(IPreferencesService).openWorkspaceSettings(args); } });
Change:
Create the following keybinding and open intellisense in the command: Lots of wasted space and I can no longer tell which one is and which is : ! In stable: ! Version: 1.42.0-insider (user setup) Commit: Date: 2020-02-05T16:51:41.553Z Electron: 6.1.6 Chrome: 76.0.3809.146 12.4.0 V8: 7.6.303.31-electron.0 OS: Windows_NT x64 10.0.
Verifier: Verify that completing use most of the spaces, like in Stable. There's 18px to the right which is reserved for the scrollbar that we don't use. !

Discussion:
} .monaco-editor .suggest-widget .monaco-list .monaco-list-row > .contents > .main > .right { overflow: hidden; <del> margin-left: 16px; </del> flex-shrink: 0; max-width: 45%; }