jiebi/CodeConvo huggingface dataset:
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.79.2 OS Version: Darwin x64 22.5.0 Steps to Reproduce: a webserver at serving a single schema at containing (the precise contents don't really matter) a file , and paste in: the cursor between the quotes just after the trailing slash , and look at the webserver logs, observing no user agent was sent
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.80.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
I suggest to verify this in code:

Discussion:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { ExtensionContext, OutputChannel, window, workspace, l10n } from 'vscode'; </del> <ins> import { ExtensionContext, OutputChannel, window, workspace, l10n, env } from 'vscode'; </ins> import { startClient, LanguageClientConstructor, SchemaRequestService, languageServerDescription } from '../jsonClient'; import { ServerOptions, TransportKind, LanguageClientOptions, LanguageClient, BaseLanguageClient } from 'vscode-languageclient/node';

const isXHRResponse = (error: any): error is XHRResponse => typeof error?.status === 'number'; const request = async (uri: string, etag?: string): Promise<string> => { <del> const headers: Headers = { 'Accept-Encoding': 'gzip, deflate' }; </del> <ins> const headers: Headers = { 'Accept-Encoding': 'gzip, deflate', 'User-Agent': `${env.appName} (${env.appHost})` }; </ins> if (etag) { headers['If-None-Match'] = etag; }
Change:
Build: Changes: This seems to be temporary. Still it would be good if we can retry

Discussion:
env: GITHUB_TOKEN: "$(github-distro-mixin-password)" displayName: Download Electron and Playwright <ins> retryCountOnTaskFailure: 3 </ins> - ${{ if ne(parameters.VSCODE_QUALITY, 'oss') }}: - script: |

env: GITHUB_TOKEN: "$(github-distro-mixin-password)" displayName: Download Electron and Playwright <ins> retryCountOnTaskFailure: 3 </ins> - ${{ if eq(parameters.VSCODE_RUN_UNIT_TESTS, true) }}: - ${{ if eq(parameters.VSCODE_QUALITY, 'oss') }}:
Change:
Type: <bFeature Request</bNo Clone Git repository option available VS Code version: Code 1.80.1 (, 2023-07-12T17:22:07.651Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --
Have you followed the instructions at yet?
! The button for the same doesn't show up
At a Windows command prompt please run to confirm what version you installed.
[image: ] It is the latest version
What do you see after you choose the third option on Activity Bar (Source Control view) instead of Explorer view? See the screenshot at
The git extension does indeed contribute welcome views to the "Explorer" view and it uses the context key. The problem is that this particular context key is only set when the "Source Control" view is rendered. So if you switch to the "Source Control" view and then back to the "Explorer" view then the option to clone a repository will appear.

Discussion:
{ "view": "scm", "contents": "%view.workbench.scm.folder%", <del> "when": "config.git.enabled && !git.missing && git.state == initialized && workbenchState == folder && scmRepositoryCount == 0 && git.parentRepositoryCount == 0 && git.unsafeRepositoryCount == 0 && git.closedRepositoryCount == 0 && remoteName != 'codespaces'", </del> <ins> "when": "config.git.enabled && !git.missing && git.state == initialized && workbenchState == folder && scm.providerCount == 0 && git.parentRepositoryCount == 0 && git.unsafeRepositoryCount == 0 && git.closedRepositoryCount == 0 && remoteName != 'codespaces'", </ins> "group": "5_scm@1" }, { "view": "scm", "contents": "%view.workbench.scm.workspace%", <del> "when": "config.git.enabled && !git.missing && git.state == initialized && workbenchState == workspace && workspaceFolderCount != 0 && scmRepositoryCount == 0 && git.parentRepositoryCount == 0 && git.unsafeRepositoryCount == 0 && git.closedRepositoryCount == 0 && remoteName != 'codespaces'", </del> <ins> "when": "config.git.enabled && !git.missing && git.state == initialized && workbenchState == workspace && workspaceFolderCount != 0 && scm.providerCount == 0 && git.parentRepositoryCount == 0 && git.unsafeRepositoryCount == 0 && git.closedRepositoryCount == 0 && remoteName != 'codespaces'", </ins> "group": "5_scm@1" }, {

{ "view": "explorer", "contents": "%view.workbench.cloneRepository%", <del> "when": "config.git.enabled && git.state == initialized && scmRepositoryCount == 0", </del> <ins> "when": "config.git.enabled && git.state == initialized && scm.providerCount == 0", </ins> "group": "5_scm@1" }, { "view": "explorer", "contents": "%view.workbench.learnMore%", <del> "when": "config.git.enabled && git.state == initialized && scmRepositoryCount == 0", </del> <ins> "when": "config.git.enabled && git.state == initialized && scm.providerCount == 0", </ins> "group": "5_scm@10" } ]
Change:
Here's what I am seeing. It looks like the accessibility help always gets the content from the editor. Here's a gif: I might be doing something wrong ! Originally posted by in

Discussion:
return; } runAccessibilityHelpAction(accessor, codeEditor, 'panelChat'); <del> }, CONTEXT_IN_CHAT_INPUT)); </del> <ins> }, CONTEXT_IN_CHAT_SESSION)); </ins> } }
Change:
! Testing
I'll try to deal with this
I'm sorry, I would like to ask a simple question. If I want to use this accessibility mode, do I need a software like NVDA to make it work? Or if I only have VS Code, can I still trigger this functionality?
Hey you can enable this with the command - a status bar indicator will appear
I used to be able to trigger , but now when I trigger it, it will show up in the lower left corner, but it won't have any function, which is a bit strange, are and the same function, I didn't find
Yes that's what I had meant. Hm, maybe a recent regression? Last time I tried this, it worked for me. I'll investigate tomorrow
Also, re the question of do you need to use a screen reader, it depends on what you're trying to do/ test. With that mode on, certain audio cues will (should) be enabled by default for example.
I have used this function once before, and it is true that the audio will play after it is turned on, but this time there is no response, I will check again to see if it is a problem with my settings
you can test this - and it's working for me with: screen reader mode status bar item appears in the terminal hear sound screen reader mode status bar item disappears no sound
Thanks! This work for me
I started trying to solve the problem

Discussion:
} } <del> private count(): number { return this.panes.reduce((count, view) => (<ExtensionsListView>view).count() + count, 0); </del> <ins> private getFirstExpandedPane(): ExtensionsListView | undefined { for (const pane of this.panes) { if (pane.isExpanded() && pane instanceof ExtensionsListView) { return pane; } } return undefined; </ins> } private focusListView(): void { <del> if (this.count() > 0) { this.panes[0].focus(); </del> <ins> const pane = this.getFirstExpandedPane(); if (pane && pane.count() > 0) { pane.focus(); </ins> } }
Change:
Testing Not sure if the settings editor is intended to support this, but it seems very similar to the other places that do support it.
I'll try to fix that, if it should be supported

Discussion:
import { IWorkbenchAssignmentService } from 'vs/workbench/services/assignment/common/assignmentService'; import { IProductService } from 'vs/platform/product/common/productService'; import { IEnvironmentService } from 'vs/platform/environment/common/environment'; <ins> import { registerNavigableContainer } from 'vs/workbench/browser/actions/widgetNavigationCommands'; </ins> export const enum SettingsFocusContext { Search,

this.createBody(this.rootElement); this.addCtrlAInterceptor(this.rootElement); this.updateStyles(); <ins> this._register(registerNavigableContainer({ focusNotifiers: [this], focusNextWidget: () => { if (this.searchWidget.inputWidget.hasWidgetFocus()) { this.focusTOC(); } }, focusPreviousWidget: () => { if (!this.searchWidget.inputWidget.hasWidgetFocus()) { this.focusSearch(); } } })); </ins> } override async setInput(input: SettingsEditor2Input, options: ISettingsEditorOptions | undefined, context: IEditorOpenContext, token: CancellationToken): Promise<void> {
Change:
Testing Repro: screen reader mode Screen Reader Optimized status bar item escape Screen Reader Optimized status bar item, nothing happens Instead 4 should either show and focus the hidden notification or show a new one
I'll try to deal with this
Hi Tyriar, I would like to ask what you mean by "Press escape", does it mean clicking "No"? !
by escape I mean the (same as escape if you have the notification focused), so the notification is still there but just hidden in the notification center (via the little bell icon)
Oops, I can't reproduce it here TAT
I reproduced and tried to solve it

Discussion:
} private showScreenReaderNotification(): void { <del> if (!this.screenReaderNotification) { this.screenReaderNotification = this.notificationService.prompt( Severity.Info, localize('screenReaderDetectedExplanation.question', "Are you using a screen reader to operate VS Code?"), [{ label: localize('screenReaderDetectedExplanation.answerYes', "Yes"), run: () => { this.configurationService.updateValue('editor.accessibilitySupport', 'on', ConfigurationTarget.USER); } }, { label: localize('screenReaderDetectedExplanation.answerNo', "No"), run: () => { this.configurationService.updateValue('editor.accessibilitySupport', 'off', ConfigurationTarget.USER); } }], { sticky: true, priority: NotificationPriority.URGENT </del> <ins> this.screenReaderNotification = this.notificationService.prompt( Severity.Info, localize('screenReaderDetectedExplanation.question', "Are you using a screen reader to operate VS Code?"), [{ label: localize('screenReaderDetectedExplanation.answerYes', "Yes"), run: () => { this.configurationService.updateValue('editor.accessibilitySupport', 'on', ConfigurationTarget.USER); </ins> } <del> ); </del> <ins> }, { label: localize('screenReaderDetectedExplanation.answerNo', "No"), run: () => { this.configurationService.updateValue('editor.accessibilitySupport', 'off', ConfigurationTarget.USER); } }], { sticky: true, priority: NotificationPriority.URGENT } ); </ins> <del> Event.once(this.screenReaderNotification.onDidClose)(() => this.screenReaderNotification = null); } </del> <ins> Event.once(this.screenReaderNotification.onDidClose)(() => this.screenReaderNotification = null); </ins> } private updateScreenReaderModeElement(visible: boolean): void { if (visible) {
Change:
There is a z-index error: <img width="572" alt="Screenshot 2023-07-25 at 13 56 59" src=""

Discussion:
static readonly ID = 'editor.contrib.standaloneColorPickerWidget'; readonly allowEditorOverflow = true; <del> private body: HTMLElement = document.createElement('div'); </del> private readonly _position: Position | undefined = undefined; private readonly _standaloneColorPickerParticipant: StandaloneColorPickerParticipant; <ins> private _body: HTMLElement = document.createElement('div'); </ins> private _colorHover: StandaloneColorPickerHover | null = null; private _selectionSetInEditor: boolean = false;

endLineNumber: editorSelection.endLineNumber, endColumn: editorSelection.endColumn } : { startLineNumber: 0, endLineNumber: 0, endColumn: 0, startColumn: 0 }; <del> const focusTracker = this._register(dom.trackFocus(this.body)); </del> <ins> const focusTracker = this._register(dom.trackFocus(this._body)); </ins> this._register(focusTracker.onDidBlur(_ => { this.hide(); }));

this._render(result.value, result.foundInEditor); })); this._start(selection); <ins> this._body.style.zIndex = '50'; </ins> this._editor.addContentWidget(this); }

} public getDomNode(): HTMLElement { <del> return this.body; </del> <ins> return this._body; </ins> } public getPosition(): IContentWidgetPosition | null {

public focus(): void { this._standaloneColorPickerFocused.set(true); <del> this.body.focus(); </del> <ins> this._body.focus(); </ins> } private async _start(selection: IRange) {

if (colorPickerWidget === undefined) { return; } <del> this.body.classList.add('standalone-colorpicker-body'); this.body.style.maxHeight = Math.max(this._editor.getLayoutInfo().height / 4, 250) + 'px'; this.body.style.maxWidth = Math.max(this._editor.getLayoutInfo().width * 0.66, 500) + 'px'; this.body.tabIndex = 0; this.body.appendChild(fragment); </del> <ins> this._body.classList.add('standalone-colorpicker-body'); this._body.style.maxHeight = Math.max(this._editor.getLayoutInfo().height / 4, 250) + 'px'; this._body.style.maxWidth = Math.max(this._editor.getLayoutInfo().width * 0.66, 500) + 'px'; this._body.tabIndex = 0; this._body.appendChild(fragment); </ins> colorPickerWidget.layout(); const colorPickerBody = colorPickerWidget.body;
Change:
Type: <bBug</bExtension installed: Goal: Open all -Files with the default editor, except for which should be opened with . Configuration: The setting for is respected, the second one isn't. No matter how I change the config, it's always the same result. I can assign all markdown files to runme, or all to default. Specifying full filenames doesn't have any noticable effect. VS Code version: Code - Insiders 1.81.0-insider (, 2023-07-25T08:12:53.439Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 5.15.0-1041-azure <details<summarySystem Info</summary </details<!-- generated by issue reporter --
My guess is that we go through the list and pick the first that matches, not looking for more specific matches. Maybe the editor resolver should prefer a match that does not use wildcards over those with wildcards, assuming it is a more specific match.
Oh, I think some logic like that already exists?
I tested for that case by putting the full filename first in the list - no change. It doesn't even match if it's the only entry in that list.

Discussion:
getAssociationsForResource(resource: URI): EditorAssociations { const associations = this.getAllUserAssociations(); <del> const matchingAssociations = associations.filter(association => association.filenamePattern && globMatchesResource(association.filenamePattern, resource)); </del> <ins> let matchingAssociations = associations.filter(association => association.filenamePattern && globMatchesResource(association.filenamePattern, resource)); // Sort matching associations based on glob length as a longer glob will be more specific matchingAssociations = matchingAssociations.sort((a, b) => (b.filenamePattern?.length ?? 0) - (a.filenamePattern?.length ?? 0)); </ins> const allEditors: RegisteredEditors = this._registeredEditors; // Ensure that the settings are valid editors return matchingAssociations.filter(association => allEditors.find(c => c.editorInfo.id === association.viewType));
Change:
Testing any task in VS Code repo, e.g. npm: eslint Rerun Last Task from command palette :bug: get prompted to choose a task to run, I would expect that last task to be automatically selected
this was working in v1.77 - broken in v1.80 so a regression but not this iteration
interesting - this doesn't happen for certain tasks - like
does repro for
Ok so for background / watch tasks that are currently running, like , the command to use instead is . For tasks with start/stop executions, if a user invokes while that task is in progress, it currently shows a quickpick. We should instead do nothing. That command is meant to be used for tasks that have ceased execution.
fyi, I did repro this for specifically
Yes I could ultimately repro when that task was in progress

Discussion:
if (executeResult) { return this._handleExecuteResult(executeResult); } else { <del> this._doRunTaskCommand(); </del> return Promise.resolve(undefined); } });
Change:
Testing default build task in VS Code repo running (I also installed the Java extension pack like in ) window Ctrl+Shift+B a few times :bug: get two sets of default build tasks. They are both reconnected, if I edit a file and hit save, both sets of tasks display log updates !
Duplicate

Discussion:
if (this._terminalService.getReconnectedTerminals('Task')?.length) { this._attemptTaskReconnection(); } else { <del> this._register(this._terminalService.onDidChangeConnectionState(async () => { await this._terminalService.whenConnected; </del> <ins> this._terminalService.whenConnected.then(() => { </ins> if (this._terminalService.getReconnectedTerminals('Task')?.length) { this._attemptTaskReconnection(); <ins> } else { this._tasksReconnected = true; </ins> } <del> })); </del> <ins> }); </ins> } this._upgrade(); }

} private async _runTaskCommand(filter?: string | ITaskIdentifier): Promise<void> { <ins> if (!this._tasksReconnected) { return; } </ins> if (!filter) { return this._doRunTaskCommand(); }

} private _runBuildCommand(): void { <ins> if (!this._tasksReconnected) { return; } </ins> return this._runTaskGroupCommand(TaskGroup.Build, { fetching: nls.localize('TaskService.fetchingBuildTasks', 'Fetching build tasks...'), select: nls.localize('TaskService.pickBuildTask', 'Select the build task to run'),
Change:
Testing VS Code repo Test Task from command palette (I'm not sure what this command does) :bug: nothing happens
any errors in the output channel? does it always repro for you?
Always repros, no errors in tasks output channel even after enabling debug logging
What is that recording supposed to show? It has length 0 for me, I only see the default build tasks getting run?
That something happens for me when I call as opposed to " nothing happens" I see why the default build task is running for me - pretty sure that's not what's supposed to happen here and likely a recent regression.
Expectation to verify: the vscode test script gets run when that command is invoked

Discussion:
} if (!globTasksDetected && groupTasks.length === 0) { <del> groupTasks = await this._findWorkspaceTasksInGroup(TaskGroup.Build, true); </del> <ins> groupTasks = await this._findWorkspaceTasksInGroup(taskGroup, true); </ins> } const handleMultipleTasks = (areGlobTasks: boolean) => {
Change:
Testing a file in a PR that has comments focus to the comment widget input :bug: can't ctrl+up/ctrl+down to move focus to the comments within that thread
Author of here. I would like to solve this.

Discussion:
this.commentEditor.focus(); } <ins> public expandReplyAreaAndFocusCommentEditor() { this.expandReplyArea(); this.commentEditor.focus(); } public isCommentEditorFocused(): boolean { return this.commentEditor.hasWidgetFocus(); } </ins> public getCommentModel() { return this.commentEditor.getModel()!; }

import { ICellRange } from 'vs/workbench/contrib/notebook/common/notebookRange'; import { FontInfo } from 'vs/editor/common/config/fontInfo'; import { IContextMenuService } from 'vs/platform/contextview/browser/contextView'; <ins> import { registerNavigableContainer } from 'vs/workbench/browser/actions/widgetNavigationCommands'; </ins> export const COMMENTEDITOR_DECORATION_KEY = 'commenteditordecoration';

const bodyElement = <HTMLDivElement>dom.$('.body'); container.appendChild(bodyElement); <ins> const tracker = this._register(dom.trackFocus(bodyElement)); this._register(registerNavigableContainer({ focusNotifiers: [tracker], focusNextWidget: () => { if (!this._commentReply?.isCommentEditorFocused()) { this._commentReply?.expandReplyAreaAndFocusCommentEditor(); } }, focusPreviousWidget: () => { if (this._commentReply?.isCommentEditorFocused() && this._commentThread.comments?.length) { this._body.focus(); } } })); </ins> this._body = this._scopedInstatiationService.createInstance( CommentThreadBody, this._owner,
Change:
Testing Type a request, press enter Nothing from the response is ever read I think it's supposed to do this?
Are you in screen reader optimized mode?
also any errors in dev tools console?
I can reproduce now not sure what changed
here's the problem
cc and this is the error you were encountering. should be fixed in insider's tomorrow
regression caused by the fix for

Discussion:
const isPanelChat = typeof response !== 'string'; this._responsePendingAudioCue?.dispose(); this._runOnceScheduler?.cancel(); <del> if (this._lastResponse === response?.toString()) { </del> <ins> const responseContent = typeof response === 'string' ? response : response?.response.value; if (this._lastResponse === responseContent) { </ins> return; } <del> this._lastResponse = response?.toString(); </del> this._audioCueService.playAudioCue(AudioCue.chatResponseReceived, true); this._hasReceivedRequest = false; if (!response) { return; } const errorDetails = isPanelChat && response.errorDetails ? ` ${response.errorDetails.message}` : ''; <del> const content = isPanelChat ? response.response.value : response; status(content + errorDetails); </del> <ins> this._lastResponse = responseContent; status(responseContent + errorDetails); </ins> } }
Change:
Tested on Windows 11. Yep, I also found it confusing as to when a sticky header would appear. Scrolling through in the testing repo, I had to scroll several times past before it would appear in the sticky scroll UI. I would have expected the header to be displayed right after it scrolled out the top of the view port. I also saw that headers higher in the hierarchy such as would disappear and reappear. Shouldn't the H2s remain as the H3s change? Originally posted by in
Somewhat related to visible range issues and multiple md cells with headers in a row.

Discussion:
} // if we are here, the cell is a code cell. <del> // check next cell, if markdown, that means this is the end of the section const nextCell = this.notebookEditor.cellAt(i + 1); if (nextCell) { if (nextCell.cellKind === CellKind.Markup) { </del> <ins> // check next visible cell, if markdown, that means this is the end of the section const nextVisibleCell = this.notebookEditor.cellAt(i + 1); if (nextVisibleCell && i + 1 < visibleRange.end) { if (nextVisibleCell.cellKind === CellKind.Markup) { </ins> // this is the end of the section // store the bottom scroll position of this cell sectionBottom = this.notebookCellList.getCellViewScrollBottom(cell);

// if we are here, the cell is a code cell. // check next cell, if markdown, that means this is the end of the section <del> const nextCell = this.notebookEditor.cellAt(i + 1); if (nextCell) { if (nextCell.cellKind === CellKind.Markup) { </del> <ins> const nextVisibleCell = this.notebookEditor.cellAt(i + 1); if (nextVisibleCell && i + 1 < visibleRange.end) { if (nextVisibleCell.cellKind === CellKind.Markup) { </ins> // this is the end of the section // store the bottom scroll position of this cell sectionBottom = this.notebookCellList.getCellViewScrollBottom(cell);

} private updateDisplay() { <del> const hasChildren = this.domNode.hasChildNodes(); if (!hasChildren) { </del> <ins> const hasSticky = this.currentStickyLines.size > 0; if (!hasSticky) { </ins> this.domNode.style.display = 'none'; } else { this.domNode.style.display = 'block';

const elementsToRender = []; while (currentEntry) { <ins> if (currentEntry.level === 7) { // level 7 represents a comment in python, which we don't want to render currentEntry = currentEntry.parent; continue; } </ins> const lineToRender = this.createStickyElement(currentEntry, partial); newMap.set(currentEntry, lineToRender); elementsToRender.unshift(lineToRender);