Change:
Start a long running search, notice the ugly stop icon I feel like somebody took the debug stop and stripped it of its color. Notice how it is too bright compared to the other icons. Also it feels a bit too large / too strong !
Should we use the exact same icon as the "Debug" stop icon maybe?
The Debug stop icon is red though, which aligns with the rest of the debug buttons that are multi-colored. Not sure if red would make sense here though: !
It goes with the redish clear. But still looks too strong and distracting for me. Why do we need a button for that in the end, why doesn't esc simply cancel the search?
I think ESC is not really discoverable and the button only shows up when search is taking a long time (as far as I remember). I don't mind the button there, but I am also not a big fan of the icon we have at the moment.
Typically you see an to cancel/stop progress, but we use that icon for closing items so it feels a bit out of place. Here's a few variations: ! I think an interesting idea is using the loading spinner and placing the stop icon on hover. Though we already have the viewlet progress indicator so it might be a duplication but the icon and interaction feels a little more natural: !
This is right, we used to get a lot of complaints about not being able to cancel a search.
I am not sure I would agree that X is used to stop a running operation, it feels to me the stop button makes more sense. I associate X more with closing something then stopping something.
here's a few examples where X is used to stop a running operation: <img width="50%" src="https://user-"<img width="50%" src="https://user-"<img width="30%" src="https://user-"If we want to keep using the "Stop" icon, we can either make the current one smaller and match the correct color or use an alternate stop icon: !
that icon might work in other apps, but in VSCode every usage of the "X" is for closing something, not stopping something.
agreed, I was just pointing out that other apps also use the X in other ways. What are your thoughts on either stop button?
how did the stop button change in the first screenshot?
It's subtle, I made it smaller by 2px, removed the white border, and used the same gray color as the other icons.
yeah let's try it out in insiders
Yeah without the border it at least looks better. We shuold try it out

Discussion:
<del> <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" enable-background="new 0 0 16 16" height="16" width="16"><path fill="#F6F6F6" d="M13 13h-10v-10h10v10z"/><path fill="#C5C5C5" d="M12 12h-8v-8h8v8z"/></svg> </del>  No newline at end of file <ins> <svg width="14" height="14" viewBox="0 0 14 14" fill="none" xmlns="http://www.w3.org/2000/svg"> <path d="M11 11H3V3H11V11Z" fill="#C5C5C5"/> </svg> </ins>  No newline at end of file

<del> <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" enable-background="new 0 0 16 16" height="16" width="16"><path fill="#F6F6F6" d="M13 13h-10v-10h10v10z"/><path fill="#424242" d="M12 12h-8v-8h8v8z"/></svg> </del>  No newline at end of file <ins> <svg width="14" height="14" viewBox="0 0 14 14" fill="none" xmlns="http://www.w3.org/2000/svg"> <path d="M11 11H3V3H11V11Z" fill="#424242"/> </svg> </ins>  No newline at end of file