jiebi/CodeConvo huggingface dataset:
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (N/A) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.88.1 OS Version: macOS Steps to Reproduce: the shell, run , UPDATE: the system need to have a existing tunnel already running that the machine name is always inferred from Hostname instead of the machine name set through <img width="931" alt="image" src=""
Update: I noticed the "Connected to an existing tunnel..." line, and if I kill the tunnel first using and run the same command, it would correctly set the machine name. I'll update the issue description to reflect that.
Yea, if there's an existing tunnel we just connect to it and never enter the process in which the name would be set. Renaming a running tunnel is also possible but could lead to unpredictable side effects. We should just log a warning in this case.
I'm not seeing any warning:
still no warning. I made sure I was on the latest !
in your screenshot you can see the warning which is what I for this.

Discussion:
match acquire_singleton(&paths.tunnel_lockfile()).await { Ok(SingletonConnection::Client(stream)) => { debug!(log, "starting as client to singleton"); <del> if gateway_args.name.is_none() </del> <ins> if gateway_args.name.is_some() </ins> || !gateway_args.install_extension.is_empty() || gateway_args.tunnel.tunnel_id.is_some() {
Change:
Originally posted by in Currently, and don't work for : ! Please add support.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
I think this feature request is pretty basic, from my past experience, issues moved to the backlog candidate most likely get closed, could you please consider moving it to the backlog?
Hello, and I would like to start working in this. If moved to the backlog, could this issue be assigned to us? Thank you!
I wonder if the example above falls into the category of this filter which we maintain already: The idea here being to not automatically add git related files to the history. Is your case any special in terms of git operations?
I use a lot, should also be filtered out from , since they are only temporary files: !
Yeah that sounds reasonable to me, feel free to add it as PR.
duplicate of ?
related:
this FR is for the "File" "Open Recent" "More..." picker. I actually think can be closed as fixed for March already, I commented.
See
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Is this released in 1.90.2? If it is, I think the PR didn't solve this issue.
Yes, this was part of the 1.90.x release.
Thanks, perhaps reopen this issue? I just tried, the issue still exists.
It works for me:
Can you please try , then the rest?
Same

Discussion:
// Exclude some very common files from the dock/taskbar private static readonly COMMON_FILES_FILTER = [ 'COMMIT_EDITMSG', <del> 'MERGE_MSG' </del> <ins> 'MERGE_MSG', 'git-rebase-todo' </ins> ]; private readonly macOSRecentDocumentsUpdater = this._register(new ThrottledDelayer<void>(800));
Change:
(originally reported in ) Extensions that are enabled both in the show the text . This text can be confusing. asked me to open an issue Te proposal is thus to remove the text. To be honest though, I am unsure what the text even means. Look at this image: ! That extension is clearly installed locally. But I do not find it installed in on the remote. It is not there in the remote part of the Extensions sidebar. VS Code version: Code 1.88.1 (, 2024-04-10T17:41:02.734Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 5.4.0-177-generic <details<summarySystem Info</summary </details<details<summaryExtensions (40)</summaryExtensionVersion ------ yang0.1.3 jupyter-keymap1.1.2 remote-containers0.354.0 remote-ssh0.110.1 remote-ssh-edit0.86.0 remote-wsl0.88.0 vscode-remote-extensionpack0.25.0 remote-explorer0.4.3 remote-server1.5.1 vscode-openapi4.25.3 lit-html1.11.1 markdown-preview-github-styles2.0.4 vscode-fish1.0.38 ruff2024.20.0 vale-vscode0.19.0 vscode-markdownlint0.55.0 vscode-eslint2.4.4 gitlens14.9.1 prettier-vscode10.4.0 code-runner0.12.2 go0.41.4 path-autocomplete1.25.0 restructuredtext190.3.0 vscode-azureresourcegroups0.8.6 vscode-cosmosdb0.21.0 vscode-docker1.29.0 vscode-kubernetes-tools1.3.16 debugpy2024.4.0 python2024.4.1 vscode-pylance2024.4.1 azure-account0.11.6 vscode-thunder-client2.21.15 vscode-yaml1.14.0 vscode-direnv0.0.2 code-spell-checker3.0.1 vscode-stylelint1.4.0 even-better-toml0.19.2 shellcheck0.37.1 simple-rst1.5.4 vscode-proto30.5.5 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --

Discussion:
} } if (this.extension.enablementState === EnablementState.EnabledGlobally) { <del> this.updateStatus({ message: new MarkdownString(localize('globally enabled', "This extension is enabled globally.")) }, true); </del> return; } }
Change:
The colors we define in code should match our default theme, otherwise there is potential for ugly flickering as seen below: ! Notice how the title bar color changes, the active tab indicator appears late. It feels sluggish and like a UI bug. At one point I think we made "Modern Dark" our default, we I think we did not make a pass over our colors to align them with the colors defined in the theme. We need to ensure that the colors in code match the colors in our default themes, I would argue even for light and HC theme.
I think this should be fixed in May, it looks really bad for first startups.
Is there a reason to do it this way? I think I would have assumed the default dark theme JSON file to be empty (because it does not overwrite any colors) and our colors in code to be matching the default dark theme colors?
We can not change the defaults as all custom themes inherit these. I agree that it's not so nice to duplicate the colors but I couldn't yet come up with a simple solution.
I understand the argument that we cannot easily change the default colors without breaking other themes. But the issue still reproduces even after your change: open a fresh Code-OSS and see how title bar color and tab active indicator only kick in late. Also adding since this covers UI components of his.

Discussion:
'activityBar.background': '#181818', 'statusBar.background': '#181818', 'statusBar.noFolderBackground': '#1f1f1f', <ins> 'titleBar.border': '#2B2B2B', 'titleBar.inactiveBackground': '#ff0000', 'titleBar.inactiveForeground': '#9D9D9D' </ins> }; export const COLOR_THEME_LIGHT_INITIAL_COLORS = { 'activityBar.background': '#f8f8f8', 'statusBar.background': '#f8f8f8', <del> 'statusBar.noFolderBackground': '#f8f8f8' </del> <ins> 'statusBar.noFolderBackground': '#f8f8f8', 'titleBar.border': '#E5E5E5', 'titleBar.inactiveBackground': '#F8F8F8', 'titleBar.inactiveForeground': '#8B949E', </ins> }; export interface IWorkbenchTheme {
Change:
Is this intentional? ! This makes the contribution quite slow on startup, and it feels off that it would save immediately. Would this be needed or could it run deferred?
Thanks!

Discussion:
// Process the notebook contributions but buffer changes from the resolver this._editorResolverService.bufferChangeEvents(() => { for (const info of (mementoObject[NotebookProviderInfoStore.CUSTOM_EDITORS_ENTRY_ID] || []) as NotebookEditorDescriptor[]) { <del> this.add(new NotebookProviderInfo(info)); </del> <ins> this.add(new NotebookProviderInfo(info), false); </ins> } });

return this._contributedEditors.get(viewType); } <del> add(info: NotebookProviderInfo): IDisposable { </del> <ins> add(info: NotebookProviderInfo, saveMemento = true): IDisposable { </ins> if (this._contributedEditors.has(info.id)) { throw new Error(`notebook type '${info.id}' ALREADY EXISTS`); }

this._contributedEditorDisposables.add(editorRegistration); } <del> const mementoObject = this._memento.getMemento(StorageScope.PROFILE, StorageTarget.MACHINE); mementoObject[NotebookProviderInfoStore.CUSTOM_EDITORS_ENTRY_ID] = Array.from(this._contributedEditors.values()); this._memento.saveMemento(); </del> <ins> if (saveMemento) { const mementoObject = this._memento.getMemento(StorageScope.PROFILE, StorageTarget.MACHINE); mementoObject[NotebookProviderInfoStore.CUSTOM_EDITORS_ENTRY_ID] = Array.from(this._contributedEditors.values()); this._memento.saveMemento(); } </ins> return this._register(toDisposable(() => { const mementoObject = this._memento.getMemento(StorageScope.PROFILE, StorageTarget.MACHINE);
Change:
Open notebook with a header, code cell, and symbols in the code cell: # 1: symbols appear as a child of the header md cell, and the code cell is not present in the outline. # 2: changing the filter settings to remove code cells or symbols does not recompute the outline. Fixes: For # 1: an outline provider was being created with the incorrect target (sticky scroll was created with a QuickPick target), and this was being retrieved for the outline pane incorrectly. For # 2: one of the locations an outline change event is fired was shifted and subsequently removed, meaning that the outline did not recompute to reflect the filtered-out cells.

Discussion:
export class NotebookOutlineEntryFactory { private cellOutlineEntryCache: Record<string, entryDesc[]> = {}; <del> private readonly cachedMarkdownOutlineEntries = new WeakMap<ICellViewModel, { alternativeId: number; headers: { depth: number, text: string }[] }>(); </del> <ins> private readonly cachedMarkdownOutlineEntries = new WeakMap<ICellViewModel, { alternativeId: number; headers: { depth: number; text: string }[] }>(); </ins> constructor( private readonly executionStateService: INotebookExecutionStateService ) { }

} })); <del> this._recomputeActive(); </del> <ins> const { changeEventTriggered } = this._recomputeActive(); if (!changeEventTriggered) { this._onDidChange.fire({}); } </ins> } private _recomputeActive(): { changeEventTriggered: boolean } {

export const INotebookCellOutlineProviderFactory = createDecorator<INotebookCellOutlineProviderFactory>('INotebookCellOutlineProviderFactory'); export interface INotebookCellOutlineProviderFactory { <del> getOrCreate(editor: INotebookEditor, target: OutlineTarget): IReference<NotebookCellOutlineProvider> </del> <ins> getOrCreate(editor: INotebookEditor, target: OutlineTarget): IReference<NotebookCellOutlineProvider>; </ins> } export class NotebookCellOutlineProviderFactory implements INotebookCellOutlineProviderFactory {

} private init() { <del> const { object: notebookOutlineReference } = this.notebookOutlineReference = this.instantiationService.invokeFunction((accessor) => accessor.get(INotebookCellOutlineProviderFactory).getOrCreate(this.notebookEditor, OutlineTarget.QuickPick)); </del> <ins> const { object: notebookOutlineReference } = this.notebookOutlineReference = this.instantiationService.invokeFunction((accessor) => accessor.get(INotebookCellOutlineProviderFactory).getOrCreate(this.notebookEditor, OutlineTarget.OutlinePane)); </ins> this._register(this.notebookOutlineReference); this.updateContent(computeContent(this.notebookEditor, this.notebookCellList, notebookOutlineReference.entries, this.getCurrentStickyHeight()));
Change:
Open notebook with a header, code cell, and symbols in the code cell: # 1: symbols appear as a child of the header md cell, and the code cell is not present in the outline. # 2: changing the filter settings to remove code cells or symbols does not recompute the outline. Fixes: For # 1: an outline provider was being created with the incorrect target (sticky scroll was created with a QuickPick target), and this was being retrieved for the outline pane incorrectly. For # 2: one of the locations an outline change event is fired was shifted and subsequently removed, meaning that the outline did not recompute to reflect the filtered-out cells.

Discussion:
const { hasFileIcons } = this._themeService.getFileIconTheme(); const showSymbols = this._configurationService.getValue<boolean>(NotebookSetting.gotoSymbolsAllSymbols); <ins> const isSymbol = (element: OutlineEntry) => !!element.symbolKind; const isCodeCell = (element: OutlineEntry) => (element.cell.cellKind === CellKind.Code && element.level === NotebookOutlineConstants.NonHeaderOutlineLevel); // code cell entries are exactly level 7 by this constant </ins> for (let i = 0; i < bucket.length; i++) { const element = bucket[i]; <del> const nextElement = bucket[i + 1]; // this logic controls the following for code cells entries in quick pick: if (element.cell.cellKind === CellKind.Code) { // if we are showing all symbols, and // 		- the next entry is a symbol, we DO NOT include the code cell entry (ie continue) //		- the next entry is not a symbol, we DO include the code cell entry (ie push as normal in the loop) if (showSymbols && element.level === NotebookOutlineConstants.NonHeaderOutlineLevel && (nextElement?.level > NotebookOutlineConstants.NonHeaderOutlineLevel)) { continue; } // if we are not showing all symbols, skip all entries with level > NonHeaderOutlineLevel (ie 8+) else if (!showSymbols && element.level > NotebookOutlineConstants.NonHeaderOutlineLevel) { continue; } </del> <ins> const nextElement = bucket[i + 1]; // can be undefined if (!showSymbols && isSymbol(element)) { continue; } if (showSymbols && isCodeCell(element) && nextElement && isSymbol(nextElement)) { continue; </ins> } const useFileIcon = hasFileIcons && !element.symbolKind;
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: ~1.88.1~ 1.89.0 OS Version: Windows_NT x64 10.0. I am trying to add a hotkey to open the source file and close all diffs when pressed in a diff. When running it, an error is thrown, and execution stops before reaching the second command: ! (from keybinding debugger): [error] Method not found: toJSON: CodeExpectedError: Method not found: toJSON at (..ProgramsMicrosoft VS Coderesourcesappoutvscodeelectron-main) I removed the second command, and found that openSide fails even if no other command exists, and succeeds if not run by runCommands: Works fine: Fails: Steps to Reproduce: this to Open a diff, run keybind, observe it does not work and throws error I am able to workaround this by using the extension.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.89.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Thank you bot, I have updated to 1.89, issue is still present
Thank you for the issue! This will be fixed in VSCode Insiders released on Monday and VSCode stable May release early June.

Discussion:
logService.debug(`runCommands: executing ${i}-th command: ${safeStringify(cmd)}`); <del> const r = await this._runCommand(commandService, cmd); </del> <ins> await this._runCommand(commandService, cmd); </ins> <del> logService.debug(`runCommands: executed ${i}-th command with return value: ${safeStringify(r)}`); </del> <ins> logService.debug(`runCommands: executed ${i}-th command`); </ins> } } catch (err) { logService.debug(`runCommands: executing ${i}-th command resulted in an error: ${err instanceof Error ? err.message : safeStringify(err)}`);
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.89.0 OS Version: Windows 10.0. Steps to Reproduce: Create a keybinding to with the argument set to . The search sidepanel appears but if the includes and excludes fields were shown from a prior search they are still visible. The same happens even though the includes and excludes are cleared:
Hmm, that isn't currently an option in . But it can be . You can see the existing fields here:
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
To verify, try binding a keyboard shortcut like this: And verify that setting to true and false correctly shows the and fields in the search view. !

Discussion:
matchWholeWord?: boolean; useExcludeSettingsAndIgnoreFiles?: boolean; onlyOpenEditors?: boolean; <ins> showIncludesExcludes?: boolean; </ins> } //#endregion

matchWholeWord: { 'type': 'boolean' }, useExcludeSettingsAndIgnoreFiles: { 'type': 'boolean' }, onlyOpenEditors: { 'type': 'boolean' }, <ins> showIncludesExcludes: { 'type': 'boolean' } </ins> } } },

updatedText = openedView.updateTextFromFindWidgetOrSelection({ allowUnselectedWord: typeof args.replace !== 'string' }); } openedView.setSearchParameters(args); <ins> if (typeof args.showIncludesExcludes === 'boolean') { openedView.toggleQueryDetails(false, args.showIncludesExcludes); } </ins> openedView.searchAndReplaceWidget.focus(undefined, updatedText, updatedText); }
Change:
creates a tree view opens the tree view disposes the tree view while it's still open creates the tree view again The tree view will stay empty until it's is toggled Real world repo (also works as steps to verify): to a Codespace (to use a specific build of VS Code you can specify a commit in the URL with , ex ) the Remote Explorer the page. This will cause the Codespace to load with the remote explorer visible 'll see that the Codespace view in the remote explorer is empty
update

Discussion:
set dataProvider(dataProvider: ITreeViewDataProvider | undefined) { if (dataProvider) { <ins> if (this.visible) { this.activate(); } </ins> const self = this; this._dataProvider = new class implements ITreeViewDataProvider { private _isEmpty: boolean = true;
Change:
I see this, but I think I've seen it correct in the past? But right now it's reproable in new terminals <img width="708" alt="image" src=""
Maybe related to my zsh prompt config, I can share the zsh config if it helps
I see the same, since I use the same setup <img width="1434" alt="Screenshot 2024-05-07 at 21 49 41" src=""
Yes can you pls share your zsh config?
Steps are: zsh oh-my-zsh a terminal in a workspace that has a git repo Let me know if that doesn't work for you.
Disabled by default in for now
also mentioned he thinks it should use the terminal's font
using your steps and I am still not seeing it . Can you share your configuration? <img width="986" alt="Screenshot 2024-05-13 at 9 50 51 AM" src=""
Also, any terminal settings would help - do you set the font / letter spacing for example?
I see that for the first prompt, the prompt start marker occurs before the (see the status bar). <img width="900" alt="Screenshot 2024-05-13 at 10 55 04 AM" src=""
Handle prompt start happens before the is by the program.
We should be disposing of the decoration when there's input, even for this case, when that's happening via a shell script.
In the case of the specific theme can be used without this issue if one removes from the prompt in Also note that the prompt is correct when a user hits enter. It's only the first prompt that is wrongly interpreted.

Discussion:
private _createHint(): void { const instance = this._instance instanceof TerminalInstance ? this._instance : undefined; <del> if (!instance || !this._xterm || this._hintWidget || instance?.capabilities.get(TerminalCapability.CommandDetection)?.hasInput) { </del> <ins> const commandDetectionCapability = instance?.capabilities.get(TerminalCapability.CommandDetection); if (!instance || !this._xterm || this._hintWidget || !commandDetectionCapability || !commandDetectionCapability?.hasInput) { </ins> return; }

this._addon?.dispose(); })); <ins> const inputModel = commandDetectionCapability.promptInputModel; if (inputModel) { this._register(inputModel.onDidChangeInput(() => { if (inputModel.value) { this._decoration?.dispose(); this._addon?.dispose(); } })); } </ins> if (!this._decoration) { return; }

restricted: true, markdownDescription: localize('terminal.integrated.initialHint', "Controls if the first terminal without input will show a hint about available actions when it is focused."), type: 'boolean', <del> default: false </del> <ins> default: true </ins> } };