jiebi/CodeConvo huggingface dataset:
Change:
Getting Started / Welcome on switching a theme The themes flash on desktop. On web you don't see flashing but there is a brief glimpse of the images at the top of the screen before they get laid out.
Maybe I'm abusing it too much but if you cycle through and click the themes it still glitches out.
How fast were you cycling? I was able to see a glitch maybe once when cycling as fast as possible on my MBP, though it may happen more often on different hardware
! Not very fast. See the buttons just dissapear.
Oh, interesting, I haven't seen that one before.

Discussion:
} })); <del> this.stepDisposables.add(this.themeService.onDidColorThemeChange(async () => { // Render again since syntax highlighting of code blocks may have changed const body = await this.detailsRenderer.renderMarkdown(media.path, media.base); if (!isDisposed) { // Make sure we weren't disposed of in the meantime webview.html = body; postTrueKeysMessage(); } })); </del> <ins> if (rawHTML.indexOf('<code>') >= 0) { // Render again when Theme changes since syntax highlighting of code blocks may have changed this.stepDisposables.add(this.themeService.onDidColorThemeChange(async () => { const body = await this.detailsRenderer.renderMarkdown(media.path, media.base); if (!isDisposed) { // Make sure we weren't disposed of in the meantime webview.html = body; postTrueKeysMessage(); } })); } </ins> const layoutDelayer = new Delayer(50);
Change:
When a test fails, it might sometimes look like this: ! By pressing in both editors, I can get it to look like this, which is more helpful for long strings: ! It might be better to enable word wrapping by default for string comparisons.
Code pointer:
Is this issue up for grabs? I would love to implement this
Yep
Could you assign me to this issue?
No, only people in the Microsoft org can be assigned issues. You can open a PR without being assigned though
I agree this is a better default. Thanks Maybe a setting to make this customizable? Not sure how many people would care.
How do I update commonEditorOptions dynamically? Replace every usage of commonEditorOptions with ?

Discussion:
minimap: { enabled: false }, <ins> wordWrap: 'on', </ins> }; const diffEditorOptions: IDiffEditorConstructionOptions = {
Change:
VS Code Version: 1.61.0-insider Steps to Reproduce: This is reproducible in the mock debugger: the disassembly view and scroll up to the address 0xf5 that 0xf4 is skipped. <img width="388" alt="Screen Shot 2021-09-29 at 9 13 10 PM" src="https://user-"The args for the disassemble request are: This skips the address just before .
how do one open the disassembly view?
While debugging, right click the main editor -open disassembly view. It will go to the current stack frame.
Run , stop on the line with the word "disassembly" in it, and right click the stack trace to open the disassembly view.

Discussion:
private async scrollUp_LoadDisassembledInstructions(instructionCount: number): Promise<boolean> { if (this._disassembledInstructions && this._disassembledInstructions.length > 0) { const address: string | undefined = this._disassembledInstructions?.row(0).instruction.address; <del> return this.loadDisassembledInstructions(address, -instructionCount, instructionCount - 1); </del> <ins> return this.loadDisassembledInstructions(address, -instructionCount, instructionCount); </ins> } return false;
Change:
We finalized this API this iteration:
Closing this as I see the PR is merged to release branch.

Discussion:
return extHostTerminalService.onDidChangeTerminalDimensions(listener, thisArg, disposables); }, onDidChangeTerminalState(listener, thisArg?, disposables?) { <del> checkProposedApiEnabled(extension); </del> return extHostTerminalService.onDidChangeTerminalState(listener, thisArg, disposables); }, onDidWriteTerminalData(listener, thisArg?, disposables?) {
Change:
our selfhost repo: microsoft/vscode <kbdCtrl Shift B</kbdto start the default build Sometimes you get 2 build tasks in separate terminals, not in split mode Sometimes <kbdCtrl C</kbdin one of them will close the panel, despite the fact that there is still a terminal open and the other task running. !
I haven't been able to reproduce this on windows or mac.
are you using linux? local or remote?
Yeah, this is remote: WSL
In WSL (cannot repro locally) when I run the build task via the command pallette -, I see that they're not split terminals. When I do ctrl + shift +b IE , they are in split terminals. thoughts?
could have to do with this?
To verify, add tasks that are similar to the following to your in an open folder: Then, run the task "Repos". Verify that you see two tasks in a split terminal. Run 2-3 more times to double check, as this was a race.
I still see this in selfhost. ! After killing one of them and running <kbdCtrl Shift B</kbdonce again: !
In fact I hit the bug more often than not.
have you seen this bug since?
Nope, good to close!

Discussion:
return [terminalToReuse.terminal, commandExecutable, undefined]; } <del> await this.terminalCreationQueue; const createTerminalPromise = this.doCreateTerminal(group, launchConfigs); this.terminalCreationQueue = createTerminalPromise; const result: ITerminalInstance = await createTerminalPromise; </del> <ins> this.terminalCreationQueue = this.terminalCreationQueue.then(() => this.doCreateTerminal(group, launchConfigs!)); const result: ITerminalInstance = (await this.terminalCreationQueue)!; </ins> const terminalKey = result.instanceId.toString(); result.onDisposed((terminal) => {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- Version: 1.60.2 Commit: Date: 2021-09-22T11:59:27.195Z (1 wk ago) Electron: 13.1.8 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin x64 20.6.0 Steps to Reproduce: a large file with a long line to be scrollable over the file (x and y axis). right. on minimap. Actual: The minimap slider does not have full width. Expected: The minimap slider is always full width.
Could you please also add a screenshot, I am not sure what you are referring to.
Please check. https://user-
can I work on this issue. if yes code pointers to investigate.
PR welcome.
thanks
what would be the expected behaviour of the minimap for a horizontal scroll?
I think we could just remove that the slider moves horizontally and let it stay put.
I think it should be:
These lines of code should work if you support scrolling horizontally for the minimap slider. At this time, we can only scroll the minimap slider vertically.
Okay, I can do that but I think it would be much better if we allow horizontal scroll in minimap. what do you think about that?

Discussion:
this._slider.setHeight(layout.sliderHeight); // Compute horizontal slider coordinates <del> const scrollLeftChars = renderingCtx.scrollLeft / this._model.options.typicalHalfwidthCharacterWidth; const horizontalSliderLeft = Math.min(this._model.options.minimapWidth, Math.round(scrollLeftChars * this._model.options.minimapCharWidth / this._model.options.pixelRatio)); this._sliderHorizontal.setLeft(horizontalSliderLeft); this._sliderHorizontal.setWidth(this._model.options.minimapWidth - horizontalSliderLeft); </del> <ins> this._sliderHorizontal.setLeft(0); this._sliderHorizontal.setWidth(this._model.options.minimapWidth); </ins> this._sliderHorizontal.setTop(0); this._sliderHorizontal.setHeight(layout.sliderHeight);
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.61.0 (I've seen this before and see it on too) OS Version: MacOS 11.6 Steps to Reproduce: Have 2 editor groups in workspace. Open a search editor (Cmd+Shift+F [can't remember if that's a default or my custom keybinding]) it to the other editor group. something to search for. At this point, you have to scroll up to see the results.
I've been looking into this. Any ideas where to start? I see that the following code does get called, but doesn't seem to position it correctly. If I wrap in a for 500ms, it works, but that's not a good long term solution.

Discussion:
}); const searchOperation = await startInput.ongoingSearchOperation; <del> this.onSearchComplete(searchOperation, config, startInput); </del> <ins> await this.onSearchComplete(searchOperation, config, startInput); </ins> } private async onSearchComplete(searchOperation: ISearchComplete, startConfig: SearchConfiguration, startInput: SearchEditorInput) {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.61.0- OS Version: Debian Steps to Reproduce: .deb package (This has been previously reported as and and I cannot see any way to reopen them.) The current postinst file calls "desktop-file-install" on the installed desktop files. This has the effect of adding the following line to each file: This gets flagged by tools which validate the security of the software supply chain, such as . In the previous issues it is implied that this tool is called in order to add the .desktop files to the menu immediately; for this there is a dedicated command which will update the menu cache without modifying the installed files.
/verified After installing the latest code-insiders .deb, debsums no longer flags the .desktop files as changed.

Discussion:
update-alternatives --install /usr/bin/editor editor /usr/bin/@@NAME@@ 0 # Install the desktop entry <del> if hash desktop-file-install 2>/dev/null; then desktop-file-install /usr/share/applications/@@NAME@@.desktop desktop-file-install /usr/share/applications/@@NAME@@-url-handler.desktop </del> <ins> if hash update-desktop-database 2>/dev/null; then update-desktop-database </ins> fi # Update mimetype database to pickup workspace mimetype
Change:
Issue Type: <bBug</bkeyboard shortcuts for "npm.packageManager" ! VS Code version: Code - Insiders 1.62.0-insider (, 2021-10-11T05:16:36.885Z) OS version: WindowsNT x64 10.0. Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (26)</summaryExtensionVersion ------ vscode-javascript-repl0.7.2 Bookmarks13.2.2 gitlens11.6.1 copilot-nightly1.5.3048 remotehub0.15.0 rest-client0.24.5 monkey-patch0.1.15 search-node-modules1.3.0 vscode-docker1.17.0 vscode-edge-devtools1.3.1 remote-containers0.202.1 remote-ssh-edit-nightly2021.10.5220 remote-ssh-nightly2021.10.5220 remote-wsl0.58.2 hexeditor1.8.2 js-debug-nightly2021.10.817 vscode-typescript-next4.5. debugger-for-edge1.0.15 vetur0.34.1 explorer-exclude-vscode-extension1.2.0 reveal1.2.7 luna-paint0.10.0 vscode-icons11.6.0 cloudmusic9.2.4 markdown-all-in-one3.4.0 material-theme3.13.2 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --

Discussion:
}, { "command": "npm.packageManager", <del> "title": "%command.packageManager" </del> <ins> "title": "%command.packageManager%" </ins> } ], "menus": {
Change:
<img width="769" alt="CleanShot 2021-10-13 at 14 40 36 src="https://user-"When we show a deprecated message we should use an icon since we shouldn't use color alone to assign meaning for accessibility.
Any suggestions for an icon?
<img src="https://user-"Verification steps: a deprecated setting in the like the settings UI and search for the setting that the deprecated message has an icon and passes color contrast ratio of 3:1 for the icon and 4.5:1 for the text

Discussion:
} .settings-editor > .settings-body > .settings-tree-container .setting-item-contents.is-deprecated .setting-item-deprecation-message { <del> display: block; </del> <ins> display: flex; } .settings-editor > .settings-body > .settings-tree-container .setting-item-contents.is-deprecated .setting-item-deprecation-message .codicon { margin-right: 4px; </ins> } .settings-editor > .settings-body > .settings-tree-container .setting-item-contents .setting-item-description {

} else { template.deprecationWarningElement.innerText = deprecationText; } <ins> template.deprecationWarningElement.prepend($('.codicon.codicon-error')); </ins> template.containerElement.classList.toggle('is-deprecated', !!deprecationText); this.renderValue(element, <ISettingItemTemplate>template, onChange);
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Steps to Reproduce: a existing folder in vscode sure the folder has files "init repository" buttun in vscode a change (delete a file) in vscode source control the error: ! I would suggest popping up a dialog asking the user if he/she wants to create a branch first.

Discussion:
UnknownPath = 'UnknownPath', EmptyCommitMessage = 'EmptyCommitMessage', BranchFastForwardRejected = 'BranchFastForwardRejected', <ins> BranchNotYetBorn = 'BranchNotYetBorn', </ins> TagConflict = 'TagConflict' }

if (/Please,? commit your changes or stash them/.test(err.stderr || '')) { err.gitErrorCode = GitErrorCodes.DirtyWorkTree; err.gitTreeish = treeish; <ins> } else if (/You are on a branch yet to be born/.test(err.stderr || '')) { err.gitErrorCode = GitErrorCodes.BranchNotYetBorn; </ins> } throw err;

}); await this.repository.clean(toClean); <del> await this.repository.checkout('', toCheckout); </del> <ins> try { await this.repository.checkout('', toCheckout); } catch (err) { if (err.gitErrorCode !== GitErrorCodes.BranchNotYetBorn) { throw err; } } </ins> await this.repository.updateSubmodules(submodulesToUpdate); this.closeDiffEditors([], [...toClean, ...toCheckout]);
Change:
. a folder and add this task: that task The task runs, but there is an error that shows in a notification:
shouldn't be getting used in the stack trace
when I set default location to editor and run the build task, terminals are appearing in the panel. is that by design ?
Currently that is by design as tasks + terminals in the editor don't work.
that might just be a matter of removing location here?
I the location to work around the issue:
is here when the terminal is in the editor, so we must be listening to somewhere in terminal editor code and disposing of the terminal !
yep, here
active instance does get updated for me, but could repro an issue where wasn't respected - fix for that incoming https://user-

Discussion:
import { IConfigurationService } from 'vs/platform/configuration/common/configuration'; import { ILogService } from 'vs/platform/log/common/log'; import { INotificationService } from 'vs/platform/notification/common/notification'; <del> import { IShellLaunchConfig, TerminalLocation, TerminalSettingId, WaitOnExitValue } from 'vs/platform/terminal/common/terminal'; </del> <ins> import { IShellLaunchConfig, TerminalSettingId, WaitOnExitValue } from 'vs/platform/terminal/common/terminal'; </ins> import { formatMessageForTerminal } from 'vs/platform/terminal/common/terminalStrings'; import { ThemeIcon } from 'vs/platform/theme/common/themeService'; import { IViewDescriptorService, IViewsService, ViewContainerLocation } from 'vs/workbench/common/views';

this._logService.trace(`No terminal found to split for group ${group}`); } // Either no group is used, no terminal with the group exists or splitting an existing terminal failed. <del> const createdTerminal = await this._terminalService.createTerminal({ location: TerminalLocation.Panel, config: launchConfigs }); </del> <ins> const createdTerminal = await this._terminalService.createTerminal({ config: launchConfigs }); </ins> createdTerminal.onDisposed((terminal) => this._fireTaskEvent({ kind: TaskEventKind.Terminated, exitReason: terminal.exitReason, taskId: task.getRecentlyUsedKey() })); return createdTerminal; }

})); const disposeListeners = [ <del> instance.onExit(() => this.dispose()), </del> <ins> instance.onExit((e) => { if (!instance.waitOnExit) { this.dispose(); } }), </ins> instance.onDisposed(() => this.dispose()), instance.onTitleChanged(() => this._onDidChangeLabel.fire()), instance.onIconChanged(() => this._onDidChangeLabel.fire()),
Change:
Issue Type: <bBug</bClone VS Code repo Follow the instructions for linking vscode-html-language-service will fail, as the project/extension has since moved to yarn. works fine. VS Code version: Code 1.62.0 (, 2021-11-03T15:23:01.379Z) OS version: Windows_NT x64 10.0. Restricted Mode: No Remote OS version: Linux x64 4.19.128-microsoft-standard <!-- generated by issue reporter --

Discussion:
"version": "2.0.0", "tasks": [ { <del> "label": "npm", "command": "npm", "args": ["run", "compile"], </del> <ins> "label": "yarn", "command": "yarn", "args": ["compile"], </ins> "type": "shell", "presentation": { "reveal": "silent",

- Clone [microsoft/vscode-html-languageservice](https://github.com/microsoft/vscode-html-languageservice) - Run `yarn` in `vscode-html-languageservice` - Run `yarn link` in `vscode-html-languageservice`. This will compile and link `vscode-html-languageservice` <del> - In `html-language-features/server/`, run `npm link vscode-html-languageservice` </del> <ins> - In `html-language-features/server/`, run `yarn link vscode-html-languageservice` </ins> #### Testing the development version of `vscode-html-languageservice`

"version": "2.0.0", "tasks": [ { <del> "label": "npm watch", "command": "npm", "args": ["run", "watch"], </del> <ins> "label": "yarn watch", "command": "yarn", "args": ["watch"], </ins> "type": "shell", "presentation": { "reveal": "silent",

"problemMatcher": "$tsc-watch" } ], <del> } </del>  No newline at end of file <ins> } </ins>

"install-service-local": "yarn link vscode-css-languageservice && yarn link vscode-html-languageservice", "install-server-next": "yarn add vscode-languageserver@next", "install-server-local": "yarn link vscode-languageserver", <del> "test": "npm run compile && node ./test/index.js" </del> <ins> "test": "yarn compile && node ./test/index.js" </ins> } }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: master OS Version: mac-os Steps to Reproduce: -produces yarn-[...].cjs file in When switching yarn version from berry to classic the .cjs file extension is not recognized by while building. The preinstall script produces an error stating:

Discussion:
err = true; } <del> if (!/yarn[w-.]*.js$|yarnpkg$/.test(process.env['npm_execpath'])) { </del> <ins> if (!/yarn[w-.]*.c?js$|yarnpkg$/.test(process.env['npm_execpath'])) { </ins> console.error('033[1;31m*** Please use yarn to install dependencies.033[0;0m'); err = true; }
Change:
These steps sometimes fail to succeed: Specifically the line: Since we first create all the files and then activate git, a repository should eventually open.
Given that you have seen this locally and/or seen it in CI, what's the workbench state when this happens? Specifically, a screenshot would be awesome.
Oh this isn't Playright. It's the git smoke tests. Which are extension tests.
is an interesting one because I see no error message from Parcel.

Discussion:
git = ext!.exports.getAPI(1); if (git.repositories.length === 0) { <del> await eventToPromise(git.onDidOpenRepository); </del> <ins> const onDidOpenRepository = eventToPromise(git.onDidOpenRepository); await commands.executeCommand('git.openRepository', cwd); await onDidOpenRepository; </ins> } assert.strictEqual(git.repositories.length, 1);
Change:
Issue Type: <bBug</bpython file with # %% comments a cell over something like 'print' in the interactive window Expected: Hover window shows up Actual: No hover messages are sent to the LS. I suspect hovering over the IW notebook just isn't hooked up. VS Code version: Code - Insiders 1.63.0-insider (, 2021-11-09T15:23:39.737Z) OS version: WindowsNT x64 10.0. Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (26)</summaryExtensionVersion ------ vscode-eslint2.2.2 prettier-vscode9.0.0 remotehub0.18.0 better-cpp-syntax1.15.10 vscode-position1.0.3 regexp-preview0.1.5 python2021.12.-dev vscode-pylance9999.0.0-dev jupyter2021.10. jupyter-keymap1.0.0 jupyter-renderers1.0.3 remote-containers0.205.1 remote-ssh0.66.0 remote-ssh-edit0.66.0 remote-ssh-edit-nightly2021.11.3789 remote-ssh-nightly2021.11.3793 remote-wsl0.58.5 vscode-remote-extensionpack0.21.0 cpptools1.7.1 cpptools-extension-pack1.0.0 live-server0.2.9 vscode-github-issue-notebooks0.0.112 vscode-selfhost-test-provider0.3.8 vscode-typescript-next4.6. rpa-eslint-snippets0.0.2 rest-book4.2.0 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
This used to work in the webview implementation
This might be because the uri is not what we expect? Meaning the language service registered for a document filter doesn't match.
/verified. Although not sure if I should be verifying as I submitted the fix

Discussion:
cellExecuteToolbar: MenuId.InteractiveCellExecute, cellExecutePrimary: undefined }, <del> cellEditorContributions: [], </del> <ins> cellEditorContributions: EditorExtensionsRegistry.getSomeEditorContributions([ SelectionClipboardContributionID, ContextMenuController.ID, ModesHoverController.ID, MarkerController.ID ]), </ins> options: this.#notebookOptions });

top: INPUT_EDITOR_PADDING, bottom: INPUT_EDITOR_PADDING }, <ins> hover: { enabled: true } </ins> } }, { ...{