jiebi/CodeConvo huggingface dataset:
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.87.1 OS Version: Windows 11 Home .3235 Steps to Reproduce: "debug.toolBarLocation" to commandCenter, and adjust the "debugIcon.disconnectForeground" color value: seems to be the default color, vs "floating" or "docked" settings that display the correct color. This is also the case when set in a custom theme extension. Example screenshot of problem: !

Discussion:
const debugIconDisconnectColor = theme.getColor(debugIconDisconnectForeground); if (debugIconDisconnectColor) { <del> collector.addRule(`.monaco-workbench .part > .title > .title-actions .action-label${ThemeIcon.asCSSSelector(icons.debugDisconnect)},.monaco-workbench .debug-view-content ${ThemeIcon.asCSSSelector(icons.debugDisconnect)}, .monaco-workbench .debug-toolbar ${ThemeIcon.asCSSSelector(icons.debugDisconnect)} { color: ${debugIconDisconnectColor}; }`); </del> <ins> collector.addRule(`.monaco-workbench .part > .title > .title-actions .action-label${ThemeIcon.asCSSSelector(icons.debugDisconnect)},.monaco-workbench ${ThemeIcon.asCSSSelector(icons.debugDisconnect)} { color: ${debugIconDisconnectColor}; }`); </ins> } const debugIconRestartColor = theme.getColor(debugIconRestartForeground);
Change:
not sure what the repro steps are yet. !
I can still reproduce the issue. Query: "blah blah blah blah baa baa bla bla blah"
something going wrong with rendering offtopic: <img width="600" alt="Screenshot 2024-03-26 at 2 56 08 PM" src=""
Looks like this is the only case where your participant returns a markdown chunk, and this isn't stringified correctly. I did a minimal fix but a better change would be to refactor this to pass markdown chunks as-is all the way down into ChatModel

Discussion:
return; } <del> if (progress.kind === 'content' || progress.kind === 'markdownContent') { </del> <ins> if (progress.kind === 'content') { </ins> responseContent += progress.content; <ins> } else if (progress.kind === 'markdownContent') { responseContent += progress.content.value; </ins> } if (this._currentRequest) { model.acceptResponseProgress(this._currentRequest, progress);
Change:
It runs the correct intent, but renders rather than ! ! This does not happen in panel chat
You implemented this, right?
Yes, the problem is here

Discussion:
const newDecorations: IModelDeltaDecoration[] = []; for (const command of commands) { <del> const withSlash = `/${command.command}`; </del> <ins> const withSlash = `/${command.command} `; </ins> const firstLine = this._inputModel.getLineContent(1); if (firstLine.startsWith(withSlash)) { newDecorations.push({
Change:
I see this when starting the panel chat voice action in dev tools. An easy way to know when this reproduces is to enable the audio cue, which then plays forever.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

Discussion:
const holdMode = keybindingService.enableKeybindingHoldMode(id); <ins> let session: IVoiceChatSession | undefined = undefined; </ins> let acceptVoice = false; const handle = disposableTimeout(() => { acceptVoice = true; <del> session.setTimeoutDisabled(true); // disable accept on timeout when hold mode runs for VOICE_KEY_HOLD_THRESHOLD </del> <ins> session?.setTimeoutDisabled(true); // disable accept on timeout when hold mode runs for VOICE_KEY_HOLD_THRESHOLD </ins> }, VOICE_KEY_HOLD_THRESHOLD); const controller = await VoiceChatSessionControllerFactory.create(accessor, target);

return; } <del> const session = await VoiceChatSessions.getInstance(instantiationService).start(controller, context); </del> <ins> session = await VoiceChatSessions.getInstance(instantiationService).start(controller, context); </ins> await holdMode; handle.dispose();
Change:
To prevent issues like this: and like this and many more
this is a good idea, I've been getting tagged in a lot of these recently. it's difficult to say what exactly the limit/requirements should be though. atm we require title and description (the rest of the info is fluff that is auto included). Maybe force description to be longer than 10 characters?
We can start with 10characters enforced on both title & body and see how issues keep coming. We could also maybe crowd-source ideas from the team

Discussion:
<textarea name="description" id="description" placeholder="${escape(localize('details', "Please enter details."))}" required></textarea> </div> <div id="description-empty-error" class="validation-error hidden" role="alert">${escape(localize('descriptionEmptyValidation', "A description is required."))}</div> <ins> <div id="description-short-error" class="validation-error hidden" role="alert">${escape(localize('descriptionTooShortValidation', "Please provide a longer description."))}</div> </ins> </div> <div class="system-info" id="block-container">

private validateInput(inputId: string): boolean { const inputElement = (<HTMLInputElement>this.getElementById(inputId)); const inputValidationMessage = this.getElementById(`${inputId}-empty-error`); <ins> const descriptionShortMessage = this.getElementById(`description-short-error`); </ins> if (!inputElement.value) { inputElement.classList.add('invalid-input'); inputValidationMessage?.classList.remove('hidden'); <ins> descriptionShortMessage?.classList.add('hidden'); </ins> return false; <del> } else { </del> <ins> } else if (inputId === 'description' && inputElement.value.length < 10) { inputElement.classList.add('invalid-input'); descriptionShortMessage?.classList.remove('hidden'); inputValidationMessage?.classList.add('hidden'); return false; } else { </ins> inputElement.classList.remove('invalid-input'); inputValidationMessage?.classList.add('hidden'); <ins> if (inputId === 'description') { descriptionShortMessage?.classList.add('hidden'); } </ins> return true; } }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Insiders OS Version: N/A Steps to Reproduce: cells in Python file to start an IW to save the IW as an ipynb file a name created ipynb file cannot be opened.
!

Discussion:
return undefined; // save cancelled } <del> return await this._editorModelReference.saveAs(target); </del> <ins> const saved = await this._editorModelReference.saveAs(target); if (saved && 'resource' in saved && saved.resource) { this._notebookService.getNotebookTextModel(saved.resource)?.dispose(); } return saved; </ins> } override matches(otherInput: EditorInput | IUntypedEditorInput): boolean {
Change:
Select a portion of a variable name Press F2 Previously, the rename widget would open with the same substring highlighted. It's helpful to quickly rename one subword in a variable name, for example. Now, the full contents of the input in the rename widget are highlighted initially. I don't know who owns this but it looks like you touched it recently
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

Discussion:
this._currentName = currentName; this._input.domNode.value = currentName; <ins> this._input.domNode.setAttribute('selectionStart', selectionStart.toString()); this._input.domNode.setAttribute('selectionEnd', selectionEnd.toString()); </ins> this._input.domNode.size = Math.max((where.endColumn - where.startColumn) * 1.1, 20); // determines width const disposeOnDone = new DisposableStore();

// TODO@ulugbekna: could this be simply run in `afterRender`? setTimeout(() => { this._input.domNode.focus(); <del> this._input.domNode.select(); </del> <ins> this._input.domNode.setSelectionRange( parseInt(this._input!.domNode.getAttribute('selectionStart')!), parseInt(this._input!.domNode.getAttribute('selectionEnd')!) ); </ins> }, 100); }
Change:
! Notice the red icon, I find that somewhat unexpected. //cc
I bisected this to gonna add you to assignees.
Thanks for tracking this down.

Discussion:
const debugIconDisconnectColor = theme.getColor(debugIconDisconnectForeground); if (debugIconDisconnectColor) { <del> collector.addRule(`.monaco-workbench .part > .title > .title-actions .action-label${ThemeIcon.asCSSSelector(icons.debugDisconnect)},.monaco-workbench ${ThemeIcon.asCSSSelector(icons.debugDisconnect)} { color: ${debugIconDisconnectColor}; }`); </del> <ins> collector.addRule(`.monaco-workbench .part > .title > .title-actions .action-label${ThemeIcon.asCSSSelector(icons.debugDisconnect)},.monaco-workbench .debug-view-content ${ThemeIcon.asCSSSelector(icons.debugDisconnect)}, .monaco-workbench .debug-toolbar ${ThemeIcon.asCSSSelector(icons.debugDisconnect)}, .monaco-workbench .command-center-center ${ThemeIcon.asCSSSelector(icons.debugDisconnect)} { color: ${debugIconDisconnectColor}; }`); </ins> } const debugIconRestartColor = theme.getColor(debugIconRestartForeground);
Change:
This used to work on the same machine however. Not sure when it stopped. Or why.
Please run
that worked! Wonder if the CLI should do it automatically?
BTW I also noticed how it returns exit code 0 (success) even when it failed like that. Perhaps you should avoid just issuing a warning in case some of these operations fails.
Thanks a ton,

Discussion:
mod context; pub mod args; <ins> pub mod serve_web; </ins> pub mod tunnels; pub mod update; pub mod version; <del> pub mod serve_web; </del> pub use context::CommandContext;

pub mod code_server; pub mod dev_tunnels; pub mod legal; <ins> pub mod local_forwarding; </ins> pub mod paths; pub mod protocol; pub mod shutdown_signal; pub mod singleton_client; pub mod singleton_server; <del> pub mod local_forwarding; mod wsl_detect; </del> mod challenge; mod control_server; mod nosleep;

#[cfg(target_os = "windows")] mod service_windows; mod socket_signal; <ins> mod wsl_detect; </ins> <del> pub use control_server::{serve, serve_stream, Next, ServeStreamParams, AuthRequired}; </del> <ins> pub use control_server::{serve, serve_stream, AuthRequired, Next, ServeStreamParams}; </ins> pub use nosleep::SleepInhibitor; pub use service::{ create_service_manager, ServiceContainer, ServiceManager, SERVICE_LOG_FILE_NAME,

info!(self.log, "Successfully registered service..."); <ins> if let Err(e) = proxy.reload().await { warning!(self.log, "Error issuing reload(): {}", e); } </ins> // note: enablement is implicit in recent systemd version, but required for older systems // https://github.com/microsoft/vscode/issues/167489#issuecomment-1331222826 proxy

#[dbus_proxy(name = "StopUnit")] fn stop_unit(&self, name: String, mode: String) -> zbus::Result<zvariant::OwnedObjectPath>; <ins> #[dbus_proxy(name = "Reload")] fn reload(&self) -> zbus::Result<()>; </ins> }

let mut rx = tailf(read_file, 32); assert!(rx.try_recv().is_err()); <del> let mut append_file = OpenOptions::new() .write(true) .append(true) .open(&file_path) .unwrap(); </del> <ins> let mut append_file = OpenOptions::new().append(true).open(&file_path).unwrap(); </ins> writeln!(&mut append_file, "some line").unwrap(); let recv = rx.recv().await;

assert!(rx.try_recv().is_err()); <del> let mut append_file = OpenOptions::new() .write(true) .append(true) .open(&file_path) .unwrap(); </del> <ins> let mut append_file = OpenOptions::new().append(true).open(&file_path).unwrap(); </ins> writeln!(append_file, " is now complete").unwrap(); let recv = rx.recv().await;

*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> use std::{ </del> <ins> use std::{ </ins> ffi::OsString, path::{Path, PathBuf}, time::Duration,
Change:
So that we can add full path to Quick Search
Verification: Open from the command palette search for something Notice the folder paths next to the names of the files - that's the description! <img width="623" alt="image" src=""

Discussion:
saneAriaLabel }; }); <ins> this._saneDescription = mainItem.description; this._saneTooltip = mainItem.tooltip; </ins> } // #region Lazy Getters

this._hidden = value; } <del> protected _saneDescription?: string; </del> <ins> private _saneDescription?: string; </ins> get saneDescription() { return this._saneDescription; }

this._saneDetail = value; } <del> protected _saneTooltip?: string | IMarkdownString | HTMLElement; </del> <ins> private _saneTooltip?: string | IMarkdownString | HTMLElement; </ins> get saneTooltip() { return this._saneTooltip; }

? Event.map(Event.filter<{ element: IQuickPickElement; checked: boolean }>(this._onChecked.event, e => e.element === this), e => e.checked) : Event.None; <del> this._saneDescription = item.description; </del> this._saneDetail = item.detail; <del> this._saneTooltip = this.item.tooltip; </del> this._labelHighlights = item.highlights?.label; this._descriptionHighlights = item.highlights?.description; this._detailHighlights = item.highlights?.detail;

type: 'separator'; id?: string; label?: string; <ins> description?: string; </ins> ariaLabel?: string; buttons?: readonly IQuickInputButton[]; tooltip?: string | IMarkdownString;

picks.push({ label, type: 'separator', <del> tooltip: description, </del> <ins> description, </ins> buttons: [{ iconClass: ThemeIcon.asClassName(searchOpenInFileIcon), tooltip: localize('QuickSearchOpenInFile', "Open File")
Change:
Type the following in a TS filePress Enter after the arrow. The cursor is not indented (here cursor is shown by | symbol):We should instead have:

Discussion:
"action": { "indent": "outdent" } <del> } </del> <ins> }, { "beforeText": "^s*(var|const|let)s+w+s*=s*(.*)s*=>s*$", "action": { "indent": "indent" } }, </ins> ] }

// Failing tests from issues... <del> test.skip('issue #116843: indent after arrow function', () => { </del> <ins> test('issue #208215: indent after arrow function', () => { </ins> <del> // https://github.com/microsoft/vscode/issues/116843 </del> <ins> // https://github.com/microsoft/vscode/issues/208215 </ins> const model = createTextModel("", languageId, {}); disposables.add(model);

'const add1 = (n) =>', '    ', ].join('n')); <del> viewModel.type('n + 1;'); </del> <ins> }); }); test.skip('issue #208215: outdented after semicolon detected after arrow function', () => { // Notes: we want to outdent after having detected a semi-colon which marks the end of the line, but only when we have detected an arrow function // We want to have one outdent pattern corresponding to an indent pattern, and not a generic outdent and indent pattern const model = createTextModel([ 'const add1 = (n) =>', '    console.log("hi");', ].join('n'), languageId, {}); disposables.add(model); withTestCodeEditor(model, { autoIndent: "full" }, (editor, viewModel, instantiationService) => { registerLanguage(instantiationService, languageId, Language.TypeScript, disposables); editor.setSelection(new Selection(2, 24, 2, 24)); viewModel.type("n", 'keyboard'); assert.strictEqual(model.getValue(), [ 'const add1 = (n) =>', '    console.log("hi");', '', ].join('n')); }); }); test.skip('issue #116843: indent after arrow function', () => { // https://github.com/microsoft/vscode/issues/116843 const model = createTextModel("", languageId, {}); disposables.add(model); withTestCodeEditor(model, { autoIndent: "full" }, (editor, viewModel, instantiationService) => { registerLanguage(instantiationService, languageId, Language.TypeScript, disposables); viewModel.type([ 'const add1 = (n) =>', '    n + 1;', ].join('n')); </ins> viewModel.type("n", 'keyboard'); assert.strictEqual(model.getValue(), [ 'const add1 = (n) =>', <del> '	n + 1;', </del> <ins> '    n + 1;', </ins> '', ].join('n')); });

beforeText: /^s+([^{is]|i(?!fb))/, action: { indentAction: IndentAction.Outdent } }, <ins> { // TODO: Do not leave this here - place instead in the indent regex pattern if we use this method beforeText: /^s*(var|const|let)s+w+s*=s*(.*)s*=>s*$/, action: { indentAction: IndentAction.Indent } }, </ins> ];
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Latest Insiders OS Version: N/A Steps to Reproduce: Open a Jupyter Notebook Make changes changes to the cell and view the diff (scm or timeline) issues left padding in the first code cell. (on the left of there is no padding unlike the one on right) centers of code and metadata are not aligned ceneters of code and metadata have different styles (code cells have a gap, but metadata have a gap with some shadow effect) VS Code (or the diff editor) You'll notice that metadata diff view resizes and finally collapses into one But this is not the case with the code cells, i think the width is hard coded for code cells On wide screens there's a lot of white space on the far right of the right most code cell) !
What are actionables I should look into? I think the top thing is not a diff editor. The gutter comes from
Closing this for now, as this can no longer be replicated.

Discussion:
wordWrap: 'off', diffWordWrap: 'off', diffAlgorithm: 'advanced', <ins> renderSideBySide: true, useInlineViewWhenSpaceIsLimited: false </ins> };

dimension: { height: 0, width: 0 <del> } </del> <ins> }, renderSideBySide: true, useInlineViewWhenSpaceIsLimited: false </ins> }, { originalEditor: getOptimizedNestedCodeEditorWidgetOptions(), modifiedEditor: getOptimizedNestedCodeEditorWidgetOptions()
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.88.0-insider (Universal), Commit: , Date: 2024-03-21T17:26:53.619Z (9 hrs ago) OS Version: OS: Darwin arm64 23.2.0 Steps to Reproduce: the code server URL in the browser that the Activity Bar icons are not visible, it looks like the theme is broken. the is launched without server-base-path option at a given port, for example 8884, and then after accessing it from the browser, if the server is started with , then the issue is masked, perhaps because of browser caching.
This seems to be related to the new feature -

Discussion:
const workbenchWebConfiguration = { remoteAuthority, <del> remoteBaseUrl: this._basePath, </del> <ins> serverBasePath: this._basePath, </ins> _wrapWebWorkerExtHostInIframe, developmentOptions: { enableSmokeTestDriver: this._environmentService.args['enable-smoke-test-driver'] ? true : undefined, logLevel: this._logService.getLevel() }, settingsSyncOptions: !this._environmentService.isBuilt && this._environmentService.args['enable-sync'] ? { enabled: true } : undefined,
Change:
start inline chat in the content widget author multiple lines :bug: the widget's height doesn't change
still kind of running into this kinda - height changes, but the prompt layout after querying is unreadable since there's only one or 2 line height worth of space also, seems like there is a weird horizontal scroll element on the bottom left of the widget?
I see. This is because the height of the zone is limited by the overall height of the editor. It doesn't want to take more than 42% - that's something we can tweak but you might be facing a bit of a special case having a multiturn convo and accessibility viewer enabled as well.
The first prompt handles a long string nicely. A long string for the follow-up prompt results in content overflow. !

Discussion:
} ); this._store.add(this._widget); <del> this._store.add(this._widget.onDidChangeHeight(() => _editor.layoutContentWidget(this))); </del> this._widget.render(this._inputContainer); this._widget.setModel(this._defaultChatModel, {}); <ins> this._store.add(this._widget.inputEditor.onDidContentSizeChange(() => _editor.layoutContentWidget(this))); </ins> this._domNode.tabIndex = -1; this._domNode.className = 'inline-chat-content-widget interactive-session';