jiebi/CodeConvo huggingface dataset:
Change:
Issue Type: <bBug</b(or maybe feature) HI! I have a habit that I constantly do and and we have strict rules on doing feature branches, hence creating (& removing) lots of branches per week. (did I just implicitly mentioned that I'm fast : )))) ) So it comes to me a lot that I do and I see no action, and sometimes I even don't understand that no action happened. So it happens a lot that I do code, I do branches, I do sync, I go home happy, I come back tomorrow and I find out that my commits existed only on my local system the whole time. (and, BTW, I have strict inner rules that my codes should always be synced with remote) So, firstly, what I am asking for, is to receive a toast, a popup, an error, or everything that can notify me when I do and my branch is not published yet, so I can remember to publish my branch every time its new. Secondly, I think it wouldn't be bad if VSCode automatically publishes my branch when I do . I'm not sure if this is correct considering git rules/conventions. But If that's OK with Git & VSCode team/community, well, that's OK with me :) +1 Keep up the good work :) VS Code version: Code - Insiders 1.30.0-insider (, 2018-11-30T06:19:37.226Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (20)</summaryExtensionVersion ------ swagger-viewer2.1.0 npm-intellisense1.3.0 path-intellisense1.4.2 vscode-markdownlint0.21.0 vscode-eslint1.7.0 githistory0.4.4 gitlens9.0.1 tslint1.0.40 vscode-npm-script0.3.5 prettier-vscode1.7.2 vscode-nginx-conf-hint0.1.0 Angular27.0.1 camelcasenavigation0.3.51 Angular-BeastCode7.0.18 vsliveshare0.3.1005 vscode-icons7.28.0 sass-indented1.4.9 vscode-nginx0.6.0 move-ts1.11.3 html-css-class-completion1.17.1 </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.453 --- <!-- score: 0.448 --<!-- potentialduplicatescomment --

Discussion:
private async _sync(repository: Repository, rebase: boolean): Promise<void> { const HEAD = repository.HEAD; <del> if (!HEAD || !HEAD.upstream) { </del> <ins> if (!HEAD) { return; } else if (!HEAD.upstream) { const branchName = HEAD.name; const message = localize('confirm publish branch', "The branch '{0}' has no upstream branch. Would you like to publish this branch?", branchName); const yes = localize('ok', "OK"); const pick = await window.showWarningMessage(message, { modal: true }, yes); if (pick === yes) { await this.publish(repository); } </ins> return; }
Change:
Since it has the info about both & it would be handy to show the contrast ratio in the widget.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.516 --<!-- potentialduplicates_comment --
We could probably do this, from w3c: and using that calculation:
Probably round it off (1.074) to 1.1 or 1.07 For colors containing alpha value it should put a warning, something of the sort .
There's actually already a function in vscode And the poor thing has 0 references(uses).

Discussion:
let metadata = this._decodeMetadata(data.tokens2[(token2Index << 1) + 1]); result += `<table class="tm-metadata-table"><tbody>`; <del> result += `<tr><td class="tm-metadata-key">language</td><td class="tm-metadata-value">${escape(metadata.languageIdentifier.language)}</td>`; result += `<tr><td class="tm-metadata-key">token type</td><td class="tm-metadata-value">${this._tokenTypeToString(metadata.tokenType)}</td>`; result += `<tr><td class="tm-metadata-key">font style</td><td class="tm-metadata-value">${this._fontStyleToString(metadata.fontStyle)}</td>`; result += `<tr><td class="tm-metadata-key">foreground</td><td class="tm-metadata-value">${Color.Format.CSS.formatHexA(metadata.foreground)}</td>`; result += `<tr><td class="tm-metadata-key">background</td><td class="tm-metadata-value">${Color.Format.CSS.formatHexA(metadata.background)}</td>`; </del> <ins> result += `<tr><td class="tm-metadata-key">language</td><td class="tm-metadata-value">${escape(metadata.languageIdentifier.language)}</td></tr>`; result += `<tr><td class="tm-metadata-key">token type</td><td class="tm-metadata-value">${this._tokenTypeToString(metadata.tokenType)}</td></tr>`; result += `<tr><td class="tm-metadata-key">font style</td><td class="tm-metadata-value">${this._fontStyleToString(metadata.fontStyle)}</td></tr>`; result += `<tr><td class="tm-metadata-key">foreground</td><td class="tm-metadata-value">${Color.Format.CSS.formatHexA(metadata.foreground)}</td></tr>`; result += `<tr><td class="tm-metadata-key">background</td><td class="tm-metadata-value">${Color.Format.CSS.formatHexA(metadata.background)}</td></tr>`; if (metadata.background.isOpaque() && metadata.foreground.isOpaque()) { result += `<tr><td class="tm-metadata-key">contrast ratio</td><td class="tm-metadata-value">${metadata.background.getContrastRatio(metadata.foreground).toFixed(2)}</td></tr>`; } else { result += '<tr><td class="tm-metadata-key">Contrast ratio cannot be precise for colors that use transparency</td><td class="tm-metadata-value"></td></tr>'; } </ins> result += `</tbody></table>`; let theme = this._themeService.getColorTheme();
Change:
Press , . Choose from the quick pick. The extension viewlet opens with pre-populated in the search box and the caret is at the end of the line, after the : ! If I start typing now (e.g. start looking for a theme) I don't get any results because I need a space between and whatever I'm searching for, in this case : ! It would be nice to add the space automatically so that I can just start typing, not having to remember to press space first.

Discussion:
const selectTheme = (theme, applyTheme: boolean) => { if (typeof theme.id === 'undefined') { // 'pick in marketplace' entry if (applyTheme) { <del> openExtensionViewlet(this.viewletService, 'category:themes'); </del> <ins> openExtensionViewlet(this.viewletService, 'category:themes '); </ins> } theme = currentTheme; }

const selectTheme = (theme, applyTheme: boolean) => { if (typeof theme.id === 'undefined') { // 'pick in marketplace' entry if (applyTheme) { <del> openExtensionViewlet(this.viewletService, 'tag:icon-theme'); </del> <ins> openExtensionViewlet(this.viewletService, 'tag:icon-theme '); </ins> } theme = currentTheme; }
Change:
Open folder containing CRLF files (typically on windows) Copy multiple lines of text, paste into search viewlet Close that file Do multiline search The file is not found cc Candidate because the feature is essentially completely broken on windows.

Discussion:
} else if (query.isRegExp) { let fixedRegexpQuery = fixRegexEndingPattern(query.pattern); fixedRegexpQuery = fixRegexNewline(fixedRegexpQuery); <ins> fixedRegexpQuery = fixNewline(fixedRegexpQuery); </ins> fixedRegexpQuery = fixRegexCRMatchingNonWordClass(fixedRegexpQuery, !!query.isMultiline); fixedRegexpQuery = fixRegexCRMatchingWhitespaceClass(fixedRegexpQuery, !!query.isMultiline); args.push('--regexp', fixedRegexpQuery);

pattern.replace(/([^]|^)((?:)*)W/g, '$1$2(r?n|[^wr])') : pattern.replace(/([^]|^)((?:)*)W/g, '$1$2[^wr]'); } <ins> export function fixNewline(pattern: string): string { return pattern.replace(/n/g, 'r?n'); } </ins>

import { joinPath } from 'vs/base/common/resources'; import { URI } from 'vs/base/common/uri'; import { Range } from 'vs/workbench/services/search/node/ripgrepSearchUtils'; <del> import { fixRegexCRMatchingNonWordClass, fixRegexCRMatchingWhitespaceClass, fixRegexEndingPattern, fixRegexNewline, IRgMatch, IRgMessage, RipgrepParser, unicodeEscapesToPCRE2 } from 'vs/workbench/services/search/node/ripgrepTextSearchEngine'; </del> <ins> import { fixRegexCRMatchingNonWordClass, fixRegexCRMatchingWhitespaceClass, fixRegexEndingPattern, fixRegexNewline, IRgMatch, IRgMessage, RipgrepParser, unicodeEscapesToPCRE2, fixNewline } from 'vs/workbench/services/search/node/ripgrepTextSearchEngine'; </ins> import { TextSearchResult } from 'vscode'; suite('RipgrepTextSearchEngine', () => {

].forEach(testFixRegexNewline); }); <ins> test('fixNewline', () => { function testFixNewline([inputReg, testStr, shouldMatch = true]): void { const fixed = fixNewline(inputReg); const reg = new RegExp(fixed); assert.equal(reg.test(testStr), shouldMatch, `${inputReg} => ${reg}, ${testStr}, ${shouldMatch}`); } [ ['foo', 'foo'], ['foon', 'foorn'], ['foon', 'foon'], ['foonabc', 'foornabc'], ['foonabc', 'foonabc'], ['foorn', 'foorn'], ['foonbarc', 'foobar', false], ['foobar', 'foonbar', false], ].forEach(testFixNewline); }); </ins> suite('RipgrepParser', () => { const TEST_FOLDER = URI.file('/foo/bar');
Change:
Issue Type: <bBug</b! VS Code version: Code - Insiders 1.31.0-insider (, 2018-12-17T10:06:30.031Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
Adding to makes it focusable and fixes the issue. In , line 108 needs to be changed to: Is this an acceptable fix? Shall I raise a PR?
Yeah it is acceptable. Please create a PR.
there's a yellow border in that case and it breaks <kbdShift</kbd+<kbdTab</kbdwhen focus is inside input.
Where is that yellow border? And what exactly is breaking in <kbdShift</kbd+<kbdTab</kbd? Works fine for me.
!
<kbdShift</kbd+<kbdTab</kbd(when focus is on input) should focus editor menu (three dots). And the icon should remain in place.
Oh I see it now. I am getting a blue border that is barely noticeable. I will fix that. Thanks! When focus is on input, I believe <kbdShift</kbd+<kbdTab</kbdshould move focus to the "Record keys" button (on the far right of the input box) and so on. That's how it is happening in the latest release version too.
That's what pressing <kbdTab</kbdshould do. <kbdShift</kbd+<kbdTab</kbdis a reverse command of that and should move focus in the opposite side - in this case to editor actions menu (and the icon should be in place to be available for pressing by <kbdEnter</kbd).
Oh! My bad! Will look into it.
I think you should do the same as in and set the key to true in the setInput method and remove this listeners
Thanks That works! I have updated my PR .

Discussion:
this.createOverlayContainer(keybindingsEditorElement); this.createHeader(keybindingsEditorElement); this.createBody(keybindingsEditorElement); <del> const focusTracker = this._register(DOM.trackFocus(parent)); this._register(focusTracker.onDidFocus(() => this.keybindingsEditorContextKey.set(true))); this._register(focusTracker.onDidBlur(() => this.keybindingsEditorContextKey.reset())); </del> } setInput(input: KeybindingsEditorInput, options: EditorOptions, token: CancellationToken): Promise<void> { <ins> this.keybindingsEditorContextKey.set(true); </ins> return super.setInput(input, options, token) .then(() => this.render(options && options.preserveFocus, token)); }
Change:
When previewing not secured content - there's a warning. . Choosing the last item - - the warning is still there and requires to close and reopen the preview. VS Code version: Code 1.30.0 (, 2018-12-11T22:29:11.253Z) OS version: Windows_NT x64 10.0.
Does not repo on MacOs or Windows in the current insiders build Does this happen in the current insiders builds (1.31) with all extensions disabled How are you opening the markdown file. Is it in a workspace?
Yes. Preview to the side. It is a workspace. Not multi-root. ! How do I check if it's a workspace or not? I mean, it should be a workspace... the setting is working only it doesn't hide the warning after you pick an option.
Sorry, I misread which you were selecting. Confirmed that selecting the last item does not refresh the preview
, fixing this :)

Discussion:
if (selection.type === 'toggle') { this.cspArbiter.setShouldDisableSecurityWarning(!this.cspArbiter.shouldDisableSecurityWarnings()); <ins> this.webviewManager.refresh(); </ins> return; } else { await this.cspArbiter.setSecurityLevelForResource(resource, selection.type);
Change:
VS Code version: Code 1.30.1 (, 2018-12-18T18:12:07.165Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
This was discussed previously in
Added with a in

Discussion:
if (jsFlags) { app.commandLine.appendSwitch('--js-flags', jsFlags); } <ins> // Disable smooth scrolling for Webviews if (cliArgs['disable-smooth-scrolling']) { app.commandLine.appendSwitch('disable-smooth-scrolling'); } </ins> } /**
Change:
VSCode Version: 1.30.1 OS Version: Windows 10 - build 1803 Steps to Reproduce: new branch "git checkout -b Code display branch like below ! on publish icon, which spins and does nothing and produces this log. To [new branch] - fatal: no such branch: 'refs/heads/ Issues: works. I can see my branch on server repo but I also get above error. After publish icon remains same. ! notifications stop working. I don't see any indication if there is any pending commit to push or pull latest changes. I think it was working fine until 1.28 or 1.29 Note: If I create branch with name like "feature1", everything works as expected. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.542 --- <!-- score: 0.484 --<!-- potentialduplicatescomment --
I have reproed this locally and tracked down the issue. receives the branch string, , as an argument, . The first thing it does it compare the branch name to 'HEAD', else tests if the name of the branch begins with an ' using the regex . In the case of the branch beginning with an ' it then replaces the name argument to the function with the symbolic full name. resolved by running . This resolves to . To then compute the rest of the branch information, the upstream/downstream changes, the code then runs which in the case of a symbolic full name branch, , fails to resolve, because the branch does not exist. The code catches the git exception, and throws which the calling code treats as if the upstream doesn't exist, hence showing the publish icon still, even though the branch DOES have an upstream and should show the sync icon. If I remove the initial regex test , the code then works correctly, in this case. This behavior was changed by in commit The simplest workaround is to not use a branch beginning with ' As for a fix, I can't see the context on why the change was made, the description says 'git: getBranch should resolve @ name syntax', but I'm not sure what '@ name syntax' is. Reverting this commit would fix this issue, but presumably there was another issue somewhere else which warranted the change in the first place. do you have more context?

Discussion:
async getBranch(name: string): Promise<Branch> { if (name === 'HEAD') { return this.getHEAD(); <del> } else if (/^@/.test(name)) { const symbolicFullNameResult = await this.run(['rev-parse', '--symbolic-full-name', name]); const symbolicFullName = symbolicFullNameResult.stdout.trim(); name = symbolicFullName || name; </del> } <del> const result = await this.run(['rev-parse', name]); </del> <ins> let result = await this.run(['rev-parse', name]); if (!result.stdout && /^@/.test(name)) { const symbolicFullNameResult = await this.run(['rev-parse', '--symbolic-full-name', name]); name = symbolicFullNameResult.stdout.trim(); result = await this.run(['rev-parse', name]); } </ins> if (!result.stdout) { return Promise.reject<Branch>(new Error('No such branch'));
Change:
VSCode Version:1.30.2 OS Version: Applies to Windows and OS X When the cursor flips on line numbers the SVG used has inconsistency's with the system defaults, e.g. tail is shorter Does this issue occur when all extensions are disabled?: Yes

Discussion:
<del> <svg xmlns="http://www.w3.org/2000/svg" x="0px" y="0px" width="30" height="42" viewBox="0 0 30 42" style="enable-background:new 0 0 30 42;"><polygon style="fill:#FFFFFF;stroke:#000000;stroke-width:2;" points="29,2.4 3.8,27.6 14.3,27.6 9,38.1 15.4,40.2 20.6,29.7 29,36"/></svg> </del> <ins> <svg xmlns="http://www.w3.org/2000/svg" x="0px" y="0px" width="30" height="50" viewBox="0 0 30 50" style="enable-background:new 0 0 30 50;"><polygon style="fill:#FFFFFF;stroke:#000000;stroke-width:2;" points="29,2.4 3.8,27.6 14,27.6 6.4,43 12.6,45 20.2,29.8 29,36"/></svg> </ins>

<del> <svg xmlns="http://www.w3.org/2000/svg" width="24" height="36" viewBox="0 0 24 36.1"><defs><style>.a{fill:#fff;}</style></defs><title>flipped-cursor-mac-2x</title><polygon points="8.6 33.1 11.8 23.9 2.2 23.9 23 2.5 23 31.3 17.4 26.1 14.2 35.1 8.6 33.1"/><path class="a" d="M22,29.1l-5-4.6-3.062,8.938-4.062-1.5L13,23H5L22,5M0,25H10.4l-3,8.3L15,36.1l3.125-7.662L24,33V0Z"/></svg> </del>  No newline at end of file <ins> <svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 26 38" style="enable-background:new 0 0 26 38;" width="26" height="38"><style type="text/css">.st0{stroke:#FFFFFF;stroke-miterlimit:10;}</style>	<title>flipped-cursor-mac</title><path class="st0" d="M10.6,33.2l3.2-9.4H4.2L25,2.4v28.8L19.4,26l-3.2,9.2c-0.4,1-1.6,1.6-2.6,1.2L12,35.8 C10.8,35.4,10.2,34.4,10.6,33.2z"/></svg> </ins>

<del> <svg xmlns="http://www.w3.org/2000/svg" width="12" height="18" viewBox="0 0 12 18"><style>.st0{fill:#fff}</style><title>flipped-cursor-mac</title><path d="M4.3 16.5l1.6-4.6H1.1L11.5 1.2v14.4L8.7 13l-1.6 4.5z"/><path class="st0" d="M11 14.5l-2.5-2.3L7 16.7 5 16l1.6-4.5h-4l8.5-9M0 12.5h5.2l-1.5 4.1L7.5 18 9 14.2l2.9 2.3V0L0 12.5z"/></svg> </del>  No newline at end of file <ins> <svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 13 19" style="enable-background:new 0 0 13 19;" width="13" height="19"><style type="text/css">.st0{stroke:#FFFFFF;stroke-miterlimit:10;}</style><title>flipped-cursor-mac</title><path class="st0" d="M5.3,16.6l1.6-4.7H2.1L12.5,1.2v14.4L9.7,13l-1.6,4.6c-0.2,0.5-0.8,0.8-1.3,0.6L6,17.9 C5.4,17.7,5.1,17.2,5.3,16.6z"/></svg> </ins>

<del> <svg xmlns="http://www.w3.org/2000/svg" width="15" height="21" x="0px" y="0px" viewBox="0 0 15 21" style="enable-background:new 0 0 15 21;"><polygon style="fill:#FFFFFF;stroke:#000000" points="14.5,1.2 1.9,13.8 7.1,13.8 4.5,19.1 7.7,20.1 10.3,14.9 14.5,18"/></svg> </del>  No newline at end of file <ins> <svg xmlns="http://www.w3.org/2000/svg" width="15" height="25" x="0px" y="0px" viewBox="0 0 15 25" style="enable-background:new 0 0 15 25;"><polygon style="fill:#FFFFFF;stroke:#000000" points="14.5,1.2 1.9,13.8 7,13.8 3.2,21.5 6.3,22.5 10.1,14.9 14.5,18"/></svg> </ins>  No newline at end of file
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --show n characters when typing it scrolls so fast you only see some at a time !
Feel free to submit PR.
Instead of adding a setting, just increased the limit and clipped the screencast less.

Discussion:
const keybinding = this.keybindingService.resolveKeyboardEvent(event); const label = keybinding.getLabel(); <del> if (!event.ctrlKey && !event.altKey && !event.metaKey && !event.shiftKey && this.keybindingService.mightProducePrintableCharacter(event) && label) { </del> <ins> if (!event.ctrlKey && !event.altKey && !event.metaKey && !event.shiftKey && (this.keybindingService.mightProducePrintableCharacter(event) || !keyboardMarker.textContent || keyboardMarker.textContent.length < 15) && label) { </ins> keyboardMarker.textContent += ' ' + label; } else { keyboardMarker.textContent = label;
Change:
<!-- Please search existing issues to avoid creating duplicates. --I'd like to provide my grunt tasks with a single argument but the VSCode task system doesn't support arguments for grunt tasks. I was shocked to discover this because I rarely have grunt tasks without arguments. I can of course work around this issue by using the "shell" task type to run grunt with arguments. Here's . <!-- Describe the feature you'd like. --
Starting pointer:
I would like to work on this. Can I start if no one else is on it ?
thank you, go for it! If you could make a sample repo to test out your change and link it here when you make a PR that would help me review your PR faster :)
To verify, use the from the PR to test.

Discussion:
"type": "string", "description": "%grunt.taskDefinition.type.description%" }, <ins> "args": { "type": "array", "description": "%grunt.taskDefinition.args.description%" }, </ins> "file": { "type": "string", "description": "%grunt.taskDefinition.file.description%"

"displayName": "Grunt support for VS Code", "config.grunt.autoDetect": "Controls whether auto detection of Grunt tasks is on or off. Default is on.", "grunt.taskDefinition.type.description": "The Grunt task to customize.", <ins> "grunt.taskDefinition.args.description": "Command line arguments to pass to the grunt task", </ins> "grunt.taskDefinition.file.description": "The Grunt file that provides the task. Can be omitted." <del> } </del>  No newline at end of file <ins> } </ins>

} interface GruntTaskDefinition extends vscode.TaskDefinition { task: string; <ins> args?: string[]; </ins> file?: string; }

} public async getTask(_task: vscode.Task): Promise<vscode.Task | undefined> { <del> const gruntTask = (<any>_task.definition).task; </del> <ins> const taskDefinition = <any>_task.definition; const gruntTask = taskDefinition.task; </ins> if (gruntTask) { <del> let kind: GruntTaskDefinition = (<any>_task.definition); </del> let options: vscode.ShellExecutionOptions = { cwd: this.workspaceFolder.uri.fsPath }; let source = 'grunt'; let task = gruntTask.indexOf(' ') === -1 <del> ? new vscode.Task(kind, this.workspaceFolder, gruntTask, source, new vscode.ShellExecution(`${await this._gruntCommand} ${gruntTask.name}`, options)) : new vscode.Task(kind, this.workspaceFolder, gruntTask, source, new vscode.ShellExecution(`${await this._gruntCommand} "${gruntTask.name}"`, options)); </del> <ins> ? new vscode.Task(taskDefinition, this.workspaceFolder, gruntTask, source, new vscode.ShellExecution(`${await this._gruntCommand}`, [gruntTask, ...taskDefinition.args], options)) : new vscode.Task(taskDefinition, this.workspaceFolder, gruntTask, source, new vscode.ShellExecution(`${await this._gruntCommand}`, [`"${gruntTask}"`, ...taskDefinition.args], options)); </ins> return task; } return undefined;
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.30.2 OS Version: macOS X 10.13.6 (17G4015) Steps to Reproduce: a package with in the file to execute the build task the error (pardon my french): <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes The issue appears to be caused by the being at , resulting in an invalid invocation of . A possible solution might be to append at the end instead of prepending.
I have a fix for this in my fork that I should be able to push a PR for pretty soon (waiting for employee to approve the contrib).

Discussion:
project.workspaceFolder || vscode.TaskScope.Workspace, localize('buildAndWatchTscLabel', 'watch - {0}', label), 'tsc', <del> new vscode.ShellExecution(command, ['--watch', ...args]), </del> <ins> new vscode.ShellExecution(command, [...args, '--watch']), </ins> '$tsc-watch'); watchTask.group = vscode.TaskGroup.Build; watchTask.isBackground = true;

this.taskProviderSub = vscode.workspace.registerTaskProvider('typescript', new TscTaskProvider(this.client)); } } <del> } </del>  No newline at end of file <ins> } </ins>