jiebi/CodeConvo huggingface dataset:
Change:
Steps: begin with multi tabs showing open an editor hide tab bar actions move to the top close editor open same editor actions are not visible anymore, there is just a "..." <img width="1348" alt="image" src=""
When creating the editor actions we rely on the event to tell us when actions change. However, this event is not set when there is no active pane. In that case we should have a different event trigger the onDidChange event such as onDidChangeActiveEditor for example

Discussion:
import { ActiveEditorGroupLockedContext, ActiveEditorDirtyContext, EditorGroupEditorsCountContext, ActiveEditorStickyContext, ActiveEditorPinnedContext, ActiveEditorLastInGroupContext, ActiveEditorFirstInGroupContext, EditorPinnedAndUnpinnedTabsContext, ResourceContextKey, applyAvailableEditorIds, ActiveEditorAvailableEditorIdsContext, ActiveEditorCanSplitInGroupContext, SideBySideEditorActiveContext } from 'vs/workbench/common/contextkeys'; import { EditorInput } from 'vs/workbench/common/editor/editorInput'; import { SideBySideEditorInput } from 'vs/workbench/common/editor/sideBySideEditorInput'; <del> import { Emitter, Relay, Event } from 'vs/base/common/event'; </del> <ins> import { Emitter, Relay } from 'vs/base/common/event'; </ins> import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { Dimension, trackFocus, addDisposableListener, EventType, EventHelper, findParentWithClass, isAncestor, IDomNodePagePosition, isMouseEvent, isActiveElement, focusWindow } from 'vs/base/browser/dom'; import { ServiceCollection } from 'vs/platform/instantiation/common/serviceCollection';

const primary: IAction[] = []; const secondary: IAction[] = []; <del> let onDidChange = Event.None; </del> <ins> let onDidChange; </ins> // Editor actions require the editor control to be there, so we retrieve it via service const activeEditorPane = this.activeEditorPane;

'navigation', shouldInlineGroup ); <ins> } else { // If there is no active pane in the group (it's the last group and it's empty) // Trigger the change event when the active editor changes const _onDidChange = new Emitter<void>(); onDidChange = _onDidChange.event; disposables.add(this.onDidActiveEditorChange(() => _onDidChange.fire())); </ins> } return { actions: { primary, secondary }, onDidChange };

export interface IActiveEditorActions { readonly actions: IToolbarActions; <del> readonly onDidChange: Event<IMenuChangeEvent>; </del> <ins> readonly onDidChange: Event<IMenuChangeEvent | void>; </ins> } export interface IEditorGroup {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: Python <img width="296" alt="Screenshot 2023-11-07 at 8 00 18 AM" src=""<img width="312" alt="Screenshot 2023-11-07 at 8 00 30 AM" src=""

Discussion:
const actions = createCancelablePromise(async token => { if (this._settingEnabledNearbyQuickfixes() && trigger.trigger.type === CodeActionTriggerType.Invoke && (trigger.trigger.triggerAction === CodeActionTriggerSource.QuickFix || trigger.trigger.filter?.include?.contains(CodeActionKind.QuickFix))) { const codeActionSet = await getCodeActions(this._registry, model, trigger.selection, trigger.trigger, Progress.None, token); <ins> const allCodeActions = [...codeActionSet.allActions]; </ins> if (token.isCancellationRequested) { return emptyCodeActionSet; }

for (const action of actionsAtMarker.validActions) { action.highlightRange = action.action.isPreferred; } <ins> if (codeActionSet.allActions.length === 0) { allCodeActions.push(...actionsAtMarker.allActions); } </ins> // Already filtered through to only get quickfixes, so no need to filter again. if (Math.abs(currPosition.column - col) < distance) { currentActions.unshift(...actionsAtMarker.validActions);

}); // Only retriggers if actually found quickfix on the same line as cursor <del> return { validActions: filteredActions, allActions: codeActionSet.allActions, documentation: codeActionSet.documentation, hasAutoFix: codeActionSet.hasAutoFix, dispose: () => { codeActionSet.dispose(); } }; </del> <ins> return { validActions: filteredActions, allActions: allCodeActions, documentation: codeActionSet.documentation, hasAutoFix: codeActionSet.hasAutoFix, dispose: () => { codeActionSet.dispose(); } }; </ins> } } }
Change:
I have created a vscode extension which uses the comment thread and the comment thread width is too small after the update. This was working fine in version 1.79, here's a screenshot of the bug. <img width="1259" alt="Screenshot 2023-11-09 at 8 51 25 AM" src=""
Why are you still on 1.81 when the current release is 1.84.1?
sorry,I meant 1.84.1 I typed incorrectly.
I'm not able to reproduce this. Are there any more steps you took to arrive in this state?
create a comment thread in ur extension as shown below.
use the below code to create a comment thread in ur extension, edit the code to give dummy comments instead of reading it from a file. make sure the comment thread is Collapsed and in Edit mode.
This is the key. I can repo.

Discussion:
this._commentEditContainer!.remove(); } <del> layout() { this._commentEditor?.layout({ width: this._commentEditor.getLayoutInfo().width, height: this._editorHeight }); </del> <ins> layout(widthInPixel?: number) { const editorWidth = widthInPixel !== undefined ? widthInPixel - 72 /* - margin and scrollbar*/ : (this._commentEditor?.getLayoutInfo().width ?? 0); this._commentEditor?.layout({ width: editorWidth, height: this._editorHeight }); </ins> const scrollWidth = this._body.scrollWidth; const width = dom.getContentWidth(this._body); const scrollHeight = this._body.scrollHeight;

return dom.getClientArea(this.container); } <del> layout() { </del> <ins> layout(widthInPixel?: number) { </ins> this._commentElements.forEach(element => { <del> element.layout(); </del> <ins> element.layout(widthInPixel); </ins> }); }

} layout(widthInPixel?: number) { <del> this._body.layout(); </del> <ins> this._body.layout(widthInPixel); </ins> if (widthInPixel !== undefined) { this._commentReply?.layout(widthInPixel);
Change:
Type: <bBug</b- Choose "View" -"Appearance" -"Tab bar" -"Single tab" Enter "Zen mode" You will see multiple tabs Right clicking the tab bar and selecting the options under "Tab Bar" have no effect You can get "un-stuck" here by: Exiting "Zen mode" Changing "Tab Bar" back to "Mutliple tabs" Enter "Zen mode" Right click the tab bar and select an option under "Tab Bar" VS Code version: Code 1.84.0 (Universal) (, 2023-11-01T11:30:19.406Z) OS version: Darwin arm64 22.1.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (23)</summaryExtensionVersion ------ Bookmarks13.4.2 vscode-tailwindcss0.10.3 vscode-eslint2.4.2 xml2.5.1 gitlens14.4.1 prettier-vscode10.1.0 godot-tools1.3.1 copilot1.134.0 copilot-chat0.8.0 vscode-pull-request-github0.76.0 gc-excelviewer4.2.58 vscode-drawio1.6.6 docomment1.0.0 rainbow-csv3.8.0 vscode-docker1.27.0 csharp2.9.20 vscode-dotnet-runtime2.0.0 mono-debug0.16.3 vsliveshare1.0.5892 vsliveshare-pack0.4.0 focus0.3.0 gdscript-toolkit-formatter1.2.3 code-spell-checker3.0.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.84.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Issue persists in 1.84.1
We have a separate setting for the tab bar in zen mode (). This is why when switching into zen mode you suddenly have multiple tabs. However, the "Tab Bar" menus should adapt to the zen mode settings when in that mode.
Thank you So the bug is that the menu options does not set when in zen mode?
Exactly, I'll fix that.
I had a closer look and realized that even if we make these submenus change the showTabs setting of the zen mode, they won't update right away in the UI. This is because zen mode setting changes only apply the next time you activate zen mode again. For the meantime I will hide the "Tab Bar" submenu when the user is in zen mode as it only leads to confusion.
! still seeing the "tab bar" submenu when I enter zen mode
You are right, Fix it in
<!-- UNABLETOLOCATECOMMITMESSAGE issue --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
verification steps: Zen Mode to that the submenu is not visible

Discussion:
submenu: MenuId.EditorTabsBarShowTabsSubmenu, title: localize('tabBar', "Tab Bar"), group: '3_workbench_layout_move', <del> order: 10 </del> <ins> order: 10, when: InEditorZenModeContext.negate() </ins> }); // --- Show Editor Actions in Title Bar
Change:
Type: <bBug</bObserved with a custom extension on a Clearcase SCM, but can be easily reproduced with SVN too, probably with any SCM that treats directories as versionable entities. How to reproduce: the SVN extension (I wish we could skip this step, but git does not version directories, so we can't reproduce with that) a svn repository a dir a file or more in that dir add dir svn repo in vscode, inspect the SCM view entities in List mode to tree mode Expected result: both the dir and the file are shown, preferably with the right badge; Actual result: dir children are omitted; Sample List mode SCM view: ! Sample Tree mode SCM view (same content of the repo): ! This is most likely a recent regression (possibly starting today's Insiders build, but I'm not 100% sure). VS Code version: Code - Insiders 1.85.0-insider (, 2023-11-10T05:35:29.445Z) OS version: WindowsNT x64 10.0. Modes: Remote OS version: Linux x64 4.18.0-372.19.1.el86.x8664 Remote OS version: Linux x64 4.4.0-64-generic <details<summarySystem Info</summary </details<details<summaryExtensions (4)</summaryExtensionVersion ------ remote-ssh0.108. remote-explorer0.5. rewrap17.8.0 svn-scm2.17.0 </details<!-- generated by issue reporter --
cc - Sorry for the ping, is it possible this was caused by the recent sticky scroll addition (great feature, btw)?
may be relevant so pinging
thank you very much for reporting this issue and will update the issue with my findings.
the fix for this will be included in Friday's Insiders release. I would really appreciate if you would download that tomorrow and confirm that the issue is resolved. Thanks again, and apologies for the inconveniences.
Hi, I saw the pending PR and that it just got merged, I will definitely test and confirm this asap. Thank you!
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified

Discussion:
// Resources (Tree) const children: TreeElement[] = []; for (const node of inputOrElement.resourceTree.root.children) { <del> children.push(node.element ?? node); </del> <ins> children.push(node.element && node.childrenCount === 0 ? node.element : node); </ins> } return children;

// Resources (Tree), History item changes (Tree) const children: TreeElement[] = []; for (const node of inputOrElement.children) { <del> children.push(node.element ?? node); </del> <ins> children.push(node.element && node.childrenCount === 0 ? node.element : node); </ins> } return children;
Change:
After ending a debug session the readonly code tab that was opened does not auto-close. This is frustrating, because I often start trying to edit this file without thinking, and of course I cannot.
If this issue is still valid, I'd love to work on it.
I would like to work on this bug as well
THis is still valid, feel free to give it a shot!
Great! I'll try then:)
I'll tried to fix it in this Let me know if there was any problem.
Completed in
I couldn't verify this--I enabled , debugged an extension, opened the file from the Loaded Scripts section (which is readonly), and the tab remained open after terminating my debug session. Are there other steps I should use?
Confirmed that enabling the setting doesn't resolve the issue on Windows.

Discussion:
if (this.configurationService.getValue<IDebugConfiguration>('debug').closeReadonlyTabsOnEnd) { const editorsToClose = this.editorService.getEditors(EditorsOrder.SEQUENTIAL).filter(({ editor }) => { <del> if (editor.resource?.scheme === DEBUG_SCHEME) { return editor.isReadonly() && session.getId() === Source.getEncodedDebugData(editor.resource).sessionId; } return false; </del> <ins> return editor.resource?.scheme === DEBUG_SCHEME && session.getId() === Source.getEncodedDebugData(editor.resource).sessionId; </ins> }); this.editorService.closeEditors(editorsToClose); }
Change:
Type: <bBug</ba git repository on a UNC path the folder in VS Code the repository as safe ! repositories will be shown instead of one. ! The issue is ephemeral and only one repo shows after reloading the window. ! VS Code version: Code 1.84.2 (, 2023-11-09T10:51:52.184Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (17)</summaryExtensionVersion ------ 2sxc0.0.1 vscode-tailwindcss0.10.3 dart-code3.76.1 flutter3.76.0 xml2.5.1 batch-rename-extension0.0.6 csdevkit1.0.14 csharp2.10.28 vscode-dotnet-runtime2.0.0 vscodeintellicode-csharp0.1.26 python2023.20.0 vscode-pylance2023.11.10 remote-ssh0.107.0 remote-ssh-edit0.86.0 remote-explorer0.4.1 sqltools0.28.0 postman-for-vscode0.13.1 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
are you able to reproduce the issue with the latest ? I went through the steps, but in my case only one repository is being shown. If you are able to reproduce with the latest VS Code Insiders release, could you please go through the steps up until the point where two repositories are shown and share the contents of ? Thanks!
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

Discussion:
// Use the repository real path const repoPathRealPath = await fs.promises.realpath(repoPath, { encoding: 'utf8' }); const openRepositoryRealPath = this.openRepositories <del> .find(r => pathEquals(r.repository.rootRealPath ?? '', repoPathRealPath)); </del> <ins> .find(r => pathEquals(r.repository.rootRealPath ?? r.repository.root, repoPathRealPath)); </ins> return openRepositoryRealPath?.repository; } catch (err) {
Change:
I found it confusing that the icon for opening multi-diff editor is a magnifying glass. Should it maybe match GHPR's icon or have some other icon? !
Fixed in , uses this icon now: ! FYI Maybe we should create a new icon for this though

Discussion:
{ "command": "git.timeline.openCommit", "title": "%command.timelineOpenCommit%", <del> "icon": "$(search)", </del> <ins> "icon": "$(tasklist)", </ins> "category": "Git" }, {

{ "command": "git.viewChanges", "title": "View Changes", <del> "icon": "$(search)", </del> <ins> "icon": "$(tasklist)", </ins> "category": "Git" }, { "command": "git.viewStagedChanges", "title": "View Staged Changes", <del> "icon": "$(search)", </del> <ins> "icon": "$(tasklist)", </ins> "category": "Git" } ],
Change:
Type: <bBug</bWhen Webview is open with , Codelenses become inactive (codelenses don't change color when hovered, nothing happens when codelense is clicked). To reproduce, launch extension sample: (This is a combination of webview-sample and codelens-sample from vscode-extension-samples) code lenses with the 'CodeLens Sample: Enable CodeLens' command empty file, type something in there and observe code lens shown and it, and that it active and works 'Cat Coding' webview with the 'CatCoding: Start cat coding session' command back to the file created in step 1 and observe that codelens doesn't work anymore. cat coding webview or move it into a second column, codelense begins to work. VS Code version: Code 1.84.2 (Universal) (, 2023-11-09T10:52:33.687Z) OS version: Darwin x64 23.0.0 Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (23)</summaryExtensionVersion ------ vscode-openapi4.18.6 prettier-vscode10.1.0 vscode-jest-runner0.4.69 go0.39.1 vscode-dotnet-runtime2.0.0 python2023.20.0 vscode-pylance2023.11.10 jupyter2023.10. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 azurerm-vscode-tools0.15.11 vscode-thunder-client2.16.0 java1.24.0 vscode-yaml1.14.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-java-debug0.55.0 vscode-java-dependency0.23.2 vscode-java-pack0.25.15 vscode-java-test0.40.1 vscode-maven0.43.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Hi ! Please let me know if you require any additional info. Also, I didn't mention it in the original report but I have tried it with extensions disabled and experienced the same issue.
Is there a logical conflict between WebView and CodeLens?
can I take this one or is someone else working on it?
any news on this?
BTW, it doesn't have to be a WebView open by an extension to cause this. I can open VS Code "Settings" pane, and while it's open, none of the CodeLenses are clickable.
This can be reproduced easily (I think all newer vscode versions are impacted ) P.S: all extensions are turned off !
Any update on this? We seen to be experiencing the same issue with our extension that adds custom CodeLenses to a new file type we're working on.
I have submitted a PR to fix this.

Discussion:
this._resolveCodeLensesPromise?.cancel(); this._resolveCodeLensesPromise = undefined; })); <del> this._localToDispose.add(this._editor.onDidFocusEditorWidget(() => { </del> <ins> this._localToDispose.add(this._editor.onDidFocusEditorText(() => { </ins> scheduler.schedule(); })); this._localToDispose.add(this._editor.onDidBlurEditorText(() => {
Change:
The editor sparkle shows unconditionally, e.g in any editor, like the extensions editor when a session is already active in the editor <img width="738" alt="Screenshot 2023-11-15 at 16 04 10" src=""

Discussion:
title: { value: LOCALIZED_START_INLINE_CHAT_STRING, original: 'Start Inline Chat' }, category: AbstractInlineChatAction.category, f1: true, <del> precondition: ContextKeyExpr.and(CTX_INLINE_CHAT_HAS_PROVIDER, EditorContextKeys.writable), </del> <ins> precondition: ContextKeyExpr.and(CTX_INLINE_CHAT_HAS_PROVIDER, CTX_INLINE_CHAT_VISIBLE.toNegated(), EditorContextKeys.focus), </ins> keybinding: { weight: KeybindingWeight.WorkbenchContrib, primary: KeyMod.CtrlCmd | KeyCode.KeyI,

icon: START_INLINE_CHAT, menu: [{ id: MenuId.EditorTitle, <del> when: ContextKeyExpr.and(CTX_INLINE_CHAT_HAS_PROVIDER, EditorContextKeys.writable), </del> <ins> when: ContextKeyExpr.and(CTX_INLINE_CHAT_HAS_PROVIDER, CTX_INLINE_CHAT_VISIBLE.toNegated(), EditorContextKeys.focus), </ins> group: 'navigation', order: -1000000, // at the very front }],
Change:
VS Code Version:OS Version: Windows 11 and Linux-Fedora-39 Steps to Reproduce: click a file or folder in explorer pane and select copy from context menu click where you want file/folder to be copied to in explorer pane and select paste from context menu. /folder is not copied.

Discussion:
}; async function getFilesToPaste(fileList: FileList | undefined, clipboardService: IClipboardService): Promise<readonly URI[]> { <del> if (fileList) { </del> <ins> if (fileList && fileList.length > 0) { </ins> // with a `fileList` we support natively pasting files from clipboard return [...fileList].filter(file => !!file.path && isAbsolute(file.path)).map(file => URI.file(file.path)); } else {
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --For Anonymous functions code lens is displayed although it has only one reference. This is a lot of noise for nothing. In my opinion these lenses can be removed completely.
This issue lacks name of the language/extensions that you are using/showing
You are right. My bad. I fixed it. Sorry.
Requires: -
I in those required settings and am seeing the screenshot below. Seems to now only say 0 references instead of one but the code lens still exists !
I think the screenshot shows the expected (fixed) behavior. Previously the references codelens was on the line with . There are zero references because there are no uses of that class or method
yep - this is exactly what I wanted.

Discussion:
switch (item.kind) { case PConst.Kind.function: { const showOnAllFunctions = vscode.workspace.getConfiguration(this.language.id).get<boolean>('referencesCodeLens.showOnAllFunctions'); <del> if (showOnAllFunctions) { </del> <ins> if (showOnAllFunctions && item.nameSpan) { </ins> return getSymbolRange(document, item); } }
Change:
I started seeing this error since yesterday, then remembered that I this setting trying to commit from scm view: ! saving the file which triggers : !

Discussion:
import { ExtensionIdentifier, IExtensionDescription } from 'vs/platform/extensions/common/extensions'; import { TelemetryTrustedValue } from 'vs/platform/telemetry/common/telemetryUtils'; import { IExtHostTelemetry } from 'vs/workbench/api/common/extHostTelemetry'; <ins> import { generateUuid } from 'vs/base/common/uuid'; </ins> interface CommandHandler { callback: Function;

export class CommandsConverter implements extHostTypeConverter.Command.ICommandsConverter { <del> readonly delegatingCommandId: string = `__vsc${Date.now().toString(36)} `; </del> <ins> readonly delegatingCommandId: string = `__vsc${generateUuid()}`; </ins> private readonly _cache = new Map<string, vscode.Command>(); private _cachIdPool = 0;
Change:
Steps to Reproduce: in VS Code, build and run as an extension the debugged VS Code version open a text file some text Rename from the context menu Observe: the rename dialog opens, however the method on the rename provider is never called. The return before however since no other rename provider is registered the provider should still be called according to discussions with

Discussion:
return res; } <ins> // we are here when no provider prepared a location which means we can // just rely on the word under cursor and start with the first provider this._providerRenameIdx = 0; </ins> const word = this.model.getWordAtPosition(this.position); if (!word) { return {
Change:
For a while now when I ran unit tests on Windows I see this: ! I figured this was running all of them and just one was failing locally for some reason. The problem was much worse as it seems to not run 8000+ tests without me realizing until it gets to CI. Commenting out the test fixes the problem and runs all the tests. It seems this issue is known based on the test content, but I guess it's not handled in all cases?

Discussion:
return await doCopySymlink(source, target, payload); } catch (error) { // in any case of an error fallback to normal copy via dereferencing <del> console.warn('[node.js fs] copy of symlink failed: ', error); </del> } }