jiebi/CodeConvo huggingface dataset:
Change:
VS Code Version: 1.52.1 Steps to Reproduce: !
at line number 20-23 syntax is wrong
That code runs correctly in PHP 8 ().
The syntax highlight is broken when you use an attribute and write code in the same line (method1) but also is incorrect when you write code in a param (method2) or you use line break (method3).
Noticed that this is better in the latest version of vscode, but they are missing tokens to be fully colored. Filed

Discussion:
"If you want to provide a fix or improvement, please create a pull request against the original repository.", "Once accepted there, we are happy to receive an update request." ], <del> "version": "https://github.com/atom/language-php/commit/72739e6341b1b4bf4aa185e928932983baca449e", </del> <ins> "version": "https://github.com/atom/language-php/commit/5fae657cf989701e9594912772daff33249839b3", </ins> "scopeName": "source.php", "patterns": [ {

] }, { <del> "match": "(?xi)n((?:(?:public|private|protected|static)(?:s+|(?=?)))+)                     # At least one modifiern(n  (?:?s*)? [a-z0-9_x{7f}-x{7fffffff}]+ |                                        # nullable typen  [a-z0-9_x{7f}-x{7fffffff}]+ (?: s*|s* [a-z0-9_x{7f}-x{7fffffff}]+)+ # union typen)?ns+ (($)[a-z_x{7f}-x{7fffffff}][a-z0-9_x{7f}-x{7fffffff}]*)          # Variable name", </del> <ins> "match": "(?xi)n((?:(?:public|private|protected|static)(?:s+|(?=?)))++)                     # At least one modifiern(n  (?:?s*)? [a-z0-9_x{7f}-x{7fffffff}]+ |                                        # nullable typen  [a-z0-9_x{7f}-x{7fffffff}]+ (?: s*|s* [a-z0-9_x{7f}-x{7fffffff}]+)+ # union typen)?ns+ (($)[a-z_x{7f}-x{7fffffff}][a-z0-9_x{7f}-x{7fffffff}]*)          # Variable name", </ins> "captures": { "1": { "patterns": [

"function-parameters": { "patterns": [ { <ins> "include": "#attribute" }, { </ins> "include": "#comments" }, {

"name": "keyword.operator.null-coalescing.php" } } <del> } </del>  No newline at end of file <ins> } </ins>
Change:
<!-- Do Not Delete This! bugreporttemplate --Issue Type: <bBug</bWhen trying to run with a markdown-code which contains a picture, a is thrown: My extension uses the vscode-parser for converting markdown-files to pdf, so my extension depends on the vscode-parser and needs it to work. Steps to Reproduce: a new extension to the -file following code to the extension: VS Code version: Code - Insiders 1.54.0-insider (, 2021-02-18T05:14:01.684Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (41)</summaryExtensionVersion ------ silverstripe1.0.6 ts-loader-problem-matcher0.3.0 markdown-emoji0.0.9 markdown-mermaid1.9.2 better-toml0.3.2 arm1.5.0 javascript-ejs-support1.3.1 vscode-reveal4.0.3 php-debug1.14.9 php-intellisense2.3.14 php-pack1.0.2 cshtml-tm1.0.0 coldfusion1.0.1 reg1.0.2 vscode-edit-csv0.5.4 vscode-peacock3.9.1 languague-renpy1.0.6 eslint-language-service1.0.8 rainbow-csv1.8.1 git-graph1.28.0 vscode-apache1.2.0 csharp1.23.9 remote-containers0.160.0 remote-ssh0.64.0 remote-ssh-edit0.64.0 remote-wsl0.54.0 vscode-remote-extensionpack0.20.0 hexeditor1.4.0 powershell2020.6.0 vscode-typescript-tslint-plugin1.3.3 vsliveshare1.0.3784 debugger-for-chrome4.12.12 php-docblocker2.1.0 material-icon-theme4.5.0 ejs-language-support0.0.1 ruby0.28.1 vscode-yaml0.15.0 vbsvscode1.2.0 vscodeintellicode1.2.11 vscode-ruby0.28.0 markdown-all-in-one3.4.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
We'd take a PR. However this looks specific to how your extension is using the markdown extension point in an unsupported way so this is not something we'll prioritize fixing
Thanks a lot for your rapid answer. I found myself able to refactor the package to make rendering work again out of the box. I'll open up a PR asap.
/verified

Discussion:
const src = token.attrGet('src'); if (src) { <del> env.containingImages.push({ src }); </del> <ins> env.containingImages?.push({ src }); </ins> const imgHash = hash(src); token.attrSet('id', `image-hash-${imgHash}`); }
Change:
Issue Type: Bug Steps to Reproduce: an empty document with language set to TypeScript this: To help follow, these are two words, the first is the three vertical bars, and the second is the three circles (btw this is Hebrew text, and these aren't real words) your cursor to the beginning - <kbdHome</kbdResult: Cursor is somewhere in the middle Expected: Cursor should be at the far right (before the first word) your cursor to the end of the first word - <kbdRight</kbd3 Result: Cursor is between the space and the second word Expected: Cursor should be between the space and the first word your cursor to the start of the second word - <kbdRight</kbdResult: Cursor is at the far left Expected: Cursor is between the space and the second word language to "Plain Text" and repeat these experiments, you will now get different cursor positions - WTF? The problem is specifically when the cursor is at the beginning of a syntax token, therefore the difference between document languages. VS Code version: Code - Insiders 1.54.0-insider (, 2021-02-19T05:14:28.632Z) OS version: Windows_NT x64 10.0. Does this issue occur when all extensions are disabled?: Yes More weirdness: Select the space: <kbdHome</kbd3<kbdRight</kbd<kbdShift+Right</kbd- Select the space from the other side: <kbdHome</kbd4<kbdRight</kbd<kbdShift+Left</kbd- Select the space and the first word: <kbdHome</kbd4<kbdRight</kbd<kbdShift+Home</kbd

Discussion:
startChildIndex = Math.min(max, Math.max(min, startChildIndex)); endChildIndex = Math.min(max, Math.max(min, endChildIndex)); <del> if (startChildIndex === endChildIndex && startOffset === endOffset && startOffset === 0) { </del> <ins> if (startChildIndex === endChildIndex && startOffset === endOffset && startOffset === 0 && !domNode.children[startChildIndex].firstChild) { </ins> // We must find the position at the beginning of a <span> <del> // To cover cases of empty <span>s, aboid using a range and use the <span>'s bounding box </del> <ins> // To cover cases of empty <span>s, avoid using a range and use the <span>'s bounding box </ins> const clientRects = domNode.children[startChildIndex].getClientRects(); return this._createHorizontalRangesFromClientRects(clientRects, clientRectDeltaLeft); }
Change:
Testing We don't show the provider in the list of extensions that want to sign in: ! In this case, test117290 wants to sign in using the provider and the others I assume want to sign in using GitHub. It would be good to know what I am signing into.
or maybe "sign in with <<< provider " to use ...
Verification steps: Install GHPR extension See: ! Install GitHub Codespaces extension ("Cancel" any modals) Reload VS Code Once GitHub Codespaces activates you should see: !

Discussion:
id: `${providerId}${extensionId}Access`, title: nls.localize({ key: 'accessRequest', <del> comment: ['The placeholder {0} will be replaced with an extension name. (1) is to indicate that this menu item contributes to a badge count'] </del> <ins> comment: [`The placeholder {0} will be replaced with an authentication provider''s label. {1} will be replaced with an extension name. (1) is to indicate that this menu item contributes to a badge count`] </ins> }, <del> "Grant access to {0}... (1)", extensionName) </del> <ins> "Grant access to {0} for {1}... (1)", this.getLabel(providerId), extensionName) </ins> } });

group: '2_signInRequests', command: { id: `${extensionId}signIn`, <del> title: nls.localize( { key: 'signInRequest', comment: ['The placeholder {0} will be replaced with an extension name. (1) is to indicate that this menu item contributes to a badge count.'] }, "Sign in to use {0} (1)", </del> <ins> title: nls.localize({ key: 'signInRequest', comment: [`The placeholder {0} will be replaced with an authentication provider's label. {1} will be replaced with an extension name. (1) is to indicate that this menu item contributes to a badge count.`] }, "Sign in with {0} to use {1} (1)", provider.label, </ins> extensionName) } });
Change:
Testing an html file, try triggering emmet Bug According to , I should see an error notification. However I don't see any error or notifications
I also don't see error for an invalid (if it isn't valid json for example)
Also get no errors in Linux.
+1 WSL
The reason seems like to be on the which has not be loaded when the extension first activate.
And the should be an error object instead of a string.
closedWith
I'll reopen the issue because I think the error handling changed afterwards, and I'd like to look into the implementation again during a later iteration.

Discussion:
export function activateEmmetExtension(context: vscode.ExtensionContext) { registerCompletionProviders(context); <ins> updateEmmetExtensionsPath(); </ins> context.subscriptions.push(vscode.commands.registerCommand('editor.emmet.action.wrapWithAbbreviation', (args) => { wrapWithAbbreviation(args);

vscode.commands.executeCommand('workbench.action.quickOpen', '>Emmet: '); })); <del> updateEmmetExtensionsPath(); </del> context.subscriptions.push(vscode.workspace.onDidChangeConfiguration((e) => { if (e.affectsConfiguration('emmet.includeLanguages')) { registerCompletionProviders(context);

if (!_emmetHelper) { _emmetHelper = require('vscode-emmet-helper'); } <del> updateEmmetExtensionsPath(); </del> return _emmetHelper; }

* Update Emmet Helper to use user snippets from the extensionsPath setting */ export function updateEmmetExtensionsPath(forceRefresh: boolean = false) { <del> if (!_emmetHelper) { return; } </del> <ins> const helper = getEmmetHelper(); </ins> let extensionsPath = vscode.workspace.getConfiguration('emmet')['extensionsPath']; if (forceRefresh || _currentExtensionsPath !== extensionsPath) { _currentExtensionsPath = extensionsPath;

} else { const rootPath = vscode.workspace.workspaceFolders[0].uri; const fileSystem = vscode.workspace.fs; <del> _emmetHelper.updateExtensionsPath(extensionsPath, fileSystem, rootPath, _homeDir).then(null, (err: string) => vscode.window.showErrorMessage(err)); </del> <ins> helper.updateExtensionsPath(extensionsPath, fileSystem, rootPath, _homeDir).catch(err => vscode.window.showErrorMessage(err.message)); </ins> } } }
Change:
Testing Bug Currently the setting can only be configured by editing the file. It would be nice if you could configure it using our settings UI as well
It'd make sense to me to deprecate the string/null potential values in favor of an array of strings. You could declare the settings as (which settings editor can handle, see ), then transform existing 's to the empty array and existing single string values to .

Discussion:
"description": "%emmetExclude%" }, "emmet.extensionsPath": { <del> "type": [ "string", "array", "null" ], "default": null, </del> <ins> "type": "array", "items": { "type": "string" }, "default": [], </ins> "description": "%emmetExtensionsPath%" }, "emmet.triggerExpansionOnTab": {

import { fetchSelectItem } from './selectItem'; import { evaluateMathExpression } from './evaluateMathExpression'; import { incrementDecrement } from './incrementDecrement'; <del> import { LANGUAGE_MODES, getMappingForIncludedLanguages, updateEmmetExtensionsPath, getPathBaseName, getSyntaxes, getEmmetMode } from './util'; </del> <ins> import { LANGUAGE_MODES, getMappingForIncludedLanguages, updateEmmetExtensionsPath, migrateEmmetExtensionsPath, getPathBaseName, getSyntaxes, getEmmetMode } from './util'; </ins> import { reflectCssValue } from './reflectCssValue'; import { addFileToParseCache, removeFileFromParseCache } from './parseDocument'; export function activateEmmetExtension(context: vscode.ExtensionContext) { <ins> migrateEmmetExtensionsPath(); </ins> registerCompletionProviders(context); updateEmmetExtensionsPath();

} /** <ins> * Migrate old configuration(string) for extensionsPath to new type(string[]) * https://github.com/microsoft/vscode/issues/117517 */ export function migrateEmmetExtensionsPath() { // Get the detail info of emmet.extensionsPath setting let config = vscode.workspace.getConfiguration().inspect('emmet.extensionsPath'); // Update Global setting if the value type is string or the value is null if (typeof config?.globalValue === 'string') { vscode.workspace.getConfiguration().update('emmet.extensionsPath', [config.globalValue], true); } else if (config?.globalValue === null) { vscode.workspace.getConfiguration().update('emmet.extensionsPath', [], true); } // Update Workspace setting if the value type is string or the value is null if (typeof config?.workspaceValue === 'string') { vscode.workspace.getConfiguration().update('emmet.extensionsPath', [config.workspaceValue], false); } else if (config?.workspaceValue === null) { vscode.workspace.getConfiguration().update('emmet.extensionsPath', [], false); } // Update WorkspaceFolder setting if the value type is string or the value is null if (typeof config?.workspaceFolderValue === 'string') { vscode.workspace.getConfiguration().update('emmet.extensionsPath', [config.workspaceFolderValue]); } else if (config?.workspaceFolderValue === null) { vscode.workspace.getConfiguration().update('emmet.extensionsPath', []); } } /** </ins> * Mapping between languages that support Emmet and completion trigger characters */ export const LANGUAGE_MODES: { [id: string]: string[] } = {
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --You can localise many aspects of , including config, but you cannot localise the options in an enum dropdown - you can but your extension will get the translated value. I think these should be translated, but the value the extension gets should be a fixed value no matter what langauge is enabled in the GUI. Currently I now have to keep the dropdown values in english and add enumDescriptions for each label explaining what those mean in other languages. Can you add an enumLabels array to the enum configuration and use that for labels within the dropdown and use the enum array just for the values that a develop gets when accessing settings? Currently the enum array is used as both label and value.
You can use to explain about your enums and also translated. See how we use it at other places:
I already use this, but it is not a very good solution. It should be possible to localise what users see in the dropdown. Why can everything else be localised but not the dropdowns? I wrote in my post that I already use enumDescriptions
I see, thanks for clarification. We already have to use internally for Settings editor. Can this be extended to json language server so that user can see the labels in the file and also in the settings editor?
Do you mean to also use the in the JSON editor? Can you make an example of what should be seen there? IMO the labels seen in code complete should always correspond to the text that is typed.
I see, makes sense and let's make it Settings Editor only feature and JSON shows the ids.
What is the current progress of this issue?
It turns out already exists, but we never exposed it to the user. See in the Settings editor for an example of a setting that uses it.

Discussion:
}, description: nls.localize('scope.markdownEnumDescriptions', 'Descriptions for enum values in the markdown format.') }, <ins> enumItemLabels: { type: 'array', items: { type: 'string' }, markdownDescription: nls.localize('scope.enumItemLabels', 'Labels for enum values to be displayed in the Settings editor. When specified, the {0} values still show after the labels, but less prominently.', '`enum`') }, </ins> markdownDescription: { type: 'string', description: nls.localize('scope.markdownDescription', 'The description in the markdown format.')
Change:
Issue Type: <bBug says of the optional property: I'm finding that this doesn't happen. To reproduce: the source-control-sample folder, build it () and run it () to SCM view and see that the (0) badge appears on the provider line (JSFiddle #demo) one of the demo documents, save the change, and confirm that the (1) badge appears on the Changes group and on the provider. the Extension Development Host window. the extension sample source, and comment out this line: the test again. :bug: the provider line count remains zero even when a change is made to a demo file. This is not a 1.54 regression; it also exists in 1.53 VS Code version: Code - Insiders 1.54.0-insider (, 2021-02-26T05:13:29.656Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
I think we should probably just update the docs here to say that the SCM control determines the count. thoughts?
So how about using this wording in Would you like a PR from me?
I think this is a quick win in the current issue grooming iteration because I have already submitted a PR to fix it in documentation. Please consider merging it.
thanks for the nudge. Merged!
/verified Confirmed change present in main. Won't appear in online doc at until 1.62 ships.

Discussion:
* The UI-visible count of {@link SourceControlResourceState resource states} of * this source control. * <del> * Equals to the total number of {@link SourceControlResourceState resource state} * of this source control, if undefined. </del> <ins> * If undefined, this source control will * - display its UI-visible count as zero, and * - contribute the count of its {@link SourceControlResourceState resource states} to the UI-visible aggregated count for all source controls </ins> */ count?: number;
Change:
Companion of For the TS: The lightbulb is always shown inside of
The expected behavior is that you now have to go through the refactor menu to trigger this

Discussion:
return undefined; } <del> const actions = this.convertApplicableRefactors(response.body, document, rangeOrSelection); </del> <ins> const actions = this.convertApplicableRefactors(response.body, document, rangeOrSelection).filter(action => { // Don't show 'infer return type' refactoring unless it has been explicitly requested // https://github.com/microsoft/TypeScript/issues/42993 if (!context.only && action.kind?.value === 'refactor.rewrite.function.returnType') { return false; } return true; }); </ins> if (!context.only) { return actions; }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: OS Version: macOS Big Sur (Version ) Steps to Reproduce: an extension's page from the Extensions view. For example, this is what the extension README looks like: <img width="1193" alt="Screen Shot 2021-02-27 at 2 07 49 PM" src="https://user-"The attribute of the image is 200, however, the real width of the image is larger, and it seems that the real width is used rather than the attribute. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
/verified

Discussion:
allowedAttributes: { '*': [ 'align', <del> ] </del> <ins> ], img: ['src', 'alt', 'title', 'aria-label', 'width', 'height'], </ins> }, filter(token: { tag: string, attrs: { readonly [key: string]: string } }): boolean { return token.tag !== 'svg';
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --The context menu on the Source Control view has a whole section for "Branch" which contains most things you'd want to do except it does not contain "Delete Branch..." ! This seems like a strange omission when the opposite ("Create Branch...") is there and the capability to do a branch delete is available from the action bar: ! Please add "Delete Branch..." to this menu.
Good call!
I'll try to work on this issue. is it still up?
Added the Submenu Item in the linked pull request.
Hello, I am a new member of this community. I am trying to begin with this bug. Can you help me and tell me from where to begin please? Which file to look for?
I've already submitted a fix for this issue.
To Verify: Make sure Delete Branch... shows up in the context menu below !

Discussion:
ariaLabel: `${ariaLabel}${command.tooltip ? ` - ${command.tooltip}` : ''}`, tooltip, command: command.id ? command : undefined <del> }, 'status.scm', localize('status.scm', "Sourece Control"), MainThreadStatusBarAlignment.LEFT, 10000)); </del> <ins> }, 'status.scm', localize('status.scm', "Source Control"), MainThreadStatusBarAlignment.LEFT, 10000)); </ins> } this.statusBarDisposable = disposables;
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.55.0-insider Steps to Reproduce: all the actions in the 2 getting started tiles all items are complete, go back and try opening them again. Unable to reopen them once complete. ! <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
Good catch thanks!

Discussion:
const progressAmount = assertIsDefined(progress.querySelector('.progress-bar-inner') as HTMLDivElement).style.width; if (!toFocus && progressAmount !== '100%') { toFocus = assertIsDefined(progress.parentElement?.parentElement); } }); <del> (toFocus ?? assertIsDefined(this.container.querySelector('button.skip')) as HTMLButtonElement).focus(); </del> <ins> (toFocus ?? assertIsDefined(this.container.querySelector('button.getting-started-category')) as HTMLButtonElement)?.focus(); </ins> } private setSlide(toEnable: 'details' | 'categories') {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --Version: 1.54.1 Commit: Date: 2021-03-04T22:42:18.719Z Electron: 11.3.0 Chrome: 87.0.4280.141 12.18.3 V8: 8.7.220.31-electron.0 OS: Darwin x64 20.3.0 Steps to Reproduce: multiple editor groups Command Pallette "View: Join all editor groups" enter I expect that the editors groups would be joined into a single editor group. But nothing happens. If I use an alternative command "View: Join editor group with Next Group" it works as expected, joining the current editor with the next group. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.517 --- <!-- score: 0.463 --- <!-- score: 0.461 --<!-- potentialduplicatescomment --
Same here.

Discussion:
const target = editorGroupService.activeGroup; for (const group of editorGroupService.getGroups(GroupsOrder.MOST_RECENTLY_ACTIVE)) { if (group === target) { <del> return; // keep target </del> <ins> continue; // keep target </ins> } editorGroupService.mergeGroup(group, target);