jiebi/CodeConvo huggingface dataset:
Change:
Originally posted by in This was mostly an oversight on my part.
Fixed in In the (Configure Runtime Arguments) we have two improvements: both and now show up in completions (they no longer say "not allowed") in is plumbed through properly
Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.
verification: run: make sure and show up in completions make sure you are currently logged in to any account and have an extension that asks for auth now set to restart VS Code you should be asked to log in because you are now using the inmemory store remote the setting from your now restart VS Code you should be logged in again because you are no longer using the inmemory store
Sorry the completion should only be seen on Linux

Discussion:
'disable-hardware-acceleration', // override for the color profile to use <del> 'force-color-profile', // override which password-store is used 'password-store' </del> <ins> 'force-color-profile' </ins> ]; if (process.platform === 'linux') { // Force enable screen readers on Linux via this flag SUPPORTED_ELECTRON_SWITCHES.push('force-renderer-accessibility'); <ins> // override which password-store is used on Linux SUPPORTED_ELECTRON_SWITCHES.push('password-store'); </ins> } const SUPPORTED_MAIN_PROCESS_SWITCHES = [

'enable-proposed-api', // Log level to use. Default is 'info'. Allowed values are 'error', 'warn', 'info', 'debug', 'trace', 'off'. <del> 'log-level' </del> <ins> 'log-level', // Use an in-memory storage for secrets 'use-inmemory-secretstorage' </ins> ]; // Read argv config

} } break; <ins> case 'use-inmemory-secretstorage': if (argvValue) { process.argv.push('--use-inmemory-secretstorage'); } break; </ins> } } });

'disable-chromium-sandbox': { type: 'boolean', description: localize('argv.disableChromiumSandbox', "Disables the Chromium sandbox. This is useful when running VS Code as elevated on Linux and running under Applocker on Windows.") <ins> }, 'use-inmemory-secretstorage': { type: 'boolean', description: localize('argv.useInMemorySecretStorage', "Ensures that an in-memory store will be used for secret storage instead of using the OS's credential store. This is often used when running VS Code extension tests or when you're experiencing difficulties with the credential store.") </ins> } } };

type: 'boolean', description: localize('argv.force-renderer-accessibility', 'Forces the renderer to be accessible. ONLY change this if you are using a screen reader on Linux. On other platforms the renderer will automatically be accessible. This flag is automatically set if you have editor.accessibilitySupport: on.'), }; <ins> schema.properties!['password-store'] = { type: 'string', description: localize('argv.passwordStore', "Configures the backend used to store secrets on Linux. This argument is ignored on Windows & macOS.") }; </ins> } jsonRegistry.registerSchema(argvDefinitionFileSchemaId, schema);
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.83.0 OS Version: Kubuntu 23.04 Steps to Reproduce: a new extension the following code to this test extension and go to settings page could not be displayed I found this problem when using mxp131011.element-plus-doc v2.0.8. Installing this extension should also reproduce. ! (This extension has been enabled globally. () is not visible) ! (This extension has been disabled globally) Previous versions of vscode don't seem to report errors for this kind of regular expression, which appeared in version 1.83.0. I have created an issue to that extension (mxp131011/element-plus-doc). But I think this error should be caught early, or at least should not interrupt the configurations of other extensions
It looks like now installs fine and the Settings Editor works.

Discussion:
return true; } <ins> function toRegExp(pattern: string): RegExp { try { // The u flag allows support for better Unicode matching, // but deprecates some patterns such as [s-9] // Ref https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Regular_expressions/Character_class#description return new RegExp(pattern, 'u'); } catch (e) { try { return new RegExp(pattern); } catch (e) { // If the pattern can't be parsed even without the 'u' flag, // just log the error to avoid rendering the entire Settings editor blank. // Ref https://github.com/microsoft/vscode/issues/195054 console.error(nls.localize('regexParsingError', "Error parsing the following regex both with and without the u flag:"), pattern); return /.*/; } } } </ins> function getStringValidators(prop: IConfigurationPropertySchema) { const uriRegex = /^(([^:/?#]+?):)?(//([^/?#]*))?([^?#]*)(?([^#]*))?(#(.*))?/; let patternRegex: RegExp | undefined; if (typeof prop.pattern === 'string') { <del> patternRegex = new RegExp(prop.pattern, 'u'); </del> <ins> patternRegex = toRegExp(prop.pattern); </ins> } return [

} if (typeof propItems.pattern === 'string') { <del> const patternRegex = new RegExp(propItems.pattern, 'u'); </del> <ins> const patternRegex = toRegExp(propItems.pattern); </ins> arrayValue.forEach(v => { if (!patternRegex.test(v)) { message +=
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.83.0 OS Version: macOS Sonoma(14.0) Steps to Reproduce: the color theme to high contrast any theme to extension search (I have attached a picture below which you will see there) will see no border-right edge of the install button !
I'll start trying to fix this weird border-right

Discussion:
margin-left: 6px; } <del> .extension-list-item .monaco-action-bar > .actions-container > .action-item.action-dropdown-item > .extension-action.label { </del> <ins> .extension-list-item .monaco-action-bar > .actions-container > .action-item.action-dropdown-item:not(.empty) > .extension-action.label { </ins> border-right-width: 0; }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: MacOS A case where specific lint/styling quick fixes are still below. Could be something to do with warnings vs actual fixes. Not sure if this is intentional or not, but in cases where it is wrapped by quick fixes above and below, it does seem a little weird. Example: ! Warning for missing semicolon according to linter, activate quickfix: <img width="789" alt="Screenshot 2023-10-10 at 2 26 38 PM" src=""Other warnings with direct fixes is okay: <img width="772" alt="Screenshot 2023-10-10 at 2 29 56 PM" src=""
related to
Hi the reason this is the case is likely because of this part of the code: The code actions you mentioned that appear below the Copilot actions have an empty field, hence they are placed below the copilot ones. You can see this in the image below where the Copilot actions have associated diagnostics, the eslint one does not. <img width="691" alt="Screenshot 2023-10-11 at 09 19 55" src=""<img width="673" alt="Screenshot 2023-10-11 at 09 20 59" src=""I am wondering if we want the Copilot diagnostics to appear at the very bottom of this list? Thoughts
I suggest we have the ai code actions appear always at the end. So, first criteria: isAI, second criteria whether it has diagnostics attached. Ok for you?

Discussion:
class ManagedCodeActionSet extends Disposable implements CodeActionSet { private static codeActionsPreferredComparator(a: languages.CodeAction, b: languages.CodeAction): number { <del> if (a.isAI && !b.isAI) { return 1; } else if (!a.isAI && b.isAI) { return -1; } else if (a.isPreferred && !b.isPreferred) { </del> <ins> if (a.isPreferred && !b.isPreferred) { </ins> return -1; } else if (!a.isPreferred && b.isPreferred) { return 1;

} private static codeActionsComparator({ action: a }: CodeActionItem, { action: b }: CodeActionItem): number { <ins> if (a.isAI && !b.isAI) { return 1; } else if (!a.isAI && b.isAI) { return -1; } </ins> if (isNonEmptyArray(a.diagnostics)) { return isNonEmptyArray(b.diagnostics) ? ManagedCodeActionSet.codeActionsPreferredComparator(a, b) : -1; } else if (isNonEmptyArray(b.diagnostics)) {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. -- It seems the cell heights are not updated properly when clearing outputs of cells that are not visible.
I had trouble reproing the original issue, but I also can't repro in insiders so marking verified.

Discussion:
DOM.hide(this.templateData.outputShowMoreContainer.domNode); } <del> const editorHeight = this.templateData.editor.getContentHeight(); this.viewCell.editorHeight = editorHeight; </del> this._relayoutCell(); // if it's clearing all outputs, or outputs are all rendered synchronously // shrink immediately as the final output height will be zero.
Change:
cc and got some feedback that it could be useful to alert when a completion is accepted. I can imagine why this would be helpful, but also, the user has taken the action and knows what the completion is, so wonder if this would just add noise.
IMO, this is not necessary b/c users take the accept gesture; thus, the event result is very obvious.
Agree, it's also clear because the user's focus is in the editor right where the suggestion was inserted.
Will wait for more feedback, but seems likely we'll close this.
I agree, however that announcement is currently present if I accept a suggestion from the accessible view. I wonder if it should be removed there for consistency. There is a change of context that happens because the accessible view closes and focus goes to the editor, which I believe serves as a confirmation.
it seems like I should verify that a screen reader alert does not happen when accepting a completion in the "accessible view". Which accessible view is this?
Correct, the inline completions accessible view, so trigger an inline completion, then use alt+f2

Discussion:
import { IAccessibleViewService } from 'vs/workbench/contrib/accessibility/browser/accessibleView'; import { ICodeEditorService } from 'vs/editor/browser/services/codeEditorService'; import { InlineCompletionsController } from 'vs/editor/contrib/inlineCompletions/browser/inlineCompletionsController'; <del> import { alert } from 'vs/base/browser/ui/aria/aria'; </del> const accessibleViewMenu = { id: MenuId.AccessibleView,

return; } await model.accept(editor); <del> alert('Accepted'); </del> model.stop(); editor.focus(); }
Change:
Type: <bBug</ba funtion name in fileA. the the fileA variable and use "." operator for suggention then paste the copied funtion name. Expected: the suggestion should disapper when I click enter. Actual: it's not disappearing. I have to close the tab and reopen the file. VS Code version: Code 1.83.0 (, 2023-10-03T16:12:16.321Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (27)</summaryExtensionVersion ------ project-manager12.7.0 cucumberautocomplete2.15.2 aws-toolkit-vscode1.93.0 folder-source-actions0.2.1 gitignore0.9.0 vscode-deno3.26.0 git-extension-pack0.1.3 githistory0.6.20 gitlens14.3.0 vscode-great-icons2.1.102 vsc-material-theme33.10.5 vsc-material-theme-icons3.1.4 vs-code-xml-format0.1.5 vscode-pull-request-github0.74.0 open-in-browser1.0.2 csharp2.6.24 vscode-dotnet-runtime1.8.1 python2023.18.0 vscode-pylance2023.10.20 remote-wsl0.81.8 powershell2023.8.0 open-in-gitup1.0.0 LiveServer5.7.9 es7-react-js-snippets1.9.3 sonarlint-vscode3.22.0 code-spell-checker3.0.1 vscode-open-in-github1.3.6 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.83.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Better workaround: press

Discussion:
if (index === -1) { index = 0; } <ins> if (this.model.state === State.Idle) { // selecting an item can "pump" out selection/cursor change events // which can cancel suggest halfway through this function. therefore // we need to check again and bail if the session has been canceled return; } </ins> let noFocus = false; if (e.triggerOptions.auto) { // don't "focus" item when configured to do
Change:
Repro: copilot chat in terminal /cmd+. click the action It hides when clicked, enter works though
This only happens sometimes, not sure on exact case

Discussion:
updateLayout(this._configurationService, e); this._audioCueService.playAudioCue(AudioCue.terminalQuickFix); <del> const parentElement = e.closest('.xterm') as HTMLElement; </del> <ins> const parentElement = (e.closest('.xterm') as HTMLElement).parentElement; </ins> if (!parentElement) { return; }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.83.1 OS Version: Windows 10 Steps to Reproduce: The "editorGutter" element in the editor has disappeared, and the corresponding colors for Git changes cannot be displayed. normal: ! ! wrong: !
Do you have any settings related to gutters that you've modified?
No, I haven’t modified any related settings. And after suspecting it was a git issue, I’ve upgraded git to the latest version, but the problem still hasn’t been resolved.
I found a stable way to reproduce the problem: Step: 1Open a file 2Click " Ctrl +  " 3Close the split
do you mind taking an initial look at this? Thanks!
thanks for the repro steps!

Discussion:
for (const [uri, item] of this.items) { for (const editorId of item.keys()) { if (!this.editorService.visibleTextEditorControls.find(editor => isCodeEditor(editor) && editor.getModel()?.uri.toString() === uri.toString() && editor.getId() === editorId)) { <del> dispose(item.values()); this.items.delete(uri); </del> <ins> if (item.has(editorId)) { const dirtyDiffItem = item.get(editorId); dirtyDiffItem?.dispose(); item.delete(editorId); if (item.size === 0) { this.items.delete(uri); } } </ins> } } }
Change:
Steps: enable one of the HC themes <img width="787" alt="image" src=""I would have expected the turquoise color as border around the command center. I think that one is . //cc

Discussion:
); // border: active and inactive. defaults to active background export const COMMAND_CENTER_BORDER = registerColor( <del> 'commandCenter.border', { dark: transparent(TITLE_BAR_ACTIVE_FOREGROUND, .20), hcDark: transparent(TITLE_BAR_ACTIVE_FOREGROUND, .60), light: transparent(TITLE_BAR_ACTIVE_FOREGROUND, .20), hcLight: transparent(TITLE_BAR_ACTIVE_FOREGROUND, .60) }, </del> <ins> 'commandCenter.border', { dark: transparent(TITLE_BAR_ACTIVE_FOREGROUND, .20), hcDark: contrastBorder, light: transparent(TITLE_BAR_ACTIVE_FOREGROUND, .20), hcLight: contrastBorder }, </ins> localize('commandCenter-border', "Border color of the command center"), false );
Change:
a cell that will produce an error a link in the stack trace sometimes focus is not correctly given to the cell !

Discussion:
return; } <ins> let outputFocus: { id: string } | undefined = undefined; </ins> for (const node of event.composedPath()) { if (node instanceof HTMLElement && node.classList.contains('output')) { <del> // output postNotebookMessage<webviewMessages.IOutputFocusMessage>('outputFocus', { id: node.id, }); </del> <ins> outputFocus = { id: node.id }; </ins> break; } }

for (const node of event.composedPath()) { if (node instanceof HTMLAnchorElement && node.href) { if (node.href.startsWith('blob:')) { <ins> if (outputFocus) { postNotebookMessage<webviewMessages.IOutputFocusMessage>('outputFocus', outputFocus); } </ins> handleBlobUrlClick(node.href, node.download); } else if (node.href.startsWith('data:')) { <ins> if (outputFocus) { postNotebookMessage<webviewMessages.IOutputFocusMessage>('outputFocus', outputFocus); } </ins> handleDataUrl(node.href, node.download); } else if (node.getAttribute('href')?.trim().startsWith('#')) { // Scrolling to location within current doc

} else { const href = node.getAttribute('href'); if (href) { <ins> if (href.startsWith('command:') && outputFocus) { postNotebookMessage<webviewMessages.IOutputFocusMessage>('outputFocus', outputFocus); } </ins> postNotebookMessage<webviewMessages.IClickedLinkMessage>('clicked-link', { href }); } }

return; } } <ins> if (outputFocus) { postNotebookMessage<webviewMessages.IOutputFocusMessage>('outputFocus', outputFocus); } </ins> }; const handleDataUrl = async (data: string | ArrayBuffer | null, downloadName: string) => {
Change:
Reproduction steps: to the extension panel and search some extensions which have contribution points. outliers displayed: ! Version: 1.83.1 Commit: User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X ) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/117.0.0.0 Safari/537.36 Embedder: <!-- generated by web issue reporter --

Discussion:
return $('tr', undefined, $('td', undefined, $('code', undefined, key)), $('td', undefined, description), <del> $('td', undefined, $('code', undefined, `${isUndefined(properties[key].default) ? getDefaultValue(properties[key].type) : properties[key].default}`))); </del> <ins> $('td', undefined, $('code', undefined, `${isUndefined(properties[key].default) ? getDefaultValue(properties[key].type) : JSON.stringify(properties[key].default)}`))); </ins> }) ) );
Change:
! ! : 1.84.0-insider (user setup) : : 2023-10-19T05:34:47.214Z Electron: 25.9.1 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows_NT x64 10.0.

Discussion:
margin: 0 0 8px 0; } <ins> .interactive-item-container .interactive-result-code-block .monaco-toolbar .monaco-action-bar .actions-container { padding-inline-start: unset; } </ins> .interactive-response .interactive-response-error-details { display: flex;
Change:
Enable screen reader mode or use preview mode Create a code error Invoke inline chat and use The response doesn't get shown in the diff editor and sometimes doesn't come back at all. The console shows the error below
I see:
Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our . Please take the time to review these and update the issue. Happy Coding!
screen reader mode a code error inline that and use /fix response doesn't get shown in the diff editor and sometimes doesn't come back at all.
Maybe related

Discussion:
let done = false; const progress: vscode.Progress<vscode.InteractiveEditorProgressItem> = { report: async value => { <del> if (!request.live) { </del> <ins> if (!request.live && value.edits?.length) { </ins> throw new Error('Progress reporting is only supported for live sessions'); } if (done || token.isCancellationRequested) {

async showEditsPreview(textModel0: ITextModel, textModelN: ITextModel, allEdits: ISingleEditOperation[][]) { <del> const diff = await this._editorWorkerService.computeDiff(textModel0.uri, textModelN.uri, { ignoreTrimWhitespace: false, maxComputationTimeMs: 5000, computeMoves: false }, 'advanced'); if (!diff || diff.changes.length === 0) { this.hideEditsPreview(); return; } </del> this._elements.previewDiff.classList.remove('hidden'); const languageSelection: ILanguageSelection = { languageId: textModel0.getLanguageId(), onDidChange: Event.None };

for (const edits of allEdits) { modified.applyEdits(edits, false); } <ins> const diff = await this._editorWorkerService.computeDiff(textModel0.uri, modified.uri, { ignoreTrimWhitespace: false, maxComputationTimeMs: 5000, computeMoves: false }, 'advanced'); if (!diff || diff.changes.length === 0) { this.hideEditsPreview(); return; } </ins> this._previewDiffEditor.value.setModel({ original: textModel0, modified }); // joined ranges