jiebi/CodeConvo huggingface dataset:
Change:
I wonder if we should not overlay here: ! My understanding is that this is the only place where we show the profile icon but then its always overlayed with the gear which is quite large. I think people can make the connection that the location of the button is for settings.
I tend to agree that the overlay is superfluous, but is an underlay possible as an alternative to be tried?
We are trying to come up with a smaller gear icon for overlay ! ! I am preferring to have gear overlay icon to indicate it is for settings, this will be helpful when there are duplicates like extensions profile icon.
I am thinking to undo the overlay until we have better overlay icon.
At present we do not overlay and show the profile icon as is. Hence closing this.

Discussion:
import { runWhenIdle } from 'vs/base/common/async'; import { Lazy } from 'vs/base/common/lazy'; import { DEFAULT_ICON } from 'vs/workbench/services/userDataProfile/common/userDataProfileIcons'; <del> import { ThemeIcon } from 'vs/base/common/themables'; </del> export class ViewContainerActivityAction extends ActivityAction {

return; } <del> if (this.userDataProfileService.currentProfile.icon && this.userDataProfileService.currentProfile.icon !== DEFAULT_ICON.id) { this.profileBadgeContent.classList.toggle('profile-icon-overlay', true); this.profileBadgeContent.classList.toggle('profile-text-overlay', false); append(this.profileBadgeContent, $(ThemeIcon.asCSSSelector(DEFAULT_ICON))); } else { </del> <ins> if (!this.userDataProfileService.currentProfile.icon || this.userDataProfileService.currentProfile.icon === DEFAULT_ICON.id) { </ins> this.profileBadgeContent.classList.toggle('profile-text-overlay', true); this.profileBadgeContent.classList.toggle('profile-icon-overlay', false); this.profileBadgeContent.textContent = this.userDataProfileService.currentProfile.name.substring(0, 2).toUpperCase();
Change:
Testing See here: ! When many tabs are wrapping and height is little, at once point we disable wrapping to make room for the editor. I think this limit now needs to account for when 2 tab rows are showing.

Discussion:
layout(dimensions: IEditorTitleControlDimensions): Dimension { const stickyDimensions = this.stickyEditorTabsControl.layout(dimensions); <del> const unstickyDimensions = this.unstickyEditorTabsControl.layout(dimensions); </del> <ins> const unstickyAvailableDimensions = { container: dimensions.container, available: new Dimension(dimensions.available.width, dimensions.available.height - stickyDimensions.height) }; const unstickyDimensions = this.unstickyEditorTabsControl.layout(unstickyAvailableDimensions); </ins> return new Dimension( dimensions.container.width,
Change:
Testing ! I am still trying to recap how I got there... Update: have some pinned and non-pinned tabs open an empty group to the right drag the entire group to the right by dragging from empty space after the last tab you end up with 2 action bars visible

Discussion:
if (didChange) { // HACK: To render all editor tabs on startup, otherwise only one row gets rendered otherTabController.openEditors([]); <ins> this.handleOpenedEditors(); </ins> } return didChange; }

const didChangeOpenEditorsSticky = this.stickyEditorTabsControl.openEditors(stickyEditors); const didChangeOpenEditorsUnSticky = this.unstickyEditorTabsControl.openEditors(unstickyEditors); <del> return didChangeOpenEditorsSticky || didChangeOpenEditorsUnSticky; </del> <ins> const didChange = didChangeOpenEditorsSticky || didChangeOpenEditorsUnSticky; if (didChange) { this.handleOpenedEditors(); } return didChange; } private handleOpenedEditors(): void { this.handlePinnedTabsSeparateRowToolbars(); </ins> } beforeCloseEditor(editor: EditorInput): void {
Change:
I wonder if this could be a 18 issue? //cc
Yes , this is addressed in Node v20 and we have also backported the fix to Electron in However, we haven't backported the fix to but we can.

Discussion:
{ "name": "code-oss-dev", "version": "1.84.0", <del> "distro": "7df09ac7212a2c85067c0e2ef8c1ec89686483d2", </del> <ins> "distro": "7c11ebfa20a4556137f851c95af40923aae11a3d", </ins> "author": { "name": "Microsoft Corporation" },

disturl "https://nodejs.org/dist" target "18.15.0" <del> ms_build_id "229541" </del> <ins> ms_build_id "234519" </ins> runtime "node" build_from_source "true"
Change:
Testing comments view open and scrolled to the top of the file enter in the node :bug: I get scrolled to the first comment
This also happens if I expand the node after collapsing it, which I found a bit surprising, as I didn't hit enter on a specific comment, just the file node
There are a couple problems here: We should only expand/collapse the file node when the twisty is clicked/entered (we should have both an action and an expand/collapse with the file is clicked/entered) We should just open the file and not scroll to a comment when the file node is clicked/entered.
Actually, since you're opening the file from the Comments view, it makes sense to reveal the first comment. I'm just going to fix the expand/collapse + action issue.
I just verified this by making sure that clicking on the node doesn't expand/collapse the node (only the twistie can). Please lmk if that's sufficient!
That is sufficient!

Discussion:
return ''; } }, <del> expandOnlyOnTwistieClick: (element: any) => { if (element instanceof CommentsModel || element instanceof ResourceWithCommentThreads) { return false; } return true; }, </del> <ins> expandOnlyOnTwistieClick: true, </ins> collapseByDefault: false, overrideStyles: options.overrideStyles, filter: options.filter,
Change:
Type: <bBug</bCopilot and auto inline suggestion. , type the following comment in the first line and hit enter: soon as you hit enter to change a line, you will hear an audio cue and alert for the inline suggestion, such as . Press alt+F2 to see if you can open Accessible View. Notes: Accessible View is not open. VS Code version: Code - Insiders 1.83.0-insider (, 2023-09-28T05:34:00.540Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (92)</summaryExtensionVersion ------ android-dev-ext1.3.2 aiprm-lang0.0.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.118 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.52.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.25.0 gitlens14.3.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.15.4 copilot1.117.446 copilot-chat0.8. remotehub0.60.0 vscode-github-actions0.26.2 vscode-pull-request-github0.72.0 overleaf-workshop0.2.4 cslpreview0.2.2 easy-snippet0.6.3 path-autocomplete1.25.0 latex-workshop9.14.0 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 vscode-bard0.0.10 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.1 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.16.0 vscode-pylance2023.9.20 jupyter2023.8. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.313.0 remote-ssh0.106.4 remote-ssh-edit0.86.0 remote-wsl0.81.5 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.15.31 cpptools1.17.5 cpptools-extension-pack1.3.0 js-debug-nightly2023.9.2717 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.130 vscode-selfhost-test-provider0.3.18 vscode-serial-monitor0.10.0 vsliveshare1.0.5883 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.4 shinyuieditor0.5.0 quarto1.100.0 r-debugger0.5.4 java1.22.1 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.7.0 latex-utilities0.4.10 cmake0.0.17 errorlens3.14.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.54.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.14 vscode-java-test0.40.0 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
I see that's happening because the model says there's no content for that line. I notice that it goes into this cache and returns . Any idea what we can do about this? ! !
here's where is returned
this is a breaking issue for screen reader users. Any thoughts would be appreciated.

Discussion:
return false; } const lineText = model.textModel.getLineContent(state.ghostText.lineNumber); <del> if (!lineText) { return false; } </del> const ghostText = state.ghostText.renderForScreenReader(lineText); if (!ghostText) { return false;
Change:
found testing for a cell to get output ctrl+down to focus the output :bug: visually, it looks like the cell container is focused.
in the insiders build of 1.83.0, NVDA 2023.2 does read the output but like said it doesn't visually focus it. Unlike NVDA JAWS 2023.2307 doesn't even read the output. And even pressing alt+F2 while using JAWS, accessible view is not even pulled up/JAWS doesn't do anything. While output focus issue is not found in version 1.81.1 with JAWS 2023.2307. Seems like VS Code bug.
So this worked but with the keybindings on Mac. Not sure if the keybinding you mentioned is the keybinding on another platform like windows?
yes sorry, didn't notice that mac keybinding was different

Discussion:
function focusFirstFocusableOrContainerInOutput(cellOrOutputId: string, alternateId?: string) { const cellOutputContainer = document.getElementById(cellOrOutputId) ?? <del> alternateId ? document.getElementById(alternateId!) : undefined; </del> <ins> (alternateId ? document.getElementById(alternateId!) : undefined); </ins> if (cellOutputContainer) { if (cellOutputContainer.contains(document.activeElement)) { return;
Change:
Does this issue occur when all extensions are disabled?: Yes VS Code Version: 1.82.2 OS Version: macOs Monterey 12.3 Steps to Reproduce: Created a ttf font file using select any icon and font character ( I have selected G) the to include the ttf file Status bar item with text Icon needs to show up but the character G shows up instead ! Attached my font file expected to show !
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.82.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Hey I saw you were working on the status bar (in the working areas md file)
I am not sure if this is a missing adoption or a bug, starting with Martin.
Nornally we use font characters codes starting from . I guess lower ones should work too. Can you add a complete sample extension to reproduce?
Hi Team thanks for reaching out here is my sample extension to reproduce it is very minimal just contributes the icon. Use command helloworld to see the status bar not working
I also have a small question as well do we need to use reserve characters to add icons in my case I replaced the letter G with my icon in my TTF file.
Found the problem. We had a bug with TTF fonts. I pushed a fix. In the meantime, if you can use or fonts, that should work, also with as character code.
Thanks for the nice sample.
Thanks for your quick response !

Discussion:
if (typeof defaultIcon === 'string') { iconRegistry.registerIcon(id, { id: defaultIcon }, iconContribution.description); } else if (typeof defaultIcon === 'object' && typeof defaultIcon.fontPath === 'string' && typeof defaultIcon.fontCharacter === 'string') { <del> const format = extname(defaultIcon.fontPath).substring(1); if (['woff', 'woff2', 'ttf'].indexOf(format) === -1) { collector.warn(nls.localize('invalid.icons.default.fontPath.extension', "Expected `contributes.icons.default.fontPath` to have file extension 'woff', woff2' or 'ttf', is '{0}'.", format)); </del> <ins> const fileExt = extname(defaultIcon.fontPath).substring(1); const format = formatMap[fileExt]; if (!format) { collector.warn(nls.localize('invalid.icons.default.fontPath.extension', "Expected `contributes.icons.default.fontPath` to have file extension 'woff', woff2' or 'ttf', is '{0}'.", fileExt)); </ins> return; } const extensionLocation = extension.description.extensionLocation;

} } <ins> const formatMap: Record<string, string> = { 'ttf': 'truetype', 'woff': 'woff', 'woff2': 'woff2' }; </ins> function getFontId(description: IExtensionDescription, fontPath: string) { return posix.join(description.identifier.value, fontPath); }
Change:
The Python debugger extension has adopted the portsAttributes API to help us gain confidence in the API before finalization. Not granting that extension access to the API was an oversight.
<!-- UNABLETOLOCATECOMMITMESSAGE issue --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased
closedWith

Discussion:
{ "name": "code-oss-dev", "version": "1.83.0", <del> "distro": "e61050c5d43d2c66a196fafaa2b78d4f2a8c929a", </del> <ins> "distro": "843239091771548f8641e7125413223827657911", </ins> "author": { "name": "Microsoft Corporation" },
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.82.2 OS Version: macOS Monterey (12.6) Steps to Reproduce: any SCM extension, e.g. , so you'll have multiple SCM providers. && && vscode select the "" file under Hg, you'll see how the "" under Git is revealed, selected and focused. This feature to reveal the active file in the SCM panel was implemented . It's enabled by default (). The problem is that when using other scm providers and trying to select the files to see the diff, it jumps to the git section instead of staying with the same provider. <img width="572" alt="Screen Shot 2023-09-30 at 12 05 07 AM" src=""In the screenshot above I selected the "" inside the "hg" section, but the one in Git was auto-selected. This is not specific for HG, I implemented an SCM provider in and it has the exact same issue.
The change that I made addresses the issue when an item is being clicked in the Source Control tree. Switching tabs may still highlight the incorrect resource since multiple resources have the same URI. The only way to address that would be to change the URI of the resources displayed in the Source Control view but that is a significant undertaking.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified

Discussion:
return; } <ins> // Do not set focus/selection when the resource is already focused and selected if (this.tree.getFocus().some(e => isSCMResource(e) && this.uriIdentityService.extUri.isEqual(e.sourceUri, uri)) && this.tree.getSelection().some(e => isSCMResource(e) && this.uriIdentityService.extUri.isEqual(e.sourceUri, uri))) { return; } </ins> this.revealResourceThrottler.queue( () => this.treeOperationSequencer.queue( async () => {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.82.2 OS Version: Windows 10.0..2361 Steps to Reproduce: !
Any output in the devtools console during the first load? To get to the devtools console, press Ctrl+Shift+P to open the command palette, and then run the "Developer: Toggle Developer" Tools command.
! I've found that this problem occurs when I'm not connected to the internet, and it shows up fine when connected.
I'm unable to reproduce the issue. Does it occur with extensions disabled?
yes
Got it. What must've happened last time was my device reconnected me to the Internet while I was confirming the issue.

Discussion:
const additionalGroups: ISettingsGroup[] = []; const toggleData = await getExperimentalExtensionToggleData(this.workbenchAssignmentService, this.environmentService, this.productService); <del> if (toggleData && groups.filter(g => g.extensionInfo).length) { </del> <ins> if (this.extensionGalleryService.isEnabled() && toggleData && groups.filter(g => g.extensionInfo).length) { </ins> for (const key in toggleData.settingsEditorRecommendedExtensions) { const extensionId = key; // Recommend prerelease if not on Stable.
Change:
Support moving debug and extensions viewlets to other locations. At present these cannot be moved because the views contained in them are not movable. But that should not stop moving the complete view container. CC
Figured out that there are issues moving Remote container viewlet and it is because the views infrastructure re-create the ViewPaneContainer on move and wrongly assumes itself as a single-ton and adding the remote help ext point handler again which throws an error.
/duplicate
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!

Discussion:
} // ... on a different composite bar else { <del> const viewsToMove = this.viewDescriptorService.getViewContainerModel(currentContainer)!.allViewDescriptors; if (viewsToMove.some(v => !v.canMoveView)) { return; } </del> this.viewDescriptorService.moveViewContainerToLocation(currentContainer, this.targetContainerLocation, this.getTargetIndex(targetCompositeId, before)); } }

return dragData.id !== targetCompositeId; } <del> // ... to another composite location const draggedViews = this.viewDescriptorService.getViewContainerModel(currentContainer)!.allViewDescriptors; // ... all views must be movable return !draggedViews.some(view => !view.canMoveView); </del> <ins> return true; </ins> } else { // Dragging an individual view
Change:
I've just merged a PR that will "cleared" when the terminal or chat history has been cleared. This won't be in insider's until late this week - after our release FYI. I noticed that we handle this differently across components: Search says "the search results have been cleared". Debug console says "Debug console cleared" Chat/terminal say "Cleared" The output channel says "Output cleared". Do you prefer the including the feature's name in the or keeping it concise?
IMO, there is no need to contain the feature name and we can make it concise like “Cleared.”
I agree 200%.
Thanks, we'll go with "cleared" everywhere and consolidate this so that it would be trivial to add an audio cue someday
Noted, thanks -- I've updated our documentation to reflect this.
Search still says "The search results have been cleared"

Discussion:
import { CommonFindController } from 'vs/editor/contrib/find/browser/findController'; import { MultiCursorSelectionController } from 'vs/editor/contrib/multicursor/browser/multicursor'; import * as nls from 'vs/nls'; <del> import { IAccessibilityService } from 'vs/platform/accessibility/common/accessibility'; </del> <ins> import { AccessibleNotificationEvent, IAccessibilityService, IAccessibleNotificationService } from 'vs/platform/accessibility/common/accessibility'; </ins> import { MenuId } from 'vs/platform/actions/common/actions'; import { ICommandService } from 'vs/platform/commands/common/commands'; import { IConfigurationChangeEvent, IConfigurationService } from 'vs/platform/configuration/common/configuration';

@ITelemetryService telemetryService: ITelemetryService, @INotebookService private readonly notebookService: INotebookService, @ILogService private readonly logService: ILogService, <ins> @IAccessibleNotificationService private readonly accessibleNotificationService: IAccessibleNotificationService </ins> ) { super(options, keybindingService, contextMenuService, configurationService, contextKeyService, viewDescriptorService, instantiationService, openerService, themeService, telemetryService);

this.viewModel.cancelSearch(); this.tree.ariaLabel = nls.localize('emptySearch', "Empty Search"); <del> aria.status(nls.localize('ariaSearchResultsClearStatus', "The search results have been cleared")); </del> <ins> this.accessibleNotificationService.notify(AccessibleNotificationEvent.Clear); </ins> this.reLayout(); }
Change:
was resolved by adding global installation of to pipelines that needed it. However, we have pipelines that require the use of custom node-gyp (ex: ) and any package that requires global will result in an error in these pipelines, refs since it was the job of these binary scripts to redirect to the custom node-gyp in the first place. We can emulate this behavior, by adding the relevant scripts to environment in CI.
Losing my freakin mind over here. Here's the state of my PR Windows When is set: works When not set: my cmd script is not right, and I guess returns multiple options. See the results here: Non-Windows on the path actually points at a script that invokes node in some other location. I don't think we can determine that without hardcoding the path to it. Probably we will have to hardcode the paths on both sides? and
Would be worth checking if returns the path, or maybe running a node command to print would do it
Thanks for looking into this, yeah something like that should work.
Closing in favor of the yarn -npm move.

Discussion:
<del> 18.18 </del>  No newline at end of file <ins> 18.17 </ins>  No newline at end of file