Change:
I noticed some task messages weren't localized: Terminal support for unicode is pretty great now so if we have issues with other languages here we should fix them.
Seems like a good idea. Changing these would only be an issue if we have extensions that are reading terminal output and looking for these strings.
That's a proposed api that will probably never get finalized, I doubt the few that use this would be checking for task messages like that.

Discussion:
shellLaunchConfig.args = windowsShellArgs ? combinedShellArgs.join(' ') : combinedShellArgs; if (task.command.presentation && task.command.presentation.echo) { if (needsFolderQualification && workspaceFolder) { <del> shellLaunchConfig.initialText = formatMessageForTerminal(`Executing task in folder ${workspaceFolder.name}: ${commandLine}`, { excludeLeadingNewLine: true }); </del> <ins> shellLaunchConfig.initialText = formatMessageForTerminal(nls.localize({ key: 'task.executingInFolder', comment: ['The workspace folder the task is running in', 'The task command line or label'] }, 'Executing task in folder {0}: {1}', workspaceFolder.name, commandLine), { excludeLeadingNewLine: true }); </ins> } else { <del> shellLaunchConfig.initialText = formatMessageForTerminal(`Executing task: ${commandLine}`, { excludeLeadingNewLine: true }); </del> <ins> shellLaunchConfig.initialText = formatMessageForTerminal(nls.localize({ key: 'task.executing', comment: ['The task command line or label'] }, 'Executing task: {0}', commandLine), { excludeLeadingNewLine: true }); </ins> } } } else {

return args.join(' '); }; if (needsFolderQualification && workspaceFolder) { <del> shellLaunchConfig.initialText = formatMessageForTerminal(`Executing task in folder ${workspaceFolder.name}: ${shellLaunchConfig.executable} ${getArgsToEcho(shellLaunchConfig.args)}`, { excludeLeadingNewLine: true }); </del> <ins> shellLaunchConfig.initialText = formatMessageForTerminal(nls.localize({ key: 'task.executingInFolder', comment: ['The workspace folder the task is running in', 'The task command line or label'] }, 'Executing task in folder {0}: {1}', workspaceFolder.name, `${shellLaunchConfig.executable} ${getArgsToEcho(shellLaunchConfig.args)}`), { excludeLeadingNewLine: true }); </ins> } else { <del> shellLaunchConfig.initialText = formatMessageForTerminal(`Executing task: ${shellLaunchConfig.executable} ${getArgsToEcho(shellLaunchConfig.args)}`, { excludeLeadingNewLine: true }); </del> <ins> shellLaunchConfig.initialText = formatMessageForTerminal(nls.localize({ key: 'task.executing', comment: ['The task command line or label'] }, 'Executing task: {0}', `${shellLaunchConfig.executable} ${getArgsToEcho(shellLaunchConfig.args)}`), { excludeLeadingNewLine: true }); </ins> } } }

customPtyImplementation: (id, cols, rows) => new TerminalProcessExtHostProxy(id, cols, rows, this._terminalService), waitOnExit, name: this._createTerminalName(task), <del> initialText: task.command.presentation && task.command.presentation.echo ? formatMessageForTerminal(`Executing task: ${task._label}`, { excludeLeadingNewLine: true }) : undefined, </del> <ins> initialText: task.command.presentation && task.command.presentation.echo ? formatMessageForTerminal(nls.localize({ key: 'task.executing', comment: ['The task command line or label'] }, 'Executing task: {0}', task._label), { excludeLeadingNewLine: true }) : undefined, </ins> isFeatureTerminal: true, icon: task.configurationProperties.icon ? ThemeIcon.fromId(task.configurationProperties.icon) : undefined, color: task.configurationProperties.color