jiebi/CodeConvo huggingface dataset:
Change:
VSCode Version:1.25 OS Version:Windows Server 2012r2 / Win 10 Steps to Reproduce: 1.25 to an Network share. create an .data folder to make it an portable .exe runs as background process in task manager. No Gui is shown on Fileserver from local Filesystem works as expected with gui in portable mode. Does this issue occur when all extensions are disabled?: Yes
Just found out it happens only if started from UNC path. If you map a drive it works as expected.
/duplicate
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues . See also our guidelines. Happy Coding!
isn’t a duplicate of this issue
Thanks my bad.
Can you go through this checklist, so we figure out what goes wrong? Here is a checklist to find out more about the freeze/slow/crash [ ] it reproduces with extensions disabled ( from the command line - NOT the integrated terminal of Code) if it does not reproduce with extensions disabled, you can stop testing and report this! [ ] it was not happening in the previous stable release ) [ ] there is no suspicious output when running from the command line () [ ] there is no suspicious output in the window itself (Help Console) [ ] it reproduces on Windows, Linux and Mac [ ] it reproduces after deleting and (backup first! see below for paths) [ ] it reproduces when opening empty ( from the command line) [ ] it reproduces opening any folder [ ] it reproduces opening any file [ ] it reproduces when only having a single window open [ ] it reproduces by just using Code without external tools running on the same folder [ ] it reproduces from a workspace that is not under Git version control [ ] it reproduces independently if a file is opened or not after startup [ ] it reproduces when running with GPU disabled () [ ] it reproduces when being offline [ ] it reproduces when disabling the file watching (set to ) [ ] it reproduces after uninstalling and reinstalling [ ] it reproduces after deleting the application data directory (backup first! see below for paths) [ ] I have not played around with permissions or ran Code as administrator [ ] I am seeing a single CPU process spin high (please share the full command line arguments) [ ] I am seeing Code consuming lots of memory in a short time Application Data Directory for VS Code: Windows: Mac: Linux: Application Data Directory for VS Code Insiders: Windows: Mac: Linux:

Discussion:
pathName = '/' + pathName; } <del> return encodeURI('file://' + pathName).replace(/#/g, '%23'); </del> <ins> /** @type {string} */ let uri; if (pathName.startsWith('//')) { uri = encodeURI('file:' + pathName); } else { uri = encodeURI('file://' + pathName); } return uri.replace(/#/g, '%23'); </ins> }; //#endregion
Change:
VSCode Version: 1.25.1 (also tested in latest insiders build) OS Version: Arch Linux x64 Steps to Reproduce: I have created a little demonstrating this bug: the project and run and the debugger - a new VS Code window opens containing a custom view called "BUG DEMO" that custom view and expand all nodes in it - the labels are , and on "INCREASE COUNTER" - now the labels are , and (which is correct) the root node, click "INCREASE COUNTER" and expand the root node again Now the labels are , and - this is incorrect, the grandchild's label should be . You can also see in the Debug console that after clicking "INCREASE COUNTER" the second time and expanding the root node again, only the root and child nodes are fetched, but not the grandchild.
Assigned to July milestone for investigation
Looks like in your code you are using the same id for all nodes. If you are providing an it should be unique. is optional and when it is removed the last step increase counter for all elements
But I'm only using this for one of the 3 nodes:
I just tried with the latest Insiders build and the bug is still there: ! The output in the debug console shows that the three nodes have different IDs , and : Removing the IDs is not a good workaround as it means that the tree loses its collapsed state on every update: !
You are right, it is also reproducible with attribute.
To Verify: Open VS Code on a folder with following structureExpand to see Reveal File C in OS Explorer (Finder/File Explorer) Collapse in VS Code file explorer Rename to Outside VS Code (Finder) Refresh the File Explorer Tree in VS Code Expand in VS Code Verify that Folder B is expanded and showing

Discussion:
private refreshChildren(recursive: boolean, safe: boolean = false, force: boolean = false): WinJS.Promise { if (!force && !this.isExpanded()) { <del> this.needsChildrenRefresh = true; </del> <ins> const setNeedsChildrenRefresh = (item: Item) => { item.needsChildrenRefresh = true; item.forEachChild(setNeedsChildrenRefresh); }; setNeedsChildrenRefresh(this); </ins> return WinJS.TPromise.as(this); }

return child.doRefresh(recursive, true); })); } else { <del> this.mapEachChild(child => child.updateVisibility()); return WinJS.TPromise.as(null); </del> <ins> return WinJS.Promise.join(this.mapEachChild((child) => { if (child.needsChildrenRefresh) { return child.doRefresh(recursive, true); } else { child.updateVisibility(); return WinJS.TPromise.as(null); } })); </ins> } });
Change:
<!-- Please search existing issues to avoid creating duplicates. --trim file name search <!-- Describe the feature you'd like. --Suppose you're looking for or . If you search them exactly, you'll get the file result. If you prepend and/or append whitepace, e.g. , you won't. It's common to accidentally include spaces when copy & pasting file names from, say, test reports. I'd love to fix this issue if you don't mind!
Assuming leading and trailing whitespace is never relevant to any filePattern in a search, I think the correct spot would be here: A PR would be great!

Discussion:
this.resolveSmartCaseToCaseSensitive(contentPattern); } <del> const query = <ISearchQuery>{ </del> <ins> const query: ISearchQuery = { </ins> type, folderQueries, usingSearchPaths: !!(searchPaths && searchPaths.length), extraFileResources: options.extraFileResources, <del> filePattern: options.filePattern, </del> <ins> filePattern: options.filePattern ? options.filePattern.trim() : options.filePattern, </ins> excludePattern, includePattern, maxResults: options.maxResults,

}); }); <ins> test('file pattern trimming', () => { const content = 'content'; assertEqualQueries( queryBuilder.text( PATTERN_INFO, undefined, { filePattern: ` ${content} ` } ), <ISearchQuery>{ contentPattern: PATTERN_INFO, filePattern: content, type: QueryType.Text }); }); </ins> test('exclude ./ syntax', () => { assertEqualQueries( queryBuilder.text(
Change:
a debugging session (assume JS for next step) in debug repl widget should appear, but does not.
cc
thanks for fixing this! Works great now, adding verified label

Discussion:
if (this.isSimpleWidget) { commandDelegate = { paste: (source: string, text: string, pasteOnNewLine: boolean, multicursorText: string[]) => { <del> this.cursor.trigger(source, editorCommon.Handler.Paste, { text, pasteOnNewLine, multicursorText }); </del> <ins> this.trigger(source, editorCommon.Handler.Paste, { text, pasteOnNewLine, multicursorText }); </ins> }, type: (source: string, text: string) => { <del> this.cursor.trigger(source, editorCommon.Handler.Type, { text }); </del> <ins> this.trigger(source, editorCommon.Handler.Type, { text }); </ins> }, replacePreviousChar: (source: string, text: string, replaceCharCnt: number) => { <del> this.cursor.trigger(source, editorCommon.Handler.ReplacePreviousChar, { text, replaceCharCnt }); </del> <ins> this.trigger(source, editorCommon.Handler.ReplacePreviousChar, { text, replaceCharCnt }); </ins> }, compositionStart: (source: string) => { <del> this.cursor.trigger(source, editorCommon.Handler.CompositionStart, undefined); </del> <ins> this.trigger(source, editorCommon.Handler.CompositionStart, undefined); </ins> }, compositionEnd: (source: string) => { <del> this.cursor.trigger(source, editorCommon.Handler.CompositionEnd, undefined); </del> <ins> this.trigger(source, editorCommon.Handler.CompositionEnd, undefined); </ins> }, cut: (source: string) => { <del> this.cursor.trigger(source, editorCommon.Handler.Cut, undefined); </del> <ins> this.trigger(source, editorCommon.Handler.Cut, undefined); </ins> } }; } else {
Change:
Opening the view menu I only see them screaming at me due to their size. Can we somehow decrease their size. The native mac arrows are slightly smaller. While visual studio on windows uses a much smaller version ! !
VSCode uses Electron's toolbar if I'm not mistaken. It is basically menus in Chromium and the drop down menu in Chrome, which have arrows larger then those shown in the screenshots. So unless the toolbar can be customized, I don't think it's possible to tweak the arrow size without creating a custom toolbar. Please correct me if I get anything wrong. Thank you.
This is the custom toolbar on the windows we are currently working on. So we could customize it here imho
+1 I think the arrow could be reduced a bit

Discussion:
} .monaco-shell .monaco-menu .monaco-action-bar.vertical .submenu-indicator { <del> font-size: inherit; padding: 0 1em; </del> <ins> font-size: 60%; padding: 0 1.8em; </ins> } .monaco-shell .monaco-menu .action-item {
Change:
Visual Studio Code lacks support for automatic comment-block ending in C and C++. If you were to start a comment-block with , an automatic will not be as it would be in the traditional Visual Studio. When I type , it should automatically be turned into and the text cursor should be between the two ``. It isn't that big of a deal but it would be really nice to have this feature in Visual Studio Code.
Ugh. I currently have the exact OPPOSITE problem: I want to DISABLE this feature. This is happening for me and I can't figure out how to turn it OFF. There are a large number of developers who just don't ever want their text editor to ever, under any circumstances, insert a character that did not correspond exactly 1:1 to a specific keystroke. I push "A", I get "A". And so on. "Surprises" break my flow worse than any other kind of interruption. Obviously, there are a lot of developers in the other camp. But the upshot is that the fact that both camps exist, and both camps are large, means that when features like this exist, it needs to be possible to disable them. I have encouraged many projects for years to consider adding a "dumb as a brick" switch that will just globally disable all of these. In the absence of a master switch, we at least need configuration switches that can shut these things off-- preferably arranged hierarchically, so that we can shut off entire branches. But the absolute lowest rung on the ladder is that individual switches must exist to disable these things.
Let's track in

Discussion:
{ "open": "{", "close": "}" }, { "open": "(", "close": ")" }, { "open": "'", "close": "'", "notIn": ["string", "comment"] }, <del> { "open": """, "close": """, "notIn": ["string"] } </del> <ins> { "open": """, "close": """, "notIn": ["string"] }, { "open": "/*", "close": " */", "notIn": ["string", "comment"] } </ins> ], "surroundingPairs": [ ["{", "}"],
Change:
Open a large workspace Start a text search Press esc See busy process still running is never called here:

Discussion:
let uninitializedPromise: TPromise<any> | null = null; const emitter = new Emitter<any>({ onFirstListenerAdd: () => { <del> uninitializedPromise = this.whenInitialized().then(() => { </del> <ins> uninitializedPromise = this.whenInitialized(); uninitializedPromise.then(() => { </ins> uninitializedPromise = null; this.send(request.raw); });

} this.activeRequests.splice(this.activeRequests.indexOf(listener), 1); <ins> listener.dispose(); </ins> if (this.activeRequests.length === 0) { this.disposeDelayer.trigger(() => this.disposeClient());

} public static collectResultsFromEvent(event: Event<ISerializedSearchProgressItem | ISerializedSearchComplete>): PPromise<ISearchComplete, ISearchProgressItem> { <ins> let listener: IDisposable; </ins> const promise = new PPromise<ISerializedSearchSuccess, ISerializedSearchProgressItem>((c, e, p) => { setTimeout(() => { <del> const listener = event(ev => { </del> <ins> listener = event(ev => { </ins> if (isSerializedSearchComplete(ev)) { if (isSerializedSearchSuccess(ev)) { c(ev);

} }); }, 0); <del> }); </del> <ins> }, () => listener.dispose()); </ins> return DiskSearch.collectResults(promise); }
Change:
Issue Type: <bBug</b!] On MacOS Mojave, there is a white, horizontal bar that appears at the top of the software-generated title bar on the window. Expected Result: No white bar over top of titlebar Actual Result: White bar appears over top of titlebar VS Code version: Code 1.25.1 (, 2018-07-11T15:33:29.235Z) OS version: Darwin x64 18.0.0 <details<summarySystem Info</summary </details<details<summaryExtensions (9)</summaryExtensionVersion ------ npm-intellisense1.3.0 tslint1.0.34 vscode-npm-script0.3.5 php-intellisense2.3.3 code-runner0.9.3 beautify1.3.2 applescript0.10.0 python2018.7.0 csharp1.15.2 (1 theme extensions excluded) </details<!-- generated by issue reporter --
are you zoomed in in VSCode?
Whether zoomed or not, it's the same.
Is there any solution to this issue?
I see this on every window
could you check another Electron 2 app ()?
Sorry I mean every window on MacOS. It's definitely just an annoying quirk of the dark theme.
Actually, it's not quite the same in other apps. I see the same issue on Chrome, Slack, OneNote, Teams, Atom, at least. Not on Finder, Spotify, System Preferences, or apps with a native title bar.
This seems to be
Via
So this appears to add support for dark mode on Mojave. But now this adds a dark line for our light themes (bug?): !

Discussion:
name: product.nameLong, urlSchemes: [product.urlProtocol] }], <ins> darwinForceDarkModeSupport: true, </ins> darwinCredits: darwinCreditsTemplate ? Buffer.from(darwinCreditsTemplate({ commit: commit, date: new Date().toISOString() })) : void 0, linuxExecutableName: product.applicationName, winIcon: 'resources/win32/code.ico',
Change:
Need to update the css so that this badge becomes a circle (when a single digit) instead of an odd shape. It also doesn't match the badge used in the content area: !

Discussion:
} .monaco-workbench  > .part.panel > .title > .panel-switcher-container > .monaco-action-bar .badge { <del> margin-left: 4px; </del> <ins> margin-left: 8px; </ins> } .monaco-workbench  > .part.panel > .title > .panel-switcher-container > .monaco-action-bar .badge .badge-content { <del> padding: 0.2em 0.5em; </del> <ins> padding: 0.3em 0.5em; </ins> border-radius: 1em; font-weight: normal; text-align: center; <del> display: inline; } </del> <ins> display: inline-block; min-width: 1.6em; line-height: 1em; box-sizing: border-box; } </ins> /** Actions */
Change:
on insiders !
Do you know of any recent changes to relevant CSS? If not I'll take a look
Good chance it was this () commit.
I suppose this is a duplicate.
Yes that was part of it

Discussion:
font-size: 11px; -webkit-margin-before: 0; -webkit-margin-after: 0; <del> display: flex; </del> }

super({ ...(options as IViewletPanelOptions), ariaHeaderLabel: options.title }, keybindingService, contextMenuService, configurationService); } <ins> protected renderHeader(container: HTMLElement): void { this.renderHeaderTitle(container); } </ins> renderHeaderTitle(container: HTMLElement): void { super.renderHeaderTitle(container, this.options.title);

height: calc(100% - 38px); } <ins> .extensions-viewlet > .extensions .list-actionbar-container { margin-right: 10px; } </ins> .extensions-viewlet > .extensions .list-actionbar-container .monaco-action-bar .action-item > .octicon { font-size: 12px; line-height: 1;
Change:
I'm using the on a keybinding to quickly switch between different components in a project. A slightly frustrating behavior is that the window list appears in the same order in both windows. This means that when you do , the first window in the list is always selected. So, if you have 2 windows open and you're switching back and forth between them, you have to remember two key combinations, one for each window you're in: Switching from Window 1 to Window 2: Switching from Window 2 to Window 1: only I propose defaulting the selection to be the first entry that is not the current window. That way, it is a "quick switch" indeed. :) Thoughts? I will implement this when I have time if there is no objection.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.612 --<!-- potentialduplicatescomment --
Don't believe this is a duplicate - the other issues think this unexpected behavior is a bug, while this issue proposes a way to make the behavior closer to what the user expects.
Another way this could work is to by default, select the window after the current window in the window switcher. So you can quickly flip through 3 or more windows.

Discussion:
action: (!this.isQuickNavigate() && currentWindowId !== win.id) ? this.closeWindowAction : void 0 } as IFilePickOpenEntry)); <ins> const autoFocusIndex = (picks.indexOf(picks.filter(pick => pick.payload === currentWindowId)[0]) + 1) % picks.length; </ins> this.quickOpenService.pick(picks, { contextKey: 'inWindowsPicker', <del> autoFocus: { autoFocusFirstEntry: true }, </del> <ins> autoFocus: { autoFocusIndex }, </ins> placeHolder, quickNavigateConfiguration: this.isQuickNavigate() ? { keybindings: this.keybindingService.lookupKeybindings(this.id) } : void 0 });
Change:
Copy text with newlines Paste into extension viewlet search box Now I have multiple lines of text and can scroll with the arrow keys I think the lines should be flattened

Discussion:
this.searchBox.setModel(this.modelService.createModel('', null, uri.parse('extensions:searchinput'), true)); <ins> this.disposables.push(this.searchBox.onDidPaste(() => { this.searchBox.setValue(this.searchBox.getValue().replace(/s+/g, ' ')); this.searchBox.setScrollTop(0); })); </ins> this.disposables.push(this.searchBox.onDidFocusEditorText(() => addClass(this.monacoStyleContainer, 'synthetic-focus'))); this.disposables.push(this.searchBox.onDidBlurEditorText(() => removeClass(this.monacoStyleContainer, 'synthetic-focus')));
Change:
Steps to Reproduce: the extensions view, use the menu to use any of the pre-cooked filters (Show Enabled/Disabled/Installed/Recommended extensions) cursor should be at the end of the search text but instead its in the start of the search text This is a regression. In 1.25.1 the cursor does show up at the end of the text

Discussion:
event.immediate = true; this.searchBox.setValue(value); <ins> this.searchBox.setPosition(new Position(1, value.length + 1)); </ins> } private triggerSearch(immediate = false): void {
Change:
Hello, I've initially asked about this on Twitter: Current default behaviour: (A) Ctrl + C on a line with code (no text selection): copies the whole line (B) Ctrl + C on a blank line (no text selection): copies the empty line I would love to be able to do (A), but disable (B). The closest setting for this is . Setting it to disables (B), but prevents me from using (A) forcing me to select the whole line to copy it.
I am curious.. Why would you Ctrl+C on a blank line in the first place?
Hello I don't do it intentionally. Since the and the keys are next to each other (in QWERTY keyboards at least), every now and then when I attempt to paste something on a blank line I accidentally click instead of so whatever I initially have in my clipboard gets overwritten by a blank line.
Got it, thanks.
An extension: , can you unlock that issue: , so I can put a link to the extension, since not everybody happy there and they basically want the same thing as described in this issue.
I don't believe the extension is the right solution for this problem for 2 reasons: It can easily be solved in the product itself. The extension introduces a new command which users will have to learn I believe we can add this fix as a default. Would you like to send a PR? The fix would be in the file If there is no selection and the line is empty, then we shouldn't copy to clipboard Please correct me if I am wrong above
thanks for the investigation and proposal, sounds good to me. Things to take care of carefully is lines with only leading whitespaces and multi cursors.
IDK, similar issue got 5 days ago: If you will accept PR, then I can try.
I would like to fix this issue, how to i assigne this issue to me?
There is already an open Pull Request addressing this issue, I would suggest to look for another issue to fix.
thanks but then, the status shouldn't be OPEN.
The PR hasnt been merged yet, so the issue is open. Perhaps, we can remove the help-wanted label, since the PR is already open.

Discussion:
if (!emptySelectionClipboard && editor.getSelection().isEmpty()) { return; } <ins> // Prevent copying an empty line by accident if (editor.getSelections().length === 1 && editor.getSelection().isEmpty()) { if (editor.getModel().getLineFirstNonWhitespaceColumn(editor.getSelection().positionLineNumber) === 0) { return; } } </ins> super.run(accessor, editor); }
Change:
Issue Type: <bBug</b! ! As seen in the image above, the right side of the border has a portion cut off for an unknown reason. This doesn't happen with any of the official themes but does happen with themes installed from the marketplace. VS Code version: Code - Insiders 1.26.0-insider (, 2018-07-27T05:18:38.441Z) OS version: Linux x64 4.17.8-1-ARCH <details<summarySystem Info</summary </details<details<summaryExtensions (29)</summaryExtensionVersion ------ flutter-snippets0.0.2 gitignore0.5.0 transformer1.6.0 dart-code2.16.0 flutter2.16.0 gitlens8.5.3 vsc-material-theme2.3.0 vscode-commands1.2.2 vscode-todo-plus2.2.1 toggler0.0.3 output-colorizer0.1.2 vscode-insertdatestring2.2.2 vscode-commitizen0.5.0 Go0.6.85 vscode-quick-open-create0.6.0 vsnotes0.5.1 vscode-docker0.1.0 java0.28.0 vscode-yaml0.0.14 code-settings-sync3.0.0 gitconfig1.0.1 code-spell-checker1.6.10 vsfire1.3.2 vz-file-templates0.0.3 vscode-java-debug0.10.0 vscode-java-pack0.3.0 vscode-java-test0.7.1 vscode-maven0.10.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
Could you specify which theme causes this? In your installed extensions one theme has been redacted, I assume that't the one, as vsc-material-theme doesn't seem to have this issue for me.
Got a repro with dracula
Put up a PR that fixes this in the cases I saw. Thanks for the report!
Thanks for the fix! I originally thought it was just one or two themes using a deprecated api so I closed the issue but I later realized that most marketplace themes were broken.

Discussion:
layout(dimension: Dimension): void { toggleClass(this.root, 'narrow', dimension.width <= 300); <del> this.searchBox.layout({ height: 20, width: dimension.width - 30 }); </del> <ins> this.searchBox.layout({ height: 20, width: dimension.width - 34 }); </ins> this.placeholderText.style.width = '' + (dimension.width - 30) + 'px'; super.layout(new Dimension(dimension.width, dimension.height - 38));
Change:
Testing Issue Type: <bBug</bextension search box, type Bug start showing up instead ! VS Code version: Code - Insiders 1.26.0-insider (, 2018-07-30T05:11:25.700Z) OS version: Darwin x64 17.7.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
what should we do in this case? We aren't able to change how these match. We could disable fuzzy finding entirely

Discussion:
config.ariaLabel = ariaLabel || ''; config.cursorWidth = 1; config.snippetSuggestions = 'none'; <ins> config.suggest = { filterGraceful: false }; </ins> config.fontFamily = ' -apple-system, BlinkMacSystemFont, "Segoe WPC", "Segoe UI", "HelveticaNeue-Light", "Ubuntu", "Droid Sans", sans-serif'; return config; }