Change:
On Insiders, for in the Settings editor. an HTML language filter to that setting. A default override indicator shows up for the setting that indicates that the default setting value of the extension has been overridden by the HTML Languages extension. remove the language filter from the search query in the search bar. :bug: The default override indicator still remains, even though we are back to the non-language-specific scope.

Discussion:
updateDefaultOverrideIndicator(element: SettingsTreeSettingElement) { this.defaultOverrideIndicatorElement.style.display = 'none'; <del> const defaultValueSource = element.setting.defaultValueSource; </del> <ins> const defaultValueSource = element.defaultValueSource; </ins> if (defaultValueSource) { this.defaultOverrideIndicatorElement.style.display = 'inline'; if (typeof defaultValueSource !== 'string' && defaultValueSource.id !== element.setting.extensionInfo?.id) {

} // Add default override indicator text <del> if (element.setting.defaultValueSource) { const defaultValueSource = element.setting.defaultValueSource; </del> <ins> if (element.defaultValueSource) { const defaultValueSource = element.defaultValueSource; </ins> if (typeof defaultValueSource !== 'string' && defaultValueSource.id !== element.setting.extensionInfo?.id) { const extensionSource = defaultValueSource.displayName ?? defaultValueSource.id; ariaLabelSections.push(localize('defaultOverriddenDetails', "Default setting value overridden by {0}", extensionSource));

template.elementDisposables.add(template.button.onDidClick(() => { if (isLanguageTagSetting) { <del> this._onApplyFilter.fire(`@${LANGUAGE_SETTING_TAG}:${plainKey}`); </del> <ins> this._onApplyFilter.fire(`@${LANGUAGE_SETTING_TAG}${plainKey}`); </ins> } else { this._onDidOpenSettings.fire(dataElement.setting.key); }

import { IJSONSchema } from 'vs/base/common/jsonSchema'; import { Disposable } from 'vs/base/common/lifecycle'; import { Emitter } from 'vs/base/common/event'; <del> import { ConfigurationScope, EditPresentationTypes, Extensions, IConfigurationRegistry } from 'vs/platform/configuration/common/configurationRegistry'; </del> <ins> import { ConfigurationScope, EditPresentationTypes, Extensions, IConfigurationRegistry, IExtensionInfo } from 'vs/platform/configuration/common/configurationRegistry'; </ins> import { ILanguageService } from 'vs/editor/common/languages/language'; import { Registry } from 'vs/platform/registry/common/platform';

defaultValue?: any; /** <ins> * The source of the default value to display. * This value also accounts for extension-contributed language-specific default value overrides. */ defaultValueSource: string | IExtensionInfo | undefined; /** </ins> * Whether the setting is configured in the selected scope. */ isConfigured = false;

tags?: Set<string>; overriddenScopeList: string[] = []; <ins> /** * For each language that contributes setting values or default overrides, we can see those values here. */ </ins> languageOverrideValues: Map<string, IConfigurationValue<unknown>> = new Map<string, IConfigurationValue<unknown>>(); description!: string; valueType!: SettingValueType;

} } <ins> // The user might have added, removed, or modified a language filter, // so we reset the default value source to the non-language-specific default value source for now. this.defaultValueSource = this.setting.nonLanguageSpecificDefaultValueSource; </ins> if (inspected.policyValue) { this.hasPolicyValue = true; isConfigured = false; // The user did not manually configure the setting themselves.

const registryValues = Registry.as<IConfigurationRegistry>(Extensions.Configuration).getConfigurationDefaultsOverrides(); const overrideValueSource = registryValues.get(`[${languageSelector}]`)?.valuesSources?.get(this.setting.key); if (overrideValueSource) { <del> this.setting.defaultValueSource = overrideValueSource; </del> <ins> this.defaultValueSource = overrideValueSource; </ins> } } else { this.scopeValue = isConfigured && inspected[targetSelector];

enumItemLabels?: string[]; allKeysAreBoolean?: boolean; editPresentation?: EditPresentationTypes; <del> defaultValueSource?: string | IExtensionInfo; </del> <ins> nonLanguageSpecificDefaultValueSource?: string | IExtensionInfo; </ins> isLanguageTagSetting?: boolean; categoryOrder?: number; categoryLabel?: string;

allKeysAreBoolean, editPresentation: prop.editPresentation, order: prop.order, <del> defaultValueSource, </del> <ins> nonLanguageSpecificDefaultValueSource: defaultValueSource, </ins> isLanguageTagSetting, categoryLabel, categoryOrder