jiebi/CodeConvo huggingface dataset:
Change:
VSCode Version: Version 1.28.0-insider (1.28.0-insider) OS Version: macOS Mojave Version 10.14 Steps to Reproduce: "Dark" appearance under system preferences general. up Visual Studio Code. "File" and then "Open file..." (or command+o). I have dark mode selected. However, when I select to open a file in VSCode, the finder window is still using the light theme instead of the dark theme as shown below. <img width="1136" alt="screen shot 2018-09-25 at 8 57 26 pm" src="https://user-"
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.612 --- <!-- score: 0.528 --- <!-- score: 0.527 --- <!-- score: 0.495 --- <!-- score: 0.488 --<!-- potentialduplicatescomment --
Set and use native tabs to get dark mode menus and titlebar. <img width="1067" alt="image" src="https://user-"
Perfect! Just a note for VSC Insiders users:
Via

Discussion:
name: product.nameLong, urlSchemes: [product.urlProtocol] }], <ins> darwinForceDarkModeSupport: true, </ins> darwinCredits: darwinCreditsTemplate ? Buffer.from(darwinCreditsTemplate({ commit: commit, date: new Date().toISOString() })) : void 0, linuxExecutableName: product.applicationName, winIcon: 'resources/win32/code.ico',
Change:
an explorer with a lot of elements tree horizontal scrolling covers the last element and there is no way to read nicely the content of that element I would expect the scroll is rendered below the last element, not on top of it
Can you share a screenshot?
If it could help, here is it: !
Also here's one from the explorer !
Seems to be a special case of combination between our scrollbar and the tree: the row is less than double the height of the scrollbar. We should add some extra pixels at the end of the view.
Hello. I want to take this issue. Could you give me a hint where should I start?
can i take this up? some insights will be helpful..

Discussion:
} private set scrollHeight(scrollHeight: number) { <del> this.scrollableElement.setScrollDimensions({ scrollHeight }); </del> <ins> const horizontalScrollHeight = this.horizontalScrolling ? 10 : 0; this.scrollableElement.setScrollDimensions({ scrollHeight: scrollHeight + horizontalScrollHeight }); </ins> } public get viewWidth(): number {

} public set scrollTop(scrollTop: number) { <ins> const horizontalScrollHeight = this.horizontalScrolling ? 10 : 0; </ins> this.scrollableElement.setScrollDimensions({ <del> scrollHeight: this.getContentHeight() </del> <ins> scrollHeight: this.getContentHeight() + horizontalScrollHeight </ins> }); this.scrollableElement.setScrollPosition({ scrollTop: scrollTop

if (visibleElementsCount === 0) { this.doShow(this.showAtPosition, this.tree.getInput(), false, true); } else { <del> const height = Math.min(visibleElementsCount, MAX_ELEMENTS_SHOWN) * 18; </del> <ins> const height = Math.min(visibleElementsCount, MAX_ELEMENTS_SHOWN) * 18 + 10; // add 10 px for the horizontal scroll bar </ins> if (this.treeContainer.clientHeight !== height) { this.treeContainer.style.height = `${height}px`;
Change:
Version: 1.27.2 (user setup) Commit: Date: 2018-09-12T16:17:45.060Z Electron: 2.0.7 Chrome: 61.0.3163.100 8.9.3 V8: 6.1.534.41 Architecture: x64 OS: Window 10 Steps to Reproduce: Install Latest VS Live Share extension on Insiders Host: Share a Node JS App, set a breakpoint and start debugging : Join collaboration session (guest automatically joins debug session) Guest: Restart debug session ! This issue appears to be due to recent debug restart refactoring: The issue occurs in debugService's restartSession. When the VS Live Share Guest clicks restart the correct resolved and unresolved debug configurations are found on the session. The unresolved configuration does not equal the session.unresolvedConfiguration. needsToSubstitute is set to true and the sessions resolved configuration ends up getting replaced with an unresolved configuration that doesn't contain the required information for VSLS to properly initialize the debug session (ex: localPath, joinUniqueId, etc is missing) Resolved configuration is set correctly if substituteVariables isn't called: ! When subsituteVariables is called required debug configuration information is lost: !
Thanks a lot for filling this issue with great steps and detail. I have explained the reson what caused this regression in This pr is merged, so this should be fixed in the next stable and from Insiders tomorrow. I have verified this worked for me when doing a live share session with myself on my mac. Though it would be great if you can also verify
Thanks Verified this resolves the associated issues.
great, adding verified label!

Discussion:
} } <del> (needsToSubstitute ? this.substituteVariables(launch, unresolved) : TPromise.as(session.configuration)).then(resolved => { </del> <ins> let configPromise = TPromise.as(session.configuration); if (needsToSubstitute) { configPromise = this.configurationManager.resolveConfigurationByProviders(launch.workspace && launch.workspace.uri, unresolved.type, unresolved) .then(resolved => this.substituteVariables(launch, resolved)); } configPromise.then(resolved => { </ins> session.setConfiguration({ resolved, unresolved }); session.configuration.__restart = restartData;
Change:
Issue Type: <bBug</bOpen settings in JSON view. ! VS Code version: Code 1.27.2 (, 2018-09-12T16:17:45.060Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.546 --<!-- potentialduplicatescomment --

Discussion:
justify-content: flex-start; } <ins> .default-preferences-editor-container > .preferences-header-container > .default-preferences-header, </ins> .settings-tabs-widget > .monaco-action-bar .action-item { padding: 3px 0px; }
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Try catch block to snippets

Discussion:
"#endregion" ], "description": "Folding Region End" <ins> }, "Try Catch Block": { "prefix": "try", "body": [ "try {", "t${1://code...}", "} catch (Exception $$e) {", "t${2://throw $$e;}", "}" ], "description": "Try catch block" </ins> } }  No newline at end of file
Change:
The Undo Last Commit currently behaves like : it undoes the commit and discards anything that has been staged. If I had previously carefully files or hunks to the stage, this work is lost. I think it would be better to switch to the behavior: If adding to index was carefully done, this work would be preserved. If the users wants the behavior, i.e., reset all the staged files, VSCode already has a convenient button for that. Because of the latter point, I'd propose VSCode changes the behavior, not introduce an option for mixed vs. soft behavior.
I’d like to work on this if it’s agreed to move ahead with the change. For the record, I agree with the proposed change, but I could also see this as a configuration to preserve behavior for users used to it.
Fixed by

Discussion:
} async reset(treeish: string, hard: boolean = false): Promise<void> { <del> const args = ['reset']; if (hard) { args.push('--hard'); } args.push(treeish); </del> <ins> const args = ['reset', hard ? '--hard' : '--soft', treeish]; </ins> await this.run(args); }
Change:
Issue Type: <bBug</ban editor the find widget the editor size so that it is quite narrow Bug Find widget has overlapping elements: <img width="442" alt="screen shot 2018-10-02 at 1 48 52 pm" src="https://user-"VS Code version: Code 1.28.0 (, 2018-10-04T16:40:40.180Z) OS version: Darwin x64 18.0.0 <details<summarySystem Info</summary </details<!-- generated by issue reporter --
I still see this in !
Verified from source

Discussion:
/* COLLAPSED (SMALLER THAN NARROW) */ .monaco-editor .find-widget.collapsed-find-widget { <del> max-width: 111px !important; </del> <ins> max-width: 170px !important; </ins> } .monaco-editor .find-widget.collapsed-find-widget .button.previous,
Change:
Issue Type: <bBug</b"Open File" shortcut/command does not work on an opened diff-view file if the working tree becomes clean (e.g. after a commit). Oddly, pressing the button near the top right corner for this action does work. "Open Changes" in a file doesn't work on a clean tree which is expected, but going from a diff-view back to the file after changes have been committed should be a valid flow IMO. It'd be nice to have a shortcut by default to toggle between the two. Repro steps: a dirty working tree to the modified file via "Open Changes" button or shortcut that diff-view file open commit the changes to "Open File" via the command pallette (shift+cmd P) -"Git: Open File", nothing happens on the "Open File" button near top right corner. This takes me to the corresponding file. VS Code version: Code 1.28.0 (, 2018-10-04T16:40:40.180Z) OS version: Darwin x64 18.0.0 <!-- generated by issue reporter --

Discussion:
uris = resources.map(r => r.resourceUri); } <ins> else { uris = [(window.activeTextEditor && window.activeTextEditor.document.uri)] as Uri[]; } </ins> } if (!uris) {
Change:
Issue Type: <bBug</bCreate a repo with a name that contains one or more spaces. Put something in it eg a and then attempt to clone it via VS Code. VS Code fails to URL encode the URL, and fails to quote the folder name that it creates. I copied the generated git command and did those things to it and then it worked as expected. VS Code version: Code 1.28.0 (, 2018-10-05T14:58:53.203Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (11)</summaryExtensionVersion ------ vscode-css-formatter1.0.1 aurelia1.0.3 xml2.3.2 gitlens8.5.6 vscode-test-explorer2.0.9 reg0.0.2 mssql1.4.0 csharp1.16.2 PowerShell1.9.0 vsliveshare0.3.735 team1.136.0 </details<!-- generated by issue reporter --
The reason I removed the Windows from the bug title is I suspect the problem will take much the same form with the same solution on all platforms.
Are there any news on this? I am hitting this issue quite often

Discussion:
await mkdirp(parentPath); try { <del> await this.exec(parentPath, ['clone', url, folderPath], { cancellationToken }); </del> <ins> await this.exec(parentPath, ['clone', url.includes(' ') ? encodeURI(url) : url, folderPath], { cancellationToken }); </ins> } catch (err) { if (err.stderr) { err.stderr = err.stderr.replace(/^Cloning.+$/m, '').trim();
Change:
Markdown preview urlencode link get arguments then broken links when pasting in a rich text document. VSCode Version: Version 1.28.0 2018-10-04T16:33:34.831Z OS Version: macOS Mojave 10.14 (18A391) Steps to Reproduce: a Markdown document with a link with parameters, i.e.: the preview link in a rich text document (in example mac Notes) the link, is broken. If you follow the link from the preview, it works, but if you follow the link from the rich text you get Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.537 --- <!-- score: 0.5 --<!-- potentialduplicatescomment --
I'm not able to reproduce this. How are you copying the link? In the markdown preview or in the editor?
Hi I'm copying from the Preview pane.
Here a screenshot with the link urlencoded: ! Lots of thanks
How are you copying that link?
I'm copying the link in the preview pane selecting the text with the mouse and pressing Command & C keys simultaneously. Today I installed and then, works fine.
Notes for repo: I can't figure out how to copy the link from the preview hover but on macos you can just drag the link to textedit

Discussion:
try { const externalSchemeUri = getUriForLinkWithKnownExternalScheme(link); if (externalSchemeUri) { <del> return normalizeLink(externalSchemeUri.toString()); </del> <ins> // set true to skip encoding return normalizeLink(externalSchemeUri.toString(true)); </ins> }
Change:
Right now we can do pull but not push with Git's API . We are looking into allowing users to create pull request from the extension but without this API, we can only execute git command ourselves. Not sure about the cost of adding this API, the shape of in my mind can be like .
Fixed by

Discussion:
pull(): Promise<void> { return this._repository.pull(); } <ins> push(head: Branch): Promise<void> { return this._repository.push(head); } pushTo(remote?: string, name?: string, setUpstream: boolean = false): Promise<void> { return this._repository.pushTo(remote, name, setUpstream); } </ins> } export class ApiGit implements Git {

fetch(remote?: string, ref?: string): Promise<void>; pull(): Promise<void>; <ins> push(head: Branch): Promise<void>; pushTo(remote?: string, name?: string, setUpstream?: boolean): Promise<void>; </ins> } export interface API {
Change:
Tweak label option for outputs action bar select box as "Output Channels." for better readability.
Fixed with PR

Discussion:
@IThemeService themeService: IThemeService, @IContextViewService contextViewService: IContextViewService ) { <del> super(null, action, [], 0, contextViewService, { ariaLabel: nls.localize('outputs', 'Outputs') }); </del> <ins> super(null, action, [], 0, contextViewService, { ariaLabel: nls.localize('outputChannels', 'Output Channels.') }); </ins> let outputChannelRegistry = Registry.as<IOutputChannelRegistry>(OutputExt.OutputChannels); this.toDispose.push(outputChannelRegistry.onDidRegisterChannel(() => this.updateOtions(this.outputService.getActiveChannel().id)));
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --! ! <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.28.1 OS Version: macOS Sierra 10.12.6 (1st screenshot); and Windows 10 Version 1803 (2nd screenshot) Steps to Reproduce: VS Code, in Icon Theme to Release Notes (from "Show Release Notes" command) the icon is an overlap between generic file icon (!) and VS Code icon (!). --! This issue does not happen when I set Icon Theme to or <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes

Discussion:
if (URI.isUri(value)) { cssRules.push(`${webviewSelector} { content: ""; background-image: url(${value.toString()}); }`); } else { <del> cssRules.push(`${webviewSelector} { content: ""; background-image: url(${value.light.toString()}); }`); </del> <ins> cssRules.push(`.vs ${webviewSelector} { content: ""; background-image: url(${value.light.toString()}); }`); </ins> cssRules.push(`.vs-dark ${webviewSelector} { content: ""; background-image: url(${value.dark.toString()}); }`); } });
Change:
please provide a "Delete Record" button when the "Path does not exist" dialog box pops up in the "Recent" tab of the initial welcome screen
Currently when the path does not exists for the recent folder uri, it gets deleted from vscode state. It will not be shown again. What is actually expected?
It doesn't like what you said. !
I am using version 1.28.2 Which version of vscode you are using?
VS Code version: Code - Insiders 1.29.0-insider (, 2018-10-19T06:58:45.940Z) OS version: Windows_NT x64 10.0.
That page is now gone but issue remains that Getting Started's recent list should be better synced with ctrl+r's.
The open recent list should now be better linked to the getting started screen. So feel free to delete and clear issues there
To verify ensure deleting something from the open recent menu also deletes it from the walkthrough's recent section

Discussion:
})); this.recentlyOpened = workspacesService.getRecentlyOpened(); <ins> this._register(workspacesService.onDidChangeRecentlyOpened(() => { this.recentlyOpened = workspacesService.getRecentlyOpened(); rerender(); })); </ins> } // remove when 'workbench.welcomePage.preferReducedMotion' deprecated
Change:
The color of Gitter badge doesn't align with the other badges which adds a bit of nonuniformity.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.553 --- <!-- score: 0.486 --- <!-- score: 0.482 --<!-- potentialduplicatescomment --

Discussion:
[![Build Status](https://vscode.visualstudio.com/_apis/public/build/definitions/a4cdce18-a05c-4bb8-9476-5d07e63bfd76/1/badge?branchName=master)](https://aka.ms/vscode-builds) [![Feature Requests](https://img.shields.io/github/issues/Microsoft/vscode/feature-request.svg)](https://github.com/Microsoft/vscode/issues?q=is%3Aopen+is%3Aissue+label%3Afeature-request+sort%3Areactions-%2B1-desc) [![Bugs](https://img.shields.io/github/issues/Microsoft/vscode/bug.svg)](https://github.com/Microsoft/vscode/issues?utf8=✓&q=is%3Aissue+is%3Aopen+label%3Abug) <del> [![Gitter](https://img.shields.io/badge/chat-on%20gitter-blue.svg)](https://gitter.im/Microsoft/vscode) </del> <ins> [![Gitter](https://img.shields.io/badge/chat-on%20gitter-yellow.svg)](https://gitter.im/Microsoft/vscode) </ins> [VS Code](https://code.visualstudio.com) is a new type of tool that combines the simplicity of a code editor with what developers need for their core edit-build-debug cycle. Code
Change:
Issue Type: <bBug</bwhen clicking the percentage at the bottom-right of the state bar,zooming function won't work, and the aspect ratio changes to abnormal value. VS Code version: Code 1.28.1 (, 2018-10-11T18:13:53.910Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (9)</summaryExtensionVersion ------ intellij-idea-keybindings0.2.27 vscode-language-pack-zh-hans1.28.2 mssql1.4.0 java0.32.0 vscode-java-debug0.14.0 vscode-java-pack0.4.0 vscode-java-test0.10.0 vscode-maven0.11.1 markdown-all-in-one1.6.2 </details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.47 --<!-- potentialduplicatescomment --

Discussion:
DOM.removeClass(image, 'scale-to-fit'); image.style.minWidth = `${(image.naturalWidth * scale)}px`; <del> image.style.widows = `${(image.naturalWidth * scale)}px`; </del> <ins> image.style.width = `${(image.naturalWidth * scale)}px`; </ins> const newWidth = image.width; const scaleFactor = (newWidth - oldWidth) / oldWidth;
Change:
Currently, as far as I am aware, the only accepted language identifiers for C# code blocks in the markdown preview are and . Other markdown previewers, like github and gitlab issue trackers, supports a third alternative: , as the following: csharp public int M() =2; //works everywhere c# public int M() =2; //doesn't work in vscode markdown preview My feature is request is for vscode to allow the mentioned alternative identifier. I also noticed something strange: the identifier works inside the editor, but not in the preview. I'd call this an inconsistency. !

Discussion:
if (lang && lang.toLocaleLowerCase() === 'json5') { lang = 'json'; } <ins> if (lang && lang.toLocaleLowerCase() === 'c#') { lang = 'cs'; } </ins> if (lang && hljs.getLanguage(lang)) { try { return `<div>${hljs.highlight(lang, str, true).value}</div>`;
Change:
Issue Type: <bBug</bIn the September release, we updated the suggest widget to respect the class. See The recent changes in the suggest widget for has caused a regression and brought the icons back when class is set on the widget. VS Code version: Code - Insiders 1.29.0-insider (, 2018-10-19T06:50:39.461Z) OS version: Darwin x64 15.6.0 <!-- generated by issue reporter --
I still see icons in the Setting suggest widget: !
I meant the settings search <img width="646" alt="screen shot 2018-11-02 at 10 15 38 am" src="https://user-"

Discussion:
display: none; } <del> .monaco-editor .suggest-widget.no-icons .monaco-list .monaco-list-row .icon { </del> <ins> .monaco-editor .suggest-widget.no-icons .monaco-list .monaco-list-row .icon, .monaco-editor .suggest-widget.no-icons .monaco-list .monaco-list-row .monaco-icon-label.suggest-icon::before { </ins> display: none; }
Change:
Environment Details: VSCode Version : 1.25.0 OS Version : Win10 Additional Details: HighContrast,MAS1.4.3 Repro Steps: Visual Studio code desktop application. to "Plain Text" of "Status Bar"-Enter "PowerShell" in "Select Language Mode" combo box-Write the PowerShell Code in plain editor-Save the editor. to Setting button of Activity Bar and select "Color Theme" option. Themes shows number of different colors list apply all that theme on the editor. color contrast analyser and check the color contrast ratio. shows color contrast ratio less than expected color contrast ratio. Actual: After applying color themes to editor it shows color contrast ratio as 3.5:1 eg. Select "QuietLight" theme from color theme list and check for the color contrast ratio. Expected: The expected colorcontrast ratio should be greater than or equals to 7:1 ratio. Recommendations: Refer below link which is repository of bug fixes code  User Impact: User will not able to see the content of the editor. MAS Reference: MAS1.4.3- Attachment For Reference: ! Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.701 --- <!-- score: 0.617 --- <!-- score: 0.552 --- <!-- score: 0.508 --<!-- potentialduplicatescomment --
I believe you are using the wrong color contrast ratio. From the link you provided: We've only been targeting the minimum contrast ratio, which is Level AA at 4.5:1

Discussion:
"storage" ], "settings": { <del> "foreground": "#4B83CD" </del> <ins> "foreground": "#4B69C6" </ins> } }, {

"name": "Strings: Regular Expressions", "scope": "string.regexp", "settings": { <del> "foreground": "#4B83CD" </del> <ins> "foreground": "#4B69C6" </ins> } }, {

"name": "HTML: Tag Names", "scope": "entity.name.tag", "settings": { <del> "foreground": "#4B83CD" </del> <ins> "foreground": "#4B69C6" </ins> } }, {

"name": "Markup: Link", "scope": "meta.link", "settings": { <del> "foreground": "#4B83CD" </del> <ins> "foreground": "#4B69C6" </ins> } }, {

"name": "Markup Lists", "scope": "markup.list", "settings": { <del> "foreground": "#4B83CD" </del> <ins> "foreground": "#4B69C6" </ins> } }, {

"panel.background": "#F5F5F5", "sideBar.background": "#F2F2F2", "sideBarSectionHeader.background": "#ede8ef", <del> "editorLineNumber.foreground": "#9DA39A", </del> <ins> "editorLineNumber.foreground": "#6D705B", </ins> "editorCursor.foreground": "#54494B", "inputOption.activeBorder": "#adafb7", "dropdown.background": "#F5F5F5",
Change:
This clear option can be into the exiting task property and would be called : { "label": "ExampleTask", "type": "shell", "command": "echo hello", "presentation": { "echo": true, "reveal": "always", "focus": false, "panel": "shared", "showReuseMessage": true, "clear": false } } Added to : / Controls how the task is presented in the UI. / export interface TaskPresentationOptions { …. / Controls whether the terminal is cleared before executing the task. / clear?: boolean; }
This doesn't work for me: I run it multiple times and see all the output, the terminal is never cleared.
Turns out that if the only presentation option set is clear, this doesn't work. Thanks for finding!

Discussion:
* Controls whether to show the "Terminal will be reused by tasks, press any key to close it" message. */ showReuseMessage?: boolean; <ins> /** * Controls whether the terminal is cleared before executing the task. */ clear?: boolean; </ins> } /**

//#endregion //#region Task <del> /** * Controls how the task is presented in the UI. */ export interface TaskPresentationOptions { /** * Controls whether the terminal is cleared before executing the task. */ clear?: boolean; } </del> export enum RerunBehavior { reevaluate = 1, useEvaluated = 2,