Change:
going to keep track of examples here to see if there's a pattern <img width="1112" alt="Screenshot 2023-01-23 at 2 12 18 PM" src="https://user-"
far right terminal <img width="1120" alt="Screenshot 2023-01-23 at 3 07 17 PM" src="https://user-"
middle terminal !
far right terminal !
far right terminal <img width="1076" alt="Screenshot 2023-01-24 at 1 59 40 PM" src="https://user-"
right terminal <img width="1644" alt="Screenshot 2023-01-24 at 2 22 27 PM" src="https://user-"
right terminal !
here are the lines when there's not a quick fix result - it contains after which we don't account for here !
Seeing this frequently: <img width="726" alt="image" src="https://user-"
I think we just need to include the to fix this
or better yet, remove and just look for the link
ok I see the issue. when lines are wrapped a lot, we need to search more lines - setting the length to 10/15 fixes it even when the terminal is quite narrow
I see it on non-wrapped lines, I'm not sure I understand what you mean with the To?
The to comment above was actually wrong. What's happened in the screen shot above is we abort the search early - after looking at only 5 lines. When it's actually on line 9
this goes wrong when we break before reaching the content IE when line count length
I tried pushing up a new branch using pwsh in the integrated terminal on Windows, and the lightbulb did not show. !
you have shell integration disabled, it won't work at all there.
also make sure to not move issues to the next milestone, this one was marked important
Working much better now, but just reproduced !
Just happened and captured the trace log (escape sequence log would be better): <img width="806" alt="image" src="https://user-"
I've seen this not work twice today already for create PR !
even though the lightbulb didn't appear here, there was a match found !
the match always happens, the lightbulb doesn't show up though until I resize the terminal
this happens when the have not yet been resolved by the time occurs ! !
I think we should be calling at the end of
have seen the create PR not show up 3 times today. resizing doesn't cause it to show up, which means our match range is wrong/ there isn't a match
this says unreleased, but was merged before the current version of insider's (5 hours ago) was released. create with PR still failing !
insider's is based on the release branch, so I was confused
<!-- UNABLETOLOCATECOMMITMESSAGE issue --Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting , or directly add the label if you know this has already been releaased

Discussion:
const matcher = outputMatcher.lineMatcher; const linesToCheck = typeof matcher === 'string' ? 1 : outputMatcher.length || countNewLines(matcher); const lines: string[] = []; <del> let wrappedLines = 1; </del> let match: RegExpMatchArray | null | undefined; if (outputMatcher.anchor === 'bottom') { for (let i = endLine - (outputMatcher.offset || 0); i >= startLine; i--) {

i = wrappedLineStart; lines.unshift(getXtermLineContent(buffer, wrappedLineStart, wrappedLineEnd, cols)); if (!match) { <del> match = lines.join('n').match(matcher); wrappedLines++; </del> <ins> match = lines[0].match(matcher); </ins> } <del> if (wrappedLines >= linesToCheck) { </del> <ins> if (lines.length >= linesToCheck) { </ins> break; } }

i = wrappedLineEnd; lines.push(getXtermLineContent(buffer, wrappedLineStart, wrappedLineEnd, cols)); if (!match) { <del> match = lines.join('n').match(matcher); </del> <ins> match = lines[lines.length - 1].match(matcher); </ins> } <del> if (wrappedLines >= linesToCheck) { </del> <ins> if (lines.length >= linesToCheck) { </ins> break; } }

commandLineMatcher: GitPushCommandLineRegex, // Example output: // ... <del> // 9:  remote: // 8:  remote: Create a pull request for 'my_branch' on GitHub by visiting: // 7:  remote:      https://github.com/microsoft/vscode/pull/new/my_branch // 6:  remote: // 5:  remote: GitHub found x vulnerabilities on microsoft/vscode's default branch (...). To find out more, visit: // 4:  remote:      https://github.com/microsoft/vscode/security/dependabot // 3:  remote: // 2:  To https://github.com/microsoft/vscode // 1:  * [new branch]              my_branch -> my_branch // 0:  Branch 'my_branch' set up to track remote branch 'my_branch' from 'origin'. </del> <ins> // 10: remote: // 9:  remote: Create a pull request for 'my_branch' on GitHub by visiting: // 8:  remote:      https://github.com/microsoft/vscode/pull/new/my_branch // 7:  remote: // 6:  remote: GitHub found x vulnerabilities on microsoft/vscode's default branch (...). To find out more, visit: // 5:  remote:      https://github.com/microsoft/vscode/security/dependabot // 4:  remote: // 3:  To https://github.com/microsoft/vscode // 2:  * [new branch]              my_branch -> my_branch // 1:  Branch 'my_branch' set up to track remote branch 'my_branch' from 'origin'. // 0: </ins> outputMatcher: { lineMatcher: GitCreatePrOutputRegex, anchor: 'bottom', <del> offset: 3, length: 6 </del> <ins> offset: 4, // ~6 should only be needed here for security alerts, but the git provider can customize // the text, so use 12 to be safe. length: 12 </ins> }, commandExitResult: 'success', getQuickFixes: (matchResult: ITerminalCommandMatchResult) => {