jiebi/CodeConvo huggingface dataset:
Change:
Issue Type: <bBug</bAs of TypeScript 2.9, is enabled by default on a new ts project, however the error list does not seem to pick these up from build. Is there anything specific on the TS side to add to the errors to make the errors grokable by the error list? here are steps to reproduce add a .ts file with errors build VS Code version: Code 1.22.2 (, 2018-04-12T16:38:45.278Z) OS version: Windows_NT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (1)</summaryExtensionVersion ------ xml1.9.2 </details<!-- generated by issue reporter --ed by issue reporter --
You can add a new problem matcher that matches pretty output:
Looks like the tsc problem matcher does not handle output for locations.. So we can either change it on our side and have emit the same file name/line number similar to the non-pretty mode, or we can add a new problem matcher regex or modify the tsc problem matcher. what would be your preference?
I fixed it on our end. Having two problem matchers is not nice for the users. one thing: the fix now assumes that a message only contains line,column information and never line,column,endline,endcolumn which was possible with the old matcher. But to my knowledge TS always emitted line,column only. Right?
please review and merge if you think the fix is fine.

Discussion:
"problemPatterns": [ { "name": "tsc", <del> "regexp": "^([^s].*)((d+|d+,d+|d+,d+,d+,d+)):s+(error|warning|info)s+(TSd+)s*:s*(.*)$", </del> <ins> "regexp": "^([^s].*)[(:](d+)[,:](d+)(?:):s+|s+-s+)(error|warning|info)s+(TSd+)s*:s*(.*)$", </ins> "file": 1, <del> "location": 2, "severity": 3, "code": 4, "message": 5 </del> <ins> "line": 2, "column": 3, "severity": 4, "code": 5, "message": 6 </ins> } ], "problemMatchers": [
Change:
This would be quite nice to have for us. Also it allows the and param on url, so we just need to include a few variations of the issue templates in our repo and update issue reporter to choose the param depending on the issue type. !
Great suggestion, I updated the issue templates. I don't think the issue reporter needs to be updated, since the body it generates always overwrites the content of the template

Discussion:
<ins> --- name: Bug report about: Create a report to help us improve --- <!-- Please search existing issues to avoid creating duplicates. --> <!-- Use Help > Report Issue to prefill these. --> - VSCode Version: - OS Version: Steps to Reproduce: 1. 2. <!-- Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: Yes/No </ins>

<ins> --- name: Feature request about: Suggest an idea for this project --- <!-- Please search existing issues to avoid creating duplicates. --> <!-- Describe the feature you'd like. --> </ins>

<ins> --- name: Question about: The issue tracker is not for questions. Please ask questions on https://stackoverflow.com/questions/tagged/vscode. --- 🚨 The issue tracker is not for questions 🚨 If you have a question, please ask it on https://stackoverflow.com/questions/tagged/vscode. </ins>

<del> <!-- Do you have a question? Please ask it on https://stackoverflow.com/questions/tagged/vscode. For bug reports, please fill in the details below. For feature requests, please describe the desired feature. --> <!-- Use Help > Report Issue to prefill these. --> - VSCode Version: - OS Version: Steps to Reproduce: 1. 2. <!-- Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: Yes/No </del>
Change:
The icon is svg, but not pixel perfext, just like bitmap. I am using macOS 10.13. !

Discussion:
.monaco-workbench > .activitybar > .content .monaco-action-bar .action-label.extensions { -webkit-mask: url('extensions-dark.svg') no-repeat 50% 50%; <del> -webkit-mask-size: 22px; </del> <ins> -webkit-mask-size: 21px; </ins> }  No newline at end of file
Change:
There are some project for which I'm always greeted with a warning like this when opening them:  This is a bit annoying, as there's nothing actually "wrong" - I don't need all submodules to be auto-detected for my workflow. I tried this setting in the hopes that it would get rid of the warning: However, it doesn't actually get rid of the warning, which seems like a bug, or at least counter-intuitive behavior. Increasing does work, but as I said, I don't really need all submodules to be auto-detected, I just want the warning to go away, and I'm concerned that this has a performance impact. __ VSCode version: 
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.48 --<!-- potentialduplicatescomment --
It looks like a possible workaround is to specify both settings: The first one avoids the auto-detection, the second one gets rid of the warning.

Discussion:
const changeListener = repository.onDidChangeRepository(uri => this._onDidChangeRepository.fire({ repository, uri })); const originalResourceChangeListener = repository.onDidChangeOriginalResource(uri => this._onDidChangeOriginalResource.fire({ repository, uri })); <ins> const detectSubmodules = workspace .getConfiguration('git', Uri.file(repository.root)) .get<boolean>('detectSubmodules') as boolean; </ins> const submodulesLimit = workspace .getConfiguration('git', Uri.file(repository.root)) .get<number>('detectSubmodulesLimit') as number; const checkForSubmodules = () => { <del> if (repository.submodules.length > submodulesLimit) { </del> <ins> if (detectSubmodules && repository.submodules.length > submodulesLimit) { </ins> window.showWarningMessage(localize('too many submodules', "The '{0}' repository has {1} submodules which won't be opened automatically. You can still open each one individually by opening a file within.", path.basename(repository.root), repository.submodules.length)); statusListener.dispose(); }
Change:
<!-- Do you have a question? Please ask it on For bug reports, please fill in the details below. For feature requests, please describe the desired feature. --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.23.1 OS Version: Windows 10 Enterprise Ver.1703 build .877 Im trying action. but, this action working only absolute path. is working code (absolute path) ex: - Emmet: Update Image size -not working code (root relative path) ex: - Emmet: Update Image size -its not working... <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: No
Thanks for reporting PRs are welcome to fix this issue. The code behind this feature is at
Hi, I'm interested in this bug. I noticed the person filing the bug gives as a example of a working path. I believe that path means that in the current working directory there should be folder called that has another folder named which has photo in it. However, is given as an example of the command not working. It is true that this path doesn't work but I believe that is intentional. at the beginning means it starts at the root and because of that it may be looking for in a different spot in the directory. For example, if my absolute path to a image is like this: and the location to the html file being editing is in here: I can't run the command with this code: But I can run it on this: and this: Hopefully this information is useful.
Thanks for the detailed analysis I can confirm your findings. Can you share what your folder structure is? Unless folder is directly under root, we cannot expect the command to work on Also see
thx comments. I can be submitted sample folder structure. Sample folder structure is working code of path: is not working code of path but, code is Ctrl + LClick (img Preview) is working. because I think passed root path of VSCode.
Are you on Windows, Linux or Mac?
Windows
Ctrl+Click will navigate to the image file in the first 2 cases as expected in both Mac and Windows The works on all 3 cases in Mac, but only the first case in Windows. So, at the very least, we can look into if we can get the second case working to keep the experience consistent between the Ctrl+Click and the Emmet experience

Discussion:
import * as path from 'path'; import * as fs from 'fs'; <del> const reAbsolute = /^/+/; </del> <ins> const reAbsolutePosix = /^/+/; const reAbsoluteWin32 = /^+/; const reAbsolute = path.sep === '/' ? reAbsolutePosix : reAbsoluteWin32; </ins> /** * Locates given `filePath` on user’s file system and returns absolute path to it.
Change:
Currently the sync icon will sync with pull and merge, which results in undesirable (in my case) merge commits. ! It would be helpful if there was a "Sync with rebase" option for clicking this icon. I see a PR was performed to add Sync (Rebase) command (, though I still don't even see this command in the git menu for 1.23.1 today?), but this does not apply to clicking the actual icon. A setting to change its default value would be great.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.479 --<!-- potentialduplicatescomment --
shouldn't the setting text say something like instead of saying . If a branch is already configured to use rebase by default this setting has no effect (i.e. unchecking the box does not use merge)

Discussion:
"scope": "resource", "default": 10, "description": "%config.detectSubmodulesLimit%" <ins> }, "git.syncRebase": { "type": "boolean", "scope": "resource", "default": false, "description": "%config.syncRebase%" </ins> } } },

"config.detectSubmodules": "Controls whether to automatically detect git submodules.", "colors.added": "Color for added resources.", "config.detectSubmodulesLimit": "Controls the limit of git submodules detected.", <ins> "config.syncRebase": "Synchronize changes using rebase.", </ins> "colors.modified": "Color for modified resources.", "colors.deleted": "Color for deleted resources.", "colors.untracked": "Color for untracked resources.",

'use strict'; <del> import { Disposable, Command, EventEmitter, Event } from 'vscode'; </del> <ins> import { Disposable, Command, EventEmitter, Event, workspace } from 'vscode'; </ins> import { Branch } from './git'; import { Repository, Operation } from './repository'; import { anyEvent, dispose } from './util';

if (HEAD && HEAD.name && HEAD.commit) { if (HEAD.upstream) { <ins> const config = workspace.getConfiguration('git'); const gitSyncRebase = config.get<string>('syncRebase'); </ins> if (HEAD.ahead || HEAD.behind) { text += this.repository.syncLabel; } <del> command = 'git.sync'; </del> <ins> if (gitSyncRebase) { command = 'git.syncRebase'; } else { command = 'git.sync'; } </ins> tooltip = localize('sync changes', "Synchronize Changes"); } else { icon = '$(cloud-upload)';
Change:
The prompt as part of , looks like the below: ! If the user's locale was Hungarian to begin with, then all they need to do is restart VS Code to activate the language pack. Setting the file is not necessary. I propose as a fix cc

Discussion:
if (!this.storageService.getBoolean(donotAskUpdateKey) && e.local && e.operation === InstallOperation.Install && e.local.manifest.contributes && e.local.manifest.contributes.localizations && e.local.manifest.contributes.localizations.length) { const locale = e.local.manifest.contributes.localizations[0].languageId; if (platform.language !== locale) { <ins> const updateAndRestart = platform.locale !== locale; </ins> this.notificationService.prompt( Severity.Info, <del> localize('updateLocale', "Would you like to change VS Code's UI language to {0} and restart?", e.local.manifest.contributes.localizations[0].languageName || e.local.manifest.contributes.localizations[0].languageId), </del> <ins> updateAndRestart ? localize('updateLocale', "Would you like to change VS Code's UI language to {0} and restart?", e.local.manifest.contributes.localizations[0].languageName || e.local.manifest.contributes.localizations[0].languageId) : localize('activateLanguagePack', "Would you like to restart VS Code to activate the language pack that was just installed?"), </ins> [{ label: localize('yes', "Yes"), run: () => { const file = URI.file(join(this.environmentService.appSettingsHome, 'locale.json')); <del> this.jsonEditingService.write(file, { key: 'locale', value: locale }, true) .then(() => this.windowsService.relaunch({}), e => this.notificationService.error(e)); </del> <ins> const updatePromise = updateAndRestart ? this.jsonEditingService.write(file, { key: 'locale', value: locale }, true) : TPromise.as(null); updatePromise.then(() => this.windowsService.relaunch({}), e => this.notificationService.error(e)); </ins> } }, { label: localize('no', "No"),
Change:
Extending Have 1.txt Copy/paste it in the file explorer Get
fyi
I’ll fix it.

Discussion:
}); } <ins> // 1.txt=>2.txt let prefixFileNoNameRegex = RegExp('(d+)(..*)$'); if (!isFolder && name.match(prefixFileNoNameRegex)) { return name.replace(prefixFileNoNameRegex, (match, g1?, g2?) => { let number = parseInt(g1); return number < maxNumber ? strings.pad(number + 1, g1.length) + g2 : strings.format('{0}.1{1}', g1, g2); }); } </ins> // file.txt=>file.1.txt const lastIndexOfDot = name.lastIndexOf('.'); if (!isFolder && lastIndexOfDot >= 0) {

assert.strictEqual(result, '2.test.js'); }); <ins> test('Increment file name with just version in name', function () { const name = '1.js'; const result = incrementFileName(name, false); assert.strictEqual(result, '2.js'); }); test('Increment file name with just version in name, too big number', function () { const name = '9007199254740992.js'; const result = incrementFileName(name, false); assert.strictEqual(result, '9007199254740992.1.js'); }); </ins> test('Increment file name with prefix version, trailing zeros', function () { const name = '001.test.js'; const result = incrementFileName(name, false);
Change:
Changing display language (either via the command or editing the file directly) needs restart to take effect, but user is not notified of the same. I would suggest that we show a prompt that would say something like . Options being and .
Makes sense
The command seems to just open for editing. has default contents: Do we need more notification than that line right above? If so should this be implemented on save? Or what?
Honestly, thats the first time I saw that message in the comments. Even though... its right there! I believe having a notification still helps. Especially because in this case we need a restart (close all windows and start again. In Mac, quit and restart) and not just a reload on the single window. It should show up after the file is saved if is not the same as what was just configured. I am not sure if we are firing any events when the locale is changed. If we do, then you can piggy back on that. If we don't and its not trivial to add one, then I am ok with closing this issue given that the comment has the instruction to restart.
There is currently no event. Major reason being is that the locale is computed as one of the first things when VS Code starts and is then used to configure or loader. So it can't change dynamically hence no event and the reason for needed a restart. I see the point that the message can easily be over read. We can either add a message on save or we can restructure the file to make it easier to detect. Something like:

Discussion:
'{', `t// ${localize('displayLanguage', 'Defines VSCode's display language.')}`, `t// ${localize('doc', 'See {0} for a list of supported languages.', 'https://go.microsoft.com/fwlink/?LinkId=761051')}`, <del> `t// ${localize('restart', 'Changing the value requires restarting VSCode.')}`, `t"locale":"${language}"`, </del> <ins> `t`, `t"locale":"${language}" // ${localize('restart', 'Changes will not take effect until VSCode has been restarted.')}`, </ins> '}' ].join('n');
Change:
I have these keybinding: Currently it doesn't center the viewport like F3, which makes it less nice.
You mean you want it to center the viewport when the editor needs to be scrolled?
I'm interested to work on this as my first issue. Will you point me in the right direction
Looks like a PR is already out

Discussion:
const position = new Position(change.modifiedStartLineNumber, 1); outerEditor.setPosition(position); <del> outerEditor.revealPosition(position); </del> <ins> outerEditor.revealPositionInCenter(position); </ins> } } registerEditorAction(MoveToPreviousChangeAction);

const position = new Position(change.modifiedStartLineNumber, 1); outerEditor.setPosition(position); <del> outerEditor.revealPosition(position); </del> <ins> outerEditor.revealPositionInCenter(position); </ins> } } registerEditorAction(MoveToNextChangeAction);
Change:
When tabs are enabled, the close button is slightly larger and unbalances the tab. This button should be different than when tabs are disabled and the close button is moved to the editor toolbar. !

Discussion:
<del> <svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="3 3 16 16" enable-background="new 3 3 16 16"><polygon fill="#e8e8e8" points="12.597,11.042 15.4,13.845 13.844,15.4 11.042,12.598 8.239,15.4 6.683,13.845 9.485,11.042 6.683,8.239 8.238,6.683 11.042,9.486 13.845,6.683 15.4,8.239"/></svg> </del>  No newline at end of file <ins> <svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M9.784 8L13 11.217 11.215 13 8.001 9.786 4.785 13 3 11.216l3.214-3.215L3 4.785 4.784 3 8 6.216 11.216 3 13 4.785 9.784 8.001z" fill="#C5C5C5"/></svg> </ins>  No newline at end of file

<del> <svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="3 3 16 16" enable-background="new 3 3 16 16"><polygon fill="#424242" points="12.597,11.042 15.4,13.845 13.844,15.4 11.042,12.598 8.239,15.4 6.683,13.845 9.485,11.042 6.683,8.239 8.238,6.683 11.042,9.486 13.845,6.683 15.4,8.239"/></svg> </del>  No newline at end of file <ins> <svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M9.784 8L13 11.217 11.215 13 8.001 9.786 4.785 13 3 11.216l3.214-3.215L3 4.785 4.784 3 8 6.216 11.216 3 13 4.785 9.784 8.001z" fill="#424242"/></svg> </ins>  No newline at end of file

<del> <svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M9.784 8L13 11.217 11.215 13 8.001 9.786 4.785 13 3 11.216l3.214-3.215L3 4.785 4.784 3 8 6.216 11.216 3 13 4.785 9.784 8.001z" fill="#C5C5C5"/></svg> </del>  No newline at end of file <ins> <svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M9.428 8L12 10.573 10.572 12 8 9.428 5.428 12 4 10.573 6.572 8 4 5.428 5.427 4 8 6.572 10.573 4 12 5.428 9.428 8z" fill="#E8E8E8"/></svg> </ins>  No newline at end of file

<del> <svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M9.784 8L13 11.217 11.215 13 8.001 9.786 4.785 13 3 11.216l3.214-3.215L3 4.785 4.784 3 8 6.216 11.216 3 13 4.785 9.784 8.001z" fill="#424242"/></svg> </del>  No newline at end of file <ins> <svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M9.428 8L12 10.573 10.572 12 8 9.428 5.428 12 4 10.573 6.572 8 4 5.428 5.427 4 8 6.572 10.573 4 12 5.428 9.428 8z" fill="#424242"/></svg> </ins>  No newline at end of file
Change:
I am just interacting with the extensions viewlet.
There is a in place that ensures never gets called if the gallery is not configured, so I don't see how this can happen. I am not able to repro either. Can you provide more details about your setup and what actions you were performing?
Perhaps it has something to do with not being invoked as a function. Perhaps should be at
Thanks That must be it. This got introduced in . This was supposed to cover the case of no gallery service. Can you fix this and see why the test case wasn't failing?

Discussion:
} getWorkspaceRecommendations(): TPromise<string[]> { <del> if (!this.isEnabled) { return TPromise.as([]); } </del> <ins> if (!this.isEnabled()) { return TPromise.as([]); } </ins> return this.fetchCombinedExtensionRecommendationConfig() .then(content => {

} test('ExtensionTipsService: No Prompt for valid workspace recommendations when galleryService is absent', () => { <del> instantiationService.stub(IExtensionGalleryService, 'isEnabled', false); return testNoPromptOrRecommendationsForValidRecommendations(mockTestData.validRecommendedExtensions); </del> <ins> const galleryQuerySpy = sinon.spy(); instantiationService.stub(IExtensionGalleryService, { query: galleryQuerySpy, isEnabled: () => false }); return testNoPromptOrRecommendationsForValidRecommendations(mockTestData.validRecommendedExtensions) .then(() => assert.ok(galleryQuerySpy.notCalled)); </ins> }); test('ExtensionTipsService: No Prompt for valid workspace recommendations during extension development', () => {
Change:
Environment Details: VSCode Version : 1.24.1 OS Version : WIN10 Additional Details: ScreenReaderNVDA[2018.2],JAWS[18.0.5038]MAS1.3.1,Voceover[MACOS High Sierra 10.13.5 Beta (17F70a)] Repro Steps: VS Code when NVDA is ON. to View(Alt+V) menu option and select "Extensions" from dropdown. to more button. what Screenreader reads. Actual: Screenreader reads as More button.It does not give extra information about the button what is inside the button. Same issue observed in Jaws and Voiceover also. Expected: Screenreader should give extra information about the button. Recommendations: Refer below link which is repository of bug fixes code snippets: User Impact: User unable to get the information about the button. MAS Reference: Does this issue occur when all extensions are disabled?: Yes Attachment For Reference
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.69 --- <!-- score: 0.59 --- <!-- score: 0.509 --- <!-- score: 0.484 --- <!-- score: 0.476 --<!-- potentialduplicates_comment --
We should make the title of the more action more descriptive. Feels like low hanging fruit -july
that "More" text is the same "More" used throughout the application's secondary actions, would we create a bespoke label for all of them, or find some way to generate it?
let's try to use the same label for all of them. Consistency.
Oh so just "More Actions" or something?
More Actions works for me.
I verified the bug on below environment and the issue is no longer reproduced hence close this bug. Version: 1.27.0-insider Commit: Date: 2018-08-27T07:36:47.732Z Electron: 2.0.7 Chrome: 61.0.3163.100 8.9.3 V8: 6.1.534.41 Architecture: x64
the issue is already closed, but thanks

Discussion:
private toggleDropdownMenu: () => void; constructor(toggleDropdownMenu: () => void) { <del> super(ToggleMenuAction.ID, nls.localize('more', "More"), null, true); </del> <ins> super(ToggleMenuAction.ID, nls.localize('moreActions', "More Actions..."), null, true); </ins> this.toggleDropdownMenu = toggleDropdownMenu; }