jiebi/CodeConvo huggingface dataset:
Change:
Start legacy protocol debug session Open something via "Open loaded scripts" scroll down ctrl+tab to switch to another doc ctrl+tab back to the newly opened script It's scrolled up to the top. Is it being closed/opened each time we switch away?
This problem is independent from the "Open Loaded Scripts" feature. To reproduce: debug a simple node hello world program and stop on entry in the CALL STACK select an internal module press Control-Tab twice (to switch between two editors) Observe: you loose the scroll position in the internal module
March to investigate
Workbench is not preserving scroll location of in memory resources. Same is true for diff view. Forwarding to since he probably already has an issue for this
I do but I cannot find it right now, PR welcome.
give me some code pointers for the PR and I can do it in debt week
we do it for and via the and methods that are actually defined in and we could probably push this down from and and just use it from textEditor for any input that has a resource
Ok, makes sense. Assigning to me and April to look into it
Related:
With landed, we keep the UI state when you switch editors, though we clear it when you close a tab. The rationale is that the lifecycle of these editors that have virtual resources is not known, as such we assume the view state can be ditched once the editor closes.
That sounds perfect!

Discussion:
import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { IEditorOptions } from 'vs/editor/common/config/editorOptions'; import { TextEditorOptions, EditorModel, EditorInput, EditorOptions } from 'vs/workbench/common/editor'; <ins> import { ResourceEditorInput } from 'vs/workbench/common/editor/resourceEditorInput'; </ins> import { BaseTextEditorModel } from 'vs/workbench/common/editor/textEditorModel'; import { UntitledEditorInput } from 'vs/workbench/common/editor/untitledEditorInput'; import { BaseTextEditor } from 'vs/workbench/browser/parts/editor/textEditor';

} protected restoreViewState(input: EditorInput) { <del> if (input instanceof UntitledEditorInput) { </del> <ins> if (input instanceof UntitledEditorInput || input instanceof ResourceEditorInput) { </ins> const viewState = this.loadTextEditorViewState(input.getResource().toString()); if (viewState) { this.getControl().restoreViewState(viewState);

return super.saveTextEditorViewState(arg1); } <del> if (arg1 instanceof UntitledEditorInput && !arg1.isDisposed()) { </del> <ins> if ((arg1 instanceof UntitledEditorInput || arg1 instanceof ResourceEditorInput) && !arg1.isDisposed()) { </ins> return super.saveTextEditorViewState(arg1.getResource().toString()); } }
Change:
Please use different badge colors for modified and renamed files in the git sidebar to provide better visual distinction, which is important if there are lots of changes - especially upon merging. Right now both use blue color and visually hardly distinguishable. I'd suggest orange color for some of them. :) !

Discussion:
<svg width="14px" height="14px" viewBox="0 0 100 100" xmlns="http://www.w3.org/2000/svg"> <del> <rect fill="#4668C5" x="0" y="0" width="100" height="100" rx="35" ry="35"/> </del> <ins> <rect fill="#CC6633" x="0" y="0" width="100" height="100" rx="35" ry="35"/> </ins> <text x="50" y="75" font-size="75" text-anchor="middle" style="font-family: Menlo, Monaco, Consolas, &quot;Droid Sans Mono&quot;, &quot;Inconsolata&quot;, &quot;Courier New&quot;, monospace, &quot;Droid Sans Fallback&quot;;" fill="white"> R </text>
Change:
VSCode Version: Code 1.11.1 (, 2017-04-06T13:58:12.954Z) OS Version: Windows_NT ia32 6.1.7601 Extensions: ; Steps to Reproduce: SCM icon and M show in front of the different file but the arrow and the + signs are not enough clear ! It would be nice if ot could be contrast increased... Besides that, the last release with keyboard new mapping system is really great!

Discussion:
const light = join(extension.description.extensionFolderPath, icon.light); const dark = join(extension.description.extensionFolderPath, icon.dark); createCSSRule(`.icon.${iconClass}`, `background-image: url("${URI.file(light).toString()}")`); <del> createCSSRule(`.vs-dark .icon.${iconClass}, hc-black .icon.${iconClass}`, `background-image: url("${URI.file(dark).toString()}")`); </del> <ins> createCSSRule(`.vs-dark .icon.${iconClass}, .hc-black .icon.${iconClass}`, `background-image: url("${URI.file(dark).toString()}")`); </ins> } }
Change:
<!-- Do you have a question? Please ask it on --- VSCode Version: $ code --version 11.1 OS Version: Ubuntu 14.04 Steps to Reproduce: vscode annoying warning about git version being 1.9 something appears. It is nice information to have, and its a good warning to show once, or twice, but please don't show it every time I open code. That is very annoying. I don't really care that much if the git features in vscode can work better with 2.x. I do not use these features that much and prefer to use other gui and cli tools anyways. Also, I prefer to stick with the version of git that comes with my Os's package manager by default. You should assume that is just what some people are going to want to do and perpetually pestering them to upgrade git is not very nice. So please, give me an easy and obvious way to dismiss the warning once and for all so it doesn't pop back up the next time I open vscode.

Discussion:
model ); <del> if (/^[01]/.test(info.version)) { const update = localize('updateGit', "Update Git"); const choice = await window.showWarningMessage(localize('git20', "You seem to have git {0} installed. Code works best with git >= 2", info.version), update); if (choice === update) { commands.executeCommand('vscode.open', Uri.parse('https://git-scm.com/')); </del> <ins> const IgnoreOldGitStorageKey = 'settings.extension.git.ignoreOld'; // Check user setting to show older version message if (!context.globalState.get(IgnoreOldGitStorageKey)) { if (/^[01]/.test(info.version)) { const update = localize('updateGit', "Update Git"); const neverShowAgain = localize('neverShowAgain', "Don't show again"); const choice = await window.showWarningMessage( localize('git20', "You seem to have git {0} installed. Code works best with git >= 2", info.version), update, neverShowAgain ); if (choice === update) { commands.executeCommand('vscode.open', Uri.parse('https://git-scm.com/')); } else if (choice === neverShowAgain) { context.globalState.update(IgnoreOldGitStorageKey, true); } </ins> } } }
Change:
The video below demonstrates tslint running as a language server plugin. Notice that the tslint warnings show up as errors. However, in the code the DiagnosticCategory is set to . ! This is the code that creates the diagnostic
Looks like we don't set a severity on the diagnostics which causes them to all be marked as errors. Looking into fixing this
Hmm, I don't see a field on normal objects in the TSServer protocol, only on . Let me see if this field is sent anyways when you explicitly set in the TSLint plugin
I've opened to track adding to the objects that tsserver returns to us. This seems like an oversight in the current protocol

Discussion:
public static readonly variable = 'var'; public static readonly warning = 'warning'; } <ins> export class DiagnosticCategory { public static readonly error = 'error'; public static readonly warning = 'warning'; } </ins>  No newline at end of file

* ------------------------------------------------------------------------------------------ */ 'use strict'; <del> import { env, languages, commands, workspace, window, ExtensionContext, Memento, IndentAction, Diagnostic, DiagnosticCollection, Range, Disposable, Uri, MessageItem, TextEditor, FileSystemWatcher } from 'vscode'; </del> <ins> import { env, languages, commands, workspace, window, ExtensionContext, Memento, IndentAction, Diagnostic, DiagnosticCollection, Range, Disposable, Uri, MessageItem, TextEditor, FileSystemWatcher, DiagnosticSeverity } from 'vscode'; </ins> // This must be the first statement otherwise modules might got loaded with // the wrong locale.

import * as path from 'path'; import * as Proto from './protocol'; <ins> import * as PConst from './protocol.const'; </ins> import TypeScriptServiceClient from './typescriptServiceClient'; import { ITypescriptServiceClientHost } from './typescriptService';

private createMarkerDatas(diagnostics: Proto.Diagnostic[], source: string): Diagnostic[] { const result: Diagnostic[] = []; for (let diagnostic of diagnostics) { <del> let { start, end, text } = diagnostic; let range = new Range(start.line - 1, start.offset - 1, end.line - 1, end.offset - 1); let converted = new Diagnostic(range, text); converted.source = source; </del> <ins> const { start, end, text } = diagnostic; const range = new Range(start.line - 1, start.offset - 1, end.line - 1, end.offset - 1); const converted = new Diagnostic(range, text); converted.severity = this.getDiagnosticSeverity(diagnostic); converted.source = diagnostic.source || source; </ins> converted.code = '' + diagnostic.code; result.push(converted); } return result; } <ins> private getDiagnosticSeverity(diagnostic: Proto.Diagnostic): DiagnosticSeverity { switch (diagnostic.category) { case PConst.DiagnosticCategory.error: return DiagnosticSeverity.Error; case PConst.DiagnosticCategory.warning: return DiagnosticSeverity.Warning; default: return DiagnosticSeverity.Error; } } </ins> }
Change:
VSCode Version: Code 1.11.2 (, 2017-04-13T08:03:11.395Z) OS Version: Windows_NT ia32 6.1.7601 Extensions: ; Steps to Reproduce: " don't " inside a comment. Get " don't' " Should be able to disable auto close inside comments and control auto-close inside and outside comments per bracket type and language type.
What language are you working in? I believe that languages can already restrict this functionality in their language configuration, see for example. Perhaps that language you are working in doesn't use in this configuration
I'm using C and C++. Should I file an issue in the C/C++ extension?
Thanks. We control at least the the basic c/c++ language configuration and I confirmed that it does not use . Would you like to submit a PR with the fix? . Take a look at the for an example of
Unfortunately, I'm not really in the position to submit as I don't have any the tools installed. I don't have git installed (as at work using ClearCase) and I don't know what the other tools are. I'll see if I can work out the settings and paste the configuration in here.

Discussion:
["(", ")"] ], "autoClosingPairs": [ <del> ["{", "}"], ["[", "]"], ["(", ")"], [""", """], ["'", "'"] </del> <ins> { "open": "[", "close": "]" }, { "open": "{", "close": "}" }, { "open": "(", "close": ")" }, { "open": "'", "close": "'", "notIn": ["string", "comment"] }, { "open": """, "close": """, "notIn": ["string"] } </ins> ], "surroundingPairs": [ ["{", "}"],
Change:
From a normal Windows command prompt, will stop a node server running. However, if I start the command prompt via the menu item , then pressing (even multiple times) does not stop the server as usual. Running on Windows 10 x64 VS Code 1.11.2 Also asked on SO:
does this still happen when you add this to your settings?
If I add that setting it works fine. Note after I install VS Code it already has similar setting: // Place your settings in this file to overwrite the default settings { "window.zoomLevel": 0.5, "": "C:WINDOWSSysnative", "terminal.external.windowsExec": "C:Windowssysnative" }
We should just hardcode 32/64-bit then if that works, right now we point to the environment variable that defaults to the 32-bit version of regardless of what version of Windows you're on.
I can reproduce. This has been a bug for the longest time. Also this true not just for node processes. E.g. when I launch a go web service that I'm developing.
I merged which should select the sysnative version. I noticed two things though, firstly I couldn't reproduce the issue on my machine (Windows 10 64-bit), plus I didn't see it change to Sysnative using the same trick we used to fix a similar issue with 64-bit PowerShell. This may be blocked by shipping a 64-bit version of VS Code. I'm interested to hear if the problem is fixed in Insiders on Monday.
I'll test when this gets released.
Works for me, adding verified.
Edit: found an open issue more appropriate....

Discussion:
export const DEFAULT_TERMINAL_OSX = 'Terminal.app'; <del> export const DEFAULT_TERMINAL_WINDOWS = '%COMSPEC%'; </del> <ins> export const DEFAULT_TERMINAL_WINDOWS = `${process.env.windir}${process.env.hasOwnProperty('PROCESSOR_ARCHITEW6432') ? 'Sysnative' : 'System32'}cmd.exe`; </ins> export interface ITerminalConfiguration { terminal: {
Change:
Is this still open? I would like to work on this. I am new to the code and would probably need some help.
sure looks like it is.

Discussion:
"when": "config.git.enabled && gitOpenRepositoryCount != 0 && isInDiffEditor && resourceScheme =~ /^git$|^file$/" } ], <ins> "editor/context": [ { "command": "git.stageSelectedRanges", "group": "2_git@1", "when": "config.git.enabled && gitOpenRepositoryCount != 0 && isInDiffEditor && resourceScheme =~ /^git$|^file$/" }, { "command": "git.unstageSelectedRanges", "group": "2_git@2", "when": "config.git.enabled && gitOpenRepositoryCount != 0 && isInDiffEditor && resourceScheme =~ /^git$|^file$/" }, { "command": "git.revertSelectedRanges", "group": "2_git@3", "when": "config.git.enabled && gitOpenRepositoryCount != 0 && isInDiffEditor && resourceScheme =~ /^git$|^file$/" } ], </ins> "scm/change/title": [ { "command": "git.stageChange",
Change:
<!-- Do you have a question? Please ask it on --- VSCode Version: n/a OS Version: n/a Steps to Reproduce: space on python file doesn't show with syntax highlighting <img width="324" alt="screen shot 2017-05-03 at 1 56 59 pm" src=""<img width="909" alt="screen shot 2017-05-03 at 1 57 01 pm" src=""
This seems to be doable—I see TextMate 2 handle previews for all source code.
Thanks to allows this to happen. Setting it for November.
Awesome, thanks for the fast pull!
I'm sure this will be great for tonnes of users. I have this older ticket - but it got shelved. A variable explorer like spyder. made a fantastic effort in surfacing these here I wonder how hard it would be to rip apart the debug variable explorer. I don't know where to start. A friend illustrated to me 6 mths back that the content inside vscode could be inspected like google chrome with divs and dom hierarchy.
The changes don't seem to have made any change. For example, after installing today's Insiders, files still don't show source in QuickLook, although they are associated with Code.
LaunchServices may not have picked up on the change, and it's a bit fiddly (especially if you have multiple apps with the same CFBundleIdentifier on the machine). It also won't work if the CodeSignature is invalid. I downloaded Insiders today (1.18.0-insider) and didn't see the new key in the , FWIW.
I'll take a look at it in November.
Are you sure all this needs is to add the key? I can't get this to work on my machine in any way. Also, the official docs say: I get the feeling that this is not sufficient for Quick Look, but rather that a Quick Look plugin is required to get this to work.
OK guys, I'm going to close this and revert the PR for two reasons: Causes issues There are other alternatives out there which do a much better job than Code:

Discussion:
role: 'Editor', ostypes: ["TEXT", "utxt", "TUTX", "****"], extensions: ["ascx", "asp", "aspx", "bash", "bash_login", "bash_logout", "bash_profile", "bashrc", "bat", "bowerrc", "c", "cc", "clj", "cljs", "cljx", "clojure", "cmd", "code-workspace", "coffee", "config", "cpp", "cs", "cshtml", "csproj", "css", "csx", "ctp", "cxx", "dockerfile", "dot", "dtd", "editorconfig", "edn", "eyaml", "eyml", "fs", "fsi", "fsscript", "fsx", "gemspec", "gitattributes", "gitconfig", "gitignore", "go", "h", "handlebars", "hbs", "hh", "hpp", "htm", "html", "hxx", "ini", "jade", "jav", "java", "js", "jscsrc", "jshintrc", "jshtm", "json", "jsp", "less", "lua", "m", "makefile", "markdown", "md", "mdoc", "mdown", "mdtext", "mdtxt", "mdwn", "mkd", "mkdn", "ml", "mli", "php", "phtml", "pl", "pl6", "pm", "pm6", "pod", "pp", "profile", "properties", "ps1", "psd1", "psgi", "psm1", "py", "r", "rb", "rhistory", "rprofile", "rs", "rt", "scss", "sh", "shtml", "sql", "svg", "svgz", "t", "ts", "txt", "vb", "wxi", "wxl", "wxs", "xaml", "xcodeproj", "xcworkspace", "xml", "yaml", "yml", "zlogin", "zlogout", "zprofile", "zsh", "zshenv", "zshrc"], <ins> utis: ['public.source-code'], </ins> iconFile: 'resources/darwin/code_file.icns' }], darwinBundleURLTypes: [{
Change:
All input box based widgets (find, file search, etc) need text selection foreground/background UI colors. Have to decide if there should be a global ::selection color or any individual ones are needed. !
Added via for May.

Discussion:
export const contrastBorder = registerColor('contrastBorder', { light: null, dark: null, hc: '#6FC3DF' }, nls.localize('contrastBorder', "An extra border around elements to separate them from others for greater contrast.")); export const activeContrastBorder = registerColor('contrastActiveBorder', { light: null, dark: null, hc: focusBorder }, nls.localize('activeContrastBorder', "An extra border around active elements to separate them from others for greater contrast.")); <ins> export const selectionBackground = registerColor('selection.background', { light: null, dark: null, hc: null }, nls.localize('selectionBackground', "The background color of text selections in the workbench (e.g. for input fields or text areas). Note that this does not apply to selections within the editor and the terminal.")); </ins> // ----- widgets export const widgetShadow = registerColor('widget.shadow', { dark: '#000000', light: '#A8A8A8', hc: null }, nls.localize('widgetShadow', 'Shadow color of widgets such as find/replace inside the editor.'));

import { IWorkbenchThemeService } from 'vs/workbench/services/themes/common/workbenchThemeService'; import { WorkbenchThemeService } from 'vs/workbench/services/themes/electron-browser/workbenchThemeService'; import { registerThemingParticipant, ITheme, ICssStyleCollector } from 'vs/platform/theme/common/themeService'; <del> import { foreground, focusBorder, scrollbarShadow, scrollbarSliderActiveBackground, scrollbarSliderBackground, scrollbarSliderHoverBackground, listHighlightForeground } from 'vs/platform/theme/common/colorRegistry'; </del> <ins> import { foreground, selectionBackground, focusBorder, scrollbarShadow, scrollbarSliderActiveBackground, scrollbarSliderBackground, scrollbarSliderHoverBackground, listHighlightForeground } from 'vs/platform/theme/common/colorRegistry'; </ins> /** * Services that we require for the Shell

collector.addRule(`.monaco-shell { color: ${windowForeground}; }`); } <ins> // Selection const windowSelectionBackground = theme.getColor(selectionBackground); if (windowSelectionBackground) { collector.addRule(`.monaco-shell ::selection { background-color: ${windowSelectionBackground}; }`); } </ins> // List highlight const listHighlightForegroundColor = theme.getColor(listHighlightForeground); if (listHighlightForegroundColor) {
Change:
Most macOS apps (like ) use em dash () instead of en dash () as window title separator. I suggest VS Code use em dash for better consistency.
PR welcome.
Can anyone explain a bit about it ? Thanks

Discussion:
private static NLS_UNSUPPORTED = nls.localize('patchedWindowTitle', "[Unsupported]"); private static NLS_EXTENSION_HOST = nls.localize('devExtensionWindowTitlePrefix', "[Extension Development Host]"); private static TITLE_DIRTY = 'u25cf '; <del> private static TITLE_SEPARATOR = ' - '; </del> <ins> private static TITLE_SEPARATOR = ' — '; </ins> private titleContainer: Builder; private title: Builder;
Change:
tslint outputs errors in this format: /cc Related:
Doesn't work for me when there's a space between line and col, it looks like tslint is outputting it that way Top goes to correct line/col, bottom just goes to the file !
do you have an example program that outputs like this?
tslint apparently does, from the example above?
I actually can't click at all in this example !

Discussion:
const lineAndColumnClause = [ '((S*) on line ((d+)(, column (d+))?))', // (file path) on line 8, column 13 '((S*):line ((d+)(, column (d+))?))', // (file path):line 8, column 13 <del> '(([^s()]*)(s?((d+)(,(d+))?)))', // (file path)(45), (file path) (45), (file path)(45,18), (file path) (45,18) </del> <ins> '(([^s()]*)(s?[([](d+)(,(d+))?)[)]])', // (file path)(45), (file path) (45), (file path)(45,18), (file path) (45,18) </ins> '(([^:s()<>'"[]]*)(:(d+))?(:(d+))?)' // (file path):336, (file path):336:9 ].join('|').replace(/ /g, `[${'u00A0'} ]`);

const baseLocalLinkClause = _platform === platform.Platform.Windows ? winLocalLinkClause : unixLocalLinkClause; // Append line and column number regex this._localLinkPattern = new RegExp(`${baseLocalLinkClause}(${lineAndColumnClause})`); this._xterm.setHypertextLinkHandler(this._wrapLinkHandler(() => true)); this._xterm.setHypertextValidationCallback((uri: string, element: HTMLElement, callback: (isValid: boolean) => void) => { this._validateWebLink(uri, element, callback);

{ urlFormat: '{0}({1},{2})', line: '5', column: '3' }, { urlFormat: '{0} ({1},{2})', line: '5', column: '3' }, { urlFormat: '{0}:{1}', line: '5' }, <del> { urlFormat: '{0}:{1}:{2}', line: '5', column: '3' } </del> <ins> { urlFormat: '{0}:{1}:{2}', line: '5', column: '3' }, { urlFormat: '{0}[{1}]', line: '5' }, { urlFormat: '{0} [{1}]', line: '5' }, { urlFormat: '{0}[{1},{2}]', line: '5', column: '3' }, { urlFormat: '{0} [{1},{2}]', line: '5', column: '3' } </ins> ]; linkUrls.forEach(linkUrl => {
Change:
I find myself expanding this option nearly every time I use VSCode, would it be possible to have a setting that allows the search details to be open by default? !
It could be persisted as open, same as the button states are persisted.

Discussion:
const exclusionsUsePattern = this.viewletSettings['query.exclusionsUsePattern']; const includesUsePattern = this.viewletSettings['query.includesUsePattern']; const patternIncludes = this.viewletSettings['query.folderIncludes'] || ''; <ins> const queryDetailsExpanded = this.viewletSettings['query.queryDetailsExpanded'] || ''; </ins> const useIgnoreFiles = typeof this.viewletSettings['query.useIgnoreFiles'] === 'boolean' ? this.viewletSettings['query.useIgnoreFiles'] : this.configurationService.getConfiguration<ISearchConfiguration>().search.useIgnoreFilesByDefault;

this.actionRegistry[action.id] = action; }); <del> if (filePatterns !== '' || patternExclusions !== '' || patternIncludes !== '') { </del> <ins> if (filePatterns !== '' || patternExclusions !== '' || patternIncludes !== '' || queryDetailsExpanded !== '') { </ins> this.toggleQueryDetails(true, true, true); }

let cls = 'more'; show = typeof show === 'undefined' ? !dom.hasClass(this.queryDetails, cls) : Boolean(show); <ins> this.viewletSettings['query.queryDetailsExpanded'] = show; </ins> skipLayout = Boolean(skipLayout); if (show) {
Change:
Don't know if this is the intention or a bug. See
I believed this is a bug, and I've sent a PR for this. cc
It was indeed, thanks again

Discussion:
css += `.monaco-workbench .panel.integrated-terminal .terminal-outer-container { background-color: ${bgColor}; }`; } const fgColor = theme.getColor(TERMINAL_FOREGROUND_COLOR); <del> if (bgColor) { </del> <ins> if (fgColor) { </ins> css += `.monaco-workbench .panel.integrated-terminal .xterm { color: ${fgColor}; }`; }