jiebi/CodeConvo huggingface dataset:
Change:
As the title says. Some extensions haven't been yet, so we need to add them.
this does not really work for me Am I doing something wrong? !
Is it the latest development build? If so, I think you need to wait until the next release.
This is the latest VS Code insiders from 5 hours ago.
Hmm, that's pretty strange... ~I may have forgotten to update this file:
Let's reopen and can comment
Yes, sorry for not paying attention. The file extension list in is used when we generate the vscode-seti theme from the repo. It is used to find an icon for a language () that is not part of our built-in languages, based on the file extension associations defined in You still need to install an extension that defines the language, and its file associations. E.g. Or you define the associations in the settings:
To verify check that our seti theme has a language icon for :
Is there any way to enable all "ocaml. *" as well?
Not sure what you mean. Associate all files that start with to the language?

Discussion:
"kotlin": { extensions: ['kt'] }, "mustache": { extensions: ['mustache', 'mst', 'mu', 'stache'] }, "nunjucks": { extensions: ['nunjucks', 'nunjs', 'nunj', 'nj', 'njk', 'tmpl', 'tpl'] }, <del> "ocaml": { extensions: ['ml', 'mli'] }, </del> <ins> "ocaml": { extensions: ['ml', 'mli', 'mll', 'mly', 'eliom', 'eliomi'] }, </ins> "puppet": { extensions: ['puppet'] }, "r": { extensions: ['r', 'rhistory', 'rprofile', 'rt'] }, "sass": { extensions: ['sass'] },
Change:
To repro, cause the Ports view to rerender several times. This can be done by trying to set a label and escaping out about 8 times.
is this a bad leak? Like does it leak just 1 listener per interaction or does it grow faster than that?
It grows faster than that, but it's probably only a medium bad leak. After 8 table rerenders there are 175 listeners. After ~5 more table rerenders there are 263 listeners. After ~5 more table rerenders there are 351 listeners. After ~5 more table rerenders there are 439 listeners. A table rerender can be triggered through port auto-forwarding. Once when the process is started and the port is forwarded, and once when the process exists and the port is removed. The number of listeners is depended on the number of ports that have been forwarded. My numbers above are with 3 ports.
No more leak, works as expected -verified

Discussion:
templateData.button.element.style.display = 'none'; templateData.button.dispose(); } <ins> templateData.elementDisposable.dispose(); </ins> let editableData: IEditableData | undefined; if (element.editId === TunnelEditId.New && (editableData = this.remoteExplorerService.getEditableData(undefined))) {

}); } <ins> disposeElement(element: ActionBarCell, index: number, templateData: IActionBarTemplateData, height: number | undefined) { templateData.elementDisposable.dispose(); } </ins> disposeTemplate(templateData: IActionBarTemplateData): void { <ins> templateData.label.dispose(); </ins> templateData.actionBar.dispose(); templateData.elementDisposable.dispose(); <ins> templateData.button?.dispose(); </ins> } }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54.1 OS Version: Ubuntu 20.04 Steps to Reproduce: /create a Handlebars file. tag. some Emmet CSS abbreviation and try to expand. . Emmet HTML abbreviations in Handlebars files work fine. See HTML vs Handlebars example: ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.606 --<!-- potentialduplicatescomment --
I think I have found the issue. In , we check , we should be checking instead. I will raise a PR.

Discussion:
const lsDoc = toLSTextDocument(document); position = document.validatePosition(position); <del> if (document.languageId === 'html') { </del> <ins> if (syntax === 'html') { </ins> if (context.triggerKind === vscode.CompletionTriggerKind.TriggerForIncompleteCompletions) { switch (this.lastCompletionType) { case 'html':
Change:
This started yesterday. I am on Remote WSL. !
Setting to -1 works as a temporary workaround.
any ideas? Could adding the pty host process in remote have caused this somehow? Not sure what other changes could have caused it.
I can't look into this for a few hours, I'm guessing something that it expected was synchronous is now asynchronous.
I wonder... when you hit ENTER, does it run correctly? I wonder if this is more of a cosmetic issue than impacting what is actually run.
Yes it's cosmetic only
Typeahead hasn't changed in several weeks, so I'm guessing pty in the remote is it. I was able to reproduce this in Insiders, but annoyingly could not do so in a dev setup from OSS -- anything that was fixed since the last Insiders? Would any of the pty process work cause to no longer be synchronous? That would be a prime suspect. It seems to only happen when typing somewhat rapidly (i.e. when there's multiple predictions written and one is validated) so the is probably incorrect in these scenarios. I can try to debug Insiders off sourcemaps if we can't get an OSS repro...
I don't repro this on Insiders today. Let me know if you do, or if it comes back
I could reproduce it the other day in WSL but not out of sources, but now can't . Good news I guess, do you see it anymore?
No more repro!

Discussion:
this._processManager.relaunch(this._shellLaunchConfig, this._cols, this._rows, this._accessibilityService.isScreenReaderOptimized(), reset); <del> this._xtermTypeAhead?.reset(this._processManager); </del> <ins> this._xtermTypeAhead?.reset(); </ins> } @debounce(1000)

})); } <del> public reset(processManager: ITerminalProcessManager) { </del> <ins> public reset() { </ins> this.lastRow = undefined; <del> this.processManager = processManager; this._register(this.processManager.onBeforeProcessData(e => this.onBeforeProcessData(e))); </del> } private deferClearingPredictions() {
Change:
There's a typo on line 3239 of . Should be (extra pipe character):

Discussion:
appendPlaceholder(value: string | ((snippet: SnippetString) => any), number?: number): SnippetString; /** <del> * Builder-function that appends a choice (`${1|a,b,c}`) to </del> <ins> * Builder-function that appends a choice (`${1|a,b,c|}`) to </ins> * the [`value`](#SnippetString.value) of this snippet string. * * @param values The values for choices - the array of strings
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.54.3 OS Version: Windows 10 20H2 Steps to Reproduce: a file with the same words with different casing a find replace with preserve casing switched on the preview does not work properly (and the replace also doesn't) preserve casing does not do anything ! I'm pretty sure this worked as expected before.. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
The feature came via
This case is not handled. When the match is mixed-case and starts with a lowercase character, I think the replace pattern should have its first character lowercased. Would take a PR that adds this.

Discussion:
return pattern.toLowerCase(); } else if (strings.containsUppercaseCharacter(matches[0][0]) && pattern.length > 0) { return pattern[0].toUpperCase() + pattern.substr(1); <ins> } else if (matches[0][0].toUpperCase() !== matches[0][0] && pattern.length > 0) { return pattern[0].toLowerCase() + pattern.substr(1); </ins> } else { // we don't understand its pattern yet. return pattern;

assertReplace(['abc', 'Abc'], 'Def', 'def'); assertReplace(['Abc', 'abc'], 'Def', 'Def'); assertReplace(['ABC', 'abc'], 'Def', 'DEF'); <ins> assertReplace(['aBc', 'abc'], 'Def', 'def'); </ins> assertReplace(['AbC'], 'Def', 'Def'); <del> assertReplace(['aBC'], 'Def', 'Def'); </del> <ins> assertReplace(['aBC'], 'Def', 'def'); assertReplace(['aBc'], 'DeF', 'deF'); </ins> assertReplace(['Foo-Bar'], 'newfoo-newbar', 'Newfoo-Newbar'); assertReplace(['Foo-Bar-Abc'], 'newfoo-newbar-newabc', 'Newfoo-Newbar-Newabc'); assertReplace(['Foo-Bar-abc'], 'newfoo-newbar', 'Newfoo-newbar'); assertReplace(['foo-Bar'], 'newfoo-newbar', 'newfoo-Newbar'); assertReplace(['foo-BAR'], 'newfoo-newbar', 'newfoo-NEWBAR'); <ins> assertReplace(['foO-BAR'], 'NewFoo-NewBar', 'newFoo-NEWBAR'); </ins> assertReplace(['Foo_Bar'], 'newfoo_newbar', 'Newfoo_Newbar'); assertReplace(['Foo_Bar_Abc'], 'newfoo_newbar_newabc', 'Newfoo_Newbar_Newabc'); assertReplace(['Foo_Bar_abc'], 'newfoo_newbar', 'Newfoo_newbar');
Change:
When I select "Open with..." on a code search file, I would have expected to see our search editor in there as well: ! Slightly related, I would probably expect an entry "Settings Editor" when opening a file with...

Discussion:
*--------------------------------------------------------------------------------------------*/ import { KeyCode, KeyMod } from 'vs/base/common/keyCodes'; <del> import { extname } from 'vs/base/common/resources'; </del> <ins> import { extname, isEqual } from 'vs/base/common/resources'; </ins> import { URI } from 'vs/base/common/uri'; import { ServicesAccessor } from 'vs/editor/browser/editorExtensions'; import { Range } from 'vs/editor/common/core/range';

import { LifecyclePhase } from 'vs/workbench/services/lifecycle/common/lifecycle'; import { Registry } from 'vs/platform/registry/common/platform'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; <del> import { EditorDescriptor, Extensions as EditorExtensions, IEditorRegistry } from 'vs/workbench/browser/editor'; </del> <ins> import { DEFAULT_EDITOR_ASSOCIATION, EditorDescriptor, Extensions as EditorExtensions, IEditorRegistry } from 'vs/workbench/browser/editor'; </ins> import { Extensions as WorkbenchExtensions, IWorkbenchContribution, IWorkbenchContributionsRegistry } from 'vs/workbench/common/contributions'; import { ActiveEditorContext, Extensions as EditorInputExtensions, IEditorInputSerializer, IEditorInputFactoryRegistry } from 'vs/workbench/common/editor'; import { IViewsService } from 'vs/workbench/common/views';

) { this.editorService.overrideOpenEditor({ <ins> getEditorOverrides: (resource: URI) => { return extname(resource) === SEARCH_EDITOR_EXT ? [{ id: SearchEditorInput.ID, label: localize('promptOpenWith.searchEditor.displayName', "Search Editor"), detail: DEFAULT_EDITOR_ASSOCIATION.providerDisplayName, active: isEqual(this.editorService.activeEditor?.resource, resource) && this.editorService.activeEditor instanceof SearchEditorInput }] : []; }, </ins> open: (editor, options, group) => { const resource = editor.resource; if (!resource) { return undefined; }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --Steps to Reproduce: trigger the Command Palette: command Try to search by a snippet's "Description" field for a word not in the prefix - does not work. The description field can be seen in the Command Palette but cannot be searched for successfully. Seems to be a regression, see Tested in Stable and Insiders. Version: 1.55.0-insider (user setup) Commit: Date: 2021-03-18T05:14:49.087Z Electron: 11.3.0 Chrome: 87.0.4280.141 12.18.3 V8: 8.7.220.31-electron.0 OS: Windows_NT x64 10.0. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported direct to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.48 --<!-- potentialduplicatescomment --
I confirm this issue is happened on 1.54, while it worked on 1.43

Discussion:
const picker = quickInputService.createQuickPick<ISnippetPick>(); picker.placeholder = nls.localize('pick.placeholder', "Select a snippet"); <del> picker.matchOnDescription = true; </del> <ins> picker.matchOnDetail = true; </ins> picker.ignoreFocusOut = false; picker.onDidTriggerItemButton(ctx => { const isEnabled = snippetService.isEnabled(ctx.item.snippet);
Change:
Testing Ctrl+[RightLeft] Ctrl+Up &mdash; put the cell in edit mode and focused the editor, I expected it to move the focus to the preview cell without changing the selection (like Windows Explorer) Ctrl+Down &mdash; seems to scroll down slowly. Again I expected it to move the focus to the next cell without changing the selection
It seems the ctrl+arrows are already being used by actions.
Meaning expand/collapse headers? Why? If I understand correctly, this is basically what arrow up/down by themselves are already doing, right? ctrl+up/down are matching the editor by scrolling without moving focus. Except that they are double-booked with focus in/out of output, which maybe should only happen when focus is in the editor
I think the only thing to fix here is that ctrl+up invokes when focus is not in the output, and focuses the editor.

Discussion:
id: FOCUS_OUT_OUTPUT_COMMAND_ID, title: localize('focusOutputOut', 'Focus Out Active Cell Output'), keybinding: { <del> when: NOTEBOOK_EDITOR_FOCUSED, </del> <ins> when: ContextKeyExpr.and(NOTEBOOK_EDITOR_FOCUSED, NOTEBOOK_OUTPUT_FOCUSED), </ins> primary: KeyMod.CtrlCmd | KeyCode.UpArrow, mac: { primary: KeyMod.WinCtrl | KeyMod.CtrlCmd | KeyCode.UpArrow, }, weight: KeybindingWeight.WorkbenchContrib
Change:
Clicking on "New File" from getting started when in a workspace opens the explorer and places a new file where your selection is: ! This works the opposite way our current welcome page does where it will always create an untitled file: ! I think we should keep these actions consistent and not change the behavior.

Discussion:
icon: Codicon.newFile, content: { type: 'startEntry', <del> command: 'explorer.newFile', </del> <ins> command: 'workbench.action.files.newUntitledFile', </ins> } }, {
Change:
Verifying Version: 1.55.0-insider Commit: Date: 2021-03-25T16:24:13.227Z clone and open in vscode add a to F5 to run the extension Open an untitled file In the editor's tab, choose from the context menu, pick ! a different notebook is opened, no console log statement printed !
Are you able to open markdown notebooks without issue on non untitled files?
Yes, that works. I also tried to open a GitHub issue notebook on an untitled file and while a notebook seems to open which has a 'Github Issues' cell, the function in the GitHub issue notebook source seems not be called. So I'm a bit confused
I did some investigation with this and I can't reproduce it out of sources. When I select it through the reopen with dialog the notebook service receives the correct viewtype, although it always fails to open with the error . I'm not sure why it is failing as the inputs get created correctly and everything seems to be passing through the right way. Let me know if you want to investigate together.

Discussion:
}); } <del> async withNotebookDataProvider(resource: URI): Promise<ComplexNotebookProviderInfo | SimpleNotebookProviderInfo> { const [first] = this._notebookProviderInfoStore.getContributedNotebook(resource); if (!first) { </del> <ins> async withNotebookDataProvider(resource: URI, viewType?: string): Promise<ComplexNotebookProviderInfo | SimpleNotebookProviderInfo> { const providers = this._notebookProviderInfoStore.getContributedNotebook(resource); // If we have a viewtype specified we want that data provider, as the resource won't always map correctly const selected = viewType ? providers.find(p => p.id === viewType) : providers[0]; if (!selected) { </ins> throw new Error(`NO contribution for resource: '${resource.toString()}'`); } <del> await this.canResolve(first.id); const result = this._notebookProviders.get(first.id); </del> <ins> await this.canResolve(selected.id); const result = this._notebookProviders.get(selected.id); </ins> if (!result) { <del> throw new Error(`NO provider registered for view type: '${first.id}'`); </del> <ins> throw new Error(`NO provider registered for view type: '${selected.id}'`); </ins> } return result; }

protected async createReferencedObject(key: string, viewType: string): Promise<IResolvedNotebookEditorModel> { const uri = URI.parse(key); <del> const info = await this._notebookService.withNotebookDataProvider(uri); </del> <ins> const info = await this._notebookService.withNotebookDataProvider(uri, viewType); </ins> let result: IResolvedNotebookEditorModel;

registerNotebookController(viewType: string, extensionData: NotebookExtensionDescription, controller: IMainNotebookController): IDisposable; registerNotebookSerializer(viewType: string, extensionData: NotebookExtensionDescription, serializer: INotebookSerializer): IDisposable; <del> withNotebookDataProvider(resource: URI): Promise<ComplexNotebookProviderInfo | SimpleNotebookProviderInfo>; </del> <ins> withNotebookDataProvider(resource: URI, viewType?: string): Promise<ComplexNotebookProviderInfo | SimpleNotebookProviderInfo>; </ins> getMimeTypeInfo(textModel: NotebookTextModel, output: IOutputDto): readonly IOrderedMimeType[];
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Currently, the Markdown supports surround with parentheses , square brackets , backtick, underscore, and asterisk. Selection surround support should also be extended to curly brace , single quote , and double quote . I can certainly fork and make a PR myself if that is all that's needed. Suggested: I'm submitting here after submitting on the extension and being informed this upstream change is needed.
These are all probably good to add. We support all of them in plain text files when I tested Please send a PR to add them when you have a chance
Hello, are you already working on a PR for this issue? If not, is it okay If I go ahead and take a stab at it?
Yes please do

Discussion:
["[", "]"], ["`", "`"], ["_", "_"], <del> ["*", "*"] </del> <ins> ["*", "*"], ["{", "}"], ["'", "'"], [""", """] </ins> ], "folding": { "offSide": true,
Change:
Issue Type: <bBug</bAfter clicking "Stop Extensions Host Profile", the profile timings don't appear in the list. VS Code version: Code 1.54.3 (, 2021-03-15T10:55:45.459Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (13)</summaryExtensionVersion ------ vscode-eslint2.1.19 EditorConfig0.16.4 go0.23.3 python2021.3. jupyter2021.3. remote-containers0.163.2 cpptools1.2.2 js-debug-nightly2021.3.2417 vs-keybindings0.2.0 vscode-github-issue-notebooks0.0.75 debugger-for-chrome4.12.12 rust0.7.8 vscode-lldb1.6.1 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --

Discussion:
for (let i = 0, len = extensionsDescriptions.length; i < len; i++) { const extensionDescription = extensionsDescriptions[i]; <del> let profileInfo: IExtensionProfileInformation | null = null; </del> <ins> let extProfileInfo: IExtensionProfileInformation | null = null; </ins> if (profileInfo) { let extensionSegments = segments[ExtensionIdentifier.toKey(extensionDescription.identifier)] || []; let extensionTotalTime = 0;

const endTime = extensionSegments[2 * j + 1]; extensionTotalTime += (endTime - startTime); } <del> profileInfo = { </del> <ins> extProfileInfo = { </ins> segments: extensionSegments, totalTime: extensionTotalTime };

description: extensionDescription, marketplaceInfo: marketplaceMap[ExtensionIdentifier.toKey(extensionDescription.identifier)], status: statusMap[extensionDescription.identifier.value], <del> profileInfo: profileInfo || undefined, </del> <ins> profileInfo: extProfileInfo || undefined, </ins> unresponsiveProfile: this._getUnresponsiveProfile(extensionDescription.identifier) }; }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: From sources !
That looks grid related to me.
Web bisect points out this commit range which includes the move to the new table widget: This seems to require the custom menu (Windows, Web) to reproduce.
fyi, not sure if anything within the keybindings editor could have caused this other than adopting the table widget.
Can also be reproduced by focusing the search input and then tabbing until the table is focused Created a PR fixing this.
Tagged this as candidate as the experience is bad with custom menu and it is a regression. As mentioned it can also be reproduced everywhere with following steps: Open Keybindings editor Focus search input Tab until table is focused Editor title bar is not visible

Discussion:
this.cachedHeight = height; this.splitview.layout(width); <del> this.list.layout(height - this.virtualDelegate.headerRowHeight, width); </del> <ins> const listHeight = height - this.virtualDelegate.headerRowHeight; this.list.getHTMLElement().style.height = `${listHeight}px`; this.list.layout(listHeight, width); </ins> } toggleKeyboardNavigation(): void {