Change:
ADD ISSUE DESCRIPTION HERE Version: 1.85.1 Commit: User Agent: Mozilla/5.0 (X11; CrOS x86_64 .0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36 Embedder: <!-- generated by web issue reporter --Search in workspace fails with: 'Unable to search with web worker text searcher'. This is on a chromebook. This used to work great, until a couple of weeks ago. Please help / fix. It's a great tool.
Can you show a screen recording? Which browsers does this not work on?
Chrome browser on the chromebook.
If you open the , do you see any error messages?
ERR i.with is not a function: TypeError: i.with is not a function at v.getComparisonKey () at S.c () at S.has () at M () at y () at a.value () at u.y () at u.fire () at m.sendTextSearchMatch () at Object.handleMessage ()
ERR i.with is not a function: TypeError: i.with is not a function
Does this happen with other projects/repos also?
Happens to all project and reposGet Outlook for AndroidFrom: Andrea Mah Monday, January 15, 2024 3:18:52 PMTo: microsoft/vscode mikewguo Author Re: [microsoft/vscode] Can no longer search across all the files in the workspace (Issue ) Does this happen with other projects/repos also? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID:
do you happen to know how we can test the on a chromebook (or know how we can try to repro this)?
I cannot repro and I don't think any of us has a Chromebook, but it sounds like this was a recent regression. There hasn't been any change to how in the call stack works , and it looks like we're trying to call on an object that doesn't actually have the method. I'm wondering whether we might be passing an invalid URI to somewhere in search, e.g. I think this can happen if the URI wasn't properly revived
Does it happen if you open the vscode repo? Can you try that out?
yes, just tried on vscode repo. Same problem: unable to search with web worker text search
Same issue here, on different Windows computers, for and Usually, I could just open a folder, and use the search to find across all files. Now, VS Code for the Web only searches in files when they are opened in the workspace, which would be impossible if I want to search-and-replace across 1,000 files. How to reproduce: a random folder on your machine, allow file access in the browser (Edge) for a string of which you know must be in one of the files in the folder gives no results a file in the workspace, use search again instantly finds the string, but only in the open file
are you opening the VS Code repo as a remote repository (i.e. ) or by using local file access to open files that are cloned to your machine?
by using local files, that are cloned to my machine.
Ah, thanks for confirming. this doesn't involve RemoteHub, so unassigning myself. I can repro btw: Folder choose the VS Code repo locally to search for the string "foo", there are 6881 results when you do the same search on desktop :bug: no results

Discussion:
return; } <ins> // force resource to revive using URI.revive. // TODO @andrea see why we can't just use `revive()` below. For some reason, (<MarshalledObject>obj).$mid was undefined for result.resource const reviveMatch = (result: IFileMatch<UriComponents>): IFileMatch => ({ resource: URI.revive(result.resource), results: revive(result.results) }); </ins> queryDisposables.add(this.onDidReceiveTextSearchMatch(e => { if (e.queryId === queryId) { <del> onProgress?.(revive(e.match)); </del> <ins> onProgress?.(reviveMatch(e.match)); </ins> } }));