jiebi/CodeConvo huggingface dataset:
Change:
Testing When entering a category that does not exists (e.g. 'theme' instead of 'themes') then there is no feedback that the category does not exist.

Discussion:
private async listExtensions(showVersions: boolean, category?: string): Promise<void> { let extensions = await this.extensionManagementService.getInstalled(ExtensionType.User); <del> if (category) { </del> <ins> // TODO: we should save this array in a common place so that the command and extensionQuery can use it that way changing it is easier const categories = ['"programming languages"', 'snippets', 'linters', 'themes', 'debuggers', 'formatters', 'keymaps', '"scm providers"', 'other', '"extension packs"', '"language packs"']; if (category && category !== '') { if (categories.indexOf(category.toLowerCase()) < 0) { console.log('Invalid category please enter a valid category. To list valid categories run --category without a category specified'); return; } </ins> extensions = extensions.filter(e => { if (e.manifest.categories) { const lowerCaseCategories: string[] = e.manifest.categories.map(c => c.toLowerCase());

} return false; }); <ins> } else if (category === '') { console.log('Possible Categories: '); categories.forEach(category => { console.log(category); }); return; </ins> } extensions.forEach(e => console.log(getId(e.manifest, showVersions))); }

disposables.dispose(); } }); <del> } </del>  No newline at end of file <ins> } </ins>
Change:
Testing More of a feature request, it would be great if you didn't supply a category when running that it would print out a list of categories available (like below). I could always go to the extension viewlet and run but that's an extra step and would be nice to show the options inline. <img width="276" alt="image" src="https://user-"
Also tried running this for extension packs and tried to guess the format, printing out the category names would've helped here: <img width="604" alt="image" src="https://user-"

Discussion:
private async listExtensions(showVersions: boolean, category?: string): Promise<void> { let extensions = await this.extensionManagementService.getInstalled(ExtensionType.User); <del> if (category) { </del> <ins> // TODO: we should save this array in a common place so that the command and extensionQuery can use it that way changing it is easier const categories = ['"programming languages"', 'snippets', 'linters', 'themes', 'debuggers', 'formatters', 'keymaps', '"scm providers"', 'other', '"extension packs"', '"language packs"']; if (category && category !== '') { if (categories.indexOf(category.toLowerCase()) < 0) { console.log('Invalid category please enter a valid category. To list valid categories run --category without a category specified'); return; } </ins> extensions = extensions.filter(e => { if (e.manifest.categories) { const lowerCaseCategories: string[] = e.manifest.categories.map(c => c.toLowerCase());

} return false; }); <ins> } else if (category === '') { console.log('Possible Categories: '); categories.forEach(category => { console.log(category); }); return; </ins> } extensions.forEach(e => console.log(getId(e.manifest, showVersions))); }

disposables.dispose(); } }); <del> } </del>  No newline at end of file <ins> } </ins>
Change:
One of the first things I noticed when switching from Sublime Text 3 to VSCode for PowerShell code is VSCode doesn't change the syntax highlighting color for methods. In Sublime Text 3 and PowerShell IDE, methods use a separate color. VSCode method color is the same color as variables. Below, both editors are using the same TextMate color scheme: Sublime Text 3: ! VSCode: ! I am hoping someone with more experience in VSCode might have a temporary workaround in until there's an official fix for this. Wishful thinking.. but something like: below: VSCode Version: 1.36.1 (user setup) OS Version: (Windows 10 64bit) Steps to Reproduce: Open PowerShell code that has PowerShell methods
You can use the "Developer: Inspect TM scope" to get the correct scope for your setting: <img width="388" alt="textmatescope" src="https://user-"You could also make your own theme that does colors the way you want.
We try to keep VS Code lean and we think the functionality you're asking for is great for a VS Code extension. Maybe you can already find one that suits you in the . Just in case, in a few simple steps you can get started . See also our guidelines. Happy Coding!
I'll fix it for the default themes.
Thank you for the tip to use "Developer: Inspect TM scope". This was extremely helpful.

Discussion:
"scope": [ "entity.name.function", "support.function", <del> "support.constant.handlebars" </del> <ins> "support.constant.handlebars", "source.powershell variable.other.member" </ins> ], "settings": { "foreground": "#DCDCAA"

} } ] <del> } </del>  No newline at end of file <ins> } </ins>

"scope": [ "entity.name.function", "support.function", <del> "support.constant.handlebars" </del> <ins> "support.constant.handlebars", "source.powershell variable.other.member" </ins> ], "settings": { "foreground": "#795E26"

} ] <del> } </del>  No newline at end of file <ins> } </ins>
Change:
Visual Studio's Output window has a "Toggle Word Wrap" button, but VS Code has word wrapping always (?) enabled. For certain scenarious like the pending "C/C++ References" output it is desirable for word wrapping to be disabled for the results to be more easily read. There is a "View: Toggle Word Wrap" command, but it applies to the active document only (and not the Output panel, even if it's active). And/or if the OutputChannel interface could add a toggleWordWrap capability, that would allow extensions to set an appropriate default for their particular Output channel. This seems like a pretty basic feature that other Output channel providers would want, but I couldn't find an existing feature request on this.
This describes the same issue and led to adding a config option but it doesn't seem to work or the feature request was misunderstood?
Thanks a lot -- I can use that [Log] setting as a workaround (by setting it in our configurationDefaults); however, the result is still not ideal because it will apply to all Output windows and our C/C++ extension would prefer to isolate the behavior to a specific one. (And a button in the UI would make it easier for users to figure out how to overwrite our "no wrap" default).
Currently, one workaround is to set:
Yes, that is the same workaround I was describing (which our C/C++ extension uses), but it applies to all the output panes, and we'd prefer to isolate the change to a particular output pane (e.g. "C/C++" or "C/C++ References" and not "Git", etc.).
that's a nice to have feature.
For log files, I had the word wrap button visible & after a few moments it just disappeared
It looks like the 'editor.wordWrap' setting no longer works for [Log]. Was it removed intentionally or it is a bug?
That setting is working for me with non-Insiders VS Code with our C/C++ output window, but I see certain output panes like "Window" ignoring the setting somehow (i.e. it always wraps).
Ah, it's working for me now. It looks like it requires a Reload Window after it is set.
command is now also supported for Output Channels.

Discussion:
if (!model) { return false; } <del> if (model.uri.scheme === 'output') { // in output editor return false; } </del> if (editor.getOption(EditorOption.inDiffEditor)) { // this editor belongs to a diff editor for (const diffEditor of codeEditorService.listDiffEditors()) {
Change:
Type in an input box setting, like Font Family Wait a couple seconds Focus is lost From
I used the wrong check. is parent of : !
Verifier: Verify both this bug and are fixed.

Discussion:
// If a single setting is being refreshed, it's ok to refresh now if that is not the focused setting if (key) { const focusedKey = focusedSetting.getAttribute(AbstractSettingRenderer.SETTING_KEY_ATTR); <del> /** * Update `list`s live if focused item is whole list or list item, * as they have a separate "submit edit" step built in before this */ if ( focusedKey === key && !DOM.hasClass(focusedSetting, 'setting-item-list') && !DOM.hasClass(focusedSetting, 'setting-item-contents') </del> <ins> if (focusedKey === key && // update `list`s live, as they have a separate "submit edit" step built in before this (focusedSetting.parentElement && !DOM.hasClass(focusedSetting.parentElement, 'setting-item-list')) </ins> ) { this.updateModifiedLabelForKey(key);
Change:
Previously was F12 on at It's impossible to navigate to the first result
This is from but that change seems correct, I think we should fix , I think it is just assuming that browserEvent will be undefined when triggered by the keyboard. We can change this for pass for any KeyboardEvent too. Also FYI
Thanks

Discussion:
}); this._tree.onDidOpen(e => { const aside = (e.browserEvent instanceof MouseEvent) && (e.browserEvent.ctrlKey || e.browserEvent.metaKey || e.browserEvent.altKey); <del> const goto = !e.browserEvent || ((e.browserEvent instanceof MouseEvent) && e.browserEvent.detail === 2); </del> <ins> const goto = !e.browserEvent || (e.browserEvent instanceof KeyboardEvent) || ((e.browserEvent instanceof MouseEvent) && e.browserEvent.detail === 2); </ins> if (aside) { onEvent(e.elements[0], 'side');
Change:
Issue Type: <bFeature Request</bI want the message could display under the variables it refers to. Because the message box blocks the code over the current line. Thank you. VS Code version: Code 1.36.1 (, 2019-07-08T22:59:35.033Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
Can we just change the default to or does this require a setting?
Kind of feel like this is out of scope, but I don't think this should be assigned to me since it's regarding monaco.
Actually I was wrong - it is determined by : I verified if I swap the order then the hovers appear below instead of above (where there's space). I'll make a PR.
Done! Before: <img width="734" alt="Screenshot 2021-06-30 at 08 45 06" src="https://user-"Change the setting: <img width="921" alt="Screenshot 2021-06-30 at 08 45 14" src="https://user-"After: <img width="777" alt="Screenshot 2021-06-30 at 08 45 22" src="https://user-"
Let's continue tracking in

Discussion:
const defaults: EditorHoverOptions = { enabled: true, delay: 300, <del> sticky: true </del> <ins> sticky: true, below: false, </ins> }; super( EditorOption.hover, 'hover', defaults,

default: defaults.sticky, description: nls.localize('hover.sticky', "Controls whether the hover should remain visible when mouse is moved over it.") }, <ins> 'editor.hover.below': { type: 'boolean', default: defaults.below, description: nls.localize('hover.below', "Show hovers below the line instead of above, if there's space.") }, </ins> } ); }

return { enabled: boolean(input.enabled, this.defaultValue.enabled), delay: EditorIntOption.clampedInt(input.delay, this.defaultValue.delay, 0, 10000), <del> sticky: boolean(input.sticky, this.defaultValue.sticky) </del> <ins> sticky: boolean(input.sticky, this.defaultValue.sticky), below: boolean(input.below, this.defaultValue.below), </ins> }; } }

private _shouldFocus: boolean; private _colorPicker: ColorPickerWidget | null; private _renderDisposable: IDisposable | null; <ins> private _preferBelow: boolean; </ins> constructor( editor: ICodeEditor,

this._isChangingDecorations = false; this._shouldFocus = false; this._colorPicker = null; <ins> this._preferBelow = this._editor.getOption(EditorOption.hover).below; </ins> this._hoverOperation = new HoverOperation( this._computer,

})); this._register(editor.onDidChangeConfiguration(() => { this._hoverOperation.setHoverTime(this._editor.getOption(EditorOption.hover).delay); <ins> this._preferBelow = this._editor.getOption(EditorOption.hover).below; </ins> })); this._register(TokenizationRegistry.onDidChange(() => { if (this._isVisible && this._lastAnchor && this._messages.length > 0) {

return { position: this._showAtPosition, range: this._showAtRange, <del> preference: [ </del> <ins> preference: this._preferBelow ? [ ContentWidgetPositionPreference.BELOW, </ins> ContentWidgetPositionPreference.ABOVE, <del> ContentWidgetPositionPreference.BELOW ] </del> <ins> ] : [ ContentWidgetPositionPreference.ABOVE, ContentWidgetPositionPreference.BELOW, ], </ins> }; } return null;

* Defaults to true. */ sticky?: boolean; <ins> /** * Should the hover be shown below the line if possible? * Defaults to false. */ below?: boolean; </ins> } /**
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --microsoft/monaco-editor VSCode Version: Monaco 0.17.0 Browser: Crhome Steps to Reproduce: a Link Provider for monaco-editor 2 .Click on the link on the monaco editor. results with the following error: <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A Solution: Looks like this is an error in Line 301: It compares the rejected promise errors to 'invalid' and 'missing', but in it rejects an Error not a string Line 61: So instead of the warning in throws an error. The code in should be:

Discussion:
return this.openerService.open(uri, { openToSide }); }, err => { <ins> const messageOrError = err instanceof Error ? (<Error>err).message : err; </ins> // different error cases <del> if (err === 'invalid') { </del> <ins> if (messageOrError === 'invalid') { </ins> this.notificationService.warn(nls.localize('invalid.url', 'Failed to open this link because it is not well-formed: {0}', link.url!.toString())); <del> } else if (err === 'missing') { </del> <ins> } else if (messageOrError === 'missing') { </ins> this.notificationService.warn(nls.localize('missing.url', 'Failed to open this link because its target is missing.')); } else { onUnexpectedError(err);
Change:
I would like a new Snippet Variable for time to be to the variables listed here. Something like or Number of seconds since the unix epoch.
Nice. I would like to work on that
I've got a commit here that works on my local build. Does this look good to you? I just get the milliseconds since epoch using and divide by 1,000. However I use to round to the nearest integer so there aren't a bunch of decimals. If that's what you wanted, I'll go ahead and open the PR, but just wanted to share it for discussion before I go ahead and do that.
I thought was the normal way of doing that? PS: just occurred, would be better since could go upwards
Ah you are right, completely forgot about . Definitely a cleaner look, and I've also changed round to floor. The new commit is and local build works perfect. Was there anything else that crossed your mind?
tested this is a Snippet in Insiders edition today. Works as expected. Thank you very much.

Discussion:
'CURRENT_DAY_NAME_SHORT': true, 'CURRENT_MONTH_NAME': true, 'CURRENT_MONTH_NAME_SHORT': true, <ins> 'CURRENT_SECONDS_UNIX': true, </ins> 'SELECTION': true, 'CLIPBOARD': true, 'TM_SELECTED_TEXT': true,

return TimeBasedVariableResolver.monthNames[new Date().getMonth()]; } else if (name === 'CURRENT_MONTH_NAME_SHORT') { return TimeBasedVariableResolver.monthNamesShort[new Date().getMonth()]; <ins> } else if (name === 'CURRENT_SECONDS_UNIX') { return String(Math.floor(Date.now() / 1000)); </ins> } return undefined;

assertVariableResolve3(resolver, 'CURRENT_DAY_NAME_SHORT'); assertVariableResolve3(resolver, 'CURRENT_MONTH_NAME'); assertVariableResolve3(resolver, 'CURRENT_MONTH_NAME_SHORT'); <ins> assertVariableResolve3(resolver, 'CURRENT_SECONDS_UNIX'); </ins> }); test('creating snippet - format-condition doesn't work #53617', function () {
Change:
Issue Type: <bBug</bAssume If a FileSystemProvider extension implements more than one scheme, and if a file is opened using a scheme that is not used by the root folder(s) of the workspace, then when focus is switched to that file a call is issued on a folder resource that cannot possibly contain the file resource (because the scheme is different). In some scenarios a stat() call on a root folder can be costly, meaning it is important not to do it unnecessarily. This is not a new 1.37 issue. I will add information about how to demonstrate the issue using a variant of fsprovider-sample, and I am also willing to supply a PR to fix it. VS Code version: Code 1.37.0 (, 2019-08-08T02:33:50.993Z) OS version: Windows_NT x64 10.0.
Steps to reproduce: Use 1.38.0-insider, or a 1.37 build that contains the fix for branch at fsprovider-sample in VS Code a logpoint in the stat() method of (line 58) with the following message: that the 'Launch Extension' debug configuration. the Extension Development Host window appears, run the following commands in it: MemFS: Setup Workspace MemFS: Add Second Root MemFS: Create Files to Explorer view. on under the second root (MemFS2 - Different Scheme) the first root doubleclick on at least two files. the Debug Console of your initial VS Code instance, observe the stat messages as you switch between file tabs on the EDH, e.g. context menu of second root (MemFS2) to Remove Folder from Workspace. between tabs of the files and observe how when you click on the opened from memfs2 there is an additional stat of the first root (memfs)
Fixed via can you just let us know tomorrow once the new insiders is out if the issue is indeed fixed for you. Thank you
confirmed good in today's Insider. Thanks!
Thanks, adding verified label.

Discussion:
// Stat needs to be resolved first and then revealed const options: IResolveFileOptions = { resolveTo: [resource], resolveMetadata: this.sortOrder === 'modified' }; const workspaceFolder = this.contextService.getWorkspaceFolder(resource); <del> const rootUri = workspaceFolder ? workspaceFolder.uri : this.roots[0].resource; </del> <ins> if (workspaceFolder === null) { return Promise.resolve(undefined); } const rootUri = workspaceFolder.uri; </ins> const root = this.roots.filter(r => r.resource.toString() === rootUri.toString()).pop()!; try {
Change:
Issue Type: <bBug</bThe first Mac native tab has its top row cut off: ! The second one has the statusbar below the visible window: ! Resizing the window is a workaround. VS Code version: Code - Insiders 1.38.0-insider (, 2019-08-15T05:23:00.986Z) OS version: Darwin x64 18.6.0 <details<summarySystem Info</summary </details<details<summaryExtensions (27)</summaryExtensionVersion ------ unique-lines1.0.0 ssh0.0.4 ghlink1.1.0 remotehub0.5.0 EditorConfig0.13.0 tslint1.0.44 git-project-manager1.7.1 rest-client0.22.0 solidity0.0.58 theme-karyfoundation-themes18.2.1 graphql-for-vscode1.15.1 vscode-docker0.7.0 remote-containers0.67.4 remote-ssh-edit-nightly2019.8. remote-ssh-explorer-nightly2019.8. remote-ssh-nightly2019.8. azure-account0.8.4 azurecli0.4.6 github-issues-prs0.9.1 debugger-for-chrome4.11.7 vetur0.22.1 vscode-versionlens0.24.0 vscode-yaml0.4.1 vscode-workspacecontains-canary0.0.2 vscode-open-in-github1.12.0 ayu0.18.0 vscodeintellicode1.1.9 </details<!-- generated by issue reporter --
does this reproduce when you disable grid layout?
Yes, it's the same with grid layout disabled.
I cannot reproduce using Electron 4.2.7
!
Fix is up at , should be available with next electron release.
we will take the new build and will push it via a PR.

Discussion:
disturl "https://atom.io/download/electron" <del> target "4.2.9" </del> <ins> target "4.2.10" </ins> runtime "electron"

"git": { "name": "electron", "repositoryUrl": "https://github.com/electron/electron", <del> "commitHash": "3d4d6454007f14fa9a5f0e1fa49206fb91b676cc" </del> <ins> "commitHash": "4e4c7527c63fcf27dffaeb58bde996b8d859c0ed" </ins> } }, "isOnlyProductionDependency": true, "license": "MIT", <del> "version": "4.2.9" </del> <ins> "version": "4.2.10" </ins> }, { "component": {

<del> // Type definitions for Electron 4.2.9 </del> <ins> // Type definitions for Electron 4.2.10 </ins> // Project: http://electronjs.org/ // Definitions by: The Electron Team <https://github.com/electron/electron> // Definitions: https://github.com/electron/electron-typescript-definitions

electron: string; chrome: string; } <del> } </del>  No newline at end of file <ins> } </ins>

"@types/webdriverio": "4.6.1", "concurrently": "^3.5.1", "cpx": "^1.5.0", <del> "electron": "4.2.9", </del> <ins> "electron": "4.2.10", </ins> "htmlparser2": "^3.9.2", "mkdirp": "^0.5.1", "mocha": "^5.2.0",

semver "^5.4.1" sumchecker "^2.0.2" <del> electron@4.2.9: version "4.2.9" resolved "https://registry.yarnpkg.com/electron/-/electron-4.2.9.tgz#81226aa1ba58e1b05388474faf5a815010a11ea2" integrity sha512-zC7K3GOiZKmxqllVG/qq/Gx+qQvyolKj5xKKwXMqIGekfokEW2hvoIO5Yh7KCoAh5dqBtpzOJjS4fj1se+YBcg== </del> <ins> electron@4.2.10: version "4.2.10" resolved "https://registry.yarnpkg.com/electron/-/electron-4.2.10.tgz#7096450bb14875ec2e6797316c0c1034e7fe2b76" integrity sha512-dFhsJOW7OZX8JxjoBdugUZh6VWbs5PjlQIH6/w1KsZO7otgBy44j9vPI31KnIid3bdMtNbmTEF+6PA32z88kRw== </ins> dependencies: "@types/node" "^10.12.18" electron-download "^4.1.0"
Change:
Issue Type: <bBug</bthe embedded Quiet Light theme. and insertion point into an indented section. that the active indent guide is indistinguishable from other indent guides. ! Based on this should be easy to fix. Will you accept a PR? VS Code version: Code - Insiders 1.38.0-insider (, 2019-08-21T13:26:22.457Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
if you'd like to submit a PR feel free to do so
Verification steps: Verify that the Quiet Light theme indent guides (default and active) look like this: !

Discussion:
"errorForeground": "#f1897f", "badge.background": "#705697AA", "progressBar.background": "#705697", <del> "walkThrough.embeddedEditorBackground": "#00000014" </del> <ins> "walkThrough.embeddedEditorBackground": "#00000014", "editorIndentGuide.background": "#aaaaaa60", "editorIndentGuide.activeBackground": "#777777b0" </ins> } }
Change:
failed in I have pushed a commit to comment out this test
Let's fix this or close it if already fixed.

Discussion:
fixture = document.body; }); <del> // test('TerminalConfigHelper - getFont fontFamily', async () => { // 	const configurationService = new TestConfigurationService(); // 	await configurationService.setUserConfiguration('editor', { fontFamily: 'foo' }); // 	await configurationService.setUserConfiguration('terminal', { integrated: { fontFamily: 'bar' } }); // 	const configHelper = new TerminalConfigHelper(configurationService, null!, null!, null!); // 	configHelper.panelContainer = fixture; // 	assert.equal(configHelper.getFont().fontFamily, 'bar', 'terminal.integrated.fontFamily should be selected over editor.fontFamily'); // }); </del> <ins> test('TerminalConfigHelper - getFont fontFamily', async () => { const configurationService = new TestConfigurationService(); await configurationService.setUserConfiguration('editor', { fontFamily: 'foo' }); await configurationService.setUserConfiguration('terminal', { integrated: { fontFamily: 'bar' } }); const configHelper = new TerminalConfigHelper(configurationService, null!, null!, null!, null!, null!, null!); configHelper.panelContainer = fixture; assert.equal(configHelper.getFont().fontFamily, 'bar', 'terminal.integrated.fontFamily should be selected over editor.fontFamily'); }); </ins> test('TerminalConfigHelper - getFont fontFamily (Linux Fedora)', async () => { const configurationService = new TestConfigurationService();
Change:
Issue Type: <bFeature Request</bI would like support for the element inside a JSdoc block. See here: Currently it displays the element literally, because VScode (blindly) assumes that everything after is javascript/typescript. VS Code version: Code 1.37.1 (, 2019-08-15T16:17:55.855Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
I am interested in picking this issue up
Here's the relevant code:
I made a PR, I thought it made more sense for the code to be under but please let me know if I am wrong

Discussion:
switch (tag.name) { case 'example': <ins> // check for caption tags, fix for #79704 const captionTagMatches = tag.text.match('<caption>(.*?)</caption>r'); if (captionTagMatches && captionTagMatches.index === 0) { tag.text = captionTagMatches[1] + 'rr' + tag.text.substr(captionTagMatches[0].length); } </ins> case 'default': // Convert to markdown code block if it is not already one if (tag.text.match(/^s*[~`]{3}/g)) {