jiebi/CodeConvo huggingface dataset:
Change:
Looking at . Seems like it works fine on all the other themes I have installed. I think the theme tokens ultimately inherit from a null value here: <img width="535" alt="CleanShot 2022-05-13 at 08 31 49 src="https://user-"<img width="567" alt="CleanShot 2022-05-13 at 08 31 56 src="https://user-"
Can you help me to define colors for this?
I think makes the most sense here. <img width="665" alt="CleanShot 2022-05-16 at 08 13 18 src="https://user-"<img width="687" alt="CleanShot 2022-05-16 at 08 13 25 src="https://user-"I'll file a separate issue for this nested contrast border issue on hover: <img width="100" alt="CleanShot 2022-05-16 at 08 14 11 src="https://user-"
Nice catch - squeezed that into

Discussion:
line-height: 18px; } <del> .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.title-menu:HOVER .quickopen .action-label{ </del> <ins> .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.title-menu:HOVER .quickopen .action-label { </ins> background-color: transparent !important; <ins> outline-color: transparent !important; </ins> } .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.title-menu .action-item.quickopen>.action-label.search {

// border: defaults to active background colors.registerColor( 'titleMenu.border', <del> { dark: activeBackground, hcDark: activeBackground, light: activeBackground, hcLight: activeBackground }, </del> <ins> { dark: activeBackground, hcDark: colors.inputBorder, light: activeBackground, hcLight: colors.inputBorder }, </ins> localize('titleMenu-border', "Border color of the title menu"), false );
Change:
I noticed that the Menu Bar doesn't open the menus on when using Safari. Note the explorer focus indicating that I'm clicking on the buttons to no effect: ! !
can you try with non-insiders to see if this is a regression?
Looks to work as expected on stable: https://user-
Thanks likely regression from updating styles for the WCO

Discussion:
justify-content: left; } <ins> .monaco-workbench.web.safari .part.titlebar, .monaco-workbench.web.safari .part.titlebar>.titlebar-container { /* Must be scoped to safari due to #148851 */ /* Is required in safari due to #149476 */ overflow: visible; } </ins> /* Draggable region */ .monaco-workbench .part.titlebar>.titlebar-container>.titlebar-drag-region { top: 0;
Change:
Trying Perhaps we could default to some subset of the prompt text under some media query or other window size condition. One possible option would be to shorten the [Action | Folder name] pattern to just the action. E.g. "Search hello-world" -"Search" <img width="461" alt="CleanShot 2022-05-13 at 09 59 13 src="https://user-"<img width="472" alt="CleanShot 2022-05-13 at 10 03 30 src="https://user-"cc for other ideas
Small update: based on standup-feedback I swapped "Search" with the corresponding icon. That should give some more room but the problem still exists... I lean towards using the usual ellipsis for text overflow <img width="473" alt="Screenshot 2022-05-16 at 14 02 46" src="https://user-"
This is how it looks with ellipsis. *it actually looks better - the recording shows some padding issues when space is tight https://user-
Looks great! Especially if there more padding L/R per your edit.

Discussion:
line-height: 14px; background-color: inherit; justify-content: center; <del> width: calc(100% - 16px); </del> <ins> width: calc(100% - 19px); </ins> } .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.title-menu .action-item.quickopen>.action-label.search>.search-icon { font-size: 14px; opacity: .8; <del> padding-right: 3px; </del> <ins> padding: 0 3px; } .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.title-menu .action-item.quickopen>.action-label.search>.search-label { overflow: hidden; text-overflow: ellipsis; </ins> } .monaco-workbench .part.titlebar>.titlebar-container>.window-title>.title-menu .action-item.quickopen>.all-options>.action-label {

const searchIcon = renderIcon(Codicon.search); searchIcon.classList.add('search-icon'); <ins> this.workspaceTitle.classList.add('search-label'); </ins> this._updateFromWindowTitle(); reset(this.label, searchIcon, this.workspaceTitle); this._renderAllQuickPickItem(container);
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Latest/Master branch OS Version: All Steps to Reproduce: to settings the one for your OS (with the dropdown set to by default) over the last line (notice how it says instead of
<img width="866" alt="Screen Shot 2022-05-16 at 7 56 38 am" src="https://user-"

Discussion:
} function createExtensionProfileDescription(profile: IExtensionTerminalProfile): string { <del> let description = `$(${ThemeIcon.isThemeIcon(profile.icon) ? profile.icon.id : profile.icon ? profile.icon : Codicon.terminal.id}) ${profile.title}n- extensionIdenfifier: ${profile.extensionIdentifier}`; </del> <ins> let description = `$(${ThemeIcon.isThemeIcon(profile.icon) ? profile.icon.id : profile.icon ? profile.icon : Codicon.terminal.id}) ${profile.title}n- extensionIdentifier: ${profile.extensionIdentifier}`; </ins> return description; }
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --When I don't have any commits, running doesn't do anything, there are no prompts and it can be confusing. In the output, you can see the hint given by Git. <img width="2032" alt="Xnip2022-05-15_02-45-50" src="https://user-"
Instead of a notification maybe add a clause to the command so that it is only enabled when there is an initial commit and there are changes to stash.

Discussion:
return; } <del> await repository.createStash(message, includeUntracked); </del> <ins> try { await repository.createStash(message, includeUntracked); } catch (err) { if (/You do not have the initial commit yet/.test(err.stderr || '')) { window.showInformationMessage(l10n.t('The repository does not have any commits. Please make an initial commit before creating a stash.')); return; } throw err; } </ins> } @command('git.stash', { repository: true })

...includeUntracked ? this.untrackedGroup.resourceStates.map(r => r.resourceUri.fsPath) : []]; return await this.run(OperationKind.Stash, async () => { <del> this.repository.createStash(message, includeUntracked); </del> <ins> await this.repository.createStash(message, includeUntracked); </ins> this.closeDiffEditors(indexResources, workingGroupResources); }); }
Change:
in vscode , the formula is rendered with katex, an KaTeX parse Error occurred ! in pycharm , it's rendered properly with mathjax ! latex code:
The equation renders fine if you wrap it in so I reckon it's related to how we handle bare math blocks. Relevant code:
wow
Hi Can I work on this?
sure
Can you let me know where to get started? As per the last comment, it works when wrapping with "$$" so I figure I need to look into how vscode is rendering lateX in general? any other pointers?
the reason is probably katex can't process environments outside $$ , but i wonder if katex has a similar option 'processEnvironments' like MathJax provides
This is the same for .NET Interactive
This is indeed a pain - especially for someone still going through the learning process and not a LaTeX expert by any means.

Discussion:
"@iktakahiro/markdown-it-katex@mjbvz/markdown-it-katex": <del> version "4.0.3" resolved "https://codeload.github.com/mjbvz/markdown-it-katex/tar.gz/58f6637b5883caa8a811f1736bc90b34cd26b395" </del> <ins> version "4.0.4" resolved "https://codeload.github.com/mjbvz/markdown-it-katex/tar.gz/cfcbc640a2780f2349d4e137ad51638f39279aa7" </ins> dependencies: katex "^0.16.2"
Change:
The new lazy variable evaluation button line-height or dimensions appear to be too large. The button creates frequent gaps in-between node items and creates unsightly misalignment. This is not a settings font issue because the issue appeared with the change to the lazy evaluation button in version 1.67.1. This new button does not improve JavaScript debugging. The ellipsis button did not do this. Version: 1.67.1 (user setup) Commit: Date: 2022-05-06T12:37:03.389Z Electron: 17.4.1 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Windows_NT x64 10.0. Does this issue occur when all extensions are disabled?: Yes Steps to Reproduce: JavaScript object to console window the gaps between expandable nodes any collapsed variable to evaluate. The item will jump and become misaligned. !
Hey is there a reason that the variables view tree is 22px tall while the hover variables rows are 18px tall? I just noticed this.
I think the idea is to make the debugHover tree smaller, while the other trees in views should be larger. The problem here seems to be that the debugHover reuses the and by that the height of the hover items is 22. So the height should be configurable, and debugHover should be able to say to the variableDelagate that the height is 18 in this case.
The variables tree in the debug hover is correctly sized. It's just a CSS issue on that one button. I guess it's intentional, and that's fine, so I'll just fix the css.
okey. Thanks for fixing
This broke the alignment of the lazy button in the debug console because the text wraps there

Discussion:
/* Expressions */ <ins> .monaco-workbench .debug-pane .monaco-list-row .expression, .monaco-workbench .debug-hover-widget .monaco-list-row .expression { display: flex; } </ins> .monaco-workbench .debug-pane .monaco-list-row .expression, .monaco-workbench .debug-hover-widget .monaco-list-row .expression { font-size: 13px;

.monaco-workbench .monaco-list-row .expression .lazy-button { margin-left: 3px; <ins> display: none; border-radius: 5px; align-self: center; } .monaco-workbench .monaco-list-row .expression.lazy .lazy-button { display: inline; </ins> } /* Links */

font-style: italic; } <del> .monaco-workbench .monaco-list-row .expression .lazy-button { display: none; border-radius: 5px; padding: 3px; } .monaco-workbench .monaco-list-row .expression.lazy .lazy-button { display: inline; } </del> .monaco-workbench .debug-inline-value { background-color: var(--vscode-editor-inlineValuesBackground); color: var(--vscode-editor-inlineValuesForeground);

font-size: 11px; } <del> .debug-pane .monaco-list-row .expression { display: flex; } </del> .debug-pane .monaco-list-row .expression .actionbar-spacer { flex-grow: 1; }
Change:
The new lazy variable evaluation button line-height or dimensions appear to be too large. The button creates frequent gaps in-between node items and creates unsightly misalignment. This is not a settings font issue because the issue appeared with the change to the lazy evaluation button in version 1.67.1. This new button does not improve JavaScript debugging. The ellipsis button did not do this. Version: 1.67.1 (user setup) Commit: Date: 2022-05-06T12:37:03.389Z Electron: 17.4.1 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Windows_NT x64 10.0. Does this issue occur when all extensions are disabled?: Yes Steps to Reproduce: JavaScript object to console window the gaps between expandable nodes any collapsed variable to evaluate. The item will jump and become misaligned. !
Hey is there a reason that the variables view tree is 22px tall while the hover variables rows are 18px tall? I just noticed this.
I think the idea is to make the debugHover tree smaller, while the other trees in views should be larger. The problem here seems to be that the debugHover reuses the and by that the height of the hover items is 22. So the height should be configurable, and debugHover should be able to say to the variableDelagate that the height is 18 in this case.
The variables tree in the debug hover is correctly sized. It's just a CSS issue on that one button. I guess it's intentional, and that's fine, so I'll just fix the css.
okey. Thanks for fixing
This broke the alignment of the lazy button in the debug console because the text wraps there

Discussion:
word-break: break-all; } <ins> .monaco-workbench .repl .repl-tree.word-wrap .monaco-tl-contents .expression.nested-variable { white-space: pre; /* Preserve whitespace but don't wrap */ } </ins> .monaco-workbench.mac .repl .repl-tree .monaco-tl-twistie.collapsible + .monaco-tl-contents, .monaco-workbench.mac .repl .repl-tree .monaco-tl-twistie { cursor: pointer;

protected renderExpression(expression: IExpression, data: IExpressionTemplateData, highlights: IHighlight[]): void { renderVariable(expression as Variable, data, true, highlights, this.linkDetector); <ins> data.expression.classList.toggle('nested-variable', isNestedVariable(expression)); </ins> } protected getInputBoxOptions(expression: IExpression): IInputBoxOptions | undefined {
Change:
LSP now support pull diagnostics. Adopt for [x] CSS [x] JSON [x] HTML

Discussion:
languageServices.scss = getSCSSLanguageService({ fileSystemProvider: requestService, clientCapabilities: params.capabilities }); languageServices.less = getLESSLanguageService({ fileSystemProvider: requestService, clientCapabilities: params.capabilities }); <del> const pullDiagnosticSupport = getClientCapability('textDocument.diagnostic', undefined); if (pullDiagnosticSupport === undefined) { </del> <ins> const supportsDiagnosticPull = getClientCapability('textDocument.diagnostic', undefined); if (supportsDiagnosticPull === undefined) { </ins> diagnosticsSupport = registerDiagnosticsPushSupport(documents, connection, runtime, validateTextDocument); } else { diagnosticsSupport = registerDiagnosticsPullSupport(documents, connection, runtime, validateTextDocument);

foldingRangeLimit = getClientCapability('textDocument.foldingRange.rangeLimit', Number.MAX_VALUE); formatterMaxNumberOfEdits = initializationOptions?.customCapabilities?.rangeFormatting?.editLimit || Number.MAX_VALUE; <del> const pullDiagnosticSupport = getClientCapability('textDocument.diagnostic', undefined); if (pullDiagnosticSupport === undefined) { </del> <ins> const supportsDiagnosticPull = getClientCapability('textDocument.diagnostic', undefined); if (supportsDiagnosticPull === undefined) { </ins> diagnosticsSupport = registerDiagnosticsPushSupport(documents, connection, runtime, validateTextDocument); } else { diagnosticsSupport = registerDiagnosticsPullSupport(documents, connection, runtime, validateTextDocument);

return c; } clientSnippetSupport = getClientCapability('textDocument.completion.completionItem.snippetSupport', false); dynamicFormatterRegistration = getClientCapability('textDocument.rangeFormatting.dynamicRegistration', false) && (typeof initializationOptions.provideFormatter !== 'boolean'); foldingRangeLimitDefault = getClientCapability('textDocument.foldingRange.rangeLimit', Number.MAX_VALUE); hierarchicalDocumentSymbolSupport = getClientCapability('textDocument.documentSymbol.hierarchicalDocumentSymbolSupport', false); formatterMaxNumberOfEdits = initializationOptions.customCapabilities?.rangeFormatting?.editLimit || Number.MAX_VALUE; <del> const pullDiagnosticSupport = getClientCapability('textDocument.diagnostic', undefined); if (pullDiagnosticSupport === undefined) { </del> <ins> const supportsDiagnosticPull = getClientCapability('textDocument.diagnostic', undefined); if (supportsDiagnosticPull === undefined) { </ins> diagnosticsSupport = registerDiagnosticsPushSupport(documents, connection, runtime, validateTextDocument); } else { diagnosticsSupport = registerDiagnosticsPullSupport(documents, connection, runtime, validateTextDocument); } const capabilities: ServerCapabilities = { textDocumentSync: TextDocumentSyncKind.Incremental, completionProvider: clientSnippetSupport ? {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.67.1 OS Version: macOS 12.3.1 Steps to Reproduce: a new TypeScript extension using and open it in VS Code. Ctrl/Cmd+P and and type "task " that the task for watch is labeled "npm watch" (The task has no in ), while if you were to add it by choosing to configure it, it would have been generated with a label of "npm: watch".
A few years ago we improved the performance of the task quick pick by delaying going to extensions for tasks until a task actually needs to be run. This means that properties that aren't required to be in , like , are made up by the task system instead of fetched from the extension. Here's how we make up a task label: Here's where the npm extension provides the task name (label becomes for extension provided tasks: After the task has been run, then we'll save the actual task label and it will be shown in the quick pick next time. happy to discuss with you if you want!
do we intend to change this so that the extension task name is used on first run?
there isn't a perfect solution here. It was too expensive to fetch the actual task label from the extension which is why we're in this state. I think we could either: Change how we make up the task label in the hopes that we can get closer to what most tasks end up doing. Do nothing, the discrepancy resolves after first run and was the price we had to pay for better performance. I'm leaning slightly toward the first option since this this is one of the first things a new user of tasks might see. There's always the risk then that users might notice the change and be unhappy with it. Given that the change is just to add a in an existing string it's probably worth doing.

Discussion:
for (let required of typeDeclaration.required) { let value = result.configures[required]; if (value) { <del> label = label + ' ' + value; </del> <ins> label = label + ': ' + value; </ins> break; } }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.67.1 (user setup) OS: Windows_NT x64 10.0. Steps to Reproduce: following markdown code in jupyter notebook the cell formula wrapped in shows in display style ! ! correct in browser: !
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

Discussion:
"@iktakahiro/markdown-it-katex@mjbvz/markdown-it-katex": version "4.0.1" <del> resolved "https://codeload.github.com/mjbvz/markdown-it-katex/tar.gz/2e3736e4b916ee64ed92ebfabeaa94643612665a" </del> <ins> resolved "https://codeload.github.com/mjbvz/markdown-it-katex/tar.gz/1e0d09f9174b3ee1537de2586ce8d8a460284ce4" </ins> dependencies: katex "^0.13.0"
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66.2 OS Version: Web Steps to Reproduce: a banner set up with a link in it. over the link still uses the arrow cursor, rather than switching to the pointer which is more commonly associated with links.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.67.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
can you please provide a screen shot. Which banner do you mean?

Discussion:
padding: 3px; margin-left: 12px; text-decoration: underline; <ins> cursor: pointer; </ins> } .monaco-workbench .part.banner .message-container a { text-decoration: underline; <ins> cursor: pointer; </ins> } .monaco-workbench .part.banner .action-container {
Change:
Hover over the down arrow in the title bar search -"Show Quick Pick Options" shows up Not convinced by the wording here, most new users might not know what is a quick pick. Instead I would have something like "Search Modes", or something more understandable. These are not really options imho fyi for thoughts !
"Show Search Modes..." is the winner

Discussion:
const container = document.createElement('span'); container.classList.add('all-options'); parent.appendChild(container); <del> const action = new Action('all', localize('all', "Show Quick Pick Options..."), Codicon.chevronDown.classNames, true, () => { </del> <ins> const action = new Action('all', localize('all', "Show Search Modes..."), Codicon.chevronDown.classNames, true, () => { </ins> quickInputService.quickAccess.show('?'); }); const dropdown = new ActionViewItem(undefined, action, { icon: true, label: false, hoverDelegate });