Change:
Issue Type: <bBug</bPerform a search In the results panel, right-click a filename Select 'Reveal in Explorer' File is highlighted in the 'Files' side panel. VS Code version: Code 1.39.2 (, 2019-10-15T15:35:18.241Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (7)</summaryExtensionVersion ------ Bookmarks10.5.0 cucumberautocomplete2.14.1 vscode-svgviewer2.0.0 vscode-markdownlint0.31.1 vscode-eslint1.9.1 vscode-scss-formatter1.4.2 perforce3.2.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
what you refer to as "the 'Files' side panel" is called Explorer. So the current behaviour of 'Reveal in Explorer' from a filename in Search results makes sense. But I can see it's confusing because when you then right-click on the filename that's been revealed in VS Code's Explorer, you get another 'Reveal in Explorer', and that one opens a Windows Explorer onto the folder containing the file and highlights the file. I guess on macOS the equivalent context menu will say 'Reveal in Finder'.
Exactly.
So maybe the option in the Search side bar's context menu should be recaptioned 'Reveal in Explorer Side Bar' (1 change): Alternatively, make the Explorer side bar context menu on Windows use the caption 'Reveal in Windows Explorer' (3 changes):
fyi
I'm still on Windows, I right-click the tab of an open file, and it offers and .
on my 1.39.2 on Windows the context menu from a file tab captions the options "Reveal in Explorer" and "Reveal in Side Bar" (not "Open in ..." as you wrote). So for consistency I think the context menu from the filename on the Search list should be changed on this line to become
Fair enough. My point, though, was obviously regarding the inconsistency in numerology across the application.
We talked about this at the time. The thing is, "Explorer" is used in a bunch of places to refer to the file explorer in vscode and it doesn't seem like a big deal to me. However I realized that there is precedent for referring to it as "Side bar", the command "File: Reveal active file in side bar". I think that's kind of imprecise and also you are already looking at the search results in the side bar, so it doesn't make sense to "reveal in side bar" again. But anyway, I don't have a strong opinion.
We have been using the term "side bar" exactly for this reason: to have a way to distinguish between the Windows Explorer and the explorer in VSCode. We could in theory refer to it as "Explorer View", but that may cause frustration when users search for "reveal explorer" and find 2 results. I think no matter what we do, both commands should have a similar label. I don't think there is an issue calling the command in the search results "Reveal in Side Bar".
That'd be nice and clear.
are you willing to take my PR for this? It failed CI on windows and darwin but as far as I can tell that wasn't caused by anything in my PR itself.

Discussion:
const RevealInSideBarForSearchResultsCommand: ICommandAction = { id: Constants.RevealInSideBarForSearchResults, <del> title: nls.localize('revealInSideBar', "Reveal in Explorer") </del> <ins> title: nls.localize('revealInSideBar', "Reveal in Side Bar") </ins> }; MenuRegistry.appendMenuItem(MenuId.SearchContext, {