jiebi/CodeConvo huggingface dataset:
Change:
Extension version: v0.29.2 VSCode Version: 1.59.0 OS: GitHub editor / mac Steps to Reproduce: "" on the right side image, it zooms in ctrl down and the icon turns into a "zoom out" icon Expected outcome: Zoom out Actual outcome: You see a menu with "Cut", "Copy", "Paste"
The image preview editor is provided by VS Code core (instead of this extension), so moving this issue to VS Code.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.509 --- <!-- score: 0.493 --<!-- potentialduplicatescomment --
maybe a safari issue?
In Chrome, ctrl-click only shows the menu In Safari, ctrl-click zooms out and also shows the menu
Thanks for the additional details. In Edge, I get only the zoom out.
Working fine in firefox.
Issue exists in Safari browser, how can I fix this
yes it works in safari , but the the cursor remains zoom out cursor even when I don't press control, it doesn't change back to + symbol
Can i work on this??
if you didn't work to zoom in or zoom out you use simply method on keybord key ctrl + or ctrl - .
I really want to be VS Code contributor. I try to working on this task since yesterday. I hope I will find the fix and my first meeting with VSC will end with success ;)
Zoom in Works fine in Safari, however zoom out works but the magnifying glass disappears and I had to double click (not sure if this is intentional) to get the image to properly zoom out while zoom in only take one click.

Discussion:
]; const settings = getSettings(); <del> const isMac = settings.isMac; </del> <ins> const isMac = navigator.platform.toUpperCase().indexOf('MAC') >= 0; </ins> const vscode = acquireVsCodeApi();

private async getWebviewContents(): Promise<string> { const version = Date.now().toString(); const settings = { <del> isMac: isMac(), </del> src: await this.getResourcePath(this.webviewEditor, this.resource, version), };

} } <del> declare const process: undefined | { readonly platform: string }; function isMac(): boolean { if (typeof process === 'undefined') { return false; } return process.platform === 'darwin'; } </del> function escapeAttribute(value: string | vscode.Uri): string { return value.toString().replace(/"/g, '&quot;'); }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.59.0 OS Version: Linux JD 5.13.10-arch1-1 Although there is an option to close terminal after task completes running in , the option doesn't exist in interface TaskPresntationOptions Steps to Reproduce: VS Code extension a task in extension to set presentation field with close: ! Steps to Fix: close field to interface TaskPresntationOptions in ! TypeScript error: ! as expected, task closes after run: ! Adding this issue for a pull request
can you please describe why having the presentation options is important to have as extension API? We do not like to add API just for the sake of having it, so I want to understand that it will be useful for multiple extension authors before adding it.
Hi
sounds like you have a real use case for it. Thanks for the details!
Reopening for finalization

Discussion:
* Controls whether the terminal is cleared before executing the task. */ clear?: boolean; <ins> /** * Controls whether the terminal is closed after executing the task. */ close?: boolean; </ins> } /**

* Controls whether the task is executed in a specific terminal group using split panes. */ group?: string; <del> /** * Controls whether the terminal is closed after executing the task. */ close?: boolean; </del> } }
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I noticed some files like , etc. don't allow wrapping content with quotes: ! While a plain file allows that: ! Can we add the option to enable all files with this feature?
For that the quotes need to be ad autoClosingPairs in git language configurations files at (If it makes sense)
Can we do that in the or must via an extension?
This can't be done in settings. The feature request for that is:
I've submitted a PR for it:
Verification steps: the latest VS Code Insiders a folder/workspace that contains a git repository a change to a file, and press the "Commit" button (do not enter a commit messages) will open the COMMIT_EDITMSG file in a word, select it, and type Confirm that the word has been wrapped in
Verified.

Discussion:
["{", "}"], ["[", "]"], ["(", ")"] <ins> ], "autoClosingPairs": [ { "open": "{", "close": "}" }, { "open": "[", "close": "]" }, { "open": "(", "close": ")" }, { "open": "'", "close": "'", "notIn": ["string", "comment"] }, { "open": """, "close": """, "notIn": ["string"] }, { "open": "`", "close": "`", "notIn": ["string", "comment"] }, { "open": "/**", "close": " */", "notIn": ["string"] } </ins> ] <del> } </del>  No newline at end of file <ins> } </ins>

{ "comments": { "lineComment": "#", <del> } </del> <ins> }, "autoClosingPairs": [ { "open": "{", "close": "}" }, { "open": "[", "close": "]" }, { "open": "(", "close": ")" }, { "open": "'", "close": "'", "notIn": ["string", "comment"] }, { "open": """, "close": """, "notIn": ["string"] }, { "open": "`", "close": "`", "notIn": ["string", "comment"] }, { "open": "/**", "close": " */", "notIn": ["string"] } ] </ins> }
Change:
<img width="472" alt="capture" src="https://user-"
I think they look nice centered in the quick pick item. Any particular reason for this feedback?
I think they don't look nice :-), especially since the second line is rendered slightly dimmed.
This suggestion looks like it's in line with the documented design intent from in the VS Code design toolkit. The actions and shortcuts should be aligned with the primary text of the option. This makes the position stable whether the second line of supporting text is shown or not :) !
Yeah top aligned looks like it fits more imo
I think another reason for top right alignment is that when hovering over items, the action will always be in a consistent spot.
I think I'm use to seeing them center aligned because of Teams: !
Another example where we have multi-lines and actions shown is in notifications: <img width="466" alt="CleanShot 2021-09-01 at 12 04 53 src="https://user-"
LGTM

Discussion:
box-sizing: border-box; overflow: hidden; display: flex; <del> height: 100%; </del> padding: 0 6px; }

.quick-input-list .quick-input-list-entry-action-bar .action-label.codicon { margin-right: 4px; <del> padding: 0px 2px 2px 2px; </del> <ins> padding: 2px; </ins> } .quick-input-list .quick-input-list-entry-action-bar {
Change:
Issue Type: <bBug</bI could reproduce this issue only in a browser environment (using the project). Starting a jupyter notebook can sometimes fail to start the notebook (the editor keeps showing a blank page and a loading indicator that never stops). It's very frequent in Firefox and less frequent in Chrome. I also have a fix for the issue that I'll be submitting in a PR soon. VS Code version: Code 1.59.1 (Universal) (, 2021-08-19T11:53:52.479Z) OS version: Darwin x64 19.6.0 Restricted Mode: No <!-- generated by issue reporter --

Discussion:
} }; navigator.serviceWorker.addEventListener('message', versionHandler); <del> assertIsDefined(registration.active).postMessage({ channel: 'version' }); </del> <ins> const postVersionMessage = () => { assertIsDefined(navigator.serviceWorker.controller).postMessage({ channel: 'version' }) }; // At this point, either the service worker is ready and // became our controller, or we need to wait for it. // Note that navigator.serviceWorker.controller could be a // controller from a previously loaded service worker. const currentController = navigator.serviceWorker.controller; if (currentController && currentController.scriptURL.endsWith(swPath)) { // service worker already loaded & ready to receive messages postVersionMessage(); } else { // either there's no controlling service worker, or it's an old one: // wait for it to change before posting the message const onControllerChange = () => { navigator.serviceWorker.removeEventListener('controllerchange', onControllerChange); postVersionMessage(); }; navigator.serviceWorker.addEventListener('controllerchange', onControllerChange); } </ins> }, error => { reject(new Error(`Could not register service workers: ${error}.`));
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.59.1 OS Version: Win10 Bug description: WebviewPanel.viewColumn does not update when the column is changed by closing all files in a previous column. Steps to Reproduce: file in column 1 a WebviewPanel in column 2 file in column 1, shifting the WebviewPanel in column 2 into column 1 WebviewPanel.viewColumn Expected Result: WebviewPanel.viewColumn is correctly updated to reflect column 1 Actual Result: WebviewPanel.viewColumn says it is in column 2 until the user performs a tab action like opening or switching tabs.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.647 --- <!-- score: 0.556 --- <!-- score: 0.478 --<!-- potentialduplicates_comment --
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

Discussion:
*--------------------------------------------------------------------------------------------*/ import { onUnexpectedError } from 'vs/base/common/errors'; <ins> import { Event } from 'vs/base/common/event'; </ins> import { Disposable, DisposableMap } from 'vs/base/common/lifecycle'; import { URI } from 'vs/base/common/uri'; import { generateUuid } from 'vs/base/common/uuid';

this._proxy = context.getProxy(extHostProtocol.ExtHostContext.ExtHostWebviewPanels); <del> this._register(_editorService.onDidActiveEditorChange(() => { this.updateWebviewViewStates(this._editorService.activeEditor); })); this._register(_editorService.onDidVisibleEditorsChange(() => { </del> <ins> this._register(Event.any( _editorService.onDidActiveEditorChange, _editorService.onDidVisibleEditorsChange, _editorGroupService.onDidAddGroup, _editorGroupService.onDidRemoveGroup, _editorGroupService.onDidMoveGroup, )(() => { </ins> this.updateWebviewViewStates(this._editorService.activeEditor); }));
Change:
Allow installing extension packs those without code CC
To verify: Open Go to extensions view Browse for extension pack Make sure you can install this extension pack
Can you please verify this?
Verified on insiders: Version: 1.60.0-insider Commit: Date: 2021-09-01T01:33:58.665Z Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4544.0 Safari/537.36 Edg/93.0.933.1

Discussion:
let result = [...ALL_EXTENSION_KINDS]; <del> // Extension pack defaults to workspace extensionKind </del> <ins> // Extension pack defaults to workspace, web extensionKind </ins> if (isNonEmptyArray(manifest.extensionPack) || isNonEmptyArray(manifest.extensionDependencies)) { <del> result = ['workspace']; </del> <ins> result = ['workspace', 'web']; </ins> } if (manifest.contributes) {

let testObject = new ExtensionManifestPropertiesService(TestProductService, new TestConfigurationService(), new TestWorkspaceTrustEnablementService(), new NullLogService()); <del> test('declarative with extension dependencies => workspace', () => { assert.deepStrictEqual(testObject.getExtensionKind(<IExtensionManifest>{ extensionDependencies: ['ext1'] }), ['workspace']); </del> <ins> test('declarative with extension dependencies', () => { assert.deepStrictEqual(testObject.getExtensionKind(<IExtensionManifest>{ extensionDependencies: ['ext1'] }), ['workspace', 'web']); </ins> }); <del> test('declarative extension pack => workspace', () => { assert.deepStrictEqual(testObject.getExtensionKind(<IExtensionManifest>{ extensionPack: ['ext1', 'ext2'] }), ['workspace']); </del> <ins> test('declarative extension pack', () => { assert.deepStrictEqual(testObject.getExtensionKind(<IExtensionManifest>{ extensionPack: ['ext1', 'ext2'] }), ['workspace', 'web']); </ins> }); <del> test('declarative extension pack and extension dependencies => workspace', () => { assert.deepStrictEqual(testObject.getExtensionKind(<IExtensionManifest>{ extensionPack: ['ext1', 'ext2'], extensionDependencies: ['ext1', 'ext2'] }), ['workspace']); </del> <ins> test('declarative extension pack and extension dependencies', () => { assert.deepStrictEqual(testObject.getExtensionKind(<IExtensionManifest>{ extensionPack: ['ext1', 'ext2'], extensionDependencies: ['ext1', 'ext2'] }), ['workspace', 'web']); </ins> }); test('declarative with unknown contribution point => workspace, web', () => { assert.deepStrictEqual(testObject.getExtensionKind(<IExtensionManifest>{ contributes: <any>{ 'unknownPoint': { something: true } } }), ['workspace', 'web']); }); <del> test('declarative extension pack with unknown contribution point => workspace', () => { assert.deepStrictEqual(testObject.getExtensionKind(<IExtensionManifest>{ extensionPack: ['ext1', 'ext2'], contributes: <any>{ 'unknownPoint': { something: true } } }), ['workspace']); </del> <ins> test('declarative extension pack with unknown contribution point', () => { assert.deepStrictEqual(testObject.getExtensionKind(<IExtensionManifest>{ extensionPack: ['ext1', 'ext2'], contributes: <any>{ 'unknownPoint': { something: true } } }), ['workspace', 'web']); </ins> }); test('simple declarative => ui, workspace, web', () => {
Change:
STR: VS Code with locale set for language prompt and close it VS Code and repeat 1st step Language prompt shows again. has logic for storing an ignore key after a prompt was shown, but is using the wrong key (language instead of locale). The same variable mixup has caused prior breakage of the feature.
Forwarding to since he owns localization.
I partly own localizations support in VS Code especially recommending. It seems you come up with a fix. Do you mind opening a PR?
Ignore above comment, I see the PR now.
I'm still seeing this in insiders I clicked the on the notification and then restarted. After a few seconds, the prompt came up again
Found it. Only "Don't show again" triggers that logic, but just canceling doesn't. I wonder what the right behavior should be. Other prompts also depend on "Don't show again" (using the option, ) for a similar logic and otherwise pop up again on next launch. cc for guidance.
Clicking is never meant to be not to show again and user has to explicitly select action. I think this is general behavior for all prompts. I would recommend to discuss this UX change separately and mark this as verified otherwise.
Marking as verified based on comments above

Discussion:
if (!language || !locale || locale === 'en' || locale.indexOf('en-') === 0) { return; } <del> if (language === locale || languagePackSuggestionIgnoreList.indexOf(language) > -1) { </del> <ins> if (language === locale || languagePackSuggestionIgnoreList.indexOf(locale) > -1) { </ins> return; }

label: localize('neverAgain', "Don't Show Again"), isSecondary: true, run: () => { <del> languagePackSuggestionIgnoreList.push(language); </del> <ins> languagePackSuggestionIgnoreList.push(locale); </ins> this.storageService.store( LANGUAGEPACK_SUGGESTION_IGNORE_STORAGE_KEY, JSON.stringify(languagePackSuggestionIgnoreList),
Change:
As per bracket pairs should not be colorized in .txt files or any other non-programming language related files.
/assign
Makes sense. This can be fixed by setting for .txt and other files. Feel free to file a PR!
Would be good to know how to do that. I've created a folder inside and created a file in it with the following json - an empty array because I don't want any brackets colorized for .txt files, but that doesn't work. I have the exact same problem for .vue files where, in turn, even the <tags are colorized (inside the section of the .vue file) which I don't want to be colorized. I would appreciate if you could hint to a fix for these specifically, per file type/extension (or language type). Thanks.
Would these be non-programming languages? diff, dockerfile, dockercompose, git-commit, git-rebase, ignore, ini search-result, shaderlab, xsl
Good question... I think only the angle brackets colorization should be removed by default, from ALL languages/file extensions, and I hope that will be the road taken in
I couldn't figure out a way to pull changes from microsoft/vscode without introducing additional commits to existing pull request. Using seems to introduce an additional merge commit to the pr. Uisng seems to add me as contributor for new commits and add them to pr.
to avoid this you should have created a branch, made your change on the branch, then submitted the branch as a PR.

Discussion:
{ open: ''', close: ''' }, { open: '`', close: '`' }, ], <ins> colorizedBracketPairs: [], </ins> folding: { offSide: true }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Commit: Date: 2021-09-01T10:54:53.442Z Electron: 13.1.8 Chrome: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin x64 20.6.0 OS Version: MacOS big sur 11.5.2 Steps to Reproduce: use this settings follow shortcut any project, press f4 to debug. There should hit confirm restart dialog 2 delay to 500 f4, there aren't confirm restart dialog showing there are same question.
Does this issue has some result?
what is the exact reason that you cannot use "Restart" to do the "Stop"/"Start" sequence?
"Restart" in Rust will use previous binary. But I have changed my codes already, so I want to stop first, then start again, extension(lldb) will first recompile my codes.
It's important for Non-interpreter language. Javascript's "Restart" will re-interpreter codes, so it will always use latest codes. But in others, possibly not
Currently I'm using , executing , sequentially. But shortcuts But after pressed F4, dialog showed. I guess state from one process don't sync to another process. It I delay some second, there no dialog showing. Please see this
In clion(a jetbrains rust IDE), there are option showing that we can disable dialog forever. After clicking , recompile is the first step. !
Does have any progress?
Does have some result?
There is an await missing here: But I'm not sure whether that's enough to fix this issue. Would take a PR for it if someone else has the time to debug and investigate.
Recently made the same fix 2 lines above: I think just adding the await is fine.
I can still reproduce this bug in insider
Works fine for me, debugging in node, even with no delay. If you still see it, it could be an issue on the debug adapter's end? What are you debugging? Consider filing an issue on the debug extension.
For nodejs, If we have the prebuild task take 10s to finished in . Before vscode's toolbar become to yellow(maybe It's BeforeDebuggerSessionStart phase), press F4 will cause confirm restart dialog showing up
Ok but that will be sort of a different issue, if you open another issue I can take a look.
Ok

Discussion:
} catch (e) { // Catch the potential 'disconnect' error - no need to show it to the user since the adapter is shutting down } finally { <del> this.stopAdapter(error); </del> <ins> await this.stopAdapter(error); </ins> } } else { return this.stopAdapter(error);
Change:
This happens when the cwd is invalid, we could give a better error message <img width="645" alt="Screen Shot 2021-09-07 at 12 43 39 PM" src="https://user-"
Is "A native exception occurred during launch" the better error message?
We'd want to detect the error code: 267 part and present something more friendly like the terminal's starting directory doesn't exist, we already have a similar message which catches other cases of this so we'd want to align the wording with that:
Just the part might not have been handled but I managed to fit the rest in
Similar fix to
when I try this, I don't see a notification. in the console, I see:
it should show a notification as well To get this to repro, try commending out the section that handles cwd validation so we try to start the process with an invalid one.
Error handling needs some clean up

Discussion:
break; } this._exitCode = exitCodeOrError.code; <ins> if (exitCodeOrError.message.match(/.*error code:s*d{3}.*$/)) { exitCodeOrError.message = `Invalid starting directory ${this.initialCwd}, review your terminal.integrated.cwd setting.`; } </ins> exitCodeMessage = nls.localize('launchFailed.errorMessage', "The terminal process failed to launch: {0}.", exitCodeOrError.message); break; }