Change:
Repro: a file in vscode, example copy relative path command copy path of active file command We should add some unit tests for this or improve existing ones to catch this case.
Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our . Please take the time to review these and update the issue. Happy Coding!
Latest insiders, macOS, any workspaces. I use these commands many times per day and it's a huge pain to swap the separators every time. Version: 1.68.0-insider Commit: Date: 2022-06-01T05:17:25.414Z Electron: 17.4.6 Chromium: 98.0.4758.141 16.13.0 V8: 9.8.177.13-electron.0 OS: Darwin x64 21.5.0
Can you try to run where is an empty folder? This will ensure Code is starting with a fresh data directory, e.g. no specific settings and without any extensions running.
Still happens with
I'm looking into it now to make sure it's not on my end
I was asking because there is a setting, but it only applies to copying relative paths.
I tried clearing user data dir again and it worked, not sure what happened before, might not have made it into the clipboard for some reason or I made a mistake. When I repro it with extensions disabled and all settings cleared there are several formatters with the wrong separator: <img width="438" alt="Screen Shot 2022-06-01 at 9 07 40 am" src="https://user-"Definitely don't have set.
The bad formatters are coming through via the momento: Can extensions register these? Any ideas on how I could track down the source? I'll try adding my extensions in the clear user data dir.
to load all my extensions doesn't repro, I don't suppose the momento is synced across platforms? !
Likely cause of regression: cc
PR out:
this didn't end up fixing it because the synced formatters still seem to be getting pulled in. Any ideas on how we should clear out the bad cache? I was hoping this would be a quick drive by fix.
Anywhere labels are used gets impacted for multi platform users: <img width="396" alt="Screen Shot 2022-06-03 at 4 53 07 am" src="https://user-"
I think a bandaid fix is to either revert this change entirely or change the storage key that is used.
I don't think anyone has a strong preference on name so updating the storage key name is sane to me.
thanks, will do this today
Thanks for fixing this I didn't realize that we synced workspace state as part of settings sync.

Discussion:
this.os = OS; this.userHome = pathService.defaultUriScheme === Schemas.file ? this.pathService.userHome({ preferLocal: true }) : undefined; <del> const memento = this.storedFormattersMemento = new Memento('cachedResourceFormatters', storageService); </del> <ins> const memento = this.storedFormattersMemento = new Memento('cachedResourceLabelFormatters', storageService); </ins> this.storedFormatters = memento.getMemento(StorageScope.GLOBAL, StorageTarget.MACHINE); this.formatters = this.storedFormatters?.formatters || [];

test('label caching', () => { <del> const m = new Memento('cachedResourceFormatters', storageService).getMemento(StorageScope.GLOBAL, StorageTarget.MACHINE); </del> <ins> const m = new Memento('cachedResourceLabelFormatters', storageService).getMemento(StorageScope.GLOBAL, StorageTarget.MACHINE); </ins> const makeFormatter = (scheme: string): ResourceLabelFormatter => ({ formatting: { label: `${path} (${scheme})`, separator: '/' }, scheme }); assert.deepStrictEqual(m, {});