jiebi/CodeConvo huggingface dataset:
Change:
follow up after a notebook cell that displays multiple images down and select 'copy output to clipboard' on the last image :bug: the first image is selected and the notebook scrolls to reveal it

Discussion:
if (mimeType?.startsWith('image/')) { const editorService = accessor.get(IEditorService); const editor = editorService.activeEditorPane?.getControl() as INotebookEditor; <del> await editor.focusNotebookCell(outputViewModel.cellViewModel as ICellViewModel, 'output'); </del> <ins> await editor.focusNotebookCell(outputViewModel.cellViewModel as ICellViewModel, 'output', { skipReveal: true, outputId: outputViewModel.model.outputId }); </ins> editor.copyOutputImage(outputViewModel); } else { const clipboardService = accessor.get(IClipboardService);

readonly skipReveal?: boolean; readonly focusEditorLine?: number; readonly minimalScrolling?: boolean; <ins> readonly outputId?: string; </ins> } //#endregion

return; } <del> if (!options?.skipReveal) { this._webview.focusOutput(cell.id, this._webviewFocused); } </del> <ins> const focusElementId = options?.outputId ?? cell.id; this._webview.focusOutput(focusElementId, this._webviewFocused); </ins> cell.updateEditState(CellEditState.Preview, 'focusNotebookCell'); cell.focusMode = CellFocusMode.Output;

this.webview?.focus(); } <del> focusOutput(cellId: string, viewFocused: boolean) { </del> <ins> focusOutput(cellOrOutputId: string, viewFocused: boolean) { </ins> if (this._disposed) { return; }

this._sendMessageToWebview({ type: 'focus-output', <del> cellId, </del> <ins> cellOrOutputId: cellOrOutputId, </ins> }); }

export interface IFocusOutputMessage { readonly type: 'focus-output'; <del> readonly cellId: string; </del> <ins> readonly cellOrOutputId: string; </ins> } export interface IAckOutputHeight {

}); }; <del> function focusFirstFocusableOrContainerInOutput(cellId: string) { const cellOutputContainer = document.getElementById(cellId); </del> <ins> function focusFirstFocusableOrContainerInOutput(cellOrOutputId: string) { const cellOutputContainer = document.getElementById(cellOrOutputId); </ins> if (cellOutputContainer) { if (cellOutputContainer.contains(document.activeElement)) { return;

break; } case 'focus-output': <del> focusFirstFocusableOrContainerInOutput(event.data.cellId); </del> <ins> focusFirstFocusableOrContainerInOutput(event.data.cellOrOutputId); </ins> break; case 'decorations': { let outputContainer = document.getElementById(event.data.cellId);
Change:
Host OS: Windows 11 22H2 Steps to Reproduce: latest insiders tunnel CLI the tunnel link and see the following error in the logs <details<summaryLogs</summary</details
Hm, I don't repro this, do you see anythingin the Remote Tunnels output?
Nothing interesting in the logs, I also tried removing , and the keyring, but the issue persists. It also repros on my macOS device. However, I am able to use stable version of tunnels on these devices. <details<summaryCLI logs</summary</details
Comparing the debug output from stable tunnel CLI, looks like insiders is unable to make an ssh connection ? Anyway I can collect additional debug logs related to the ssh connection ? <details<summaryStable successful</summary</details<details<summaryInsiders failed</summary</details
Actually, I can reproduce this. It seems like the resolver extension is not consistently activated on Insiders. For me I only hit it sometimes and a refresh will fix it. This can be consistently hit in the smoke tests for tunnels which uses a new playright-controlled browser, or in an incognito window, but then manually refreshing the page fixes it. I notice in this case that the web worker extension host never gets spun up. I also notice I can reproduce this on a non-incognito window just be deleting indexdb database. (Interestingly, specifically deleting the and storage entires leads to a different error "no remote extension installed to resolve...", but then a refresh works.) were there any changes that could have affected this recently?
Turns out that was a bit of a goose chase... the actual cause is here, it seems like this blocks (deadlocks?) on the first load of vscode-dev when there's a remote, which prevents extensions from starting This then prevents the extension service from running which is the step where the remote authority gets resolved
We realized my repro steps were actually different than Deekpaks, but it was the same core issue and the PR fixes both :)
Thanks! verified the fix in today's insider.

Discussion:
) { super(); <del> if (environmentService.remoteAuthority && !environmentService.options?.credentialsProvider) { </del> <ins> if ( environmentService.remoteAuthority && !environmentService.options?.credentialsProvider && !environmentService.options?.secretStorageProvider ) { </ins> // If we have a remote authority but the embedder didn't provide a credentialsProvider, // we can use the CredentialsService on the remote side const remoteCredentialsService = ProxyChannel.toService<ICredentialsService>(remoteAgentService.getConnection()!.getChannel('credentials')); this.credentialsProvider = remoteCredentialsService; this._secretStoragePrefix = remoteCredentialsService.getSecretStoragePrefix(); } else { <del> // fall back to InMemoryCredentialsProvider if none was given to us. This should really only be used // when running tests. </del> <ins> // fall back to InMemoryCredentialsProvider if none was given to us. </ins> this.credentialsProvider = environmentService.options?.credentialsProvider ?? new InMemoryCredentialsProvider(); this._secretStoragePrefix = Promise.resolve(this.productService.urlProtocol); }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.81.1 OS Version: win10 Steps to Reproduce: new version vscode after 1.78.2 remote connection before vscode 1.78.2 in win 10 right click win10 taskbar show remote connect like ! but recently I update my vscode to 1.81.1, the information for remote node disapear. ! This bug is quite inconvenience when I have many projects with the same name in different remote nodes.
Same Issue Here
Do you own this part of the label service Aware of any changes?

Discussion:
} /** <del> * Splits a recent label in name and parent path, supporting both '/' and '' and workspace suffixes </del> <ins> * Splits a recent label in name and parent path, supporting both '/' and '' and workspace suffixes. * If the location is remote, the remote name is included in the name part. </ins> */ <del> export function splitRecentLabel(recentLabel: string) { </del> <ins> export function splitRecentLabel(recentLabel: string): { name: string; parentPath: string } { </ins> if (recentLabel.endsWith(']')) { // label with workspace suffix const lastIndexOfSquareBracket = recentLabel.lastIndexOf(' [', recentLabel.length - 2); if (lastIndexOfSquareBracket !== -1) { const split = splitName(recentLabel.substring(0, lastIndexOfSquareBracket)); <del> return { name: split.name, parentPath: split.parentPath + recentLabel.substring(lastIndexOfSquareBracket) }; </del> <ins> const remoteNameWithSpace = recentLabel.substring(lastIndexOfSquareBracket); return { name: split.name + remoteNameWithSpace, parentPath: split.parentPath }; </ins> } } return splitName(recentLabel);
Change:
Currently sticky scroll is grouped with the breadcrumbs in the context menu which appears on right click on sticky scroll. Henceforth it should be grouped with it too in the menu. cc

Discussion:
}, menu: [ { id: MenuId.CommandPalette }, <del> { id: MenuId.MenubarViewMenu, group: '5_editor', order: 2 }, </del> <ins> { id: MenuId.MenubarAppearanceMenu, group: '4_editor', order: 3 }, </ins> { id: MenuId.StickyScrollContext } ] });

menu: { id: MenuId.MenubarAppearanceMenu, group: '4_editor', <del> order: 4 </del> <ins> order: 5 </ins> } }); }

menu: { id: MenuId.MenubarAppearanceMenu, group: '4_editor', <del> order: 3 </del> <ins> order: 4 </ins> } }); }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Type: Bug Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Version: 1.81.1 Commit: Date: 2023-08-09T22:18:39.991Z Electron: 22.3.18 ElectronBuildId: Chromium: 108.0.5359.215 16.17.1 V8: 10.8.168.25-electron.0 OS: Linux x64 5.15.0-76-generic Steps to Reproduce: Settings, find a block comprised of a list of items; the column size so that some of the items wrap towards next line, and you can observe the list overflows.
is that u r using some go extension
The screencast did, but it's merely for demostrating the bug. The bug itself is irrelevant to any extension.
Duplicate of

Discussion:
} const header = this.renderHeader(); <del> const ITEM_HEIGHT = 24; let listHeight = ITEM_HEIGHT * this.model.items.length; </del> if (header) { <del> listHeight += ITEM_HEIGHT; </del> this.listElement.appendChild(header); } this.rowElements = this.model.items.map((item, i) => this.renderDataOrEditItem(item, i, focused)); this.rowElements.forEach(rowElement => this.listElement.appendChild(rowElement)); <del> this.listElement.style.height = listHeight + 'px'; </del> } protected createBasicSelectBox(value: IObjectEnumData): SelectBox {
Change:
Type: <bBug</bHere's the markdown content. The following are the effects rendered in different software / website Visual Studio Code ! Visual Studio ! Github a Properties: id href Defines a hyperlink form Stackoverflow ! As you can see in Visual Studio Code, there's a big gap before the sub list, but there's a small gap after the sub list. Now it's too ugly, I think they should at least be consistent. BTW, different themes have no impact on this. VS Code version: Code 1.81.1 (, 2023-08-09T22:22:42.175Z) OS version: Windows_NT x64 10.0. Modes: <!-- generated by issue reporter --

Discussion:
line-height: 0; } <del> ul ul, ul ol, ol ul, ol ol { </del> <ins> ul ul:first-child, ul ol:first-child, ol ul:first-child, ol ol:first-child { </ins> margin-bottom: 0; }

margin-bottom: 16px; } <ins> li p { margin-bottom: 0.7em; } </ins> ul, ol { margin-bottom: 0.7em;
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.81.1 OS Version: Windows 10 Pro (.2965) Steps to Reproduce: to add a port forward for example to "webservice1:80" (either via the view or command) UI gives the error "Forwarded port should be a number or a host:port" ! Using dashes would work. ! But that would not be so practical. Especially when working with dev containers, tunneling to other containers mostly happens via their name, which a lot of times includes underscores.

Discussion:
}, { "type": "string", <del> "pattern": "^([a-z0-9-]+):(d{1,5})$" </del> <ins> "pattern": "^([a-z0-9_-]+):(d{1,5})$" </ins> } ] }

} export function parseAddress(address: string): { host: string; port: number } | undefined { <del> const matches = address.match(/^([a-zA-Z0-9-]+(?:.[a-zA-Z0-9-]+)*:)?([0-9]+)$/); </del> <ins> const matches = address.match(/^([a-zA-Z0-9_-]+(?:.[a-zA-Z0-9_-]+)*:)?([0-9]+)$/); </ins> if (!matches) { return undefined; }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Insiders OS Version: Steps to Reproduce: Jupyter extension VS Code and ensure there are no documents open a new untitled notebook via the command a kernel the notebook the explorer view and you'll see that item is displayed to close VS Code or use the command to close all editors (even though there are none) and now you're prompted to save the changes, even when no notebook is open.
possible regression from the implementation of in the notebook editor - The tab should be dirty as the file is untitled

Discussion:
override isSaving(): boolean { const model = this._editorModelReference?.object; <del> if (!model || !model.isDirty() || model.hasErrorState) { return false; // require the model to be dirty and not in an error state </del> <ins> if (!model || !model.isDirty() || model.hasErrorState || this.hasCapability(EditorInputCapabilities.Untitled)) { return false; // require the model to be dirty, file-backed and not in an error state </ins> } // if a short auto save is configured, treat this as being saved
Change:
Sometimes inlay hints are off for a short amount of time: ! It happens randomly and fixes itself quickly: ! I cannot reproduce it in isolation or in the monaco editor playground, but I see it very often when working in the VS Code repo. I think this is what happens: I type somewhere to trigger a delayed update I wait until the delay completes and the provider is asked I add new lines The provider comes back, but does not consider the edits in between The inlay hints are off I'm not sure if this is an issue of the inlay hints feature or typescripts implementation.
/duplicate of
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for . See also our . Happy Coding!
I still do think is buggy behavior and not a problem of delays. The initial screenshot should not be observed, regardless of delays. I'm not sure though if this is a typescript bug or inlay hint bug. And I can still reproduce it by doing random edits (took me some minutes though): !
this is still a duplicate of
Repro steps: Wait for 4 seconds, notice the inlay hint afer Press enter in line 1 Wait for 1 second Press enter in line 1 every 100 ms Notice that after 3 seconds there are invalid inline suggestions ! Validation: In the playground, click on "Compare with latest dev" Verify that there are no invalid inline suggestions after doing the steps again

Discussion:
} })); this._sessionDisposables.add(this._editor.onDidChangeModelContent((e) => { <ins> cts?.cancel(); </ins> // update less aggressive when typing const delay = Math.max(scheduler.delay, 1250); scheduler.schedule(delay);
Change:
This never really stopped happening: ! Version: 1.82.0-insider (user setup) Commit: Date: 2023-08-21T05:32:43.957Z Electron: 25.5.0 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows_NT x64 10.0.
No reload, works as expected: ! First reload: Lacks , spinner never completes for the second (dependent) task ! Second reload: , no status for first task, spinner never completes for the second (dependent task) !
This is happening because for the initial run, we are running which contains dependency tasks. On reload, and are getting run individually, so doesn't happen. !
One issue is we use to determine if we should persist a task. since that is false for , it doesn't get saved and only it's components do.
I sometimes see this not just after a reload, and saving to trigger a new watch doesn't update it to a tick still
Can you reproduce that without reloading? I haven't been able to.
linked PR just fixes the issue in which one reloads the window after running the build task (or any task with dependencies)
Actually, I believe it's the and events that are needed here.
it's hard to repro unfortunately. We can go with this fix and I'll keep an eye out
Verify that clicking on the terminal tabs of task terminals does not remove the statuses.

Discussion:
for (let i = bufferLines.length - 1; i >= 0; i--) { watchingProblemMatcher.processLine(bufferLines[i]); } <ins> this._fireTaskEvent(TaskEvent.general(TaskEventKind.Active, task, terminal.instanceId)); </ins> } } else { [terminal, error] = await this._createTerminal(task, resolver, workspaceFolder);
Change:
I think we used to do this. The below profile was generated by opening a ~100mb typescript file and copy and pasting its contents. The editor locked up for about 2-3 minutes before tokenization finished. After it finished it was reasonably fast but a slower computer may crash from this and waiting minutes for something to finish is not reasonable. ! Version: 1.82.0-insider (user setup) Commit: Date: 2023-08-21T05:32:43.957Z Electron: 25.5.0 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows_NT x64 10.0.
I had set, even though it's async we still shouldn't be doing it for files this large unless the user force enables it.
As in freezed? In the profile it looks it just reacts on the onmessage event, the UI shouldn't freeze.
You can see the task in the screenshot takes ~600ms, so the editor dropped to ~2 fps for 3 minutes or less fps when other things were happening in the same task.

Discussion:
if (tokenizationSupport && tokenizationSupport.createBackgroundTokenizer && !tokenizationSupport.backgroundTokenizerShouldOnlyVerifyTokens) { this._backgroundTokenizer.value = tokenizationSupport.createBackgroundTokenizer(this._textModel, b); } <del> if (!this._backgroundTokenizer.value) { </del> <ins> if (!this._backgroundTokenizer.value && !this._textModel.isTooLargeForTokenization()) { </ins> this._backgroundTokenizer.value = this._defaultBackgroundTokenizer = new DefaultBackgroundTokenizer(this._tokenizer, b); this._defaultBackgroundTokenizer.handleChanges();
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Related to Swap header ellipses to semi-colons - less confusing vs actual links in other vs code instances

Discussion:
const uncategorizedCodeActionGroup = Object.freeze<ActionGroup>({ kind: CodeActionKind.Empty, title: localize('codeAction.widget.id.more', 'More Actions...') }); const codeActionGroups = Object.freeze<ActionGroup[]>([ <del> { kind: CodeActionKind.QuickFix, title: localize('codeAction.widget.id.quickfix', 'Quick Fix...') }, { kind: CodeActionKind.RefactorExtract, title: localize('codeAction.widget.id.extract', 'Extract...'), icon: Codicon.wrench }, { kind: CodeActionKind.RefactorInline, title: localize('codeAction.widget.id.inline', 'Inline...'), icon: Codicon.wrench }, { kind: CodeActionKind.RefactorRewrite, title: localize('codeAction.widget.id.convert', 'Rewrite...'), icon: Codicon.wrench }, { kind: CodeActionKind.RefactorMove, title: localize('codeAction.widget.id.move', 'Move...'), icon: Codicon.wrench }, { kind: CodeActionKind.SurroundWith, title: localize('codeAction.widget.id.surround', 'Surround With...'), icon: Codicon.symbolSnippet }, { kind: CodeActionKind.Source, title: localize('codeAction.widget.id.source', 'Source Action...'), icon: Codicon.symbolFile }, </del> <ins> { kind: CodeActionKind.QuickFix, title: localize('codeAction.widget.id.quickfix', 'Quick Fix:') }, { kind: CodeActionKind.RefactorExtract, title: localize('codeAction.widget.id.extract', 'Extract:'), icon: Codicon.wrench }, { kind: CodeActionKind.RefactorInline, title: localize('codeAction.widget.id.inline', 'Inline:'), icon: Codicon.wrench }, { kind: CodeActionKind.RefactorRewrite, title: localize('codeAction.widget.id.convert', 'Rewrite:'), icon: Codicon.wrench }, { kind: CodeActionKind.RefactorMove, title: localize('codeAction.widget.id.move', 'Move:'), icon: Codicon.wrench }, { kind: CodeActionKind.SurroundWith, title: localize('codeAction.widget.id.surround', 'Surround With:'), icon: Codicon.symbolSnippet }, { kind: CodeActionKind.Source, title: localize('codeAction.widget.id.source', 'Source Action:'), icon: Codicon.symbolFile }, </ins> uncategorizedCodeActionGroup, ]);