jiebi/CodeConvo huggingface dataset:
Change:
<!-- Please search existing issues to avoid creating duplicates. --- VS Code version: 1.68.0 (Universal) / 1.69.0-insider (Universal) Jupyter Extension version (available under the Extensions sidebar): v2022.6. Python Extension version (available under the Extensions sidebar): v2022.8.0 OS (Windows Linux distro) and version: macOS Monterey version 12.4 Python and/or Anaconda version: Python 3.10.4 Type of virtual environment used (N/A ...): - Jupyter server running: Local Ipywidgets Dropdown selector should stay open until the user click on the desired selection. When combining several types of selector (e.g. a slider and a dropdown), the Dropdown menu flashes briefly and doesn't stay open, so the selection is impossible. This issue seems to appear only for a combination of selectors (a dropdown alone works properly). This issue appears in VSCode but not in Jupyter Lab. !
Sorry you are running into this issue and thanks for filing this issue. I can repro this issue at my end, will look into this.
Note for Team: I can repro this for a lot of widgets that use dropdown and textboxes/sliders. Seems like a pretty bad regression, basically I'm unable to select anything from the dropdown. I've tested this with VS Code Version 1.66 and older versions of Jupyter along with the latest dev version of VS Code Jupyter and it works as expected. Seems like a regression in VS Code.
From Don's analysis this looks to have regressed recently.
While waiting for a resolution to this issue, a temporary workaround (and additional info to the issue that is not captured in the above posts) if you are only working with one dropdown menu is to place it first of all widgets. It seems the first widget will constantly get focus, which is what causes the dropdown menu to instantly close if it's placed after any other widgets. If the first widget is the dropdown menu, it will still sometimes flash, but for the most part work. If you have several dropdown menus this will only work for the first widget.
thanks ras, that worked! Also nothing that this is still an ongoing issue with the june update
I think this should have the 'candidate' label. It is assigned to the June 2022 Recovery 2 milestone but lacks the label to make it appear on the candidate query results.

Discussion:
function focusFirstFocusableInCell(cellId: string) { const cellOutputContainer = document.getElementById(cellId); if (cellOutputContainer) { <ins> if (cellOutputContainer.contains(document.activeElement)) { return; } </ins> const focusableElement = cellOutputContainer.querySelector('[tabindex="0"], [href], button, input, option, select, textarea') as HTMLElement | null; focusableElement?.focus(); }
Change:
This is the main thing I wanted from the task icons, if tasks of of kind to use the beaker: ! I think this makes sense over a setting since we can now override them via the property and the beaker icon aligns with our testing pane
I like it!

Discussion:
import { INotificationService } from 'vs/platform/notification/common/notification'; import { ThemeIcon } from 'vs/platform/theme/common/themeService'; import { formatMessageForTerminal } from 'vs/platform/terminal/common/terminalStrings'; <ins> import { GroupKind } from 'vs/workbench/contrib/tasks/common/taskConfiguration'; import { Codicon } from 'vs/base/common/codicons'; </ins> interface ITerminalData { terminal: ITerminalInstance;

os, remoteAuthority: this._environmentService.remoteAuthority }); <ins> let icon: URI | ThemeIcon | { light: URI; dark: URI } | undefined; if (task.configurationProperties.icon) { icon = ThemeIcon.fromId(task.configurationProperties.icon); } else { const taskGroupKind = task.configurationProperties.group ? GroupKind.to(task.configurationProperties.group) : undefined; const kindId = typeof taskGroupKind === 'string' ? taskGroupKind : taskGroupKind?.kind; icon = kindId === 'test' ? ThemeIcon.fromId(Codicon.beaker.id) : defaultProfile.icon; } </ins> shellLaunchConfig = { name: terminalName, type, executable: defaultProfile.path, args: defaultProfile.args, env: { ...defaultProfile.env }, <del> icon: task.configurationProperties.icon ? ThemeIcon.fromId(task.configurationProperties.icon) : defaultProfile.icon, </del> <ins> icon, </ins> color: task.configurationProperties.color || defaultProfile.color, waitOnExit };
Change:
Given crash reports are now enabled in smoke tests, here is a Linux smoke test crash as I had indicated before: This could be an Electron 18 regression? Build:
Another one -
Update on the issue with symbolicating the dump, currently the minidump stacks are corrupted when using the tool. Investigating revealed the symbols generated from the internal build only contain exported symbols because generation happens after stripping the binaries on linux. Currently working on a fix for it.
Symbols are now fixed with , if we can get newer crash dumps with this change, it can help move this issue forward.
The above report was from the build and the original version was from , considering the build environments to be same, here is the symbolicated trace
Crash because the compositor is unable to create shared memory to transfer layout tiles to the gpu, this is usually the case when running under container environment where the default size of is not sufficient. We already disable it for integration and unit tests , not sure why we missed smoke tests. Will send a PR to address it.
Wow
Hm that does not explain the macOS crash though, unfortunately no crash report.
Which CI run has the macOS crash ? Yeah macOS crash would be a different cause if it was present.
nvm I believe you are referring to
Yes,

Discussion:
} if (process.platform === 'linux') { <del> args.push('--disable-gpu'); // Linux has trouble in VMs to render properly with GPU enabled </del> <ins> // --disable-dev-shm-usage: when run on docker containers where size of /dev/shm // partition < 64MB which causes OOM failure for chromium compositor that uses // this partition for shared memory. // Refs https://github.com/microsoft/vscode/issues/152143 args.push('--disable-dev-shm-usage'); </ins> } if (remote) {
Change:
Failed again, will skip.
Very likely the share the same root cause as
Should now be resolved. If we see it later we would create an issue and treat as bug.

Discussion:
assert.strictEqual(selectionRedo[0].end, 2); }); <del> test('editor editing event', async function () { </del> <ins> test.skip('editor editing event', async function () { // TODO@rebornix https://github.com/microsoft/vscode/issues/152145 </ins> const notebook = await openRandomNotebookDocument(); const editor = await vscode.window.showNotebookDocument(notebook);
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.0 OS Version: Linux x64 5.18.3-zen1-1-zen Steps to Reproduce: code display nothing.
<!-- -96bd-47a8-a0e8- --This feature request is now a candidate for our backlog. The community has 60 days to the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our . Happy Coding!
Actually this is already enabled, you just need to set as well as . The bug is that theme icons gets stripped from an without an href
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
/verified

Discussion:
|| /^command:(///)?_workbench.downloadResource/i.test(href) ) { // drop the link <del> a.replaceWith(a.textContent ?? ''); </del> <ins> a.replaceWith(...a.childNodes); </ins> } else { let resolvedHref = _href(href, false); if (markdown.baseUri) {

</tbody></table> `); }); <ins> test('render icon in <a> without href (#152170)', () => { const mds = new MarkdownString(undefined, { supportThemeIcons: true, supportHtml: true }); mds.appendMarkdown(`<a>$(sync)</a>`); const result: HTMLElement = renderMarkdown(mds).element; assert.strictEqual(result.innerHTML, `<p><span class="codicon codicon-sync"></span></p>`); }); </ins> }); suite('ThemeIcons Support Off', () => {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.1 OS Version: Windows_NT x64 10.0. Steps to Reproduce: a JSON file in which values including , with a pair of escaped double quotes like below. lines between and by + /, then these lines are indented incorrectly. ! [Edited] This issue still remains in 1.68.1 (the latest version at 2022/6/17).
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.68.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!

Discussion:
{ "open": "`", "close": "`", "notIn": ["string", "comment"] } ], "indentationRules": { <del> "increaseIndentPattern": "({+(?=([^"]*"[^"]*")*[^"}]*$))|([+(?=([^"]*"[^"]*")*[^"]]*$))", </del> <ins> "increaseIndentPattern": "({+(?=((.|[^"])*"(.|[^"])*")*[^"}]*)$)|([+(?=((.|[^"])*"(.|[^"])*")*[^"]]*)$)", </ins> "decreaseIndentPattern": "^s*[}]],?s*$" } }
Change:
Not a bug really but it's not really a feature request or question either. <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No Yes. <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.68.0 OS Version: macOS Big Sur 11.6.6 Steps to Reproduce: to Code Preferences Settings Workbench Editor Management description for the Untitled: Hint setting says "Controls if the untitled hint should be inline text in the editor or a floating button or hidden." but there is not an option in the select list for a floating button. If the button feature was removed, then this description should be updated to reflect that.
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.68.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Issue is still there in 1.68.1.
For reference, the setting ID is , and the setting description does appear to be outdated. Assigning to

Discussion:
'type': 'string', 'enum': ['text', 'hidden'], 'default': 'text', <del> 'markdownDescription': localize({ comment: ['This is the description for a setting. Values surrounded by single quotes are not to be translated.'], key: 'untitledHint' }, "Controls if the untitled hint should be inline text in the editor or a floating button or hidden.") </del> <ins> 'markdownDescription': localize({ comment: ['This is the description for a setting. Values surrounded by single quotes are not to be translated.'], key: 'untitledHint' }, "Controls if the untitled text hint should be visible in the editor.") </ins> }, 'workbench.editor.languageDetection': { type: 'boolean',
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.69.0-insider OS Version: Windows 10 Steps to Reproduce: Two split terminals + one standalone terminal, select them all then join. !
this works now, must've been fixed
I tried it in the latest insider build, still fails. Instead of selecting the terminal tabs one by one, can you try to select all, then join them? If you can reproduce, please reopen it.

Discussion:
break; } } <del> if (!differentGroups) { </del> <ins> if (!differentGroups && group.terminalInstances.length === instances.length) { </ins> return; } }
Change:
! cc
is this with latest from main, eg out of source? I believe there is no insiders with the larger titlebar (due to CC)
the activity bar also changes size... there must be more to it. I guess rapid render is getting wrong values. Do you use zoom?
Correct, this is main on OSS. Confirmed that I wasn't zoomed.
is there some conflict of zoom here? Even the watermark renders for a bit slightly enlarged before shrinking?
I can only reproduce with zoom enabled, e.g zoom in once or twice reload workbench rapid render but also water mark are wrongly sized during load
LGTM other than the window controls overlay (WCO), which is being tracked at

Discussion:
document.head.appendChild(style); style.textContent = `body { background-color: ${shellBackground}; color: ${shellForeground}; margin: 0; padding: 0; }`; <ins> // set zoom level as soon as possible if (typeof data?.zoomLevel === 'number' && typeof globalThis.vscode?.webFrame?.setZoomLevel === 'function') { globalThis.vscode.webFrame.setZoomLevel(data.zoomLevel); } </ins> // restore parts if possible (we might not always store layout info) if (data?.layoutInfo) { const { layoutInfo, colorInfo } = data;

} export interface IPartsSplash { <ins> zoomLevel: number | undefined; </ins> baseTheme: string; colorInfo: { background: string;

@IWorkbenchEnvironmentService private readonly _environmentService: IWorkbenchEnvironmentService, @ILifecycleService lifecycleService: ILifecycleService, @IEditorGroupsService editorGroupsService: IEditorGroupsService, <del> @IConfigurationService configService: IConfigurationService, </del> <ins> @IConfigurationService private readonly _configService: IConfigurationService, </ins> @ISplashStorageService private readonly _partSplashService: ISplashStorageService ) { lifecycleService.when(LifecyclePhase.Restored).then(_ => {

savePartsSplashSoon.schedule(); }, undefined, this._disposables); <del> configService.onDidChangeConfiguration(e => { </del> <ins> _configService.onDidChangeConfiguration(e => { </ins> if (e.affectsConfiguration('window.titleBarStyle')) { this._didChangeTitleBarStyle = true; this._savePartsSplash();

const theme = this._themeService.getColorTheme(); this._partSplashService.saveWindowSplash({ <ins> zoomLevel: this._configService.getValue<undefined>('window.zoomLevel'), </ins> baseTheme: getThemeTypeSelector(theme.type), colorInfo: { foreground: theme.getColor(foreground)?.toString(),
Change:
Not much padding between it and the word: ! !
Passing to as this is a file icon but in the icon we actually have it designed at 14px scale (and offset to avoid pixelation) and i know the file icons use different scaling styles <img width="568" alt="CleanShot 2022-06-17 at 12 33 56 src="https://user-"
The trust editor uses a product icon (codicon) as editor icon here: I think this needs to be adjusted there.

Discussion:
font-family: 'codicon'; content: 'eb53'; background-image: none; <del> font-size: 150%; </del> <ins> font-size: 16px; line-height: 37px !important; </ins> } .workspace-trust-editor {
Change:
This test takes 30 seconds for me when running locally . !
Not sure why it takes you so long? It takes 6 seconds for me. ! The test has to execute a number of cells to make sure the output scrolls off the screen. Right now that number is 20. Executing 10 cells is probably enough on most screens, but it's still going to take a bit.
I think we should understand why execution time seems to get slower and slower the more cells there are. Check out this video, it looks as if things get slower and slower: !
Execution might be getting slower but the scrolling doesn't look like it's getting slower? That seems like a different issue.
Yeah, execution slows down, waiting for results.
Closing in favor of new issue.

Discussion:
assert.ok(notebookEditor); // Run and add a bunch of cells <del> for (let i = 0; i < 20; i++) { </del> <ins> for (let i = 0; i < 10; i++) { </ins> await addCellAndRun(`print ${i}`, notebookEditor.notebook); }
Change:
Noticed a flaky web remote smoke test run: Then diagnostics printed after shows this: Build: I think saw something similar. Did anything change with the server and how it shuts down? The server logs print MBs of this data: Full logs:
Looking at the left-over process: The server in the test also appears to want to start on port 8000: I think this might be caused by a missing over here: Edit I've created a PR at Regarding the server process leaking, could this be a consequence of the before hook failing? Is there any cleanup code running in the smoke test infrastructure to kill the server process in case the before hook throws?
Yeah we do: This is also relatively new, we have been running with this code for months now and only now I start to see this issue, but your fix will help nevertheless.

Discussion:
const args = [ '--disable-telemetry', '--disable-workspace-trust', <del> `--port${port++}`, </del> <ins> `--port=${port++}`, </ins> '--enable-smoke-test-driver', `--extensions-dir=${extensionsPath}`, `--server-data-dir=${agentFolder}`,
Change:
Testing in current Insiders. Loss of space character originally reported at by with screenshot Verified by me. Opening this issue for better tracking. /assign
I think will solve this. I am preparing a PR.
Hi I found that in 1.69.0, it's still style for the label - the whitespace is still losing.
We removed since it was causing issues, but the space in a different way. This is what I see, are you seeing something different? <img width="267" alt="image" src="https://user-"
Ok. I guess maybe it's because different codicons has different size? ! At the top you can see, the character looks very close to the square. Not a big issue though.
Yea, I think just different sizes. We now have the label be flex and use its . Text alignment on the web is always fun...

Discussion:
align-items: center; } <ins> .test-explorer .test-item .label { white-space: pre-wrap; } </ins> .test-explorer .test-item, .test-output-peek-tree .test-peek-item { display: flex;
Change:
VS Code Version: stable and from sources Terminals within a terminal group of size 1 should not show a subindex like the terminal in the first group !
Hey can I work on this issue if it's still open ?
Sorry but I already fixed it in this PR

Discussion:
const terminalGroup = terminalGroups[groupIndex]; for (let terminalIndex = 0; terminalIndex < terminalGroup.terminalInstances.length; terminalIndex++) { const terminal = terminalGroup.terminalInstances[terminalIndex]; <del> const pick = this._createPick(terminal, terminalIndex, filter, groupIndex); </del> <ins> const pick = this._createPick(terminal, terminalIndex, filter, { groupIndex, groupSize: terminalGroup.terminalInstances.length }); </ins> if (pick) { terminalPicks.push(pick); }

return terminalPicks; } <del> private _createPick(terminal: ITerminalInstance, terminalIndex: number, filter: string, groupIndex?: number): IPickerQuickAccessItem | undefined { </del> <ins> private _createPick(terminal: ITerminalInstance, terminalIndex: number, filter: string, groupInfo?: { groupIndex: number; groupSize: number }): IPickerQuickAccessItem | undefined { </ins> const iconId = getIconId(terminal); <del> const label = groupIndex ? `$(${iconId}) ${groupIndex + 1}.${terminalIndex + 1}: ${terminal.title}` : `$(${iconId}) ${terminalIndex + 1}: ${terminal.title}`; </del> <ins> const index = groupInfo ? (groupInfo.groupSize > 1 ? `${groupInfo.groupIndex + 1}.${terminalIndex + 1}` : `${groupInfo.groupIndex + 1}`) : `${terminalIndex + 1}`; const label = `$(${iconId}) ${index}: ${terminal.title}`; </ins> const iconClasses: string[] = []; const colorClass = getColorClass(terminal); if (colorClass) {
Change:
Issue Type: <bBug</bWhen I try to create an empty commit, this popup in the bottom-right comes up with the message "Commit operation was cancelled due to empty commit message.". This is after the latest Code Insiders update. Steps: 1 whitespace in the commit message box sync (check button in source control) comes This is a feature I use all the time, literally. I kindly request quick fixture of this issue. VS Code version: Code - Insiders 1.69.0-insider (, 2022-06-20T05:17:02.003Z) OS version: WindowsNT x64 10.0. Restricted Mode: No <details<summarySystem Info</summary </details<details<summaryExtensions (60)</summaryExtensionVersion ------ html-snippets0.2.1 jbart-studio0.6.8 code-gnu-global0.2.2 vscode-intelephense-client1.8.2 doxdocgen1.4.0 vscode-eslint2.2.2 vscode-html-css1.13.0 vsc-material-theme-icons2.3.1 cshtml0.1.3 cshtml-tm1.0.0 code-runner0.11.8 language-lava1.1.11 ghoul007-puppeteer-snippet1.1.2 vscode-pull-request-github0.44.0 better-cpp-syntax1.15.18 vscode-JS-CSS-HTML-formatter0.2.3 file-downloader1.0.12 vscode-docker1.22.0 csharp1.25.0 data-workspace-vscode0.2.1 mssql1.15.0 sql-bindings-vscode0.2.0 sql-database-projects-vscode0.17.1 jupyter2022.5. jupyter-renderers1.0.8 remote-containers0.240.0 remote-ssh0.82.1 remote-ssh-edit0.80.0 remote-wsl0.66.3 atom-keybindings3.0.9 cmake-tools1.11.26 cpptools1.11.0 cpptools-extension-pack1.2.0 vsliveshare1.0.5625 vsliveshare-audio0.1.91 sqltools0.23.0 puppeteer-snippets1.6.1 open-html-in-browser2.1.9 material-icon-theme4.18.1 webfocus0.2.3 aspx-html0.0.11 java1.7.0 vscode-yaml1.8.0 sql-snippets0.0.4 spgo1.7.3 sonarlint-vscode3.5.4 codevalet-vscode2.0.1 webfocus0.6.2 html-preview-vscode0.2.5 python0.2.3 pdf1.2.0 cmake0.0.17 vscodeintellicode1.2.21 vscode-arduino0.4.12 vscode-java-debug0.41.0 vscode-java-dependency0.19.1 vscode-java-pack0.23.0 vscode-maven0.35.2 php-debug1.27.0 html-css-class-completion1.20.0 (2 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
I tried clicking on the commit button without typing a message and the viewlet seems to be stuck. I'm able to create a commit with a single space as a message, though.

Discussion:
if (message) { options.input = message; <del> args.push('--file', '-'); </del> <ins> args.push('--allow-empty-message', '--file', '-'); </ins> } if (opts.verbose) {