jiebi/CodeConvo huggingface dataset:
Change:
VS Code version: 1.66.0 Jupyter Extension version (available under the Extensions sidebar): v2022.3. Python Extension version (available under the Extensions sidebar): v2022.4.0 OS (Windows Linux distro) and version: Windows 10 21H2 Python and/or Anaconda version: Python 3.9.7, Miniconda 4.12.0 Type of virtual environment used (N/A ...): python & conda environment both have this problem. Jupyter server running: Local & Remote both have this problem. Click and drag the vertical scroll bar should be able to scroll the window vertically. When hover the mouse over the scroll bar, it does not respond to click and drag. Touchpad works though. jupyter interactive window. the following code: click and drag the vertical scroll bar on the right. It does not work.
Thanks for the issue. This would be a vscode core issue. Seems like something is capturing the mouse input.
I would transfer it to VS code, but github seems to be having a problem with transferring at the moment.
I can no longer click on the scrollbar for the interactive window? Would this be your area?
I see this, only in the interactive window and not a normal notebook, seems like something must be covering the scrollbar but I can't figure out what
Same as issue
Hey I was wondering if there is a solution to this? I am being confronted with the same issue.

Discussion:
outline: none !important; } <del> .monaco-workbench .notebookOverlay.notebook-editor-editable > .cell-list-container > .monaco-list > .monaco-scrollable-element > .scrollbar.visible { </del> <ins> .monaco-workbench .notebookOverlay.notebook-editor > .cell-list-container > .monaco-list > .monaco-scrollable-element > .scrollbar.visible { </ins> z-index: var(--z-index-notebook-scrollbar); cursor: default; }
Change:
Looking at ways to make VS Code feel ever so slightly more approachable. A subtle 2px border radius on our common input components could be one way to make the UI feel more inviting and less harsh: <img width="361" alt="CleanShot 2022-04-08 at 14 48 52 src="https://user-"<img width="522" alt="CleanShot 2022-04-08 at 14 55 52 src="https://user-"<img width="494" alt="CleanShot 2022-04-08 at 14 58 01 src="https://user-"<img width="437" alt="CleanShot 2022-04-08 at 14 49 46 src="https://user-"<img width="500" alt="CleanShot 2022-04-08 at 15 01 55 src="https://user-"! FWIW, we already use a border radius on our icon buttons: <img width="300" alt="CleanShot 2022-04-08 at 15 03 36 src="https://user-"cc
I like this idea for buttons. I am not so sure about input/combo boxes.
I'm a +1 on this one, I think the inputs might need a bit of spacing from the side to feel more natural. We should also make sure that our labels are distinguishable as they start looking similar. Maybe we update the labels to be more pill-like?
As in padding L/R? I think they are indeed a bit different from our dropdowns if memory serves. Good call on the labels/tags.
Border-radius on buttons was merged but inputs is still under discussion so I'll keep this one open.
Good job

Discussion:
display: block; padding: 0; box-sizing:	border-box; <ins> border-radius: 2px; </ins> /* Customizable */ font-size: inherit;

.monaco-inputbox > .ibwrapper > .mirror { /* Customizable */ <del> padding: 4px; </del> <ins> padding: 4px 6px; </ins> } .monaco-inputbox > .ibwrapper {

.monaco-select-box { width: 100%; cursor: pointer; <ins> border-radius: 2px; </ins> } .monaco-select-box-dropdown-container {

.monaco-editor .rename-box .rename-input { padding: 3px; width: calc(100% - 6px); <ins> border-radius: 2px; </ins> } .monaco-editor .rename-box .rename-label {

*--------------------------------------------------------------------------------------------*/ .suggest-input-container { <del> padding: 2px 4px; </del> <ins> padding: 2px 6px; border-radius: 2px; </ins> } .suggest-input-container .monaco-editor-background,

width: initial; font: inherit; height: 26px; <del> padding: 2px 8px; </del> <ins> padding: 2px 6px; </ins> } .settings-editor > .settings-body .settings-tree-container .setting-item-new-extensions {

.scm-view .scm-input { height: 100%; padding-left: 11px; <ins> border-radius: 2px; } .scm-view .scm-input .margin { width: 6px !important; } .scm-input .monaco-scrollable-element { left: 6px !important; } .scm-view .scm-editor-container .monaco-editor { border-radius: 2px !important; </ins> } .scm-view .scm-editor {

box-sizing: border-box; padding: 1px; outline-offset: -1px; <ins> border-radius: 2px; </ins> } .scm-editor-validation-container {

position: absolute; pointer-events: none; z-index: 1; <del> padding: 2px 4px 3px 4px; </del> <ins> padding: 2px 6px 3px 6px; </ins> box-sizing: border-box; width: 100%; overflow: hidden;
Change:
https://user- As shown in the recording, when I tried to paste in the editor The terminal paste command is matched, meaning that the terminal is still "focused" based on the context keys The terminal shows a context menu for paste. We are not seeing this in the editor, the terminal should handle in the same way
As long as the terminal is opened once, I have to reload the window to get it fixed.
I think this means that this isn't happening on safari for some reason
This gets hit even when I click in the editor area !
Still reproduced on latest codespace with VS Code insider bits.
Had a call, we believe it's happening because we set when hiding the panel which caused the blur/focusout events to not fire. We also noticed this happens in terminal editors as well. So to fix we need to reset or refresh the state of the context key when the terminal panel/view is hidden as well as when the terminal editor is hidden. Something to verify when these changes are made is to make sure if you have a single terminal editor and a single terminal in the panel, toggling the panel should still keep because the terminal editor will now be focused (ie. the panel hide context key reset should happen before the terminal editor focus is handled).

Discussion:
setTimeout(() => this._refreshSelectionContextKey(), 0); })); <del> this._register(dom.addDisposableListener(xterm.raw.textarea, 'focus', () => { this._terminalFocusContextKey.set(true); this._onDidFocus.fire(this); })); this._register(dom.addDisposableListener(xterm.raw.textarea, 'blur', () => { this._terminalFocusContextKey.reset(); this._onDidBlur.fire(this); this._refreshSelectionContextKey(); })); </del> <ins> this._register(dom.addDisposableListener(xterm.raw.textarea, 'focus', () => this._setFocus(true))); this._register(dom.addDisposableListener(xterm.raw.textarea, 'blur', () => this._setFocus(false))); this._register(dom.addDisposableListener(xterm.raw.textarea, 'focusout', () => this._setFocus(false))); </ins> this._initDragAndDrop(container);

} } <ins> private _setFocus(focused?: boolean): void { if (focused) { this._terminalFocusContextKey.set(true); this._onDidFocus.fire(this); } else { this._terminalFocusContextKey.reset(); this._onDidBlur.fire(this); this._refreshSelectionContextKey(); } } </ins> private _initDragAndDrop(container: HTMLElement) { this._dndObserver?.dispose(); const dndController = this._instantiationService.createInstance(TerminalInstanceDragAndDropController, container);
Change:
https://user- As shown in the recording, when I tried to paste in the editor The terminal paste command is matched, meaning that the terminal is still "focused" based on the context keys The terminal shows a context menu for paste. We are not seeing this in the editor, the terminal should handle in the same way
As long as the terminal is opened once, I have to reload the window to get it fixed.
I think this means that this isn't happening on safari for some reason
This gets hit even when I click in the editor area !
Still reproduced on latest codespace with VS Code insider bits.
Had a call, we believe it's happening because we set when hiding the panel which caused the blur/focusout events to not fire. We also noticed this happens in terminal editors as well. So to fix we need to reset or refresh the state of the context key when the terminal panel/view is hidden as well as when the terminal editor is hidden. Something to verify when these changes are made is to make sure if you have a single terminal editor and a single terminal in the panel, toggling the panel should still keep because the terminal editor will now be focused (ie. the panel hide context key reset should happen before the terminal editor focus is handled).

Discussion:
clearSelection(): void; /** <ins> * When the panel is hidden or a terminal in the editor area becomes inactive, reset the focus context key * to avoid issues like #147180. */ resetFocusContextKey(): void; /** </ins> * Select all text in the terminal. */ selectAll(): void;

} } })); <ins> this._register(this._editorService.onDidActiveEditorChange(() => { const instance = this._editorService.activeEditor instanceof TerminalEditorInput ? this._editorService.activeEditor : undefined; if (!instance) { for (const instance of this.instances) { instance.resetFocusContextKey(); } } })); </ins> } private _getActiveTerminalEditors(): EditorInput[] {

} } <ins> resetFocusContextKey(): void { this._terminalFocusContextKey.reset(); } </ins> private _initDragAndDrop(container: HTMLElement) { this._dndObserver?.dispose(); const dndController = this._instantiationService.createInstance(TerminalInstanceDragAndDropController, container);

this._terminalGroupService.activeGroup?.setVisible(visible); } } else { <ins> for (const instance of this._terminalGroupService.instances) { instance.resetFocusContextKey(); } </ins> this._terminalGroupService.activeGroup?.setVisible(false); } }));
Change:
Open Set some breakpoints They show in the wrong place and cover a character, but seemingly get fixed when setting a breakpoint on the next line !
It is non-deterministic: ! Maybe that depends on the timing of the debugger. If I add to this statement (effectively removing the condition), I cannot reproduce anymore: Unfortunately that might cause performance problems. I think this is because needs to be called when injected text is inserted before it.
I am currently still reproing it here: <img width="445" alt="image" src="https://user-" btw make sure you add labels and a milestone to issues for verification and tracking
Any chance this could be looked at soon? It comes up pretty often <img width="1018" alt="image" src="https://user-"
Thanks

Discussion:
return true; } public override onLineMappingChanged(e: viewEvents.ViewLineMappingChangedEvent): boolean { <del> const keys = Object.keys(this._widgets); for (const widgetId of keys) { this._widgets[widgetId].onLineMappingChanged(e); } </del> <ins> this._updateAnchorsViewPositions(); </ins> return true; } public override onLinesChanged(e: viewEvents.ViewLinesChangedEvent): boolean { <ins> this._updateAnchorsViewPositions(); </ins> return true; } public override onLinesDeleted(e: viewEvents.ViewLinesDeletedEvent): boolean { <ins> this._updateAnchorsViewPositions(); </ins> return true; } public override onLinesInserted(e: viewEvents.ViewLinesInsertedEvent): boolean { <ins> this._updateAnchorsViewPositions(); </ins> return true; } public override onScrollChanged(e: viewEvents.ViewScrollChangedEvent): boolean {

// ---- end view event handlers <ins> private _updateAnchorsViewPositions(): void { const keys = Object.keys(this._widgets); for (const widgetId of keys) { this._widgets[widgetId].updateAnchorViewPosition(); } } </ins> public addWidget(_widget: IContentWidget): void { const myWidget = new Widget(this._context, this._viewDomNode, _widget); this._widgets[myWidget.id] = myWidget;

} } <del> public onLineMappingChanged(e: viewEvents.ViewLineMappingChangedEvent): void { </del> <ins> public updateAnchorViewPosition(): void { </ins> this._setPosition(this._affinity, this._primaryAnchor.modelPosition, this._secondaryAnchor.modelPosition); }
Change:
This message right here: <img width="474" alt="image" src="https://user-"When i click on "Don't show again", it doesn't really work: as soon as i navigate to that input field again, it shows the same message again. Version: 1.66.2 Commit: User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.88 Safari/537.36 Embedder:
says this regressed with

Discussion:
.replace(/>/g, '&gt;') .replace(/"/g, '&quot;') .replace(/'/g, '&#39;'); <del> return `<a data-href="${href}" title="${title || href}">${text}</a>`; </del> <ins> return `<a href="" data-href="${href}" title="${title || href}">${text}</a>`; </ins> } }; renderer.paragraph = (text): string => {

mds.appendMarkdown(`[$(zap)-link](#link)`); let result: HTMLElement = renderMarkdown(mds).element; <del> assert.strictEqual(result.innerHTML, `<p><a data-href="#link" title="#link"><span class="codicon codicon-zap"></span>-link</a></p>`); </del> <ins> assert.strictEqual(result.innerHTML, `<p><a href="" data-href="#link" title="#link"><span class="codicon codicon-zap"></span>-link</a></p>`); </ins> }); test('render icon in table', () => {

</thead> <tbody><tr> <td><span class="codicon codicon-zap"></span></td> <del> <td><a data-href="#link" title="#link"><span class="codicon codicon-zap"></span>-link</a></td> </del> <ins> <td><a href="" data-href="#link" title="#link"><span class="codicon codicon-zap"></span>-link</a></td> </ins> </tr> </tbody></table> `);
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66.2 OS Version: windows 10 The text input field is simply blocked. It is impossible to use both search and text replacement. Steps to Reproduce: combination like "Ctrl + H" or "Ctrl + F" !

Discussion:
.monaco-workbench .notebookOverlay.notebook-editor .simple-fr-find-part-wrapper .matchesCount { text-align: center; <ins> text-overflow: ellipsis; overflow: hidden; white-space: nowrap; padding: 0 2px; box-sizing: border-box; </ins> }

return; } <del> this._matchesCount.style.minWidth = MAX_MATCHES_COUNT_WIDTH + 'px'; </del> <ins> this._matchesCount.style.width = MAX_MATCHES_COUNT_WIDTH + 'px'; </ins> this._matchesCount.title = ''; // remove previous content
Change:
Again: I think these tests need to stop using an arbritrary timeout of 200 ms and find a different way of figuring out.

Discussion:
import * as assert from 'assert'; import { IListRenderer, IListVirtualDelegate } from 'vs/base/browser/ui/list/list'; import { IListOptions, List } from 'vs/base/browser/ui/list/listWidget'; <ins> import { raceTimeout } from 'vs/base/common/async'; </ins> import { QuickInputController } from 'vs/base/parts/quickinput/browser/quickInput'; import { IQuickPick, IQuickPickItem } from 'vs/base/parts/quickinput/common/quickInput'; <del> import { flakySuite } from 'vs/base/test/common/testUtils'; // Simple promisify of setTimeout function wait(delayMS: number) { return new Promise(function (resolve) { setTimeout(resolve, delayMS); }); </del> <ins> // Sets up an `onShow` listener to allow us to wait until the quick pick is shown (useful when triggering an `accept()` right after launching a quick pick) // kick this off before you launch the picker and then await the promise returned after you launch the picker. async function setupWaitTilShownListener(controller: QuickInputController): Promise<void> { const result = await raceTimeout(new Promise<boolean>(resolve => { const event = controller.onShow(_ => { event.dispose(); resolve(true); }); }), 2000); if (!result) { throw new Error('Cancelled'); } </ins> } <del> flakySuite('QuickInput', () => { // https://github.com/microsoft/vscode/issues/147543 </del> <ins> suite('QuickInput', () => { // https://github.com/microsoft/vscode/issues/147543 </ins> let fixture: HTMLElement, controller: QuickInputController, quickpick: IQuickPick<IQuickPickItem>; function getScrollTop(): number {

test('pick - basecase', async () => { const item = { label: 'foo' }; <ins> const wait = setupWaitTilShownListener(controller); </ins> const pickPromise = controller.pick([item, { label: 'bar' }]); <del> // wait a bit to let the pick get set up. await wait(200); </del> <ins> await wait; </ins> controller.accept(); const pick = await pickPromise; assert.strictEqual(pick, item); }); test('pick - activeItem is honored', async () => { const item = { label: 'foo' }; <ins> const wait = setupWaitTilShownListener(controller); </ins> const pickPromise = controller.pick([{ label: 'bar' }, item], { activeItem: item }); <del> // wait a bit to let the pick get set up. await wait(200); </del> <ins> await wait; </ins> controller.accept(); const pick = await pickPromise; assert.strictEqual(pick, item); }); test('input - basecase', async () => { <ins> const wait = setupWaitTilShownListener(controller); </ins> const inputPromise = controller.input({ value: 'foo' }); <del> // wait a bit to let the pick get set up. await wait(200); </del> <ins> await wait; </ins> controller.accept(); const value = await inputPromise; assert.strictEqual(value, 'foo'); });

quickpick.value = 'changed'; try { <del> // wait a bit to let the event play out. await wait(200); </del> assert.strictEqual(value, quickpick.value); } finally { quickpick.dispose();
Change:
I clicked to "Uninstall" an extension with dependencies and got an error toast as a result: ! I think since I clicked a button explicitly, I would expect a modal dialog as a result.
Sounds low hanging? Should we close or this milestone to fix?
We closed this issue because we in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our and . Thanks for your understanding, and happy coding!

Discussion:
private static readonly UnInstallingClass = `${ExtensionAction.LABEL_ACTION_CLASS} uninstall uninstalling`; constructor( <del> @IExtensionsWorkbenchService private extensionsWorkbenchService: IExtensionsWorkbenchService </del> <ins> @IExtensionsWorkbenchService private readonly extensionsWorkbenchService: IExtensionsWorkbenchService, @IDialogService private readonly dialogService: IDialogService </ins> ) { super('extensions.uninstall', UninstallAction.UninstallLabel, UninstallAction.UninstallClass, false); this.update();

} alert(localize('uninstallExtensionStart', "Uninstalling extension {0} started.", this.extension.displayName)); <del> return this.extensionsWorkbenchService.uninstall(this.extension).then(() => { </del> <ins> try { await this.extensionsWorkbenchService.uninstall(this.extension); </ins> alert(localize('uninstallExtensionComplete', "Please reload Visual Studio Code to complete the uninstallation of the extension {0}.", this.extension!.displayName)); <del> }); </del> <ins> } catch (error) { this.dialogService.error(getErrorMessage(error)); } </ins> } }
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --I would like to run all the tests from the task. However, if there is a hidden test (e.g. by mistake), that test will not be executed. Is it possible to make work from task? Or if there is a command that ignores the hidden ones and runs all tests, that would be fine.
It looks like expects some arguments but you're looking for a command that unhides all instead.
Code pointer for the existing action:
Should there be a new command to unhide all tests say testing.hideAll or a task to run all tasks including hidden tests - testing.runAllIncludingHidden?
Yes! please.
Verified it unhides all hidden tests.

Discussion:
} } <ins> export class UnhideAllTestsAction extends Action2 { constructor() { super({ id: TestCommandId.UnhideAllTestsAction, title: localize('unhideAllTests', 'Unhide All Tests'), }); } public override run(accessor: ServicesAccessor) { const service = accessor.get(ITestService); service.excluded.clear(); return Promise.resolve(); } } </ins> const testItemInlineAndInContext = (order: ActionOrder, when?: ContextKeyExpression) => [ { id: MenuId.TestItem,

TestingViewAsTreeAction, ToggleInlineTestOutput, UnhideTestAction, <ins> UnhideAllTestsAction, </ins> ];

ToggleAutoRun = 'testing.toggleautoRun', ToggleInlineTestOutput = 'testing.toggleInlineTestOutput', UnhideTestAction = 'testing.unhideTest', <ins> UnhideAllTestsAction = 'testing.unhideAllTests', </ins> }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.66 OS Version: Windows 11 Steps to Reproduce: a notebook in on the notebook editor below the cell list ! +s :bug: prompted to save webpage !
thanks! The focus is in the webview but it seems the save action is not handled properly.

Discussion:
<meta charset="UTF-8"> <meta http-equiv="Content-Security-Policy" <del> content="default-src 'none'; script-src 'sha256-EDTzzejMryXNJsvXPm3ha4m5Mi6h2Y//JRojh+K0+bY=' 'self'; frame-src 'self'; style-src 'unsafe-inline';"> </del> <ins> content="default-src 'none'; script-src 'sha256-j+I5FRqQBE2aQY6H/U/pjZI3buJy36yZ/upZTKZov3c=' 'self'; frame-src 'self'; style-src 'unsafe-inline';"> </ins> <!-- Disable pinch zooming --> <meta name="viewport"

// make sure we block the browser from dispatching it. Instead VS Code // handles these events and will dispatch a copy/paste back to the webview // if needed <del> if (isUndoRedo(e) || isPrint(e) || isFindEvent(e)) { </del> <ins> if (isUndoRedo(e) || isPrint(e) || isFindEvent(e) || isSaveEvent(e)) { </ins> e.preventDefault(); } else if (isCopyPasteOrCut(e)) { if (onElectron) {

return hasMeta && e.key.toLowerCase() === 'f'; } <ins> /** * @param {KeyboardEvent} e * @return {boolean} */ function isSaveEvent(e) { const hasMeta = e.ctrlKey || e.metaKey; return hasMeta && e.key.toLowerCase() === 's'; } </ins> let isHandlingScroll = false; /**
Change:
When the comment is too long to fit in the panel (which is common), the author name and the date get truncated first. Instead, we should truncate the comment: e.g. look at the last comment in ! Showing the author name (instead of ) should be more important than showing a few more characters in the comment preview. (cc
/verified It prefers the user name over comment now.

Discussion:
.comments-panel .comments-panel-container .tree-container .comment-thread-container .comment-snippet-container .count, .comments-panel .comments-panel-container .tree-container .comment-thread-container .comment-metadata-container .user { <del> overflow: hidden; text-overflow: ellipsis; </del> <ins> min-width: fit-content; </ins> } .comments-panel .comments-panel-container .tree-container .comment-thread-container .comment-snippet-container .text {