jiebi/CodeConvo huggingface dataset:
Change:
With current implementation of search history it's a bit hard to find previous "proper" searches when is . When used with regular expressions which are not as fast to type as regular text it allows to quickly see RE errors or preliminary results but also saves each a lot of version with only 1-3 changed characters to history. Without better options to navigate field history except <kbdUp</kbd/<kbdDown</kbdit makes hard to find history entry for intentional searches (in my case it was about 20 intermediate results to spot proper search). Current solutions are: 1) Disable and then only "submitted" searches will be in history. 2) Increase to 2s and hope that I can type all capturing groups and lookaheads fast enough, but it might be faster just to hit <kbdEnter</kbdAs for me - ideal solution will be an option to treat searches triggered by as early preview of possible matches and add history entry only after user intentionally hits <kbdEnter</kbd. Is it something that can be implemented and considered by the team? /cc
I think it would make sense to add to history either on enter, or on a "large" (2 seconds maybe) debounce.
Looks like same problem appears in "files to include/exclude" fields (even more spam entries) so I created PR that will debounce saving history entries for these fields too. And the another related question: Will you consider merging PR that will add Setting to completely disable history entries on type and will require explicit <kbdEnter</kbdpress (off by default) or it's unnecessary complexity (which might be source of confusion) that wont be merged? It will basically turn "search on type" into some kind of Search preview mode - ideal for me, but would understand if it's not good for general auditory.
Thanks for the PR, I've merged it. As for the setting, if you propose a good name and description text I think it's reasonable.

Discussion:
private onInputKeyUp(keyboardEvent: IKeyboardEvent) { switch (keyboardEvent.keyCode) { case KeyCode.Enter: <ins> this.onSearchSubmit(); </ins> this.searchOnTypeDelayer.trigger(() => this._onSubmit.fire(false), 0); return; case KeyCode.Escape:

} private onQueryTriggered(query: ITextQuery, options: ITextQueryBuilderOptions, excludePatternText: string, includePatternText: string, triggeredOnType: boolean): void { <del> this.addToSearchHistoryDelayer.trigger(() => this.searchWidget.searchInput.onSearchSubmit()); this.inputPatternExcludes.onSearchSubmit(); this.inputPatternIncludes.onSearchSubmit(); </del> <ins> this.addToSearchHistoryDelayer.trigger(() => { this.searchWidget.searchInput.onSearchSubmit(); this.inputPatternExcludes.onSearchSubmit(); this.inputPatternIncludes.onSearchSubmit(); }); </ins> this.viewModel.cancelSearch();
Change:
Not the gutter. The ones that are rendered in the editor area. (And whitespace x2 + colon).
The "click to go to line" functionality reads from those line numbers, and I don't know a way to get around that (Sublime for instance does the same). Closing as this would require a major implementation change with non-major benefit.
Line number already has a grammar scope . Could you add another scope for the colon after it, so it would be possible to make them both transparent from ?
sure, that's a good idea.
So far adding a scope for the "line number + colon" construct (), and subdividing the path scope into and (and also ). !
Updated the scope names. Example: !

Discussion:
"name": "comment" }, { <del> "match": "^S.*:$", "name": "string path.searchResult" </del> <ins> "match": "^(?!s)(.*?)([^/n]*)(:)$", "name": "string path.searchResult", "captures": { "1": { "name": "dirname.path.searchResult" }, "2": { "name": "basename.path.searchResult" }, "3": { "name": "endingColon.path.searchResult" } } </ins> }, { <del> "match": "^  d+", "name": "constant.numeric lineNumber.searchResult" </del> <ins> "match": "^  (d+)(:| )", "captures": { "1": { "name": "constant.numeric lineNumber.searchResult resultPrefix.searchResult" }, "2:": { "name": "resultPrefixSeparator.searchResult resultPrefix.searchResult" } } </ins> } ] }
Change:
A regression from the work of custom editors, when typing into an editor with auto save on (after 1s delay), we typically do not show any dirty indicators. However, the open editors view still shows them: !

Discussion:
import { URI } from 'vs/base/common/uri'; import { withUndefinedAsNull } from 'vs/base/common/types'; import { isWeb } from 'vs/base/common/platform'; <del> import { IWorkingCopyService } from 'vs/workbench/services/workingCopy/common/workingCopyService'; </del> <ins> import { IWorkingCopyService, IWorkingCopy, WorkingCopyCapabilities } from 'vs/workbench/services/workingCopy/common/workingCopyService'; </ins> import { SIDE_BAR_BACKGROUND } from 'vs/workbench/common/theme'; <ins> import { AutoSaveMode, IFilesConfigurationService } from 'vs/workbench/services/filesConfiguration/common/filesConfigurationService'; </ins> const $ = dom.$;

@IThemeService private readonly themeService: IThemeService, @ITelemetryService private readonly telemetryService: ITelemetryService, @IMenuService private readonly menuService: IMenuService, <del> @IWorkingCopyService private readonly workingCopyService: IWorkingCopyService </del> <ins> @IWorkingCopyService private readonly workingCopyService: IWorkingCopyService, @IFilesConfigurationService private readonly filesConfigurationService: IFilesConfigurationService </ins> ) { super({ ...(options as IViewletPaneOptions),

this._register(this.configurationService.onDidChangeConfiguration(e => this.onConfigurationChange(e))); // Handle dirty counter <del> this._register(this.workingCopyService.onDidChangeDirty(() => this.updateDirtyIndicator())); </del> <ins> this._register(this.workingCopyService.onDidChangeDirty(c => this.updateDirtyIndicator(c))); </ins> } private registerUpdateEvents(): void {

this.maximumBodySize = this.getMaxExpandedBodySize(); } <del> private updateDirtyIndicator(): void { </del> <ins> private updateDirtyIndicator(workingCopy?: IWorkingCopy): void { if (workingCopy) { const gotDirty = workingCopy.isDirty(); if (gotDirty && !!(workingCopy.capabilities & WorkingCopyCapabilities.AutoSave) && this.filesConfigurationService.getAutoSaveMode() === AutoSaveMode.AFTER_SHORT_DELAY) { return; // do not indicate dirty of working copies that are auto saved after short delay } } </ins> let dirty = this.workingCopyService.dirtyCount; if (dirty === 0) { dom.addClass(this.dirtyCountElement, 'hidden');
Change:
there is a typo wrong spelled, which you can see here: hope this can be corrected :)

Discussion:
import { IStateService } from 'vs/platform/state/node/state'; import { ILogService } from 'vs/platform/log/common/log'; <del> type StorageDatebase = { [key: string]: any; }; </del> <ins> type StorageDatabase = { [key: string]: any; }; </ins> export class FileStorage { <del> private _database: StorageDatebase | null = null; </del> <ins> private _database: StorageDatabase | null = null; </ins> private lastFlushedSerializedDatabase: string | null = null; constructor(private dbPath: string, private onError: (error: Error) => void) { } <del> private get database(): StorageDatebase { </del> <ins> private get database(): StorageDatabase { </ins> if (!this._database) { this._database = this.loadSync(); }

this._database = database; } <del> private loadSync(): StorageDatebase { </del> <ins> private loadSync(): StorageDatabase { </ins> try { this.lastFlushedSerializedDatabase = fs.readFileSync(this.dbPath).toString();

} } <del> private async loadAsync(): Promise<StorageDatebase> { </del> <ins> private async loadAsync(): Promise<StorageDatabase> { </ins> try { this.lastFlushedSerializedDatabase = (await readFile(this.dbPath)).toString();
Change:
Issue Type: <bBug</b- VS Code version: Code 1.41.0 (, 2019-12-11T18:37:42.077Z) OS version: WindowsNT x64 10.0. . following stuff: Does this issue occur when all extensions are disabled?: Yes <details<summarySystem Info</summary </details<details<summaryExtensions (7)</summaryExtensionVersion ------ language-mcfunction0.16.0 snapshot-tools0.4.0 vscode-edit-csv0.2.5 vscode-typescript-tslint-plugin1.2.3 datapack-json2.0.1 datapack-language-server1.10.5 vscode-icons9.6.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --

Discussion:
}, description: nls.localize('scope.enumDescriptions', 'Descriptions for enum values') }, <del> markdownEnumDescription: { </del> <ins> markdownEnumDescriptions: { </ins> type: 'array', items: { type: 'string', }, <del> description: nls.localize('scope.markdownEnumDescription', 'Descriptions for enum values in the markdown format.') </del> <ins> description: nls.localize('scope.markdownEnumDescriptions', 'Descriptions for enum values in the markdown format.') </ins> }, markdownDescription: { type: 'string',
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.42.0-insider OS Version: Ubuntu 19.10 The is ! The is ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.524 --<!-- potentialduplicatescomment --

Discussion:
case PConst.Kind.memberSetAccessor: return vscode.CompletionItemKind.Field; case PConst.Kind.function: <ins> case PConst.Kind.localFunction: </ins> return vscode.CompletionItemKind.Function; case PConst.Kind.memberFunction: case PConst.Kind.constructSignature:
Change:
Originally to search in I swear there is an issue for having this in the explorer somewhere but I can't find it. Possible that it was closed as out of scope at some point, but I've always wanted this and I am trying to implement it. I will also add a setting to disable this. I don't know whether we would want it on by default or not.
We can't really do a common implementation for this because the tree doesn't give a way to examine the tree structure of the data. The Navigator is not sufficient because we don't know the depth of nodes as we visit them. We could have a common helper utility that would take some delegate to give info about the model's tree structure with an API like the old IDataSource, or the depth of nodes + navigator, but it seems like overkill given that the utility of this is limited. I think search+explorer are the only places where this is useful. If there is a third, maybe we try for a common implementation...
Adding verified label since this works great :)

Discussion:
} collapseAll(): void { <ins> const treeInput = this.tree.getInput(); if (Array.isArray(treeInput)) { if (this.hasExpandedItemInsideFolder(treeInput)) { treeInput.forEach(folder => { folder.children.forEach(child => this.tree.hasNode(child) && this.tree.collapse(child)); }); return; } } </ins> this.tree.collapseAll(); } <ins> private hasExpandedItemInsideFolder(treeInput: ExplorerItem[]): boolean { for (const folder of treeInput) { if (this.tree.hasNode(folder) && !this.tree.isCollapsed(folder)) { for (const [, child] of folder.children.entries()) { if (this.tree.hasNode(child) && !this.tree.isCollapsed(child)) { return true; } } } } return false; } </ins> previousCompressedStat(): void { const focused = this.tree.getFocus(); if (!focused.length) {
Change:
VSCode Version: 1.41.1 OS Version: irrelevant Steps to Reproduce: : type Declaration: line 2316 [location links][#LocationLink] -(#LocationLink) Does this issue occur when all extensions are disabled?: Yes
Please remove it immediately and make it your top priority. To me this is almost equally offensive as a swastika.
He think it's funny to imitate .

Discussion:
/** * The declaration of a symbol representation as one or many [locations](#Location) <del> * or [location links][#LocationLink]. </del> <ins> * or [location links](#LocationLink). </ins> */ export type Declaration = Location | Location[] | LocationLink[];
Change:
<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.41.1 OS Version: Windows 10 Steps to Reproduce: the "Explorer" view (e.g. with Ctrl+B) a file from the Windows Explorer to drop it in the Explorer icon in vscode. explorer does not automatically open, which would be somewhat helpful, in order to be able to drop the file in the folder of your choice directly. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
This is a fair feature request for the that on dragOver the corresponding view would get open. I think this feature reuqest makes sense in general, since in the future we might want to drag and drop views between containers, and then the corresponding container should expand. Thus also assigning to
this is a regression though. Testing I can move a file from the desktop over the (collapsed) activity bar and views expand properly and focus depending on which view is hovered. This was very useful to drag images to for writing release notes. Can we bring it back?
Re-labeled it then, and assigned to Janaury so we try to fix it this milestone. hope that makes sense.
Thanks a lot for the fix

Discussion:
height: 100%; } <ins> .monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .active-item-indicator { pointer-events: none; } </ins> .monaco-workbench.border .activitybar.right > .content :not(.monaco-menu) > .monaco-action-bar .active-item-indicator { left: -2px; }
Change:
<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --When developing an extension with vscode-insiders, the extension host prints many warnings like: The warnings are printed for the following extensions: The built-in extension The built-in extension (when opening a markdown file) The built-in extension (when opening a html file) The built-in extension (when opening a ts file and typing something) ! When developing an extension with vscode, no warnings are printed. ! <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.42.0-insider OS Version: Ubuntu 19.10 Steps to Reproduce: an extension warnings are printed inside <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
I believe these should be fixed now. Let me know if you notice any additional ones

Discussion:
const scope = OVERRIDE_PROPERTY_PATTERN.test(key) ? ConfigurationScope.RESOURCE : this._configurationScopes.get(key); const extensionIdText = extensionId ? `[${extensionId.value}] ` : ''; if (ConfigurationScope.RESOURCE === scope) { <del> if (overrides?.resource) { </del> <ins> if (typeof overrides?.resource === 'undefined') { </ins> this._logService.warn(`${extensionIdText}Accessing a resource scoped configuration without providing a resource is not expected. To get the effective value for '${key}', provide the URI of a resource or 'null' for any resource.`); } return;
Change:
<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --When developing an extension with vscode-insiders, the extension host prints many warnings like: The warnings are printed for the following extensions: The built-in extension The built-in extension (when opening a markdown file) The built-in extension (when opening a html file) The built-in extension (when opening a ts file and typing something) ! When developing an extension with vscode, no warnings are printed. ! <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.42.0-insider OS Version: Ubuntu 19.10 Steps to Reproduce: an extension warnings are printed inside <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
I believe these should be fixed now. Let me know if you notice any additional ones

Discussion:
if (isWorkspaceFolder(scope)) { return { resource: scope.uri }; } <ins> if (scope === null) { return { resource: null }; } </ins> return undefined; }
Change:
have a file with an error press F8 press Ctrl+M to toggle that Tab moves focus press Tab once the focus moves first to the close button, then the up button, and finally the down button. ! <details<summaryOLD DESCRIPTION from Details:​ ​​ ​​ Browser Details: ​​​ Microsoft Edge 44..1.0, Google Chrome 75.0.3770.142​ ​OS: Windows (Version 1903, Build: .113)​​ ​ Repro Steps: ​​​ 1) Hit the URL ""​​ 2) Navigate till "Playground" link and press enter​​ 3) Tab till editor field and type any wrong code. ​ 4) Press F8 or Shift+F8 to open the errors​ 5) Verify the focus order between "Go to next problem, Go to previous problem and close" buttons​ Actual Result: ​​​ Focus order is not proper between "Go to next problem, Go to previous problem and close" buttons. Focus order is given in the wrong sequence as close--Go to previous problem --Go to next problem​ ​​ Expected Result: ​​​ When user press Tab key focus order should in the sequence as ​ Go to next problem--Go to previous problem--close​ ​ User Impact: ​​​ Keyboard users will find difficult to work if focus order is not proper between the controls​ Video Attachment: </details

Discussion:
const prevMarkerKeybinding = this._keybindingService.lookupKeybinding(PrevMarkerAction.ID); const nextMarkerKeybinding = this._keybindingService.lookupKeybinding(NextMarkerAction.ID); const actions = [ <del> new Action(PrevMarkerAction.ID, PrevMarkerAction.LABEL + (prevMarkerKeybinding ? ` (${prevMarkerKeybinding.getLabel()})` : ''), 'show-previous-problem codicon-chevron-up', this._model.canNavigate(), async () => { if (this._model) { this._model.move(false, true); } }), new Action(NextMarkerAction.ID, NextMarkerAction.LABEL + (nextMarkerKeybinding ? ` (${nextMarkerKeybinding.getLabel()})` : ''), 'show-next-problem codicon-chevron-down', this._model.canNavigate(), async () => { if (this._model) { this._model.move(true, true); } }) </del> <ins> new Action(NextMarkerAction.ID, NextMarkerAction.LABEL + (nextMarkerKeybinding ? ` (${nextMarkerKeybinding.getLabel()})` : ''), 'show-next-problem codicon-chevron-down', this._model.canNavigate(), async () => { if (this._model) { this._model.move(true, true); } }), new Action(PrevMarkerAction.ID, PrevMarkerAction.LABEL + (prevMarkerKeybinding ? ` (${prevMarkerKeybinding.getLabel()})` : ''), 'show-previous-problem codicon-chevron-up', this._model.canNavigate(), async () => { if (this._model) { this._model.move(false, true); } }) </ins> ]; this._widget = new MarkerNavigationWidget(this._editor, actions, this._themeService); this._widgetVisible.set(true);

protected _fillHead(container: HTMLElement): void { super._fillHead(container); <del> this._actionbarWidget!.push(this.actions, { label: false, icon: true }); </del> <ins> this._actionbarWidget!.push(this.actions, { label: false, icon: true, index: 0 }); </ins> } protected _fillTitleIcon(container: HTMLElement): void {

protected _getActionBarOptions(): IActionBarOptions { return { <del> orientation: ActionsOrientation.HORIZONTAL_REVERSE </del> <ins> orientation: ActionsOrientation.HORIZONTAL </ins> }; }
Change:
does not appear in other doc strings. I know this is petty but it's bugging me

Discussion:
* A complex edit that will be applied in one transaction on a TextEditor. * This holds a description of the edits and if the edits are valid (i.e. no overlapping regions, document was not changed in the meantime, etc.) * they can be applied on a [document](#TextDocument) associated with a [text editor](#TextEditor). <del> * </del> */ export interface TextEditorEdit { /**
Change:
VSCode Version: 1.41.0 OS Version: Not applicable Steps to Reproduce: to row 50 that the word 'should' is unexpectedly repeated. Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.633 --<!-- potentialduplicatescomment --

Discussion:
assert.deepEqual(innerLazy.getValue(), [1, 11]); }); <del> test('map should should handle error values', () => { </del> <ins> test('map should handle error values', () => { </ins> let outer = 0; let inner = 10; const outerLazy = new Lazy(() => { throw new Error(`${++outer}`); });
Change:
VSCode Version: 1.41 OS Version: Not applicable Steps to Reproduce: to row 233 that the word 'file' is unexpectedly repeated. Does this issue occur when all extensions are disabled?: Yes
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.578 --<!-- potentialduplicatescomment --

Discussion:
pickWorkspaceAndOpen(options: IPickAndOpenOptions): Promise<void>; /** <del> * Shows a save file file dialog and save the file at the chosen file URI. </del> <ins> * Shows a save file dialog and save the file at the chosen file URI. </ins> */ pickFileToSave(options: ISaveDialogOptions): Promise<URI | undefined>;
Change:
<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.41 OS Version: Ubuntu 18.04 Steps to Reproduce: a debug adapter the pause feature the debug adapter and see that pause works the debug adapter using the restart button that pause no longer works <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No The commit is used to slow down fetching threads from a debug adapter. However, when using the default restart mechanism, is disposed (via and therefore no longer runs after restarting the debug adapter.
Thanks for filling this issue. Can you be so kind to fork Mock Debug and to create changes on top of it such that this issue is reproducable. Since I can not reproduce it using node - gif attached !
It looks like I was missing sending an so the same debug session was being reused after restart.
I also made this comment in the pull request: The says "A debug adapter is expected to send this event when it is ready to accept configuration requests (but not before the ‘initialize’ request has finished)." So either the specification needs to say "required" instead of "expected" or there is a bug in VS Code. VS Code doesn't seem to correctly handle the situation where the debug adapter never sends . Although the fix may be to create a new debug session object instead of the fix that I have proposed.
Simply removing the line that sends from the mock debug unfortunately extension doesn't seem to be enough to reproduce the problem, but since I found a workaround, I can't really justify spending more time on it.
did you verify that this works with the latest VS Code insiders as expected?

Discussion:
this.raw.dispose(); } this.raw = undefined; <ins> this.fetchThreadsScheduler = undefined; </ins> this.model.clearThreads(this.getId(), true); this._onDidChangeState.fire(); }