jiebi/CodeConvo huggingface dataset:
Change:
Steps to Reproduce: settings JSON editor click on any next to a setting context menu shown If I use right click, context menu does show. Related to
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.624 --- <!-- score: 0.498 --- <!-- score: 0.462 --- <!-- score: 0.447 --<!-- potentialduplicatescomment --
My bad. This is a duplicate of
/duplicate
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues . See also our guidelines. Happy Coding!

Discussion:
*--------------------------------------------------------------------------------------------*/ import { ContextSubMenu } from 'vs/base/browser/contextmenu'; <del> import { getDomNodePagePosition } from 'vs/base/browser/dom'; </del> <ins> import { EventHelper, getDomNodePagePosition } from 'vs/base/browser/dom'; </ins> import { IAction } from 'vs/base/common/actions'; import { Delayer } from 'vs/base/common/async'; import { Emitter, Event } from 'vs/base/common/event';

} private onEditSettingClicked(editPreferenceWidget: EditPreferenceWidget<IIndexedSetting>, e: IEditorMouseEvent): void { <ins> EventHelper.stop(e.event, true); </ins> const anchor = { x: e.event.posx, y: e.event.posy + 10 }; const actions = this.getSettings(editPreferenceWidget.getLine()).length === 1 ? this.getActions(editPreferenceWidget.preferences[0], this.getConfigurationsMap()[editPreferenceWidget.preferences[0].key]) : editPreferenceWidget.preferences.map(setting => new ContextSubMenu(setting.key, this.getActions(setting, this.getConfigurationsMap()[setting.key])));
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.35.1 (also tried current 1.36.0-insider) OS Version: Ubuntu 18.04 VSCode's view seems to show all threads that ever existed, not just the ones returned by latest request. Repro: and run mock-debug extension from this branch: the folder and start configuration. all threads in the thread list and start stepping line by line. After each step the adapter will reduce the number of active threads by one. requests for invalid thread ids will be failed. By line 5, there will be only one thread remaining, yet VSCode tries to display all 5.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.586 --- <!-- score: 0.462 --- <!-- score: 0.461 --- <!-- score: 0.461 --<!-- potentialduplicatescomment --
make sure that only the threads returned by the last thread request (plus additional threads coming reported via the "thread" event) are shown.
thanks for the nice repo steps. I have changed that we now always respect the request as the absolute truth. So if a thread is not returned as part of the response we will delete it. I have created a PR which tackles this and I will merge this PR in next week since now we are in endgame and I would like to get more insiders coverage so we catch potential extensions which might rely on the current bugy behavior.

Discussion:
} rawUpdate(data: IRawModelUpdate): void { <ins> const threadIds: number[] = []; </ins> data.threads.forEach(thread => { <ins> threadIds.push(thread.id); </ins> if (!this.threads.has(thread.id)) { // A new thread came in, initialize it. this.threads.set(thread.id, new Thread(this, thread.name, thread.id));

} } }); <ins> this.threads.forEach(t => { // Remove all old threads which are no longer part of the update #75980 if (threadIds.indexOf(t.threadId) === -1) { this.threads.delete(t.threadId); } }); </ins> const stoppedDetails = data.stoppedDetails; if (stoppedDetails) {
Change:
! <img width="714" alt="Screen Shot 2019-06-24 at 11 01 18 AM" src="https://user-"
<img width="646" alt="Screen Shot 2019-06-24 at 11 03 29 AM" src="https://user-"
Source maps appear to be messed up, it's probably talking about ?
Repro on mac: cmd+shift+up
I think the bug here is actually related to markers/command tracking selection, rather than the dom renderer.
Don't think this was a regression, just always happened when terminal rows were odd

Discussion:
private _scrollToMarker(marker: IMarker, position: ScrollPosition): void { let line = marker.line; if (position === ScrollPosition.Middle) { <del> line = Math.max(line - this._xterm.rows / 2, 0); </del> <ins> line = Math.max(line - Math.floor(this._xterm.rows / 2), 0); </ins> } this._xterm.scrollToLine(line); }
Change:
When middle clicking any of the links in the image, it opens the browser with a broken url For example for the remote development link, the url is: ! I'm Using Ubuntu 18.04
Hi I'm not sure I understand the scenario here. Why would you want to open to a section of the in-product release notes in an external browser? Left click will navigate to the section staying in-product. We had expected people to read the release notes either in-product or on the website at We didn't think people would want to use both at the same time.
Habit! problem is it took me several seconds to realize that I was not suppose to do that, so maybe middle-clicking should be disabled, or just not open in a browser, in fact, I was just expecting it to open in a new tab
Here's where we handle clicks inside of webviews:

Discussion:
return; } <ins> // Prevent middle clicks opening a broken link in the browser if (event.button == 1) { event.preventDefault(); } </ins> let baseElement = event.view.document.getElementsByTagName('base')[0]; /** @type {any} */ let node = event.target;

}); // Bubble out link clicks <del> newFrame.contentWindow.addEventListener('click', handleInnerClick); </del> <ins> newFrame.contentWindow.addEventListener('mousedown', handleInnerClick); </ins> if (host.onIframeLoaded) { host.onIframeLoaded(newFrame);
Change:
See for context
, I will take a look at this. Adding border to image as suggested in the other issue.

Discussion:
import { IStatusbarEntry, IStatusbarEntryAccessor, IStatusbarService, StatusbarAlignment } from 'vs/platform/statusbar/common/statusbar'; import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; <ins> import { ITheme, registerThemingParticipant, ICssStyleCollector } from 'vs/platform/theme/common/themeService'; import { IMAGE_PREVIEW_BORDER } from 'vs/workbench/common/theme'; </ins> export interface IResourceDescriptor { readonly resource: URI;

metadataClb(meta: string): void; } <ins> registerThemingParticipant((theme: ITheme, collector: ICssStyleCollector) => { const borderColor = theme.getColor(IMAGE_PREVIEW_BORDER); collector.addRule(`.monaco-resource-viewer.image img { border : 1px solid ${borderColor ? borderColor.toString() : ''}; }`); }); </ins> /** * Helper to actually render the given resource into the provided container. Will adjust scrollbar (if provided) automatically based on loading * progress of the binary resource.

hc: null }, nls.localize('editorDragAndDropBackground', "Background color when dragging editors around. The color should have transparency so that the editor contents can still shine through.")); <ins> // < --- Resource Viewer --- > export const IMAGE_PREVIEW_BORDER = registerColor('imagePreview.border', { dark: Color.fromHex('#808080').transparent(0.35), light: Color.fromHex('#808080').transparent(0.35), hc: contrastBorder }, nls.localize('imagePreviewBorder', "Border color for image in image preview.")); </ins> // < --- Panels --- >
Change:
Repro: recently opened down x on one of the entries The view will be scrolled to the top, making it much more difficult than it needs to be to clean out entries you no longer want in recently opened.
Could be the picker widget behaviour, not sure. Does it have API to remove items individually? //cc
Yeah I call  Leaving it up to if this is a bug or not.
verification steps: Trigger recently opened Scroll down Press x on one of the entries (not the highlighted one) The cursor should stay put.
Still seeing this
Ah... I fixed the issue on the active item persisting but not the scroll.
duping this to as we will fix this generically.

Discussion:
const index = input.items.indexOf(event.item); if (index !== -1) { const items = input.items.slice(); <del> items.splice(index, 1); </del> <ins> const removed = items.splice(index, 1); const activeItems = input.activeItems.filter((ai) => ai !== removed[0]); </ins> input.items = items; <ins> if (activeItems) { input.activeItems = activeItems; } </ins> } } })),
Change:
There are still some sporadic native crashes on our integration tests on macOS: After emmet tests:
it looks like the first build with was showing this same issue Are we sure the fix made it into that Electron build from Prague?

Discussion:
disturl "https://atom.io/download/electron" <del> target "4.2.7" </del> <ins> target "4.2.9" </ins> runtime "electron"

"git": { "name": "electron", "repositoryUrl": "https://github.com/electron/electron", <del> "commitHash": "36ea114ac0616e469e75ae94e6d53af48925e036" </del> <ins> "commitHash": "3d4d6454007f14fa9a5f0e1fa49206fb91b676cc" </ins> } }, "isOnlyProductionDependency": true, "license": "MIT", <del> "version": "4.2.7" </del> <ins> "version": "4.2.9" </ins> }, { "component": {

<del> // Type definitions for Electron 4.2.7 </del> <ins> // Type definitions for Electron 4.2.9 </ins> // Project: http://electronjs.org/ // Definitions by: The Electron Team <https://github.com/electron/electron> // Definitions: https://github.com/electron/electron-typescript-definitions

"@types/webdriverio": "4.6.1", "concurrently": "^3.5.1", "cpx": "^1.5.0", <del> "electron": "4.2.7", </del> <ins> "electron": "4.2.9", </ins> "htmlparser2": "^3.9.2", "mkdirp": "^0.5.1", "mocha": "^5.2.0",

semver "^5.4.1" sumchecker "^2.0.2" <del> electron@4.2.7: version "4.2.7" resolved "https://registry.yarnpkg.com/electron/-/electron-4.2.7.tgz#bdd2dbf489a4a4255405bd8330cc8509831d29ba" integrity sha512-Azpkw0OPzKVipSsN9/0DrBQhXOpG48Q1gTG7Akchtv37s8TijMe403TUgHxGGhw2ti117ek51kYf7NXLhjXqoA== </del> <ins> electron@4.2.9: version "4.2.9" resolved "https://registry.yarnpkg.com/electron/-/electron-4.2.9.tgz#81226aa1ba58e1b05388474faf5a815010a11ea2" integrity sha512-zC7K3GOiZKmxqllVG/qq/Gx+qQvyolKj5xKKwXMqIGekfokEW2hvoIO5Yh7KCoAh5dqBtpzOJjS4fj1se+YBcg== </ins> dependencies: "@types/node" "^10.12.18" electron-download "^4.1.0"
Change:
Provided the Python extension uses the API and it works as expected (), we should finalize it in July.
To verify just do a quick test that it seems to be working as expected on any platform, a more thorough test was done in the June milestone.

Discussion:
assert.equal(typeof env.appName, 'string'); assert.equal(typeof env.machineId, 'string'); assert.equal(typeof env.sessionId, 'string'); <ins> assert.equal(typeof env.shell, 'string'); </ins> }); test('env is readonly', function () {

assert.throws(() => (env as any).appName = '234'); assert.throws(() => (env as any).machineId = '234'); assert.throws(() => (env as any).sessionId = '234'); <ins> assert.throws(() => (env as any).shell = '234'); </ins> }); test('env.remoteName', function () {

export const remoteName: string | undefined; /** <ins> * The detected default shell for the extension host, this is overridden by the * `terminal.integrated.shell` setting for the extension host's platform. */ export const shell: string; /** </ins> * Opens an *external* item, e.g. a http(s) or mailto-link, using the * default application. *

export const logLevel: LogLevel; /** <del> * The detected default shell for the extension host, this is overridden by the * `terminal.integrated.shell` setting for the extension host's platform. */ export const shell: string; /** </del> * An [event](#Event) that fires when the log level has changed. */ export const onDidChangeLogLevel: Event<LogLevel>;

return extHostClipboard; }, get shell() { <del> checkProposedApiEnabled(extension); </del> return extHostTerminalService.getDefaultShell(configProvider); }, openExternal(uri: URI) {
Change:
Repro: vscode for "interface ITerminalChild" (or any search with a single result) F4 to some other file F4, nothing happens (presumably because the item is still selected in the search viewlet)
I think this was fixed with but we can verify it separately
Doesn't work still

Discussion:
// Reveal the newly selected element if (next) { <ins> if (next === selected) { this.tree.setFocus([]); } </ins> this.tree.setFocus([next], getSelectionKeyboardEvent(undefined, false)); this.tree.reveal(next); }

// Reveal the newly selected element if (prev) { <ins> if (prev === selected) { this.tree.setFocus([]); } </ins> this.tree.setFocus([prev], getSelectionKeyboardEvent(undefined, false)); this.tree.reveal(prev); }
Change:
is a very common extension for C++ file to be processed by cmake. also It would be nice to add it to vscode so it can highlight it in c++ out of the box. Thank you.
Pointer for starting:
, I will push this change :)

Discussion:
}, { "id": "cpp", <del> "extensions": [ ".cpp", ".cc", ".cxx", ".hpp", ".hh", ".hxx", ".h", ".ino", ".inl", ".ipp" ], </del> <ins> "extensions": [ ".cpp", ".cc", ".cxx", ".hpp", ".hh", ".hxx", ".h", ".ino", ".inl", ".ipp", ".hpp.in", ".h.in" ], </ins> "aliases": [ "C++", "Cpp", "cpp"], "configuration": "./language-configuration.json" }],
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: Version: 1.37.0-insider Commit: Date: 2019-07-08T05:33:31.335Z Electron: 4.2.5 Chrome: 69.0.3497.128 10.11.0 V8: 6.9.427.31-electron.0 OS: Darwin x64 17.7.0 OS Version: macOS High Sierra 10.13.6 (17G7024) Steps to Reproduce: the following sample code of extension. the WebView Panel. is not smooth. ! Does this issue occur when all extensions are disabled?: Yes

Discussion:
return; } <del> const iframes = getElementsByTagName('iframe'); </del> <ins> // Select both iframes and webviews; internally Electron nests an iframe // in its <webview> component, but this isn't queryable. const iframes = [ ...getElementsByTagName('iframe'), ...getElementsByTagName('webview'), ]; </ins> for (const iframe of iframes) { iframe.style.pointerEvents = 'none'; // disable mouse events on iframes as long as we drag the sash }

dispose(disposables); <del> const iframes = getElementsByTagName('iframe'); </del> for (const iframe of iframes) { iframe.style.pointerEvents = 'auto'; }
Change:
if you just want to 'Select Language Mode', languages has icons. but if you want to 'Configure File Association', languages has no icons
True, up for grab if someone wants to do it.
I'm going to work on it.

Discussion:
description = nls.localize('languageDescriptionConfigured', "({0})", this.modeService.getModeIdForLanguageName(lang.toLowerCase())); } <del> // construct a fake resource to be able to show nice icons if any let fakeResource: URI | undefined; const extensions = this.modeService.getExtensions(lang); if (extensions && extensions.length) { fakeResource = URI.file(extensions[0]); } else { const filenames = this.modeService.getFilenames(lang); if (filenames && filenames.length) { fakeResource = URI.file(filenames[0]); } } </del> return { label: lang, <del> iconClasses: getIconClasses(this.modelService, this.modeService, fakeResource), </del> <ins> iconClasses: getIconClasses(this.modelService, this.modeService, this.getResource(lang)), </ins> description }; });

return { id, label: lang, <ins> iconClasses: getIconClasses(this.modelService, this.modeService, this.getResource(lang)), </ins> description: (id === currentAssociation) ? nls.localize('currentAssociation', "Current Association") : undefined }; });

} }, 50 /* quick open is sensitive to being opened so soon after another */); } <ins> private getResource(lang: string): URI | undefined { // construct a fake resource to be able to show nice icons if any let fakeResource: URI | undefined; const extensions = this.modeService.getExtensions(lang); if (extensions && extensions.length) { fakeResource = URI.file(extensions[0]); } else { const filenames = this.modeService.getFilenames(lang); if (filenames && filenames.length) { fakeResource = URI.file(filenames[0]); } } return fakeResource; } </ins> } export interface IChangeEOLEntry extends IQuickPickItem {
Change:
VSCode Version: 1.36.0 OS Version: Windows 10 / Mac OS Steps to Reproduce: any c++ code inside of a .cpp/h/hpp etc file. "/" at the begging of of a line that has already been written "/" gets automatically afterwards, but before the code, so nothing actually gets commented out Simple example, where "|" denotes the cursor position: "/*" shouldn't auto-add the end symbol of the comment block by default, should be setting controlled, and should be able to recognize when it's been entered at the start of a line. Does this issue occur when all extensions are disabled?: Yes Originally reported here: They forwarded me to you folks, so I'm assuming this was to the "C/C++ Language Basics" built-in extension without a setting to control it. Please for the love of god fix this. It's super annoying.
Found a temporary workaround: to: (User Folder)AppDataLocalProgramsMicrosoft VS Coderesourcesappextensions "cpp" to (User Folder).vscodeextensions it something like "cpp.language-basics-custom" to avoid any later confusion. "language-" & comment out (or remove) this line: the trailing comma in the previous line (might not be necessary) VS Code. The custom version should take precedence over the built-in version. Comment blocks will no longer auto-close.
Also, of note: Neither javascript nor typescript contains that in their language- files, but uses the same style of block comments. I think it's safe to say it should just be removed from the cpp language-
It looks like C# and json use the as an auto closing pair, but java, javascript, php, and typescript use the . For C languages we whould use since it is more consistent.
Fix will be available in next insiders if you want it ASAP. It installs side by side with stable, so you can have both:
the C/C++ extension already registers a custom , including for . Please don't add autoClosingPairs for comments since there is no way to disable them in vscode. There are only settings for and . I seem to recall these all being controlled by a single setting at some point, but now there are only 2 out of 3 available.

Discussion:
{ "open": "{", "close": "}" }, { "open": "(", "close": ")" }, { "open": "'", "close": "'", "notIn": ["string", "comment"] }, <del> { "open": """, "close": """, "notIn": ["string"] } </del> <ins> { "open": """, "close": """, "notIn": ["string"] }, { "open": "/*", "close": " */", "notIn": ["string", "comment"] } </ins> ], "surroundingPairs": [ ["{", "}"],
Change:
Issue Type: <bBug</bHitting Ctrl+R refresh Issue Report window content and the filled information are lost after refreshing. VS Code version: Code 1.35.1 (, 2019-06-12T14:27:31.086Z) OS version: Linux x64 4.15.0-54-generic <details<summaryExtensions (15)</summaryExtensionVersion ------ githistory0.4.6 es7-react-js-snippets2.3.0 json-tools1.0.2 prettier-vscode1.9.0 composer-support-client0.19.12 golang-tdd0.0.9 solidity0.0.56 vscode-docker0.7.0 python2019.6. cpptools0.24.0 Go0.11.4 sqltools0.19.6 material-icon-theme3.8.0 sass-indented1.5.1 gitblame2.8.1 </details<!-- generated by issue reporter --

Discussion:
* * @param {string[]} modulePaths * @param {(result, configuration: object) => any} resultCallback <del> * @param {{ forceEnableDeveloperKeybindings?: boolean, removeDeveloperKeybindingsAfterLoad?: boolean, canModifyDOM?: (config: object) => void, beforeLoaderConfig?: (config: object, loaderConfig: object) => void, beforeRequire?: () => void }=} options </del> <ins> * @param {{ forceEnableDeveloperKeybindings?: boolean, disallowReloadKeybinding?: boolean, removeDeveloperKeybindingsAfterLoad?: boolean, canModifyDOM?: (config: object) => void, beforeLoaderConfig?: (config: object, loaderConfig: object) => void, beforeRequire?: () => void }=} options </ins> */ exports.load = function (modulePaths, resultCallback, options) {

const enableDeveloperTools = (process.env['VSCODE_DEV'] || !!configuration.extensionDevelopmentPath) && !configuration.extensionTestsPath; let developerToolsUnbind; if (enableDeveloperTools || (options && options.forceEnableDeveloperKeybindings)) { <del> developerToolsUnbind = registerDeveloperKeybindings(); </del> <ins> developerToolsUnbind = registerDeveloperKeybindings(options && options.disallowReloadKeybinding); </ins> } // Correctly inherit the parent's environment

} /** <ins> * @param {boolean} disallowReloadKeybinding </ins> * @returns {() => void} */ <del> function registerDeveloperKeybindings() { </del> <ins> function registerDeveloperKeybindings(disallowReloadKeybinding) { </ins> // @ts-ignore const ipc = require('electron').ipcRenderer;

const key = extractKey(e); if (key === TOGGLE_DEV_TOOLS_KB || key === TOGGLE_DEV_TOOLS_KB_ALT) { ipc.send('vscode:toggleDevTools'); <del> } else if (key === RELOAD_KB) { </del> <ins> } else if (key === RELOAD_KB && !disallowReloadKeybinding) { </ins> ipc.send('vscode:reloadWindow'); } };

bootstrapWindow.load(['vs/code/electron-browser/issue/issueReporterMain'], function (issueReporter, configuration) { issueReporter.startup(configuration); <del> }, { forceEnableDeveloperKeybindings: true }); </del>  No newline at end of file <ins> }, { forceEnableDeveloperKeybindings: true, disallowReloadKeybinding: true }); </ins>
Change:
Currently, can only be set when going through the more complex API. It would be great if the title could be set via when using the simpler .
proposal: for quickpick or Input: This basically meshes with UI in: and in the class itself here: cc
what extensions have to do now in order to get the base functionality + a title:
In API sync there was no pushback or additional comments. I have moved to implementation ^
I will reopen this for API finalization next week.
This was covered on so there's nothing else to do here besides wait for the next release of vscode types :)

Discussion:
* Options to configure the behavior of the quick pick UI. */ export interface QuickPickOptions { <ins> /** * An optional string that represents the tile of the quick pick. */ title?: string; </ins> /** * An optional flag to include the description when filtering the picks. */

export interface InputBoxOptions { /** <ins> * An optional string that represents the tile of the input box. */ title?: string; /** </ins> * The value to prefill in the input box. */ value?: string;

//#endregion <del> //#region allow title property to QuickPickOptions/InputBoxOptions: https://github.com/microsoft/vscode/issues/77423 interface QuickPickOptions { /** * An optional string that represents the tile of the quick pick. */ title?: string; } interface InputBoxOptions { /** * An optional string that represents the tile of the input box. */ title?: string; } //#endregion </del> //#region https://github.com/microsoft/vscode/issues/106744, Notebooks (misc) export enum NotebookCellKind {