Change:
Issue Type: <bBug</bsearch.maxResults to a value larger than some text in file which may have results more than "Open in editor" in search panel search editor shows " results - 1 file The result set only contains a subset of all matches. Be more specific in your search to narrow down the results." and only results shown in search editor VS Code version: Code 1.58.0 (, 2021-07-08T06:54:55.083Z) OS version: Windows_NT x64 10.0. Restricted Mode: Yes Remote OS version: Linux x64 4.15.0-136-generic <details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.468 --- <!-- score: 0.45 --<!-- potentialduplicatescomment --
Accidentally already created a walkthrough of how to resolve this in so I'll post it here: To reproduce, set the max results setting to some larger value, and run a search in the search editor which has more results than the value: ! ! Access search editor with: ! You can start by changing the limit passed here to read from the Then, you should add a way for the search to be re run with no limit. See what happens in the search from the sidebar, whose code is here: for how to make that change.
Hello, , I would like to work on this issue. As-is: Search Editor has maxResults fixed to To-Be: Should use a maxResult value from configureationService and with no limit if value is null Am I understading the issue correctly?
yes that is correct. Thanks!
Hey have you started working on this? If not, I'm interested on picking it up.
I've been busy so I have not done much, so you can pick it up. I realized it requires more time than I previously expected. As far as I see, making search editor to rerun the search results with polling like the search view requires some work...
It is by design that the search editor does not stream results, this causes undesirable behavior in an editor context when you may be in the process of manipulating the results. For this ticket simply respecting the setting is sufficient.
In that case, I have just done that, however, I still need to resolve what to do when the maxResult is null, because the editor will hang and crash. What would you suggest I do?
It's cool, I'll pick up another issue.

Discussion:
import { CancellationToken } from 'vs/base/common/cancellation'; import { KeyCode, KeyMod } from 'vs/base/common/keyCodes'; import { DisposableStore } from 'vs/base/common/lifecycle'; <del> import { assertIsDefined } from 'vs/base/common/types'; </del> <ins> import { assertIsDefined, withNullAsUndefined } from 'vs/base/common/types'; </ins> import { URI } from 'vs/base/common/uri'; import 'vs/css!./media/searchEditor'; import { CodeEditorWidget } from 'vs/editor/browser/widget/codeEditorWidget';

const options: ITextQueryBuilderOptions = { _reason: 'searchEditor', extraFileResources: this.instantiationService.invokeFunction(getOutOfWorkspaceEditorResources), <del> maxResults: 10000, </del> <ins> maxResults: withNullAsUndefined(this.searchConfig.maxResults), </ins> disregardIgnoreFiles: !config.useExcludeSettingsAndIgnoreFiles || undefined, disregardExcludeSettings: !config.useExcludeSettingsAndIgnoreFiles || undefined, excludePattern: config.filesToExclude,