jiebi/CodeConvo huggingface dataset:
Change:
open quick input or the find widget type and select some text observe that the selection is not rendered (this happened with this insiders update, I'm quite sure it was working in yesterday's insiders) https://user-
So it looks like the use of CSS variables in some cases is dangerous. Here explains a bit more. My fix is to revert back to how it was for

Discussion:
touch-action: none; /* Disable browser handling of all panning and zooming gestures. Removes 300ms touch delay. */ } <del> .monaco-workbench ::selection { background-color: var(--vscode-selection-background); } </del> .monaco-workbench.border:not(.fullscreen) { box-sizing: border-box; border: 1px solid var(--window-border-color);

import { isWeb, isIOS, isMacintosh, isWindows } from 'vs/base/common/platform'; import { createMetaElement } from 'vs/base/browser/dom'; import { isSafari, isStandalone } from 'vs/base/browser/browser'; <ins> import { selectionBackground } from 'vs/platform/theme/common/colorRegistry'; </ins> registerThemingParticipant((theme, collector) => {

const workbenchBackground = WORKBENCH_BACKGROUND(theme); collector.addRule(`.monaco-workbench { background-color: ${workbenchBackground}; }`); <ins> // Selection (do NOT remove - https://github.com/microsoft/vscode/issues/169662) const windowSelectionBackground = theme.getColor(selectionBackground); if (windowSelectionBackground) { collector.addRule(`.monaco-workbench ::selection { background-color: ${windowSelectionBackground}; }`); } </ins> // Update <meta name="theme-color" content=""> based on selected theme if (isWeb) { const titleBackground = theme.getColor(TITLE_BAR_ACTIVE_BACKGROUND);
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.2 OS Version: Ubuntu 22.04 LTS (with all updates applied) Steps to Reproduce: in using a Active Directory account (Ubuntu must be joined into an Active Directory Domain) Visual Studio Code Terminal tab, click on [ + ] sign to open a new terminal, choosing zsh. A empty terminal tab opens and no shell is launched When I look in Output tab, section 'Shared', the following log lines were found By looking at message, it seems vscode is looking at /etc/passwd for some reason. And it may be failing because when I log in with an Active Directory account, no /etc/passwd entry is created for my user, because sssd/realm does not write entries on that. I opened a terminal Window and grab the following output for helping debugging:
Looks like we need to try catch here:
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
Verified by code review (but would still appreciate your
I confirmed now that it´s working as expected. Nice job from team! <img width="1009" alt="image" src="https://user-"

Discussion:
newArgs[newArgs.length - 1] = format(newArgs[newArgs.length - 1], appRoot); // Move .zshrc into $ZDOTDIR as the way to activate the script <del> const zdotdir = path.join(os.tmpdir(), `${os.userInfo().username}-${productService.applicationName}-zsh`); </del> <ins> let username: string; try { username = os.userInfo().username; } catch { username = 'unknown'; } const zdotdir = path.join(os.tmpdir(), `${username}-${productService.applicationName}-zsh`); </ins> envMixin['ZDOTDIR'] = zdotdir; const userZdotdir = env?.ZDOTDIR ?? os.homedir() ?? `~`; envMixin['USER_ZDOTDIR'] = userZdotdir;
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Windows 10 -- Ref: Steps to Reproduce: theme to the line number in the Editor disappear for the active line !

Discussion:
"editorInlayHint.foreground": "#8b949e", "editorInlayHint.typeBackground": "#8b949e33", "editorInlayHint.typeForeground": "#8b949e", <del> "editorLineNumber.activeForeground": "#ffffffc5", </del> <ins> "editorLineNumber.activeForeground": "#171184", </ins> "editorLineNumber.foreground": "#6e7681", "editorOverviewRuler.border": "#0000001a", "editorSuggestWidget.background": "#f8f8f8",
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Windows 10 -- Ref: Steps to Reproduce: theme to new terminal cursor is white on a light background which is hard to see for most I'm about 99% sure this is not associated with any customized profile in use for PowerShell session. Starting with no profile shows the same thing. !

Discussion:
"tab.unfocusedActiveBorder": "#f8f8f8", "tab.unfocusedActiveBorderTop": "#00000015", "tab.unfocusedHoverBackground": "#6e76811a", <ins> "terminalCursor.foreground": "#005FB8", </ins> "terminal.foreground": "#ffffffc5", "terminal.inactiveSelectionBackground": "#E5EBF1", "terminal.tab.activeBorder": "#005fb8",
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Our users want to see which comments need to be worked on next. During a review round there might be some comments which are not actionable anymore as their threads got resolved. For better overview we think it is valuable to be able to expand only all unresolved (and therefore actionable) comments. Since we can't use anymore to do this from our extension. Reading there is no intention in bringing back this functionality. Introducing commands like (and probably also ) could be a way bring back some control over comment collapsed state to the extension without the need for extension to directly. cc
Tentatively adding for February.
The new command is "Comments: Expand Unresolved Comments".
To verify: Open a workspace with unresolved comments (a PR with comments using the GitHub Pull Requests and Issues extension works well for this). Collapse some comments in the editor. Run "Comments: Expand Unresolved Comments" and verify that all unresolved comments are expanded.
If a comment is already collapsed when I open the file, the command "Expand Unresolved Comments" doesn't work repro: an unresolved comment the current tab the tab again run the command - the comment is not expanded https://user-
good find! Will be fixed in the next insiders build.

Discussion:
} } <ins> public expandUnresolved(): void { for (const widget of this._commentWidgets) { if (widget.commentThread.state === languages.CommentThreadState.Unresolved) { widget.expand(); } } } </ins> public nextCommentThread(): void { this._findNearestCommentThread(); }

when: WorkspaceHasCommenting }); <ins> const EXPAND_UNRESOLVED_COMMENT_COMMAND = 'workbench.action.expandUnresolvedComments'; CommandsRegistry.registerCommand({ id: EXPAND_UNRESOLVED_COMMENT_COMMAND, handler: (accessor) => { return getActiveController(accessor)?.expandUnresolved(); } }); MenuRegistry.appendMenuItem(MenuId.CommandPalette, { command: { id: EXPAND_UNRESOLVED_COMMENT_COMMAND, title: nls.localize('comments.expandUnresolved', "Expand Unresolved Comments"), category: 'Comments' }, when: WorkspaceHasCommenting }); </ins> KeybindingsRegistry.registerCommandAndKeybindingRule({ id: 'workbench.action.submitComment', weight: KeybindingWeight.EditorContrib,
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Our users want to see which comments need to be worked on next. During a review round there might be some comments which are not actionable anymore as their threads got resolved. For better overview we think it is valuable to be able to expand only all unresolved (and therefore actionable) comments. Since we can't use anymore to do this from our extension. Reading there is no intention in bringing back this functionality. Introducing commands like (and probably also ) could be a way bring back some control over comment collapsed state to the extension without the need for extension to directly. cc
Tentatively adding for February.
The new command is "Comments: Expand Unresolved Comments".
To verify: Open a workspace with unresolved comments (a PR with comments using the GitHub Pull Requests and Issues extension works well for this). Collapse some comments in the editor. Run "Comments: Expand Unresolved Comments" and verify that all unresolved comments are expanded.
If a comment is already collapsed when I open the file, the command "Expand Unresolved Comments" doesn't work repro: an unresolved comment the current tab the tab again run the command - the comment is not expanded https://user-
good find! Will be fixed in the next insiders build.

Discussion:
export class CommentThreadWidget<T extends IRange | ICellRange = IRange> extends Disposable implements ICommentThreadWidget { private _header!: CommentThreadHeader<T>; <del> private _body!: CommentThreadBody<T>; </del> <ins> private _body: CommentThreadBody<T>; </ins> private _commentReply?: CommentReply<T>; private _additionalActions?: CommentThreadAdditionalActions<T>; private _commentMenus: CommentMenus;

} getDimensions() { <del> return this._body?.getDimensions(); </del> <ins> return this._body.getDimensions(); </ins> } layout(widthInPixel?: number) {

this._commentThreadWidget.submitComment(); } <del> _refresh(dimensions?: dom.Dimension) { if (this._isExpanded && dimensions) { </del> <ins> _refresh(dimensions: dom.Dimension) { if (dimensions.height === 0 && dimensions.width === 0) { this.commentThread.collapsibleState = languages.CommentThreadCollapsibleState.Collapsed; return; } if (this._isExpanded) { </ins> this._commentThreadWidget.layout(); const headHeight = Math.ceil(this.editor.getOption(EditorOption.lineHeight) * 1.2);
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.2 OS Version: MacOS Ventura 13.0 Steps to Reproduce: an extension that adds a command, calling . The call should provide a range to be replaced. e.g. a range selection and then call the snippet-inserting command that change selection is now with the parts that have previously been replaced, instead of the selection pre-insertSnippet

Discussion:
import { IClipboardService } from 'vs/platform/clipboard/common/clipboardService'; import { SnippetParser } from 'vs/editor/contrib/snippet/browser/snippetParser'; import { MainThreadDocuments } from 'vs/workbench/api/browser/mainThreadDocuments'; <ins> import { ISnippetEdit } from 'vs/editor/contrib/snippet/browser/snippetSession'; </ins> export interface IFocusTracker { onGainedFocus(): void;

return false; } <del> // cancel previous snippet mode // snippetController.leaveSnippet(); // set selection, focus editor const selections = ranges.map(r => new Selection(r.startLineNumber, r.startColumn, r.endLineNumber, r.endColumn)); this._codeEditor.setSelections(selections); </del> this._codeEditor.focus(); <del> // make modifications snippetController.insert(template, { </del> <ins> // make modifications as snippet edit const edits: ISnippetEdit[] = ranges.map(range => ({ range: Range.lift(range), template })); snippetController.apply(edits, { </ins> overwriteBefore: 0, overwriteAfter: 0, undoStopBefore: opts.undoStopBefore, undoStopAfter: opts.undoStopAfter, clipboardText
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.2 OS Version: Windows 10 Steps to Reproduce: a CSS file suggestion is shown, but is not enough. ! There should be more keywords below: - () () (safe <content-position, like ) (unsafe <content-position, like ) See: Same issue happens for and Thank you.
Tested in but not seeing the suggestions !

Discussion:
"browser": "./dist/browser/cssServerMain", "dependencies": { "@vscode/l10n": "^0.0.11", <del> "vscode-css-languageservice": "^6.2.2", </del> <ins> "vscode-css-languageservice": "^6.2.3", </ins> "vscode-languageserver": "^8.1.0-next.6", "vscode-uri": "^3.0.7" },

"main": "./out/node/htmlServerMain", "dependencies": { "@vscode/l10n": "^0.0.11", <del> "vscode-css-languageservice": "^6.2.2", </del> <ins> "vscode-css-languageservice": "^6.2.3", </ins> "vscode-html-languageservice": "^5.0.4", "vscode-languageserver": "^8.1.0-next.6", "vscode-languageserver-textdocument": "^1.0.8",

resolved "https://registry.yarnpkg.com/@vscode/l10n/-/l10n-0.0.11.tgz#325d7beb2cfb87162bc624d16c4d546de6a73b72" integrity sha512-ukOMWnCg1tCvT7WnDfsUKQOFDQGsyR5tNgRpwmqi+5/vzU3ghdDXzvIM4IOPdSb3OeSsBNvmSL8nxIVOqi2WXA== <del> vscode-css-languageservice@^6.2.2: version "6.2.2" resolved "https://registry.yarnpkg.com/vscode-css-languageservice/-/vscode-css-languageservice-6.2.2.tgz#05f97e937a896b3823c0b13212ab4b39a7b6a8a1" integrity sha512-K3Bl/cYGNlH4MgVtBIYJr9Qj0g3BVMUtioOCc5PJFSlgLPVHpWV5RY5jSDH3hYlldWjokIkXMk1ABMY4bimG7g== </del> <ins> vscode-css-languageservice@^6.2.3: version "6.2.3" resolved "https://registry.yarnpkg.com/vscode-css-languageservice/-/vscode-css-languageservice-6.2.3.tgz#6c1e6104e77f1fb729eeea5cd2f81f3b800d87ff" integrity sha512-EAyhyIVHpEaf+GjtI+tVe7SekdoANfG0aubnspsQwak3Qkimn/97FpAufNyXk636ngW05pjNKAR9zyTCzo6avQ== </ins> dependencies: "@vscode/l10n" "^0.0.11" vscode-languageserver-textdocument "^1.0.8"
Change:
Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.
Verification steps: Open a folder/workspace that contains a git repository Use the "Git: Checkout to..." command to "Checkout detached...", and select a branch/tag Switch to the "Source Control" view and confirm that the "Commit" action button is shown instead of "Publish Branch"

Discussion:
const config = workspace.getConfiguration('git', Uri.file(this.repository.root)); const showActionButton = config.get<{ publish: boolean }>('showActionButton', { publish: true }); <del> // Branch does have an upstream, commit/merge/rebase is in progress, or the button is disabled if (this.state.HEAD?.upstream || this.state.isCommitInProgress || this.state.isMergeInProgress || this.state.isRebaseInProgress || !showActionButton.publish) { return undefined; } </del> <ins> // Not a branch (tag, detached), branch does have an upstream, commit/merge/rebase is in progress, or the button is disabled if (!this.state.HEAD?.name || this.state.HEAD?.upstream || this.state.isCommitInProgress || this.state.isMergeInProgress || this.state.isRebaseInProgress || !showActionButton.publish) { return undefined; } </ins> // Button icon const icon = this.state.isSyncInProgress ? '$(sync~spin)' : '$(cloud-upload)';
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes (though an extension that introduces inlay hints is required) <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.2 OS Version: Windows_NT x64 10.0. Steps to Reproduce: a new rust project with . a font for VSCode that has a ligature for , install and set the config. the cargo project in VSCode and paste the following snippet into the file: Watch how there is an inlay hint inserted in front of both which merges with the leading . Actual result: ! Note that in my theme, inlay hints are dimmed ! but due to the ligature forming, the inlay hint looks like its part of the default code. Expected result ( apparently this can depend on the theme): ! (Different themes are due to running the rust-analyzer fix in the debugger without a custom theme) This also occurs for when two different inlay hints follow each other, as seen in
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.74.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
Confirmed to also occur on 1.74.2
can a decoration force ligature boundaries?
Turns out even inserting a zero-width non joiner doesn't prevent ligatures from forming (for some reason using a builtin theme prevents the ligature from forming, unsure why)
Btw the assigned label is incorrect, this is not a problem with but with
! An obvious example. expected: !
I think this should be on the May milestone?
could you verify this one as you have a rust setup?
Can confirm it is fixed with the latest release! Thanks
Thanks

Discussion:
fontWeight?: string; fontSize?: string; fontFamily?: string; <ins> unicodeBidi?: string; </ins> textDecoration?: string; color?: string | ThemeColor; backgroundColor?: string | ThemeColor;

fontSize: `${fontSize}px`, fontFamily: `var(${fontFamilyVar}), ${EDITOR_FONT_DEFAULTS.fontFamily}`, verticalAlign: isUniform ? 'baseline' : 'middle', <ins> unicodeBidi: 'isolate' </ins> }; if (isNonEmptyArray(item.hint.textEdits)) {
Change:
/ This is likely caused by testing/startup page code triggering this command on machines that have disabled the built-in markdown extension

Discussion:
import { TelemetryLevel } from 'vs/platform/telemetry/common/telemetry'; import { IProductService } from 'vs/platform/product/common/productService'; import { ILogService } from 'vs/platform/log/common/log'; <ins> import { INotificationService } from 'vs/platform/notification/common/notification'; import { localize } from 'vs/nls'; </ins> export const restoreWalkthroughsConfigurationKey = 'workbench.welcomePage.restorableWalkthroughs'; export type RestoreWalkthroughsConfigurationValue = { folder: string; category?: string; step?: string };

@ICommandService private readonly commandService: ICommandService, @IWorkbenchEnvironmentService private readonly environmentService: IWorkbenchEnvironmentService, @IStorageService private readonly storageService: IStorageService, <del> @ILogService private readonly logService: ILogService </del> <ins> @ILogService private readonly logService: ILogService, @INotificationService private readonly notificationService: INotificationService </ins> ) { this.run().then(undefined, onUnexpectedError); }

if (readmes.length) { const isMarkDown = (readme: URI) => readme.path.toLowerCase().endsWith('.md'); await Promise.all([ <del> this.commandService.executeCommand('markdown.showPreview', null, readmes.filter(isMarkDown), { locked: true }), </del> <ins> this.commandService.executeCommand('markdown.showPreview', null, readmes.filter(isMarkDown), { locked: true }).catch(error => { this.notificationService.error(localize('startupPage.markdownPreviewError', 'Could not open markdown preview: {0}.nnPlease make sure the markdown extension is enabled.', error.message)); }), </ins> this.editorService.openEditors(readmes.filter(readme => !isMarkDown(readme)).map(readme => ({ resource: readme }))), ]); }