jiebi/CodeConvo huggingface dataset:
Change:
Magnification users often zoom out to decide what they will zoom in to read. For HC themes, we should make sure there's a difference in color between requests and responses.
good idea!
There's a slight difference on high contrast dark, but there appears to be no difference with high contrast light: ! !
This is by design as the light theme is completely flat and doesn't use a secondary background colour anywhere . The main differentiator in the HC themes is the bars on the side.

Discussion:
"--vscode-chat-avatarBackground", "--vscode-chat-avatarForeground", "--vscode-chat-requestBorder", <ins> "--vscode-chat-requestBackground", </ins> "--vscode-chat-slashCommandBackground", "--vscode-chat-slashCommandForeground", "--vscode-chat-list-background",

.interactive-request { border-bottom: 1px solid var(--vscode-chat-requestBorder); border-top: 1px solid var(--vscode-chat-requestBorder); <ins> background-color: var(--vscode-chat-requestBackground); } .hc-black .interactive-request, .hc-light .interactive-request { border-left: 3px solid var(--vscode-chat-requestBorder); border-right: 3px solid var(--vscode-chat-requestBorder); </ins> } .interactive-item-container .value {

import { Color, RGBA } from 'vs/base/common/color'; import { localize } from 'vs/nls'; <del> import { badgeBackground, badgeForeground, contrastBorder, foreground, registerColor } from 'vs/platform/theme/common/colorRegistry'; </del> <ins> import { badgeBackground, badgeForeground, contrastBorder, editorBackground, editorWidgetBackground, foreground, registerColor } from 'vs/platform/theme/common/colorRegistry'; </ins> export const chatRequestBorder = registerColor( 'chat.requestBorder',

localize('chat.requestBorder', 'The border color of a chat request.') ); <ins> export const chatRequestBackground = registerColor( 'chat.requestBackground', { dark: editorBackground, light: editorBackground, hcDark: editorWidgetBackground, hcLight: null }, localize('chat.requestBackground', 'The background color of a chat request.') ); </ins> export const chatSlashCommandBackground = registerColor( 'chat.slashCommandBackground', { dark: '#34414B', light: '#D2ECFF', hcDark: Color.white, hcLight: badgeBackground },
Change:
add a keybinding for (see below) open a file open debug viewlet trigger the command :bug: nothing happens Try the same with 1.82 and see it working just fine
This doesn't reproduce all the time but when it does it doesn't seem to be a context key issue but the command failing. See how the right command is invoked but how nothing happens
I'm having a hard time reproducing this one. How often do you hit it? It appears your views are in standard locations. Do you have autoReveal on?
No, autoReveal is off. This reproduces rarely but during normal work.
I was able to debug this and it seems that  return . This is because the view container seems undefined (2nd capture) <img width="1510" alt="Screenshot 2023-12-18 at 09 37 25" src=""<img width="1496" alt="Screenshot 2023-12-18 at 09 40 29" src=""
I am also experiencing this bug. It occurs after I do bunch of shortcut that opens sidebar with other views (e.g. search, reference). Once I open file explorer only then it will work again.
Any ideas? Seems like the container itself is defined but the pane container is not. This doesn't really seem like an explorer issue as I'm using the view service for finding which view to reveal. The view service is chosen as the user could place the file view in any container
This is because the explore view pane container is not yet created. Hence it is returned . You should be opening the view instead of getting the view.
Well I get the view because I need to apply some properties to it such as before opening it. Is this not possible and I must just directly call open?
You cannot get the view because it is not yet created.
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

Discussion:
const uri = getResourceForCommand(resource, accessor.get(IListService), accessor.get(IEditorService)); if (uri && contextService.isInsideWorkspace(uri)) { <del> const explorerView = viewService.getViewWithId<ExplorerView>(VIEW_ID); </del> <ins> const explorerView = await viewService.openView<ExplorerView>(VIEW_ID, false); </ins> if (explorerView) { const oldAutoReveal = explorerView.autoReveal; // Disable autoreveal before revealing the explorer to prevent a race betwene auto reveal + selection // Fixes #197268 explorerView.autoReveal = false; <del> await viewService.openView<ExplorerView>(VIEW_ID, false); </del> explorerView.setExpanded(true); await explorerService.select(uri, 'force'); explorerView.focus();
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.84.2 (user setup) OS Version: WindowsNT x64 10.0. Copied from VSCode: Version: 1.84.2 (user setup) Commit: Date: 2023-11-09T10:51:52.184Z Electron: 25.9.2 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: WindowsNT x64 10.0. Steps to Reproduce: at least one space in the FILE path, in my case, in the username I created... Click doesn't function due to the space. If I remove the space in terminal.integrated.wordSeparators, the beginning of the line, the "FILE " gets copied as well, ruining the entire Ctrl + Click functionality. I've been searching online to change the Windows username, but all the required steps are extremely frustrating (me hincha mucho las pelotas). In the end, the only solution seems to be creating a new user or formatting, which is even more frustrating because I need to work! I can't believe this, all because they didn't implement a Regex in terminal.integrated.wordSeparators instead of "1 character in that configuration string = 1 space". Goodness!
This is a pretty clear violation of the , consider this a warning.
I think you're saying removing space from word separators would fix this but that would not work because then would be part of the .
To verify make sure links in the format above () work correctly

Discussion:
const fallbackMatchers: RegExp[] = [ // Python style error: File "<path>", line <line> /^ *File (?<link>"(?<path>.+)"(, line (?<line>d+))?)/, <ins> // Unknown tool #200166: FILE  <path>:<line>:<col> /^ +FILE +(?<link>(?<path>.+)(?::(?<line>d+)(?::(?<col>d+))?)?)/, </ins> // Some C++ compile error formats: // C:foobar baz(339) : error ... // C:foobar baz(339,12) : error ...

// Python style error: File "<path>", line <line> { urlFormat: 'File "{0}"', linkCellStartOffset: 5 }, { urlFormat: 'File "{0}", line {1}', line: '5', linkCellStartOffset: 5 }, <ins> // Unknown tool #200166: FILE  <path>:<line>:<col> { urlFormat: ' FILE  {0}', linkCellStartOffset: 7 }, { urlFormat: ' FILE  {0}:{1}', line: '5', linkCellStartOffset: 7 }, { urlFormat: ' FILE  {0}:{1}:{2}', line: '5', column: '3', linkCellStartOffset: 7 }, </ins> // Some C++ compile error formats { urlFormat: '{0}({1}) :', line: '5', linkCellEndOffset: -2 }, { urlFormat: '{0}({1},{2}) :', line: '5', column: '3', linkCellEndOffset: -2 },
Change:
open notebook make inline chat changes select "Discard" the editor will freeze, stuck in an endless loop in
This doesn't reproduce but I had this with insiders and I could see that would return and wouldn't do anything, e.g it would not change the alternative version id. This is notebook specific and the debugger did show me that parts of undo seems to be async. I wonder if this should be exposed in the undo-method that I am calling and that's the cause for this
I did a quick look at the source code in and that looks OK to me. returns . I notice the loop doesn't await the result in case a promise is returned. Could that be the right fix here?
I missed it returning a promise. Might be the right fix here but I also wasn't able reproduce and only debugged this from insiders once.

Discussion:
} private static _undoModelUntil(model: ITextModel, targetAltVersion: number): void { <del> while (targetAltVersion < model.getAlternativeVersionId() && model.canUndo()) { </del> <ins> let actualAltVersion = model.getAlternativeVersionId(); while (targetAltVersion < actualAltVersion && model.canUndo()) { </ins> model.undo(); <ins> const newActualAltVersion = model.getAlternativeVersionId(); if (actualAltVersion === newActualAltVersion) { break; } actualAltVersion = newActualAltVersion; </ins> } }
Change:
This is subjective (and others might not feel this way) but the grey sparkle looks a bit off-putting to me, especially in dark mode. I guess there was feedback that non-filled grey sparkle was not too visible, but the current solution seems less pleasant. <img width="643" alt="image" src=""<img width="455" alt="image" src=""
I agree. What about using the same yellow as the lightbulb? In the end it is just a different lightbulb. And we don't need to make up a new color. !
I will change the color of the sparkle to make it yellow
Is that ok for you?
I thought changed this before from yellow to grey based of previous feedback. :) Maybe we should just increase the contrast?
I think the yellow looks good and has some advantages: we don't need to come up with a new color. It's difficult to pick a color that works for existing themes the sparkle is just a variant of the lightbulb and the hope is using the same color will convey that
Hi afaik the sparkle was always white or slightly grey, so now we are thinking of changing it to yellow

Discussion:
*/ export const editorLightBulbForeground = registerColor('editorLightBulb.foreground', { dark: '#FFCC00', light: '#DDB100', hcDark: '#FFCC00', hcLight: '#007ACC' }, nls.localize('editorLightBulbForeground', "The color used for the lightbulb actions icon.")); export const editorLightBulbAutoFixForeground = registerColor('editorLightBulbAutoFix.foreground', { dark: '#75BEFF', light: '#007ACC', hcDark: '#75BEFF', hcLight: '#007ACC' }, nls.localize('editorLightBulbAutoFixForeground', "The color used for the lightbulb auto fix actions icon.")); <del> export const editorLightBulbAiForeground = registerColor('editorLightBulbAi.foreground', { dark: darken(iconForeground, 0.4), light: lighten(iconForeground, 1), hcDark: iconForeground, hcLight: iconForeground }, nls.localize('editorLightBulbAiForeground', "The color used for the lightbulb AI icon.")); </del> <ins> export const editorLightBulbAiForeground = registerColor('editorLightBulbAi.foreground', { dark: editorLightBulbForeground, light: editorLightBulbForeground, hcDark: editorLightBulbForeground, hcLight: editorLightBulbForeground }, nls.localize('editorLightBulbAiForeground', "The color used for the lightbulb AI icon.")); </ins> /** * Diff Editor Colors
Change:
! command palette: ! keybinding editor: !
I'm on Mac, so there are no in the examples below: <img width="493" alt="Screenshot 2023-12-07 at 2 29 34 PM" src=""<img width="355" alt="Screenshot 2023-12-07 at 2 29 18 PM" src=""Thoughts on if we need to have a version of keybindings, leave as is, or just not show if disabled? I don't think there is an example of menu options that are disabled that have this kind of keybinding.
I guess if the user explicitly shows the disabled ones then it's still good to show the keybinding for future reference. In your screenshot they're fairly short, ideally we'd keep the same dimensions as in the command palette if possible.

Discussion:
text-overflow: ellipsis; } <ins> .action-widget .monaco-list-row.action .monaco-keybinding > .monaco-keybinding-key { background-color: var(--vscode-keybindingLabel-background); color: var(--vscode-keybindingLabel-foreground); border-style: solid; border-width: 1px; border-radius: 3px; border-color: var(--vscode-keybindingLabel-border); border-bottom-color: var(--vscode-keybindingLabel-bottomBorder); box-shadow: inset 0 -1px 0 var(--vscode-widget-shadow); } </ins> /* Action bar */ .action-widget .action-widget-action-bar {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.0 OS Version: Windows 11, 23H2 build .2792 Steps to Reproduce: a shell task in user level Minimal example with PowerShell: the task in a non-workspace folder and it's fine (no path is printed in this case). Execute it in a saved workspace and the shell will print a mangled path: I believe this path was printing correctly before the 1.85.0 update. !
do you set a for the task? if so, what is it? here's where we do this
I did not have a cwd set, so I tried , which had the same result. So I tried absolute paths and it seems to be a problem with the seperators in a Windows path, which I am guessing is also using on Windows. = = =

Discussion:
shellLaunchConfig.args = windowsShellArgs ? combinedShellArgs.join(' ') : combinedShellArgs; if (task.command.presentation && task.command.presentation.echo) { if (needsFolderQualification && workspaceFolder) { <del> const folder = cwd ? path.posix.basename(cwd.toString()) : workspaceFolder.name; </del> <ins> const folder = cwd && typeof cwd === 'object' && 'path' in cwd ? path.basename(cwd.path) : workspaceFolder.name; </ins> shellLaunchConfig.initialText = this.taskShellIntegrationStartSequence(cwd) + formatMessageForTerminal(nls.localize({ key: 'task.executingInFolder', comment: ['The workspace folder the task is running in', 'The task command line or label']
Change:
<!-- Please search existing issues to avoid creating duplicates. --If outputs are cleared from a jupyter notebook, attempting to view a diff in source control view displays the error in the subject. Search for related issues brings up a different issue related to filesystem sync. VS Code version: 1.80.1 Jupyter Extension version (available under the Extensions sidebar): v2023.6. Python Extension version (available under the Extensions sidebar): v2023.12.0 OS (Windows Linux distro) and version: Windows 11 Python and/or Anaconda version: 3.9.16 Type of virtual environment used (N/A ...): conda Jupyter server running: Local Display the diff, don't display an error, even if outputs are undefined in a version of the diff. Error is displayed and the diff can't be viewed. Open a notebook in jupyter server (not VS Code) Click Cell -All Output -Clear Save the notebook Go to VS Code -Source Control View -click on the notebook. <details<summaryOutput for <codeJupyter</codein the <codeOutput</codepanel (<codeView</code→<codeOutput</code, change the drop-down the upper-right of the <codeOutput</codepanel to <codeJupyter</code) </summary<p</p</details
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.85.0. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
the editor opens successfully, though it does not show the change unless you click the switch output rendering button !
Tracked here

Discussion:
this.notebookEditor.textModel!.transientOptions.transientOutputs ? [] : this.cell.type === 'insert' <del> ? this.cell.modified!.outputs || [] : this.cell.original!.outputs || []); </del> <ins> ? this.cell.modified?.outputs || [] : this.cell.original?.outputs || []); </ins> const outputModel = this.modelService.createModel(originaloutputSource, mode, undefined, true); this._outputEditorDisposeStore.add(outputModel); this._outputEditor.setModel(outputModel);

const span = DOM.append(this._outputEmptyElement, DOM.$('span')); span.innerText = 'No outputs to render'; <del> if (this.cell.original!.outputs.length === 0) { </del> <ins> if (!this.cell.original?.outputs.length) { </ins> this._outputEmptyElement.style.display = 'block'; } else { this._outputEmptyElement.style.display = 'none';

this._outputEmptyElement = DOM.append(this._outputViewContainer, DOM.$('.output-empty-view')); this._outputEmptyElement.innerText = 'No outputs to render'; <del> if (this.cell.modified!.outputs.length === 0) { </del> <ins> if (!this.cell.modified?.outputs.length) { </ins> this._outputEmptyElement.style.display = 'block'; } else { this._outputEmptyElement.style.display = 'none';
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --VS Code Version: 1.85.0 Commit: Date: 2023-12-06T18:17:50.719Z Electron: 25.9.7 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Darwin arm64 23.1.0 macOS Version: macOS Sonoma 14.1.1 Steps to Reproduce: a file(Command-C) in VS Code explorer in VS Code explorer (Command-P) in VS Code explorer Code not respond Gif reproduce steps: !
Can reproduce on Windows 10 22H2: <img width="1308" alt="image" src=""The copied file will be created () and then the application freezes.
I'm unable to get a crash dump, but there are some logs when I run

Discussion:
const previouslyCutItems = this.cutItems; this.cutItems = cut ? items : undefined; await this.clipboardService.writeResources(items.map(s => s.resource)); <ins> if (items.length === 1) { await this.clipboardService.writeText(items[0].name); } </ins> this.view?.itemsCopied(items, cut, previouslyCutItems); }

const element = context.length ? context[0] : explorerService.roots[0]; const incrementalNaming = configurationService.getValue<IFilesConfiguration>().explorer.incrementalNaming; <ins> const editableItem = explorerService.getEditable(); // If it's an editable item, just do nothing if (editableItem) { return; } </ins> try { // Check if target is ancestor of pasted folder const sourceTargetPairs = coalesce(await Promise.all(toPaste.map(async fileToPaste => {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.85.0 OS Version: win10 Steps to Reproduce: a C/C++ program. "Ctrl +j" to Toggle Panel invisible. Change the debug console font size, then toggle panel visible. It can be seen the debug console content is cleared is a video demonstration
Weird bug. I can repro it
Still repros
I see that this works sometimes, but sometimes it still clears the debug console content.
I would like to work on this. Can you please assign this to me?
Feel free to send a PR if you'd like
Tried to reproduce this on the latest stable release and it seems like this is already fixed.
The original steps:
I submitted a to fix this problem. But I'm not sure if it is an ideal approach. Any feedback would be helpful .

Discussion:
private scopedInstantiationService!: IInstantiationService; private replElementsChangeListener: IDisposable | undefined; private styleElement: HTMLStyleElement | undefined; <ins> private styleChangedWhenInvisible: boolean = false; </ins> private completionItemProvider: IDisposable | undefined; private modelChangeListener: IDisposable = Disposable.None; private filter: ReplFilter;

this.replInput.setModel(this.model); this.updateInputDecoration(); this.refreshReplElements(true); <ins> if (this.styleChangedWhenInvisible) { this.styleChangedWhenInvisible = false; this.onDidStyleChange(); } </ins> } })); this._register(this.configurationService.onDidChangeConfiguration(e => {

} private onDidStyleChange(): void { <ins> if (!this.isVisible()) { this.styleChangedWhenInvisible = true; return; } </ins> if (this.styleElement) { this.replInput.updateOptions({ fontSize: this.replOptions.replConfiguration.fontSize,