jiebi/CodeConvo huggingface dataset:
Change:
Type: <bBug</bIn today's Insiders build, the Thumbs Up and Down buttons in chat offer no visual feedback that they were clicked. When you click thumbs up, absolutely nothing visible happens. When you click thumbs down, you get the dropdown and you can select a reason, but the only visual feedback that anything happened is that the checkbox next to the reason is checked the next time you hit thumbs down. Ideally, both buttons should do something like fill in solid color when they have been clicked. VS Code version: Code - Insiders 1.94.0-insider (, 2024-09-25T05:04:31.141Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (20)</summaryExtensionVersion ------ vscode-sidebar1.2.3 tsl-problem-matcher0.6.2 esbuild-problem-matchers0.0.3 vscode-eslint3.0.10 codespaces1.17.3 copilot1.234.1124 copilot-chat0.21. azure-dev0.8.3 vscode-azure-github-copilot0.2.74 vscode-azureresourcegroups0.9.5 vscode-docker1.29.3 vscode-dotnet-runtime2.1.6 debugpy2024.11. python2024.15. remote-containers0.387.0 remote-wsl0.88.4 extension-test-runner0.0.12 vscode-selfhost-test-provider0.3.25 vscode-yaml1.15.0 fugio0.0.7 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Good catch, thank you!

Discussion:
background-color: inherit; } <del> .chat-footer-toolbar { </del> <ins> .interactive-item-container .chat-footer-toolbar { </ins> display: none; } <del> .chat-footer-toolbar .monaco-action-bar .actions-container { </del> <ins> .interactive-item-container .chat-footer-toolbar .monaco-action-bar .actions-container { </ins> gap: 4px; padding-top: 6px; } <del> .interactive-response:not(.chat-response-loading) .chat-footer-toolbar { /* Complete response only */ display: initial; height: 22px; } .interactive-item-container .header .monaco-toolbar .checked.action-label, .interactive-item-container .header .monaco-toolbar .checked.action-label:hover { </del> <ins> .interactive-item-container .chat-footer-toolbar .checked.action-label, .interactive-item-container .chat-footer-toolbar .checked.action-label:hover { </ins> color: var(--vscode-inputOption-activeForeground) !important; border-color: var(--vscode-inputOption-activeBorder); background-color: var(--vscode-inputOption-activeBackground); } <ins> .interactive-item-container.interactive-response:not(.chat-response-loading) .chat-footer-toolbar { /* Complete response only */ display: initial; height: 22px; } </ins> .interactive-item-container .value { width: 100%; }
Change:
Provided we continue going forward with changing the background of the selection during composition, we need to also change the color of the text when in the high and low contrast themes, otherwise it is no longer possible to see the text very well. There would not be enough contrast. The way it looks now: Here the word should be in black so we can see it clearly.
Another option is to add an outline/dashed outline/etc. to indicate composition? Inverting the background color is a bit extreme imo, imagine being a user and almost everything you type makes the background of the text flip. Doesn't feel like a good UX to me.
Hmm that is true, I haven't thought about that. Good idea :). Maybe I'll just add an outline then.

Discussion:
border-bottom: none; } <del> .monaco-editor .edit-context-composition-secondary { </del> <ins> .monaco-editor :not(.hc-black, .hc-light) .edit-context-composition-secondary { </ins> border-bottom: 1px solid var(--vscode-editor-compositionBorder); } <del> .monaco-editor .edit-context-composition-primary { </del> <ins> .monaco-editor :not(.hc-black, .hc-light) .edit-context-composition-primary { </ins> border-bottom: 2px solid var(--vscode-editor-compositionBorder); } <ins> .monaco-editor :is(.hc-black, .hc-light) .edit-context-composition-secondary { border: 1px solid var(--vscode-editor-compositionBorder); } .monaco-editor :is(.hc-black, .hc-light) .edit-context-composition-primary { border: 2px solid var(--vscode-editor-compositionBorder); } </ins>
Change:
going through to test this: note I forgot to add these settings got these logs
I think I also ran into something similar while trying to test the same issue. There's some type of version mismatch !
Not sure if it's the same bug. I just: a notebook by just creating an empty file called a cell to save mismatch :bug:
same steps I used too
Verifier: Ensure that is enabled Open a notebook, e.g., GitHub issue notebook in VS Code repo Modify a cell content and try to save No error prompt should show up

Discussion:
this._alternativeId = this._textModel.getAlternativeVersionId(); } this._textBufferHash = null; <ins> this._onDidChangeContent.fire('content'); </ins> this._onDidChangeContent.fire({ type: 'model', event: e }); }));
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: and Steps to Reproduce: reports the following error and fails to read from stdin. I have located the root cause:
Great catch!
The fix should be in, could you verify after having pulled in the latest insiders update?
Yes, it works on the latest insiders with commit . Thank you :heart:.

Discussion:
export async function readFromStdin(targetPath: string, verbose: boolean, onEnd?: Function): Promise<void> { let [encoding, iconv] = await Promise.all([ <del> resolveTerminalEncoding(verbose),	// respect terminal encoding when piping into file import('@vscode/iconv-lite-umd'),	// lazy load encoding module for usage fs.promises.appendFile(targetPath, '') // make sure file exists right away (https://github.com/microsoft/vscode/issues/155341) </del> <ins> resolveTerminalEncoding(verbose),		// respect terminal encoding when piping into file import('@vscode/iconv-lite-umd'),		// lazy load encoding module for usage fs.promises.appendFile(targetPath, '') 	// make sure file exists right away (https://github.com/microsoft/vscode/issues/155341) </ins> ]); <del> if (!iconv.encodingExists(encoding)) { </del> <ins> if (!iconv.default.encodingExists(encoding)) { </ins> console.log(`Unsupported terminal encoding: ${encoding}, falling back to UTF-8.`); encoding = 'utf8'; }

const appendFileQueue = new Queue(); <del> const decoder = iconv.getDecoder(encoding); </del> <ins> const decoder = iconv.default.getDecoder(encoding); </ins> process.stdin.on('data', chunk => { const chunkStr = decoder.write(chunk);
Change:
a rust project Hold mousedown on the rust analyzer status bar contribution. The hover appears and disappears when the mouse is released.
it seems like you to prevent flickering from happening in the status bar. Maybe this is not required anymore? It seems like this is causing the flickering to happen currently. cc as he the if condition
I those listeners so that the tooltip is shown and hidden when keyboard focus moves into / out of status bar items. I just tested and those listeners are no longer needed because of work you've done to support showing the tooltip for items around the workbench when they're focused with the keyboard

Discussion:
private readonly commandMouseListener = this._register(new MutableDisposable()); private readonly commandTouchListener = this._register(new MutableDisposable()); private readonly commandKeyboardListener = this._register(new MutableDisposable()); <del> private readonly focusListener = this._register(new MutableDisposable()); private readonly focusOutListener = this._register(new MutableDisposable()); </del> private hover: IManagedHover | undefined = undefined;

} else { this.hover = this._register(this.hoverService.setupManagedHover(this.hoverDelegate, this.container, hoverContents)); } <del> if (entry.command !== ShowTooltipCommand /* prevents flicker on click */) { this.focusListener.value = addDisposableListener(this.labelContainer, EventType.FOCUS, e => { EventHelper.stop(e); this.hover?.show(false); }); this.focusOutListener.value = addDisposableListener(this.labelContainer, EventType.FOCUS_OUT, e => { EventHelper.stop(e); this.hover?.hide(); }); } </del> } // Update: Command
Change:
See It appears to timeout
I cannot explain this, we hang here: Which would suggest that we were unable to complete creating all workbench contributions. But I do not find anything in the logs that would hint into a direction

Discussion:
(function () { if (typeof globalThis.requestIdleCallback !== 'function' || typeof globalThis.cancelIdleCallback !== 'function') { <del> _runWhenIdle = (_targetWindow, runner) => { </del> <ins> _runWhenIdle = (_targetWindow, runner, timeout?) => { </ins> setTimeout0(() => { if (disposed) { return;

}; }; } <del> runWhenGlobalIdle = (runner) => _runWhenIdle(globalThis, runner); </del> <ins> runWhenGlobalIdle = (runner, timeout) => _runWhenIdle(globalThis, runner, timeout); </ins> })(); export abstract class AbstractIdleValue<T> {