Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.61.0 OS Version: macOS 11.6 a locked editor group containing a terminal: <img width="903" alt="Screen Shot 2021-10-13 at 1 48 32 PM" src="https://user-"the “New terminal” (+) button in the editor group header. The terminal opens in a different editor group and locks the group: <img width="903" alt="Screen Shot 2021-10-13 at 1 48 43 PM" src="https://user-"The terminal should open in the same editor group, like so: <img width="903" alt="Screen Shot 2021-10-13 at 1 52 30 PM" src="https://user-"(This may be the same issue as but because it’s been closed I can’t comment in it.)
This is working for me in insider's, so I believe it was fixed already.
I just installed the latest Insiders build (1.62.0-insider ) and can reproduce this issue with stock preferences and no extensions: https://user- I feel like I may be misunderstanding this issue — is the behaviour I’m showing intended?
I can reproduce, but only in the left most tab, in a tab on the right it seems to work fine.
FWIW I can reproduce in both directions. Here I have an editor open on the left to verify that the behaviour isn’t dependent on the other editor being empty: https://user-
can't reproduce in insider's, likely fixed now that the terminal editor is a singleton
I can still make this happen with the same reproduction steps in the latest Insiders build (Commit: ). Could this somehow be a macOS-specific bug? I’m trying to think of other reasons different users are seeing different results.
on Mac ! !
you're right reproduces with the editor group on the right
I can still reproduce this in the latest Insiders build (Version: 1.65.0-insider Commit: ).
I looked into this but couldn't find an option I can pass in to to force opening in the group if it's locked. It ends up here and passing on the active group: Am I missing something or would this need to be a new option to ignore locked? I think the ask makes sense that doing a plus via the action in the top of the editor should open it in that editor group as it's similar to dropping an editor into the group. I was going to make a new internal command that passes in a special option.
it should bypass if either you pass in the identifier of a group explicitly or
Thanks for your work on this, but FWIW I can still reproduce in the latest Insiders build ().
thanks for verifying, it should land in the first 1.80.0-insider build
Fix verified in Version: 1.80.0-insider Commit:, thanks!

Discussion:
import { IClipboardService } from 'vs/platform/clipboard/common/clipboardService'; import { TerminalCapability } from 'vs/platform/terminal/common/capabilities/capabilities'; import { killTerminalIcon, newTerminalIcon } from 'vs/workbench/contrib/terminal/browser/terminalIcons'; <ins> import { IEditorGroupsService } from 'vs/workbench/services/editor/common/editorGroupsService'; </ins> export const switchTerminalActionViewItemSeparator = 'u2500u2500u2500u2500u2500u2500u2500u2500u2500'; export const switchTerminalShowTabsTitle = localize('showTerminalTabs', "Show Tabs");

}); registerTerminalAction({ <ins> id: TerminalCommandId.CreateTerminalEditorSameGroup, title: { value: localize('workbench.action.terminal.createTerminalEditor', "Create New Terminal in Editor Area"), original: 'Create New Terminal in Editor Area' }, f1: false, run: async (c, accessor, args) => { // Force the editor into the same editor group if it's locked. This command is only ever // called when a terminal is the active editor const editorGroupsService = accessor.get(IEditorGroupsService); const instance = await c.service.createTerminal({ location: { viewColumn: editorGroupsService.activeGroup.index } }); instance.focusWhenReady(); } }); registerTerminalAction({ </ins> id: TerminalCommandId.CreateTerminalEditorSide, title: { value: localize('workbench.action.terminal.createTerminalEditorSide', "Create New Terminal in Editor Area to the Side"), original: 'Create New Terminal in Editor Area to the Side' }, run: async (c) => {

MenuRegistry.appendMenuItem(MenuId.EditorTitle, { command: { <del> id: TerminalCommandId.CreateTerminalEditor, </del> <ins> id: TerminalCommandId.CreateTerminalEditorSameGroup, </ins> title: terminalStrings.new, icon: Codicon.plus },

FocusPreviousPane = 'workbench.action.terminal.focusPreviousPane', ShowTabs = 'workbench.action.terminal.showTabs', CreateTerminalEditor = 'workbench.action.createTerminalEditor', <ins> CreateTerminalEditorSameGroup = 'workbench.action.createTerminalEditorSameGroup', </ins> CreateTerminalEditorSide = 'workbench.action.createTerminalEditorSide', FocusTabs = 'workbench.action.terminal.focusTabs', FocusNextPane = 'workbench.action.terminal.focusNextPane',