jiebi/CodeConvo huggingface dataset:
Change:
This situation has been discussed on PR . VSCode Version: Code OSS Dev (Insiders hasn't been built since PR ) OS Version: Ubuntu 19.10 Steps to Reproduce: the new setting 'Definition Link Opens in Peek' ! ctrl + click to open definition on Peek Widget that Peek Widget use ctrl + click again on another definition. As can be seen on this image there will be nested peeks which is not a correct behavior. ! I will submit a new PR because I have already fixed this on my fork.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.702 --- <!-- score: 0.646 --- <!-- score: 0.594 --- <!-- score: 0.542 --- <!-- score: 0.541 --<!-- potentialduplicatescomment --

Discussion:
import { withNullAsUndefined } from 'vs/base/common/types'; import { IKeyboardEvent } from 'vs/base/browser/keyboardEvent'; import { EditorOption } from 'vs/editor/common/config/editorOptions'; <ins> import { PeekContext } from 'vs/editor/contrib/peekView/peekView'; import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { ServicesAccessor } from 'vs/platform/instantiation/common/instantiation'; </ins> export class GotoDefinitionAtPositionEditorContribution implements IEditorContribution {

private gotoDefinition(position: Position, openToSide: boolean): Promise<any> { this.editor.setPosition(position); <del> const openInPeek = this.editor.getOption(EditorOption.definitionLinkOpensInPeek); const action = new DefinitionAction({ openToSide, openInPeek: openInPeek, muteMessage: true }, { alias: '', label: '', id: '', precondition: undefined }); return this.editor.invokeWithinContext(accessor => action.run(accessor, this.editor)); </del> <ins> const definitionLinkOpensInPeek = this.editor.getOption(EditorOption.definitionLinkOpensInPeek); return this.editor.invokeWithinContext((accessor) => { const canPeek = definitionLinkOpensInPeek && !this.isInPeekEditor(accessor); const action = new DefinitionAction({ openToSide, openInPeek: canPeek, muteMessage: true }, { alias: '', label: '', id: '', precondition: undefined }); return action.run(accessor, this.editor); }); } private isInPeekEditor(accessor: ServicesAccessor): boolean | undefined { const contextKeyService = accessor.get(IContextKeyService); return PeekContext.inPeekEditor.getValue(contextKeyService); </ins> } public dispose(): void {
Change:
<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --When using the git extension, the intent is clear when clicking on "+ Create new branch..." and immediately being prompted "Please provide a branch name". ! ! But, when clicking on "+ Create a new branch from..." the intent is ambiguous, since the statement "Please provide a branch name" could refer to the branch from which you wish to base the new branch or the name of the new branch, the latter being what actually happens. I've gotten confused one too many times, and inadvertently typed "develop" for the first prompt, only to be prompted with "Select a ref to create the 'develop' branch from". Whoops, time to start over. ! By specifying "Please provide a new branch name...", the intent is clear: the prompt is asking for the name you wish to call the new branch.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.658 --- <!-- score: 0.653 --- <!-- score: 0.652 --- <!-- score: 0.646 --- <!-- score: 0.573 --<!-- potentialduplicatescomment --
Let's swap the pick order, what do you think?
Oh I see you already have a PR for it

Discussion:
const rawBranchName = defaultName || await window.showInputBox({ placeHolder: localize('branch name', "Branch name"), <del> prompt: localize('provide branch name', "Please provide a branch name"), </del> <ins> prompt: localize('provide branch name', "Please provide a new branch name"), </ins> value: initialValue, ignoreFocusOut: true, validateInput: (name: string) => {
Change:
From Language specific settings are behind proposed API flag
English
— when a fixed stable build can be expected?
Planning to release today.

Discussion:
import { ILogService } from 'vs/platform/log/common/log'; import { Workspace } from 'vs/platform/workspace/common/workspace'; import { URI } from 'vs/base/common/uri'; <del> import { checkProposedApiEnabled } from 'vs/workbench/services/extensions/common/extensions'; </del> function lookUp(tree: any, key: string) { if (key) {

getConfiguration(section?: string, scope?: vscode.ConfigurationScope | null, extensionDescription?: IExtensionDescription): vscode.WorkspaceConfiguration { const overrides = scopeToOverrides(scope) || {}; <del> if (overrides.overrideIdentifier && extensionDescription) { checkProposedApiEnabled(extensionDescription); } </del> const config = this._toReadonlyValue(section ? lookUp(this._configuration.getValue(undefined, overrides, this._extHostWorkspace.workspace), section) : this._configuration.getValue(undefined, overrides, this._extHostWorkspace.workspace));
Change:
VSCode Version: 1.42.0 OS Version: Darwin x64 19.2.0 Git version: 2.24.1 Steps to Reproduce: and Debug extension git api commands, specifically Results in This format option was introduced here, and seems to be the change causing the issues I'm experiencing:
Reopening as it is not merged yet.

Discussion:
return path.replace(/^([a-z]):/i, (_, letter) => `${letter.toUpperCase()}:`); } <del> const COMMIT_FORMAT = '%Hn%aNn%aEn%atn%Pn%B'; </del> <ins> const COMMIT_FORMAT = '%H%n%aN%n%aE%n%at%n%P%n%B'; </ins> export class Git {

} async log(options?: LogOptions): Promise<Commit[]> { <del> const maxEntries = options && typeof options.maxEntries === 'number' && options.maxEntries > 0 ? options.maxEntries : 32; const args = ['log', '-' + maxEntries, `--format:${COMMIT_FORMAT}`, '-z']; </del> <ins> const maxEntries = options?.maxEntries ?? 32; const args = ['log', `-n${maxEntries}`, `--format=${COMMIT_FORMAT}`, '-z', '--']; </ins> const result = await this.run(args); if (result.exitCode) {

async logFile(uri: Uri, options?: LogFileOptions): Promise<Commit[]> { const maxEntries = options?.maxEntries ?? 32; <del> const args = ['log', `-${maxEntries}`, `--format=${COMMIT_FORMAT}`, '-z', '--', uri.fsPath]; </del> <ins> const args = ['log', `-n${maxEntries}`, `--format=${COMMIT_FORMAT}`, '-z', '--', uri.fsPath]; </ins> const result = await this.run(args); if (result.exitCode) {
Change:
my SCM extension has no use for the input box, so after creating its instance using scm.createSourceControl I want to set .inputBox.visible=false But visible is only defined in so I get this error reported when I save my change: It seems the property first got introduced by but that caused a problem and had to be reverted on 24-Oct-2018 by , which in turn was reverted later the same day by It passed testing on 30-Oct-2018 under More recently (4-Oct-2019) (still open) has made use of the visible property despite still only being proposed. Perhaps it can do this because it's the built-in Git SCM rather than an extension. Can this API be finalized soon?
Yeah let's try to move it along.
Sorry, but had to push this forward to March. Will get it done as soon as the milestone starts.
No worries and thanks for the update.
Ufff... I forgot I'll be out in March (paternity leave!) so have to push to April, sorry about that!
no worries. I hope your own personal March endgame goes really well

Discussion:
* A string to show as placeholder in the input box to guide the user. */ placeholder: string; <ins> /** * Controls whether the input box is visible (default is `true`). */ visible: boolean; </ins> } interface QuickDiffProvider {

//#endregion <del> //#region Joao: SCM Input Box /** * Represents the input box in the Source Control viewlet. */ export interface SourceControlInputBox { /** * Controls whether the input box is visible (default is `true`). */ visible: boolean; } //#endregion </del> //#region Terminal data write event https://github.com/microsoft/vscode/issues/78502 export interface TerminalDataWriteEvent {
Change:
The code in question looks like: This doesn't actually do anything, and is likely a bug. There are a few cases in .

Discussion:
export function makeKeyOptionalMessage(markerData: IMarkerData, useMessage: boolean): string { let result: string[] = [emptyString]; if (markerData.source) { <del> result.push(markerData.source.replace('¦', '¦')); </del> <ins> result.push(markerData.source.replace('¦', '¦')); </ins> } else { result.push(emptyString); } if (markerData.code) { if (typeof markerData.code === 'string') { <del> result.push(markerData.code.replace('¦', '¦')); </del> <ins> result.push(markerData.code.replace('¦', '¦')); </ins> } else { <del> result.push(markerData.code.value.replace('¦', '¦')); </del> <ins> result.push(markerData.code.value.replace('¦', '¦')); </ins> } } else { result.push(emptyString);

// Modifed to not include the message as part of the marker key to work around // https://github.com/microsoft/vscode/issues/77475 if (markerData.message && useMessage) { <del> result.push(markerData.message.replace('¦', '¦')); </del> <ins> result.push(markerData.message.replace('¦', '¦')); </ins> } else { result.push(emptyString); }
Change:
is a utility which is used for augmenting a shell with directory-specific environment variables. The main configuration file for direnv, , should be treated as a Shell Script by default.

Discussion:
"id": "shellscript", "aliases": ["Shell Script", "shellscript", "bash", "sh", "zsh", "ksh"], "extensions": [".sh", ".bash", ".bashrc", ".bash_aliases", ".bash_profile", ".bash_login", ".ebuild", ".install", ".profile", ".bash_logout", ".zsh", ".zshrc", ".zprofile", ".zlogin", ".zlogout", ".zshenv", ".zsh-theme", ".ksh"], <del> "filenames": ["APKBUILD", "PKGBUILD"], </del> <ins> "filenames": [ "APKBUILD", "PKGBUILD", ".envrc" ], </ins> "firstLine": "^#!.*b(bash|zsh|sh|tcsh|ksh|ash|qsh).*|^#s*-*-[^*]*mode:s*shell-script[^*]*-*-", "configuration": "./language-configuration.json", "mimetypes": ["text/x-shellscript"]
Change:
Currently the list sets the role of each item to be This should only be done for the Tree, not for the list. List should use . More details Tree that actually uses the list should probably pass the role as the getRole to the list it extends from. if you are busy let me know and I can look into this.
We should also verify this nicely works with NVDA, since it is part of aria 1.1 spec.
Sure, PR would be great.
Sure. Assigning to this milestone and if I do not find time might get pushed out.
To verify , turn on NVDA suggest box -make sure that the suggestions do not have "Level 1" read ath the end explorer -make sure the items have appropriate Level read at the end

Discussion:
if (!item.row) { item.row = this.cache.alloc(item.templateId); <del> const role = this.ariaProvider.getRole ? this.ariaProvider.getRole(item.element) : 'treeitem'; </del> <ins> const role = this.ariaProvider.getRole ? this.ariaProvider.getRole(item.element) : 'listitem'; </ins> item.row!.domNode!.setAttribute('role', role); const checked = this.ariaProvider.isChecked ? this.ariaProvider.isChecked(item.element) : undefined; if (typeof checked !== 'undefined') {

} : undefined, getRole: options.ariaProvider && options.ariaProvider.getRole ? (node) => { return options.ariaProvider!.getRole!(node.element); <del> } : undefined </del> <ins> } : () => 'treeitem' </ins> } }; }

}, getRole: options.ariaProvider!.getRole ? (el) => { return options.ariaProvider!.getRole!(el.element as T); <del> } : undefined, </del> <ins> } : () => 'treeitem', </ins> isChecked: options.ariaProvider!.isChecked ? (e) => { return options.ariaProvider?.isChecked!(e.element as T); } : undefined
Change:
has "strict" set to true, which "noImplicitAny", "noImplicitThis", and "alwaysStrict" but they are set to true explicitly anyway in the same file which is just redundant.

Discussion:
"compilerOptions": { "module": "amd", "moduleResolution": "node", <del> "noImplicitAny": true, </del> "experimentalDecorators": true, "noImplicitReturns": true, "noUnusedLocals": true, <del> "noImplicitThis": true, "alwaysStrict": true, </del> "strict": true, "forceConsistentCasingInFileNames": true, "baseUrl": ".",
Change:
The widget does not appear when a local link has line numbers like: . This is because the URI cannot be parsed correctly and crashes here: This might happen in other cases when the URI cannot be parsed.
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.469 --<!-- potentialduplicatescomment --

Discussion:
} } <del> const message: IMarkdownString = new MarkdownString(`[Follow Link](${uri}) (${label})`, true); message.uris = { [uri]: URI.parse(uri).toJSON() }; return message; </del> <ins> return new MarkdownString(`[Follow Link](${uri}) (${label})`, true); </ins> } private get osPath(): IPath {
Change:
Steps to Repro Set up settings sync - Follow instructions Turn on Sync From the gear icon, select entry Quick pick is shown. From the quick pick click on entry Quick pick with wrong selected items is shown <img width="631" alt="image" src="https://user-"Expected: <img width="632" alt="image" src="https://user-"Note: Expected is shown when you use keyboard to select entry. It happens only when you use mouse and click.
There is a change event on the checkbox from the mouse up on the entry. I don't have a fix in QuickInput currently, can we change to: That appears to let the mouse up pass without triggering the change event on the checkbox.
Is this a temp workaround and do you have plans to fix it in quick pick later?
It’s certainly a workaround. I don’t have a proper fix yet.

Discussion:
import { IProductService } from 'vs/platform/product/common/productService'; import { IStorageService, StorageScope } from 'vs/platform/storage/common/storage'; import { IOpenerService } from 'vs/platform/opener/common/opener'; <ins> import { timeout } from 'vs/base/common/async'; </ins> const enum AuthStatus { Initializing = 'Initializing',

quickPick.items = items; disposables.add(quickPick.onDidAccept(() => { if (quickPick.selectedItems[0] && quickPick.selectedItems[0].id) { <del> commandService.executeCommand(quickPick.selectedItems[0].id); </del> <ins> // Introduce timeout as workaround - #91661 #91740 timeout(0).then(() => commandService.executeCommand(quickPick.selectedItems[0].id!)); </ins> } quickPick.hide(); }));
Change:
the debug view and a .js file the window that the debug view doesn't seem to recognize a file is open to another file and back again fixes it
I can not reproduce this with latest VS Code out of source. I can reproduce in vscode insiders. Thus it seems like I fixed the issue. Let me know if you can repro out of source and I will reopen. Potentially a candidate. Let me know if you think it is and I can search for the exact fix and port it to the release branch if we do a recovery release.
I don't think this is candidate worthy. Thanks for looking into it!
I can actually still reproduce this, though it seems racey. Create a brand new folder Create some in it, and open it. Open the debug view Reload the window Run and Debug button is greyed out
Pushed a potential fix. Can not really verify if it fixes since can not repro out of source.
This still repro's. I'll move this to next month and debug on my machine since it doesn't repro for you.
thanks for moving it. No need to debug on your machine since now I can reproduce it. But I can only reproduce it in the built version which makes debugging it a bit harder.
I got a fix for this though I couldn't actually verify it since I cannot repro out of source but it does happen in stable and insiders. I'll create a PR so you can try it out.
As mentioned in the PR I fully built VS Code from your changes and the issue is fixed. Great fix and thanks for help

Discussion:
import { isCodeEditor } from 'vs/editor/browser/editorBrowser'; import { IStorageService, StorageScope } from 'vs/platform/storage/common/storage'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; <ins> import { DisposableStore } from 'vs/base/common/lifecycle'; </ins> const debugStartLanguageKey = 'debugStartLanguage'; const CONTEXT_DEBUG_START_LANGUAGE = new RawContextKey<string>(debugStartLanguageKey, undefined);

} this.debuggerInterestedContext.set(false); }; <del> this._register(editorService.onDidActiveEditorChange(setContextKey)); </del> <ins> const disposables = new DisposableStore(); this._register(disposables); this._register(editorService.onDidActiveEditorChange(() => { disposables.clear(); const editorControl = this.editorService.activeTextEditorControl; if (isCodeEditor(editorControl)) { disposables.add(editorControl.onDidChangeModelLanguage(setContextKey)); } setContextKey(); })); </ins> this._register(this.debugService.getConfigurationManager().onDidRegisterDebugger(setContextKey)); this._register(this.onDidChangeBodyVisibility(visible => { if (visible) {
Change:
Issue Type: <bBug</bnew VSCode window new Terminal terminal: terminal: in Cmd and mouse over the two listing name. Only the /tmp/Foo.h will be clickable. won't be because of the . VS Code version: Code 1.43.0 (, 2020-03-09T19:34:44.548Z) OS version: Darwin x64 19.3.0 <!-- generated by issue reporter --
/duplicate

Discussion:
const pathSeparatorClause = '/'; // '":; are allowed in paths but they are often separators so ignore them // Also disallow  to prevent a catastropic backtracking case #24798 <del> const excludedPathCharactersClause = '[^0s!$`&*()[]+'":;]'; </del> <ins> const excludedPathCharactersClause = '[^0s!$`&*()[]'":;]'; </ins> /** A regex that matches paths in the form /foo, ~/foo, ./foo, ../foo, foo/bar */ export const unixLocalLinkClause = '((' + pathPrefix + '|(' + excludedPathCharactersClause + ')+)?(' + pathSeparatorClause + '(' + excludedPathCharactersClause + ')+)+)'; export const winDrivePrefix = '(?:?)?[a-zA-Z]:'; const winPathPrefix = '(' + winDrivePrefix + '|..?|~)'; const winPathSeparatorClause = '(|/)'; <del> const winExcludedPathCharactersClause = '[^0<>?|/s!$`&*()[]+'":;]'; </del> <ins> const winExcludedPathCharactersClause = '[^0<>?|/s!$`&*()[]'":;]'; </ins> /** A regex that matches paths in the form ?c:foo c:foo, ~foo, .foo, ..foo, foobar */ export const winLocalLinkClause = '((' + winPathPrefix + '|(' + winExcludedPathCharactersClause + ')+)?(' + winPathSeparatorClause + '(' + winExcludedPathCharactersClause + ')+)+)';

'./foo', '../foo', '/foo/bar', <del> 'foo/bar' </del> <ins> '/foo/bar+more', 'foo/bar', 'foo/bar+more', </ins> ]; const windowsLinks = [

'~/foo', 'c:/foo/bar', 'c:foobar', <ins> 'c:foobar+more', </ins> 'c:foo/barbaz', 'foo/bar', 'foo/bar', <del> 'foobar' </del> <ins> 'foobar', 'foobar+more', </ins> ]; interface LinkFormatInfo {
Change:
<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.43.0 OS Version: macOS 10.15.3 Steps to Reproduce: ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Same issue after updating to 1.43.0
I experience the same issue in: Version: 1.44.0-insider Commit: Date: 2020-03-11T09:19:54.444Z Electron: 7.1.11 Chrome: 78.0.3904.130 12.8.1 V8: 7.8.279.23-electron.0 OS: Linux x64 5.3.0-40-generic !
Does this have anything to do with the recent change in less?
caused by
PR created, to review (and merge, if ok)
To verify open a 'less' file with content and check that there's a color decorator

Discussion:
}, "main": "./out/cssServerMain", "dependencies": { <del> "vscode-css-languageservice": "^4.1.0", </del> <ins> "vscode-css-languageservice": "^4.1.1", </ins> "vscode-languageserver": "^6.1.1" }, "devDependencies": {

dependencies: is-number "^7.0.0" <del> vscode-css-languageservice@^4.1.0: version "4.1.0" resolved "https://registry.yarnpkg.com/vscode-css-languageservice/-/vscode-css-languageservice-4.1.0.tgz#144c8274e0bf1719fa6f773ca684bd1c7ffd634f" integrity sha512-iTX3dTp0Y0RFWhIux5jasI8r9swdiWVB1Z3OrZ10iDHxzkETjVPxAQ5BEQU4ag0Awc8TTg1C7sJriHQY2LO14g== </del> <ins> vscode-css-languageservice@^4.1.1: version "4.1.1" resolved "https://registry.yarnpkg.com/vscode-css-languageservice/-/vscode-css-languageservice-4.1.1.tgz#9131dd465e4b20f3ba78ab9734b2c7cdb9237443" integrity sha512-2r2bYbhscivRu1zqh5kNe8aYpFnfksMYC7wTpKX2HqFsSzSJYXk0sCqPaWsP5ptqz0OFBTXnzx2JlE+Nb5Edgw== </ins> dependencies: vscode-languageserver-textdocument "^1.0.1" vscode-languageserver-types "^3.15.1"
Change:
WebView width is limited to 780px. ! It shrinks all images included what makes them barely readable. What's the point of this limit? It should be set to either 100% or more reasonable 1200px, but would be best to manage it through <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.43 OS Version: Windows 10 Steps to Reproduce: any extension page including images in VSCode or hit Help -Release notes <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes and with all themes
Very long lines of text are not readable You can view the web release notes (or the ones on GitHub) if you want a different layout
seriously? Someone having problems with reading lines longer than 780px is the reason for this!? Do you even realise how ridiculous it is? And what exactly is a design problem here that it can't be managed by user settings like almost everything else? Please, reopen this issue.
You are welcome to submit a PR that makes images larger (while keeping the max text line length the same). However even the images should likely have a max width. See how GitHub and many other sites render readmes
My point exactly! GitHub's limit for content width is 882px and I believe it was also like that for VSCode few versions ago. Why it was lowered to 780px is inexplicable. Plus on GitHub you can actually click the image for full size. That's why even Microsoft often adds images 2000px+ width in readmes.
It is now 100px wider :)
Baby steps I'd rather make it 1200px or 100%, but I doubt it would be approved. Maybe someday it will be managed through settings for everyone's content... Thanks

Discussion:
body { padding: 10px 20px; line-height: 22px; <del> max-width: 780px; </del> <ins> max-width: 882px; </ins> margin: 0 auto; }
Change:
Steps to Reproduce: a breakpoint into debug viewlet on link to create mock debug config = dispose of the workbench is triggered

Discussion:
import { Event } from 'vs/base/common/event'; import { IOpenerService } from 'vs/platform/opener/common/opener'; <del> import { $ } from 'vs/base/browser/dom'; </del> <ins> import { $, EventHelper, EventLike } from 'vs/base/browser/dom'; </ins> import { domEvent } from 'vs/base/browser/event'; import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent'; import { KeyCode } from 'vs/base/common/keyCodes';

.map(e => new StandardKeyboardEvent(e)) .filter(e => e.keyCode === KeyCode.Enter) .event; <del> const onOpen = Event.any(onClick, onEnterPress); </del> <ins> const onOpen = Event.any<EventLike>(onClick, onEnterPress); </ins> <del> this._register(onOpen(_ => openerService.open(link.href))); </del> <ins> this._register(onOpen(e => { EventHelper.stop(e, true); openerService.open(link.href); })); </ins> this.applyStyles(); }

const anchor = $('a', { href: node.href, title: title, }, node.label); if (actionHandler) { <del> actionHandler.toDispose.add(addDisposableListener(anchor, EventType.CLICK, () => actionHandler.callback(node.href))); </del> <ins> actionHandler.toDispose.add(addDisposableListener(anchor, EventType.CLICK, e => { EventHelper.stop(e, true); actionHandler.callback(node.href); })); </ins> } messageContainer.appendChild(anchor);