jiebi/CodeConvo huggingface dataset:
Change:
Related: Both need additional info: <img width="241" alt="Screen Shot 2021-04-27 at 4 55 10 AM" src="https://user-"
Any change I do in the explorer raises a user revolt. So could do this start of next milestone. Delete does not require additional user input (if I say do not ask again for prompt). So I think only should be However I would wait for the editor to change to be so they are aligned. fyi
Not so sure about the rules <img width="748" alt="Screenshot 2021-04-27 at 14 36 26" src="https://user-"
Finder is inconsistent; "Tags..." opens an inline pop similar to rename, but rename doesn't have the . It might not be the best example.
Using ... on actions when needing user input has been a consistent pattern we've used for named actions. So we should try to keep it consistent.
Will take this in start of next milestone
From a UX perspective it appears is used when a quick input is present but not when an inline edit widget is. So I believe that's why things like and do not have , so is the UX guideline that inline edit widgets also should have ?
I would say that any action that requires user input should use the . I am seeing the same for toolbar actions like new file/folder in the tooltip as well while the quick pick and app menu do show it. <img width="170" alt="CleanShot 2022-08-16 at 08 45 32 src="https://user-"<img width="202" alt="CleanShot 2022-08-16 at 08 45 40 src="https://user-"<img width="303" alt="CleanShot 2022-08-16 at 08 45 47 src="https://user-"

Discussion:
import { IPathService } from 'vs/workbench/services/path/common/pathService'; export const NEW_FILE_COMMAND_ID = 'explorer.newFile'; <del> export const NEW_FILE_LABEL = nls.localize('newFile', "New File"); </del> <ins> export const NEW_FILE_LABEL = nls.localize('newFile', "New File..."); </ins> export const NEW_FOLDER_COMMAND_ID = 'explorer.newFolder'; <del> export const NEW_FOLDER_LABEL = nls.localize('newFolder', "New Folder"); export const TRIGGER_RENAME_LABEL = nls.localize('rename', "Rename"); </del> <ins> export const NEW_FOLDER_LABEL = nls.localize('newFolder', "New Folder..."); export const TRIGGER_RENAME_LABEL = nls.localize('rename', "Rename..."); </ins> export const MOVE_FILE_TO_TRASH_LABEL = nls.localize('delete', "Delete"); export const COPY_FILE_LABEL = nls.localize('copyFile', "Copy"); export const PASTE_FILE_LABEL = nls.localize('pasteFile', "Paste");

constructor() { super({ id: 'workbench.files.action.createFileFromExplorer', <del> title: nls.localize('createNewFile', "New File"), </del> <ins> title: nls.localize('createNewFile', "New File..."), </ins> f1: false, icon: Codicon.newFile, precondition: ExplorerResourceNotReadonlyContext,

constructor() { super({ id: 'workbench.files.action.createFolderFromExplorer', <del> title: nls.localize('createNewFolder', "New Folder"), </del> <ins> title: nls.localize('createNewFolder', "New Folder..."), </ins> f1: false, icon: Codicon.newFolder, precondition: ExplorerResourceNotReadonlyContext,
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --VS Code currently associates the extension with the Make language. is another common file extension for files included by s. It's associated with Make by , i.e. files are recognized by , and there are a few dozen public . VS Code should recognize this extension automatically.
could you point me to some documentation about please?
Hi I've updated the issue description with some additional information. Notably, , which I consider to be a fairly canonical source. I've not any of the other file extensions recognized by GitHub Linguist for Make, as I've not seen them in use. Anecdotally, my employer has been using the extension internally since at least 2001.
Here are some additional examples which demonstrate inclusion of files by s:
That's good enough for me, thank you!
/verified

Discussion:
"makefile" ], "extensions": [ <ins> ".mak", </ins> ".mk" ], "filenames": [
Change:
We decided to turn the feature off by default. While the feature is quite polished at this point, there are a few remaining issues and we'll probably find some more when the feature goes out to a larger group so we'll push the default switch to next month.

Discussion:
'terminal.integrated.tabs.enabled': { description: localize('terminal.integrated.tabs.enabled', 'Controls whether terminal tabs display as a list to the side of the terminal. When this is disabled a dropdown will display instead.'), type: 'boolean', <del> default: true, </del> <ins> default: false, </ins> }, 'terminal.integrated.tabs.hideCondition': { description: localize('terminal.integrated.tabs.hideCondition', 'Controls whether the terminal tabs view will hide under certain conditions.'),
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --It should be documented that if the and the decoration already exists in the editor, it removes the decoration instead of no-op.

Discussion:
/** * Adds a set of decorations to the text editor. If a set of decorations already exists with <del> * the given {@link TextEditorDecorationType decoration type}, they will be replaced. </del> <ins> * the given {@link TextEditorDecorationType decoration type}, they will be replaced. If * `rangesOrOptions` is empty, the existing decorations with the given {@link TextEditorDecorationType decoration type} * will be removed. </ins> * * @see {@link window.createTextEditorDecorationType createTextEditorDecorationType}. *
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --WMIC is deprecated and has been for some time. Currently it is used for determining if any integrated terminal instances have any child processes. There are PowerShell commands that can return the count of child processes given a parent process ID, but I'm not sure what the performance hit for using PowerShell would be.
Windows doesn't maintain strong parent/child process relationships, so the design here needs some more thinking. If you're feeling gangster, you can call with and dig out the undocumented member. But I wouldn't bother, because you then need to consider and now points to something else entirely.
Thanks for all the help !

Discussion:
import { ExtHostConfigProvider } from 'vs/workbench/api/common/extHostConfiguration'; function spawnAsPromised(command: string, args: string[]): Promise<string> { return new Promise((resolve, reject) => { let stdout = '';

export function hasChildProcesses(processId: number | undefined): Promise<boolean> { if (processId) { // if shell has at least one child process, assume that shell is busy if (platform.isWindows) { <del> return spawnAsPromised('wmic', ['process', 'get', 'ParentProcessId']).then(stdout => { const pids = stdout.split('rn'); return pids.some(p => parseInt(p) === processId); }, error => { return true; </del> <ins> return new Promise<boolean>(async (resolve) => { // See #123296 const windowsProcessTree = await import('windows-process-tree'); windowsProcessTree.getProcessTree(processId, (processTree) => { resolve(processTree.children.length > 0); }); </ins> }); } else { return spawnAsPromised('/usr/bin/pgrep', ['-lP', String(processId)]).then(stdout => {
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.56.1 OS Version: Windows Steps to Reproduce: a (reasonably long) markdown file and scroll down a bit. the dynamic preview for the markdown file. It opens the preview at the top of the file, but should open it where your text editor (containing the target markdown) is scrolled to. This is not adjusted until the user scrolls or resizes the window. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --

Discussion:
resource: vscode.Uri, previewSettings: DynamicPreviewSettings ): DynamicMarkdownPreview { <ins> const activeTextEditorURI = vscode.window.activeTextEditor?.document.uri; const scrollLine = (activeTextEditorURI?.toString() === resource.toString()) ? vscode.window.activeTextEditor?.visibleRanges[0].start.line : undefined; </ins> const preview = DynamicMarkdownPreview.create( { resource, resourceColumn: previewSettings.resourceColumn, locked: previewSettings.locked, <ins> line: scrollLine, </ins> }, previewSettings.previewColumn, this._contentProvider,
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --- VS Code Version: 1.56.1 OS Version: Windows 10 Prof 64 Bit Steps to Reproduce: CustomDocumentProvider to CustomEditorProvider line 7747 line 7786 TaskProvider line 6697: create a md link from #tasks.registerTaskProvider <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --
Hi, I would like to look into this issue. Could I be assigned ?
I'm new to this, but I'm eager to learn!
Hello, can I work on this issue ?
This is a very small change so please just submit a PR

Discussion:
/** * Event triggered by extensions to signal to VS Code that an edit has occurred on an {@link CustomDocument `CustomDocument`}. * <del> * @see {@link CustomDocumentProvider.onDidChangeCustomDocument `CustomDocumentProvider.onDidChangeCustomDocument`}. </del> <ins> * @see {@link CustomEditorProvider.onDidChangeCustomDocument `CustomEditorProvider.onDidChangeCustomDocument`}. </ins> */ interface CustomDocumentEditEvent<T extends CustomDocument = CustomDocument> {

* Event triggered by extensions to signal to VS Code that the content of a {@link CustomDocument `CustomDocument`} * has changed. * <del> * @see {@link CustomDocumentProvider.onDidChangeCustomDocument `CustomDocumentProvider.onDidChangeCustomDocument`}. </del> <ins> * @see {@link CustomEditorProvider.onDidChangeCustomDocument `CustomEditorProvider.onDidChangeCustomDocument`}. </ins> */ interface CustomDocumentContentChangeEvent<T extends CustomDocument = CustomDocument> { /**
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --When using the Git API extension Repository interface and the corresponding are not exposed. Having access to these functions would be very helpful, since using with returns early and doesn't provide useful errors.
Verified by code review

Discussion:
return this._repository.getMergeBase(ref1, ref2); } <ins> tag(name: string, upstream: string): Promise<void> { return this._repository.tag(name, upstream); } deleteTag(name: string): Promise<void> { return this._repository.deleteTag(name); } </ins> status(): Promise<void> { return this._repository.status(); }

getMergeBase(ref1: string, ref2: string): Promise<string>; <ins> tag(name: string, upstream: string): Promise<void>; deleteTag(name: string): Promise<void>; </ins> status(): Promise<void>; checkout(treeish: string): Promise<void>;
Change:
Issue Type: <bBug</ba new markdown file. For example: txt code block (with backslash to prevent outer markdown from being prematurely terminated in the issue report)  the preview for the markdown file that the spacing after the table and before the header is very small and makes it less readable. I've tried adding extra lines after the table, but they just get collapsed since it's just whitespace. VS Code version: Code 1.56.0 (Universal) (, 2021-05-04T22:06:21.189Z) OS version: Darwin x64 20.3.0 <details<summarySystem Info</summary </details<details<summaryExtensions (12)</summaryExtensionVersion ------ Bookmarks13.0.4 vscode-eslint2.1.20 gitlens11.4.1 EditorConfig0.16.4 bash-ide-vscode1.11.0 vscode-docker1.12.1 mssql1.10.1 cpptools1.3.1 shellcheck0.14.1 pdf1.1.0 cmake0.0.17 markdown-all-in-one3.4.0 </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Hi, according to the : The implication of the “one or more consecutive lines of text” rule is that Markdown supports “hard-wrapped” text paragraphs. This differs significantly from most other text-to-HTML formatters (including Movable Type’s “Convert Line Breaks” option) which translate every line break character in a paragraph into a <br /tag. You can insert 2 newlines or else you can insert a HTML line break like this txt code block (with backslash to prevent outer markdown from being prematurely terminated in the issue report)  hope that help ;)
hello I will love to take a shot this, could you provide a guide on what is needed.
Here's the css file for the markdown preview: Try seeing if other elements, such as images, also need more bottom padding in this case
I a margin-bottom to table element, after checking on image the existing space seams okay, you can review the PR

Discussion:
table { border-collapse: collapse; <ins> margin-bottom: 0.7em; </ins> } th {
Change:
In Chrome sometimes opened window is sharing event loop with the original window, in cases like the same origin or the same parent domain. If one tries to debug one of such windows then others are hanging. I was wondering whether it is better to rewrite like that: Updated: i tried with above and it does not help, Chrome blocks new windows besides first by default.
To avoid sharing the same event loop or whatever, I suggest to adopt . But that one does not return true/false if the window opened. I left in this particular place to maintain the existing behavior. I think this returned boolean was as part of the Safari/iPad work.
Yes the returned boolean was as a way for us to know if the window opened successfully. Since Safari sometimes blocks new windows / tabs.
You could invoke different methods based on the browser: the one without a return value in Chrome / the one with a return value in Safari.
this makes sense we are open to a PR which implements this as suggested.

Discussion:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ <del> import { setFullscreen } from 'vs/base/browser/browser'; </del> <ins> import { isSafari, setFullscreen } from 'vs/base/browser/browser'; </ins> import { addDisposableListener, addDisposableThrottledListener, detectFullscreen, EventHelper, EventType, windowOpenNoOpenerWithSuccess, windowOpenNoOpener } from 'vs/base/browser/dom'; import { DomEmitter } from 'vs/base/browser/event'; import { timeout } from 'vs/base/common/async';

this.openerService.setDefaultExternalOpener({ openExternal: async (href: string) => { if (matchesScheme(href, Schemas.http) || matchesScheme(href, Schemas.https)) { <del> const opened = windowOpenNoOpenerWithSuccess(href); if (!opened) { const showResult = await this.dialogService.show( Severity.Warning, localize('unableToOpenExternal', "The browser interrupted the opening of a new tab or window. Press 'Open' to open it anyway."), [ localize('open', "Open"), localize('learnMore', "Learn More"), localize('cancel', "Cancel") ], { cancelId: 2, detail: href </del> <ins> if (isSafari) { const opened = windowOpenNoOpenerWithSuccess(href); if (!opened) { const showResult = await this.dialogService.show( Severity.Warning, localize('unableToOpenExternal', "The browser interrupted the opening of a new tab or window. Press 'Open' to open it anyway."), [ localize('open', "Open"), localize('learnMore', "Learn More"), localize('cancel', "Cancel") ], { cancelId: 2, detail: href } ); if (showResult.choice === 0) { windowOpenNoOpener(href); </ins> } <del> ); if (showResult.choice === 0) { windowOpenNoOpener(href); } if (showResult.choice === 1) { await this.openerService.open(URI.parse('https://aka.ms/allow-vscode-popup')); </del> <ins> if (showResult.choice === 1) { await this.openerService.open(URI.parse('https://aka.ms/allow-vscode-popup')); } </ins> } <ins> } else { windowOpenNoOpener(href); </ins> } } else { this.lifecycleService.withExpectedUnload(() => window.location.href = href);
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Insiders OS Version: Mac Steps to Reproduce: a serializer a document with cells having an execution order execution order is not available in the cells

Discussion:
data.language, data.outputs ? data.outputs.map(NotebookCellOutput.to) : undefined, data.metadata ? NotebookCellMetadata.to(data.metadata) : undefined, <ins> data.internalMetadata ? NotebookCellExecutionSummary.to(data.internalMetadata) : undefined </ins> ); } }
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --For labels in extensions, using e.g. . However, there seems to be no way to show the literal text in a label, i.e. escaping the icon syntax. This is relevant for the Vim extension, as it makes it impossible to e.g. search/replace icon codes using the Vim commandline input when developing an extension: ! See
May I know where/which view in VS code this is being rendered?
In the screenshot it's a , but according to the same would apply to hovers and QuickPickItems too
should do it.
Hm, that seems to work indeed. I thought I had tried that, but apparently not? Thanks, closing this then. I opened to document this.

Discussion:
// See http://go.microsoft.com/fwlink/?LinkId=759670 // for the documentation about the jsconfig.json format "compilerOptions": { <del> "module": "commonjs" </del> <ins> "target": "es6" </ins> }, "exclude": [ "node_modules",
Change:
create a TS file: place cursor after and press wait for inline completions to render press arrow right https://user-
Interesting, I cannot reproduce this on main: !
Can you try to unbind the keybinding that arrow right accepts the completion ? (I think for me arrow right is moving cursor right and for you arrow right might accept the completion)
Oh I misread the issue description. But what should be the expected outcome? ~You can either only position the cursor directly before the decoration or directly after it, but not both. We explicitly want to set the cursor directly before it.~ Oh I see the point. It should properly predict what the suggest widget will do on insert.
I think the problem is that the view model updates only on document content change events and on suggest widget focus events and doesn't re-evaluate the common prefix on cursor position change events. i.e. here is what I would expect: !
Interestingly it works efor arrow left when you trigger the suggest widget at .

Discussion:
const info = suggestController.getOverwriteInfo(item, false); return { text: insertText, <del> range: Range.fromPositions(position.delta(0, -info.overwriteBefore), position.delta(0, info.overwriteAfter)), </del> <ins> range: Range.fromPositions( position.delta(0, -info.overwriteBefore), position.delta(0, Math.max(info.overwriteAfter, 0)) ), </ins> }; }
Change:
In today Insider build a lot of Mac OS smoke tests failed all with The build is here: I will rerun the test to see if this is a hick-up or a general problem.
Seems related to Assigning some owners.

Discussion:
await this._start(); await this.code.waitForElement('.explorer-folders-view'); <ins> if (!this.options.web) { // Dismiss workspace trust dialog await this.code.waitAndClick(`.monaco-workbench .dialog-buttons-row a:nth-child(1)`, 10, 10); } </ins> // https://github.com/microsoft/vscode/issues/118748 // if (expectWalkthroughPart) { // 	await this.code.waitForElement(`.editor-instance > div > div.welcomePageFocusElement[tabIndex="0"]`);

await this.stop(); await new Promise(c => setTimeout(c, 1000)); await this._start(options.workspaceOrFolder, options.extraArgs); <ins> await this.code.waitForElement('.explorer-folders-view'); if (!this.options.web) { // Dismiss workspace trust dialog await this.code.waitAndClick(`.monaco-workbench .dialog-buttons-row a:nth-child(1)`, 10, 10); } </ins> } private async _start(workspaceOrFolder = this.workspacePathOrFolder, extraArgs: string[] = []): Promise<any> {