jiebi/CodeConvo huggingface dataset:
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.34.0-insider OS Version: All Steps to Reproduce: This issue is difficult to reproduce as it requires a special version of an icon theme extension that supports theme reloading ().
(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: <!-- score: 0.592 --- <!-- score: 0.528 --- <!-- score: 0.482 --- <!-- score: 0.45 --<!-- potentialduplicatescomment --
Being a maintainer of the extension, I stumbled on this issue while testing the implementation of this feature on our extension. As I'm the author of the theme reloading feature, I pinpointed the cause of the bug. The reason for it is that on we don't call the event, resulting in the not getting notified. The solution is to add a call to on the function. Although much of the code execution of the is overkill when we reload the icon theme, it has no side effects. Possible actions are: and extract the calls to telemetry and event triggering to separate function and then use only the extracted function nothing and just add the call to and don't care about the redundant code execution since it does not have any side effects. I'm more than willing to provide a PR according to the chosen action, although I suspect that you guys prefer action 2. Awaiting your response.
I like the suggestion of calling . PR is of course very welcome!

Discussion:
} if (this.watchedIconThemeLocation && this.currentIconTheme && e.contains(this.watchedIconThemeLocation, FileChangeType.UPDATED)) { await this.currentIconTheme.reload(this.fileService); <del> _applyIconTheme(this.currentIconTheme, () => Promise.resolve(this.currentIconTheme)); </del> <ins> _applyIconTheme(this.currentIconTheme, () => { this.doSetFileIconTheme(this.currentIconTheme); return Promise.resolve(this.currentIconTheme); }); </ins> } }); }
Change:
install open a json document open the context menu, and pick the first entry in the list. Nothing happens.
this is 0 being falsy...
JFR: setting first formatter as default and running "Format Document" works as a workaround.
fix for next insiders and for 1.33.1
wt., 9 kwi 2019, 17:57 użytkownik Johannes Rieken <notifications
verified in Version: 1.34.0-insider Commit:

Discussion:
const model = editor.getModel(); const provider = getRealAndSyntheticDocumentFormattersOrdered(model); const pick = await instaService.invokeFunction(showFormatterPick, model, provider); <del> if (pick) { </del> <ins> if (typeof pick === 'number') { </ins> await instaService.invokeFunction(formatDocumentWithProvider, provider[pick], editor, FormattingMode.Explicit, CancellationToken.None); } logFormatterTelemetry(telemetryService, 'document', provider, typeof pick === 'number' && provider[pick] || undefined);

const provider = DocumentRangeFormattingEditProviderRegistry.ordered(model); const pick = await instaService.invokeFunction(showFormatterPick, model, provider); <del> if (pick) { </del> <ins> if (typeof pick === 'number') { </ins> await instaService.invokeFunction(formatDocumentRangeWithProvider, provider[pick], editor, range, CancellationToken.None); }
Change:
For This minor release of TypeScript will invalidate the automatic types cache so that upstream fixes to the styled components typings are downloaded
PR has been merged -closing.

Discussion:
"version": "0.0.1", "description": "Dependencies shared by all extensions", "dependencies": { <del> "typescript": "3.4.1" </del> <ins> "typescript": "3.4.3" </ins> }, "scripts": { "postinstall": "node ./postinstall"

# yarn lockfile v1 <del> typescript@3.4.1: version "3.4.1" resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.4.1.tgz#b6691be11a881ffa9a05765a205cb7383f3b63c6" integrity sha512-3NSMb2VzDQm8oBTLH6Nj55VVtUEpe/rgkIzMir0qVoLyjDZlnMBva0U6vDiV3IH+sl/Yu6oP5QwsAQtHPmDd2Q== </del> <ins> typescript@3.4.3: version "3.4.3" resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.4.3.tgz#0eb320e4ace9b10eadf5bc6103286b0f8b7c224f" integrity sha512-FFgHdPt4T/duxx6Ndf7hwgMZZjZpB+U0nMNGVCYPq0rEzWKjEDobm4J6yb3CS7naZ0yURFqdw9Gwc7UOh/P9oQ== </ins>
Change:
VSCode Version: 1.34.0-insider (1.34.0-insider) OS Version: macOS mojave 10.14.4 Steps to Reproduce: in activate method of any extension. the developer tools. What is expected? Show the file dialog like following: ! What is actually happening? Following error message shown in the Developer tools. Does this issue occur when all extensions are disabled?: Yes According to the code here: , I think the reason is " is ", then I got as the of see here: If you confirm this is a bug, I'd like to create a pull request to fix it.
I think I find the commit which cause the bug, see: Here we transform the " and " to " and ", but the args that send is still , and because it send undefined in my case, I got as , then the error throws. Since I find the cause of this bug, I feel confident to create a pull request to fix it. : )
Yes, PR is welcome!

Discussion:
arg = { forceNewWindow: arg }; } if (!uri) { <del> return executor.executeCommand('_files.pickFolderAndOpen', arg.forceNewWindow); </del> <ins> return executor.executeCommand('_files.pickFolderAndOpen', { forceNewWindow: arg.forceNewWindow }); </ins> } const options: IOpenSettings = { forceNewWindow: arg.forceNewWindow, noRecentEntry: arg.noRecentEntry }; uri = URI.revive(uri);
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.33.1 OS Version: Ubuntu 18.04 Steps to Reproduce: It should be noted that this behavior (bug?) was introduced during the latest version. the following structure tree view of these workspaces is correct. When everything is folded it shows like this: the files then , located under app (workspaceFolder). The tree view become like this. open in the editor, click on tab. The tree view become like this. While it should stay the same it was in step 3. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Oh the item is reveald in every root, except just in one. Is that what you are tying to say?
When I click a tab of an opened file, the treeview unfolds the root workspace (outermost) to show the file. Instead, it should show the file in the innermost workspace (the closest one to the file).
I rolled back to an old version. It was still working perfectly well up to version 1.32.3. This bug was introduced from version 1.33.0 onwards.
Why it feature-request if it's a bug?

Discussion:
return; } <del> // Expand all stats in the parent chain let item: ExplorerItem | undefined = this.explorerService.roots.filter(i => isEqualOrParent(resource, i.resource))[0]; </del> <ins> // Expand all stats in the parent chain. let item: ExplorerItem | undefined = this.explorerService.roots.filter(i => isEqualOrParent(resource, i.resource)) // Take the root that is the closest to the stat #72299 .sort((first, second) => second.resource.path.length - first.resource.path.length)[0]; </ins> while (item && item.resource.toString() !== resource.toString()) { await this.tree.expand(item);
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --I've set "explorer.sortOrder": "modified" but the explorer does switch back to default sort order. <!-- Use Help Report Issue to prefill these. --- VSCode Version:1.33.1 OS Version:Windows 10 1809 Steps to Reproduce: I push multiple times the "Refresh explorer" button in explorer on an opened folder the sort order changes between default and modified randomly. It can reproduced by fast clicking the button, the last order will persist. <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
I can not reproduce this. Can you reproduce this with vscode insiders
I can also reproduce it in this insider build. Installed insiders, went to open settings and only have one setting set, the one I mentioned. It seems a fast double click does the trick after a few times. Probably you need more items inside your test folder? My folder (open folder) consist of 15 folders and 195 .ps files in open folder.
I can reproduce now. But only on windows slow machine. Currently I do not have cycles to look into this. A PR that fixes this is welcome. Code pointer Whoever wants to fix this should first 1) Be able to reproduce this consistnently 2) Check out code pointer and the issue is probably timing related how the sortOrder attribute is being read when resolving stats I will not accept some complex fixes. So the PR should be straight forward. Thanks
Good to read you can reproduce. I'm using a Dell Xps 15 -i7-32 GB, faster then Elon Musks Falcon rocket :D
I will look into this.
I found that the sort order would reset every time I opened the settings page again. I would choose modified time as the sort order, refresh the exporer and close the settings. It would be sorted correctly. Then when I would open the settings again, the sort order would reset to the default order, until I refresh the explorer again. This may be a different problem that what you were describing. !
Thanks a lot for fixing this!

Discussion:
} // Stat needs to be resolved first and then revealed <del> const options: IResolveFileOptions = { resolveTo: [resource], resolveMetadata: false }; </del> <ins> const options: IResolveFileOptions = { resolveTo: [resource], resolveMetadata: this.sortOrder === 'modified' }; </ins> const workspaceFolder = this.contextService.getWorkspaceFolder(resource); const rootUri = workspaceFolder ? workspaceFolder.uri : this.roots[0].resource; const root = this.roots.filter(r => r.resource.toString() === rootUri.toString()).pop()!;
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.33.1 OS Version: Windows Steps to Reproduce: the C/C++ extension. It's not a C/C++ extension bug, but it doesn't repro with TypeScript. the code below in a .cpp file, and use Ctrl+Space to invoke completion after "test1". // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text // lots of text lots of text lots of text lots of text lots of text lots of text lots of text lots of text int test1; test1 ! Bug: No vertical scroll bar appears so the text isn't viewable. The vertical scrollbar re-appears the 2nd time completion occurs, but the bug starts reproing again after a Reload Window. This is the expected result: ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
I was able to reproduce this in a file by changing the comment style to . ~I'd like to try fixing this bug and would appreciate any tips of where to look in the codebase.~ I found the issue in . VSCode version: 1.33.1 OS version: macOS Mojave 10.14.4 Extensions: none Note: the scrollbar does appear for me (unlike the original bug report) but the content appears to be truncated the first time I press . !

Discussion:
this.expandSideOrBelow(); show(this.details.element); <del> this.details.render(this.list.getFocusedElements()[0]); </del> <ins> // Set maxHeight before .render() as Fix for #72587 </ins> this.details.element.style.maxHeight = this.maxWidgetHeight + 'px'; <ins> this.details.render(this.list.getFocusedElements()[0]); </ins> // Reset margin-top that was set as Fix for #26416 this.listElement.style.marginTop = '0px';
Change:
"emmet.preferences": { "": true } Why not working?
Does the new modular emmet support this feature?
yes, it should be passed as option:
Looks like it is enabled by default. Since VS Code doesnt change that particular property, we will need to debug why this doesnt work.
I'm having the same problem, using the latest VS Code version: 1.35.0. After adding the setting as mentioned above, Emmet in VS Code still expands to instead of . Hope this could get some love, because small color values are just way more sexy!
I updated the Emmet dependency, and now is enabled by default in the latest Insiders. I still have to add the setting to VS Code if one wants to disable it for whatever reason, so I'll leave this issue open.

Discussion:
"type": "boolean", "default": false, "description": "%emmetPreferencesOutputReverseAttributes%" <ins> }, "css.color.short": { "type": "boolean", "default": true, "description": "%emmetPreferencesCssColorShort%" </ins> } } },

"emmetPreferencesCssMsProperties": "Comma separated CSS properties that get the 'ms' vendor prefix when used in Emmet abbreviation that starts with `-`. Set to empty string to always avoid the 'ms' prefix.", "emmetPreferencesCssFuzzySearchMinScore": "The minimum score (from 0 to 1) that fuzzy-matched abbreviation should achieve. Lower values may produce many false-positive matches, higher values may reduce possible matches.", "emmetOptimizeStylesheetParsing": "When set to `false`, the whole file is parsed to determine if current position is valid for expanding Emmet abbreviations. When set to `true`, only the content around the current position in css/scss/less files is parsed.", <del> "emmetPreferencesOutputReverseAttributes": "If `true`, reverses attribute merging directions when resolving snippets." </del> <ins> "emmetPreferencesOutputReverseAttributes": "If `true`, reverses attribute merging directions when resolving snippets.", "emmetPreferencesCssColorShort": "If `true`, color values like #f will be expanded to #fff instead of #ffffff." </ins> }
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.34.0 OS Version: WindowsNT x64 10.0. I found this issue when I was trying to function in does not work properly when an array include an empty string at the beginning is sent to function. the below to in . ` the Launch VS Code launch configuration from the launch dropdown in the Debug viewlet and press F5. . . Choose Choose an empty string ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
I guess we can just special case and not do the file check to catch accidental errors? Code pointer:
I have an idea. It is to add this code between the below into .
, you want to send a PR for this or can I handle this ?
PR for this issue is created by Sorry, I think that I entrust him. I do not know how to best deal with this situation.
, sent the PR after the comment and while I was waiting for your confirmation and maybe to suggest the best approach.
I wrote it here because I was afraid that my suggestion is wrong. My answer to your question is "Of course! You can handle this.".
I just found the first 'good first issue' and submitted a PR. As it was too small, I won't mind even if it gets rejected or be replaced by your PR. Cheers.
, There is nothing wrong in that but it is good to let others know that you are working on the issue. I will leave this PR to you and close my PR :) , i guess your approach is good but i will leave to take the final decision :)

Discussion:
return Promise.resolve(null); } const current = potentialPaths.shift(); <ins> if (current! === '') { return this._validateShellPaths(label, potentialPaths); } </ins> return this._fileService.exists(URI.file(current!)).then(exists => { if (!exists) { return this._validateShellPaths(label, potentialPaths);
Change:
I'm working with a password protected Git repo in VS Code I open command pallet (F1) and execute a Git command Now most commands like , , etc. correctly asks for a password by showing a UI password prompt. However, certain commands like , etc. do not ask for a password by showing a UI password prompt and fails with error
I see explicitly skips the command. Any particular reason for this?
We skip fetch since it's done automatically behind the scenes, most of the time. We should probably change the check to make sure it is only skipped if the fetch is automatic (vs manually).
I had the same problem. Cannot type my prompt password anymore. Have any workaround without set a credentials? Thanks.

Discussion:
return fatal('Missing pipe'); } <del> if (process.env['VSCODE_GIT_COMMAND'] === 'fetch') { return fatal('Skip fetch commands'); } </del> const output = process.env['VSCODE_GIT_ASKPASS_PIPE'] as string; const socketPath = process.env['VSCODE_GIT_ASKPASS_HANDLE'] as string; const request = argv[2];
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --Steps to Reproduce: rename on a top level file element in explorer view in single folder workspace in developer tools that the div for that file row contains multiple invisible children elements which are input element containers !
I can not reproduce this issue on my machine. How do you end the rename, with Esc, Enter or some other way? Are you doing anything else that is special?
I just press continuously. I can reproduce this easily on linux(ubuntu) and windows. The setup it's just a folder with a single file and I drag and drop the folder on vscode.
Yes I can reproduce now.
This might happen again on tomorrow's vscode insiders. Thus unlocking converstaion so we can open this issue if needed.
You are right I can repro this again.

Discussion:
inputBox.focus(); inputBox.select({ start: 0, end: lastDot > 0 && !stat.isDirectory ? lastDot : value.length }); <del> const done = once(async (success: boolean) => { </del> <ins> const done = once(async (success: boolean, finishEditing: boolean) => { </ins> label.element.style.display = 'none'; const value = inputBox.value; dispose(toDispose); container.removeChild(label.element); <del> // Timeout: once done rendering only then re-render #70902 setTimeout(() => editableData.onFinish(value, success), 0); </del> <ins> if (finishEditing) { // Timeout: once done rendering only then re-render #70902 setTimeout(() => editableData.onFinish(value, success), 0); } </ins> }); let ignoreDisposeAndBlur = true; setTimeout(() => ignoreDisposeAndBlur = false, 100); const blurDisposable = DOM.addDisposableListener(inputBox.inputElement, DOM.EventType.BLUR, () => { if (!ignoreDisposeAndBlur) { <del> done(inputBox.isInputValid()); </del> <ins> done(inputBox.isInputValid(), true); </ins> } });

DOM.addStandardDisposableListener(inputBox.inputElement, DOM.EventType.KEY_DOWN, (e: IKeyboardEvent) => { if (e.equals(KeyCode.Enter)) { if (inputBox.validate()) { <del> done(true); </del> <ins> done(true, true); </ins> } } else if (e.equals(KeyCode.Escape)) { <del> done(false); </del> <ins> done(false, true); </ins> } }), blurDisposable,

]; return toDisposable(() => { <del> if (!ignoreDisposeAndBlur) { blurDisposable.dispose(); done(false); } </del> <ins> blurDisposable.dispose(); done(false, false); </ins> }); }
Change:
Issue Type: <bBug</bThe preview in the minimap slider is wrong when: The minimap is NOT overflown (doesn't need to scroll internally when the editor is scrolled) is (default value) When is set to , the preview is shown as expected. Reproducible without extensions: Yes ! The slider preview ends at the beginning of the block comment, while it should contain a portion of it. VS Code version: Code 1.33.1 (, 2019-04-11T08:27:14.102Z) OS version: Windows_NT x64 10.0. <details<summaryExtensions (15)</summaryExtensionVersion ------ gitstash2.1.0 bracket-pair-colorizer-20.0.28 vscode-eslint1.8.2 todo-tree0.0.129 svg0.1.4 tag-rename0.2.1 vscode-simple-icons1.11.4 dotenv1.0.1 vscode-docker0.6.1 vscode-javascript-booster0.10.2 code-settings-sync3.2.9 markdown-preview-enhanced0.3.13 code-spell-checker1.7.0 language-pde1.3.0 markdown-all-in-one2.2.0 (1 theme extensions excluded) </details<!-- generated by issue reporter --
A new observation: It's not about the state of the window (maximized/restored), it's about weather the minimap is overflown or not (needs to scroll internally when the editor is scrolled). I edited the issue accordingly.
Another observation: has no effect on the issue either. The problem is that the minimap height is not calculated correctly when is , the extra lines that this setting adds are not accordingly to the minimap height, only when it's NOT overflown (i.e. when ).

Discussion:
const computedSliderRatio = (maxMinimapSliderTop) / (scrollHeight - viewportHeight); const sliderTop = (scrollTop * computedSliderRatio); <del> if (minimapLinesFitting >= lineCount) { </del> <ins> let extraLinesAtTheBottom = 0; if (options.scrollBeyondLastLine) { const expectedViewportLineCount = viewportHeight / lineHeight; extraLinesAtTheBottom = expectedViewportLineCount; } if (minimapLinesFitting >= lineCount + extraLinesAtTheBottom) { </ins> // All lines fit in the minimap const startLineNumber = 1; const endLineNumber = lineCount;