jiebi/CodeConvo huggingface dataset:
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --THIS IS NOT A PYTHON EXTENSION ISSUE <!-- Use Help Report Issue to prefill these. --- VSCode Version: 1.33 OS Version: Windows 10 This issue occurs only in vscode insiders, vscode stable works fine. Steps to Reproduce: Download development version of python extension from . Use -to install it, and reload window. Open a folder containing a python file in workspace. Open a python file to activate the extension. Then add configuration in as demonstrated in the gif, and try to re-add another configuration. ! Current behavior: When re-adding the configuration a second time, upon clicking in gif, a red colored "Python" string appears, and selecting any configuration after that does not work. ! Expected behavior: No such "Python" string appears, and configuration is . ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
FYI - The way i see it, this is a regression. I.e breaks in VSC Insiders and works in stable.
Assigning to April to investigate in the next couple of days
It seems that the interpretation of 'insert nothing' has changed. The suggestion is returned with as insertText (see ). It seems that before we would have actually inserted nothing and that now we insert the default, e.g. the label. We always set and now we can argue if the empty snippet string is falsy or not... So, yeah definitely something that changed on our side but unsure if that change is bad or towards more correctness. May I ask why you need a completion item that doesn't do anything expect showing a picker? Why aren't those pick-options presented as individual suggestions?
This is very likely caused by this like of code ( with , bisect master):
I have created to restore the old, questionable, behaviour. Tho would love to get feedback/explainer from if they are willing to model that fits the suggestion world better, e.g instead of using an empty suggestion as trampoline, have many suggestions with quick pick (basically what quick pick is used for today)

Discussion:
sortText: data.e, filterText: data.f, preselect: data.g, <del> insertText: data.h || data.a, </del> <ins> insertText: typeof data.h === 'undefined' ? data.a : data.h, </ins> insertTextRules: data.i, range: data.j || defaultRange, commitCharacters: data.k,
Change:
When I'm tracking inbox I see a lot of issues in foreign languages that doesn't have any reproducible details. The cause might be a combination of the issue opener now knowing English well and thus not reading at all. We should have a *english-please label. When bot sees it it'll close the issue with a message and suggest user to rewrite a new issue using Bing translate. Extra: We can include a translated version of issue reporting guideline. I can do the Chinese version.
You could open a PR for if you like.

Discussion:
comment: "The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.nnHappy Coding!" }, { <ins> type: 'label', name: '*english-please', action: 'close', comment: "This issue is being closed because its description is not in English, that makes it hard for us to work on it. Please open a new issue with an English description. You might find [Bing Translator](https://www.bing.com/translator) useful." }, { </ins> type: 'comment', name: 'duplicate', allowUsers: ['cleidigh', 'usernamehw'],
Change:
1.33.1 macos 10.13.6 Steps to Reproduce: a file named with breadcrumbs open it to how filename in the tab updates but the one in breadcrumbs doesn't Does this issue occur when all extensions are disabled?: Yes

Discussion:
return false; } if (this.element instanceof FileElement && other.element instanceof FileElement) { <del> return isEqual(this.element.uri, other.element.uri); </del> <ins> return isEqual(this.element.uri, other.element.uri, false); </ins> } if (this.element instanceof TreeElement && other.element instanceof TreeElement) { return this.element.id === other.element.id;
Change:
Issue Type: <bBug</bIn VSC, load a small image, zoom in a lot, close the image. Resize the small image by 10 times. In VSC, load the resized image. VS Code version: Code 1.33.1 (, 2019-04-11T08:27:14.102Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </details<details<summaryExtensions (15)</summaryExtensionVersion ------ Bookmarks10.4.3 npm-intellisense1.3.0 vscode-eslint1.8.2 githistory0.4.6 EditorConfig0.13.0 rainbow-csv1.0.0 dotenv1.0.1 vscode-typescript-tslint-plugin1.0.0 vetur0.19.2 github-actions-vscode2.6.1 rust0.6.1 RustyCode0.19.1 vscode-hexdump1.7.2 sort-lines1.8.0 markdown-all-in-one2.3.1 (1 theme extensions excluded) </details<!-- generated by issue reporter --
I would like to take this. I think we can store more information in . In my opinion, we can add the size or add the SHA1 value of the image? Do you have any suggestions?
can i work on this?
i didn't know that already started working on this, both prs work. as far as mine considered, i'm resetting scale to 1.
I'm sorry that I didn't reply to you immediately. Do you reset the scale every time you close the image? It makes the editor cannot remember the scale and offset even the image isn't modified.
yes you are write. let me close mine. :+1:

Discussion:
dispose: () => combinedDisposable(disposables).dispose() }; <del> const cacheKey = descriptor.resource.toString(); </del> <ins> const cacheKey = `${descriptor.resource.toString()}:${descriptor.etag}`; </ins> let ctrlPressed = false; let altPressed = false;
Change:
Issue Type: <bBug</bthe refactoring window over any element with many available refactoring options (e.g.: a widget in Flutter) tab selection won't move BUT if you hit enter it will choose an option other than the highlighted one VS Code version: Code 1.33.1 (, 2019-04-11T08:27:14.102Z) OS version: WindowsNT x64 10.0. <details<summarySystem Info</summary </detailsExtensions disabled <!-- generated by issue reporter --
Assigning because this only happens when using custom title bars. Repo Windows with custom title bar enabled the ts file: code actions and press tab once or twice, then enter The second or third code action ends up being applied even though the visible selection never changes

Discussion:
this.menuDisposables = []; <ins> addDisposableListener(menuElement, EventType.KEY_DOWN, (e) => { const event = new StandardKeyboardEvent(e); // Stop tab navigation of menus if (event.equals(KeyCode.Tab)) { EventHelper.stop(e, true); } }); </ins> if (options.enableMnemonics) { this.menuDisposables.push(addDisposableListener(menuElement, EventType.KEY_DOWN, (e) => { const key = e.key.toLocaleLowerCase();
Change:
<!-- Please search existing issues to avoid creating duplicates. --<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: --<!-- Use Help Report Issue to prefill these. --- VSCode Version: master Ran into this issue while preparing Monaco release in vscode repo open monaco-editor test page switch monaco-editor-core source to not found error in Dev Console is registered through which is only read by workbench We can add the singleton services to standalone but a simple standalone service can also fix the problem <img width="576" alt="image" src="https://user-" let me know if you have time for a quick fix, if not I can push my change to branch first to unblock publishing.
FYI is also made to ensure work at this moment. Unluckily our intermediate typescript files for tree shaking don't apply to yet. The commit will be cherry-picked to master later.
There is no need for , the default implementation is good enough and just needs to be brought into the editor land.
please review
can you clarify the steps for this? I'm not sure where the monaco-editor test page is
I can take this one

Discussion:
) { } } <del> class CodeLensCache implements ICodeLensCache { </del> <ins> export class CodeLensCache implements ICodeLensCache { </ins> _serviceBrand: any;

import { IAccessibilityService } from 'vs/platform/accessibility/common/accessibility'; import { BrowserAccessibilityService } from 'vs/platform/accessibility/common/accessibilityService'; import { ILayoutService } from 'vs/platform/layout/browser/layoutService'; <ins> import { ICodeLensCache, CodeLensCache } from 'vs/editor/contrib/codelens/codeLensCache'; </ins> export interface IEditorOverrideServices { [index: string]: any;

export const suggestMemoryService = define(ISuggestMemoryService, (o) => new SuggestMemoryService(storageService.get(o), configurationService.get(o))); <ins> export const codeLensCacheService = define(ICodeLensCache, (o) => new CodeLensCache(storageService.get(o))); </ins> } export class DynamicStandaloneServices extends Disposable {
Change:
Steps to Repro: Search for an extension pack in extensions view (Say PHP Extension Pack) Open PHP Extension Pack in the editor Go to Extensions Pack tab Click on any extension Fails to open Close to open the editor Does not close Not sure how it happened but I had the extension pack open (as extension editor) and after a while (being on twitter) I wanted to close the editor and I saw error notifications. These are the minified stacktraces from the log the build was
Not able to repro it. Also followed the code and I do not see a path that has no extension in the input. Do you remember any steps you followed during this? Is it possible to guess what could be happening in editor land from the above stack trace?
are you using editors with preview mode, e.g. do they appear italic? Hard to say what the execution flow here is to be honest. Looks like a normal editor opening but failing to get the resource for the editor, which is used to associate the editor in the editor tabs model.
But this is happening while is trying to close the currently opened extension editor.
I don't use tabs, so I am not sure what the model then is... Yes, closing it was. I had the extension editor open, also installed the extension, then waited, and then tried to close the editor. So maybe some cleanup logic hit me or installing the extension made a different...
The preview feature works with tabs enabled or disabled. The fact that an editor is opened can be explained if you closed an editor and the next one below that editor was the extension editor. Closing an editor always means we open the previous editor unless it is the last editor. I suggest you try to figure out how it is possible that is even though it is not typed as such.
Ok
What are the verification steps for this?
Steps to repro are in the description

Discussion:
} } <del> export class ExtensionsTree extends WorkbenchAsyncDataTree<IExtensionData, any> { </del> <ins> export class ExtensionsTree extends WorkbenchAsyncDataTree<IExtensionData, IExtensionData> { </ins> constructor( input: IExtensionData,

this.setInput(input); this.disposables.push(this.onDidChangeSelection(event => { <del> extensionsWorkdbenchService.open(event.elements[0], event.browserEvent instanceof MouseEvent && (event.browserEvent.ctrlKey || event.browserEvent.metaKey || event.browserEvent.altKey)); </del> <ins> if (event.browserEvent && event.browserEvent instanceof KeyboardEvent) { extensionsWorkdbenchService.open(event.elements[0].extension, false); } </ins> })); } }  No newline at end of file
Change:
Configure search view to show in panel Open Search panel Reload window Search panel is not shown, instead debug panel is shown.

Discussion:
1 )); <ins> Registry.as<PanelRegistry>(PanelExtensions.Panels).registerPanel(new PanelDescriptor( SearchPanel, PANEL_ID, nls.localize('name', "Search"), 'search', 10 )); </ins> class RegisterSearchViewContribution implements IWorkbenchContribution { constructor(
Change:
This is because unlike the other algorithm for path or file name, we actually iterate over the registered languages in order and not in reverse order. As such, an extension cannot override the language mode when providing a pattern that is matched by an built in extension. I would argue that we should do the same trick and reverse the order, so that extensions have a chance. //cc
via

Discussion:
} if (firstLine.length > 0) { <del> for (const association of registeredAssociations) { </del> <ins> // We want to prioritize associations based on the order they are registered so that the last registered // association wins over all other. This is for https://github.com/Microsoft/vscode/issues/20074 for (let i = registeredAssociations.length - 1; i >= 0; i--) { const association = registeredAssociations[i]; </ins> if (!association.firstline) { continue; }

import { guessMimeTypes, registerTextMime, suggestFilename } from 'vs/base/common/mime'; suite('Mime', () => { test('Dynamically Register Text Mime', () => { let guess = guessMimeTypes('foo.monaco'); assert.deepEqual(guess, ['application/unknown']);

registerTextMime({ id: 'docker', filepattern: 'dockerfile*', mime: 'text/looser' }); guess = guessMimeTypes('dockerfile'); assert.deepEqual(guess, ['text/winner', 'text/plain']); <ins> registerTextMime({ id: 'azure-looser', mime: 'text/azure-looser', firstline: /azure/ }); registerTextMime({ id: 'azure-winner', mime: 'text/azure-winner', firstline: /azure/ }); guess = guessMimeTypes('azure', 'azure'); assert.deepEqual(guess, ['text/azure-winner', 'text/plain']); </ins> }); test('Specificity priority 1', () => {
Change:
Search view, context menu on empty area -no context menu In this case we should still offer the option to move the search view to the panel. Since it is a "global" action, and it only appears when there are results in the search view
, can i take a look at this or are you working on this ? :)
You can take a look
, I understood how "Toggle Search View Position" works both in and functionality. So when we right click on the search result then only the option comes up , so it is bound to search result. So what is the approach we should take to fix this ? We need to move this whole functionality to somewhere else rite ? ( Like some button next "Refresh","Clear All Search Results".... ? ) Please suggest me the way forward :)
do you know how to add a context menu to an empty tree?
gets fired for every place in the tree, including empty items. Here's an example how I use this in the explorer
I think we should use that for this command, rather than
, I tried doing this and here is what I found. There is already trigger in If we remove this check then it will work on empty tree also ( ) In case of no results , we are showing custom message and here the tree is no longer in the view , so right clicking there would not work. ( ) Ideally if we remove that mentioned in case 2 , then what suggested is already there but as the tree itself is not valid in case of "No Search Results" because of showing some custom message described above. Please let me know the way forward to fix this :)
Good analysis. Can we change it to keep the tree in the DOM when that no results message is shown? Not sure how the tree is sized in css but it would have to be vertically flexible. Also, when I am right clicking on an empty tree, I should not see context menu items that are not valid without a row, like copy, dismiss, etc.

Discussion:
} private onContextMenu(e: ITreeContextMenuEvent<RenderableMatch | null>): void { <del> if (!e.element) { return; } </del> if (!this.contextMenu) { this.contextMenu = this._register(this.menuService.createMenu(MenuId.SearchContext, this.contextKeyService)); }

// Indicate as status to ARIA aria.status(message); <del> dom.hide(this.resultsElement); </del> const messageEl = this.clearMessage(); const p = dom.append(messageEl, $('p', undefined, message));

if (this.contextService.getWorkbenchState() === WorkbenchState.EMPTY) { this.showSearchWithoutFolderMessage(); } <ins> this.reLayout(); </ins> } else { this.viewModel.searchResult.toggleHighlights(this.isVisible()); // show highlights
Change:
This is for . Steps to reproduce: the extension (of version 1.3.2 or up). if necessary. a new document with the following content: the language to “Graphviz (dot)”. “Graphviz: Open Preview to the Side” command. the text in the preview. Expect to be opened in a browser window.

Discussion:
scrollTarget.scrollIntoView(); } } else { <del> host.postMessage('did-click-link', node.href); </del> <ins> host.postMessage('did-click-link', node.href.baseVal || node.href); </ins> } event.preventDefault(); break;
Change:
Issue Type: <bFeature Request</bIt would be sweat to show the current branch name near the commit message box. Many times I committed the changes to the wrong branch (I know we can see it in the status bar. I just forgot to take a look) ! VS Code version: Code 1.33.1 (, 2019-04-11T08:27:14.102Z) OS version: Windows_NT x64 10.0. <!-- generated by issue reporter --
How about we just add in the placeholder, instead? Care to submit PR?
Glad to do that. One concern is it seems not to be enough space for the branch name in a normal width input box. It is the max width that prevents the extension logo from showing up in the extension list. Would you mind omitting "press"?
Yeah let's remove .
How does the current implementation for this work? I couldn't find any documentation of localize used this way.
Here is it:
I think the solution of breaks localization of the placeholder. I comments to his PR and created a new one.

Discussion:
const root = Uri.file(repository.root); this._sourceControl = scm.createSourceControl('git', 'Git', root); <del> this._sourceControl.inputBox.placeholder = localize('commitMessage', "Message (press {0} to commit)"); </del> <ins> this.onDidRunGitStatus(() => { const headLabel = this.headLabel; let placeholder: string; if (headLabel !== '') { // '{0}' will be replaced by the corresponding key-command later in the process, which is why it needs to stay. placeholder = localize('commitMessageWithHeadLabel', "Message ({0} to commit to {1})", "{0}", this.headLabel); } else { placeholder = localize('commitMessage', "Message ({0} to commit)"); } this._sourceControl.inputBox.placeholder = placeholder; }); </ins> this._sourceControl.acceptInputCommand = { command: 'git.commitWithInput', title: localize('commit', "Commit"), arguments: [this._sourceControl] }; this._sourceControl.quickDiffProvider = this; this._sourceControl.inputBox.validateInput = this.validateInput.bind(this);
Change:
DEBUG selectBox, when hover over, can't see title. Checked with latest insider build, has the same issue. While in version ! There is title ! May be caused be
do you have time to look into this?
do you see this for other dropdowns as well. For example the terminal dropdown, or the output channel name dropdown?
Terminal dropdown has no title either.
Ok, so it is a general select box issue. Let's see if has time to look into this
Absolutely. I've been a bit awol... Will look at this tomorrow.
This issue has been closed automatically because it needs more information and has not had recent activity. See also our guidelines. Happy Coding!

Discussion:
index: e.target.selectedIndex, selected: e.target.value }); <ins> if (!!this.options[this.selected] && !!this.options[this.selected].text) { this.selectElement.title = this.options[this.selected].text; } </ins> })); // Have to implement both keyboard and mouse controllers to handle disabled options

} this.selectElement.selectedIndex = this.selected; <ins> if (!!this.options[this.selected] && !!this.options[this.selected].text) { this.selectElement.title = this.options[this.selected].text; } </ins> } public setAriaLabel(label: string): void {

let listBackground = this.styles.selectListBackground ? this.styles.selectListBackground.toString() : background; this.selectDropDownListContainer.style.backgroundColor = listBackground; this.selectionDetailsPane.style.backgroundColor = listBackground; <del> const optionsBorder = this.styles.focusBorder ? this.styles.focusBorder.toString() : null; </del> <ins> const optionsBorder = this.styles.focusBorder ? this.styles.focusBorder.toString() : ''; </ins> this.selectDropDownContainer.style.outlineColor = optionsBorder; this.selectDropDownContainer.style.outlineOffset = '-1px'; }

this._onDidSelect.fire({ index: this.selectElement.selectedIndex, selected: this.options[this.selected].text }); <ins> if (!!this.options[this.selected] && !!this.options[this.selected].text) { this.selectElement.title = this.options[this.selected].text; } </ins> } this.hideSelectDropDown(true);

index: this.selectElement.selectedIndex, selected: this.options[this.selected].text }); <ins> if (!!this.options[this.selected] && !!this.options[this.selected].text) { this.selectElement.title = this.options[this.selected].text; } </ins> } this.hideSelectDropDown(true);
Change:
Version: 1.34.0 (user setup) Commit: Date: 2019-05-15T21:59:37.030Z Electron: 3.1.8 Chrome: 66.0.3359.181 10.2.0 V8: 6.6.346.32 OS: Windows_NT x64 10.0. Steps to Reproduce: there is no terminal opened, quickly press ctrl+` twice pop up(maybe at the back of the vs code window). Whatever which button I choose, vs code window would tell me there was a crash and need to restart window ! <!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes
Does this happen consistently for you? I can't reproduce it. This check is meant to prevent this exception from occurring: Unless the process crashes or something?
Yes It crashes every time on my computer. Maybe you didn't press keyboard quick enough? XD I looks like terminal cannot initialize if the intergrated terminal is not visible. I think I can send a screen record later
I had failed to record a meaningful capture.... Just simply press the keyboard as quick as possible
Video of making it crash with extensions enabled or disabled: Logs from these sessions:
I can confirm this is with user setup version only on my machine. I installed the system installer and removed the user setup. I cannot duplicate this issue anymore.
thanks for the video
could you enable trace logging (F1 "log level" "trace"), then repro the issue again and check the logs if there is a entry at the end? These will be located in your user data directory, something like this: You might also be able to see the log if you open dev tools (via help menu) and open the console there, which would be easier if it gets there before the crash happens.
Related
Did the trace and find this entry and the end of the
perfect! You found the bug
Can add an extra defensive check in too
I can't reproduce the original issue using 1.34 user install so I'm not sure how to verify. Any repro/verification steps?
Verify via code review, I could not reproduce the issue either.

Discussion:
if (this._isDisposed) { return; } <ins> if (typeof cols !== 'number' || typeof rows !== 'number' || isNaN(cols) || isNaN(rows)) { return; } </ins> // Ensure that cols and rows are always >= 1, this prevents a native // exception in winpty. if (this._ptyProcess) {
Change:
Steps to Reproduce: a change to a binary resource (e.g. PNG) it :bug: changes view looses focus
As always, this is invoking with . That seems to have broken.
This is being hit:
Up for grab.
looks like this came in a long time ago via I do not understand why the editor would need to give itself . Typically that should not be needed as the container of editors will call as needed.
Honestly, I do not remember why the change is but I think the change is for side by side settings editor. Settings editor is no longer using . So this line can be removed.

Discussion:
this.detailsEditor.setInput(detailsInput, null, token), this.masterEditor.setInput(masterInput, options, token)] ); <del> return this.focus(); </del> } updateStyles(): void {