jiebi/CodeConvo huggingface dataset:
Change:
is a very popular textmate color scheme optimised for es6 / es7 / JSX. I imported the and made the changes to the file mentioned here , however the results are quite different to the same textmate theme in sublime. ! ! Its a beautiful theme used by the likes of and I would love to see equivalent support for this theme in VSCode.
We only have a small set of themes that are included with vscode, most themes are typically put on the marketplace. Two developers have put ports of OceanicNext up so you can try them out:
Why is this issue being closed? VSCode is supposed to support textmate themes. Here is a textmate theme that is not working. There are clearly gaps in VSCode's theme support, for example the in the top import statement is not colored. Shouldn't the same textmate theme appear consistently across various editors?
You're right, I interpreted this as there's no officially supported theme but there are indeed a bunch of issues preventing full parity with the other editors. I'll leave this closed but created a bunch of issues for the main problems causing this. Thanks for the report!
same here: ! !

Discussion:
// regexes to check for trivial glob patterns that just check for String#endsWith const T1 = /^**/*.[w.-]+$/; 						   									// **/*.something const T2 = /^**/([w.-]+)/?$/; 							   							// **/something <del> const T3 = /^{**/[*.]?[w.-]+/?(,**/[*.]?[w.-]+/?)*}$/; 						// {**/*.something,**/*.else} or {**/package.json,**/project.json} const T3_2 = /^{**/[*.]?[w.-]+(/(**)?)?(,**/[*.]?[w.-]+(/(**)?)?)*}$/; 	// Like T3, with optional trailing /** </del> <ins> const T3 = /^{**/*?[w.-]+/?(,**/*?[w.-]+/?)*}$/; 						// {**/*.something,**/*.else} or {**/package.json,**/project.json} const T3_2 = /^{**/*?[w.-]+(/(**)?)?(,**/*?[w.-]+(/(**)?)?)*}$/; 	// Like T3, with optional trailing /** </ins> const T4 = /^**((/[w.-]+)+)/?$/; 						   								// **/something/else const T5 = /^([w.-]+(/[w.-]+)*)/?$/; 						   							// something/else
Change:
We are working on the EditorConfig plugin and we have issues regarding . Users don't have to specify values for let's say . Let's take the following And my VSCode settings file looks like this If I open , the style should be set to and the indent size to . If I open , it should set the to and take the global setting (which is ) so it should be calculated by VS Code itself. At the moment this is not possible. Because you have to overwrite the entire object which prevents auto-calculating the indent size. I think you are in charge for something like this :)?
These are my findings. Please let me know if I'm wrong :). So internally VS Code has some decision check wether it should recalculate the settings for a file in the text editor. Based on some debugging, it looks like the decision looks like this. Is the options object still referring to the initial options object? -YES: No plugin changed the settings so recalculate them based on the user settings -NO: Do nothing as someone altered the object Because when I only change one value , it still takes my global VS Code settings because (in my opinion) the object is still referring to the initial options object and thus is not changed. This is how this issue can be resolved. Values passed in as should be calculated by VS Code (based upon the user settings). If my global settings is set to , VS Code will determine the tab size for me based on the current file being opened. Same goes for .
you can get the right GitHub code coloring for files by using the file type, see?
Thanks :)
This issue is thoroughly discussed here
It looks like I found a solution in It looks like the interface is defined like Which makes it not possible to provide as value for either one of the properties. But actually, it is perfectly valid to provide as VS Code will then auto calculate the value for that property. So I guess a solution for this would be to update that interface.
For the record, you're referring to . Would Microsoft be willing to update this interface or is there a good reason they don't use union types for these settings?
Did a PR I guess they will accept it as I don't see any reason to not allow strings.
Thank you for the PR! :+1: I went a bit further to try to clarify things:

Discussion:
*  - the rendering width of a tab character; *  - the number of spaces to insert when [insertSpaces](#TextEditorOptions.insertSpaces) is true. */ <del> tabSize: number; </del> <ins> tabSize: number | string; </ins> /** * When pressing Tab insert [n](#TextEditorOptions.tabSize) spaces. */ <del> insertSpaces: boolean; </del> <ins> insertSpaces: boolean | string; </ins> } /**
Change:
! !
Good catch
Same for breakpoints. Looks like Visual Studio also doesn't grow the breakpoint and folding icons with the font size. Users can always use the Zoom feature, which zooms everything.
I removed the code that grows the folding icon gutter by font size to avoid the clipping that can bee seen in the second screenshot. We can add that again if we decide to grow the icons along with the font size
I can fix this by converting the icon sizing to ems, but it could possibly affect the pixel-perfect lines of the icon; I wouldn't be able to test it before the freeze (because my Retina screen lies to me about how other screens will alias it. I would need my desktop). Let's hold off until March on this one just to be safe and not compromise the icon.
Makes sense. As the breakpoints also don't grow/shrink I think we are consistent.
This is fixed now I guess. !
this actually happens when you change , which is different from

Discussion:
*--------------------------------------------------------------------------------------------*/ .monaco-editor .margin-view-overlays .folding { <del> margin-left: 5px; </del> cursor: pointer; background-repeat: no-repeat; background-origin: border-box; <del> background-position: 3px center; background-size: 15px; </del> <ins> background-position: calc(50% + 2px) center; background-size: auto calc(100% - 3px); </ins> opacity: 0; transition: opacity 0.5s; }

display: inline; line-height: 1em; cursor: pointer; <del> } </del> <ins> } </ins>  No newline at end of file
Change:
I have editor.autoClosingBrackets set to true but it seems it works stricly with brackets. I guess autoclosing single/double quotes is not implemented yet? If not, please do it. I think it is a common feature for every editor.
What language is missing them?
Closing after a number of days without a reply.

Discussion:
["{", "}"], ["[", "]"], ["(", ")"] <ins> ], "autoClosingPairs": [ ["{", "}"], ["[", "]"], ["(", ")"], [""", """], ["'", "'"] ], "surroundingPairs": [ ["{", "}"], ["[", "]"], ["(", ")"], [""", """], ["'", "'"] </ins> ] }  No newline at end of file

} /** <del> * Interface used to support insertion of matching characters like brackets and qoutes. </del> <ins> * Interface used to support insertion of matching characters like brackets and quotes. </ins> */ export interface IAutoClosingPair { open:string;

import {readFile} from 'vs/base/node/pfs'; import {IRichEditConfiguration} from 'vs/editor/common/modes/supports/richEditSupport'; import {IModeService} from 'vs/editor/common/services/modeService'; <ins> import {IAutoClosingPair} from 'vs/editor/common/modes'; </ins> type CharacterPair = [string, string];

interface ILanguageConfiguration { comments?: ICommentRule; brackets?: CharacterPair[]; <ins> autoClosingPairs?: CharacterPair[]; surroundingPairs?: CharacterPair[]; </ins> } export class LanguageConfigurationFileHandler {

if (configuration.brackets) { richEditConfig.brackets = configuration.brackets; <ins> } if (configuration.autoClosingPairs) { richEditConfig.__characterPairSupport = { autoClosingPairs: this._mapCharacterPairs(configuration.autoClosingPairs) }; } else if (configuration.brackets) { </ins> richEditConfig.__characterPairSupport = { <del> autoClosingPairs: configuration.brackets.map(pair => { let [open, close] = pair; return { open: open, close: close }; }) </del> <ins> autoClosingPairs: this._mapCharacterPairs(configuration.brackets) </ins> }; } <ins> if (richEditConfig.__characterPairSupport && configuration.surroundingPairs) { richEditConfig.__characterPairSupport.surroundingPairs = this._mapCharacterPairs(configuration.surroundingPairs); } </ins> this._modeService.registerRichEditSupport(modeId, richEditConfig); } <ins> private _mapCharacterPairs(pairs:CharacterPair[]): IAutoClosingPair[] { return pairs.map(pair => { let [open, close] = pair; return { open: open, close: close }; }); } </ins> }
Change:
By default, there appears to be no syntax highlighting for .xhtml files.
is this available in the current release? There was an update recently but it doesn't seem to include this (guessing it'll be in the next update?).
it's in the insiders build, not yet in stable.

Discussion:
"contributes": { "languages": [{ "id": "html", <del> "extensions": [ ".html", ".htm", ".shtml", ".mdoc", ".jsp", ".asp", ".aspx", ".jshtm" ], </del> <ins> "extensions": [ ".html", ".htm", ".shtml", ".xhtml", ".mdoc", ".jsp", ".asp", ".aspx", ".jshtm" ], </ins> "aliases": [ "HTML", "htm", "html", "xhtml" ], "mimetypes": ["text/html", "text/x-jshtm", "text/template", "text/ng-template"] }],
Change:
typing gives intellisense for colors, not for text-decoration. typing non will not show 'none' in Intellisense. The problem occurs in any css, less and scss file in any place, with any selector. Problem also occurs without extensions. I am running Windows 7 32bit with all updates possible. ! !
Colours are valid values for text-decoration, as it is a shorthand which includes text-decoration-color

Discussion:
*  Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ // file generated from css-schema.xml using css-exclude_generate_browserjs.js <del> define(["require", "exports"], function(require, exports) { </del> <ins> define(["require", "exports"], function(require, exports) { </ins> exports.data ={ "css": {

"name": "overline" }, { <ins> "name": "none", "desc": "Produces no text decoration." }, { </ins> "name": "solid" }, {

}, { "name": "none", <del> "desc": "Neither produces nor inhibits text decoration." </del> <ins> "desc": "Produces no text decoration." </ins> }, { "name": "overline"

"name": "double" }, { <del> "name": "none", "desc": "Produces no line." </del> <ins> "name": "none" </ins> }, { "name": "solid"
Change:
from If you select "Show Installed Extensions" you won't see the update button but if you select "Install Extension" and search for an already installed extension that has a newer version available, the update button is visible. Is this part of this bug or is this something else? Install Extension: ! Show Installed Extensions: !

Discussion:
public entries: IExtensionEntry[]; constructor( <del> private extensions: IExtension[], </del> <ins> private installedExtensions: IExtension[], private outdatedExtensions: IExtension[], </ins> @IInstantiationService instantiationService: IInstantiationService ) { this.renderer = instantiationService.createInstance(Renderer);

} public set input(input: string) { <del> this.entries = this.extensions </del> <ins> this.entries = this.installedExtensions </ins> .map(extension => ({ extension, highlights: getHighlights(input.trim(), extension) })) .filter(({ highlights }) => !!highlights) <del> .map(({ extension, highlights }) => ({ extension, highlights, state: ExtensionState.Installed })) </del> <ins> .map(({ extension, highlights }: { extension: IExtension, highlights: IHighlights }) => { const [outdatedExt] = this.outdatedExtensions.filter(outdatedExt => extensionEquals(outdatedExt, extension)); return { extension, highlights: getHighlights(input.trim(), extension), state: outdatedExt ? ExtensionState.Outdated : ExtensionState.Installed }; }) </ins> .sort(extensionEntryCompare); } }

constructor( @IInstantiationService private instantiationService: IInstantiationService, <del> @IExtensionManagementService private extensionManagementService: IExtensionManagementService </del> <ins> @IExtensionManagementService private extensionManagementService: IExtensionManagementService, @IExtensionGalleryService private galleryService: IExtensionGalleryService </ins> ) { super(); this.modelPromise = null;

getResults(input: string): TPromise<IModel<IExtensionEntry>> { if (!this.modelPromise) { <del> this.modelPromise = this.extensionManagementService.getInstalled() .then(extensions => this.instantiationService.createInstance(LocalExtensionsModel, extensions)); </del> <ins> this.modelPromise = TPromise.join<any>([this.extensionManagementService.getInstalled(), getOutdatedExtensions(this.extensionManagementService, this.galleryService)]) .then(result => this.instantiationService.createInstance(LocalExtensionsModel, result[0], result[1])); </ins> } return this.modelPromise.then(model => {
Change:
VSCode Version: 0.10.12-alpha OS Version: Linux Steps to Reproduce: in write to the (see VSCODENLSCONFIG) environment variable will not reach the renderer process
you reviewed. Can you please verify.

Discussion:
getUserEnvironment() .then(userEnv => { assign(process.env, userEnv); <ins> // Make sure the NLS Config travels to the rendered process // See also https://github.com/Microsoft/vscode/issues/4558 userEnv['VSCODE_NLS_CONFIG'] = process.env['VSCODE_NLS_CONFIG']; </ins> return setupIPC() .then(ipcServer => main(ipcServer, userEnv)); })
Change:
Issue Id: <-e6e6-b9ac-f191-</b<br /<br /Versions <br /- <br /- <br /- <br /- <br /- <br /Stack <br /TypeError: Cannot read property 'dispose' of undefined<br /<br /<br /<br /at Array.forEach (native)<br /<br /at Array.forEach (native)<br /<br /<br /<br /<br /
Just reproduced locally after closing the "?" help quick open: Cannot read property 'dispose' of undefined: TypeError: Cannot read property 'dispose' of undefined at Renderer.disposeTemplate () at Renderer.disposeTemplate () at at Array.forEach (native) at at Array.forEach (native) at RowCache.garbageCollect () at TreeView.onSetInput () at TreeView.onModelEvents () at Array.<anonymous()WorkbenchShell.onUnexpectedError @ //Users/bpasero/Development/monaco/out/vs/workbench/electron- [uncaught exception]: TypeError: Cannot read property 'firstChild' of nullonError @ TypeError: Cannot read property 'firstChild' of null at EntryItemRenderer.LegacyRenderer.renderElement () at Renderer.renderElement () at Renderer.renderElement () at () at ViewItem.insertInDOM () at TreeView.insertItemInDOM () at () at at () at ()onError @ Uncaught TypeError: Cannot read property 'firstChild' of null //Users/bpasero/Development/monaco/out/vs/workbench/electron- Cannot read property 'dispose' of undefined: TypeError: Cannot read property 'dispose' of undefined at Renderer.disposeTemplate () at Renderer.disposeTemplate () at at Array.forEach (native) at at Array.forEach (native) at RowCache.garbageCollect () at TreeView.onSetInput () at TreeView.onModelEvents () at Array.<anonymous()
This is bad as it can bring quick open into a broken state. To reproduce open quick open, type ? and repeat: !
Closing as per commit

Discussion:
public disposeTemplate(templateId: string, templateData: any): void { if (templateId === templateEntryItem) { this.entryItemRenderer.disposeTemplate(null, templateId, templateData); <ins> } else { const data = templateData as IQuickOpenEntryGroupTemplateData; data.actionBar.dispose(); data.actionBar = null; data.container = null; data.description.dispose(); data.description = null; data.detail.dispose(); data.detail = null; data.group = null; data.icon = null; data.label.dispose(); data.label = null; data.prefix = null; </ins> } <del> const data = templateData as IQuickOpenEntryGroupTemplateData; data.actionBar.dispose(); data.actionBar = null; data.container = null; data.description.dispose(); data.description = null; data.detail.dispose(); data.detail = null; data.group = null; data.icon = null; data.label.dispose(); data.label = null; data.prefix = null; </del> } }
Change:
VSCode Version: 0.10.11 OS Version: OSX 10.10 Is it possible to use the .es6 file extension, and still have the editor enable intellisense appropriately? For instance, I have some projects that use the ".es6" extension, and keywords like "module" have red lines under them, and the file isn't processed in the same way that a .js file is. Renaming the file to .js fixes the issues (but isn't always an option, due to internal project reasons).
In the latest you can associate file extensions to languages and the association is persisted, pls see:

Discussion:
addToHistory(input: string): void { this._inlineChatWidget.addToHistory(input); this._inlineChatWidget.saveState(); <ins> this._inlineChatWidget.value = input; this._inlineChatWidget.selectAll(true); </ins> } setValue(value?: string) { this._inlineChatWidget.value = value ?? '';
Change:
OS Version: I see it both on el capitan and linux Steps to Reproduce: vscode - you get a prompt if you want to save, click 'Save' name the file and sav it inside the repo changes are visible in repository - vscode is still open, and there is no file that I just saved. I still see the untitiled file open and there is no way for me to save it's content
Looks good with latest build

Discussion:
} public showSaveDialog(options: Electron.Dialog.SaveDialogOptions, callback?: (fileName: string) => void): string { <del> return dialog.showSaveDialog(this.win, options, callback); </del> <ins> if (callback) { return dialog.showSaveDialog(this.win, options, callback); } return dialog.showSaveDialog(this.win, options); </ins> } public setFullScreen(fullscreen: boolean): void {
Change:
VSCode Version: 1.0.0-alpha OS Version: Windows10 Mouse hove on the truncated path in the command pallete is not displaying full path. User can't dynamically change the command pallete window size so it is hard to identify file path for manual verification. !

Discussion:
// Description data.description.set(entry.getDescription(), descriptionHighlights || []); <ins> data.description.element.title = entry.getDescription(); </ins> } }

run(entry: QuickOpenEntry, mode: Mode, context: IContext): boolean { return entry.run(mode, context); } <del> } </del>  No newline at end of file <ins> } </ins>
Change:
VSCode Version: 1.0.0 OS Version: Fedora 23 x86_64 Steps to Reproduce: VSCode Puppet Extension puppet manifest (.pp file) detects it as a Ruby file type The included Ruby language extension has the puppet extension (.pp) in its extensions list and overrides any installed Puppet extension causing Puppet manifest files to always be detected as Ruby files unless a manual override is put into the User Configuration.
// CC
Any progress with this?
This was fixed back in the July/August release. I should have closed it then, sorry. See PR

Discussion:
"contributes": { "languages": [{ "id": "ruby", <del> "extensions": [ ".rb", ".rbx", ".rjs", ".gemspec", ".pp", ".rake", ".ru" ], </del> <ins> "extensions": [ ".rb", ".rbx", ".rjs", ".gemspec", ".rake", ".ru" ], </ins> "filenames": [ "rakefile", "gemfile", "guardfile" ], "aliases": [ "Ruby", "rb" ], "configuration": "./ruby.configuration.json"
Change:
VSCode Version: 1.1.0-alpha OS Version: Mac Steps to Reproduce: Regarding test plan Just found this very small bug (not an urgent one—ok to delay if necessary). just a package name in with no leading quotation mark (so it autocompletes the quotes for you) try adding a package with a leading quotation mark. Note that in the first case a comma is not , but in the second case a comma is . Not a huge deal, but consistency would be nice. Preferably, if it knows that it's on the last line of properties (i.e. the next line is a closing brace), then it would not insert a comma. But if it's in the middle of the list (i.e. the next line is another property in the JSON), then it would add a comma.
I always get a comma: Code assist after : Completes to Code assist after : Completes to Code assist inside :Completes to Code assist after : Completes to Code assist after : Completes to Code assist inside :Completes to Let me know if you saw another issue.
yes, that's what I was seeing. Thanks for checking!

Discussion:
*--------------------------------------------------------------------------------------------*/ 'use strict'; <del> import {Location, getLocation, createScanner, SyntaxKind} from 'jsonc-parser'; </del> <ins> import {Location, getLocation, createScanner, SyntaxKind, ScanError} from 'jsonc-parser'; </ins> import {basename} from 'path'; import {BowerJSONContribution} from './bowerJSONContribution'; import {PackageJSONContribution} from './packageJSONContribution';

if (location.isAtPropertyKey) { let addValue = !location.previousNode || !location.previousNode.columnOffset; <del> let scanner = createScanner(document.getText(), true); scanner.setPosition(offset); scanner.scan(); let isLast = scanner.getToken() === SyntaxKind.CloseBraceToken || scanner.getToken() === SyntaxKind.EOF; </del> <ins> let isLast = this.isLast(document, position); </ins> collectPromise = this.jsonContribution.collectPropertySuggestions(fileName, location, currentWord, addValue, isLast, collector); } else { if (location.path.length === 0) {

} return text.substring(i+1, position.character); } <ins> private isLast(document: TextDocument, position: Position):boolean { let scanner = createScanner(document.getText(), true); scanner.setPosition(document.offsetAt(position)); let nextToken = scanner.scan(); if (nextToken === SyntaxKind.StringLiteral && scanner.getTokenError() === ScanError.UnexpectedEndOfString) { nextToken= scanner.scan(); } return nextToken === SyntaxKind.CloseBraceToken || nextToken === SyntaxKind.EOF; } </ins> }  No newline at end of file
Change:
VSCode Version:1.1.0-alpha OS Version: Windows 10 Steps to Reproduce: a markdown file and add a code block. a function, string, etc that has an opening bracket or string Regardless of the language specified for the code block, bracket completion is not supported.
Verified that this still does not work with the new markdown extension.
Fixed via
cool! would it not make more sense to push your changes directly to master given that we pushed vscode-markdown into VSCode?
I'll send out my PR real quick (I'd like to have the push privilege after my onboard).

Discussion:
"(", ")" ] <ins> ], "autoClosingPairs": [ [ "{", "}" ], [ "[", "]" ], [ "(", ")" ] </ins> ] }  No newline at end of file

</dict> <dict> <key>include</key> <ins> <string>#fenced_code_block_php</string> </dict> <dict> <key>include</key> </ins> <string>#fenced_code_block_sql</string> </dict> <dict>

</dict> </array> </dict> <ins> <key>fenced_code_block_php</key> <dict> <key>begin</key> <string>(^|G)s*([`~]{3,})s*(php|php3|php4|php5|phpt|phtml|aw|ctp)s*$</string> <key>name</key> <string>markup.fenced_code.block.markdown</string> <key>end</key> <string>(^|G)(2)n</string> <key>patterns</key> <array> <dict> <key>include</key> <string>text.html.php</string> </dict> </array> </dict> </ins> <key>fenced_code_block_sql</key> <dict> <key>begin</key>