Change:
Type: <bBug</bI open any and see a warning. I have disabled this feature in the past, it is still disabled in the settings but its somewhat turned back on. In fact the warning even mentions that the feature is disabled. Please remove the warning if the feature is disabled. At the moment the only way to 'hide' this warning is to enable the feature again. VS Code version: Code 1.74.0 (, 2022-12-05T16:47:18.476Z) OS version: Linux x64 6.0.6--generic Modes: Sandboxed: No <details<summarySystem Info</summary </details<details<summaryExtensions (7)</summaryExtensionVersion ------ esp-idf-extension1.5.1 todo-tree0.0.220 better-cpp-syntax1.17.2 git-graph1.30.0 cpptools1.13.8 color-highlight2.5.0 rust-analyzer0.3.1325 (2 theme extensions excluded) </details<!-- generated by issue reporter --
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.74.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
updated to: Version: 1.74.2 Commit: Date: 2022-12-20T10:27:19.253Z Electron: 19.1.8 Chromium: 102.0.5005.167 16.14.2 V8: 10.2.154.15-electron.0 OS: Linux x64 6.0.6--generic Sandboxed: No the issue remains in 1.74.2
Is disabled or enabled in the settings? If you disabled it, then we won't load the schema, but show the warning so users understand why they don't get any schema support. Are you suggesting to not show such a warning in that case?
it is set like this: but I do get the warning
I mean I don't know what this schema is or why it should be downloaded from the internet.. Tthe warning doesn't help me understand that either, it only informs me how I can avoid the warning by enabling a feature that seems like it doesn't really do anything useful. I expected that setting to false would remove the warning but it doesn't. So either I get this warning or vscode downloads schemas that have no meaning to me
me too, when set when open it's still show warning info
Disabling a feature should not produce a warning that it is disabled.
Yep, this is a very curious UX when I specifically choose to disable an unwanted feature, and then get a persistent warning stating I have disabled the feature. As with all other settings, this shouldn't be a warning.
Imagine a warning is shown for every setting that is not on the default value. I would have over a thousand warnings, completely useless and drowning out actual relevant/useful warnings. Please remove the warning if the feature is disabled. There are many closed issues with the same request for different schemas, why not spend 5 minutes and remove this 1 line of code?
or you know add another option so I can choose if I want to see this warning.

Discussion:
ProviderResult, TextEdit, Range, Position, Disposable, CompletionItem, CompletionList, CompletionContext, Hover, MarkdownString, FoldingContext, DocumentSymbol, SymbolInformation, l10n } from 'vscode'; import { <del> LanguageClientOptions, RequestType, NotificationType, FormattingOptions as LSPFormattingOptions, </del> <ins> LanguageClientOptions, RequestType, NotificationType, FormattingOptions as LSPFormattingOptions, DocumentDiagnosticReportKind, </ins> DidChangeConfigurationNotification, HandleDiagnosticsSignature, ResponseError, DocumentRangeFormattingParams, DocumentRangeFormattingRequest, ProvideCompletionItemsSignature, ProvideHoverSignature, BaseLanguageClient, ProvideFoldingRangeSignature, ProvideDocumentSymbolsSignature, ProvideDocumentColorsSignature } from 'vscode-languageclient';

} })); <ins> function filterSchemaErrorDiagnostics(uri: Uri, diagnostics: Diagnostic[]): Diagnostic[] { const schemaErrorIndex = diagnostics.findIndex(isSchemaResolveError); if (schemaErrorIndex !== -1) { const schemaResolveDiagnostic = diagnostics[schemaErrorIndex]; fileSchemaErrors.set(uri.toString(), schemaResolveDiagnostic.message); if (!schemaDownloadEnabled) { diagnostics = diagnostics.filter(d => !isSchemaResolveError(d)); } if (window.activeTextEditor && window.activeTextEditor.document.uri.toString() === uri.toString()) { schemaResolutionErrorStatusBarItem.show(); } } return diagnostics; } </ins> // Options to control the language client const clientOptions: LanguageClientOptions = { // Register the server for json documents

workspace: { didChangeConfiguration: () => client.sendNotification(DidChangeConfigurationNotification.type, { settings: getSettings() }) }, <del> handleDiagnostics: (uri: Uri, diagnostics: Diagnostic[], next: HandleDiagnosticsSignature) => { const schemaErrorIndex = diagnostics.findIndex(isSchemaResolveError); if (schemaErrorIndex === -1) { fileSchemaErrors.delete(uri.toString()); return next(uri, diagnostics); </del> <ins> provideDiagnostics: async (uriOrDoc, previousResolutId, token, next) => { const diagnostics = await next(uriOrDoc, previousResolutId, token); console.log('provideDiagnostics', diagnostics, uriOrDoc); if (diagnostics && diagnostics.kind === DocumentDiagnosticReportKind.Full) { const uri = uriOrDoc instanceof Uri ? uriOrDoc : uriOrDoc.uri; diagnostics.items = filterSchemaErrorDiagnostics(uri, diagnostics.items); </ins> } <del> const schemaResolveDiagnostic = diagnostics[schemaErrorIndex]; fileSchemaErrors.set(uri.toString(), schemaResolveDiagnostic.message); if (!schemaDownloadEnabled) { diagnostics = diagnostics.filter(d => !isSchemaResolveError(d)); } if (window.activeTextEditor && window.activeTextEditor.document.uri.toString() === uri.toString()) { schemaResolutionErrorStatusBarItem.show(); } </del> <ins> return diagnostics; }, handleDiagnostics: (uri: Uri, diagnostics: Diagnostic[], next: HandleDiagnosticsSignature) => { diagnostics = filterSchemaErrorDiagnostics(uri, diagnostics); </ins> next(uri, diagnostics); }, // testing the replace / insert mode