Change:
Testing Have the same content in the editor and in the terminal. Search for something. Notice how the occurrence are fat and visible in the editor scrollbar. Notice how they are not fat and sparse in terminal. They seem to be incorrectly placed since my match is almost on every line and that is not the feeling I get from the terminal scroll bar ! !
How many lines do you have in the editor for this example? It looks like there are a bunch of empty lines near the bottom? The way we calculate the position of terminal scroll bar decorations is line / number of lines in the buffer.
I had the same number of lines as the terminal which is 23. If I had more lines in the editor I think that would mean that the decorations are smaller in the editor, not larger and that seems to be happening :)
to me, it looks like the decorations are closer together and not taking up as much vertical space in the scrollbar see how the lower half is just empty? !
Good point. Now I have disabled scrolling beyond last line in the editor. And they render the equal height. But look at the decorations - they are very different. Do you also see this on your machine? !
The ones in the editor are double the height - likely because of device pixel ratio on a mac that's getting taken into account there and probably should be also for the terminal. ! !
Strange because we are doing the right thing here, but is 1 here for me on a mac . !
We can make these heights different based on the number of lines in the buffer similar to what the editor does
Upstream issue:

Discussion:
"vscode-proxy-agent": "^0.12.0", "vscode-regexpp": "^3.1.0", "vscode-textmate": "7.0.1", <del> "xterm": "4.19.0-beta.55", </del> <ins> "xterm": "4.19.0-beta.56", </ins> "xterm-addon-search": "0.9.0-beta.39", "xterm-addon-serialize": "0.7.0-beta.12", "xterm-addon-unicode11": "0.4.0-beta.3", "xterm-addon-webgl": "0.12.0-beta.36", <del> "xterm-headless": "4.19.0-beta.55", </del> <ins> "xterm-headless": "4.19.0-beta.56", </ins> "yauzl": "^2.9.2", "yazl": "^2.4.3" },

"tas-client-umd": "0.1.5", "vscode-oniguruma": "1.6.1", "vscode-textmate": "7.0.1", <del> "xterm": "4.19.0-beta.55", </del> <ins> "xterm": "4.19.0-beta.56", </ins> "xterm-addon-search": "0.9.0-beta.39", "xterm-addon-unicode11": "0.4.0-beta.3", "xterm-addon-webgl": "0.12.0-beta.36"

resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.36.tgz#460f80829a78c979a448d5b764699af3f0366ff1" integrity sha512-sgX7OHSGZQZE5b4xtPqd/5NEcll0Z+00tnTVxKZlXf5XEENcG0tnBF4I4f+k9K3cmjE1UIUVG2yYPrqWlYCdpA== <del> xterm@4.19.0-beta.55: version "4.19.0-beta.55" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.55.tgz#b2b4acca6ef5c7a4761098b5e1629b7f93deefc9" integrity sha512-AGT7b6UYZ0o7jtyLZ8KwY8Rchdqv3Pi6Nkcs4YbxR0opbQjIovEc44jkGmudfVYcGaFWsA/bdxM6feJ7VXRAlg== </del> <ins> xterm@4.19.0-beta.56: version "4.19.0-beta.56" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.56.tgz#a3f1021b43ac04aa0c3f7b06f1b44ad34d487879" integrity sha512-kywKIK61oPjbloZI+jXY1zgjQm/ghOsFFMjb79IIMaWocUDDqdpo9MmGwziTVZYu4w/Air2Zfas9UWBu4/KEyA== </ins>

resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.36.tgz#460f80829a78c979a448d5b764699af3f0366ff1" integrity sha512-sgX7OHSGZQZE5b4xtPqd/5NEcll0Z+00tnTVxKZlXf5XEENcG0tnBF4I4f+k9K3cmjE1UIUVG2yYPrqWlYCdpA== <del> xterm-headless@4.19.0-beta.55: version "4.19.0-beta.55" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.55.tgz#0f8fafefef57cd033100f4ffa60a04e71ed5e122" integrity sha512-LR2LyKLF/eo/m52qIlONnxNYr7a/Vp6X0M3CnaCFmYKXhjEMHqEOJOAUz/hhKG/R9j7apLgaNj/uw0mCdL780g== xterm@4.19.0-beta.55: version "4.19.0-beta.55" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.55.tgz#b2b4acca6ef5c7a4761098b5e1629b7f93deefc9" integrity sha512-AGT7b6UYZ0o7jtyLZ8KwY8Rchdqv3Pi6Nkcs4YbxR0opbQjIovEc44jkGmudfVYcGaFWsA/bdxM6feJ7VXRAlg== </del> <ins> xterm-headless@4.19.0-beta.56: version "4.19.0-beta.56" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.56.tgz#7e6bdc8d647916bf5de64a73eee6bd508d25e344" integrity sha512-EZoR/HqZoernhFngFQp7gUPy+G0TpEJkbJ9HVZcINC3m8wuV1wZKfZ4xBhsRPfhSJ7rsPnqbC+qez5ZjxwYEIw== xterm@4.19.0-beta.56: version "4.19.0-beta.56" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.56.tgz#a3f1021b43ac04aa0c3f7b06f1b44ad34d487879" integrity sha512-kywKIK61oPjbloZI+jXY1zgjQm/ghOsFFMjb79IIMaWocUDDqdpo9MmGwziTVZYu4w/Air2Zfas9UWBu4/KEyA== </ins> yallist@^4.0.0: version "4.0.0"

resolved "https://registry.yarnpkg.com/xterm-addon-webgl/-/xterm-addon-webgl-0.12.0-beta.36.tgz#460f80829a78c979a448d5b764699af3f0366ff1" integrity sha512-sgX7OHSGZQZE5b4xtPqd/5NEcll0Z+00tnTVxKZlXf5XEENcG0tnBF4I4f+k9K3cmjE1UIUVG2yYPrqWlYCdpA== <del> xterm-headless@4.19.0-beta.55: version "4.19.0-beta.55" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.55.tgz#0f8fafefef57cd033100f4ffa60a04e71ed5e122" integrity sha512-LR2LyKLF/eo/m52qIlONnxNYr7a/Vp6X0M3CnaCFmYKXhjEMHqEOJOAUz/hhKG/R9j7apLgaNj/uw0mCdL780g== xterm@4.19.0-beta.55: version "4.19.0-beta.55" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.55.tgz#b2b4acca6ef5c7a4761098b5e1629b7f93deefc9" integrity sha512-AGT7b6UYZ0o7jtyLZ8KwY8Rchdqv3Pi6Nkcs4YbxR0opbQjIovEc44jkGmudfVYcGaFWsA/bdxM6feJ7VXRAlg== </del> <ins> xterm-headless@4.19.0-beta.56: version "4.19.0-beta.56" resolved "https://registry.yarnpkg.com/xterm-headless/-/xterm-headless-4.19.0-beta.56.tgz#7e6bdc8d647916bf5de64a73eee6bd508d25e344" integrity sha512-EZoR/HqZoernhFngFQp7gUPy+G0TpEJkbJ9HVZcINC3m8wuV1wZKfZ4xBhsRPfhSJ7rsPnqbC+qez5ZjxwYEIw== xterm@4.19.0-beta.56: version "4.19.0-beta.56" resolved "https://registry.yarnpkg.com/xterm/-/xterm-4.19.0-beta.56.tgz#a3f1021b43ac04aa0c3f7b06f1b44ad34d487879" integrity sha512-kywKIK61oPjbloZI+jXY1zgjQm/ghOsFFMjb79IIMaWocUDDqdpo9MmGwziTVZYu4w/Air2Zfas9UWBu4/KEyA== </ins> y18n@^3.2.1: version "3.2.2"