jiebi/CodeConvo huggingface dataset:
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.74.0 OS Version: Mac 12.2.1 intel Steps to Reproduce: the debug activitybar of the local vscode. If the currently opened project does not have , you need to create a new one to activate debug. a test Expression, and watch carefully. problems: end of the text is truncated because of italics. icon container is not vertically centered. !
By the way, there is also a inputbox offset problem. Sometimes there are two border above the expression, which looks like there is a inputbox at the top but it is covered. As well as the vertical center of the inputbox, there are also some small deviations. ! I can't reproduce steadily, but I know that this problem existed before many versions. !
We closed this issue because we in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our and . Thanks for your understanding, and happy coding!

Discussion:
nameElement.style.display = 'none'; valueElement.style.display = 'none'; inputBoxContainer.style.display = 'initial'; <ins> dom.clearNode(inputBoxContainer); </ins> const inputBox = new InputBox(inputBoxContainer, this.contextViewService, { ...options, inputBoxStyles: defaultInputBoxStyles });
Change:
workspace trust workspace untrusted settings the hover for the workspace trust indicator and focus it to the action and press enter :bug: The action doesn't run pressing tab :bug: Focus leaves the hover and the hover stays open

Discussion:
actionOptions.run(this.actionContainer); })); <del> this._register(dom.addDisposableListener(this.actionContainer, dom.EventType.KEY_UP, e => { </del> <ins> this._register(dom.addDisposableListener(this.actionContainer, dom.EventType.KEY_DOWN, e => { </ins> const event = new StandardKeyboardEvent(e); <del> if (event.equals(KeyCode.Enter)) { </del> <ins> if (event.equals(KeyCode.Enter) || event.equals(KeyCode.Space)) { </ins> e.stopPropagation(); e.preventDefault(); actionOptions.run(this.actionContainer);

// Add a hover tab loop if the hover has at least one element with a valid tabIndex const firstContainerFocusElement = this._hover.containerDomNode; <del> const lastContainerFocusElement = this.findLastFocusableChild(this._hover.contentsDomNode); </del> <ins> const lastContainerFocusElement = this.findLastFocusableChild(this._hover.containerDomNode); </ins> if (lastContainerFocusElement) { const beforeContainerFocusElement = dom.prepend(this._hoverContainer, $('div')); const afterContainerFocusElement = dom.append(this._hoverContainer, $('div'));
Change:
click to open context menu in text editor +P to open quick open :bug: both context menu and quick open are dismissed !
re: context menu
This is not a regression so assigning to december
I'm going to pass to you for your take. Here's what I found out. When we show the command palette that causes the editor context menu to trigger the hide: This hide, focuses the editor... but in doing so, that causes the Quick Pick's didBlur to hide: which will hide the quick pick if is set to which is the default. This behavior with context menus seems to repro: Always in context menus of the editor Only with custom menus (not native menus) in the rest of the product (tree views, Account/Gear menu, etc)
Two actions here: needs to be removed or handled better (passing that to or menus should follow the logic: if ESC/selection, focus what was previously focused. If dismissed due to focus lost, don't restore focus (this goes to
my suspicion is that the editor contribution is old and unnecessary as the behavior is built-in to the menu widget. Removing it, we can centralize the logic to the menu widget.
re-opening as we still have some work to do on the custom menu side

Discussion:
onHide: (wasCancelled: boolean) => { this._contextMenuIsBeingShownCount--; <del> this._editor.focus(); </del> this._editor.updateOptions({ hover: oldHoverSetting });
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --VS Code version | OS ------------------ | ---- 73.1 | Win 10 x64 pro 21H2 a color like as transparent then to browse through symbol ! A uniform background with no line. This is not a duplicate of other related issues. This is not related to or Not related to fonts either.

Discussion:
const rangeHighlightBorder = theme.getColor(editorRangeHighlightBorder); if (rangeHighlightBorder) { <del> collector.addRule(`.monaco-editor .rangeHighlight { border: 1px ${isHighContrast(theme.type) ? 'dotted' : 'solid'} ${rangeHighlightBorder}; }`); </del> <ins> collector.addRule(`.monaco-editor .rangeHighlight { border: 1px ${isHighContrast(theme.type) ? 'dotted' : 'solid'} ${rangeHighlightBorder}; box-sizing: border-box; }`); </ins> } const symbolHighlightBorder = theme.getColor(editorSymbolHighlightBorder);
Change:
extension suppresses cancellation errors so Create New Codespace errors or cancellations show up as reports all errors as rather than distinguishing cancellation errors

Discussion:
import { IEditorService } from 'vs/workbench/services/editor/common/editorService'; import { ILocalizedString } from 'vs/platform/action/common/action'; import { Codicon } from 'vs/base/common/codicons'; <ins> import { CancellationError } from 'vs/base/common/errors'; </ins> registerSingleton(IEditSessionsLogService, EditSessionsLogService, InstantiationType.Delayed); registerSingleton(IEditSessionsStorageService, EditSessionsWorkbenchService, InstantiationType.Delayed);

} private async autoResumeEditSession() { <del> const shouldAutoResumeOnReload = this.configurationService.getValue('workbench.editSessions.autoResume') === 'onReload'; </del> <ins> const shouldAutoResumeOnReload = this.configurationService.getValue('workbench.cloudChanges.autoResume') === 'onReload'; </ins> if (this.environmentService.editSessionId !== undefined) { this.logService.info(`Resuming cloud changes, reason: found editSessionId ${this.environmentService.editSessionId} in environment service...`);

} private async autoStoreEditSession() { <del> if (this.configurationService.getValue('workbench.experimental.editSessions.autoStore') === 'onShutdown') { </del> <ins> if (this.configurationService.getValue('workbench.experimental.cloudChanges.autoStore') === 'onShutdown') { </ins> const cancellationTokenSource = new CancellationTokenSource(); await this.progressService.withProgress({ location: ProgressLocation.Window,

folderRoot = f; break; } else if (match === EditSessionIdentityMatch.Partial && <del> this.configurationService.getValue('workbench.experimental.editSessions.partialMatches.enabled') === true </del> <ins> this.configurationService.getValue('workbench.experimental.cloudChanges.partialMatches.enabled') === true </ins> ) { if (!force) { // Surface partially matching edit session

this.telemetryService.publicLog2<EvaluateContinueOnDestinationEvent, EvaluateContinueOnDestinationClassification>('continueOn.openDestination.outcome', { selection: command, outcome: 'invalidDestination' }); return undefined; } catch (ex) { <del> this.telemetryService.publicLog2<EvaluateContinueOnDestinationEvent, EvaluateContinueOnDestinationClassification>('continueOn.openDestination.outcome', { selection: command, outcome: 'unknownError' }); </del> <ins> if (ex instanceof CancellationError) { this.telemetryService.publicLog2<EvaluateContinueOnDestinationEvent, EvaluateContinueOnDestinationClassification>('continueOn.openDestination.outcome', { selection: command, outcome: 'cancelled' }); } else { this.telemetryService.publicLog2<EvaluateContinueOnDestinationEvent, EvaluateContinueOnDestinationClassification>('continueOn.openDestination.outcome', { selection: command, outcome: 'unknownError' }); } </ins> return undefined; } }
Change:
Testing microsoft/vscode-jupyter Remote-SSH to a remote linux machine, from mac Open a notebook "Detecting Kernels" has been there for minutes
Just as I filed this, it updated to show a kernel name, and still has the spinner. You can see the 10 minute gap in the updated log
Based on the logs Extension loads at 15:44:46 And kernel discovery finishes at 15:44:53 At 15:53:32 the kernel selection changed (either you selected this manually or vscode selected this or other) I.e. i don't see any issues (at least not from the logs()
I updated to get your logs. I see Oddly, when I debugged the extension on the same remote, same folder, I didn't see this issue. But in normal insiders with the latest extension, I see it 100% of the time
based on the logs we start the spinner and dispose the task, we only do this once meaning there aren't multiple tasks created by us, the only one created gets disposed. I.e. i think the cause for an infinite spinner must be in core

Discussion:
} }); <del> if (shouldStartDetection) { </del> <ins> if (shouldStartDetection && !this._detectionMap.has(notebookType)) { </ins> const task = this._notebookKernelService.registerNotebookKernelDetectionTask({ notebookType: notebookType });
Change:
Could you please open another issue for that? Thanks. Originally posted by in
Remember to assign bugs and feature requests to the milestone they got addressed in.

Discussion:
if (toSide && fullSize.width > 700) { if (this.groupsService.count === 1) { <del> this.groupsService.addGroup(this.groupsService.groups[0], GroupDirection.LEFT, { activate: true }); </del> <ins> this.groupsService.addGroup(this.groupsService.groups[0], GroupDirection.RIGHT, { activate: true }); </ins> const gettingStartedSize = Math.floor(fullSize.width / 2);
Change:
<!-- Do Not Delete This! featurerequesttemplate --<!-- Please read our Rules of Conduct: --<!-- Please search existing issues to avoid creating duplicates. --<!-- Describe the feature you'd like. --Extensions which contribute notebook renderers must declare in , this can be inferred for extension authors by specifying the . See also (Note, this would require adoption in the notebook renderers extension as well, which currently activates : )

Discussion:
export const notebookRendererExtensionPoint = ExtensionsRegistry.registerExtensionPoint<INotebookRendererContribution[]>({ extensionPoint: 'notebookRenderer', <del> jsonSchema: notebookRendererContribution </del> <ins> jsonSchema: notebookRendererContribution, activationEventsGenerator: (contribs: INotebookRendererContribution[], result: { push(item: string): void }) => { for (const contrib of contribs) { if (contrib.id) { result.push(`onRenderer:${contrib.id}`); } } } </ins> }); export const notebookPreloadExtensionPoint = ExtensionsRegistry.registerExtensionPoint<INotebookPreloadContribution[]>({
Change:
<img width="1792" alt="image" src="https://user-"Hi, like visible on the screenshot, more than half of the terminal width in vertical mode is taken to display the path of the file where the log originated. I think this is not relevant to many of us since the path will point to the logger file At some point it gets really hard to read the logs Just to have an option to display path in cli would be enought for me. My screen resolution is 3072x1920 and my zoom level is -0.5 (at 0 it is even worst)
This has always been a bit off- I think only showing the file name would be sufficient
To be honest, who even needs the filename? When debugging I know what my messages mean and where they are generated. If I don't, a simple clickable elipsis will save space and perform the same function by bringing me directly to the line of code.

Discussion:
} } <del> abstract class AbstractLaunch { </del> <ins> abstract class AbstractLaunch implements ILaunch { abstract readonly uri: uri; abstract readonly name: string; abstract readonly workspace: IWorkspaceFolder | undefined; </ins> protected abstract getConfig(): IGlobalConfig | undefined; <ins> abstract openConfigFile(options: { preserveFocus: boolean; type?: string | undefined; suppressInitialConfigs?: boolean | undefined }, token?: CancellationToken | undefined): Promise<{ editor: IEditorPane | null; created: boolean }>; </ins> constructor( protected configurationManager: ConfigurationManager,

import { IAsyncDataSource, ITreeNode, ITreeRenderer } from 'vs/base/browser/ui/tree/tree'; import { createMatches, FuzzyScore } from 'vs/base/common/filters'; import { dispose, IDisposable } from 'vs/base/common/lifecycle'; <ins> import { basename } from 'vs/base/common/path'; </ins> import severity from 'vs/base/common/severity'; import { localize } from 'vs/nls'; import { IConfigurationService } from 'vs/platform/configuration/common/configuration';

templateData.value.appendChild(result); templateData.value.classList.add((element.severity === severity.Warning) ? 'warn' : (element.severity === severity.Error) ? 'error' : (element.severity === severity.Ignore) ? 'ignore' : 'info'); <del> templateData.source.textContent = element.sourceData ? `${element.sourceData.source.name}:${element.sourceData.lineNumber}` : ''; </del> <ins> templateData.source.textContent = element.sourceData ? `${basename(element.sourceData.source.name)}:${element.sourceData.lineNumber}` : ''; </ins> templateData.source.title = element.sourceData ? `${this.labelService.getUriLabel(element.sourceData.source.uri)}:${element.sourceData.lineNumber}` : ''; templateData.getReplElementSource = () => element.sourceData; }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --<!-- Does this issue occur when all extensions are disabled?: Yes/No --<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --VS Code Version: 1.73.1 Host OS Version: Windows 10 Enterprise 20H2 Remote OS Version: Ubuntu 20.04.3 LTS Steps to Reproduce: a notebook file setting: on Expand All in the Outline section on Split Editor Right window on the (newer) right-side of split view outline automatically collapses window back on the (original) left-side of split view outline automatically collapses views repeatedly continues to show outline view always collapsed, despite setting Expect switching between tabs of the same notebook file in split view to follow the last collapse/expand state.
is it expected that if I: Open the Notebook (Outline is expanded) change the setting to Click the Notebook tab to show it Then the Outline is still expanded. Is that expected?
Yeah, in response the settings change I didn't want to undo the current state but only apply it to future states

Discussion:
expandOnlyOnTwistieClick: true, multipleSelectionSupport: false, accessibilityProvider: new NotebookOutlineAccessibility(), <del> identityProvider: { getId: element => element.cell.id }, </del> <ins> identityProvider: { getId: element => element.cell.uri.toString() }, </ins> keyboardNavigationLabelProvider: new NotebookNavigationLabelProvider() };
Change:
Running on main:
Am I missing something on how to run this? An ignore rule is in :

Discussion:
'!build/win32/**', '!extensions/markdown-language-features/notebook-out/*.js', '!extensions/markdown-math/notebook-out/**', <ins> '!extensions/ipynb/notebook-out/**', </ins> '!extensions/notebook-renderers/renderer-out/**', '!extensions/php-language-features/src/features/phpGlobalFunctions.ts', '!extensions/typescript-language-features/test-workspace/**',

'!extensions/typescript-language-features/test-workspace/**', '!extensions/typescript-language-features/resources/walkthroughs/**', '!extensions/markdown-math/notebook-out/**', <ins> '!extensions/ipynb/notebook-out/**', </ins> '!extensions/vscode-api-tests/testWorkspace/**', '!extensions/vscode-api-tests/testWorkspace2/**', '!build/monaco/**',

'!extensions/markdown-language-features/media/*.js', '!extensions/markdown-language-features/notebook-out/*.js', '!extensions/markdown-math/notebook-out/*.js', <ins> '!extensions/ipynb/notebook-out/**', </ins> '!extensions/notebook-renderers/renderer-out/*.js', '!extensions/simple-browser/media/*.js', ];

'!extensions/configuration-editing/build/inline-allOf.ts', '!extensions/markdown-language-features/media/highlight.css', '!extensions/markdown-math/notebook-out/**', <ins> '!extensions/ipynb/notebook-out/**', </ins> '!extensions/html-language-features/server/src/modes/typescript/*', '!extensions/*/server/bin/*', '!src/vs/editor/test/node/classification/typescript-test.ts',
Change:
Reproduce: vscode-insiders latest vscode-insiders vscode-insiders command `Clear Display Language Preference https://user-

Discussion:
let hasEdits: boolean = false; for (const value of values) { const edit = this.getEdits(model, value)[0]; <del> hasEdits = this.applyEditsToBuffer(edit, model); </del> <ins> hasEdits = !!edit && this.applyEditsToBuffer(edit, model); </ins> } if (hasEdits) { return this.textFileService.save(model.uri);
Change:
Repro long markdown file preview to side Bug This scrolls to the bottom of the markdown preview
Introduced by
Reopening to track candidate
Fix merged into 1.74. Closing for verification
Marking as verified based on Greg's testing

Discussion:
} onceDocumentLoaded(() => { <del> const scrollTo = !isNaN(state.line) ? state.line : state.scrollProgress; </del> <ins> const scrollProgress = state.scrollProgress; </ins> <del> if (typeof scrollTo === 'number' && !settings.settings.fragment) { </del> <ins> if (typeof scrollProgress === 'number' && !settings.settings.fragment) { </ins> doAfterImagesLoaded(() => { scrollDisabledCount += 1; <del> window.scrollTo(0, scrollTo * document.body.clientHeight); </del> <ins> window.scrollTo(0, scrollProgress * document.body.clientHeight); </ins> }); return; }

default: return; } <del> } else if (!scrollLocation) { scrollLocation = new StartingScrollLine(0); </del> } this._preview.dispose();
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: (2022-12-06) OS Version: Steps to Reproduce: that returns an item with and (filtertext doesn't matter, as long as it matches whatever is typed) should be , but you get (the o should be highlighted and is not) some examples from typescript (typing in ): <img width="289" alt="Screenshot 2022-12-06 at 10 41 36 PM" src="https://user-"<img width="351" alt="Screenshot 2022-12-06 at 10 41 03 PM" src="https://user-"
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.73.1. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding!
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!

Discussion:
export function anyScore(pattern: string, lowPattern: string, patternPos: number, word: string, lowWord: string, wordPos: number): FuzzyScore { const max = Math.min(13, pattern.length); for (; patternPos < max; patternPos++) { <del> const result = fuzzyScore(pattern, lowPattern, patternPos, word, lowWord, wordPos, { firstMatchCanBeWeak: false, boostFullMatch: true }); </del> <ins> const result = fuzzyScore(pattern, lowPattern, patternPos, word, lowWord, wordPos, { firstMatchCanBeWeak: true, boostFullMatch: true }); </ins> if (result) { return result; }

assertMatches('.', 'log', 'log', anyScore); }); <ins> test('anyScore should not require a strong first match', function () { assertMatches('bar', 'foobAr', 'foo^b^A^r', anyScore); assertMatches('bar', 'foobar', 'foo^b^a^r', anyScore); }); </ins> test('configurable full match boost', function () { const prefix = 'create'; const a = 'createModelServices';