jiebi/CodeConvo huggingface dataset:
Change:
Testing It seems to be a workspace setting?
To verify: 2 windows panel alignment to anything but current 2nd window updates

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
Testing "Network status appears to be offline" -"Network appears to be offline" "status" not needed here imho <img width="557" alt="Screenshot 2022-01-25 at 11 46 28" src="https://user-"
!
exactly :D

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
Testing I would have expected: the order to preserve the active view to restore the active view getting focus after the op
the order may be preserved only on the first move since each part caches its order. restoring focus/active needs to be fixed

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
web + server open a folder add folder to workspace after reload you should be in an untitled workspace with 2 folders

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
Testing The "Open Detected Link" command opens another UI (quick pick). In such cases we add ellipsis () to signal this extra step, like "Set Log Level..." or "Report Issue..."

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
Testing No string feelings but the TPI itself made me file this issue. If above explanation is needed than that might be a since of bad naming? So how about "Open closest/nearest link" or "Open last link" (last allows for interpreting it as time/recency and proximity-value)
Open Last Link is nice and concise

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
Testing Current deprecation dialog: ! Proposed deprecation dialog - more concise, looks better, yet still delivers the message !

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
Testing <img width="142" alt="image" src="https://user-"
See also
independent of the linked issue, I think I can improve the badge situation
This is only a simple fix for the release to reduce the spacing. Next milestone we can revisit better representations as mentioned in the linked issue.

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
Testing I was thinking that the new API isn't working because I had terminal persistent disabled via its user setting. So, I suggest to call this behaviour out in the jsdoc-comment

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
Testing Open the hover in the JSON settings ! Note the "$(capture)` which needs to be escaped as this is the syntax of codicons.
Do you know how I'd properly escape that? I tried with no luck. for now using zero width space: but I don't like how this may end up copy/pasted

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
I have the following "Problems" warning shown for my file for vscode insider (Version: 1.64.0-insider), for which I'm unable to find the source. I even copy-and-pasted a file from another vscode that doesn't have such warning, and it still showing the same message. May I ask what I have missed here? PROBLEMS warning message shown in vscode insider. My file is show in this .

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
Testing Testing the step to introduce conflicts. Turned off Settings Sync on machine X Made a change in in both machines Turned on Settings Sync again on machine X Prompted there is a conflict, select "Merge" Notified merge cannot be completed and I need to resolve conflict manually : I wasn't sure what to do since "Turn on Settings Sync" was grayed out, and I didn't see any entries to go through: ! I clicked around the viewlet and noticed the was hidden and only partially clickable on the black horizontal line under the top text: ! If I expand the view, then the file appears: ! Is there a way to avoid the step above, i.e. defaulting the view to a certain width, or still showing the file name even if the view is narrow? Being unable to see the entry and noticing the "Turn on Settings Sync" button was gray made me think I needed to turn on Settings Sync again to see file names.

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
It's an edge case but worthwhile considering 1) Ensure that all new windows are in restricted mode by default 2) Open a new empty window (no open files at all, no open folder) 3) Use <kbdCmd</kbd+<kbd`</kbd-prompt for trusting the workspace, but there is nothing there to be trusted
In this case, it definitely gets in the way that we ask about trust, and also doesn't make too much to limit access to the terminal. However, what considerations should be in place for when someone decides to bring in untrusted content into the workspace after the terminal is opened? Does this matter for empty workspaces
it's only useful for the terminal if the folder is of a potentially foreign origin. I could special case this since it's going to open in the home directory anyway, but should it even be possible to have an empty window in restricted mode? Might need to handle this special case in multiple places if it's not handled by the trust request service?
we have settings to configure the empty window experience... this allows empty windows to bring in untrusted content easily without prompting.
Ok, let's allow opening the terminal if the active workspace root is undefined then as it's safe in that case.

Discussion:
import { ITextModel } from 'vs/editor/common/model'; import { IModelService } from 'vs/editor/common/services/model'; import { ITextModelContentProvider, ITextModelService } from 'vs/editor/common/services/resolverService'; <ins> import { IHistoryService } from 'vs/workbench/services/history/common/history'; import { Schemas } from 'vs/base/common/network'; </ins> const enum Constants { /**

@IWorkbenchEnvironmentService workbenchEnvironmentService: IWorkbenchEnvironmentService, @IWorkspaceContextService private readonly _workspaceContextService: IWorkspaceContextService, @IEditorService private readonly _editorService: IEditorService, <del> @IWorkspaceTrustRequestService private readonly _workspaceTrustRequestService: IWorkspaceTrustRequestService </del> <ins> @IWorkspaceTrustRequestService private readonly _workspaceTrustRequestService: IWorkspaceTrustRequestService, @IHistoryService private readonly _historyService: IHistoryService </ins> ) { super();

if (this._isDisposed) { return; } <del> const trusted = await this._trust(); if (!trusted) { </del> <ins> const activeWorkspaceRootUri = this._historyService.getLastActiveWorkspaceRoot(Schemas.file); if (activeWorkspaceRootUri) { const trusted = await this._trust(); if (!trusted) { this._onProcessExit({ message: nls.localize('workspaceNotTrustedCreateTerminal', "Cannot launch a terminal process in an untrusted workspace") }); } } else if (this._userHome && this._cwd !== this._userHome) { // ensure that the process is launched in userHome for an empty workspace this._shellLaunchConfig.cwd = this._userHome; } else if (!this._userHome) { </ins> this._onProcessExit({ message: nls.localize('workspaceNotTrustedCreateTerminal', "Cannot launch a terminal process in an untrusted workspace") }); }
Change:
Testing It's not clear what means for . / are talking about when the explorer will prompt to warn users but disable this feature completely. I didn't get that when the first time read , maybe we make it clear that undo/redo will no longer work in explorer when disabled.
Moved to
Actually split this into two settings, so is a boolean controlling whether the explorer does undo at all, then is an enum configuring how frequently to prompt.

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
Testing Set to Resize the window so that it's just big enough for the labels to appear Run a cell Notice that the labels in the toolbar disappeared I don't know what the best solution for this would be, if there's any Since a new icon + label are to the toolbar when running a cell, this issue is bound to happen for window dimensions that straddle the line between labels being displayed and hidden (and that's not even considering translations). https://user-
Basically by design, a shorter label for "Go to Running Cell" would help. Would just "Go To" (with the full label in tooltip) and with the spinning icon be clear? Any other ideas to mitigate it
I think the spinning icon is a good enough indicator. Even if we address the issue with "Go To", it might happen in languages with a longer translated label.
Are you saying the button shouldn't have a label in the toolbar?
Oh no, I meant to say that the current solution is good enough.

Discussion:
super({ id: REVEAL_RUNNING_CELL, title: localize('revealRunningCell', "Go To Running Cell"), <ins> tooltip: localize('revealRunningCell', "Go To Running Cell"), shortTitle: localize('revealRunningCellShort', "Go To"), </ins> precondition: NOTEBOOK_HAS_RUNNING_CELL, menu: [ {

if (executingCells[0]) { const cell = context.notebookEditor.getCellByHandle(executingCells[0].cellHandle); if (cell) { <del> context.notebookEditor.revealInCenter(cell); </del> <ins> context.notebookEditor.focusNotebookCell(cell, 'container'); </ins> } } }
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: N/A <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: Version: 1.63.2 Commit: Date: 2021-12-15T09:39:46.686Z Electron: 13.5.2 Chromium: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Linux x64 5.11.0-46-generic OS Version: Ubuntu Linux 21.04 (running under VMware) Steps to Reproduce: a notebook (ipynb) in VS Code a lot of code into a cell -- too much code to fit onto the screen at once other cells to scroll back and forth between cells using the keyboard Expected: The arrow keys should be able to scroll to the cell immediately before the current cell Actual: The arrow keys are ignored; eventually, it sometimes scrolls, but then to the top of the entire notebook. Scroll doesn't work; it locks on the cell. Sometimes, when it releases, it goes to the top of the entire notebook.

Discussion:
cell.updateEditState(CellEditState.Editing, 'focusNotebookCell'); cell.focusMode = CellFocusMode.Editor; if (!options?.skipReveal) { <del> this.revealInCenterIfOutsideViewport(cell); </del> <ins> const selectionsStartPosition = cell.getSelectionsStartPosition(); if (selectionsStartPosition?.length) { const firstSelectionPosition = selectionsStartPosition[0]; this.revealRangeInCenterIfOutsideViewportAsync(cell, Range.fromPositions(firstSelectionPosition, firstSelectionPosition)); } else { this.revealInCenterIfOutsideViewport(cell); } </ins> } } else if (focusItem === 'output') { this.focusElement(cell);
Change:
Testing I found the language on this line ambiguous: 'This method' I believe is referring to passing a string or glob pattern. But the first time I read I thought it was referring to createFileSystemWatcher (which would contradict the previous bit of documentation). Perhaps replace 'This method' with 'Using a string or a glob pattern'.

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
Testing vscode open to folder , and another folder . Have the files , , and , to folder enter in the terminal and click on it. opens in the folder. opens https://user-
Maybe I'm doing something wrong, but I can't reproduce. I have a workspace with a . It opens that before I into a new directory. I into a new directory with a and when I click on it, that one opens. !
did it look like shell integration was enabled on hover ?
Can repro, we need to also make validated local link provider aware of command detection.
this should already work as preprocessPath uses the cwd Guessing this is a windows only issue, as I'm not encountering it on mac
I think _processCwd is hooked up to the old system:
<img width="1648" alt="image" src="https://user-" is this as expected, I'm in folder and clicking on opens the quick pick other than directly opening .
if you create another terminal and hover the tab, what capabilities do you see?
hadn't enabled shell integration. he did and does see the capabilities, the run recent command works, but he said that this does not.
issue above is with word links whereas this original issue was not
Can repro, the following screenshot tries to open a link in vscode: ! !

Discussion:
private _hasHadInput: boolean; <ins> // Enables disposal of the xterm onKey // event when the CwdDetection capability // is added private _xtermOnKey: IDisposable | undefined; </ins> readonly statusList: ITerminalStatusList; disableLayout: boolean = false;

if (e === TerminalCapability.CwdDetection) { this.capabilities.get(TerminalCapability.CwdDetection)?.onDidChangeCwd((e) => { this._cwd = e; <ins> if (this._linkManager) { this._linkManager.processCwd = this._cwd; } this._xtermOnKey?.dispose(); </ins> this.refreshTabLabels(this.title, TitleEventSource.Api); }); }

} }); }, 1000); <del> xterm.raw.onKey(e => this._onKey(e.key, e.domEvent)); </del> <ins> this._xtermOnKey = xterm.raw.onKey(e => this._onKey(e.key, e.domEvent)); </ins> xterm.raw.onSelectionChange(async () => this._onSelectionChange()); xterm.raw.buffer.onBufferChange(() => this._refreshAltBufferContextKey());
Change:
<!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --Testing Version: 1.64.0-insider (user setup) Commit: Date: 2022-01-25T08:42:41.055Z Electron: 13.5.2 Chromium: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Windows_NT x64 10.0. Steps to Reproduce: notebook in latest insiders for text that exceeds default length of search bar text overlaps the "Aa" icon <img width="332" alt="image" src="https://user-"
We should expand the default width of the notebook find widget and consider supporting find widget expansion () like the editor find widget.

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
<!-- Do Not Delete This! bugreporttemplate --Does this issue occur when all extensions are disabled?: Yes Version: 1.64.0-insider Commit: Date: 2022-01-21T13:26:52.572Z Electron: 13.5.2 Chromium: 91.0.4472.164 14.16.0 V8: 9.1.269.39-electron.0 OS: Linux x64 5.13.0-27-generic Steps to Reproduce the microsoft/vscode repository the Search sidebar, click "Open a New Search Editor" a multi-line search query: the results, blank lines are replaced with the word . (Only blank lines within the matched range are affected; blank lines in the surrounding context are rendered correctly.)

Discussion:
const prefixOffset = prefix.length; // split instead of replace to avoid creating a new string object <del> const line = prefix + sourceLine.split(/r?n?$/, 1)[0]; </del> <ins> const line = prefix + (sourceLine.split(/r?n?$/, 1)[0] || ''); </ins> const rangeOnThisLine = ({ start, end }: { start?: number; end?: number; }) => new Range(1, (start ?? 1) + prefixOffset, 1, (end ?? sourceLine.length + 1) + prefixOffset);
Change:
Testing Hide panel Do "Run Recent Command" I can't see the effect, I expect the terminal to be revealed

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
If you have a pre-release built in extension then the context menu and the extension editor will not show the same "switch" options: ! !

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
spotted this when running out of sources: I think we stabilized this so we would want to remove it from vscode-api-tests if it's there.

Discussion:
disposables.push(server.onServerStart(path => { <del> defaultStatus.text = '$(flame) Runnning'; </del> <ins> defaultStatus.text = '$(flame) Running'; </ins> defaultStatus.command = 'o.pickProjectAndStart'; defaultStatus.color = ''; render();
Change:
With the following settings: I'm not seeing show up: ! Changing to also doesn't show the (), but it does when I add that to description. Creating a new terminal will have it applied though: !
/verified

Discussion:
this.capabilities.get(TerminalCapability.CwdDetection)?.onDidChangeCwd((e) => { this._cwd = e; this._xtermOnKey?.dispose(); <del> this.refreshTabLabels(this.title, TitleEventSource.Api); </del> <ins> this.refreshTabLabels(this.title, TitleEventSource.Config); </ins> }); } }));

case ProcessPropertyType.InitialCwd: this._initialCwd = value; this._cwd = this._initialCwd; <del> this.refreshTabLabels(this.title, TitleEventSource.Api); </del> <ins> this.refreshTabLabels(this.title, TitleEventSource.Config); </ins> break; case ProcessPropertyType.Title: this.refreshTabLabels(value ? value : '', TitleEventSource.Process);
Change:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: 1.63.2 OS Version: MacOS Monterey Steps to Reproduce: a JavaScript file. enter. next line is indented because it doesn't realise the is in a regular expression.
/assign mjbvz -Tyriar
It looks like it is looking for a matching closing bracket. Indent: Indent: No Indent: No Indent:

Discussion:
const jsTsLanguageConfiguration: vscode.LanguageConfiguration = { indentationRules: { decreaseIndentPattern: /^((?!.*?/*).**/)?s*[}]].*$/, <del> increaseIndentPattern: /^((?!//).)*({([^}"'`]*|(t|[ ])*//.*)|([^)"'`]*|[[^]"'`]*)$/, </del> <ins> increaseIndentPattern: /^((?!//).)*({([^}"'`/]*|(t|[ ])*//.*)|([^)"'`/]*|[[^]"'`/]*)$/, </ins> // e.g.  * ...| or */| or *-----*/| unIndentedLinePattern: /^(t|[ ])*[ ]*[^/]**/s*$|^(t|[ ])*[ ]*/s*$|^(t|[ ])*[ ]*([ ]([^*]|*(?!/))*)?$/ },

testIndentAction('', '  * test() {', '', IndentAction.Indent, null, 0); testIndentAction('  ', '  * test() {', '', IndentAction.Indent, null, 0); }); <ins> test('issue #141816', () => { let support = new OnEnterSupport({ onEnterRules: javascriptOnEnterRules }); let testIndentAction = (beforeText: string, afterText: string, expected: IndentAction) => { let actual = support.onEnter(EditorAutoIndentStrategy.Advanced, '', beforeText, afterText); if (expected === IndentAction.None) { assert.strictEqual(actual, null); } else { assert.strictEqual(actual!.indentAction, expected); } }; testIndentAction('const r = /{/;', '', IndentAction.None); testIndentAction('const r = /{[0-9]/;', '', IndentAction.None); testIndentAction('const r = /[a-zA-Z]{/;', '', IndentAction.None); }); </ins> });
Change:
A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #Visual Studio Code Client; #BM-VisualStudioCode-Win32-Nov2021; #Win32; #Narrator; #NVDA; #ScreenReader; #WCAG4.2.5 #AINotInScope; #FTP; #STP; Application Name: Visual Studio Code Client Windows Version: Windows 11 1)Turn on Narrator/NVDA. 2)Open Visual studio code editor. 3)Open the command Pallet by pressing "F1" key and type "Theme" 4)Using Down arrow key select "Preference color Theme" and press enter key to select. 5)Using "Up/Down" arrow key select different available theme. 6)verify that screen reader is announcing the associated label for the 'recently used' and 'Other commands' or not. Screen reader does not announce associated label for the 'recently used' and 'Other commands'.. Screen reader should announce the associated label for the 'recently used' and 'Other commands'. Screen Reader users will not get the complete information about the controls. !
The issue here is that the group label "recently used" does not get read. I suggest to append the group name to the aria label of the first element in the quick pick that belongs to that group. I think it should be a low hanging fix.

Discussion:
} getAriaLabel(element: ListElement): string | null { <del> return element.saneAriaLabel; </del> <ins> return element.separator?.label ? `${element.saneAriaLabel}, ${element.separator.label}` : element.saneAriaLabel; </ins> } getWidgetRole() {