Change:
: cc <!-- TRIAGEBOTSTART --<!-- TRIAGEBOTASSIGNSTART --<!-- TRIAGEBOTASSIGNDATASTARTTRIAGEBOTASSIGNDATAEND --<!-- TRIAGEBOTASSIGNEND --<!-- TRIAGEBOTEND --
Nearly 100% of that time is spent in . ! Is this even required for intra-doc links? AFAIK this is only for and , which don't have associated items.
... why is taking a quarter of the time?
I think this could be sped up quite a bit by only considering traits that have an associated item of the right name. Then rustdoc wouldn't have to go through the trait system at all, just look at it long enough to see it wouldn't work even if it did apply to the type.
Relevant code: We could change to take a parameter, that wouldn't be too invasive I think.
It probably also doesn't help that simplifies the type to an extent where all generic args are erased and then iterates on all trait implementations of it: If you have gazillions of then that's a problem :) Reducing the number of traits this (rather expensive) search is done is a good idea!
I think the strategy similar to would be helpful here too, but I guess the lower hanging fruit (checking whether the trait contains the name in the first place) should be tried before.
Discussed in Discord with , I'll be trying my hand at this one :rocket: claim

Discussion:
use rustc_hir::lang_items::LangItem; use rustc_hir::Mutability; use rustc_index::vec::IndexVec; <del> use rustc_middle::ty::{AssocKind, TyCtxt}; </del> <ins> use rustc_middle::ty::TyCtxt; </ins> use rustc_session::Session; use rustc_span::hygiene::MacroKind; use rustc_span::source_map::DUMMY_SP;

_ => false, } } <del> crate fn as_assoc_kind(&self) -> Option<AssocKind> { match *self { ItemKind::AssocConstItem(..) => Some(AssocKind::Const), ItemKind::AssocTypeItem(..) => Some(AssocKind::Type), ItemKind::TyMethodItem(..) | ItemKind::MethodItem(..) => Some(AssocKind::Fn), _ => None, } } </del> } #[derive(Clone, Debug)]

use std::mem; use std::ops::Range; <del> use crate::clean::{self, Crate, GetDefId, Item, ItemLink, PrimitiveType}; </del> <ins> use crate::clean::{self, Crate, Item, ItemLink, PrimitiveType}; </ins> use crate::core::DocContext; use crate::fold::DocFolder; use crate::html::markdown::markdown_links;

ns: Namespace, cx: &DocContext<'_>, ) -> Option<(ty::AssocKind, DefId)> { <del> let ty = cx.tcx.type_of(did); // First consider blanket impls: `impl From<T> for T` let implicit_impls = crate::clean::get_auto_trait_and_blanket_impls(cx, ty, did); let mut candidates: Vec<_> = implicit_impls .flat_map(|impl_outer| { match impl_outer.kind { clean::ImplItem(impl_) => { debug!("considering auto or blanket impl for trait {:?}", impl_.trait_); // Give precedence to methods that were overridden if !impl_.provided_trait_methods.contains(&*item_name.as_str()) { let mut items = impl_.items.into_iter().filter_map(|assoc| { if assoc.name != Some(item_name) { return None; } let kind = assoc .kind .as_assoc_kind() .expect("inner items for a trait should be associated items"); if kind.namespace() != ns { return None; } trace!("considering associated item {:?}", assoc.kind); // We have a slight issue: normal methods come from `clean` types, // but provided methods come directly from `tcx`. // Fortunately, we don't need the whole method, we just need to know // what kind of associated item it is. Some((kind, assoc.def_id)) }); let assoc = items.next(); debug_assert_eq!(items.count(), 0); assoc } else { // These are provided methods or default types: // ``` // trait T { //   type A = usize; //   fn has_default() -> A { 0 } // } // ``` let trait_ = impl_.trait_.unwrap().def_id().unwrap(); cx.tcx .associated_items(trait_) .find_by_name_and_namespace( cx.tcx, Ident::with_dummy_span(item_name), ns, trait_, ) .map(|assoc| (assoc.kind, assoc.def_id)) } } _ => panic!("get_impls returned something that wasn't an impl"), } }) .collect(); </del> <ins> // FIXME: this should also consider blanket impls (`impl<T> X for T`). Unfortunately // `get_auto_trait_and_blanket_impls` is broken because the caching behavior is wrong. In the // meantime, just don't look for these blanket impls. </ins> // Next consider explicit impls: `impl MyTrait for MyType` // Give precedence to inherent impls. <del> if candidates.is_empty() { let traits = traits_implemented_by(cx, did, module); debug!("considering traits {:?}", traits); candidates.extend(traits.iter().filter_map(|&trait_| { cx.tcx .associated_items(trait_) .find_by_name_and_namespace(cx.tcx, Ident::with_dummy_span(item_name), ns, trait_) .map(|assoc| (assoc.kind, assoc.def_id)) })); } </del> <ins> let traits = traits_implemented_by(cx, did, module); debug!("considering traits {:?}", traits); let mut candidates = traits.iter().filter_map(|&trait_| { cx.tcx .associated_items(trait_) .find_by_name_and_namespace(cx.tcx, Ident::with_dummy_span(item_name), ns, trait_) .map(|assoc| (assoc.kind, assoc.def_id)) }); </ins> // FIXME(#74563): warn about ambiguity <del> debug!("the candidates were {:?}", candidates); candidates.pop() </del> <ins> debug!("the candidates were {:?}", candidates.clone().collect::<Vec<_>>()); candidates.next() </ins> } /// Given a type, return all traits in scope in `module` implemented by that type.