Change:
review comments:
triage: P-medium. (We should look into this, but even if its wrong, I'm not going to push to a backport its hypothetical bug fix.)

Discussion:
use mir::visit::MirVisitable; use rustc_apfloat::ieee::{Double, Single}; use rustc_apfloat::Float; <ins> use rustc_data_structures::fx::FxHashSet; </ins> use rustc_data_structures::graph::dominators::{dominators, Dominators}; use rustc_data_structures::graph::{self, GraphPredecessors, GraphSuccessors}; use rustc_data_structures::indexed_vec::{Idx, IndexVec};

} } <ins> /// Returns `true` if `other` is earlier in the control flow graph than `self`. pub fn is_predecessor_of<'tcx>(&self, other: Location, mir: &Mir<'tcx>) -> bool { // If we are in the same block as the other location and are an earlier statement // then we are a predecessor of `other`. if self.block == other.block && self.statement_index < other.statement_index { return true; } // If we're in another block, then we want to check that block is a predecessor of `other`. let mut queue: Vec<BasicBlock> = mir.predecessors_for(other.block).clone(); let mut visited = FxHashSet::default(); while let Some(block) = queue.pop() { // If we haven't visited this block before, then make sure we visit it's predecessors. if visited.insert(block) { queue.append(&mut mir.predecessors_for(block).clone()); } else { continue; } // If we found the block that `self` is in, then we are a predecessor of `other` (since // we found that block by looking at the predecessors of `other`). if self.block == block { return true; } } false } </ins> pub fn dominates(&self, other: Location, dominators: &Dominators<BasicBlock>) -> bool { if self.block == other.block { self.statement_index <= other.statement_index

} } <del> fn check_parent_of_field<'cx, 'gcx, 'tcx>(this: &mut MirBorrowckCtxt<'cx, 'gcx, 'tcx>, context: Context, base: &Place<'tcx>, span: Span, flow_state: &Flows<'cx, 'gcx, 'tcx>) { </del> <ins> fn check_parent_of_field<'cx, 'gcx, 'tcx>( this: &mut MirBorrowckCtxt<'cx, 'gcx, 'tcx>, context: Context, base: &Place<'tcx>, span: Span, flow_state: &Flows<'cx, 'gcx, 'tcx>, ) { </ins> // rust-lang/rust#21232: Until Rust allows reads from the // initialized parts of partially initialized structs, we // will, starting with the 2018 edition, reject attempts

} if let Some((prefix, mpi)) = shortest_uninit_seen { <ins> // Check for a reassignment into a uninitialized field of a union (for example, // after a move out). In this case, do not report a error here. There is an // exception, if this is the first assignment into the union (that is, there is // no move out from an earlier location) then this is an attempt at initialization // of the union - we should error in that case. let tcx = this.infcx.tcx; if let ty::TyKind::Adt(def, _) = base.ty(this.mir, tcx).to_ty(tcx).sty { if def.is_union() { if this.move_data.path_map[mpi].iter().any(|moi| { this.move_data.moves[*moi].source.is_predecessor_of( context.loc, this.mir, ) }) { return; } } } </ins> this.report_use_of_moved_or_uninitialized( context, InitializationRequiringAction::PartialAssignment,

fn gather_init(&mut self, place: &Place<'tcx>, kind: InitKind) { debug!("gather_init({:?}, {:?})", self.loc, place); <ins> let place = match place { // Check if we are assigning into a field of a union, if so, lookup the place // of the union so it is marked as initialized again. Place::Projection(box Projection { base, elem: ProjectionElem::Field(_, _), }) if match base.ty(self.builder.mir, self.builder.tcx).to_ty(self.builder.tcx).sty { ty::TyKind::Adt(def, _) if def.is_union() => true, _ => false, } => base, // Otherwise, lookup the place. _ => place, }; </ins> if let LookupResult::Exact(path) = self.builder.data.rev_lookup.find(place) { let init = self.builder.data.inits.push(Init { location: InitLocation::Statement(self.loc),

| = note: move occurs because `u` has type `U`, which does not implement the `Copy` trait <del> error[E0382]: use of moved value: `u` --> $DIR/borrowck-union-move-assign.rs:33:21 | LL |             let a = u.a; |                     --- value moved here LL |             u.a = A; LL |             let a = u.a; // OK |                     ^^^ value used here after move | = note: move occurs because `u` has type `U`, which does not implement the `Copy` trait error[E0382]: use of moved value: `u` --> $DIR/borrowck-union-move-assign.rs:39:21 | LL |             let a = u.a; |                     --- value moved here LL |             u.b = B; LL |             let a = u.a; // OK |                     ^^^ value used here after move | = note: move occurs because `u` has type `U`, which does not implement the `Copy` trait error: aborting due to 3 previous errors </del> <ins> error: aborting due to previous error </ins> For more information about this error, try `rustc --explain E0382`.

LL |     x.a = 1;  //~ ERROR |     ^^^^^^^ use of possibly uninitialized `x` <del> error: aborting due to previous error </del> <ins> error[E0594]: cannot assign to `x.b`, as `x` is not declared as mutable --> $DIR/reassignment_immutable_fields_overlapping.rs:23:5 | LL |     let x: Foo; |         - help: consider changing this to be mutable: `mut x` LL |     x.a = 1;  //~ ERROR LL |     x.b = 22; //~ ERROR |     ^^^^^^^^ cannot assign error: aborting due to 2 previous errors </ins> <del> For more information about this error, try `rustc --explain E0381`. </del> <ins> Some errors occurred: E0381, E0594. For more information about an error, try `rustc --explain E0381`. </ins>

<ins> // Copyright 2016 The Rust Project Developers. See the COPYRIGHT // file at the top-level directory of this distribution and at // http://rust-lang.org/COPYRIGHT. // // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your // option. This file may not be copied, modified, or distributed // except according to those terms. // compile-pass #![feature(untagged_unions)] struct A; struct B; union U { a: A, b: B, } fn main() { unsafe { { let mut u = U { a: A }; let a = u.a; u.a = A; let a = u.a; // OK } { let mut u = U { a: A }; let a = u.a; u.b = B; let a = u.a; // OK } } } </ins>