jiebi/CodeConvo huggingface dataset:
Change:
In current master branch pythonPackages.mysqlclient fails to build. Checkout nixpkgs on revision and run: system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:
Most likely caused by . Unfortunately, the config-tools are not very configuration friendly. Until is resolved, I would add to the package.
Unfortunately this does not change anything, still failing with the same error message..
Hmm, apparently just hardcodes the path without the ability to override it from the attrset passed to : Is that intentional, Until this is resolved, you can use :

Discussion:
jreOnly = true; }; <del> jdk = if stdenv.isDarwin then openjdk else jdkdistro true false; jre = jdkdistro false false; </del> <ins> jdk = if (stdenv.isDarwin || stdenv.system == "i686-linux" || stdenv.system == "x86_64-linux") then openjdk else jdkdistro true false; jre = if (stdenv.system == "i686-linux" || stdenv.system == "x86_64-linux") then openjre else jdkdistro false false; </ins> jrePlugin = lowPrio (jdkdistro false true);
Change:
In current master branch pythonPackages.mysqlclient fails to build. Checkout nixpkgs on revision and run: system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:
Most likely caused by . Unfortunately, the config-tools are not very configuration friendly. Until is resolved, I would add to the package.
Unfortunately this does not change anything, still failing with the same error message..
Hmm, apparently just hardcodes the path without the ability to override it from the attrset passed to : Is that intentional, Until this is resolved, you can use :

Discussion:
{ stdenv, fetchzip }: let <del> version = "3.1.1"; </del> <ins> version = "3.2.0"; </ins> in fetchzip { name = "emacs-all-the-icons-fonts-${version}";

stdenv.mkDerivation rec { pname = "plano-theme"; <del> version = "3.30-3"; </del> <ins> version = "3.32-1"; </ins> src = fetchFromGitHub { owner = "lassekongo83"; repo = pname; rev = "v${version}"; <del> sha256 = "1rb9whr5r2pj6fmwa9g0vdrfki3dqldnx85mpyq07jvxkipcdq6g"; </del> <ins> sha256 = "0p9j4p32489jb6d67jhf9x26my0mddcc6a174x713drch8zvb96l"; </ins> }; buildInputs = [ gdk_pixbuf gtk_engines ];

{ stdenv , buildPythonPackage <del> , fetchPypi </del> <ins> , fetchFromGitHub </ins> , mock , nose , pamqp

version = "1.0.0"; pname = "rabbitpy"; <del> src = fetchPypi { inherit pname version; sha256 = "54d33746d0c6a686417cd354346803945df0740b39fb92842d259387100db126"; </del> <ins> # No tests in the pypi tarball, so we directly fetch from git src = fetchFromGitHub { owner = "gmr"; repo = pname; rev = version; sha256 = "0fd80zlr4p2sh77rxyyfi9l0h2zqi2csgadr0rhnpgpqsy10qck6"; </ins> }; <del> buildInputs = [ mock nose ]; </del> propagatedBuildInputs = [ pamqp ]; <ins> checkInputs = [ mock nose ]; checkPhase = '' runHook preCheck rm tests/integration_tests.py # Impure tests requiring network nosetests tests runHook postCheck ''; postPatch = '' # See: https://github.com/gmr/rabbitpy/issues/118 substituteInPlace setup.py  --replace 'pamqp>=1.6.1,<2.0' 'pamqp' ''; </ins> meta = with stdenv.lib; { description = "A pure python, thread-safe, minimalistic and pythonic RabbitMQ client library";

{ stdenv, fetchFromGitHub, rustPlatform }: rustPlatform.buildRustPackage rec { <del> name = "lsd-${version}"; version = "0.13.0"; </del> <ins> pname = "lsd"; version = "0.14.0"; </ins> src = fetchFromGitHub { owner = "Peltoche"; repo = "lsd"; rev = version; <del> sha256 = "0s0pgnhzhkjm78cp12jscpld0m2mslin5yb273wzdvx4wax2s17z"; </del> <ins> sha256 = "1k054c4mz0z9knfn7kvvs3305z2g2w44l0cjg4k3cax06ic1grlr"; </ins> }; cargoSha256 = "0pg4wsk2qaljrqklnl5p3iv83314wmybyxsn1prvsjsl4b64mil9";

install -Dm644 -t $out/share/bash-completion/completions/ target/release/build/lsd-*/out/lsd.bash ''; <ins> # Some tests fail, but Travis ensures a proper build doCheck = false; </ins> meta = with stdenv.lib; { homepage = https://github.com/Peltoche/lsd; description = "The next gen ls command";
Change:
broke all of my nginx vhosts that serve content on port 80 and do not automatically redirect the client to port 443. This includes all of my sites that use auto-ACME renewal from Let's Encrypt. Listen directives that used to look like this: now look like this: Clients such as and the Let's Encrypt certbot don't seem to support/expect http2 on port 80. To confirm that this is the issue, I've disabled the nginx NixOS module from nixpkgs master and replaced it with a version identical to the NixOS module prior to , and port 80 vhosts work again. [edit for clarity]
Looks like this is as simple as changing http2 to default to false in or setting it yourself in your vhost block. Is there a way we can make this default to true if we're using SSL and default to false if we're not but not override it like the previous functionality?
I feel like the simplest way to support this would be to have a separate setting to specifically indicate whether you want http2 where . I'm not aware of any major browser that supports HTTP/2 without encryption, so for most users a listen directive without ssl but with http2 is highly undesirable. Given that consideration, having to put an extra option in each vhost when http2 is wanted without encryption does not seem unreasonable. I would do something like

Discussion:
listenString = { addr, port, ssl, extraParameters ? [], ... }: "listen ${addr}:${toString port} " + optionalString ssl "ssl " <del> + optionalString vhost.http2 "http2 " </del> <ins> + optionalString (ssl && vhost.http2) "http2 " </ins> + optionalString vhost.default "default_server " + optionalString (extraParameters != []) (concatStringsSep " " extraParameters) + ";";
Change:
If you start without a config file, then it starts fine. But when later you exit it and start again, then it crashes with: This error was fixed in but it's not part of tool official releases. (Note that the original upstream repo no longer exists; so we should switch to fork of it. -env -f . -i python3.6-turses it with "q". Please run and paste the results.

Discussion:
<del> { stdenv, python36Packages }: </del> <ins> { stdenv, fetchpatch, python36Packages }: </ins> with stdenv.lib;

checkInputs = [ mock pytest coverage tox ]; propagatedBuildInputs = [ urwid tweepy future ]; <ins> patches = [ (fetchpatch { url = "https://github.com/louipc/turses/commit/be0961b51f502d49fd9e2e5253ac130e543a31c7.patch"; sha256 = "17s1n0275mcj03vkf3n39dmc09niwv4y7ssrfk7k3vqx22kppzg3"; }) ]; </ins> checkPhase = '' TMP_TURSES=`echo turses-$RANDOM` mkdir $TMP_TURSES

rm -rf $TMP_TURSES ''; <del> patchPhase = '' </del> <ins> postPatch = '' </ins> sed -i -e 's|urwid==1.3.0|urwid==${getVersion urwid}|' setup.py sed -i -e "s|future==0.14.3|future==${getVersion future}|" setup.py sed -i -e "s|tweepy==3.3.0|tweepy==${getVersion tweepy}|" setup.py

''; meta = with stdenv.lib; { <del> homepage = https://github.com/alejandrogomez/turses; </del> <ins> homepage = https://github.com/louipc/turses; </ins> description = "A Twitter client for the console"; license = licenses.gpl3; maintainers = with maintainers; [ garbas ];
Change:
If you start without a config file, then it starts fine. But when later you exit it and start again, then it crashes with: This error was fixed in but it's not part of tool official releases. (Note that the original upstream repo no longer exists; so we should switch to fork of it. -env -f . -i python3.6-turses it with "q". Please run and paste the results.

Discussion:
<del> { stdenv, python3Packages }: </del> <ins> { stdenv, fetchpatch, python3Packages }: </ins> with stdenv.lib; with python3Packages;

buildInputs = [ mock pytest coverage tox ]; propagatedBuildInputs = [ urwid tweepy future ]; <ins> patches = [ (fetchpatch { url = "https://github.com/louipc/turses/commit/be0961b51f502d49fd9e2e5253ac130e543a31c7.patch"; sha256 = "17s1n0275mcj03vkf3n39dmc09niwv4y7ssrfk7k3vqx22kppzg3"; }) ]; </ins> checkPhase = '' TMP_TURSES=`echo turses-$RANDOM` mkdir $TMP_TURSES

rm -rf $TMP_TURSES ''; <del> patchPhase = '' </del> <ins> postPatch = '' </ins> sed -i -e 's|urwid==1.3.0|urwid==${getVersion urwid}|' setup.py sed -i -e "s|future==0.14.3|future==${getVersion future}|" setup.py sed -i -e "s|tweepy==3.3.0|tweepy==${getVersion tweepy}|" setup.py

''; meta = with stdenv.lib; { <del> homepage = https://github.com/alejandrogomez/turses; </del> <ins> homepage = https://github.com/louipc/turses; </ins> description = "A Twitter client for the console"; license = licenses.gpl3; maintainers = with maintainers; [ garbas ];
Change:
We use ipxe based on clever's setup () like this: This causes the following build failure on 19.03: Googling around for "Unrecognised relocation type 4" and ipxe returns , indicating it's fixed upstream (it is, I have a PR coming). See the override above system: host os: multi-user?: sandbox: version: channels(root): channels(atu): nixpkgs:

Discussion:
}: let <del> date = "20180220"; rev = "47849be3a900c546cf92066849be0806f4e611d9"; </del> <ins> date = "20190310"; rev = "b6ffe28a21c53a0946d95751c905d9e0b6c3b630"; </ins> in stdenv.mkDerivation {

src = fetchgit { url = git://git.ipxe.org/ipxe.git; <del> sha256 = "1f4pi1dp2zqnrbfnggnzycfvrxv0bqgw73dxbyy3hfy4mhdj6z45"; </del> <ins> sha256 = "1s8sy75lpx8zq60wc0i35d8c1wwm1rq3scxpkq31623d097mch59"; </ins> inherit rev; };
Change:
The Haskell package chell does not build due to missing dependency . I think this the culprit: Try to get a nix-shell with purescript and nixpgks pinned to . Please run and paste the results. system: host os: multi-user?: sandbox: version: channels(stefan): nixpkgs: (Note that this fails with a pinned nixpkg, see above.)

Discussion:
# }); libnix = dontCheck super.libnix; <del> # https://github.com/jmillikin/chell/issues/1 chell = super.chell.override { patience = self.patience_0_1_1; }; </del> # The test suite tries to mess with ALSA, which doesn't work in the build sandbox. xmobar = dontCheck super.xmobar;
Change:
kodiPlain.aarch64-linux is failing to build on master and release-18.09. This is a problem because new users trying NixOS on their Raspberry Pis won't be able to install Kodi.
was the first failing build on release-18.09. The changes since the last successful build are all JDK/JRE related: suggests a problem with Freetype: build/video/video.a() CTeletextDecoder::EndDecoder(): error: undefined reference to 'FTCManagerDone' build/video/video.a() CTeletextDecoder::RenderCharIntern(TextRenderInfot, int, TextPageAttrt, int, int): error: undefined reference to 'FTCSBitCacheLookup' and I see that from that log file that cmake has managed to grab freetype from the JRE (unexpected!): -- Found FreeType: /nix/store/3vslpb5ksghr02vb58vvpv2c3hv1ig32-adoptopenjdk-jre-hotspot-bin- (found version "22.0.16") Compare that to , in which cmake found freetype from freetype (as expected): -- Found FreeType: /nix/store/p14jcjs9ij0jfd9pgyq7gxpdl8k1kgj1-freetype- (found version "22.0.16")
OpenJDK 11.0.1 did not contain libfreetype, but OpenJDK 11.0.2 does contain libfreetype: i; tar tf $i | grep -i freetype; done OpenJDK11U- OpenJDK11U- jdk-11.0.2+7- jdk-11.0.2+7- OpenJDK11U- jdk-11.0.2+9- jdk-11.0.2+9- ... so of the two aforementioned changes ( ), the upgrade to 11.0.2 likely triggered this: commit .
has been merged to master, and now kodiPlain.aarch64-linux is building ( ). Woo! Let's get this in 18.09 and 19.03
With and being merged, this can be closed :-)

Discussion:
# Remove some broken manpages. rm -rf $out/man/ja* <ins> # Remove embedded freetype to avoid problems like # https://github.com/NixOS/nixpkgs/issues/57733 rm $out/lib/libfreetype.so </ins> # for backward compatibility ln -s $out $out/jre
Change:
is non-deterministic if given both and . Here are a couple runs back-to-back: However, when I make this and :
Interestingly, itself is deterministic, despite being non-deterministic (at least from the command line). This is pretty curious.
Perhaps environment variables come into play? Does the shell script take care to clear the environment like a nix build does?
So, I tried diffing two of the outputs: That looks an awful lot like part of my git hooks that automatically generate tags. Sure enough: I'm of the opinion that we should override in the package, to prevent these kinds of problems. Thoughts?
Seems like those scripts in general should almost completely clear out your environment
Yeah, I don't know how much to get rid of, considering that someone may want to get the hash of their private repos or something.

Discussion:
wrapArgs="$wrapArgs --prefix PATH : $dep/bin" done wrapArgs="$wrapArgs --prefix PATH : ${gnused}/bin" <ins> wrapArgs="$wrapArgs --set HOME : /homeless-shelter" </ins> wrapProgram $out/bin/$name $wrapArgs }
Change:
Support for C.UTF-8 was to , however, not to . Including as a or during run-time may break as mentioned in and Please run and paste the results. cc
Yeah. Make sense to add it to glibcLocales too. I had the intention it would actually look in both places. But maybe this is not the case if is exported as environment variable.
Also checkout
This is fixed in staging and staging-19.03.
Great, thanks!

Discussion:
'' mkdir -p $TMPDIR/"${buildPackages.stdenv.cc.libc.out}/lib/locale" <ins> echo 'C.UTF-8/UTF-8 ' >> ../glibc-2*/localedata/SUPPORTED </ins> # Hack to allow building of the locales (needed since glibc-2.12) sed -i -e 's,^$(rtld-prefix) $(common-objpfx)locale/localedef,localedef --prefix='$TMPDIR',' ../glibc-2*/localedata/Makefile ''
Change:
TEXMF defines the order in which files are read in The idea is that TEXMFSYSVAR and TEXMFCONFIG files take precedence over files distributed with TEXMFDIST, so there is a way for the user to override configuration files. Our lists: This seems all fine, except that our derivation also makes TEXMFLOCAL point to TEXMFDIST as well, and this destroys override-ability. My suggestion is to use a separate and empty $out/share/texmf-local for TEXMFLOCAL.
Could you please provide an example of the override that doesn't work?
I dropped my customization here: It boils down to adding a custom package (minionpro availble for my ) and running: in postBuild.
I investigated your override. I see that you sneak the original , then add your font to it and regenerate the mappings which go to share/texmf-var. At the same time our texlive setup just reuses prebuilt maps provided by (for pdftex), individual font packages and others and those are installed into share/texmf which happens to be also pointed by TEXMFLOCAL. I also now discover that the line does nothing for us. Your change makes sense to me. Makes me wonder if we could do better. For example, not deleting should not hurt anything. I could not find any way to automatically scan for new entries for The Gentoo documentation mentions [1] concatenating it from /etc/texmf/updmap.d. [1]
First of all thank you for taking such a careful look at my code snippet. I really appreciate it! First, yes, I sneak out and later sneak back in. I do think that there are no adverse side-effects from not deleting in texlive.combine. I will submit a PR to remove it. This will minimize my postBuild override to just: That looks much cleaner :) As there is no real "hooks" functionality in our texlive package derivation, it seems to be a good idea to optimistically merge (by concatenation) separate snippets. I will file a separate issue to discuss this.
Thank you!

Discussion:
export TEXMFSYSVAR="$out/share/texmf-var" export PERL5LIB="$out/share/texmf/scripts/texlive" '' + <del> # patch texmf-{dist,local} -> texmf to be sure </del> <ins> # patch texmf-dist  -> $out/share/texmf # patch texmf-local -> $out/share/texmf-local </ins> # TODO: perhaps do lua actions? # tried inspiration from install-tl, sub do_texmf_cnf ''

rm ./texmfcnf.lua sed  -e 's,texmf-dist,texmf,g'  <del> -e 's,texmf-local,texmf,g'  -e "s,(TEXMFLOCAL[ ]*=[ ]*)[^,]*,1"$out/share/texmf",g"  </del> <ins> -e "s,(TEXMFLOCAL[ ]*=[ ]*)[^,]*,1"$out/share/texmf-local",g"  </ins> -e "s,$SELFAUTOLOC,$out,g"  -e "s,selfautodir:/,$out/share/,g"  -e "s,selfautodir:,$out/share/,g" 

rm ./texmf.cnf sed  -e 's,texmf-dist,texmf,g'  <del> -e 's,texmf-local,texmf,g'  </del> -e "s,$SELFAUTOLOC,$out,g"  -e "s,$SELFAUTODIR,$out/share,g"  -e "s,$SELFAUTOPARENT,$out/share,g" 

patchCnfLua "./texmfcnf.lua" <ins> mkdir $out/share/texmf-local </ins> rm updmap.cfg ) '' +
Change:
The issue is due to an inverted logic error marking not supported on darwin when it should be marked as only supported darwin instead. cc an expression depending on Nix 2.0.4 on x86_64-darwin on Travis
Tried this again with travis with nixpkgs pinned to this commit, but it still fails for some reason, any ideas?
That commit configures which generates that file, so it takes another run of that tool before the configured changes take effect. has the update.
Is a full regen expected on 19.03 as well before release? Right now, the job does not eval because of this, but I guess we don't need to manually poke it if it's going to be regenerated. :)
I don't think we'll re-generate on the release branch any time soon, so manually submitted changes there are probably the way to go. I might do a complete update at some point in the future, but I can't say for sure. Updating a branch that's supposed to be stable is a lot of work.

Discussion:
gi-ostree:                                    [ x86_64-darwin ] gtk-mac-integration:                          [ i686-linux, x86_64-linux ] hcwiid:                                       [ x86_64-darwin ] <del> hfsevents:                                    [ x86_64-darwin ] </del> HFuse:                                        [ x86_64-darwin ] hommage-ds:                                   [ i686-linux, x86_64-linux, x86_64-darwin ] lio-fs:                                       [ x86_64-darwin ]

libraryToolDepends = [ CoreServices ]; description = "File/folder watching for OS X"; license = stdenv.lib.licenses.bsd3; <del> platforms = stdenv.lib.platforms.none; </del> <ins> platforms = [ "x86_64-darwin" ]; </ins> }) {inherit (pkgs.darwin.apple_sdk.frameworks) Cocoa; inherit (pkgs.darwin.apple_sdk.frameworks) CoreServices;};
Change:
The packages fails to build on a recent with the following error: - system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:

Discussion:
substituteInPlace setup.py  --replace "pathlib==1.0.1" "pathlib>=1.0.0,<2.0.0"  --replace "plac>=0.9.6,<1.0.0" "plac>=0.9.6"  <del> --replace "msgpack-numpy<0.4.4" "msgpack-numpy" </del> <ins> --replace "msgpack-numpy<0.4.4" "msgpack-numpy"  --replace "wheel>=0.32.0,<0.33.0" "wheel"  --replace "wrapt>=1.10.0,<1.11.0" "wrapt"  --replace "msgpack>=0.5.6,<0.6.0" "msgpack" </ins> ''; # Cannot find cython modules.
Change:
Installing NixOS on virtualbox with the minimal install CD. If I chose the default boot option, graphics would stop working around "NixOS Stage 1. Changing it to the (nomodeset), graphics started working. After installing NixOS and rebooting, graphics stopped working again at some point during systemd boot. I messed around with the graphics settings, changing the Graphics Controller from to fixed both issues. I was able to boot with the CD with the default GRUB boot option and I was able to boot using NixOS that was installed to the drive. Setup a VirtualBox Machine. I used 4096 MB or RAM. I set the CPU count to 4. You can double check that the problematic graphics controller is being used Download the NixOS minimal install CD, add it to the VirtualBox machine Start the machine Let it boot with the default boot option Graphics will stop working around NixOS Stage 1 You can workaround the issue in this case by selecting the option. Otherwise, you can change the Graphics Controller to and that should also fix it. My guess is that the default linux kernel doesn't support the VMSVGA graphics controller. The fix is probably just an extra config option in NixOS's default kernel config.
I booted with the graphics controller and the controller and captured the kernel log by adding to the kernel command line. I'm attaching both log files here. Even though the continued to graphics were completely hosed in the "NixOS State 1" part of boot, whch is near the beginning of the log file. The most noteworthy lines that could be indicating what is happening are these 2 lines in the logfile that don't appear in the logfile: As it's related to DRM seems like it's likely reporting an error related to why graphics completely stop working.
I'm getting the same issue with a Macbook pro.

Discussion:
VGA_SWITCHEROO         = yes; # Hybrid graphics support DRM_GMA600             = yes; DRM_GMA3600            = yes; <ins> DRM_VMWGFX_FBCON       = yes; </ins> # necessary for amdgpu polaris support DRM_AMD_POWERPLAY = whenBetween "4.5" "4.9" yes; # (experimental) amdgpu support for verde and newer chipsets
Change:
Can't simply apply the upstream commits, unfortunately (AFAICT). This looks pretty serious!
Thank you!! :sparkle:

Discussion:
{ config, stdenv, lib, fetchurl, pkgconfig, zlib, expat, openssl, autoconf , libjpeg, libpng, libtiff, freetype, fontconfig, libpaper, jbig2dec <del> , libiconv, ijs, lcms2 </del> <ins> , libiconv, ijs, lcms2, fetchpatch </ins> , cupsSupport ? config.ghostscript.cups or (!stdenv.isDarwin), cups ? null , x11Support ? cupsSupport, xlibsWrapper ? null # with CUPS, X11 only adds very little }:

patches = [ ./urw-font-files.patch ./doc-no-ref.diff <ins> (fetchpatch { name = "CVE-2019-6116"; url = "http://git.ghostscript.com/?p=ghostpdl.git;a=patch;h=d3537a54740d78c5895ec83694a07b3e4f616f61"; sha256 = "1hr8bpi87bbg1kvv28kflmfh1dhzxw66p9q0ddvbrj72qd86p3kx"; }) </ins> ]; outputs = [ "out" "man" "doc" ];
Change:
Can't simply apply the upstream commits, unfortunately (AFAICT). This looks pretty serious!
Thank you!! :sparkle:

Discussion:
{ stdenv, lib, fetchurl, pkgconfig, zlib, expat, openssl, autoconf , libjpeg, libpng, libtiff, freetype, fontconfig, libpaper, jbig2dec <del> , libiconv, ijs </del> <ins> , libiconv, ijs, fetchpatch </ins> , x11Support ? false, xlibsWrapper ? null , cupsSupport ? false, cups ? null }:

patches = [ ./urw-font-files.patch ./doc-no-ref.diff <ins> (fetchpatch { name = "CVE-2019-6116"; url = "http://git.ghostscript.com/?p=ghostpdl.git;a=patch;h=d3537a54740d78c5895ec83694a07b3e4f616f61"; sha256 = "1hr8bpi87bbg1kvv28kflmfh1dhzxw66p9q0ddvbrj72qd86p3kx"; }) </ins> ]; outputs = [ "out" "man" "doc" ];
Change:
Can't simply apply the upstream commits, unfortunately (AFAICT). This looks pretty serious!
Thank you!! :sparkle:

Discussion:
{ config, stdenv, lib, fetchurl, pkgconfig, zlib, expat, openssl, autoconf , libjpeg, libpng, libtiff, freetype, fontconfig, libpaper, jbig2dec <del> , libiconv, ijs </del> <ins> , libiconv, ijs, fetchpatch </ins> , cupsSupport ? config.ghostscript.cups or (!stdenv.isDarwin), cups ? null , x11Support ? cupsSupport, xlibsWrapper ? null # with CUPS, X11 only adds very little }:

patches = [ ./urw-font-files.patch ./doc-no-ref.diff <ins> (fetchpatch { name = "CVE-2019-6116"; url = "http://git.ghostscript.com/?p=ghostpdl.git;a=patch;h=d3537a54740d78c5895ec83694a07b3e4f616f61"; sha256 = "1hr8bpi87bbg1kvv28kflmfh1dhzxw66p9q0ddvbrj72qd86p3kx"; }) </ins> ]; outputs = [ "out" "man" "doc" ];