Change:
Describe the bug Since some day, clementine refuse to work. I bisected the error to the commit . The error message in the terminal is: realloc(): invalid pointer fish : Tâche , './result/bin/clementine' terminée par le signal SIGABRT (Abandon) To Reproduce go to a nixpkgs git tree Expected behavior clementine start as expected Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Metadata system: host os: multi-user?: sandbox: version: channels(root): channels(marius): nixpkgs: Maintainer information:
Looks like we are hitting here. cc
I could have sworn I tested this… let me see if I can reproduce this issue.
Yup, and reverting the projectm fix makes it run again. Hm… I was really sure I tested clementine. I don't think I'll have time to look into this properly until the weekend, so as a quick fix, you can revert the projectm update, if you want to.

Discussion:
<del> diff --git a/CMakeLists.txt b/CMakeLists.txt index 23070d9..83b6772 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -275,8 +275,6 @@ optional_component(LIBPULSE ON "Pulse audio integration" optional_component(VISUALISATIONS ON "Visualisations") if(NOT HAVE_SPOTIFY_BLOB AND NOT CRYPTOPP_FOUND) -  message(FATAL_ERROR "Either crypto++ must be available or the non-GPL Spotify " -          "code must be compiled in") elseif(CRYPTOPP_FOUND) set(HAVE_CRYPTOPP ON) set(HAVE_SPOTIFY_DOWNLOADER ON) @@ -434,7 +432,6 @@ if(HAVE_BREAKPAD) endif(HAVE_BREAKPAD) if(HAVE_SPOTIFY_BLOB) -  add_subdirectory(ext/clementine-spotifyblob) endif(HAVE_SPOTIFY_BLOB) if(HAVE_MOODBAR) </del>

<del> { stdenv, fetchFromGitHub, fetchpatch, boost, cmake, chromaprint, gettext, gst_all_1, liblastfm </del> <ins> { stdenv, mkDerivation, fetchFromGitHub, fetchpatch, boost, cmake, chromaprint, gettext, gst_all_1, liblastfm , qtbase, qtx11extras </ins> , taglib, fftw, glew, qjson, sqlite, libgpod, libplist, usbmuxd, libmtp , libpulseaudio, gvfs, libcdio, libechonest, libspotify, pcre, projectm, protobuf , qca2, pkgconfig, sparsehash, config, makeWrapper, gst_plugins }:

withCD = config.clementine.cd or true; withCloud = config.clementine.cloud or true; <del> version = "1.3.1"; </del> <ins> version = "1.4.0rc1"; </ins> src = fetchFromGitHub { owner = "clementine-player"; repo = "Clementine"; rev = version; <del> sha256 = "0i3jkfs8dbfkh47jq3cnx7pip47naqg7w66vmfszk4d8vj37j62j"; </del> <ins> sha256 = "1rqk0hrsn8f8bjk0j0vq1af0ygy6xx7qi9fw0jjw2cmj6kzckyi2"; </ins> }; patches = [ ./clementine-spotify-blob.patch <del> # Required so as to avoid adding libspotify as a build dependency (as it is # unfree and thus would prevent us from having a free package). ./clementine-spotify-blob-remove-from-build.patch (fetchpatch { # Fix w/gcc7 url = "https://github.com/clementine-player/Clementine/pull/5630.patch"; sha256 = "0px7xp1m4nvrncx8sga1qlxppk562wrk2qqk19iiry84nxg20mk4"; }) (fetchpatch { # Fixes compilation with chromaprint >= 1.4 url = "https://github.com/clementine-player/Clementine/commit/d3ea0c8482dfd3f6264a30cfceb456076d76e6cd.patch"; sha256 = "1ifrs5aqdzw16jbnf0z1ilir20chdnr9k5n21r99miq9hzjpbh12"; }) </del> ]; nativeBuildInputs = [ cmake pkgconfig ];

protobuf qca2 qjson <ins> qtbase qtx11extras </ins> sqlite taglib ]

-e 's,libprotobuf.a,protobuf,g' ''; <del> free = stdenv.mkDerivation { </del> <ins> free = mkDerivation { </ins> pname = "clementine-free"; inherit version; inherit src patches nativeBuildInputs postPatch;

# gst_plugins needed for setup-hooks buildInputs = buildInputs ++ [ makeWrapper ] ++ gst_plugins; <del> cmakeFlags = [ "-DUSE_SYSTEM_PROJECTM=ON" ]; </del> <ins> preConfigure = '' rm -rf ext/{,lib}clementine-spotifyblob ''; cmakeFlags = [ "-DUSE_SYSTEM_PROJECTM=ON" "-DSPOTIFY_BLOB=OFF" ]; </ins> enableParallelBuilding = true;

}; # Unfree Spotify blob for Clementine <del> unfree = stdenv.mkDerivation { </del> <ins> unfree = mkDerivation { </ins> pname = "clementine-blob"; inherit version; # Use the same patches and sources as Clementine <del> inherit src nativeBuildInputs postPatch; patches = [ ./clementine-spotify-blob.patch ]; </del> <ins> inherit src nativeBuildInputs patches postPatch; </ins> buildInputs = buildInputs ++ [ libspotify makeWrapper ]; # Only build and install the Spotify blob

<del> { stdenv, fetchurl, qt4, pkgconfig, libsamplerate, fftwSinglePrec, which, cmake </del> <ins> { stdenv, fetchurl, pkgconfig, which, cmake , fftwSinglePrec, libsamplerate, qtbase </ins> , darwin }: let version = "1.1.0"; in

sha256 = "1j34xc30vg7sfszm2jx9mlz9hy7p1l929fka9wnfcpbib8gfi43x"; }; <ins> postPatch = '' substituteInPlace CMakeLists.txt  --replace 'find_package(Qt5Core QUIET)'  'find_package(Qt5 REQUIRED COMPONENTS Core Network Sql Test Xml)' ''; </ins> prefixKey = "--prefix "; <del> propagatedBuildInputs = [ qt4 libsamplerate fftwSinglePrec ]; </del> nativeBuildInputs = [ pkgconfig which cmake ]; <del> buildInputs = stdenv.lib.optional stdenv.isDarwin darwin.apple_sdk.frameworks.SystemConfiguration; </del> <ins> buildInputs = [ fftwSinglePrec libsamplerate qtbase ] ++ stdenv.lib.optional stdenv.isDarwin darwin.apple_sdk.frameworks.SystemConfiguration; </ins> meta = with stdenv.lib; { homepage = "https://github.com/lastfm/liblastfm"; repositories.git = "git://github.com/lastfm/liblastfm.git"; description = "Official LastFM library"; <del> inherit (qt4.meta) platforms; </del> <ins> platforms = platforms.unix; </ins> maintainers =  [ maintainers.phreedom ]; license = licenses.gpl3; };

liblastfmSF = callPackage ../development/libraries/liblastfmSF { }; <del> liblastfm = callPackage ../development/libraries/liblastfm { }; </del> <ins> liblastfm = libsForQt5.callPackage ../development/libraries/liblastfm { }; </ins> liblcf = callPackage ../development/libraries/liblcf { };