Change:
Describe the bug VirtualBox kernel modules are not able to compile with . Notify maintainers Metadata Maintainer information: /cc
Upstream bug:
Well, seriously thinking about using full QEMU + KVM. I can confirm the bug here, but from a quick read, there is still no version with this fix (test versions only), so I'm not sure of the best way here, we can add a patch for now (if the maintainers agree) or wait for the next release.
Yeah, upstream seems pretty bad in keeping up to date with kernel updates. Assuming the patches circulating in the issue tracker don't break the build in older kernels, 'ing them in nixpkgs before there's a release is fine. Can you send a PR?
I can try, will search how to first lol
Ok, after a few rounds I found what to change, reading it calmly, there seems to be 3 patches involved in the problem, one to fix the initial problem described in that issue and two to fix the DRM and shared folders in this kernel version. It's pretty late around here so I'm leaving my laptop compiling with the initial patch to test, as my biggest use of the Virtualbox is with Vagrant it is quite possible that I won't find the other two problems, but I'll investigate as well. First patch is this one: (Same as ) A PR would have to change these lines: I'm using this expression to test the patch:
People, for me, running the latest version of Zen, the first patch was all I needed, graphics ok, shared folder ok. I tested a Windows 10 previously created and two Debian 10 (via vagrant) one already provisioned and another new. Can anyone else test before sending a PR? In the meantime I will look for the possibility of using an IF for kernel versions = 5.10 and applying the patch only to them. !
Patches should be applied unconditionally (so they fail loudly when they don't apply), not only in corner cases. They of course then needs to be written to work with both kernels (but that should be the case here)
Okay, I got lost here, in theory this patch is only necessary from 5.10 onwards, so should we test it on a lower one and if everything works add it? It can also have some other side effect, for now I'm just using via vagrant (as I usually do) and I would like someone else to test it too.
Yes, but the patch includes ifdefs, so it should work on both kernel versions. Only adding patches in some conditions is discouraged in nixpkgs. After doing version bumps, patches might not apply cleanly anymore, but it's not caught during review if only tested on a variant where the patch is "hidden by the condition". In the case of virtualbox, imagine a reviewer testing manually while on a stable kernel. They'll never realize the patch doesn't apply anymore, as it's not in the derivation they built.
First, happy new year! Second, thanks for explaining, I understand. As I am not at the computer these days, I am going to do a quick test with this patch in 5.10 Vanilla and 5.9, if everything goes well I will return with PR to merge this patch. Thank you! Future note to myself: Read the entire patch file.
Created PR
Opened , which include the latest release with fix.
Let's close this in favor of
I think the issue should remain opened until the issue is fixed in master.
Indeed - I confused this with Sorry!

Discussion:
buildType = "release"; # Use maintainers/scripts/update.nix to update the version and all related hashes or # change the hashes in extpack.nix and guest-additions/default.nix as well manually. <del> version = "6.1.16"; </del> <ins> version = "6.1.18"; </ins> iasl' = iasl.overrideAttrs (old: rec { inherit (old) pname;

src = fetchurl { url = "https://download.virtualbox.org/virtualbox/${version}/VirtualBox-${version}.tar.bz2"; <del> sha256 = "49c1990da16d8a3d5bda8cdb961ec8195a901e67e4c79aea44c1521a5fc2f9f1"; </del> <ins> sha256 = "108d42b9b391b7a332a33df1662cf7b0e9d9a80f3079d16288d8b9487f427d40"; </ins> }; outputs = [ "out" "modsrc" ];

# Manually sha256sum the extensionPack file, must be hex! # Thus do not use `nix-prefetch-url` but instead plain old `sha256sum`. # Checksums can also be found at https://www.virtualbox.org/download/hashes/${version}/SHA256SUMS <del> let value = "9802482b77b95a954cb5111793da10d009009a4e9a9c4eaa4bd1ae5dafe9db46"; </del> <ins> let value = "d609e35accff5c0819ca9be47de302abf094dc1b6d4c54da8fdda639671f267e"; </ins> in assert (builtins.stringLength value) == 64; value; meta = {

src = fetchurl { url = "http://download.virtualbox.org/virtualbox/${version}/VBoxGuestAdditions_${version}.iso"; <del> sha256 = "88db771a5efd7c048228e5c1e0b8fba56542e9d8c1b75f7af5b0c4cf334f0584"; </del> <ins> sha256 = "904432eb331d7ae517afaa4e4304e6492b7947b46ecb8267de7ef792c4921b4c"; </ins> }; KERN_DIR = "${kernel.dev}/lib/modules/${kernel.modDirVersion}/build";