jiebi/CodeConvo huggingface dataset:
Change:
Looks like / require referenced licenses to match attribute name of . This is broken for SSPL license and for some packages that have inline license attrset. Steps to reproduce the behavior: (can use also ) in NixOS global configuration. to build configuration. Can build your system unless it references package with license (I guess Mongodb related stuff) and which is referenced in . Can reference licenses in-lined in packages . E.g. (or its direct value) This was found out in attempt to use pre-approved list of "safe" open source licenses by adding in all that are not on the list but present in . But have next definition (notice upper case in ): In order to fully implement pre-approved "allow list" (different from ) it is required to be able to reference licenses that are in package meta but not in . <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --MongoDB maintainers: Please run and paste the result. system: host os: multi-user?: sandbox: version: channels(root): channels(nikolay): nixpkgs:
Why do we even have this restriction in a first place? I'm not sure what it solves. And is silent about side-effect of using in-place license which is that it is not usable in . Tracing back to when it was introduced led me to . But original code had no such restrictions: (this is roughly what I expected when I tried to use ) Can we remove this restriction? This will allow to use licenses out of (my attempt to patch with overlay was no successful).
do you remember why you this in ?
Oops I missed this question, sorry. I don't remember, but I expect that I the check to make sure that all licenses are maintained in the central registry.

Discussion:
allowlist = config.allowlistedLicenses or config.whitelistedLicenses or []; blocklist = config.blocklistedLicenses or config.blacklistedLicenses or []; <del> onlyLicenses = list: lib.lists.all (license: let l = lib.licenses.${license.shortName or "BROKEN"} or false; in if license == l then true else throw ''‘${showLicense license}’ is not an attribute of lib.licenses'' ) list; </del> areLicenseListsValid = if lib.mutuallyExclusive allowlist blocklist then <del> assert onlyLicenses allowlist; assert onlyLicenses blocklist; true </del> <ins> true </ins> else throw "allowlistedLicenses and blocklistedLicenses are not mutually exclusive.";
Change:
add glooctl is the official cli tool to manage it Metadata homepage URL: source URL: license: Apache-2.0 License platforms: linux, darwin

Discussion:
<ins> { lib, buildGoModule, fetchFromGitHub, installShellFiles }: buildGoModule rec { pname = "glooctl"; version = "1.10.6"; src = fetchFromGitHub { owner = "solo-io"; repo = "gloo"; rev = "v${version}"; sha256 = "sha256-t63tK0hwbVnUP9UxS8g3uzL3rBvKR10vu1E85mNV3E0="; }; subPackages = [ "projects/gloo/cli/cmd" ]; vendorSha256 = "sha256-IBuAUKbX1esx2p4Q/b3UxQH9S3VVNYZcn5vRKtmhO0A="; nativeBuildInputs = [ installShellFiles ]; postInstall = '' mv $out/bin/cmd $out/bin/glooctl export HOME=$TMP installShellCompletion --cmd glooctl  --bash <($out/bin/glooctl completion bash)  --zsh <($out/bin/glooctl completion zsh) ''; ldflags = [ "-s" "-w" "-X github.com/solo-io/gloo/pkg/version.Version=${version}" ]; meta = with lib; { description = "glooctl is the unified CLI for Gloo"; homepage = "https://docs.solo.io/gloo-edge/latest/reference/cli/glooctl/"; license = licenses.asl20; maintainers = with maintainers; [ nelsonjeppesen ]; }; } </ins>

gfshare = callPackage ../tools/security/gfshare { }; <ins> glooctl = callPackage ../applications/networking/cluster/glooctl { }; </ins> gobgp = callPackage ../tools/networking/gobgp { }; gofu = callPackage ../applications/misc/gofu { };
Change:
Linux config: enable SNDSOCINTELSOUNDWIRESOFMACH module Enable for SNDSOCINTELSOUNDWIRESOFMACH kernel module. This is used on some 10/11th gen Intel laptops such as the XPS 17 97[00|10] Enable SNDSOCINTELUSERFRIENDLYLONGNAMES as well - this is required dep The Dell XPS 9700 and 9710 laptops do not have sound without this module. Also, on my 9710, the kernel hung on shutdown without enabling. I'd expect other laptops use this driver as well Requested by nixos-hardware admin enabled in 2020 I was unable to find to correct git repo for Ubuntu's configuration but booted a Ubuntu 21.10 and verified this module is enabled Metadata homepage URL: source URL: license: gpl2-only platforms: linux

Discussion:
# Enable Sound Open Firmware support } // optionalAttrs (stdenv.hostPlatform.system == "x86_64-linux" && versionAtLeast version "5.5") { <ins> SND_SOC_INTEL_SOUNDWIRE_SOF_MACH       = whenAtLeast "5.10" module; SND_SOC_INTEL_USER_FRIENDLY_LONG_NAMES = whenAtLeast "5.10" yes; # dep of SOF_MACH </ins> SND_SOC_SOF_TOPLEVEL              = yes; SND_SOC_SOF_ACPI                  = module; SND_SOC_SOF_PCI                   = module;
Change:
The build is failing on master; it has been reproduced at . An example of the failure is below: There is a new release () which also doesn't pass, so I didn't send the PR as it'd fail on CI. Steps to reproduce the behavior:
Those aren't the failing tests (BROKEN means they are known to fail). These are the real failures: Looks like a broken test directory setup in the build environment.
fixed in the next point release I think
prior work

Discussion:
sha256 = "wfLO7kf2iXESItcgWvKj/npKnYwy5OCyStZviN9qR9M="; }; <ins> patches = [ # https://nmbug.notmuchmail.org/nmweb/show/87o84iza9r.fsf%40starbuck.i-did-not-set--mail-host-address--so-tickle-me ./test-fix-support-for-gpgsm-in-gnupg-2.3.patch ]; </ins> nativeBuildInputs = [ pkg-config doxygen                   # (optional) api docs

<ins> From a642ad542e3d3f34e949c5c66923ca8a6e6cbbd8 Mon Sep 17 00:00:00 2001 From: Stig Palmquist <stig@stig.io> Date: Tue, 11 Jan 2022 13:23:13 +0100 Subject: [PATCH] test: fix support for gpgsm in gnupg 2.3 gpgsm --list-keys output changed the label for fingerprints from "fingerprint: " to "sha[12] fpr: " breaking tests with gnupg 2.3. this adds support for both. --- test/test-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 6bc0b723..3de608f9 100644 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -145,7 +145,7 @@ add_gpgsm_home () { mkdir -p -m 0700 "$GNUPGHOME" gpgsm --batch --no-tty --no-common-certs-import --pinentry-mode=loopback --passphrase-fd 3  --disable-dirmngr --import  >"$GNUPGHOME"/import.log 2>&1 3<<<'' <$NOTMUCH_SRCDIR/test/smime/0xE0972A47.p12 -    fpr=$(gpgsm --batch --list-key test_suite@notmuchmail.org | sed -n 's/.*fingerprint: //p') +    fpr=$(gpgsm --batch --list-key test_suite@notmuchmail.org | sed -n 's/.*(fingerprint|sha1 fpr): //p') echo "$fpr S relax" >> "$GNUPGHOME/trustlist.txt" gpgsm --quiet --batch --no-tty --no-common-certs-import --disable-dirmngr --import < $NOTMUCH_SRCDIR/test/smime/ca.crt echo "4D:E0:FF:63:C0:E9:EC:01:29:11:C8:7A:EE:DA:3A:9A:7F:6E:C1:0D S" >> "$GNUPGHOME/trustlist.txt" -- 2.34.1 </ins>
Change:
flashfocus won't build because pyyaml has a too recent version. probably since pyyaml 6.0: Steps to reproduce the behavior: -shell -p flashfocus To build without errors (flashfocus) (pyyaml)
I am having a similar bug dependent on PyYaml.
fixed by

Discussion:
sha256 = "0cn44hryvz2wl7xklaslxsb3l2i3f8jkgmml0n9v2ks22j5l4r4h"; }; <ins> postPatch = '' substituteInPlace setup.py  --replace "pyyaml>=5.1,<6.0" "pyyaml>=5.1" ''; </ins> nativeBuildInputs = with python3.pkgs; [ pytest-runner ];
Change:
fails to compile on because of a broken Python 2 dependency (). According to the github home page, is not anymore developed and replaced by , see ,
Thanks for reporting. I opened the above mentioned PR to address this issue. In the PR I made an alias for split2flac that throws a message ecouraging the use of or to help package the library. A review is welcomed ;)

Discussion:
<del> { lib, stdenv, fetchFromGitHub, makeWrapper , shntool, cuetools , flac, faac, mp4v2, wavpack, mac , imagemagick, libiconv, enca, lame, mutagen, vorbis-tools , aacgain, mp3gain, vorbisgain }: let wrapSplit2flac =  format: '' makeWrapper $out/bin/.split2flac-wrapped $out/bin/split2${format}  --set SPLIT2FLAC_FORMAT ${format}  --prefix PATH : ${lib.makeBinPath [ shntool cuetools flac faac mp4v2 wavpack mac imagemagick libiconv enca lame mutagen vorbis-tools aacgain mp3gain vorbisgain ]} ''; in stdenv.mkDerivation rec { pname = "split2flac"; version = "122"; src = fetchFromGitHub { owner = "ftrvxmtrx"; repo = "split2flac"; rev = version; sha256 = "1a71amamip25hhqx7wwzfcl3d5snry9xsiha0kw73iq2m83r2k63"; }; dontBuild = true; nativeBuildInputs = [ makeWrapper ]; patchPhase = '' substituteInPlace split2flac  --replace 'FORMAT="''${0##*split2}"' 'FORMAT=''${SPLIT2FLAC_FORMAT:-flac}' ''; installPhase = '' mkdir -p $out/share/bash-completion/completions cp split2flac-bash-completion.sh  $out/share/bash-completion/completions/split2flac-bash-completion.sh mkdir -p $out/bin cp split2flac $out/bin/.split2flac-wrapped ${wrapSplit2flac "flac"} ${wrapSplit2flac "mp3"} ${wrapSplit2flac "ogg"} ${wrapSplit2flac "m4a"} ${wrapSplit2flac "wav"} ''; meta = with lib; { description = "Split flac/ape/wv/wav + cue sheet into separate tracks"; homepage = "https://github.com/ftrvxmtrx/split2flac"; license = licenses.mit; platforms = platforms.all; maintainers = with maintainers; [ jfrankenau ]; }; } </del>

spidermonkey_68 = throw "spidermonkey_68 has been removed. Please use spidermonkey_91 instead"; # added 2022-01-04 # spidermonkey is not ABI upwards-compatible, so only allow this for nix-shell spidermonkey = spidermonkey_78; # Added 2020-10-09 <ins> split2flac = throw "split2flac has been removed. Consider using the shnsplit command from shntool package or help packaging unflac."; # added 2022-01-13 </ins> spring-boot = spring-boot-cli; # added 2020-04-24 sqlite3_analyzer = throw "'sqlite3_analyzer' has been renamed to/replaced by 'sqlite-analyzer'"; # Converted to throw 2022-02-22 sqliteInteractive = throw "'sqliteInteractive' has been renamed to/replaced by 'sqlite-interactive'"; # Converted to throw 2022-02-22

spideroak = callPackage ../applications/networking/spideroak { }; <del> split2flac = callPackage ../applications/audio/split2flac { inherit (python3.pkgs) mutagen; }; </del> spotify-qt = libsForQt5.callPackage ../applications/audio/spotify-qt { }; spotify-tray = callPackage ../applications/misc/spotify-tray { };
Change:
<!-- You can use the "Go to file" functionality on github to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: <!-- The current version can be found easily with the same process than above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: desired version: <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: are you already working on it? if not i can do it
I have some exams to take tomorrow, so maybe I cannot open a PR in 17 hours. Feel free to open one if you have done the update.
I just wanted to make sure you haven't started to work on it, so we don't do duplicate work. I wish you great success with the exams!
Just also have a try on this, fails with . Actually I have no idea what happened so I just opened , downstream workaround should be something like , actually this seems to work, builds and launches. <img src="https://user-" width=50%Also I noticed that we maybe need in , haven't tested yet.
downstream workaround should be something like , actually this seems to work, builds and launches. i don't understand what it does, but it works Also I noticed that we maybe need in , haven't tested yet. I noticed before that the indicators do not work. I'll try it.

Discussion:
, sassc , udisks2 , wrapGAppsHook <ins> , libX11 , libXext , libXNVCtrl </ins> }: stdenv.mkDerivation rec { pname = "monitor"; <del> version = "0.11.0"; </del> <ins> version = "0.12.0"; </ins> src = fetchFromGitHub { owner = "stsdc"; repo = "monitor"; rev = version; <del> sha256 = "sha256-xWhhjn7zk/juXx50wLG2TpB5aqU+588kWBBquWrVJbM="; </del> <ins> sha256 = "1fv98yz9393ddp0k96bwbgccy6x9dmmg8g1pjd3xs6m4c1bnvfc7"; </ins> fetchSubmodules = true; };

libwnck sassc udisks2 <ins> libX11 libXext libXNVCtrl </ins> ]; <ins> # Force link against Xext, otherwise build fails with: # ld: /nix/store/...-libXNVCtrl-495.46/lib/libXNVCtrl.a(NVCtrl.o): undefined reference to symbol 'XextAddDisplay' # ld: /nix/store/...-libXext-1.3.4/lib/libXext.so.6: error adding symbols: DSO missing from command line # https://github.com/stsdc/monitor/issues/292 NIX_LDFLAGS = "-lXext"; mesonFlags = [ "-Dindicator-wingpanel=enabled" ]; </ins> postPatch = '' chmod +x meson/post_install.py patchShebangs meson/post_install.py

ocamlPackages = ocaml-ng.ocamlPackages_4_01_0; }; <del> monitor = callPackage ../applications/system/monitor { }; </del> <ins> monitor = callPackage ../applications/system/monitor { libXNVCtrl = linuxPackages.nvidia_x11.settings.libXNVCtrl; }; </ins> moolticute = libsForQt5.callPackage ../applications/misc/moolticute { };
Change:
The platform is x86_64. I'm not sure why nix thought I needed to compile subversion client instead of downloading it from Hydra. System: 16.09pre83100. (Flounder) Nix version: nix-env (Nix) 1.11.2
Because it fails on Hydra with the same error.
I thought unstable doesn't update unless all the hydra builds succeed?
forgot to cc maintainers:
no, they merely have to complete, only some jobs are release critical. EDIT: otherwise there'd never be any channel updates ...
Hmm. It would be nice to know what's working and what's broken before upgrading.
It's not exactly user-friendly, but you can check hydra, e.g.,
this reappeared on the latest nixos-unstable though it seems fixed on hydra

Discussion:
patches = [ ./apr-1.patch ]; <ins> # SVN build seems broken on gcc5: # https://gcc.gnu.org/gcc-5/porting_to.html CPPFLAGS = "-P"; </ins> configureFlags = '' ${if bdbSupport then "--with-berkeley-db" else "--without-berkeley-db"} ${if httpServer then "--with-apxs=${apacheHttpd}/bin/apxs" else "--without-apxs"}
Change:
running gzdoom results in and quits. Steps to reproduce the behavior: -shell -p gzdoom I enter hell and banish demons. mentioned here. <!-- --Please run and paste the result. system: host os: multi-user?: sandbox: version: channels(user): channels(root): nixpkgs:
I know nothing about gzdoom and new to NixOS. But I've tried to fix this by doing something like this: The problem seems solved. But soon it pops up saying that Did you install GZDoom properly? You can do either of the following: Edit your and add the directories of your iwads to the list beneath [IWADSearch.Directories] Any idea about this?
some are pay for, some a free ware/shareware. Your going to need the games data files, I have them, and i will pull from your branch and give it a try. Thanks for looking at this.. and above all... Welcome to Nixos..
Got it. I've pushed my branch and Thank you for your reply!
Did this fix get confirmed?
I couldn't find your branch, so I reconstructed a commit from your comment and submitted a PR. The fix seems to work, but the game I'm trying it on does not, so I cannot say for sure everything is good. (Though I believe that's a different issue.) For the impatient, you should now be able to run gzdoom with (if you have flakes enabled):

Discussion:
<del> { lib, stdenv, fetchFromGitHub, cmake, makeWrapper, openal, fluidsynth </del> <ins> { lib, stdenv, fetchFromGitHub, fetchpatch, cmake, makeWrapper, openal, fluidsynth </ins> , soundfont-fluid, libGL, SDL2, bzip2, zlib, libjpeg, libsndfile, libvpx, mpg123 , game-music-emu, pkg-config, copyDesktopItems, makeDesktopItem }:

zmusic ]; <ins> patches = [ (fetchpatch {  # TODO: Delete me when upgrading to 4.9 url = "https://github.com/ZDoom/gzdoom/commit/aae85a1b9169953d8dcc5f138a477d5c7d75addb.patch"; sha256 = "upuLDgVMaGaFSVaDV9Hj13DR5LUma51xv+Mfsz9m9a0="; }) ]; </ins> NIX_CFLAGS_LINK = "-lopenal -lfluidsynth"; desktopItems = [
Change:
Octave needs library to process audio (e.g. ). System: NixOS: Nix version: Nixpkgs version:
See
Closing in favor of

Discussion:
{ stdenv, fetchurl, gfortran, readline, ncurses, perl, flex, texinfo, qhull <del> , libX11, graphicsmagick, pcre, pkgconfig, mesa, fltk </del> <ins> , libsndfile, libX11, graphicsmagick, pcre, pkgconfig, mesa, fltk </ins> , fftw, fftwSinglePrec, zlib, curl, qrupdate, openblas , qt ? null, qscintilla ? null, ghostscript ? null, llvm ? null, hdf5 ? null,glpk ? null , suitesparse ? null, gnuplot ? null, jdk ? null, python ? null

}; buildInputs = [ gfortran readline ncurses perl flex texinfo qhull libX11 <del> graphicsmagick pcre pkgconfig mesa fltk zlib curl openblas </del> <ins> graphicsmagick pcre pkgconfig mesa fltk zlib curl openblas libsndfile </ins> fftw fftwSinglePrec qrupdate ] ++ (stdenv.lib.optional (qt != null) qt) ++ (stdenv.lib.optional (qscintilla != null) qscintilla)
Change:
Not valid cryptography in python3 ... Steps to reproduce the behavior: switch "Screenshot" Install yubikey-manager ;) Add any other context about the problem here. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- as cryptography maintainer Please run and paste the result.

Discussion:
python3Packages.buildPythonPackage rec { pname = "yubikey-manager"; version = "4.0.7"; <ins> format = "pyproject"; </ins> src = fetchFromGitHub { repo = "yubikey-manager";

}; postPatch = '' <ins> substituteInPlace pyproject.toml  --replace 'cryptography = "^2.1 || ^3.0"' 'cryptography = "*"' </ins> substituteInPlace "ykman/pcsc/__init__.py"  <del> --replace '/usr/bin/pkill' '${procps}/bin/pkill' </del> <ins> --replace 'pkill' '${procps}/bin/pkill' </ins> ''; <del> format = "pyproject"; </del> nativeBuildInputs = with python3Packages; [ poetry-core ]; propagatedBuildInputs =
Change:
Project description is a command output timestamper similar to in moreutils. Primary advantages over are the non-conflicting command name and its handling of progress bars. See "Comparison to moreutils ts" section in source repo for more complete comparison. Metadata homepage URL: source URL: license: mit platforms: linux, darwin

Discussion:
githubId = 7435854; name = "Victor Calvert"; }; <ins> cameronfyfe = { email = "cameron.j.fyfe@gmail.com"; github = "cameronfyfe"; githubId = 21013281; name = "Cameron Fyfe"; }; </ins> cameronnemo = { email = "cnemo@tutanota.com"; github = "cameronnemo";

<ins> { lib, buildGoModule, fetchFromGitHub, fetchpatch, installShellFiles }: buildGoModule rec { pname = "ets"; version = "0.2.1"; src = fetchFromGitHub { owner = "zmwangx"; repo = pname; rev = "v${version}"; sha256 = "sha256-XWIDo5msTMTLr60x1R9cwsiZIDG6G+uHWx8idt4F2iA="; }; # https://github.com/zmwangx/ets/pull/18/ patches = [ (fetchpatch { url = "https://github.com/zmwangx/ets/commit/600ec17a9c86ca63cd022d00439cdc4978e2afa9.patch"; sha256 = "sha256-SGCISHkWNFubgKkQYx8Vf5/fknNDfPNYkSuw1mMhZaE="; }) ]; vendorSha256 = "sha256-+8dXfqOu8XTw2uEx3GAynQSHtzifejZtddr1CdxrupA="; ldflags = [ "-s" "-w" "-X main.version=v${version}-nixpkgs" ]; nativeBuildInputs = [ installShellFiles ]; preBuild = '' rm -rf fixtures ''; postInstall = '' installManPage ets.1 ''; doCheck = false; meta = with lib; { description = "Command output timestamper"; homepage = "https://github.com/zmwangx/ets/"; license = licenses.mit; maintainers = with maintainers; [ cameronfyfe ]; }; } </ins>

ethtool = callPackage ../tools/misc/ethtool { }; <ins> ets = callPackage ../tools/misc/ets { }; </ins> ettercap = callPackage ../applications/networking/sniffers/ettercap { }; eventstat = callPackage ../os-specific/linux/eventstat { };
Change:
When enabling the services and and the system is relying on wifi managed by networkmanager, freshclam will fails to get the database signature and then clamav will refuse to start because freshclam is in failed state. When using ethernet connection, internet connection is working at boot time, before an user log in and freshclam doesn't fail. I suspect if you configure wifi without networkmanager it would also work fine because there would be no delay for connecting. Steps to reproduce the behavior: if I restart freshclam and then clamav, both services work fine until reboot. clamav and freshclam service should be running, or at least try to restart automatically. Please run and paste the result.
Looks like we didn't follow the upstream units enough:

Discussion:
pkg = pkgs.clamav; toKeyValue = generators.toKeyValue { <del> mkKeyValue = generators.mkKeyValueDefault {} " "; </del> <ins> mkKeyValue = generators.mkKeyValueDefault { } " "; </ins> listsAsDuplicateKeys = true; };

settings = mkOption { type = with types; attrsOf (oneOf [ bool int str (listOf str) ]); <del> default = {}; </del> <ins> default = { }; </ins> description = '' ClamAV configuration. Refer to <link xlink:href="https://linux.die.net/man/5/clamd.conf"/>, for details on supported values.

settings = mkOption { type = with types; attrsOf (oneOf [ bool int str (listOf str) ]); <del> default = {}; </del> <ins> default = { }; </ins> description = '' freshclam configuration. Refer to <link xlink:href="https://linux.die.net/man/5/freshclam.conf"/>, for details on supported values.

systemd.services.clamav-daemon = mkIf cfg.daemon.enable { description = "ClamAV daemon (clamd)"; after = optional cfg.updater.enable "clamav-freshclam.service"; <del> requires = optional cfg.updater.enable "clamav-freshclam.service"; </del> wantedBy = [ "multi-user.target" ]; restartTriggers = [ clamdConfigFile ];

systemd.services.clamav-freshclam = mkIf cfg.updater.enable { description = "ClamAV virus database updater (freshclam)"; restartTriggers = [ freshclamConfigFile ]; <ins> after = [ "network-online.target" ]; </ins> preStart = '' mkdir -m 0755 -p ${stateDir} chown ${clamavUser}:${clamavGroup} ${stateDir}
Change:
On most linux distributions, is provided by the package as a symlink to . This is not the case on NixOS, which makes building some software that expects a binary difficult. NixOS should change the package to provide in addition to the and that it currently provides.
Here are several instances of people running into this problem on IRC: ; ; ;
Closing since it sounds like it should've closed when merged. Happy to reopen if I'm mistaken.

Discussion:
dontDisableStatic = stdenv.buildPlatform != stdenv.hostPlatform; <ins> postInstall = '' ln -s $out/bin/flex $out/bin/lex ''; </ins> meta = with lib; { homepage = "https://github.com/westes/flex"; description = "A fast lexical analyser generator";