jiebi/CodeConvo huggingface dataset:
Change:
Describe the bug seems to be broken. When enabling via it doesn't seem to find the correct config file (namely ) and instead seemingly tries a few files in the dir one by one until it eventually fails. To Reproduce Steps to reproduce the behavior: via that the service does not start and instead the journal is filled with errors Expected behavior The service starts and is usable with a Yubikey Screenshots Output of running the command in the service file manually: ! More logs, seeing it try different files in and then failing to remove the pid file it didn't create: ! Additional context cc who also encountered this issue Notify maintainers via git blame Metadata
This was merged recently: cc: if this is the cause, we should consider a revert if we can't fix it quickly, this is potentially extremely bad.
This issue has been mentioned on NixOS Discourse. There might be relevant details there:
It's an easy fix (workaround at least). PR coming up in a few minutes.
Does this fix it for you ? I'm getting this in my pcscd logs, not sure if this is normal. But things aren't working with gpg still (with the using-pcscd path, anyway) EDIT: maybe this has to do with how I'm overriding gnupg (maybe the normal system gnupg gets some polkit rule that mine doesn't?)
I have the same issue: cc
I believe you've fixed the wrong file. Since the computer I'm on is affected, I cannot send a PR right now, so all I can offer immediately is a patch that reverts your changes in and, I believe, solves the actual root problem, which is an error in pscslite's . See patch below.
These logs look like
applying both and fixes the issue for me too
Thanks for the feedback! Could you please comment on so we can get it merged asap?

Discussion:
systemd.services.pcscd = { environment.PCSCLITE_HP_DROPDIR = pluginEnv; restartTriggers = [ "/etc/reader.conf" ]; <ins> # If the cfgFile is empty and not specified (in which case the default # /etc/reader.conf is assumed), pcscd will happily start going through the # entire confdir (/etc in our case) looking for a config file and try to # parse everything it finds. Doesn't take a lot of imagination to see how # well that works. It really shouldn't do that to begin with, but to work # around it, we force the path to the cfgFile. # # https://github.com/NixOS/nixpkgs/issues/121088 serviceConfig.ExecStart = [ "" "${getBin pkgs.pcsclite}/bin/pcscd -f -x -c ${cfgFile}" ]; </ins> }; }; }
Change:
Using version
Hello! Can you confirm this patch works on OSX + ? I get the following error above.
This might be the same issue that's breaking

Discussion:
<del> { stdenv, fetchurl }: </del> <ins> { stdenv, fetchurl, IOKit, Carbon }: </ins> stdenv.mkDerivation rec { name = "cdparanoia-III-10.2";

preConfigure = "unset CC"; <del> patches = stdenv.lib.optionals stdenv.isDarwin [ </del> <ins> patches = stdenv.lib.optionals stdenv.isDarwin [ </ins> (fetchurl { url = "https://trac.macports.org/export/70964/trunk/dports/audio/cdparanoia/files/osx_interface.patch"; sha1 = "c86e573f51e6d58d5f349b22802a7a7eeece9fcd";

}) ]; <ins> buildInputs = stdenv.lib.optional stdenv.isDarwin [ Carbon IOKit ]; </ins> meta = { homepage = http://xiph.org/paranoia; description = "A tool and library for reading digital audio from CDs";

cdparanoia = cdparanoiaIII; <del> cdparanoiaIII = callPackage ../applications/audio/cdparanoia { }; </del> <ins> cdparanoiaIII = callPackage ../applications/audio/cdparanoia { inherit (darwin) IOKit; inherit (darwin.apple_sdk.frameworks) Carbon; }; </ins> cdrtools = callPackage ../applications/misc/cdrtools { };
Change:
Describe the bug fails due to To Reproduce Steps to reproduce the behavior: nixos-unstable, or nixos-unstable-small a derivation depending on , for example or Expected behavior Build succeeds Screenshots Additional context With I was able to narrow this down to the merge from that happened in . Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Hello pass-import maintainers! Metadata Please run and paste the result. system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:

Discussion:
<del> { lib, fetchPypi, buildPythonPackage </del> <ins> { lib, fetchFromGitHub, buildPythonPackage </ins> , lxml, pycryptodomex, construct , argon2_cffi, dateutil, future <ins> , python </ins> }: buildPythonPackage rec { pname   = "pykeepass"; version = "4.0.0"; <del> src = fetchPypi { inherit pname version; sha256 = "1b41b3277ea4e044556e1c5a21866ea4dfd36e69a4c0f14272488f098063178f"; </del> <ins> src = fetchFromGitHub { owner = "libkeepass"; repo = "pykeepass"; rev = version; sha256 = "1zw5hjk90zfxpgq2fz4h5qzw3kmvdnlfbd32gw57l034hmz2i08v"; </ins> }; postPatch = ''

argon2_cffi dateutil future ]; <del> # no tests in PyPI tarball doCheck = false; </del> <ins> checkPhase = '' ${python.interpreter} -m unittest tests.tests ''; </ins> <del> meta = { homepage = "https://github.com/pschmitt/pykeepass"; </del> <ins> meta = with lib; { homepage = "https://github.com/libkeepass/pykeepass"; changelog = "https://github.com/libkeepass/pykeepass/blob/${version}/CHANGELOG.rst"; </ins> description = "Python library to interact with keepass databases (supports KDBX3 and KDBX4)"; <del> license = lib.licenses.gpl3; </del> <ins> license = licenses.gpl3Only; maintainers = with maintainers; [ dotlambda ]; </ins> }; }

sha256 = "sha256-nH2xAqWfMT+Brv3z9Aw6nbvYqArEZjpM28rKsRPihqA="; }; <del> # by default, tries to install scripts/pimport, which is a bash wrapper around "python -m pass_import ..." # This is a better way to do the same, and takes advantage of the existing Nix python environments </del> patches = [ <ins> (fetchpatch { name = "support-for-keepass-4.0.0.patch"; url = "https://github.com/roddhjav/pass-import/commit/86cfb1bb13a271fefe1e70f24be18e15a83a04d8.patch"; sha256 = "0mrlblqlmwl9gqs2id4rl4sivrcclsv6zyc6vjqi78kkqmnwzhxh"; }) # by default, tries to install scripts/pimport, which is a bash wrapper around "python -m pass_import ..." # This is a better way to do the same, and takes advantage of the existing Nix python environments </ins> # from https://github.com/roddhjav/pass-import/pull/138 (fetchpatch { name = "pass-import-pr-138-pimport-entrypoint.patch";
Change:
See The NixOS option  does: This is not safe. The private key can be read by an unprivileged user who opens the file between and . For example with : are never safe. This sequence should never be used for writing secrets. This is why (like ) and exist. See for example the key generation section in or . Edit for completeness: The parent directory of the private key file is currently created with So the directory doesn't exist, it is created with permissions ; due to lack of , no non-root-user can do things in it at all. However, this protection does not apply when already exists; then is a no-op. There's nothing in docs or code that suggest that; for example, that may be . I think setting is also not very good; it only works because has implicit access anyway, and the service runs as root. Instead, the private key file should have strict permissions.
cc
I'm looking into making an based fix now.
There are similar problems in [ ] ( [ ] and ( [ ] ( [ ] ( [ ] ( [ ] ( [ ] ( [ ] ( [ ] ... does it correctly :tada:
Could you move those to a separate issue? Because this one will be autoclosed after my fix is merged. And we could also make give that new overview issue the label.
PR in

Discussion:
</para> </listitem> <listitem> <ins> <para> <link linkend="opt-networking.wireguard.interfaces">networking.wireguard.interfaces.&lt;name&gt;.generatePrivateKeyFile</link>, which is off by default, had a <literal>chmod</literal> race condition fixed. As an aside, the parent directory's permissions were widened, and the key files were made owner-writable. This only affects newly created keys. However, if the exact permissions are important for your setup, read <link xlink:href="https://github.com/NixOS/nixpkgs/pull/121294">#121294</link>. </para> </listitem> <listitem> </ins> <para> <link linkend="opt-boot.zfs.forceImportAll">boot.zfs.forceImportAll</link> previously did nothing, but has been fixed. However its default has been

}; script = '' <del> mkdir --mode 0644 -p "${dirOf values.privateKeyFile}" </del> <ins> set -e # If the parent dir does not already exist, create it. # Otherwise, does nothing, keeping existing permisions intact. mkdir -p --mode 0755 "${dirOf values.privateKeyFile}" </ins> if [ ! -f "${values.privateKeyFile}" ]; then <del> touch "${values.privateKeyFile}" chmod 0600 "${values.privateKeyFile}" wg genkey > "${values.privateKeyFile}" chmod 0400 "${values.privateKeyFile}" </del> <ins> # Write private key file with atomically-correct permissions. (set -e; umask 077; wg genkey > "${values.privateKeyFile}") </ins> fi ''; };
Change:
<!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: () <!-- The current version can be found easily with the same process than above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: desired version: <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Please tag this issue in your PR.

Discussion:
buildDunePackage rec { pname = "google-drive-ocamlfuse"; <del> version = "0.7.22"; </del> <ins> version = "0.7.26"; </ins> useDune2 = true;

owner = "astrada"; repo = "google-drive-ocamlfuse"; rev = "v${version}"; <del> sha256 = "027j1r2iy8vnbqs8bv893f0909yk5312ki5p3zh2pdz6s865h750"; </del> <ins> sha256 = "sha256-8s3DnpdYIVyJj5rtsof3WpLvX9wCrWU47dp4D6c986s="; </ins> }; buildInputs = [ ocaml_extlib ocamlfuse gapi_ocaml ocaml_sqlite3 ];
Change:
Describe the bug When i open the About dialog in any program provided by gnunet-gtk, for example , i notice that the logo is missing. ! To Reproduce Steps to reproduce the behavior: (wait for ) Help -About Expected behavior no icons missing Notify maintainers (who fixed the build last) Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
PR:

Discussion:
configureFlags = [ "--with-gnunet=${gnunet}" ]; <del> patchPhase = "patchShebangs pixmaps/icon-theme-installer"; </del> <ins> postPatch = "patchShebangs pixmaps/icon-theme-installer"; postInstall = '' ln -s $out/share/gnunet-gtk/gnunet_logo.png $out/share/gnunet/gnunet-logo-color.png ''; </ins> meta = gnunet.meta // { description = "GNUnet GTK User Interface";
Change:
Project description is a server validation tool. It lets you write assertions in YAML format and runs them really fast to ensure your server matches them, for example it lets you assert some binary is present in path or some command gives an expected result, or that some port is open, etc. I personally use it a lot to test docker images through its sub-project , for which I'll submit another request. Metadata homepage URL: source URL: license: Apache License 2.0 platforms: linux. Darwin and windows support is alpha (see the )
Per request I am bringing up the question here from : should we split into a separate package ? I assumed that since they are different binaries, they would need different packages. Both and are built and released together in the same github repository. depends on , but may be used without it.

Discussion:
githubId = 12491746; name = "Masato Yonekawa"; }; <ins> hyzual = { email = "hyzual@gmail.com"; github = "Hyzual"; githubId = 2051507; name = "Joris Masson"; }; </ins> hzeller = { email = "h.zeller@acm.org"; github = "hzeller";

<ins> { lib, fetchFromGitHub, buildGoModule }: buildGoModule rec { pname = "goss"; version = "0.3.16"; src = fetchFromGitHub { owner = "aelsabbahy"; repo = pname; rev = "v${version}"; sha256 = "1m5w5vwmc9knvaihk61848rlq7qgdyylzpcwi64z84rkw8qdnj6p"; }; vendorSha256 = "1lyqjkwj8hybj5swyrv6357hs8sxmf4wim0c8yhfb9mv7fsxhrv7"; CGO_ENABLED = 0; preBuild = '' buildFlagsArray+=("-ldflags" "-s -w -X main.version=v${version}") ''; meta = with lib; { homepage = "https://github.com/aelsabbahy/goss/"; changelog = "https://github.com/aelsabbahy/goss/releases/tag/v${version}"; description = "Quick and easy server validation"; longDescription = '' Goss is a YAML based serverspec alternative tool for validating a server’s configuration. It eases the process of writing tests by allowing the user to generate tests from the current system state. Once the test suite is written they can be executed, waited-on, or served as a health endpoint. ''; license = licenses.asl20; platforms = platforms.linux; maintainers = with maintainers; [ hyzual jk ]; }; } </ins>

godu = callPackage ../tools/misc/godu { }; <ins> goss = callPackage ../tools/misc/goss { }; </ins> gosu = callPackage ../tools/misc/gosu { }; gotify-cli = callPackage ../tools/misc/gotify-cli { };
Change:
It would be nice to add pijul () to the list of source controls that nix supports.
What are some motivating examples of software distributed via Pijul that you would like to see available through Nix/Nixpkgs?
Sort of a chicken and egg problem. My use case is for libraries. I want to start using pijul exclusively for source control for projects I control, therefore pulling source via say niv would require a fetchpijul to exist somewhere and nixpkgs seemed like the most likely place. It feels like a common theme that folks would be keen to use it over git if there were less friction and more integration options.
Concrete use case:
Is there a good high level outline on what needs to happen for the fetching process? I might be open to taking a stab at this, but just reading through the fetchgit source unassisted was a tad intimidating, I thought. Does there also need to be some work done in nix itself to support something like using Pijul for tracking what is included in a flake?
fetchFossil sounds like a better starting point…

Discussion:
<ins> { lib, stdenvNoCC, pijul }: lib.makeOverridable ( { url , hash ? "" , change ? null , state ? null , channel ? "main" , name ? "fetchpijul" , # TODO: Changes in pijul are unordered so there's many ways to end up with the same repository state. # This makes leaveDotPijul unfeasible to implement until pijul CLI implements # a way of reordering changes to sort them in a consistent and deterministic manner. # leaveDotPijul ? false }: if change != null && state != null then throw "Only one of 'change' or 'state' can be set" else stdenvNoCC.mkDerivation { inherit name; nativeBuildInputs = [ pijul ]; dontUnpack = true; dontConfigure = true; dontBuild = true; installPhase = '' runHook preInstall pijul clone  ''${change:+--change "$change"}  ''${state:+--state "$state"}  --channel "$channel"  "$url"  "$out" runHook postInstall ''; fixupPhase = '' runHook preFixup rm -rf "$out/.pijul" runHook postFixup ''; outputHashAlgo = if hash != "" then null else "sha256"; outputHashMode = "recursive"; outputHash = if hash != "" then hash else lib.fakeSha256; inherit url change state channel; } ) </ins>

fetchMavenArtifact = callPackage ../build-support/fetchmavenartifact { }; <ins> fetchpijul = callPackage ../build-support/fetchpijul { }; </ins> inherit (callPackage ../build-support/node/fetch-yarn-deps { }) prefetch-yarn-deps fetchYarnDeps;
Change:
Describe the bug It seems that is unable to build in current master (). To Reproduce Steps to reproduce the behavior: checkout -build . -A citrixworkspace Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Maintainer information:
A fix should be in

Discussion:
{ lib, stdenv, requireFile, makeWrapper, autoPatchelfHook, wrapGAppsHook, which, more , file, atk, alsaLib, cairo, fontconfig, gdk-pixbuf, glib, gnome3, gtk2-x11, gtk3 , heimdal, krb5, libsoup, libvorbis, speex, openssl, zlib, xorg, pango, gtk2 <del> , gnome2, nss, nspr, gtk_engines, freetype, dconf, libpng12, libxml2 </del> <ins> , gnome2, mesa, nss, nspr, gtk_engines, freetype, dconf, libpng12, libxml2 </ins> , libjpeg, libredirect, tzdata, cacert, systemd, libcxxabi, libcxx, e2fsprogs, symlinkJoin , libpulseaudio, pcsclite

libsoup libvorbis libxml2 <ins> mesa </ins> nspr nss openssl'
Change:
Describe the bug Epiphany crashes on startup with a bind mount error. To Reproduce Steps to reproduce the behavior: epiphany Expected behavior The browser should startup Additional context Error: exists and opengl is enabled I bet is relevant Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Metadata Maintainer information:
I can't reproduce this on my machine. Can you try running it with ?
Thanks for responding. I think this is the relevant part from :
Ah, this only shows that emits the error message. To trace what it actually does, could you try adding the flag?
I just piped it all into here:
The output got cut off there, unfortunately. Maybe you could just attach the text file directly to your reply?
Sorry about that, here is the file:
Thanks for the log! I think I've found the culprit. I've opened which seems to fix it - please try it out.

Discussion:
, xdg-dbus-proxy , substituteAll , glib <ins> , addOpenGLRunpath </ins> }: assert enableGeoLocation -> geoclue2 != null;

(substituteAll { src = ./fix-bubblewrap-paths.patch; inherit (builtins) storeDir; <ins> inherit (addOpenGLRunpath) driverLink; </ins> }) ./libglvnd-headers.patch ];

diff -ru old/webkitgtk-2.26.0/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp webkitgtk-2.26.0/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp --- old/webkitgtk-2.26.0/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp	2019-09-09 04:47:07.000000000 -0400 +++ webkitgtk-2.26.0/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp	2019-09-20 21:14:10.537921173 -0400 <del> @@ -585,7 +585,7 @@ { SCMP_SYS(keyctl), nullptr }, { SCMP_SYS(request_key), nullptr }, -        // Scary VM/NUMA ops +        // Scary VM/NUMA ops { SCMP_SYS(move_pages), nullptr }, { SCMP_SYS(mbind), nullptr }, { SCMP_SYS(get_mempolicy), nullptr }, @@ -724,6 +724,11 @@ </del> <ins> @@ -724,6 +724,12 @@ </ins> "--ro-bind-try", "/usr/local/lib64", "/usr/local/lib64", "--ro-bind-try", PKGLIBEXECDIR, PKGLIBEXECDIR,

+        // Nix Directories +        "--ro-bind", "@storeDir@", "@storeDir@", +        "--ro-bind", "/run/current-system", "/run/current-system", <del> +        "--ro-bind", "/run/opengl-driver", "/run/opengl-driver", </del> <ins> +        "--ro-bind-try", "@driverLink@/lib", "@driverLink@/lib", +        "--ro-bind-try", "@driverLink@/share", "@driverLink@/share", </ins> }; // We would have to parse ld config files for more info. bindPathVar(sandboxArgs, "LD_LIBRARY_PATH");
Change:
Describe the bug An error (below) is thrown when attempting to install swi-prolog on macOS Big Sur. /nix/store/59hdixd6qf2jq5mj0bqiwrhy7621wa7j-stdenv-darwin/setup: line 88: No such file or directory To Reproduce Steps to reproduce the behavior: Expected behavior SWI Prolog installation to succeed. Screenshots Here is the result I get: Metadata Please run and paste the result.

Discussion:
# Add the packInstall path to the swipl pack search path postPatch = '' <del> echo "user:file_search_path(pack, '$out/lib/swipl/pack')." >> /build/$sourceRoot/boot/init.pl </del> <ins> echo "user:file_search_path(pack, '$out/lib/swipl/pack')." >> boot/init.pl </ins> ''; nativeBuildInputs = [ cmake pkg-config ];
Change:
Describe the bug While evaluating : To Reproduce Steps to reproduce the behavior: Found in . I haven't narrowed down exactly which attribute it is yet. Refs Additional context Add any other context about the problem here. Notify maintainers Metadata Please run and paste the result. Maintainer information:
It's
Thanks for the heads up! Addressed in

Discussion:
networking.firewall.enable = false; virtualisation.vlans = [ 1 ]; environment.systemPackages = with pkgs; [ wireguard-tools ]; <del> boot.extraModulePackages = [ config.boot.kernelPackages.wireguard ]; </del> systemd.network = { enable = true; netdevs = {
Change:
Project description Lightweight nextcloud/seafile/syncthing/ftp alternative to easily share files with mutiple users via HTTP Metadata homepage URL: source URL: license: Apache License platforms: any
I marked this as stale due to inactivity. &rarr;
need this too
I also have a work in progress for a module that wraps FileBrowser
If you submit a PR I can help review or test it
I've not quite sure how stacked PR's work on github as the previous one is still pending, but it would be great if you could test and leave feedback on this commit:
I've opened a new issue to discuss the options:

Discussion:
fingerprint = "E576 BFB2 CF6E B13D F571  33B9 E315 A758 4613 1564"; }]; }; <ins> nielsegberts = { email = "nix@nielsegberts.nl"; github = "nielsegberts"; githubId = 368712; name = "Niels Egberts"; }; </ins> nigelgbanks = { name = "Nigel Banks"; email = "nigel.g.banks@gmail.com";

<ins> { buildGoModule, buildNpmPackage, fetchFromGitHub, lib }: let frontend = buildNpmPackage rec { pname = "filebrowser-frontend"; version = "2.23.0"; src = fetchFromGitHub { owner = "filebrowser"; repo = "filebrowser"; rev = "v${version}"; hash = "sha256-xhBIJcEtxDdMXSgQtLAV0UWzPtrvKEil0WV76K5ycBc="; }; sourceRoot = "source/frontend"; npmDepsHash = "sha256-acNIMKHc4q7eiFLPBtKZBNweEsrt+//0VR6dqwXHTvA="; NODE_OPTIONS = "--openssl-legacy-provider"; installPhase = '' runHook preInstall mkdir $out mv dist $out runHook postInstall ''; }; in buildGoModule rec { pname = "filebrowser"; version = "2.23.0"; src = fetchFromGitHub { owner = "filebrowser"; repo = "filebrowser"; rev = "v${version}"; hash = "sha256-xhBIJcEtxDdMXSgQtLAV0UWzPtrvKEil0WV76K5ycBc="; }; vendorHash = "sha256-MR0ju2Nomb3j78Z+1YcJY+jPd40MZpuOTuQJM94AM8A="; excludedPackages = [ "tools" ]; preBuild = '' cp -r ${frontend}/dist frontend/ ''; passthru = { inherit frontend; }; meta = with lib; { description = "Filebrowser is a web application for managing files and directories"; homepage = "https://filebrowser.org"; license = licenses.asl20; maintainers = with maintainers; [ nielsegberts ]; }; } </ins>

irssi = callPackage ../applications/networking/irc/irssi { }; <ins> filebrowser = callPackage ../applications/networking/filebrowser { }; </ins> fish-irssi = callPackage ../applications/networking/irc/irssi/fish { }; kirc = callPackage ../applications/networking/irc/kirc { };