jiebi/CodeConvo huggingface dataset:
Change:
Package name: trunk Latest released version: 0.18.0 Current version on the unstable channel: 0.17.2 Current version on the stable/release channel: 0.17.2 Checked the nixpkgs pull requests It's a big release since 0.17.2 and adds a lot of new features including an flag which is helpful for nix Note for maintainers: Please tag this issue in your PR.
there was PR created before this issue maybe because PR title doesn't match contribution guidelines it was't found
Yeah. Sorry about that. I missed it.
it's ok, no harm done :-)
Do you know how to remove a package? I believe trunk-ng will get deprecated now.
yes, I've recently removed a package as for trunk-ng, I can't see anywhere that is has been deprecated yet

Discussion:
<del> { lib, stdenv, rustPlatform, fetchFromGitHub, pkg-config , openssl, libiconv, CoreServices, Security }: </del> <ins> { lib, stdenv, rustPlatform, fetchFromGitHub, pkg-config, openssl, libiconv, jq, moreutils, CoreServices, Security }: </ins> rustPlatform.buildRustPackage rec { pname = "trunk"; <del> version = "0.17.2"; </del> <ins> version = "0.18.0"; </ins> src = fetchFromGitHub { owner = "thedodd"; repo = "trunk"; rev = "v${version}"; <del> sha256 = "sha256-A6h8TmYK5WOcmANk/uM9QO1h767BWASWTwLthtKqrEk="; </del> <ins> hash = "sha256-riebGbDCqkJTkDmvXCuD0ywjSfGfLgxywkHUPlGzCgI="; </ins> }; nativeBuildInputs = [ pkg-config ]; buildInputs = if stdenv.isDarwin then [ libiconv CoreServices Security ] else [ openssl ]; # requires network checkFlags = [ "--skip=tools::tests::download_and_install_binaries" ]; <del> cargoHash = "sha256-+jz0J1qFK2fZ4OX089pgNtT2vfiOTf39qQjeXmLoFNs="; </del> <ins> cargoHash = "sha256-O2AKIOvAwDpZDzEyc/x5lF0E0UR+Mj/J///1bYRgoX4="; # the dependency css-minify contains both README.md and Readme.md, # which causes a hash mismatch on systems with a case-insensitive filesystem # this removes the readme files and updates cargo's checksum file accordingly depsExtraArgs = { nativeBuildInputs = [ jq moreutils ]; postBuild = '' pushd $name/css-minify rm -f README.md Readme.md jq 'del(.files."README.md") | del(.files."Readme.md")'  .cargo-checksum.json -c  | sponge .cargo-checksum.json popd ''; }; </ins> meta = with lib; { homepage = "https://github.com/thedodd/trunk";
Change:
Steps to reproduce the behavior: qt6.qtmultimedia for mingw (windows) hostPlatform I am slowly adding mingw support for qt6.qtmultimedia. Will reference this issue when I open a PR for a cross build dependency. May open some drafts in a effort to get help from the community. Here is an image of the dependency tree from msys2. ! Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Upstreaming my changes to nixpkgs is taking longer than I expected. Here is the publication of my overlays. Hopefully other members of the community can help me upstream these packages to get qtbase and qtmultimedia cross compiling.
Builds qt6.qtmultimedia for mingw32. Thank you and anyone else I forgot to mention, for helping with reviews. My experience of contributing to nixpkgs was very positive, and it's thanks to all you incredibly bright and generous people. Closing as resolved.
Thank you for putting in all the hard work, very much appreciated!

Discussion:
<del> { lib, stdenv, fetchFromGitHub , meson, ninja, nasm, pkg-config </del> <ins> { lib , stdenv , fetchFromGitHub , meson , ninja , nasm , pkg-config </ins> , xxHash , withTools ? false # "dav1d" binary <del> , withExamples ? false, SDL2 # "dav1dplay" binary , useVulkan ? false, libplacebo, vulkan-loader, vulkan-headers </del> <ins> , withExamples ? false , SDL2 # "dav1dplay" binary , useVulkan ? false , libplacebo , vulkan-loader , vulkan-headers </ins> <del> # for passthru.tests </del> <ins> # for passthru.tests </ins> , ffmpeg , gdal , handbrake

++ lib.optional withExamples SDL2 ++ lib.optionals useVulkan [ libplacebo vulkan-loader vulkan-headers ]; <del> mesonFlags= [ </del> <ins> mesonFlags = [ </ins> "-Denable_tools=${lib.boolToString withTools}" "-Denable_examples=${lib.boolToString withExamples}" ];

changelog = "https://code.videolan.org/videolan/dav1d/-/tags/${version}"; # More technical: https://code.videolan.org/videolan/dav1d/blob/${version}/NEWS license = licenses.bsd2; <del> platforms = platforms.unix; </del> <ins> platforms = platforms.unix ++ platforms.windows; </ins> maintainers = with maintainers; [ primeos ]; }; }
Change:
Steps to reproduce the behavior: kaidan <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Thanks for notifying me!

Discussion:
, qtmultimedia , qtlocation , qqc2-desktop-style <ins> , kirigami-addons </ins> , kirigami2 <ins> , kio </ins> , knotifications <ins> , kquickimageedit </ins> , zxing-cpp , qxmpp , sonnet

mkDerivation rec { pname = "kaidan"; <del> version = "0.8.0"; </del> <ins> version = "0.9.1"; </ins> src = fetchFromGitLab { domain = "invent.kde.org"; owner = "network"; repo = pname; rev = "v${version}"; <del> sha256 = "070njci5zyzahmz3nqyp660chxnqx1mxp31w17syfllvrw403qmg"; </del> <ins> hash = "sha256-F5GhN9hAF2e8b0T3peUnLk8CVd+nq4YR8k52x6ZOoLM="; </ins> }; nativeBuildInputs = [ cmake extra-cmake-modules pkg-config ];

qtmultimedia qtlocation qqc2-desktop-style <ins> kirigami-addons </ins> kirigami2 <ins> kio </ins> knotifications <ins> kquickimageedit </ins> zxing-cpp qxmpp sonnet

<ins> { lib , stdenv , fetchFromGitHub , cmake , openssl }: stdenv.mkDerivation rec { pname = "libomemo-c"; version = "0.5.0"; src = fetchFromGitHub { owner = "dino"; repo = "libomemo-c"; rev = "v${version}"; hash = "sha256-GvHMp0FWoApbYLMhKfNxSBel1xxWWF3TZ4lnkLvu2s4="; }; nativeBuildInputs = [ cmake ]; buildsInputs = [ openssl ]; cmakeFlags = [ "-DBUILD_SHARED_LIBS=ON" ]; meta = with lib; { description = "Fork of libsignal-protocol-c adding support for OMEMO XEP-0384 0.5.0+"; homepage = "https://github.com/dino/libomemo-c"; license = licenses.gpl3Only; maintainers = [ maintainers.astro ]; }; } </ins>

, pkg-config , withGstreamer ? true , gst_all_1 <ins> , withOmemo ? true , qca-qt5 , libomemo-c </ins> }: mkDerivation rec {

nativeBuildInputs = [ cmake <del> ] ++ lib.optionals withGstreamer [ </del> <ins> ] ++ lib.optionals (withGstreamer || withOmemo) [ </ins> pkg-config ]; buildInputs = lib.optionals withGstreamer (with gst_all_1; [

gst-plugins-bad gst-plugins-base gst-plugins-good <del> ]); </del> <ins> ]) ++ lib.optionals withOmemo [ qca-qt5 libomemo-c ]; </ins> cmakeFlags = [ "-DBUILD_EXAMPLES=false" "-DBUILD_TESTS=false" ] ++ lib.optionals withGstreamer [ "-DWITH_GSTREAMER=ON" <ins> ] ++ lib.optionals withOmemo [ "-DBUILD_OMEMO=ON" </ins> ]; meta = with lib; {
Change:
using frr-9.0.1 from nixos-23.11 results in failure of staticd.service: = true systemctl status staticd staticd used to work with option see Quick fix see below. maybe / want to insert themselves kindly into maintainers :-) system: host os: multi-user?: sandbox: version: channels(fd): channels(root): nixpkgs:
No, sorry. I'm a BIRD user, and I like it that way. Me writing that test and getting FRR over the finish line was some morbid curiosity. My only interest in FRR was bgp-evpn signaling fwiw.
Thanks even more for contributing! My quickfix for this issue is so far It seems, config file location with mgmtd is now instead of mgmtd is needed for staticd to get configured.
also mentions
yes, all daemons have as default config file, I'll try to adapt the nixos service accordingly to get rid of in all service definitions.
Please also test with: (should not have changed this).

Discussion:
"pbr" "bfd" "fabric" <del> "mgmt" </del> ]; <del> allServices = services ++ [ "zebra" ]; </del> <ins> allServices = services ++ [ "zebra" "mgmt" ]; </ins> isEnabled = service: cfg.${service}.enable;

''; }; }; <ins> mgmt = (serviceOptions "mgmt") // { enable = mkOption { type = types.bool; default = isEnabled "static"; defaultText = lib.literalExpression "config.services.frr.static.enable"; description = '' Whether to enable the Configuration management daemon. The Configuration management daemon is automatically enabled if needed, at the moment this is when staticd is enabled. ''; }; }; </ins> }; } { options.services.frr = (genAttrs services serviceOptions); }

environment.etc = let mkEtcLink = service: { <del> name = "frr/${service}.conf"; </del> <ins> name = "frr/${daemonName service}.conf"; </ins> value.source = configFile service; }; in

unitConfig.Documentation = if service == "zebra" then "man:zebra(8)" else "man:${daemon}(8) man:zebra(8)"; <del> restartTriggers = [ </del> <ins> restartTriggers = mkIf (service != "mgmt") [ </ins> (configFile service) ]; <del> reloadIfChanged = true; </del> <ins> reloadIfChanged = (service != "mgmt"); </ins> serviceConfig = { PIDFile = "frr/${daemon}.pid"; <del> ExecStart = "${pkgs.frr}/libexec/frr/${daemon} -f /etc/frr/${service}.conf" </del> <ins> ExecStart = "${pkgs.frr}/libexec/frr/${daemon}" </ins> + optionalString (scfg.vtyListenAddress != "") " -A ${scfg.vtyListenAddress}" + optionalString (scfg.vtyListenPort != null) " -P ${toString scfg.vtyListenPort}" + " " + (concatStringsSep " " scfg.extraOptions); <del> ExecReload = "${pkgs.python3.interpreter} ${pkgs.frr}/libexec/frr/frr-reload.py --reload --daemon ${daemonName service} --bindir ${pkgs.frr}/bin --rundir /run/frr /etc/frr/${service}.conf"; </del> <ins> ExecReload = mkIf (service != "mgmt") "${pkgs.python3.interpreter} ${pkgs.frr}/libexec/frr/frr-reload.py --reload --daemon ${daemon} --bindir ${pkgs.frr}/bin --rundir /run/frr /etc/frr/${daemon}.conf"; </ins> Restart = "on-abnormal"; }; });
Change:
currently has a conditional: is defined as this: However, this is only one part of the picture. I can also add the option to a entry to cause a dependency on (or just do it explicitly by ). ~ is also missing entirely~ dealt with online in stage 2 I think we should ship by default with systemd-in-initrd. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
This is intentional: systemd-growfs is an online operation. We do it during stage 2 when is enabled.
oh, but I see, you're saying we should add in case users add the fstab option themselves and don't use the NixOS option. I think that makes sense. The point of the previous comment stands though; growfs is intentionally not in stage 1.
Makes sense, and I even reviewed this PR :laughing: sorry. Yes, in case the fstab options contain we should also (or just add it unconditionally)
Yea, I don't mind adding it unconditionally. It's a negligible size increase, and I think there's ways to trigger its use on the cmdline anyway.
PR up at

Discussion:
fileSystems = filter utils.fsNeededForBoot config.system.build.fileSystems; <del> needMakefs = lib.any (fs: fs.autoFormat) fileSystems; </del> kernel-name = config.boot.kernelPackages.kernel.name or "kernel"; modulesTree = config.system.modulesTree.override { name = kernel-name + "-modules"; }; firmware = config.hardware.firmware;

"${cfg.package}/lib/systemd/systemd-fsck" "${cfg.package}/lib/systemd/systemd-hibernate-resume" "${cfg.package}/lib/systemd/systemd-journald" <del> (lib.mkIf needMakefs "${cfg.package}/lib/systemd/systemd-makefs") </del> <ins> "${cfg.package}/lib/systemd/systemd-makefs" </ins> "${cfg.package}/lib/systemd/systemd-modules-load" "${cfg.package}/lib/systemd/systemd-remount-fs" "${cfg.package}/lib/systemd/systemd-shutdown"
Change:
The installation script looks in subdirectory () but lilyjazz uses instead: As a result the additional fonts are not installed. In addition, there are also stylesheets and examples which would be useful to have. Install . All fonts in lilyjazz directory are installed. system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:
Thanks for the report. Might you be willing and able to open a PR to fix it?

Discussion:
local fontsdir="$out/share/lilypond/${lilypond.version}/fonts" install -m755 -d "$fontsdir/otf" <del> for font in {otf,supplementary-fonts}/**.{o,t}tf; do install -Dt "$fontsdir/otf" -m755 "$font" </del> <ins> shopt -s globstar for font in {otf,supplementary-fonts,supplementary-files}/**/*.{o,t}tf; do echo $font install -Dt "$fontsdir/otf" -m644 "$font" </ins> done install -m755 -d "$fontsdir/svg" <del> for font in svg/**.{svg,woff}; do install -Dt "$fontsdir/svg" -m755 "$font" </del> <ins> for font in {svg,woff}/**.{svg,woff}; do install -Dt "$fontsdir/svg" -m644 "$font" </ins> done '';
Change:
The tool that checks the . A notable feature is that it can report multiple failures at once: The tool currently only has tests for single errors. There should be a test to test multiple failures together, ideally as many of them as possible. See for how tests can be declared.

Discussion:
- `default.nix`: Always contains ```nix <del> import ../mock-nixpkgs.nix { root = ./.; } </del> <ins> import <test-nixpkgs> { root = ./.; } </ins> ``` which makes ```

let root = Root::parse(&contents); if let Some(error) = root.errors().first() { <ins> // NOTE: There's now another Nixpkgs CI check to make sure all changed Nix files parse // correctly, though that uses mainline Nix instead of rnix, so it doesn't give the same // errors. In the future we should unify these two checks, ideally moving the other CI // check into this tool as well and checking for both mainline Nix and rnix. </ins> return Ok(NixpkgsProblem::CouldNotParseNix { relative_package_dir: relative_package_dir.to_path_buf(), subpath: subpath.to_path_buf(),

<ins> import <test-nixpkgs> { root = ./.; } </ins>

<ins> pkgs/by-name/A: Invalid directory name "A", must be at most 2 ASCII characters consisting of a-z, 0-9, "-" or "_". pkgs/by-name/A/fo@: Invalid package directory name "fo@", must be ASCII characters consisting of a-z, A-Z, 0-9, "-" or "_". pkgs/by-name/A/fo@: Path foo is a symlink which cannot be resolved: No such file or directory (os error 2). pkgs/by-name/A/fo@: Path package.nix is a symlink pointing to a path outside the directory of that package. pkgs/by-name/aa: This is a file, but it should be a directory. pkgs/by-name/ba/bar: This path is a file, but it should be a directory. pkgs/by-name/ba/baz: "package.nix" must be a file. pkgs/by-name/ba/foo: Incorrect directory location, should be pkgs/by-name/fo/foo instead. pkgs/by-name/ba/foo: File package.nix at line 2 contains the path expression "/bar" which cannot be resolved: No such file or directory (os error 2). pkgs/by-name/ba/foo: File package.nix at line 3 contains the path expression "../." which may point outside the directory of that package. pkgs/by-name/ba/foo: File package.nix at line 4 contains the nix search path expression "<nixpkgs>" which may point outside the directory of that package. pkgs/by-name/ba/foo: File package.nix at line 5 contains the path expression "./${"test"}", which is not yet supported and may point outside the directory of that package. pkgs/by-name/fo/foo: Missing required "package.nix" file. </ins>

<ins> ../../../../someDrv.nix </ins>  No newline at end of file

<ins> { someDrv }: someDrv // { escapeAbsolute = /bar; escapeRelative = ../.; nixPath = <nixpkgs>; pathWithSubexpr = ./${"test"}; } </ins>

<del> import <test-nixpkgs> { root = ./.; } </del>

<del> pkgs/by-name/aa/aa: File invalid.nix could not be parsed by rnix: unexpected token at 28..29 </del>

<del> pkgs/by-name/fo/foo: Path foo.nix is a symlink which cannot be resolved: No such file or directory (os error 2). </del> <ins> pkgs/by-name/fo/foo: Path foo is a symlink which cannot be resolved: No such file or directory (os error 2). </ins>
Change:
The for libpng is known to cause animated PNGs to flicker in Chromium, and (by extension) any app which uses Electron such as and (where the problem is much more noticeable since stickers on Discord are often animated PNGs, which is how I discovered this). Chromium itself includes a , which allows APNGs to be rendered properly with an unpatched libpng. The issue does not occur when Chromium or Electron is built against an unpatched libpng. , , and previously included this patch with their libpng packages, but (I think) removed them for this reason. Chromium definitely doesn't need this patch in any case, since it breaks things there. Edit: It looks like Chromium is supposed to be built against an unpatched libpng, so I'm not sure where it's still getting the patched version from, but using an overlay to disable the patch causes it to be fixed. Steps to reproduce the behavior: in Chromium the animated PNG flickering A clear and concise description of what you expected to happen. The PNG should not flicker. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --- system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Discussion:
buildPlatformLlvmStdenv.cc pkg-config libuuid <del> libpng # needed for "host/generate_colors_info" </del> <ins> (libpng.override { apngSupport = false; }) # needed for "host/generate_colors_info" </ins> ] # When cross-compiling, chromium builds a huge proportion of its # components for both the `buildPlatform` (which it calls
Change:
rustPlatform doesn't support all workspaces features that Iced-rs requires. Specifically, I believe it's this commit (but I'm not entirely sure if that is the problem) that the tooling doesn't support: Steps to reproduce the behavior: ` That the build executes successfully. ! Console output: <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Fix is in

Discussion:
if grep -q workspace "$out/Cargo.toml"; then chmod u+w "$out/Cargo.toml" <del> ${replaceWorkspaceValues} "$out/Cargo.toml" "${tree}/Cargo.toml" </del> <ins> ${replaceWorkspaceValues} "$out/Cargo.toml" "$(${cargo}/bin/cargo metadata --format-version 1 --no-deps --manifest-path $crateCargoTOML | ${jq}/bin/jq -r .workspace_root)/Cargo.toml" </ins> fi # Cargo is happy with empty metadata.
Change:
At the moment it is not possible to install on my Mac M1 cause is not available at the moment. It would be awsome if I could disable installation of by overriding the . I also could be that I am missing how to do that. Steps to reproduce the behavior: Install Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Discussion:
{ lib <ins> , stdenv </ins> , buildPythonPackage , fetchFromGitHub <del> , fetchpatch </del> , pytestCheckHook , p7zip , cabextract

"test_unzip_file" "test_zip" "test_zip_file" <ins> ] ++ lib.optionals stdenv.isDarwin [ "test_ar" </ins> ]; meta = with lib; {

homepage = "http://mattmahoney.net/dc/zpaq.html"; license = licenses.gpl3Plus ; maintainers = with maintainers; [ raskin ]; <del> platforms = platforms.linux; </del> <ins> platforms = platforms.unix; </ins> mainProgram = "zpaq"; }; }
Change:
was looking to resume my work on espanso's (which has been somewhat impeded by ), and now I find that espanso no longer builds at all. As those issues haven't gotten much attention thought I'd reach out to to see if anyone can at least confirm (as my understanding is that the reproducibility on darwin can't be quite as good as NixOS -- especially when one ). Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Thank you so much for the quick fix! I keep running into these issues on darwin, I really want / need to learn more so I can contribute back! Unfortunately I'm still getting a build error, which looks to be a sandbox issue: This seems to fix the issue: Could you take a look and if appropriate merge? Many thanks!

Discussion:
--replace '"/usr/local/bin/espanso"' '"${placeholder "out"}/bin/espanso"' ''; <ins> env = lib.optionalAttrs stdenv.cc.isClang { # Work around https://github.com/NixOS/nixpkgs/issues/166205. NIX_LDFLAGS = "-l${stdenv.cc.libcxx.cxxabi.libName}"; }; </ins> # Some tests require networking doCheck = false;
Change:
Package name: immich-cli Latest released version: 2.0.4 <!-- Search your package here: --- Current version on the unstable channel: 0.41.0 Current version on the stable/release channel: 0.41.0 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- has since been migrated from a (now archived) . I'm actually not entirely sure if this was a migration, or a new app from scratch, in which case perhaps the current package should be marked as legacy, and a new one created? Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR.

Discussion:
, fetchFromGitHub }: <del> buildNpmPackage rec { </del> <ins> buildNpmPackage { </ins> pname = "immich-cli"; <del> version = "0.41.0"; </del> <ins> version = "2.0.6"; </ins> src = fetchFromGitHub { owner = "immich-app"; <del> repo = "CLI"; rev = "v${version}"; hash = "sha256-BpJNssNTJZASH5VTgTNJ0ILj0XucWvyn3Y7hQdfCEGQ="; </del> <ins> repo = "immich"; # Using a fixed commit until upstream has release tags for cli. rev = "014adf175ad50a61f92804666940e267ab329064"; hash = "sha256-MK3Watq5/Zp+rymCIfWxAXSgBPDE13g23uDnW7A5x9g="; </ins> }; <del> npmDepsHash = "sha256-GOYWPRAzV59iaX32I42dOOEv1niLiDIPagzQ/QBBbKc="; </del> <ins> npmDepsHash = "sha256-ssxOXKE1t/bSb972w/cBeK61IrqPLmx9ODMn6D+2Ezw="; postPatch = '' cd cli ''; </ins> meta = { <del> changelog = "https://github.com/immich-app/CLI/releases/tag/${src.rev}"; </del> description = "CLI utilities for Immich to help upload images and videos"; <del> homepage = "https://github.com/immich-app/CLI"; </del> <ins> homepage = "https://github.com/immich-app/immich"; </ins> license = lib.licenses.mit; mainProgram = "immich"; <del> maintainers = with lib.maintainers; [ felschr ]; </del> <ins> maintainers = with lib.maintainers; [ felschr pineapplehunter ]; </ins> }; }
Change:
Project description Model-rocketry aerodynamics and trajectory simulation software. Metadata homepage URL: source URL: license: gpl3 platforms: linux, darwin Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Mentioned in
Opened a PR, sorry about the long delay. I kind of got distracted refactoring other java packages for reproducibility instead of creating the PR.

Discussion:
<ins> { lib , stdenvNoCC , fetchFromGitHub , ant , jdk17 , makeWrapper }: let jdk = jdk17; # Only java 17 is supported as of 23.09 in stdenvNoCC.mkDerivation (finalAttrs: { pname = "openrocket"; version = "23.09"; src = fetchFromGitHub { owner = "openrocket"; repo = "openrocket"; rev = "release-${finalAttrs.version}"; hash = "sha256-Dg/v72N9cDG9Ko5JIcZxGxh+ClRDgf5Jq5DvQyCiYOs="; fetchSubmodules = true; }; nativeBuildInputs = [ ant jdk makeWrapper ]; buildPhase = '' runHook preBuild ant runHook postBuild ''; doCheck = true; checkPhase = '' runHook preCheck ant unittest runHook postCheck ''; installPhase = '' runHook preInstall sed -i "s|Icon=.*|Icon=openrocket|g" snap/gui/openrocket.desktop install -Dm644 snap/gui/openrocket.desktop -t $out/share/applications install -Dm644 snap/gui/openrocket.png -t $out/share/icons/hicolor/256x256/apps install -Dm644 swing/build/jar/OpenRocket.jar -t $out/share/openrocket makeWrapper ${jdk}/bin/java $out/bin/openrocket  --add-flags "-jar $out/share/openrocket/OpenRocket.jar" runHook postInstall ''; meta = { changelog = "https://github.com/openrocket/openrocket/releases/tag/${finalAttrs.src.rev}"; description = "Model-rocketry aerodynamics and trajectory simulation software"; homepage = "openrocket.info"; license = lib.licenses.gpl3Plus; mainProgram = "openrocket"; maintainers = with lib.maintainers; [ tomasajt ]; platforms = jdk.meta.platforms; sourceProvenance = with lib.sourceTypes; [ fromSource binaryBytecode # source bundles dependencies as jars ]; }; }) </ins>