jiebi/CodeConvo huggingface dataset:
Change:
<!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on GitHub to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: sumneko-lua-language-server <!-- The current version can be found easily with the same process as above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 3.2.3 desired version: 3.4.1 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Please tag this issue in your PR.

Discussion:
in stdenv.mkDerivation rec { pname = "sumneko-lua-language-server"; <del> version = "3.2.3"; </del> <ins> version = "3.4.1"; </ins> src = fetchFromGitHub { owner = "sumneko"; repo = "lua-language-server"; rev = version; <del> sha256 = "sha256-n54PWkiB+vXAqIOZ5FOTUNgGhAdBs81Q1WYxJ2XIb8o="; </del> <ins> sha256 = "sha256-A5a3cOhdPkheMooPjcZW5jneziDcFB0o3gfY2nEOJ4Y="; </ins> fetchSubmodules = true; };
Change:
crashes with option activated Steps to reproduce the behavior: slack with option a call screensharing and select a desktop crashes with Screensharing starts. Log output Even if Slack is started with this command it crashes.
I just tested it again with the following command and what should I write... it now works as expected and is stable :tada: overlay to make it more convenient.
I've came across the issue yesterday and made a PR for it, also I can't reproduce the problem issue of this issue anymore so when merged I would like to going forward, closing this? :)

Discussion:
makeWrapper $out/lib/slack/slack $out/bin/slack  --prefix XDG_DATA_DIRS : $GSETTINGS_SCHEMAS_PATH  --suffix PATH : ${lib.makeBinPath [xdg-utils]}  <del> --add-flags "''${NIXOS_OZONE_WL:+''${WAYLAND_DISPLAY:+--ozone-platform-hint=auto --enable-features=WaylandWindowDecorations}}" </del> <ins> --add-flags "''${NIXOS_OZONE_WL:+''${WAYLAND_DISPLAY:+--ozone-platform-hint=auto --enable-features=WaylandWindowDecorations}}"  --add-flags "''${WAYLAND_DISPLAY:+--enable-features=WebRTCPipeWireCapturer}" </ins> # Fix the desktop link substituteInPlace $out/share/applications/slack.desktop
Change:
Project description It's a pinentry app, using rofi. I , but failed with (pls ignore metadata on that derivation, was testing): Metadata homepage URL: source URL: license: gpl-3+ platforms: linux
I just gave it try and quickly hacked together the following (based on ): Please feel free to use this as a base for a pr.

Discussion:
<ins> { stdenv , lib , fetchFromGitHub , pkg-config , autoreconfHook , autoconf-archive , guile , texinfo , rofi }: stdenv.mkDerivation rec { pname = "pinentry-rofi"; version = "2.0.3"; src = fetchFromGitHub { owner = "plattfot"; repo = pname; rev = version; sha256 = "sha256-EzbeMAhdn9SuSmE+aMHeyuje3s74isIKRDTrFO3bX04="; }; nativeBuildInputs = [ autoconf-archive autoreconfHook pkg-config texinfo ]; buildInputs = [ guile ]; propagatedBuildInputs = [ rofi ]; meta = with lib; { description = "Rofi frontend to pinentry"; homepage = "https://github.com/plattfot/pinentry-rofi"; license = licenses.gpl3Plus; platforms = platforms.unix; maintainers = with maintainers; [ seqizz ]; }; } </ins>

pinentry-bemenu = callPackage ../tools/security/pinentry-bemenu { }; <ins> pinentry-rofi = callPackage ../tools/security/pinentry-rofi { }; </ins> pingtcp = callPackage ../tools/networking/pingtcp { }; pinnwand = callPackage ../servers/pinnwand { };
Change:
Virt-manager requires netcat version with support for arguments. version available by default does not. Steps to reproduce the behavior: virt-manager into a profile connecting to remote machine Connection successful virt-manager complains about not supporting flag. ! <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result. (this is probably mostly irrelevant as I'm using flakes to manage my profile)
Both and do support -U but does not. Since this needs to be available on the remote machine, we should add this to the module.

Discussion:
] ++ cfg.extraOptions ); <del> path = [ cfg.qemu.package ] # libvirtd requires qemu-img to manage disk images </del> <ins> path = [ cfg.qemu.package pkgs.netcat ] # libvirtd requires qemu-img to manage disk images </ins> ++ optional vswitch.enable vswitch.package ++ optional cfg.qemu.swtpm.enable cfg.qemu.swtpm.package;
Change:
<!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on GitHub to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: vala-language-server <!-- The current version can be found easily with the same process as above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 0.48.4 desired version: 0.48.5 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Please tag this issue in your PR.

Discussion:
stdenv.mkDerivation rec { pname = "vala-language-server"; <del> version = "0.48.4"; </del> <ins> version = "0.48.5"; </ins> src = fetchFromGitHub { <del> owner = "Prince781"; </del> <ins> owner = "vala-lang"; </ins> repo = pname; rev = version; <del> sha256 = "sha256-vCQ/j0DxG9sSEquPh9TtZ5hTADPh0d8sDIDSJdUDK4s="; </del> <ins> sha256 = "sha256-gntGnz8uqGz2EGwWWyty/N1ImaUKAPtXVZcjgp73SQM="; </ins> }; passthru = {

meta = with lib; { description = "Code Intelligence for Vala & Genie"; <del> homepage = "https://github.com/Prince781/vala-language-server"; </del> <ins> homepage = "https://github.com/vala-lang/vala-language-server"; </ins> license = licenses.lgpl21Plus; maintainers = with maintainers; [ andreasfelix ]; platforms = platforms.linux;
Change:
Project description screenshot tool for wlroots based compositors implementing zwlrscreencopyv1 Metadata homepage URL: source URL: license: bsd platforms: linux
have you looked if any of these packages are not already in ?
yes

Discussion:
<ins> { lib, fetchFromGitHub, rustPlatform }: rustPlatform.buildRustPackage rec { pname = "wayshot"; version = "1.1.9"; src = fetchFromGitHub { owner = "waycrate"; repo = pname; rev = version; hash = "sha256-4tzL/9p/qBCSWX+O7wZlKi9qb7mIt+hoxcQY7cWlFoU="; }; cargoHash = "sha256-/FAI2VUoyQ1+3CuA7sEpeF5oeJdGB9CRZEp1leLnTh4="; meta = with lib; { description = "A native, blazing-fast screenshot tool for wlroots based compositors such as sway and river"; homepage = "https://github.com/waycrate/wayshot"; license = licenses.bsd2; maintainers = [ maintainers.dit7ya ]; platforms = platforms.linux; }; } </ins>

waybar = callPackage ../applications/misc/waybar {}; <ins> wayshot = callPackage ../tools/misc/wayshot { }; </ins> wbg = callPackage ../applications/misc/wbg { }; hikari = callPackage ../applications/window-managers/hikari {
Change:
Project description A tool to print Wayland toplevels status and info. Metadata homepage URL: source URL: license: bsd platforms: linux

Discussion:
<ins> { lib , fetchFromSourcehut , makeWrapper , rustPlatform , wayland }: rustPlatform.buildRustPackage rec { pname = "waylevel"; version = "1.0.0"; src = fetchFromSourcehut { owner = "~shinyzenith"; repo = pname; rev = version; hash = "sha256-T2gqiRcKrKsvwGNnWrxR1Ga/VX4AyllYn1H25aIKt5s="; }; cargoHash = "sha256-gw5m1/btJ5zZP04C7BCnHqEOUBoeu0whK8W7xA+xSQo="; postFixup = '' patchelf --set-rpath ${lib.makeLibraryPath [wayland]} $out/bin/waylevel ''; meta = with lib; { description = "A tool to print wayland toplevels and other compositor info"; homepage = "https://git.sr.ht/~shinyzenith/waylevel"; license = licenses.bsd2; maintainers = with maintainers; [ dit7ya ]; platforms = platforms.linux; }; } </ins>

wayshot = callPackage ../tools/misc/wayshot { }; <ins> waylevel = callPackage ../tools/misc/waylevel { }; </ins> wbg = callPackage ../applications/misc/wbg { }; hikari = callPackage ../applications/window-managers/hikari {
Change:
Project description Autotiling for sway (and possibly i3) Metadata homepage URL: source URL: license: platforms: linux

Discussion:
<ins> { lib, fetchFromGitHub, rustPlatform }: rustPlatform.buildRustPackage rec { pname = "autotiling-rs"; version = "0.1.3"; src = fetchFromGitHub { owner = "ammgws"; repo = pname; rev = "v${version}"; sha256 = "sha256-LQbmF2M6pWa0QEbKF770x8TFLMGrJeq5HnXHvLrDDPA="; }; cargoHash = "sha256-wot5GKBA2TBrA/jnWD0eypPRqUodmk/TJlYJMl3/gm4="; meta = with lib; { description = "Autotiling for sway (and possibly i3)"; homepage = "https://github.com/ammgws/autotiling-rs"; license = licenses.mit; platforms = platforms.linux; maintainers = with maintainers; [ dit7ya ]; }; } </ins>

autotiling = python3Packages.callPackage ../misc/autotiling { }; <ins> autotiling-rs = callPackage ../misc/autotiling-rs { }; </ins> avell-unofficial-control-center = python3Packages.callPackage ../applications/misc/avell-unofficial-control-center { }; beep = callPackage ../misc/beep { };
Change:
Post merge, lots of Haskell programs print the following errors: Incidentally, it seemed that some Haskell builds were running out of memory (None left on Hydra as I restarted all of the them). There's a GHC issue mentioning this problem along with a suggested patch: should we apply?
There is some information about this issue to grab from Apparently the problem is not related to Haskell but to the version of which is fairly recent for the default nixos kernel. So if you upgrade the kernel the error should disappear. I haven't tested or try to upgrade the kernel but instead was hoping the issue would disappear with some recent nix-channel updates (the unstable channel). But so far it hasn't. I still hope for a fix to come up in a near future.
Well sorry I probably misunderstood the messages from the IRC channel. Initially this happens to me on only but it has just started to show up in another linux distro after updating the nix channel:
Also see post on nix-dev: Worked for me. Still an issue given that hydra runs on 4.4.x…
the glibc, or binutils, or hardening flags could all be causing this but using kernel 4.7 does fix it.
Personally, I'd rather configure the build with than patch the script. IMHO that's a cleaner solution. Does anyone understand the implications of this setting, i.e. does it reduce performance in any significant way etc.?
The idea is to reduce the number of system calls. With , GHC s a 1TB region of virtual memory and does its own allocations there. Disabling this feature will incur a small performance penalty when allocating. GHC has a different implementation of if it doesn't detect MADV_FREE, so I think forcibly disabling that check in the configure script is the right way to go. That way there is no performance penalty (even if it is small).
OK. Does anyone have a patch ready that accomplishes this? The patch from goes a different route which doesn't feel ideal.

Discussion:
# Fix https://ghc.haskell.org/trac/ghc/ticket/12130 (fetchFilteredPatch { url = https://git.haskell.org/ghc.git/patch/4d71cc89b4e9648f3fbb29c8fcd25d725616e265; sha256 = "0syaxb4y4s2dc440qmrggb4vagvqqhb55m6mx12rip4i9qhxl8k0"; }) (fetchFilteredPatch { url = https://git.haskell.org/ghc.git/patch/2f8cd14fe909a377b3e084a4f2ded83a0e6d44dd; sha256 = "06zvlgcf50ab58bw6yw3krn45dsmhg4cmlz4nqff8k4z1f1bj01v"; }) <del> ]; </del> <ins> ] ++ stdenv.lib.optional stdenv.isLinux ./ghc-no-madv-free.patch; </ins> buildInputs = [ ghc perl hscolour ];

<ins> diff --git a/rts/posix/OSMem.c b/rts/posix/OSMem.c index 99620ee..e052a84 100644 --- a/rts/posix/OSMem.c +++ b/rts/posix/OSMem.c @@ -523,13 +523,7 @@ void osDecommitMemory(void *at, W_ size) sysErrorBelch("unable to make released memory unaccessible"); #endif -#ifdef MADV_FREE -    // Try MADV_FREE first, FreeBSD has both and MADV_DONTNEED -    // just swaps memory out -    r = madvise(at, size, MADV_FREE); -#else r = madvise(at, size, MADV_DONTNEED); -#endif if(r < 0) sysErrorBelch("unable to decommit memory"); } </ins>
Change:
It's currently possible to cancel between deletion of previous setuid wrappers and population of new ones. And yes, I've been able to lock myself out of machine (almost, if I didn't have root ssh key). Current implementation: Proposed implementation (see at the bottom of blog post):
so this was failing because it's ready a tmpfs upon install: So, if we want to be a tmpfs and a symlink that won't work. My proposal would be to make a tmpfs and move conents to which could then be a symlink. This would be a backwards incompatible change, but we can fix it in nixpkgs and document it. Thoughts?
I think it would be better to just not have /var/setuid-wrappers be a tmpfs since we're symlinking to a tmpfs anyway.
Well, we can just change nixos-install not to create that tmpfs, right? Not sure why it's doing that anyway...
I'll have a PR ready soon, fixing a bug atm.

Discussion:
source=/nix/var/nix/profiles/default/bin/${program} fi <del> cp ${setuidWrapper}/bin/setuid-wrapper ${wrapperDir}/${program} echo -n "$source" > ${wrapperDir}/${program}.real chmod 0000 ${wrapperDir}/${program} # to prevent races chown ${owner}.${group} ${wrapperDir}/${program} chmod "u${if setuid then "+" else "-"}s,g${if setgid then "+" else "-"}s,${permissions}" ${wrapperDir}/${program} </del> <ins> cp ${setuidWrapper}/bin/setuid-wrapper $wrapperDir/${program} echo -n "$source" > $wrapperDir/${program}.real chmod 0000 $wrapperDir/${program} # to prevent races chown ${owner}.${group} $wrapperDir/${program} chmod "u${if setuid then "+" else "-"}s,g${if setgid then "+" else "-"}s,${permissions}" $wrapperDir/${program} </ins> ''; in stringAfter [ "users" ]

# programs to be wrapped. SETUID_PATH=${config.system.path}/bin:${config.system.path}/sbin <del> rm -f ${wrapperDir}/* # */ </del> <ins> mkdir -p /run/setuid-wrapper-dirs wrapperDir=$(mktemp --directory --tmpdir=/run/setuid-wrapper-dirs setuid-wrappers.XXXXXXXXXX) </ins> ${concatMapStrings makeSetuidWrapper setuidPrograms} <ins> if [ -d ${wrapperDir} ]; then mv --no-target-directory ${wrapperDir} ${wrapperDir}-old ln --symbolic $wrapperDir ${wrapperDir} rm --force --recursive ${wrapperDir}-old elif [ -L ${wrapperDir} ]; then ln --symbolic --force --no-dereference $wrapperDir ${wrapperDir}-tmp old=$(readlink ${wrapperDir}) mv --no-target-directory ${wrapperDir}-tmp ${wrapperDir} rm --force --recursive $old else ln --symbolic $wrapperDir ${wrapperDir} fi </ins> ''; };
Change:
The 'select file' dialog works fine, but I cant actually open or edit anything. Steps to reproduce the behavior: Either: via the GUI, then a design or a design via the command line: A edit window with a preview should appear. Please run and paste the result.
Judging by the error message, this might be as simple as compiling with wayland in the deps like ?
Omg it worked! Can I leave it with the maintainers or do you want me to file a PR?
If you submit the PR yourself then you automatically get ownership/credit for your work :-)

Discussion:
, qtmacextras , qmake , spacenavSupport ? stdenv.isLinux, libspnav <ins> , wayland , wayland-protocols , qtwayland </ins> }: mkDerivation rec {

eigen boost glew opencsg cgal mpfr gmp glib harfbuzz lib3mf libzip double-conversion freetype fontconfig qtbase qtmultimedia qscintilla <del> ] ++ lib.optionals stdenv.isLinux [ libGLU libGL ] </del> <ins> ] ++ lib.optionals stdenv.isLinux [ libGLU libGL wayland wayland-protocols qtwayland ] </ins> ++ lib.optional stdenv.isDarwin qtmacextras ++ lib.optional spacenavSupport libspnav ;
Change:
The nixos test for signal-desktop with the following error According to a comment in the source code, trying to access the encrypted signal database with should fail, because only should be able to read it: Steps to reproduce the behavior: on master The between the last succeeding and the first failing build: doesn't include changes to does include a version bump of So the issue might be caused by some changes to .
can you try a bisect between these two changesets?
I tried bisecting the issue, but running the test () requires mass rebuilds for most of the commits, so at least on my machine it's not feasible to find the faulty commit in a timely manner.
I just had a brief look (sorry for the delay, I don't have as much time anymore). Luckily the encryption still seems to work. is fine and I also dumped the content to the log with and it looks like random data / garbage (-encrypted). However, the behaviour of seems to have indeed changed... :o The command succeeds now and outputs just this: Theoretically we could just remove that command but for extra security I'd find it best to replace it with something that still works. However, it seems best to simply replace with (or (full)schema): I'll send in a quick PR. Thanks for the report and pinging me! :)

Discussion:
) # Only SQLCipher should be able to read the encrypted DB: machine.fail( <del> "su - alice -c 'sqlite3 ~/.config/Signal/sql/db.sqlite .databases'" </del> <ins> "su - alice -c 'sqlite3 ~/.config/Signal/sql/db.sqlite .tables'" </ins> ) print(machine.succeed( "su - alice -c 'sqlcipher ~/.config/Signal/sql/db.sqlite'"
Change:
openmpi nix package do not strip the .la files coming from libtool. This generate dependency issues for other project using libtool and nix, due to libtool trying to link against the dependencies of openmpi itself ( e.g libibverbs ) when it should not. This issue has been encountered here It is a general good practice to strip libtool .la file in package. System: (NixOS: , Ubuntu/Fedora: , ...) Nix version: (run ) Nixpkgs version: (run )
closed with

Discussion:
patchShebangs ompi/mpi/fortran/base/gen-mpi-sizeof.pl ''; <ins> postInstall = '' rm -f $out/lib/*.la ''; </ins> meta = { homepage = http://www.open-mpi.org/; description = "Open source MPI-2 implementation";
Change:
<!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on GitHub to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: electron-mail <!-- The current version can be found easily with the same process as above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 4.14.0 desired version: 5.0.1 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Please tag this issue in your PR.

Discussion:
let pname = "electron-mail"; <del> version = "4.14.0"; </del> <ins> version = "5.0.1"; </ins> name = "ElectronMail-${version}"; src = fetchurl { url = "https://github.com/vladimiry/ElectronMail/releases/download/v${version}/electron-mail-${version}-linux-x86_64.AppImage"; <del> sha256 = "sha256-sahMEj9m10gsceTBnYk8wkWcQoM5s6s1ek1U6u3PTgw="; </del> <ins> sha256 = "sha256-w6ZZPIJnAlA8WhNHtM9gsjr7U6wMYT21fGFmkDDAVJU="; </ins> }; appimageContents = appimageTools.extract { inherit name src; };

meta = with lib; { description = "ElectronMail is an Electron-based unofficial desktop client for ProtonMail"; homepage = "https://github.com/vladimiry/ElectronMail"; <del> license = licenses.mit; </del> <ins> license = licenses.gpl3; </ins> maintainers = [ maintainers.princemachiavelli ]; platforms = [ "x86_64-linux" ]; };
Change:
can panic/die and systemd still thinks the service exits successfully. Steps to reproduce the behavior: syncthing: . out of disk space, syncthing panics and exits. to see that syncthing.service has deactivated successfully, even though it prints . I expect that when syncthing.service stops due to , the service gets marked as failed. I'm not sure what the exit code of syncthing is in this case (so perhaps this is an upstream issue after all), but NixOS has this syncthing.service snippet that might hide some errors: Also, here's the syncthing.service log when it failed: NixOS 22.05 (commit ).
The contains whereas the NixOS module contains
It seems that we imported from upstream in 2015: . I haven't yet found documentation for syncthing exit codes, but it's clear now that exit code is not supposed to be a "success" in 2022.
I haven't yet found documentation for syncthing exit codes EDIT: I linked to an old version, but newer ones have the same exit codes:

Discussion:
}; systemd.services = { <ins> # upstream reference: # https://github.com/syncthing/syncthing/blob/main/etc/linux-systemd/system/syncthing%40.service </ins> syncthing = mkIf cfg.systemService { description = "Syncthing service"; after = [ "network.target" ];

wantedBy = [ "multi-user.target" ]; serviceConfig = { Restart = "on-failure"; <del> SuccessExitStatus = "2 3 4"; </del> <ins> SuccessExitStatus = "3 4"; </ins> RestartForceExitStatus="3 4"; User = cfg.user; Group = cfg.group;
Change:
Steps to reproduce the behavior: netcoredbg <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result.
My first hunch is that caused something to break it, but I'm going to investigate futher when I have the time.

Discussion:
hardeningDisable = [ "strictoverflow" ]; preConfigure = '' <ins> export DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1 </ins> dotnetVersion="$(${dotnet-sdk}/bin/dotnet --list-runtimes | grep -Po '^Microsoft.NETCore.App K.*?(?= )')" cmakeFlagsArray+=( "-DDBGSHIM_RUNTIME_DIR=${dotnet-sdk}/shared/Microsoft.NETCore.App/$dotnetVersion" )