jiebi/CodeConvo huggingface dataset:
Change:
Describe the bug texlive on master fails to build since : This commit upgraded the poppler library, and upstream they "modernized the headers", including instead of in the . texlive includes this file in a plain C program, so is not available. To Reproduce Expected behavior Should build. Additional context Gentoo had this issue too: I'm not familiar enough with gentoo to understand what the fix is doing, but it looks like they fixed it by moving to an r6 version of texlive? Metadata Maintainer information: cc
No, that's versioning of gentoo-specific tarball with patches, currently and their workaround is in texlive-core-2019- inside.
The patch was applied in . I believe poppler should be blamed instead, but it should work now at least.

Discussion:
assert stdenv.system != "powerpc-linux"; stdenv.mkDerivation rec { <del> ver = "1.21.3"; </del> <ins> ver = "1.23.1"; </ins> name = "recoll-${ver}"; src = fetchurl { url = "http://www.lesbonscomptes.com/recoll/${name}.tar.gz"; <del> sha256 = "66f039f08b149d5e4840664d4a636f6b55145b02072f87aab83282ebe0cd593a"; </del> <ins> sha256 = "0si407qm47ndy0l6zv57lqb5za4aiv0lyghnzb211g03szjkfpg8"; </ins> }; <del> patches = [ ./nodeblayout.patch ./versionawk.patch ]; </del> configureFlags = [ "--with-inotify" ]; buildInputs = [ qt4 xapian file python bison];

homepage = http://www.lesbonscomptes.com/recoll/; license = licenses.gpl2; platforms = platforms.unix; <del> maintainers = with maintainers; [ jcumming ]; </del> <ins> maintainers = [ maintainers.jcumming ]; </ins> }; }
Change:
Describe the bug Test  is broken on Master To Reproduce Steps to reproduce the behavior: Expected behavior For the test to pass Additional context I've bisected the problem to this commit:
Thank you for opening this :sparkles:
In that case let's it.
That is weird. How does depend on rsyslog?
This test is kind of flaky, there's some chance I incorrectly bisected it?
I'm bisecting again starting at
going to plug :grin: At a glance I don't see rysyslog having any relation, and likely if the tests are flakey enough bisecting can't give reliable results.
I didn't use that tool because I was bisecting by running the test thrice and only if all fail considering it a bad commit :P
cc. maybe add a flag to :P
That kind of unforseen usecase is exactly why nix-bisect is not just a tool, but a library ;) So you could write your own bisect script in python (a much more pleasant experience than doing so in bash). I may add that feature to the CLI at some poing though, since its probably a pretty common usecase. would probably be a better name, since we really want a minimum number of tries. Feel free to file an issue against :)
I tried bisecting again, but I think this result is also nonsense:
Core of the issue seems to be this:
I don't know &ndash; locally I'm getting this :arrow_up: error even on which (I tried several times).
Careful (manual) bisect lead me to a surprising result: I'll try a few more experiments now. Many my steps failed for other reasons (e.g. libselinux not building), so I suspect that's where you were led astray. I did 2-3 attempts on every step to be surer, but I found no non-determinism on my machine.
I had quite a few steps where the first attempt at building failed, but the second one succeeded, I was bisecting manually with this:
I re-confirmed that reverting that commit atop master () fixes the test for me. (Still no idea why so far.)
cc for the linux config change
Narrowed down just to the kernel option. I don't know... maybe the JIT has some bad interaction with the VM.
For now I suppose I'll push a revert of that single option, unless someone suggests a better idea very soon.
Sounds good to me

Discussion:
, liblogging ? null, libnet ? null, hadoop ? null, rdkafka ? null , libmongo-client ? null, czmq ? null, rabbitmq-c ? null, hiredis ? null, mongoc ? null , libmaxminddb ? null <ins> , nixosTests ? null </ins> }: with stdenv.lib;

(mkFlag true                      "generate-man-pages") ]; <ins> passthru.tests = { nixos-rsyslogd = nixosTests.rsyslogd; }; </ins> meta = { homepage = https://www.rsyslog.com/; description = "Enhanced syslog implementation";
Change:
Describe the bug Cross-compilation is broken since we bumped to glibc 2.30. To Reproduce Maintainer information:
I opened a workaround PR :arrow_up: Cross (boot) is probably best known by &ndash; in case you know pointers how to fix this better. (Possibly later; I don't expect we want to wait long with this PR.)

Discussion:
# nscd needs libgcc, and we don't want it dynamically linked # because we don't want it to depend on bootstrap-tools libs. echo "LDFLAGS-nscd += -static-libgcc" >> nscd/Makefile <ins> '' # FIXME: find a solution for infinite recursion in cross builds. # For now it's hopefully acceptable that IDN from libc doesn't reliably work. + lib.optionalString (stdenv.hostPlatform == stdenv.buildPlatform) '' </ins> # Ensure that libidn2 is found. patch -p 1 <<EOF

outputs = [ "bin" "dev" "out" "man" ] ++ optional withDocs "doc"; setOutputFlags = false; <del> separateDebugInfo = !(stdenv.hostPlatform.useLLVM or false) && stdenv.cc.isGNU; </del> <ins> separateDebugInfo = !(stdenv.hostPlatform.useLLVM or false) && stdenv.hostPlatform == stdenv.buildPlatform # unable to fix infinite recursion on stdenv.cc && stdenv.cc.isGNU; </ins> nativeBuildInputs = [ perl ]; buildInputs = stdenv.lib.optional withCryptodev cryptodev;
Change:
[Moved here from , where claims that this is an issue with stdenv and refers to as proof.] When I run in the source tree of , I get this: I just installed nix today so I assume I am running the current version. I have this in my : points at: I freely admit that this may be a problem with rss2email rather than a problem with nix, but it's not self-evidently that and I don't know how to debug further. Any insight you have would be appreciated.
btw, this is happening all of the time for me, I am surprised nobody opened a ticket for this already.
So we can fix this by doing a in dumpVars. It sounds like this happens when you have the option set in bash.
Opened to fix.
Yay , I also have this issue.

Discussion:
# the environment used for building. dumpVars() { if [ "${noDumpEnvVars:-0}" != 1 ]; then <del> export > "$NIX_BUILD_TOP/env-vars" || true </del> <ins> export >| "$NIX_BUILD_TOP/env-vars" || true </ins> fi }
Change:
, CVSSv3=9.1 (nixos-19.09) Scanned versions: nixos-19.09: . May contain false positives.
See also:
The upstream advisory mentions the fix could break some apps, so I suggest a proper version bump on stable.
this issue is still valid
Oops sorry
CVE-2019-: Fixed at version 0.60.8 (nixos-19.09, nixos-20.03, nixos-unstable).

Discussion:
in stdenv.mkDerivation rec { <del> name = "aspell-0.60.6.1"; </del> <ins> name = "aspell-0.60.8"; </ins> src = fetchurl { url = "mirror://gnu/aspell/${name}.tar.gz"; <del> sha256 = "1qgn5psfyhbrnap275xjfrzppf5a83fb67gpql0kfqv37al869gm"; </del> <ins> sha256 = "1wi60ankalmh8ds7nplz434jd7j94gdvbahdwsr539rlad8pxdzr"; </ins> }; <del> patches = [ (fetchpatch { # remove in >= 0.60.7 name = "gcc-7.patch"; url = "https://github.com/GNUAspell/aspell/commit/8089fa02122fed0a.diff"; sha256 = "1b3p1zy2lqr2fknddckm58hyk95hw4scf6hzjny1v9iaic2p37ix"; }) (fetchpatch { name = "CVE-2019-17544.patch"; url = "https://github.com/GNUAspell/aspell/commit/80fa26c74279fced8d778351cff19d1d8f44fe4e.patch"; sha256 = "0k5dnh8gcb7chnyx7jgkksqmz2hm05hmrvcd0znsfib975pvp4rg"; }) ] ++ stdenv.lib.optional searchNixProfiles ./data-dirs-from-nix-profiles.patch; </del> <ins> patches = stdenv.lib.optional searchNixProfiles ./data-dirs-from-nix-profiles.patch; </ins> postPatch = '' patch interfaces/cc/aspell.h < ${./clang.patch} ''; <del> nativeBuildInputs = [ perl ]; </del> <ins> buildInputs = [ perl ]; </ins> doCheck = true;
Change:
, CVSSv3=7.5 (nixos-unstable) Scanned versions: nixos-unstable: . May contain false positives.
PR is in staging.
do you think I should also port this to staging-19.09 and/or staging-20.03?
Oh, I didn't realize as this ticket only mentioned unstable :-) OK, I picked it directly. The patch is so simple that I feel sufficiently confident that it will work even one minor release earlier.

Discussion:
# Media support MEDIA_CAMERA_SUPPORT? y MEDIA_RC_SUPPORT? y <ins> MEDIA_USB_SUPPORT y </ins> ${if kernelPlatform ? kernelExtraConfig then kernelPlatform.kernelExtraConfig else ""} ${extraConfig}
Change:
Describe the bug To Reproduce Steps to reproduce the behavior: Expected behavior Works. Metadata Maintainer information:
cc
I am getting same error
/cc . Maybe the closure size got reduced a bit too much
Hmm, this only seems to come up in . I think we plausibly just want to remove that function.

Discussion:
patches = [ ./gcloud-path.patch <ins> ./gsutil-disable-updates.patch </ins> ]; installPhase = ''

# remove tests and test data find $out -name tests -type d -exec rm -rf '{}' + <ins> rm $out/google-cloud-sdk/platform/gsutil/gslib/commands/test.py </ins> # compact all the JSON find $out -name *.json | while read path; do

<ins> diff --git a/platform/gsutil/gslib/command_runner.py b/platform/gsutil/gslib/command_runner.py index 06ca5e5..4a4e225 100644 --- a/platform/gsutil/gslib/command_runner.py +++ b/platform/gsutil/gslib/command_runner.py @@ -61,7 +61,6 @@ from gslib.utils.text_util import InsistAsciiHeaderValue from gslib.utils.text_util import print_to_fd from gslib.utils.unit_util import SECONDS_PER_DAY from gslib.utils.update_util import LookUpGsutilVersion -from gslib.tests.util import HAS_NON_DEFAULT_GS_HOST def HandleHeaderCoding(headers): @@ -331,17 +330,6 @@ class CommandRunner(object): Returns: Return value(s) from Command that was run. """ -    command_changed_to_update = False -    if (not skip_update_check and -        self.MaybeCheckForAndOfferSoftwareUpdate(command_name, debug)): -      command_name = 'update' -      command_changed_to_update = True -      args = [_StringToSysArgType('-n')] - -      # Check for opt-in analytics. -      if system_util.IsRunningInteractively() and collect_analytics: -        metrics.CheckAndMaybePromptForAnalyticsEnabling() - if not args: args = [] @@ -414,18 +402,10 @@ class CommandRunner(object): ShutDownGsutil() if GetFailureCount() > 0: return_code = 1 -    if command_changed_to_update: -      # If the command changed to update, the user's original command was -      # not executed. -      return_code = 1 -      print('n'.join( -          textwrap.wrap( -              'Update was successful. Exiting with code 1 as the original command ' -              'issued prior to the update was not executed and should be re-run.' -          ))) return return_code def MaybeCheckForAndOfferSoftwareUpdate(self, command_name, debug): +    return False """Checks the last time we checked for an update and offers one if needed. Offer is made if the time since the last update check is longer </ins>
Change:
Describe the bug It is not able to build 3.4.2 with To Reproduce Steps to reproduce the behavior: Expected behavior Successfully build Additional context It looks like there is a build issue with 3.4.2 (, , ). It would be better to update to version 3.5.1 from Metadata Please run and paste the result. system: host os: multi-user?: sandbox: version: channels(jjc93): nixpkgs: Maintainer information:
I tried to update it locally, and failed. It still gives me .

Discussion:
stdenv.mkDerivation rec { pname = "lean"; <del> version = "3.4.2"; </del> <ins> version = "3.5.1"; </ins> src = fetchFromGitHub { <del> owner  = "leanprover"; </del> <ins> owner  = "leanprover-community"; </ins> repo   = "lean"; rev    = "v${version}"; <del> sha256 = "0zpnfg6kyg120rrdr336i1lymmzz4xgcqpn96iavhzhlaanmx55l"; </del> <ins> sha256 = "0m7knf1hfbn2v6p6kmqxlx8c40p5nzv8d975w2xwljaccc42j1yp"; </ins> }; nativeBuildInputs = [ cmake ];
Change:
Steam shows "Show in Steam" instead of the appropriate options without installed: ! The following gets printed to stdout when right-clicking on a friend: With installed: ! NixOS version: 19.09
thanks for opening a ticket :)

Discussion:
gdk-pixbuf pango fontconfig <ins> # friends options won't display "Launch Game" without it lsof </ins> ] ++ (if (!nativeOnly) then [ (steamPackages.steam-runtime-wrapped.override { inherit runtimeOnly;
Change:
Project description A bitmap font optimized for coziness. Metadata homepage URL: source URL: license: MIT platforms: Linux
If you have never contributed to nixpkgs, a font package would be a good start. This one specifically provides all the formats you may ever need, so no conversion/build is needed at all: just copying files. If you want to try I can help you, otherwise you'll probably have to wait until I'm done with issue .

Discussion:
githubId = 7716744; name = "Berno Strik"; }; <ins> brettlyons = { email = "blyons@fastmail.com"; github = "brettlyons"; githubId = 3043718; name = "Brett Lyons"; }; </ins> btlvr = { email = "btlvr@protonmail.com"; github = "btlvr";

<ins> { stdenv, fetchurl, mkfontscale }: let version = "1.5.1"; releaseUrl = "https://github.com/slavfox/Cozette/releases/download/v.${version}"; in stdenv.mkDerivation rec { pname = "Cozette"; inherit version; srcs = map fetchurl [ { url = "${releaseUrl}/cozette.otb"; sha256 = "05k45n7jar11gnng2awpmc7zk9jdlzd6wz87xx49cp75jm4z9xm8"; } { url = "${releaseUrl}/CozetteVector.otf"; sha256 = "1sqhnjpizn1wi26lc7z2zml7yr7zkcpa72mh1drvd74rlcs1ip30"; } { url = "${releaseUrl}/CozetteVector.ttf"; sha256 = "1q4ml8shv9lmyc6bwhffwvbvl92s73j7xkb0rkqvci4f0zbz7mcy"; } ]; nativeBuildInputs = [ mkfontscale ]; sourceRoot = "./"; unpackCmd = '' otName=$(stripHash "$curSrc") cp $curSrc ./$otName ''; installPhase = '' install -D -m 644 *.otf -t "$out/share/fonts/opentype" install -D -m 644 *.ttf -t "$out/share/fonts/truetype" install -D -m 644 *.otb -t "$out/share/fonts/misc" mkfontdir "$out/share/fonts/misc" mkfontscale "$out/share/fonts/truetype" mkfontscale "$out/share/fonts/opentype" ''; outputs = [ "out" ]; meta = with stdenv.lib; { description = "A bitmap programming font optimized for coziness."; homepage = "https://github.com/slavfox/cozette"; license = licenses.mit; platforms = platforms.all; maintainers = with maintainers; [ brettlyons ]; }; } </ins>

corefonts = callPackage ../data/fonts/corefonts { }; <ins> cozette = callPackage ../data/fonts/cozette { }; </ins> culmus = callPackage ../data/fonts/culmus { }; clearlyU = callPackage ../data/fonts/clearlyU
Change:
Describe the bug is broken on macOS, due to the casing of a symlink ( is spelled as ) To Reproduce Steps to reproduce the behavior: Expected behavior being cased correctly. Screenshots <img width="1479" alt="Screenshot 2020-02-17 at 16 18 43" src="https://user-"Additional Context Electron is the only package that cases this way. All other packages appear to be using instead. (source: ) Patch: Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
Would be nice to also fix 5.x and 6.x while at it.
Ah, my bad. Was looking at an slightly outdated revision.

Discussion:
unzip $src mv Electron.app $out/Applications mkdir -p $out/bin <del> ln -s $out/Applications/Electron.app/Contents/MacOs/Electron $out/bin/electron </del> <ins> ln -s $out/Applications/Electron.app/Contents/MacOS/Electron $out/bin/electron </ins> ''; }; in
Change:
Project description Client for authenticating to services using a German ID Metadata homepage URL: source URL: license: EUPL platforms: unix, linux, darwin, win32

Discussion:
fullName = "European Union Public License 1.1"; }; <ins> eupl12 = spdx { spdxId = "EUPL-1.2"; fullName = "European Union Public License 1.2"; }; </ins> fdl12 = spdx { spdxId = "GFDL-1.2-only"; fullName = "GNU Free Documentation License v1.2 only";

<ins> { stdenv, mkDerivation, fetchFromGitHub, cmake, pkgconfig, pcsclite, qtsvg, qttools, qtwebsockets , qtquickcontrols2, qtgraphicaleffects }: mkDerivation rec { pname = "AusweisApp2"; version = "1.20.0"; src = fetchFromGitHub { owner = "Governikus"; repo = "AusweisApp2"; rev = "${version}"; sha256 = "0qkwdaxhig4qjim7h20j6ln6w76ycppfc786nd8l69bd1qv46m40"; }; nativeBuildInputs = [ cmake pkgconfig ]; buildInputs = [ qtsvg qttools qtwebsockets qtquickcontrols2 qtgraphicaleffects pcsclite ]; meta = with stdenv.lib; { description = "Authentication software for the German ID card"; downloadPage = "https://github.com/Governikus/AusweisApp2/releases"; homepage = "https://www.ausweisapp.bund.de/ausweisapp2/"; license = licenses.eupl12; maintainers = with maintainers; [ b4dm4n ]; platforms = platforms.linux; }; } </ins>

aesop = callPackage ../applications/office/aesop { }; <ins> AusweisApp2 = libsForQt5.callPackage ../applications/misc/ausweisapp2 { }; </ins> avidemux = libsForQt5.callPackage ../applications/video/avidemux { }; avrdudess = callPackage ../applications/misc/avrdudess { };
Change:
Describe the bug When trying to use the nixos module a patch is applied. This patch however does not match the updated fish package for . To Reproduce Steps to reproduce the behavior: containing: Expected behavior The module should be able to be enabled. Additional context Metadata system: host os: multi-user?: sandbox: version: nixpkgs: master @ Maintainer information:
Sorry about that. Could you see if solves your problem (it should, I hope)? I don't have an easy way to test this on NixOS :grimacing:

Discussion:
--- a/create_manpage_completions.py +++ b/create_manpage_completions.py <del> @@ -776,8 +776,6 @@ def parse_manpage_at_path(manpage_path, output_directory): </del> <ins> @@ -844,10 +844,6 @@ def parse_manpage_at_path(manpage_path, output_directory): </ins> built_command_output.insert(0, "# " + CMDNAME) -            # Output the magic word Autogenerated so we can tell if we can overwrite this <del> -            built_command_output.insert(1, "# Autogenerated from man page " + manpage_path) </del> <ins> -            built_command_output.insert( -                1, "# Autogenerated from man page " + manpage_path -            ) </ins> # built_command_output.insert(2, "# using " + parser.__class__.__name__) # XXX MISATTRIBUTES THE CULPABILE PARSER! Was really using Type2 but reporting TypeDeroffManParser for line in built_command_output:
Change:
Describe the bug When using mosh/tmux is first read by the login shell that spawns mosh-server, which sets . The actual user shell spawned by mosh will therefor ignore this file and not set its fpath. For that reason all system provided completion functions are ignored.
This bug was introduced by in who changed this variable to . What was the reasoning for not changing the environment of interactive non-login shells?
Um, this was six years ago, but I will attempt to answer the question. :sweat_smile: Consider this scenario: log in and the shell environment is initialized. make some local changes to the environment, and export them. open a sub-shell and the shell environment is re-initialized. changes made in the parent shell environment are not present in the sub-shell, as one would expect. Basically, the zsh initialization process would clobber any environment that you tried to propagate from a parent shell into a child sub-shell.
Currently zshenv by default only set fpath and HELPDIR without exporting them. A parent shell would also not set those variables usually as they are shell local. It also sources a file called set-environment but this is protected by an environment variable called . Hence any modification done by the parent shell should persist as long as NIXOSSETENVIRONMENTDONE is not unset. This behavior deviates from what we do in bashrc and breaks common setups such as tmux/mosh or screen. Hence I would revert it.
I don't think, at that time, this worked as you describe, but it was six years ago, and I haven't used zsh in years anyway, so my memory is not entirely trustworthy. If reverting my commit fixes mosh and tmux, and doesn't obviously break anything else, then go for it!

Discussion:
# This file is read for all shells. # Only execute this file once per shell. <del> # But don't clobber the environment of interactive non-login children! </del> if [ -n "$__ETC_ZSHENV_SOURCED" ]; then return; fi <del> export __ETC_ZSHENV_SOURCED=1 </del> <ins> __ETC_ZSHENV_SOURCED=1 </ins> if [ -z "$__NIXOS_SET_ENVIRONMENT_DONE" ]; then . ${config.system.build.setEnvironment}
Change:
Package reaper-5.981 is out of date. Latest available version is 6.03.
cc

Discussion:
{ stdenv, fetchurl, autoPatchelfHook, makeWrapper <del> , alsaLib, xorg </del> <ins> , alsaLib, xorg, libjack2 </ins> , gtk3, pango, gdk-pixbuf, cairo, glib, freetype , libpulseaudio, xdg_utils }: stdenv.mkDerivation rec { pname = "reaper"; <del> version = "5.987"; </del> <ins> version = "6.10"; </ins> src = fetchurl { url = "https://www.reaper.fm/files/${stdenv.lib.versions.major version}.x/reaper${builtins.replaceStrings ["."] [""] version}_linux_x86_64.tar.xz"; <del> sha256 = "040k5inzj7mmi75fc6hr0ym18y5xss1675bl5rmhn4sq535m289k"; </del> <ins> sha256 = "1p54phmsa6xbqxb5cpgwnz7ny4famb8zi25y3cmxwgr4pfy94b2p"; </ins> }; nativeBuildInputs = [ autoPatchelfHook makeWrapper ];

rm $out/opt/REAPER/uninstall-reaper.sh wrapProgram $out/opt/REAPER/reaper  <del> --prefix LD_LIBRARY_PATH : ${libpulseaudio}/lib </del> <ins> --prefix LD_LIBRARY_PATH : "${stdenv.lib.makeLibraryPath [ libpulseaudio libjack2 ]}" </ins> mkdir $out/bin ln -s $out/opt/REAPER/reaper $out/bin/