jiebi/CodeConvo huggingface dataset:
Change:
Describe the bug On the latest nixos-unstable-small, jetbrains idea-ultimate crashes when font ligatures are enabled due to a segfault in the libharfbuzz-library. This library is a dependency of . From the crash log file: To Reproduce Steps to reproduce the behavior: idea-ultimate to Editor Font and enable ligatures a project a file editor crashes and exits I was able to open an empty project without files. Once I created a file it crashed. I think this might have something to do with the rendering of font ligatures. This also occurs when trying to open the editor font settings (not the normal font settings). Expected behavior Intellij IDEA Ultimate should be able to open files normally. Screenshots The last screen before the program exits: ! Additional context I am running the Fira Code font which has ligatures. Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(rien): nixpkgs: Maintainer information:
The crashes are still occurring after reverting . I will try to look for recent changes with fonts that might have caused this.
I was able to pinpoint the problem. After a full reset everything works again. Going to Editor Font and selecting "Enable font ligatures" immediately crashes it. I have opened a report with JetBrains for this issue:
I was able to fix this issue by reverting this commit where jetbrains-jdk was updated from 11.0.7-b64 to 11.0,10.b37. how should we go further with this? It seems like this issue is solved in the latest release.

Discussion:
openjdk11.overrideAttrs (oldAttrs: rec { pname = "jetbrains-jdk"; <del> version = "11.0.10-b37"; </del> <ins> version = "11.0.10-b1427"; </ins> src = fetchFromGitHub { owner = "JetBrains"; repo = "JetBrainsRuntime"; rev = "jb${lib.replaceStrings ["."] ["_"] version}"; <del> sha256 = "0bcvwnwi29z000b1bk5dhfkd33xfp9899zc3idzifdwl7q42zi02"; </del> <ins> sha256 = "sha256-2cn+FiFfGpp7CBeQMAASVZwTm6DOFaXaWxAL/nVC2Nk="; </ins> }; patches = []; meta = with lib; {
Change:
Describe the bug If a has a linebreak (), then it will fail when building with the following To Reproduce Use something like Expected behavior Somewhat expect it to remove suffix "n", but not entirely sure if this should be fixed. Screenshots If applicable, add screenshots to help explain your problem. Additional context Add any other context about the problem here. Fixed by doing Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Hope it is OK I tag you, just to have a discussion about it: Metadata Please run and paste the result. Maintainer information:
I don't think that the wireguard module should concern itself with this kind of thing, attempting to santise or modify user input here seems like a somewhat sisyphean task that will result in unexpected behaviour and unnesscessary maintaince overhead. As a side note are you aware of ?
But shouldn't the type just not allow linebreaks?
Which one of the would you use for this?
Hmm. well it should be OK I guess. I thought str would not allow newlines. However a option could be to add to this :) Or assert a error if it contains newlines, so that it does not fail silently.

Discussion:
publicKey = mkOption { example = "xTIBA5rboUvnH4htodjb6e697QjLERt1NAB4mZqp8Dg="; <del> type = types.str; </del> <ins> type = types.singleLineStr; </ins> description = lib.mdDoc "The base64 public key of the peer."; };

peer1 = { privateKey = "uO8JVo/sanx2DOM0L9GUEtzKZ82RGkRnYgpaYc7iXmg="; <del> publicKey = "Ks9yRJIi/0vYgRmn14mIOQRwkcUGBujYINbMpik2SBI="; </del> <ins> # readFile'd keys may have trailing newlines, emulate this publicKey = "Ks9yRJIi/0vYgRmn14mIOQRwkcUGBujYINbMpik2SBI=n"; </ins> }; }
Change:
My understanding was that nix rejected the / distinction and we avoided having folders in our outputs. At the same time, I see that at least the following packages have nontrivial output folders: - - - probably several more And that we have workarounds like in place to deal with that fact. Questions: Are those packages supposed to have output folders? Is the exception policy described somewhere? What mechanism is suppressing in , for example? It looks like at least for , the was intentional:
Are you sure they're not symlinks? E.g. for iptables is a symlink: The script seems to be working fine here and on Hydra. For the other examples, they were written before the move-sbin-to-bin script, so they can probably just be fixed to use /bin. A stricter policy would be to remove /sbin completely; I like that, as the current approach does cause some overhead, particularly in buildEnv (It's not smart enough to merge all the symlinks together) Old mailing list discussion:
That would first need quite some changes in nixpkgs: but it should be safe to sed this without much checking.
All packages on this list do have sbin only as symlink to bin (x86_64-linux, master). Perhaps some buildEnv confused you? (It seems you meant the same platform.) The string there was very long ago: .
(triage) Is there an action item? Are the sbin folders problematic?
i believe there is a fixupPhase that moves all sbin items to bin, but then symlinks sbin to bin incase sbin paths where hard-coded into things that may be part of what is adding confusion to this
In all the cases above it's just a symlink, as there's that hook moving stuff around. It doesn't seem likely to me that someone would really want to eliminate all references, as it's nontrivial work with risks of breakage and very little to gain IMHO. (Also, contrary to merge that is quite common nowadays, I haven't noticed any other distro getting rid of .)

Discussion:
serviceConfig = { ExecStart = <del> "${cfgc.package}/sbin/sshd " + (optionalString cfg.startWhenNeeded "-i ") + </del> <ins> "${cfgc.package}/bin/sshd " + (optionalString cfg.startWhenNeeded "-i ") + </ins> "-f ${pkgs.writeText "sshd_config" cfg.extraConfig}"; KillMode = "process"; } // (if cfg.startWhenNeeded then {

# I set --disable-strip because later we strip anyway. And it fails to strip # properly when cross building. configureFlags = [ <ins> "--sbindir=${out}/bin" </ins> "--localstatedir=/var" "--with-pid-dir=/run" "--with-mantype=man"
Change:
<!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on github to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: sayonara <!-- The current version can be found easily with the same process than above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 1.6.0-beta6 desired version: 1.6.0-beta7 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: Please tag this issue in your PR.

Discussion:
{ mkDerivation , cmake , fetchFromGitLab <ins> , nix-update-script </ins> , gst_all_1 , lib , libpulseaudio

, qttools , taglib , zlib <ins> , python3 </ins> }: <ins> let py = python3.withPackages (ps: with ps; [ pydbus ]); in </ins> mkDerivation rec { <del> pname = "sayonara-player"; version = "1.6.0-beta6"; </del> <ins> pname = "sayonara"; version = "1.6.0-beta7"; </ins> src = fetchFromGitLab { owner = "luciocarreras"; repo = "sayonara-player"; rev = version; <del> sha256 = "sha256-SbJS0DQvbW++CNXbuDHQxFlLRb1kTtDdIdHOqu0YxeQ="; </del> <ins> sha256 = "14svszfldx32vn937rszd21rgl31vb5kzs0hnrg41ygx0br61rvd"; </ins> }; nativeBuildInputs = [ cmake ninja pkg-config qttools ];

qtbase taglib zlib <ins> py </ins> ] ++ (with gst_all_1; [ gstreamer

qtWrapperArgs+=(--prefix GST_PLUGIN_SYSTEM_PATH_1_0 : "$GST_PLUGIN_SYSTEM_PATH_1_0") ''; <ins> passthru = { updateScript = nix-update-script { attrPath = pname; }; }; </ins> meta = with lib; { description = "Sayonara music player"; homepage = "https://sayonara-player.com/";
Change:
Describe the bug On current nixos-unstable, yubioath-desktop starts up, but does not detect a connected yubikey and spews error messages to the terminal. I believe this is related to and might be fixable by updating the package. To Reproduce Steps to reproduce the behavior: a yubikey (4 nano); set and rebuild (optional, I believe) Expected behavior Would expect the key to be discovered and silence on the terminal. Screenshots Additional context (none) Notify maintainers Metadata Please run and paste the result. system: host os: multi-user?: sandbox: version: nixpkgs: `/nix/store/d7bsnyyw1wbmkv197krfd0fbaw1rqcpv-source Maintainer information:
Version 5.0.5 seems to include the fix and will probably be released soon. I'll update the package once it has made it to their release website.
Thank you! I could work around the issue by using: for now (this may break some of the things fixed in patches)
Looks like 5.0.5 is released:
tarballs haven't been published yet.

Discussion:
<del> From 5eb4d6a384753896d495b09d8651c48672ef234d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Thalheim?= <joerg@thalheim.io> Date: Wed, 25 Nov 2020 11:26:49 +0100 Subject: [PATCH] replace git with normal python package MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Jörg Thalheim <joerg@thalheim.io> --- requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/requirements.txt b/requirements.txt index ef25aad..b4246a4 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,2 +1,2 @@ -git+https://github.com/Yubico/yubikey-manager.git +yubikey-manager ./py/qr -- 2.29.2 </del>

mkDerivation rec { pname = "yubioath-desktop"; <del> version = "5.0.4"; </del> <ins> version = "5.0.5"; </ins> src = fetchurl { url = "https://developers.yubico.com/yubioath-desktop/Releases/yubioath-desktop-${version}.tar.gz"; <del> sha256 = "1aw88xvg6gjsfwmmlcrdcgyycn2cp7b8vxjzj14h7igcj02xh84h"; </del> <ins> sha256 = "05xs6xh9pi50h0668arirj0gnz11adpixgsdkds072077gasdm0g"; </ins> }; doCheck = false;

nativeBuildInputs = [ qmake makeWrapper python3.pkgs.wrapPython ]; <del> patches = [ ./0001-replace-git-with-normal-python-package.patch ]; </del> postPatch = '' substituteInPlace deployment.pri  --replace '/usr/bin' "$out/bin"
Change:
Describe the bug does not build because of: To Reproduce Steps to reproduce the behavior: Expected behavior The library is built Screenshots If applicable, add screenshots to help explain your problem. Additional context Add any other context about the problem here. Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Metadata system: host os: multi-user?: sandbox: version: channels(kpg): channels(root): nixpkgs: Maintainer information:

Discussion:
sed '/^void doit(void)/,/^{/ s/{/{ exit(77);/' -i tests/{trust-store,psk-file}.c sed 's:/usr/lib64/pkcs11/ /usr/lib/pkcs11/ /usr/lib/x86_64-linux-gnu/pkcs11/:`pkg-config --variable=p11_module_path p11-kit-1`:' -i tests/p11-kit-trust.sh '' + lib.optionalString stdenv.hostPlatform.isMusl '' # See https://gitlab.com/gnutls/gnutls/-/issues/945 <del> sed '2iecho "certtool tests skipped in musl build"nexit 0' -i tests/cert-tests/certtool </del> <ins> sed '2iecho "certtool tests skipped in musl build"nexit 0' -i tests/cert-tests/certtool.sh </ins> ''; preConfigure = "patchShebangs .";
Change:
Describe the bug When I try to pull from a remote repository using ostree, it fails. Note that flatpak is not affected, just ostree. To Reproduce Steps to reproduce the behavior: Expected behavior It would download the source files of org.freedesktop.Sdk (actually I'm not sure I'm doing that part right, but the TLS error seems like a Nix problem) Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(root): channels(qolen): nixpkgs: Maintainer information:
This is a problem with not getting set properly. Should we wrap the ostree binary?
When I set in the derivation, as i've seen suggsted, I get "Failed to load TLS database: Failed to load system trust store: Error while reading file." instead
(seems to be the same issue as )

Discussion:
, xz , e2fsprogs , libsoup <ins> , glib-networking , wrapGAppsHook </ins> , gpgme , which , makeWrapper

libxslt docbook-xsl-nons docbook_xml_dtd_42 <ins> wrapGAppsHook </ins> ]; buildInputs = [

systemd e2fsprogs libsoup <ins> glib-networking </ins> gpgme fuse libselinux
Change:
for example, here's an excerpt note that it explicitly instructs to write with quotes, but the example doesn't have them. This may be a problem with how the docs are generated from the nix expressions
That's because the definition is wrong, it should use in

Discussion:
boot.kernel.sysctl = mkOption { default = {}; <del> example = { "net.ipv4.tcp_syncookies" = false; "vm.swappiness" = 60; }; </del> <ins> example = literalExample '' { "net.ipv4.tcp_syncookies" = false; "vm.swappiness" = 60; } ''; </ins> type = types.attrsOf sysctlOption; description = '' Runtime parameters of the Linux kernel, as set by
Change:
Describe the bug same with previous versions nixpkgs at nixpkgs at nixpkgs at their download url seems not stable. i got the same file (hash) every time the latest version is 3.10.5. an update should fix it. but stable url would still be good To Reproduce Steps to reproduce the behavior: ... ... ... Expected behavior A clear and concise description of what you expected to happen. Screenshots If applicable, add screenshots to help explain your problem. Additional context Add any other context about the problem here. Notify maintainers Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:

Discussion:
stdenv.mkDerivation rec { pname = "ocenaudio"; <del> version = "3.10.2"; </del> <ins> version = "3.10.6"; </ins> src = fetchurl { url = "https://www.ocenaudio.com/downloads/index.php/ocenaudio_debian9_64.deb?version=${version}"; <del> sha256 = "sha256-mmo6/zc/3R8ptXfY01RKUOLgmDhWTHiYBMlGqpdMTAo="; </del> <ins> sha256 = "0fgvm1xw2kgrqj3w6slpfxbb3pw9k8i0dz16q9d5d8gyyvr2mh8g"; </ins> }; nativeBuildInputs = [ autoPatchelfHook qt5.qtbase <ins> qt5.wrapQtAppsHook </ins> libjack2 libpulseaudio bzip2

dontUnpack = true; dontBuild = true; dontStrip = true; <del> dontWrapQtApps = true; </del> installPhase = '' mkdir -p $out
Change:
Describe the bug nnn fails to install on MacOs (darwin) because archivemount is not supported on darwin platform To Reproduce Steps to reproduce the behavior: -shell -p nnn Notify maintainers Metadata Please run and paste the result. Maintainer information:
This is fixed in . <details</details
Actually, that wasn't enough. I overlooked that archivemount was only a part of . For the latest nnn to build on Darwin, the vlock dependency would have to be disabled. Moreover, the dependencies that were are command line utilities that nnn can optionally use if installed. As these are command line utilities that users would typically choose to explicitly install if needed, I think it's enough to let nnn pick up the available commands from at runtime rather than having the nnn package depend on them. Or maybe introduce an option (e.g., ) to include those dependencies.

Discussion:
<del> { lib, stdenv, fetchFromGitHub, pkg-config, makeWrapper, ncurses, readline , archivemount, atool, fzf, libarchive, rclone, sshfs, unzip, vlock , conf ? null, withIcons ? false, withNerdIcons ? false }: </del> <ins> { lib , stdenv , fetchFromGitHub , installShellFiles , makeWrapper , pkg-config , file , ncurses , readline , which # options , conf ? null , withIcons ? false , withNerdIcons ? false }: </ins> # Mutually exclusive options assert withIcons -> withNerdIcons == false;

configFile = lib.optionalString (conf != null) (builtins.toFile "nnn.h" conf); preBuild = lib.optionalString (conf != null) "cp ${configFile} src/nnn.h"; <del> nativeBuildInputs = [ pkg-config makeWrapper ]; </del> <ins> nativeBuildInputs = [ installShellFiles makeWrapper pkg-config ]; </ins> buildInputs = [ readline ncurses ]; <del> makeFlags = [ "PREFIX=$(out)" ] </del> <ins> makeFlags = [ "PREFIX=${placeholder "out"}" ] </ins> ++ lib.optional withIcons [ "O_ICONS=1" ] ++ lib.optional withNerdIcons [ "O_NERD=1" ]; <del> # shell completions </del> <ins> binPath = lib.makeBinPath [ file which ]; </ins> postInstall = '' <del> install -Dm555 misc/auto-completion/bash/nnn-completion.bash $out/share/bash-completion/completions/nnn.bash install -Dm555 misc/auto-completion/zsh/_nnn -t $out/share/zsh/site-functions install -Dm555 misc/auto-completion/fish/nnn.fish -t $out/share/fish/vendor_completions.d </del> <ins> installShellCompletion --bash --name nnn.bash misc/auto-completion/bash/nnn-completion.bash installShellCompletion --fish misc/auto-completion/fish/nnn.fish installShellCompletion --zsh misc/auto-completion/zsh/_nnn </ins> <del> wrapProgram $out/bin/nnn  --prefix PATH : ${lib.makeBinPath [ archivemount atool fzf libarchive rclone sshfs unzip vlock ]} </del> <ins> wrapProgram $out/bin/nnn --prefix PATH : "$binPath" </ins> ''; meta = with lib; {
Change:
Describe the bug kernel module fails to build against . To Reproduce Steps to reproduce the behavior: something that depends on (e.g. , add to list) Expected behavior successfully rebuilds and kernel modules that are depending on are working as expected. Additional context It fails to build with (which refers to kernel version at the moment, and is pointing to this version) but successfully builds with for me. Here are logs chunks that have the information about the failure: Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --- () () () Metadata Please note that I’m using because I couldn’t build it with . system: host os: multi-user?: sandbox: version: channels(root): channels(wenzel): nixpkgs: The channel pin is: Maintainer information:
fixed in newer version of evdi.
appreciated if you have the time to test it out ;)
This should be merged now, please try again and reopen if the issue persists. :)
sorry, I was busy to test it, but I’m planning to. Do you know if this is going to be backported to ?
Sorry, I will reopen this again. Didn't think about 20.09. I will just check what the best way is to go about that :)
I have opened a backport PR, can you test it out?
Backported and everything, should work fine. Closing. Feel free to reopen if there is still a issue!
sorry, I didn’t have time to test this. Now tested against NixOS 20.09, it compiles with latest kernelPackages and works fine after restart :+1:

Discussion:
in stdenv.mkDerivation rec { pname = "displaylink"; <del> version = "5.3.1.34"; </del> <ins> version = "5.4.0-55.153"; </ins> src = requireFile rec { name = "displaylink.zip"; <del> sha256 = "1c1kbjgpb71f73qnyl44rvwi6l4ivddq789rwvvh0ahw2jm324hy"; </del> <ins> sha256 = "1m2l3bnlfwfp94w7khr05npsbysg9mcyi7hi85n78xkd0xdcxml8"; </ins> message = '' In order to install the DisplayLink drivers, you must first comply with DisplayLink's EULA and download the binaries and sources from here: <del> https://www.displaylink.com/downloads/file?id=1576 </del> <ins> https://www.synaptics.com/node/3751 </ins> Once you have downloaded the file, please use the following commands and re-run the installation:

stdenv.mkDerivation rec { pname = "evdi"; <del> version = "v1.7.2"; </del> <ins> version = "unstable-20210401"; </ins> src = fetchFromGitHub { owner = "DisplayLink"; repo = pname; <del> rev = version; sha256 = "074j0xh037n8mc4isihfz9lap57wvxaxib32pvy6jhjl3wyik632"; </del> <ins> rev = "b0b3d131b26df62664ca33775679eea7b70c47b1"; sha256 = "09apbvdc78bbqzja9z3b1wrwmqkv3k7cn3lll5gsskxjnqbhxk9y"; </ins> }; nativeBuildInputs = kernel.moduleBuildDependencies;

platforms = platforms.linux; license = with licenses; [ lgpl21 gpl2 ]; homepage = "https://www.displaylink.com/"; <del> broken = with kernel; kernelOlder "5" || stdenv.isAarch64; </del> <ins> broken = versionOlder kernel.version "4.19" || stdenv.isAarch64; </ins> }; }
Change:
Describe the bug Keyboard backlight keys don't work out of the box on LXQT. Pressing one brings up a polkit dialog for authorization to run as superuser. Of course, changing the backlight brightness should not require authorization. liblxqt provides an function in which I believe is the problematic code path. This function calls a helper utility as follows: FILE lxqtbacklightbackendgetwritestream() { FILE stream = popen("pkexec lxqt-backlightbackend --stdin", "w"); return stream; } There is a polkit rule for this: $ cat <?xml version="1.0" encoding="UTF-8"?<!DOCTYPE policyconfig PUBLIC "-//freedesktop//DTD PolicyKit Policy Configuration 1.0//EN" ""<policyconfig<action id=""<messageAuthentication is required to Change Brightness</message<iconnamebattery</iconname<defaults<allowanyno</allowany<allowinactiveno</allowinactive<allowactiveyes</allowactive</defaults<annotate key=""${CMAKEINSTALLPREFIX}/bin/lxqt-backlightbackend</annotate</action</policyconfigHowever, this rule ends up expanding to e.g.: <annotate key=""/nix/store/k1w634ib02dxqh046icm2i7ml28iycq5-liblxqt-0.17.0/bin/lxqt-backlightbackend</annotateand polkit is presumably just finding the binary in . It appears that pkexec doesn't resolve symlinks, as if I run on the path, I get the prompt, whereas if I run on the resolved path, I don't get prompted, and I can adjust the brightness from the command line. I'm not sure what the proper solution is here. I don't know enough about polkit to have an opinion on its symlink handling. Maybe we can provide another polkit rule for the path? To Reproduce Steps to reproduce the behavior: LXQT and boot into it. a display brightness key on your keyboard. polkit dialog appear. Expected behavior Display brightness should be adjustable without entering your password. Screenshots If applicable, add screenshots to help explain your problem. Additional context I'm running NixOS 20.09, and have hit this bug both with the shipped LXQT, as well as when I backported 0.17.0 from . Notify maintainers Hi there thanks for providing an update to 0.17 so quickly! Metadata system: host os: multi-user?: sandbox: version: channels(root): channels(khumba): nixpkgs: Maintainer information:

Discussion:
patches = [ ./fix-application-path.patch ]; postPatch = '' <ins> # https://github.com/NixOS/nixpkgs/issues/119766 substituteInPlace lxqtbacklight/linux_backend/driver/libbacklight_backend.c  --replace "pkexec lxqt-backlight_backend" "pkexec $out/bin/lxqt-backlight_backend" </ins> sed -i "s|''${POLKITQT-1_POLICY_FILES_INSTALL_DIR}|''${out}/share/polkit-1/actions|" CMakeLists.txt '';