Change:
Project description It's Shipwright but for Majora's Mask <!-- Describe the project a little: --Metadata homepage URL: source URL: license: cc0, unfree platforms: linux Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
I've got it to build, but the audio is all garbled and it crashes after a few seconds on the main menu. Will check against staging-next as upstream builds their binaries with SDL 2.30.3
For me it works flawlessly. Downloaded the appimage and used appimage-run though
My initial experiences were exactly what both prior comments described. Identical audio glitches and crash when building manually; flawless execution with the prebuilt appimage and appimage-run. Obviously I'd prefer to get the former working as well as the latter, but at least we know it is capable of running at all under the right conditions. We just need to figure out what exactly those conditions are.
It may have something to do with the software they're using. For example they use OpenGL for rendering, so digging into what they use for audio and then tinkering with it might help. I can't remember it off the top of my head, but it's certainly in the context menu if you emulate majora.
Weirdly enough, after installing home-manager with it, the appimage-run method sort of breaks it. It asks for the rom to be put in your home directory but then can't find it. Weird.
Using sudo on appimage-run gave a horrendous audio "host is down" error. I had to close kitty to stop it.
My bad, ALSA gave that error. It can't launch sdl_openaudio.
Doing it without sudo simply crashes it with an error message to send it to the discord.
Moved it back to documents. Cd'd into it. No sudo. Works!!! I was probably being stupid or something lmao
I'm using steam-run instead of appimage-run and it's working great with no obvious issues, but I'm by no means a Zelda expert. !
I've been able to reproduce this crash on Fedora 40. It's a slightly different traceback than building on NixOS, but involves the audio stack. Let's see what upstream thinks.
2ship doesn't segfault when built with :satisfied: Please test
Just built the pull request. Appears to run flawlessly.

Discussion:
githubId = 22085373; name = "Luis Hebendanz"; }; <ins> qubitnano = { name = "qubitnano"; email = "qubitnano@protonmail.com"; github = "qubitnano"; githubId = 146656568; }; </ins> queezle = { email = "git@queezle.net"; github = "queezle42";

<ins> Submodule libultraship contains modified content diff --git a/libultraship/cmake/dependencies/common.cmake b/libultraship/cmake/dependencies/common.cmake index 596158c..c62d7b2 100644 --- a/libultraship/cmake/dependencies/common.cmake +++ b/libultraship/cmake/dependencies/common.cmake @@ -47,10 +47,6 @@ set(stormlib_optimizations_patch git apply ${CMAKE_CURRENT_SOURCE_DIR}/cmake/dep endif() #=================== STB =================== -set(STB_DIR ${CMAKE_BINARY_DIR}/_deps/stb) -file(DOWNLOAD "https://github.com/nothings/stb/raw/0bc88af4de5fb022db643c2d8e549a0927749354/stb_image.h" "${STB_DIR}/stb_image.h") -file(WRITE "${STB_DIR}/stb_impl.c" "#define STB_IMAGE_IMPLEMENTATIONn#include "stb_image.h"") - add_library(stb STATIC) target_sources(stb PRIVATE </ins>

<ins> { stdenv, cmake, lsb-release, ninja, lib, fetchFromGitHub, fetchurl, copyDesktopItems, makeDesktopItem, python3, boost, SDL2, pkg-config, libpulseaudio, libpng, imagemagick, gnome, makeWrapper, imgui, stormlib, libzip, nlohmann_json, tinyxml-2, spdlog, fetchpatch, writeTextFile, }: let # 2ship needs a specific imgui version imgui' = imgui.overrideAttrs rec { version = "1.90.6"; src = fetchFromGitHub { owner = "ocornut"; repo = "imgui"; rev = "v${version}-docking"; hash = "sha256-Y8lZb1cLJF48sbuxQ3vXq6GLru/WThR78pq7LlORIzc="; }; }; # Apply 2ship's patch for stormlib stormlib' = stormlib.overrideAttrs (prev: rec { version = "9.25"; src = fetchFromGitHub { owner = "ladislav-zezula"; repo = "StormLib"; rev = "v${version}"; hash = "sha256-HTi2FKzKCbRaP13XERUmHkJgw8IfKaRJvsK3+YxFFdc="; }; buildInputs = prev.buildInputs ++ [ pkg-config ]; patches = (prev.patches or [ ]) ++ [ (fetchpatch { name = "stormlib-optimizations.patch"; url = "https://github.com/briaguya-ai/StormLib/commit/ff338b230544f8b2bb68d2fbe075175ed2fd758c.patch"; hash = "sha256-Jbnsu5E6PkBifcx/yULMVC//ab7tszYgktS09Azs5+4="; }) ]; }); # This would get fetched at build time otherwise, see: # https://github.com/HarbourMasters/Shipwright/blob/e46c60a7a1396374e23f7a1f7122ddf9efcadff7/soh/CMakeLists.txt#L736 gamecontrollerdb = fetchurl { name = "gamecontrollerdb.txt"; url = "https://raw.githubusercontent.com/gabomdq/SDL_GameControllerDB/30cb02c07001234f021eadf64035ef07753c1263/gamecontrollerdb.txt"; hash = "sha256-Q/OUrvoLY4fF/EJBmQC57y5b3D0Rmlyd9zAmB7U8SUU="; }; thread_pool = fetchFromGitHub { owner = "bshoshany"; repo = "thread-pool"; rev = "v4.1.0"; hash = "sha256-zhRFEmPYNFLqQCfvdAaG5VBNle9Qm8FepIIIrT9sh88="; }; libgfxd = fetchFromGitHub { owner = "glankk"; repo = "libgfxd"; rev = "008f73dca8ebc9151b205959b17773a19c5bd0da"; hash = "sha256-AmHAa3/cQdh7KAMFOtz5TQpcM6FqO9SppmDpKPTjTt8="; }; stb_impl = writeTextFile { name = "stb_impl.c"; text = '' #define STB_IMAGE_IMPLEMENTATION #include "stb_image.h" ''; }; stb' = fetchurl { name = "stb_image.h"; url = "https://raw.githubusercontent.com/nothings/stb/0bc88af4de5fb022db643c2d8e549a0927749354/stb_image.h"; hash = "sha256-xUsVponmofMsdeLsI6+kQuPg436JS3PBl00IZ5sg3Vw="; }; in stdenv.mkDerivation (finalAttrs: { pname = "2ship2harkinian"; version = "1.0.1"; src = fetchFromGitHub { owner = "HarbourMasters"; repo = "2ship2harkinian"; rev = finalAttrs.version; hash = "sha256-czPAmqlXfhOjOYYssDuKt2YDlMlkruNx8EDXo1ksb14="; fetchSubmodules = true; }; nativeBuildInputs = [ cmake ninja pkg-config lsb-release python3 imagemagick copyDesktopItems makeWrapper ]; buildInputs = [ SDL2 libpulseaudio libpng gnome.zenity imgui' stormlib' libzip nlohmann_json tinyxml-2 spdlog ]; cmakeFlags = [ "-DCMAKE_INSTALL_PREFIX=${placeholder "out"}/2s2h" "-DFETCHCONTENT_SOURCE_DIR_IMGUI=${imgui'.src}" "-DFETCHCONTENT_SOURCE_DIR_STORMLIB=${stormlib'}" "-DFETCHCONTENT_SOURCE_DIR_LIBGFXD=${libgfxd}" "-DFETCHCONTENT_SOURCE_DIR_THREADPOOL=${thread_pool}" (lib.cmakeFeature "CMAKE_BUILD_TYPE" "Release") (lib.cmakeBool "NON_PORTABLE" true) ]; dontAddPrefix = true; # Linking fails without this hardeningDisable = [ "format" ]; # Pie needs to be enabled or else it segfaults hardeningEnable = [ "pie" ]; preConfigure = '' # mirror 2ship's stb mkdir stb cp ${stb'} ./stb/${stb'.name} cp ${stb_impl} ./stb/${stb_impl.name} substituteInPlace libultraship/cmake/dependencies/common.cmake  --replace-fail "''${STB_DIR}" "/build/source/stb" ''; patches = [ # remove fetching stb as we will patch our own ./0001-deps.patch ]; postBuild = '' cp ${gamecontrollerdb} ${gamecontrollerdb.name} pushd ../OTRExporter python3 ./extract_assets.py -z ../build/ZAPD/ZAPD.out --norom --xml-root ../mm/assets/xml --custom-assets-path ../mm/assets/custom --custom-otr-file 2ship.o2r --port-ver ${finalAttrs.version} popd ''; preInstall = '' # Cmake likes it here for its install paths cp ../OTRExporter/2ship.o2r mm/ ''; postInstall = '' mkdir -p $out/bin ln -s $out/2s2h/2s2h.elf $out/bin/2s2h install -Dm644 ../mm/linux/2s2hIcon.png $out/share/pixmaps/2s2h.png ''; fixupPhase = '' wrapProgram $out/2s2h/2s2h.elf --prefix PATH ":" ${lib.makeBinPath [ gnome.zenity ]} ''; desktopItems = [ (makeDesktopItem { name = "2s2h"; icon = "2s2h"; exec = "2s2h"; comment = finalAttrs.meta.description; genericName = "2 Ship 2 Harkinian"; desktopName = "2s2h"; categories = [ "Game" ]; }) ]; meta = { homepage = "https://github.com/HarbourMasters/2ship2harkinian"; description = "A PC port of Majora's Mask with modern controls, widescreen, high-resolution, and more"; mainProgram = "2s2h"; platforms = [ "x86_64-linux" ]; maintainers = with lib.maintainers; [ qubitnano ]; license = with lib.licenses; [ # OTRExporter, OTRGui, ZAPDTR, libultraship mit # 2 Ship 2 Harkinian cc0 # Reverse engineering unfree ]; }; }) </ins>