jiebi/CodeConvo huggingface dataset:
Change:
Describe the bug I'd like the function to accept lists and produce duplicate keys, like so: which would yield:
ping to see if he has any interest in implementing this :heart:
Done in :)

Discussion:
* mkKeyValue is the same as in toINI. */ toKeyValue = { <del> mkKeyValue ? mkKeyValueDefault {} "=" }: attrs: let mkLine = k: v: mkKeyValue k v + "n"; in libStr.concatStrings (libAttr.mapAttrsToList mkLine attrs); </del> <ins> mkKeyValue ? mkKeyValueDefault {} "=", listsAsDuplicateKeys ? false }: let mkLine = k: v: mkKeyValue k v + "n"; mkLines = if listsAsDuplicateKeys then k: v: map (mkLine k) (if lib.isList v then v else [v]) else k: v: [ (mkLine k v) ]; in attrs: libStr.concatStrings (lib.concatLists (libAttr.mapAttrsToList mkLines attrs)); </ins> /* Generate an INI-style config file from an

# apply transformations (e.g. escapes) to section names mkSectionName ? (name: libStr.escape [ "[" "]" ] name), # format a setting line from key and value <del> mkKeyValue    ? mkKeyValueDefault {} "=" </del> <ins> mkKeyValue    ? mkKeyValueDefault {} "=", # allow lists as values for duplicate keys listsAsDuplicateKeys ? false </ins> }: attrsOfAttrs: let # map function to string for each key val

(libAttr.mapAttrsToList mapFn attrs); mkSection = sectName: sectValues: '' [${mkSectionName sectName}] <del> '' + toKeyValue { inherit mkKeyValue; } sectValues; </del> <ins> '' + toKeyValue { inherit mkKeyValue listsAsDuplicateKeys; } sectValues; </ins> in # map input to ini sections mapAttrsToStringsSep "n" mkSection attrsOfAttrs;

''; }; <ins> testToINIDuplicateKeys = { expr = generators.toINI { listsAsDuplicateKeys = true; } { foo.bar = true; baz.qux = [ 1 false ]; }; expected = '' [baz] qux=1 qux=false [foo] bar=true ''; }; </ins> testToINIDefaultEscapes = { expr = generators.toINI {} { "no [ and ] allowed unescaped" = {
Change:
Describe the bug Building afl is broken because a dependency (qemu 2.8) can't be built. This seems to be related to an update of glibc. Probably applying the fix here will solve this partially, but I think further investigation is needed. Probably the fix would be somewhere along the lines of: Replace the call with Replace with Replace with To Reproduce Steps to reproduce the behavior: (see below for my current nixpkgs version) that qemu build starts build fails with the errors below. <details<summaryBuild error log</summary</detailsExpected behavior AFL builds correctly. Additional context See also the issue in AFLplusplus: Remove QEMU support is useful as a temporary workaround, but this prevents any users of that part of AFL (blackbox fuzzing) to be able to use the QEMU from nixpkgs. This fix might help solve the missing SIOC* defines: See also the HYDRA build and Metadata system: host os: multi-user?: sandbox: version: channels(rick): channels(root): nixpkgs: Maintainer information:

Discussion:
<ins> --- qemu-2.10.0-clean/linux-user/syscall.c	2020-03-12 18:47:47.898592169 +0100 +++ qemu-2.10.0/linux-user/syscall.c	2020-03-13 09:13:42.461809699 +0100 @@ -34,6 +34,7 @@ #include <sys/resource.h> #include <sys/swap.h> #include <linux/capability.h> +#include <linux/sockios.h> // https://lkml.org/lkml/2019/6/3/988 #include <sched.h> #include <sys/timex.h> #ifdef __ia64__ @@ -256,7 +257,9 @@ static type name (type1 arg1,type2 arg2, #endif #ifdef __NR_gettid -_syscall0(int, gettid) +// taken from https://patchwork.kernel.org/patch/10862231/ +#define __NR_sys_gettid __NR_gettid +_syscall0(int, sys_gettid) #else /* This is a replacement for the host gettid() and must return a host errno. */ @@ -6219,7 +6222,7 @@ static void *clone_func(void *arg) cpu = ENV_GET_CPU(env); thread_cpu = cpu; ts = (TaskState *)cpu->opaque; -    info->tid = gettid(); +    info->tid = sys_gettid(); task_settid(ts); if (info->child_tidptr) put_user_u32(info->tid, info->child_tidptr); @@ -6363,9 +6366,9 @@ static int do_fork(CPUArchState *env, un mapping.  We can't repeat the spinlock hack used above because the child process gets its own copy of the lock.  */ if (flags & CLONE_CHILD_SETTID) -                put_user_u32(gettid(), child_tidptr); +                put_user_u32(sys_gettid(), child_tidptr); if (flags & CLONE_PARENT_SETTID) -                put_user_u32(gettid(), parent_tidptr); +                put_user_u32(sys_gettid(), parent_tidptr); ts = (TaskState *)cpu->opaque; if (flags & CLONE_SETTLS) cpu_set_tls (env, newtls); @@ -11402,7 +11405,7 @@ abi_long do_syscall(void *cpu_env, int n break; #endif case TARGET_NR_gettid: -        ret = get_errno(gettid()); +        ret = get_errno(sys_gettid()); break; #ifdef TARGET_NR_readahead case TARGET_NR_readahead: </ins>

"../${afl.src.name}/qemu_mode/patches/memfd.diff" # nix-specific patches to make installation more well-behaved ./qemu-patches/no-etc-install.patch <ins> # patch for fixing qemu build on glibc >= 2.30 ./qemu-patches/syscall-glibc2_30.diff </ins> ]; configureFlags =
Change:
Describe the bug terraform012 crashes on macos 10.14.6 mojave To Reproduce Steps to reproduce the behavior: terraform012 from (I also built locally on ) : Expected behavior A the version number should be printed. Additional context terraform011 does not crash. I was able to work around the problem by building building terraform012 using go 1.12 (this patch against nixpkgs): Metadata Please run and paste the result. Maintainer information:
upstream issue would you mind creating a PR with your patch but with ?
Looks like you beat me to it, thank you.

Discussion:
buildGoModule = buildGo112Module; }; <del> inherit (callPackage ../applications/networking/cluster/terraform {}) </del> <ins> inherit (callPackage ../applications/networking/cluster/terraform { # terraform 0.12 crashes with go1.14 on darwin https://github.com/hashicorp/terraform/issues/24287 buildGoPackage = if stdenv.isDarwin then buildGo113Package else buildGoPackage; }) </ins> terraform_0_11 terraform_0_11-full terraform_0_12
Change:
Describe the bug The default applications menu of Xfce and Mate desktop environments use to present preferences items and a control center (or similar) item for system configuration. Those items stopped appearing in the menu. Screenshots Screenshots taken for Xfce and Mate running in a local virtual machine: ! ! Metadata system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
With the following changes in the services they work again: cc
Likely caused by
PR fixes this issue for Mate. Can it be merged? cc
I guess we have too.
Does need backport is the question.
I think so.
Would a similar solution (use upstream session) work for XFCE?
I had to revert it actually, because people can't combine wm and desktop manager :frowning:
The environment variable can be set to explicitly in the xfce desktop module. At least until a more well structured solution comes up.
That can do it, it would have to be in .
This issue has been mentioned on NixOS Discourse. There might be relevant details there:

Discussion:
services.xserver.desktopManager.session = [{ name = "xfce"; <ins> desktopNames = [ "XFCE" ]; </ins> bgSupport = true; start = '' ${pkgs.runtimeShell} ${pkgs.xfce.xfce4-session.xinitrc} &

(dm: wm: let sessionName = "${dm.name}${optionalString (wm.name != "none") ("+" + wm.name)}"; script = xsession dm wm; <ins> desktopNames = if dm ? desktopNames then concatStringsSep ";" dm.desktopNames else sessionName; </ins> in optional (dm.name != "none" || wm.name != "none") (pkgs.writeTextFile {

TryExec=${script} Exec=${script} Name=${sessionName} <del> DesktopNames=${sessionName} </del> <ins> DesktopNames=${desktopNames} </ins> ''; } // { providedSessions = [ sessionName ];
Change:
Describe the bug Tor Browser doesn't show the thumbnail icons for search engines. To Reproduce Steps to reproduce the behavior: the search bar in Tor Browser. something. Expected behavior The icons should appear as they do in Firefox on NixOS, and on Tor Browser on other platforms. Screenshots ! Additional context Add any other context about the problem here. Metadata Please run and paste the result. system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
This worked in 9.0.5 but has stopped working since. In 9.0.9 there are no search engine thumbnails. Please reopen.
if this was originally fixed by , a new bug should be opened - the issue is likely a different one this time.

Discussion:
, apulse # Media support (implies audio support) <del> , mediaSupport ? false </del> <ins> , mediaSupport ? true </ins> , ffmpeg , gmp
Change:
Describe the bug Tor Browser does not correctly display audio/video streams, and instead tries to download it. To Reproduce Steps to reproduce the behavior: Tor Browser. an audio or video stream such as or Expected behavior The stream should play correctly as it does on Tails. Metadata Please run and paste the result. system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
I just noticed that there is a parameter which is set to false by default. I guess this bug is actually intentional then.
By using I figured that you can manually override the package like this: The Tor Browser appears to work fine with this adjustment, and it's still relatively safe because NoScript blocks multimedia by default as well. So I suggest that be changed to by default.

Discussion:
, apulse # Media support (implies audio support) <del> , mediaSupport ? false </del> <ins> , mediaSupport ? true </ins> , ffmpeg , gmp
Change:
Describe the bug The  package fails to build on both , and . Hydra: To Reproduce Metadata Please run and paste the result. Maintainer information: CC
It seems that these derivations are on the nix cache so it used to build at some point in the past.
I marked this as stale due to inactivity. &rarr;

Discussion:
appleDerivation { # We can't just run the root build, because https://github.com/facebook/xcbuild/issues/264 <ins> patchPhase = '' substituteInPlace adv_cmds.xcodeproj/project.pbxproj  --replace '/usr/lib/libtermcap.dylib' 'libncurses.dylib' ''; </ins> # pkill requires special private headers that are unavailable in # NixPkgs. These ones are needed: #  - xpc/xpxc.h #  - os/base_private.h #  - _simple.h # We disable it here for now. TODO: build pkill inside adv_cmds <del> # We also disable locale here because of some issues with a missing # "lstdc++". patchPhase = '' substituteInPlace adv_cmds.xcodeproj/project.pbxproj  --replace "FD201DC214369B4200906237 /* pkill.c in Sources */," ""  --replace "FDF278D60FC6204E00D7A3C6 /* locale.cc in Sources */," ""  --replace '/usr/lib/libtermcap.dylib' 'libncurses.dylib' ''; </del> buildPhase = '' targets=$(xcodebuild -list  | awk '/Targets:/{p=1;print;next} p&&/^s*$/{p=0};p'  | tail -n +2 | sed 's/^[ t]*//'  <del> | grep -v -e Desktop -e Embedded -e mklocale -e colldef) </del> <ins> | grep -v -e Desktop -e Embedded -e mklocale -e pkill -e pgrep -e colldef) </ins> for i in $targets; do xcodebuild SYMROOT=$PWD/Products OBJROOT=$PWD/Intermediates -target $i

installPhase = '' for f in Products/Release/*; do if [ -f $f ]; then <del> install -D $file $out/bin/$(basename $f) </del> <ins> install -D $f $out/bin/$(basename $f) </ins> fi done
Change:
Describe the bug Besides the included themes, Kvantum manager is does not allow the user to select other themes installed from packages like or . To Reproduce Steps to reproduce the behavior: Kvantum manager and try to select Arc theme Expected behavior Being able to select an installed theme. Screenshots As you can see the themes Adapta and AdaptaNokto do not appear in the drop down menu, even though they are installed in the correct folder. ! Metadata Please run and paste the result. Maintainer information:
Hello, I'm a bot and I thank you in the name of the community for opening this issue. To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use or on the relevant files to find them. Lastly, you can always ask for help at or at .
still important to me
I marked this as stale due to inactivity. &rarr;
Here is a patch that adds XDGDATADIRS support for theme lookup paths: Would be nice to submit a PR upstream, but if you take a look at the code: it's just impenetrable. If time allows, I'll try to submit a PR making the code more maintainable and the submit this patch (if the author agrees).

Discussion:
<del> { lib, stdenv, fetchFromGitHub, qmake, qtbase, qtsvg, qtx11extras, kwindowsystem </del> <ins> { lib, stdenv, fetchFromGitHub, fetchpatch, qmake, qtbase, qtsvg, qtx11extras, kwindowsystem </ins> , libX11, libXext, qttools, wrapQtAppsHook , gitUpdater }:

sourceRoot = "source/Kvantum"; <ins> patches = [ (fetchpatch { # add xdg dirs support url = "https://github.com/tsujan/Kvantum/commit/01989083f9ee75a013c2654e760efd0a1dea4a68.patch"; hash = "sha256-HPx+p4Iek/Me78olty1fA0dUNceK7bwOlTYIcQu8ycc="; stripLen = 1; }) ]; </ins> postPatch = '' # Fix plugin dir substituteInPlace style/style.pro
Change:
Describe the bug I am trying to get binutils to support all targets by overriding the withAllTargets argument. But I get the following error message: To Reproduce Steps to reproduce the behavior: nix-shell Expected behavior A shell environment containing binutils with all targets enabled. Additional context The higher-level goal is to obtain a version of that supports and targets. I need to copy a 32-bit PE object file to a 64-bit one. If there is a better way to accomplish this goal, I'd appreciate guidance. Metadata Please run and paste the result. Maintainer information:
Setting as well seems to be working fine. Is this expected? Then maybe the error message should somehow reflect that, if possible.
/cc
Hello, I'm a bot and I thank you in the name of the community for opening this issue. To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use or on the relevant files to find them. Lastly, you can always ask for help at or at .
Maybe i am completely wrong about this, but I think since this works with the issue most likely comes from .
I marked this as stale due to inactivity. &rarr;
I'm experiencing the same issue with .
Still a problem. I think the trigger is the use of in , but I don't understand why it matter for override. CLI reproducer:
Proposed the fix (and a new explicit attribute) as

Discussion:
# FHS sys dirs presumably only have stuff for the build platform noSysDirs = (stdenv.targetPlatform != stdenv.hostPlatform) || noSysDirs; }; <ins> binutils-unwrapped-all-targets = callPackage ../development/tools/misc/binutils { autoreconfHook = if targetPlatform.isiOS then autoreconfHook269 else autoreconfHook; # FHS sys dirs presumably only have stuff for the build platform noSysDirs = (stdenv.targetPlatform != stdenv.hostPlatform) || noSysDirs; withAllTargets = true; }; </ins> binutils = wrapBintoolsWith { bintools = binutils-unwrapped; };
Change:
Describe the bug While building ant-theme 3.0 with latest master the following error occurs: To Reproduce Steps to reproduce the behavior: ant-theme Expected behavior builds Screenshots If applicable, add screenshots to help explain your problem. Additional context Add any other context about the problem here. Metadata system: host os: multi-user?: sandbox: version: channels(maciej): channels(root): nixpkgs: Maintainer information:
This issue has been mentioned on NixOS Discourse. There might be relevant details there:

Discussion:
runHook postInstall ''; <del> outputHashAlgo = "sha256"; outputHashMode = "recursive"; outputHash = "0v5pdhysa2460sh400cpq11smcfsi9g1lbfzx8nj1w5a21d811cz"; </del> meta = with stdenv.lib; { description = "Bloody variant of the Ant theme"; homepage = "https://github.com/EliverLara/${themeName}";

runHook postInstall ''; <del> outputHashAlgo = "sha256"; outputHashMode = "recursive"; outputHash = "1a9mkxfb0zixx8s05h15lhnnzygh2qzc8k2q10i0khx90bf72x14"; </del> meta = with stdenv.lib; { description = "Dracula variant of the Ant theme"; homepage = "https://github.com/EliverLara/${themeName}";

runHook postInstall ''; <del> outputHashAlgo = "sha256"; outputHashMode = "recursive"; outputHash = "1lmlc4fvjnp05gshc0arfysh8r1xxzpzdv3j0bk40mjf3d59814c"; </del> meta = with stdenv.lib; { description = "Nebula variant of the Ant theme"; homepage = "https://github.com/EliverLara/${themeName}";

gtk-engine-murrine ]; <del> dontBuild = true; </del> installPhase = '' runHook preInstall mkdir -p $out/share/themes/${themeName}

runHook postInstall ''; <del> outputHashAlgo = "sha256"; outputHashMode = "recursive"; outputHash = "07iv4jangqnzrvjr749vl3x31z7dxds51bq1bhz5acbjbwf25wjf"; </del> meta = with stdenv.lib; { description = "A flat and light theme with a modern look"; homepage = "https://github.com/EliverLara/${themeName}";
Change:
Describe the bug When renaming a submodule, the makes the child options reappear in the docs at the old location. This did not happen before (ping I've encountered the problem in the arion docs when its tooling to nixpkgs 20.03. The move is -. The regression makes the docs start with a mountain of legacy options comprising just under half of all options. Reverting fixes the problem. To Reproduce Steps to reproduce the behavior: an option to is in the docs, despite Expected behavior The option docs should have at most one entry per renamed option. Any suboptions should be omitted. Screenshots If applicable, add screenshots to help explain your problem. Additional context Add any other context about the problem here. Metadata Please run and paste the result. Maintainer information:

Discussion:
let ss = opt.type.getSubOptions opt.loc; in if ss != {} then optionAttrSetToDocList' opt.loc ss else []; in <del> [ docOption ] ++ subOptions) (collect isOption options); </del> <ins> [ docOption ] ++ optionals docOption.visible subOptions) (collect isOption options); </ins> /* This function recursively removes all derivation attributes from
Change:
Describe the bug A behaviour I'm observing on my Nix machines is that dvipng takes a long time to render the image from , about 9 times slower than imagemagick. To Reproduce the packages: a test latex file: the file: the benchmarks: Expected behavior Expect to be as performant as . Additional context This behaviour is observed because in previewing Emacs latex fragments, is the default command used, and I've noticed this to be significantly slower than on other distros. Additional Information Not sure if this is related, but I'm seeing: perhaps dvipng is performing some extra work, making it slow. Any way to make this go away? Metadata system: host os: multi-user?: sandbox: version: channels(jethro): nixpkgs:
I can reproduce this: Do you think you could bring this up with the upstream?
glad to see I'm not the only one, had run a similar benchmark though and he can't reproduce this, so I'm unsure if it's an upstream issue.
Maybe you could run dvipng under "strace -rf" to see if any specific filesystem activity eats up the time?
I'm not too familiar on how to read , but here's the summary:
I think the cited invocation produces a lower-resolution image. The timestamps in the strace output seem to be too low for a 1-second process. Interesting…
This is a result on RHEL7-like system:
From eyeballing the stdout of the command, it seems a lot of time is spent on : I'm not sure how to proceed further with the diagnosis.

Discussion:
rm "$link" makeWrapper "$target" "$link"  --prefix PATH : "$out/bin:${perl}/bin"  <del> --prefix PERL5LIB : "$PERL5LIB" </del> <ins> --prefix PERL5LIB : "$PERL5LIB"  --set-default TEXMFCNF "$TEXMFCNF" </ins> # avoid using non-nix shebang in $target by calling interpreter if [[ "$(head -c 2 "$target")" = "#!" ]]; then
Change:
Describe the bug trying to launch (a Play Station 3 emulator) in a terminal tells you To Reproduce Steps to reproduce the behavior: Expected behavior I expect the emulator to start and show the window Metadata Maintainer information:
cc

Discussion:
<del> { stdenv, lib, fetchgit, cmake, pkgconfig, git , qt5, openal, glew, vulkan-loader, libpng, ffmpeg, libevdev, python27 </del> <ins> { mkDerivation, lib, fetchgit, cmake, pkgconfig, git , qtbase, qtquickcontrols, openal, glew, vulkan-loader, libpng, ffmpeg, libevdev, python3 </ins> , pulseaudioSupport ? true, libpulseaudio , waylandSupport ? true, wayland , alsaSupport ? true, alsaLib }: let <del> majorVersion = "0.0.6"; gitVersion = "8187-790962425"; # echo $(git rev-list HEAD --count)-$(git rev-parse --short HEAD) </del> <ins> majorVersion = "0.0.8"; gitVersion = "9300-341fdf7eb"; # echo $(git rev-list HEAD --count)-$(git rev-parse --short HEAD) </ins> in <del> stdenv.mkDerivation { </del> <ins> mkDerivation { </ins> pname = "rpcs3"; version = "${majorVersion}-${gitVersion}"; src = fetchgit { url = "https://github.com/RPCS3/rpcs3"; <del> rev = "790962425cfb893529f72b3ef0dd1424fcc42973"; sha256 = "154ys29b9xdws3bp4b7rb3kc0h9hd49g2yf3z9268cdq8aclahaa"; </del> <ins> rev = "341fdf7eb14763fd06e2eab9a4b2b8f1adf9fdbd"; sha256 = "1qx97zkkjl6bmv5rhfyjqynbz0v8h40b2wxqnl59g287wj0yk3y1"; </ins> }; preConfigure = ''

nativeBuildInputs = [ cmake pkgconfig git ]; buildInputs = [ <del> qt5.qtbase qt5.qtquickcontrols openal glew vulkan-loader libpng ffmpeg libevdev python27 </del> <ins> qtbase qtquickcontrols openal glew vulkan-loader libpng ffmpeg libevdev python3 </ins> ] ++ lib.optional pulseaudioSupport libpulseaudio ++ lib.optional alsaSupport alsaLib ++ lib.optional waylandSupport wayland; enableParallelBuilding = true; <del> meta = with stdenv.lib; { </del> <ins> meta = with lib; { </ins> description = "PS3 emulator/debugger"; homepage = "https://rpcs3.net/"; maintainers = with maintainers; [ abbradar nocent ];
Change:
The failure is limited to Python 3.8. Update in does not help.
This issue has been mentioned on NixOS Discourse. There might be relevant details there:
Possibly, we need to cherry-pick

Discussion:
url = "https://github.com/GStreamer/gst-python/commit/f98c206bdf01529f8ea395a719b10baf2bdf717f.patch"; sha256 = "04n4zrnfivgr7iaqw4sjlbd882s8halc2bbbhfxqf0sg2lqwmrxg"; }) <ins> ] ++ [ # Fix linking against Python 3.8 # https://gitlab.freedesktop.org/gstreamer/gst-python/merge_requests/30 (fetchpatch { url = "https://gitlab.freedesktop.org/gstreamer/gst-python/commit/22f28155d86e27c4134de4ed2861264003fcfd23.patch"; sha256 = "Y70qVguHUBmmRVMFBKAP0d6anBQw5W0TKyu2bAwxbQg="; }) </ins> ]; mesonFlags = [