jiebi/CodeConvo huggingface dataset:
Change:
According to , Django 2.0 will reach EOL in April 2019, i.e. just after the release of 19.03. Better not include it in the first place. cc
agreed. For 19.03 we will only support 1.11 and 2.1 (and probably port 2.2 when it gets available).

Discussion:
<del> { stdenv, buildPythonPackage, fetchPypi, substituteAll, isPy3k, geos, gdal, pytz, withGdal ? false }: buildPythonPackage rec { pname = "Django"; version = "2.0.10"; disabled = !isPy3k; src = fetchPypi { inherit pname version; sha256 = "0292a7ad7d8ffc9cfc6a77f043d2e81f5bbc360c0c4a1686e130ef3432437d23"; }; patches = stdenv.lib.optionals withGdal [ (substituteAll { src = ./1.10-gis-libs.template.patch; geos = geos; gdal = gdal; extension = stdenv.hostPlatform.extensions.sharedLibrary; }) ]; # patch only $out/bin to avoid problems with starter templates (see #3134) postFixup = '' wrapPythonProgramsIn $out/bin "$out $pythonPath" ''; propagatedBuildInputs = [ pytz ]; # too complicated to setup doCheck = false; meta = with stdenv.lib; { description = "A high-level Python Web framework"; homepage = https://www.djangoproject.com/; license = licenses.bsd3; maintainers = with maintainers; [ georgewhewell ]; }; } </del>

gdal = self.gdal; }; <del> django_2_0 = callPackage ../development/python-modules/django/2_0.nix { gdal = self.gdal; }; </del> django_2_1 = callPackage ../development/python-modules/django/2_1.nix { gdal = self.gdal; };
Change:
with new versions of deps - build is broken. Example of error instance: Full log: This creates a blocker for contributors to the manual. To contribute to NixPkgs manual, it is required to build the manual () before creating a pull request. I want to contribute some section. By the process - I need to pass a successful build. The manual on the master branch is currently broken, building it on my setup. Errors ask me to make changes, which doc maintainers probably know what to do about. system: host os: multi-user?: sandbox: version: channels(root): channels(pyro): nixpkgs:
Maybe this is due to manual being built on the current stable branch?
Even on the job builds and most likely will build for you as well but I confirm that in indeed is broken.
BTW, I believe this earlier message is closer to the root of the problem:
Yes, this was to in but the was forgotten. cc
Gonna take a look at this. Edit: PR to fix it is up at
if you are still having issues on master (or a revision where is merged) make sure you before using , and otherwise, re-open with more details.

Discussion:
.PHONY: clean clean: <del> rm -f ${MD_TARGETS} .version manual-full.xml functions/library/locations.xml </del> <ins> rm -f ${MD_TARGETS} .version manual-full.xml functions/library/locations.xml functions/library/generated </ins> rm -rf ./out/ ./highlightjs .PHONY: validate

cp -r "$$HIGHLIGHTJS/loader.js" highlightjs/ <del> manual-full.xml: ${MD_TARGETS} .version functions/library/locations.xml *.xml **/*.xml **/**/*.xml </del> <ins> manual-full.xml: ${MD_TARGETS} .version functions/library/locations.xml functions/library/generated *.xml **/*.xml **/**/*.xml </ins> xmllint --nonet --xinclude --noxincludenode manual.xml --output manual-full.xml .version: nix-instantiate --eval  -E '(import ../lib).version' > .version <ins> function_locations := $(shell nix-build --no-out-link ./lib-function-locations.nix) </ins> functions/library/locations.xml: <del> nix-build ./lib-function-locations.nix  --out-link ./functions/library/locations.xml </del> <ins> ln -s $(function_locations) ./functions/library/locations.xml functions/library/generated: nix-build ./lib-function-docs.nix  --arg locationsXml $(function_locations) --out-link ./functions/library/generated </ins> %.section.xml: %.section.md pandoc $^ -w docbook+smart
Change:
Running the idris-glfw example at fails on nix. nix-shell -p ' (with idrisPackages; [ contrib glfw ])' -p gmp -p glfw Followed by trying to build the example at
cc

Discussion:
idrisDeps = [ effects ]; <ins> nativeBuildInputs = [ pkgs.pkgconfig ]; </ins> extraBuildInputs = [ pkgs.glfw ]; <ins> postPatch = '' substituteInPlace src/MakefileGlfw  --replace glfw3 "glfw3 gl" ''; </ins> src = fetchFromGitHub { owner = "eckart"; repo = "glfw-idris";
Change:
This bug is specific to NixOS and concerns all versions of . The error also appears with (). Running gives more details (). This bug doesn't appear on other Linux distros that provide ImageMagick distributions, like Alpine or Arch (). Use instead of while ghostscript is in . This way, the binary is used instead of the broken . GDB reveals a segfault triggered by , via : The reason for the exception shown in is that tries to delete a temp file which has been previously deleted by an exception handler triggered by the segfault. Running the above script with older versions yields: : Works without errors : SIGSEGV in strlensse2 (libc), via liblcms2 or alternatively: SIGSEV in pthreadmutexdestroy (libpthread), via liblcms2, : SIGSEGV in memmovessse3 (libc), via liblcms2, (as demonstrated above): SIGSEGV in memmovessse3 or memmoveavxunalignederms (libc), via liblcms2, cc:
broke building zbar and thus electrum on my system. I don't think this issue really warranted breaking the build of dependencies just because an optional feature doesn't work... So I started looking into the root cause of this. My understanding is that ghostscript has its own fork of lcms2 inside its codebase ("lcms2mt" directory). We build against it, as shown by build flags at compile time: . But then at runtime libgs ends up using from the lcms2 derivation instead. This is bound to cause ABI problems which could manifest in SEGV. The easiest fix is probably to do like Arch is currently doing: using systemwide lcms2 and removing Ghostscript's fork. I'll give it a shot.

Discussion:
description = "A software suite to create, edit, compose, or convert bitmap images"; platforms = platforms.linux ++ platforms.darwin; license = licenses.asl20; <del> broken = ghostscript != null; # https://github.com/NixOS/nixpkgs/issues/55118 </del> maintainers = with maintainers; [ the-kenny ]; }; }
Change:
The request is to change into in This is needed for python environments that contain .pth files. These .pth files will only be picked up if the python environment that is used for the uwsgi vassal is set as a python home. Please run and paste the results. /nix/store/ial8a56ys2rswfq4j2abm3cl99li5b6p-bash-interactive-4.4-p23-dev copying path '/nix/store/ial8a56ys2rswfq4j2abm3cl99li5b6p-bash-interactive-4.4-p23-dev' from ''... system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:
Any chance for this to be included in 19.09?

Discussion:
inherit plugins; } // removeAttrs c [ "type" "pythonPackages" ] // optionalAttrs (python != null) { <del> pythonpath = "${pythonEnv}/${python.sitePackages}"; </del> <ins> pyhome = "${pythonEnv}"; </ins> env = # Argh, uwsgi expects list of key-values there instead of a dictionary. let env' = c.env or [];
Change:
opens most of the ports required for the Unifi controller, except it's missing port 6789, which is used for the UniFi mobile speed test. /cc
Hey I took the maintainership for only recently, so could you elaborate on what the UniFi mobile speed test is? I can't find good info about that on UBNT's support site. includes only the minimum required ports. Depending on wether 6789 is strictly required for operation, I'd add it or if not, it could be mentioned in the of , as 8443 is.
The UniFi iOS app has 2 features that rely on this port. The first is the WiFi Throughput test and the second is the Heatmap overlay. IMO all L3 ports should be opened except for 8443, and the only reason to exclude 8443 by default is because the operator may wish to configure a server on port 443 to proxy the unifi controller (which is exactly what I’m doing, using ), which would make port 8443 redundant. But the other ports (including 6789) don’t have the potential for being proxied like the web GUI does.
Thanks for elaborating, I think that makes sense. Would you mind to provide a PR to add 6789 to the open ports? If yes I can do it as well.
PR submitted as . Untested, but this change is pretty safe.

Discussion:
}; networking.firewall = mkIf cfg.openPorts { <del> # https://help.ubnt.com/hc/en-us/articles/204910084-UniFi-Change-Default-Ports-for-Controller-and-UAPs </del> <ins> # https://help.ubnt.com/hc/en-us/articles/218506997 </ins> allowedTCPPorts = [ 8080  # Port for UAP to inform controller. 8880  # Port for HTTP portal redirect, if guest portal is enabled. 8843  # Port for HTTPS portal redirect, ditto. <ins> 6789  # Port for UniFi mobile speed test. </ins> ]; allowedUDPPorts = [ 3478  # UDP port used for STUN.
Change:
, (nixos-18.09, nixos-unstable) Scanned versions: nixos-18.09: ; nixos-unstable: . May contain false positives.

Discussion:
}; patches = [ <ins> # CVE-2019-6133 - See: https://bugs.chromium.org/p/project-zero/issues/detail?id=1692 (fetchpatch { url = "https://gitlab.freedesktop.org/polkit/polkit/commit/6cc6aafee135ba44ea748250d7d29b562ca190e3.patch"; name = "CVE-2019-6133.patch"; sha256 = "0jjlbjzqcz96xh6w3nv3ss9jl0hhrcd7jg4aa5advf08ibaj29r1"; }) </ins> # CVE-2018-19788 - high UID fixup (fetchpatch { url = "https://gitlab.freedesktop.org/polkit/polkit/commit/5230646dc6876ef6e27f57926b1bad348f636147.patch";
Change:
Installation of fails using the current channel or the branch of (18.09-beta--g70765af1a69). The relevant part of the error message is: This error can be fixed by adding to : I can create a pull request for that. But I think there is something interesting going on here: From my quick inspection of the source code it looks like itself does not need . But as part of the installation it tries to load (which it also installs as a dependency). And does need but is already in . So I wonder why is not available for when it is loaded through ? Understanding this problem might help to come up with a more clever way to fix it than adding as a buildInput for (and possibly other packages that depend on ). system: host os: multi-user?: sandbox: version: channels(root): channels(user): nixpkgs:

Discussion:
pbdPROF = [ pkgs.openmpi ]; pbdZMQ = lib.optionals stdenv.isDarwin [ pkgs.which ]; pdftools = [ pkgs.poppler.dev ]; <ins> phytools = [ pkgs.which ]; </ins> PKI = [ pkgs.openssl.dev ]; png = [ pkgs.libpng.dev ]; PopGenome = [ pkgs.zlib.dev ];
Change:
We currently use a pinned commit of MultiMC for Qt 5.11 compatibility (see and MultiMC/MultiMC5). This is probably not the best option. The three options as I see them are: Wait for a stable release with Qt 5.11 compatibility. See MultiMC/MultiMC5. Follow the MultiMC branch. I believe, but am not sure, that this is the branch in the MultiMC auto-updater. Backport ourselves. It is unclear whether the MultiMC license allows this, as it requires forks to have unrelated names. N/A Please run and paste the results. (probably N/A, but better safe than sorry)

Discussion:
libpath = with xorg; stdenv.lib.makeLibraryPath [ libX11 libXext libXcursor libXrandr libXxf86vm libpulseaudio ]; in stdenv.mkDerivation rec { name = "multimc-${version}"; <del> # Current release as of 2018-06-23 (v0.6.2) breaks under Qt 5.11—see # https://github.com/NixOS/nixpkgs/issues/42387 version = "unstable-2018-06-04"; </del> <ins> version = "0.6.4"; </ins> src = fetchFromGitHub { owner = "MultiMC"; repo = "MultiMC5"; <del> rev = "19bb50b872da2702b8e0b65f3f7b6b54c1c5b071"; sha256 = "01frkk2klm1axr7ywnj23ikxn5pkgj8q6w8vqbslsvmh8bni8rk0"; </del> <ins> rev = "0.6.4"; sha256 = "0z9mhvfsq9m2cmi0dbrjjc51642r6ppdbb8932236gar5j7w3bc2"; </ins> fetchSubmodules = true; }; nativeBuildInputs = [ cmake file makeWrapper ];
Change:
The hash for in pkgs/applications/science/math/sage/sage- appears to have changed. (I believe would also fix this.) nix-build -A sage system: host os: multi-user?: sandbox: (really no) version:
It does build and work fine with the updated hash.
cc
That is surprising for multiple reasons I did specify the exact hash. Isn't s stable? Don't we mirror fixed-output derivations? For reference (haven't looked into the differences yet), is the old patch file from my nix store and is the new one.
Looks like this is because I changed to use s instead of . No idea what I was thinking to do that without re-checking the hashes.
Those seem to be the same link. I believe the file it's actually grabbing is This still appears to have some real (but probably unimportant) differences: I also saw that the new file is incorrectly and randomly truncated, which seems to be some kind of caching problem with their server -- subtly altering the request temporarily fixes it, and I believe the hash is for the untruncated file.
Yes, I think the truncation is because they an outdated cgit and is broken. The other difference is because of the changed . Should be fixed in . Thanks for the report.

Discussion:
fetchSageDiff = { base, rev, name ? "sage-diff-${base}-${rev}.patch", ...}@args: ( fetchpatch ({ inherit name; <del> url = "https://git.sagemath.org/sage.git/rawdiff?id2=${base}&id=${rev}"; </del> <ins> url = "https://git.sagemath.org/sage.git/patch?id2=${base}&id=${rev}"; </ins> # We don't care about sage's own build system (which builds all its dependencies). # Exclude build system changes to avoid conflicts. <del> excludes = [ "/build/*" ]; </del> <ins> excludes = [ "build/*" ]; </ins> } // builtins.removeAttrs args [ "rev" "base" ]) ); in [
Change:
installed with Error at runtime:
It's a matter of adding the missing librar(y|ies) to . Do you want to try a PR?
Yes! I know how to do git fork/PR, but I don't know the process/syntax for including a missing library. Would you be able to teach me over a chat channel? I can sign up for a chat forum/slack/mattermost/Zulip/IRC. Btw Zulip is the best.
Due to the time difference, it might be a bit difficult to find a time where we are both online but it basically boils down to: the relevant missing libraries (ldd on the binary is the easiest to get an overview) the corresponding derivation name in nixpkgs (in case of libxdamage it's ) that to the list and see if it runs. If not, rinse and repeat until it does.

Discussion:
{ stdenv, fetchurl, gtk2, glib, gdk_pixbuf, alsaLib, nss, nspr, gconf <del> , cups, libgcrypt_1_5, systemd, dbus }: </del> <ins> , cups, libgcrypt_1_5, systemd, dbus, libXdamage, expat }: </ins> with stdenv.lib; let bracketsLibs = makeLibraryPath [ <del> gtk2 glib gdk_pixbuf stdenv.cc.cc.lib alsaLib nss nspr gconf cups libgcrypt_1_5 dbus systemd </del> <ins> gtk2 glib gdk_pixbuf stdenv.cc.cc.lib alsaLib nss nspr gconf cups libgcrypt_1_5 dbus systemd libXdamage expat </ins> ]; in stdenv.mkDerivation rec {
Change:
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly: for maintainers and people that previously touched the related code and @ mention them in a comment. on the . on the on .

Discussion:
inherit version; src = fetchurl { <del> url = "http://a1227.g.akamai.net/f/1227/40484/7d/download.ebz.epson.net/dsc/f/01/00/01/58/65/cd71929d2bf41ebf7e96f68fa9f1279556545ef1/Epson-ALC1100-filter-1.2.tar.gz"; sha256 = "0q0bf4dfm4v69l7xg6sgkh7rwb0h77i8j9kplq1dfkd208g7y81p"; </del> <ins> url = "https://download3.ebz.epson.net/dsc/f/03/00/11/33/07/4027e99517b5c388d444b8444d719b4b77f7e9db/Epson-ALC1100-filter-1.2.tar.gz"; sha256 = "1dfw75a3kj2aa4iicvlk9kz3jarrsikpnpd4cdpw79scfc5mwm2p"; </ins> }; patches = [ ./cups-data-dir.patch ./ppd.patch ];
Change:
networking.firewall.allowedTCPPorts = [ 443 443 ]; Seems to generate two identical iptables rules instead of just one. This kind of configuration can easily happen when multiple independent modules append the same port to the list. IMO it would be worth de-duplicating ports (and maybe sorting?) so that the generated firewall configuration is easier to read. system: host os: multi-user?: sandbox: version: channels(delroth): nixpkgs:
Great idea - want to take a stab at a PR?

Discussion:
fi ''; <ins> canonicalizePortList = ports: lib.unique (builtins.sort builtins.lessThan ports); </ins> commonOptions = { allowedTCPPorts = mkOption { <del> type = types.listOf types.int; </del> <ins> type = types.listOf types.port; </ins> default = [ ]; <ins> apply = canonicalizePortList; </ins> example = [ 22 80 ]; description = ''

}; allowedTCPPortRanges = mkOption { <del> type = types.listOf (types.attrsOf types.int); </del> <ins> type = types.listOf (types.attrsOf types.port); </ins> default = [ ]; example = [ { from = 8999; to = 9003; } ]; description =

}; allowedUDPPorts = mkOption { <del> type = types.listOf types.int; </del> <ins> type = types.listOf types.port; </ins> default = [ ]; <ins> apply = canonicalizePortList; </ins> example = [ 53 ]; description = ''

}; allowedUDPPortRanges = mkOption { <del> type = types.listOf (types.attrsOf types.int); </del> <ins> type = types.listOf (types.attrsOf types.port); </ins> default = [ ]; example = [ { from = 60000; to = 61000; } ]; description =
Change:
connman built with iwd: But module contains assertion that returns error when wpasupplicant is disabled (enabling iwd disables wpasupplicant):
In , the only supported way to use is to use it as a standalone wireless daemon. Even if you assertion was disabled, it wouldn't make a difference, since the configurations don't allow for to connect to . The default is setup for which differs from the one that is required [1]. Though it does look like it's relatively easy to enable integration with the addition of two services, for now it might be better to just override the module manually on your local configuration. [1]
If someone ends up putting together the needed bits, please share (probably as a PR)! Ive kludged network-manager into using iwd (kludge is needed for similar assertion and to not run iwd standalone, IIRC) but I'm keen to give connman a try :).
FYI guys, ConnMan doesn't really keep up to date with iwd and integration between the two might lead to frustration. See and The best bet for now is to use network manager with iwd ()
NetworkManager is ugly and buggy
I've been also using iwd without network manager or connman just fine.
I'm thinking of writing a GUI for iwd - to use iwd + dhcpcd
Heads up for anyone interested iwd 1.0 was released with breaking changes, refs:

Discussion:
${cfg.extraConfig} ''; <ins> enableIwd = cfg.wifi.backend == "iwd"; </ins> in { imports = [

''; }; <ins> wifi = { backend = mkOption { type = types.enum [ "wpa_supplicant" "iwd" ]; default = "wpa_supplicant"; description = '' Specify the Wi-Fi backend used. Currently supported are <option>wpa_supplicant</option> or <option>iwd</option>. ''; }; }; </ins> extraFlags = mkOption { type = with types; listOf str; default = [ ];

assertion = !config.networking.useDHCP; message = "You can not use services.connman with networking.useDHCP"; }{ <del> assertion = config.networking.wireless.enable; message = "You must use services.connman with networking.wireless"; }{ </del> assertion = !config.networking.networkmanager.enable; message = "You can not use services.connman with networking.networkmanager"; }];

systemd.services.connman = { description = "Connection service"; wantedBy = [ "multi-user.target" ]; <del> after = [ "syslog.target" ]; </del> <ins> after = [ "syslog.target" ] ++ optional enableIwd "iwd.service"; requires = optional enableIwd "iwd.service"; </ins> serviceConfig = { Type = "dbus"; BusName = "net.connman"; Restart = "on-failure"; <del> ExecStart = "${pkgs.connman}/sbin/connmand --config=${configFile} --nodaemon ${toString cfg.extraFlags}"; </del> <ins> ExecStart = toString ([ "${pkgs.connman}/sbin/connmand" "--config=${configFile}" "--nodaemon" ] ++ optional enableIwd "--wifi=iwd_agent" ++ cfg.extraFlags); </ins> StandardOutput = "null"; }; };

networking = { useDHCP = false; <del> wireless.enable = true; </del> <ins> wireless = { enable = mkIf (!enableIwd) true; iwd = mkIf enableIwd { enable = true; }; }; </ins> networkmanager.enable = false; }; };
Change:
updates postgresql11 from 11.1 to 11.2. <delIt seems like this includes breaking changes, since neither my Gitea nor my Quassel servers can properly work with 11.2.</delWhen upgrading, the new service is configured to use a different storage directory, because the psqlSchema version was changed: /var/lib/postgresql/11.2/ instead of /var/lib/postgresql/11.1/. This means when upgrading to 11.2, the data is not transferred and applications crash because their databases don't exist anymore. <delI'm also confused as to why postgresql96 has an own package as a minor version, while postgresql 11.x share one package. Shouldn't there be postgresql111 and postgresql112 if 11.2 includes breaking changes?</delRebuild a system with postgresql with the current unstable channel. postgresql 11.1 will be updated to postgresql 11.2, and all databases will not exist with the new versions, applications will crash. system: host os: multi-user?: sandbox: version: channels(pbb): channels(root): nixpkgs:
Thanks for report. PG changed it's version schema since v10. Previously v9.6.1 and 9.6.2 were considered compatible, but 9.5 and 9.6 - not compatible. Now 11.1 and 11.2 are considered compatible, but 10 and 11 - are not. In case they really have introduced a breaking change, it should be reported upstream. We can add old PG as workaround. Can you describe what exactly was broken (test case)?
I was running Quassel and Gitea with postgresql_11 pinned in my config. Last night the nixos-upgrade ran and updated from 11.1 to 11.2. After restarting, both Gitea and Quassel could not access their databases properly. For Gitea it just looked like the database was empty, all repositories and users were missing. I could not see any related messages in the log. For Quassel, the log looked like this:
As a quickfix I have my own postgresql111 package in my system configuration. After downgrading, everything works as expected again.
Okay, I can now tell what causes this behaviour: When upgrading, the new service is configured to use a different storage directory: /var/lib/postgresql/11.2/ instead of /var/lib/postgresql/11.1/. This means when upgrading to 11.2, the data is not transferred. Both applications failed, because their databases were missing.
Probably the psqlSchema version for 11.1 and 11.2 should be 11.0.

Discussion:
postgresql_10 = self.callPackage generic { version = "10.6"; <del> psqlSchema = "10.0"; </del> <ins> psqlSchema = "10.0"; # should be 10, but changing it is invasive </ins> sha256 = "0jv26y3f10svrjxzsgqxg956c86b664azyk2wppzpa5x11pjga38"; this = self.postgresql_10; inherit self;

postgresql_11 = self.callPackage generic { version = "11.2"; <del> psqlSchema = "11.2"; </del> <ins> psqlSchema = "11.1"; # should be 11, but changing it is invasive </ins> sha256 = "01clq2lw0v83zh5dc89xdr3mmap0jr37kdkh401ph6f2177bjxi6"; this = self.postgresql_11; inherit self;