jiebi/CodeConvo huggingface dataset:
Change:
The NixOS module for ddclient installs the config file world-readable, since commit . This results in the following warning from ddclient: Enable the NixOS ddclient module: When ddclient runs, will appear world-readable as system: host os: multi-user?: sandbox: version: channels(bfo): channels(root): nixpkgs:
Should that not be reopened? Is including and replacing with in ExecStartPre like this: a valid solution? I'm not sure if the user name is guaranteed to be unique
Oh yeah, and the above PR was reverted in too
Still getting this warning.

Discussion:
configFile = if (cfg.configFile != null) then cfg.configFile else configFile'; preStart = '' <del> install ${configFile} /run/${RuntimeDirectory}/ddclient.conf </del> <ins> install --mode=600 --owner=$USER ${configFile} /run/${RuntimeDirectory}/ddclient.conf </ins> ${lib.optionalString (cfg.configFile == null) (if (cfg.protocol == "nsupdate") then '' <del> install ${cfg.passwordFile} /run/${RuntimeDirectory}/ddclient.key </del> <ins> install --mode=600 --owner=$USER ${cfg.passwordFile} /run/${RuntimeDirectory}/ddclient.key </ins> '' else if (cfg.passwordFile != null) then '' "${pkgs.replace-secret}/bin/replace-secret" "@password_placeholder@" "${cfg.passwordFile}" "/run/${RuntimeDirectory}/ddclient.conf" '' else ''
Change:
does not include dependencies that are only listed in the field in the cabal file. This can cause build failures due to missing dependencies. Create the following Cabal file : Create the following Nix shell : Execute the following command to verify that the dependency is missing: In the cabal file uncomment the line for and then verify that the dependency becomes available: The expected behavior is that should be available in the Nix shell even if it is only listed under . The issue seems to lie with and not as correctly adds to in the generated Nix expression (after adding to the Nix shell):

Discussion:
optionals doBenchmark (benchmarkDepends ++ benchmarkHaskellDepends ++ benchmarkSystemDepends ++ benchmarkFrameworkDepends); <del> allBuildInputs = propagatedBuildInputs ++ otherBuildInputs ++ depsBuildBuild; </del> <ins> allBuildInputs = propagatedBuildInputs ++ otherBuildInputs ++ depsBuildBuild ++ nativeBuildInputs; </ins> isHaskellPartition = stdenv.lib.partition isHaskellPkg allBuildInputs;
Change:
When I run , I have the jupyter website that opens, however when I open a sage notebook, the sage kernel fails to start, and I've an error Install sage, tested on both latest nixos-unstable (that took ages to compile), and using the one provided here: Then run and try to open a sage notebook. You should see on the top right a red error "Kernel error", and the console should display the above errors Please run and paste the results.
/cc maintainer
Thanks for the report :) The immediate cause for the error is that contains while it should be . I have never used jupyter so I'm not sure if that is all. Integrating with would probably be good / maybe be necessary. I don't know when/if I'll get to debugging this since I don't currently use it myself, but I'll happily help you do it if you want to try. Note that the regular sage cli does work.
I also experience this issue. I thought I was installing Jupyter incorrectly. Lol, I should have checked for a bug report, I asked for help at
This is now fixed in master.

Discussion:
}; }; <ins> jupyter-kernel-definition = { displayName = "SageMath ${sage-src.version}"; argv = [ "${sage-with-env}/bin/sage" # FIXME which sage "--python" "-m" "sage.repl.ipython_kernel" "-f" "{connection_file}" ]; language = "sagemath"; # just one 16x16 logo is available logo32 = "${sage-src}/doc/common/themes/sage/static/sageicon.png"; logo64 = "${sage-src}/doc/common/themes/sage/static/sageicon.png"; }; </ins> # A bash script setting various environment variables to tell sage where # the files its looking fore are located. Also see `sage-env`. env-locations = callPackage ./env-locations.nix {

in # A wrapper around sage that makes sure sage finds its docs (if they were build). callPackage ./sage.nix { <del> inherit sage-tests sage-with-env sagedoc; </del> <ins> inherit sage-tests sage-with-env sagedoc jupyter-kernel-definition; </ins> inherit withDoc; }

, makeWrapper , sage-tests , sage-with-env <ins> , jupyter-kernel-definition , jupyter-kernel </ins> , sagedoc , withDoc }: <del> # A wrapper that makes sure sage finds its docs (if they were build). </del> <ins> # A wrapper that makes sure sage finds its docs (if they were build) and the # jupyter kernel spec. let # generate kernel spec + default kernels kernel-specs = jupyter-kernel.create { definitions = jupyter-kernel.default // { sagemath = jupyter-kernel-definition; }; }; in </ins> stdenv.mkDerivation rec { version = src.version; name = "sage-${version}";

mkdir -p "$out/bin" makeWrapper "${sage-with-env}/bin/sage" "$out/bin/sage"  --set SAGE_DOC_SRC_OVERRIDE "${src}/src/doc" ${ <del> stdenv.lib.optionalString withDoc "--set SAGE_DOC_OVERRIDE ${sagedoc}/share/doc/sage" } </del> <ins> stdenv.lib.optionalString withDoc "--set SAGE_DOC_OVERRIDE ${sagedoc}/share/doc/sage" }  --prefix JUPYTER_PATH : "${kernel-specs}" </ins> ''; doInstallCheck = withDoc;

tests = sage-tests; doc = sagedoc; lib = sage-with-env.env.lib; <ins> kernelspec = jupyter-kernel-definition; </ins> }; meta = with stdenv.lib; {
Change:
3 is out! I'm not sure what's changed but it's at least 200% more better, and has a plugin for making you toast :stuckouttongue: . The release notes are here: and are as follows: Anyway I imagine someone'll be excited about the new version :grin: so thought I'd share.
Haha, a proper changelog is here: my bad :innocent:.

Discussion:
weechat = assert lib.all (p: p.enabled -> ! (builtins.elem null p.buildInputs)) plugins; stdenv.mkDerivation rec { <del> version = "2.2"; </del> <ins> version = "2.3"; </ins> name = "weechat-${version}"; src = fetchurl { <del> url = "http://weechat.org/files/src/weechat-${version}.tar.bz2"; sha256 = "0p4nhh7f7w4q77g7jm9i6fynndqlgjkc9dk5g1xb4gf9imiisqlg"; </del> <ins> url = "https://weechat.org/files/src/weechat-${version}.tar.bz2"; sha256 = "0mi4pfnyny0vqc35r0scn6yy21y790a5iwq8ms7kch7b7z11jn9w"; </ins> }; outputs = [ "out" "man" ] ++ map (p: p.name) enabledPlugins;

done ''; <del> # remove when bumping to the latest version. # This patch basically rebases `fcf7469d7664f37e94d5f6d0b3fe6fce6413f88c` # from weechat upstream to weechat-2.2. patches = [ ./aggregate-commands.patch ]; </del> meta = { homepage = http://www.weechat.org/; description = "A fast, light and extensible chat client";
Change:
Changing or will not do anything till the next round of refresh after refresh, changes to do not actually propagate. The permissions of the key are not changed. Only of the surrounding directory. a cert with change to : Afterwards add Observe that the owner is still and that there are no group read permissions yet after manually refreshing by calling the timer manually, the did change, by the permission bits still not allow read access to even if is set Please run and paste the results.
Hey I made a PR that fixes this, would love to have somebody else make sure it fixes this problem:
Lets re-open this issue.
Hello, I'm a bot and I thank you in the name of the community for opening this issue. To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use or on the relevant files to find them. Lastly, you can always ask for help at or at .
wasnt this fixed by the recent bugfix round ?
Yeah, that option has been removed Infact :P
This option is now gone in favour of always making the certificates group readable and owned by the acme user, and letting users change only the group that will be applied to them. Closing this issue.

Discussion:
environment.REQUESTS_CA_BUNDLE = "/etc/ssl/certs/ca-certificates.crt"; serviceConfig = { Type = "oneshot"; <ins> # With RemainAfterExit the service is considered active even # after the main process having exited, which means when it # gets changed, the activation phase restarts it, meaning # the permissions of the StateDirectory get adjusted # according to the specified group RemainAfterExit = true; </ins> SuccessExitStatus = [ "0" "1" ]; User = data.user; Group = data.group;
Change:
msgpack-python was renamed to msgpack, but the rename isn't handled properly in release-18.09 yet. See Please run and paste the results.

Discussion:
# Media support MEDIA_CAMERA_SUPPORT? y MEDIA_RC_SUPPORT? y <ins> MEDIA_USB_SUPPORT y </ins> ${if kernelPlatform ? kernelExtraConfig then kernelPlatform.kernelExtraConfig else ""} ${extraConfig}
Change:
If I install , then I get version , which causes problems with Tiller image pulls. Alternatively, if I try to pull a specific version like this: Then I get this build failure:

Discussion:
# Thsese are the original flags from the helm makefile buildFlagsArray = '' <del> -ldflags= </del> <ins> -ldflags=-X k8s.io/helm/pkg/version.Version=v${version} </ins> -w -s '';
Change:
I had defined a gid for user kvm. 18.09 likely introduces its own kvm user, which is incompatible and configuration fails as a result. Define in users.extraGroups a user and do This is a bug, because it is not in the release notes. Not relevant (tried to switch to the nixos-18.09 release channel) from a 18.03 machine.

Discussion:
anyways for clarity. </para> </listitem> <ins> <listitem> <para> Groups <literal>kvm</literal> and <literal>render</literal> are introduced now, as systemd requires them. </para> </listitem> </ins> </itemizedlist> </section>
Change:
option was changed to ddclient.domains, but instead of maintaining backwards compatibility the type was changed to a list of strings, which also was not in the release notes, which makes this a bug. I don't see why the type was not simply changed to an or of a string and a list of strings in order to maintain compatibility. Try to upgrade 18.03 with = ""; Any released 18.03 version.
As this breakage already happened, would there be a point in doing a patch for 18.09? (I could provide one, but I don't know, wether it will be merged into a stable branch.)
It would improve the experience for others (if you make it such that it works for both types). I cannot imagine any reason for it not being merged into a stable branch. I wouldn't mind merging it myself, but since I have no rights to do that you would have to wait longer.
hmm it looks like the module is in a weird state anyway. The config file, which is produced at the moment, doesn't look very useful, as all options will be applied to all domains likewise. So only one protocol can be used in nixos at the moment. If I am not mistaken I will need to change that into a config per domain, with a global part.
Your changes would introduce new features and go beyond what is in 18.09. 19.03 would be a good target. Due to the module system people could already use them in . Even then if would be nice if you could keep it backwards compatible. It's probably also relevant to consider whether there is an actual demand for what you are trying to do. For example, I would not be a potential user and most people would likely only use one protocol.
Not a problem, so I will just make the minimal possible change.
This needs to be reopened, because of a failure to build:
I'll take look. Which commit did you use?
Whatever was newest 15 hours ago in the release channel.
Yes, the change wasn't backported to the release branch :(
: Could you please reopen this and merge the change into release-18.09 ?

Discussion:
(config: let enabled = getAttrFromPath [ "services" "printing" "gutenprint" ] config; in if enabled then [ pkgs.gutenprint ] else [ ])) <del> (mkRenamedOptionModule [ "services" "ddclient" "domain" ] [ "services" "ddclient" "domains" ]) </del> <ins> (mkChangedOptionModule [ "services" "ddclient" "domain" ] [ "services" "ddclient" "domains" ] (config: let value = getAttrFromPath [ "services" "ddclient" "domain" ] config; in if value != "" then [ value ] else [])) </ins> (mkRemovedOptionModule [ "services" "ddclient" "homeDir" ] "") (mkRenamedOptionModule [ "services" "elasticsearch" "host" ] [ "services" "elasticsearch" "listenAddress" ]) (mkRenamedOptionModule [ "services" "graphite" "api" "host" ] [ "services" "graphite" "api" "listenAddress" ])
Change:
Invoking is producing the following error message: is part of the package so it's just failing to locate it. I'm running on NixOS Unstable.
I believe this issue has been fixed and can be closed:

Discussion:
python3.pkgs.buildPythonApplication rec { pname = "borgbackup"; <del> version = "1.1.10"; </del> <ins> version = "1.1.11"; </ins> src = python3.pkgs.fetchPypi { inherit pname version; <del> sha256 = "1pp70p4n5kamvcbl4d8021ggrxhyykmg9isjg4yd3wags8b19d7g"; </del> <ins> sha256 = "190gjzx83b6p64nqj840x382dgz9gfv0gm7wj585lnkrpa90j29n"; </ins> }; nativeBuildInputs = with python3.pkgs; [

HOME=$(mktemp -d) py.test --pyargs borg.testsuite ''; <del> # 63 failures, needs pytest-benchmark </del> <ins> # 64 failures, needs pytest-benchmark </ins> doCheck = false; meta = with stdenv.lib; {
Change:
Enabling the option during repository creation makes it fail with Internal Server Error. Additionally, the repository creation page doesn't list , and templates. Enable in NixOS configuration, open Gitea in browser, register a user, go to Create Repository page, enter repository name, check the checkbox, click , see it fails. system: host os: multi-user?: sandbox: version: channels(paul): channels(root): nixpkgs:
The reason for this is that the package doesn't include templates for README and other initial repository contents. It's easy to fix, I'll submit a PR.
There is a about the Debian package.

Discussion:
postInstall = '' mkdir $data <del> cp -R $src/{public,templates} $data </del> <ins> cp -R $src/{public,templates,options} $data </ins> mkdir -p $out cp -R $src/options/locale $out/locale
Change:
Maybe it's a problem with the ? Don't seem so. I can also not download it manually with curl: (i get a 0 byte file) But i can download it using a browser from the website. But the hash is also different: So they prevent us from downloading the file using something else than their website. Maybe the referer is not enough now? system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:

Discussion:
src = fetchurl { url = "https://www2.ati.com/drivers/linux/radeon-crimson-15.12-15.302-151217a-297685e.zip"; <del> sha256 = "0n0ynqmjkjp5dl5q07as7ps3rlyyn63hq4mlwgd7c7v82ky2skvh"; curlOpts = "--referer http://support.amd.com/en-us/download/desktop?os=Linux+x86_64"; </del> <ins> sha256 = "704f2dfc14681f76dae3b4120c87b1ded33cf43d5a1d800b6de5ca292bb61e58"; curlOpts = "--referer https://www.amd.com/en/support"; </ins> }; hardeningDisable = [ "pic" "format" ];
Change:
, (unstable, 18.09, 18.03) (unstable, 18.09, 18.03) (unstable, 18.09, 18.03)
libtiff-4.0.10 has been
We have 4.0.10 in both active branches, but I've been unable to find a convincing claim that the update fixed (some of) these three CVEs. (They're tagged by == 4.0.9 on NVD, but I don't know...)
Version tags in the NVD are not always of high quality.
obsolete: 19.03 ships libtiff-4.0.10

Discussion:
<del> { stdenv, fetchurl, pkgconfig, zlib, libjpeg, xz }: </del> <ins> { stdenv , fetchFromGitLab </ins> <del> let version = "4.0.9"; in stdenv.mkDerivation rec { name = "libtiff-${version}"; </del> <ins> , pkgconfig , autogen , autoconf , automake , libtool </ins> <del> src = fetchurl { url = "https://download.osgeo.org/libtiff/tiff-${version}.tar.gz"; sha256 = "1kfg4q01r4mqn7dj63ifhi6pmqzbf4xax6ni6kkk81ri5kndwyvf"; }; </del> <ins> , zlib , libjpeg , xz }: </ins> <del> prePatch = let debian = fetchurl { # When the URL disappears, it typically means that Debian has new patches # (probably security) and updating to new tarball will apply them as well. url = http://http.debian.net/debian/pool/main/t/tiff/tiff_4.0.9-6.debian.tar.xz; sha256 = "10yk5npchxscgsnd7ihd3bbbw2fxkl7ni0plm43c9q4nwp6ms52f"; }; in '' tar xf ${debian} patches="$patches $(sed 's|^|debian/patches/|' < debian/patches/series)" ''; </del> <ins> stdenv.mkDerivation rec { version = "2018-11-04"; name = "libtiff-unstable-${version}"; src = fetchFromGitLab { owner = "libtiff"; repo = "libtiff"; rev = "779e54ca32b09155c10d398227a70038de399d7d"; sha256 = "029fmn0rdmb5gxhg83ff9j2zx3qk6wsiaiv554jq26pdc23achsp"; }; </ins> outputs = [ "bin" "dev" "out" "man" "doc" ]; <del> nativeBuildInputs = [ pkgconfig ]; </del> <ins> nativeBuildInputs = [ pkgconfig autogen autoconf automake libtool ]; </ins> propagatedBuildInputs = [ zlib libjpeg xz ]; #TODO: opengl support (bogus configure detection) enableParallelBuilding = true; <ins> preConfigure = "./autogen.sh"; </ins> doCheck = true; # not cross; meta = with stdenv.lib; {
Change:
I'm reporting this for a friend of mine who wanted to install NixOS and ran into this issue. I hope that's okay. The problem is: fails if you have in your host's kernel config (which, I think, is reasonable if you're compiling it yourself and don't need swap). I took a cursory look into and saw that it reads from . This fails, apparently, because the file doesn't exist on systems without swap support. Can this be easily fixed by assuming there are no swap devices if the file cannot be found?
I'd say already assume this, but don't handle it gracefully.

Discussion:
# Generate the swapDevices option from the currently activated swap # devices. <del> my @swaps = read_file("/proc/swaps"); shift @swaps; </del> <ins> my @swaps = read_file("/proc/swaps", err_mode => 'carp'); </ins> my @swapDevices; <del> foreach my $swap (@swaps) { $swap =~ /^(S+)s/; next unless -e $1; my $dev = findStableDevPath $1; push @swapDevices, "{ device = "$dev"; }"; </del> <ins> if (@swaps) { shift @swaps; foreach my $swap (@swaps) { $swap =~ /^(S+)s/; next unless -e $1; my $dev = findStableDevPath $1; push @swapDevices, "{ device = "$dev"; }"; } </ins> }
Change:
In the file a non existing shell script is referenced as executable: ` The binary in is called . Please change the line in the file accordingly. install software try to run it through a launchersystem: host os: multi-user?: sandbox: version: channels(root): channels(wucke13): nixpkgs:
Do you feel like trying to fix this in the ?
Sure

Discussion:
cd .. mkdir -p $out/share/applications <ins> sed 's/Exec=.*$/Exec=QGroundControl/g' --in-place deploy/qgroundcontrol.desktop </ins> cp -v deploy/qgroundcontrol.desktop $out/share/applications mkdir -p $out/bin
Change:
The derivation is available but cannot be built. I get the following error : I get the original package to work in a nix-shell with the following derivation:
I commented in the PR to address this issue. It is due to a circular dependency that and have on each other for testing. You may run into more similar issues since python 35 it not heavily tested in the community right now. If you can use 36 or 37. 37 will be the default soon.
Thanks!

Discussion:
<del> { lib, buildPythonPackage, fetchPypi, pythonOlder, pytest, pytest-asyncio }: </del> <ins> { lib, buildPythonPackage, fetchPypi, pythonOlder, isPy35, pytest, pytest-asyncio }: </ins> buildPythonPackage rec { pname = "async_generator";

pytest -W error -ra -v --pyargs async_generator ''; <ins> # disable tests on python3.5 to avoid circular dependency with pytest-asyncio doCheck = !isPy35; </ins> meta = with lib; { description = "Async generators and context managers for Python 3.5+"; homepage = https://github.com/python-trio/async_generator;

<del> { stdenv, buildPythonPackage, fetchPypi, pytest, isPy3k }: </del> <ins> { stdenv, buildPythonPackage, fetchPypi, pytest, isPy3k, isPy35, async_generator }: </ins> buildPythonPackage rec { pname = "pytest-asyncio"; version = "0.9.0";

sha256 = "fbd92c067c16111174a1286bfb253660f1e564e5146b39eeed1133315cf2c2cf"; }; <del> buildInputs = [ pytest ]; </del> <ins> buildInputs = [ pytest ] ++ stdenv.lib.optionals isPy35 [ async_generator ]; </ins> # No tests in archive doCheck = false;
Change:
nixos-18.09 (and nixpgks master and everything in-between) currently ships Firefox 63.0 and geckodriver "unstable-2018-02-24" (which claims to be 0.19.1 when called with ). According to https://firefox-source- geckodriver &ge; 0.21 is needed to be compatible with Firefox 62. last command runs with exit code and without any terminal output opens an empty firefox window: ! last command runs with exit code and the following terminal output no Firefox window is being opened system: host os: multi-user?: sandbox: version: channels(root): channels(das-g): nixpkgs:
I'm looking into updating the geckodriver derivation, but am unsure what source repo / revision to refer to. (See mozilla/geckodriver.)
We also have no newer version in master. If you update the package on master, I would backport it to 18.09 as well.
We also should switch to a stable release so would automatically upgrade to newer releases.
Hey I'm also running into this issue. Have you made any progress?
I can't reproduce that, For me your series of commands "works" it opens an empty Firefox window it runs with exit code and without any output except that caused by nix building/fetching
Yeah, right after my (deleted) post I noticed I forgot to setup the variable . Sorry about that, it's indeed working great now! :smiley_cat:

Discussion:
{ lib , fetchFromGitHub , rustPlatform <ins> , stdenv , darwin </ins> }: with rustPlatform; buildRustPackage rec { <del> version = "unstable-2018-02-24"; </del> <ins> version = "0.22.0"; </ins> name = "geckodriver-${version}"; src = fetchFromGitHub { owner = "mozilla"; <del> repo = "gecko-dev"; rev = "ecb86060b4c5a9808798b81a57e79e821bb47082"; sha256 = "1am84a60adw0bb12rlhdqbiwyywhza4qp5sf4f4fmssjl2qcr6nl"; </del> <ins> repo = "geckodriver"; rev = "v${version}"; sha256 = "12m95lfqwdxs2m5kjh3yrpm9w2li5m8n3fw46a2nkxyfw6c94l4b"; </ins> }; <del> sourceRoot = "${src.name}/testing/geckodriver"; </del> <ins> buildInputs = lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security ]; </ins> <del> cargoSha256 = "0dvcvdb623jla29i93glx20nf8pbpfw6jj548ii6brzkcpafxxm8"; </del> <ins> cargoSha256 = "1a8idl6falz0n9irh1p8hv5w2pmiknzsfnxl70k1psnznrpk2y8n"; </ins> meta = with lib; { description = "Proxy for using W3C WebDriver-compatible clients to interact with Gecko-based browsers";
Change:
should be imported into the top-level module list, so that it is visible without manually importing this module. Might be go if it goes in here.
Thanks for pointing this out! Didn't notice it because we import modules from pinned versions.

Discussion:
./services/logging/graylog.nix ./services/logging/heartbeat.nix ./services/logging/journalbeat.nix <ins> ./services/logging/journaldriver.nix </ins> ./services/logging/journalwatch.nix ./services/logging/klogd.nix ./services/logging/logcheck.nix