Change:
Package name: srb2 Latest released version: 2.2.13 <!-- Search your package here: --- Current version on the unstable channel: 2.2.11 Current version on the stable/release channel: 2.2.10 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. -- Note for maintainers: Please tag this issue in your PR.
Looks like there were a bunch of CMake changes so the build needs to be changed. See: Not sure how to make this work in Nix yet so it might take some time before I figure things out.
Looks like openSUSE patched 2.2.13 with these changes: Will investigate more later.
The PR hasn't been merged yet, but you can play SRB2 with the following: Feel free to leave an approving review if it works for you.
been using it for a few days now, also I don't know how to review since i've never done it before could I be pointed to the relevant docs?
Here's the . Thanks in advance!

Discussion:
diff --git a/CMakeLists.txt b/CMakeLists.txt <del> index 915912af5..f5c2cf9cc 100644 </del> <ins> index 80a3bdcd6..380a1573a 100644 </ins> --- a/CMakeLists.txt +++ b/CMakeLists.txt <del> @@ -91,11 +91,6 @@ if("${CMAKE_HOST_SYSTEM_NAME}" STREQUAL Windows) </del> <ins> @@ -61,7 +61,7 @@ option( "Link dependencies using CMake's find_package and do not use internal builds" ${SRB2_CONFIG_SYSTEM_LIBRARIES_DEFAULT} ) -option(SRB2_CONFIG_ENABLE_TESTS "Build the test suite" ON) +option(SRB2_CONFIG_ENABLE_TESTS "Build the test suite" OFF) # This option isn't recommended for distribution builds and probably won't work (yet). cmake_dependent_option( SRB2_CONFIG_SHARED_INTERNAL_LIBRARIES @@ -80,25 +80,6 @@ option(SRB2_CONFIG_ZDEBUG "Compile with ZDEBUG defined." OFF) option(SRB2_CONFIG_PROFILEMODE "Compile for profiling (GCC only)." OFF) set(SRB2_CONFIG_ASSET_DIRECTORY "" CACHE PATH "Path to directory that contains all asset files for the installer. If set, assets will be part of installation and cpack.") -if(SRB2_CONFIG_ENABLE_TESTS) -	# https://github.com/catchorg/Catch2 -	CPMAddPackage( -		NAME Catch2 -		VERSION 3.4.0 -		GITHUB_REPOSITORY catchorg/Catch2 -		OPTIONS -			"CATCH_INSTALL_DOCS OFF" -	) -	list(APPEND CMAKE_MODULE_PATH "${Catch2_SOURCE_DIR}/extras") -	include(CTest) -	include(Catch) -	add_executable(srb2tests) -	# To add tests, use target_sources to add individual test files to the target in subdirs. -	target_link_libraries(srb2tests PRIVATE Catch2::Catch2 Catch2::Catch2WithMain) -	target_compile_features(srb2tests PRIVATE c_std_11 cxx_std_17) -	catch_discover_tests(srb2tests) -endif() - # Enable CCache # (Set USE_CCACHE=ON to use, CCACHE_OPTIONS for options) if("${CMAKE_HOST_SYSTEM_NAME}" STREQUAL Windows) @@ -113,12 +94,6 @@ if("${CMAKE_HOST_SYSTEM_NAME}" STREQUAL Windows) message(WARNING "USE_CCACHE was set but ccache is not found (set CCACHE_TOOL_PATH)") </ins> endif() endif() <del> else() </del> <ins> -else() </ins> -	CPMAddPackage( -		NAME Ccache.cmake -		GITHUB_REPOSITORY TheLartians/Ccache.cmake -		VERSION 1.2 -	) endif() # Dependencies <del> -- 2.40.1 </del> <ins> @@ -179,7 +154,7 @@ include(GitUtilities) if("${SRB2_SDL2_EXE_NAME}" STREQUAL "") # cause a reconfigure if the branch changes get_git_dir(SRB2_GIT_DIR) -	configure_file("${SRB2_GIT_DIR}/HEAD" HEAD COPYONLY) +	#configure_file("${SRB2_GIT_DIR}/HEAD" HEAD COPYONLY) git_current_branch(SRB2_GIT_REVISION) </ins>

stdenv.mkDerivation (finalAttrs: { pname = "srb2"; <del> version = "2.2.11"; </del> <ins> version = "2.2.13"; </ins> src = fetchFromGitHub { owner = "STJr"; repo = "SRB2"; rev = "SRB2_release_${finalAttrs.version}"; <del> hash = "sha256-tyiXivJWjNnL+4YynUV6k6iaMs8o9HkHrp+qFj2+qvQ="; </del> <ins> hash = "sha256-OSkkjCz7ZW5+0vh6l7+TpnHLzXmd/5QvTidRQSHJYX8="; </ins> }; nativeBuildInputs = [

src = fetchurl { url = "https://github.com/STJr/SRB2/releases/download/SRB2_release_${finalAttrs.version}/SRB2-v${lib.replaceStrings ["."] [""] finalAttrs.version}-Full.zip"; <del> hash = "sha256-KsJIkCczD/HyIwEy5dI3zsHbWFCMBaCoCHizfupFoWM="; </del> <ins> hash = "sha256-g7kaNRE1tjcF5J2v+kTnrDzz4zs5f1b/NH67ce2ifUo="; </ins> }; sourceRoot = ".";

]; patches = [ <del> # Fix unknown command "CPMAddPackage" by not using Ccache.cmake </del> <ins> # Make the build work without internet connectivity # See: https://build.opensuse.org/request/show/1109889 </ins> ./cmake.patch <ins> ./thirdparty.patch </ins> ]; desktopItems = [

platforms = platforms.linux; license = licenses.gpl2Plus; maintainers = with maintainers; [ zeratax donovanglover ]; <ins> mainProgram = "srb2"; </ins> }; })

<ins> diff --git a/thirdparty/CMakeLists.txt b/thirdparty/CMakeLists.txt index f33b3bf3f..1214f179c 100644 --- a/thirdparty/CMakeLists.txt +++ b/thirdparty/CMakeLists.txt @@ -16,6 +16,5 @@ if(NOT "${SRB2_CONFIG_SYSTEM_LIBRARIES}") include("cpm-png.cmake") include("cpm-curl.cmake") include("cpm-openmpt.cmake") +	include("cpm-libgme.cmake") endif() - -include("cpm-libgme.cmake") </ins>