jiebi/CodeConvo huggingface dataset:
Change:
Emby uses ffmpeg for transcoding media and for generating thumbnails. Emby fails to find the FFmpeg binary during the setup wizard but can be specified manually if FFmpeg has been installed separately. Add to , browse to , and advance through the wizard. System: 17.03pre92039. (Gorilla) Nix version:nix-env (Nix) 1.11.4 Nixpkgs version: 17.03pre92039.
cc
Funny thing is that I was just watching a movie when I was mentioned on a system without any ffmpeg/ffprobe binary. My system was upgraded from an older version (config was already existing so no check was done by the wizard). I was able to reproduce the issue. Will take a more detailed look at it sometime tomorrow :)

Discussion:
User = cfg.user; Group = cfg.group; PermissionsStartOnly = "true"; <del> ExecStart = "${pkgs.mono}/bin/mono ${pkgs.emby}/bin/MediaBrowser.Server.Mono.exe"; </del> <ins> ExecStart = "${pkgs.emby}/bin/MediaBrowser.Server.Mono"; </ins> Restart = "on-failure"; }; };

<del> { stdenv, fetchurl, pkgs, ... }: </del> <ins> { stdenv, fetchurl, pkgs, makeWrapper, mono, ffmpeg, ... }: </ins> stdenv.mkDerivation rec { name = "emby-${version}";

sha256 = "0xm3jw8ll49akr4fxa5qjbsglcgb6fq6nc54zppannxdlfkqj5jk"; }; <ins> buildInputs = with pkgs; [ makeWrapper ]; </ins> propagatedBuildInputs = with pkgs; [ mono sqlite

installPhase = '' mkdir -p $out/bin cp -r MediaBrowser.Server.Mono/bin/Release Mono/* $out/bin/ <ins> makeWrapper "${mono}/bin/mono" $out/bin/MediaBrowser.Server.Mono  --add-flags "$out/bin/MediaBrowser.Server.Mono.exe -ffmpeg ${ffmpeg}/bin/ffmpeg -ffprobe ${ffmpeg}/bin/ffprobe" </ins> ''; meta = {
Change:
Nixpkgs already has some guidelines how to write commit messages in It describes how to structure the message. Most commits follow this guideline which is very good. However one Problem is that many people do really good changes in their commit but for somebody not directly involved it is really hard to understand why. In my opinion it's very important to have this "why" in the commit message, especially if the project has many collaborators of various degree of involvement. One project I found to do this very well is . I propose to add a section to that encourages to explain a bit more why the changes were made. Maintainers should then encourage people to follow this guidelines when reviewing PRs.
Do you have any special kind of commits in mind? I am asking because package updates and new package commits seems pretty much self-explanatory. (one improvement I can see in this regard is to put release notes for package updates commits) Also, the why, while not in mandatory in the commit message, should figure in the pull-request .
I recently stumbled upon this commit for example: While the commit message clearly states what is done, I have no Idea why it was done. Having the motivation in the pull request is good but doing self contained commits with all the information for somebody to understand the changes and the reasons behind is even better.
I second that the motivation should be in the commit message and not only the pr, so one can read it without searching for the pr on github first..

Discussion:
* Format the commits in the following way: <del> `(pkg-name | service-name): (from -> to | init at version | refactor | etc)` </del> <ins> ``` (pkg-name | service-name): (from -> to | init at version | refactor | etc) (Motivation for change. Additional information.) ``` </ins> Examples: * nginx: init at 2.0.1 * firefox: 3.0 -> 3.1.1 * hydra service: add bazBaz option <ins> Dual baz behavior is needed to do foo. </ins> * nginx service: refactor config generation <ins> The old config generation system used impure shell scripts and could break in specific circumstances (see #1234). </ins> * `meta.description` should: * Be capitalized

See the nixpkgs manual for more details on how to [Submit changes to nixpkgs](https://nixos.org/nixpkgs/manual/#chap-submitting-changes). <ins> ## Writing good commit messages In addition to writing properly formatted commit messages, it's important to include relevant information so other developers can later understand *why* a change was made. While this information usually can be found by digging code, mailing list archives, pull request discussions or upstream changes, it may require a lot of work. For package version upgrades and such a one-line commit message is usually sufficient. </ins> ## Reviewing contributions See the nixpkgs manual for more details on how to [Review contributions](https://nixos.org/nixpkgs/manual/#sec-reviewing-contributions).
Change:
The python3 package appears to be missing the submodule. Steps to reproduce the behavior: The python statement to succeed.

Discussion:
{ python <ins> , pythonAtLeast , disabledIf </ins> , fetchurl , lib , stdenv

, shiboken2 }: <ins> # Only build when Python<=3.10 # See https://bugreports.qt.io/browse/PYSIDE-1864 # "There are no plans to support Python versions > 3.10 in the 5.15 branch." disabledIf (pythonAtLeast "3.11") ( </ins> stdenv.mkDerivation rec { pname = "pyside2"; version = "5.15.5";

qtcharts qtsensors qtsvg <ins> qt3d </ins> ]) ++ (with python.pkgs; [ setuptools ]) ++ (lib.optionals (python.pythonOlder "3.9") [

homepage = "https://wiki.qt.io/Qt_for_Python"; maintainers = with maintainers; [ gebner ]; }; <del> } </del> <ins> }) </ins>
Change:
Doesn't start from shortcut in GNOME system. Runs in the terminal. The shortcut does not work.
This seems to be caused by the fact that the desktop file sets . The problem also occurs on Plasma Wayland, so I guess it happens on Wayland in general. (Didn't test X11 window managers.)

Discussion:
stdenv.mkDerivation rec { pname = "pcsx2"; <del> version = "1.7.3165"; </del> <ins> version = "1.7.3331"; </ins> # nixpkgs-update: no auto update src = fetchFromGitHub {

repo = "pcsx2"; fetchSubmodules = true; rev = "v${version}"; <del> hash = "sha256-FdLmLZLpS8zPmHVn4k0nE6vS/omYVIOal9ej0h3bE/Y="; </del> <ins> hash = "sha256-0RcmBMxKj/gnkNEjn2AUSSO1DzyNSf1lOZWPSUq6764="; </ins> }; cmakeFlags = [

zlib ]; <del> # Wayland doesn't seem to work right now (crashes when booting a game). # Try removing `--prefix GDK_BACKEND : x11` on the next update. # (This may be solved when the project finshes migrating to Qt) </del> preFixup = '' gappsWrapperArgs+=( --prefix LD_LIBRARY_PATH : ${lib.makeLibraryPath [ vulkan-loader ]} <del> --prefix GDK_BACKEND : x11 </del> ) '';
Change:
Unstable Bitwig doesn't know where libpipewire- is when attempting to load the Pipewire audio device. Console error !

Discussion:
{ stdenv, fetchurl, alsa-lib, cairo, dpkg, freetype , gdk-pixbuf, glib, gtk3, lib, xorg , libglvnd, libjack2, ffmpeg <del> , libxkbcommon, xdg-utils, zlib, pulseaudio </del> <ins> , libxkbcommon, xdg-utils, zlib, pipewire, pulseaudio </ins> , wrapGAppsHook, makeWrapper }: stdenv.mkDerivation rec {

dontWrapGApps = true; # we only want $gappsWrapperArgs here buildInputs = with xorg; [ <del> alsa-lib cairo freetype gdk-pixbuf glib gtk3 libxcb xcbutil xcbutilwm zlib libXtst libxkbcommon pulseaudio libjack2 libX11 libglvnd libXcursor stdenv.cc.cc.lib </del> <ins> alsa-lib cairo freetype gdk-pixbuf glib gtk3 libxcb xcbutil xcbutilwm zlib libXtst libxkbcommon pipewire pulseaudio libjack2 libX11 libglvnd libXcursor stdenv.cc.cc.lib </ins> ]; installPhase = ''
Change:
When localhost is mapped to both and in , getaddrinfo(3) still only returns . It should be returning both with ipv6 first. Run the following program as On gentoo, OSX and arch the program returns something like: Whereas on nixos, it returns: System: (NixOS: , Ubuntu/Fedora: , ...) (Gorilla) Nix version: (run ) nix-env (Nix) 1.11.4 Nixpkgs version: (run )
There is also no in nixos.
On Ubuntu 14.04.4 LTS, compiling your code with nix's gcc: The machine has those entries in file. (I compiled with gcc from the latest unstable channel, as your nixpkgs version seems to be unreachable from official branches.)
FWIW neither adding from Arch or stopping (a shot in the dark) fixed this.
The same issue can be demonstrated with . Note that it works in a docker archlinux container on NixOS (using ), which means that the network stack itself is not the problem since the container shares the network stack with the host.
Found the issue: The difference is in the file . On archlinux, this file contains the following line: NixOS doesn't use a non-default , so is set to its default value, which is off. From :
Should be a easy fix then right?
Following other popular distros is probably the way to go, perhaps with a config option to opt out.

Discussion:
''; }; <ins> networking.hostConf = lib.mkOption { type = types.lines; default = "multi on"; example = '' multi on reorder on trim lan ''; description = '' The contents of <filename>/etc/host.conf</filename>. See also <citerefentry><refentrytitle>host.conf</refentrytitle><manvolnum>5</manvolnum></citerefentry>. ''; }; </ins> networking.dnsSingleRequest = lib.mkOption { type = types.bool; default = false;

${cfg.extraHosts} ''; <ins> # /etc/host.conf: resolver configuration file "host.conf".text = cfg.hostConf; </ins> # /etc/resolvconf.conf: Configuration for openresolv. "resolvconf.conf".text = ''
Change:
(Apologies if this is the wrong place/format for this issue; I'm a Nix newcomer.) I'm trying to use the Python package as supported. I'd be happy to contribute a patch to change this if someone could help me figure out what needs to happen.
That sounds reasonable to me. The list of supported platforms came from , which doesn't mention MacOS, only that the package failed to build on aarch64-linux. I was locally able to build it on aarch64-darwin, so the restriction doesn't seem to be needed for MacOS. You can open a PR that adds (which is a list) to the platforms list (in Nix, is the list concatenation operator), following the .
per , failed due to lack of on aarch64. But nothing is marked as broken in . FWIW, I successfully built both and on . Any volunteers to test it on ?

Discussion:
homepage = "https://pysam.readthedocs.io/"; maintainers = with maintainers; [ unode ]; license = licenses.mit; <del> platforms = [ "i686-linux" "x86_64-linux" ]; </del> <ins> platforms = platforms.unix; </ins> }; }
Change:
Steps to reproduce the behavior: githhub-desktop Libs not to the Update of Package:
This issue is addressed by

Discussion:
stdenv.mkDerivation rec { pname = "github-desktop"; <del> version = "3.0.5"; </del> <ins> version = "3.0.6"; </ins> src = fetchurl { url = "https://github.com/shiftkey/desktop/releases/download/release-${version}-linux1/GitHubDesktop-linux-${version}-linux1.deb"; <del> sha256 = "sha256-7Sk2jDNZtOA04hkl/J+Up2yMGT8+FcXGPiUMcHhb7iY="; </del> <ins> hash = "sha256-UQsMT4/D571xgrU8C4HBoRO+qf08GCGerA4Y5gHcjRc="; </ins> }; nativeBuildInputs = [

github-commenter = callPackage ../development/tools/github-commenter { }; <del> github-desktop = callPackage ../applications/version-management/github-desktop { }; </del> <ins> github-desktop = callPackage ../applications/version-management/github-desktop { curl = curl.override { openssl = openssl_1_1; }; }; </ins> github-to-sqlite = with python3Packages; toPythonApplication github-to-sqlite;
Change:
The package 18 on master failed to build. Steps to reproduce the behavior: build github:nixos/nixpkgs#clevis ! Full build log:

Discussion:
{ lib , stdenv , fetchFromGitHub <ins> , fetchurl </ins> , meson , ninja , pkg-config

sha256 = "sha256-m1UhyjD5ydSgCTBu6sECLlxFx0rnQxFnBA7frbdUqU8="; }; <ins> patches = [ # sss: use BN_set_word(x, 0) instead of BN_zero(), fixes build issue with different versions of openssl (fetchurl { url = "https://github.com/latchset/clevis/commit/ee1dfedb9baca107e66a0fec76693c9d479dcfd9.patch"; sha256 = "sha256-GeklrWWlAMALDLdnn6+0Bi0l+bXrIbYkgIyI94WEybM="; }) ]; </ins> postPatch = '' for f in $(find src/ -type f); do grep -q "/bin/cat" "$f" && substituteInPlace "$f"
Change:
will send emails with in the To: field. For me, this causes rspamd to categorize these emails as spam. Notably, rspamd assigns the following symbols to the mails: Steps to reproduce the behavior: test email, can probably be done by setting in the relevant field if email landed in spam folder (dependent on the spam filter and its configuration) The module sets the To: field to the value of . As far as I can tell, this would solve the problem without any downsides. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result.
can I open a PR changing the line in question to: ? I have tested it locally and it did fix the problem improving the score given by
I forgot this was upstreamed. Feel free to open a PR.

Discussion:
{ ${pkgs.coreutils}/bin/cat << EOF From: smartd on ${host} <${nm.sender}> <del> To: undisclosed-recipients:; </del> <ins> To: ${nm.recipient} </ins> Subject: $SMARTD_SUBJECT $SMARTD_FULLMESSAGE
Change:
Golang releases once every 6 month and supports the latest two releases. These are currently 1.19 was released on 2022/08/02 1.18 was released on 2022/03/15 and will be EOL around 2023/03, two months before 22.11's EOL. Cf.
Besides fixing or pinning broken builds/nixosTests would need to check vendor hashes are reproducible or fix/pin them as well. The PR for 1.18 has more detail about what needs to be done when changing the default :
How do we handle packages pinned with ?
They need to be fixed to not use 1.17 or eventually they'll be marked as broken when 1.17 is removed. Likely that most of the packages still on 1.17 require upstream fixes.
Would we accept a PR that pins every existing user of to and switching the default to on master. This would change the default for new modules and allow piecemeal work on migrating all existing modules. I'm not against a single effort like , but I don't think I could set aside the time to manage something like that, and I'm interested in helping out.
As the two active go maintainers, can both of you clarify whether you will take care of the required update?
I'll do it this week.
I'll count that as a check-in for . Thanks!
I've rechecked vendor hashes after the staging-next merge, no breakage. As hydra catches up I'll continue fixing/pinning any other breakage from 1.19 that I didn't catch initially.
Which version of NixOS Docker image has/will have Go 1.19?
Go 1.19 is on NixOS unstable right now and will be part of NixOS 22.11. I'm not sure about the base of your docker images though.

Discussion:
### DEVELOPMENT / GO # the unversioned attributes should always point to the same go version <del> go = go_1_18; buildGoModule = buildGo118Module; buildGoPackage = buildGo118Package; </del> <ins> go = go_1_19; buildGoModule = buildGo119Module; buildGoPackage = buildGo119Package; </ins> go_1_17 = callPackage ../development/compilers/go/1.17.nix ({ inherit (darwin.apple_sdk.frameworks) Foundation Security;
Change:
Build NixOS with , and journald ends up with a lot of log entries like this:
The service was fixed by in master and in 16.09, though as notes, the riemann-tools package itself ought to be fixed.

Discussion:
systemd.services.riemann-health = { wantedBy = [ "multi-user.target" ]; <ins> path = [ procps ]; </ins> serviceConfig = { User = "riemanntools"; ExecStart = "${healthLauncher}/bin/riemann-health";
Change:
While deploying a machine via deploy-rs, I had this error: Then stop docker or deploy the service from scratch, my belief is that docker-prune can start before docker.service and thus fail since it can't access the docker daemon. No systemd error whatever the configuration. I believe a patch like this should fix it but I am no systemd expert: <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- from blame current unstable
I think the patch you propose makes sense. Could you open an PR for it?

Discussion:
''; startAt = optional cfg.autoPrune.enable cfg.autoPrune.dates; <ins> after = [ "docker.service" ]; requires = [ "docker.service" ]; </ins> }; assertions = [

{ pkgs, ... }: { virtualisation.docker.enable = true; <ins> virtualisation.docker.autoPrune.enable = true; </ins> virtualisation.docker.package = pkgs.docker; users.users = {
Change:
Building this package twice does not produce the bit-by-bit identical result each time, making it harder to detect CI breaches. You can read more about this at https://reproducible- . nix-build '<nixpkgs' -A ... --check --keep-failed You can use to analyze the differences in the output of the two builds. To view the build log of the build that produced the artifact in the binary cache: nix-store --read-log $(nix-instantiate '<nixpkgs' -A ...) Seems to be a file ordering issue while generating : vs
Looks like this list is generated with the standard Ruby function, which in 2.x leaves the sorting up to the filesystem, but from 3.x onwards itself. So perhaps we should just update to Ruby 3.x. In general 2.7 is in mode, so it will only receive security updates and we should probably plan to move things to 3.x

Discussion:
, buildEnv, bundler, bundix , libiconv, libobjc, libunwind, Foundation , makeWrapper, buildRubyGem, defaultGemConfig <del> , baseRuby ? buildPackages.ruby.override { </del> <ins> , baseRuby ? buildPackages.ruby_3_1.override { </ins> useRailsExpress = false; docSupport = false; rubygemsSupport = false;

}@args: let <del> basicEnv = (callPackage ../bundled-common {}) args; </del> <ins> basicEnv = (callPackage ../bundled-common { inherit ruby; }) args; </ins> cmdArgs = removeAttrs args [ "pname" "postBuild" "gemConfig" "passthru" "gemset" "gemdir" ] // { inherit preferLocalBuild allowSubstitutes; # pass the defaults

enableExtraPlugins = true; }; <del> asciidoctor = callPackage ../tools/typesetting/asciidoctor { }; </del> <ins> asciidoctor = callPackage ../tools/typesetting/asciidoctor { bundlerApp = bundlerApp.override { # asciidoc supports both ruby 2 and 3, # but we don't want to be stuck on it: ruby = ruby_3_1; }; }; </ins> asciidoctor-with-extensions = callPackage ../tools/typesetting/asciidoctor-with-extensions { };
Change:
Building this package twice does not produce the bit-by-bit identical result each time, making it harder to detect CI breaches. You can read more about this at https://reproducible- . nix-build '<nixpkgs' -A --check --keep-failed You can use to analyze the differences in the output of the two builds. To view the build log of the build that produced the artifact in the binary cache: nix-store --read-log $(nix-instantiate '<nixpkgs' -A ) Tested on nixpkgs
PR was merged and made it to nixos-unstable, so this should be fixed

Discussion:
{ stdenv, lib, fetchurl, docbook_xsl, docbook_xsl_ns, gettext, libxslt, glibcLocales, docbook_xml_dtd_412, docbook_sgml_dtd_41, texlive, opensp <del> , perl, buildPerlPackage, ModuleBuild, TextWrapI18N, LocaleGettext, TermReadKey, SGMLSpm, UnicodeLineBreak, PodParser, YAMLTiny }: </del> <ins> , perl, buildPerlPackage, ModuleBuild, TextWrapI18N, LocaleGettext, TermReadKey, SGMLSpm, UnicodeLineBreak, PodParser, YAMLTiny , fetchpatch }: </ins> buildPerlPackage rec { pname = "po4a";

url = "https://github.com/mquinson/po4a/releases/download/v${version}/po4a-${version}.tar.gz"; sha256 = "0eb510a66f59de68cf7a205342036cc9fc08b39334b91f1456421a5f3359e68b"; }; <ins> patches = [ (fetchpatch { # make devdoc output reproducible # https://github.com/mquinson/po4a/pull/387 url = "https://github.com/mquinson/po4a/commit/df7433b58f6570558d44b6aac885c2a8f7862e51.patch"; sha256 = "9MVkYiItR2P3PBCUc4OhEOUHQuLqTWUYtYlZ3L8miC8="; }) ]; </ins> nativeBuildInputs = [ docbook_xsl docbook_xsl_ns ModuleBuild ]; propagatedBuildInputs = lib.optional (!stdenv.hostPlatform.isMusl) TextWrapI18N ++ [ LocaleGettext SGMLSpm UnicodeLineBreak PodParser YAMLTiny ]; # TODO: TermReadKey was temporarily removed from propagatedBuildInputs to unfreeze the build
Change:
After updating nix flake inputs, rebuilding with returns the following error: Commenting out the package rebuilds successfully. Steps to reproduce the behavior: ; ; `. succeeds with Slack package. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --The error may got introduced after this . cc Please run and paste the result.

Discussion:
usb_modeswitch = throw "'usb_modeswitch' has been renamed to/replaced by 'usb-modeswitch'"; # Converted to throw 2022-02-22 usbguard-nox = throw "'usbguard-nox' has been renamed to/replaced by 'usbguard'"; # Converted to throw 2022-09-24 util-linuxCurses = util-linux; # Added 2022-04-12 <del> utillinux = throw "'utillinux' has been renamed to/replaced by 'util-linux'"; # Converted to throw 2022-09-24 </del> ### V ###
Change:
OpenSCAD seems to be built without support for PDF exports. (This is a very useful feature to print projections on paper to check the dimensions of a design for example). Version: OpenSCAD version 2021.01 On nixpkgs: master (2022-09-18) Open OpenSCAD Go to File -Export -Export as PDF… Save to some file Observe the following error in the OpenSCAD console: CC package maintainers:
Any idea what dependency they need for PDF? (image file export has been enough for me so I never looked)
I think cairo. (I was looking into this earlier today.)
Yes, cairo was missing:

Discussion:
, wayland , wayland-protocols , qtwayland <ins> , cairo </ins> }: mkDerivation rec {

buildInputs = [ eigen boost glew opencsg cgal mpfr gmp glib harfbuzz lib3mf libzip double-conversion freetype fontconfig <del> qtbase qtmultimedia qscintilla </del> <ins> qtbase qtmultimedia qscintilla cairo </ins> ] ++ lib.optionals stdenv.isLinux [ libGLU libGL wayland wayland-protocols qtwayland ] ++ lib.optional stdenv.isDarwin qtmacextras ++ lib.optional spacenavSupport libspnav
Change:
rst2pdf The usual way of creating PDF from reStructuredText is by going through LaTeX. This tool provides an alternative by producing PDF directly using the ReportLab library. Metadata homepage URL: source URL: license: MIT platforms: unix, linux, darwin, ...
I want to package this - will try to do it in a few hours.

Discussion:
<ins> { lib , buildPythonPackage , fetchPypi , setuptools , docutils , importlib-metadata , jinja2 , packaging , pygments , pyyaml , reportlab , smartypants , pillow , pytestCheckHook , pymupdf , sphinx }: buildPythonPackage rec { pname = "rst2pdf"; version = "0.99"; format = "pyproject"; src = fetchPypi { inherit pname version; sha256 = "8fa23fa93bddd1f52d058ceaeab6582c145546d80f2f8a95974f3703bd6c8152"; }; outputs = [ "out" "man" ]; nativeBuildInputs = [ setuptools ]; propagatedBuildInputs = [ docutils importlib-metadata jinja2 packaging pygments pyyaml reportlab smartypants pillow ]; pythonImportsCheck = [ "rst2pdf" ]; checkInputs = [ pytestCheckHook pymupdf sphinx ]; # Test suite fails: https://github.com/rst2pdf/rst2pdf/issues/1067 doCheck = false; postInstall = '' mkdir -p $man/share/man/man1/ ${docutils}/bin/rst2man.py doc/rst2pdf.rst $man/share/man/man1/rst2pdf.1 ''; meta = with lib; { description = "Convert reStructured Text to PDF via ReportLab"; homepage = "https://rst2pdf.org/"; license = licenses.mit; maintainers = with maintainers; [ marsam ]; }; } </ins>

rst2ansi = callPackage ../development/python-modules/rst2ansi { }; <ins> rst2pdf = callPackage ../development/python-modules/rst2pdf { }; </ins> rstcheck = callPackage ../development/python-modules/rstcheck { }; rstcheck-core = callPackage ../development/python-modules/rstcheck-core { };