jiebi/CodeConvo huggingface dataset:
Change:
The package does not detect the locale for the package to download. The source code attempts to use , but does not detect it, and automatically falls back to . There is also no package option to override the locale. Install , either with nix-env as a normal user, or with , while the locale is set to something other than Please run and paste the results. I made a rather hacky patch to add a locale option to the firefox-bin package (replacing the literal string "en-US", but I would not consider it mergable.
this is related and this PR
The PR was a cleaner version of what I implemented, so I'll mark this as closed when it gets merged. Am So, 24. Mär 2019, um 04:55, schrieb Tomas Hlavaty:
This has been bug for me forever, thank you for reporting. Firefox is always in en-US, regardless of locale for me.
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly: for maintainers and people that previously touched the related code and @ mention them in a comment. on the . on the on .
This is still an issue today.
I marked this as stale due to inactivity. &rarr;

Discussion:
, ffmpeg , runtimeShell , mesa # firefox wants gbm for drm+dmabuf <del> , systemLocale ? config.i18n.defaultLocale or "en-US" </del> <ins> , systemLocale ? config.i18n.defaultLocale or "en_US" </ins> }: let

defaultSource = lib.findFirst (sourceMatches "en-US") {} sources; <del> source = lib.findFirst (sourceMatches systemLocale) defaultSource sources; </del> <ins> mozLocale = if systemLocale == "ca_ES@valencia" then "ca-valencia" else lib.replaceStrings ["_"] ["-"] systemLocale; source = lib.findFirst (sourceMatches mozLocale) defaultSource sources; </ins> pname = "firefox-${channel}-bin-unwrapped";
Change:
repo: originally mentioned at
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly: for maintainers and people that previously touched the related code and @ mention them in a comment. on the . on the on .
still important to me
I marked this as stale due to inactivity. &rarr;
Still important to me
Any progress on this?
There is a PR open at
The PR has sadly been closed :(
I marked this as stale due to inactivity. &rarr;

Discussion:
<ins> { stdenv , lib , fetchFromGitHub , meson , ninja , vala , pkg-config , desktop-file-utils , glib , gtk3 , glib-networking , libgee , libsoup , json-glib , sqlite , webkitgtk , libmanette , libXtst , wrapGAppsHook }: stdenv.mkDerivation rec { pname = "GameHub"; version = "0.16.3-2"; src = fetchFromGitHub { owner = "tkashkin"; repo = pname; rev = "${version}-master"; hash = "sha256-dBGzXwDO9BvnEIcdfqlGnMzUdBqaVA96Ds0fY6eukes="; }; nativeBuildInputs = [ desktop-file-utils meson ninja pkg-config vala wrapGAppsHook ]; buildInputs = [ glib glib-networking gtk3 json-glib libgee libmanette libsoup libXtst sqlite webkitgtk ]; meta = with lib; { homepage = "https://tkashkin.github.io/projects/gamehub"; description = "Unified library for all your games"; longDescription = '' GameHub is a unified library for all your games. It allows you to store your games from different platforms into one program to make it easier for you to manage your games. ''; maintainers = with maintainers; [ pasqui23 ]; license = with licenses; [ gpl3Only ]; platforms = platforms.linux; }; } </ins>

fusionInventory = callPackage ../servers/monitoring/fusion-inventory { }; <ins> gamehub = callPackage ../games/gamehub { }; </ins> gatling = callPackage ../servers/http/gatling { }; gitlab-pages = callPackage ../servers/http/gitlab-pages { };
Change:
My libvirt setup invokes ebtables in the context of the clean-traffic filter and fails because /etc/ethertypes is expected by the ebtables binary. Run system: host os: multi-user?: sandbox: version: channels(root): nixpkgs:
Tracing this a bit further shows that despite the source code of ebtables containing /etc/ethertypes as a string, the ebtables binary doesn't contain "/etc/ethertypes" when being strings-ed. The offending string is hardcoded inside which comes from the iptables derivation. /etc/ethertypes feels like /etc/protocols and /etc/services. Do we want to promote it to that level or do we want to fix the hardcoded path in iptables?
For anyone suffering from this, the workaround is:
Debian 10, KVM, Libvirt...
are you using the service module?
Yes
Why does this add to my system path? I don't see how that's related

Discussion:
# this file is expected in /etc/qemu and not sysconfdir (/var/lib) etc."qemu/bridge.conf".text = lib.concatMapStringsSep "n" (e: "allow ${e}") cfg.allowedBridges; <del> systemPackages = with pkgs; [ libvirt libressl.nc cfg.qemuPackage ]; </del> <ins> systemPackages = with pkgs; [ libvirt libressl.nc iptables cfg.qemuPackage ]; etc.ethertypes.source = "${iptables}/etc/ethertypes"; </ins> }; boot.kernelModules = [ "tun" ];
Change:
, (nixos-unstable, nixos-19.03, nixos-18.09) Scanned versions: nixos-unstable: ; nixos-19.03: ; nixos-18.09: . May contain false positives.

Discussion:
{ config, stdenv, lib, fetchurl, pkgconfig, zlib, expat, openssl, autoconf , libjpeg, libpng, libtiff, freetype, fontconfig, libpaper, jbig2dec <del> , libiconv, ijs, lcms2 </del> <ins> , libiconv, ijs, lcms2, fetchpatch </ins> , cupsSupport ? config.ghostscript.cups or (!stdenv.isDarwin), cups ? null , x11Support ? cupsSupport, xlibsWrapper ? null # with CUPS, X11 only adds very little }:

patches = [ ./urw-font-files.patch ./doc-no-ref.diff <ins> (fetchpatch { name = "CVE-2019-6116"; url = "http://git.ghostscript.com/?p=ghostpdl.git;a=patch;h=d3537a54740d78c5895ec83694a07b3e4f616f61"; sha256 = "1hr8bpi87bbg1kvv28kflmfh1dhzxw66p9q0ddvbrj72qd86p3kx"; }) </ins> ]; outputs = [ "out" "man" "doc" ];
Change:
, (nixos-unstable, nixos-19.03, nixos-18.09) Scanned versions: nixos-unstable: ; nixos-19.03: ; nixos-18.09: . May contain false positives.

Discussion:
{ stdenv, lib, fetchurl, pkgconfig, zlib, expat, openssl, autoconf , libjpeg, libpng, libtiff, freetype, fontconfig, libpaper, jbig2dec <del> , libiconv, ijs </del> <ins> , libiconv, ijs, fetchpatch </ins> , x11Support ? false, xlibsWrapper ? null , cupsSupport ? false, cups ? null }:

patches = [ ./urw-font-files.patch ./doc-no-ref.diff <ins> (fetchpatch { name = "CVE-2019-6116"; url = "http://git.ghostscript.com/?p=ghostpdl.git;a=patch;h=d3537a54740d78c5895ec83694a07b3e4f616f61"; sha256 = "1hr8bpi87bbg1kvv28kflmfh1dhzxw66p9q0ddvbrj72qd86p3kx"; }) </ins> ]; outputs = [ "out" "man" "doc" ];
Change:
, (nixos-unstable, nixos-19.03, nixos-18.09) Scanned versions: nixos-unstable: ; nixos-19.03: ; nixos-18.09: . May contain false positives.

Discussion:
{ config, stdenv, lib, fetchurl, pkgconfig, zlib, expat, openssl, autoconf , libjpeg, libpng, libtiff, freetype, fontconfig, libpaper, jbig2dec <del> , libiconv, ijs </del> <ins> , libiconv, ijs, fetchpatch </ins> , cupsSupport ? config.ghostscript.cups or (!stdenv.isDarwin), cups ? null , x11Support ? cupsSupport, xlibsWrapper ? null # with CUPS, X11 only adds very little }:

patches = [ ./urw-font-files.patch ./doc-no-ref.diff <ins> (fetchpatch { name = "CVE-2019-6116"; url = "http://git.ghostscript.com/?p=ghostpdl.git;a=patch;h=d3537a54740d78c5895ec83694a07b3e4f616f61"; sha256 = "1hr8bpi87bbg1kvv28kflmfh1dhzxw66p9q0ddvbrj72qd86p3kx"; }) </ins> ]; outputs = [ "out" "man" "doc" ];
Change:
If I try to use the grpc package from the current unstable channel, then this builds only the static libraries. I tried to add to the , then cmake tries to build the shared libraries, but fails with the following error: Maybe this is an grpc issue?
I could fix it for me. The build creates a executable, which is linked to . This executable gets then used by protbuf as a plugin to build other stuff. If it gets statically linked, everythings works. But as I try to build it dynamically, it doesn't find the library when protbuf gets executed with the plugin. So I add a hook to set the . Maybe there is a better solution, but this works for me.

Discussion:
{ stdenv, fetchFromGitHub, cmake, zlib, c-ares, pkgconfig, openssl, protobuf, gflags }: stdenv.mkDerivation rec { <del> version = "1.19.0"; </del> <ins> version = "1.19.1"; </ins> name = "grpc-${version}"; src = fetchFromGitHub { owner = "grpc"; repo = "grpc"; rev = "v${version}"; <del> sha256 = "105hvpn2z3qiyc01wyzpmfbrpmy20kz1nb9j1c2s0kz1r0v92gqi"; </del> <ins> sha256 = "0c0jra4qnd86gyr4rlblic3igb5dpgrldac35myk5i5ia547fdhj"; </ins> }; nativeBuildInputs = [ cmake pkgconfig ]; buildInputs = [ zlib c-ares c-ares.cmake-config openssl protobuf gflags ];

"-DgRPC_SSL_PROVIDER=package" "-DgRPC_PROTOBUF_PROVIDER=package" "-DgRPC_GFLAGS_PROVIDER=package" <ins> "-DBUILD_SHARED_LIBS=ON" </ins> ]; # CMake creates a build directory by default, this conflicts with the

rm -vf BUILD ''; <ins> preBuild = '' export LD_LIBRARY_PATH=$(pwd):$LD_LIBRARY_PATH ''; </ins> NIX_CFLAGS_COMPILE = stdenv.lib.optionalString stdenv.cc.isClang "-Wno-error=unknown-warning-option"; enableParallelBuilds = true;
Change:
I tried to create a Docker file using Nix which, in its , just calls . This fails because contains , which, apparently, isn't put into the Docker image. system: host os: multi-user?: sandbox: version: channels(philipp): channels(root): nixpkgs:

Discussion:
<del> { stdenv, fetchurl, steam-run, bash </del> <ins> { stdenv, fetchurl, steam-run, bash, coreutils </ins> , steamRoot ? "~/.local/share/Steam" }:

mkdir -p $out/bin substitute ${./steamcmd.sh} $out/bin/steamcmd  <del> --subst-var shell  </del> --subst-var out  <ins> --subst-var-by coreutils ${coreutils}  </ins> --subst-var-by steamRoot "${steamRoot}"  --subst-var-by steamRun ${steam-run} chmod 0755 $out/bin/steamcmd

# Always run steamcmd in the user's Steam root. STEAMROOT=@steamRoot@ <ins> # Add coreutils to PATH for mkdir, ln and cp used below PATH=$PATH${PATH:+:}@coreutils@/bin </ins> # Create a facsimile Steam root if it doesn't exist. if [ ! -e "$STEAMROOT" ]; then mkdir -p "$STEAMROOT"/{appcache,config,logs,Steamapps/common}
Change:
JupyterHub seems to be broken. Launch JupyterHub and sign in from the browser.

Discussion:
, tornado , traitlets , requests <ins> , notebook </ins> , pythonOlder , nodePackages }:

propagatedBuildInputs = [ alembic ipython jinja2 pamela python-oauth2 requests sqlalchemy tornado <del> traitlets prometheus_client async_generator </del> <ins> traitlets prometheus_client async_generator notebook </ins> ]; # Disable tests because they take an excessive amount of time to complete.
Change:
python36Packages.jsbeautifier build is failing, the same error occurs on master and 19.03. Updating the package does not solve the problem. system: host os: multi-user?: sandbox: version: channels(root): channels(kalbasit): channels(yl): nixpkgs:
/cc maintainer of this package.
This was not happening back in . I believe this started happening with version 1.8.0rc2 when test-packer was introduced upstream.
fixed via

Discussion:
<del> { lib, fetchPypi, buildPythonApplication, EditorConfig, pytest, six }: </del> <ins> { lib, fetchPypi, buildPythonApplication, EditorConfig, fetchpatch, pytest, six }: </ins> buildPythonApplication rec { pname = "jsbeautifier"; <del> version = "1.8.9"; </del> <ins> version = "1.9.1"; </ins> <del> propagatedBuildInputs = [ six ]; buildInputs = [ EditorConfig pytest ]; </del> <ins> propagatedBuildInputs = [ six EditorConfig ]; checkInputs = [ pytest ]; </ins> src = fetchPypi { inherit pname version; <del> sha256 = "7d02baa9b0459bf9c5407c1b99ad5566de04a3b664b18a58ac64f52832034204"; </del> <ins> sha256 = "0q8ld072dkccssagjxyvc9633fb6ynflvz70924phgp3zxmim960"; </ins> }; <ins> patches = [ (fetchpatch { url = "https://github.com/beautify-web/js-beautify/commit/78e35a11cbb805fc044241d6465800ee2bd57ebc.patch"; sha256 = "1ah7nshk96yljy37i20v4fga834dix9cdbhkdc3flfm4904n4523"; }) ]; patchFlags = [ "-p2" ]; </ins> meta = with lib; { homepage    = "http://jsbeautifier.org"; description = "JavaScript unobfuscator and beautifier.";
Change:
Every new firefox update/rebuild generates its own (new) profile. This is annoying, as we rebuild firefox whenever any of its dependencies changes. See: Start with the profile manager or with a custom profile
Should not it be just one profile per branch – one for stable, one for beta, one for nightly? Updating should not change the branch.
I thought that too, but at least for me it created 4 profiles already - could be, that the FF beta is not smart enough (yet). Anyway, now it's documented, so people hopefully won't get as confused as I've been when/if they reproduce this.
Can repro as well. Unfortunate!
Not explicit above, but the workaround is: you see "this firefox uses a fresh profile"... quit firefox profile manager with an older profile and "use as default profile" as normal until the next update
Related issue: and workaround:
Firefox 67 is now the stable release, when I upgraded unstable this morning I got hit with this issue, I'd guess a lot of other folks will shortly as well. Could the SNAP_NAME workaround be incorporated into the derivation until there is a fix from Mozilla? If there is a better fix out there then maybe that.
Just got made aware of the issues as well. I'd sway te SNAP_NAME workaround is okayish for now. I will try to get a patch made so that we do not need that in the future and have a proper kill-switch for that... Sorry for the troubles. I missed that during testing the latest release :'(
I opened a PR to add the workaround Will do the backport as soon as someone else can confirm that it works as expected.
Looks like the more general solution has been merged into Firefox and will be deployed with 68+. From The dedicated profiles feature is off when MOZLEGACY_PROFILES is set to 1 at environment level, while the downgrade protection is still enabled. Probably should coordinate a change to that environment variable name with the release of 68, though it looks like the SNAP version would work for a while after as well.
Can we set in the latest firefox now?
We could do that but that wouldn't work with former ESR / tor browser and probably a few other things. In the long run that probably makes sense. I am not sure it is worth the extra code to use the newer (equivalent) option for newer versions and the old one for older versions. There are constantly users that want older firefox versions because of plugins, java, … so we shouldn't just remove them?!
this hasn't popped up in my daily usage for a while now - please comment/reopen if it's still an issue.

Discussion:
--suffix PATH ':' "$out${browser.execdir or "/bin"}"  --set MOZ_APP_LAUNCHER "${browserName}${nameSuffix}"  --set MOZ_SYSTEM_DIR "$out/lib/mozilla"  <ins> --set SNAP_NAME "firefox"  </ins> ${lib.optionalString gdkWayland '' --set GDK_BACKEND "wayland"  ''}${lib.optionalString (browser ? gtk3)
Change:
During Hackage downtime, nix builds are needlessly broken. There are mirrors available; we should use them. See: Mirrors include: http://objects-us-east- I'm a third party reporting errors I've heard of, so I don't have precise repro steps. Do certain Haskell-related build stuff during Hackage downtime, I guess?
Mirror list is available at E. g. https://objects-us-east-

Discussion:
in stdenv.mkDerivation { name = "hsc3-mode-${version}"; src = fetchurl { <del> url = http://hackage.haskell.org/package/hsc3-0.15/hsc3-0.15.tar.gz; </del> <ins> url = mirror://hackage/hsc3-0.15/hsc3-0.15.tar.gz; </ins> sha256 = "2f3b15655419cf8ebe25ab1c6ec22993b2589b4ffca7c3a75ce478ca78a0bde6"; <del> }; </del> <ins> }; </ins> buildInputs = [ emacs ];

hackage = [ http://hackage.haskell.org/package/ http://hdiff.luite.com/packages/archive/package/ <ins> http://hackage.fpcomplete.com/package/ http://objects-us-east-1.dream.io/hackage-mirror/package/ </ins> ]; # Roy marples mirrors

binDir = if enableSeparateBinOutput then "$bin/bin" else "$out/bin"; <del> newCabalFileUrl = "http://hackage.haskell.org/package/${pname}-${version}/revision/${revision}.cabal"; </del> <ins> newCabalFileUrl = "mirror://hackage/${pname}-${version}/revision/${revision}.cabal"; </ins> newCabalFile = fetchurl { url = newCabalFileUrl; sha256 = editedCabalFile;

callHackageDirect = {pkg, ver, sha256}@args: let pkgver = "${pkg}-${ver}"; in self.callCabal2nix pkg (pkgs.fetchzip { <del> url = "http://hackage.haskell.org/package/${pkgver}/${pkgver}.tar.gz"; </del> <ins> url = "mirror://hackage/${pkgver}/${pkgver}.tar.gz"; </ins> inherit sha256; });
Change:
After switching to 19.03, krunner-pass failed to build on 19.03, it is failing with: Please run and paste the results. system: host os: multi-user?: sandbox: version: channels(root): channels(myuser): nixpkgs:
Upstream issue here looks like the same problem Needs a patch in the probably.

Discussion:
<del> { mkDerivation, stdenv, fetchFromGitHub, cmake, extra-cmake-modules, gnumake, </del> <ins> { mkDerivation, lib, fetchFromGitHub, fetchpatch, cmake, extra-cmake-modules , kauth, krunner , pass, pass-otp ? null }: </ins> <del> pass, pass-otp ? null, krunner, }: let </del> <ins> mkDerivation rec { </ins> pname = "krunner-pass"; version = "1.3.0"; <del> in mkDerivation rec { name = "${pname}-${version}"; </del> src = fetchFromGitHub { owner = "akermu";

}; buildInputs  = [ <del> pass pass-otp krunner </del> <ins> kauth krunner pass pass-otp </ins> ]; <del> nativeBuildInputs = [cmake extra-cmake-modules gnumake]; </del> <ins> nativeBuildInputs = [ cmake extra-cmake-modules ]; </ins> patches = [ <ins> (fetchpatch { url = https://github.com/peterhoeg/krunner-pass/commit/be2695f4ae74b0cccec8294defcc92758583d96b.patch; sha256 = "098dqnal57994p51p2srfzg4lgcd6ybp29h037llr9cdv02hdxvl"; name = "fix_build.patch"; }) </ins> ./pass-path.patch ]; CXXFLAGS = [ <del> ''-DNIXPKGS_PASS="${stdenv.lib.getBin pass}/bin/pass"'' </del> <ins> ''-DNIXPKGS_PASS="${lib.getBin pass}/bin/pass"'' </ins> ]; <del> meta = with stdenv.lib; { </del> <ins> meta = with lib; { </ins> description = "Integrates krunner with pass the unix standard password manager (https://www.passwordstore.org/)"; homepage = https://github.com/akermu/krunner-pass; license = licenses.gpl3;
Change:
Hi, I'm trying to execute a fish script which runs fine on my local machine on NixOS, but fails in a NixOS docker. fish --version works in the docker and returns 3.0.2, but attempting to run a script results in many lines of the form. Full Log here: Any script will fail with a segfault. Something as simple as will fail.
The fact that it segfaults sounds liker a fish bug to me. With bash, I get this:
I don't really understand what you've said. What are you comparing with bash?
The fact that it segfaults sounds liker a fish bug to me The important part is that there's an infinite recursion here, which is bogus and needs to be removed. How fish handles this form of infinite recursion is a secondary issue - even if it just errored, it would still be a bug in the nix package to have it in the first place.
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly: for maintainers and people that previously touched the related code and @ mention them in a comment. on the . on the on .
I checked that did not check the docker case, but it should also fix that.

Discussion:
#     source both, but source the more global configuration files earlier #     than the more local ones, so that more local configurations inherit #     from but override the more global locations. <ins> # #     Special care needs to be taken, when fish is called from an FHS user env #     or similar setup, because this configuration file will then be relocated #     to /etc/fish/config.fish, so we test for this case to avoid nontermination. </ins> <del> if test -f /etc/fish/config.fish </del> <ins> if test -f /etc/fish/config.fish && test /etc/fish/config.fish != (status filename) </ins> source /etc/fish/config.fish end
Change:
The module fails to evaluate since we are calling without a required argument. caused the regression. I'm not sure how to fix this. Please run and paste the results.

Discussion:
# Create the tarball system.build.tarball = import ../../../lib/make-system-tarball.nix { <del> inherit (pkgs) stdenv perl xz pathsFromGraph; </del> <ins> inherit (pkgs) stdenv closureInfo pixz; </ins> inherit (config.tarball) contents storeContents; };
Change:
There seems to be even more wrong with openldap as mentioned in When I declare openldap as follows: The service won't start due to: Shouldn't the be linked to /etc? It is not.
Set to something else:
Still not working:
I guess you have to create this directory with proper permissions. And yeah, I wouldn't use /var/run for databases. ;-)
Hmm, looking at the module I would suggest using . This directory is automatically created by systemd service and gets the right permissions.

Discussion:
services.openldap = { enable = mkOption { <ins> type = types.bool; </ins> default = false; description = " Whether to enable the ldap server.

}; user = mkOption { <ins> type = types.string; </ins> default = "openldap"; description = "User account under which slapd runs."; }; group = mkOption { <ins> type = types.string; </ins> default = "openldap"; description = "Group account under which slapd runs."; }; <ins> dataDir = mkOption { type = types.string; default = "/var/db/openldap"; description = "The database directory."; }; </ins> extraConfig = mkOption { <ins> type = types.lines; </ins> default = ""; description = " sldapd.conf configuration

preStart = '' mkdir -p /var/run/slapd chown -R ${cfg.user}:${cfg.group} /var/run/slapd <del> mkdir -p /var/db/openldap chown -R ${cfg.user}:${cfg.group} /var/db/openldap </del> <ins> mkdir -p ${cfg.dataDir} chown -R ${cfg.user}:${cfg.group} ${cfg.dataDir} </ins> ''; <del> serviceConfig.ExecStart = "${openldap}/libexec/slapd -u openldap -g openldap -d 0 -f ${configFile}"; </del> <ins> serviceConfig.ExecStart = "${openldap}/libexec/slapd -u ${cfg.user} -g ${cfg.group} -d 0 -f ${configFile}"; </ins> }; <del> users.extraUsers = optionalAttrs (cfg.user == "openldap") (singleton { name = "openldap"; </del> <ins> users.extraUsers.openldap = { name = cfg.user; </ins> group = cfg.group; uid = config.ids.uids.openldap; <del> }); </del> <ins> }; </ins> <del> users.extraGroups = optionalAttrs (cfg.group == "openldap") (singleton { name = "openldap"; </del> <ins> users.extraGroups.openldap = { name = cfg.group; </ins> gid = config.ids.gids.openldap; <del> }); </del> <ins> }; </ins> }; }