jiebi/CodeConvo huggingface dataset:
Change:
Package name: Latest released version: 3.5 <!-- Search your package here: --- Current version on the unstable channel: 3.2 Current version on the stable/release channel: 3.2 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Discussion:
{ lib <del> , fetchFromGitHub </del> <ins> , fetchurl </ins> , fetchpatch , python3Packages , gnupg

python3Packages.buildPythonApplication rec { pname = "pass-import"; <del> version = "3.2"; </del> <ins> version = "3.5"; </ins> <del> src = fetchFromGitHub { owner = "roddhjav"; repo = "pass-import"; rev = "v${version}"; sha256 = "0hrpg7yiv50xmbajfy0zdilsyhbj5iv0qnlrgkfv99q1dvd5qy56"; </del> <ins> src = fetchurl { url = "https://github.com/roddhjav/${pname}/releases/download/v${version}/${pname}-${version}.tar.gz"; hash = "sha256-+wrff3OxPkAGu1Mn4Kl0KN4FmvIAb+MnaERcD5ScDNc="; </ins> }; <del> patches = [ (fetchpatch { name = "support-for-pykeepass-4.0.3.patch"; url = "https://github.com/roddhjav/pass-import/commit/f1b167578916d971ee4f99be99ba0e86ef49015e.patch"; hash = "sha256-u6bJbV3/QTfRaPauKSyCWNodpy6CKsreMXUZWKRbee0="; }) ]; </del> propagatedBuildInputs = with python3Packages; [ cryptography defusedxml <ins> jsonpath-ng </ins> pyaml pykeepass python-magic # similar API to "file-magic", but already in nixpkgs. <ins> requests </ins> secretstorage <ins> zxcvbn </ins> ]; nativeCheckInputs = [

postInstall = '' mkdir -p $out/lib/password-store/extensions <del> cp ${src}/import.bash $out/lib/password-store/extensions/import.bash </del> <ins> cp import.bash $out/lib/password-store/extensions/import.bash </ins> wrapProgram $out/lib/password-store/extensions/import.bash  --prefix PATH : "${python3Packages.python.withPackages (_: propagatedBuildInputs)}/bin"  --prefix PYTHONPATH : "$out/${python3Packages.python.sitePackages}"  --run "export PREFIX" <del> cp -r ${src}/share $out/ </del> <ins> cp -r share $out/ </ins> ''; postCheck = ''
Change:
Currently it's only possible to configure kanata by specifying specific parts one at a time. It's not possible to read a configuration from a file and use that instead of the specific parts. I use HomeManager to manage the kanata configuration file and because it's also used for Windows this is the most platform neutral way for me without duplicating parts of the configuration. As a workaround I did it like this for now: But clearly that is not ideal. What I would want is to just keep the 'readFile' and uncomment the 'defcfg' part from the configuration file ()
I created to address this issue. Could you help test it?
Thanks a lot for the fast solution! I tested it with my config and it works without any issues.

Discussion:
upstreamDoc = "See [the upstream documentation](https://github.com/jtroo/kanata/blob/main/docs/config.adoc) and [example config files](https://github.com/jtroo/kanata/tree/main/cfg_samples) for more information."; <del> keyboard = { </del> <ins> keyboard = { name, config, ... }: { </ins> options = { devices = mkOption { type = types.listOf types.str;

${upstreamDoc} ''; }; <ins> configFile = mkOption { type = types.path; default = mkConfig name config; defaultText = "A config file generated by values from other kanata module options."; description = '' The config file. By default, it is generated by values from other kanata module options. You can also set it to your own full config file which overrides all other kanata module options.  ${upstreamDoc} ''; }; </ins> extraArgs = mkOption { type = types.listOf types.str; default = [ ];

${keyboard.config} ''; <ins> # Only the config file generated by this module is checked.  A # user-provided one is not checked because it may not be available # at build time.  I think this is a good balance between module # complexity and functionality. </ins> checkPhase = '' ${getExe cfg.package} --cfg "$target" --check --debug '';

Type = "notify"; ExecStart = '' ${getExe cfg.package}  <del> --cfg ${mkConfig name keyboard}  </del> <ins> --cfg ${keyboard.configFile}  </ins> --symlink-path ''${RUNTIME_DIRECTORY}/${name}  ${optionalString (keyboard.port != null) "--port ${toString keyboard.port}"}  ${utils.escapeSystemdExecArgs keyboard.extraArgs}
Change:
Project description <!-- Describe the project a little: --Metadata homepage URL: source URL: none license: unfree platforms: unix, linux, darwin Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Discussion:
<ins> { lib, appimageTools, fetchurl, }: let pname = "heptabase"; version = "1.35.3"; src = fetchurl { url = "https://github.com/heptameta/project-meta/releases/download/v${version}/Heptabase-${version}.AppImage"; hash = "sha256-2HEBQI+C/LKrIUb+6qNmm+xjvTOxS+vk5WTsOZKz3+s="; }; appimageContents = appimageTools.extractType2 { inherit pname version src; }; in appimageTools.wrapType2 { inherit pname version src; extraInstallCommands = '' install -Dm444 ${appimageContents}/project-meta.desktop -T $out/share/applications/heptabase.desktop install -m 444 -D ${appimageContents}/usr/share/icons/hicolor/0x0/apps/project-meta.png $out/share/icons/hicolor/512x512/apps/${pname}.png substituteInPlace $out/share/applications/heptabase.desktop  --replace-fail 'Exec=AppRun --no-sandbox %U' 'Exec=heptabase %U'  --replace-fail 'Icon=project-meta' 'Icon=${pname}' ''; meta = { changelog = "https://github.com/heptameta/project-meta/releases/tag/v${version}"; description = "A visual note-taking tool for learning complex topics"; homepage = "https://heptabase.com/"; license = lib.licenses.unfree; maintainers = with lib.maintainers; [ luftmensch-luftmensch ]; mainProgram = "heptabase"; platforms = [ "x86_64-linux" ]; sourceProvenance = with lib.sourceTypes; [ binaryNativeCode ]; }; } </ins>
Change:
-build -A ! Logs: I'm out of context on this. This seems too fundamental to be broken. It is breaking all NixOS tests? Nginx test also fails the same. I could not build using: ! CC Update: Bisect answer was
!
Oh, that was quick, I'm still building ruff on my machine...
A solution has been found is preparing the PR.

Discussion:
class JunitXMLLogger(AbstractLogger): class TestCaseState: def __init__(self) -> None: self.stdout = ""

def __init__(self, outfile: str) -> None: self.logfile_handle = codecs.open(outfile, "wb") self.xml = XMLGenerator(self.logfile_handle, encoding="utf-8") <del> self.queue: "Queue[Dict[str, str]]" = Queue() </del> <ins> self.queue: Queue[dict[str, str]] = Queue() </ins> self._print_serial_logs = True
Change:
and are listed as code owners for . That means they are requested for review whenever a new maintainer is to the list. Last matching pattern is used, so if is on its own line without any users, this would be fixed. Feel free to close if this is intended.
Is there a way to specify any empty list of reviewers? Otherwise, we could make it a bot, which checks that the patch is only adding lines, and that the files evaluate properly.
I think just listing no users would work but to make sure that it parses user can be .

Discussion:
# Eclipse /pkgs/applications/editors/eclipse @rycee <ins> # https://github.com/NixOS/nixpkgs/issues/31401 /lib/maintainers.nix @ghost </ins>
Change:
Podman exits with an error on unstable. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Hmm. I can't seem to reproduce this (also on 24.05..). How is your podman installed?
Just for reference mine is: virtualisation = { podman = { enable = true; dockerCompat = true; }; }; The only thing I can think of is to try removing the line to see if that is what is causing the issue?
Found the culprit. I recently tried Deepin which uses dde-daemon. dde-daemon creates . Removing altogether makes podman work again. A fix was introduced in but got reverted in for some reason. ?
Sorry, this is a mistake. I lost a patch when upgrading dde-daemon, should fix in

Discussion:
postPatch = '' substituteInPlace session/eventlog/{app_event.go,login_event.go}  <del> --replace "/bin/bash" "${runtimeShell}" </del> <ins> --replace-fail "/bin/bash" "${runtimeShell}" </ins> substituteInPlace inputdevices/layout_list.go  <del> --replace "/usr/share/X11/xkb" "${xkeyboard_config}/share/X11/xkb" </del> <ins> --replace-fail "/usr/share/X11/xkb" "${xkeyboard_config}/share/X11/xkb" </ins> <del> substituteInPlace bin/dde-system-daemon/wallpaper.go accounts1/user.go  --replace "/usr/share/wallpapers" "/run/current-system/sw/share/wallpapers" </del> <ins> substituteInPlace accounts1/user.go  --replace-fail "/usr/share/wallpapers" "/run/current-system/sw/share/wallpapers" </ins> substituteInPlace timedate1/zoneinfo/zone.go  <del> --replace "/usr/share/dde" "$out/share/dde"  --replace "/usr/share/zoneinfo" "${tzdata}/share/zoneinfo" </del> <ins> --replace-fail "/usr/share/dde" "$out/share/dde"  --replace-fail "/usr/share/zoneinfo" "${tzdata}/share/zoneinfo" </ins> substituteInPlace accounts1/image_blur.go grub2/modify_manger.go  <del> --replace "/usr/lib/deepin-api" "/run/current-system/sw/lib/deepin-api" </del> <ins> --replace-fail "/usr/lib/deepin-api" "/run/current-system/sw/lib/deepin-api" </ins> substituteInPlace accounts1/user_chpwd_union_id.go  <del> --replace "/usr/lib/dde-control-center" "/run/current-system/sw/lib/dde-control-center" </del> <ins> --replace-fail "/usr/lib/dde-control-center" "/run/current-system/sw/lib/dde-control-center" substituteInPlace system/uadp1/crypto.go  --replace-fail "/usr/share/uadp" "/var/lib/dde-daemon/uadp" </ins> for file in $(grep "/usr/lib/deepin-daemon" * -nR |awk -F: '{print $1}') do
Change:
Steps to reproduce the behavior: Add any other context about the problem here. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
This looks to me like the compiler wrapper isn't respecting and/or , and it's inappropriately passing the libunwind shared object. I don't have immediate time to investigate further but did discover this minimal reproducer:
looks the same as which is due to (search path prefers .so files with ). i agree that passing in libunwind unconditionally seems not good. if one builds libcxx with the linker script at will result in but we don't so we add unconditionally. it is not clear to me why c code needs libunwind.

Discussion:
bridge-utils = callPackage ../os-specific/linux/bridge-utils { }; <del> busybox = callPackage ../os-specific/linux/busybox { }; </del> <ins> busybox = callPackage ../os-specific/linux/busybox { # Fixes libunwind from being dynamically linked to a static binary. stdenv = if (stdenv.targetPlatform.useLLVM or false) then overrideCC stdenv buildPackages.llvmPackages.clangNoLibcxx else stdenv; }; </ins> busybox-sandbox-shell = callPackage ../os-specific/linux/busybox/sandbox-shell.nix { # musl roadmap has RISC-V support projected for 1.1.20 busybox = if !stdenv.hostPlatform.isRiscV && !stdenv.hostPlatform.isLoongArch64 && stdenv.hostPlatform.libc != "bionic"
Change:
When installing a PWA using the Floorp browser (experimental toggle in settings), the installed desktop file uses /usr/bin/floorp as the path for the browser to run said PWA. Steps to reproduce the behavior: Floorp experimental PWAs in settings a PWA, e.g. Github or Excalidraw the newly spawned PWA window to launch the same PWA from your DE's application launcher The PWA opens. ! , using flakes, installed via <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Thanks for reporting! As well as the upstream report! I can look into it what we can do as I get time. But as I'm the only maintainer for Floorp and currently pretty much out of time due to university and $dayjob, I cannot promise any timeline unfortunately. But happy to review patches, of course, if you'd like to fix it yourself. Can you provide such a generated file for further investigation?
sure, one such generated desktop file with the example of excalidraw can be found (github doesn't allow for drag and drop of .desktop files)
Hello! I don't have experience maintaining and modifying large packages like Firefox (floorp), and I currently don't have much free time. However, I've discovered how floorp generates the .desktop file for PWA applications: Maybe it will be helpful to you.
Thanks, that is indeed helpful! Should be relatively easy patchable by us then, from the looks of it.
upstream has and now it will use the path it was in at the time of creating the PWA. It may not be too big of an issue if what they say about fixing it in the next version is true but now the patching will probably fail.

Discussion:
((buildMozillaMach rec { pname = "floorp"; <del> packageVersion = "11.13.3"; </del> <ins> packageVersion = "11.14.1"; </ins> applicationName = "Floorp"; binaryName = "floorp"; branding = "browser/branding/official";

allowAddonSideload = true; # Must match the contents of `browser/config/version.txt` in the source tree <del> version = "115.12.0"; </del> <ins> version = "115.13.0"; </ins> src = fetchFromGitHub { owner = "Floorp-Projects"; repo = "Floorp"; fetchSubmodules = true; rev = "v${packageVersion}"; <del> hash = "sha256-9EDTVckSqv/nyDi4qjMd54I69WiqM8v6om7zQLT+pQc="; </del> <ins> hash = "sha256-PhI+hIypPF6W5RJIXhCAXblSJNwgYavfCgdQozDSXG0="; </ins> }; extraConfigureFlags = [

"--with-unsigned-addon-scopes=app,system" ]; <ins> extraPostPatch = '' # Fix .desktop files for PWAs generated by Floorp; they hardcode /usr/bin # https://github.com/NixOS/nixpkgs/issues/314115 substituteInPlace floorp/browser/base/content/modules/ssb/LinuxSupport.mjs  --replace-fail /usr/bin/floorp floorp ''; </ins> updateScript = ./update.sh; meta = {
Change:
Going by , I would not trust to work reliably with a different version of the Nvidia driver. It may happen to work with some version combinations if the protocol versions happen to match, but could break at any time if an update makes the protocols not match.
I should have looked at the history before posting my previous comment. The comment has not changed since at least , so it is quite stable. The also appears to be between client and , rather than between the library and the driver.
If we confirm this to work, I'd suggest we move into a separate package in , except that we write it in a generic manner so that each variant of can override it with different sources

Discussion:
KERNEL=="nvidia_uvm", RUN+="${pkgs.runtimeShell} -c 'mknod -m 666 /dev/nvidia-uvm-tools c $$(grep nvidia-uvm /proc/devices | cut -d   -f 1) 1'" ''; hardware.opengl = { <del> extraPackages = [ nvidia_x11.out ] ++ (lib.optional (builtins.hasAttr "libXNVCtrl" nvidia_x11.settings) nvidia_x11.settings.libXNVCtrl); </del> <ins> extraPackages = [ nvidia_x11.out ]; </ins> extraPackages32 = [ nvidia_x11.lib32 ]; }; environment.systemPackages = [ nvidia_x11.bin ];

substituteInPlace $out/share/vulkan/implicit_layer.d/MangoHud.${layerPlatform}.json  --replace "VK_LAYER_MANGOHUD_overlay" "VK_LAYER_MANGOHUD_overlay_${toString stdenv.hostPlatform.parsed.cpu.bits}" '' + '' <del> # Add OpenGL driver path to RUNPATH to support NVIDIA cards </del> <ins> # Add OpenGL driver and libXNVCtrl paths to RUNPATH to support NVIDIA cards </ins> addOpenGLRunpath "$out/lib/mangohud/libMangoHud.so" <ins> patchelf --add-rpath ${libXNVCtrl}/lib "$out/lib/mangohud/libMangoHud.so" </ins> '' + lib.optionalString gamescopeSupport '' addOpenGLRunpath "$out/bin/mangoapp" '' + lib.optionalString finalAttrs.finalPackage.doCheck ''
Change:
Package name: Lutris Latest released version: 0.5.17Current version on the unstable channel: 0.5.16 Current version on the stable/release channel: 0.5.14 <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. -- Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Discussion:
in buildPythonApplication rec { pname = "lutris-unwrapped"; <del> version = "0.5.16"; </del> <ins> version = "0.5.17"; </ins> src = fetchFromGitHub { owner = "lutris"; repo = "lutris"; rev = "v${version}"; <del> hash = "sha256-Ed1bhugBe97XmY050A5jCPcnLj0Fd7qPX2p/Ab+YbOE="; </del> <ins> hash = "sha256-Tr5k5LU0s75+1B17oK8tlgA6SlS1SHyyLS6UBKadUmw="; </ins> }; nativeBuildInputs = [ wrapGAppsHook3 gobject-introspection ];

postPatch = '' substituteInPlace lutris/util/magic.py  <del> --replace "'libmagic.so.1'" "'${lib.getLib file}/lib/libmagic.so.1'" </del> <ins> --replace '"libmagic.so.1"' "'${lib.getLib file}/lib/libmagic.so.1'" </ins> ''; nativeCheckInputs = [ xvfb-run nose2 flake8 ] ++ requiredTools;
Change:
Package name: gpt4all Latest released version: 2.8.0 <!-- Search your package here: --- Current version on the unstable channel: 2.7.5 Current version on the stable/release channel: N/A <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- Notify maintainers <!-- If the result shows no maintainers, tag the person that last updated the package. --Note for maintainers: Please tag this issue in your PR. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Discussion:
{ lib <ins> , config </ins> , stdenv , fetchFromGitHub , cmake

, shaderc , vulkan-headers , wayland <ins> , cudaSupport ? config.cudaSupport , cudaPackages ? { } </ins> }: stdenv.mkDerivation (finalAttrs: { pname = "gpt4all"; <del> version = "2.7.5"; </del> <ins> version = "2.8.0"; </ins> src = fetchFromGitHub { fetchSubmodules = true; <del> hash = "sha256-i/T6gk8ICneW624008eiStgYNv5CE8w0Yx8knk57EFw="; </del> <ins> hash = "sha256-aSz37+1K26Xizf4cpV45a2DnSsl959VQok/ppFRk/hs="; </ins> owner = "nomic-ai"; repo = "gpt4all"; rev = "v${finalAttrs.version}";

nativeBuildInputs = [ cmake qt6.wrapQtAppsHook <ins> ] ++ lib.optionals cudaSupport [ cudaPackages.cuda_nvcc </ins> ]; buildInputs = [

shaderc vulkan-headers wayland <del> ]; </del> <ins> ] ++ lib.optionals cudaSupport ( with cudaPackages; [ cuda_cccl.dev cuda_cudart.dev cuda_cudart.lib cuda_cudart.static libcublas.dev libcublas.lib ]); </ins> cmakeFlags = [ "-DKOMPUTE_OPT_USE_BUILT_IN_VULKAN_HEADER=OFF" "-DKOMPUTE_OPT_DISABLE_VULKAN_VERSION_CHECK=ON" "-DKOMPUTE_OPT_USE_BUILT_IN_FMT=OFF" <ins> ] ++ lib.optionals (!cudaSupport) [ "-DLLMODEL_CUDA=OFF" </ins> ]; postInstall = ''

gparted = callPackage ../tools/misc/gparted { }; <ins> gpt4all-cuda = gpt4all.override { cudaSupport = true; }; </ins> gpt2tc = callPackage ../tools/text/gpt2tc { }; gptcommit = callPackage ../development/tools/gptcommit {
Change:
A clear and concise description of what the bug is. raise Steps to reproduce the behavior: add ... ... A clear and concise description of what you expected to happen. If applicable, add screenshots to help explain your problem. Add any other context about the problem here. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:

Discussion:
# cfg.configFile contains secrets such as proxy servers' credential! # we dont want plaintext secrets in world-readable `/nix/store`. <del> { lib , config , pkgs , ... </del> <ins> { lib, config, pkgs, ... </ins> }: let cfg = config.services.mihomo;

package = lib.mkPackageOption pkgs "mihomo" { }; configFile = lib.mkOption { <del> default = null; </del> type = lib.types.nullOr lib.types.path; description = "Configuration file to use."; };

ExecStart = lib.concatStringsSep " " [ (lib.getExe cfg.package) "-d /var/lib/private/mihomo" <del> (lib.optionalString (cfg.configFile != null) "-f ${CREDENTIALS_DIRECTORY}/config.yaml") </del> <ins> "-f ${CREDENTIALS_DIRECTORY}/config.yaml" </ins> (lib.optionalString (cfg.webui != null) "-ext-ui ${cfg.webui}") (lib.optionalString (cfg.extraOpts != null) cfg.extraOpts) ];
Change:
The scripts from ` contained she bangs that are not patched: This makes XeLatex build like defined here () fails with: I don't know how to trigger the call of this scripts exactly, but in should fail in any sandboxed environment that call these scripts. System: NixOS: 18.03pre119383. (Impala) Nix version: nix-env (Nix) 1.11.15 Nixpkgs version: 18.03pre119383. Sandboxing enabled: build-use-sandbox = true
Is this still an issue on master (which has texlive 2017)?
Yes, still there. You check it using grep:
Hmm, using the linked MWE works fine for me. I notice above--can you post a new MWE that demonstrates the issue? Actually, ha! I found this in my one of my own local repositories for my slides (I notice in your first post): So, that should at least give you a reasonable workaround; it was enough to point me to the problem. I'll be submitting a PR to address this shortly.
It only happen sometimes when xelatex decides internally to use one of the impacted scripts. I don't know how to trigger this with a simple example, I tried but without success...

Discussion:
# remove dependency-heavy packages from the basic collections collection-basic = orig.collection-basic // { <del> deps = removeAttrs orig.collection-basic.deps [ "luatex" "metafont" "xdvi" ]; }; latex = orig.latex // { deps = removeAttrs orig.latex.deps [ "luatex" ]; </del> <ins> deps = removeAttrs orig.collection-basic.deps [ "metafont" "xdvi" ]; </ins> }; # add them elsewhere so that collections cover all packages <del> collection-luatex = orig.collection-luatex // { deps = orig.collection-luatex.deps // { inherit (tl) luatex; }; }; </del> collection-metapost = orig.collection-metapost // { deps = orig.collection-metapost.deps // { inherit (tl) metafont; }; };
Change:
I get this error: while trying to evaluate nixpkgs.rPackages (). /cc System: (NixOS: , Ubuntu/Fedora: , ...) macOS Nix version: (run ) nix-env (Nix) 1.11.15 Nixpkgs version: (run ) 03pre119383. Sandboxing enabled: (run ) no
have the same problem but on linux

Discussion:
rtfbs = [ pkgs.zlib pkgs.pcre.dev pkgs.bzip2 pkgs.gzip pkgs.readline ]; rtiff = [ pkgs.libtiff.dev ]; runjags = [ pkgs.jags ]; <del> RSymphony = [ pkgs.symphony ]; </del> RVowpalWabbit = [ pkgs.zlib.dev pkgs.boost ]; rzmq = [ pkgs.zeromq3 ]; SAVE = [ pkgs.zlib pkgs.bzip2 pkgs.icu pkgs.lzma pkgs.pcre ];