Change:
The czkawka package is missing ffmpeg as a dependency. If ffmpeg is not found you get this error when trying to compare video files: Ignore the snap part, it throws this error when it can't find ffmpeg, regardless if snap or not. 't have ffmpeg installed on you system. comparing videos in czkawka throws error ffmpeg error. Just works. No error. Just works. First issue I've reported here, hopefully I'm doing this right. <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. --Please run and paste the result. Add a :+1: [reaction] to [issues you find important]. [reaction]: [issues you find important]:
Before I propose any changes, let me know a thing or two. When you install both ffmpeg and czkawka, then czkawka finds ffmpeg, correct?
Correct. It finds it no problem.

Discussion:
<ins> diff --git a/Cargo.lock b/Cargo.lock index 5ae2bd6..e4c6f18 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -5676,9 +5676,9 @@ dependencies = [ [[package]] name = "time" -version = "0.3.34" +version = "0.3.36" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "c8248b6521bb14bc45b4067159b9b6ad792e2d6d754d6c41fb50e29fefe38749" +checksum = "5dfd88e563464686c916c7e46e623e520ddc6d79fa6641390f2e3fa86e83e885" dependencies = [ "deranged", "itoa", @@ -5699,9 +5699,9 @@ checksum = "ef927ca75afb808a4d64dd374f00a2adf8d0fcff8e7b184af886c3c87ec4a3f3" [[package]] name = "time-macros" -version = "0.2.17" +version = "0.2.18" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "7ba3a3ef41e6672a2f0f001392bb5dcd3ff0a9992d618ca761a11c3121547774" +checksum = "3f252a68540fde3a3877aeea552b832b40ab9a69e318efd078774a01ddee1ccf" dependencies = [ "num-conv", "time-core", </ins>

<del> { lib , stdenv , atk , cairo , czkawka , darwin , fetchFromGitHub , gdk-pixbuf , glib , gobject-introspection , gtk4 , pango , overrideSDK , pkg-config , rustPlatform , testers , wrapGAppsHook4 , xvfb-run </del> <ins> { lib, atk, cairo, callPackage, darwin, fetchFromGitHub, gdk-pixbuf, glib, gobject-introspection, gtk4, overrideSDK, pango, pkg-config, rustPlatform, stdenv, testers, wrapGAppsHook4, xvfb-run, </ins> }: let <del> pname = "czkawka"; version = "7.0.0"; src = fetchFromGitHub { owner = "qarmin"; repo = "czkawka"; rev = version; hash = "sha256-SOWtLmehh1F8SoDQ+9d7Fyosgzya5ZztCv8IcJZ4J94="; }; cargoPatches = [ ./time.patch ]; cargoHash = "sha256-cQv8C0P3xizsvnJODkTMJQA98P4nYSCHFT75isJE6es="; </del> buildRustPackage' = rustPlatform.buildRustPackage.override { stdenv = if stdenv.isDarwin then overrideSDK stdenv "11.0" else stdenv; }; <del> in buildRustPackage' { inherit pname version src cargoPatches cargoHash; nativeBuildInputs = [ gobject-introspection pkg-config wrapGAppsHook4 ]; </del> <ins> self = buildRustPackage' { pname = "czkawka"; version = "7.0.0"; </ins> <del> buildInputs = [ atk cairo gdk-pixbuf glib gtk4 pango ] ++ lib.optionals stdenv.hostPlatform.isDarwin (with darwin.apple_sdk.frameworks; [ Foundation AppKit ]); </del> <ins> src = fetchFromGitHub { owner = "qarmin"; repo = "czkawka"; rev = self.version; hash = "sha256-SOWtLmehh1F8SoDQ+9d7Fyosgzya5ZztCv8IcJZ4J94="; }; </ins> <del> nativeCheckInputs = [ xvfb-run ]; </del> <ins> cargoPatches = [ # Updates time and time-macros from Cargo.lock ./0000-time.diff ]; </ins> <del> strictDeps = true; </del> <ins> cargoHash = "sha256-cQv8C0P3xizsvnJODkTMJQA98P4nYSCHFT75isJE6es="; </ins> <del> checkPhase = '' runHook preCheck xvfb-run cargo test runHook postCheck ''; </del> <ins> nativeBuildInputs = [ gobject-introspection pkg-config wrapGAppsHook4 ]; </ins> <del> doCheck = stdenv.hostPlatform.isLinux && (stdenv.hostPlatform == stdenv.buildPlatform); </del> <ins> buildInputs = [ atk cairo gdk-pixbuf glib gtk4 pango ] ++ lib.optionals stdenv.hostPlatform.isDarwin ( with darwin.apple_sdk.frameworks; [ AppKit Foundation ] ); </ins> <del> passthru.tests.version = testers.testVersion { package = czkawka; command = "czkawka_cli --version"; }; </del> <ins> nativeCheckInputs = [ xvfb-run ]; </ins> <del> # Desktop items, icons and metainfo are not installed automatically postInstall = '' install -Dm444 -t $out/share/applications data/com.github.qarmin.czkawka.desktop install -Dm444 -t $out/share/icons/hicolor/scalable/apps data/icons/com.github.qarmin.czkawka.svg install -Dm444 -t $out/share/icons/hicolor/scalable/apps data/icons/com.github.qarmin.czkawka-symbolic.svg install -Dm444 -t $out/share/metainfo data/com.github.qarmin.czkawka.metainfo.xml ''; </del> <ins> strictDeps = true; </ins> <del> meta = { changelog = "https://github.com/qarmin/czkawka/raw/${version}/Changelog.md"; description = "Simple, fast and easy to use app to remove unnecessary files from your computer"; homepage = "https://github.com/qarmin/czkawka"; license = with lib.licenses; [ mit ]; mainProgram = "czkawka_gui"; maintainers = with lib.maintainers; [ AndersonTorres yanganto _0x4A6F ]; </del> <ins> doCheck = stdenv.hostPlatform.isLinux && (stdenv.hostPlatform == stdenv.buildPlatform); checkPhase = '' runHook preCheck xvfb-run cargo test runHook postCheck ''; # Desktop items, icons and metainfo are not installed automatically postInstall = '' install -Dm444 -t $out/share/applications data/com.github.qarmin.czkawka.desktop install -Dm444 -t $out/share/icons/hicolor/scalable/apps data/icons/com.github.qarmin.czkawka.svg install -Dm444 -t $out/share/icons/hicolor/scalable/apps data/icons/com.github.qarmin.czkawka-symbolic.svg install -Dm444 -t $out/share/metainfo data/com.github.qarmin.czkawka.metainfo.xml ''; passthru = { tests.version = testers.testVersion { package = self; command = "czkawka_cli --version"; }; wrapper = callPackage ./wrapper.nix { czkawka = self; }; }; meta = { homepage = "https://github.com/qarmin/czkawka"; description = "Simple, fast and easy to use app to remove unnecessary files from your computer"; changelog = "https://github.com/qarmin/czkawka/raw/${self.version}/Changelog.md"; license = with lib.licenses; [ mit ]; mainProgram = "czkawka_gui"; maintainers = with lib.maintainers; [ AndersonTorres yanganto _0x4A6F ]; }; </ins> }; <del> } </del> <ins> in self </ins>

<del> diff --git a/Cargo.lock b/Cargo.lock index 5ae2bd6..e4c6f18 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -5676,9 +5676,9 @@ dependencies = [ [[package]] name = "time" -version = "0.3.34" +version = "0.3.36" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "c8248b6521bb14bc45b4067159b9b6ad792e2d6d754d6c41fb50e29fefe38749" +checksum = "5dfd88e563464686c916c7e46e623e520ddc6d79fa6641390f2e3fa86e83e885" dependencies = [ "deranged", "itoa", @@ -5699,9 +5699,9 @@ checksum = "ef927ca75afb808a4d64dd374f00a2adf8d0fcff8e7b184af886c3c87ec4a3f3" [[package]] name = "time-macros" -version = "0.2.17" +version = "0.2.18" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "7ba3a3ef41e6672a2f0f001392bb5dcd3ff0a9992d618ca761a11c3121547774" +checksum = "3f252a68540fde3a3877aeea552b832b40ab9a69e318efd078774a01ddee1ccf" dependencies = [ "num-conv", "time-core", </del>

<ins> { lib, czkawka, makeWrapper, symlinkJoin, # configurable options extraPackages ? [ ], }: symlinkJoin { name = "czkawka-wrapped-${czkawka.version}"; inherit (czkawka) pname version outputs; nativeBuildInputs = [ makeWrapper ]; paths = [ czkawka ]; postBuild = '' ${lib.concatMapStringsSep "n" ( output: "ln --symbolic --no-target-directory ${czkawka.${output}} $${output}" ) (lib.remove "out" czkawka.outputs)} pushd $out/bin for f in *; do rm -v $f makeWrapper ${lib.getBin czkawka}/bin/$f $out/bin/$f  --prefix PATH ":" "${lib.makeBinPath extraPackages}" done popd ''; meta = czkawka.meta; } </ins>

cz-cli = callPackage ../applications/version-management/cz-cli { }; <ins> czkawka-full = czkawka.wrapper.override { extraPackages = [ ffmpeg ]; }; </ins> comma = callPackage ../tools/package-management/comma { }; commitizen = with python3Packages; toPythonApplication commitizen;