jiebi/CodeConvo huggingface dataset:
Change:
Describe the bug Teeworlds does not have a .desktop file so it doesn't show up in any menus. Maintainer information:

Discussion:
<del> { fetchFromGitHub, stdenv, cmake, pkgconfig, python, alsaLib , libX11, libGLU, SDL2, lua5_3, zlib, freetype, wavpack </del> <ins> { fetchFromGitHub, stdenv, cmake, pkgconfig, python3, alsaLib , libX11, libGLU, SDL2, lua5_3, zlib, freetype, wavpack, icoutils </ins> }: stdenv.mkDerivation rec {

'#define DATA_DIR "${placeholder "out"}/share/teeworlds/data"' ''; <del> nativeBuildInputs = [ cmake pkgconfig ]; </del> <ins> nativeBuildInputs = [ cmake pkgconfig icoutils ]; </ins> buildInputs = [ <del> python alsaLib libX11 libGLU SDL2 lua5_3 zlib freetype wavpack </del> <ins> python3 alsaLib libX11 libGLU SDL2 lua5_3 zlib freetype wavpack </ins> ]; <ins> postInstall = '' # Convert and install desktop icon mkdir -p $out/share/pixmaps icotool --extract --index 1 --output $out/share/pixmaps/teeworlds.png $src/other/icons/teeworlds.ico # Install menu item install -D $src/other/teeworlds.desktop $out/share/applications/teeworlds.desktop ''; </ins> meta = { description = "Retro multiplayer shooter game";
Change:
Describe the bug In Tor Browser, all add-ons, including HTTPS Everywhere and NoScript are disabled when you start up the browser. To Reproduce Steps to reproduce the behavior: you have Tor Browser 9.0.6 (from 20.03 or unstable). -click on the starting page. that the "NoScript" option is missing. Expected behavior All add-ons should be enabled on startup. Additional context This appears to be a regression since 9.0.5 introduced in Metadata Please run and paste the result. system: host os: multi-user?: sandbox: version: channels(root): nixpkgs: Maintainer information:
After deleting and re-starting Tor Browser, this problem seems to have gone away. I'm not sure what caused it.
It seems like switching between Tor Browser versions causes it, for instance switching from to . After deleting the Tor Browser directory once, the issue is solved until you switch again,
This happens to me even after simply quitting Tor Browser and starting again, no upgrade or change in-between, although it's not 100% reproducible - I haven't yet figured out what are the exact conditions that trigger this. It's peculiar because NoScript is missing from the UI, although it shows as enabled in about:addons. pinging the maintainers:
With the upgrade to Tor Browser 10.0.2, NoScript is missing 100% of the time, the Hightest Security Level doesn't disable javascript. I wouldn't consider using Tor Browser in this state - it's too different from its normal behavior.
It needs to be marked broken until this is resolved, imo.
potentially related upstream issue: edit: actually its probably not related What worked for me is manually copying the extension from the nix store to the profile directory: maybe this can be to in derivation? The tor-browser 10. is based on a new release of firefox, right? Then this may be because firefox stopped sideloading extensions from the installation directory (, ). Another option may be to use
I have a fix for the noscript issue, feel free to check it out, and see if it works for you. But the HTTPS Everywhere addon is loaded via a different mechanism I think? At least on my system it used to work even with the 10. version before this fix.
And do we have a channel to notify users about the fact that they potentially used a broken version of the tor-browser since (Sep 23)? This is rather critical software..

Discussion:
# Preload extensions by moving into the runtime instead of storing under the # user's profile directory. <del> mkdir -p "$TBB_IN_STORE/browser/extensions" </del> <ins> # See https://support.mozilla.org/en-US/kb/deploying-firefox-with-extensions mkdir -p "$TBB_IN_STORE/distribution/extensions" </ins> mv "$TBB_IN_STORE/TorBrowser/Data/Browser/profile.default/extensions/"*  <del> "$TBB_IN_STORE/browser/extensions" </del> <ins> "$TBB_IN_STORE/distribution/extensions" </ins> # Hard-code paths to geoip data files.  TBB resolves the geoip files # relative to torrc-defaults_path but if we do not hard-code them

# the compound is "libre" in a strict sense (some components place certain # restrictions on redistribution), it's free enough for our purposes. license = licenses.free; <del> broken = true; </del> }; }
Change:
Project description The shares a history with , but is a different app, which fits the pantheon desktop. Metadata homepage URL: source URL: license: GPLv3 platforms: Linux I think you're coordinating pantheon efforts? I'd be happy to take a look at this.
See the last bullet of
Hello, I'm a bot and I thank you in the name of the community for opening this issue. To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use or on the relevant files to find them. Lastly, you can always ask for help at or at .
Not stale, still waiting for them to ship-it :shipit:
it seems like your wait might be over, judging by dependency list in
I see this , so I will ask them in slack if they're shipping it. If so, I think I'll add it myself when they release odin, or anyone else is free to package it.

Discussion:
<ins> { lib, stdenv , fetchFromGitHub , nix-update-script , pantheon , pkg-config , meson , ninja , python3 , vala , desktop-file-utils , gtk3 , libxml2 , libhandy , webkitgtk , folks , libgdata , sqlite , granite , elementary-icon-theme , evolution-data-server , appstream , wrapGAppsHook , libgee }: stdenv.mkDerivation rec { pname = "elementary-mail"; version = "unstable-2021-06-21"; repoName = "mail"; src = fetchFromGitHub { owner = "elementary"; repo = repoName; rev = "c64c87fabb31dea8dc388152d5a835401993acf4"; sha256 = "yEUg1IbYbzOJiklnqR23X+aGVE9j4F9iH8FkmlB15x4="; }; passthru = { updateScript = nix-update-script { attrPath = "pantheon.${pname}"; }; }; nativeBuildInputs = [ appstream desktop-file-utils libxml2 meson ninja pkg-config python3 vala wrapGAppsHook ]; buildInputs = [ elementary-icon-theme evolution-data-server folks granite gtk3 libgdata libgee libhandy sqlite webkitgtk ]; postPatch = '' chmod +x meson/post_install.py patchShebangs meson/post_install.py ''; meta = with lib; { description = "Mail app designed for elementary OS"; homepage = "https://github.com/elementary/mail"; license = licenses.gpl3Plus; platforms = platforms.linux; maintainers = pantheon.maintainers ++ [ maintainers.ethancedwards8 ]; }; } </ins>

elementary-feedback = callPackage ./apps/elementary-feedback { }; <ins> elementary-mail = callPackage ./apps/elementary-mail { }; </ins> elementary-music = callPackage ./apps/elementary-music { }; elementary-photos = callPackage ./apps/elementary-photos { };
Change:
As described in , NixOS's module needs to use so it in the . I noticed errors in the journal saying that certain kernel modules weren't loaded. When I replaced with the errors disappeared.
Why did errors disappear?
I believe the errors disappeared because doesn't look in the right modules directory and does.

Discussion:
systemd.services.strongswan = { description = "strongSwan IPSec Service"; wantedBy = [ "multi-user.target" ]; <del> path = with pkgs; [ kmod iproute iptables utillinux ]; # XXX Linux </del> <ins> path = with pkgs; [ config.system.sbin.modprobe iproute iptables utillinux ]; # XXX Linux </ins> wants = [ "keys.target" ]; after = [ "network.target" "keys.target" ]; environment = {
Change:
Project description Declarative configuration for Gmail filters Metadata homepage URL: source license: mit platforms: unix Package Definition
Do you mind opening a PR?
I haven't been able to get explicit permission from my employer to contribute to open source code, so I'm afraid I can't at this point.

Discussion:
<ins> { stdenv , buildGoModule , fetchFromGitHub }: buildGoModule rec { pname = "gmailctl"; version = "0.6.0"; src = fetchFromGitHub { owner = "mbrt"; repo = "gmailctl"; rev = "v${version}"; sha256 = "0g581gdkib7bj86blpm8skjvbnivmzh9ddikxai9hr5qq231j1pb"; }; modSha256 = "0pv3lhzl96ygzh9y01hi9klrrk403ii92imr9yrbimaf7rsvyvjp"; meta = with stdenv.lib; { description = "Declarative configuration for Gmail filters"; homepage = "https://github.com/mbrt/gmailctl"; license = licenses.mit; maintainers = [ maintainers.doronbehar ]; platforms = platforms.unix; }; } </ins>

gmailieer = callPackage ../applications/networking/gmailieer {}; <ins> gmailctl = callPackage ../applications/networking/gmailctl {}; </ins> gpm = callPackage ../servers/gpm { ncurses = null;  # Keep curses disabled for lack of value };
Change:
Describe the bug The riot-desktop package crashes on NixOS systems where KDE is the only explicitly installed desktop environment. To Reproduce Steps to reproduce the behavior: KDE and riot-desktop riot-desktop, sign in and join a room the paperclip to attach a file Expected behavior The KDE file chooser should pop up allowing you to select a file Additional context My best guess based on the terminal output is that Matrix is trying to use some kind of GTK library to determine the file chooser and does not list it as a dependency. Terminal output of the crashing program:
This is a somewhat common error and it goes undetected because package testers have these gsettings schemas installed on their system. For me, on NixOS, I this to my : If you don't use NixOS, try to follow what's explained .
This is an electron program, it probably needs to be wrapped manually, the standard hook won't work.
Backported to 20.03 in .
Now riot-desktop crashes here with the following error:
there has been a new PR that fixes up this one: . Can you check that out?
Yes, I'm on master with the latest commits. The shows at the top:

Discussion:
<del> { pkgs, stdenv, fetchFromGitHub, makeWrapper, makeDesktopItem, electron_7, riot-web, mkYarnPackage }: </del> <ins> { stdenv, fetchFromGitHub , makeWrapper, makeDesktopItem, mkYarnPackage , electron_7, riot-web, gtk3, }: </ins> # Notes for maintainers: # * versions of `riot-web` and `riot-desktop` should be kept in sync.

packageJSON = ./riot-desktop-package.json; yarnNix = ./riot-desktop-yarndeps.nix; <del> nativeBuildInputs = [ makeWrapper ]; </del> <ins> nativeBuildInputs = [ makeWrapper gtk3 ]; </ins> installPhase = '' # resources

# executable wrapper makeWrapper '${electron}/bin/electron' "$out/bin/${executableName}"  <del> --add-flags "$out/share/riot/electron" </del> <ins> --add-flags "$out/share/riot/electron"  --prefix XDG_DATA_DIRS : $GSETTINGS_SCHEMAS_PATH </ins> ''; # Do not attempt generating a tarball for riot-web again.
Change:
In the nixpkgs manual, : but 37 window-managers are in . Should I change the documentation to reflect this?
I don't know if that hierarchy makes sense at all, but yes we can change it.
I that hierarchy does not make sense, I think we should just remove it.

Discussion:
</listitem> </varlistentry> <varlistentry> <del> <term>If it’s a <emphasis>desktop environment</emphasis> (including <emphasis>window managers</emphasis>):</term> </del> <ins> <term>If it’s a <emphasis>desktop environment</emphasis>:</term> </ins> <listitem> <para><filename>desktops</filename> (e.g. <filename>kde</filename>, <filename>gnome</filename>, <filename>enlightenment</filename>)</para> </listitem> </varlistentry> <varlistentry> <ins> <term>If it’s a <emphasis>window manager</emphasis>:</term> <listitem> <para><filename>applications/window-managers</filename> (e.g. <filename>awesome</filename>, <filename>compiz</filename>, <filename>stumpwm</filename>)</para> </listitem> </varlistentry> <varlistentry> </ins> <term>If it’s an <emphasis>application</emphasis>:</term> <listitem> <para>A (typically large) program with a distinct user
Change:
Describe the bug Zotero crashes whenever it tries to open the file chooser (e.g. when you try to install addons, or add a file to a reference), complaining that no GSettings schemas are installed on the system: To Reproduce Steps to reproduce the behavior: Zotero -Add-ons the new window, click the settings cog -Install Add-on From File... Expected behavior Zotero opens the file chooser dialog (from Gtk3) Additional context I am only running xmonad with no desktop environment, which might explain why is unset - the problem is that it's looking for . As a workaround, one can set the value of to . Glancing at the Zotero's nixexpr, it's using and is listed as a build input, so I'm not sure why this is happening. Metadata Please run and paste the result. Maintainer information:
can you see if adding to fixes this, and file a PR if it does?
(also glib to buildInputs if it isn't there already)
Yes, it is strange that is listed in - it should definitely go in , however, this does not seem to fix the problem (neither does suggestion)
Maybe phases is messing this up It should instead probably set
can confirm why this addresses the issue. Before I make a pull request, could you please elaborate on why needs to be in ? It seems to work either way.
See and the first item in GLib has a setup hook for gsettings-schemas that wrapGAppsHook needs
It can work either way because gtk3 propagates it, but it still should be .

Discussion:
sha256 = "1abkwxdi154hnry8nsvxbklvbsnvd7cs2as0041h2kbiz824pv31"; }; <del> buildInputs= [ wrapGAppsHook gsettings-desktop-schemas gtk3 gnome3.adwaita-icon-theme dconf ]; phases = [ "unpackPhase" "patchPhase" "installPhase" "fixupPhase" ]; </del> <ins> nativeBuildInputs = [ wrapGAppsHook ]; buildInputs= [ gsettings-desktop-schemas glib gtk3 gnome3.adwaita-icon-theme dconf ]; dontConfigure = true; dontBuild = true; </ins> dontStrip = true; dontPatchELF = true;
Change:
This impacts any fixed-output derivation using that is not already in the binary cache. Packages relying on should be inspected to make sure that the canonical source location still actually uses in the first place; many of them have migrated to GitHub or similar places over the years.
It appears that is now fixed.

Discussion:
<del> { lib, buildPythonPackage, fetchdarcs, zope_interface, isPy3k }: </del> <ins> { lib, buildPythonPackage, fetchFromGitHub, zope_interface, isPy3k }: </ins> buildPythonPackage rec { pname = "python-application"; <del> version = "2.7.0"; </del> <ins> version = "2.8.0"; </ins> disabled = isPy3k; <del> src = fetchdarcs { url = "http://devel.ag-projects.com/repositories/${pname}"; </del> <ins> src = fetchFromGitHub { owner = "AGProjects"; repo = pname; </ins> rev = "release-${version}"; <del> sha256 = "1xpyk2v3naxkjhpyris58dxg1lxbraxgjd6f7w1sah5j0sk7psla"; </del> <ins> sha256 = "1xd2gbpmx2ghap9cnr1h6sxjai9419bdp3y9qp5lh67977m0qg30"; </ins> }; buildInputs = [ zope_interface ]; <ins> # No tests upstream to run doCheck = false; </ins> meta = with lib; { description = "Basic building blocks for python applications"; <del> homepage = https://github.com/AGProjects/python-application; </del> <ins> homepage = "https://github.com/AGProjects/python-application"; changelog = "https://github.com/AGProjects/python-application/blob/master/ChangeLog"; </ins> license = licenses.lgpl2Plus; }; }

meta = with stdenv.lib; { description = "A pure python implementation of OTR"; <del> homepage = https://github.com/AGProjects/otr; </del> <ins> homepage = "https://github.com/AGProjects/python-otr"; </ins> license = licenses.lgpl21Plus; platforms = platforms.linux; maintainers = with maintainers; [ edwtjo ]; <ins> # The package itself does not support python3, and its transitive # dependencies rely on namespace package support that does not work in # Nix's python2 infra. See #74619 for details. broken = true; </ins> }; }
Change:
After (krb5: 1.17 -1.18) is merged, doesn't build with anymore. The error is: Since is a dependency of , this affects significant number of downstream packages. To Reproduce cc

Discussion:
<ins> From cbdbc8d00d31344fafe00e0fdf984e04e631f7c4 Mon Sep 17 00:00:00 2001 From: TBK <tbk@jjtc.eu> Date: Wed, 26 Feb 2020 21:12:45 +0100 Subject: [PATCH] Fix Linux build error with musl libc Commit bf5953c549a6d279977df69ffe89b2ba51460eaf caused a build failure on non-glibc Linux build environments.  Change the conditionalization so that __GLIBC_PREREQ will only be used if it is defined. [ghudson@mit.edu: simplified conditionals; rewrote commit message] ticket: 8880 (new) tags: pullup target_version: 1.18-next --- src/util/support/plugins.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/support/plugins.c b/src/util/support/plugins.c index 3329db7dc3..1644d16fd0 100644 --- a/src/util/support/plugins.c +++ b/src/util/support/plugins.c @@ -62,8 +62,7 @@ * dlopen() with RTLD_NODELETE, we weren't going to unload the plugin objects * anyway. */ -#ifdef __linux__ -#include <features.h> +#ifdef __GLIBC__PREREQ #if ! __GLIBC_PREREQ(2, 25) #define dlclose(x) #endif </ins>

<ins> From b009cca2026b615ef5386faa4c0230bc27c4161d Mon Sep 17 00:00:00 2001 From: Greg Hudson <ghudson@mit.edu> Date: Thu, 12 Mar 2020 00:44:10 -0400 Subject: [PATCH] Fix typo in musl build fix Commit cbdbc8d00d31344fafe00e0fdf984e04e631f7c4 checked for __GLIBC__PREREQ instead of __GLIBC_PREREQ, thus accidentally reverting the workaround introduced in commit bf5953c549a6d279977df69ffe89b2ba51460eaf.  Fix the typo. ticket: 8880 --- src/util/support/plugins.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/support/plugins.c b/src/util/support/plugins.c index 1644d16fd0..1ff10c354d 100644 --- a/src/util/support/plugins.c +++ b/src/util/support/plugins.c @@ -62,7 +62,7 @@ * dlopen() with RTLD_NODELETE, we weren't going to unload the plugin objects * anyway. */ -#ifdef __GLIBC__PREREQ +#ifdef __GLIBC_PREREQ #if ! __GLIBC_PREREQ(2, 25) #define dlclose(x) #endif </ins>

with stdenv.lib; stdenv.mkDerivation rec { name = "${type}krb5-${version}"; <del> majorVersion = "1.18"; </del> <ins> majorVersion = "1.18"; # remove patches below with next upgrade </ins> version = majorVersion; src = fetchurl {

sha256 = "121c5xsy3x0i4wdkrpw62yhvji6virbh6n30ypazkp0isws3k4bk"; }; <ins> patches = optionals stdenv.hostPlatform.isMusl [ # TODO: Remove with next release > 1.18 # Patches to fix musl build with 1.18. # Not using `fetchpatch` for these for now to avoid infinite recursion # errors in downstream projects (unclear if it's a nixpkgs issue so far). ./krb5-Fix-Linux-build-error-with-musl-libc.patch ./krb5-Fix-typo-in-musl-build-fix.patch ]; </ins> outputs = [ "out" "dev" ]; configureFlags = [ "--with-tcl=no" "--localstatedir=/var/lib"]
Change:
Fails to begin evaluation example failure : example PR (if still relevant): cc
There seems to be also an error in nixpkgs, where building nixos results in infinite recursion, but it seems to be independent of this issues, as error persists, even if i rebase on nixos-unstable branch??
offending commit: cc
this seems to concur with the
actually, the other offending line is in I think that's setting to enable, which then causes the geoclue2 to reset the provider to geoclue, which then causes infinite recursion.
Seems like the main issue is that we have 2 ways of declaring that geoclue2 should be used: location.provider I think the correct course of action would be to eliminate one of these options. Seeing as location.provider is stringly typed, and only used to set , I think it can be removed.

Discussion:
###### implementation config = mkIf cfg.enable { <del> location.provider = "geoclue2"; </del> environment.systemPackages = [ package ]; services.dbus.packages = [ package ];
Change:
Related to Project description Jitsi Meet desktop application powered by Electron Metadata homepage URL: source URL: license: Apache-2.0 platforms: unix, linux, darwin,
+1 as the App seems to have some benefits over using just a browser. Whoever starts working on this, please remember to deactivate the auto-update functionality.
Also I would suggest to make sure we are using a recent version of Electron and nodejs, as don in this fork:
There was a 2.0.0 release two days ago: I think this fixes the outdated dependencies issue mentioned in the previous comment.
Yes a pull request from the fork I mentioned before was accepted.
I fixed the outstanding issues and PR is ready for review

Discussion:
<ins> { stdenv , fetchurl , appimageTools , makeWrapper , electron_8 }: stdenv.mkDerivation rec { pname = "jitsi-meet-electron"; version = "2.0.0"; src = fetchurl { url = "https://github.com/jitsi/jitsi-meet-electron/releases/download/v${version}/jitsi-meet-x86_64.AppImage"; sha256 = "11ci9dqhy8hkb4fwykjvcvai20ahqhjil825n1y1xf663ch8by93"; name="${pname}-${version}.AppImage"; }; appimageContents = appimageTools.extractType2 { name = "${pname}-${version}"; inherit src; }; dontUnpack = true; dontConfigure = true; dontBuild = true; nativeBuildInputs = [ makeWrapper ]; installPhase = '' runHook preInstall mkdir -p $out/bin $out/share/${pname} $out/share/applications cp -a ${appimageContents}/{locales,resources} $out/share/${pname} cp -a ${appimageContents}/jitsi-meet.desktop $out/share/applications/${pname}.desktop cp -a ${appimageContents}/usr/share/icons $out/share substituteInPlace $out/share/applications/${pname}.desktop  --replace 'Exec=AppRun' 'Exec=${pname}' runHook postInstall ''; postFixup = '' makeWrapper ${electron_8}/bin/electron $out/bin/${pname}  --add-flags $out/share/${pname}/resources/app.asar  --prefix LD_LIBRARY_PATH : "${stdenv.lib.makeLibraryPath [ stdenv.cc.cc ]}" ''; meta = with stdenv.lib; { description = "Jitsi Meet desktop application powered by Electron"; homepage = "https://github.com/jitsi/jitsi-meet-electron"; license = licenses.asl20; maintainers = with maintainers; [ prusnak ]; platforms = [ "x86_64-linux" ]; }; } </ins>

btcdeb = callPackage ../applications/blockchains/btcdeb {}; <ins> jitsi-meet-electron = callPackage ../applications/networking/instant-messengers/jitsi-meet-electron { }; </ins> }