jiebi/CodeConvo huggingface dataset:
Change:
The library has support for AVIF since the . that AVIF support. The support is optional however, and requires the libavif library to be present. I imagine one needs to package for nixos, then add it to the / similarly to how it's done for openexr already.
libavif is already packaged in . So maybe just adding to in is enough? Can you try if that works for you and if it did send a pull request?
interesting. I'll give it a try.
So I've done some experimenting locally, and apparently if I only add libavif it still doesn't recognize avif files. It does create a file meaning that it successfully created a plugin, but when I try to open avif files using gwenview, it gives an error that it can't open files. If I try to open an heif file however, it shows a different error: it complains that it can't open files. So maybe it has the module, but no clue it can use the module because it doesn't know the mime type. Also, running returns the correct mime type for jpg and heif files, but does not return the correct mime type for avif files. I've checked and apparently the shared-mime-info package points to the 1.13.1 release from September 2019, but the . The most recent release is 2.1 from Dec 31 2020. I suspect that an update of the shared-mime-info package should fix this, but need to test it. cc maintainer of shared-mime-info.
I've looked a bit into the question of updating shared-mime-info. An update to 2.1 needed some adjustments to accommodate for the meson migration and a backport of a patch to not hit the internet during build. After that the package built but there was a test failure in one of the dependents... When I backported the AVIF patch for 1.13.1, I realized that basically everything depends on shared-mime-info. I eventually ran out of disk space during the build. I think that waiting for a regular update of shared-mime-info would be best.
Also, it seems that the CXXFLAGS thing isn't needed.
I've tested the patch locally and it works (needed to wait until there were sufficient hydra cache results for ). I've made a PR:
KImageFormat does currently not seem build: See comments in PR of libavif upgrade: The following fix, which looks to be included in seems relevant:

Discussion:
{ mkDerivation, lib, extra-cmake-modules, <del> ilmbase, karchive, openexr, qtbase </del> <ins> ilmbase, karchive, openexr, libavif, qtbase </ins> }: let inherit (lib) getDev; in

mkDerivation { name = "kimageformats"; nativeBuildInputs = [ extra-cmake-modules ]; <del> buildInputs = [ karchive openexr qtbase ]; </del> <ins> buildInputs = [ karchive openexr libavif qtbase ]; </ins> outputs = [ "out" ]; # plugins only CXXFLAGS = "-I${getDev ilmbase}/include/OpenEXR"; }
Change:
Describe the bug When open any component of wps office, it shows an dialog "An error has occurred in WPS" and crash. No logs found, but it works by using steam-run. To Reproduce Steps to reproduce the behavior: package pkgs.wpsoffice it in terminal or click office logo shows an error dialog, self-restart repeatedly and exit. Screenshots ! Notify maintainers Metadata `` Maintainer information:
Confirmed this error on my nixos

Discussion:
{ lib, stdenv , mkDerivation , fetchurl <del> , autoPatchelfHook </del> , dpkg , wrapGAppsHook , wrapQtAppsHook

, unixODBC , xorg , zlib <ins> , steam , makeWrapper </ins> }: stdenv.mkDerivation rec {

rm opt/kingsoft/wps-office/office6/{libjsetapi.so,libjswppapi.so,libjswpsapi.so} ''; <del> nativeBuildInputs = [ autoPatchelfHook dpkg wrapGAppsHook wrapQtAppsHook ]; </del> <ins> nativeBuildInputs = [ dpkg wrapGAppsHook wrapQtAppsHook makeWrapper ]; </ins> meta = with lib; { description = "Office suite, formerly Kingsoft Office";

sqlite unixODBC zlib <ins> cups.lib </ins> ]; dontPatchELF = true;

"tcmalloc" # gperftools ]; <del> installPhase = '' </del> <ins> installPhase = let steam-run = (steam.override { extraPkgs = p: buildInputs; nativeOnly = true; }).run; in '' </ins> prefix=$out/opt/kingsoft/wps-office mkdir -p $out cp -r opt $out

substituteInPlace $i  --replace /usr/bin $out/bin done <del> ''; runtimeLibPath = lib.makeLibraryPath [ cups.lib ]; </del> <ins> for i in wps wpp et wpspdf; do mv $out/bin/$i $out/bin/.$i-orig makeWrapper ${steam-run}/bin/steam-run $out/bin/$i  --add-flags $out/bin/.$i-orig  --argv0 $i done ''; </ins> dontWrapQtApps = true; dontWrapGApps = true;

echo "Wrapping $f" wrapProgram "$f"  "''${gappsWrapperArgs[@]}"  <del> "''${qtWrapperArgs[@]}"  --suffix LD_LIBRARY_PATH : "$runtimeLibPath" </del> <ins> "''${qtWrapperArgs[@]}" </ins> done ''; }
Change:
Describe the bug When open any component of wps office, it shows an dialog "An error has occurred in WPS" and crash. No logs found, but it works by using steam-run. To Reproduce Steps to reproduce the behavior: package pkgs.wpsoffice it in terminal or click office logo shows an error dialog, self-restart repeatedly and exit. Screenshots ! Notify maintainers Metadata `` Maintainer information:
Confirmed this error on my nixos

Discussion:
{ lib , stdenv <del> , mkDerivation </del> , fetchurl , dpkg , wrapGAppsHook

, mesa , libtiff , cups <ins> , udev </ins> , xorg <del> , steam-run </del> , makeWrapper , useChineseVersion ? false }:

nspr mesa libtiff <ins> udev ]; runtimeDependencies = [ </ins> cups.lib ];

substituteInPlace $i  --replace /usr/bin $out/bin done <del> for i in wps wpp et wpspdf; do mv $out/bin/$i $out/bin/.$i-orig makeWrapper ${steam-run}/bin/steam-run $out/bin/$i  --add-flags $out/bin/.$i-orig  --argv0 $i done </del> runHook postInstall '';

preFixup = '' # The following libraries need libtiff.so.5, but nixpkgs provides libtiff.so.6 patchelf --replace-needed libtiff.so.5 libtiff.so $out/opt/kingsoft/wps-office/office6/{libpdfmain.so,libqpdfpaint.so,qt/plugins/imageformats/libqtiff.so} <ins> # dlopen dependency patchelf --add-needed libudev.so.1 $out/opt/kingsoft/wps-office/office6/addons/cef/libcef.so </ins> ''; postFixup = ''
Change:
<!-- Note that these are hard requirements --<!-- You can use the "Go to file" functionality on github to find the package Then you can go to the history for this package Find the latest "packagename: oldversion -newversion" commit The "newversion" is the the current version of the package --- <!-- Type the name of your package and try to find an open pull request for the package If you find an open pull request, you can review it! There's a high chance that you'll have the new version right away while helping the community! --- name: vimix-gtk-themes <!-- The current version can be found easily with the same process than above for checking the master branch If an open PR is present for the package, take this version as the current one and link to the PR --current version: 2020-11-28 desired version: 2021-04-25 <!-- Search your package here: If no maintainer is listed for your package, tag the person that last updated the package --maintainers: the install Phase currently doesn't install all the variations of the theme, only the "doder", you must pass the parameter "-a" or "--all" to "" Please tag this issue in your PR.

Discussion:
stdenv.mkDerivation rec { pname = "vimix-gtk-themes"; <del> version = "2020-11-28"; </del> <ins> version = "2021-04-25"; </ins> src = fetchFromGitHub { owner = "vinceliuice"; repo = pname; rev = version; <del> sha256 = "1m84p4cs9dfwc27zfjnwgkfdnfmlzbimq3g5z4mhz23cijm178rf"; </del> <ins> sha256 = "0ak763vs27h5z2pgcqpz1g1hypn5gl0p0ylffawc9zdi1wp2mpxb"; </ins> }; buildInputs = [ gtk_engines ];

propagatedUserEnvPkgs = [ gtk-engine-murrine ]; installPhase = '' <ins> runHook preInstall </ins> patchShebangs . mkdir -p $out/share/themes <del> name= ./install.sh -d $out/share/themes </del> <ins> name= ./install.sh --all --dest $out/share/themes </ins> rm $out/share/themes/*/{AUTHORS,LICENSE} <ins> runHook postInstall </ins> ''; meta = with lib; { description = "Flat Material Design theme for GTK based desktop environments"; homepage = "https://github.com/vinceliuice/vimix-gtk-themes"; <del> license = licenses.gpl3; </del> <ins> license = licenses.gpl3Only; </ins> platforms = platforms.unix; maintainers = [ maintainers.romildo ]; };
Change:
Describe the bug results in the following error on : Seems like the writer expects to be executed in a stdenv environment to find instead of knowing the path to it. To Reproduce Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- (rust maintainers)
This should work as long as GHC is proper dep, because libiconv is propagated.
This should be independent of GHC entirely: only relation to GHC is probably that I mistook the error for one coming from GHC initially, but this is not the case ( doesn't allow building the writers individually what confused me).
I'm facing this issue trying to build from on macOS Big Sur. (wasmer is a dependency of FastAPI, which is the package I'm actually interested in) <details<summaryLogs:</summary</details
I think adding to could also help there.
Fix here:

Discussion:
<del> { pkgs, buildPackages, lib, gawk, gnused, gixy }: </del> <ins> { pkgs, buildPackages, lib, stdenv, libiconv, gawk, gnused, gixy }: </ins> with lib; rec {

rustcArgs ? [], strip ? true }: <ins> let darwinArgs = lib.optionals stdenv.isDarwin [ "-L${lib.getLib libiconv}/lib" ]; in </ins> makeBinWriter { compileScript = '' cp "$contentPath" tmp.rs <del> PATH=${makeBinPath [pkgs.gcc]} ${lib.getBin rustc}/bin/rustc ${lib.escapeShellArgs rustcArgs} -o "$out" tmp.rs </del> <ins> PATH=${makeBinPath [pkgs.gcc]} ${lib.getBin rustc}/bin/rustc ${lib.escapeShellArgs rustcArgs} ${lib.escapeShellArgs darwinArgs} -o "$out" tmp.rs </ins> ''; inherit strip; } name;
Change:
Project description Jobber is a "modern" replacement for cron, with sophisticated status-reporting and error-handling, and simpler configuration. Metadata homepage URL: source URL: license: mit platforms: "Unix-like systems"
So this would also require a module I assume.
In a certain sense the module can be delegated for later.
I marked this as stale due to inactivity. &rarr;
I'd like this! I've never contributed to Nixpkgs before... so I might be able to do this
Go for it, man!

Discussion:
<ins> { lib, buildGoModule, fetchFromGitHub, gotools }: buildGoModule rec { pname = "jobber"; version = "1.4.4"; src = fetchFromGitHub { owner = "dshearer"; repo = pname; rev = "v${version}"; hash = "sha256-mLYyrscvT/VK9ehwkPUq4RbwHb+6Wjvt7ZXk/fI0HT4="; }; vendorHash = null; nativeBuildInputs = [ gotools ]; postConfigure = "go generate ./..."; ldflags = [ "-s" "-w" "-X github.com/dshearer/jobber/common.jobberVersion=${version}" "-X github.com/dshearer/jobber/common.etcDirPath=${placeholder "out"}/etc" ]; postInstall = '' mkdir -p $out/etc $out/libexec $out/bin/jobbermaster defprefs --libexec $out/libexec > $out/etc/jobber.conf mv $out/bin/jobber{master,runner} $out/libexec/ ''; meta = with lib; { homepage = "https://dshearer.github.io/jobber"; changelog = "https://github.com/dshearer/jobber/releases/tag/v${version}"; description = "An alternative to cron, with sophisticated status-reporting and error-handling"; license = licenses.mit; maintainers = with maintainers; [ urandom ]; }; } </ins>

httm = callPackage ../tools/filesystems/httm { }; <ins> jobber = callPackage ../tools/system/jobber {}; </ins> kanata = callPackage ../tools/system/kanata { }; kanata-with-cmd = kanata.override { withCmd = true; };
Change:
Project description Metadata Git helper for credentials in lastpass homepage URL: source URL: license: gpl2+ platforms: unix

Discussion:
<del> { stdenv, lib, fetchFromGitHub, asciidoc, cmake, docbook_xsl, pkg-config , bash-completion, openssl, curl, libxml2, libxslt }: </del> <ins> { stdenv , lib , fetchFromGitHub , asciidoc , cmake , docbook_xsl , pkg-config , bash-completion , openssl , curl , libxml2 , libxslt }: </ins> stdenv.mkDerivation rec { pname = "lastpass-cli";

nativeBuildInputs = [ asciidoc cmake docbook_xsl pkg-config ]; buildInputs = [ <del> bash-completion curl openssl libxml2 libxslt </del> <ins> bash-completion curl openssl libxml2 libxslt </ins> ]; installTargets = [ "install" "install-doc" ];

postInstall = '' install -Dm644 -T ../contrib/lpass_zsh_completion $out/share/zsh/site-functions/_lpass install -Dm644 -T ../contrib/completions-lpass.fish $out/share/fish/vendor_completions.d/lpass.fish <ins> install -Dm755 -T ../contrib/examples/git-credential-lastpass $out/bin/git-credential-lastpass </ins> ''; meta = with lib; { description = "Stores, retrieves, generates, and synchronizes passwords securely"; <del> homepage    = "https://github.com/lastpass/lastpass-cli"; license     = licenses.gpl2Plus; platforms   = platforms.unix; </del> <ins> homepage = "https://github.com/lastpass/lastpass-cli"; license = licenses.gpl2Plus; platforms = platforms.unix; </ins> maintainers = with maintainers; [ cstrahan ]; }; }
Change:
Even if the target host gets the toplevel closure, later steps in the nixos-rebuild will always the build closure over to the targetHost (which can thousands of packages larger) and is potentially unnecessary. PR which introduced of the .drv: Additional Context: For our scenario, we would to the machine, as the machines are usually underpowered compared our dev boxes, and our dev boxes would likely have the configurations in the store as we were iterating on the configurations. Thus it was odd that we copied the closure over and still have to copy an additional 2200 - 4000 paths, when the runtime closure already existed.
I'm not entirely sure how introduced this behaviour. The only thing I there was a function allowing flakes to be built remotely. Copying results to the target host was not touched in that PR.
Previous behavior created a realised outpath: new behavior creates a derivation, then 's it: for a to be valid, it needs every single .drv dependency. For me, this is 2000-5000 and FOD paths which need to be instantiated and copied; as opposed to ~120 new outpaths
I guess I'm missing something. With the previous behaviour, it was not possible to build remotely, so you had to do . If you give the same params now, it will only copy the out paths, not the derivations. (And to clarify: it's not that important to me, but I always like to know what I could have done better.)
I guess the previous built the toplevel locally, then pushed it. Now this behavior pushes the .drv closure over, then realises it. Probably not that bad if the target host has a small configuration, but hosts which have 2-3 dozen services, and several dozen packages start to get .drv closures in the thousands, and it does become quite painful. I guess I would have prefered to be the default (which also would have retained previous behavior). And realisation on the target host should be done with

Discussion:
upgrade_all= repair= profile=/nix/var/nix/profiles/system <del> buildHost= </del> <ins> buildHost=localhost </ins> targetHost= maybeSudo=()
Change:
Project description Italic in Roboto Mono has different width so the Robotization Mono fork is simply a renamed monospacified version of Roboto Mono. Metadata homepage URL: source URL: license: mit platforms: multi-platform

Discussion:
<ins> { lib, fetchurl }: let pname = "open-fonts"; version = "0.7.0"; in fetchurl { name = "${pname}-${version}"; url = "https://github.com/kiwi0fruit/open-fonts/releases/download/${version}/open-fonts.tar.xz"; downloadToTemp = true; recursiveHash = true; sha256 = "sha256-bSP9Flotoo3E5vRU3eKOUAPD2fmkWseWYWG4y0S07+4="; postFetch = '' tar xf $downloadedFile mkdir -p $out/share/fonts/truetype install open-fonts/*.ttf $out/share/fonts/truetype ''; meta = with lib; { description = "A collection of beautiful free and open source fonts"; homepage = "https://github.com/kiwi0fruit/open-fonts"; license = licenses.mit; platforms = platforms.all; maintainers = with maintainers; [ fortuneteller2k ]; }; } </ins>

inter = callPackage ../data/fonts/inter { }; <ins> open-fonts = callPackage ../data/fonts/open-fonts { }; </ins> scientifica = callPackage ../data/fonts/scientifica { }; siji = callPackage ../data/fonts/siji
Change:
Describe the bug Sweet theme doesn't provide murrine gtk engine compared to other themes: Apps thus don't detect the murrine engine because it is not installed. There might also be other problems with the package as I think pixbuf and librsvg are mendatory for themes, I am not sure about that but it could be. Expected behavior The sweet package should install all necessary dependencies. Screenshots ! Notify maintainers <!-- Please @ people who are in the list of the offending package or module. If in doubt, check for whoever last touched something. -- Maintainer information:
Nice! Thank you

Discussion:
<del> { lib, stdenv, fetchurl }: </del> <ins> { lib, stdenv, fetchurl, gtk-engine-murrine }: </ins> stdenv.mkDerivation rec { pname = "sweet";

}) ]; <ins> propagatedUserEnvPkgs = [ gtk-engine-murrine ]; </ins> sourceRoot = "."; installPhase = ''
Change:
is now failing, and blocking the unstable channel cc
Minimal reproducer: Bisected to Relevant snippet of cc
Oh I see, the stdenv setup logic is wrong when stdenv's cc version doesn't match the bootstrap tools because it tries to use a nonexistent include dir. The following patch should fix it but rebuilds the world, is there a clever way we can avoid rebuilds?
The bootstrap files contain some version of llvm, we could make this an explicit part of the tools. More generally, the test here is quite strict: it builds all the way to with new bootstrap tools but using current stdenv structure. When there are significant changes being made to the bootstrap tools that require stdenv changes this test makes it almost impossible. We've previously temporarily disabled this test to make such changes (). <details<summaryExplicit versions patch</summary</deatils
Yeah, the next bootstrap tools will depend on so it's somewhat expected that the stdenv test fails. I missed that build when testing.

Discussion:
, config , overlays , crossOverlays ? [ ] <ins> , bootstrapLlvmVersion ? if localSystem.isAarch64 then "11.1.0" else "7.1.0" </ins> # Allow passing in bootstrap files directly so we can test the stdenv bootstrap process when changing the bootstrap tools , bootstrapFiles ? if localSystem.isAarch64 then let

let inherit (localSystem) system; <del> # Bootstrap version needs to be known to reference headers included in the bootstrap tools bootstrapLlvmVersion = if localSystem.isAarch64 then "11.1.0" else "7.1.0"; </del> useAppleSDKLibs = localSystem.isAarch64; haveKRB5 = localSystem.isx86_64; # final toolchain is injected into llvmPackages_${finalLlvmVersion} <del> finalLlvmVersion = if localSystem.isAarch64 then "11" else "7"; </del> <ins> finalLlvmVersion = lib.versions.major bootstrapLlvmVersion; </ins> finalLlvmPackages = "llvmPackages_${finalLlvmVersion}"; commonImpureHostDeps = [

''; }; <ins> bootstrapLlvmVersion = llvmPackages.llvm.version; </ins> bootstrapFiles = { sh      = "${build}/on-server/sh"; bzip2   = "${build}/on-server/bzip2";

system = if crossSystem != null then crossSystem else system; stdenvStages = args: let <del> args' = args // { inherit bootstrapFiles; }; </del> <ins> args' = args // { inherit bootstrapLlvmVersion bootstrapFiles; }; </ins> in (import (test-pkgspath + "/pkgs/stdenv/darwin") args').stagesDarwin; }; }

# Lightweight distribution and test inherit (bootstrap) dist test; # Test a full stdenv bootstrap from the bootstrap tools definition <del> inherit (bootstrap.test-pkgs) stdenv; </del> <ins> # TODO re-enable with https://github.com/NixOS/nixpkgs/pull/126411 # inherit (bootstrap.test-pkgs) stdenv; </ins> }; # Cross compiled bootstrap tools
Change:
Describe the bug The Thunar bulk-rename dialog doesn't support regular expressions. To Reproduce Steps to reproduce the behavior: multiple files. -Click → Rename. "Search & Replace" Expected behavior The "Regular Expression" option can be checked. Screenshots ! Additional context This appears to be because it is not using PCRE or PCRE doesn't support UTF-8. I support it isn't being built with PCRE at all. Notify maintainers No maintainers, touched it last. Metadata system: host os: multi-user?: sandbox: version: channels(kevincox): channels(root): nixpkgs: Maintainer information:

Discussion:
, libxfce4ui , libxfce4util , libxslt <ins> , pcre </ins> , xfconf , gobject-introspection , makeWrapper

libnotify libxfce4ui libxfce4util <ins> pcre </ins> xfconf ];
Change:
Describe the bug Fails during tests on unstable channel: Seems to be caused by To Reproduce Steps to reproduce the behavior: Expected behavior Build succeeds. Notify maintainers Metadata Maintainer information:
May be hitting this:
Simply adding makes the test pass and the build succeed.

Discussion:
, appdirs , attrs , click <ins> , colorama </ins> , dataclasses , mypy-extensions , pathspec

, regex , toml , typed-ast <del> , typing-extensions }: </del> <ins> , typing-extensions , uvloop }: </ins> buildPythonPackage rec { pname = "black"; <del> version = "21.5b1"; </del> <ins> version = "21.6b0"; </ins> disabled = pythonOlder "3.6"; src = fetchPypi { inherit pname version; <del> sha256 = "1cdkrl5vw26iy7s23v2zpr39m6g5xsgxhfhagzzflgfbvdc56s93"; </del> <ins> sha256 = "016f6bhnnnbcrrh3cvmpk77ww0nykv5n1qvgf8b3044dm14264yw"; </ins> }; nativeBuildInputs = [ setuptools-scm ];

# Black starts a local server and needs to bind a local address. __darwinAllowLocalNetworking = true; <del> checkInputs =  [ pytestCheckHook parameterized ]; </del> <ins> checkInputs = [ pytestCheckHook parameterized ]; </ins> preCheck = '' export PATH="$PATH:$out/bin"

# The top directory /build matches black's DEFAULT_EXCLUDE regex. # Make /build the project root for black tests to avoid excluding files. touch ../.git <ins> '' + lib.optionalString stdenv.isDarwin '' # Work around https://github.com/psf/black/issues/2105 export TMPDIR="/tmp" </ins> ''; disabledTests = [

appdirs attrs click <ins> colorama </ins> mypy-extensions pathspec regex toml <del> typed-ast typing-extensions ] ++ lib.optional (pythonOlder "3.7") dataclasses; </del> <ins> typed-ast # required for tests and python2 extra uvloop ] ++ lib.optional (pythonOlder "3.7") dataclasses ++ lib.optional (pythonOlder "3.8") typing-extensions; </ins> meta = with lib; { description = "The uncompromising Python code formatter"; <del> homepage    = "https://github.com/psf/black"; changelog   = "https://github.com/psf/black/blob/${version}/CHANGES.md"; license     = licenses.mit; </del> <ins> homepage = "https://github.com/psf/black"; changelog = "https://github.com/psf/black/blob/${version}/CHANGES.md"; license = licenses.mit; </ins> maintainers = with maintainers; [ sveitser ]; }; }
Change:
Gitlint CLI tool and pre-commit hook plugin to lint commit messages with presets Metadata homepage URL: source URL: license: MIT platforms: linux, unix, darwin (python3)
This isn't my library, I simply requested for this package. should i still be included as maintainer?
Also, do I make a PR with the code above? Or is there already a PR
There is no PR yet. New packages need a maintainer and I don't want to maintain this.
I'll do it. I'll send in a PR now.

Discussion:
<ins> { lib , buildPythonApplication , fetchFromGitHub , gitMinimal , arrow , click , sh , wheel }: buildPythonApplication rec { pname = "gitlint"; version = "0.15.1"; src = fetchFromGitHub { owner = "jorisroovers"; repo = "gitlint"; rev = "v${version}"; sha256 = "sha256-CqmE4V+svSuQAsoX0I3NpUqPU5CQf3fyCHJPrjUjHF4="; }; nativeBuildInputs = [ wheel ]; propagatedBuildInputs = [ arrow click sh ]; preCheck = '' export PATH="$out/bin:$PATH" ''; checkInputs = [ gitMinimal ]; meta = { description = "Linting for your git commit messages"; homepage = "http://jorisroovers.github.io/gitlint"; license = lib.licenses.mit; maintainers = with lib.maintainers; [ ethancedwards8 ]; }; } </ins>

gitless = callPackage ../applications/version-management/gitless { python = python3; }; <ins> gitlint = python3Packages.callPackage ../tools/misc/gitlint { }; </ins> gitter = callPackage  ../applications/networking/instant-messengers/gitter { }; gjs = callPackage ../development/libraries/gjs { };