jiebi/CodeConvo huggingface dataset:
Change:
Looks like the hardcoded URL - is not working anymore and returns: Having said that - installation from works.
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
looks like we have a bunch of locations to fix: ,kubernetes/test-infra,kubernetes/website Looks like this was their plan all along: They have yum/apt repos in:
/assign
Sorry that page is offline, we're looking at it internally () It's also worth nothing that (http does work) only has versions from 2018 and prior (I see 1.2.0 is being used here), newer + current versions are available at , but i'm not sure if there's changes between versions that would break your workflows. (Unfortunately we haven't gotten around to publishing debs for cfssl on yet.)
Seems like "" can't be used but "" works fine. Since the version 1.2.0 is old, I replace them with latest 1.5.0 installation from in Is that ok?
yes, 1.5.0 will do. thanks!
/sig testing

Discussion:
kernel=$(uname -s) case "${kernel}" in Linux) <del> curl --retry 10 -L -o cfssl https://pkg.cfssl.org/R1.2/cfssl_linux-amd64 curl --retry 10 -L -o cfssljson https://pkg.cfssl.org/R1.2/cfssljson_linux-amd64 </del> <ins> curl --retry 10 -L -o cfssl https://github.com/cloudflare/cfssl/releases/download/v1.5.0/cfssl_1.5.0_linux_amd64 curl --retry 10 -L -o cfssljson https://github.com/cloudflare/cfssl/releases/download/v1.5.0/cfssljson_1.5.0_linux_amd64 </ins> ;; Darwin) <del> curl --retry 10 -L -o cfssl https://pkg.cfssl.org/R1.2/cfssl_darwin-amd64 curl --retry 10 -L -o cfssljson https://pkg.cfssl.org/R1.2/cfssljson_darwin-amd64 </del> <ins> curl --retry 10 -L -o cfssl https://github.com/cloudflare/cfssl/releases/download/v1.5.0/cfssl_1.5.0_darwin_amd64 curl --retry 10 -L -o cfssljson https://github.com/cloudflare/cfssl/releases/download/v1.5.0/cfssljson_1.5.0_darwin_amd64 </ins> ;; *) echo "Unknown, unsupported platform: ${kernel}." >&2
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: ! What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.20.1 Cloud provider or hardware configuration: OS (e.g: ): 7 Kernel (e.g. ): Linux zsm-test-2 3.10.0-1160.11.1.el7.x8664 SMP Fri Dec 18 16:34:56 UTC 2020 x8664 x8664 x86_64 GNU/Linux Install tools: Network plugin and version (if this is a network-related bug): Others:
/sig node
/triage accepted /priority backlog

Discussion:
`, inhibitDelayMax.Seconds()) logindOverridePath := filepath.Join(logindConfigDirectory, kubeletLogindConf) <del> if err := ioutil.WriteFile(logindOverridePath, []byte(inhibitOverride), 0755); err != nil { </del> <ins> if err := ioutil.WriteFile(logindOverridePath, []byte(inhibitOverride), 0644); err != nil { </ins> return fmt.Errorf("failed writing logind shutdown inhibit override file %v: %v", logindOverridePath, err) }
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: kubelet from panic after getting the wrong signal, and restart. ! What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.20.1 Cloud provider or hardware configuration: OS (e.g: ): 7 Kernel (e.g. ): Linux zsm-test-2 3.10.0-1160.11.1.el7.x8664 SMP Fri Dec 18 16:34:56 UTC 2020 x8664 x8664 x86_64 GNU/Linux Install tools: Network plugin and version (if this is a network-related bug): Others:
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig node

Discussion:
case event := <-busChan: if event == nil || len(event.Body) == 0 { klog.Errorf("Failed obtaining shutdown event, PrepareForShutdown event was empty") <ins> continue </ins> } shutdownActive, ok := event.Body[0].(bool) if !ok { klog.Errorf("Failed obtaining shutdown event, PrepareForShutdown event was not bool type as expected") <del> return </del> <ins> continue </ins> } shutdownChan <- shutdownActive }
Change:
<!-- Please only use this template for submitting reports about continuously failing tests or jobs in Kubernetes CI --Which jobs are failing: Which test(s) are failing: Since when has it been failing: From about 9 hours ago. Testgrid link: Reason for failure: Unknown. Anything else we need to know: Along with this job, even for started failing with similar tests. While is failing, is not failing indicating that something went in master in last 9 hours that's breaking the tests.
/sig node
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
One interesting note on CRIO job is, it's only failing when run by test-infra. If I trigger those jobs locally it completes successfully. Maybe something broke in ? not sure. That's the way to trigger node e2e from your local system (make sure gcloud is configured because just like test-infra, the actual tests are run on gcloud)
/cc
I believe I have identified the issue stemming from Working on fix now :+1: /assign
Fix in

Discussion:
flags.StringVar(&framework.TestContext.SystemSpecName, "system-spec-name", "", "The name of the system spec (e.g., gke) that's used in the node e2e test. The system specs are in test/e2e_node/system/specs/. This is used by the test framework to determine which tests to run for validating the system requirements.") flags.Var(cliflag.NewMapStringString(&framework.TestContext.ExtraEnvs), "extra-envs", "The extra environment variables needed for node e2e tests. Format: a list of key=value pairs, e.g., env1=val1,env2=val2") flags.StringVar(&framework.TestContext.SriovdpConfigMapFile, "sriovdp-configmap-file", "", "The name of the SRIOV device plugin Config Map to load.") <del> flag.StringVar(&framework.TestContext.ClusterDNSDomain, "dns-domain", "cluster.local", "The DNS Domain of the cluster.") </del> <ins> flag.StringVar(&framework.TestContext.ClusterDNSDomain, "dns-domain", "", "The DNS Domain of the cluster.") </ins> } func init() {
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: ! What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.20.1 Cloud provider or hardware configuration: OS (e.g: ): 7 Kernel (e.g. ): Linux zsm-test-2 3.10.0-1160.11.1.el7.x8664 SMP Fri Dec 18 16:34:56 UTC 2020 x8664 x8664 x8664 GNU/Linux Install tools: Network plugin and version (if this is a network-related bug): Others:
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig node

Discussion:
if err != nil { return err } <ins> if m.inhibitLock != 0 { m.dbusCon.ReleaseInhibitLock(m.inhibitLock) } </ins> m.inhibitLock = lock return nil }
Change:
<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: - Which test(s) are flaking: Testgrid link: https://k8s- https://k8s- Reason for failure: Anything else we need to know: Having some trouble with finding this in Triage, but here are two example failures: /sig network <!-- Please see the deflaking doc () for more guidance! --
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign I'll take time to see it.
Any updates on this? Should we triage-accept it?

Discussion:
svcName := fmt.Sprintf("%s.%s.svc.%s", svc.Name, svc.Namespace, framework.TestContext.ClusterDNSDomain) // Service must resolve to IP cmd := fmt.Sprintf("nslookup %s", svcName) <del> _, stderr, err := framework.RunHostCmdWithFullOutput(pod.Namespace, pod.Name, cmd) // NOTE(claudiub): nslookup may return 0 on Windows, even though the DNS name was not found. In this case, // we can check stderr for the error. if err != nil || (framework.NodeOSDistroIs("windows") && strings.Contains(stderr, fmt.Sprintf("can't find %s", svcName))) { return fmt.Errorf("ExternalName service %q must resolve to IP", pod.Namespace+"/"+pod.Name) } return nil </del> <ins> return wait.PollImmediate(framework.Poll, ServiceReachabilityShortPollTimeout, func() (done bool, err error) { _, stderr, err := framework.RunHostCmdWithFullOutput(pod.Namespace, pod.Name, cmd) // NOTE(claudiub): nslookup may return 0 on Windows, even though the DNS name was not found. In this case, // we can check stderr for the error. if err != nil || (framework.NodeOSDistroIs("windows") && strings.Contains(stderr, fmt.Sprintf("can't find %s", svcName))) { framework.Logf("ExternalName service %q failed to resolve to IP", pod.Namespace+"/"+pod.Name) return false, nil } return true, nil }) </ins> } // CheckServiceReachability ensures that request are served by the services. Only supports Services with type ClusterIP, NodePort and ExternalName.
Change:
What happened: Kubectl patch sub-command shows wrong error help message if an input is wrong. The error message says and when I try to use flag it says . What you expected to happen: I expected either the first error message to not have or should have a flag . How to reproduce it (as minimally and precisely as possible): If you run the following command without a node name you get this error: As the above error said you can specify , you specify that. This fails with another error saying is unknown flag: And in the help there is no flag: Environment: Kubernetes version (use ):
/sig cli
I think we need to decide whether to add flag --all and --selector to kubectl patch. After the decision, i can help.
/assign
on my queue, will look tomorrow :D
/triage accepted Probably just need to update error message here.
oh sorry, missed that one. Will look now
/assign
OK, so we decided to correct the error message per the PR right? :)
as you're dealing with this PR, I'll left you as assignee and follow the PR review :) /unassign

Discussion:
return &Result{err: err} } } <del> return &Result{err: fmt.Errorf("resource(s) were provided, but no name, label selector, or --all flag specified")} </del> <ins> return &Result{err: fmt.Errorf("resource(s) were provided, but no name was specified")} </ins> } return &Result{err: missingResourceError} }

"resources but no selectors": { args: []string{"pods"}, errFn: func(err error) bool { <del> return strings.Contains(err.Error(), "resource(s) were provided, but no name, label selector, or --all flag specified") </del> <ins> return strings.Contains(err.Error(), "resource(s) were provided, but no name was specified") </ins> }, }, "multiple resources but no selectors": { args: []string{"pods,deployments"}, errFn: func(err error) bool { <del> return strings.Contains(err.Error(), "resource(s) were provided, but no name, label selector, or --all flag specified") </del> <ins> return strings.Contains(err.Error(), "resource(s) were provided, but no name was specified") </ins> }, }, }

"resources but no selectors": { args: []string{"pods", "app=bar"}, errFn: func(err error) bool { <del> return strings.Contains(err.Error(), "resource(s) were provided, but no name, label selector, or --all flag specified") </del> <ins> return strings.Contains(err.Error(), "resource(s) were provided, but no name was specified") </ins> }, }, "multiple resources but no selectors": { args: []string{"pods,deployments", "app=bar"}, errFn: func(err error) bool { <del> return strings.Contains(err.Error(), "resource(s) were provided, but no name, label selector, or --all flag specified") </del> <ins> return strings.Contains(err.Error(), "resource(s) were provided, but no name was specified") </ins> }, }, }
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: There is an metric in kubelet, which is used to track the number of containers per pod. The current metric data format is The number of containers in the pod will definitely not be less than 1, so the bucket is set to have optimized space What you expected to happen: Would it be better if optimized to the following bucket How to reproduce it (as minimally and precisely as possible): curl kubelet metrics endpoint Anything else we need to know?: Environment: Kubernetes version (use ): 1.19,1.20 Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others: /sig node /area kubelet
/assign
/triage accepted

Discussion:
}, []string{NodeLabelKey}, ) <del> // ContainersPerPodCount is a Counter that tracks the number of containers per pod. </del> <ins> // ContainersPerPodCount is a Histogram that tracks the number of containers per pod. </ins> ContainersPerPodCount = metrics.NewHistogram( &metrics.HistogramOpts{ Subsystem:      KubeletSubsystem, Name:           "containers_per_pod_count", Help:           "The number of containers per pod.", <del> Buckets:        metrics.DefBuckets, </del> <ins> Buckets:        metrics.ExponentialBuckets(1, 2, 5), </ins> StabilityLevel: metrics.ALPHA, }, )
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: ! What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.20.1 Cloud provider or hardware configuration: OS (e.g: ): 7 Kernel (e.g. ): Linux zsm-test-2 3.10.0-1160.11.1.el7.x8664 SMP Fri Dec 18 16:34:56 UTC 2020 x8664 x8664 x8664 GNU/Linux Install tools: Network plugin and version (if this is a network-related bug): Others:
/sig node
Do you know how to reproduce this problem?
Yes, can reproduce the problem stably, but the steps are a little complicated.
/triage accepted

Discussion:
// pod stats api summarizes ephemeral storage usage (container, emptyDir, host[etc-hosts, logs]) podEphemeralStorageTotalUsage := &resource.Quantity{} <del> if podStats.EphemeralStorage != nil { </del> <ins> if podStats.EphemeralStorage != nil && podStats.EphemeralStorage.UsedBytes != nil { </ins> podEphemeralStorageTotalUsage = resource.NewQuantity(int64(*podStats.EphemeralStorage.UsedBytes), resource.BinarySI) } podEphemeralStorageLimit := podLimits[v1.ResourceEphemeralStorage]
Change:
<!-- Please only use this template for submitting enhancement requests --What would you like to be : Add Support for Windows Server version 2004 and 20H2. Why is this needed: Windows Server version 1909 is going end of life.
/sig windows /triage accepted

Discussion:
# Path for kube-proxy kubeconfig file on Windows nodes. export WINDOWS_KUBEPROXY_KUBECONFIG_FILE="${WINDOWS_K8S_DIR}kubeproxy.kubeconfig" # Pause container image for Windows container. <del> export WINDOWS_INFRA_CONTAINER="gcr.io/gke-release/pause-win:1.2.1" </del> <ins> export WINDOWS_INFRA_CONTAINER="gcr.io/gke-release/pause-win:1.5.1" </ins> # Storage Path for csi-proxy. csi-proxy only needs to be installed for Windows. export CSI_PROXY_STORAGE_PATH="https://storage.googleapis.com/gke-release/csi-proxy" # Version for csi-proxy

# Override this to use a different kubectl binary. kubectl=kubectl linux_deployment_timeout=60 <del> windows_deployment_timeout=300 </del> <ins> windows_deployment_timeout=600 </ins> output_file=/tmp/k8s-smoke-test.out function check_windows_nodes_are_ready {

spec: containers: - name: agnhost <del> image: e2eteam/agnhost:2.8 </del> <ins> image: e2eteam/agnhost:2.26 </ins> args: - serve-hostname nodeSelector:

spec: containers: - name: pause-win <del> image: gcr.io/gke-release/pause-win:1.2.0 </del> <ins> image: gcr.io/gke-release/pause-win:1.5.1 </ins> nodeSelector: kubernetes.io/os: windows tolerations:

# curl-ing the metrics-server service downloads 14 bytes of unprintable binary # data and sets a return code of success (0). if ! $kubectl exec "$linux_command_pod" --  <del> curl -s -m 20 "http://$service_ip:$service_port" &> $output_file; then </del> <ins> curl -s -m 20 --insecure "https://$service_ip:$service_port" &> $output_file; then </ins> cleanup_deployments echo "Failing output: $(cat $output_file)" echo "FAILED: ${FUNCNAME[0]}"
Change:
What happened: Cannot enter the process namespace using with target parameter. The nginx process does not appear, but a pause process instead. What you expected to happen: Enter the process namespace of a target container and see processes running inside it. How to reproduce it (as minimally and precisely as possible): a Pod. with target parameter and show processes. Anything else we need to know?: Environment: Kubernetes version (use ): 1.19.7 OS (e.g: ):Kernel (e.g. ): Install tools: CKE Network plugin and version (if this is a network-related bug): Coil v2.0.5 Others: Container Runtime: containerd 1.4.3
/sig cli
Add the parameter to try
I know I can see all processes including nginx and pause with , but why parameter doesn't work as expected on my environment? I thought it targets the process namespace of another container.
/assign Please take a look and accept if so.
/triage accepted
I suspect this is because containerd hasn't implemented This works for me with the builtin dockershim: I know that dockershim is slated for removal soon, so we should ask containerd to support this.
We should probably print a warning that requires support from the runtime
Opened to discuss this with the containerd authors.
Did you try this with ? I tried which didn't work for me with the message : Error: unknown flag: --share-processes See 'kubectl alpha debug --help' for usage. ( And this doesn't list --share-processes as an option ) this suggests me that kubectl alpha debug doesn't have --share-processes option enabled at least until kubectl version v1.18.4 Environment : Kubernetes version (use kubectl version): 1.18.4 Others: Container Runtime: containerd 1.3.3
containerd now has an open PR to fix this (containerd/containerd)
containerd/containerd has been resolved. containerd plans to support namespace targeting in the 1.5 release.
/close
Closing this issue. <detailsIn response to : /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
} // TargetContainer <del> if len(o.TargetContainer) > 0 && len(o.CopyTo) > 0 { return fmt.Errorf("--target is incompatible with --copy-to. Use --share-processes instead.") </del> <ins> if len(o.TargetContainer) > 0 { if len(o.CopyTo) > 0 { return fmt.Errorf("--target is incompatible with --copy-to. Use --share-processes instead.") } if !o.Quiet { // If the runtime doesn't support container namespace targeting this will fail silently, which has caused // some confusion (ex: https://issues.k8s.io/98362), so print a warning. This can be removed when // EphemeralContainers are generally available. fmt.Fprintf(o.Out, "Targeting container %q. If you don't see processes from this container it may be because the container runtime doesn't support this feature.n", o.TargetContainer) // TODO(verb): Add a list of supported container runtimes to https://kubernetes.io/docs/concepts/workloads/pods/ephemeral-containers/ and then link here. } </ins> } // TTY
Change:
<!-- Please only use this template for submitting enhancement requests --What would you like to be : // See right address of restful-serve- in the comment of Why is this needed: the address of restful-serve- in the comment of is wrong now
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
/sig Docs
/kind cleanup /remove-kind feature

Discussion:
// Install func registers the logs handler. func (l Logs) Install(c *restful.Container) { // use restful: ws.Route(ws.GET("/logs/{logpath:*}").To(fileHandler)) <del> // See github.com/emicklei/go-restful/blob/master/examples/restful-serve-static.go </del> <ins> // See github.com/emicklei/go-restful/blob/master/examples/static/restful-serve-static.go </ins> ws := new(restful.WebService) ws.Path("/logs") ws.Doc("get log files")