jiebi/CodeConvo huggingface dataset:
Change:
What happened: After fixing golint failures under , we need to put for each and . Then common error checking code has become like: We can replace this code with which is more readable and easy to be understood what the code does. Now we have following e2e test directories which can be replaced: [x] test/e2e/apimachinery () [x] test/e2e/apps () [x] test/e2e/auth () [x] test/e2e/autoscaling () [x] test/e2e/cloud () [x] test/e2e/common () [ ] test/e2e/framework () [x] test/e2e/kubectl () [x] test/e2e/lifecycle () [x] test/e2e/network () [x] test/e2e/node () [x] test/e2e/scalability () [x] test/e2e/scheduling () [x] test/e2e/servicecatalog () [x] test/e2e/storage () [x] test/e2e/upgrades () [x] test/e2e/windows () [x] () [x] () [x] () [x] () [x] () [x] () [x] () [x] () [x] () [x] () [x] () [x] ()
/sig testing
I will work test/e2e/kubectl.
I can work test/e2e/scheduling.
I will work /test/e2e/cloud
I could work on these file
I created and to cleanup gomega in these files, I could take more to work:
I will work for the rest
/reopen Regards, Draven
Reopened this issue. <detailsIn response to : /reopen Draven On Jul 6, 2019, 10:03 AM +0800, Kubernetes Prow Robot , wrote: Closed via . — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread. </details
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
I will work on
I will work
I'll work on the rest
Thanks for raising your hands. All items are fulfilled :-)
/remove-kind bug /kind cleanup

Discussion:
} func computeQuantile(sample []float64, quantile float64) float64 { <del> gomega.Expect(sort.Float64sAreSorted(sample)).To(gomega.Equal(true)) gomega.Expect(quantile >= 0.0 && quantile <= 1.0).To(gomega.Equal(true)) </del> <ins> framework.ExpectEqual(sort.Float64sAreSorted(sample), true) framework.ExpectEqual(quantile >= 0.0 && quantile <= 1.0, true) </ins> index := int(quantile*float64(len(sample))) - 1 if index < 0 { return math.NaN()

// Fail if there were some high-latency requests. gomega.Expect(highLatencyRequests).NotTo(gomega.BeNumerically(">", 0), "There should be no high-latency requests") // Fail if more than the allowed threshold of measurements were missing in the latencyTest. <del> gomega.Expect(missingMeasurements <= MaxMissingPodStartupMeasurements).To(gomega.Equal(true)) </del> <ins> framework.ExpectEqual(missingMeasurements <= MaxMissingPodStartupMeasurements, true) </ins> }) options := framework.Options{

if !ok { e2elog.Logf("Failed to cast observed object to *v1.Pod.") } <del> gomega.Expect(ok).To(gomega.Equal(true)) </del> <ins> framework.ExpectEqual(ok, true) </ins> go checkPod(p) }, UpdateFunc: func(oldObj, newObj interface{}) {

if !ok { e2elog.Logf("Failed to cast observed object to *v1.Pod.") } <del> gomega.Expect(ok).To(gomega.Equal(true)) </del> <ins> framework.ExpectEqual(ok, true) </ins> go checkPod(p) }, },
Change:
What happened: After fixing golint failures under , we need to put for each and . Then common error checking code has become like: We can replace this code with which is more readable and easy to be understood what the code does. Now we have following e2e test directories which can be replaced: [x] test/e2e/apimachinery () [x] test/e2e/apps () [x] test/e2e/auth () [x] test/e2e/autoscaling () [x] test/e2e/cloud () [x] test/e2e/common () [ ] test/e2e/framework () [x] test/e2e/kubectl () [x] test/e2e/lifecycle () [x] test/e2e/network () [x] test/e2e/node () [x] test/e2e/scalability () [x] test/e2e/scheduling () [x] test/e2e/servicecatalog () [x] test/e2e/storage () [x] test/e2e/upgrades () [x] test/e2e/windows () [x] () [x] () [x] () [x] () [x] () [x] () [x] () [x] () [x] () [x] () [x] () [x] ()
/sig testing
I will work test/e2e/kubectl.
I can work test/e2e/scheduling.
I will work /test/e2e/cloud
I could work on these file
I created and to cleanup gomega in these files, I could take more to work:
I will work for the rest
/reopen Regards, Draven
Reopened this issue. <detailsIn response to : /reopen Draven On Jul 6, 2019, 10:03 AM +0800, Kubernetes Prow Robot , wrote: Closed via . — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread. </details
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
I will work on
I will work
I'll work on the rest
Thanks for raising your hands. All items are fulfilled :-)
/remove-kind bug /kind cleanup

Discussion:
fi done <ins> errors_expect_equal=() for file in "${all_e2e_files[@]}" do if grep -E "Expect(.*).To((gomega.Equal|Equal)" "${file}" > /dev/null then errors_expect_equal+=( "${file}" ) fi done </ins> if [ ${#errors_expect_no_error[@]} -ne 0 ]; then { echo "Errors:"

exit 1 fi <ins> if [ ${#errors_expect_equal[@]} -ne 0 ]; then { echo "Errors:" for err in "${errors_expect_equal[@]}"; do echo "$err" done echo echo 'The above files need to use framework.ExpectEqual(foo, bar) instead of ' echo 'Expect(foo).To(Equal(bar)) or gomega.Expect(foo).To(gomega.Equal(bar))' echo } >&2 exit 1 fi </ins> echo 'Congratulations!  All e2e test source files are valid.'
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: is unset on a networking daemonset pod used by (read via the downward api). Previously this was reliably set to match the hostIP. What you expected to happen: This should be the hostIP (which is set). How to reproduce it (as minimally and precisely as possible): We know the kind CI tests cover this ,%20master%20(dev)%20%5Bnon-serial%5D&show-stale-tests=&width=5 Anything else we need to know?: This is also tracked in , we observed this change in Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:
/sig network /cc /priority important-soon
/assign

Discussion:
for _, ipInfo := range apiPodStatus.PodIPs { podStatus.IPs = append(podStatus.IPs, ipInfo.IP) } <ins> if len(podStatus.IPs) == 0 && len(apiPodStatus.PodIP) > 0 { podStatus.IPs = []string{apiPodStatus.PodIP} } </ins> // Record the time it takes for the pod to become running. existingStatus, ok := kl.statusManager.GetPodStatus(pod.UID) if !ok || existingStatus.Phase == v1.PodPending && apiPodStatus.Phase == v1.PodRunning &&
Change:
What happened: When doing , the Allow Privileged Escalation output shows a hex-encoded value instead of a stringified boolean: What you expected to happen: Show the stringified boolean value instead. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Solution turned out to be simple. Change this line: to be instead of .
/sig cli
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
Stale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten
This was fixed with

Discussion:
w.Write(LEVEL_0, "nSettings:n") w.Write(LEVEL_1, "Allow Privileged:t%tn", psp.Spec.Privileged) <del> w.Write(LEVEL_1, "Allow Privilege Escalation:t%vn", psp.Spec.AllowPrivilegeEscalation) </del> <ins> if psp.Spec.AllowPrivilegeEscalation != nil { w.Write(LEVEL_1, "Allow Privilege Escalation:t%tn", *psp.Spec.AllowPrivilegeEscalation) } else { w.Write(LEVEL_1, "Allow Privilege Escalation:t<unset>n") } </ins> w.Write(LEVEL_1, "Default Add Capabilities:t%vn", capsToString(psp.Spec.DefaultAddCapabilities)) w.Write(LEVEL_1, "Required Drop Capabilities:t%sn", capsToString(psp.Spec.RequiredDropCapabilities)) w.Write(LEVEL_1, "Allowed Capabilities:t%sn", capsToString(psp.Spec.AllowedCapabilities))

expected := []string{ "Name:s*mypsp", "Allow Privileged:s*false", <ins> "Allow Privilege Escalation:s*false", </ins> "Default Add Capabilities:s*<none>", "Required Drop Capabilities:s*<none>", "Allowed Capabilities:s*<none>",

"Supplemental Groups Strategy: RunAsAny", } <ins> falseVal := false </ins> fake := fake.NewSimpleClientset(&policyv1beta1.PodSecurityPolicy{ ObjectMeta: metav1.ObjectMeta{ Name: "mypsp", }, Spec: policyv1beta1.PodSecurityPolicySpec{ <del> AllowedUnsafeSysctls: []string{"kernel.*", "net.ipv4.ip_local_port_range"}, ForbiddenSysctls:     []string{"net.ipv4.ip_default_ttl"}, </del> <ins> AllowPrivilegeEscalation: &falseVal, AllowedUnsafeSysctls:     []string{"kernel.*", "net.ipv4.ip_local_port_range"}, ForbiddenSysctls:         []string{"net.ipv4.ip_default_ttl"}, </ins> SELinux: policyv1beta1.SELinuxStrategyOptions{ Rule: policyv1beta1.SELinuxStrategyRunAsAny, },
Change:
Which jobs are failing: ci-kubernetes-e2e-gce-new-master-upgrade-master-parallel Which test(s) are failing: [sig-apps] Deployment deployment should support rollback Since when has it been failing: 06-22 - 17:13 PDT Testgrid link: Reason for failure: Anything else we need to know: /priority critical-urgent /kind failing-test /sig apps
I will look in test together with
/milestone v1.16
stopped serving those APIs in 1.16. The test in the release-1.15 branch should skip if the server it is testing against does not serve the deprecated extensions/v1beta1 API
closing
and did not completely resolve the failing tests here or in /reopen
Reopened this issue. <detailsIn response to : and did not completely resolve the failing tests here or in /reopen </details
this job is running 1.14-level tests against master (1.16). the test should be updated to run 1.15 against master
Possible issue here is that we may have misconfigured upgrade/downgrade jobs (upgrading/downgrading to incorrect k8s versions). For full discussion see
/assign
Ultimately, the issue with this and was the the Kubernetes release markers did not point to the releases we expected. This was fixed during the recent 1.16 alpha release. /close
Closing this issue. <detailsIn response to : Ultimately, the issue with this and was the the Kubernetes release markers did not point to the releases we expected. This was fixed during the recent 1.16 alpha release. /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
"k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/labels" <ins> "k8s.io/apimachinery/pkg/runtime/schema" </ins> "k8s.io/apimachinery/pkg/types" "k8s.io/apimachinery/pkg/util/intstr" "k8s.io/apimachinery/pkg/util/wait"

var ( nilRs *apps.ReplicaSet <ins> // DeploymentGroupVersionResource identifies a Deployment resource. DeploymentGroupVersionResource = schema.GroupVersionResource{Group: extensions.GroupName, Version: "v1beta1", Resource: "deployments"} </ins> ) var _ = SIGDescribe("Deployment", func() {

// Then rollback the deployment to revision 10 (doesn't exist in history) should fail. // Finally, rollback current deployment (revision 4) to revision 4 should be no-op. func testRollbackDeployment(f *framework.Framework) { <ins> // extensions/v1beta1 is deprecated, only testing if the server serves this api framework.SkipIfMissingResource(f.DynamicClient, DeploymentGroupVersionResource, f.Namespace.Name) </ins> ns := f.Namespace.Name c := f.ClientSet podName := "nginx"
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: dir crated in would not be automatically removed. What you expected to happen: when a pod delete the, the dir would be removed How to reproduce it (as minimally and precisely as possible): create a pod using csi raw block volume and delete it Anything else we need to know?: ! pod using pv--6195-49a0-b262- actually has been deleted and the volume has been unmounted, but the dir still exists. ! {pv}/data still exists Environment: Kubernetes version (use ): 1.15 Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:
/sig storage /assign
I am afraid that the fix won't work for all volume plugins. I randomly checked where some volume plugins symlinks a device: iscsi: aws: So, iSCSI would be cleaned with this PR, but just as a coincidence, not as deliberate design. And AWS would still leave orphaned . I am not convinced that this we don't have a plugin that does not use subdirectories. I think a better approach is necessary. Perhaps of every plugin should clean up everything that created?
thanks for your advice, I would try to find a better approach
/reopen
Reopened this issue. <detailsIn response to : /reopen </details
is being reverted because it broke CSI block volume cleanup
/assign
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
Stale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten
/remove-lifecycle rotten is this still an issue?
I am adding CSI directories cleanup in
This should be fixed by /close
Closing this issue. <detailsIn response to : This should be fixed by /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
"errors" "fmt" "os" <ins> "path" </ins> "path/filepath" "k8s.io/klog"

} } <ins> dataDir := getVolumeDeviceDataDir(m.specName, m.plugin.host) // remove ~/${pv}/data/vol_data.json first, then remove the other dir. volDataFile := path.Join(dataDir, volDataFileName) err = os.Remove(volDataFile) if err != nil && !os.IsNotExist(err) { return err } // remove ~/${pv}/data err = os.Remove(dataDir) if err != nil && !os.IsNotExist(err) { return err } // remove ~/${pv} pvPath := filepath.Dir(dataDir) err = os.Remove(pvPath) if err != nil && !os.IsNotExist(err) { return err } </ins> return nil }
Change:
There are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
local targets=( vendor/github.com/onsi/ginkgo/ginkgo test/e2e/e2e.test <ins> cluster/images/conformance/go-runner </ins> cmd/kubectl ) echo "${targets[@]}"
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: runs as a APIService but it fails with and the endpoint returns on kubernetes clusters with v1.15. It works with all previous cluster versions perfectly but gives the following status on v1.15 but I also don't see any changes in Releasing notes that effects APIService What you expected to happen: APISerice should run correctly and the endpoint should be responding. How to reproduce it (as minimally and precisely as possible): Linkerd dosent have to be installed to check this, and discovery happens directly at the url without any communication with the underlying mesh. In the repo, running this generates the required certs and applies the config to the cluster To check the status of the APIService, can be used Anything else we need to know?: I did check with clean 1.15 clusters and its the same. I also don't see any changes in 1.15 release notes that effects APIServices. Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others: Testing is done on kind but its the same with minikube
/sig api-machinery
that sounds bad.. i didnt remember any breaking change except for making the port confiugrable.. /cc
what does interrogating the service directly return?
On Clusters 1.15, where the status of APIService is it gives On Clusters 1.14.3, where the status of APIService is it gives
looks related If the aggregated server returns non-200 status code, it is treated as unavailable. what endpoint is checked by the available controller?
i skimmed implementation from smi-metrics.. it only serves on prefixes so when the available controller checks the root endpoint it returns a 404.
but then it dosent fail on clusters running v1.14, In that version the apiService is marked as
fixed by , picked to 1.15.x in , will be in v1.15.1
Awesome Thanks for the quick fix :)

Discussion:
results <- err return } <ins> discoveryURL.Path = "/apis/" + apiService.Spec.Group + "/" + apiService.Spec.Version </ins> errCh := make(chan error) go func() { <ins> // be sure to check a URL that the aggregated API server is required to serve </ins> newReq, err := http.NewRequest("GET", discoveryURL.String(), nil) if err != nil { errCh <- err

return &apiregistration.APIService{ ObjectMeta: metav1.ObjectMeta{Name: name}, Spec: apiregistration.APIServiceSpec{ <ins> Group:   strings.SplitN(name, ".", 2)[0], Version: strings.SplitN(name, ".", 2)[1], </ins> Service: &apiregistration.ServiceReference{ Namespace: "foo", Name:      "bar",
Change:
/assign Cannot find either of these aliases ref
thanks /sig cluster-lifecycle let me know if want me to PR a fix, yet i don't know what action to take. do you wish to keep these aliases?
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
Stale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten
/lifecycle frozen
/assign /lifecycle active

Discussion:
# See the OWNERS docs at https://go.k8s.io/owners approvers: <del> - sig-cluster-lifecycle-maintainers </del> <ins> - luxas - timothysc - fabriziopandini - neolit123 - rosti - ereslibre </ins> reviewers: <del> - sig-cluster-lifecycle </del> <ins> - luxas - timothysc - fabriziopandini - neolit123 - kad - detiber - dixudx - rosti - yagonobre - ereslibre - SataQiu - yastij </ins> labels: - sig/cluster-lifecycle

<del> # See the OWNERS docs at https://go.k8s.io/owners approvers:  #sig-cluster-lifecycle is the owner of this feature - luxas - wanghaoran1988 reviewers: - mikedanese - luxas - dmmcquay - krousey - wanghaoran1988 emeritus_approvers: - jbeda </del>  No newline at end of file
Change:
The plugin and/or the code behind the plugin does not seem to be maintained, is it time to deprecate it?
/sig storage
cc ?
/area code-organization
LGTM

Discussion:
CSIVolumePublished CSIVolumePhaseType = "published" ) <ins> var ( deprecatedVolumeProviders = map[string]string{ "kubernetes.io/cinder":  "The Cinder volume provider is deprecated and will be removed in a future release", "kubernetes.io/scaleio": "The ScaleIO volume provider is deprecated and will be removed in a future release", } ) </ins> // VolumeOptions contains option information about a volume. type VolumeOptions struct { // The attributes below are required by volume.Provisioner

} return nil, fmt.Errorf("multiple volume plugins matched: %s", strings.Join(matchedPluginNames, ",")) } <ins> // Issue warning if the matched provider is deprecated if detail, ok := deprecatedVolumeProviders[matches[0].GetPluginName()]; ok { klog.Warningf("WARNING: %s built-in volume provider is now deprecated. %s", matches[0].GetPluginName(), detail) } </ins> return matches[0], nil }
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: The image ` cannot be built anymore, since its mirrors has been archived. For more details, see: What you expected to happen: The image should be buildable. How to reproduce it (as minimally and precisely as possible): cd kubernetes/tests/images make all-container WHAT=jessie-dnsutils Anything else we need to know?: /sig testing /area conformance /priority important-soon Environment: N/A Kubernetes version (use ): N/A Cloud provider or hardware configuration: N/A OS (e.g: ): N/A Kernel (e.g. ): N/A Install tools: N/A Network plugin and version (if this is a network-related bug): N/A Others: N/A
/assign
ref:

Discussion:
case ${DEB_ARCH} in s390x|arm64|ppc64el) <del> sed -i '/debian-security/d' /etc/apt/sources.list ;; </del> <ins> # we have to use the archive mirrors. # See: https://lists.debian.org/debian-devel-announce/2019/03/msg00006.html echo "deb http://archive.debian.org/debian/ jessie main contrib non-free" | tee /etc/apt/sources.list echo "deb-src http://archive.debian.org/debian/ jessie main contrib non-free" | tee -a /etc/apt/sources.list ;; </ins> esac exit 0
Change:
The failure looks like this (example from ): Easy to recreate using the following snippet
There are no sig labels on this issue. Please add a sig label by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
cc

Discussion:
# The resource manifest is expecting something like 'registry/kube-controller-manager:v1.2.3', no arch specified. local -r images=$(docker images --format "{{.Repository}}:{{.Tag}}" | egrep 'kube-apiserver|kube-controller-manager|kube-scheduler|kube-proxy' | grep amd64) for image in $images ; do <del> local -r manifest_name="${image/-amd64/}" </del> <ins> local manifest_name="${image/-amd64/}" </ins> if ! docker images --format "{{.Repository}}:{{.Tag}}" | grep -q ${manifest_name} ; then docker tag $image $manifest_name fi