Change:
Cluster logging assumes kubelet stores container log at a specific directory with specific name. Currently the path is: After the CRI work, the path will be: However, we don't have test coverage for this. We don't even know whether the log files are there or not. We should add a node e2e test for this, basically: 1) Create a container which prints logs 2) Check whether the expected log file is created. 3) Check whether the logs are collected in the file as expected. And it would be better to launch a pod to do the check instead of accessing local file system directly, which makes containerizing easier. /cc because you are collecting missing test. /cc
I will try to add a node-e2e test there
I think it's ok to add this for CRI. But there maybe problems on today's interface for rkt. If I'm not wrong, rkt does't store logs at same location with docker. cc/ Is this true?
Thanks! :)
After gets merged, we need to update the test to verify the cri log path.

Discussion:
nodeStatusUpdateRetry = 5 // Location of container logs. <del> containerLogsDir = "/var/log/containers" </del> <ins> ContainerLogsDir = "/var/log/containers" </ins> // max backoff period, exported for the e2e test MaxContainerBackOff = 300 * time.Second

kubeCfg.PodInfraContainerImage, float32(kubeCfg.RegistryPullQPS), int(kubeCfg.RegistryBurst), <del> containerLogsDir, </del> <ins> ContainerLogsDir, </ins> kubeDeps.OSInterface, klet.networkPlugin, klet,

} // Step 3: If the container logs directory does not exist, create it. <del> if _, err := os.Stat(containerLogsDir); err != nil { if err := kl.os.MkdirAll(containerLogsDir, 0755); err != nil { glog.Errorf("Failed to create directory %q: %v", containerLogsDir, err) </del> <ins> if _, err := os.Stat(ContainerLogsDir); err != nil { if err := kl.os.MkdirAll(ContainerLogsDir, 0755); err != nil { glog.Errorf("Failed to create directory %q: %v", ContainerLogsDir, err) </ins> } }

} // If the container logs directory does not exist, create it. <del> if _, err := os.Stat(containerLogsDir); err != nil { if err := kl.os.MkdirAll(containerLogsDir, 0755); err != nil { glog.Errorf("Failed to create directory %q: %v", containerLogsDir, err) </del> <ins> if _, err := os.Stat(ContainerLogsDir); err != nil { if err := kl.os.MkdirAll(ContainerLogsDir, 0755); err != nil { glog.Errorf("Failed to create directory %q: %v", ContainerLogsDir, err) </ins> } }

go_library( name = "go_default_library", srcs = [ <ins> "bindata.go", </ins> "main.go", <del> ":bindata", ], ) genrule( name = "bindata", srcs = [ "//examples:sources", "//test/images:sources", "//test/fixtures:sources", "//test/e2e/testing-manifests:sources", ], outs = ["bindata.go"], cmd = """ $(location //vendor:github.com/jteeuwen/go-bindata/go-bindata)  -nometadata -o "$(OUTS)" -pkg generated  -prefix $$(pwd)  -ignore .jpg -ignore .png -ignore .md  $(SRCS) """, tools = [ "//vendor:github.com/jteeuwen/go-bindata/go-bindata", </del> ], <ins> tags = ["automanaged"], </ins> )

"image_id_test.go", "kubelet_test.go", "lifecycle_hook_test.go", <ins> "log_path_test.go", </ins> "memory_eviction_test.go", "mirror_pod_test.go", "resource_usage_test.go",

"//pkg/api/unversioned:go_default_library", "//pkg/client/cache:go_default_library", "//pkg/client/clientset_generated/internalclientset:go_default_library", <ins> "//pkg/kubelet:go_default_library", </ins> "//pkg/kubelet/api/v1alpha1/stats:go_default_library", "//pkg/kubelet/cm:go_default_library", <ins> "//pkg/kubelet/container:go_default_library", </ins> "//pkg/kubelet/dockertools:go_default_library", "//pkg/kubelet/images:go_default_library", "//pkg/kubelet/metrics:go_default_library",

<ins> /* Copyright 2016 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package e2e_node import ( "k8s.io/kubernetes/pkg/api" "k8s.io/kubernetes/pkg/kubelet" kubecontainer "k8s.io/kubernetes/pkg/kubelet/container" "k8s.io/kubernetes/pkg/util/uuid" "k8s.io/kubernetes/test/e2e/framework" . "github.com/onsi/ginkgo" ) const logString = "This is the expected log content of this node e2e test" var _ = framework.KubeDescribe("ContainerLogPath", func() { f := framework.NewDefaultFramework("kubelet-container-log-path") Describe("Pod with a container", func() { Context("printed log to stdout", func() { It("should print log to correct log path", func() { podClient := f.PodClient() ns := f.Namespace.Name logDirVolumeName := "log-dir-vol" logDir := kubelet.ContainerLogsDir logPodName := "logger-" + string(uuid.NewUUID()) logContName := "logger-c-" + string(uuid.NewUUID()) checkPodName := "checker" + string(uuid.NewUUID()) checkContName := "checker-c-" + string(uuid.NewUUID()) logPod := &api.Pod{ ObjectMeta: api.ObjectMeta{ Name: logPodName, }, Spec: api.PodSpec{ // this pod is expected to exit successfully RestartPolicy: api.RestartPolicyNever, Containers: []api.Container{ { Image:   "gcr.io/google_containers/busybox:1.24", Name:    logContName, Command: []string{"sh", "-c", "echo " + logString}, }, }, }, } podClient.Create(logPod) err := framework.WaitForPodSuccessInNamespace(f.ClientSet, logPodName, ns) framework.ExpectNoError(err, "Failed waiting for pod: %s to enter success state", logPodName) // get containerID from created Pod createdLogPod, err := podClient.Get(logPodName) logConID := kubecontainer.ParseContainerID(createdLogPod.Status.ContainerStatuses[0].ContainerID) framework.ExpectNoError(err, "Failed to get pod: %s", logPodName) expectedlogFile := logDir + "/" + logPodName + "_" + ns + "_" + logContName + "-" + logConID.ID + ".log" checkPod := &api.Pod{ ObjectMeta: api.ObjectMeta{ Name: checkPodName, }, Spec: api.PodSpec{ // this pod is expected to exit successfully RestartPolicy: api.RestartPolicyNever, Containers: []api.Container{ { Image: "gcr.io/google_containers/busybox:1.24", Name:  checkContName, // If we find expected log file and contains right content, exit 0 // else, keep checking until test timeout Command: []string{"sh", "-c", "while true; do if [ -e " + expectedlogFile + " ] && grep -q " + logString + " " + expectedlogFile + "; then exit 0; fi; sleep 1; done"}, VolumeMounts: []api.VolumeMount{ { Name: logDirVolumeName, // mount ContainerLogsDir to the same path in container MountPath: expectedlogFile, ReadOnly:  true, }, }, }, }, Volumes: []api.Volume{ { Name: logDirVolumeName, VolumeSource: api.VolumeSource{ HostPath: &api.HostPathVolumeSource{ Path: expectedlogFile, }, }, }, }, }, } podClient.Create(checkPod) err = framework.WaitForPodSuccessInNamespace(f.ClientSet, checkPodName, ns) framework.ExpectNoError(err, "Failed waiting for pod: %s to enter success state", checkPodName) }) }) }) }) </ins>

Container Runtime Conformance Test container runtime conformance blackbox test when starting a container that exits should report termination message if TerminationMessagePath is set,timothysc,1 DNS horizontal autoscaling kube-dns-autoscaler should scale kube-dns pods in both nonfaulty and faulty scenarios,MrHohn,0 DNS horizontal autoscaling kube-dns-autoscaler should scale kube-dns pods when cluster size changed,MrHohn,0 <ins> ContainerLogPath Pod with a container printed log to stdout should print log to correct log path,resouer,0 </ins> DNS should provide DNS for ExternalName services,rmmh,1 DNS should provide DNS for pods for Hostname and Subdomain Annotation,mtaufen,1 DNS should provide DNS for services,roberthbailey,1