Change:
<!-- Please only use this template for submitting reports about continuously failing tests or jobs in Kubernetes CI -- tests 08/11 ~2:30PDT First fail run These tests appear to be newly in They have never passed as far as I can tell. Not sure why this was merged/not caught in CI. /cc /sig node
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
Hi thanks for pointing out. I was looking at this I thought I saw green runs in the latest tests. Please.correct me if I am wrong.
They're fine on that tab but they're broken in
I'm puzzled why they're even getting pulled into that job since they're marked ...
why does this feature need its own separate job for a single test?
Apologies, I'm not sure of the conventions for the tests. I wasn't given info/notified regarding this. Where else could I have put a test for this ?
since it's just the one test there are a number of jobs we could add this to. Let's discuss at the CI subproject tomorrow? I'll add this to the agenda.
When does the CI subproject happen ? If it fits the timezone, if like to atttend. I'd very much like to re-revert the changes and put this test in proper place with green runs
Agreed! It's tomorrow at 8am Pacific Time:

Discussion:
<del> // +build linux /* Copyright 2021 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package e2enode import ( "time" "golang.org/x/sys/unix" "github.com/onsi/ginkgo" "github.com/onsi/gomega" "k8s.io/kubernetes/test/e2e/framework" ) const contentionLockFile = "/var/run/kubelet.lock" var _ = SIGDescribe("Lock contention [Slow] [Disruptive] [NodeFeature:LockContention]", func() { ginkgo.It("Kubelet should stop when the test acquires the lock on lock file and restart once the lock is released", func() { ginkgo.By("perform kubelet health check to check if kubelet is healthy and running.") // Precautionary check that kubelet is healthy before running the test. gomega.Expect(kubeletHealthCheck(kubeletHealthCheckURL)).To(gomega.BeTrue()) ginkgo.By("acquiring the lock on lock file i.e /var/run/kubelet.lock") // Open the file with the intention to acquire the lock, this would imitate the behaviour // of the another kubelet(self-hosted) trying to start. When this lock contention happens // it is expected that the running kubelet must terminate and wait until the lock on the // lock file is released. // Kubelet uses the same approach to acquire the lock on lock file as shown here: // https://github.com/kubernetes/kubernetes/blob/master/cmd/kubelet/app/server.go#L530-#L546 // and the function definition of Acquire is here: // https://github.com/kubernetes/kubernetes/blob/master/pkg/util/flock/flock_unix.go#L25 fd, err := unix.Open(contentionLockFile, unix.O_CREAT|unix.O_RDWR|unix.O_CLOEXEC, 0600) framework.ExpectNoError(err) // Defer the lock release in case test fails and we don't reach the step of the release // lock. This ensures that we release the lock for sure. defer func() { err = unix.Flock(fd, unix.LOCK_UN) framework.ExpectNoError(err) }() // Acquire lock. err = unix.Flock(fd, unix.LOCK_EX) framework.ExpectNoError(err) ginkgo.By("verifying the kubelet is not healthy as there was a lock contention.") // Once the lock is acquired, check if the kubelet is in healthy state or not. // It should not be. gomega.Eventually(func() bool { return kubeletHealthCheck(kubeletHealthCheckURL) }, 10*time.Second, time.Second).Should(gomega.BeFalse()) ginkgo.By("releasing the lock on lock file i.e /var/run/kubelet.lock") // Release the lock. err = unix.Flock(fd, unix.LOCK_UN) framework.ExpectNoError(err) ginkgo.By("verifying the kubelet is healthy again after the lock was released.") // Releasing the lock triggers kubelet to re-acquire the lock and restart. // Hence the kubelet should report healthy state. gomega.Eventually(func() bool { return kubeletHealthCheck(kubeletHealthCheckURL) }, 10*time.Second, time.Second).Should(gomega.BeTrue()) }) }) </del>