jiebi/CodeConvo huggingface dataset:
Change:
Is this a BUG REPORT or FEATURE REQUEST? We should stop including the deb for CCM as part of Kubernetes releases. Given we almost always see cloud controller manager run within a container (as recommended). This is consistent with other controllers. /kind bug /sig release /sig cluster-lifecycle /sig cloud-provider cc
Resolved in :tada:

Discussion:
release_filegroup( name = "debs", srcs = [ <del> ":cloud-controller-manager.deb", </del> ":cri-tools.deb", ":kubeadm.deb", ":kubectl.deb",
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind feature What happened: With respect to the to promote e2e tests for conformance, while going through codebase, It is observed that this e2e test case is using deprecated (in 1.7) (OrphanDependents=nil). So we may not promote it to conformance as it is not meeting the . What you expected to happen: not promote this e2e tests for conformance. another e2e test with deleteOptions parameters as propagationPolicy="Orphan" to achieve same behaviour. Anything else we need to know?: Any suggestion or feedback is expected in order to promote this e2e test. Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: cc /area conformance
Reiterating the mentions to trigger a notification: <detailsIn response to : <!-- This form is for bug reports and feature requests ONLY! --/kind feature /kind bug /kind feature What happened: With respect to the to promote e2e tests for conformance, while going through codebase, It is observed that this e2e test case is using deprecated (in 1.7) (OrphanDependents=nil). So we may not promote it to conformance as it is not meeting the . Do not promote this e2e tests for conformance. Create another e2e test with deleteOptions parameters as propagationPolicy="Orphan" to achieve same behaviour. Any suggestion or feedback is expected in order to promote this e2e test. Kubernetes version (use ):OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /area conformance Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
your guidance on this will be helpful. Should we consider rewriting the e2e test and then promote it?
/cc who is on the blamelist for this test
As discussed offline in an email thread, can help rewrite the test as long as there's some guidance to help him get started.
So as per your observation here there's already a conformance test for deleteOptions? Ref: and let us know if the test referenced above tests the functionality fully or you need it updated.
Yes mentioned conformance test is verifying GC behavior with Orphan propagation.
based on discussion offline, it sounds like we don't want to bother promoting to conformance because is deprecated, let's document this next to the test to close this out, so we don't lose track and try promoting this in the future

Discussion:
gatherMetrics(f) }) <ins> // deleteOptions.OrphanDependents is deprecated in 1.7 and preferred to use the PropagationPolicy. // Discussion is tracked under https://github.com/kubernetes/kubernetes/issues/65427 to promote for conformance in future. </ins> It("should orphan pods created by rc if deleteOptions.OrphanDependents is nil", func() { clientSet := f.ClientSet rcClient := clientSet.CoreV1().ReplicationControllers(f.Namespace.Name)
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: What happened: What you expected to happen: I think should just show the help or something? How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): ubuntu 16.04 amd64 Kernel (e.g. ): Install tools: Others:
/sig cli
It has fixed in higher version:
You have 1.9.7, I was testing . There's a regression, it seems. Anyway, it's just a minor annoyance, it just looks ugly, that's all.
This is indeed a bug. /assign
with some arguments crash all the way from 1.9.0 to 1.10.5 (1.8.14 is ok): Command: (no trailing slash): 0: 10.5:
Off-topic, but kubectl 1.10.5 release binary also looks funky with in the path, while up to 1.9.3 it's clean . From 1.9.4 onwards it has changed to ?
Since this has fix candidate going in already, opened a separate issue for my variant:

Discussion:
} func (o *CopyOptions) Run(args []string) error { <ins> if len(args) < 2 { return fmt.Errorf("source and destination are required") } </ins> srcSpec, err := extractFileSpec(args[0]) if err != nil { return err
Change:
Was running a pod with an activeDeadlineSeconds on a 1.10 cluster. The pod reached the deadline, but the pod status did not contain the latest state of the pod containers (pod containersStatus was empty). The status only had the following fields: The statuses were there immediately prior to the deadline being reached. This broke API clients that were looking at container status.
Looks like the status is just overwritten here if returns true
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale

Discussion:
func (kl *Kubelet) generateAPIPodStatus(pod *v1.Pod, podStatus *kubecontainer.PodStatus) v1.PodStatus { glog.V(3).Infof("Generating status for %q", format.Pod(pod)) <ins> s := kl.convertStatusToAPIStatus(pod, podStatus) </ins> // check if an internal module has requested the pod is evicted. for _, podSyncHandler := range kl.PodSyncHandlers { if result := podSyncHandler.ShouldEvict(pod); result.Evict { <del> return v1.PodStatus{ Phase:   v1.PodFailed, Reason:  result.Reason, Message: result.Message, } </del> <ins> s.Phase = v1.PodFailed s.Reason = result.Reason s.Message = result.Message return *s </ins> } } <del> s := kl.convertStatusToAPIStatus(pod, podStatus) </del> // Assume info is ready to process spec := &pod.Spec allStatus := append(append([]v1.ContainerStatus{}, s.ContainerStatuses...), s.InitContainerStatuses...)

status, found := kubelet.statusManager.GetPodStatus(pods[0].UID) assert.True(t, found, "expected to found status for pod %q", pods[0].UID) assert.Equal(t, v1.PodFailed, status.Phase) <ins> // check pod status contains ContainerStatuses, etc. assert.NotNil(t, status.ContainerStatuses) </ins> } func TestSyncPodsDoesNotSetPodsThatDidNotRunTooLongToFailed(t *testing.T) {
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: there will be azure disk creation issue when specifying an external resource group, after azure disk creation succeeded, it fails to get azure disk state What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.11 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /assign /azure
/sig azure
/kind bug

Discussion:
diskID := "" err = kwait.ExponentialBackoff(defaultBackOff, func() (bool, error) { <del> provisionState, id, err := c.getDisk(diskName) </del> <ins> provisionState, id, err := c.getDisk(resourceGroup, diskName) </ins> diskID = id // We are waiting for provisioningState==Succeeded // We don't want to hand-off managed disks to k8s while they are

} // return: disk provisionState, diskID, error <del> func (c *ManagedDiskController) getDisk(diskName string) (string, string, error) { </del> <ins> func (c *ManagedDiskController) getDisk(resourceGroup, diskName string) (string, string, error) { </ins> ctx, cancel := getContextWithCancel() defer cancel() <del> result, err := c.common.cloud.DisksClient.Get(ctx, c.common.resourceGroup, diskName) </del> <ins> result, err := c.common.cloud.DisksClient.Get(ctx, resourceGroup, diskName) </ins> if err != nil { return "", "", err }

ctx, cancel = getContextWithCancel() defer cancel() <del> if _, err := c.common.cloud.DisksClient.CreateOrUpdate(ctx, c.common.resourceGroup, diskName, result); err != nil { </del> <ins> if _, err := c.common.cloud.DisksClient.CreateOrUpdate(ctx, resourceGroup, diskName, result); err != nil { </ins> return oldSize, err }
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: What happened: Currently in gce/config-, function get-alias-range-size returns a range which is strictly bigger than log2(max pods 2). Where equal should be also acceptable. Say if max pods constraint = 8, it should return /28, instead of /27. What you expected to happen: Return a range which is larger OR EQUAL to the max pods constraint. How to reproduce it (as minimally and precisely as possible): Take 8 as $1 param for the function. Anything else we need to know?: Need to cherrypick to past versions. Me myself will fix it.
/sig network
/cc

Discussion:
} # Calculate ip alias range based on max number of pods. <del> # Let pow be the smallest integer which is bigger than log2($1 * 2). </del> <ins> # Let pow be the smallest integer which is bigger or equal to log2($1 * 2). </ins> # (32 - pow) will be returned. # # $1: The number of max pods limitation. function get-alias-range-size() { for pow in {0..31}; do <del> if (( 1 << $pow > $1 * 2 )); then </del> <ins> if (( 1 << $pow >= $1 * 2 )); then </ins> echo $((32 - pow)) return 0 fi
Change:
/kind bug /sig cli What happened: kubectl 1.11.0 defaults to (see ), hence, you need to explicitly specify it for each and every single request for a resource managed by an aggregated API server. However, it is even not able to print those resources properly (which was possible before with versions <= 1.10.5): and What you expected to happen: Properly printed and well-formatted output of . (Actually, I do not want to specify but this is what is for). Environment: Kubernetes version (use ):Kernel (e.g. ): MacOS Install tools: Brew
/cc
fixed in
/assign

Discussion:
actual_output=$(kubectl get pod --server-print=false "${kube_flags[@]}" | awk 'NF{NF--};1') kube::test::if_has_string "${actual_output}" "${expected_output}" <ins> # Test printing objects with --use-openapi-print-columns actual_output=$(kubectl get namespaces --use-openapi-print-columns --v=7 "${kube_flags[@]}" 2>&1) # it should request full objects (not server-side printing) kube::test::if_has_not_string "${actual_output}" 'application/json;as=Table' kube::test::if_has_string "${actual_output}"     'application/json' </ins> ### Test retrieval of daemonsets against server-side printing kubectl apply -f hack/testdata/rollingupdate-daemonset.yaml "${kube_flags[@]}" # Post-condition: daemonset is created

Latest(). Flatten(). TransformRequests(func(req *rest.Request) { <ins> // We need full objects if printing with openapi columns if o.PrintWithOpenAPICols { return } </ins> if o.ServerPrint && o.IsHumanReadablePrinter && !o.Sort { group := metav1beta1.GroupName version := metav1beta1.SchemeGroupVersion.Version
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: I use but my cloud provider doesn't support Openstack LBaaS. Because of the latter I've been using MetalLB instead to get things going. However I keep getting warnings when deploying a when there is no configuration defined in . NOTE: has only a section - there is no mention no section. What you expected to happen: should not print warning via Openstack LoadBalancer since it doesn't support/can't do anything with it. How to reproduce it (as minimally and precisely as possible): Configure Push a Create a Anything else we need to know?: See this Environment: See this
/sig cloud-provider
/sig openstack
that error is coming from row but I am not 100% sure should we support metallb in openstack cloud provider integration. Metallb is not part of openstack. any opinion? anyways it is little bit weird that EnsureLoadBalancer function is even working if LoadBalancer section is not defined in config. Openstack lbaas is not initialized but that function is called?
if there is no LBaaS in the environment and or no , we should not try to deploy one (and let metallb to do the work as it is supposed to). i think.
when you start node, do you see this log print in logs? Can you try to add following to does creating service with type loadbalancer (with metallb) work after that without error prints?
~ With the original config doesnt show up in the log files. The only reference for in the logs is:~ UPDATE BELOW Now, if adding as it yields: And: The IP allocation via MetalLB works The service is remotely available The warning on object disappears:
weird, without this Loadbalancer thing in config it should end up to row and print "Claiming to support LoadBalancer". Now when you that Loadbalancer section with random lb-version it ends up to row and it does not have support to external loadbalancer from openstack. When using metallb the init function in openstack should return false (no support from openstack) but I do not have now idea why it does not do that (when you do not have that loadbalancer section in config)
I take it back. my log level was too high (). After moving to it shows up when there is no section in :
cool, then we should have check in function as first thing which checks is LoadBalancer even defined in config - if no then return nil, false
(or someone else openstack guy) do you have time to run some test to fix this? I am on vacation and I do not have my test environment with me :) I am thinking to add following to row So I am trying to check is lbOpts totally empty, if yes - then it does not initialize openstack lbaas at all. Maybe I will do PR, but I do not have possibility to test it

Discussion:
"net" "net/http" "os" <ins> "reflect" </ins> "regexp" "strings" "time"

func (os *OpenStack) LoadBalancer() (cloudprovider.LoadBalancer, bool) { glog.V(4).Info("openstack.LoadBalancer() called") <ins> if reflect.DeepEqual(os.lbOpts, LoadBalancerOpts{}) { glog.V(4).Info("LoadBalancer section is empty/not defined in cloud-config") return nil, false } </ins> network, err := os.NewNetworkV2() if err != nil { return nil, false
Change:
https://k8s- https://k8s- It passes on COS. /cc
I can look into this, since likely this was introduced because of latest changes I made.
This looks like a timing thing - because I can see message in logs , but I think 5 minutes is not enough for the pod to come up after installing flexvolume.
That's strange, the dummy driver just sets up a tmpfs so it should be fairly quick. I wonder if there's something else blocking pod creation?
the driver is not being installed on kubelet I am doing some more investigating, have my own cluster up.
On ubuntu, we set the flexvolume install dir to --volume-plugin-dir=/home/kubernetes/fl exvolume Small oversight, I'll make a PR shortly
They are still failing, I am having another look e: Same as before, it is not installing on the node. I started my test cluster using (basically...) the same kubetest command sooo allow me to try again. e2: it's a false alarm. The tests are not using a commit with my fix in it yet zzzz

Discussion:
func getFlexDir(c clientset.Interface, node *v1.Node, vendor, driver string) string { volumePluginDir := defaultVolumePluginDir if framework.ProviderIs("gce") { <del> if node == nil && framework.MasterOSDistroIs("gci") { </del> <ins> if node == nil && framework.MasterOSDistroIs("gci", "ubuntu") { </ins> v, err := getMasterVersion(c) if err != nil { framework.Failf("Error getting master version: %v", err)

} else { volumePluginDir = gciVolumePluginDirLegacy } <del> } else if node != nil && framework.NodeOSDistroIs("gci") { </del> <ins> } else if node != nil && framework.NodeOSDistroIs("gci", "ubuntu") { </ins> if getNodeVersion(node).AtLeast(versionutil.MustParseGeneric(gciVolumePluginDirVersion)) { volumePluginDir = gciVolumePluginDir } else {
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: What happened: tried to update godeps on mac OSX Eventual error out with osx bash is old and doesn't know what the flag is for declare. What you expected to happen: successfully finish running the scripts How to reproduce it (as minimally and precisely as possible): see above Anything else we need to know?: Environment: OS (e.g. from /etc/os-release): mac os 10.13.5
There are no sig labels on this issue. Please add a sig label. <detailsA sig label can be by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/cc since you use a mac
/cc
What version of OSX and what version of bash are you using?
The licenses script is important but horrible.
worked last time I tried (some days ago, on 10.13.5.
Default bash version in OSX is pretty old, you can check your current version with The option is only available on version 4 or newer, so you have to install a new bash version The shebang line in the script will use the first bash in your PATH, which should be the new one.
so this error is actually being thrown by . there's actually a version check in that script to ensure you're running bash 4 () I'm curious though.. because you have declare, but just not the -A flag... but somehow you're passing the version check, which I know fails on bash 3 (just tested it). Seems weird.
I think that the problem is that there is no inside the sentence so it warns the user but it continues running.
huh, you're right. I do have bash 4. I think I have an incorrect root cause. I made assumptions. My apologies. I'll try and take another look at it next week.

Discussion:
echo "$ brew install md5sha1sum bash jq" fi echo <ins> exit 9 </ins> fi # This variable can be injected, as in the verify script.
Change:
/kind bug What happened: The wording of kubectl cluster-info is misleading. When no cluster is running, it will state (in green) that the kubernetes master is running. What you expected to happen: I would expect a different message, like Or a How to reproduce it (as minimally and precisely as possible): Execute kubectl with no config files, and no local kubernetes cluster running on 8080
Reiterating the mentions to trigger a notification: <detailsIn response to : Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
} func (o *ClusterInfoOptions) Run() error { <del> printService(o.Out, "Kubernetes master", o.Client.Host) </del> // TODO use generalized labels once they are implemented (#341) b := o.Builder. WithScheme(legacyscheme.Scheme).

if err != nil { return err } <ins> printService(o.Out, "Kubernetes master", o.Client.Host) </ins> services := r.Object.(*api.ServiceList).Items for _, service := range services { var link string
Change:
/kind bug What happened: kube-aggregrator returns 500 status code with message: unable to set dialer for wardle/api as rest transport is of type *transport.debuggingRoundTripper What you expected to happen: 500 status code should not returned How to reproduce it (as minimally and precisely as possible): kube-apiserver with flag: sample-apiserver as said. command and get the 500 status code: Environment: community master
/assign
/sig api-machinery
/cc

Discussion:
import ( "context" <del> "fmt" </del> "net/http" "net/url" "sync/atomic"

serviceNamespace: apiService.Spec.Service.Namespace, serviceAvailable: apiregistrationapi.IsAPIServiceConditionTrue(apiService, apiregistrationapi.Available), } <ins> if r.proxyTransport != nil && r.proxyTransport.DialContext != nil { newInfo.restConfig.Dial = r.proxyTransport.DialContext } </ins> newInfo.proxyRoundTripper, newInfo.transportBuildingError = restclient.TransportFor(newInfo.restConfig) <del> if newInfo.transportBuildingError == nil && r.proxyTransport != nil && r.proxyTransport.DialContext != nil { switch transport := newInfo.proxyRoundTripper.(type) { case *http.Transport: transport.DialContext = r.proxyTransport.DialContext default: newInfo.transportBuildingError = fmt.Errorf("unable to set dialer for %s/%s as rest transport is of type %T", apiService.Spec.Service.Namespace, apiService.Spec.Service.Name, newInfo.proxyRoundTripper) glog.Warning(newInfo.transportBuildingError.Error()) } </del> <ins> if newInfo.transportBuildingError != nil { glog.Warning(newInfo.transportBuildingError.Error()) </ins> } r.handlingInfo.Store(newInfo) }
Change:
Seeing several of the tests in ./pkg/cloudprovider/providers/gce flake 1 in 5-10 runs when run locally (I am logged in to gcloud). Is it possible one of the APIs is not correctly shimmed and is fetching real data?
you were the last folks in here - why would this and other internal_tests in here be flaking?
Happens in both master and 1.11 release branches
/cc cheftako

Discussion:
} func TestEnsureInternalBackendServiceGroups(t *testing.T) { <ins> t.Parallel() </ins> for desc, tc := range map[string]struct { mockModifier func(*cloud.MockGCE) }{

}, } { t.Run(desc, func(t *testing.T) { <del> t.Parallel() </del> vals := DefaultTestClusterValues() nodeNames := []string{"test-node-1"}

err = gce.ensureInternalBackendService(bsName, "description", svc.Spec.SessionAffinity, cloud.SchemeInternal, "TCP", igLinks, "") require.NoError(t, err) <del> // Update the BackendService with new Instances </del> <ins> // Update the BackendService with new InstanceGroups </ins> if tc.mockModifier != nil { tc.mockModifier(gce.c.(*cloud.MockGCE)) } <del> newNodeNames := []string{"new-test-node-1", "new-test-node-2"} err = gce.ensureInternalBackendServiceGroups(bsName, newNodeNames) </del> <ins> newIGLinks := []string{"new-test-ig-1", "new-test-ig-2"} err = gce.ensureInternalBackendServiceGroups(bsName, newIGLinks) </ins> if tc.mockModifier != nil { assert.Error(t, err) return

bs, err := gce.GetRegionBackendService(bsName, gce.region) assert.NoError(t, err) <del> // Check that the instances are updated newNodes, err := createAndInsertNodes(gce, newNodeNames, vals.ZoneName) newIgLinks, err := gce.ensureInternalInstanceGroups(igName, newNodes) backends := backendsFromGroupLinks(newIgLinks) </del> <ins> // Check that the Backends reflect the new InstanceGroups backends := backendsFromGroupLinks(newIGLinks) </ins> assert.Equal(t, bs.Backends, backends) }) }