jiebi/CodeConvo huggingface dataset:
Change:
Which jobs are failing: Which test(s) are failing: Since when has it been failing: Testgrid link: Reason for failure: Anything else we need to know: /cc /milestone v1.19 /priority critical-urgent /sig testing
You must be a member of the GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility. <detailsIn response to : Which jobs are failing: Up W0501 09:18:42.774] scp: /var/log/konnectivity- No such file or directory W0501 09:18:42.775] scp: No such file or directory W0501 09:18:42.775] scp: No such file or directory W0501 09:18:42.775] scp: *: No such file or directory W0501 09:18:42.780] ERROR: () [/usr/bin/scp] exited with return code [1]. /milestone v1.19 /priority critical-urgent /sig testing Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/milestone v1.19
I am seeing the same error listed above on successful runs as well so I think the issue might be elsewhere
/assign

Discussion:
software-properties-common  lsb-release <ins> # focal repo for docker is not yet available, so we use bonic for now # https://github.com/kubernetes/kubernetes/issues/90709 release=$(lsb_release -cs) if [ "$release" == "focal" ]; then release="bionic"; fi </ins> # Add the Docker apt-repository curl -fsSL https://download.docker.com/linux/$(. /etc/os-release; echo "$ID")/gpg  | apt-key add - add-apt-repository  "deb [arch=amd64] https://download.docker.com/linux/$(. /etc/os-release; echo "$ID")  <del> $(lsb_release -cs) stable" </del> <ins> $release stable" </ins> # Install Docker apt-get update && 

software-properties-common  lsb-release <ins> # focal repo for docker is not yet available, so we use bonic for now # https://github.com/kubernetes/kubernetes/issues/90709 release=$(lsb_release -cs) if [ "$release" == "focal" ]; then release="bionic"; fi </ins> # Add the Docker apt-repository (as we install containerd from there) curl -fsSL https://download.docker.com/linux/$(. /etc/os-release; echo "$ID")/gpg  | apt-key add - add-apt-repository  "deb [arch=amd64] https://download.docker.com/linux/$(. /etc/os-release; echo "$ID")  <del> $(lsb_release -cs) stable" </del> <ins> $release stable" </ins> # Install containerd from Docker repo apt-get update &&
Change:
What happened: TestKubeletDefault unit test fails when run locally on system that has systemd-resolved active What you expected to happen: Unit test succeeds How to reproduce it (as minimally and precisely as possible): Use ubuntu with systemd-resolved active. Run Output: Anything else we need to know?: Environment: Kubernetes version (use ): Master branch (v1.19.0-alpha) Cloud provider or hardware configuration: n/a OS (e.g: ):Kernel (e.g. ):Install tools: Network plugin and version (if this is a network-related bug): Others:
/sig node /priority important-soon I created this issue to track what happened. I'll have a PR to fix soon. /assign
/area kubeadm /sig cluster-lifecycle
/remove-sig node
thanks for reporting. /remove-kind bug /kind failing-test /assign

Discussion:
} func TestKubeletDefault(t *testing.T) { <ins> var resolverConfig string if isSystemdResolvedActive, _ := isServiceActive("systemd-resolved"); isSystemdResolvedActive { // If systemd-resolved is active, we need to set the default resolver config resolverConfig = kubeletSystemdResolverConfig } </ins> tests := []struct { name       string clusterCfg kubeadmapi.ClusterConfiguration

HealthzBindAddress: kubeletHealthzBindAddress, HealthzPort:        utilpointer.Int32Ptr(constants.KubeletHealthzPort), RotateCertificates: kubeletRotateCertificates, <ins> ResolverConfig:     resolverConfig, </ins> }, }, },

got := &kubeletConfig{} got.Default(&test.clusterCfg, &kubeadmapi.APIEndpoint{}, &kubeadmapi.NodeRegistrationOptions{}) if !reflect.DeepEqual(got, &test.expected) { <del> t.Fatalf("Missmatch between expected and got:nExpected:n%vn---nGot:n%v", test.expected, got) </del> <ins> t.Fatalf("Missmatch between expected and got:nExpected:n%vn---nGot:n%v", test.expected, *got) </ins> } }) }
Change:
Using with a without a () will result in a panic. What happened: What you expected to happen: Expected a successful kube-api server call, or at the very least an error to be returned. Although i think it should just not call and continue with the kube-api server call. Anything else we need to know?: The reason for this is due to where has no check.
/sig cli
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
Stale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten
Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close
Closing this issue. <detailsIn response to : Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
Persist(map[string]string) error } <ins> type noopPersister struct{} func (n *noopPersister) Persist(_ map[string]string) error { // no operation persister return nil } </ins> // All registered auth provider plugins. var pluginsLock sync.Mutex var plugins = make(map[string]Factory)

if !ok { return nil, fmt.Errorf("no Auth Provider found for name %q", apc.Name) } <ins> if persister == nil { persister = &noopPersister{} } </ins> return p(clusterAddress, apc.Config, persister) }

} <ins> func Test_WhenNilPersister_NoOpPersisterIsAssigned(t *testing.T) { if err := RegisterAuthProviderPlugin("anyPlugin", pluginPersistProvider); err != nil { t.Errorf("unexpected error: failed to register 'anyPlugin': %v", err) } cfg := &clientcmdapi.AuthProviderConfig{ Name:   "anyPlugin", Config: nil, } plugin, err := GetAuthProvider("127.0.0.1", cfg, nil) if err != nil { t.Errorf("unexpected error: failed to get 'anyPlugin': %v", err) } anyPlugin := plugin.(*pluginPersist) if _, ok := anyPlugin.persister.(*noopPersister); !ok { t.Errorf("expected to be No Operation persister") } } </ins> // emptyTransport provides an empty http.Response with an initialized header // to allow wrapping RoundTrippers to set header values. type emptyTransport struct{}
Change:
Currently services/proxy is available in client-go, but pods/proxy resource is not. This requires manual usage via the rest client like This can be seen in Kubernetes e2e tests as well
/kind feature /sig api-machinery

Discussion:
_, err := c.Fake.Invokes(action, eviction) return err } <ins> func (c *FakePods) ProxyGet(scheme, name, port, path string, params map[string]string) restclient.ResponseWrapper { return c.Fake.InvokesProxy(core.NewProxyGetAction(podsResource, c.ns, scheme, name, port, path, params)) } </ins>

v1 "k8s.io/api/core/v1" policy "k8s.io/api/policy/v1beta1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" <ins> "k8s.io/apimachinery/pkg/util/net" </ins> "k8s.io/client-go/kubernetes/scheme" restclient "k8s.io/client-go/rest" )

Bind(ctx context.Context, binding *v1.Binding, opts metav1.CreateOptions) error Evict(ctx context.Context, eviction *policy.Eviction) error GetLogs(name string, opts *v1.PodLogOptions) *restclient.Request <ins> ProxyGet(scheme, name, port, path string, params map[string]string) restclient.ResponseWrapper </ins> } // Bind applies the provided binding to the named pod in the current namespace (binding.Namespace is ignored).

func (c *pods) GetLogs(name string, opts *v1.PodLogOptions) *restclient.Request { return c.client.Get().Namespace(c.ns).Name(name).Resource("pods").SubResource("log").VersionedParams(opts, scheme.ParameterCodec) } <ins> // ProxyGet returns a response of the pod by calling it through the proxy. func (c *pods) ProxyGet(scheme, name, port, path string, params map[string]string) restclient.ResponseWrapper { request := c.client.Get(). Namespace(c.ns). Resource("pods"). SubResource("proxy"). Name(net.JoinSchemeNamePort(scheme, name, port)). Suffix(path) for k, v := range params { request = request.Param(k, v) } return request } </ins>
Change:
A long time ago we removed conformance for a similar HostPath test in: At that time a policy was : Current Policy : Note that the conformance tag was in . Which was basically bulk tagging a bunch of tests as conformance tests, So not really specifying a specific reason on why it is a behavior that should be tested. Also note that this is and something that does not work on Windows. And we are expecting the "sticky bit" to be set ... Is this really what we want in a conformance test? So bottom line, does it really need to be a conformance test?
/sig architecture /area conformance
LinuxOnly things should still be in conformance, as I understand it (and hope?!?). Agree with the other reasons.
Yes, you can have LinuxOnly in conformance, that's not the issue here. The issue is that it does violate the current policy, and looks like it was to conformance prior to that but probably should have been removed. So it seems reasonable to me.

Discussion:
able to start with Secret and ConfigMap volumes mounted into the container. release: v1.13 file: test/e2e/storage/empty_dir_wrapper.go <del> - testname: Host path, volume mode default codename: '[sig-storage] HostPath should give a volume the correct mode [LinuxOnly] [NodeConformance] [Conformance]' description: Create a Pod with host volume mounted. The volume mounted MUST be a directory with permissions mode -rwxrwxrwx and that is has the sticky bit (mode flag t) set. This test is marked LinuxOnly since Windows does not support setting the sticky bit (mode flag t). release: v1.9 file: test/e2e/common/host_path.go </del> - testname: Projected Volume, multiple projections codename: '[sig-storage] Projected combined should project all components that make up the projection API [Projection][NodeConformance] [Conformance]'

}) /* <del> Release : v1.9 Testname: Host path, volume mode default Description: Create a Pod with host volume mounted. The volume mounted MUST be a directory with permissions mode -rwxrwxrwx and that is has the sticky bit (mode flag t) set. </del> <ins> Host path, volume mode default Create a Pod with host volume mounted. The volume mounted MUST be a directory with permissions mode -rwxrwxrwx and that is has the sticky bit (mode flag t) set. </ins> This test is marked LinuxOnly since Windows does not support setting the sticky bit (mode flag t). */ <del> framework.ConformanceIt("should give a volume the correct mode [LinuxOnly] [NodeConformance]", func() { </del> <ins> ginkgo.It("should give a volume the correct mode [LinuxOnly] [NodeConformance]", func() { </ins> source := &v1.HostPathVolumeSource{ Path: "/tmp", }
Change:
Explicitly state in this repo's . The CNCF received a user complaint that the CLA requirement is non-obvious until a contributor opens a PR (i.e., after the work is already done). Given that the CLA requirement is a minimum of two links away from , the complaint seems reasonable. It also seems reasonable to explicitly state that contributors must sign a license agreement.
/sig docs

Discussion:
# Contributing <del> Welcome to Kubernetes! If you are interested in contributing to the [Kubernetes code repo](README.md) then checkout the [Contributor's Guide](https://git.k8s.io/community/contributors/guide/) </del> <ins> Welcome to Kubernetes! To learn more about contributing to the [Kubernetes code repo](README.md), check out the [Contributor's Guide](https://git.k8s.io/community/contributors/guide/). </ins> <del> The [Kubernetes community repo](https://github.com/kubernetes/community) contains information on how the community is organized and other information that is pertinent to contributing. </del> <ins> The [Kubernetes community repo](https://github.com/kubernetes/community) contains information about how to get started, how the community organizes, and more. ## Sign the CLA You must sign the [Contributor License Agreement](https://git.k8s.io/community/contributors/guide/getting-started.md#sign-the-cla) in order to contribute. </ins> [![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/CONTRIBUTING.md?pixel)]()
Change:
<!-- Please only use this template for submitting enhancement requests --What would you like to be : AWS release [Local Zones] (). One user enable local zones, using us-west-2 as an example, there's AZ and AWS right now uses method here to infer to region. This won't work for local zone region. Why is this needed: Update to cover this case
/sig cloud-provider These SIGs are my best guesses for this issue. Please comment if I am incorrect about one. I am a bot run by vllry. ‍
/area provider/aws

Discussion:
"io" "net" "path" <ins> "regexp" </ins> "sort" "strconv" "strings"

if len(az) < 1 { return "", fmt.Errorf("invalid (empty) AZ") } <del> region := az[:len(az)-1] </del> <ins> r := regexp.MustCompile(`^([a-zA-Z]+-)+d+`) region := r.FindString(az) if region == "" { return "", fmt.Errorf("invalid AZ: %s", az) } </ins> return region, nil }

s.elb = &MockedFakeELB{FakeELB: s.elb.(*FakeELB)} return s } <ins> func TestAzToRegion(t *testing.T) { testCases := []struct { az     string region string }{ {"us-west-2a", "us-west-2"}, {"us-west-2-lax-1a", "us-west-2"}, {"ap-northeast-2a", "ap-northeast-2"}, {"us-gov-east-1a", "us-gov-east-1"}, {"us-iso-east-1a", "us-iso-east-1"}, {"us-isob-east-1a", "us-isob-east-1"}, } for _, testCase := range testCases { result, err := azToRegion(testCase.az) assert.NoError(t, err) assert.Equal(t, testCase.region, result) } } </ins>
Change:
[x] Original approval issue: [x] Two weeks soak end date: 6 July 2020 This issue is created to allow edit by /wip /hold According to this APIsnoop query, there are still an endpoint which is untested. a set of 3 Events with a static label within a Namespace. that all 3 Events with the label in the Namespaces are created. the set of Namespaced Events with a label via DeleteCollection. that all Events with the label have been deleted. Discover useragents: List endpoints hit by the test: Display endpoint coverage change: Two other endpoints tested here have tests in progress to conformance already. If a test with these calls gets merged, test coverage will go up by 1 points This test is also created with the goal of conformance promotion.
/sig testing /sig architecture /area conformance
During Conformance Meeting: Is there a way to write this test so it is resource agnostic? If we are just changing the resource... can be parameterize the resource-type
/assign
GitHub didn't allow me to assign the following users: heyste. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/reopen PR Merge and soaking
Reopened this issue. <detailsIn response to : /reopen PR Merge and soaking Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
definitions MUST be published for custom resource definitions. release: v1.16 file: test/e2e/apimachinery/crd_publish_openapi.go <ins> - testname: Event, delete a collection codename: '[sig-api-machinery] Events should delete a collection of events [Conformance]' description: A set of events is created with a label selector which MUST be found when listed. The set of events is deleted and MUST NOT show up when listed by its label selector. release: v1.19 file: test/e2e/apimachinery/events.go </ins> - testname: Event resource lifecycle codename: '[sig-api-machinery] Events should ensure that an event can be fetched, patched, deleted, and listed [Conformance]'

framework.ExpectEqual(foundCreatedEvent, false, "should not have found test event after deletion") }) <del> ginkgo.It("should delete a collection of events", func() { </del> <ins> /* Release : v1.19 Testname: Event, delete a collection Description: A set of events is created with a label selector which MUST be found when listed. The set of events is deleted and MUST NOT show up when listed by its label selector. */ framework.ConformanceIt("should delete a collection of events", func() { </ins> eventTestNames := []string{"test-event-1", "test-event-2", "test-event-3"} ginkgo.By("Create set of events")
Change:
[x] Original approval issue: [x] Two weeks soak end date: This issue is created to allow edit by /wip /hold This issue proposes the writing of a new test for the API endponts , , , with the intention of promoting it to Conformance. This issue contains a very basic mock test in order to start the conversation about what a good e2e test would look like for this endpoint. The code below is verified to be hitting the intended endpoint, show as per the queries in APIsnoop's live view of the cluster's audit logs. According to this APIsnoop query, there are still some remaining Endpoints endpoints which are untested. a Service in a namespace all Endpoints in all Namespaces find the created Service(1) /update the Namespaced Endpoint for the Service(1) the Namespaced Endpoint for the Service(1) the Namespaced Endpoint for the Service(1) Namespaced Endpoint(1) via a Collection with a LabelSelector Discover useragents: If a test with these calls gets merged, Conformance coverage will go up by 4 points* /sig testing /sig architecture /area conformance
/reopen Wait for Promotion PR to Merge.
Reopened this issue. <detailsIn response to : /reopen Wait for Promotion PR to Merge. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
Pod and the service must now have empty set of endpoints. release: v1.9 file: test/e2e/network/service.go <ins> - testname: Endpoint resource lifecycle codename: '[sig-network] Services should test the lifecycle of an Endpoint [Conformance]' description: Create an endpoint, the endpoint MUST exist. The endpoint is updated with a new label, a check after the update MUST find the changes. The endpoint is then patched with a new IPv4 address and port, a check after the patch MUST the changes. The endpoint is deleted by it's label, a watch listens for the deleted watch event. release: v1.19 file: test/e2e/network/service.go </ins> - testname: ConfigMap, from environment field codename: '[sig-node] ConfigMap should be consumable via environment variable [NodeConformance] [Conformance]'

framework.ExpectEqual(foundSvc, true, "could not find service 'kubernetes' in service list in all namespaces") }) <del> ginkgo.It("should test the lifecycle of an Endpoint", func() { </del> <ins> /* Release : v1.19 Testname: Endpoint resource lifecycle Description: Create an endpoint, the endpoint MUST exist. The endpoint is updated with a new label, a check after the update MUST find the changes. The endpoint is then patched with a new IPv4 address and port, a check after the patch MUST the changes. The endpoint is deleted by it's label, a watch listens for the deleted watch event. */ framework.ConformanceIt("should test the lifecycle of an Endpoint", func() { </ins> testNamespaceName := f.Namespace.Name testEndpointName := "testservice" testEndpoints := v1.Endpoints{
Change:
What happened: A resource is not replaced (deleted and recreated) when passing the flag to and the change cannot be applied. What you expected to happen: I expected the service to be replaced. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ):
/sig api-machinery /wg api-expression
/sig cli
/cc
Good to know, that's certainly worthy of a fix.
/cc
This is slightly related: If we want to support we could try and make the behavior clearer.
Can you weigh in on how important this is? We feel that is super, super dangerous in general. It's also very easy to confuse it with for server side apply, so it's extra dangerous. Do we need to implement this field for this command? Can we give an error, like "use one of: --force-conflicts or --delete-then-create"? Can SIG CLI do something about this flag in general?
/cc
Noted, I'll make sure this is in the agenda for the next sig-cli meeting.
I don't think the two are related. is now error-ing when used with , but it'll still fail with server-side apply.
You're right... my recall was bad. I deleted my comment where I thought was this, but it is not. Sorry about that
Looks like in the SIG-CLI meeting it was decided to not enable the user to use the and flag together. kubectl should fail immediately with a warning that should not be used with server side apply. Do you mind if I start working on this issue? I will reach out to you and other members of the SIG to get more details needed. I am a new contributor to k8s and would like to work on this issue.
Thanks for summarizing the discussion! I'd love to see you submit a PR for that, that's awesome!
/assign /lifecycle-active

Discussion:
return err } <ins> if o.ServerSideApply && o.DeleteOptions.ForceDeletion { return fmt.Errorf("--force cannot be used with --server-side") } </ins> if o.DryRunStrategy == cmdutil.DryRunServer && o.DeleteOptions.ForceDeletion { return fmt.Errorf("--dry-run=server cannot be used with --force") }

t.Fatalf(`expected error "%s"`, expectedError) } <ins> func TestDontAllowForceApplyWithServerSide(t *testing.T) { expectedError := "error: --force cannot be used with --server-side" cmdutil.BehaviorOnFatal(func(str string, code int) { panic(str) }) defer func() { actualError := recover() if expectedError != actualError { t.Fatalf(`expected error "%s", but got "%s"`, expectedError, actualError) } }() tf := cmdtesting.NewTestFactory().WithNamespace("test") defer tf.Cleanup() tf.ClientConfigVal = cmdtesting.DefaultClientConfig() ioStreams, _, _, _ := genericclioptions.NewTestIOStreams() cmd := NewCmdApply("kubectl", tf, ioStreams) cmd.Flags().Set("filename", filenameRC) cmd.Flags().Set("server-side", "true") cmd.Flags().Set("force", "true") cmd.Run(cmd, []string{}) t.Fatalf(`expected error "%s"`, expectedError) } </ins> func TestDontAllowApplyWithPodGeneratedName(t *testing.T) { expectedError := "error: from testing-: cannot use generate name with apply" cmdutil.BehaviorOnFatal(func(str string, code int) {