jiebi/CodeConvo huggingface dataset:
Change:
I ran pull-kubernetes-verify with race detection enabled (see ). It with: No errors. Run the integration test with - but I am not sure whether it triggers reliable outside of the Prow job. No response master n/a No response <details</details<details</details<details</details
/sig apimachinery
The label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig apimachinery Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig api-machinery
Took a peek at this. Looks like writes to under a lock: But copies from it without a lock: This code is pretty old, I'm surprised we haen't caught this before
Well, We need a lock here..., I will file a fix for it. /assign
/triage accepted

Discussion:
// ListedPaths returns the registered handler exposedPaths. func (m *PathRecorderMux) ListedPaths() []string { <ins> m.lock.Lock() </ins> handledPaths := append([]string{}, m.exposedPaths...) <del> sort.Strings(handledPaths) </del> <ins> m.lock.Unlock() sort.Strings(handledPaths) </ins> return handledPaths }
Change:
https://prow.ppc64le- Tests are not getting executed due to improper go version. It has been failing since past 4 days. No response No response No response /sig node
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
This seems to be failing due to improper version addition in dependency files where is instead of at some places. I will raise a PR for it.
/assign
fixing that

Discussion:
<del> v1.30.0-go1.22-bullseye.0 </del> <ins> v1.30.0-go1.22.0-bullseye.0 </ins>

# These are the default versions (image tags) for their respective base images. readonly __default_distroless_iptables_version=v0.5.1 <del> readonly __default_go_runner_version=v2.3.1-go1.22-bookworm.0 </del> <ins> readonly __default_go_runner_version=v2.3.1-go1.22.0-bookworm.0 </ins> readonly __default_setcap_version=bookworm-v1.0.1 # These are the base images for the Docker-wrapped binaries.

# Golang - name: "golang: upstream version" <del> version: 1.22 </del> <ins> version: 1.22.0 </ins> refPaths: - path: .go-version - path: build/build-image/cross/VERSION

match: minimum_go_version=go([0-9]+.[0-9]+) - name: "registry.k8s.io/kube-cross: dependents" <del> version: v1.30.0-go1.22-bullseye.0 </del> <ins> version: v1.30.0-go1.22.0-bullseye.0 </ins> refPaths: - path: build/build-image/cross/VERSION

match: configs[DistrolessIptables] = Config{list.BuildImageRegistry, "distroless-iptables", "v([0-9]+).([0-9]+).([0-9]+)"} - name: "registry.k8s.io/go-runner: dependents" <del> version: v2.3.1-go1.22-bookworm.0 </del> <ins> version: v2.3.1-go1.22.0-bookworm.0 </ins> refPaths: - path: build/common.sh match: __default_go_runner_version=
Change:
agnhost was updated to v2.46 in: However, is failing: ... exporting to image exporting layers exporting layers 2.9s done exporting manifest sha256:db8e9d1930d4799d474ea9228d4957d54053c107e10385d77021ef44f567fc69 done exporting config sha256:037153f61da4211d6ec5f00f694639ce15a0bbebf12fa5c86eea059fc3c0b07c done exporting attestation manifest sha256:744b616c276ff7f6518476765c2457e0b2664225ef798ce7e93874450807310b exporting attestation manifest sha256:744b616c276ff7f6518476765c2457e0b2664225ef798ce7e93874450807310b 0.0s done exporting manifest list sha256:29bf785c1a8338d5f7a8be8cae8a2435b94370eecbaa586a61e08454095940cb done pushing layers pushing layers 5.9s done pushing manifest for pushing manifest for 4.3s done DONE 13.2s /workspace/test/images /workspace/test/images/agnhost /workspace/test/images is a manifest list make: * [Makefile:43: all-build-and-push] Error 1 ERROR ERROR: build step 0 "" failed: step exited with non-zero status: 2
2024/02/13 15:34:04 Failed to run some build jobs: [error running [gcloud builds submit --verbosity info --config --substitutions PULLBASEREF=master,PULLBASESHA=,WHAT=agnhost,GITTAG=v20240213-v1.30.0-alpha.1-173-gc3b2295c3a --project k8s-staging-e2e-test-images --gcs-log-dir gs://k8s-staging-e2e-test-images-gcb/logs --gcs-source-staging-dir gs://k8s-staging-e2e-test-images-gcb/source gs://k8s-staging-e2e-test-images-gcb/source/-7566-469c-a5a0-]: exit status 1] N/A 2024-02-14 No response No response_ /sig testing
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
PR:

Discussion:
"${SED}" -i '/CROSS_BUILD_/d' Dockerfile fi <del> docker buildx build --progress=plain --no-cache --pull --output=type="${output_type}" --platform "${os_name}/${arch}"  </del> <ins> # `--provenance=false --sbom=false` is set to avoid creating a manifest list: https://github.com/kubernetes/kubernetes/issues/123266 docker buildx build --progress=plain --no-cache --pull --output=type="${output_type}" --platform "${os_name}/${arch}" --provenance=false --sbom=false  </ins> --build-arg BASEIMAGE="${base_image}" --build-arg REGISTRY="${REGISTRY}" --build-arg OS_VERSION="${os_version}"  -t "${REGISTRY}/${image}:${TAG}-${suffix}" -f "${dockerfile_name}"  --label "image_version=${TAG}" --label "commit_id=${GIT_COMMIT_ID}"
Change:
agnhost was updated to v2.46 in: However, is failing: ... exporting to image exporting layers exporting layers 2.9s done exporting manifest sha256:db8e9d1930d4799d474ea9228d4957d54053c107e10385d77021ef44f567fc69 done exporting config sha256:037153f61da4211d6ec5f00f694639ce15a0bbebf12fa5c86eea059fc3c0b07c done exporting attestation manifest sha256:744b616c276ff7f6518476765c2457e0b2664225ef798ce7e93874450807310b exporting attestation manifest sha256:744b616c276ff7f6518476765c2457e0b2664225ef798ce7e93874450807310b 0.0s done exporting manifest list sha256:29bf785c1a8338d5f7a8be8cae8a2435b94370eecbaa586a61e08454095940cb done pushing layers pushing layers 5.9s done pushing manifest for pushing manifest for 4.3s done DONE 13.2s /workspace/test/images /workspace/test/images/agnhost /workspace/test/images is a manifest list make: * [Makefile:43: all-build-and-push] Error 1 ERROR ERROR: build step 0 "" failed: step exited with non-zero status: 2
2024/02/13 15:34:04 Failed to run some build jobs: [error running [gcloud builds submit --verbosity info --config --substitutions PULLBASEREF=master,PULLBASESHA=,WHAT=agnhost,GITTAG=v20240213-v1.30.0-alpha.1-173-gc3b2295c3a --project k8s-staging-e2e-test-images --gcs-log-dir gs://k8s-staging-e2e-test-images-gcb/logs --gcs-source-staging-dir gs://k8s-staging-e2e-test-images-gcb/source gs://k8s-staging-e2e-test-images-gcb/source/-7566-469c-a5a0-]: exit status 1] N/A 2024-02-14 No response No response_ /sig testing
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
PR:

Discussion:
<del> 2.46 </del> <ins> 2.47 </ins>
Change:
pull-kubernetes-local-e2e pull-kubernetes-local-e2e.Overall 02-01 and ` No response /sig testing
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
that's not the reason for failure, we don't exit non-zero on this. This job is running and is failing tests.
But what about this one , all tests pass but it fails because a running process is not terminated, i believe is the docker process. I think we are hit by thus the proposed solution to try to send SIG Term wait 30 seconds and if not successfully terminated try to kill the docker process.
/assign
is the PR which I mentioned in the SIG meeting, It introduced the timeout of 30 seconds as a remedy, but unfortunately issue re-appeared.
This job is running , all test passed but failed again for same issue
/assign
wasn't enough to fix this :-( , i checked with , attempts to fix this.
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
framework.KubeDescribe("DynamicProvisioner", func() { It("should create and delete persistent volumes [Slow]", func() { <del> // added until the GKE startup includes storage.k8s.io/v1beta1 framework.SkipIfProviderIs("gke") </del> framework.SkipUnlessProviderIs("openstack", "gce", "aws", "gke") By("creating a StorageClass")
Change:
pull-kubernetes-local-e2e pull-kubernetes-local-e2e.Overall 02-01 and ` No response /sig testing
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
that's not the reason for failure, we don't exit non-zero on this. This job is running and is failing tests.
But what about this one , all tests pass but it fails because a running process is not terminated, i believe is the docker process. I think we are hit by thus the proposed solution to try to send SIG Term wait 30 seconds and if not successfully terminated try to kill the docker process.
/assign
is the PR which I mentioned in the SIG meeting, It introduced the timeout of 30 seconds as a remedy, but unfortunately issue re-appeared.
This job is running , all test passed but failed again for same issue
/assign
wasn't enough to fix this :-( , i checked with , attempts to fix this.
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
<del> v1.6.3-2 </del> <ins> v1.6.3-4 </ins>
Change:
We observed this recently. Steps to reproduce: clone kubernetes test ./test/utils/ktesting -c -race /root/go/bin/stress - TestCause /sig
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig testing even after , we see this flakiness. This is easily reproducible in our local machines.
See Yes, it only reduced the flaking rate IMO. It still flakes in /cc
/milestone v1.30 Does fix the flake?
This still occurs after The change above is only skipping the Test for cases where . But this failure is occurring at a different stage while comparing expectErr and actualErr at Hence this change would fix it. Can you PTAL?

Discussion:
time.Sleep(tt.sleep) actualErr := ctx.Err() actualCause := context.Cause(ctx) <del> assert.Equal(t, tt.expectErr, actualErr, "ctx.Err()") assert.Equal(t, tt.expectCause, actualCause, "context.Cause()") </del> <ins> ci, _ := os.LookupEnv("CI") switch strings.ToLower(ci) { case "yes", "true", "1": // Skip. default: assert.Equal(t, tt.expectErr, actualErr, "ctx.Err()") assert.Equal(t, tt.expectCause, actualCause, "context.Cause()") } </ins> }) } }
Change:
ci-kubernetes-unit testing Failed; === RUN TestRoundTripTypes since 02-25 No response /sig api-machinery network
It started to flake after /cc
It is also flaking in our internal CI on
/triage accepted

Discussion:
j.Service = &empty } }, <ins> func(j *core.LoadBalancerStatus, c fuzz.Continue) { ipMode := core.LoadBalancerIPModeVIP for i := range j.Ingress { if j.Ingress[i].IPMode == nil { j.Ingress[i].IPMode = &ipMode } } }, </ins> } }
Change:
has code which takes a flag called but it tries to hunt for the file in both "local" and "dockerized" places. This doesn't feel right. /cc /cc
/triage accepted

Discussion:
} func getConformanceData(targetFrame frame) (*ConformanceData, error) { <del> // TODO: This is terribly hacky.  Why can't we rely on the --source flag in // all cases? https://issues.k8s.io/123567 // // Filenames may be in a couple special places, depending on if they were // built dockerized or with the host go.  We want to trim this prefix to // produce portable relative paths. containerGopath := "/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/" </del> root := *k8sPath if !strings.HasSuffix(root, string(os.PathSeparator)) { root += string(os.PathSeparator) } trimmedFile := strings.TrimPrefix(targetFrame.File, root) <del> trimmedFile = strings.TrimPrefix(trimmedFile, containerGopath) </del> targetFrame.File = trimmedFile freader, err := os.Open(targetFrame.File)
Change:
and also v1.27-1.29 TestPrintIPAddressList After 03-01 the leap day caused the failure /sig cli network
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
{ ObjectMeta: metav1.ObjectMeta{ Name:              "192.168.2.2", <del> CreationTimestamp: metav1.Time{Time: time.Now().AddDate(-10, 0, 0)}, </del> <ins> CreationTimestamp: metav1.Time{}, </ins> }, Spec: networking.IPAddressSpec{ ParentRef: &networking.ParentReference{

}, { ObjectMeta: metav1.ObjectMeta{ Name:              "2001:db8::2", <del> CreationTimestamp: metav1.Time{Time: time.Now().AddDate(-5, 0, 0)}, </del> <ins> CreationTimestamp: metav1.Time{}, </ins> }, Spec: networking.IPAddressSpec{ ParentRef: &networking.ParentReference{

} // Columns: Name, ParentRef, Age expected := []metav1.TableRow{ <del> {Cells: []interface{}{"192.168.2.2", "myresource.mygroup/mynamespace/myname", "10y"}}, {Cells: []interface{}{"2001:db8::2", "myresource2.mygroup2/mynamespace2/myname2", "5y1d"}}, </del> <ins> {Cells: []interface{}{"192.168.2.2", "myresource.mygroup/mynamespace/myname", "<unknown>"}}, {Cells: []interface{}{"2001:db8::2", "myresource2.mygroup2/mynamespace2/myname2", "<unknown>"}}, </ins> } rows, err := printIPAddressList(&ipList, printers.GenerateOptions{})
Change:
Seeing data race flakes in unit tests: Appears to have just been in /sig api-machinery /priority critical-urgent /assign /cc
This code is mutating the package-level schemebuilder: I think it should be adding the conversions to the local scheme instead:
Fixed in (found several instances)
/triage accepted

Discussion:
scheme := runtime.NewScheme() err := v2beta1scheme.AddToScheme(scheme) require.NoError(t, err) <del> v2scheme.SchemeBuilder.Register(v2scheme.RegisterConversions) </del> err = v2scheme.AddToScheme(scheme) require.NoError(t, err) <ins> err = v2scheme.RegisterConversions(scheme) require.NoError(t, err) </ins> fuzzer := fuzz.NewWithSeed(2374375)

func NewResourceManager(path string) ResourceManager { scheme := runtime.NewScheme() <del> // Register conversion for apidiscovery apidiscoveryv2.SchemeBuilder.Register(apidiscoveryv2conversion.RegisterConversions) </del> utilruntime.Must(apidiscoveryv2.AddToScheme(scheme)) utilruntime.Must(apidiscoveryv2beta1.AddToScheme(scheme)) <ins> // Register conversion for apidiscovery utilruntime.Must(apidiscoveryv2conversion.RegisterConversions(scheme)) </ins> codecs := serializer.NewCodecFactory(scheme) rdm := &resourceDiscoveryManager{

fuzz "github.com/google/gofuzz" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" apidiscoveryv2 "k8s.io/api/apidiscovery/v2" apidiscoveryv2beta1 "k8s.io/api/apidiscovery/v2beta1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

const discoveryPath = "/apis" func init() { <del> // Register conversion for apidiscovery apidiscoveryv2.SchemeBuilder.Register(apidiscoveryv2conversion.RegisterConversions) </del> utilruntime.Must(apidiscoveryv2.AddToScheme(scheme)) utilruntime.Must(apidiscoveryv2beta1.AddToScheme(scheme)) <ins> // Register conversion for apidiscovery utilruntime.Must(apidiscoveryv2conversion.RegisterConversions(scheme)) </ins> codecs = runtimeserializer.NewCodecFactory(scheme) }

target discoveryendpoint.ResourceManager, ) DiscoveryAggregationController { discoveryScheme := runtime.NewScheme() <del> // Register conversion for apidiscovery apidiscoveryv2.SchemeBuilder.Register(apidiscoveryv2conversion.RegisterConversions) </del> utilruntime.Must(apidiscoveryv2.AddToScheme(discoveryScheme)) utilruntime.Must(apidiscoveryv2beta1.AddToScheme(discoveryScheme)) <ins> // Register conversion for apidiscovery utilruntime.Must(apidiscoveryv2conversion.RegisterConversions(discoveryScheme)) </ins> codecs := serializer.NewCodecFactory(discoveryScheme) return &discoveryManager{
Change:
<img width="1480" alt="image" src="" /kind failing-test <!-- If this is a flake, please add: /kind flake --/sig api-machinery
cc in case you know of something that just merged
Last good run : First bad run : k8s version stamp: GOOD: "v1.30.0-alpha.3.56+" BAD : "v1.30.0-alpha.3.62+" Here's the comparison of what went in: We have a winner :) - Will leave this to !
/assign
Thanks I've opened and kicked off the alpha tests on that PR to ensure the fix sticks.
These tests appear to be passing in latest runs: (although NPD is failing)
yea, for the NPD failure i had a cherry pick to containerd 1.7 here -
/triage accepted

Discussion:
"time" "github.com/onsi/ginkgo/v2" <ins> "sigs.k8s.io/yaml" </ins> openapiutil "k8s.io/kube-openapi/pkg/util" "k8s.io/utils/pointer" <del> "sigs.k8s.io/yaml" </del> "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions" apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"

delete(s.Properties, "apiVersion") delete(s.Properties, "kind") delete(s.Extensions, "x-kubernetes-group-version-kind") <ins> delete(s.Extensions, "x-kubernetes-selectable-fields") </ins> } func verifyKubectlExplain(ns, name, pattern string) error {
Change:
has to retry after failures. This currently uses a fixed 5 second delay to avoid busy-looping. Exponential backoff might be better. /sig node /triage-accepted /priority important-longterm /lifecycle frozen /assign
/triage accepted
/assign

Discussion:
resourceinformers "k8s.io/client-go/informers/resource/v1alpha2" "k8s.io/client-go/kubernetes" "k8s.io/client-go/tools/cache" <ins> "k8s.io/client-go/util/flowcontrol" </ins> "k8s.io/client-go/util/workqueue" "k8s.io/klog/v2" drapb "k8s.io/kubelet/pkg/apis/dra/v1alpha3"

const ( // resyncPeriod for informer // TODO (https://github.com/kubernetes/kubernetes/issues/123688): disable? <del> resyncPeriod = time.Duration(10 * time.Minute) </del> <ins> resyncPeriod   = time.Duration(10 * time.Minute) retryPeriod    = 5 * time.Second maxRetryPeriod = 180 * time.Second backoffFactor  = 2.0 // Introduce a backoff multiplier as jitter factor </ins> ) // nodeResourcesController collects resource information from all registered

logger.Info("Stopping to monitor node resources of the plugin", "reason", context.Cause(ctx), "err", ctx.Err(), "recover", r) }() <ins> backOff := flowcontrol.NewBackOffWithJitter(retryPeriod, maxRetryPeriod, backoffFactor) backOffID := "retry" </ins> // Keep trying until canceled. for ctx.Err() == nil { logger.V(5).Info("Calling NodeListAndWatchResources")

default: // This is a problem, report it and retry. logger.Error(err, "Creating gRPC stream for node resources failed") <del> // TODO (https://github.com/kubernetes/kubernetes/issues/123689): expontential backoff? </del> select { <del> case <-time.After(5 * time.Second): </del> <ins> case <-time.After(backOff.Get(backOffID)): backOff.Next(backOffID, time.Now()) </ins> case <-ctx.Done(): } }

case ctx.Err() == nil: // This is a problem, report it and retry. logger.Error(err, "Reading node resources from gRPC stream failed") <del> // TODO (https://github.com/kubernetes/kubernetes/issues/123689): expontential backoff? </del> select { <del> case <-time.After(5 * time.Second): </del> <ins> case <-time.After(backOff.Get(backOffID)): backOff.Next(backOffID, time.Now()) </ins> case <-ctx.Done(): } }
Change:
Yesterday Not yet available. Jobs fail to start due to kubelet startup issues. /sig
/sig testing node
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
We identified as a potential fix. These labels are what we actually want. But the tests actually started to pass before this merge. It still isn't clear to us what happenend to make these tests fail. and I were able to reproduce the test failures on FCOS but it seems to have resolved itself. Writing this here for record but it was an odd one thats for sure!

Discussion:
// kubelet on Fedora CoreOS distribution func setKubeletSELinuxLabels(host, workspace string) error { cmd := getSSHCommand(" && ", <del> fmt.Sprintf("/usr/bin/chcon -u system_u -r object_r -t bin_t %s", filepath.Join(workspace, "kubelet")), </del> <ins> fmt.Sprintf("/usr/bin/chcon -u system_u -r object_r -t kubelet_exec_t %s", filepath.Join(workspace, "kubelet")), </ins> fmt.Sprintf("/usr/bin/chcon -u system_u -r object_r -t bin_t %s", filepath.Join(workspace, "e2e_node.test")), fmt.Sprintf("/usr/bin/chcon -u system_u -r object_r -t bin_t %s", filepath.Join(workspace, "ginkgo")), fmt.Sprintf("/usr/bin/chcon -u system_u -r object_r -t bin_t %s", filepath.Join(workspace, "mounter")),