jiebi/CodeConvo huggingface dataset:
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: GCE Windows cluster bring up fails on some versions of Windows. What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: This is a regression caused by Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others: /assign jeremyje /sig windows
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign pjh
/unassign pjh

Discussion:
[parameter(Mandatory = $false)] [System.Collections.IDictionary]$Headers = @{} ) <ins> # Load the System.Net.Http assembly if it's not loaded yet. if ("System.Net.Http.HttpClient" -as [type]) {} else { Add-Type -AssemblyName System.Net.Http } </ins> $timeout = New-TimeSpan -Minutes 5 try {

# If the URL is for GCS and the node has dev storage scope, add the # service account OAuth2 bearer token to the request headers. # https://cloud.google.com/compute/docs/access/create-enable-service-accounts-for-instances#applications <del> if (($Url -match "^https://storage`.googleapis`.com.*") -And $(Check-StorageScope)) { </del> <ins> if (($Url -match "^https://storage`.googleapis`.com.*") -and $(Check-StorageScope)) { </ins> $httpClient.DefaultRequestHeaders.Add("Authorization", "Bearer $(Get-Credentials)") } # Attempt to download the file $httpResponseMessage = $httpClient.GetAsync([System.Uri]::new($Url)) $httpResponseMessage.Wait() <del> if (-Not $httpResponseMessage.IsCanceled) { </del> <ins> if (-not $httpResponseMessage.IsCanceled) { </ins> # Check if the request was successful. # # DO NOT replace with EnsureSuccessStatusCode(), it prints the # OAuth2 bearer token. <del> if (-Not $httpResponseMessage.Result.IsSuccessStatusCode) { </del> <ins> if (-not $httpResponseMessage.Result.IsSuccessStatusCode) { </ins> $statusCode = $httpResponseMessage.Result.StatusCode throw "Downloading ${Url} returned status code ${statusCode}, retrying." }
Change:
What happened: Found while testing kubeadm 1.20 for openSUSE Kubic in openQA. The test attempted to bootstrap a simple kubernetes 1.19.4 cluster with but this test failed, complaining it could not find a etcd container with tag - etcd 3.4.9 images were removed from our registry after the recent CVE, which was resolved by 3.4.13, which was supported as of k8s 1.19.1 ( for reference) This seems to be because still references etcd 3.4.9 for clusters of version even though 3.4.13 is the correct version to be used. Thanks to for finding that. What you expected to happen: Kubeadm should use etcd v3.4.13 for all clusters version 1.19.1 and higher How to reproduce it (as minimally and precisely as possible): Run , check version of etcd. It should be , but with this bug it will be Anything else we need to know?: Environment: OS (e.g: ): NAME="openSUSE MicroOS" ID="opensuse-microos" IDLIKE="suse opensuse opensuse-tumbleweed" VERSIONID="" PRETTYNAME="openSUSE MicroOS" ANSICOLOR="0;32" CPENAME="cpe:/o:opensuse:microos:" BUGREPORTURL="" HOMEURL="" DOCUMENTATIONURL="" LOGO="distributor-logo" Kernel (e.g. ): Linux r2d2 5.9.12-1-default SMP Wed Dec 2 09:24:35 UTC 2020 () x8664 x8664 x8664 GNU/Linux /sig cluster-lifecycle
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig cluster-lifecycle
/assign
According to , the cve is fixed in 3.4.13+ & 3.3.25+ & 3.5+. : Fix CVE-2020- and CVE-2020-. Should we upgrade all etcd versions which has the issue in 1.19 or 1.18?
the fix for the default behavior at master and 1.20 is fine. for readers, note that you can always override the etcd image using ClusterConfiguration.Etcd.

Discussion:
16: "3.3.17-0", 17: "3.4.3-0", 18: "3.4.3-0", <del> 19: "3.4.9-1", </del> <ins> 19: "3.4.13-0", </ins> 20: "3.4.13-0", 21: "3.4.13-0", }
Change:
<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: bazel-test-master Which test(s) are flaking: gotest: Testgrid link: Reason for failure: Anything else we need to know: links to appreciated [Will update shortly] links to specific failures in spyglass appreciated <!-- Please see the deflaking doc () for more guidance! --/sig api-machinery
The label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : Which jobs are flaking: bazel-test-master Which test(s) are flaking: gotest: Testgrid link: Reason for failure: links to appreciatedlinks to specific failures in spyglass appreciated /sig api-machinary Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig api-machinery
/assign /triage accepted
Flaked twice ~2 weeks ago but now looking good: Since it's been relatively quiet, I'm going to go ahead and close this for now. /close
Closing this issue. <detailsIn response to : Flaked twice ~2 weeks ago but now looking good: Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/reopen /assign I meet this test failure in And I can reproduce it with local stress testing. The reason is the same with
Reopened this issue. <detailsIn response to : /reopen /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
"github.com/google/go-cmp/cmp" "k8s.io/apimachinery/pkg/util/json" "k8s.io/apimachinery/pkg/util/sets" <ins> "k8s.io/apimachinery/pkg/util/wait" </ins> "k8s.io/apimachinery/pkg/util/waitgroup" auditinternal "k8s.io/apiserver/pkg/apis/audit" "k8s.io/apiserver/pkg/audit"

"/readyz/shutdown", } checkExpectedPathsAtRoot(server.URL, expectedPaths, t) <ins> // wait for health (max-in-flight-filter is initialized asynchronously, can take a few milliseconds to initialize) if err := wait.PollImmediate(100*time.Millisecond, wait.ForeverTestTimeout, func() (bool, error) { // healthz checks are installed in PrepareRun resp, err := http.Get(server.URL + "/healthz?exclude=wrapping-health&exclude=delegate-health") if err != nil { t.Fatal(err) } data, _ := ioutil.ReadAll(resp.Body) if http.StatusOK != resp.StatusCode { t.Logf("got %d", resp.StatusCode) t.Log(string(data)) return false, nil } return true, nil }); err != nil { t.Fatal(err) } </ins> checkPath(server.URL+"/healthz", http.StatusInternalServerError, `[+]ping ok [+]log ok [-]wrapping-health failed: reason withheld
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: When run below commands against master branch, only amd64 images are built. What you expected to happen: Images should be built successfully according to values set in . How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig release

Discussion:
echo "COPY nsswitch.conf /etc/" >> "${docker_file_path}" fi <del> "${DOCKER[@]}" build ${docker_build_opts:+"${docker_build_opts}"} -q -t "${docker_image_tag}" "${docker_build_path}" >/dev/null </del> <ins> if [[ "${arch}" == "linux/s390x" || "${arch}" == "linux/ppc64le" ]]; then DOCKER_CLI_EXPERIMENTAL=enabled "${DOCKER[@]}" buildx build --platform linux/"${arch}" --load ${docker_build_opts:+"${docker_build_opts}"} -q -t "${docker_image_tag}" "${docker_build_path}" >/dev/null else "${DOCKER[@]}" build ${docker_build_opts:+"${docker_build_opts}"} -q -t "${docker_image_tag}" "${docker_build_path}" >/dev/null fi </ins> # If we are building an official/alpha/beta release we want to keep # docker images and tag them appropriately. local -r release_docker_image_tag="${KUBE_DOCKER_REGISTRY-$docker_registry}/${binary_name}-${arch}:${KUBE_DOCKER_IMAGE_TAG-$docker_tag}"
Change:
<!-- Please only use this template for submitting enhancement requests --What would you like to be : When trying to build kubectl from tip () on a M1 Macbook: Why is this needed: M1 MacBooks are a new major client platform that many developers will use. brew listed kubectl (kubernetes-cli) is one of the major packages still not supported on M1 () Since it's supported by go, it's only required to add it to the supported client list Locally I managed to add support using the following patch:
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig cli architecture
/sig release
Any updates on this? cheers
you can watch the PR:
it works, nice!!!
Done!!!

Discussion:
linux/s390x linux/ppc64le darwin/amd64 <ins> darwin/arm64 </ins> windows/amd64 windows/386 )

linux/s390x linux/ppc64le darwin/amd64 <ins> darwin/arm64 </ins> windows/amd64 )

readonly KUBE_CLIENT_PLATFORMS elif [[ "${KUBE_FASTBUILD:-}" == "true" ]]; then <del> KUBE_SERVER_PLATFORMS=(linux/amd64) </del> <ins> host_arch=$(kube::util::host_arch) if [[ "${host_arch}" != "amd64" && "${host_arch}" != "arm64" ]]; then # on any platform other than amd64 and arm64, we just default to amd64 host_arch="amd64" fi KUBE_SERVER_PLATFORMS=("linux/${host_arch}") </ins> readonly KUBE_SERVER_PLATFORMS <del> KUBE_NODE_PLATFORMS=(linux/amd64) </del> <ins> KUBE_NODE_PLATFORMS=("linux/${host_arch}") </ins> readonly KUBE_NODE_PLATFORMS if [[ "${KUBE_BUILDER_OS:-}" == "darwin"* ]]; then KUBE_TEST_PLATFORMS=( <del> darwin/amd64 linux/amd64 </del> <ins> "darwin/${host_arch}" "linux/${host_arch}" </ins> ) readonly KUBE_TEST_PLATFORMS KUBE_CLIENT_PLATFORMS=( <del> darwin/amd64 linux/amd64 </del> <ins> "darwin/${host_arch}" "linux/${host_arch}" </ins> ) readonly KUBE_CLIENT_PLATFORMS else <del> KUBE_TEST_PLATFORMS=(linux/amd64) </del> <ins> KUBE_TEST_PLATFORMS=("linux/${host_arch}") </ins> readonly KUBE_TEST_PLATFORMS <del> KUBE_CLIENT_PLATFORMS=(linux/amd64) </del> <ins> KUBE_CLIENT_PLATFORMS=("linux/${host_arch}") </ins> readonly KUBE_CLIENT_PLATFORMS fi else

// interesting OS-based errors happen earlier. crossPlatforms = []string{ "linux/amd64", "windows/386", <del> "darwin/amd64", "linux/arm", "linux/386", "windows/amd64", "linux/arm64", "linux/ppc64le", "linux/s390x", </del> <ins> "darwin/amd64", "darwin/arm64", "linux/arm", "linux/386", "windows/amd64", "linux/arm64", "linux/ppc64le", "linux/s390x", </ins> } // directories we always ignore
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: docker-containerd have renamed to containerd, but EnsureDockerInContainer check not update,so it not work What you expected to happen: Is this check still needed How to reproduce it (as minimally and precisely as possible): no need Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig node
cc
feel free to send an PR update with new name for the process and the location of the pid file.

Discussion:
) const ( <del> dockerProcessName     = "dockerd" </del> <ins> dockerProcessName = "dockerd" // dockerd option --pidfile can specify path to use for daemon PID file, pid file path is default "/var/run/docker.pid" </ins> dockerPidFile         = "/var/run/docker.pid" <del> containerdProcessName = "docker-containerd" containerdPidFile     = "/run/docker/libcontainerd/docker-containerd.pid" </del> <ins> containerdProcessName = "containerd" </ins> maxPidFileLength      = 1 << 10 // 1KB )

type process struct{ name, file string } dockerProcs := []process{{dockerProcessName, dockerPidFile}} if dockerAPIVersion.AtLeast(containerdAPIVersion) { <ins> // By default containerd is started separately, so there is no pid file. containerdPidFile := "" </ins> dockerProcs = append(dockerProcs, process{containerdProcessName, containerdPidFile}) } var errs []error
Change:
Flakes in the past week: 4 Consistency: 78.90% /kind flake
the flakes should now be resolved by , can someone merge ? its a one character change. We just need an , has already reviewed it
/sig network
/triage accepted

Discussion:
// ProbePodToPodConnectivity runs a series of probes in kube, and records the results in `testCase.Reachability` func ProbePodToPodConnectivity(k8s *kubeManager, model *Model, testCase *TestCase) { <del> numberOfWorkers := 30 </del> <ins> numberOfWorkers := 3 // See https://github.com/kubernetes/kubernetes/pull/97690 </ins> allPods := model.AllPods() size := len(allPods) * len(allPods) jobs := make(chan *ProbeJob, size)
Change:
What happened: Some of our windows tests (in this case ) dont add enough scheduling metadata to behave predictably in environments where, for example, is required to interpret a pods proper location. A "bug" in EKS CNI actually causes EKS, for example, to not properly label such pods with IP addresses (because it uses an adm controller to add metadata before a pod is created, and that md is sent to eks's cni). In any case adding this metadata is a standard in Sig-windows, per conv with yesterday, so we'll want to add these in. As an example of the test failure which results when you dont have this selector.... Looking at the pod Spec: What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig windows

Discussion:
"github.com/onsi/ginkgo" ) <del> var _ = SIGDescribe("DNS", func() { </del> <ins> var _ = SIGDescribe("[Feature:Windows] DNS", func() { </ins> ginkgo.BeforeEach(func() { e2eskipper.SkipUnlessNodeOSDistroIs("windows")

Nameservers: []string{testInjectedIP}, Searches:    []string{testSearchPath}, } <ins> testUtilsPod.Spec.NodeSelector = map[string]string{ "kubernetes.io/os": "windows", } </ins> testUtilsPod, err := f.ClientSet.CoreV1().Pods(f.Namespace.Name).Create(context.TODO(), testUtilsPod, metav1.CreateOptions{}) framework.ExpectNoError(err) framework.Logf("Created pod %v", testUtilsPod)
Change:
similar to PR en route
/sig windows
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
image = imageutils.GetE2EImage(imageutils.Pause) ) <del> var _ = SIGDescribe("Windows volume mounts ", func() { </del> <ins> var _ = SIGDescribe("[Feature:Windows] Windows volume mounts ", func() { </ins> f := framework.NewDefaultFramework("windows-volumes") var ( emptyDirSource = v1.VolumeSource{

podName  = "pod-" + string(uuid.NewUUID()) pod      = testPodWithROVolume(podName, source, volumePath) ) <ins> pod.Spec.NodeSelector = map[string]string{ "kubernetes.io/os": "windows", } pod = f.PodClient().CreateSync(pod) ginkgo.By("verifying that pod has the correct nodeSelector") framework.ExpectEqual(pod.Spec.NodeSelector["kubernetes.io/os"], "windows") </ins> <del> f.PodClient().CreateSync(pod) </del> cmd := []string{"cmd", "/c", "echo windows-volume-test", ">", filePath} _, stderr, _ := f.ExecCommandInContainerWithFullOutput(podName, containerName, cmd...) framework.ExpectEqual(stderr, "Access is denied.") } func doReadWriteReadOnlyTest(f *framework.Framework, source v1.VolumeSource, volumePath string) {

pod             = testPodWithROVolume(podName, source, volumePath) rwcontainerName = containerName + "-rw" ) <ins> pod.Spec.NodeSelector = map[string]string{ "kubernetes.io/os": "windows", } </ins> rwcontainer := v1.Container{ Name:  containerName + "-rw",

} pod.Spec.Containers = append(pod.Spec.Containers, rwcontainer) <del> f.PodClient().CreateSync(pod) </del> <ins> pod = f.PodClient().CreateSync(pod) ginkgo.By("verifying that pod has the correct nodeSelector") framework.ExpectEqual(pod.Spec.NodeSelector["kubernetes.io/os"], "windows") </ins> cmd := []string{"cmd", "/c", "echo windows-volume-test", ">", filePath}

framework.ExpectNoError(err, readmsg) } <ins> // testPodWithROVolume makes a minimal pod defining a volume input source. Similarly to // other tests for sig-windows this should append a nodeSelector for windows. </ins> func testPodWithROVolume(podName string, source v1.VolumeSource, path string) *v1.Pod { return &v1.Pod{ TypeMeta: metav1.TypeMeta{
Change:
<!-- Please only use this template for submitting enhancement requests --What would you like to be : on multiple nodes, if one node failed, the command aborting. Without special purpose, maybe it's better to continue processing other nodes. Why is this needed: Follow the pattern of other subcommand, such as kubectl delete.
/sig cli
/triage accepted /assign
done /close
Closing this issue. <detailsIn response to : done /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
I would wait the patch get merged before closing :)

Discussion:
} cmd.Flags().BoolVar(&o.drainer.Force, "force", o.drainer.Force, "Continue even if there are pods not managed by a ReplicationController, ReplicaSet, Job, DaemonSet or StatefulSet.") cmd.Flags().BoolVar(&o.drainer.IgnoreAllDaemonSets, "ignore-daemonsets", o.drainer.IgnoreAllDaemonSets, "Ignore DaemonSet-managed pods.") <ins> cmd.Flags().BoolVar(&o.drainer.IgnoreErrors, "ignore-errors", o.drainer.IgnoreErrors, "Ignore errors occurred between drain nodes in group.") </ins> cmd.Flags().BoolVar(&o.drainer.DeleteEmptyDirData, "delete-local-data", o.drainer.DeleteEmptyDirData, "Continue even if there are pods using emptyDir (local data that will be deleted when the node is drained).") cmd.Flags().MarkDeprecated("delete-local-data", "This option is deprecated and will be deleted. Use --delete-emptydir-data.") cmd.Flags().BoolVar(&o.drainer.DeleteEmptyDirData, "delete-emptydir-data", o.drainer.DeleteEmptyDirData, "Continue even if there are pods using emptyDir (local data that will be deleted when the node is drained).")

drainedNodes.Insert(info.Name) printObj(info.Object, o.Out) } else { <ins> if o.drainer.IgnoreErrors && len(o.nodeInfos) > 1 { fmt.Fprintf(o.ErrOut, "error: unable to drain node %q due to error:%s, continuing command...n", info.Name, err) continue } fmt.Fprintf(o.ErrOut, "DEPRECATED WARNING: Aborting the drain command in a list of nodes will be deprecated.n"+ "The new behavior will make the drain command go through all nodes even if one or more nodes failed during the drain.n"+ "For now, users can try such experience via: --ignore-errorsn") </ins> fmt.Fprintf(o.ErrOut, "error: unable to drain node %q, aborting command...nn", info.Name) remainingNodes := []string{} fatal = err

Force               bool GracePeriodSeconds  int IgnoreAllDaemonSets bool <ins> IgnoreErrors        bool </ins> Timeout             time.Duration DeleteEmptyDirData  bool Selector            string