jiebi/CodeConvo huggingface dataset:
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: In https://k8s- failed due to . Afterwards crashed as follows: What you expected to happen: Graceful exit.
/assign

Discussion:
} function dump_nodes() { <del> local node_names </del> <ins> local node_names=() </ins> if [[ -n "${1:-}" ]]; then echo "Dumping logs for nodes provided as args to dump_nodes() function" node_names=( "$@" )

else echo "Detecting nodes in the cluster" detect-node-names &> /dev/null <del> node_names=( "${NODE_NAMES[@]}" ) </del> <ins> if [[ -n "${NODE_NAMES:-}" ]]; then node_names=( "${NODE_NAMES[@]}" ) fi </ins> fi if [[ "${#node_names[@]}" == 0 ]]; then

echo "Detecting nodes in the cluster" detect-node-names &> /dev/null <del> if [[ "${#NODE_NAMES[@]}" == 0 ]]; then </del> <ins> if [[ -z "${NODE_NAMES:-}" ]]; then </ins> echo "No nodes found!" return fi
Change:
/kind bug What happened: pull-kubernetes-cross complains: https://k8s-
/sig storage
For reference, root cause

Discussion:
srcs = [ "doc.go", "exec.go", <ins> "exec_mount_unsupported.go", </ins> "fake.go", "mount.go", "mount_unsupported.go",

<ins> // +build !linux /* Copyright 2017 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package mount import ( "errors" ) type execMounter struct{} // ExecMounter is a mounter that uses provided Exec interface to mount and // unmount a filesystem. For all other calls it uses a wrapped mounter. func NewExecMounter(exec Exec, wrapped Interface) Interface { return &execMounter{} } func (mounter *execMounter) Mount(source string, target string, fstype string, options []string) error { return nil } func (mounter *execMounter) Unmount(target string) error { return nil } func (mounter *execMounter) List() ([]MountPoint, error) { return []MountPoint{}, nil } func (mounter *execMounter) IsMountPointMatch(mp MountPoint, dir string) bool { return (mp.Path == dir) } func (mounter *execMounter) IsNotMountPoint(dir string) (bool, error) { return IsNotMountPoint(mounter, dir) } func (mounter *execMounter) IsLikelyNotMountPoint(file string) (bool, error) { return true, nil } func (mounter *execMounter) GetDeviceNameFromMount(mountPath, pluginDir string) (string, error) { return "", nil } func (mounter *execMounter) DeviceOpened(pathname string) (bool, error) { return false, nil } func (mounter *execMounter) PathIsDevice(pathname string) (bool, error) { return true, nil } func (mounter *execMounter) MakeRShared(path string) error { return nil } func (mounter *execMounter) GetFileType(pathname string) (FileType, error) { return FileType("fake"), errors.New("not implemented") } func (mounter *execMounter) MakeDir(pathname string) error { return nil } func (mounter *execMounter) MakeFile(pathname string) error { return nil } func (mounter *execMounter) ExistsPath(pathname string) bool { return true } </ins>
Change:
Is this a BUG REPORT or FEATURE REQUEST?: What happened: Now for storage class only support skuName with PremiumLRS and StandardLRS Met error if the storage account was created with other sku. But actually it can work well without setting it What you expected to happen: skuName should support others if the storage account support it How to reproduce it (as minimally and precisely as possible): Create a storage account which is using StandardRAGRS sku. Create storage class as below: Create pvc as below PVC would never bind with below error: Failed to provision volume with StorageClass "scazure": azureDisk - StandardRAGRS is not supported sku/storageaccounttype. Supported values are [PremiumLRS StandardLRS] But if I remove the skuName parameter, the pvc could be bound Anything else we need to know?: Environment: Kubernetes version (use ): Client Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.6+", GitCommit:"", GitTreeState:"clean", BuildDate:"2017-11-12T02:22:57Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.6+", GitCommit:"", GitTreeState:"clean", BuildDate:"2017-11-12T02:22:57Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"} Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): RHEL7 Install tools: ansible
/assign andyzhangx
/sig azure
thanks, it's a requirement, we should support StandardLRS, StandardZRS, StandardGRS, StandardRGRS, while for premium, it only support Premium_LRS
/kind feature
StandardZRS, PremiumGRS are not supported for azure disk now

Discussion:
string(api.AzureDedicatedBlobDisk), string(api.AzureManagedDisk)) <del> supportedStorageAccountTypes = sets.NewString("Premium_LRS", "Standard_LRS") </del> <ins> supportedStorageAccountTypes = sets.NewString("Premium_LRS", "Standard_LRS", "Standard_GRS", "Standard_RAGRS") </ins> ) func getPath(uid types.UID, volName string, host volume.VolumeHost) string {
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind cleanup What happened: This log seems to imply that we wait until less than some number of pods are un-ready, and yet the loop succeeds if there is no improvement. What you expected to happen: Either the loop should terminate earlier (if the condition is acceptable) or fail (if it's unacceptable).
/sig scalability since this probably most affects us
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
Stale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten /remove-lifecycle stale
Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close

Discussion:
var ignoreNotReady bool badPods := []v1.Pod{} desiredPods := 0 <ins> notReady := int32(0) </ins> if wait.PollImmediate(Poll, timeout, func() (bool, error) { // We get the new list of pods, replication controllers, and

return false, err } nOk := int32(0) <del> notReady := int32(0) </del> <ins> notReady = int32(0) </ins> badPods = []v1.Pod{} desiredPods = len(podList.Items) for _, pod := range podList.Items {

if !ignoreNotReady { return errors.New(errorBadPodsStates(badPods, desiredPods, ns, "RUNNING and READY", timeout)) } <del> Logf("Number of not-ready pods is allowed.") </del> <ins> Logf("Number of not-ready pods (%d) is below the allowed threshold (%d).", notReady, allowedNotReadyPods) </ins> } return nil }
Change:
Offshoot of regression - We are supporting "100 pods per node" in k8s officially () and need to make sure metadata-proxy allows those many pods to access the metadata service simultaneously. cc
cc
/assign
/sig auth
Xref

Discussion:
dnsPolicy: Default containers: - name: metadata-proxy <del> image: gcr.io/google_containers/metadata-proxy:v0.1.5 </del> <ins> image: gcr.io/google_containers/metadata-proxy:v0.1.6 </ins> securityContext: privileged: true <ins> # Request and limit resources to get guaranteed QoS. </ins> resources: requests: <del> memory: "32Mi" </del> <ins> memory: "25Mi" </ins> cpu: "30m" limits: <del> memory: "32Mi" </del> <ins> memory: "25Mi" </ins> cpu: "30m" # BEGIN_PROMETHEUS_TO_SD - name: prometheus-to-sd-exporter image: gcr.io/google_containers/prometheus-to-sd:v0.2.2 <ins> # Request and limit resources to get guaranteed QoS. resources: requests: memory: "20Mi" cpu: "2m" limits: memory: "20Mi" cpu: "2m" </ins> command: - /monitor - --stackdriver-prefix={{ prometheus_to_sd_prefix }}/addons
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: kube-proxy throws the following error message whena valid IP is used: The same error can be observed when running the UT: What you expected to happen: Errors should only be logged for invalid IP addresses. How to reproduce it (as minimally and precisely as possible): Run UT and observe or deploy kube-proxy and review logs.
/sig network /sig node

Discussion:
} // Check if host string is a valid IP address if ip := net.ParseIP(host); ip != nil { <ins> return ip.String() } else { </ins> glog.Errorf("invalid IP part '%s'", host) <del> return host </del> } return "" }
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug CheckpointNotFoundError has been completely removed by But GetPodPortMappings method was not updated to return nil, when a checkpoint was not available. What happened: The CNI network (that is done for the shared containers only for windows) call would fail in this case, which is breaking CNI in windows. What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
Related issue
/sig node /sig windows
/assign
Previous PR for tracking

Discussion:
"k8s.io/kubernetes/pkg/kubelet/network/kubenet" "k8s.io/kubernetes/pkg/kubelet/server/streaming" "k8s.io/kubernetes/pkg/kubelet/util/cache" <ins> utilstore "k8s.io/kubernetes/pkg/kubelet/util/store" </ins> "k8s.io/kubernetes/pkg/kubelet/dockershim/libdocker" "k8s.io/kubernetes/pkg/kubelet/dockershim/metrics"

checkpoint, err := ds.checkpointHandler.GetCheckpoint(podSandboxID) // Return empty portMappings if checkpoint is not found if err != nil { <ins> if err == utilstore.ErrKeyNotFound { return nil, nil } </ins> return nil, err }
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Deploy a cluster on azure with managed identity. The controller manager won't start: The following code tries to list all storage account in subscription, while it only has permission for the containing resource group. This issue would also apply for service principals with permission for the cluster resource group only. What you expected to happen: The cluster works correctly. How to reproduce it (as minimally and precisely as possible): Refer to: Anything else we need to know?: Environment: Updated: The client would only list the resources it has permission to, so the issue's cause here is not RBAC permission. Please see below comments for detail.
/sig azure
Checked the inner cause of the error log, the response returned by local msi endpoint is: There are 2 issues need to be fixed here: now needs metadata header Pending on integration with: storage account in current resource group master branch already contains that fix in 'go-autorest' , the issue is for v1.8 only
I have the same issue and expect fix for 1.8. Thanks
I don't think there would be a cherry-pick of azure SDK upgrade for a preview feature.

Discussion:
} func (c *BlobDiskController) getAllStorageAccounts() (map[string]*storageAccountState, error) { <del> accountListResult, err := c.common.cloud.StorageAccountClient.List() </del> <ins> accountListResult, err := c.common.cloud.StorageAccountClient.ListByResourceGroup(c.common.resourceGroup) </ins> if err != nil { return nil, err }
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: sometimes use vi edit /etc/kubernetes/manifests/kube-, apiserver will be kill, but not restart again; but sometimes is ok, kube-apiserver will restart.(test 10 times, and 2 times problem found) but if I move this file out of /etc/kubernetes/manifests/, wait for moment, and then move back, apiserver restart, problem fix. What you expected to happen: edit /etc/kubernetes/manifests/kube-, apiserver auto-update How to reproduce it (as minimally and precisely as possible): a k8s cluster. kube- by vi editor. apiserver status. Anything else we need to know?: any thing you want to know, please ping me. Environment: Kubernetes version (use ):Cloud provider or hardware configuration:none OS (e.g. from /etc/os-release):Kernel (e.g. ):Install tools: kubeadm Others:none
/sig node
could you help to fix this problem?
You mean changing file in folder ? Seems did not catch your changes. Any logs from ?
yes, and I have try again, got this:
but why is 4913, not the file kube- I have try several times, and got the same error message. by the way, following code, I arrive here: (), seem here to watch the file change.
Thanks for finding this bug. I will take a look.
after I add glog.Errorf("Be careful, I am going to check: %v", e.Name) to print log, I found this: has read the right file /etc/kubernetes/kube- must parse to pod success, because it knows the mirror older kube-apiserver is outdated add in ():
Right. was deleted first. That's why so many occurred afterwards. And the new pod for cannot be created as well. Seems we have to make a special treatment for , but this will be kind of ugly. Any suggestions?
relatived to but found in kubernetes v1.8.3 further more, following the code, I have found that create mirror pod failed, because kubelet can't connect to apiserver, and the code already filter the temp file .kube- So, the problem must be why kubelet can't start kube-apiserver static pod. But I can't find out where to create the static pod in code, Could you help?
is in (), I will continue to find out why kube-apiserver not start.
Good job! Thanks for the update. I prefer to move the discussion to .
It's a good idea, discussion in .
/close Move discussion to .

Discussion:
case statInfo.Mode().IsRegular(): pod, err := s.extractFromFile(path) if err != nil { <del> glog.Errorf("Can't process manifest file %q: %v", path, err) </del> <ins> if !os.IsNotExist(err) { glog.Errorf("Can't process manifest file %q: %v", path, err) } </ins> } else { pods = append(pods, pod) }
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: Create 50Gi podVolumeClaim with glusterfs provisioner. What you expected to happen: I expected 50Gi volume would be created, instead of 54Gi. How to reproduce it (as minimally and precisely as possible): storage class with glusterfs as dynamic provisioner. podVolumeClaim. Anything else we need to know?: Commit, that cause it: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/sig storage
Is it better to check binary/decimal format?
make sense
The bug doesn't exist in the commit you linked. Heketi can't provision volume in chunks of GiB that you are requesting, so it is never going to provision 50GiB if you asked for 50GiB. It will round the value upto GB and provision it. For example, if you are asking for 50GiB it will provision 51GiB after rounding upto to GBs. The problematic line in code is - That line incorrectly assumes returned integer from function to be in GiB whereas it is in GB, it should be relatively easy to change that line. So If you request 50GiB it will give you 54GB and 51GiB.
Yeah, inside the container i got:
Yep, the problem is in how the size is represented in PV. can you make a PR for fixing it?
Yes, it would be great.
Completely agree to what wrote. thanks for the PR.
/assign

Discussion:
} pv.Spec.Capacity = v1.ResourceList{ <del> v1.ResourceName(v1.ResourceStorage): resource.MustParse(fmt.Sprintf("%dGi", sizeGB)), </del> <ins> v1.ResourceName(v1.ResourceStorage): resource.MustParse(fmt.Sprintf("%dG", sizeGB)), </ins> } return pv, nil }
Change:
/kind bug What happened: e2e node summary test fails on machines with more than 10Gb of ram. What you expected to happen: memory limit bounds to look at node capacity rather than hardcode an upper bound. How to reproduce it (as minimally and precisely as possible): have more ram on a box and run e2e-node FOCUS=Summary Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/sig node

Discussion:
maxStartAge = time.Hour * 24 * 365 // 1 year maxStatsAge = time.Minute ) <del> fsCapacityBounds := bounded(100*framework.Mb, 100*framework.Gb) </del> <ins> // fetch node so we can know proper node memory bounds for unconstrained cgroups node := getLocalNode(f) memoryCapacity := node.Status.Capacity["memory"] memoryLimit := memoryCapacity.Value() fsCapacityBounds := bounded(100*framework.Mb, 10*framework.Tb) </ins> // Expectations for system containers. sysContExpectations := func() types.GomegaMatcher { return gstruct.MatchAllFields(gstruct.Fields{

"Time": recent(maxStatsAge), // We don't limit system container memory. "AvailableBytes":  BeNil(), <del> "UsageBytes":      bounded(1*framework.Mb, 10*framework.Gb), "WorkingSetBytes": bounded(1*framework.Mb, 10*framework.Gb), </del> <ins> "UsageBytes":      bounded(1*framework.Mb, memoryLimit), "WorkingSetBytes": bounded(1*framework.Mb, memoryLimit), </ins> // this now returns /sys/fs/cgroup/memory.stat total_rss <del> "RSSBytes":        bounded(1*framework.Mb, 1*framework.Gb), </del> <ins> "RSSBytes":        bounded(1*framework.Mb, memoryLimit), </ins> "PageFaults":      bounded(1000, 1E9), "MajorPageFaults": bounded(0, 100000), }),

"Time": recent(maxStatsAge), // We don't limit system container memory. "AvailableBytes":  BeNil(), <del> "UsageBytes":      bounded(100*framework.Kb, 10*framework.Gb), "WorkingSetBytes": bounded(100*framework.Kb, 10*framework.Gb), "RSSBytes":        bounded(100*framework.Kb, 1*framework.Gb), </del> <ins> "UsageBytes":      bounded(100*framework.Kb, memoryLimit), "WorkingSetBytes": bounded(100*framework.Kb, memoryLimit), "RSSBytes":        bounded(100*framework.Kb, memoryLimit), </ins> "PageFaults":      bounded(1000, 1E9), "MajorPageFaults": bounded(0, 100000), })

}), "Memory": ptrMatchAllFields(gstruct.Fields{ "Time":            recent(maxStatsAge), <del> "AvailableBytes":  bounded(100*framework.Mb, 100*framework.Gb), "UsageBytes":      bounded(10*framework.Mb, 10*framework.Gb), "WorkingSetBytes": bounded(10*framework.Mb, 10*framework.Gb), </del> <ins> "AvailableBytes":  bounded(100*framework.Mb, memoryLimit), "UsageBytes":      bounded(10*framework.Mb, memoryLimit), "WorkingSetBytes": bounded(10*framework.Mb, memoryLimit), </ins> // this now returns /sys/fs/cgroup/memory.stat total_rss <del> "RSSBytes":        bounded(1*framework.Kb, 1*framework.Gb), </del> <ins> "RSSBytes":        bounded(1*framework.Kb, memoryLimit), </ins> "PageFaults":      bounded(1000, 1E9), "MajorPageFaults": bounded(0, 100000), }),
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: is failing with: What you expected to happen: The cross build should work,. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: It looks like this happened in , probably because we don't block the queue on cross :-( xref: /priority failing-test /sig release
Additionally ideally sig-release should for this job.
/assign
, is making a fix and then we'll look at making sure cross blocks PRs it runs against in the future.

Discussion:
var _ Interface = new(cadvisorUnsupported) <del> func New(address string, port uint, imageFsInfoProvider ImageFsInfoProvider, rootPath string) (Interface, error) { </del> <ins> func New(address string, port uint, imageFsInfoProvider ImageFsInfoProvider, rootPath string, usingLegacyStats bool) (Interface, error) { </ins> return &cadvisorUnsupported{}, nil }

var _ Interface = new(cadvisorClient) // New creates a cAdvisor and exports its API on the specified port if port > 0. <del> func New(address string, port uint, imageFsInfoProvider ImageFsInfoProvider, rootPath string) (Interface, error) { </del> <ins> func New(address string, port uint, imageFsInfoProvider ImageFsInfoProvider, rootPath string, usingLegacyStats bool) (Interface, error) { </ins> client, err := winstats.NewPerfCounterClient() return &cadvisorClient{winStatsClient: client}, err }
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: An error occured when creating a PersistentVolumeClaim on a single node cluster created with kubeadm. The cluster is created by following The PersistentVolumeClaim remains Pending and we see the following errors in the log of the kube-controller-manager: What you expected to happen: A Persistent Volume is created and ready to use How to reproduce it (as minimally and precisely as possible): create a single node cluster on gce with kubeadm, eg create a StorageClasscreate a PersistentVolumeClaim Anything else we need to know?: We are also having this issue on a cluster we try to create from scratch on GCE using CentOS. Environment: Kubernetes version (use ): 1.8.3 Cloud provider or hardware configuration: GCP OS (e.g. from /etc/os-release): Ubuntu 17.04 Kernel (e.g. ): Linux kubeadm-single-node-cluster 4.10.0-38-generic -Ubuntu SMP Tue Oct 10 13:24:27 UTC 2017 x8664 x8664 x86_64 GNU/Linux Install tools: kubeadm Others:
/sig gcp /sig storage
thanks for reporting this! I send a PR to fix this:
/cc

Discussion:
glog.Errorf("Encountered error for creating alpha feature gate: %v", err) } cloudConfig.AlphaFeatureGate = alphaFeatureGate <ins> } else { // initialize AlphaFeatureGate when no AlphaFeatures are configured. alphaFeatureGate, err := NewAlphaFeatureGate([]string{}) if err != nil { glog.Errorf("Encountered error for initializing alpha feature gate: %v", err) } cloudConfig.AlphaFeatureGate = alphaFeatureGate </ins> } // retrieve projectID and zone
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug /priority failing-test What happened: https://k8s- failed with: Attached graph shows that it's not a huge increase from normal usage. Dear SIG networking, is this expected? Should we just bump the limit? ! Please note this is in a release-blocking job.
Umbrella bug:
We were seeing a similar issue for memory a while ago () for l7-lb-controller.

Discussion:
MemoryConstraint: 100 * (1024 * 1024), } constraints["l7-lb-controller"] = framework.ResourceConstraint{ <del> CPUConstraint:    0.2 + 0.0001*float64(numNodes), </del> <ins> CPUConstraint:    0.2 + 0.00015*float64(numNodes), </ins> MemoryConstraint: (75 + uint64(math.Ceil(0.8*float64(numNodes)))) * (1024 * 1024), } constraints["influxdb"] = framework.ResourceConstraint{