Change:
When an auth proxy tries to proxy an anonymous request, the user.Info ends up with the group system:authenticated, which is wrong.

Discussion:
"//vendor:k8s.io/apiserver/pkg/authentication/request/union", "//vendor:k8s.io/apiserver/pkg/authentication/request/x509", "//vendor:k8s.io/apiserver/pkg/authentication/token/tokenfile", <del> "//vendor:k8s.io/apiserver/pkg/authentication/user", </del> "//vendor:k8s.io/apiserver/plugin/pkg/authenticator/password/keystone", "//vendor:k8s.io/apiserver/plugin/pkg/authenticator/password/passwordfile", "//vendor:k8s.io/apiserver/plugin/pkg/authenticator/request/basicauth",

"k8s.io/apiserver/pkg/authentication/request/union" "k8s.io/apiserver/pkg/authentication/request/x509" "k8s.io/apiserver/pkg/authentication/token/tokenfile" <del> "k8s.io/apiserver/pkg/authentication/user" </del> "k8s.io/apiserver/plugin/pkg/authenticator/password/keystone" "k8s.io/apiserver/plugin/pkg/authenticator/password/passwordfile" "k8s.io/apiserver/plugin/pkg/authenticator/request/basicauth"

authenticator := union.New(authenticators...) <del> authenticator = group.NewGroupAdder(authenticator, []string{user.AllAuthenticated}) </del> <ins> authenticator = group.NewAuthenticatedGroupAdder(authenticator) </ins> if config.Anonymous { // If the authenticator chain returns an error, return an error (don't consider a bad bearer token anonymous).

"k8s.io/apiserver/pkg/authentication/request/headerrequest" unionauth "k8s.io/apiserver/pkg/authentication/request/union" "k8s.io/apiserver/pkg/authentication/request/x509" <del> "k8s.io/apiserver/pkg/authentication/user" </del> webhooktoken "k8s.io/apiserver/plugin/pkg/authenticator/token/webhook" authenticationclient "k8s.io/client-go/kubernetes/typed/authentication/v1beta1" "k8s.io/client-go/util/cert"

return nil, nil, errors.New("No authentication method configured") } <del> authenticator := group.NewGroupAdder(unionauth.New(authenticators...), []string{user.AllAuthenticated}) </del> <ins> authenticator := group.NewAuthenticatedGroupAdder(unionauth.New(authenticators...)) </ins> if c.Anonymous { authenticator = unionauth.NewFailOnError(authenticator, anonymous.NewAuthenticator()) }

<ins> /* Copyright 2017 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package group import ( "net/http" "k8s.io/apiserver/pkg/authentication/authenticator" "k8s.io/apiserver/pkg/authentication/user" ) // AuthenticatedGroupAdder adds system:authenticated group when appropriate type AuthenticatedGroupAdder struct { // Authenticator is delegated to make the authentication decision Authenticator authenticator.Request } // NewAuthenticatedGroupAdder wraps a request authenticator, and adds the system:authenticated group when appropriate. // Authentication must succeed, the user must not be system:anonymous, the groups system:authenticated or system:unauthenticated must // not be present func NewAuthenticatedGroupAdder(auth authenticator.Request) authenticator.Request { return &AuthenticatedGroupAdder{auth} } func (g *AuthenticatedGroupAdder) AuthenticateRequest(req *http.Request) (user.Info, bool, error) { u, ok, err := g.Authenticator.AuthenticateRequest(req) if err != nil || !ok { return nil, ok, err } if u.GetName() == user.Anonymous { return u, true, nil } for _, group := range u.GetGroups() { if group == user.AllAuthenticated || group == user.AllUnauthenticated { return u, true, nil } } return &user.DefaultInfo{ Name:   u.GetName(), UID:    u.GetUID(), Groups: append(u.GetGroups(), user.AllAuthenticated), Extra:  u.GetExtra(), }, true, nil } </ins>

t.Errorf("Expected original,added groups, got %#v", user.GetGroups()) } } <ins> func TestAuthenticatedGroupAdder(t *testing.T) { tests := []struct { name         string inputUser    user.Info expectedUser user.Info }{ { name: "add", inputUser: &user.DefaultInfo{ Name:   "user", Groups: []string{"some-group"}, }, expectedUser: &user.DefaultInfo{ Name:   "user", Groups: []string{"some-group", user.AllAuthenticated}, }, }, { name: "don't double add", inputUser: &user.DefaultInfo{ Name:   "user", Groups: []string{user.AllAuthenticated, "some-group"}, }, expectedUser: &user.DefaultInfo{ Name:   "user", Groups: []string{user.AllAuthenticated, "some-group"}, }, }, { name: "don't add for anon", inputUser: &user.DefaultInfo{ Name:   user.Anonymous, Groups: []string{"some-group"}, }, expectedUser: &user.DefaultInfo{ Name:   user.Anonymous, Groups: []string{"some-group"}, }, }, { name: "don't add for unauthenticated group", inputUser: &user.DefaultInfo{ Name:   "user", Groups: []string{user.AllUnauthenticated, "some-group"}, }, expectedUser: &user.DefaultInfo{ Name:   "user", Groups: []string{user.AllUnauthenticated, "some-group"}, }, }, } for _, test := range tests { adder := authenticator.Request( NewAuthenticatedGroupAdder( authenticator.RequestFunc(func(req *http.Request) (user.Info, bool, error) { return test.inputUser, true, nil }), ), ) user, _, _ := adder.AuthenticateRequest(nil) if !reflect.DeepEqual(user, test.expectedUser) { t.Errorf("got %#v", user) } } } </ins>

go_library( name = "k8s.io/apiserver/pkg/authentication/group", <del> srcs = ["k8s.io/apiserver/pkg/authentication/group/group_adder.go"], </del> <ins> srcs = [ "k8s.io/apiserver/pkg/authentication/group/authenticated_group_adder.go", "k8s.io/apiserver/pkg/authentication/group/group_adder.go", ], </ins> tags = ["automanaged"], deps = [ "//vendor:k8s.io/apiserver/pkg/authentication/authenticator",