jiebi/CodeConvo huggingface dataset:
Change:
Since 2 days ago, the test is becoming more and more flaky, and one of the examples is: https://k8s-
There are no sig labels on this issue. Please by:<br(1) mentioning a sig: <bre.g., for API Machinery<br(2) specifying the label manually: <bre.g., for sig/scalability<br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list
please triage this one. Currently I put it as the release blocker, and please feel free to remove that if you think it is not. Thanks!
The test deletes the node, and at the end, waits 5 minutes for the node to become ready, but it timed out. cc
The test logic hasn't changed after I last modified it, so the test deletes the node through gcloud, and the instance should be restarted automatically by GCE because it's part of an instance template. The likely possibility, as pointed out, is that another change made node discovery take longer, so extending the timeout would be enough. The very unlikely possibility is there's a problem discovering brand new instances.

Discussion:
podClient.Delete(host0Pod.Name, metav1.NewDeleteOptions(0)) detachAndDeletePDs(diskName, []types.NodeName{host0Name}) framework.WaitForNodeToBeReady(f.ClientSet, string(host0Name), nodeStatusTimeout) <ins> framework.WaitForAllNodesSchedulable(f.ClientSet, nodeStatusTimeout) </ins> nodes = framework.GetReadySchedulableNodesOrDie(f.ClientSet) <del> Expect(len(nodes.Items)).To(Equal(initialGroupSize)) </del> <ins> Expect(len(nodes.Items)).To(Equal(initialGroupSize), "Requires node count to return to initial group size.") </ins> }() By("submitting host0Pod to kubernetes")

originalCount := len(nodes.Items) containerName := "mycontainer" nodeToDelete := &nodes.Items[0] <del> defer func() error { </del> <ins> defer func() { </ins> By("Cleaning up PD-RW test env") detachAndDeletePDs(diskName, []types.NodeName{host0Name}) nodeToDelete.ObjectMeta.SetResourceVersion("0")

framework.ExpectNoError(err, "Unable to re-create the deleted node") framework.ExpectNoError(framework.WaitForGroupSize(framework.TestContext.CloudConfig.NodeInstanceGroup, int32(initialGroupSize)), "Unable to get the node group back to the original size") framework.WaitForNodeToBeReady(f.ClientSet, nodeToDelete.Name, nodeStatusTimeout) <ins> framework.WaitForAllNodesSchedulable(f.ClientSet, nodeStatusTimeout) </ins> nodes = framework.GetReadySchedulableNodesOrDie(f.ClientSet) <del> if len(nodes.Items) != originalCount { return fmt.Errorf("The node count is not back to original count") } return nil </del> <ins> Expect(len(nodes.Items)).To(Equal(originalCount), "Requires node count to return to original node count.") </ins> }() By("submitting host0Pod to kubernetes")
Change:
When an object is told to encode its nested objects, the preferred encoding version is not provided for it to use. That means nested objects with more than one possible serialized version use the default instead of the requested version.

Discussion:
} if e, ok := out.(runtime.NestedObjectEncoder); ok { <del> if err := e.EncodeNestedObjects(DirectEncoder{Encoder: c.encoder, ObjectTyper: c.typer}); err != nil { </del> <ins> if err := e.EncodeNestedObjects(DirectEncoder{Version: c.encodeVersion, Encoder: c.encoder, ObjectTyper: c.typer}); err != nil { </ins> return err } }
Change:
1 tests failed, 3 jobs failed, 73 builds failed. Failure stats cover 1 day time range '26 Jun 2017 23:52 UTC' to '27 Jun 2017 23:52 UTC'. <details<summaryRationale for assignments:</summary </details<br
There are no sig labels on this issue. Please by:<br(1) mentioning a sig: <bre.g., for API Machinery<br(2) specifying the label manually: <bre.g., for sig/scalability<br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list
This was broke by . I'm working on a fix for this. /assign

Discussion:
return resTags.Items } <ins> // GetNodeTags gets k8s node tag from one of the nodes func GetNodeTags(c clientset.Interface, cloudConfig CloudConfig) []string { nodes := GetReadySchedulableNodesOrDie(c) if len(nodes.Items) == 0 { Logf("GetNodeTags: Found 0 node.") return []string{} } return GetInstanceTags(cloudConfig, nodes.Items[0].Name).Items } </ins> // GetInstancePrefix returns the INSTANCE_PREFIX env we set for e2e cluster. // From cluster/gce/config-test.sh, master name is set up using below format: // MASTER_NAME="${INSTANCE_PREFIX}-master"

} // ConstructFirewallForIngress returns the expected GCE firewall rule for the ingress resource <del> func (j *IngressTestJig) ConstructFirewallForIngress(gceController *GCEIngressController, nodeTag string) *compute.Firewall { </del> <ins> func (j *IngressTestJig) ConstructFirewallForIngress(gceController *GCEIngressController, nodeTags []string) *compute.Firewall { </ins> nodePorts := j.GetIngressNodePorts() fw := compute.Firewall{} fw.Name = gceController.GetFirewallRuleName() fw.SourceRanges = gcecloud.LoadBalancerSrcRanges() <del> fw.TargetTags = []string{nodeTag} </del> <ins> fw.TargetTags = nodeTags </ins> fw.Allowed = []*compute.FirewallAllowed{ { IPProtocol: "tcp",

By("should have correct firewall rule for ingress") fw := gceController.GetFirewallRule() <del> expFw := jig.ConstructFirewallForIngress(gceController, cloudConfig.NodeTag) </del> <ins> nodeTags := []string{cloudConfig.NodeTag} if framework.TestContext.Provider != "gce" { // nodeTags would be different in GKE. nodeTags = framework.GetNodeTags(jig.Client, cloudConfig) } expFw := jig.ConstructFirewallForIngress(gceController, nodeTags) </ins> // Passed the last argument as `true` to verify the backend ports is a subset // of the allowed ports in firewall rule, given there may be other existing // ingress resources and backends we are not aware of.
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: bug What happened: Got panic after running: Panic: What you expected to happen: No panic and exit successfully. How to reproduce it (as minimally and precisely as possible): Run the following command on both CoreOS v1298.7.0(bare metal) and Ubuntu 16.04.2 LTS(OpenStack) Happened with the following versions: v1.7.0-alpha.3 v1.7.0-alpha.4 v1.7.0-beta.0 v1.7.0-beta.1 v1.7.0-beta.2 v1.7.0-rc.1 v1.8.0-alpha.0 v1.8.0-alpha.1 Anything else we need to know?: I guess it caused by . Environment: Kubernetes version (use ): Cloud provider or hardware configuration**: OS (e.g. from /etc/os-release): Both CoreOS v1298.7.0(bare metal) and Ubuntu 16.04.2 LTS(OpenStack) Kernel (e.g. ): CoreOS v1298.7.0: Linux node- 4.9.16-coreos-r1 SMP Tue Apr 4 19:09:38 UTC 2017 x8664 Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz GenuineIntel GNU/Linux Ubuntu 16.04.2 LTS: Linux ubuntu- 4.4.0-62-generic -Ubuntu SMP Wed Jan 18 14:10:15 UTC 2017 x8664 x8664 x8664 GNU/Linux Install tools: Others:
There are no sig labels on this issue. Please by:<br(1) mentioning a sig: <bre.g., for API Machinery<br(2) specifying the label manually: <bre.g., for sig/scalability<br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list
/sig network /area kube-proxy
/cc
cc/ Looks like there is a new regression in v1.7. Please triage this to decide if it is a release blocker. If not, please provide the workaround for the users. Thanks! cc/
Digging into the code, will send a PR.
PR sent. Folks review it please.
Added the release-blocker label. We got a PR for it very fast so it won't delay the release anyway, thanks

Discussion:
// We omit creation of pretty much everything if we run in cleanup mode if cleanupAndExit { <del> return &ProxyServer{IptInterface: iptInterface}, nil </del> <ins> return &ProxyServer{IptInterface: iptInterface, CleanupAndExit: cleanupAndExit}, nil </ins> } client, eventClient, err := createClients(config.ClientConnection, master)

} } <del> s.Broadcaster.StartRecordingToSink(&v1core.EventSinkImpl{Interface: s.EventClient.Events("")}) </del> <ins> if s.Broadcaster != nil && s.EventClient != nil { s.Broadcaster.StartRecordingToSink(&v1core.EventSinkImpl{Interface: s.EventClient.Events("")}) } </ins> // Start up a healthz server if requested if s.HealthzServer != nil {
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: bug What happened: Got panic after running: Panic: What you expected to happen: No panic and exit successfully. How to reproduce it (as minimally and precisely as possible): Run the following command on both CoreOS v1298.7.0(bare metal) and Ubuntu 16.04.2 LTS(OpenStack) Happened with the following versions: v1.7.0-alpha.3 v1.7.0-alpha.4 v1.7.0-beta.0 v1.7.0-beta.1 v1.7.0-beta.2 v1.7.0-rc.1 v1.8.0-alpha.0 v1.8.0-alpha.1 Anything else we need to know?: I guess it caused by . Environment: Kubernetes version (use ): Cloud provider or hardware configuration**: OS (e.g. from /etc/os-release): Both CoreOS v1298.7.0(bare metal) and Ubuntu 16.04.2 LTS(OpenStack) Kernel (e.g. ): CoreOS v1298.7.0: Linux node- 4.9.16-coreos-r1 SMP Tue Apr 4 19:09:38 UTC 2017 x8664 Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz GenuineIntel GNU/Linux Ubuntu 16.04.2 LTS: Linux ubuntu- 4.4.0-62-generic -Ubuntu SMP Wed Jan 18 14:10:15 UTC 2017 x8664 x8664 x8664 GNU/Linux Install tools: Others:
There are no sig labels on this issue. Please by:<br(1) mentioning a sig: <bre.g., for API Machinery<br(2) specifying the label manually: <bre.g., for sig/scalability<br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list
/sig network /area kube-proxy
/cc
cc/ Looks like there is a new regression in v1.7. Please triage this to decide if it is a release blocker. If not, please provide the workaround for the users. Thanks! cc/
Digging into the code, will send a PR.
PR sent. Folks review it please.
Added the release-blocker label. We got a PR for it very fast so it won't delay the release anyway, thanks

Discussion:
func AddFlags(options *Options, fs *pflag.FlagSet) { fs.StringVar(&options.ConfigFile, "config", options.ConfigFile, "The path to the configuration file.") fs.StringVar(&options.WriteConfigTo, "write-config-to", options.WriteConfigTo, "If set, write the default configuration values to this file and exit.") <del> fs.BoolVar(&options.CleanupAndExit, "cleanup-iptables", options.CleanupAndExit, "If true cleanup iptables rules and exit.") </del> <ins> fs.BoolVar(&options.CleanupAndExit, "cleanup-iptables", options.CleanupAndExit, "If true, cleanup iptables rules and exit.") </ins> // All flags below here are deprecated and will eventually be removed.

assert.Nil(t, err, "unexpected error in NewProxyServer, addr: %s", addr) assert.NotNil(t, proxyserver, "nil proxy server obj, addr: %s", addr) assert.NotNil(t, proxyserver.IptInterface, "nil iptables intf, addr: %s", addr) <ins> assert.True(t, proxyserver.CleanupAndExit, "false CleanupAndExit, addr: %s", addr) </ins> // Clean up config for next test case configz.Delete("componentconfig")
Change:
It was introduced by cc/
cc/
Only in 1.7 or also 1.8?
PR sent.

Discussion:
return nil } <ins> func (cm *unsupportedContainerManager) GetCapacity() v1.ResourceList { return nil } </ins> func (cm *unsupportedContainerManager) NewPodContainerManager() PodContainerManager { return &unsupportedPodContainerManager{} }
Change:
Resources can be deleted, but still exist in the API before they are reaped. They should not be valid during this time.
I'll add this to my pile. Thanks for filing :+1: FYI
FYI as well

Discussion:
return nil, false, err } <ins> if secret.DeletionTimestamp != nil { tokenErrorf(secret, "is deleted and awaiting removal") return nil, false, nil } </ins> if string(secret.Type) != string(bootstrapapi.SecretTypeBootstrapToken) || secret.Data == nil { tokenErrorf(secret, "has invalid type, expected %s.", bootstrapapi.SecretTypeBootstrapToken) return nil, false, nil

) func TestTokenAuthenticator(t *testing.T) { <ins> now := metav1.Now() </ins> tests := []struct { name string

wantNotFound: true, }, { <ins> name: "deleted token", secrets: []*api.Secret{ { ObjectMeta: metav1.ObjectMeta{ Name:              bootstrapapi.BootstrapTokenSecretPrefix + tokenID, DeletionTimestamp: &now, }, Data: map[string][]byte{ bootstrapapi.BootstrapTokenIDKey:               []byte(tokenID), bootstrapapi.BootstrapTokenSecretKey:           []byte(tokenSecret), bootstrapapi.BootstrapTokenUsageAuthentication: []byte("true"), }, Type: "bootstrap.kubernetes.io/token", }, }, token:        tokenID + "." + tokenSecret, wantNotFound: true, }, { </ins> name: "expired token", secrets: []*api.Secret{ {
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Creating service(type: LoadBalancer, sessionAffinity: ClientIP), service has no affinity. What you expected to happen: The service has affinity How to reproduce it (as minimally and precisely as possible): a service, its yaml as following: kind: Service apiVersion: v1 metadata: labels: app: application name: application spec: type: LoadBalancer ports: port: 80 targetPort: 9091 sessionAffinity: ClientIP selector: app: application request from Neutron, check the value of "Persistence" Anything else we need to know?: Kubernetes's OpenStack cloudprovider can't set persistence to "SOURCE_IP". Environment: Kubernetes version (use ): kubernetes 1.6.4
There are no sig labels on this issue. Please by:<br(1) mentioning a sig: <bre.g., for API Machinery<br(2) specifying the label manually: <bre.g., for sig/scalability<br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list
/sig network
/assign
Fixed in /close

Discussion:
return nil, fmt.Errorf("Source range restrictions are not supported for openstack load balancers without managing security groups") } <del> affinity := v1.ServiceAffinityNone </del> <ins> affinity := apiService.Spec.SessionAffinity </ins> var persistence *v2pools.SessionPersistence switch affinity { case v1.ServiceAffinityNone:
Change:
broke support for specifying network name.
There are no sig labels on this issue. Please by:<br(1) mentioning a sig: <bre.g., for API Machinery<br(2) specifying the label manually: <bre.g., for sig/scalability<br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list
/sig network /assign /area platform/gce
This seems to be responsible for the bloodbath here: http://k8s- Since this has been broken for a while we're just going to roll forward-- Nick already has a PR out.
On second thought, I believe I'm swapping one issue for another. My PR fixes the network's name, but may be breaking the network's project ID for GKE tests. Current Behavior: The compute project ID is used as the network project. This is used for generating network and subnetwork URLS. PR's Behavior With the introduction of shared networks, the cloudprovider should get the network project via configuration. If not specified, it'll look at the local network metadata to determine which network project the local VM is using. This makes sense for unmanaged K8s clusters on XPN. However, on GKE, the master is not running on the same network as the cluster; therefore, the configuration value is needed. Plumbing the network project via environment variable has not yet merged upstream. After this PR merges, I'll submit another PR that uses the compute project ID instead of metadata as default. I'll revert this default behavior after several weeks when the GKE dependency is active.

Discussion:
projectID = cfg.Global.ProjectID } <del> if cfg.Global.NetworkName != "" && strings.Contains(cfg.Global.NetworkName, "/") { networkURL = cfg.Global.NetworkName } else { networkURL = gceNetworkURL(apiEndpoint, projectID, networkName) </del> <ins> if cfg.Global.NetworkName != "" { if strings.Contains(cfg.Global.NetworkName, "/") { networkURL = cfg.Global.NetworkName } else { networkURL = gceNetworkURL(apiEndpoint, projectID, networkName) } </ins> } <del> if cfg.Global.SubnetworkName != "" && strings.Contains(cfg.Global.SubnetworkName, "/") { subnetworkURL = cfg.Global.SubnetworkName } else { subnetworkURL = gceSubnetworkURL(apiEndpoint, cfg.Global.ProjectID, region, cfg.Global.SubnetworkName) </del> <ins> if cfg.Global.SubnetworkName != "" { if strings.Contains(cfg.Global.SubnetworkName, "/") { subnetworkURL = cfg.Global.SubnetworkName } else { subnetworkURL = gceSubnetworkURL(apiEndpoint, projectID, region, cfg.Global.SubnetworkName) } </ins> } if cfg.Global.TokenURL != "" { tokenSource = NewAltTokenSource(cfg.Global.TokenURL, cfg.Global.TokenBody) }
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: Feature Default FlexVolume driver directory is , which is not writable on COS images. Should have a different default directory to enable FlexVolume on COS. /kind feature /assign
/sig storage
There are no sig labels on this issue. Please by:<br(1) mentioning a sig: <bre.g., for API Machinery<br(2) specifying the label manually: <bre.g., for sig/scalability<br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list

Discussion:
FEATURE_GATES: $(yaml-quote ${FEATURE_GATES}) EOF fi <ins> if [[ "${master}" == "true" && "${MASTER_OS_DISTRIBUTION}" == "gci" ]] || [[ "${master}" == "false" && "${NODE_OS_DISTRIBUTION}" == "gci" ]]; then cat >>$file <<EOF VOLUME_PLUGIN_DIR: $(yaml-quote ${VOLUME_PLUGIN_DIR:-/home/kubernetes/flexvolume}) EOF fi </ins> if [ -n "${PROVIDER_VARS:-}" ]; then local var_name
Change:
Example call stack from : We should fix this and add an integration test that sets the limit low and exercises apiserver when it is getting too many requests.
There are no sig labels on this issue. Please by:<br(1) mentioning a sig: <bre.g., for API Machinery<br(2) specifying the label manually: <bre.g., for sig/scalability<br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list
Should be fixed by the above PR. Closing it.

Discussion:
"k8s.io/apiserver/pkg/endpoints/metrics" apirequest "k8s.io/apiserver/pkg/endpoints/request" genericapirequest "k8s.io/apiserver/pkg/endpoints/request" <del> "k8s.io/apiserver/pkg/server/httplog" </del> "github.com/golang/glog" )

} func tooManyRequests(req *http.Request, w http.ResponseWriter) { <del> // "Too Many Requests" response is returned before logger is setup for the request. // So we need to explicitly log it here. defer httplog.NewLogged(req, &w).Log() </del> // Return a 429 status indicating "Too Many Requests" w.Header().Set("Retry-After", retryAfter) http.Error(w, "Too many requests, please try again later.", errors.StatusTooManyRequests)
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: After starting controller manager, get the following panic: /---------------------------------- I0712 08:54:30. 1 ] Deleting route 10.245.1.0/24 10.245.1.0/24 I0712 08:54:30. 1 ] Creating route for node ab-6l35lzekrg-0-7igjn3vr43tw-kube-minion-abhezrwnqucq 10.245.1.0/24 with hint -655c-11e7-9a48-, throttled 1.602µs I0712 08:54:30. 1 ] Creating route for node ab-hfvphu5tyl-0-623ksgxczeoh-kube-master-oevhfzd3xo7s 10.245.0.0/24 with hint -655c-11e7-9a48-, throttled 651ns I0712 08:54:31. 1 ] Created route for node ab-6l35lzekrg-0-7igjn3vr43tw-kube-minion-abhezrwnqucq 10.245.1.0/24 with hint -655c-11e7-9a48- after 349.278413ms I0712 08:54:32. 1 ] Created route for node ab-hfvphu5tyl-0-623ksgxczeoh-kube-master-oevhfzd3xo7s 10.245.0.0/24 with hint -655c-11e7-9a48- after 1.583805322s panic: runtime error: index out of range goroutine 1250 [running]: panic(0x3a3d4e0, 0xc42001a080) +0x1a1 (Routes).DeleteRoute(0xc4212e15a0, 0x40ff60e, 0xa, 0xc421bf22a0, 0x0, 0x0) +0x7d5 (RouteController).reconcile.func2(0xc4210bed70, 0xc421bf05e0, 0xc421bf22a0, 0xed0f7dac6, 0x3264f461, 0x6f143e0) +0x15a created by (RouteController).reconcile +0x6e6 /---------------------------------- What you expected to happen: Successed to delete route. How to reproduce it (as minimally and precisely as possible): verytime Anything else we need to know?: Environment: Kubernetes version (use ): v1.6.4 Cloud provider or hardware configuration*: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: cc /sig-openstack
There are no sig labels on this issue. Please by:<br(1) mentioning a sig: <bre.g., for API Machinery<br(2) specifying the label manually: <bre.g., for sig/scalability<br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list
cc
Reiterating the mentions to trigger a notification: <detailsIn response to : cc Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
if index != -1 { // Delete element `index` <del> addr_pairs[index] = addr_pairs[len(routes)-1] addr_pairs = addr_pairs[:len(routes)-1] </del> <ins> addr_pairs[index] = addr_pairs[len(addr_pairs)-1] addr_pairs = addr_pairs[:len(addr_pairs)-1] </ins> unwind, err := updateAllowedAddressPairs(r.network, &port, addr_pairs) if err != nil {
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --/kind feature What happened: in kubectl 1.7.0 and cluster 1.7.0 What you expected to happen: there is an in the list and tells the short-cut was . How to reproduce it (as minimally and precisely as possible): none Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration**: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
There are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals
/sig cli yeah we should do it.
/assign will fix it.

Discussion:
* configmaps (aka 'cm') * controllerrevisions * cronjobs <ins> * customresourcedefinition (aka 'crd') </ins> * daemonsets (aka 'ds') * deployments (aka 'deploy') * endpoints (aka 'ep')