Change:
For example: struct field tag not compatible with reflect.StructTag.Get missing argument for Errorf("%v"): format reads arg 2, have only 1 args range variable pod enclosed by function struct field tag not compatible with reflect.StructTag.Get arg minion for printf verb %s of wrong type: unreachable code unreachable code
Those all look really important
I'm going to fix this unless I hear that someone else is working on this in the next couple minutes.

Discussion:
SelfLink          string    `json:"selfLink,omitempty" yaml:"selfLink,omitempty"` ResourceVersion   uint64    `json:"resourceVersion,omitempty" yaml:"resourceVersion,omitempty"` APIVersion        string    `json:"apiVersion,omitempty" yaml:"apiVersion,omitempty"` <del> Namespace         string    `json:"namespace",omitempty" yaml:"namespace,omitempty"` </del> <ins> Namespace         string    `json:"namespace,omitempty" yaml:"namespace,omitempty"` </ins> UID               string    `json:"uid,omitempty" yaml:"uid,omitempty"` // Annotations are unstructured key value data stored with a resource that may be set by

SelfLink          string    `json:"selfLink,omitempty" yaml:"selfLink,omitempty"` ResourceVersion   uint64    `json:"resourceVersion,omitempty" yaml:"resourceVersion,omitempty"` APIVersion        string    `json:"apiVersion,omitempty" yaml:"apiVersion,omitempty"` <del> Namespace         string    `json:"namespace",omitempty" yaml:"namespace,omitempty"` </del> <ins> Namespace         string    `json:"namespace,omitempty" yaml:"namespace,omitempty"` </ins> // Annotations are unstructured key value data stored with a resource that may be set by // external tooling. They are not queryable and should be preserved when modifying

func expectPrefix(t *testing.T, prefix string, errs errors.ErrorList) { for i := range errs { <del> if !strings.HasPrefix(errs[i].(errors.ValidationError).Field, prefix) { t.Errorf("expected prefix '%s' for %v", errs[i]) </del> <ins> if f, p := errs[i].(errors.ValidationError).Field, prefix; !strings.HasPrefix(f, p) { t.Errorf("expected prefix '%s' for field '%s' (%v)", p, f, errs[i]) </ins> } } }

pods = filterHostPortConflicts(pods) ch := make(chan RunPodResult) <del> for _, pod := range pods { </del> <ins> for i := range pods { pod := pods[i] // Make a copy </ins> go func() { info, err := kl.runPod(pod) ch <- RunPodResult{&pod, info, err}

) // serviceConfig is a deserialized form of the config file format which ConfigSourceFile accepts. <ins> // TODO: this is apparently untested; is it used? </ins> type serviceConfig struct { Services []struct { Name      string   `json: "name"` Port      int      `json: "port"` Endpoints []string `json: "endpoints"` <del> } `json: "service"` </del> <ins> } `json:"service"` </ins> } // ConfigSourceFile periodically reads service configurations in JSON from a file, and sends the services and endpoints defined in the file to the specified channels.

for _, minion := range list.Items { status, err := health.DoHTTPCheck(r.makeMinionURL(minion.ID), r.client) if err != nil { <del> glog.Errorf("%s failed health check with error: %s", minion, err) </del> <ins> glog.Errorf("%#v failed health check with error: %s", minion, err) </ins> continue } if status == health.Healthy {

time.Sleep(rs.podPollPeriod) } } <del> return pod, nil </del> }

return newObj } <ins> // ObjectDiff writes the two objects out as JSON and prints out the identical part of // the objects followed by the remaining part of 'a' and finally the remaining part of 'b'. // For debugging tests. </ins> func ObjectDiff(a, b Object) string { ab, err := json.Marshal(a) if err != nil {

panic(fmt.Sprintf("b: %v", err)) } return util.StringDiff(string(ab), string(bb)) <ins> } </ins> <del> // An alternate diff attempt, in case json isn't showing you // the difference. (reflect.DeepEqual makes a distinction between // nil and empty slices, for example.) </del> <ins> // ObjectGoPrintDiff is like ObjectDiff, but uses go's %#v formatter to print the // objects, in case json isn't showing you the difference. (reflect.DeepEqual makes // a distinction between nil and empty slices, for example, even though nothing else // really does.) func ObjectGoPrintDiff(a, b Object) string { </ins> return util.StringDiff( fmt.Sprintf("%#v", a), fmt.Sprintf("%#v", b),