jiebi/CodeConvo huggingface dataset:
Change:
I have an extension apiserver, and I was trying to upgrading the dependency . In our code, we have a serval resources has its , and we expect the storage version is their . for example, we have a resource in both and group, and they are wired up by method, and expected encoded as to storage. However, this seems broken after upgrade to v1.31, so I did some invertgation by myself, and I find the storage version is changed by here: In old behavior honor , but now don't. storage version semantic of would be honored. there is not easy approach, need to create an extension api server and find out. No response <detailsClient Version: v1.30.1 Kustomize Version: v5.0.4-0.- Server Version: v1.31.0-beta.0.25+-dirty </details<detailsNONE </details<detailsKind Cluster run on Darwin Darwin ReficuldeMacBook- 23.0.0 Darwin Kernel Version 23.0.0: Fri Sep 15 14:41:34 PDT 2023; root:xnu-.1.13~1/RELEASEARM64_T8103 arm64 </details<detailskind </details<details</details<details</details
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig api-machinery
PTAL cc

Discussion:
gvks, _, err := scheme.ObjectKinds(example) if err != nil { return schema.GroupVersion{}, err <del> } else if len(gvks) == 0 { // Probably shouldn't happen if err is non-nil </del> <ins> } var gvk schema.GroupVersionKind for _, item := range gvks { if item.Group != binaryVersionOfResource.Group { continue } gvk = item break } if len(gvk.Kind) == 0 { </ins> return schema.GroupVersion{}, fmt.Errorf("object %T has no GVKs registered in scheme", example) } // VersionsForGroupKind returns versions in priority order <del> versions := scheme.VersionsForGroupKind(schema.GroupKind{Group: gvks[0].Group, Kind: gvks[0].Kind}) </del> <ins> versions := scheme.VersionsForGroupKind(schema.GroupKind{Group: gvk.Group, Kind: gvk.Kind}) </ins> compatibilityVersion := effectiveVersion.MinCompatibilityVersion()

gvk := schema.GroupVersionKind{ Group:   gv.Group, Version: gv.Version, <del> Kind:    gvks[0].Kind, </del> <ins> Kind:    gvk.Kind, </ins> } exampleOfGVK, err := scheme.New(gvk)

var err error if backwardCompatibleInterface, ok := s.ResourceEncodingConfig.(CompatibilityResourceEncodingConfig); ok { <del> codecConfig.StorageVersion, err = backwardCompatibleInterface.BackwardCompatibileStorageEncodingFor(groupResource, example) </del> <ins> codecConfig.StorageVersion, err = backwardCompatibleInterface.BackwardCompatibileStorageEncodingFor(chosenStorageResource, example) </ins> if err != nil { return nil, err }
Change:
The compute project and zone in the prerequisites check are incorrectly calculated: !!! Error in hack/make-rules/test-e2e- Error in hack/make-rules/test-e2e- 'tee -i "${artifacts}/build-"' exited with status 1 0 Call stack: 1: hack/make-rules/test-e2e- main(...) Exiting with status 1 blocked by the following errors in each case: 1- Could not find gcloud compute/zone when running: .... 2- Could not find gcloud project when running: ..... 1- gcloud config unset compute/zone 2- gcloud config unset project 3- make test-e2e-node REMOTE=true LIST_IMAGES=true gcloud --version Google Cloud SDK 453.0.0 alpha 2023.10.27 beta 2023.10.27 bq 2.0.98 core 2023.10.27 gcloud-crc32c 1.0.0 <details</details<details</details<details</details<details</details<details</details<details</details
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig node /assign

Discussion:
# Get the compute zone zone=${ZONE:-"$(gcloud info --format='value(config.properties.compute.zone.value)')"} <ins> zone=${zone// /} </ins> if [[ ${zone} == "" ]]; then echo "Could not find gcloud compute/zone when running: `gcloud info --format='value(config.properties.compute.zone.value)'`" exit 1

# Get the compute project project=$(gcloud info --format='value(config.project)') <ins> project=${project// /} </ins> if [[ ${project} == "" ]]; then echo "Could not find gcloud project when running: `gcloud info --format='value(config.project)'`" exit 1