jiebi/CodeConvo huggingface dataset:
Change:
[x] Test approval issue : [x] Test PR : - Needed an update on the handling of anotations 27 March 2022 [x] Two weeks soak end date : 6 April 2022 [x] Test promotion PR : [x] Update Test PR: 15 April 2022 [x] Two weeks soak end date : 4 May 2022 with start of 1.25 [x] Update Test Promotion: According to these APIsnoop queries, there are still four remaining Job endpoints which are untested. Using a number of existing e2e test practices a new has been created for this job lifecycle test. The e2e logs for this test are listed below. This query shows the endpoints hit within a short period of running the e2e test If a test with these calls gets merged, test coverage will go up by 4 points This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance
/triage accepted
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/reopen for tracking e2e testgrid and promotion PR
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
and delete the job. Job MUST be deleted successfully. release: v1.15 file: test/e2e/apps/job.go <ins> - testname: Jobs, manage lifecycle codename: '[sig-apps] Job should manage the lifecycle of a job [Conformance]' description: Attempt to create a suspended Job which MUST succeed. Attempt to patch the Job to include a new label which MUST succeed. The label MUST be found. Attempt to replace the Job to include a new annotation which MUST succeed. The annotation MUST be found. Attempt to list all namespaces with a label selector which MUST succeed. One list MUST be found. It MUST succeed at deleting a collection of jobs via a label selector. release: v1.25 file: test/e2e/apps/job.go </ins> - testname: Jobs, completion after task failure codename: '[sig-apps] Job should run a job to completion when tasks sometimes fail and are locally restarted [Conformance]'

}) /* <ins> Release: v1.25 Testname: Jobs, manage lifecycle </ins> Description: Attempt to create a suspended Job which MUST succeed. Attempt to patch the Job to include a new label which MUST succeed. The label MUST be found. Attempt to replace the Job to include a

succeed. One list MUST be found. It MUST succeed at deleting a collection of jobs via a label selector. */ <del> ginkgo.It("should manage the lifecycle of a job", func() { </del> <ins> framework.ConformanceIt("should manage the lifecycle of a job", func() { </ins> jobName := "e2e-" + utilrand.String(5) label := map[string]string{"e2e-job-label": jobName} labelSelector := labels.SelectorFromSet(label).String()
Change:
We have a question regarding the eligibility of the following 2 endpoints for conformance; logFileListHandler logFileHandler We found this PR Don’t test the debug /logs endpoint on GKE. that disables testing of /log endpoint for GKE. Is this still valid or should the exclusion of GKE be reconsidered? Does this provider requirement make these 2 log endpoints ineligible for conformance?
/triage accepted /sig architecture /area conformance
confirmed that these endpoints should no be eligible for conformance. They should be considered an operational tool, not related to application consistency across distros.

Discussion:
- endpoint: replaceAutoscalingV2NamespacedHorizontalPodAutoscalerStatus reason: optional feature link: https://github.com/kubernetes/kubernetes/pull/106595#issuecomment-1006015756 <ins> - endpoint: logFileHandler reason: optional feature link: https://github.com/kubernetes/kubernetes/issues/108675 - endpoint: logFileListHandler reason: optional feature link: https://github.com/kubernetes/kubernetes/issues/108675 </ins>
Change:
pull-kubernetes-e2e-kind-ipv6 Pods should delete a collection of pods According to testgrid, March 18th Timeout in No response /sig node
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
Looking at The test is here - It creates 3 pods which go into Failed phase and then expects them to within . Looking at failure in the build-log, there were three pods created, , , . did not get deleted from the API-server within the 1 minute timeout causing the test to fail. From the build-log, the test starts checking for all the pods to be deleted at: So the test expected all the pods to be deleted at 1 minute + 18:35:03 = 18:36:03 Looking at the logs of which landed on : DELETE was sent at landed on DELETE was sent at which is ~20 sec after when the test with the 1 minute timeout expected which caused the test to fail.
I suggest we bump the timeout a bit since everything seems to be working, it's just taking a bit longer than the timeout is currently set to. This also may be affected by recent which slightly increases how long it takes for pod to be marked as terminal by kubelet.

Discussion:
syncLoopFrequency    = 10 * time.Second maxBackOffTolerance  = time.Duration(1.3 * float64(kubelet.MaxContainerBackOff)) podRetryPeriod       = 1 * time.Second <del> podRetryTimeout      = 1 * time.Minute </del> ) // testHostIP tests that a pod gets a host IP

// wait as required for all 3 pods to be running ginkgo.By("waiting for all 3 pods to be running") <del> err := e2epod.WaitForPodsRunningReady(f.ClientSet, f.Namespace.Name, 3, 0, framework.PodStartTimeout, nil) </del> <ins> err := e2epod.WaitForPodsRunningReady(f.ClientSet, f.Namespace.Name, 3, 0, f.Timeouts.PodStart, nil) </ins> framework.ExpectNoError(err, "3 pods not found running.") // delete Collection of pods with a label in the current namespace

// wait for all pods to be deleted ginkgo.By("waiting for all pods to be deleted") <del> err = wait.PollImmediate(podRetryPeriod, podRetryTimeout, checkPodListQuantity(f, "type=Testing", 0)) </del> <ins> err = wait.PollImmediate(podRetryPeriod, f.Timeouts.PodDelete, checkPodListQuantity(f, "type=Testing", 0)) </ins> framework.ExpectNoError(err, "found a pod(s)") })
Change:
Remove the "CSRDuration" feature gate starting in Kube v1.26. PR proposes that the CertificateSigningRequest's Spec.ExpirationSeconds field be promoted to GA in v1.24. It was originally introduced as beta in v1.22 with a corresponding feature gate called "CSRDuration" to optionally disable it (see PR ). If PR is merged and included in v1.24, then in v1.26 the "CSRDuration" feature gate should be removed. See also where a member of SIG-auth asked me to create this issue.
/sig auth
/triage accepted /milestone v1.26
Is this task a ? I would like to be assign to it.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:
/remove-lifecycle stale
I'd like to work on this! /assign
Fixed it here:

Discussion:
// Enables kubelet to detect CSI volume condition and send the event of the abnormal volume to the corresponding pod that is using it. CSIVolumeHealth featuregate.Feature = "CSIVolumeHealth" <del> // owner: @enj // beta: v1.22 // ga: v1.24 // // Allows clients to request a duration for certificates issued via the Kubernetes CSR API. CSRDuration featuregate.Feature = "CSRDuration" </del> // owner: @adrianreber // kep: http://kep.k8s.io/2008 // alpha: v1.25

CSIVolumeHealth: {Default: false, PreRelease: featuregate.Alpha}, <del> CSRDuration: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.26 </del> ContainerCheckpoint: {Default: false, PreRelease: featuregate.Alpha}, ControllerManagerLeaderMigration: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.26
Change:
E2eNode Suite: [sig-node] Security Context when creating a pod in the host PID namespace should show its pid in the host PID namespace [NodeFeature:HostAccess] expand_less since last night. NA /sig auth node
This is failing on a ton of jobs. /kind regression /priority important-soon /milestone v1.24 Triage dump:
/triage accepted

Discussion:
var _ = SIGDescribe("Security Context", func() { f := framework.NewDefaultFramework("security-context-test") <del> f.NamespacePodSecurityEnforceLevel = admissionapi.LevelBaseline </del> <ins> f.NamespacePodSecurityEnforceLevel = admissionapi.LevelPrivileged </ins> var podClient *framework.PodClient ginkgo.BeforeEach(func() { podClient = f.PodClient()
Change:
test withnot FAIL In a macos. do or golang upstrem disscusion. We use time.LoadLocation to validate timezone setting in object spec like cronjob.(It is ok) We also add a test try to validate is not a crroct value. This test is not true sometimes, for example, in default macos this is a true time_zone value.(maybe also true in other case insensitive os, but I have no device to try) At least we should get the test to pass on macos, I hope. <details</details<details</details<details</details<details</details<details</details<details</details
The label(s) cannot be applied, because the repository doesn't have them. <detailsIn response to : /sig test (I guess) Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig testing (I guess)
see
/remove-sig testing /sig apps
I was very surprised to find that this error only occurs on darwin, and does not occur on windows, although windows is also case-sensitive by default. When using , windows finally use (see ), but darwin and linux have more choices (see ) they will first try , using the method, which will call the system's open method to open , because darwin is case-insensitive by default, and this operation will succeed.
/triage accepted

Discussion:
package validation import ( <ins> "runtime" </ins> "strings" "testing"

}, }, }, <del> "spec.timeZone: Invalid value: "AMERICA/new_york": unknown time zone AMERICA/new_york": { ObjectMeta: metav1.ObjectMeta{ Name:      "mycronjob", Namespace: metav1.NamespaceDefault, UID:       types.UID("1a2b3c"), }, Spec: batch.CronJobSpec{ Schedule:          "0 * * * *", TimeZone:          &timeZoneBadCasing, ConcurrencyPolicy: batch.AllowConcurrent, JobTemplate: batch.JobTemplateSpec{ Spec: batch.JobSpec{ Template: validPodTemplateSpec, }, }, }, }, </del> "spec.timeZone: Invalid value: " America/New_York": unknown time zone  America/New_York": { ObjectMeta: metav1.ObjectMeta{ Name:      "mycronjob",

}, }, } <ins> if runtime.GOOS != "darwin" { // Skip this error case on darwin, see https://github.com/golang/go/issues/21512 errorCases["spec.timeZone: Invalid value: "AMERICA/new_york": unknown time zone AMERICA/new_york"] = batch.CronJob{ ObjectMeta: metav1.ObjectMeta{ Name:      "mycronjob", Namespace: metav1.NamespaceDefault, UID:       types.UID("1a2b3c"), }, Spec: batch.CronJobSpec{ Schedule:          "0 * * * *", TimeZone:          &timeZoneBadCasing, ConcurrencyPolicy: batch.AllowConcurrent, JobTemplate: batch.JobTemplateSpec{ Spec: batch.JobSpec{ Template: validPodTemplateSpec, }, }, }, } } </ins> for k, v := range errorCases { errs := ValidateCronJobCreate(&v, corevalidation.PodValidationOptions{})
Change:
/kind failing-test <!-- If this is a flake, please add: /kind flake --/sig node
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
There is no other failures in [x] fixed [ ] will fix this one.
/sig auth /priority important-soon /milestone v1.24
You must be a member of the GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility. <detailsIn response to : /sig auth /priority important-soon /milestone v1.24 Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
ns string ) f := framework.NewDefaultFramework("kubelet") <del> f.NamespacePodSecurityEnforceLevel = admissionapi.LevelBaseline </del> <ins> f.NamespacePodSecurityEnforceLevel = admissionapi.LevelPrivileged </ins> ginkgo.BeforeEach(func() { c = f.ClientSet
Change:
/kind failing-test <!-- If this is a flake, please add: /kind flake --<!-- Please assign a SIG using: /sig SIG-NAME --
The flake started after was merged. /cc I run it locally and it costs about 190s~220s.
/sig api-machinery testing
should fix. Needs approval.
/triage accepted

Discussion:
} return } <del> // test with cost budget exceeded errs, _ = celValidator.Validate(ctx, field.NewPath("root"), &s, tt.obj, tt.oldObj, 0) var found bool for _, err := range errs { if err.Type == field.ErrorTypeInvalid && strings.Contains(err.Error(), "validation failed due to running out of cost budget, no further validation rules will be run") { found = true } } if !found { t.Errorf("expect cost limit exceed err but did not find") } if len(errs) > 1 { t.Errorf("expect to return cost budget exceed err once") } // test with PerCallLimit exceeded found = false celValidator = NewValidator(&s, 0) if celValidator == nil { t.Fatal("expected non nil validator") } errs, _ = celValidator.Validate(ctx, field.NewPath("root"), &s, tt.obj, tt.oldObj, tt.costBudget) for _, err := range errs { if err.Type == field.ErrorTypeInvalid && strings.Contains(err.Error(), "no further validation rules will be run due to call cost exceeds limit for rule") { found = true break } } if !found { t.Errorf("expect PerCostLimit exceed err but did not find") } </del> }) } for rule, expectErrToContain := range tt.errors {

t.Errorf("expected error to contain '%s', but got: %v", expectErrToContain, err) } } <del> // test with cost budget exceeded errs, _ = celValidator.Validate(ctx, field.NewPath("root"), &s, tt.obj, tt.oldObj, 0) var found bool for _, err := range errs { if err.Type == field.ErrorTypeInvalid && strings.Contains(err.Error(), "validation failed due to running out of cost budget, no further validation rules will be run") { found = true } } if !found { t.Errorf("expect cost limit exceed err but did not find") } if len(errs) > 1 { t.Errorf("expect to return cost budget exceed err once") } </del> }) } })
Change:
script result to a nil pointer dereference exception e.g. show the below exception, no exception found when the script got called. a test binary (which are a little behind the master) the spec on the latest master branch, the spec to yaml: No response <details</details<details</detailsN/A <details</details<details</details<details</details<details</details
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
/sig apps /area conformance

Discussion:
testInfo := getTestInfo(spec) if testInfo != nil { testInfos = append(testInfos, testInfo) <del> } if err := validateTestName(testInfo.CodeName); err != nil { log.Fatal(err) </del> <ins> if err := validateTestName(testInfo.CodeName); err != nil { log.Fatal(err) } </ins> } } }
Change:
kubelet won't return error when invalid node labels are passed to flag, and node can't take part in a cluster. kubelet should return errors when invalid node labels are passed. You pass flag to kubelet (value is invalid), node doesn't take part in a cluster. ref. No response <details</details<detailsAWS </details<details</details<details</details<details</details<details</details
/sig node
/triage accepted
this should not be a breaking change as invalid labels make the kubelet unusable anyway. So better not even start the kubelet. /assign since there is a PR already
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:

Discussion:
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/util/sets" <ins> "k8s.io/apimachinery/pkg/util/validation" </ins> utilfeature "k8s.io/apiserver/pkg/util/feature" cliflag "k8s.io/component-base/cli/flag" "k8s.io/component-base/logs"

// ValidateKubeletFlags validates Kubelet's configuration flags and returns an error if they are invalid. func ValidateKubeletFlags(f *KubeletFlags) error { unknownLabels := sets.NewString() <del> for k := range f.NodeLabels { </del> <ins> invalidLabelErrs := make(map[string][]string) for k, v := range f.NodeLabels { </ins> if isKubernetesLabel(k) && !kubeletapis.IsKubeletLabel(k) { unknownLabels.Insert(k) } <ins> if errs := validation.IsQualifiedName(k); len(errs) > 0 { invalidLabelErrs[k] = append(invalidLabelErrs[k], errs...) } if errs := validation.IsValidLabelValue(v); len(errs) > 0 { invalidLabelErrs[v] = append(invalidLabelErrs[v], errs...) } </ins> } if len(unknownLabels) > 0 { return fmt.Errorf("unknown 'kubernetes.io' or 'k8s.io' labels specified with --node-labels: %vn--node-labels in the 'kubernetes.io' namespace must begin with an allowed prefix (%s) or be in the specifically allowed set (%s)", unknownLabels.List(), strings.Join(kubeletapis.KubeletLabelNamespaces(), ", "), strings.Join(kubeletapis.KubeletLabels(), ", ")) } <ins> if len(invalidLabelErrs) > 0 { labelErrs := []string{} for k, v := range invalidLabelErrs { labelErrs = append(labelErrs, fmt.Sprintf("'%s' - %s", k, strings.Join(v, ", "))) } return fmt.Errorf("invalid node labels: %s", strings.Join(labelErrs, "; ")) } </ins> if f.SeccompDefault && !utilfeature.DefaultFeatureGate.Enabled(features.SeccompDefault) { return fmt.Errorf("the SeccompDefault feature gate must be enabled in order to use the --seccomp-default flag")

error:  false, labels: map[string]string{}, }, <ins> { name:  "Invalid label", error: true, labels: map[string]string{ "cloud.google.com/repository": "kubernetes/kubernetes", }, }, </ins> } for _, tt := range tests {
Change:
sig-release-master-blocking gce-cos-master-default Kubernetes e2e suite.[sig-apps] Job should delete pods when suspended not clear No response /sig apps cc
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
cc
cc
/assign
Candidate (I'll run the suite a few times)

Discussion:
ginkgo.It("should delete pods when suspended", func() { ginkgo.By("Creating a job with suspend=false") job := e2ejob.NewTestJob("notTerminate", "suspend-false-to-true", v1.RestartPolicyNever, parallelism, completions, nil, backoffLimit) <del> job.Spec.Suspend = pointer.BoolPtr(false) </del> <ins> job.Spec.Suspend = pointer.Bool(false) </ins> job, err := e2ejob.CreateJob(f.ClientSet, f.Namespace.Name, job) framework.ExpectNoError(err, "failed to create job in namespace: %s", f.Namespace.Name)

framework.ExpectNoError(err, "failed to ensure number of pods associated with job %s is equal to parallelism count in namespace: %s", job.Name, f.Namespace.Name) ginkgo.By("Updating the job with suspend=true") <del> job, err = e2ejob.GetJob(f.ClientSet, f.Namespace.Name, job.Name) framework.ExpectNoError(err, "failed to retrieve latest job object") job.Spec.Suspend = pointer.BoolPtr(true) job, err = e2ejob.UpdateJob(f.ClientSet, f.Namespace.Name, job) </del> <ins> err = wait.PollImmediate(framework.Poll, framework.SingleCallTimeout, func() (bool, error) { job, err = e2ejob.GetJob(f.ClientSet, f.Namespace.Name, job.Name) if err != nil { return false, err } job.Spec.Suspend = pointer.Bool(true) updatedJob, err := e2ejob.UpdateJob(f.ClientSet, f.Namespace.Name, job) if err == nil { job = updatedJob return true, nil } if apierrors.IsConflict(err) { return false, nil } return false, err }) </ins> framework.ExpectNoError(err, "failed to update job in namespace: %s", f.Namespace.Name) ginkgo.By("Ensuring pods are deleted")
Change:
Before switching the modes from to it makes sense to cleanup unnecessary rules. This can be done using the command line option of . Unfortunately, this does not work anymore since was introduced into the table with We see the following error when trying to cleanup the rules after running in mode: Essentially, ipset could not be deleted as it was still referenced by the chain in the table. Cleanup of should not throw any error and completely remove the rules it created. with enabled. (You may add the configuration provided in the "What happened?" section, but it should fail either way.) The issue can be trivially fixed by adding to in . <details</details<detailsn/a </details<details</details<detailsn/a </details<detailsn/a </details<detailsn/a </details
/sig network
it seems we forget to clean these new rules :smile:
/assign /triage accepted
I see, let me know if you need more context/assist!

Discussion:
{utiliptables.TableNAT, KubeNodePortChain}, {utiliptables.TableNAT, KubeLoadBalancerChain}, {utiliptables.TableFilter, KubeForwardChain}, <ins> {utiliptables.TableFilter, KubeNodePortChain}, </ins> } // ipsetInfo is all ipset we needed in ipvs proxier
Change:
Why do we need ?
/sig apps
/remove-sig apps /sig api-machinery /kind support
IsQualifiedName allows lowercase. It seems to be not needed now.
is valid for annotation key but not QualifiedName, right?
/cc /triage accepted
That's what I read too. Should we submit a pull-request to clarify a comment somewhere?
Maybe it's better.
/assign

Discussion:
func ValidateAnnotations(annotations map[string]string, fldPath *field.Path) field.ErrorList { allErrs := field.ErrorList{} for k := range annotations { <ins> // The rule is QualifiedName except that case doesn't matter, so convert to lowercase before checking. </ins> for _, msg := range validation.IsQualifiedName(strings.ToLower(k)) { allErrs = append(allErrs, field.Invalid(fldPath, k, msg)) }