jiebi/CodeConvo huggingface dataset:
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: When I use intree-rbd to expand a pvc from 20Gi to 30Gi, it has been in the Resizing state for a long time. And kube-controller-manager reported this error The most important msg is: I found this err: After I read this part of the code, I realized that the output of command "rbd info" is not a struct. What you expected to happen: Pvc expand successful.
/sig storage
/assign
can you please let me know whats the ceph cluster version being used in your setup ? I am working on the fix.
I totally forgot this...
by any chance you have a nautilus cluster or any plans to migrate? if thats the case I can directly check on nautilus.
I don't have a nautilus cluster,but I think you can check on nautilus. By the way, I have fix this in But I forgot to fix and add some testcase in .
isn't the problem simply the use of in that includes the stderr line of rbd info (which starts with -1) which is not json, the json is only on stdout
How about the following change ?
if the only stderr line being parsed on your cluster is you can work around that by providing the controller-manager an empty
If you have time to make a PR for this bug, please just do it. I'm too busy these days, and my network is so poor that I can't even clone the code. Thanks a lot.

Discussion:
// klog.V(4).Infof("rbd: info %s using mon %s, pool %s id %s key %s", b.Image, mon, b.Pool, id, secret) output, err = b.exec.Command("rbd", <del> "info", b.Image, "--pool", b.Pool, "-m", mon, "--id", id, "--key="+secret, "-k=/dev/null", "--format=json").CombinedOutput() </del> <ins> "info", b.Image, "--pool", b.Pool, "-m", mon, "--id", id, "--key="+secret, "-k=/dev/null", "--format=json").Output() </ins> if err, ok := err.(*exec.Error); ok { if err.Err == exec.ErrNotFound {
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: of Job created by using command will be . This apiVersion is wrong. What you expected to happen: Set the to How to reproduce it (as minimally and precisely as possible): CronJob manifest: <details</detailsApply CronJob and execute command Anything else we need to know?: Environment: Kubernetes version (use ):
/sig cli
This was introduced by . /assign
GitHub didn't allow me to assign the following users: odino. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : This was introduced by . Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
I created fix pull request:

Discussion:
importpath = "k8s.io/kubectl/pkg/cmd/create", visibility = ["//build/visible_to:pkg_kubectl_cmd_create_CONSUMERS"], deps = [ <del> "//staging/src/k8s.io/api/apps/v1:go_default_library", </del> "//staging/src/k8s.io/api/batch/v1:go_default_library", "//staging/src/k8s.io/api/batch/v1beta1:go_default_library", "//staging/src/k8s.io/api/core/v1:go_default_library",

data = ["//staging/src/k8s.io/kubectl/testdata"], embed = [":go_default_library"], deps = [ <del> "//staging/src/k8s.io/api/apps/v1:go_default_library", </del> "//staging/src/k8s.io/api/batch/v1:go_default_library", "//staging/src/k8s.io/api/batch/v1beta1:go_default_library", "//staging/src/k8s.io/api/core/v1:go_default_library",

"github.com/spf13/cobra" <del> appsv1 "k8s.io/api/apps/v1" </del> batchv1 "k8s.io/api/batch/v1" batchv1beta1 "k8s.io/api/batch/v1beta1" corev1 "k8s.io/api/core/v1"

Annotations: annotations, Labels:      cronJob.Spec.JobTemplate.Labels, OwnerReferences: []metav1.OwnerReference{ <del> *metav1.NewControllerRef(cronJob, appsv1.SchemeGroupVersion.WithKind("CronJob")), </del> <ins> *metav1.NewControllerRef(cronJob, cronJob.GroupVersionKind()), </ins> }, }, Spec: cronJob.Spec.JobTemplate.Spec,

"strings" "testing" <del> apps "k8s.io/api/apps/v1" </del> batchv1 "k8s.io/api/batch/v1" batchv1beta1 "k8s.io/api/batch/v1beta1" corev1 "k8s.io/api/core/v1"

ObjectMeta: metav1.ObjectMeta{ Name:            jobName, Annotations:     map[string]string{"cronjob.kubernetes.io/instantiate": "manual"}, <del> OwnerReferences: []metav1.OwnerReference{*metav1.NewControllerRef(cronJob, apps.SchemeGroupVersion.WithKind("CronJob"))}, </del> <ins> OwnerReferences: []metav1.OwnerReference{*metav1.NewControllerRef(cronJob, cronJob.GroupVersionKind())}, </ins> }, Spec: batchv1.JobSpec{ Template: corev1.PodTemplateSpec{
Change:
<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: [sig-scheduling] SchedulerPreemption [Serial] PodTopologySpread Preemption validates proper pods are preempted Which test(s) are flaking: Testgrid link: Reason for failure: It's likely when the preemptor preempts low-priority pods, and gets running, the low-priority pods are still terminating. tries to wait for all low-priority pods to be totally deleted and do the final check. Anything else we need to know: links to appreciated links to specific failures in spyglass appreciated
/sig scheduling /assign

Discussion:
// satisfy the pod topology spread constraints. Hence it needs to preempt another low pod // to make the Pods spread like [<high>, <medium, low>]. runPausePod(f, mediumPodCfg) <del> e2epod.WaitForPodNotPending(cs, ns, mediumPodCfg.Name) </del> ginkgo.By("Verify there are 3 Pods left in this namespace") wantPods := sets.NewString("high", "medium", "low") <del> podList, err := cs.CoreV1().Pods(ns).List(context.TODO(), metav1.ListOptions{}) pods := podList.Items </del> <ins> var pods []v1.Pod // Wait until the number of pods stabilizes. Note that `medium` pod can get scheduled once the // second low priority pod is marked as terminating. // TODO: exact the wait.PollImmediate block to framework.WaitForNumberOfRunningPods. err := wait.PollImmediate(framework.Poll, framework.PollShortTimeout, func() (bool, error) { podList, err := cs.CoreV1().Pods(ns).List(context.TODO(), metav1.ListOptions{}) // ignore intermittent network error if err != nil { return false, nil } pods = podList.Items return len(pods) == 3, nil }) </ins> framework.ExpectNoError(err) <del> framework.ExpectEqual(len(pods), 3) </del> for _, pod := range pods { // Remove the ordinal index for low pod.
Change:
Recently merged PR () broke clusters brought up with only GA APIs+features. See conformance test at /sig node /priority critical-urgent /kind bug /milestone v1.18 /assign

Discussion:
} } <del> err = m.cpuManager.Allocate(pod, &container) if err != nil { return lifecycle.PodAdmitResult{ Message: fmt.Sprintf("Allocate failed due to %v, which is unexpected", err), Reason:  "UnexpectedAdmissionError", Admit:   false, </del> <ins> if m.cpuManager != nil { err = m.cpuManager.Allocate(pod, &container) if err != nil { return lifecycle.PodAdmitResult{ Message: fmt.Sprintf("Allocate failed due to %v, which is unexpected", err), Reason:  "UnexpectedAdmissionError", Admit:   false, } </ins> } } }

} func (i *internalContainerLifecycleImpl) PreStartContainer(pod *v1.Pod, container *v1.Container, containerID string) error { <del> if utilfeature.DefaultFeatureGate.Enabled(kubefeatures.CPUManager) { </del> <ins> if i.cpuManager != nil { </ins> err := i.cpuManager.AddContainer(pod, container, containerID) if err != nil { return err

} func (i *internalContainerLifecycleImpl) PreStopContainer(containerID string) error { <del> if utilfeature.DefaultFeatureGate.Enabled(kubefeatures.CPUManager) { </del> <ins> if i.cpuManager != nil { </ins> return i.cpuManager.RemoveContainer(containerID) } return nil } func (i *internalContainerLifecycleImpl) PostStopContainer(containerID string) error { <del> if utilfeature.DefaultFeatureGate.Enabled(kubefeatures.CPUManager) { </del> <ins> if i.cpuManager != nil { </ins> err := i.cpuManager.RemoveContainer(containerID) if err != nil { return err
Change:
What happened: When parsing an audit webhook config file that errors (ca file does not exist), the apiserver will panic. What you expected to happen: Error gracefully with explanation to the error (ca authority does not exist). How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: we are assigning a null pointer when . We just need to add a standard before. Will follow up with a PR shortly. Environment: Kubernetes version (use ):kube-apiserver --version Kubernetes v1.19.0-alpha.0.597+ /kind bug /area apiserver
/sig api-machinery

Discussion:
func loadWebhook(configFile string, groupVersion schema.GroupVersion, initialBackoff time.Duration, customDial utilnet.DialFunc) (*webhook.GenericWebhook, error) { w, err := webhook.NewGenericWebhook(audit.Scheme, audit.Codecs, configFile, []schema.GroupVersion{groupVersion}, initialBackoff, customDial) <ins> if err != nil { return nil, err } </ins> w.ShouldRetry = retryOnError <del> return w, err </del> <ins> return w, nil </ins> } type backend struct {
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Pods will not start on Windows nodes, even though nodes are ready and pods are scheduled to nodes. Kubelet logs are filled with this: What you expected to happen: How to reproduce it (as minimally and precisely as possible): Build K8s from master, create any pod on Windows node. Anything else we need to know?: I strongly believe this commit is responsible: What happened is that now, with the commit mentioned above, a nil podAdmitHandler is registered, that when called will result in a panic. More specifically here: For Windows, returns : Environment: All K8s built from master. This affects all sig-windows master tests.
/sig windows
/sig node
/reopen Is this resolved? The jobs still failing because of this. ref Can you check?
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
The issue is fixed, you can look here: . I don't know what's happening with gce tests, but all other windows tests ( based on aks ) are working. PS: Maybe I should add aks job to master release informing as well :)
Since this affected the Kubelet starting, I think we can safely close this issue based on just aks test results.
Thanks, /close
Closing this issue. <detailsIn response to : Thanks, /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
Thanks
can you take a look at the Windows GCE test passes? It looks like they are still unhealthy and there are a few issues being tracked by the release team and

Discussion:
nodeConfig NodeConfig } <ins> type noopWindowsResourceAllocator struct{} func (ra *noopWindowsResourceAllocator) Admit(attrs *lifecycle.PodAdmitAttributes) lifecycle.PodAdmitResult { return lifecycle.PodAdmitResult{ Admit: true, } } </ins> func (cm *containerManagerImpl) Start(node *v1.Node, activePods ActivePodsFunc, sourcesReady config.SourcesReady,

} func (cm *containerManagerImpl) GetAllocateResourcesPodAdmitHandler() lifecycle.PodAdmitHandler { <del> return nil </del> <ins> return &noopWindowsResourceAllocator{} </ins> } func (cm *containerManagerImpl) UpdateAllocatedDevices() {
Change:
<!-- Please only use this template for submitting enhancement requests --What would you like to be : Support adding extra metrics for framework plugins Why is this needed: /sig scheduling
/assign

Discussion:
func Register() { // Register the metrics. registerMetrics.Do(func() { <del> for _, metric := range metricsList { legacyregistry.MustRegister(metric) } </del> <ins> RegisterMetrics(metricsList...) </ins> volumeschedulingmetrics.RegisterVolumeSchedulingMetrics() PodScheduleSuccesses = scheduleAttempts.With(metrics.Labels{"result": "scheduled"}) PodScheduleFailures = scheduleAttempts.With(metrics.Labels{"result": "unschedulable"})

}) } <ins> // RegisterMetrics registers a list of metrics. // This function is exported because it is intended to be used by out-of-tree plugins to register their custom metrics. func RegisterMetrics(extraMetrics ...metrics.Registerable) { for _, metric := range extraMetrics { legacyregistry.MustRegister(metric) } } </ins> // GetGather returns the gatherer. It used by test case outside current package. func GetGather() metrics.Gatherer { return legacyregistry.DefaultGatherer
Change:
What happened: When calling the token size for the buffer is the default which is NOT changable. Larger documents (which is likely when using a yaml separator) causes a This was uncovered using kudo... the issue is What you expected to happen: limitation should be documented if they exist size should be calling code managed How to reproduce it (as minimally and precisely as possible): Call with a doc larger than token size Anything else we need to know?: The fixing PR provides more detail if needed. Code concern is: duplicate of which I will now close Environment: Kubernetes version (use ): 1.17 Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:
/sig api-machinery
/cc
OK so the request here is that we call on the scanner to permit larger documents? I think 5MB is a good max size? (Since YAML is more verbose than proto, where the (IIRC) 1.5MB limit is enforced.)
Adding labels-- this is a good one for new contributors.
/assign 0xMH because of open PR
GitHub didn't allow me to assign the following users: 0xMH. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign 0xMH because of open PR Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
/remove-help /remove good first issue

Discussion:
// the caller in framing the chunk. func NewDocumentDecoder(r io.ReadCloser) io.ReadCloser { scanner := bufio.NewScanner(r) <ins> // the size of initial allocation for buffer 4k buf := make([]byte, 4*1024) // the maximum size used to buffer a token 5M scanner.Buffer(buf, 5*1024*1024) </ins> scanner.Split(splitYAMLDocument) return &YAMLDecoder{ r:       r,

} } <ins> func TestBigYAML(t *testing.T) { d := ` stuff: 1 ` maxLen := 5 * 1024 * 1024 bufferLen := 4 * 1024 //  maxLen 5 M dd := strings.Repeat(d, 512*1024) r := NewDocumentDecoder(ioutil.NopCloser(bytes.NewReader([]byte(dd[:maxLen-1])))) b := make([]byte, bufferLen) n, err := r.Read(b) if err != io.ErrShortBuffer { t.Fatalf("expected ErrShortBuffer: %d / %v", n, err) } b = make([]byte, maxLen) n, err = r.Read(b) if err != nil { t.Fatalf("expected nil: %d / %v", n, err) } r = NewDocumentDecoder(ioutil.NopCloser(bytes.NewReader([]byte(dd)))) b = make([]byte, maxLen) n, err = r.Read(b) if err != bufio.ErrTooLong { t.Fatalf("bufio.Scanner: token too long: %d / %v", n, err) } } </ins> func TestYAMLDecoderCallsAfterErrShortBufferRestOfFrame(t *testing.T) { d := `--- stuff: 1
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Controller manager makes many invalid VMSS update calls. What you expected to happen: Controller manager makes correct VMSS update calls. How to reproduce it (as minimally and precisely as possible): Use AKS-Engine to deploy a cluster on Azure. Anything else we need to know?: Environment: Kubernetes version (use ): 16.6 Cloud provider or hardware configuration: Azure OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:
/area provider/azure /sig cloud-provider

Discussion:
return nil, rerr.Error() } <del> for _, scaleSet := range allScaleSets { </del> <ins> for i := range allScaleSets { scaleSet := allScaleSets[i] </ins> if scaleSet.Name == nil || *scaleSet.Name == "" { klog.Warning("failed to get the name of VMSS") continue
Change:
[ ] Promotion created According to this APIsnoop query, there are still some remaining ServiceAccount endpoints which are untested. Create a ServiceAccount with a static label Create a Secret Patch the ServiceAccount with a new Label and a new Secret Get the ServiceAccount to ensure it's patched List all ServiceAccounts in all Namespaces find the ServiceAccount(1) ensure that the ServiceAccount is found and is patched Delete Namespaced ServiceAccount(1) via a Collection with a LabelSelector Delete the Secret Discover useragents: List endpoints hit by the test: Display endpoint coverage change: If a test with these calls gets merged, test coverage will go up by 3 points This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance
Fine with moving forward You don't need to check the status of the secret as part of the test. In other places we check that the resource in question happens, we don't have to follow.
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/retitle Write CoreV1ServiceAccount resource lifecycle test+promote - +3
/close close this Issue in favour of and place in In Progress Issues on org dashboard
Closing this issue. <detailsIn response to : /close close this Issue in favour of and place in In Progress Issues on org dashboard </details

Discussion:
Container. release: v1.9 file: test/e2e/auth/service_accounts.go <ins> - testname: ServiceAccount lifecycle test codename: '[sig-auth] ServiceAccounts should run through the lifecycle of a ServiceAccount [Conformance]' description: Creates a ServiceAccount with a static Label MUST be added as shown in watch event. Patching the ServiceAccount MUST return it's new property. Listing the ServiceAccounts MUST return the test ServiceAccount with it's patched values. ServiceAccount will be deleted and MUST find a deleted watch event. release: v1.19 file: test/e2e/auth/service_accounts.go </ins> - testname: Kubectl, guestbook application codename: '[sig-cli] Kubectl client Guestbook application should create and stop a working application  [Conformance]'

framework.Logf("completed pod") }) <del> ginkgo.It("should run through the lifecycle of a ServiceAccount", func() { </del> <ins> /* Release: v1.19 Testname: ServiceAccount lifecycle test Description: Creates a ServiceAccount with a static Label MUST be added as shown in watch event. Patching the ServiceAccount MUST return it's new property. Listing the ServiceAccounts MUST return the test ServiceAccount with it's patched values. ServiceAccount will be deleted and MUST find a deleted watch event. */ framework.ConformanceIt("should run through the lifecycle of a ServiceAccount", func() { </ins> testNamespaceName := f.Namespace.Name testServiceAccountName := "testserviceaccount" testServiceAccountStaticLabels := map[string]string{"test-serviceaccount-static": "true"}
Change:
What happened: Integration tests import e2e test code today and the dependency makes two drawbacks. It is hard to move test/e2e/framework into staging () Need to run integration tests always even if PRs are just changing e2e test code This PR is for removing this dependency from integration tests. Target dependencies Following files are importing e2e test code from integration tests: [x] () [x] () [x] () and we need to put file for blocking such dependency anymore.
/sig testing /area code-organization
/remove-kind bug
/assign
for /assign

Discussion:
make -C "${KUBE_ROOT}" WHAT=vendor/k8s.io/code-generator/cmd/import-boss <del> packages=("k8s.io/kubernetes/pkg/..." "k8s.io/kubernetes/cmd/..." "k8s.io/kubernetes/plugin/..." "k8s.io/kubernetes/test/e2e/framework/...") </del> <ins> packages=( "k8s.io/kubernetes/pkg/..." "k8s.io/kubernetes/cmd/..." "k8s.io/kubernetes/plugin/..." "k8s.io/kubernetes/test/e2e/framework/..." "k8s.io/kubernetes/test/integration/..." ) </ins> for d in staging/src/k8s.io/*/; do if [ -d "$d" ]; then packages+=("./vendor/${d#"staging/src/"}...")

<ins> { "Rules": [ { "SelectorRegexp": "k8s[.]io/kubernetes/test/e2e", "AllowedPrefixes": [] } ] } </ins>
Change:
<!-- Please only use this template for submitting enhancement requests --What would you like to be : Current constructors: Could we export a new constructor like to inject custom queue. Why is this needed: In my project, i want to create a with a custom queue based on workqueue.Interface but have no way to do that.
/sig api-machinery
thanks for the issue! We've reviewed it in the bug triage, and the consensus was that to ask you to send a PR with this and discuss it there. Would you be able to do it? thanks!
Yes, i will do that.

Discussion:
return NewDelayingQueueWithCustomClock(clock.RealClock{}, "") } <ins> // NewDelayingQueueWithCustomQueue constructs a new workqueue with ability to // inject custom queue Interface instead of the default one func NewDelayingQueueWithCustomQueue(q Interface, name string) DelayingInterface { return newDelayingQueue(clock.RealClock{}, q, name) } </ins> // NewNamedDelayingQueue constructs a new named workqueue with delayed queuing ability func NewNamedDelayingQueue(name string) DelayingInterface { return NewDelayingQueueWithCustomClock(clock.RealClock{}, name)

// NewDelayingQueueWithCustomClock constructs a new named workqueue // with ability to inject real or fake clock for testing purposes func NewDelayingQueueWithCustomClock(clock clock.Clock, name string) DelayingInterface { <ins> return newDelayingQueue(clock, NewNamed(name), name) } func newDelayingQueue(clock clock.Clock, q Interface, name string) *delayingType { </ins> ret := &delayingType{ <del> Interface:       NewNamed(name), </del> <ins> Interface:       q, </ins> clock:           clock, heartbeat:       clock.NewTicker(maxWait), stopCh:          make(chan struct{}),