Change:
The metric is not called in some instances where we initiate routines, like when we call Parallelize We increase the counter every time we create a routine. N/A The metric is called , but it's already under the system. So the final metric has the name: . Maybe we should just call it . Note that we can't just remove a metric. We need to duplicate and mark the old one as deprecated for a release or two. <detailsmaster </details<detailsN/A </detailsNo response No response No response No response
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
please assign to yourself if you are already working on this. Otherwise, I think this is a good fit for a new contributor.
I've worked on it in although I didn't create the new metric for renaming. /sig scheduling /assign I'll add the change to create the new metric (+ deprecate the old one) in as you describe.
/reopen Let me reopen it so that I don't forget to remove old metric. Can we remove metric in the next release? Or should we wait more time?
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
I would wait at least 2 releases, given how old this metric is.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:
/remove-lifecycle stale We can remove the old metric in 1.28
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue as fresh with Close this issue with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:
/remove-lifecycle stale
oh, we can remove the old metric now. Any takers?
thanks !

Discussion:
Help:           "Number of pending pods, by the queue type. 'active' means number of pods in activeQ; 'backoff' means number of pods in backoffQ; 'unschedulable' means number of pods in unschedulablePods that the scheduler attempted to schedule and failed; 'gated' is the number of unschedulable pods that the scheduler never attempted to schedule because they are gated.", StabilityLevel: metrics.STABLE, }, []string{"queue"}) <del> // SchedulerGoroutines isn't called in some parts where goroutines start. // Goroutines metric replaces SchedulerGoroutines metric. Goroutine metric tracks all goroutines. SchedulerGoroutines = metrics.NewGaugeVec( &metrics.GaugeOpts{ Subsystem:         SchedulerSubsystem, DeprecatedVersion: "1.26.0", Name:              "scheduler_goroutines", Help:              "Number of running goroutines split by the work they do such as binding. This metric is replaced by the "goroutines" metric.", StabilityLevel:    metrics.ALPHA, }, []string{"work"}) </del> Goroutines = metrics.NewGaugeVec( &metrics.GaugeOpts{ Subsystem:      SchedulerSubsystem,

FrameworkExtensionPointDuration, PluginExecutionDuration, SchedulerQueueIncomingPods, <del> SchedulerGoroutines, </del> Goroutines, PermitWaitDuration, CacheSize,

bindingCycleCtx, cancel := context.WithCancel(ctx) defer cancel() <del> metrics.SchedulerGoroutines.WithLabelValues(metrics.Binding).Inc() defer metrics.SchedulerGoroutines.WithLabelValues(metrics.Binding).Dec() </del> metrics.Goroutines.WithLabelValues(metrics.Binding).Inc() defer metrics.Goroutines.WithLabelValues(metrics.Binding).Dec()

} wg.Add(1) go func(extIndex int) { <del> metrics.SchedulerGoroutines.WithLabelValues(metrics.PrioritizingExtender).Inc() </del> metrics.Goroutines.WithLabelValues(metrics.PrioritizingExtender).Inc() defer func() { <del> metrics.SchedulerGoroutines.WithLabelValues(metrics.PrioritizingExtender).Dec() </del> metrics.Goroutines.WithLabelValues(metrics.PrioritizingExtender).Dec() wg.Done() }()