Change:
<!-- Please only use this template for submitting enhancement requests --What would you like to be : API priority and fairness metrics have labels such as "priorityLevel" and "flowSchema". These should be "prioritylevel" and "flowschema" respectively. These metrics have been to an exception list: Why is this needed: snake_case is consistent with other metrics. /sig api-machinery /kind cleanup /cc Do we want to do this before 1.20 beta?
yes, lets do that.
/triage accepted Yes, we do not want to go to beta with known wrongness in the metrics.

Discussion:
for i, uc := range uss.clients { uss.integrators[i] = fq.NewIntegrator(uss.clk) fsName := fmt.Sprintf("client%d", i) <del> uss.expectedInqueue = uss.expectedInqueue + fmt.Sprintf(`				apiserver_flowcontrol_current_inqueue_requests{flowSchema=%q,priorityLevel=%q} 0%s`, fsName, uss.name, "n") </del> <ins> uss.expectedInqueue = uss.expectedInqueue + fmt.Sprintf(`				apiserver_flowcontrol_current_inqueue_requests{flow_schema=%q,priority_level=%q} 0%s`, fsName, uss.name, "n") </ins> for j := 0; j < uc.nThreads; j++ { ust := uniformScenarioThread{ uss:    uss,

for i := range uss.clients { fsName := fmt.Sprintf("client%d", i) if atomic.AddInt32(&uss.executions[i], 0) > 0 { <del> uss.expectedExecuting = uss.expectedExecuting + fmt.Sprintf(`				apiserver_flowcontrol_current_executing_requests{flowSchema=%q,priorityLevel=%q} 0%s`, fsName, uss.name, "n") </del> <ins> uss.expectedExecuting = uss.expectedExecuting + fmt.Sprintf(`				apiserver_flowcontrol_current_executing_requests{flow_schema=%q,priority_level=%q} 0%s`, fsName, uss.name, "n") </ins> } if atomic.AddInt32(&uss.rejects[i], 0) > 0 { <del> expectedRejects = expectedRejects + fmt.Sprintf(`				apiserver_flowcontrol_rejected_requests_total{flowSchema=%q,priorityLevel=%q,reason=%q} %d%s`, fsName, uss.name, uss.rejectReason, uss.rejects[i], "n") </del> <ins> expectedRejects = expectedRejects + fmt.Sprintf(`				apiserver_flowcontrol_rejected_requests_total{flow_schema=%q,priority_level=%q,reason=%q} %d%s`, fsName, uss.name, uss.rejectReason, uss.rejects[i], "n") </ins> } } if uss.evalExecutingMetrics && len(uss.expectedExecuting) > 0 {

const ( requestKind   = "request_kind" <del> priorityLevel = "priorityLevel" flowSchema    = "flowSchema" </del> <ins> priorityLevel = "priority_level" flowSchema    = "flow_schema" </ins> phase         = "phase" mark          = "mark" )

var ( apiserverRejectedRequestsTotal = compbasemetrics.NewCounterVec( &compbasemetrics.CounterOpts{ <del> Namespace: namespace, Subsystem: subsystem, Name:      "rejected_requests_total", Help:      "Number of requests rejected by API Priority and Fairness system", </del> <ins> Namespace:      namespace, Subsystem:      subsystem, Name:           "rejected_requests_total", Help:           "Number of requests rejected by API Priority and Fairness system", StabilityLevel: compbasemetrics.ALPHA, </ins> }, []string{priorityLevel, flowSchema, "reason"}, ) apiserverDispatchedRequestsTotal = compbasemetrics.NewCounterVec( &compbasemetrics.CounterOpts{ <del> Namespace: namespace, Subsystem: subsystem, Name:      "dispatched_requests_total", Help:      "Number of requests released by API Priority and Fairness system for service", </del> <ins> Namespace:      namespace, Subsystem:      subsystem, Name:           "dispatched_requests_total", Help:           "Number of requests released by API Priority and Fairness system for service", StabilityLevel: compbasemetrics.ALPHA, </ins> }, []string{priorityLevel, flowSchema}, )

apiserverCurrentInqueueRequests = compbasemetrics.NewGaugeVec( &compbasemetrics.GaugeOpts{ <del> Namespace: namespace, Subsystem: subsystem, Name:      "current_inqueue_requests", Help:      "Number of requests currently pending in queues of the API Priority and Fairness system", </del> <ins> Namespace:      namespace, Subsystem:      subsystem, Name:           "current_inqueue_requests", Help:           "Number of requests currently pending in queues of the API Priority and Fairness system", StabilityLevel: compbasemetrics.ALPHA, </ins> }, []string{priorityLevel, flowSchema}, ) apiserverRequestQueueLength = compbasemetrics.NewHistogramVec( &compbasemetrics.HistogramOpts{ <del> Namespace: namespace, Subsystem: subsystem, Name:      "request_queue_length_after_enqueue", Help:      "Length of queue in the API Priority and Fairness system, as seen by each request after it is enqueued", Buckets:   queueLengthBuckets, </del> <ins> Namespace:      namespace, Subsystem:      subsystem, Name:           "request_queue_length_after_enqueue", Help:           "Length of queue in the API Priority and Fairness system, as seen by each request after it is enqueued", Buckets:        queueLengthBuckets, StabilityLevel: compbasemetrics.ALPHA, </ins> }, []string{priorityLevel, flowSchema}, ) apiserverRequestConcurrencyLimit = compbasemetrics.NewGaugeVec( &compbasemetrics.GaugeOpts{ <del> Namespace: namespace, Subsystem: subsystem, Name:      "request_concurrency_limit", Help:      "Shared concurrency limit in the API Priority and Fairness system", </del> <ins> Namespace:      namespace, Subsystem:      subsystem, Name:           "request_concurrency_limit", Help:           "Shared concurrency limit in the API Priority and Fairness system", StabilityLevel: compbasemetrics.ALPHA, </ins> }, []string{priorityLevel}, ) apiserverCurrentExecutingRequests = compbasemetrics.NewGaugeVec( &compbasemetrics.GaugeOpts{ <del> Namespace: namespace, Subsystem: subsystem, Name:      "current_executing_requests", Help:      "Number of requests currently executing in the API Priority and Fairness system", </del> <ins> Namespace:      namespace, Subsystem:      subsystem, Name:           "current_executing_requests", Help:           "Number of requests currently executing in the API Priority and Fairness system", StabilityLevel: compbasemetrics.ALPHA, </ins> }, []string{priorityLevel, flowSchema}, ) apiserverRequestWaitingSeconds = compbasemetrics.NewHistogramVec( &compbasemetrics.HistogramOpts{ <del> Namespace: namespace, Subsystem: subsystem, Name:      "request_wait_duration_seconds", Help:      "Length of time a request spent waiting in its queue", Buckets:   requestDurationSecondsBuckets, </del> <ins> Namespace:      namespace, Subsystem:      subsystem, Name:           "request_wait_duration_seconds", Help:           "Length of time a request spent waiting in its queue", Buckets:        requestDurationSecondsBuckets, StabilityLevel: compbasemetrics.ALPHA, </ins> }, []string{priorityLevel, flowSchema, "execute"}, ) apiserverRequestExecutionSeconds = compbasemetrics.NewHistogramVec( &compbasemetrics.HistogramOpts{ <del> Namespace: namespace, Subsystem: subsystem, Name:      "request_execution_seconds", Help:      "Duration of request execution in the API Priority and Fairness system", Buckets:   requestDurationSecondsBuckets, </del> <ins> Namespace:      namespace, Subsystem:      subsystem, Name:           "request_execution_seconds", Help:           "Duration of request execution in the API Priority and Fairness system", Buckets:        requestDurationSecondsBuckets, StabilityLevel: compbasemetrics.ALPHA, </ins> }, []string{priorityLevel, flowSchema}, )

// k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/server/egressselector "apiserver_egress_dialer_dial_failure_count", // counter metrics should have "_total" suffix <del> // k8s.io/apiserver/pkg/util/flowcontrol/fairqueuing/queueset "apiserver_flowcontrol_current_inqueue_requests",   // label names should be written in 'snake_case' not 'camelCase', "apiserver_flowcontrol_current_executing_requests", // label names should be written in 'snake_case' not 'camelCase' "apiserver_flowcontrol_rejected_requests_total",    // label names should be written in 'snake_case' not 'camelCase' </del> // k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/server/healthz "apiserver_request_total", // label names should be written in 'snake_case' not 'camelCase'

sharedConcurrencyMetricsName      = "apiserver_flowcontrol_request_concurrency_limit" dispatchedRequestCountMetricsName = "apiserver_flowcontrol_dispatched_requests_total" rejectedRequestCountMetricsName   = "apiserver_flowcontrol_rejected_requests_total" <del> labelPriorityLevel                = "priorityLevel" </del> <ins> labelPriorityLevel                = "priority_level" </ins> timeout                           = time.Second * 10 )