Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: Currently swift object store has a hard-coded name: . E.g., What you expected to happen: Make swift object store parameterizable. E.g., How to reproduce it (as minimally and precisely as possible): This defaults to the hard-coded swift object store. Anything else we need to know?: Here is the patch file to address this issue: Environment: Kubernetes version (use ): Cloud provider or hardware configuration**: OpenStack OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
There are no sig labels on this issue. Please by:<br(1) mentioning a sig: <bre.g., for API Machinery<br(2) specifying the label manually: <bre.g., /sig scalability for sig/scalability<br<brNote: method (1) will trigger a notification to the team. You can find the team list and label list
/sig openstack /sig storage /remove-sig api-machinery
cc
Quick question, if you have the diff already, why not send a PR?
I noticed the contributor documentation is extensive (b/c k8s is such a big project, this is understandable) and I wasn't sure how if I was following the rules. I can send the PR, if you would like. This is no problem. Let me know :-)
I created a PR based on the diff in your issue. Please let me know if you'd like me to abandon it so that you can have credit for the work.
Here you go:
hey can you please reopen this?
I don't think I have enough privileges to reopen. It's probably best to create a new issue and reference this one.
Ah. thanks
/assign
/reopen
Looks like the bot commands worked! ()
/close

Discussion:
SWIFT_SERVER_URL=${SWIFT_SERVER_URL:-} <ins> # The name of the object store container to use SWIFT_OBJECT_STORE=${SWIFT_OBJECT_STORE:-kubernetes} </ins> # Flag indicates if new image must be created. If 'false' then image with IMAGE_ID will be used. # If 'true' then new image will be created from file config-image.sh CREATE_IMAGE=${CREATE_IMAGE:-true} # use "true" for devstack

#   ROOT #   KUBERNETES_RELEASE_TAR function upload-resources() { <del> swift post kubernetes --read-acl '.r:*,.rlistings' </del> <ins> swift post ${SWIFT_OBJECT_STORE} --read-acl '.r:*,.rlistings' </ins> locations=( "${ROOT}/../../_output/release-tars/${KUBERNETES_RELEASE_TAR}"

RELEASE_TAR_PATH=$(dirname ${RELEASE_TAR_LOCATION}) echo "[INFO] Uploading ${KUBERNETES_RELEASE_TAR}" <del> swift upload kubernetes ${RELEASE_TAR_PATH}/${KUBERNETES_RELEASE_TAR}  </del> <ins> swift upload ${SWIFT_OBJECT_STORE} ${RELEASE_TAR_PATH}/${KUBERNETES_RELEASE_TAR}  </ins> --object-name kubernetes-server.tar.gz echo "[INFO] Uploading kubernetes-salt.tar.gz" <del> swift upload kubernetes ${RELEASE_TAR_PATH}/kubernetes-salt.tar.gz  </del> <ins> swift upload ${SWIFT_OBJECT_STORE} ${RELEASE_TAR_PATH}/kubernetes-salt.tar.gz  </ins> --object-name kubernetes-salt.tar.gz }

fi SWIFT_SERVER_URL=$(openstack catalog show object-store --format value | egrep -o "$rgx" | cut -d" " -f2 | head -n 1) fi <del> local swift_repo_url="${SWIFT_SERVER_URL}/kubernetes" </del> <ins> local swift_repo_url="${SWIFT_SERVER_URL}/${SWIFT_OBJECT_STORE}" </ins> if [ $CREATE_IMAGE = true ]; then echo "[INFO] Retrieve new image ID"