Change:
What happened: After fixing golint failures under , we need to put for each and . Then common error checking code has become like: We can replace this code with which is more readable and easy to be understood what the code does. Now we have following e2e test directories which can be replaced: [x] test/e2e/apimachinery () [x] test/e2e/apps () [x] test/e2e/auth () [x] test/e2e/autoscaling () [x] test/e2e/cloud () [x] test/e2e/common () [ ] test/e2e/framework () [x] test/e2e/kubectl () [x] test/e2e/lifecycle () [x] test/e2e/network () [x] test/e2e/node () [x] test/e2e/scalability () [x] test/e2e/scheduling () [x] test/e2e/servicecatalog () [x] test/e2e/storage () [x] test/e2e/upgrades () [x] test/e2e/windows () [x] () [x] () [x] () [x] () [x] () [x] () [x] () [x] () [x] () [x] () [x] () [x] ()
/sig testing
I will work test/e2e/kubectl.
I can work test/e2e/scheduling.
I will work /test/e2e/cloud
I could work on these file
I created and to cleanup gomega in these files, I could take more to work:
I will work for the rest
/reopen Regards, Draven
Reopened this issue. <detailsIn response to : /reopen Draven On Jul 6, 2019, 10:03 AM +0800, Kubernetes Prow Robot , wrote: Closed via . — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread. </details
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
I will work on
I will work
I'll work on the rest
Thanks for raising your hands. All items are fulfilled :-)
/remove-kind bug /kind cleanup

Discussion:
e2enode "k8s.io/kubernetes/test/e2e/framework/node" "github.com/onsi/ginkgo" <del> "github.com/onsi/gomega" </del> ) var _ = SIGDescribe("[Feature:ClusterSizeAutoscalingScaleUp] [Slow] Autoscaling", func() {

// Make sure all nodes are schedulable, otherwise we are in some kind of a problem state. nodes = framework.GetReadySchedulableNodesOrDie(f.ClientSet) schedulableCount := len(nodes.Items) <del> gomega.Expect(schedulableCount).To(gomega.Equal(nodeGroupSize), "not all nodes are schedulable") </del> <ins> framework.ExpectEqual(schedulableCount, nodeGroupSize, "not all nodes are schedulable") </ins> }) ginkgo.AfterEach(func() {

defer framework.DeleteRCAndWaitForGC(f.ClientSet, f.Namespace.Name, podsConfig.Name) // Ensure that no new nodes have been added so far. <del> gomega.Expect(e2enode.TotalReady(f.ClientSet)).To(gomega.Equal(nodeCount)) </del> <ins> readyNodeCount, _ := e2enode.TotalReady(f.ClientSet) framework.ExpectEqual(readyNodeCount, nodeCount) </ins> // Start a number of schedulable pods to ensure CA reacts. additionalNodes := maxNodes - nodeCount

defer disableAutoscaler(extraPoolName, 0, 1) ngNodes := getPoolNodes(f, extraPoolName) <del> gomega.Expect(len(ngNodes)).To(gomega.Equal(extraNodes)) </del> <ins> framework.ExpectEqual(len(ngNodes), extraNodes) </ins> for _, node := range ngNodes { ginkgo.By(fmt.Sprintf("Target node for scale-down: %s", node.Name)) }

if err != nil { klog.Errorf("Error creating priority class: %v", err) } <del> gomega.Expect(err == nil || errors.IsAlreadyExists(err)).To(gomega.Equal(true)) </del> <ins> framework.ExpectEqual(err == nil || errors.IsAlreadyExists(err), true) </ins> } return func() {