Change:
This fails close to 100% of the time when run with race mode: Disabled in It is unclear if the test or the component needs to be corrected /sig api-machinery /priority critical-urgent
/assign /cc
GitHub didn't allow me to assign the following users: answer1991. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
The test is also flaky. but this one is hard to reproduce locally.
I will debug and try to fix it later, thanks for the report.
I doubt data race is caused by golang http/http2 pkg, let me try to make some reproduce cases and may open an issue to golang repo.
data race is caused by golang http/http2 pkg, I have already opened an issue at golang repo. I will continue to debug tomorrow.
another case:
For case, change to be would be a solution: But I would rather figure out why client will set-up the additional TCP connections.
Fix TestGOAWAYConcurrency flaky may need a new golang version after golang/go fixed. TestClientReceivedGOAWAY will be tracked at .
Great find-- can we skip the test for now while we wait for the go fix to land?
Yes, I think so.
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
/lifecycle stale I'm still working on it, a new golang version(1.16 or 1.15.7+) release required
Stale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten
/remove-lifecycle rotten
As clients in k/k repo use to config http2 transports instead of use golang SDK h2_bundle, a new version of (with ) will fix this issue. However, for other clients which use default http2 configuration in golang SDK, golang 1.15.8 or 1.16+ required to avoid HTTP2 un-expected error when received GOAWAY frame.
15.8 should be landed now
yes, I have already post a pr to enable goaway feature test cases:

Discussion:
// TestClientReceivedGOAWAY tests the in-flight watch requests will not be affected and new requests use a new // connection after client received GOAWAY. func TestClientReceivedGOAWAY(t *testing.T) { <del> t.Skip("disabled because of https://github.com/kubernetes/kubernetes/issues/94622") </del> s, err := newTestGOAWAYServer() if err != nil { t.Fatalf("failed to set-up test GOAWAY http server, err: %v", err)

} // TestGOAWAYConcurrency tests GOAWAY frame will not affect concurrency requests in a single http client instance. <del> // Known issues in history: https://github.com/kubernetes/kubernetes/issues/91131. </del> func TestGOAWAYConcurrency(t *testing.T) { <del> t.Skip("disabled because of https://github.com/kubernetes/kubernetes/issues/94532") </del> s, err := newTestGOAWAYServer() if err != nil { t.Fatalf("failed to set-up test GOAWAY http server, err: %v", err)