jiebi/CodeConvo huggingface dataset:
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Default azure file permission is not suitable for most users, dozens of users complain about this, set as is the best choice here, if users don't want , then they could use mountOptions to override and . What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.12 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /sig azure /assign

Discussion:
dirMode         = "dir_mode" gid             = "gid" vers            = "vers" <del> defaultFileMode = "0755" defaultDirMode  = "0755" </del> <ins> defaultFileMode = "0777" defaultDirMode  = "0777" </ins> defaultVers     = "3.0" )
Change:
Hyperkube supports a number of short aliases for commands, such as , , , , etc, rather than the longer , , , etc. There are comments indicating this is "unfortunate" and we still currently create these aliases in the hyperkube docker image: It'd be nice to simplify this, assuming we can find all uses of the short aliases and remove them. /kind cleanup Not sure which sig should own this, so tagging a few. /sig architecture cluster-lifecycle cli cc
interestingly, the command doesn't create the short aliases, though we also don't really use anywhere either.
I think we can just go ahead and start the deprecation cycle for this. WDYT? cc
cc as well
+1 to nuke it
/assign :wink: ok?
SGTM
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
Stale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten
/remove-lifecycle rotten
/help
This request has been marked as needing help from a contributor. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /help Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
I would like to work on it!
It seems like this issue was already solved in ?
I don't think the hyperkube code was changed in that PR, only the image?
Yes, thanks for your comment, can i try to fix it ?
I made a PR here: . Review/feedback/suggestions appreciated! :)
/assign /unassign
GitHub didn't allow me to assign the following users: Rand01ph. Note that only and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign /unassign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/remove-sig architecture cli /sig release Does anyone even still use hyperkube? Wouldn't they use kubeadm or k3s instead?
AFAIK, SAP (the company) still use hyperkube.
aks-engine deployer ( ) still uses hyperkube
Since this ticket is completed now. Can this todo be removed?
we are removing the whole thing :)

Discussion:
} cmd.Flags().BoolVar(&makeSymlinksFlag, "make-symlinks", makeSymlinksFlag, "create a symlink for each server in current directory") cmd.Flags().MarkHidden("make-symlinks") // hide this flag from appearing in servers' usage output <ins> cmd.Flags().MarkDeprecated("make-symlinks", "This feature will be removed in a later release.") </ins> for i := range commandFns { cmd.AddCommand(commandFns[i]())
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: The section for my was stripped, but left for all other resource types What you expected to happen: should put my changes into the cluster as requested How to reproduce it (as minimally and precisely as possible): Here are the resources (Note you will need to change the ownerReference UID and name to some object that exists in your cluster) Observe applying misses out the for the : Observe doing this again updates it correctly: Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: minikube
Reiterating the mentions to trigger a notification: <detailsIn response to : Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
Turns out, shutting down stops this from happening. After creating the object, it has the right ownerReference. On starting , it immediately removed the
/assign
fixed in
That was impressively fast! Thanks for the fix :)
cc

Discussion:
// Create a usage object that is based on the quota resource version that will handle updates // by default, we preserve the past usage observation, and set hard to the current spec <del> usage := v1.ResourceQuota{ ObjectMeta: metav1.ObjectMeta{ Name:            resourceQuota.Name, Namespace:       resourceQuota.Namespace, ResourceVersion: resourceQuota.ResourceVersion, Labels:          resourceQuota.Labels, Annotations:     resourceQuota.Annotations}, Status: v1.ResourceQuotaStatus{ Hard: hardLimits, Used: used, }, </del> <ins> usage := resourceQuota.DeepCopy() usage.Status = v1.ResourceQuotaStatus{ Hard: hardLimits, Used: used, </ins> } dirty = dirty || !quota.Equals(usage.Status.Used, resourceQuota.Status.Used) // there was a change observed by this controller that requires we update quota if dirty { <del> _, err = rq.rqClient.ResourceQuotas(usage.Namespace).UpdateStatus(&usage) </del> <ins> _, err = rq.rqClient.ResourceQuotas(usage.Namespace).UpdateStatus(usage) </ins> return err } return nil
Change:
Testgrid; https://k8s- Sample Failure: The problem seems to be that Kube-anywhere isn't working since commit /sig cluster-lifecycle /kind failing-test /priority important-soon cc:
/milestone v1.13
sent possible fix PR:
sent new PR might get merged once github is back on track.
Reopening, because the test isn't passing yet. /reopen
Reopening this issue. <detailsIn response to : Reopening, because the test isn't passing yet. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
true, i was almost sure that the solution in that last PR won't be sufficient... will investigate more tomorrow.
/assign
I see https://k8s- job failing as well. Will the 2 open PRs address this failure as well?
all the kubeadm-gce-x tests are broken at the moment due to the e2e refactor. we will hopefully decide on how to approach the issue today.
latest efforts:
the tests are working on the cluster up/down side, except that they fail when dumping the node logs. looking into it.
should be green by tomorrow.
Looks good, thanks! One flake in the last run - let's keep an eye on it but it should be fine. /cc /close
Closing this issue. <detailsIn response to : Looks good, thanks! One flake in the last run - let's keep an eye on it but it should be fine. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
echo "waiting for $1 at $2:$3" results=($(ssh-to-node "${test_node}" " set -e; <del> sudo docker pull busybox >/dev/null; sudo docker run busybox sh -c ' </del> <ins> sudo docker pull gcr.io/google_containers/busybox >/dev/null; sudo docker run gcr.io/google_containers/busybox sh -c ' </ins> for i in $(seq -s' ' 1 $(($4*3))); do if wget -q -T 3 -O - http://$2:$3; then echo

Containers: []api.Container{ { Name:    "scrub-checker", <del> Image:   "busybox", </del> <ins> Image:   "gcr.io/google_containers/busybox", </ins> Command: []string{"/bin/sh"}, Args:    []string{"-c", "test ! -e /mnt/index.html || exit 1"}, VolumeMounts: []api.VolumeMount{

Containers: []api.Container{ { Name:    "tester", <del> Image:   "busybox", </del> <ins> Image:   "gcr.io/google_containers/busybox", </ins> Command: []string{"sleep", "600"}, Lifecycle: &api.Lifecycle{ PreStop: &api.Handler{
Change:
What happened: When building kubernetes from source for 1.10 it was possible to limit the parallel linker calls using GOFLAGS="-p 1". (I understand that the new format is GOFLAGS="-p=1" so I am using that) With kubernetes 1.11 the build aborts: What you expected to happen: The build should complete, using just one process for linking. How to reproduce it (as minimally and precisely as possible): export GOFLAGS="-p=1" make -j1 Anything else we need to know?: The environment is quite memory constrained, therefore preventing the build to fork a linker for each CPU is required. Any other option instead of the GOFLAGS would work as well. Environment: Kubernetes version (use ): 12.0 OS (e.g. from /etc/os-release): Arch Linux ARM Others: go version go1.11.1 linux/arm64
Reiterating the mentions to trigger a notification: <detailsIn response to : Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig testing
This is because a change in go 1.11, see , and related go issues: , etc. I've opened a PR to address this: .
/assign

Discussion:
local host_platform host_platform=$(kube::golang::host_platform) <del> # Use eval to preserve embedded quoted strings. </del> local goflags goldflags goasmflags gogcflags <del> eval "goflags=(${GOFLAGS:-})" </del> goldflags="${GOLDFLAGS:-} -s -w $(kube::version::ldflags)" goasmflags="-trimpath=${KUBE_ROOT}" gogcflags="${GOGCFLAGS:-} -trimpath=${KUBE_ROOT}"

shift $((OPTIND - 1)) # Use eval to preserve embedded quoted strings. <del> eval "goflags=(${GOFLAGS:-})" </del> eval "testargs=(${KUBE_TEST_ARGS:-})" # Used to filter verbose test output.

# See https://github.com/golang/go/issues/16086 for details. go install ./cmd/... <del> # Use eval to preserve embedded quoted strings. eval "goflags=(${GOFLAGS:-})" </del> # Filter out arguments that start with "-" and move them to goflags. targets=() for arg; do
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: When the Kubelet plugin watcher invokes method, right now the CSI code does nothing (method is not implemented). What you expected to happen: When the Kubelet plugin watcher no longer detects the socket file for a given driver, it invokes the method on the CSI registration handler, the CSI code should then clean up plugin information and remove the corresponding CSIDriver object. How to reproduce it (as minimally and precisely as possible): Delete the socket file of a CSI plugin exposed for registration, nothing happens. /sig storage
/assign

Discussion:
driverNodeID, maxVolumePerNode, accessibleTopology, err := csi.NodeGetInfo(ctx) if err != nil { <del> unregisterDriver(pluginName) return fmt.Errorf("error during CSI NodeGetInfo() call: %v", err) </del> <ins> glog.Error(log("registrationHandler.RegisterPlugin failed at CSI.NodeGetInfo: %v", err)) if unregErr := unregisterDriver(pluginName); unregErr != nil { glog.Error(log("registrationHandler.RegisterPlugin failed to unregister plugin due to previous: %v", unregErr)) return unregErr } return err </ins> } err = nim.AddNodeInfo(pluginName, driverNodeID, maxVolumePerNode, accessibleTopology) if err != nil { <del> unregisterDriver(pluginName) return fmt.Errorf("error updating CSI node info in the cluster: %v", err) </del> <ins> glog.Error(log("registrationHandler.RegisterPlugin failed at AddNodeInfo: %v", err)) if unregErr := unregisterDriver(pluginName); unregErr != nil { glog.Error(log("registrationHandler.RegisterPlugin failed to unregister plugin due to previous error: %v", unregErr)) return unregErr } return err </ins> } return nil } <del> // DeRegisterPlugin is called when a plugin removed it's socket, signaling </del> <ins> // DeRegisterPlugin is called when a plugin removed its socket, signaling </ins> // it is no longer available <del> // TODO: Handle DeRegistration </del> func (h *RegistrationHandler) DeRegisterPlugin(pluginName string) { <ins> glog.V(4).Info(log("registrationHandler.DeRegisterPlugin request for plugin %s", pluginName)) if err := unregisterDriver(pluginName); err != nil { glog.Error(log("registrationHandler.DeRegisterPlugin failed: %v", err)) } </ins> } func (p *csiPlugin) Init(host volume.VolumeHost) error {

return attachment.Status.AttachmentMetadata, nil } <del> func unregisterDriver(driverName string) { </del> <ins> func unregisterDriver(driverName string) error { </ins> func() { csiDrivers.Lock() defer csiDrivers.Unlock()

if err := nim.RemoveNodeInfo(driverName); err != nil { glog.Errorf("Error unregistering CSI driver: %v", err) <ins> return err </ins> } <ins> return nil </ins> }
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . If the matter is security related, please disclose it privately via --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: When creating a Kubernetes 1.12.1 cluster in Azure with Availability Set backed masters and VMSS backed agents, the cloud-controller-manager is unable to parse the ProviderID returned by the Azure SDK. What you expected to happen: The providerID should be split and the cloud-controller-manager should be able to find a kubelet node IP from the cloud provider How to reproduce it (as minimally and precisely as possible): Stand up a master node in Azure within an availability set with the kubelet configured with Run the configured for Azure Anything else we need to know?: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: Azure OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/sig azure
When switching over to vmType the following was encountered;
The fix in resolved the issue that was seen in this issue, closing

Discussion:
"github.com/Azure/azure-sdk-for-go/services/network/mgmt/2017-09-01/network" "github.com/Azure/go-autorest/autorest" "github.com/golang/glog" "k8s.io/apimachinery/pkg/types" cloudprovider "k8s.io/cloud-provider" )

// IsNodeUnmanagedByProviderID returns true if the node is not managed by Azure cloud provider. // All managed node's providerIDs are in format 'azure:///subscriptions/<id>/resourceGroups/<rg>/providers/Microsoft.Compute/.*' func (az *Cloud) IsNodeUnmanagedByProviderID(providerID string) bool { <del> return azureNodeProviderIDRE.Match([]byte(providerID)) </del> <ins> return !azureNodeProviderIDRE.Match([]byte(providerID)) </ins> }

assert.Equal(t, test.expected, real, test.name) } } <ins> func TestIsNodeUnmanagedByProviderID(t *testing.T) { tests := []struct { providerID string expected   bool name       string }{ { providerID: CloudProviderName + ":///subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroupName/providers/Microsoft.Compute/virtualMachines/k8s-agent-AAAAAAAA-0", expected:   false, }, { providerID: CloudProviderName + "://", expected:   true, }, { providerID: ":///subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroupName/providers/Microsoft.Compute/virtualMachines/k8s-agent-AAAAAAAA-0", expected:   true, }, { providerID: "aws:///subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/myResourceGroupName/providers/Microsoft.Compute/virtualMachines/k8s-agent-AAAAAAAA-0", expected:   true, }, { providerID: "k8s-agent-AAAAAAAA-0", expected:   true, }, } az := getTestCloud() for _, test := range tests { isUnmanagedNode := az.IsNodeUnmanagedByProviderID(test.providerID) assert.Equal(t, test.expected, isUnmanagedNode, test.providerID) } } </ins>
Change:
/kind bug What happened: The test image pets/zookeeper-installer references an old alpha version of zookeeper: This can't be built anymore, as it no longer exists on the server: Sure enough, now lists beta versions for 3.5.x, as well as stable 3.4.x versions, but no 3.5.0 alphas. We probably should update this to a newer version, or alternately delete the test and image if it's no longer providing signal. How to reproduce it (as minimally and precisely as possible): /sig apps

Discussion:
COPY peer-finder / # See README.md <del> RUN wget -q -O /zookeeper-3.5.0-alpha.tar.gz http://apache.mirrors.pair.com/zookeeper/zookeeper-3.5.0-alpha/zookeeper-3.5.0-alpha.tar.gz &&  </del> <ins> RUN wget -q -O /zookeeper-3.5.0-alpha.tar.gz http://archive.apache.org/dist/zookeeper/zookeeper-3.5.0-alpha/zookeeper-3.5.0-alpha.tar.gz &&  </ins> tar -xzf /zookeeper-3.5.0-alpha.tar.gz -C /tmp/ && mv /tmp/zookeeper-3.5.0-alpha /zookeeper && rm /zookeeper-3.5.0-alpha.tar.gz ADD install.sh /
Change:
<!-- Please only use this template for submitting enhancement requests --What would you like to be : display EphemeralStorage usage with 'kubectl describe node' , like; Why is this needed: ephemeral-storage is a standard ContainerResources like CPU and Mem now. but now we don't display it in the node state. <!-- DO NOT EDIT BELOW THIS LINE --/kind feature /sig cli cc

Discussion:
w.Write(LEVEL_1, "ResourcetRequeststLimitsn") w.Write(LEVEL_1, "--------t--------t------n") reqs, limits := getPodsTotalRequestsAndLimits(nodeNonTerminatedPodsList) <del> cpuReqs, cpuLimits, memoryReqs, memoryLimits := reqs[api.ResourceCPU], limits[api.ResourceCPU], reqs[api.ResourceMemory], limits[api.ResourceMemory] </del> <ins> cpuReqs, cpuLimits, memoryReqs, memoryLimits, ephemeralstorageReqs, ephemeralstorageLimits := reqs[api.ResourceCPU], limits[api.ResourceCPU], reqs[api.ResourceMemory], limits[api.ResourceMemory], reqs[api.ResourceEphemeralStorage], limits[api.ResourceEphemeralStorage] </ins> fractionCpuReqs := float64(0) fractionCpuLimits := float64(0) if allocatable.Cpu().MilliValue() != 0 {

fractionMemoryReqs = float64(memoryReqs.Value()) / float64(allocatable.Memory().Value()) * 100 fractionMemoryLimits = float64(memoryLimits.Value()) / float64(allocatable.Memory().Value()) * 100 } <ins> fractionEphemeralStorageReqs := float64(0) fractionEphemeralStorageLimits := float64(0) if allocatable.StorageEphemeral().Value() != 0 { fractionEphemeralStorageReqs = float64(ephemeralstorageReqs.Value()) / float64(allocatable.StorageEphemeral().Value()) * 100 fractionEphemeralStorageLimits = float64(ephemeralstorageLimits.Value()) / float64(allocatable.StorageEphemeral().Value()) * 100 } </ins> w.Write(LEVEL_1, "%st%s (%d%%)t%s (%d%%)n", api.ResourceCPU, cpuReqs.String(), int64(fractionCpuReqs), cpuLimits.String(), int64(fractionCpuLimits)) w.Write(LEVEL_1, "%st%s (%d%%)t%s (%d%%)n", api.ResourceMemory, memoryReqs.String(), int64(fractionMemoryReqs), memoryLimits.String(), int64(fractionMemoryLimits)) <ins> w.Write(LEVEL_1, "%st%s (%d%%)t%s (%d%%)n", api.ResourceEphemeralStorage, ephemeralstorageReqs.String(), int64(fractionEphemeralStorageReqs), ephemeralstorageLimits.String(), int64(fractionEphemeralStorageLimits)) </ins> extResources := make([]string, 0, len(allocatable)) for resource := range allocatable { if !helper.IsStandardContainerResourceName(string(resource)) && resource != api.ResourcePods {
Change:
is failing with "framework.RestartControllerManager() = unsupported provider: gke; want nil" /kind failing-test
/sig network
Introduced in , should be fixed by

Discussion:
func RestartKubeProxy(host string) error { // TODO: Make it work for all providers. if !ProviderIs("gce", "gke", "aws") { <del> return fmt.Errorf("unsupported provider: %s", TestContext.Provider) </del> <ins> return fmt.Errorf("unsupported provider for RestartKubeProxy: %s", TestContext.Provider) </ins> } // kubelet will restart the kube-proxy since it's running in a static pod Logf("Killing kube-proxy on node %v", host)

// TODO: Make it work for all providers and distros. supportedProviders := []string{"gce", "aws", "vsphere"} if !ProviderIs(supportedProviders...) { <del> return fmt.Errorf("unsupported provider: %s, supported providers are: %v", TestContext.Provider, supportedProviders) </del> <ins> return fmt.Errorf("unsupported provider for RestartKubelet: %s, supported providers are: %v", TestContext.Provider, supportedProviders) </ins> } if ProviderIs("gce") && !NodeOSDistroIs("debian", "gci") { return fmt.Errorf("unsupported node OS distro: %s", TestContext.NodeOSDistro)

func RestartApiserver(cs clientset.Interface) error { // TODO: Make it work for all providers. if !ProviderIs("gce", "gke", "aws") { <del> return fmt.Errorf("unsupported provider: %s", TestContext.Provider) </del> <ins> return fmt.Errorf("unsupported provider for RestartApiserver: %s", TestContext.Provider) </ins> } if ProviderIs("gce", "aws") { initialRestartCount, err := getApiserverRestartCount(cs)

func sshRestartMaster() error { if !ProviderIs("gce", "aws") { <del> return fmt.Errorf("unsupported provider: %s", TestContext.Provider) </del> <ins> return fmt.Errorf("unsupported provider for sshRestartMaster: %s", TestContext.Provider) </ins> } var command string if ProviderIs("gce") {

func RestartControllerManager() error { // TODO: Make it work for all providers and distros. if !ProviderIs("gce", "aws") { <del> return fmt.Errorf("unsupported provider: %s", TestContext.Provider) </del> <ins> return fmt.Errorf("unsupported provider for RestartControllerManager: %s", TestContext.Provider) </ins> } if ProviderIs("gce") && !MasterOSDistroIs("gci") { return fmt.Errorf("unsupported master OS distro: %s", TestContext.MasterOSDistro)
Change:
is failing with "framework.RestartControllerManager() = unsupported provider: gke; want nil" /kind failing-test
/sig network
Introduced in , should be fixed by

Discussion:
// to be something else, see if the interval will be reconciled. It("should reconcile LB health check interval [Slow][Serial]", func() { const gceHcCheckIntervalSeconds = int64(8) <del> // This test is for clusters on GCE/GKE. framework.SkipUnlessProviderIs("gce", "gke") </del> <ins> // This test is for clusters on GCE. // (It restarts kube-controller-manager, which we don't support on GKE) framework.SkipUnlessProviderIs("gce") </ins> clusterID, err := gce.GetClusterID(cs) if err != nil { framework.Failf("framework.GetClusterID(cs) = _, %v; want nil", err)