jiebi/CodeConvo huggingface dataset:
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: Error message at is "unable to decode CoreDNS configmap %v", err" What you expected to happen: IMHO Error message should be "unable to decode CoreDNS serviceaccount %v", err" in same file and line number as We are decoding serviceaccount for CoreDNS and not configMap. configMap is already done in line 176 in same file. How to reproduce it (as minimally and precisely as possible): Check Anything else we need to know?: I just found it while working on some other PR. I didn't install kubernetes/kubeadm. Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Ubuntu 16.04.3 LTS (Xenial Xerus) Kernel (e.g. ): Linux ubuntu 4.10.0-42-generic ~16.04.1-Ubuntu SMP Mon Dec 4 15:57:59 UTC 2017 x8664 x8664 x86_64 GNU/Linux Install tools: Others:
There are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the and . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals
/area kubeadm

Discussion:
coreDNSServiceAccount := &v1.ServiceAccount{} if err := kuberuntime.DecodeInto(legacyscheme.Codecs.UniversalDecoder(), []byte(CoreDNSServiceAccount), coreDNSServiceAccount); err != nil { <del> return fmt.Errorf("unable to decode CoreDNS configmap %v", err) </del> <ins> return fmt.Errorf("unable to decode CoreDNS serviceaccount %v", err) </ins> } // Create the ConfigMap for CoreDNS or update it in case it already exists
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: Failures - https://k8s- Part of pause is not used properly for tests for other arches than x86. As the current pause image is not a manifest image, so we need to use a different image for different archs like for , for etc.. With this, I'm using logs-generator from repo What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/sig testing
/assign

Discussion:
JessieDnsutils           = ImageConfig{e2eRegistry, "jessie-dnsutils", "1.0", true} Kitten                   = ImageConfig{e2eRegistry, "kitten", "1.0", true} Liveness                 = ImageConfig{e2eRegistry, "liveness", "1.0", true} <del> LogsGenerator            = ImageConfig{gcRegistry, "logs-generator", "v0.1.0", false} </del> <ins> LogsGenerator            = ImageConfig{e2eRegistry, "logs-generator", "1.0", true} </ins> Mounttest                = ImageConfig{e2eRegistry, "mounttest", "1.0", true} MounttestUser            = ImageConfig{e2eRegistry, "mounttest-user", "1.0", true} Nautilus                 = ImageConfig{e2eRegistry, "nautilus", "1.0", true}

NoSnatTestProxy          = ImageConfig{e2eRegistry, "no-snat-test-proxy", "1.0", true} NWayHTTP                 = ImageConfig{e2eRegistry, "n-way-http", "1.0", true} // When these values are updated, also update cmd/kubelet/app/options/options.go <del> Pause               = ImageConfig{gcRegistry, "pause", "3.0", false} </del> <ins> Pause               = ImageConfig{gcRegistry, "pause", "3.0", true} </ins> Porter              = ImageConfig{e2eRegistry, "porter", "1.0", true} PortForwardTester   = ImageConfig{e2eRegistry, "port-forward-tester", "1.0", true} Redis               = ImageConfig{e2eRegistry, "redis", "1.0", true}
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: I pull the latest code, and run with below cmd. But the cluster is not up. And I notice the kube-, What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): GitCommit:"" Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/sig cluster-lifecycle
/assign
Can you please try the fix above?
/assign
/unassign
your pr does not fix it yet? If not, I can help.
The fix from works for me! o/
ok, thanks
reopen , make less modifications.
sorry, i miss hyper...

Discussion:
"//pkg/client/metrics/prometheus:go_default_library", "//pkg/version/prometheus:go_default_library", "//plugin/cmd/kube-scheduler/app:go_default_library", <ins> "//vendor/k8s.io/apiserver/pkg/util/flag:go_default_library", </ins> "//vendor/k8s.io/apiserver/pkg/util/logs:go_default_library", ], )

"//vendor/k8s.io/apimachinery/pkg/util/wait:go_default_library", "//vendor/k8s.io/apiserver/pkg/server/healthz:go_default_library", "//vendor/k8s.io/apiserver/pkg/util/feature:go_default_library", <del> "//vendor/k8s.io/apiserver/pkg/util/flag:go_default_library", </del> "//vendor/k8s.io/client-go/informers:go_default_library", "//vendor/k8s.io/client-go/informers/core/v1:go_default_library", "//vendor/k8s.io/client-go/informers/storage/v1:go_default_library",

"k8s.io/kubernetes/plugin/pkg/scheduler/factory" "github.com/golang/glog" <ins> "github.com/prometheus/client_golang/prometheus" </ins> "github.com/spf13/cobra" "github.com/spf13/pflag" <del> utilflag "k8s.io/apiserver/pkg/util/flag" "github.com/prometheus/client_golang/prometheus" </del> ) // SchedulerServer has all the context and params needed to run a Scheduler

} opts.AddFlags(pflag.CommandLine) <del> utilflag.InitFlags() </del> cmd.MarkFlagFilename("config", "yaml", "yml", "json")

import ( "os" <ins> utilflag "k8s.io/apiserver/pkg/util/flag" </ins> "k8s.io/apiserver/pkg/util/logs" _ "k8s.io/kubernetes/pkg/client/metrics/prometheus" // for client metric registration _ "k8s.io/kubernetes/pkg/version/prometheus"        // for version metric registration

func main() { command := app.NewSchedulerCommand() <ins> utilflag.InitFlags() </ins> logs.InitLogs() defer logs.FlushLogs()
Change:
/kind bug What happened: Testing is not working on master (commit ) on Mac running High Sierra and Go 1.9.2. Nil pointer dererefence in TestCadvisorListPodStats: What you expected to happen: Tests to pass. Compilation is all good. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): MacOSX 10.13.2 Kernel (e.g. ): Install tools: Others:
/sig testing
/assign

Discussion:
assert.EqualValues(t, testTime(creationTime, seedPod0Infra).Unix(), ps.StartTime.Time.Unix()) checkNetworkStats(t, "Pod0", seedPod0Infra, ps.Network) checkEphemeralStats(t, "Pod0", []int{seedPod0Container0, seedPod0Container1}, []int{seedEphemeralVolume1, seedEphemeralVolume2}, ps.EphemeralStorage) <del> checkCPUStats(t, "Pod0", seedPod0Infra, ps.CPU) checkMemoryStats(t, "Pod0", seedPod0Infra, infos["/pod0-i"], ps.Memory) </del> <ins> if ps.CPU != nil { checkCPUStats(t, "Pod0", seedPod0Infra, ps.CPU) } if ps.Memory != nil { checkMemoryStats(t, "Pod0", seedPod0Infra, infos["/pod0-i"], ps.Memory) } </ins> // Validate Pod1 Results ps, found = indexPods[prf1]
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: Failing since 12/17 https://k8s- /assign
Looks like the error message changed.
I managed to get e2e test running on my multi node cluster, and it looks ok to me. All tests are passing, here is the log I see: [sig-storage] PersistentVolumes-local [Feature:LocalPersistentVolumes] [Serial] [Volume type: tmpfs] when pod's node is different from PV's NodeName should not be able to mount due to different NodeName [BeforeEach] [sig-storage] PersistentVolumes-local [Feature:LocalPersistentVolumes] [Serial] STEP: Creating a kubernetes client Dec 29 13:55:55.865: INFO: kubeConfig: STEP: Building a namespace api object STEP: Waiting for a default service account to be provisioned in namespace [BeforeEach] [sig-storage] PersistentVolumes-local [Feature:LocalPersistentVolumes] [Serial] [BeforeEach] [Volume type: tmpfs] [BeforeEach] when pod's node is different from PV's NodeName [It] should not be able to mount due to different NodeName ResourceVersion: FieldPath:} Reason:FailedMount Message:Storage node affinity check failed for volume "local-pv8v7k7" : NodeSelectorTerm [{ Operator:In Values:[cluster-02-]}] does not match node labels Source:{Component:kubelet Host:cluster-02-} Maybe the issue you see is gce specific? Could you please add this for loop after this line? for _,e := range events.Items { fmt.Printf("<<<<%+vn", e) } And send me logs I would like to compare with logs I see on my cluster.
are you working off of the latest k8s code? There was a change that went in mid-Dec that changed a bunch of volume error messages
yep on the latest master

Discussion:
reason:  "FailedMount", pattern: make([]string, 2)} ep.pattern = append(ep.pattern, "NodeSelectorTerm") <del> ep.pattern = append(ep.pattern, "Storage node affinity check failed") </del> <ins> ep.pattern = append(ep.pattern, "MountVolume.NodeAffinity check failed") </ins> It("should not be able to mount due to different NodeName", func() { testPodWithNodeName(config, testVolType, ep, config.nodes[1].Name, makeLocalPodWithNodeName, testMode)
Change:
Is this a BUG REPORT or FEATURE REQUEST?: What happened: When setting in ipvs proxy mode, kube-proxy can't create clusterIP ipvs rules. What you expected to happen: Create clusterIP rules, so that can access service from internal. How to reproduce it (as minimally and precisely as possible): Create a service with backends in different node. Set service to . Access the service cluster IP from the node which don't have service backend.

Discussion:
// We need to bind ClusterIP to dummy interface, so set `bindAddr` parameter to `true` in syncService() if err := proxier.syncService(svcNameString, serv, true); err == nil { activeIPVSServices[serv.String()] = true <del> if err := proxier.syncEndpoint(svcName, svcInfo.onlyNodeLocalEndpoints, serv); err != nil { </del> <ins> // ExternalTrafficPolicy only works for NodePort and external LB traffic, does not affect ClusterIP // So we still need clusterIP rules in onlyNodeLocalEndpoints mode. if err := proxier.syncEndpoint(svcName, false, serv); err != nil { </ins> glog.Errorf("Failed to sync endpoint for service: %v, err: %v", serv, err) } } else {
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: when i create PersistentVolume, yaml like that: than describe it, got : What you expected to happen: Like that: How to reproduce it (as minimally and precisely as possible): What's said in Anything else we need to know?: Environment: Kubernetes version (use ): master Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/sig storage
Already got PR to fix this. /assign

Discussion:
"    Driver:t%vn"+ "    FSType:t%vn"+ "    SecretRef:t%vn"+ <del> "    ReadOnly:t%vn", </del> <ins> "    ReadOnly:t%vn"+ </ins> "    Options:t%vn", flex.Driver, flex.FSType, flex.SecretRef, flex.ReadOnly, flex.Options) }
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Run e2e node test with , and wait for new configuration take effect. But it will return new configuration has taken effect. What you expected to happen: will return with new configuration has taken effect. How to reproduce it (as minimally and precisely as possible): Run any e2e node test with . Anything else we need to know?: This is because we use period = 10 * time.Second and jitterFactor = 0.2 in . In extreme scenarios, it will take at least 12 seconds for Kubelet to catch this new config. We use this to check whether kubelet is restarted: This will return OK immediately as has been set to etcd, but kubelet don't restart with this . This function will return before new configuration has taken effect. I will send a PR to fix this. Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /area kubelet /sig node /assign /cc PTAL, Thanks!
The comment that will immediately contain the new (presumably changed) config prior to a Kubelet restart is incorrect. scrapes the values from the Kubelet's /configz endpoint, which won't have updated to the new configuration until after the Kubelet has restarted.
Hi, thanks for your explanation! I add some timestamps to test this, but the result is not the some as you described. For example, returned at , but Kubelet restarted at . And after reading the code, just call this API: , and i don't find any code about waiting for Kubelet has restarted. Could you point me these code please? Thanks very much!
Are you actually changing the configuration object's values? will return the old values until the Kubelet restarts (because /configz will return the old values until the Kubelet restarts). In any case where you actually change the config values, the assertion will fail until the Kubelet restarts, and thus you'll wait for the restart before continuing past the .
Thanks, I think this is because will read on starting, the configuration is always equal to the last time changed. So getCurrentKubeletConfig() will return immediately. But I have another question here: should we double check the is not equal to the before we call in ?
returns as soon as it gets a 200 response from /configz. Nothing to do with which config the Kubelet read. If the Eventually is exiting early, it's probably because no values were changed. The Kubelet may not have even restarted yet. That's probably a useful optimization.
Yes, I agree with you. Hi, , PTAL, Thanks.

Discussion:
framework.ExpectNoError(err) newCfg := oldCfg.DeepCopy() updateFunction(newCfg) <ins> if reflect.DeepEqual(*newCfg, *oldCfg) { return } </ins> framework.ExpectNoError(setKubeletConfiguration(f, newCfg)) }) AfterEach(func() {
Change:
Is this a BUG REPORT or FEATURE REQUEST?: What happened: In the log: What you expected to happen: The timeout should be more relaxed on /debug/pprof endpoints. How to reproduce it (as minimally and precisely as possible):
/assign

Discussion:
import ( "net/http" <ins> "strings" </ins> "k8s.io/apimachinery/pkg/util/sets" apirequest "k8s.io/apiserver/pkg/endpoints/request" ) <del> // BasicLongRunningRequestCheck returns true if the given request has one of the specified verbs or one of the specified subresources </del> <ins> // BasicLongRunningRequestCheck returns true if the given request has one of the specified verbs or one of the specified subresources, or is a profiler request. </ins> func BasicLongRunningRequestCheck(longRunningVerbs, longRunningSubresources sets.String) apirequest.LongRunningRequestCheck { return func(r *http.Request, requestInfo *apirequest.RequestInfo) bool { if longRunningVerbs.Has(requestInfo.Verb) {

if requestInfo.IsResourceRequest && longRunningSubresources.Has(requestInfo.Subresource) { return true } <ins> if !requestInfo.IsResourceRequest && strings.HasPrefix(requestInfo.Path, "/debug/pprof/") { return true } </ins> return false } }
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Received panic when I make a e2e-node test: What you expected to happen: Do not panic. How to reproduce it (as minimally and precisely as possible): Execute test locally like: Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/sig testing
/sig node

Discussion:
oldCfg, err := getCurrentKubeletConfig() framework.ExpectNoError(err) newCfg := oldCfg.DeepCopy() <ins> if newCfg.FeatureGates == nil { newCfg.FeatureGates = make(map[string]bool) } </ins> // Enable CPU Manager using feature gate. newCfg.FeatureGates[string(features.CPUManager)] = true
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: MarshalToYamlForCodecs adds an indent to the yaml output. This code can be combined with PrintBytesWithLinePrefix What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/assign rpothier
/sig cluster-lifecycle
/priority important-soon

Discussion:
package proxy import ( <ins> "bytes" </ins> "fmt" "runtime"

return err } <del> proxyBytes, err := kubeadmutil.MarshalToYamlForCodecsWithShift(cfg.KubeProxy.Config, kubeproxyconfigv1alpha1.SchemeGroupVersion, </del> <ins> proxyBytes, err := kubeadmutil.MarshalToYamlForCodecs(cfg.KubeProxy.Config, kubeproxyconfigv1alpha1.SchemeGroupVersion, </ins> kubeproxyconfigscheme.Codecs) if err != nil { return fmt.Errorf("error when marshaling: %v", err) } <ins> var prefixBytes bytes.Buffer apiclient.PrintBytesWithLinePrefix(&prefixBytes, proxyBytes, "    ") </ins> var proxyConfigMapBytes, proxyDaemonSetBytes []byte proxyConfigMapBytes, err = kubeadmutil.ParseTemplate(KubeProxyConfigMap19, struct {

ProxyConfig    string }{ MasterEndpoint: masterEndpoint, <del> ProxyConfig:    proxyBytes, </del> <ins> ProxyConfig:    prefixBytes.String(), </ins> }) if err != nil { return fmt.Errorf("error when parsing kube-proxy configmap template: %v", err)

import ( "fmt" <del> "strings" </del> "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime/schema"

encoder := codecs.EncoderForVersion(info.Serializer, gv) return runtime.Encode(encoder, obj) } <del> // MarshalToYamlForCodecsWithShift adds spaces in front of each line so the indents line up // correctly in the manifest func MarshalToYamlForCodecsWithShift(obj runtime.Object, gv schema.GroupVersion, codecs serializer.CodecFactory) (string, error) { serial, err := MarshalToYamlForCodecs(obj, gv, codecs) if err != nil { return "", err } lines := strings.Split(string(serial), "n") var newSerial string for _, line := range lines { newSerial = newSerial + "    " + line + "n" } return newSerial, err } </del>
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug /sig auth What happened: doesn't describe option. What you expected to happen: value should be present. How to reproduce it (as minimally and precisely as possible): Environment:

Discussion:
w.Write(LEVEL_0, "nSettings:n") w.Write(LEVEL_1, "Allow Privileged:t%tn", psp.Spec.Privileged) <ins> w.Write(LEVEL_1, "Allow Privilege Escalation:t%vn", psp.Spec.AllowPrivilegeEscalation) </ins> w.Write(LEVEL_1, "Default Add Capabilities:t%vn", capsToString(psp.Spec.DefaultAddCapabilities)) w.Write(LEVEL_1, "Required Drop Capabilities:t%sn", capsToString(psp.Spec.RequiredDropCapabilities)) w.Write(LEVEL_1, "Allowed Capabilities:t%sn", capsToString(psp.Spec.AllowedCapabilities))
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug /sig network Fix windows UT for proxy mode. Run UTs for in windows, That's because proxy mode "IPVS" is not valid in windows. What happened: What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/assign

Discussion:
) func TestValidateKubeProxyConfiguration(t *testing.T) { <ins> var proxyMode kubeproxyconfig.ProxyMode if runtime.GOOS == "windows" { proxyMode = kubeproxyconfig.ProxyModeKernelspace } else { proxyMode = kubeproxyconfig.ProxyModeIPVS } </ins> successCases := []kubeproxyconfig.KubeProxyConfiguration{ { BindAddress:        "192.168.59.103",

SyncPeriod:    metav1.Duration{Duration: 5 * time.Second}, MinSyncPeriod: metav1.Duration{Duration: 2 * time.Second}, }, <del> Mode: kubeproxyconfig.ProxyModeIPVS, </del> <ins> Mode: proxyMode, </ins> IPVS: kubeproxyconfig.KubeProxyIPVSConfiguration{ SyncPeriod:    metav1.Duration{Duration: 10 * time.Second}, MinSyncPeriod: metav1.Duration{Duration: 5 * time.Second},
Change:
/kind bug What happened: When a CSI driver reports a version of the CSI spec which does not match that stored in Kubernetes, Kubernetes prints the following message: What you expected to happen: Message should be: How to reproduce it (as minimally and precisely as possible): Use a CSI driver that reports version 0.0.0. Then deploy an application pod with a PVC from this driver. Application pod description will show the actual message above. Environment: Kubernetes version (use ): 1.9.1
/sig storage
/assign lpabon
hi, I can help fix that.
I did not see your PR until after I submitted.

Discussion:
// If version is not supported, the assertion fails with an error. // This test should be done early during the storage operation flow to avoid // unnecessary calls later. <ins> // `ver` argument holds the expected supported version. </ins> func (c *csiDriverClient) AssertSupportedVersion(ctx grpctx.Context, ver *csipb.Version) error { if c.versionAsserted { if !c.versionSupported {

c.versionSupported = supported if !supported { <del> return fmt.Errorf("version %s not supported", verToStr(ver)) </del> <ins> return fmt.Errorf( "CSI Driver does not support version %s. Instead it supports versions %s", verToStr(ver), versToStr(vers)) </ins> } glog.V(4).Info(log("version %s supported", verToStr(ver)))