jiebi/CodeConvo huggingface dataset:
Change:
<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --ci-kubernetes-e2e-gce-cos-k8sbeta-default Networking Granular Checks: Services should function for service endpoints using hostNetwork Triage looks like it's mostly flaking on this job only: Examples /sig network <!-- Please see the deflaking doc () for more guidance! --
/milestone v1.21 (marking in the current milestone until we get confirmation whether it is relevant to the release or not)
Slack Thread:
/assign
This is fixed by , let's wait some runs to confirm before closing
/milestone clear (since this has been deemed to be non release-blocking)
/triage accepted
/close
Closing this issue. <detailsIn response to : This is fixed by , let's wait some runs to confirm before closing Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
} }) <del> ginkgo.It("should function for pod-Service(hostNetwork): udp", func() { config := e2enetwork.NewNetworkingTestConfig(f, e2enetwork.EndpointsUseHostNetwork) ginkgo.By(fmt.Sprintf("dialing(udp) %v --> %v:%v (config.clusterIP)", config.TestContainerPod.Name, config.ClusterIP, e2enetwork.ClusterUDPPort)) err := config.DialFromTestContainer("udp", config.ClusterIP, e2enetwork.ClusterUDPPort, config.MaxTries, 0, config.EndpointHostnames()) if err != nil { framework.Failf("failed dialing endpoint, %v", err) } ginkgo.By(fmt.Sprintf("dialing(udp) %v --> %v:%v (nodeIP)", config.TestContainerPod.Name, config.NodeIP, config.NodeUDPPort)) err = config.DialFromTestContainer("udp", config.NodeIP, config.NodeUDPPort, config.MaxTries, 0, config.EndpointHostnames()) if err != nil { framework.Failf("failed dialing endpoint, %v", err) } }) </del> // if the endpoints pods use hostNetwork, several tests can't run in parallel // because the pods will try to acquire the same port in the host. // We run the test in serial, to avoid port conflicts.

framework.Failf("failed dialing endpoint, %v", err) } <ins> ginkgo.By("pod-Service(hostNetwork): udp") ginkgo.By(fmt.Sprintf("dialing(udp) %v --> %v:%v (config.clusterIP)", config.TestContainerPod.Name, config.ClusterIP, e2enetwork.ClusterUDPPort)) err = config.DialFromTestContainer("udp", config.ClusterIP, e2enetwork.ClusterUDPPort, config.MaxTries, 0, config.EndpointHostnames()) if err != nil { framework.Failf("failed dialing endpoint, %v", err) } ginkgo.By(fmt.Sprintf("dialing(udp) %v --> %v:%v (nodeIP)", config.TestContainerPod.Name, config.NodeIP, config.NodeUDPPort)) err = config.DialFromTestContainer("udp", config.NodeIP, config.NodeUDPPort, config.MaxTries, 0, config.EndpointHostnames()) if err != nil { framework.Failf("failed dialing endpoint, %v", err) } </ins> ginkgo.By("node-Service(hostNetwork): http") ginkgo.By(fmt.Sprintf("dialing(http) %v (node) --> %v:%v (config.clusterIP)", config.NodeIP, config.ClusterIP, e2enetwork.ClusterHTTPPort))
Change:
I'm writing a small bash script which generates some k8s resources in a namespace (other than ). When using to generate a service, the yaml which is generated does not include the defined namespace. I've also tried to move around the argument to the beginning (i.e. , but that doesn't work as well. Generated yaml should include the , when it's defined as an option. Kubernetes version (use ): Cloud provider or hardware configuration: n/a (not really important) OS (e.g: ): Kernel (e.g. ): Install tools: kubectl Network plugin and version (if this is a network-related bug): n/a Others: /sig cli
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig cli
/assign

Discussion:
FieldManager     string CreateAnnotation bool Namespace        string <ins> EnforceNamespace bool </ins> Client         corev1client.CoreV1Interface DryRunStrategy cmdutil.DryRunStrategy

return err } <del> o.Namespace, _, err = f.ToRawKubeConfigLoader().Namespace() </del> <ins> o.Namespace, o.EnforceNamespace, err = f.ToRawKubeConfigLoader().Namespace() </ins> if err != nil { return err }

selector := map[string]string{} selector["app"] = o.Name <ins> namespace := "" if o.EnforceNamespace { namespace = o.Namespace } </ins> service := corev1.Service{ ObjectMeta: metav1.ObjectMeta{ <del> Name:   o.Name, Labels: labels, </del> <ins> Name:      o.Name, Labels:    labels, Namespace: namespace, </ins> }, Spec: corev1.ServiceSpec{ <del> Type:         corev1.ServiceType(o.Type), </del> <ins> Type:         o.Type, </ins> Selector:     selector, Ports:        ports, ExternalName: o.ExternalName,

package create import ( <ins> "k8s.io/cli-runtime/pkg/genericclioptions" restclient "k8s.io/client-go/rest" cmdtesting "k8s.io/kubectl/pkg/cmd/testing" </ins> "testing" v1 "k8s.io/api/core/v1"

}) } } <ins> func TestCreateServiceWithNamespace(t *testing.T) { svcName := "test-service" ns := "test" tf := cmdtesting.NewTestFactory().WithNamespace(ns) defer tf.Cleanup() tf.ClientConfigVal = &restclient.Config{} ioStreams, _, buf, _ := genericclioptions.NewTestIOStreams() cmd := NewCmdCreateServiceClusterIP(tf, ioStreams) cmd.Flags().Set("dry-run", "client") cmd.Flags().Set("output", "jsonpath={.metadata.namespace}") cmd.Flags().Set("clusterip", "None") cmd.Run(cmd, []string{svcName}) if buf.String() != ns { t.Errorf("expected output: %s, but got: %s", ns, buf.String()) } } </ins>
Change:
[ ] OWNERSALIASES:581: # conformance aliases [x] // More info: ~~ [x] // See [x] fs.MarkDeprecated("redirect-container-streaming", "Container streaming redirection has been removed from the kubelet as of v1.20, and this flag will be removed in v1.22. For more details, see ") [x] // More info: [x] // More info: ~~ [x] [x] [x] CHANGELOG/CHANGELOG-[scalability validation report]: ~~ [x] ALPHA stability level ) [x] ALPHA stability level ) [x] ALPHA stability level ) [x] ALPHA stability level ) [x] ALPHA stability level ) [x] ALPHA stability level ) [x] ALPHA stability level ) [x] ALPHA stability level ) [x] ALPHA stability level ) [x] ALPHA stability level ) [x] ALPHA stability level ) [x] ALPHA stability level ) [ ] link: [ ] link: Some needs to be regenerated
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/help
/kind documentation
/remove-kind bug
/good-first-issue
/assign I shall fix .
/assign i'm working in
i have create a pr for
i see , you need
/assign fixing
/assign
/assign CHANGELOG/CHANGELOG-
/assign CHANGELOG/CHANGELOG- Edit : Link is already resolved, unassigning
/assign CHANGELOG/CHANGELOG-
/assign ,111
Sorry, already assigned
/assign i will take
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
  is merged. Most KEP links are fixed. You may scan it again. fixed most of them.
/sig architecture
/assign I will work on and
/remove-help

Discussion:
// General settings. fs.StringVar(&s.ContainerRuntime, "container-runtime", s.ContainerRuntime, "The container runtime to use. Possible values: 'docker', 'remote'.") fs.StringVar(&s.RuntimeCgroups, "runtime-cgroups", s.RuntimeCgroups, "Optional absolute name of cgroups to create and run the runtime in.") <del> _ = fs.Bool("redirect-container-streaming", false, "[REMOVED]") // TODO: Delete in v1.22 fs.MarkDeprecated("redirect-container-streaming", "Container streaming redirection has been removed from the kubelet as of v1.20, and this flag will be removed in v1.22. For more details, see http://git.k8s.io/enhancements/keps/sig-node/20191205-container-streaming-requests.md") </del> // Docker-specific settings. fs.StringVar(&s.DockershimRootDirectory, "experimental-dockershim-root-directory", s.DockershimRootDirectory, "Path to the dockershim root directory.")
Change:
We detected behavior change in v1.21.0 Example: POD has and for some containers Behavior in v1.20.5: starts applied startupProbe success, then start checks for livenessProbe working failed restarted startupProbe applied startupProbe success, then start checks for livenessProbe working Behavior in v1.21.0: starts applied startupProbe success, then start checks for livenessProbe working failed restarted applied, startupProbe skipped not ready yet, killed by liveness check in restart loop So, in v1.21 is applied to "fresh" starts only and not used when container restarted. There is not mentions in changelog that behavior of the is changed. should run on container restarts also. POD with and fail that doesn't apply after container restart Kubernetes version (use ):Cloud provider or hardware configuration: baremetal
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig node
/assign
Thanks for the quick fix
it was fixed in master (1.22) but not for 1.21, does it need a backport? /reopen
Reopened this issue. <detailsIn response to : it was fixed in master (1.22) but not for 1.21, does it need a backport? /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/close never mind i just saw the backports.
Closing this issue. <detailsIn response to : /close </details
can you summarize the impacted patch releases (looks like the regression was backported to 1.18-1.20 as well)
These 4 patch releases are impacted, 1.18.18, 1.19.10, 1.20.6, 1.21.0

Discussion:
if c.Started != nil && *c.Started { // Stop probing for startup once container has started. <ins> // we keep it running to make sure it will work for restarted container. </ins> if w.probeType == startup { <del> return false </del> <ins> return true </ins> } } else { // Disable other probes until container has started.

} } <del> func expectStop(t *testing.T, w *worker, c bool, msg string) { if c { t.Errorf("[%s - %s] Expected to stop, but did not", w.probeType, msg) } } </del> func resultsManager(m *manager, probeType probeType) results.Manager { switch probeType { case readiness:

// startupProbe fails, but is disabled m.prober.exec = fakeExecProber{probe.Failure, nil} msg = "Started, probe failure, result success" <del> expectStop(t, w, w.doProbe(), msg) </del> <ins> expectContinue(t, w, w.doProbe(), msg) </ins> expectResult(t, w, results.Success, msg) }
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --If GCE Windows VMs are created with API scope the download GCS code will not insert the bearer token when fetching artifacts. This means that private builds of Kubernetes won't download. GCE Windows VMs should pull Kubernetes from GCS if cloud-platform scope is set on the VMs service account credentials. The cluster will not come up with Windows nodes. You can then check Cloud Logging or Serial port output for the impacted VMs and see something like, Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others: /sig windows /priority important-soon
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign me
GitHub didn't allow me to assign the following users: me. Note that only , repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign me Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign jeremyje

Discussion:
$httpResponseMessage.Wait() if (-not $httpResponseMessage.IsCanceled) { # Check if the request was successful. <del> # </del> <ins> # </ins> # DO NOT replace with EnsureSuccessStatusCode(), it prints the # OAuth2 bearer token. if (-not $httpResponseMessage.Result.IsSuccessStatusCode) {

While($true) { $data = Get-InstanceMetadata -Key "service-accounts/default/scopes" if ($data) { <del> return ($data -match "auth/devstorage") </del> <ins> return ($data -match "auth/devstorage") -or ($data -match "auth/cloud-platform") </ins> } Start-Sleep -Seconds 1 }
Change:
We'd like to add to the windows nodes Discussed in , some storage e2e tests need the call to flush data to disk, this utility is not available in windows nodes or agnhost /sig storage /sig testing
/sig testing
/sig storage /kind flake
/sig windows
Does sync only need to be in Agnhost or also on the Windows node? I don't think there is any issue with adding to the agnhost for this tests. Has it been tested that it works? /cc in case you have thoughts
In the README of sync it says: Initially I thought it could be to agnhost however told me that Windows containers cannot run in privileged mode as of today. cc
Since we run the Windows Test containers as they should have full access to modify the host files if the host path is mapped in.
I downloaded the zip file and I checked that it has an EULA, do you know which sig would help with the license?
Hm, if the sysinternal is problematic, what about the GNU one? It seems to come from coreutils, which can easily be downloaded and extracted from. Hopefully, they are 64-bit binaries. Anyways, I think adding is a good idea, there are a few other non-conformance tests that are calling sync.
I believe that would be sig-contributor-experience. I thought we were using other sys-internal tools as well but it is a good idea to double check.
/triage accepted /assign
/remove-sig testing we don't own the nodes (?)
I've sent , which would add using that PR. Let us know if that satisfies your requirements, we could merge afterwards.
Thanks I guess we can merge the PR and I can run the storage e2e tests that need .

Discussion:
ADD https://github.com/coredns/coredns/releases/download/v1.5.0/coredns_1.5.0_windows_amd64.tgz /coredns.tgz ADD https://iperf.fr/download/windows/iperf-2.0.9-win64.zip /iperf.zip <ins> ADD http://download.savannah.nongnu.org/releases/coreutils/windows-64bit-unsupported/coreutils-8.31-28-windows-64bit.zip /coreutils.zip </ins> # we're also creating an empty /uploads folder, which we're copying over to Windows  because # we can't RUN commands on a Windows image. RUN tar -xzvf /coredns.tgz && unzip iperf.zip && mv iperf-2.0.9-win64 iperf && <ins> unzip coreutils.zip && mv coreutils-8.31-28-windows-64bit wincoreutils && </ins> mkdir /uploads FROM --platform=linux/amd64 $REGISTRY/windows-servercore-cache:1.0-linux-amd64-$OS_VERSION as servercore-helper

COPY --from=servercore-helper /Windows/System32/netapi32.dll /Windows/System32/netapi32.dll COPY --from=prep /coredns.exe /coredns.exe COPY --from=prep /iperf /iperf <ins> COPY --from=prep /wincoreutils/sync.exe /bin/sync.exe </ins> # NOTE(claudiub): docker buildx sets the PATH env variable to a Linux-like PATH, which is not desirable. ENV PATH="C:dig;C:bin;C:curl;C:Windowssystem32;C:Windows;C:Program FilesPowerShell;"
Change:
We'd like to add to the windows nodes Discussed in , some storage e2e tests need the call to flush data to disk, this utility is not available in windows nodes or agnhost /sig storage /sig testing
/sig testing
/sig storage /kind flake
/sig windows
Does sync only need to be in Agnhost or also on the Windows node? I don't think there is any issue with adding to the agnhost for this tests. Has it been tested that it works? /cc in case you have thoughts
In the README of sync it says: Initially I thought it could be to agnhost however told me that Windows containers cannot run in privileged mode as of today. cc
Since we run the Windows Test containers as they should have full access to modify the host files if the host path is mapped in.
I downloaded the zip file and I checked that it has an EULA, do you know which sig would help with the license?
Hm, if the sysinternal is problematic, what about the GNU one? It seems to come from coreutils, which can easily be downloaded and extracted from. Hopefully, they are 64-bit binaries. Anyways, I think adding is a good idea, there are a few other non-conformance tests that are calling sync.
I believe that would be sig-contributor-experience. I thought we were using other sys-internal tools as well but it is a good idea to double check.
/triage accepted /assign
/remove-sig testing we don't own the nodes (?)
I've sent , which would add using that PR. Let us know if that satisfies your requirements, we could merge afterwards.
Thanks I guess we can merge the PR and I can run the storage e2e tests that need .

Discussion:
} } command := fmt.Sprintf("echo '%s' > '%s'; sync", contents, path) <del> // TODO(mauriciopoppe): remove this statement once we add `sync` to the test image, ref #101172 if e2epod.NodeOSDistroIs("windows") { command = fmt.Sprintf("echo '%s' > '%s';", contents, path) } </del> stdout, stderr, err := tk.kubectlExecWithRetry(tk.Namespace, podName, containerName, "--", "/bin/sh", "-c", command) if err != nil { e2elog.Logf("error running kubectl exec to write file: %vnstdout=%vnstderr=%v)", err, string(stdout), string(stderr))
Change:
This test fails when OwnerReferencesPermissionEnforcement admission plugin is enabled: After the test creates a pod with an ephemeral volume, ephemeral volume controller in kube-controller-manager fails to create a PVC for it: The controller must have permissions to to be allowed to set with to Pods. The test passes. With : ENABLEADMISSIONPLUGINS="NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,Priority,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota,OwnerReferencesPermissionEnforcement" ALLOWPRIVILEGED=true LOGLEVEL=4 hack/local-up- Kubernetes version (use ): 1.21.0 & today's master
/sig storage /triage accepted /priority important-soon

Discussion:
ObjectMeta: metav1.ObjectMeta{Name: saRolePrefix + "ephemeral-volume-controller"}, Rules: []rbacv1.PolicyRule{ rbacv1helpers.NewRule("get", "list", "watch").Groups(legacyGroup).Resources("pods").RuleOrDie(), <ins> rbacv1helpers.NewRule("update").Groups(legacyGroup).Resources("pods/finalizers").RuleOrDie(), </ins> rbacv1helpers.NewRule("get", "list", "watch", "create").Groups(legacyGroup).Resources("persistentvolumeclaims").RuleOrDie(), eventsRule(), },

- apiGroups: - "" resources: <ins> - pods/finalizers verbs: - update - apiGroups: - "" resources: </ins> - persistentvolumeclaims verbs: - create
Change:
Users are not able to view by default as part of the or roles like they are with Users with or roles should be able to view like they are with Have a user with permissions on a namespace. Try to run the command I asked about this in slack and was told that it was an oversight that it wasn't to the default roles. Kubernetes version (use ): 1.21 Cloud provider or hardware configuration: n/a OS (e.g: ): n/a Kernel (e.g. ): n/a Install tools: n/a Network plugin and version (if this is a network-related bug): n/a Others: n/a
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig security
/sig auth

Discussion:
rbacv1helpers.NewRule(Write...).Groups(legacyGroup).Resources("replicationcontrollers", "replicationcontrollers/scale", "serviceaccounts", "services", "services/proxy", "endpoints", "persistentvolumeclaims", "configmaps", "secrets").RuleOrDie(), <ins> rbacv1helpers.NewRule(Write...).Groups(discoveryGroup).Resources("endpointslices").RuleOrDie(), </ins> rbacv1helpers.NewRule(Write...).Groups(appsGroup).Resources( "statefulsets", "statefulsets/scale", "daemonsets",

// indicator of which namespaces you have access to. rbacv1helpers.NewRule(Read...).Groups(legacyGroup).Resources("namespaces").RuleOrDie(), <ins> rbacv1helpers.NewRule(Read...).Groups(discoveryGroup).Resources("endpointslices").RuleOrDie(), </ins> rbacv1helpers.NewRule(Read...).Groups(appsGroup).Resources( "controllerrevisions", "statefulsets", "statefulsets/status", "statefulsets/scale",

- patch - update - apiGroups: <ins> - discovery.k8s.io resources: - endpointslices verbs: - create - delete - deletecollection - patch - update - apiGroups: </ins> - apps resources: - daemonsets

- list - watch - apiGroups: <ins> - discovery.k8s.io resources: - endpointslices verbs: - get - list - watch - apiGroups: </ins> - apps resources: - controllerrevisions