jiebi/CodeConvo huggingface dataset:
Change:
/kind bug What happened: I'm unable to set up a k8s cluster with RBAC due authorization errors (guessing) Nor set up kube-dns How to reproduce it (as minimally and precisely as possible): Run each component with these options: Anything else we need to know?: PRs and were patched against and kubelet + kube-controller-manager are being executed with those patches in place. Since those patches are IPv6 related, they should not affect the errors I'm seeing. Environment: Cloud provider or hardware configuration**: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/sig auth
you are telling the controller-manager to run its control loops using service account credentials (the flag), but you are not giving the controller manager a so it can actually create those credentials. You would need to specify that, and also give the corresponding public key to the apiserver (with ) so the credentials are recognized.
Opened to make it clearer when the controller manager is in this situation (it would log a warning and fail to start, rather than continue incorrectly)

Discussion:
ClientConfig: kubeconfig, } var clientBuilder controller.ControllerClientBuilder <del> if len(s.ServiceAccountKeyFile) > 0 && s.UseServiceAccountCredentials { </del> <ins> if s.UseServiceAccountCredentials { if len(s.ServiceAccountKeyFile) > 0 { // It's possible another controller process is creating the tokens for us. // If one isn't, we'll timeout and exit when our client builder is unable to create the tokens. glog.Warningf("--use-service-account-credentials was specified without providing a --service-account-private-key-file") } </ins> clientBuilder = controller.SAControllerClientBuilder{ ClientConfig:         restclient.AnonymousClientConfig(kubeconfig), CoreClient:           kubeClient.CoreV1(),
Change:
I'm consistently seeing the following failure in those runs: Seems like they're failing scheduling. Will look into it. cc
There are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals
Ok.. So it's consistently failing to create 6 pods and almost surely it's an issue with requests. Most probably some node-daemon is requesting more than before.
From the I'm almost 100% sure that it's failing due to this PR - It seems to have increased the fluentd memory request. Could one of you confirm this?
It hasn't (shouldn't have) changed the resource requirement, defaults for the env variable are the same as in the yaml
Cool, thanks. I'll check what else it could've been.
So it's due to insufficient cpu:
Unless kubemark was using another value than set in that yaml? At some point in time the cpu request was lower ().
It was almost immediately reverted:
We need 50m (kubelet) + 20m (proxy) + 20m (npd) for each hollow-node. And all nodes seem very close to being exhausted: Do you by any chance remember how much was used before?
The above pr should fix this
So the problem is indeed with fluentd. It's requesting 200m of CPU instead of 100m (as is expected). The fluentd container requests 100m as it should be - But the prometheus-to-sd-exporter sidecar container has also requested 100m : We don't have any requests for the exporter set in the yaml template - But it's being set.
There is a limitranger that sets default request to 100m but that's in default namespace which shouldn't affect fluentd. So it's indeed a bug with your PR Could you fix it?
Now these numbers seems awfully similar to the fluentd numbers. Now I see the link with Please investigate, it's a huge bug and has to be rolled back!
Testing a fix, I will send a PR soon.
Seems fixed - https://k8s-

Discussion:
kubectl set resources --dry-run --local -f ${fluentd_gcp_yaml}  --limits=memory=${FLUENTD_GCP_MEMORY_LIMIT}  --requests=cpu=${FLUENTD_GCP_CPU_REQUEST},memory=${FLUENTD_GCP_MEMORY_REQUEST}  <del> -o yaml > ${fluentd_gcp_yaml}.tmp </del> <ins> --containers=fluentd-gcp -o yaml > ${fluentd_gcp_yaml}.tmp </ins> mv ${fluentd_gcp_yaml}.tmp ${fluentd_gcp_yaml} }
Change:
while reading some cinder code, i came accross , we try to detach disk even if we didn't try to mount. Is this call mandatory ? (from what i recall AWS EBS do not have such mecanism) Also ping
There are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals
/sig openstack
cc
that's was before attach/detach controller, a revisit is necessary
Sure i'll take care of it /assign

Discussion:
volume.MetricsNil } <del> func detachDiskLogError(cd *cinderVolume) { err := cd.manager.DetachDisk(&cinderVolumeUnmounter{cd}) if err != nil { glog.Warningf("Failed to detach disk: %v (%v)", cd, err) } } </del> func (b *cinderVolumeMounter) GetAttributes() volume.Attributes { return volume.Attributes{ ReadOnly:        b.readOnly,

b.plugin.volumeLocks.LockKey(b.pdName) defer b.plugin.volumeLocks.UnlockKey(b.pdName) <del> // TODO: handle failed mounts here. </del> notmnt, err := b.mounter.IsLikelyNotMountPoint(dir) if err != nil && !os.IsNotExist(err) { glog.Errorf("Cannot validate mount point: %s %v", dir, err)

} if err := os.MkdirAll(dir, 0750); err != nil { <del> // TODO: we should really eject the attach/detach out into its own control loop. </del> glog.V(4).Infof("Could not create directory %s: %v", dir, err) <del> detachDiskLogError(b.cinderVolume) </del> return err }

} } os.Remove(dir) <del> // TODO: we should really eject the attach/detach out into its own control loop. detachDiskLogError(b.cinderVolume) </del> glog.Errorf("Failed to mount %s: %v", dir, err) return err }
Change:
See I think it's the last file that has no validation in pkg . Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration**: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
There are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals
/sig api-machinery

Discussion:
func (options *ServerRunOptions) Validate() []error { var errors []error <ins> if errs := options.GenericServerRunOptions.Validate(); len(errs) > 0 { errors = append(errors, errs...) } </ins> if errs := options.Etcd.Validate(); len(errs) > 0 { errors = append(errors, errs...) }

return nil } <ins> // Validate checks validation of ServerRunOptions func (s *ServerRunOptions) Validate() []error { errors := []error{} if s.TargetRAMMB < 0 { errors = append(errors, fmt.Errorf("--target-ram-mb can not be negative value")) } if s.MaxRequestsInFlight < 0 { errors = append(errors, fmt.Errorf("--max-requests-inflight can not be negative value")) } if s.MaxMutatingRequestsInFlight < 0 { errors = append(errors, fmt.Errorf("--min-request-timeout can not be negative value")) } return errors } </ins> // AddFlags adds flags for a specific APIServer to the specified FlagSet func (s *ServerRunOptions) AddUniversalFlags(fs *pflag.FlagSet) { // Note: the weird ""+ in below lines seems to be the only way to get gofmt to
Change:
Example: https://k8s- It seems there's not enough CPU to start in time

Discussion:
- name: kibana-logging image: docker.elastic.co/kibana/kibana:5.5.1 resources: <del> # keep request = limit to keep this container in guaranteed class </del> <ins> # need more cpu upon initialization, therefore burstable class </ins> limits: <del> cpu: 100m </del> <ins> cpu: 1000m </ins> requests: cpu: 100m env:
Change:
/kind feature As part of , the flag on the API server should be renamed to something like . We'll leave deprecated (should it be a no-op or not?) for v1.8. Or we should consider adding an explicit flag to the API server in the same way we have  flag on controller-manager. Right now, it enables/disables most authn plugins implicitely based on other flags (often pointing to various files on disk; if you specified a path to that file, you also want to enable this authn module) What way do you prefer?
/assign
Rough plan: (1.8) Add (1.8) Make it an error to specify both and (so we don't have to decide on precedence) (1.8) Add a warning if is used. (1.9) Drop
is: Mark deprecated. cc Approve?
/reopen Re-opening because there's a little bit left to do in 1.9 (ready to go in ).
[MILESTONENOTIFIER] Milestone Labels Incomplete Action required: This issue requires label changes. If the required changes are not made within 6 days, the issue will be moved out of the v1.8 milestone. priority: Must specify exactly one of [, , ]. <detailsAdditional instructions available <a href=""here</aThe commands available for adding these labels are documented <a href=""here</a</details

Discussion:
} type BootstrapTokenAuthenticationOptions struct { <del> Allow bool </del> <ins> Enable bool </ins> } type KeystoneAuthenticationOptions struct {

} if s.BootstrapToken != nil { <del> fs.BoolVar(&s.BootstrapToken.Allow, "experimental-bootstrap-token-auth", s.BootstrapToken.Allow, ""+ </del> <ins> fs.BoolVar(&s.BootstrapToken.Enable, "experimental-bootstrap-token-auth", s.BootstrapToken.Enable, ""+ "Deprecated (use --enable-bootstrap-token-auth).") fs.MarkDeprecated("experimental-bootstrap-token-auth", "use --enable-bootstrap-token-auth instead.") fs.BoolVar(&s.BootstrapToken.Enable, "enable-bootstrap-token-auth", s.BootstrapToken.Enable, ""+ </ins> "Enable to allow secrets of type 'bootstrap.kubernetes.io/token' in the 'kube-system' "+ "namespace to be used for TLS bootstrapping authentication.") }

} if s.BootstrapToken != nil { <del> ret.BootstrapToken = s.BootstrapToken.Allow </del> <ins> ret.BootstrapToken = s.BootstrapToken.Enable </ins> } if s.ClientCert != nil {
Change:
/kind feature As part of , the flag on the API server should be renamed to something like . We'll leave deprecated (should it be a no-op or not?) for v1.8. Or we should consider adding an explicit flag to the API server in the same way we have  flag on controller-manager. Right now, it enables/disables most authn plugins implicitely based on other flags (often pointing to various files on disk; if you specified a path to that file, you also want to enable this authn module) What way do you prefer?
/assign
Rough plan: (1.8) Add (1.8) Make it an error to specify both and (so we don't have to decide on precedence) (1.8) Add a warning if is used. (1.9) Drop
is: Mark deprecated. cc Approve?
/reopen Re-opening because there's a little bit left to do in 1.9 (ready to go in ).
[MILESTONENOTIFIER] Milestone Labels Incomplete Action required: This issue requires label changes. If the required changes are not made within 6 days, the issue will be moved out of the v1.8 milestone. priority: Must specify exactly one of [, , ]. <detailsAdditional instructions available <a href=""here</aThe commands available for adding these labels are documented <a href=""here</a</details

Discussion:
} if s.BootstrapToken != nil { <del> fs.BoolVar(&s.BootstrapToken.Enable, "experimental-bootstrap-token-auth", s.BootstrapToken.Enable, ""+ "Deprecated (use --enable-bootstrap-token-auth).") fs.MarkDeprecated("experimental-bootstrap-token-auth", "use --enable-bootstrap-token-auth instead.") </del> fs.BoolVar(&s.BootstrapToken.Enable, "enable-bootstrap-token-auth", s.BootstrapToken.Enable, ""+ "Enable to allow secrets of type 'bootstrap.kubernetes.io/token' in the 'kube-system' "+ "namespace to be used for TLS bootstrapping authentication.")
Change:
Referring and ; both have string in place of in section Example. This needs to be corrected in kubefed docs autogeneration. cc also see
/assign

Discussion:
"//pkg/kubectl/cmd/templates:go_default_library", "//pkg/kubectl/cmd/util:go_default_library", "//pkg/kubectl/resource:go_default_library", <ins> "//pkg/util/i18n:go_default_library", </ins> "//vendor/github.com/golang/glog:go_default_library", "//vendor/github.com/spf13/cobra:go_default_library", "//vendor/github.com/spf13/pflag:go_default_library",

kubectl "k8s.io/kubernetes/pkg/kubectl/cmd" "k8s.io/kubernetes/pkg/kubectl/cmd/templates" cmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util" <ins> "k8s.io/kubernetes/pkg/util/i18n" </ins> "github.com/spf13/cobra" ) <ins> var ( kubefedVersionExample = templates.Examples(i18n.T(` # Print the client and server versions for the current context kubefed version`)) kubefedOptionsExample = templates.Examples(i18n.T(` # Print flags inherited by all commands kubefed options`)) ) </ins> // NewKubeFedCommand creates the `kubefed` command and its nested children. func NewKubeFedCommand(f cmdutil.Factory, in io.Reader, out, err io.Writer, defaultServerImage, defaultEtcdImage string) *cobra.Command { // Parent command to which all subcommands are added.

} templates.ActsAsRootCommand(cmds, filters, groups...) <del> cmds.AddCommand(kubectl.NewCmdVersion(f, out)) cmds.AddCommand(kubectl.NewCmdOptions(out)) </del> <ins> cmdVersion := kubectl.NewCmdVersion(f, out) cmdVersion.Example = kubefedVersionExample cmds.AddCommand(cmdVersion) cmdOptions := kubectl.NewCmdOptions(out) cmdOptions.Example = kubefedOptionsExample cmds.AddCommand(cmdOptions) </ins> return cmds }
Change:
Currently IssueSSHComand in only checks for External IP address to ssh, this PR adds check for internal IP too. /sig storage /kind bug

Discussion:
} if host == "" { <del> return nil, fmt.Errorf("couldn't find external IP address for node %s", node.Name) </del> <ins> // No external IPs were found, let's try to use internal as plan B for _, a := range node.Status.Addresses { if a.Type == v1.NodeInternalIP { host = net.JoinHostPort(a.Address, sshPort) break } } } if host == "" { return nil, fmt.Errorf("couldn't find any IP address for node %s", node.Name) </ins> } Logf("SSH %q on %s(%s)", cmd, node.Name, host)
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind enhancement What happened: there is no UT for /sig testing
This issue should be closed because the corresponding PR has been merged already

Discussion:
"cluster_test.go", "configmap_test.go", "delete_test.go", <ins> "deployment_test.go", </ins> "env_file_test.go", "generate_test.go", "kubectl_test.go",

<ins> /* Copyright 2017 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package kubectl import ( "reflect" "testing" "k8s.io/api/core/v1" extensionsv1beta1 "k8s.io/api/extensions/v1beta1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" ) func TestDeploymentBasicGenerate(t *testing.T) { one := int32(1) tests := []struct { name           string deploymentName string images         []string expected       *extensionsv1beta1.Deployment expectErr      bool }{ { name:           "deployment name and images ok", deploymentName: "images-name-ok", images:         []string{"nn/image1", "registry/nn/image2", "nn/image3:tag", "nn/image4@digest"}, expected: &extensionsv1beta1.Deployment{ ObjectMeta: metav1.ObjectMeta{ Name:   "images-name-ok", Labels: map[string]string{"app": "images-name-ok"}, }, Spec: extensionsv1beta1.DeploymentSpec{ Replicas: &one, Selector: &metav1.LabelSelector{ MatchLabels: map[string]string{"app": "images-name-ok"}, }, Template: v1.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{ Labels: map[string]string{"app": "images-name-ok"}, }, Spec: v1.PodSpec{ Containers: []v1.Container{ {Name: "image1", Image: "nn/image1"}, {Name: "image2", Image: "registry/nn/image2"}, {Name: "image3", Image: "nn/image3:tag"}, {Name: "image4", Image: "nn/image4@digest"}, }, }, }, }, }, expectErr: false, }, { name:           "empty images", deploymentName: "images-empty", images:         []string{}, expectErr:      true, }, { name:           "no images", deploymentName: "images-missing", expectErr:      true, }, { name:      "no deployment name and images", expectErr: true, }, } for _, test := range tests { generator := &DeploymentBasicGeneratorV1{ BaseDeploymentGenerator{ Name:   test.deploymentName, Images: test.images, }, } obj, err := generator.StructuredGenerate() if !test.expectErr && err != nil { t.Errorf("unexpected error: %v", err) } if test.expectErr && err != nil { continue } if !reflect.DeepEqual(obj.(*extensionsv1beta1.Deployment), test.expected) { t.Errorf("test: %vnexpected:n%#vnsaw:n%#v", test.name, test.expected, obj.(*extensionsv1beta1.Deployment)) } } } </ins>
Change:
Had this test fail a few times on unrelated PRs in presubmit. Example failure: https://k8s- Possibly related to which recently merged. /kind flake cc

Discussion:
if err != nil { t.Fatalf("Failed to list pods: %v", err) } <del> if len(pods.Items) != 1 { t.Fatalf("Expect only 1 pod") </del> <ins> if len(pods.Items) > 1 { t.Fatalf("Unexpected pod list: %v", pods.Items) </ins> } // wait for the garbage collector to delete the pod if err := integration.WaitForPodToDisappear(podClient, garbageCollectedPodName, 5*time.Second, 30*time.Second); err != nil {
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind feature What happened: There are some unused commet, these are meaningless. And some function‘s comment does not follow go style. What you expected to happen: We should delete them all. and fix comment following golang style How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration**: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/assign
There are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals
can you edit the PR description in to say instead of ? That would automatically close this issue once the PR is merged. :)
OK, no problem~:)

Discussion:
return starts, nil } <del> // XXX unit test this </del> // getJobFromTemplate makes a Job from a CronJob func getJobFromTemplate(sj *batchv2alpha1.CronJob, scheduledTime time.Time) (*batchv1.Job, error) { // TODO: consider adding the following labels:

return job, nil } <del> // Return Unix Epoch Time </del> <ins> // getTimeHash returns Unix Epoch Time </ins> func getTimeHash(scheduledTime time.Time) int64 { return scheduledTime.Unix() }
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind feature What happened: In some files, i found that there are many self-contained function, whose feature is as same as some util function. Obviously, they are redundant. What you expected to happen: Use util function to replace self-contained function How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration**: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/assign
There are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals
similar comment to Can you edit the description in to say instead of ? Thanks!
Thanks. Done.

Discussion:
package mount import ( <ins> "reflect" </ins> "strings" "testing" )

} func mountPointsEqual(a, b *MountPoint) bool { <del> if a.Device != b.Device || a.Path != b.Path || a.Type != b.Type || !slicesEqual(a.Opts, b.Opts) || a.Pass != b.Pass || a.Freq != b.Freq { </del> <ins> if a.Device != b.Device || a.Path != b.Path || a.Type != b.Type || !reflect.DeepEqual(a.Opts, b.Opts) || a.Pass != b.Pass || a.Freq != b.Freq { </ins> return false } return true } <del> func slicesEqual(a, b []string) bool { if len(a) != len(b) { return false } for i := range a { if a[i] != b[i] { return false } } return true } </del> func TestGetMountRefs(t *testing.T) { fm := &FakeMounter{ MountPoints: []MountPoint{
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Some url in markdown file is invalid or need to be redirected to dest. url one time or more. What you expected to happen: So cleaning them up is necessary. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration**: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
There are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals
This can be closed now. It is fixed in
/close

Discussion:
<del> This file has moved to [https://github.com/kubernetes/examples/blob/master/staging/volumes/flexvolume/README.md](https://github.com/kubernetes/examples/blob/master/staging/volumes/flexvolume/README.md) </del> <ins> This file has moved to [https://github.com/kubernetes/community/blob/master/contributors/devel/flexvolume.md](https://github.com/kubernetes/community/blob/master/contributors/devel/flexvolume.md) </ins>
Change:
/approve no-issue isn't working on , so I'm trying this instead. /cc
There are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals
thanks

Discussion:
} // makeEventRecorder sets up kubeDeps.Recorder if its nil. Its a no-op otherwise. <del> func makeEventRecorder(s *kubeletconfiginternal.KubeletConfiguration, kubeDeps *kubelet.Dependencies, nodeName types.NodeName) { </del> <ins> func makeEventRecorder(kubeDeps *kubelet.Dependencies, nodeName types.NodeName) { </ins> if kubeDeps.Recorder != nil { return }

} // Setup event recorder if required. <del> makeEventRecorder(&s.KubeletConfiguration, kubeDeps, nodeName) </del> <ins> makeEventRecorder(kubeDeps, nodeName) </ins> if kubeDeps.ContainerManager == nil { if s.CgroupsPerQOS && s.CgroupRoot == "" {

return err } // Setup event recorder if required. <del> makeEventRecorder(kubeCfg, kubeDeps, nodeName) </del> <ins> makeEventRecorder(kubeDeps, nodeName) </ins> // TODO(mtaufen): I moved the validation of these fields here, from UnsecuredKubeletConfig, //                so that I could remove the associated fields from KubeletConfiginternal. I would