Change:
<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--Is this a request for help? (If yes, you should use our troubleshooting guide and community support channels, see ): No What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.): FailedMount Is this a BUG REPORT or FEATURE REQUEST? (choose one): Bug <!-- If this is a BUG REPORT, please: Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: Describe in detail the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --Kubernetes version (use ): 8 Environment: Cloud provider or hardware configuration: GKE, GCE OS (e.g. from /etc/os-release): GCI What happened: The FailedMount event can be misleading to users because it's not clear if the mount eventually succeeded or still failed. You would have to understand the internals of the system to correctly interpret the message, which is not user friendly. In this case, the mount did succeed, but the user still sees this failure msg in the events. What you expected to happen: A success event should be generated when a volume successfully attaches and mounts. Care needs to be taken to make sure we don't flood the event log. Maybe only have an event when the mount is successful, and not the attach. How to reproduce it (as minimally and precisely as possible): Create a deployment that uses a GCE PD volume, and move it to different nodes in order to cause the volume to need to be detached and attached to different nodes. cc
/assign
mount failures are a fairly common reason why some of the volume e2e tests fail. It has been useful to me to see the FailedMount event in the target pod. In the case of ceph-rdb we get a useful error msg: but for other plugins, not so helpful: If the mount eventually succeeds is it possible to annotate an earlier event record (not likely), or even know there was a previously recorded mount failure?
I'm not sure it's possible to modify an earlier event. So I think in this case, it would just always trigger a successful mount event, regardless of if it had previously failed.
And to clarify, I intend to leave the failed events as is. I just want to add a success event as well.
OK, that sounds good to me. Thanks for the clarification.
/sig storage

Discussion:
return detailedErr } <ins> simpleMsg, detailedMsg := volumeToMount.GenerateMsg("MountVolume.SetUp succeeded", "") </ins> verbosity := glog.Level(1) if isRemount { verbosity = glog.Level(7) <ins> } else { og.recorder.Eventf(volumeToMount.Pod, v1.EventTypeNormal, kevents.SuccessfulMountVolume, simpleMsg) </ins> } <del> glog.V(verbosity).Infof(volumeToMount.GenerateMsgDetailed("MountVolume.SetUp succeeded", "")) </del> <ins> glog.V(verbosity).Infof(detailedMsg) </ins> // Update actual state of world markVolMountedErr := actualStateOfWorld.MarkVolumeAsMounted(