Change:
Multiple, for example: Since See above The test tolerations are now to strict: No response /sig node
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
cc
I think it's from if you check the cri-o versions the succeessful one was and the failing was
Working on a fix in
cc
/reopen need to bump in kube as well to fully get the fix
Reopened this issue. <detailsIn response to : /reopen </details

Discussion:
``` cd kubernetes/.git/hooks/ <del> ln -s ../../hooks/prepare-commit-msg . ln -s ../../hooks/commit-msg . </del> <ins> ln -s ../../hooks/pre-commit . </ins> ``` ## Unit tests

# We do this in a tmpdir in case the dest has other non-autogenned files # We don't want to include them in the list of gen'd files local tmpdir="${KUBE_ROOT}/doc_tmp" <del> mkdir "${tmpdir}" </del> <ins> mkdir -p "${tmpdir}" </ins> # generate the new files ${cmd} "${tmpdir}" # create the list of generated files

<del> #!/bin/bash if [[ "$(grep -c "COMMIT_BLOCKED" $1)" -gt 0 ]]; then echo "FAILED: Unresolved errors - aborting the commit." echo "The message of your attempted commit was:" cat $1 exit 1 fi exit 0 </del>

<ins> #!/bin/bash readonly reset=$(tput sgr0) readonly   red=$(tput bold; tput setaf 1) readonly green=$(tput bold; tput setaf 2) KUBE_HOOKS_DIR="$(dirname "$(test -L "$0" && echo "$(dirname $0)/$(readlink "$0")" || echo "$0")")" exit_code=0 echo -ne "Checking for files that need gofmt... " files_need_gofmt=() files=($(git diff --cached --name-only --diff-filter ACM | grep ".go" | grep -v -e "third_party" -e "Godeps")) for file in "${files[@]}"; do # Check for files that fail gofmt. diff="$(git show ":${file}" | gofmt -s -d)" if [[ -n "$diff" ]]; then files_need_gofmt+=("${file}") fi done if [[ "${#files_need_gofmt[@]}" -ne 0 ]]; then echo "${red}ERROR!" echo "Some files have not been gofmt'd.  To fix these errors, " echo "cut and paste the following:" echo "  gofmt -s -w ${files_need_gofmt[@]}" exit_code=1 else echo "${green}OK" fi echo "${reset}" echo -ne "Checking for files that need boilerplate... " files_need_boilerplate=() boiler="${KUBE_HOOKS_DIR}/boilerplate.py" # Check for go files without the required boilerplate. if [[ ${#files[@]} -gt 0 ]]; then files_need_boilerplate+=($("${boiler}" "go" "${files[@]}")) fi # Check for sh files without the required boilerplate. files=($(git diff --cached --name-only --diff-filter ACM | grep ".sh" | grep -v -e "third_party" -e "Godeps")) if [[ ${#files[@]} -gt 0 ]]; then files_need_boilerplate+=($("${boiler}" "sh" "${files[@]}")) fi # Check for py files without the required boilerplate. files=($(git diff --cached --name-only --diff-filter ACM | grep ".py" | grep -v -e "third_party" -e "Godeps")) if [[ ${#files} -gt 0 ]]; then files_need_boilerplate+=($("${boiler}" "py" "${files[@]}")) fi if [[ "${#files_need_boilerplate[@]}" -ne 0 ]]; then echo "${red}ERROR!" echo "Some files are missing the required boilerplate header" echo "from hooks/boilerplate.txt:" for file in "${files_need_boilerplate[@]}"; do echo "  ${file}" done exit_code=1 else echo "${green}OK" fi echo "${reset}" echo -ne "Checking for API descriptions... " files_need_description=() # Check API schema definitions for field descriptions for file in $(git diff --cached --name-only --diff-filter ACM | egrep "pkg/api/v.[^/]*/types.go" | grep -v "third_party"); do # Check for files with fields without description tags descriptionless=$("${KUBE_HOOKS_DIR}/description.sh" "${file}") if [[ "$descriptionless" -eq "0" ]]; then files_need_description+=("${file}") fi done if [[ "${#files_need_description[@]}" -ne 0 ]]; then echo "${red}ERROR!" echo "Some API files are missing the required field descriptions." echo "Add description tags to all non-inline fields in the following files:" for file in "${files_need_description[@]}"; do echo "  ${file}" done exit_code=1 else echo "${green}OK" fi echo "${reset}" echo -ne "Checking for docs that need updating... " if ! hack/verify-gendocs.sh > /dev/null; then echo "${red}ERROR!" echo "Some docs are out of sync between CLI and markdown." echo "To regenerate docs, run:" echo "  hack/run-gendocs.sh > docs/kubectl.md" exit_code=1 else echo "${green}OK" fi echo "${reset}" exit $exit_code </ins>

<del> #!/bin/bash KUBE_HOOKS_DIR="$(dirname "$(test -L "$0" && echo "$(dirname $0)/$(readlink "$0")" || echo "$0")")" files_need_gofmt=() files_need_boilerplate=() files_need_description=() files=($(git diff --cached --name-only --diff-filter ACM | grep ".go" | grep -v -e "third_party" -e "Godeps")) for file in "${files[@]}"; do # Check for files that fail gofmt. diff="$(git show ":${file}" | gofmt -s -d)" if [[ -n "$diff" ]]; then files_need_gofmt+=("${file}") fi done boiler="${KUBE_HOOKS_DIR}/boilerplate.py" # Check for go files without the required boilerplate. if [[ ${#files[@]} -gt 0 ]]; then files_need_boilerplate+=($("${boiler}" "go" "${files[@]}")) fi # Check for sh files without the required boilerplate. files=($(git diff --cached --name-only --diff-filter ACM | grep ".sh" | grep -v -e "third_party" -e "Godeps")) if [[ ${#files[@]} -gt 0 ]]; then files_need_boilerplate+=($("${boiler}" "sh" "${files[@]}")) fi # Check for py files without the required boilerplate. files=($(git diff --cached --name-only --diff-filter ACM | grep ".py" | grep -v -e "third_party" -e "Godeps")) if [[ ${#files} -gt 0 ]]; then files_need_boilerplate+=($("${boiler}" "py" "${files[@]}")) fi # Check API schema definitions for field descriptions for file in $(git diff --cached --name-only --diff-filter ACM | egrep "pkg/api/v.[^/]*/types.go" | grep -v "third_party"); do # Check for files with fields without description tags descriptionless=$("${KUBE_HOOKS_DIR}/description.sh" "${file}") if [[ "$descriptionless" -eq "0" ]]; then files_need_description+=("${file}") fi done if [[ "${#files_need_gofmt[@]}" -ne 0 ]]; then ( echo echo "# *** ERROR: *** Some files have not been gofmt'd.  To fix these" echo "# errors, run gofmt -s -w <file>, or cut and paste the following:" echo "#   gofmt -s -w ${files_need_gofmt[@]}" echo "#" echo "# Your commit will be aborted unless you override this warning. To" echo "# commit in spite of these format errors, delete the following line:" echo "#   COMMIT_BLOCKED_ON_GOFMT" ) >> $1 fi if [[ "${#files_need_boilerplate[@]}" -ne 0 ]]; then ( echo echo "# *** ERROR: *** Some files are missing the required boilerplate" echo "# header from hooks/boilerplate.txt:" for file in "${files_need_boilerplate[@]}"; do echo "#   ${file}" done echo "#" echo "# Your commit will be aborted unless you fix these." echo "#   COMMIT_BLOCKED_ON_BOILERPLATE" echo ) >> $1 fi if [[ "${#files_need_description[@]}" -ne 0 ]]; then ( echo echo "# *** ERROR: *** Some API files are missing the required field descriptions" echo "# Add description tags to all non-inline fields in the following files:" for file in "${files_need_description[@]}"; do echo "#   ${file}" done echo "#" echo "# Your commit will be aborted unless you fix these." echo "#   COMMIT_BLOCKED_ON_DESCRIPTION" echo ) >> $1 fi if ! hack/verify-gendocs.sh > /dev/null; then ( echo echo "# *** ERROR: *** docs are out of sync between cli and markdown" echo "# run hack/run-gendocs.sh > docs/kubectl.md to regenerate" echo echo "#" echo "# Your commit will be aborted unless you regenerate docs." echo "    COMMIT_BLOCKED_ON_GENDOCS" echo ) >> $1 fi </del>