jiebi/CodeConvo huggingface dataset:
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Run , we could see two related command-line options. The explanation for is ambiguous, it says the master location is ought to be set by the master flag. This statement is inconsistent with the actual behavior. What you expected to happen: In fact, the flag is optional, it only overrides the control plane address in . That means, if we are using a single-context kubeconfig(or never changes the context), it's OK to just set and leave unset. Kube-proxy will parse the kubeconfig and use the credentials and master address defined in current context to contact cluster. Truth from code shows that kubeconfig parser do honors context setting: How to reproduce it (as minimally and precisely as possible): Environment: Kubernetes version (use ): v1.19.0 /sig network /area kube-proxy
Proposed a fix here
/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. ‍
/assign
If this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. ‍

Discussion:
fs.StringVar(&o.ConfigFile, "config", o.ConfigFile, "The path to the configuration file.") fs.StringVar(&o.WriteConfigTo, "write-config-to", o.WriteConfigTo, "If set, write the default configuration values to this file and exit.") <del> fs.StringVar(&o.config.ClientConnection.Kubeconfig, "kubeconfig", o.config.ClientConnection.Kubeconfig, "Path to kubeconfig file with authorization information (the master location is set by the master flag).") </del> <ins> fs.StringVar(&o.config.ClientConnection.Kubeconfig, "kubeconfig", o.config.ClientConnection.Kubeconfig, "Path to kubeconfig file with authorization information (the master location can be overridden by the master flag).") </ins> fs.StringVar(&o.config.ClusterCIDR, "cluster-cidr", o.config.ClusterCIDR, "The CIDR range of pods in the cluster. When configured, traffic sent to a Service cluster IP from outside this range will be masqueraded and traffic sent from pods to an external LoadBalancer IP will be directed to the respective cluster IP instead") fs.StringVar(&o.config.ClientConnection.ContentType, "kube-api-content-type", o.config.ClientConnection.ContentType, "Content type of requests sent to apiserver.") fs.StringVar(&o.master, "master", o.master, "The address of the Kubernetes API server (overrides any value in kubeconfig)")
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: kube-controller-manager panic when network interfaces for Azure VMSS are null. This happens when Azure cloud provider tried to get IP address for VMSS VM: What you expected to happen: kube-controller-manager should report an error instead of panic. How to reproduce it (as minimally and precisely as possible): Scale cluster nodes up and down frequently. Anything else we need to know?: /kind bug /area provider/azure Environment: Kubernetes version (use ): 1.15+ Cloud provider or hardware configuration: Azure OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:
/sig cloud-provider /assign

Discussion:
// This returns the full identifier of the primary NIC for the given VM. func (ss *scaleSet) getPrimaryInterfaceID(machine compute.VirtualMachineScaleSetVM) (string, error) { <ins> if machine.NetworkProfile == nil || machine.NetworkProfile.NetworkInterfaces == nil { return "", fmt.Errorf("failed to find the network interfaces for vm %s", to.String(machine.Name)) } </ins> if len(*machine.NetworkProfile.NetworkInterfaces) == 1 { return *(*machine.NetworkProfile.NetworkInterfaces)[0].ID, nil } for _, ref := range *machine.NetworkProfile.NetworkInterfaces { <del> if *ref.Primary { </del> <ins> if to.Bool(ref.Primary) { </ins> return *ref.ID, nil } } <del> return "", fmt.Errorf("failed to find a primary nic for the vm. vmname=%q", *machine.Name) </del> <ins> return "", fmt.Errorf("failed to find a primary nic for the vm. vmname=%q", to.String(machine.Name)) </ins> } // getVmssMachineID returns the full identifier of a vmss virtual machine.

}, expectedErr: fmt.Errorf("failed to find a primary nic for the vm. vmname="vm""), }, <ins> { description:       "GetPrimaryInterfaceID should report an error if there's no network interface on the VMSS VM", existedInterfaces: []compute.NetworkInterfaceReference{}, expectedErr:       fmt.Errorf("failed to find the network interfaces for vm vm"), }, </ins> } for _, test := range testCases {

}, }, } <ins> if len(test.existedInterfaces) == 0 { vm.VirtualMachineScaleSetVMProperties.NetworkProfile = nil } </ins> id, err := ss.getPrimaryInterfaceID(vm) assert.Equal(t, test.expectedErr, err, test.description+", but an error occurs")
Change:
<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: Which test(s) are flaking: Testgrid link: Reason for failure: Anything else we need to know: /cc /sig node /priority important-soon /milestone v1.20 Looks like this might be related to
looks like my fault, whoops. /assign As far as I can tell the test is sensitive to the environment it runs in. I'll try to make it match less, and if that doesn't work it may need to become serial.
attempt based on my understanding,

Discussion:
fmt.Sprintf("%s::%s::%s", f.Namespace.Name, pod1, "busybox-container"): boundedSample(0, 100), }), <del> "container_memory_working_set_bytes": gstruct.MatchAllElements(containerID, gstruct.Elements{ </del> <ins> "container_memory_working_set_bytes": gstruct.MatchElements(containerID, gstruct.IgnoreExtras, gstruct.Elements{ </ins> fmt.Sprintf("%s::%s::%s", f.Namespace.Name, pod0, "busybox-container"): boundedSample(10*e2evolume.Kb, 80*e2evolume.Mb), fmt.Sprintf("%s::%s::%s", f.Namespace.Name, pod1, "busybox-container"): boundedSample(10*e2evolume.Kb, 80*e2evolume.Mb), }),
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: TestLoopbackHostPortIPv6 fails when run in the machine where there is no IPv6 loopback device configured, with following error: Especially running in the containers where IPv6 is not really configured for the runtime What you expected to happen: Unit tests shouldn't really depend on the environment it is running, How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): master
/sig testing /cc
/assign
/remove-sig testing /sig api-machinery EDIT: This is a specific SIG's unit test that is environment dependent, not a systemic test issue or the framework etc.
/cc

Discussion:
t.Fatalf("fail to enumerate network interface, %s", err) } if !ipv6 { <del> t.Fatalf("no ipv6 loopback interface") </del> <ins> t.Skip("no ipv6 loopback interface") </ins> } host, port, err := LoopbackHostPort("[ff06:0:0:0:0:0:0:c3]:443")
Change:
When should it be removed? /sig network /kind cleanup
It was GAed in 1.17 and should have been removed in 1.18. I will send a PR to remove it retrospectively. /assign
/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. ‍
/remove-triage unresolved
I know a new-contributor looking for good-first-issues. Do you mind if I cc him on this issue since it seems pretty straightforward ?
That sounds perfect, thanks!
cc
I am still planning on working on this, I am just having some dev environment issues I am hoping to resolve in the next few days. I'll update again when I get them resolved.
Hey, just a quick update. I have been fairly busy and am going on vacation next week. I AM still planning on working on this, however since I am obviously very slow if someone comes along and wants to work on this feel free. Just please comment that you will work on it so I know :).

Discussion:
// Expects the OpenStack Cinder CSI Driver to be installed and configured on all nodes. CSIMigrationOpenStackComplete featuregate.Feature = "CSIMigrationOpenStackComplete" <del> // owner: @MrHohn // alpha: v1.15 // beta:  v1.16 // GA: v1.17 // // Enables Finalizer Protection for Service LoadBalancers. ServiceLoadBalancerFinalizer featuregate.Feature = "ServiceLoadBalancerFinalizer" </del> // owner: @RobertKrawitz // alpha: v1.15 //

KubeletPodResources:            {Default: true, PreRelease: featuregate.Beta}, WindowsGMSA:                    {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.20 WindowsRunAsUserName:           {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.20 <del> ServiceLoadBalancerFinalizer:   {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, </del> LocalStorageCapacityIsolationFSQuotaMonitoring: {Default: false, PreRelease: featuregate.Alpha}, NonPreemptingPriority:                          {Default: true, PreRelease: featuregate.Beta}, VolumePVCDataSource:                            {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.20
Change:
When should it be removed? /sig network /kind cleanup
/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. ‍
According to , it need to remove in 1.20. /assign
If this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. ‍
/remove-triage unresolved

Discussion:
// Enables a feature to make secrets and configmaps data immutable. ImmutableEphemeralVolumes featuregate.Feature = "ImmutableEphemeralVolumes" <del> // owner: @robscott // beta: v1.18 // ga: v1.19 // // Enables DefaultIngressClass admission controller. DefaultIngressClass featuregate.Feature = "DefaultIngressClass" </del> // owner: @bart0sh // alpha: v1.18 // beta: v1.19

ServiceTopology:                                {Default: false, PreRelease: featuregate.Alpha}, ServiceAppProtocol:                             {Default: true, PreRelease: featuregate.Beta}, ImmutableEphemeralVolumes:                      {Default: true, PreRelease: featuregate.Beta}, <del> DefaultIngressClass:                            {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.20 </del> HugePageStorageMediumSize:                      {Default: true, PreRelease: featuregate.Beta}, ExternalPolicyForExternalIP:                    {Default: true, PreRelease: featuregate.GA}, // remove in 1.20 AnyVolumeDataSource:                            {Default: false, PreRelease: featuregate.Alpha},
Change:
<!-- Please only use this template for submitting reports about flaky tests or jobs (pass or fail with no underlying change in code) in Kubernetes CI --Which jobs are flaking: pull-kubernetes-bazel-test Which test(s) are flaking: Testgrid link: Reason for failure: Anything else we need to know: To reproduce using
/sig api-machinery

Discussion:
// use a channel to ensure we don't look at the metric before it's // been set. ch := make(chan struct{}, 1) <ins> longestCh := make(chan struct{}, 1) </ins> mp.unfinished.notifyCh = ch <ins> mp.longest.notifyCh = longestCh </ins> c.Step(time.Millisecond) <-ch mp.unfinished.notifyCh = nil if e, a := .001, mp.unfinished.gaugeValue(); e != a { t.Errorf("expected %v, got %v", e, a) } <ins> <-longestCh mp.longest.notifyCh = nil </ins> if e, a := .001, mp.longest.gaugeValue(); e != a { t.Errorf("expected %v, got %v", e, a) }
Change:
Which jobs are flaking: Which test(s) are flaking: periodic-kubernetes-bazel-test-master (xref ) Testgrid link: Reason for failure: Anything else we need to know: to reproduce with : /sig storage
/assign
solved at
still flaking - /reopen
Reopened this issue. <detailsIn response to : still flaking - Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
-- No recent failures in the past 2 weeks, are you okay if we close this?
yeah, looks like resolved it /close
Closing this issue. <detailsIn response to : yeah, looks like resolved it Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
it's back not sure if related to this issue but same test with a data race spotted last night looking into filed

Discussion:
const ( // reconcilerLoopSleepDuration is the amount of time the reconciler loop // waits between successive executions <del> reconcilerLoopSleepDuration time.Duration = 1 * time.Nanosecond </del> <ins> reconcilerLoopSleepDuration = 1 * time.Nanosecond </ins> // waitForAttachTimeout is the maximum amount of time a // operationexecutor.Mount call will wait for a volume to be attached. <del> waitForAttachTimeout         time.Duration     = 1 * time.Second nodeName                     k8stypes.NodeName = k8stypes.NodeName("mynodename") kubeletPodsDir               string            = "fake-dir" testOperationBackOffDuration time.Duration     = 100 * time.Millisecond reconcilerSyncWaitDuration   time.Duration     = 10 * time.Second </del> <ins> waitForAttachTimeout         = 1 * time.Second nodeName                     = k8stypes.NodeName("mynodename") kubeletPodsDir               = "fake-dir" testOperationBackOffDuration = 100 * time.Millisecond reconcilerSyncWaitDuration   = 10 * time.Second </ins> ) func hasAddedPods() bool { return true }

<-stoppedChan finished := make(chan interface{}) <ins> fakePlugin.Lock() </ins> fakePlugin.UnmountDeviceHook = func(mountPath string) error { // Act: // 3. While a volume is being unmounted, add it back to the desired state of world

close(finished) return devicePath, nil } <ins> fakePlugin.Unlock() </ins> // Start the reconciler again. go reconciler.Run(wait.NeverStop)
Change:
Which jobs are flaking: periodic-kubernetes-bazel-test-master (xref ) Which test(s) are flaking: TestEventSeriesf Testgrid link: Reason for failure: Timeout: Anything else we need to know: To reproduce with stress: /cc
There are no sig labels on this issue. Please add an appropriate label by using one of the following commands: - Please see the for a listing of the SIGs, working groups, and committees available. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
filed to address this issue.
contains the correct analysis of flakes (thanks a lot!), I commented on way of fixing it (which I'm not convinced about).

Discussion:
return watcher.Stop } <del> // StartRecordingToSink starts sending events received from the specified eventBroadcaster to the given sink. func (e *eventBroadcasterImpl) StartRecordingToSink(stopCh <-chan struct{}) { go wait.Until(func() { e.refreshExistingEventSeries() }, refreshTime, stopCh) go wait.Until(func() { e.finishSeries() }, finishTime, stopCh) </del> <ins> func (e *eventBroadcasterImpl) startRecordingEvents(stopCh <-chan struct{}) { </ins> eventHandler := func(obj runtime.Object) { event, ok := obj.(*eventsv1.Event) if !ok {

}() } <ins> // StartRecordingToSink starts sending events received from the specified eventBroadcaster to the given sink. func (e *eventBroadcasterImpl) StartRecordingToSink(stopCh <-chan struct{}) { go wait.Until(e.refreshExistingEventSeries, refreshTime, stopCh) go wait.Until(e.finishSeries, finishTime, stopCh) e.startRecordingEvents(stopCh) } </ins> type eventBroadcasterAdapterImpl struct { coreClient          typedv1core.EventsGetter coreBroadcaster     record.EventBroadcaster

testPod := &v1.Pod{ ObjectMeta: metav1.ObjectMeta{ <del> SelfLink:  "/api/v1/namespaces/baz/pods/foo", </del> Name:      "foo", Namespace: "baz", UID:       "bar",

} eventBroadcaster := newBroadcaster(&testEvents, 0, map[eventKey]*eventsv1.Event{}) recorder := eventBroadcaster.NewRecorder(scheme.Scheme, "eventTest") <del> eventBroadcaster.StartRecordingToSink(stopCh) </del> <ins> broadcaster := eventBroadcaster.(*eventBroadcasterImpl) // Don't call StartRecordingToSink, as we don't need neither refreshing event // series nor finishing them in this tests and additional events updated would // race with our expected ones. broadcaster.startRecordingEvents(stopCh) </ins> recorder.Eventf(regarding, related, isomorphicEvent.Type, isomorphicEvent.Reason, isomorphicEvent.Action, isomorphicEvent.Note, []interface{}{1}) // read from the chan as this was needed only to populate the cache <-createEvent
Change:
What happened: 50% of builds have a different man page content What you expected to happen: It should be possible to get bit-identical build results - might need a patch similar to - knows these things. How to reproduce it (as minimally and precisely as possible): build kubernetes1.19 openSUSE package a few times and compare results. e.g. with Anything else we need to know?: Environment: OS: openSUSE-Tumbleweed While working on for , I found that when building the kubernetes1.19 package, there was sometimes such a difference between builds:
/sig release
/sig scheduling

Discussion:
import ( "fmt" <ins> "sort" </ins> "github.com/go-logr/logr" json "k8s.io/component-base/logs/json"

return nil } <del> // List names of registered log formats </del> <ins> // List names of registered log formats (sorted) </ins> func (lfr *LogFormatRegistry) List() []string { formats := make([]string, 0, len(lfr.registry)) for f := range lfr.registry { formats = append(formats, f) } <ins> sort.Strings(formats) </ins> return formats }
Change:
<!-- Please only use this template for submitting enhancement requests --What would you like to be : We need reporting of version to be shown in the metrics. Why is this needed: The goal behind this is to add some info about the underlying infrastructure for the kubernetes cluster. Some customers were experiencing issues during the cluster upgrades, but nothing in the upgrades themselves or kubernetes code for provider seemingly could cause those. The issue is storage related, and happening on a variety of releases with a significant delay from any other underlying infrastructure change, to which the kubernetes cluster has no relation and a way to know about. So knowing used hostnames, and versions associated with it over time would be extremely beneficial for debugging in similar circumstances. Some of the use cases we face: 1) A is enabled in a customer environment, and so there occurs a periodic automated vMotion for VMs backing kuberentes . We'd like to know on which host the actual kubernetes was located at any moment, and if any vCenter version transitions happened over time, new hosts /removed/renamed.
/sig cloud-provider /wg provider-vsphere
The label(s) cannot be applied, because the repository doesn't have them <detailsIn response to : /sig cloud-provider /wg provider-vsphere Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/area provider/vmware

Discussion:
It also assumes that ```$DOCKER_USER``` is set to your docker user id. <ins> You may need to open the firewall for port 8080 using the [console][cloud-console] or the `gcutil` tool. The following command will allow traffic from any source to instances tagged `kubernetes-minion`: ```shell $ gcutil addfirewall --allowed=tcp:8080 --target_tags=kubernetes-minion kubernetes-minion-8080 ``` </ins> ### Step One: Build the image $ cd kubernetes/examples/update-demo/image

$ cluster/kubecfg.sh -u=30s rollingupdate dataController Watch the UX, it will update one pod every 30 seconds until all of the pods have the new color. <ins> [cloud-console]: https://console.developer.google.com </ins>
Change:
It's not being used. Alternatively, pass the right image name to start with. /assign /sig scheduling /sig testing
/kind cleanup

Discussion:
f := framework.NewDefaultFramework("multi-az") var zoneCount int var err error <del> image := framework.ServeHostnameImage </del> ginkgo.BeforeEach(func() { e2eskipper.SkipUnlessProviderIs("gce", "gke", "aws") if zoneCount <= 0 {

// TODO: SkipUnlessDefaultScheduler() // Non-default schedulers might not spread }) ginkgo.It("should spread the pods of a service across zones", func() { <del> SpreadServiceOrFail(f, (2*zoneCount)+1, image) </del> <ins> SpreadServiceOrFail(f, (2*zoneCount)+1, imageutils.GetPauseImageName()) </ins> }) ginkgo.It("should spread the pods of a replication controller across zones", func() { <del> SpreadRCOrFail(f, int32((2*zoneCount)+1), image, []string{"serve-hostname"}) </del> <ins> SpreadRCOrFail(f, int32((2*zoneCount)+1), framework.ServeHostnameImage, []string{"serve-hostname"}) </ins> }) })

Containers: []v1.Container{ { Name:  "test", <del> Image: imageutils.GetPauseImageName(), </del> <ins> Image: image, </ins> }, }, },
Change:
/sig scheduling /sig testing /assign
/kind cleanup
May I give a try?
please go ahead. Un-assigning myself.
/assign What should I do just replace with ?
please see the go docs for and the example they have there: They do a better job than I possibly can :)

Discussion:
klog.Fatalf("%v", err) } lastScheduledCount := len(podsScheduled) <ins> ticker := time.NewTicker(throughputSampleFrequency) defer ticker.Stop() </ins> for { select { case <-ctx.Done(): return <del> // TODO(#94665): use time.Ticker instead case <-time.After(throughputSampleFrequency): </del> <ins> case <-ticker.C: </ins> podsScheduled, err := getScheduledPods(tc.podInformer, tc.namespaces...) if err != nil { klog.Fatalf("%v", err)
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: When we scale Rancher to 1000's of clusters we end up spending a large percentage of our time waking up and doing nothing across 10s of thousands of goroutines. This was seen as constantly consuming 2-3 cores while the system was in an 'idle' state with approx. 78k queues being active. What you expected to happen: I would expect these goroutines to not be running if there is no metrics for them to write to. How to reproduce it (as minimally and precisely as possible): Calling in a loop Anything else we need to know?: Environment: Kubernetes version (use ): v1.19.1 Cloud provider or hardware configuration: DO droplets OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:
/sig api-machinery
/cc
/assign
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
/remove-lifecycle stale

Discussion:
metrics:                    metrics, unfinishedWorkUpdatePeriod: updatePeriod, } <del> go t.updateUnfinishedWorkLoop() </del> <ins> // Don't start the goroutine for a type of noMetrics so we don't consume // resources unnecessarily if _, ok := metrics.(noMetrics); !ok { go t.updateUnfinishedWorkLoop() } </ins> return t }