jiebi/CodeConvo huggingface dataset:
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: E2E case fails on Azure Error log is: In , determinePublicIPName is called even if internal load balancer wanted, and static IP specified. But it will fail when user specifies a static IP. This is a regression in v1.9.0-beta.1 What you expected to happen: The internal balancer with specified static IP should work. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment:
/sig azure cc This works in v1.8.0, v1.9.0-beta.0, but fails in v1.9.0-beta.1 . Could consider a v1.9 issue.
[MILESTONENOTIFIER] Milestone Issue Needs Attention Action Required: This issue has not been updated since Dec 3. Please provide an update. Note: This issue is marked as , and must be updated every 1 day during code freeze. Example update: <details<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=""Additional instructions</a</li<li<a href=""Commands for setting labels</a</li</ul</details

Discussion:
func (az *Cloud) reconcilePublicIP(clusterName string, service *v1.Service, wantLb bool) (*network.PublicIPAddress, error) { isInternal := requiresInternalLoadBalancer(service) serviceName := getServiceName(service) <del> desiredPipName, err := az.determinePublicIPName(clusterName, service) if err != nil { return nil, err </del> <ins> var desiredPipName string var err error if !isInternal && wantLb { desiredPipName, err = az.determinePublicIPName(clusterName, service) if err != nil { return nil, err } </ins> } pips, err := az.ListPIPWithRetry()
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: currently only are checked in admission controller What you expected to happen: hostNetwork should also be checked to deny exec /attach How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/kind bug /sig auth
cc

Discussion:
client internalclientset.Interface // these flags control which items will be checked to deny exec/attach <del> hostIPC    bool hostPID    bool privileged bool </del> <ins> hostNetwork bool hostIPC     bool hostPID     bool privileged  bool </ins> } var _ admission.ValidationInterface = &DenyExec{}

// using host based configurations. func NewDenyEscalatingExec() *DenyExec { return &DenyExec{ <del> Handler:    admission.NewHandler(admission.Connect), hostIPC:    true, hostPID:    true, privileged: true, </del> <ins> Handler:     admission.NewHandler(admission.Connect), hostNetwork: true, hostIPC:     true, hostPID:     true, privileged:  true, </ins> } } // NewDenyExecOnPrivileged creates a new admission controller that is only checking the privileged <del> // option.  This is for legacy support of the DenyExecOnPrivileged admission controller.  Most // of the time NewDenyEscalatingExec should be preferred. </del> <ins> // option. This is for legacy support of the DenyExecOnPrivileged admission controller. // Most of the time NewDenyEscalatingExec should be preferred. </ins> func NewDenyExecOnPrivileged() *DenyExec { return &DenyExec{ <del> Handler:    admission.NewHandler(admission.Connect), hostIPC:    false, hostPID:    false, privileged: true, </del> <ins> Handler:     admission.NewHandler(admission.Connect), hostNetwork: false, hostIPC:     false, hostPID:     false, privileged:  true, </ins> } }

return admission.NewForbidden(a, err) } <del> if d.hostPID && pod.Spec.SecurityContext != nil && pod.Spec.SecurityContext.HostPID { return admission.NewForbidden(a, fmt.Errorf("cannot exec into or attach to a container using host pid")) } </del> <ins> if pod.Spec.SecurityContext != nil { securityContext := pod.Spec.SecurityContext if d.hostNetwork && securityContext.HostNetwork { return admission.NewForbidden(a, fmt.Errorf("cannot exec into or attach to a container using host network")) } </ins> <del> if d.hostIPC && pod.Spec.SecurityContext != nil && pod.Spec.SecurityContext.HostIPC { return admission.NewForbidden(a, fmt.Errorf("cannot exec into or attach to a container using host ipc")) </del> <ins> if d.hostPID && securityContext.HostPID { return admission.NewForbidden(a, fmt.Errorf("cannot exec into or attach to a container using host pid")) } if d.hostIPC && securityContext.HostIPC { return admission.NewForbidden(a, fmt.Errorf("cannot exec into or attach to a container using host ipc")) } </ins> } if d.privileged && isPrivileged(pod) {
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: I have tried FlexVolume on a Windows node, it does not work. I am now working on this feature now. Below is the FlexVolume initialization error What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): v1.7.7 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /sig windows /assign
Detailed steps about how to use flexvolume on Windows with this PR:
cc:

Discussion:
import ( "fmt" "net" <ins> "runtime" </ins> "github.com/golang/glog"

} func (kvh *kubeletVolumeHost) GetPodVolumeDir(podUID types.UID, pluginName string, volumeName string) string { <del> return kvh.kubelet.getPodVolumeDir(podUID, pluginName, volumeName) </del> <ins> dir := kvh.kubelet.getPodVolumeDir(podUID, pluginName, volumeName) if runtime.GOOS == "windows" { dir = volume.GetWindowsPath(dir) } return dir </ins> } func (kvh *kubeletVolumeHost) GetPodVolumeDeviceDir(podUID types.UID, pluginName string) string {

import ( "fmt" "path" <ins> "runtime" </ins> "strings" "sync"

func (plugin *flexVolumePlugin) getExecutable() string { parts := strings.Split(plugin.driverName, "/") execName := parts[len(parts)-1] <del> return path.Join(plugin.execPath, execName) </del> <ins> execPath := path.Join(plugin.execPath, execName) if runtime.GOOS == "windows" { execPath = volume.GetWindowsPath(execPath) } return execPath </ins> } // Name is part of the volume.VolumePlugin interface.

} return true } <ins> // GetWindowsPath get a windows path func GetWindowsPath(path string) string { windowsPath := strings.Replace(path, "/", "", -1) if strings.HasPrefix(windowsPath, "") { windowsPath = "c:" + windowsPath } return windowsPath } </ins>

} } } <ins> func TestGetWindowsPath(t *testing.T) { tests := []struct { path         string expectedPath string }{ { path:         `/var/lib/kubelet/pods/146f8428-83e7-11e7-8dd4-000d3a31dac4/volumes/kubernetes.io~disk`, expectedPath: `c:varlibkubeletpods146f8428-83e7-11e7-8dd4-000d3a31dac4volumeskubernetes.io~disk`, }, { path:         `var/lib/kubelet/pods/146f8428-83e7-11e7-8dd4-000d3a31dac4volumeskubernetes.io~disk`, expectedPath: `c:varlibkubeletpods146f8428-83e7-11e7-8dd4-000d3a31dac4volumeskubernetes.io~disk`, }, { path:         `/`, expectedPath: `c:`, }, { path:         ``, expectedPath: ``, }, } for _, test := range tests { result := GetWindowsPath(test.path) if result != test.expectedPath { t.Errorf("GetWindowsPath(%v) returned (%v), want (%v)", test.path, result, test.expectedPath) } } } </ins>
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: In a go program, using the YAML utility package "", the YAMLDecoder Read function always returns n=0 bytes, indicating that nothing was read. What you expected to happen: The number of bytes read should be returned as specified in the How to reproduce it (as minimally and precisely as possible): See Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: minikube & AWS OS (e.g. from /etc/os-release): macOS 10.13.1 (17B1003) Kernel (e.g. ): Darwin 17.2.0 Install tools: Others:
Reiterating the mentions to trigger a notification: <detailsIn response to : Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/cc

Discussion:
if left <= len(data) { copy(data, d.remaining) d.remaining = nil <del> return len(d.remaining), nil </del> <ins> return left, nil </ins> } // caller will need to reread

"encoding/json" "fmt" "io" <ins> "io/ioutil" </ins> "math/rand" "reflect" "strings" "testing" ) <ins> func TestYAMLDecoderReadBytesLength(t *testing.T) { d := `--- stuff: 1 test-foo: 1 ` testCases := []struct { bufLen    int expectLen int expectErr error }{ {len(d), len(d), nil}, {len(d) + 10, len(d), nil}, {len(d) - 10, len(d) - 10, io.ErrShortBuffer}, } for i, testCase := range testCases { r := NewDocumentDecoder(ioutil.NopCloser(bytes.NewReader([]byte(d)))) b := make([]byte, testCase.bufLen) n, err := r.Read(b) if err != testCase.expectErr || n != testCase.expectLen { t.Fatalf("%d: unexpected body: %d / %v", i, n, err) } } } </ins> func TestSplitYAMLDocument(t *testing.T) { testCases := []struct { input  string
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: is always appending a new line to its message: In some places of code, the message is already has a newline character and it leads to doubled new lines in the logs. What you expected to happen: I'm not sure what is the correct behavior here. One of the options could be to append a new line conditionally.
/sig testing
I'm new to Kubernetes and would like to start contributing. Is it ok if I assign myself this issue?
/assign MorrisLaw
GitHub didn't allow me to assign the following users: MorrisLaw. Note that only can be assigned. <detailsIn response to : /assign MorrisLaw Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
I can't assign this to myself, as I am not a member yet. But I am still going to take this issue.
I'll help him on reviews so assigning.

Discussion:
glog.Info("The --provider flag is not set.  Treating as a conformance test.  Some tests may not be run.") case "gce", "gke": <del> framework.Logf("Fetching cloud provider for %qrn", framework.TestContext.Provider) </del> <ins> framework.Logf("Fetching cloud provider for %qr", framework.TestContext.Provider) </ins> zone := framework.TestContext.CloudConfig.Zone region := framework.TestContext.CloudConfig.Region

return fmt.Errorf("error writing to %q: %v", filePath, err) } } else { <del> framework.Logf("nnTest Suite Metrics:n%snn", metricsJSON) </del> <ins> framework.Logf("nnTest Suite Metrics:n%sn", metricsJSON) </ins> } return nil

pollingFunction := checkForAcceleratorMetrics(projectId, gcmService, time.Now(), metricsMap) err = wait.Poll(pollFrequency, pollTimeout, pollingFunction) if err != nil { <del> framework.Logf("Missing metrics: %+vn", metricsMap) </del> <ins> framework.Logf("Missing metrics: %+v", metricsMap) </ins> } framework.ExpectNoError(err) }

// Get all the zones that the nodes are in expectedZones, err := gceCloud.GetAllZonesFromCloudProvider() Expect(err).NotTo(HaveOccurred()) <del> framework.Logf("Expected zones: %vn", expectedZones) </del> <ins> framework.Logf("Expected zones: %v", expectedZones) </ins> // Get all the zones in this current region region := gceCloud.Region()

}, }) Expect(err).NotTo(HaveOccurred()) <del> framework.Logf("Running containers:n") </del> <ins> framework.Logf("Running containers:") </ins> for _, c := range containers { <del> framework.Logf("%+vn", c) </del> <ins> framework.Logf("%+v", c) </ins> } } })

// Here we set API QPS limit from default 5 to 60 in order to test real Kubelet performance. // Note that it will cause higher resource usage. tempSetCurrentKubeletConfig(f, func(cfg *kubeletconfig.KubeletConfiguration) { <del> framework.Logf("Old QPS limit is: %dn", cfg.KubeAPIQPS) </del> <ins> framework.Logf("Old QPS limit is: %d", cfg.KubeAPIQPS) </ins> // Set new API QPS limit cfg.KubeAPIQPS = int32(itArg.APIQPSLimit) })
Change:
This issue is here to satisfy PR requirements of issue association. A lot of times we need to do version bumps for minor bug fixes that don't deserve a separate issue in the kubernetes/kubernetes repo. /kind bug /sig node
/lifecycle frozen
all the linked PRs are emrged and no activity since more than 3 years /close
Closing this issue. <detailsIn response to : all the linked PRs are emrged and no activity since more than 3 years /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
hostPath: path: /dev containers: <del> - image: "gcr.io/google-containers/nvidia-gpu-device-plugin@sha256:5e3837c3ab99e90d4c19053998ad86239591de4264bc177faad75642b64b723d" </del> <ins> - image: "gcr.io/google-containers/nvidia-gpu-device-plugin@sha256:0e79da6998a61257585e0d3fb5848240129f0fa5b4ad972dfed4049448093c33" </ins> command: ["/usr/bin/nvidia-gpu-device-plugin", "-logtostderr"] name: nvidia-gpu-device-plugin resources:
Change:
This issue is here to satisfy PR requirements of issue association. A lot of times we need to do version bumps for minor bug fixes that don't deserve a separate issue in the kubernetes/kubernetes repo. /kind bug /sig node
/lifecycle frozen
all the linked PRs are emrged and no activity since more than 3 years /close
Closing this issue. <detailsIn response to : all the linked PRs are emrged and no activity since more than 3 years /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
framework.Logf("Cluster is running on COS. Proceeding with test") if f.BaseName == "device-plugin-gpus" { <del> dsYamlUrl = "https://raw.githubusercontent.com/GoogleCloudPlatform/container-engine-accelerators/master/daemonset.yaml" </del> <ins> dsYamlUrl = "https://raw.githubusercontent.com/GoogleCloudPlatform/container-engine-accelerators/k8s-1.9/daemonset.yaml" </ins> gpuResourceName = framework.NVIDIAGPUResourceName podCreationFunc = makeCudaAdditionDevicePluginTestPod } else {
Change:
This issue is here to satisfy PR requirements of issue association. A lot of times we need to do version bumps for minor bug fixes that don't deserve a separate issue in the kubernetes/kubernetes repo. /kind bug /sig node
/lifecycle frozen
all the linked PRs are emrged and no activity since more than 3 years /close
Closing this issue. <detailsIn response to : all the linked PRs are emrged and no activity since more than 3 years /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
- key: cloud.google.com/gke-accelerator operator: Exists tolerations: <del> - key: "nvidia.com/gpu" </del> <ins> - operator: "Exists" effect: "NoExecute" - operator: "Exists" </ins> effect: "NoSchedule" <del> operator: "Exists" </del> hostNetwork: true hostPID: true volumes:
Change:
This issue is here to satisfy PR requirements of issue association. A lot of times we need to do version bumps for minor bug fixes that don't deserve a separate issue in the kubernetes/kubernetes repo. /kind bug /sig node
/lifecycle frozen
all the linked PRs are emrged and no activity since more than 3 years /close
Closing this issue. <detailsIn response to : all the linked PRs are emrged and no activity since more than 3 years /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
<del> apiVersion: extensions/v1beta1 </del> <ins> apiVersion: apps/v1 </ins> kind: DaemonSet metadata: name: nvidia-gpu-device-plugin

k8s-app: nvidia-gpu-device-plugin addonmanager.kubernetes.io/mode: Reconcile spec: <ins> selector: matchLabels: k8s-app: nvidia-gpu-device-plugin </ins> template: metadata: labels:

mountPath: /device-plugin - name: dev mountPath: /dev <ins> updateStrategy: type: RollingUpdate </ins>
Change:
Is this a BUG REPORT or FEATURE REQUEST?: Bug report /kind bug What happened: I'm following the directions to run the sample controller on When running it as directed, it gives these errors: E1214 10:34:25. ] Failed to list v1alpha1.Foo: v1.ListOptions is not suitable for converting to "" E1214 10:34:26. ] Failed to list v1alpha1.Foo: v1.ListOptions is not suitable for converting to "" What you expected to happen: Not to generate these errors. How to reproduce it (as minimally and precisely as possible): 1) Have a working kube config. 2) checkout kubernetes/sample-controller 3) run it: Anything else we need to know?: Environment: Kubernetes version (use ): Client Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.6", GitCommit:"", GitTreeState:"clean", BuildDate:"2017-09-14T06:55:55Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"9+", GitVersion:"v1.9.0-alpha.0.845+-dirty", GitCommit:"", GitTreeState:"dirty", BuildDate:"2017-10-02T22:37:04Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"} Cloud provider or hardware configuration: GKE OS (e.g. from /etc/os-release): my workstation is 14.04.5 LTS, Trusty Tahr Kernel (e.g. ): my workstation kernel is 4.4.0-96-generic Install tools: Others: go version 1.9
cc - Hi, it looks like you checked this in with . What all do I need to do to get this to work?
/sig api-machinery
Hey - thanks for this report. I'm not sure how, but we were missing an extra line in I've put in to resolve this (and it's working for me now :tada:)

Discussion:
package v1alpha1 import ( <ins> metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" </ins> "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime/schema"

&Foo{}, &FooList{}, ) <ins> metav1.AddToGroupVersion(scheme, SchemeGroupVersion) </ins> return nil }
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: Currently when run kubectl create with --raw, it will raise "--raw cannot read from a url " if the filename has a prefix "http", which is not proper as we may have filenames like "httptest" or similar. What you expected to happen: Restrict the url check with "https://" or "http://" prefix. How to reproduce it (as minimally and precisely as possible): Run 'kubectl create --raw URI -f' with a filename which has a "http" prefix.
/sig cli
--raw should start with
the message could be improved, but I think the check is reasonable (I'd actually change it to error if the raw path doesn't start with )
This is the filename url check, not the raw path. I think you mean this

Discussion:
if len(o.FilenameOptions.Filenames) != 1 { return cmdutil.UsageErrorf(cmd, "--raw can only use a single local file or stdin") } <del> if strings.HasPrefix(o.FilenameOptions.Filenames[0], "http") { </del> <ins> if strings.Index(o.FilenameOptions.Filenames[0], "http://") == 0 || strings.Index(o.FilenameOptions.Filenames[0], "https://") == 0 { </ins> return cmdutil.UsageErrorf(cmd, "--raw cannot read from a url") } if o.FilenameOptions.Recursive {
Change:
/kind bug What happened: During pod teardown, we sometimes see the following error-level kubelet logs: What you expected to happen: Clean pod shutdown, no error-level logs. How to reproduce it (as minimally and precisely as possible): We've got two kube crons that run every minute, across 12 regions in production -- so related pods daily -- and we see this about 3-12 times per day. Anything else we need to know?: Relevant kubelet log context of a cron pod that manifested this error: Controller manager for the pod: Scheduler for the pod: Cron yaml: Environment: Kubernetes version (use ):Cloud provider or hardware configuration: Bare metal OS (e.g. from /etc/os-release): 16.04.1 LTS (Xenial Xerus) Kernel (e.g. ): 4.4.0-89-generic -Ubuntu Install tools: N/A Others: N/A
/sig network
Same problem here. Every time I try to of my deploy, the old pod cannot be terminated successfully. below is output of
Have you checked the ns net files of those failed-to-deleted pods? /cc Could we just ignore these errors?
Sorry, yeah, that seems like a fair point to note -- the directories are in fact being deleted. Seems like it's either functionally succeeding yet generating error-level logs, or perhaps generating error-level logs and then succeeding on internal retry.
I prefer the later one. Perhaps kubelet does not kill the pod completely at the first time. Such error may occur during a retry.
So this is just an overly scary log message?
Yes, I think so. In the first attempt to delete the pod, the ns network file has already been deleted. But the pod does not get deleted successfully. Then "no such file or directory" will be raised in the second attempt.

Discussion:
netConf, cniNet := network.NetworkConfig, network.CNIConfig glog.V(4).Infof("About to del CNI network %v (type=%v)", netConf.Name, netConf.Plugins[0].Network.Type) err = cniNet.DelNetworkList(netConf, rt) <del> if err != nil { </del> <ins> // The pod may not get deleted successfully at the first time. // Ignore "no such file or directory" error in case the network has already been deleted in previous attempts. if err != nil && !strings.Contains(err.Error(), "no such file or directory") { </ins> glog.Errorf("Error deleting network: %v", err) return err }

} glog.V(3).Infof("Removing %s/%s from '%s' with CNI '%s' plugin and runtime: %+v", namespace, name, config.Network.Name, config.Network.Type, rt) <del> if err := plugin.cniConfig.DelNetwork(config, rt); err != nil { </del> <ins> err = plugin.cniConfig.DelNetwork(config, rt) // The pod may not get deleted successfully at the first time. // Ignore "no such file or directory" error in case the network has already been deleted in previous attempts. if err != nil && !strings.Contains(err.Error(), "no such file or directory") { </ins> return fmt.Errorf("Error removing container from network: %v", err) } return nil
Change:
helps but is not enough for the fix. After , I saw another failure: https://k8s- Before, all test after Aggregator test would fail. Now all tests before/after Aggregator tests are passing. However, during the Aggregator test waiting for namespace cleanup (10 min until timeout), all the other tests are failing. The reason is that, s run in LIFO order, s run in FIFO order. inserts an function to do namespace cleanup. In the current code, the namespace cleanup is inserted by before , it means that the test will try to delete namespace first, and then cleanup the api service. However, as known to us, if api service is not cleaned up, namespace deletion will wait forever.

Discussion:
var ns string var c clientset.Interface var aggrclient *aggregatorclient.Clientset <ins> // BeforeEachs run in LIFO order, AfterEachs run in FIFO order. // We want cleanTest to happen before the namespace cleanup AfterEach // inserted by NewDefaultFramework, so we put this AfterEach in front // of NewDefaultFramework. AfterEach(func() { cleanTest(c, aggrclient, ns) }) </ins> f := framework.NewDefaultFramework("aggregator") <ins> // We want namespace initialization BeforeEach inserted by // NewDefaultFramework to happen before this, so we put this BeforeEach // after NewDefaultFramework. </ins> BeforeEach(func() { c = f.ClientSet ns = f.Namespace.Name aggrclient = f.AggregatorClient }) <del> AfterEach(func() { cleanTest(c, aggrclient, ns) }) </del> It("Should be able to support the 1.7 Sample API Server using the current Aggregator", func() { // Make sure the relevant provider supports Agggregator framework.SkipUnlessServerVersionGTE(serverAggregatorVersion, f.ClientSet.Discovery())