jiebi/CodeConvo huggingface dataset:
Change:
No response No response_ /cc
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig network /sig cloud-provider
Fun. Are these test executed with special arguments or similar when running in CI? This is locally on master for me on my laptop:
This is currently blocking 1.29 beta.0 release cut. Do you think this is a release blocker? If yes, then can you please give an estimated time for fix? Thanks!
No, I don't think this is a release blocker. The problem is the test, not the implementation. The PR I have up should de-flake the test and fix the issue.
Thanks a lot for confirming
This is now the top flaking test in " service": 11,
ping
The PR fixing this is still not approved by the corresponding SIG, yet (ref ).
/assign This controller is really more sig-network than cloud provider :)
we discussed this at the sig cloud provider meeting today, but will need more time to investigate.
seeing this frequently in and in downstream CI unit test runs
should we revert if we cannot fix the test that came in with it? are we sure that PR didn't introduce a bug?
unit tests must not be flaky ... we either need to prioritize fixing of the flake (either the open PR or an alternative), or back out the change that brought in the flaky test. looks low risk to me and consistent with needing to wait for an informer to sync before the test will be deterministic

Discussion:
"k8s.io/apimachinery/pkg/types" "k8s.io/apimachinery/pkg/util/intstr" "k8s.io/apimachinery/pkg/util/sets" <ins> "k8s.io/apimachinery/pkg/util/wait" </ins> utilfeature "k8s.io/apiserver/pkg/util/feature" "k8s.io/client-go/informers" "k8s.io/client-go/kubernetes/fake"

t.Fatalf("error creating node3, err: %v", err) } <ins> // Allow a bit of time for the informer cache to get populated with the new // node if err := wait.PollUntilContextCancel(wait.ContextForChannel(stopCh), 10*time.Millisecond, true, func(ctx context.Context) (done bool, err error) { n3, _ := controller.nodeLister.Get("node3") return n3 != nil, nil }); err != nil { t.Fatalf("informer cache was never populated with node3") } </ins> // Sync the service if err := controller.syncService(context.TODO(), key); err != nil { t.Fatalf("unexpected service sync error, err: %v", err)
Change:
schedulingCycle only reports algorithmduration when it's a successful scheduling attempt: Also report scheduling algorithm latency when the pods is unschedulable Create a Pod that is unschedulable (perhaps node selector for a node that doesn't exist) and observe metrics No response <detailsANY </details<detailsANY </details<details</details<details</details<details</details<details</details
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig scheduling
/assign
let me try

Discussion:
pod := podInfo.Pod scheduleResult, err := sched.SchedulePod(ctx, fwk, state, pod) if err != nil { <ins> defer func() { metrics.SchedulingAlgorithmLatency.Observe(metrics.SinceInSeconds(start)) }() </ins> if err == ErrNoNodesAvailable { status := framework.NewStatus(framework.UnschedulableAndUnresolvable).WithError(err) return ScheduleResult{nominatingInfo: clearNominatedNode}, podInfo, status
Change:
under kubetest.Up Nov 22 2023, last 7 runs failed No response /sig
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
APIServer failed for
Yes it is failing for me too!
/sig testing
the generator config source must include the env to handle the "external" provider deprecation: /sig cloud-provider /area provider/gcp
/remove-sig testing /sig release
all other jobs seem green in the 1.29 blocking/informing, post that change. i will try sending a PR for this, but you need to find a non-USA approver if you want it merged before Monday. /assign
never mind, the generator is giving me errors: /unassign
/cc

Discussion:
if [[ -z "${KUBE_USER:-}" || -z "${KUBE_PASSWORD:-}" ]]; then gen-kube-basicauth fi <ins> # Make sure they don't contain any funny characters. if ! [[ "${KUBE_USER}" =~ ^[-._@a-zA-Z0-9]+$ ]]; then echo "Bad KUBE_USER string." exit 1 fi if ! [[ "${KUBE_PASSWORD}" =~ ^[-._@#%/a-zA-Z0-9]+$ ]]; then echo "Bad KUBE_PASSWORD string." exit 1 fi </ins> } function load-or-gen-kube-bearertoken() {

if [[ -n "${KUBE_USER:-}" ]]; then local -r abac_policy_json="${src_dir}/abac-authz-policy.jsonl" remove-salt-config-comments "${abac_policy_json}" <del> sed -i -e "s@{{kube_user}}@${KUBE_USER}@g" "${abac_policy_json}" </del> <ins> sed -i -e "s/{{kube_user}}/${KUBE_USER}/g" "${abac_policy_json}" </ins> cp "${abac_policy_json}" /etc/srv/kubernetes/ fi

fi source "${KUBE_HOME}/kube-env" <ins> if [[ -n "${KUBE_USER:-}" ]]; then if ! [[ "${KUBE_USER}" =~ ^[-._@a-zA-Z0-9]+$ ]]; then echo "Bad KUBE_USER format." exit 1 fi fi </ins> config-ip-firewall create-dirs ensure-local-ssds
Change:
[x] two weeks soak end date : 14 Mar 2024 : According to following APIsnoop query, there are six VolumeAttachment endpoints that are untested. Using a number of existing e2e test practices a new has been created to provide future Conformance coverage for the 7 endpoints. The e2e logs for this test are listed below. This query shows the following VolumeAttachment endpoints are hit within a short period of running this e2e test. If a test with these calls gets merged, test coverage will go up by 7 points This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue as fresh with Close this issue with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:
/remove-lifecycle stale
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
- createCoreV1NamespacedServiceAccountToken - createCoreV1Node - createStorageV1CSINode <del> - createStorageV1VolumeAttachment </del> - deleteCoreV1Node - deleteStorageV1CollectionCSINode <del> - deleteStorageV1CollectionVolumeAttachment </del> - deleteStorageV1CSINode <del> - deleteStorageV1VolumeAttachment </del> - getInternalApiserverAPIGroup - getResourceAPIGroup - listStorageV1CSINode <del> - listStorageV1VolumeAttachment </del> - patchStorageV1CSINode <del> - patchStorageV1VolumeAttachment </del> - patchStorageV1VolumeAttachmentStatus - readStorageV1CSINode <del> - readStorageV1VolumeAttachment </del> - readStorageV1VolumeAttachmentStatus - replaceStorageV1CSINode <del> - replaceStorageV1VolumeAttachment </del> - replaceStorageV1VolumeAttachmentStatus
Change:
When a scheduling gated pod is ungated, the condition's is consistently null until the pod is scheduled: Pods without a scheduling gate have the same condition but is populated: Submit a pod with a scheduling gate. Observe that after removal of the gate, the pod condition. I uncovered this while using Kueue and the ProvisioningRequest feature. Since this is reproducible with just the scheduling gate, I think k/k is the right project for the issue. <details</details<detailsGCP </details<details</details<details</details<details</details<details</details
/cc
/sig scheduling
When the pod is gated, what's the condition of the Pod? Is it empty?
The gated pod has just this condition. The transition time is also null, but is that expected since it is the first condition?
/triage accepted
The bug is here: It looks like at this point, the ObjectMeta.CreationTimestamp is already populated. We should copy that field.
/assign
Are you still on this, we meet the same problem.
It's been over a month, I assume you might no longer work on this? We encounter the same bug and hope this bug can be fixed as soon as possible(hopefully next release). Since there is no further update on this issue, I am proposing a protential fix on now, can you assign this issue to me and review the code once you are available? Thanks.
/unassign ahaysx /assign royliang
GitHub didn't allow me to assign the following users: royliang. Note that only with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /unassign ahaysx /assign royliang Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
Sorry I have been on vacation until today. Thanks for the fix
are you still working on this?
I’ve submitted the PR, but it seems lack of reviewer moving this forward.

Discussion:
} } <del> pod.Status.Conditions = append(pod.Status.Conditions, api.PodCondition{ </del> <ins> podutil.UpdatePodCondition(&pod.Status, &api.PodCondition{ </ins> Type:    api.PodScheduled, Status:  api.ConditionFalse, Reason:  apiv1.PodReasonSchedulingGated,

} } <del> if diff := cmp.Diff(tt.want, got); diff != "" { </del> <ins> if got.LastTransitionTime.IsZero() && got.Type != "" { t.Errorf("unexpected empty LastTransitionTime in condition") } if diff := cmp.Diff(tt.want, got, cmpopts.IgnoreFields(api.PodCondition{}, "LastTransitionTime")); diff != "" { </ins> t.Errorf("unexpected field errors (-want, +got):n%s", diff) } })
Change:
A pod that uses in-tree vSphere volume never starts in Kubernetes 1.29.0. Such pod should start as usual. See above Feature gate removal deleted that vSphere volumes are migrated to CSI. So the CSI volume plugin ignores in-tree vSphere volumes and does not translate them to CSI. <details</details<details</details<details</details<details</details<details</details<details</details
/sig storage /priority important-soon /triage accepted /assign
cc have you ever tested with CSI migration?
/assign
I already have a PR:

Discussion:
csitranslationplugins.AzureFileInTreePluginName: func() bool { return utilfeature.DefaultFeatureGate.Enabled(features.CSIMigrationAzureFile) }, <ins> csitranslationplugins.VSphereInTreePluginName: func() bool { return true }, </ins> csitranslationplugins.PortworxVolumePluginName: func() bool { return utilfeature.DefaultFeatureGate.Enabled(features.CSIMigrationPortworx) },
Change:
/metrics/slis was for several components (apiserver, kube-controller-manager, kube-scheduler, kubelet, cloud-controller-manager) in This is to propose adding metric to these components for /metrics/slis to support cumulative metric Missing start time metric in metrics/slis will result in inaccurate cumulative metrics. Even though the start time metric is available in /metrics, it requires the metrics collector to scrape two endpoints at once and sync them to prepare the cumulative metric data.
/sig instrumentation
/assign cc /triage accepted
I just ran into an issue related to this change while adding scrapers to /metrics/slis in kube-prometheus The components /metrics and /metrics/slis endpoints are supposed to be scraped together, but at different intervals and this is really possible anymore since we the metric to the /metric/slis endpoint since now both endpoints are exposing the same metric which causes a conflict when scraped by Prometheus. Instead of exposing the metric inside of the endpoint, I think we should rather expect users to correlate the metric with the process start time metric from the endpoint. Because otherwise, we have to explicitly drop the metric at scrape time from the SLI endpoint in order to avoid conflicts.
We can't not include it, what if people opt only to scrape ?
That's a fair point, but do we really need to make use of the cumulative metric? Computing an error rate from it shouldn't require a start time, and even in the event of a restart, it should be transparent to the computation of the rate.
Yes, you need process-start-time in order to know when a process has restarted otherwise a cumulative metric could be (1) not cumulative going from 2 -1, (2) be cumulative but not measured as such if you measure 1 at process-start-time A, and then you measure 1 again at process-start-time B, but you ignore process-start-times.

Discussion:
func Register(registry k8smetrics.KubeRegistry) { registry.Register(healthcheck) registry.Register(healthchecksTotal) <ins> _ = k8smetrics.RegisterProcessStartTime(registry.Register) </ins> } func ResetHealthMetrics() {
Change:
updated the automatic reloading logic from file watch to polling. This change in behavior needs to be documented [ ] Update the v1.29 release notes to call out this change in behavior (ref: ) to replace references to file watch with polling. /sig auth /triage accepted /assign nilekhc

Discussion:
var addressType v1.NodeAddressType if strings.HasPrefix(i.HardwareAddr.String(), MAC_OUI_VC) || strings.HasPrefix(i.HardwareAddr.String(), MAC_OUI_ESX) { <del> addressType = v1.NodeExternalIP } else { addressType = v1.NodeInternalIP </del> <ins> v1.AddToNodeAddresses(&addrs, v1.NodeAddress{ Type:    v1.NodeExternalIP, Address: ipnet.IP.String(), }, v1.NodeAddress{ Type:    v1.NodeInternalIP, Address: ipnet.IP.String(), }, ) </ins> } <del> v1.AddToNodeAddresses(&addrs, v1.NodeAddress{ Type:    addressType, Address: ipnet.IP.String(), }, ) </del> glog.V(4).Infof("Find local IP address %v and set type to %v", ipnet.IP.String(), addressType) } }

// retrieve VM's ip(s) for _, v := range mvm.Guest.Net { <del> var addressType v1.NodeAddressType </del> if vs.cfg.Network.PublicNetwork == v.Network { <del> addressType = v1.NodeExternalIP } else { addressType = v1.NodeInternalIP } for _, ip := range v.IpAddress { if net.ParseIP(ip).To4() != nil { v1.AddToNodeAddresses(&addrs, v1.NodeAddress{ Type:    addressType, Address: ip, }, ) </del> <ins> for _, ip := range v.IpAddress { if net.ParseIP(ip).To4() != nil { v1.AddToNodeAddresses(&addrs, v1.NodeAddress{ Type:    v1.NodeExternalIP, Address: ip, }, v1.NodeAddress{ Type:    v1.NodeInternalIP, Address: ip, }, ) } </ins> } } }
Change:
The link in the following sentence is incorrect macOS Install Docker for Mac. See installation instructions . It redirects to instead of The link should get redirected to Navigate to Click on the hyperlink in the below section macOS Install Docker for Mac. See installation instructions . N/A N/A N/A N/A N/A N/A N/A
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
/sig contributor-experience

Discussion:
## Requirements 1. Docker, using one of the following configurations: <del> * **macOS** Install Docker for Mac. See installation instructions [here](https://docs.docker.com/docker-for-mac/). </del> <ins> * **macOS** Install Docker for Mac. See installation instructions [here](https://docs.docker.com/desktop/install/mac-install/). </ins> **Note**: You will want to set the Docker VM to have at least 8GB of initial memory or building will likely fail. (See: [#11852]( http://issue.k8s.io/11852)). * **Linux with local Docker**  Install Docker according to the [instructions](https://docs.docker.com/installation/#installation) for your OS. * **Windows with Docker Desktop WSL2 backend**  Install Docker according to the [instructions](https://docs.docker.com/docker-for-windows/wsl-tech-preview/). Be sure to store your sources in the local Linux file system, not the Windows remote mount at `/mnt/c`.
Change:
after was merged It seems to be related to the machine type. /cc /sig scalability k8s-infra
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/cc
I'll fix this now

Discussion:
set -o errexit set -o nounset <del> set -o pipefailscript_dir=$(cd $(dirname "${BASH_SOURCE}") && pwd -P) </del> <ins> set -o pipefail script_dir=$(cd $(dirname "${BASH_SOURCE}") && pwd -P) </ins> cd "${script_dir}"
Change:
<img width="844" alt="image" src="" <img width="942" alt="image" src="" Here are some incorrect comments and function name about SchedulingGated Comments and function names need to be changed to SchedulingGated nothing No response <details</details<details</details<details</details<details</details<details</details<details</details
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
/sig scheduling
/remove-kind bug /kind cleanup

Discussion:
reason = pod.Status.Reason } <del> // If the Pod carries {type:PodScheduled, reason:WaitingForGates}, set reason to 'SchedulingGated'. </del> <ins> // If the Pod carries {type:PodScheduled, reason:SchedulingGated}, set reason to 'SchedulingGated'. </ins> for _, condition := range pod.Status.Conditions { if condition.Type == api.PodScheduled && condition.Reason == apiv1.PodReasonSchedulingGated { reason = apiv1.PodReasonSchedulingGated

[]metav1.TableRow{{Cells: []interface{}{"test14", "2/2", "Running", "9 (5d ago)", "<unknown>"}}}, }, { <del> // Test PodScheduled condition with reason WaitingForGates </del> <ins> // Test PodScheduled condition with reason SchedulingGated </ins> api.Pod{ ObjectMeta: metav1.ObjectMeta{Name: "test15"}, Spec:       api.PodSpec{Containers: make([]api.Container, 2)},

podutil.DropDisabledPodFields(pod, nil) <del> applyWaitingForSchedulingGatesCondition(pod) </del> <ins> applySchedulingGatedCondition(pod) </ins> mutatePodAffinity(pod) }

} } <del> // applyWaitingForSchedulingGatesCondition adds a {type:PodScheduled, reason:WaitingForGates} condition </del> <ins> // applySchedulingGatedCondition adds a {type:PodScheduled, reason:SchedulingGated} condition </ins> // to a new-created Pod if necessary. <del> func applyWaitingForSchedulingGatesCondition(pod *api.Pod) { </del> <ins> func applySchedulingGatedCondition(pod *api.Pod) { </ins> if !utilfeature.DefaultFeatureGate.Enabled(features.PodSchedulingReadiness) || len(pod.Spec.SchedulingGates) == 0 { return

} } <del> func TestWaitingForGatesCondition(t *testing.T) { </del> <ins> func TestSchedulingGatedCondition(t *testing.T) { </ins> tests := []struct { name           string pod            *api.Pod
Change:
The image is built as a legacy Schema 1 image and will not work with most runtimes soon: ref:
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig node
cc You seemed to have built the image from on 2016-06-24T22:29:32 , could you rebuild and push the image?
/sig testing
I actually ran into an issue with this one a few months ago. There was very little in the image for testing and I believe that pointed me to the new test images they are using. We found that this image was quite old and essentially unmaintained.
Where is the new image?
PR to merge stress to agnhost:
Next:

Discussion:
Containers: []v1.Container{ { Name:            ctnName, <del> Image:           "registry.k8s.io/stress:v1", </del> <ins> Image:           imageutils.GetE2EImage(imageutils.Agnhost), </ins> ImagePullPolicy: "Always", Env:             env, // 60 min timeout * 60s / tick per 10s = 360 ticks before timeout => ~11.11Mi/tick // to fill ~4Gi of memory, so initial ballpark 12Mi/tick. // We might see flakes due to timeout if the total memory on the nodes increases. <del> Args:      []string{"-mem-alloc-size", "12Mi", "-mem-alloc-sleep", "10s", "-mem-total", memLimit}, </del> <ins> Args:      []string{"stress", "--mem-alloc-size", "12Mi", "--mem-alloc-sleep", "10s", "--mem-total", memLimit}, </ins> Resources: res, }, },

var NodePrePullImageList = sets.NewString( imageutils.GetE2EImage(imageutils.Agnhost), "gcr.io/cadvisor/cadvisor:v0.47.2", <del> "registry.k8s.io/stress:v1", </del> busyboxImage, "registry.k8s.io/e2e-test-images/busybox@sha256:a9155b13325b2abef48e71de77bb8ac015412a566829f621d06bfae5c699b1b9", imageutils.GetE2EImage(imageutils.Nginx),

func initImageConfigs(list RegistryList) (map[ImageID]Config, map[ImageID]Config) { configs := map[ImageID]Config{} <del> configs[Agnhost] = Config{list.PromoterE2eRegistry, "agnhost", "2.45"} </del> <ins> configs[Agnhost] = Config{list.PromoterE2eRegistry, "agnhost", "2.47"} </ins> configs[AgnhostPrivate] = Config{list.PrivateRegistry, "agnhost", "2.6"} configs[AuthenticatedAlpine] = Config{list.GcAuthenticatedRegistry, "alpine", "3.7"} configs[AuthenticatedWindowsNanoServer] = Config{list.GcAuthenticatedRegistry, "windows-nanoserver", "v1"}