Change:
<!-- Please only use this template for submitting enhancement requests --What would you like to be : We should come up with a better name for : Why is this needed: From /sig testing /priority important-soon /cleanup /help /good-first-issue
This request has been marked as suitable for new contributors. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : <!-- Please only use this template for submitting enhancement requests --We should come up with a better name for : From /priority important-soon /cleanup /help /good-first-issue Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
I'd like to help out with this. /assign
mind. It seems like you have a PR for it already. /unassign
And I misread the changes you made in . I'm back on this one. /assign
I'm going to rename this to . Please let me know if there are any objections or if there are things that I should be considering.
please feel free to take it. I'm only changing ImageWhileList withint
ultimately was changed to NodePrePullImageList because that's what it's actually used for, not for any sort of filtering.

Discussion:
ginkgo.Context("when running a container with a new image", func() { <del> // Images used for ConformanceContainer are not added into NodeImageWhiteList, because this test is </del> <ins> // Images used for ConformanceContainer are not added into NodePrePullImageList, because this test is </ins> // testing image pulling, these images don't need to be prepulled. The ImagePullPolicy <del> // is v1.PullAlways, so it won't be blocked by framework image white list check. </del> <ins> // is v1.PullAlways, so it won't be blocked by framework image pre-pull list check. </ins> imagePullTest := func(image string, hasSecret bool, expectedPhase v1.PodPhase, expectedPullStatus bool, windowsImage bool) { command := []string{"/bin/sh", "-c", "while true; do sleep 1; done"} if windowsImage {

// in the test anyway. continue } <del> // If the image policy is not PullAlways, the image must be in the white list and </del> <ins> // If the image policy is not PullAlways, the image must be in the pre-pull list and </ins> // pre-pulled. <del> gomega.Expect(ImageWhiteList.Has(c.Image)).To(gomega.BeTrue(), "Image %q is not in the white list, consider adding it to CommonImageWhiteList in test/e2e/common/util.go or NodeImageWhiteList in test/e2e_node/image_list.go", c.Image) // Do not pull images during the tests because the images in white list should have </del> <ins> gomega.Expect(ImageWhiteList.Has(c.Image)).To(gomega.BeTrue(), "Image %q is not in the white list, consider adding it to CommonImageWhiteList in test/e2e/common/util.go or NodePrePullImageList in test/e2e_node/image_list.go", c.Image) // Do not pull images during the tests because the images in pre-pull list should have </ins> // been prepulled. c.ImagePullPolicy = v1.PullNever }

imagePullRetryDelay = time.Second ) <del> // NodeImageWhiteList is a list of images used in node e2e test. These images will be prepulled </del> <ins> // NodePrePullImageList is a list of images used in node e2e test. These images will be prepulled </ins> // before test running so that the image pulling won't fail in actual test. <del> var NodeImageWhiteList = sets.NewString( </del> <ins> var NodePrePullImageList = sets.NewString( </ins> imageutils.GetE2EImage(imageutils.Agnhost), "google/cadvisor:latest", "k8s.gcr.io/stress:v1",

// 2. the ones passed in from framework.TestContext.ExtraEnvs // So this function needs to be called after the extra envs are applied. func updateImageWhiteList() { <del> // Union NodeImageWhiteList and CommonImageWhiteList into the framework image white list. framework.ImageWhiteList = NodeImageWhiteList.Union(commontest.CommonImageWhiteList) </del> <ins> // Union NodePrePullImageList and CommonImageWhiteList into the framework image pre-pull list. framework.ImageWhiteList = NodePrePullImageList.Union(commontest.CommonImageWhiteList) </ins> // Images from extra envs framework.ImageWhiteList.Insert(getNodeProblemDetectorImage()) framework.ImageWhiteList.Insert(getSRIOVDevicePluginImage())

} } }` <del> // The following images are not added into NodeImageWhiteList, because this test is </del> <ins> // The following images are not added into NodePrePullImageList, because this test is </ins> // testing image pulling, these images don't need to be prepulled. The ImagePullPolicy <del> // is v1.PullAlways, so it won't be blocked by framework image white list check. </del> <ins> // is v1.PullAlways, so it won't be blocked by framework image pre-pull list check. </ins> for _, testCase := range []struct { description string image       string