Change:
used to show masters, but as of it no longer does. This is not in accordance with our deprecation policy I believe. cc
That commit/PR is not relevant as there are no supported users/deployment methods that are using label. kubeadm v1.4 or v1.5 was the last. What you're really looking for is who/what removed printing things based on the label...
No blame on you The regression is that we have stopped printing masters in . There may be more to it that a simple revert of , but we should probably start there.
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. Prevent issues from auto-closing with an comment. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
This has been fixed in recent versions

Discussion:
"doc.go", "register.go", "types.go", <ins> "well_known_labels.go", </ins> "zz_generated.deepcopy.go", ], tags = ["automanaged"],

<ins> /* Copyright 2017 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package kubeadm // Role labels are applied to Nodes to mark their purpose.  In particular, we // usually want to distinguish the master, so that we can isolate privileged // pods and operations. // // Originally we relied on not registering the master, on the fact that the // master was Unschedulable, and on static manifests for master components. // But we now do register masters in many environments, are generally moving // away from static manifests (for better manageability), and working towards // deprecating the unschedulable field (replacing it with taints & tolerations // instead). // // Even with tainting, a label remains the easiest way of making a positive // selection, so that pods can schedule only to master nodes for example, and // thus installations will likely define a label for their master nodes. // // So that we can recognize master nodes in consequent places though (such as // kubectl get nodes), we encourage installations to use the well-known labels. // We define NodeLabelRole, which is the preferred form, but we will also recognize // other forms that are known to be in widespread use (NodeLabelKubeadmAlphaRole). const ( // NodeLabelKubeadmAlphaRole is a label that kubeadm applies to a Node as a hint that it has a particular purpose. // Use of NodeLabelRole is preferred. NodeLabelKubeadmAlphaRole = "kubeadm.alpha.kubernetes.io/role" ) </ins>

], tags = ["automanaged"], deps = [ <ins> "//cmd/kubeadm/app/apis/kubeadm:go_default_library", </ins> "//federation/apis/federation:go_default_library", "//federation/apis/federation/v1beta1:go_default_library", "//federation/client/clientset_generated/federation_clientset:go_default_library",

return tabbedString(func(out io.Writer) error { w := NewPrefixWriter(out) w.Write(LEVEL_0, "Name:t%sn", node.Name) <ins> w.Write(LEVEL_0, "Role:t%sn", findNodeRole(node)) </ins> printLabelsMultiline(w, "Labels", node.Labels) printAnnotationsMultiline(w, "Annotations", node.Annotations) printNodeTaintsMultiline(w, "Taints", node.Spec.Taints)

"k8s.io/apimachinery/pkg/labels" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/util/sets" <ins> "k8s.io/kubernetes/cmd/kubeadm/app/apis/kubeadm" </ins> "k8s.io/kubernetes/federation/apis/federation" "k8s.io/kubernetes/pkg/api" "k8s.io/kubernetes/pkg/api/events"

if obj.Spec.Unschedulable { status = append(status, "SchedulingDisabled") } <ins> role := findNodeRole(obj) if role != "" { status = append(status, role) } </ins> row.Cells = append(row.Cells, obj.Name, strings.Join(status, ","), translateTimestamp(obj.CreationTimestamp), obj.Status.NodeInfo.KubeletVersion) if options.Wide {

return "<none>" } <ins> // findNodeRole returns the role of a given node, or "" if none found. // The role is determined by looking in order for: // * a kubernetes.io/role label // * a kubeadm.alpha.kubernetes.io/role label // If no role is found, ("", nil) is returned func findNodeRole(node *api.Node) string { if role := node.Labels[kubeadm.NodeLabelKubeadmAlphaRole]; role != "" { return role } // No role found return "" } </ins> func printNodeList(list *api.NodeList, options printers.PrintOptions) ([]metav1alpha1.TableRow, error) { rows := make([]metav1alpha1.TableRow, 0, len(list.Items)) for i := range list.Items {

}, status: "Unknown,SchedulingDisabled", }, <ins> { node: api.Node{ ObjectMeta: metav1.ObjectMeta{ Name:   "foo12", Labels: map[string]string{"kubeadm.alpha.kubernetes.io/role": "node"}, }, Status: api.NodeStatus{Conditions: []api.NodeCondition{{Type: api.NodeReady, Status: api.ConditionTrue}}}, }, status: "Ready,node", }, </ins> } for _, test := range table {