jiebi/CodeConvo huggingface dataset:
Change:
in e2enode test curls and directly pipes to shell: The issue is that this may present a supply chain security risk, as we are directly executing the script from I would instead expect one of the following: host includes docker already via it's OS image script is checked into this repo and version controlled script is at least verified to be unchanged via hash Running anything from - , such as: No response All GCP (kind of) N/A N/A N/A N/A
/sig node
that's some pretty old bash, I don't think we're actually using this in CI, probably that codepath can just be dropped, but up to the SIG node folks.
/triage accepted /priority backlog /assign
the script is being referred from the docs: I think the safest bet is to simply remove the docker installation part.

Discussion:
# - centos 7 # - debian jessie <del> # RHEL os detection cat /etc/*-release | grep "ID="rhel"" OS_RHEL=$? </del> # On a systemd environment, enable cpu and memory accounting for all processes by default. if [ -d /etc/systemd ]; then cat <<EOF >kubernetes-accounting.conf

fi # Install docker <del> if ! hash docker 2>/dev/null; then # RHEL platforms should always install from RHEL repository # This will install the latest supported stable docker platform on RHEL if [ $OS_RHEL -eq 0 ]; then sudo yum install -y docker-latest sudo groupadd docker sudo systemctl enable docker-latest.service sudo systemctl start docker-latest.service else curl -fsSL https://get.docker.com/ | sh sudo service docker start sudo systemctl enable docker.service fi </del> <ins> if ! hash containerd 2>/dev/null; then echo "Please install containerd, see the getting started guide here: https://github.com/containerd/containerd/blob/main/docs/getting-started.md" echo "For a docker CLI replacement, we suggest nerdctl: https://github.com/containerd/nerdctl#install" </ins> fi # Allow jenkins access to docker
Change:
ci-kubernetes-e2e-gce-iscsi-serial and ci-kubernetes-e2e-gce-iscsi I guess it is create cluster step not tests Not clear I guess may be From I guess it is releated to /sig storage
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
From I get I think there's a problem here.

Discussion:
cmds.AddCommand(NewCmdExplain(f, out)) cmds.AddCommand(NewCmdConvert(f, out)) <del> if cmds.Flag("namespace").Annotations == nil { cmds.Flag("namespace").Annotations = map[string][]string{} </del> <ins> if cmds.Flag("namespace") != nil { if cmds.Flag("namespace").Annotations == nil { cmds.Flag("namespace").Annotations = map[string][]string{} } cmds.Flag("namespace").Annotations[cobra.BashCompCustom] = append( cmds.Flag("namespace").Annotations[cobra.BashCompCustom], "__kubectl_get_namespaces", ) </ins> } <del> cmds.Flag("namespace").Annotations[cobra.BashCompCustom] = append( cmds.Flag("namespace").Annotations[cobra.BashCompCustom], "__kubectl_get_namespaces", ) </del> return cmds }
Change:
[x] test approval issue : [x] test pr : 7 July 2022 [X] two weeks soak end date : 21 July 2022 [X] test promotion pr : According to this APIsnoop query, there is still some remaining ResourceQuota endpoints which are untested. The Status endpoints will be addressed in another test. listCoreV1ResourceQuotaForAllNamespacespatchCoreV1NamespacedResourceQuotadeleteCoreV1CollectionNamespacedResourceQuota Using a number of existing e2e test practices a new has been created for three ResourceQuota endpoints. The e2e logs for this test are listed below. This query shows the endpoints hit within a short period of running the e2e test If a test with these calls gets merged, test coverage will go up by 3 points This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance
/triage accepted
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
MUST match to expected used and total allowed resource quota count within namespace. release: v1.16 file: test/e2e/apimachinery/resource_quota.go <ins> - testname: ResourceQuota, manage lifecycle of a ResourceQuota codename: '[sig-api-machinery] ResourceQuota should manage the lifecycle of a ResourceQuota [Conformance]' description: Attempt to create a ResourceQuota for CPU and Memory quota limits. Creation MUST be successful. Attempt to list all namespaces with a label selector which MUST succeed. One list MUST be found. The ResourceQuota when patched MUST succeed. Given the patching of the ResourceQuota, the fields MUST equal the new values. It MUST succeed at deleting a collection of ResourceQuota via a label selector. release: v1.25 file: test/e2e/apimachinery/resource_quota.go </ins> - testname: ResourceQuota, quota scope, BestEffort and NotBestEffort scope codename: '[sig-api-machinery] ResourceQuota should verify ResourceQuota with best effort scope. [Conformance]'

} }) <del> ginkgo.It("should manage the lifecycle of a ResourceQuota", func() { </del> <ins> /* Release: v1.25 Testname: ResourceQuota, manage lifecycle of a ResourceQuota Description: Attempt to create a ResourceQuota for CPU and Memory quota limits. Creation MUST be successful. Attempt to list all namespaces with a label selector which MUST succeed. One list MUST be found. The ResourceQuota when patched MUST succeed. Given the patching of the ResourceQuota, the fields MUST equal the new values. It MUST succeed at deleting a collection of ResourceQuota via a label selector. */ framework.ConformanceIt("should manage the lifecycle of a ResourceQuota", func() { </ins> client := f.ClientSet ns := f.Namespace.Name
Change:
[x] test approval issue : [x] test pr : [x] two weeks soak end date : 1 Aug 2022 [x] test promotion pr : According to this APIsnoop query, there is still some remaining NamespaceStatus endpoints which are untested. readCoreV1NamespaceStatuspatchCoreV1NamespaceStatus Using a number of existing e2e test practices a new has been created for 2 namespace status endpoints. The e2e logs for this test are listed below. This query shows the endpoints hit within a short period of running the e2e test If a test with these calls gets merged, test coverage will go up by 3 points This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance
/triage accepted
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
MUST cause pods created by that RC to be orphaned. release: v1.9 file: test/e2e/apimachinery/garbage_collector.go <ins> - testname: Namespace, apply changes to a namespace status codename: '[sig-api-machinery] Namespaces [Serial] should apply changes to a namespace status [Conformance]' description: Getting the current namespace status MUST succeed. The reported status phase MUST be active. Given the patching of the namespace status, the fields MUST equal the new values. Given the updating of the namespace status, the fields MUST equal the new values. release: v1.25 file: test/e2e/apimachinery/namespace.go </ins> - testname: namespace-deletion-removes-pods codename: '[sig-api-machinery] Namespaces [Serial] should ensure that all pods are removed when a namespace is deleted [Conformance]'

framework.ExpectEqual(namespace.ObjectMeta.Labels["testLabel"], "testValue", "namespace not patched") }) <del> ginkgo.It("should apply changes to a namespace status", func() { </del> <ins> /* Release: v1.25 Testname: Namespace, apply changes to a namespace status Description: Getting the current namespace status MUST succeed. The reported status phase MUST be active. Given the patching of the namespace status, the fields MUST equal the new values. Given the updating of the namespace status, the fields MUST equal the new values. */ framework.ConformanceIt("should apply changes to a namespace status", func() { </ins> ns := f.Namespace.Name dc := f.DynamicClient nsResource := v1.SchemeGroupVersion.WithResource("namespaces")
Change:
Windows GCE jobs: [sig-windows] [Feature:WindowsHostProcessContainers] [MinimumKubeletVersion:1.22] HostProcess containers should run as a process on the host/node [sig-windows] [Feature:WindowsHostProcessContainers] [MinimumKubeletVersion:1.22] HostProcess containers should support various volume mount types Since the jobs were reintroduced. Windows COMPUTERNAMEs are typically limited to 15 characters [1], while the kubelet nodes spawned in the GCE test jobs are much longer (e.g.: `). The names might be truncated, resulting in the test failure. [1] No response /sig windows /sig testing
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
dupe of /close
Closing this issue. <detailsIn response to : dupe of /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
Write-Output $c throw "Contents of /etc/secret/foo.txt are not as expected" } <del> if ($env:NODE_NAME_TEST -ne $env:COMPUTERNAME) { throw "NODE_NAME_TEST env var ($env:NODE_NAME_TEST) does not equal COMPUTERNAME ($env:COMPUTERNAME)" </del> <ins> # Windows ComputerNames cannot exceed 15 characters, which means that the $env:COMPUTERNAME # can only be a substring of $env:NODE_NAME_TEST. We compare it with the hostname instead. # The following comparison is case insensitive. if ($env:NODE_NAME_TEST -ine "$(hostname)") { throw "NODE_NAME_TEST env var ($env:NODE_NAME_TEST) does not equal hostname" </ins> } Write-Output "SUCCESS"` )

ginkgo.By("scheduling a pod with a container that verifies %COMPUTERNAME% matches selected node name") image := imageutils.GetConfig(imageutils.BusyBox) podName := "host-process-test-pod" <ins> // We're passing this to powershell.exe -Command. Inside, we must use apostrophes for strings. command := fmt.Sprintf(`& {if ('%s' -ine "$(hostname)") { exit -1 }}`, targetNode.Name) </ins> pod := &v1.Pod{ ObjectMeta: metav1.ObjectMeta{ Name: podName,

{ Image:   image.GetE2EImage(), Name:    "computer-name-test", <del> Command: []string{"cmd.exe", "/K", "IF", "NOT", "%COMPUTERNAME%", "==", targetNode.Name, "(", "exit", "-1", ")"}, </del> <ins> Command: []string{"powershell.exe", "-Command", command}, </ins> }, }, RestartPolicy: v1.RestartPolicyNever,
Change:
In a enabled cluster, Kubernetes assigns duplicate IP addresses when the dynamic block is exhausted. I expected all clusterIPs are uniquely assigned. a enabled Kubernetes v1.24 cluster with a small service-cluster-ip-range. I confirmed on the minikube with the following command. services until the dynamic block is exhausted. see some clusterIPs are duplicated. No response <details</details<detailsminikube v1.25.2 </details<details</details<details</details<details</details<details</details
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
When the dynamic block is exhausted, we expect the service creation to fail with an error message like "No IP address available", right?
According to , Dynamically IP assignment will use the upper band by default, once this has been exhausted it will use the lower range. So I think using the reserved block (the lower range) is expected behavior
/sig network
upps /assign
/assign great catch, thanks

Discussion:
for i := 0; i < rss.offset; i++ { at := (start + i) % rss.offset if allocated.Bit(at) == 0 { <del> return i, true </del> <ins> return at, true </ins> } } return 0, false

t.Errorf("expect to get %d, but got %d", max-1, f) } } <ins> func TestAllocateUniqueness(t *testing.T) { max := 128 dynamicOffset := 16 uniqueAllocated := map[int]bool{} m := NewAllocationMapWithOffset(max, "test", dynamicOffset) // Allocate all the values in both the dynamic and reserved blocks for i := 0; i < max; i++ { alloc, ok, _ := m.AllocateNext() if !ok { t.Fatalf("unexpected error") } if _, ok := uniqueAllocated[alloc]; ok { t.Fatalf("unexpected allocated value %d", alloc) } else { uniqueAllocated[alloc] = true } } if max != len(uniqueAllocated) { t.Errorf("expect to get %d, but got %d", max, len(uniqueAllocated)) } } </ins>

t.Error("Allocator expected to be full") } } <ins> func TestAllocateReservedDynamicBlockExhausted(t *testing.T) { defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.ServiceIPStaticSubrange, true)() _, storage, _, si, destroyFunc := newStorage(t) defer destroyFunc() if err := si.Create(context.TODO(), key(), validNewRangeAllocation(), nil, 0); err != nil { t.Fatalf("unexpected error: %v", err) } // allocate all addresses both on the dynamic and reserved blocks // once the dynamic block has been exhausted // the dynamic allocator will use the reserved block max := 254 for i := 0; i < max; i++ { if _, err := storage.AllocateNext(); err != nil { t.Errorf("Unexpected error trying to allocate: %v", err) } } for i := 0; i < max; i++ { ip := fmt.Sprintf("192.168.1.%d", i+1) if !storage.Has(netutils.ParseIPSloppy(ip)) { t.Errorf("IP %s expected to be allocated", ip) } } if _, err := storage.AllocateNext(); err == nil { t.Error("Allocator expected to be full") } } </ins>
Change:
pull-kubernetes-unit TestWatchOrphanPods/orphan May 4th Waiting for Pod to get the finalizer removed: timed out waiting for the condition No response /sig apps
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
Likely a bug in

Discussion:
manager.podStoreSynced = alwaysReady manager.jobStoreSynced = alwaysReady <del> jobSynced := false manager.syncHandler = func(ctx context.Context, jobKey string) (bool, error) { jobSynced = true return true, nil } </del> stopCh := make(chan struct{}) defer close(stopCh) <del> go sharedInformers.Core().V1().Pods().Informer().Run(stopCh) </del> <ins> podInformer := sharedInformers.Core().V1().Pods().Informer() go podInformer.Run(stopCh) cache.WaitForCacheSync(stopCh, podInformer.HasSynced) </ins> go manager.Run(context.TODO(), 1) // Create job but don't add it to the store. cases := map[string]struct { <del> job           *batch.Job inCache       bool wantJobSynced bool </del> <ins> job     *batch.Job inCache bool </ins> }{ "job_does_not_exist": { job: newJob(2, 2, 6, batch.NonIndexedCompletion),

} for name, tc := range cases { t.Run(name, func(t *testing.T) { <del> jobSynced = false </del> if tc.inCache { <del> sharedInformers.Batch().V1().Jobs().Informer().GetIndexer().Add(tc.job) </del> <ins> if err := sharedInformers.Batch().V1().Jobs().Informer().GetIndexer().Add(tc.job); err != nil { t.Fatalf("Failed to insert job in index: %v", err) } t.Cleanup(func() { sharedInformers.Batch().V1().Jobs().Informer().GetIndexer().Delete(tc.job) }) </ins> } podBuilder := buildPod().name(name).deletionTimestamp().trackingFinalizer()

}); err != nil { t.Errorf("Waiting for Pod to get the finalizer removed: %v", err) } <del> if !tc.inCache && jobSynced { t.Error("Tried to sync deleted job") } </del> }) } }
Change:
/kind failing-test <!-- If this is a flake, please add: /kind flake --/sig storage /kind flake
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
testSlowMultiplier = 10 // How long to wait until CSINode gets attach limit from installed CSI driver. <del> csiNodeInfoTimeout = 1 * time.Minute </del> <ins> csiNodeInfoTimeout = 2 * time.Minute </ins> ) var _ storageframework.TestSuite = &volumeLimitsTestSuite{}
Change:
[X] Test approval issue: [X] Test PR: 7 July 2022 [x] Two weeks soak end date: 21 Jul 2022 [x] Test promotion According to this APIsnoop query, there are still some remaining APIService endpoints which are untested. replaceApiregistrationV1APIServiceStatuspatchApiregistrationV1APIServiceStatusreplaceApiregistrationV1APIServicedeleteApiregistrationV1CollectionAPIService Using a number of existing e2e test practices a new has been created for 4 APIService endpoints. The e2e logs for this test are listed below. This query shows the following endpoints are hit within a short period of running this e2e test If a test with these calls gets merged, test coverage will go up by 4 points This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance
/triage accepted
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
1.17 will work on the current Aggregator/API-Server. release: v1.17, v1.21 file: test/e2e/apimachinery/aggregator.go <ins> - testname: Aggregator, manage lifecycle of an APIService codename: '[sig-api-machinery] Aggregator should manage the lifecycle of an APIService [Conformance]' description: An APIService is created which MUST succeed. The APIService status when replaced MUST succeed. Given the updating of the APIService status, the fields MUST equal the new values. The APIService status when patched MUST succeed. Given the patching of the APIService status, the fields MUST equal the new values. The APIService when replaced MUST succeed. Given the updating of the APIService, the fields MUST equal the new values. It MUST succeed at deleting a collection of APIServices via a label selector. release: v1.25 file: test/e2e/apimachinery/aggregator.go </ins> - testname: Custom Resource Definition Conversion Webhook, convert mixed version list codename: '[sig-api-machinery] CustomResourceConversionWebhook [Privileged:ClusterAdmin] should be able to convert a non homogeneous list of CRs [Conformance]'

TestSampleAPIServer(f, aggrclient, imageutils.GetE2EImage(imageutils.APIServer)) }) <del> ginkgo.It("should manage the lifecycle of an APIService", func() { </del> <ins> /* Release: v1.25 Testname: Aggregator, manage lifecycle of an APIService Description: An APIService is created which MUST succeed. The APIService status when replaced MUST succeed. Given the updating of the APIService status, the fields MUST equal the new values. The APIService status when patched MUST succeed. Given the patching of the APIService status, the fields MUST equal the new values. The APIService when replaced MUST succeed. Given the updating of the APIService, the fields MUST equal the new values. It MUST succeed at deleting a collection of APIServices via a label selector. */ framework.ConformanceIt("should manage the lifecycle of an APIService", func() { </ins> ns := f.Namespace.Name framework.Logf("ns: %v", ns)
Change:
/kind failing-test <!-- If this is a flake, please add: /kind flake --/sig cli
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign

Discussion:
"kind": "Deployment", "metadata": { "name": "my-dep", <del> "namespace": "my-ns", </del> "unknownMeta": "foo", "labels": {"app": "nginx"} },
Change:
/kind failing-test <!-- If this is a flake, please add: /kind flake --/sig cli
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign

Discussion:
"metadata": { %s "name": "subobject", <del> "namespace": "my-ns" </del> <ins> "namespace": "%s" </ins> } } } }` meta := unknownFieldMetadataJSON(gvk, "test-cr") <del> unknownRootMetaCR := fmt.Sprintf(embeddedCRPattern, meta, "") </del> <ins> unknownRootMetaCR := fmt.Sprintf(embeddedCRPattern, meta, "", ns) </ins> _, err = framework.RunKubectlInput(ns, unknownRootMetaCR, "create", "--validate=true", "-f", "-") if err == nil { framework.Failf("unexpected nil error when creating CR with unknown root metadata field")

ginkgo.By("attempting to create a CR with unknown metadata fields in the embedded object") metaEmbedded := fmt.Sprintf(metaPattern, testCRD.Crd.Spec.Names.Kind, testCRD.Crd.Spec.Group, testCRD.Crd.Spec.Versions[0].Name, "test-cr-embedded") <del> unknownEmbeddedMetaCR := fmt.Sprintf(embeddedCRPattern, metaEmbedded, `"unknownMetaEmbedded": "bar",`) </del> <ins> unknownEmbeddedMetaCR := fmt.Sprintf(embeddedCRPattern, metaEmbedded, `"unknownMetaEmbedded": "bar",`, ns) </ins> _, err = framework.RunKubectlInput(ns, unknownEmbeddedMetaCR, "create", "--validate=true", "-f", "-") if err == nil { framework.Failf("unexpected nil error when creating CR with unknown embedded metadata field")