jiebi/CodeConvo huggingface dataset:
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug Description: If TaintNodesByCondition enabled, we should disable and predicates in scheduler. In TaintNodeByCondition, we will handle those conditions: , , and ; NetworkUnavailable checking is removed by predicates, but and not (no predicate for ). /cc
/sig scheduling /sig node
/assign

Discussion:
package nodelifecycle import ( <ins> "fmt" "sync" "time" "github.com/golang/glog" </ins> "k8s.io/api/core/v1" apiequality "k8s.io/apimachinery/pkg/api/equality" apierrors "k8s.io/apimachinery/pkg/api/errors"

"k8s.io/kubernetes/pkg/util/system" taintutils "k8s.io/kubernetes/pkg/util/taints" utilversion "k8s.io/kubernetes/pkg/util/version" <del> "fmt" "sync" "time" "github.com/golang/glog" </del> ) func init() {

// ApplyFeatureGates applies algorithm by feature gates. func ApplyFeatureGates() { if utilfeature.DefaultFeatureGate.Enabled(features.TaintNodesByCondition) { <del> // Remove "CheckNodeCondition" predicate </del> <ins> // Remove "CheckNodeCondition", "CheckNodeMemoryPressure" and "CheckNodeDiskPressure" predicates </ins> factory.RemoveFitPredicate(predicates.CheckNodeConditionPred) <del> // Remove Key "CheckNodeCondition" From All Algorithm Provider </del> <ins> factory.RemoveFitPredicate(predicates.CheckNodeMemoryPressurePred) factory.RemoveFitPredicate(predicates.CheckNodeDiskPressurePred) // Remove key "CheckNodeCondition", "CheckNodeMemoryPressure" and "CheckNodeDiskPressure" // from ALL algorithm provider </ins> // The key will be removed from all providers which in algorithmProviderMap[] // if you just want remove specific provider, call func RemovePredicateKeyFromAlgoProvider() factory.RemovePredicateKeyFromAlgorithmProviderMap(predicates.CheckNodeConditionPred) <ins> factory.RemovePredicateKeyFromAlgorithmProviderMap(predicates.CheckNodeMemoryPressurePred) factory.RemovePredicateKeyFromAlgorithmProviderMap(predicates.CheckNodeDiskPressurePred) </ins> // Fit is determined based on whether a pod can tolerate all of the node's taints factory.RegisterMandatoryFitPredicate(predicates.PodToleratesNodeTaintsPred, predicates.PodToleratesNodeTaints)
Change:
http://k8s- looks like something is indeed busted :- /priority failing-test /kind bug /status approved-for-milestone /sig testing cc /assign
/assign looks like Mike is working on the fix

Discussion:
# gazelle:exclude _gopath # gazelle:exclude _output # gazelle:exclude _tmp <ins> # gazelle:prefix k8s.io/kubernetes </ins> package(default_visibility = ["//visibility:public"])

97099dccc8807e9159dc28f374a8f0602cab07e1 kube::util::go_install_from_commit  github.com/bazelbuild/bazel-gazelle/cmd/gazelle  <del> 39e8257565d3917c1674bf37d6538c10cdac2260 </del> <ins> a85b63b06c2e0c75931e57c4a1a18d4e566bb6f4 </ins> touch "${KUBE_ROOT}/vendor/BUILD"
Change:
See Today kubelet image manager returns the internal image list cache to caller directly. However, in we sort the image list, which introduces a data race. We should let image manager return a copy of image list instead of returning the list directly. /cc
There are no sig labels on this issue. Please add a sig label. <detailsA sig label can be by either: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. See the . The in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
Code Freeze for 1.10 begins in 2 hours. If this issue represents a bug or change for 1.10, then it needs SIG approval in the form of a status/approved-for-milestone label. It also needs a priority/ Thanks!

Discussion:
images []container.Image } <del> // set updates image cache. </del> <ins> // set sorts the input list and updates image cache. // 'i' takes ownership of the list, you should not reference the list again // after calling this function. </ins> func (i *imageCache) set(images []container.Image) { i.Lock() defer i.Unlock() <ins> // The image list needs to be sorted when it gets read and used in // setNodeStatusImages. We sort the list on write instead of on read, // because the image cache is more often read than written sort.Sort(sliceutils.ByImageSize(images)) </ins> i.images = images } <del> // get gets a sorted (by image size) image list from image cache. // There is a potentical data race in this function. See PR #60448 // Because there is deepcopy function available currently, move sort // function inside this function </del> <ins> // get gets image list from image cache. // NOTE: The caller of get() should not do mutating operations on the // returned list that could cause data race against other readers (e.g. // in-place sorting the returned list) </ins> func (i *imageCache) get() []container.Image { i.Lock() defer i.Unlock() <del> sort.Sort(sliceutils.ByImageSize(i.images)) </del> return i.images }

} } <del> func TestImageCacheReturnCopiedList(t *testing.T) { cache := &imageCache{} testList := []container.Image{{ID: "1"}, {ID: "2"}} cache.set(testList) list := cache.get() assert.Len(t, list, 2) list[0].ID = "3" assert.Equal(t, cache.get(), testList) } </del> func uint64Ptr(i uint64) *uint64 { return &i }

} for _, image := range containerImages { <del> names := append(image.RepoDigests, image.RepoTags...) </del> <ins> // make a copy to avoid modifying slice members of the image items in the list names := append([]string{}, image.RepoDigests...) names = append(names, image.RepoTags...) </ins> // Report up to MaxNamesPerImageInNodeStatus names per image. if len(names) > MaxNamesPerImageInNodeStatus { names = names[0:MaxNamesPerImageInNodeStatus]
Change:
/priority failing-test /priority important-soon /kind flake /sig-api-machinery this failure is currently one of the top flake and repros in both Presubmits and CI jobs. This test is also part of the Conformance suite, which makes the flake far more critical. Can one of you please help triage this issue.
/cc
/cc
/assign
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
/remove-lifecycle stale
flakes are continuing, hopefully logging gives us more info to work with
this test seems to flake quite a bit in the presubmits and its a conformance test on top of this. Can we please look into the new logs to see if we have more info to deflake this? Triage: Logs: https://k8s-
/cc
FWIW this test seems to pass consistently in our conformance dashboards - https://k8s-,%20master%20(dev). But seems to flake only in CI and Presubmits
Do those run at different parallelism levels? It could be load/timeout sensitive
I have also seen a general uptick in flakes in other e2e tests that could be sensitive to watch event latency, not just gc tests - for example, see the failures in https://k8s-
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
Hey, this test does not appear to be flaking anymore can we close this issue?
Closing based on non-response. /close
Closing this issue. <detailsIn response to : Closing based on non-response. Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
This was never actually fixed, looks like.

Discussion:
if err := deployClient.Delete(deployment.ObjectMeta.Name, deleteOptions); err != nil { framework.Failf("failed to delete the deployment: %v", err) } <del> ginkgo.By("wait for 30 seconds to see if the garbage collector mistakenly deletes the rs") time.Sleep(30 * time.Second) </del> <ins> ginkgo.By("wait for deployment deletion to see if the garbage collector mistakenly deletes the rs") err = wait.PollImmediate(500*time.Millisecond, 1*time.Minute, func() (bool, error) { dList, err := deployClient.List(metav1.ListOptions{}) if err != nil { return false, fmt.Errorf("failed to list deployments: %v", err) } return len(dList.Items) == 0, nil }) if err != nil { framework.Failf("Failed to wait for the Deployment to be deleted: %v", err) } // Once the deployment object is gone, we'll know the GC has finished performing any relevant actions. </ins> objects := map[string]int{"Deployments": 0, "ReplicaSets": 1, "Pods": 2} ok, err := verifyRemainingObjects(f, objects) if err != nil {
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug /sig network /area ipvs What happened: Per , kubeadm init doesn't support the --feature-gates=SupportIPVSProxyMode=true flag anymore since IPVS is in beta and not alpha anymore. We should enable IPVS feature gateway by default to make kubeadm set up IPVS proxy. What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/assign

Discussion:
BlockVolume:                                 {Default: false, PreRelease: utilfeature.Alpha}, StorageObjectInUseProtection:                {Default: true, PreRelease: utilfeature.Beta}, ResourceLimitsPriorityFunction:              {Default: false, PreRelease: utilfeature.Alpha}, <del> SupportIPVSProxyMode:                        {Default: false, PreRelease: utilfeature.Beta}, </del> <ins> SupportIPVSProxyMode:                        {Default: true, PreRelease: utilfeature.Beta}, </ins> SupportPodPidsLimit:                         {Default: false, PreRelease: utilfeature.Alpha}, HyperVContainer:                             {Default: false, PreRelease: utilfeature.Alpha}, NoDaemonSetScheduler:                        {Default: false, PreRelease: utilfeature.Alpha},
Change:
http://k8s- looks like the job has multiple flaky tests :- /sig node /priority failing-test /kind bug /status approved-for-milestone cc any clue :smirk: ?

Discussion:
) // Serial because the test restarts Kubelet <del> var _ = framework.KubeDescribe("Device Plugin [Feature:DevicePlugin]", func() { </del> <ins> var _ = framework.KubeDescribe("Device Plugin [Feature:DevicePlugin] [Serial]", func() { </ins> f := framework.NewDefaultFramework("device-plugin-errors") Context("DevicePlugin", func() {
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: When using IMDS, kubelet reports even when vmtype is not set: What you expected to happen: azure cloud provider should assume stardard vmtype if it is not set. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/sig azure
Added to v1.10 milestone since it is a critical bug fix. cc

Discussion:
return nil, err } <ins> if config.VMType == "" { // default to standard vmType if not set. config.VMType = vmTypeStandard } </ins> env, err := auth.ParseAzureEnvironment(config.Cloud) if err != nil { return nil, err

RouteTableName:               "rt", PrimaryAvailabilitySetName:   "as", MaximumLoadBalancerRuleCount: 250, <ins> VMType: vmTypeStandard, </ins> }, } az.DisksClient = newFakeDisksClient()
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: azure file plugin on Windows does not work after node restart, this is due to powershell cmdlet has lost account name/key after reboot, we should remove the invalid link and do the mount again after kubelet restart. What you expected to happen: azure file plugin on Windows should work after node restart How to reproduce it (as minimally and precisely as possible): has created a pod with azure file mount on Windows agent node could get following error: Anything else we need to know?: Environment: Kubernetes version (use ): v1.9, v1.10 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /assign /sig windows /sig azure
Added to v1.10 milestone since it is a critical bug fix. cc

Discussion:
import ( "fmt" <ins> "io/ioutil" </ins> "os" "runtime"

return err } if !notMnt { <del> return nil </del> <ins> // testing original mount point, make sure the mount link is valid if _, err := ioutil.ReadDir(dir); err == nil { glog.V(4).Infof("azureFile - already mounted to target %s", dir) return nil } // mount link is invalid, now unmount and remount later glog.Warningf("azureFile - ReadDir %s failed with %v, unmount this directory", dir, err) if err := b.mounter.Unmount(dir); err != nil { glog.Errorf("azureFile - Unmount directory %s failed with %v", dir, err) return err } notMnt = true </ins> } var accountKey, accountName string if accountName, accountKey, err = b.util.GetAzureCredentials(b.plugin.host, b.secretNamespace, b.secretName); err != nil { return err
Change:
Is this a BUG REPORT or FEATURE REQUEST?: BUG /kind bug What happened: when using cloud controller manager, function is not working correctly. Common function is not return correct value if instance is deleted from cloudprovider. What you expected to happen: I except that code should end to row if node is deleted from cloudprovider. How to reproduce it (as minimally and precisely as possible): kubernetes cluster to openstack cloudprovider using cloud controller manager debug print after this row cluster is up and running, delete one node from openstack and see the cloud controller log file result is If this works correctly it should return nil as error, from this row But now the code is not going there because is not working correctly. I debugged this function, and when instance is deleted from openstack this row variable e is and ok is . So it is not working as should. Anything else we need to know?: I am thinking that is this working correcly in any other place currently in openstack cloudprovider. Environment: Kubernetes version (use ): master Cloud provider or hardware configuration: openstack mitaka cc as you are author of this function. I am thinking could we just fix that using dirty way where ErrResNotFound is constant
/sig openstack
is this now fixed with the changes referenced?
yes all fixed this can be closed

Discussion:
} func isNotFound(err error) bool { <del> e, ok := err.(*gophercloud.ErrUnexpectedResponseCode) return ok && e.Actual == http.StatusNotFound </del> <ins> if _, ok := err.(gophercloud.ErrDefault404); ok { return true } if errCode, ok := err.(gophercloud.ErrUnexpectedResponseCode); ok { if errCode.Actual == http.StatusNotFound { return true } } return false </ins> } // Zones indicates that we support zones
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind e2e-test-failure /sig network /area platform/gce What happened: From https://k8s-, network tier test is failing since 2/24. From the , seems a bit suspicious. Example failure:
/assign agau4779
GitHub didn't allow me to assign the following users: agau4779. Note that only and repo collaborators can be assigned. <detailsIn response to : /assign agau4779 Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
By("creating a Service of type LoadBalancer using the standard network tier") svc := jig.CreateTCPServiceOrFail(ns, func(svc *v1.Service) { svc.Spec.Type = v1.ServiceTypeLoadBalancer <del> setNetworkTier(svc, gcecloud.NetworkTierAnnotationStandard.ToGCEValue()) </del> <ins> setNetworkTier(svc, string(gcecloud.NetworkTierAnnotationStandard)) </ins> }) // Verify that service has been updated properly. svcTier, err := gcecloud.GetServiceNetworkTier(svc)

By("updating the Service to use the standard tier with a requested IP") svc = jig.UpdateServiceOrFail(ns, svc.Name, func(svc *v1.Service) { svc.Spec.LoadBalancerIP = requestedIP <del> setNetworkTier(svc, gcecloud.NetworkTierAnnotationStandard.ToGCEValue()) </del> <ins> setNetworkTier(svc, string(gcecloud.NetworkTierAnnotationStandard)) </ins> }) // Verify that service has been updated properly. Expect(svc.Spec.LoadBalancerIP).To(Equal(requestedIP))
Change:
/kind bug https://k8s- This is likely caused by a missing REMOUNTVOLUMEPLUGIN_DIR flag in kube-env construction. /assign /sig storage
xref /priority failing-test /priority critical-urgent any update on this one?
/status approved-for-milestone
I'm aware of the solution, but I'm trying to understand how to limit the scope of the change to just COS images, instead of all VM distros.
xref
Fix submitted, awaiting review:
PR approved; awaiting 1.10 milestone marker
/status in-progress
You must be a member of the github team to add status labels.
/status in-progress
[MILESTONENOTIFIER] Milestone Issue Needs Attention Action Required: This issue has not been updated since Mar 11. Please provide an update. Note: This issue is marked as , and must be updated every 1 day during code freeze. Example update: <details<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=""Additional instructions</a</li<li<a href=""Commands for setting labels</a</li</ul</details

Discussion:
EXTRA_DOCKER_OPTS="${EXTRA_DOCKER_OPTS:-}" VOLUME_PLUGIN_DIR="${VOLUME_PLUGIN_DIR:-/home/kubernetes/flexvolume}" <del> REMOUNT_VOLUME_PLUGIN_DIR="${REMOUNT_VOLUME_PLUGIN_DIR:-true}" </del> SERVICE_CLUSTER_IP_RANGE="${SERVICE_CLUSTER_IP_RANGE:-10.0.0.0/16}"  # formerly PORTAL_NET ALLOCATE_NODE_CIDRS=true

KUBEPROXY_TEST_LOG_LEVEL="${KUBEPROXY_TEST_LOG_LEVEL:-$TEST_CLUSTER_LOG_LEVEL}" VOLUME_PLUGIN_DIR="${VOLUME_PLUGIN_DIR:-/home/kubernetes/flexvolume}" <del> REMOUNT_VOLUME_PLUGIN_DIR="${REMOUNT_VOLUME_PLUGIN_DIR:-true}" </del> TEST_CLUSTER_DELETE_COLLECTION_WORKERS="${TEST_CLUSTER_DELETE_COLLECTION_WORKERS:---delete-collection-workers=1}" TEST_CLUSTER_MAX_REQUESTS_INFLIGHT="${TEST_CLUSTER_MAX_REQUESTS_INFLIGHT:-}"

VOLUME_PLUGIN_DIR: $(yaml-quote ${VOLUME_PLUGIN_DIR}) KUBELET_ARGS: $(yaml-quote ${KUBELET_ARGS}) EOF <ins> if [[ "${master}" == "true" && "${MASTER_OS_DISTRIBUTION}" == "gci" ]] ||  [[ "${master}" == "false" && "${NODE_OS_DISTRIBUTION}" == "gci" ]]  ||  [[ "${master}" == "true" && "${MASTER_OS_DISTRIBUTION}" == "cos" ]] ||  [[ "${master}" == "false" && "${NODE_OS_DISTRIBUTION}" == "cos" ]]; then cat >>$file <<EOF REMOUNT_VOLUME_PLUGIN_DIR: $(yaml-quote ${REMOUNT_VOLUME_PLUGIN_DIR:-true}) EOF fi </ins> if [ -n "${KUBE_APISERVER_REQUEST_TIMEOUT:-}" ]; then cat >>$file <<EOF KUBE_APISERVER_REQUEST_TIMEOUT: $(yaml-quote ${KUBE_APISERVER_REQUEST_TIMEOUT})
Change:
/kind bug What happened: The kubelet command option description for pod-cidr shows the following "For IPv6, the minimum length of the cluster or pod CIDR is /66" however, this /66 restriction was removed with PR What you expected to happen: The command option should not display this restriction. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/assign rpothier
/sig node

Discussion:
fs.StringVar(&c.HairpinMode, "hairpin-mode", c.HairpinMode, "How should the kubelet setup hairpin NAT. This allows endpoints of a Service to loadbalance back to themselves if they should try to access their own Service. Valid values are "promiscuous-bridge", "hairpin-veth" and "none".") fs.Int32Var(&c.MaxPods, "max-pods", c.MaxPods, "Number of Pods that can run on this Kubelet.") <del> fs.StringVar(&c.PodCIDR, "pod-cidr", c.PodCIDR, "The CIDR to use for pod IP addresses, only used in standalone mode.  In cluster mode, this is obtained from the master. For IPv6, the minimum length of the cluster or pod CIDR is /66.") </del> <ins> fs.StringVar(&c.PodCIDR, "pod-cidr", c.PodCIDR, "The CIDR to use for pod IP addresses, only used in standalone mode.  In cluster mode, this is obtained from the master. For IPv6, the maximum number of IP's allocated is 65536") </ins> fs.Int64Var(&c.PodPidsLimit, "pod-max-pids", c.PodPidsLimit, "<Warning: Alpha feature> Set the maximum number of processes per pod.") fs.StringVar(&c.ResolverConfig, "resolv-conf", c.ResolverConfig, "Resolver configuration file used as the basis for the container DNS resolution configuration.")
Change:
the tests are failing in http://k8s- /sig sig-api-machinery /priority failing-test /priority critical-urgent /kind bug /status approved-for-milestone /milestone v1.10 cc /assign
The provided milestone is not valid for this repository. Here are the available milestones: 1.clear 1.v1.6 1.v1.13 1.v1.10 1.v1.11 1.v1.8 1.v1.4 1.v1.5 1.v1.12 1.next-candidate 1.v1.9 1.v1.7 <detailsIn response to : the tests are failing in http://k8s- /priority failing-test /priority critical-urgent /kind bug /status approved-for-milestone /milestone v1.10 /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
xref
/sig api-machinery
/assign /assign
The three tests in should be run only on 1.10+ servers. I'm just putting a PR together, should be up within next hour or so.
Master fix is in .
/reopen still failing in upgrade tests: http://k8s- the 1.9 e2e tests are checking alpha response types that don't exist any more in 1.10 requires changing 1.9 to not test these alpha features in 1.10 that dropped support for those alpha features
you can't re-open an issue/PR unless you authored it or you are assigned to it. <detailsIn response to : /reopen still failing in upgrade tests: http://k8s- Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
Is there anyone from that can look into this?
looking into this
/status in-progress
[MILESTONENOTIFIER] Milestone Issue: Up-to-date for process Note: This issue is marked as , and must be updated every 1 day during code freeze. Example update: <details open<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=""Additional instructions</a</li<li<a href=""Commands for setting labels</a</li</ul</details
fixed by

Discussion:
"k8s.io/client-go/util/workqueue" "k8s.io/kubernetes/pkg/printers" <ins> utilversion "k8s.io/kubernetes/pkg/util/version" </ins> "k8s.io/kubernetes/test/e2e/framework" imageutils "k8s.io/kubernetes/test/utils/image" ) <ins> var serverPrintVersion = utilversion.MustParseSemantic("v1.10.0") </ins> var _ = SIGDescribe("Servers with support for Table transformation", func() { f := framework.NewDefaultFramework("tables") <ins> BeforeEach(func() { framework.SkipUnlessServerVersionGTE(serverPrintVersion, f.ClientSet.Discovery()) }) </ins> It("should return pod details", func() { ns := f.Namespace.Name c := f.ClientSet