jiebi/CodeConvo huggingface dataset:
Change:
Currently I describe a Pod that is in and fails to attach/mounts its volume: Note that the generated events are shown in 4 section. The only difference between the messages is how the are ordered. I suggest to sort the unmounted/unattached) volumes for the event message. This will allow to group all events and properly have the age and the occurrences count reported. I would expect the unmounted/unattached) volumes to be sorted in the events' message and to do not have several group of events for the same issue. See above. No response <details</details<detailsAWS but does not matter for this issue. </details<details</details<details</details<details</details<details</details
/sig storage
/assign qingwave
/triage accepted

Discussion:
unattachedVolumes = append(unattachedVolumes, volumeToMount.OuterVolumeSpecName) } } <ins> sort.Strings(unattachedVolumes) </ins> return unattachedVolumes }

unmountedVolumes = append(unmountedVolumes, expectedVolume) } } <ins> sort.Strings(unmountedVolumes) </ins> return unmountedVolumes }

MountPath: "/vol2", }, { <ins> Name:      "vol02", MountPath: "/vol02", }, { </ins> Name:      "vol3", MountPath: "/vol3", }, <ins> { Name:      "vol03", MountPath: "/vol03", }, </ins> }, }, },

}, }, { <ins> Name: "vol02", VolumeSource: v1.VolumeSource{ RBD: &v1.RBDVolumeSource{}, }, }, { </ins> Name: "vol3", VolumeSource: v1.VolumeSource{ AzureDisk: &v1.AzureDiskVolumeSource{}, }, }, <ins> { Name: "vol03", VolumeSource: v1.VolumeSource{ AzureDisk: &v1.AzureDiskVolumeSource{}, }, }, </ins> }, }, }

t.Errorf("Expected error, got none") } if !strings.Contains(err.Error(), <del> "unattached volumes=[vol2], failed to process volumes=[vol3]") { </del> <ins> "unattached volumes=[vol02 vol2], failed to process volumes=[vol03 vol3]") { </ins> t.Errorf("Unexpected error info: %v", err) } }
Change:
We tried to run command to generate file. But the option in the command seems to have not been effective. Perhaps it was commit that caused the issue. used to replace all params. If the file path contains '/', other options should also take effect. Run command like which contains request parameter and proto file path. No response_ <details</details<details</details<details</details<details</details<details</details<details</details
/sig api-machinery
/area code-generation
/assign
/assign /triage accepted
GitHub didn't allow me to assign the following users: dinhxuanvu. Note that only with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see <detailsIn response to : /assign /triage accepted Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
This issue has not been updated in over 1 year, and should be re-triaged. You can: Confirm that this issue is still relevant with (org members only) Close this issue with For more details on the triage process, see /remove-triage accepted
is this issue still affecting you on the current release?
Yes, but I have no time to fix it.
Thanks Fulvio for taking this :) /triage accepted
Hi I'll implement this as agreed at the bi-weekly meeting

Discussion:
// if we're given paths as inputs, generate .pb.go files based on those paths for _, file := range request.FileToGenerate { if strings.Contains(file, "/") { <del> param := "paths=source_relative" request.Parameter = &param </del> <ins> if request.Parameter != nil { *request.Parameter += ",paths=source_relative" } else { param := "paths=source_relative" request.Parameter = &param } </ins> break } }
Change:
sig-release-1.27-informing capz-windows-containerd-1.27 04-05 23:42 IST https://k8s- No response /sig node
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
Is is related to
Yes it is related. The images published to the repository do not have entries for Windows Server 2022 containers so this test will fail test passes that use Windows Server 2022 for all the Windows nodes.
I will either skip the test for this test pass or update the image REPO_LIST used by this test to point to a different container registry that has a valid image for this test.

Discussion:
for _, item := range table { result, err := aws.List(item.input) if err != nil { <del> t.Errorf("Expected call with %v to succeed, failed with %s", item.input, err) </del> <ins> t.Errorf("Expected call with %v to succeed, failed with %v", item.input, err) </ins> } if e, a := item.expect, result; !reflect.DeepEqual(e, a) { t.Errorf("Expected %v, got %v", e, a)
Change:
PV recycler pod fails to remove files if there are files in the directory. Error in the pod logs: Apparently one hits ARG_MAX due to too long command line. PV is recycled successfully Claim and NFS pv, create files. In my testing I have provided my template and replaced the with: and recycle was successful. Maybe I am missing something but the was able to clean up everything (files, folders) and we also need to exclude the folder name. already has the command, no changes to image needed. <details</details<detailsBare metal </details<details</details<details</details<details</details<detailsNFS Persistent Volume </details
/sig storage
I can prep a PR if we are happy with using command.
/triage accepted
/help wanted
Feel free to submit a PR.
updated the command in issue description as per

Discussion:
- /bin/sh args: - -c <del> - test -e /scrub && rm -rf /scrub/..?* /scrub/.[!.]* /scrub/* && test -z $(ls -A /scrub) || exit 1 </del> <ins> - test -e /scrub && find /scrub -mindepth 1 -delete && test -z $(ls -A /scrub) || exit 1 </ins> volumeMounts: - name: vol mountPath: /scrub

Name:    "pv-recycler", Image:   "registry.k8s.io/debian-base:v2.0.0", Command: []string{"/bin/sh"}, <del> Args:    []string{"-c", "test -e /scrub && rm -rf /scrub/..?* /scrub/.[!.]* /scrub/*  && test -z "$(ls -A /scrub)" || exit 1"}, </del> <ins> Args:    []string{"-c", "test -e /scrub && find /scrub -mindepth 1 -delete && test -z "$(ls -A /scrub)" || exit 1"}, </ins> VolumeMounts: []v1.VolumeMount{ { Name:      "vol",
Change:
A V(2) log line that includes preemption details (preemptee and preemptor), somewhere here We used to have most of this information as part of the logging for Events. But we removed the preemptor from it as a security measure Logs can have pod names.
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig scheduling
/help
This request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /help Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
/help-remove

Discussion:
// Otherwise we should delete the victim. if waitingPod := fh.GetWaitingPod(victim.UID); waitingPod != nil { waitingPod.Reject(pluginName, "preempted") <ins> klog.V(2).InfoS("Preemptor pod rejected a waiting pod", "preemptor", klog.KObj(pod), "waitingPod", klog.KObj(victim), "node", c.Name()) </ins> } else { if feature.DefaultFeatureGate.Enabled(features.PodDisruptionConditions) { victimPodApply := corev1apply.Pod(victim.Name, victim.Namespace).WithStatus(corev1apply.PodStatus())

errCh.SendErrorWithCancel(err, cancel) return } <ins> klog.V(2).InfoS("Preemptor Pod preempted victim Pod", "preemptor", klog.KObj(pod), "victim", klog.KObj(victim), "node", c.Name()) </ins> } fh.EventRecorder().Eventf(victim, pod, v1.EventTypeNormal, "Preempted", "Preempting", "Preempted by a pod on node %v", c.Name()) }
Change:
[X] test approval issue : [X] test pr : 3 May 2023 [X] two weeks soak end date : 16 May 2023 [X] test promotion pr : [X] remove endpoint form file According to following two APIsnoop queries, there are still 12 APIResources endpoints that are not tested for Conformance. Using a number of existing e2e test practices a new has been created to address these 12 endpoints. The e2e logs for this test are listed below. This query shows the following apiresources endpoints are hit within a short period of running this e2e test. If a test with these calls gets merged, test coverage will go up by 12 points This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance
/triage accepted
/open For tracking the rest of the processes
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
definitions MUST be published for custom resource definitions. release: v1.16 file: test/e2e/apimachinery/crd_publish_openapi.go <ins> - testname: Discovery, confirm the groupVerion and a resourcefrom each apiGroup codename: '[sig-api-machinery] Discovery should locate the groupVersion and a resource within each APIGroup [Conformance]' description: A resourceList MUST be found for each apiGroup that is retrieved. For each apiGroup the groupVersion MUST equal the groupVersion as reported by the schema. From each resourceList a valid resource MUST be found. release: v1.28 file: test/e2e/apimachinery/discovery.go </ins> - testname: Discovery, confirm the PreferredVersion for each api group codename: '[sig-api-machinery] Discovery should validate PreferredVersion for each APIGroup [Conformance]'

} }) <del> ginkgo.It("should locate the groupVersion and a resource within each APIGroup", func(ctx context.Context) { </del> <ins> /* Release: v1.28 Testname: Discovery, confirm the groupVerion and a resourcefrom each apiGroup Description: A resourceList MUST be found for each apiGroup that is retrieved. For each apiGroup the groupVersion MUST equal the groupVersion as reported by the schema. From each resourceList a valid resource MUST be found. */ framework.ConformanceIt("should locate the groupVersion and a resource within each APIGroup", func(ctx context.Context) { </ins> tests := []struct { apiBasePath   string
Change:
{Failed === RUN TestKMSv2Healthz --- FAIL: TestKMSv2Healthz (167.38s) also shown in " TestKMSv2Healthz": 1, Not sure No response No response /sig auth
/assign /triage accepted Use for poll interval Change the poll timeout to 5m Update the poll error check (check if not nil)

Discussion:
func mustBeHealthy(t kubeapiservertesting.Logger, checkName, wantBodyContains string, clientConfig *rest.Config, excludes ...string) { t.Helper() var restErr error <del> pollErr := wait.PollImmediate(2*time.Second, 2*time.Minute, func() (bool, error) { </del> <ins> pollErr := wait.PollImmediate(1*time.Second, 5*time.Minute, func() (bool, error) { </ins> body, ok, err := getHealthz(checkName, clientConfig, excludes...) restErr = err if err != nil {

return done, nil }) <del> if pollErr == wait.ErrWaitTimeout { </del> <ins> if pollErr != nil { </ins> t.Fatalf("failed to get the expected healthz status of OK for check: %s, error: %v, debug inner error: %v", checkName, pollErr, restErr) } }

func mustBeUnHealthy(t kubeapiservertesting.Logger, checkName, wantBodyContains string, clientConfig *rest.Config, excludes ...string) { t.Helper() var restErr error <del> pollErr := wait.PollImmediate(2*time.Second, 2*time.Minute, func() (bool, error) { </del> <ins> pollErr := wait.PollImmediate(1*time.Second, 5*time.Minute, func() (bool, error) { </ins> body, ok, err := getHealthz(checkName, clientConfig, excludes...) restErr = err if err != nil {

return done, nil }) <del> if pollErr == wait.ErrWaitTimeout { </del> <ins> if pollErr != nil { </ins> t.Fatalf("failed to get the expected healthz status of !OK for check: %s, error: %v, debug inner error: %v", checkName, pollErr, restErr) } }
Change:
pull-kubernetes-e2e-gce, assorted GCE jobs Seems to be elevated today No response No response_ /sig network
three instances:
/assign I've seen it too
/triage accepted
confirmed that it has been fixed !

Discussion:
cmd := fmt.Sprintf(`curl -s -o /dev/null -w "%%{http_code}" --connect-timeout 5 http://%s/healthz`, healthCheckNodePortAddr) out, err := e2eoutput.RunHostCmd(pausePod0.Namespace, pausePod0.Name, cmd) if err != nil { <del> return false, err </del> <ins> framework.Logf("unexpected error trying to connect to nodeport %d : %v", healthCheckNodePortAddr, err) return false, nil </ins> } expectedOut := "200" if out != expectedOut { <ins> framework.Logf("expected output: %s , got %s", expectedOut, out) </ins> return false, nil } return true, nil

cmd := fmt.Sprintf(`curl -s -o /dev/null -w "%%{http_code}" --connect-timeout 5 http://%s/healthz`, healthCheckNodePortAddr) out, err := e2eoutput.RunHostCmd(pausePod0.Namespace, pausePod0.Name, cmd) if err != nil { <del> return false, err </del> <ins> framework.Logf("unexpected error trying to connect to nodeport %d : %v", healthCheckNodePortAddr, err) return false, nil </ins> } expectedOut := "503" if out != expectedOut { <ins> framework.Logf("expected output: %s , got %s", expectedOut, out) </ins> return false, nil } return true, nil
Change:
This is a subset of "make verify doesn't work under anymore" xref: In two places we assume the path for "local builds" But when dockerized it will be at should work.
I'm not sure what the cleanest solution is here. Maybe a symlink in a fixed location that we update to point to whichever we just built ...
cc
Can we set env variables as part of ? golangci-lint doesn't support a search path for plugins yet, but perhaps that can be .
Bit of a blunt instrument but we could do that. Another blunt approach would be picking some unused path under _output to add a symlink to either I guess.
It would be really nice if we could just pass searchpaths for the plugins instead of having to pass a complete path.
relative paths are resolved relative to the config file, so you can indirectly change a root path on a fixed file by using different config paths and not have to edit the file contents ... we could use two symlinks in _output to the actual config file. Still not ideal.
This is one of the few remaining verify scripts that doesnt work on mac or otherwise dockerized.
Let's fix this by making the path absolute in a temporary copy of the golangci-lint config file: Syncing .git is relevant for testing PRs, but it seems that already ensured that it is available.
That sounds reasonable. Yeah, while working on that issue I found the other handful of verify scripts that are also broken when containerized for reasons unrelated to git. This is one of them, the others are linked in

Discussion:
esac done <del> if [ "${golangci_config}" ]; then golangci+=(--config="${golangci_config}") fi </del> # Below the output of golangci-lint is going to be piped into sed to add # a prefix to each output line. This helps make the output more visible # in the Prow log viewer ("error" is a key word there) and ensures that

fi popd >/dev/null <ins> if [ "${golangci_config}" ]; then # The relative path to _output/local/bin only works if that actually is the # GOBIN. If not, then we have to make a temporary copy of the config and # replace the path with an absolute one. This could be done also # unconditionally, but the invocation that is printed below is nicer if we # don't to do it when not required. if grep -q 'path: ../_output/local/bin/' "${golangci_config}" && [ "${GOBIN}" != "${KUBE_ROOT}/_output/local/bin" ]; then kube::util::ensure-temp-dir patched_golangci_config="${KUBE_TEMP}/$(basename "${golangci_config}")" sed -e "s;path: ../_output/local/bin/;path: ${GOBIN}/;" "${golangci_config}" >"${patched_golangci_config}" golangci_config="${patched_golangci_config}" fi golangci+=(--config="${golangci_config}") fi </ins> cd "${KUBE_ROOT}" res=0
Change:
[x] test approval issue : [x] test pr : 18 May 2023 [x] two weeks soak end date : 01 June 2023 [x] test promotion pr : According to following APIsnoop query, there are still 2 PodEphemeralcontainers endpoints that are not tested for Conformance. Using a number of existing e2e test practices a new has been created to address these 2 endpoints. The e2e logs for this test are listed below. This query shows the following podephemeralcontainers endpoints are hit within a short period of running this e2e test. If a test with these calls gets merged, test coverage will go up by 2 points This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance
/triage accepted cc
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
visible at runtime in the container. release: v1.9 file: test/e2e/common/node/downwardapi.go <ins> - testname: Ephemeral Container, update ephemeral containers codename: '[sig-node] Ephemeral Containers [NodeConformance] should update the ephemeral containers in an existing pod [Conformance]' description: Adding an ephemeral container to pod.spec MUST result in the container running. There MUST now be only one ephermal container found. Updating the pod with another ephemeral container MUST succeed. There MUST now be two ephermal containers found. release: v1.28 file: test/e2e/common/node/ephemeral_containers.go </ins> - testname: Ephemeral Container Creation codename: '[sig-node] Ephemeral Containers [NodeConformance] will start an ephemeral container in an existing pod [Conformance]'

gomega.Expect(log).To(gomega.ContainSubstring("polo")) }) <del> ginkgo.It("should update the ephemeral containers in an existing pod", func(ctx context.Context) { </del> <ins> /* Release: v1.28 Testname: Ephemeral Container, update ephemeral containers Description: Adding an ephemeral container to pod.spec MUST result in the container running. There MUST now be only one ephermal container found. Updating the pod with another ephemeral container MUST succeed. There MUST now be two ephermal containers found. */ framework.ConformanceIt("should update the ephemeral containers in an existing pod", func(ctx context.Context) { </ins> ginkgo.By("creating a target pod") pod := podClient.CreateSync(ctx, &v1.Pod{ ObjectMeta: metav1.ObjectMeta{Name: "ephemeral-containers-target-pod"},
Change:
remove log warning about not using config file Currently, kube-proxy can be configured via both CLI flags and config file. and config file can override flags. In the future, all flags will be deprecated and use the config file instead. But now the config file is still at the alpha level, so we shouldn't be warning people to stop using flags if there is no config file present. refer to
/kind cleanup /sig network
just append this "... if there is no config file present"
/assign
We talked about this one on the SIG Network meeting today: We agree we should move forward with it: /triage accepted /unassign We are looking for someone from the community with a strong interest to champion it and move it forward, please do comment if you'd like to take this one on and we'd be happy to help facilitate! /help
This request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : We talked about this one on the SIG Network meeting today: We agree we should move forward with it: /unassign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
Ah looks like has already started, thank you! /assign

Discussion:
// Complete completes all the required options. func (o *Options) Complete() error { if len(o.ConfigFile) == 0 && len(o.WriteConfigTo) == 0 { <del> klog.InfoS("Warning, all flags other than --config, --write-config-to, and --cleanup are deprecated, please begin using a config file ASAP") </del> o.config.HealthzBindAddress = addressFromDeprecatedFlags(o.config.HealthzBindAddress, o.healthzPort) o.config.MetricsBindAddress = addressFromDeprecatedFlags(o.config.MetricsBindAddress, o.metricsPort) }
Change:
I met a panic in apiserver package when I create an aggregated API. not panic Do not call No response <details</details<details</details<details</details<details</details<details</details<details</details
Reference PR to fix:
/sig api-machinery
/cc /triage accepted

Discussion:
// underlying storage will be destroyed on this servers shutdown. func (s *GenericAPIServer) InstallAPIGroups(apiGroupInfos ...*APIGroupInfo) error { for _, apiGroupInfo := range apiGroupInfos { <ins> if len(apiGroupInfo.PrioritizedVersions) == 0 { return fmt.Errorf("no version priority set for %#v", *apiGroupInfo) } </ins> // Do not register empty group or empty version.  Doing so claims /apis/ for the wrong entity to be returned. // Catching these here places the error  much closer to its origin if len(apiGroupInfo.PrioritizedVersions[0].Group) == 0 {