Change:
This is a sub issue for
cc can you please assign this to me? Thanks.
, please create PR directly and cc to Tim for review.
/sig node
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. Prevent issues from auto-closing with an comment. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
Stale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten /remove-lifecycle stale
Rotten issues close after 30d of inactivity. Reopen the issue with . Mark the issue as fresh with . Send feedback to sig-testing, kubernetes/test-infra and/or . /close

Discussion:
go_test( name = "go_default_test", srcs = [ <ins> "labels_test.go", </ins> "pod_update_test.go", "types_test.go", ],

<ins> /* Copyright 2017 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package types import ( "testing" "github.com/stretchr/testify/assert" ) func TestGetContainerName(t *testing.T) { var cases = []struct { labels        map[string]string containerName string }{ { labels: map[string]string{ "io.kubernetes.container.name": "c1", }, containerName: "c1", }, { labels: map[string]string{ "io.kubernetes.container.name": "c2", }, containerName: "c2", }, } for _, data := range cases { containerName := GetContainerName(data.labels) assert.Equal(t, data.containerName, containerName) } } func TestGetPodName(t *testing.T) { var cases = []struct { labels  map[string]string podName string }{ { labels: map[string]string{ "io.kubernetes.pod.name": "p1", }, podName: "p1", }, { labels: map[string]string{ "io.kubernetes.pod.name": "p2", }, podName: "p2", }, } for _, data := range cases { podName := GetPodName(data.labels) assert.Equal(t, data.podName, podName) } } func TestGetPodUID(t *testing.T) { var cases = []struct { labels map[string]string podUID string }{ { labels: map[string]string{ "io.kubernetes.pod.uid": "uid1", }, podUID: "uid1", }, { labels: map[string]string{ "io.kubernetes.pod.uid": "uid2", }, podUID: "uid2", }, } for _, data := range cases { podUID := GetPodUID(data.labels) assert.Equal(t, data.podUID, podUID) } } func TestGetPodNamespace(t *testing.T) { var cases = []struct { labels       map[string]string podNamespace string }{ { labels: map[string]string{ "io.kubernetes.pod.namespace": "ns1", }, podNamespace: "ns1", }, { labels: map[string]string{ "io.kubernetes.pod.namespace": "ns2", }, podNamespace: "ns2", }, } for _, data := range cases { podNamespace := GetPodNamespace(data.labels) assert.Equal(t, data.podNamespace, podNamespace) } } </ins>