jiebi/CodeConvo huggingface dataset:
Change:
[x] test approval issue : [x] test pr : [x] two weeks soak end date : 14 March 2022 [X] test promotion pr : According to this APIsnoop query, there is still one remaining PodTemplate endpoint which is untested. Using a number of existing e2e test practices a new has been created for pod templates. The e2e logs for this test are listed below. This query shows the endpoints hit within a short period of running the e2e test If a test with these calls gets merged, test coverage will go up by 1 points This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance
/triage accepted
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
v1 "k8s.io/api/core/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/types" <ins> utilrand "k8s.io/apimachinery/pkg/util/rand" </ins> "k8s.io/apimachinery/pkg/util/uuid" "k8s.io/apimachinery/pkg/util/wait" <ins> "k8s.io/client-go/util/retry" </ins> "k8s.io/kubernetes/test/e2e/framework" imageutils "k8s.io/kubernetes/test/utils/image"

err = wait.PollImmediate(podTemplateRetryPeriod, podTemplateRetryTimeout, checkPodTemplateListQuantity(f, "podtemplate-set=true", 0)) framework.ExpectNoError(err, "failed to count required pod templates") <ins> }) ginkgo.It("should replace a pod template", func() { ptClient := f.ClientSet.CoreV1().PodTemplates(f.Namespace.Name) ptName := "podtemplate-" + utilrand.String(5) ginkgo.By("Create a pod template") ptResource, err := ptClient.Create(context.TODO(), &v1.PodTemplate{ ObjectMeta: metav1.ObjectMeta{ Name: ptName, }, Template: v1.PodTemplateSpec{ Spec: v1.PodSpec{ Containers: []v1.Container{ {Name: "e2e-test", Image: imageutils.GetE2EImage(imageutils.Agnhost)}, }, }, }, }, metav1.CreateOptions{}) framework.ExpectNoError(err, "failed to create pod template") ginkgo.By("Replace a pod template") var updatedPT *v1.PodTemplate err = retry.RetryOnConflict(retry.DefaultRetry, func() error { ptResource, err = ptClient.Get(context.TODO(), ptName, metav1.GetOptions{}) framework.ExpectNoError(err, "Unable to get pod template %s", ptName) ptResource.Annotations = map[string]string{ "updated": "true", } updatedPT, err = ptClient.Update(context.TODO(), ptResource, metav1.UpdateOptions{}) return err }) framework.ExpectNoError(err) framework.ExpectEqual(updatedPT.Annotations["updated"], "true", "updated object should have the applied annotation") framework.Logf("Found updated podtemplate annotation: %#vn", updatedPT.Annotations["updated"]) </ins> }) })
Change:
[x] test approval issue : [x] test pr : [x] two weeks soak end date : 14 March 2022 [X] test promotion pr : According to this APIsnoop query, there is still one remaining PodTemplate endpoint which is untested. Using a number of existing e2e test practices a new has been created for pod templates. The e2e logs for this test are listed below. This query shows the endpoints hit within a short period of running the e2e test If a test with these calls gets merged, test coverage will go up by 1 points This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance
/triage accepted
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
when listed by its label selector. release: v1.19 file: test/e2e/common/node/podtemplates.go <ins> - testname: PodTemplate, replace codename: '[sig-node] PodTemplates should replace a pod template [Conformance]' description: Attempt to create a PodTemplate which MUST succeed. Attempt to replace the PodTemplate to include a new annotation which MUST succeed. The annotation MUST be found in the new PodTemplate. release: v1.24 file: test/e2e/common/node/podtemplates.go </ins> - testname: PodTemplate lifecycle codename: '[sig-node] PodTemplates should run the lifecycle of PodTemplates [Conformance]' description: Attempt to create a PodTemplate. Patch the created PodTemplate. Fetching

}) <del> ginkgo.It("should replace a pod template", func() { </del> <ins> /* Release: v1.24 Testname: PodTemplate, replace Description: Attempt to create a PodTemplate which MUST succeed. Attempt to replace the PodTemplate to include a new annotation which MUST succeed. The annotation MUST be found in the new PodTemplate. */ framework.ConformanceIt("should replace a pod template", func() { </ins> ptClient := f.ClientSet.CoreV1().PodTemplates(f.Namespace.Name) ptName := "podtemplate-" + utilrand.String(5)
Change:
There are no sig labels on this issue. Please add an appropriate label by using one of the following commands: - Please see the for a listing of the SIGs, working groups, and committees available. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/help wanted
/good-first-issue
This request has been marked as suitable for new contributors. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /good-first-issue </details
/assign
Hi , I am new to making contributions in Kubernetes ecosystem. I am happy to start working on this issue. I will reach out to you if I need any clarifications. Best Regards, Umesh
/assign
/assign

Discussion:
return encoder.EncodeWithAllocator(obj, w, memAlloc) } } else { <del> klog.V(4).Infof("a memory allocator was provided but the encoder %T doesn't implement the runtime.EncoderWithAllocator, using regular encoder.Encode method") </del> <ins> klog.V(4).Infof("a memory allocator was provided but the encoder %s doesn't implement the runtime.EncoderWithAllocator, using regular encoder.Encode method", c.encoder.Identifier()) </ins> } } switch obj := obj.(type) {
Change:
Noticed this issue when looking at logs to figure out which images we use in a e2e test and from where. for example: Looks like it is from here:
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign /sig storage cc
see background in and
slack discussion -
Looks like we can switch to see below:
looks like this image supports all the arch(es) we care about as well: !

Discussion:
- name: vol containers: - name: pv-recycler <del> image: k8s.gcr.io/busybox:1.27 </del> <ins> image: k8s.gcr.io/debian-base:v2.0.0 </ins> command: - /bin/sh args:

- name: vol mountPath: /scrub EOF <ins> # fixup the alternate registry if specified if [[ -n "${KUBE_ADDON_REGISTRY:-}" ]]; then sed -i -e "s@k8s.gcr.io@${KUBE_ADDON_REGISTRY}@g" "${PV_RECYCLER_OVERRIDE_TEMPLATE}" fi </ins> } function wait-till-apiserver-ready() {

Containers: []v1.Container{ { Name:    "pv-recycler", <del> Image:   "busybox:1.27", </del> <ins> Image:   "k8s.gcr.io/debian-base:v2.0.0", </ins> Command: []string{"/bin/sh"}, Args:    []string{"-c", "test -e /scrub && rm -rf /scrub/..?* /scrub/.[!.]* /scrub/*  && test -z "$(ls -A /scrub)" || exit 1"}, VolumeMounts: []v1.VolumeMount{
Change:
Currently, stable metric changes can be approved by top-level approvers and are not obviously "special" to a contributor. We have verify scripts that will prevent adding or changing stable metrics without updating Instrumentation-owned files, but the errors can easily be "fixed" by running the corresponding update script. Contributors may end up doing so to fix the verify errors and not understand the consequences of promoting a metric to "stable" status. We would like to consider the following: [x] Migrate the documentation for stable metrics from KEP to the community/developer docs: [x] Add a new label that flags stable metrics changes, ex. , from the OWNERS file in required for stable metrics [x] When the label is applied, a comment from the bot that alerts contributors of the stable metric guidelines, similar to [ ] Do we also want to consider adding to the stable metrics OWNERS file to avoid accidental merges from top-level approvers? We had some contributors join the latest SIG Instrumentation meeting requesting to add some labels to stable metrics. They were under the impression that stable metrics worked similar to other Kubernetes APIs, and thus they could make "compatible" API changes. This is not the case, and they were unaware of the stable metrics documentation. I think it would be good to flag this documentation to anyone making stable metrics changes, in the same way that we flag API changes and point contributors to that documentation. /sig instrumentation contributor-experience /cc
I don't think we had any issue with top-level approvers graduating metrics to stable in the past, but I also don't think they should be able to do that, so I would be in favor of that change.
Related, stable metrics changes should some day trigger a docs PR to update a reference doc. (there's no reference doc listing stable metrics yet, but I hope that changes)
/triage accepted
/assign ehashman

Discussion:
# See the OWNERS docs at https://go.k8s.io/owners <ins> # Disable inheritance as stable metrics require SIG Instrumentation approval options: no_parent_owners: true </ins> approvers: - sig-instrumentation-approvers reviewers: - sig-instrumentation-reviewers labels: - sig/instrumentation <ins> - area/stable-metrics </ins>
Change:
[X] test approval issue : [X] test pr : 28/07/2022 [X] two weeks soak end date : 12/07/2022 [X] test promotion pr : The endpoint as seen on the website is tested but not part of conformance. The APIsnoop query below shows that there is no conformance test for this endpoint. patchCoreV1NamespacedPodStatus Using a number of existing e2e test practices a new has been created for this pod status endpoint. The e2e logs for this test are listed below. This query shows the pod status endpoints hit within a short period of running the e2e test. If a test with these calls gets merged, test coverage will go up by 1 point. This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance /sig node
/triage accepted
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:
/remove-lifecycle stale targeting this for 1.25
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
IP address. release: v1.9 file: test/e2e/common/node/pods.go <ins> - testname: Pods, patching status codename: '[sig-node] Pods should patch a pod status [Conformance]' description: A pod is created which MUST succeed and be found running. The pod status when patched MUST succeed. Given the patching of the pod status, the fields MUST equal the new values. release: v1.25 file: test/e2e/common/node/pods.go </ins> - testname: Pods, completes the lifecycle of a Pod and the PodStatus codename: '[sig-node] Pods should run through the lifecycle of Pods and PodStatus [Conformance]'

} }) <del> ginkgo.It("should patch a pod status", func() { </del> <ins> /* Release: v1.25 Testname: Pods, patching status Description: A pod is created which MUST succeed and be found running. The pod status when patched MUST succeed. Given the patching of the pod status, the fields MUST equal the new values. */ framework.ConformanceIt("should patch a pod status", func() { </ins> ns := f.Namespace.Name podClient := f.ClientSet.CoreV1().Pods(ns) podName := "pod-" + utilrand.String(5)
Change:
Example using a random PR for , take a look at: in this set of logs, at least 4 files are empty kube-container-runtime- kube-node- kube- kubelet- The reason tracked down using was that the journald configuration was defaulting to something that wipes the logs quickly!
There are no sig labels on this issue. Please add an appropriate label by using one of the following commands: - Please see the for a listing of the SIGs, working groups, and committees available. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
safe-bind-mount "${ephemeral_mountpoint}/log_pods" "/var/log/pods" } <ins> # set journald configuration function setup-journald() { if [[ "${SET_JOURNALD_CONFIGURATION:-true}" = "true" ]]; then cat <<EOF > /etc/systemd/journald.conf [Journal] Storage=persistent SystemMaxUse=1G SystemMaxFileSize=100M RuntimeMaxUse=100M EOF systemctl restart systemd-journald.service fi } </ins> # Installs logrotate configuration files function setup-logrotate() { mkdir -p /etc/logrotate.d/

log-wrap 'CreateDirs' create-dirs log-wrap 'EnsureLocalSSDs' ensure-local-ssds log-wrap 'SetupKubeletDir' setup-kubelet-dir <ins> log-wrap 'SetupJournald' setup-journald </ins> log-wrap 'SetupLogrotate' setup-logrotate if [[ "${KUBERNETES_MASTER:-}" == "true" ]]; then log-wrap 'MountMasterPD' mount-master-pd
Change:
create clusterrole command with resource value not work. I got this example command from the help note. But got error with the example command. I think it should work like yes. No response <details</details<detailsno cloud env, just vm </details<details</details<detailskubeadm </details<detailsClient: Version: 20.10.7 API version: 1.41 Go version: go1.13.8 Git commit: 20.10.7-0ubuntu5~20.04.2 Built: Mon Nov 1 00:34:17 2021 OS/Arch: linux/amd64 Context: default Experimental: true Server: Engine: Version: 20.10.7 API version: 1.41 (minimum version 1.12) Go version: go1.13.8 Git commit: 20.10.7-0ubuntu5~20.04.2 Built: Fri Oct 22 00:45:53 2021 OS/Arch: linux/amd64 Experimental: false containerd: Version: 1.5.5-0ubuntu3~20.04.2 GitCommit: runc: Version: 1.0.1-0ubuntu2~20.04.1 GitCommit: docker-init: Version: 0.19.0 GitCommit: </details<details</details
/sig CLI
/sig auth /assign
extensions/v1beta1 is no longer served since 1.16 the example should be updated to refer to
Thanks, for this information, I will update this. One more thing I have to ask here should I also do update the files/folders under folder like
Hi Any Inputs on this!
I don't know how the translation files are maintained, sorry
Don't be sorry, it's OK! Thanks!
/assign I will update the docs.
Hi I am already working on it. I have one doubt on translation files, which I already asked in the channel. Could you please tell me if you know that it will be a great help!
/usassign ok
You can check the kubectl example. ! And the role/clusterrole and something else alse needs an update. Code in website: I think it is generated
yes, I already saw where to update the things, but I have one doubt in file which is under translation , I just wonder I have to update this file or not. see this
/cc
Hi PTAL!
Hi could you please take a look!
Hi Friendly reminder!
Fix it here PTAL!
/triage accepted

Discussion:
kubectl create clusterrole pod-reader --verb=get --resource=pods --resource-name=readablepod --resource-name=anotherpod # Create a cluster role named "foo" with API Group specified <del> kubectl create clusterrole foo --verb=get,list,watch --resource=rs.extensions </del> <ins> kubectl create clusterrole foo --verb=get,list,watch --resource=rs.apps </ins> # Create a cluster role named "foo" with SubResource specified kubectl create clusterrole foo --verb=get,list,watch --resource=pods,pods/status

kubectl create role pod-reader --verb=get --resource=pods --resource-name=readablepod --resource-name=anotherpod # Create a role named "foo" with API Group specified <del> kubectl create role foo --verb=get,list,watch --resource=rs.extensions </del> <ins> kubectl create role foo --verb=get,list,watch --resource=rs.apps </ins> # Create a role named "foo" with SubResource specified kubectl create role foo --verb=get,list,watch --resource=pods,pods/status`))
Change:
The command provides a flag but this doesn't do anything. most likely the flag shouldn't exist. I have no idea how kustomize could be useful here to start a single pod. This creates a pod, and shows that is ignored: No response <details</details<detailsAzure, K3OS</details<detailsOSX 11.6.1 (Big Sur) </detailsNo response No response No response
/sig cli
This comes from the inclusion of DeleteFlags: brings in FilenameFlags: has Kustomize, resulting in the flag: I suspect there are many flags from DeleteFlags that don't really apply to . : Not sure what this would do : seems to be ignored and : doesn't seem to be used : doesn't seem to be used : also probably doesn't apply There might be others as well...
It seems to delete object which created by command.
I agree, As far as I can see, , and have this deleteFlags exposure.
/assign
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/triage accepted

Discussion:
addRunFlags(cmd, o) cmdutil.AddApplyAnnotationFlags(cmd) cmdutil.AddPodRunningTimeoutFlag(cmd, defaultPodAttachTimeout) <ins> // Deprecate the cascade flag. If set, it has no practical effect since the created pod has no dependents. // TODO: Remove the cascade flag from the run command in kubectl 1.29 cmd.Flags().MarkDeprecated("cascade", "because it is not relevant for this command. It will be removed in version 1.29.") // Deprecate and hide unused flags. // These flags are being added to the run command by DeleteFlags to support pod deletion after attach, // but they are not used if set, so they effectively do nothing. // TODO: Remove these flags from the run command in kubectl 1.29 cmd.Flags().MarkDeprecated("filename", "because it is not used by this command. It will be removed in version 1.29.") cmd.Flags().MarkDeprecated("force", "because it is not used by this command. It will be removed in version 1.29.") cmd.Flags().MarkDeprecated("grace-period", "because it is not used by this command. It will be removed in version 1.29.") cmd.Flags().MarkDeprecated("kustomize", "because it is not used by this command. It will be removed in version 1.29.") cmd.Flags().MarkDeprecated("recursive", "because it is not used by this command. It will be removed in version 1.29.") cmd.Flags().MarkDeprecated("timeout", "because it is not used by this command. It will be removed in version 1.29.") cmd.Flags().MarkDeprecated("wait", "because it is not used by this command. It will be removed in version 1.29.") </ins> return cmd }
Change:
[x] Test approval issue : [x] Test PR : - Needed an update on the handling of anotations 27 March 2022 [x] Two weeks soak end date : 6 April 2022 [x] Test promotion PR : [x] Update Test PR: 15 April 2022 [x] Two weeks soak end date : 4 May 2022 with start of 1.25 [x] Update Test Promotion: According to these APIsnoop queries, there are still four remaining Job endpoints which are untested. Using a number of existing e2e test practices a new has been created for this job lifecycle test. The e2e logs for this test are listed below. This query shows the endpoints hit within a short period of running the e2e test If a test with these calls gets merged, test coverage will go up by 4 points This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance
/triage accepted
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/reopen for tracking e2e testgrid and promotion PR
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
patchedJob, err = jobClient.Get(context.TODO(), jobName, metav1.GetOptions{}) framework.ExpectNoError(err, "Unable to get job %s", jobName) patchedJob.Spec.Suspend = pointer.BoolPtr(false) <ins> if patchedJob.Annotations == nil { patchedJob.Annotations = map[string]string{} } </ins> patchedJob.Annotations["updated"] = "true" updatedJob, err = e2ejob.UpdateJob(f.ClientSet, ns, patchedJob) return err