jiebi/CodeConvo huggingface dataset:
Change:
you this variable - PTAL
/sig gcp
Ping? I see that in all failure log messages for . Not sure if thats the cause or just an error message I can ignore?
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
/remove-lifecycle stale /assign since I bumped into this

Discussion:
# # TODO(#8867) Enable by default. ENABLE_METADATA_CONCEALMENT="${ENABLE_METADATA_CONCEALMENT:-false}" # true, false <ins> METADATA_CONCEALMENT_NO_FIREWALL="${METADATA_CONCEALMENT_NO_FIREWALL:-false}" # true, false </ins> if [[ ${ENABLE_METADATA_CONCEALMENT:-} == "true" ]]; then # Put the necessary label on the node so the daemonset gets scheduled. NODE_LABELS="${NODE_LABELS},beta.kubernetes.io/metadata-proxy-ready=true"

# Enable metadata concealment by firewalling pod traffic to the metadata server # and run a proxy daemonset on nodes. ENABLE_METADATA_CONCEALMENT="${ENABLE_METADATA_CONCEALMENT:-true}" # true, false <ins> METADATA_CONCEALMENT_NO_FIREWALL="${METADATA_CONCEALMENT_NO_FIREWALL:-false}" # true, false </ins> if [[ ${ENABLE_METADATA_CONCEALMENT:-} == "true" ]]; then # Put the necessary label on the node so the daemonset gets scheduled. NODE_LABELS="${NODE_LABELS},beta.kubernetes.io/metadata-proxy-ready=true"

HEAPSTER_GCP_BASE_CPU="${HEAPSTER_GCP_BASE_CPU:-80m}" HEAPSTER_GCP_CPU_PER_NODE="${HEAPSTER_GCP_CPU_PER_NODE:-0.5}" <ins> # Optional: custom system banner for dashboard addon CUSTOM_KUBE_DASHBOARD_BANNER="${CUSTOM_KUBE_DASHBOARD_BANNER:-}" </ins> # Default Stackdriver resources version exported by Fluentd-gcp addon LOGGING_STACKDRIVER_RESOURCE_TYPES="${LOGGING_STACKDRIVER_RESOURCE_TYPES:-old}"
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: If a new file is introduced in the FlexVolume driver directory then quickly deleted, a race condition would occur causing segmentation violation and crashing kubelet. What you expected to happen: No crashes. How to reproduce it (as minimally and precisely as possible): It is a race condition. A file needs to be created then deleted many times until the kubelet crashes. Anything else we need to know?: Patch: crash log: Environment: Kubernetes version (use ): 1.8.7 - applies to all Cloud provider or hardware configuration: Azure ACS OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/sig storage
the proposed solution looks good to me, can you please submit a pull request?
can you submit this patch if does not get to it.
ACK
I'm on it
Associated PR approved:
[MILESTONENOTIFIER] Milestone Issue: Up-to-date for process Note: This issue is marked as , and must be updated every 1 day during code freeze. Example update: <details open<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=""Additional instructions</a</li<li<a href=""Commands for setting labels</a</li</ul</details

Discussion:
// on its parent directory. func (prober *flexVolumeProber) addWatchRecursive(filename string) error { addWatch := func(path string, info os.FileInfo, err error) error { <del> if info.IsDir() { </del> <ins> if err == nil && info.IsDir() { </ins> if err := prober.watcher.AddWatch(path); err != nil { glog.Errorf("Error recursively adding watch: %v", err) }
Change:
This test consistently fails for GKE Regional Clusters: https://k8s- - can you please triage?
/assign
Hey, this was removed from 1.10 because it was never updated. Just want to make sure that this isn't a significant bug.
Yes, this is a significant bug in tests, sorry that it slipped our attention
[MILESTONENOTIFIER] Milestone Issue: Up-to-date for process Note: This issue is marked as , and must be updated every 1 day during code freeze. Example update: <details open<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=""Additional instructions</a</li<li<a href=""Commands for setting labels</a</li</ul</details
/open

Discussion:
}() ginkgo.By("Waiting for events to ingest") <del> zone := framework.TestContext.CloudConfig.Zone c := utils.NewLogChecker(p, utils.UntilFirstEntryFromZone(zone), utils.JustTimeout, "") </del> <ins> location := framework.TestContext.CloudConfig.Zone if framework.TestContext.CloudConfig.MultiZone { location = framework.TestContext.CloudConfig.Region } c := utils.NewLogChecker(p, utils.UntilFirstEntryFromLocation(location), utils.JustTimeout, "") </ins> err := utils.WaitForLogs(c, ingestionInterval, ingestionTimeout) framework.ExpectNoError(err) })

} } <del> // UntilFirstEntryFromZone is a IngestionPred that checks that at least one </del> <ins> // UntilFirstEntryFromLocation is a IngestionPred that checks that at least one </ins> // entry from the log with a given name was ingested. <del> func UntilFirstEntryFromZone(zone string) IngestionPred { </del> <ins> func UntilFirstEntryFromLocation(location string) IngestionPred { </ins> return func(_ string, entries []LogEntry) (bool, error) { for _, e := range entries { <del> if e.Location == zone { </del> <ins> if e.Location == location { </ins> return true, nil } }
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: In the case of an admission webhook that specifies a url, we only use the Host and Path fields of the parsed url, (url is defined as ) When a service based webhook is constructed, we do define a scheme for the config If the scheme is not specified when the REST client is constructed, then it defaults to http, unless CA, Cert, or config.Insecure is set What you expected to happen: Admission Webhooks should honor the scheme part of the url provided in their client config
/sig api-machinery
/assign

Discussion:
} cfg := rest.CopyConfig(restConfig) <del> cfg.Host = u.Host </del> <ins> cfg.Host = u.Scheme + "://" + u.Host </ins> cfg.APIPath = u.Path return complete(cfg)
Change:
/kind bug I wasn't able to find issue opened for ZSH case, and aware about similar, fixed, case with bash in 1.10.0-b1 bash completion is working fine
/sig cli
can you verify this and label for v1.10 milestone and note if it will be considered a release blocker
I cannot reproduce this on my local machine (zsh 5.3.1 x86_64-apple-darwin16.3.0). Please produce a docker container (with Dockerfile) that shows this issue.
And another important question for the release: can you try with the 1.9 kubectl? Is that working in your setup?
little bit more info: i'm running this on CentOS 7.4 1708 x64 and zsh from official repo same issue happenes with 1.10.0-b3: 3
From sig-cli Slack: Kazuki Suda [01:22] It seems that have to be renamed to due to changes contained (edited)
You can reproduce this with the below:
was renamed to at , but has been used yet in completions generated by . So we have to replace to .
issue still exists with v10.0.0-b4
10.0-beta.4 does not contain the fix, yet.
Because the fix is not cherry-picked to release-1.10 yet.

Discussion:
__kubeadm_filedir() { local RET OLD_IFS w qw <del> __debug "_filedir $@ cur=$cur" </del> <ins> __kubectl_debug "_filedir $@ cur=$cur" </ins> if [[ "$1" = ~* ]]; then # somehow does not work. Maybe, zsh does not call this at all eval echo "$1"

{ local template template="{{ range .spec.containers  }}{{ .name }} {{ end }}" <del> __debug "${FUNCNAME} nouns are ${nouns[*]}" </del> <ins> __kubectl_debug "${FUNCNAME} nouns are ${nouns[*]}" </ins> local len="${#nouns[@]}" if [[ ${len} -ne 1 ]]; then

__kubectl_filedir() { local RET OLD_IFS w qw <del> __debug "_filedir $@ cur=$cur" </del> <ins> __kubectl_debug "_filedir $@ cur=$cur" </ins> if [[ "$1" = ~* ]]; then # somehow does not work. Maybe, zsh does not call this at all eval echo "$1"

fi IFS="$OLD_IFS" <del> IFS="," __debug "RET=${RET[@]} len=${#RET[@]}" </del> <ins> IFS="," __kubectl_debug "RET=${RET[@]} len=${#RET[@]}" </ins> for w in ${RET[@]}; do if [[ ! "${w}" = "${cur}"* ]]; then
Change:
https://k8s- testgrid diff for commit range: looks like /priority failing-test /priority critical-urgent /kind bug /status approved-for-milestone /sig apps /milestone v1.10 cc /assign
It seems that Daemon pods are unable to be scheduled (all Pending):
maybe this case: , let me check more detail :)
ACK. In progress, that trigger a limitation of this feature that: DaemonSet pods donot tolerate unscheduable nodes. Working on the solution.
do you have any updates on this?
I believe is tackling this issue.
Working on for this :)
ACK. In progress; waiting for review comments on
ACK. In Progress ETA: Later today, waiting on test results Risks: Test may still fail.
/reopen Let's not close this until the test passes.
https://k8s- latest run is green :-) I'll close the issue
https://k8s- it start to fail again (on before suite this time) after one green run, any insight there?
, I think it should be handled by .
ack, thanks!
/status in-progress
New PR for this issue:
(let's wait for a few green runs)
This issue has more lives than a cat!
/meow
]() <detailsIn response to : /meow Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/woof :( , let me check it today
]() <detailsIn response to : /woof Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
[MILESTONENOTIFIER] Milestone Issue: Up-to-date for process <details open<summaryIssue Labels</summary- : Issue will be escalated to these SIGs if needed. : Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels. : Fixes a bug discovered during the current release. </details<details<summaryHelp</summary<ul<li<a href=""Additional instructions</a</li<li<a href=""Commands for setting labels</a</li</ul</details
ACK: in progress, open to handle a race condition, controlled by alpha feature flag
after discussion with opened (picked to 1.10 in ) to disable the daemonset scheduling feature completely in 1.10 (even in the alpha job). will revisit in 1.11.
Test went green on master after merged Waiting for cherry pick () to merge before closing
pick merged, watching https://k8s-
https://k8s- went green as well /close

Discussion:
serviceAccountName: metadata-proxy hostNetwork: true dnsPolicy: Default <ins> tolerations: - operator: "Exists" effect: "NoExecute" - operator: "Exists" effect: "NoSchedule" </ins> containers: - name: metadata-proxy image: k8s.gcr.io/metadata-proxy:v0.1.9
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: What happened: kube proxy report following error even if ipvs not enabled. What you expected to happen: How to reproduce it (as minimally and precisely as possible): Install kubernetes and start proxy. Anything else we need to know?: Environment: Kubernetes version (use ): We are using 1.9.1 Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others: /cc comments?
/sig network
It's a noise, but it's thrown by libnetwork/ipvs util. Is that a big deal?
please take a look when you have a chance :)
Yes, it always bring noise for production when customer got warning messages. Why printing some ipvs message even it was not enabled?
/area ipvs

Discussion:
dbus = utildbus.New() iptInterface = utiliptables.New(execer, dbus, protocol) <del> ipvsInterface = utilipvs.New(execer) </del> kernelHandler = ipvs.NewLinuxKernelHandler() ipsetInterface = utilipset.New(execer) <ins> if canUse, _ := ipvs.CanUseIPVSProxier(kernelHandler, ipsetInterface); canUse { ipvsInterface = utilipvs.New(execer) } </ins> // We omit creation of pretty much everything if we run in cleanup mode if cleanupAndExit {

// CleanupLeftovers clean up all ipvs and iptables rules created by ipvs Proxier. func CleanupLeftovers(ipvs utilipvs.Interface, ipt utiliptables.Interface, ipset utilipset.Interface, cleanupIPVS bool) (encounteredError bool) { <ins> if canUse, _ := CanUseIPVSProxier(NewLinuxKernelHandler(), ipset); !canUse { return false } </ins> if cleanupIPVS { // Return immediately when ipvs interface is nil - Probably initialization failed in somewhere. if ipvs == nil {
Change:
What happened: What you expected to happen: I am not sure if is it a bug, I think we should catch err when Watch testResource failed in func TestWatchCallNonNamespace. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
Absolutely we should check err gracefully.
/sig cli
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
/fixes it

Discussion:
codecs := serializer.NewCodecFactory(scheme) o := NewObjectTracker(scheme, codecs.UniversalDecoder()) watch, err := o.Watch(testResource, ns) <ins> if err != nil { t.Fatalf("test resource watch failed in %s: %v ", ns, err) } </ins> go func() { err := o.Create(testResource, testObj, ns) if err != nil {

codecs := serializer.NewCodecFactory(scheme) o := NewObjectTracker(scheme, codecs.UniversalDecoder()) w, err := o.Watch(testResource, "test_namespace") <ins> if err != nil { t.Fatalf("test resource watch failed in test_namespace: %v", err) } </ins> wAll, err := o.Watch(testResource, "") <ins> if err != nil { t.Fatalf("test resource watch failed in all namespaces: %v", err) } </ins> go func() { err := o.Create(testResource, testObj, ns) assert.NoError(t, err, "test resource creation failed")

for idx, watchNamespace := range watchNamespaces { i := idx w, err := o.Watch(testResource, watchNamespace) <ins> if err != nil { t.Fatalf("test resource watch failed in %s: %v", watchNamespace, err) } </ins> go func() { assert.NoError(t, err, "watch invocation failed") for _, c := range cases {
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: [sig-cli] Kubectl client [] Kubectl cluster-info should check if Kubernetes master services is included in cluster-info [Conformance] 10s e2e test "gci-gce" is running in 2 versions: with kube-dns as DNS Service : https://k8s- with CoreDNS as DNS Service : https://k8s- In CoreDNS use case the test is failing What you expected to happen: This e2e tests should not depend on what DNS service is running as default in K8s. CoreDNS is currently BETA, will move to GA soon (after v1.10 though) See : How to reproduce it (as minimally and precisely as possible): look at logs of dashboard : https://k8s- go run -v --test --test_args='--[sig-cli]sKubectlsclients[k8s.io]sKubectlscluster-infosshouldschecksifsKubernetessmastersservicessissincludedsinscluster-infoss[Conformance]$' Anything else we need to know?: Environment: Kubernetes version (use ): branch master Cloud provider or hardware configuration: GCE Install tools: deployment intra-test Others: see https://k8s-
/sig cli

Discussion:
// Can't check exact strings due to terminal control commands (colors) requiredItems := []string{"Kubernetes master", "is running at"} if framework.ProviderIs("gce", "gke") { <del> requiredItems = append(requiredItems, "KubeDNS", "Heapster") </del> <ins> requiredItems = append(requiredItems, "Heapster") </ins> } for _, item := range requiredItems { if !strings.Contains(output, item) {
Change:
/kind bug What happened: Every time a health check is called on the APIServer via the endpoint, an etcd healthcheck is performed. However, as this just starts at the first server in the list passed to the apiserver binary all the healthchecks generate read load on a single etcd member. What you expected to happen: The first server that is checked should either increment (and wrap around) each time or be randomised to spread load around the cluster
/assign
I think a random check is ok.
/sig api-machinery

Discussion:
import ( "fmt" <ins> "math/rand" </ins> "net" "net/url" "time"

const connectionTimeout = 1 * time.Second <del> type connection interface { serverReachable(address string) bool parseServerList(serverList []string) error CheckEtcdServers() (bool, error) } </del> // EtcdConnection holds the Etcd server list type EtcdConnection struct { ServerList []string

// CheckEtcdServers will attempt to reach all etcd servers once. If any // can be reached, return true. func (con EtcdConnection) CheckEtcdServers() (done bool, err error) { <del> // Attempt to reach every Etcd server in order for _, serverURI := range con.ServerList { host, err := parseServerURI(serverURI) </del> <ins> // Attempt to reach every Etcd server randomly. serverNumber := len(con.ServerList) serverPerms := rand.Perm(serverNumber) for _, index := range serverPerms { host, err := parseServerURI(con.ServerList[index]) </ins> if err != nil { return false, err }
Change:
BUG REPORT: /kind bug What happened: Arguments to a command inside pod are treated as kubectl flags and deprecation warnings are shown for them from . What you expected to happen: Arguments to a command inside pod should not be treated as kubectl flags by . How to reproduce it: The arguments , , , passed to the command inside the pod above are treated as flags and deprecation warnings are shown for them from . Environment: Kubernetes version: 9: Cloud provider or hardware configuration: Ubuntu Xenial VM. OS:Kernel:Install tools: minikube:
/sig cli
Reiterating the mentions to trigger a notification: <detailsIn response to : /sig cli Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
is it ok if we remove this warning ?
the warning should be removed just for the arguments to a command inside pod that are passed after the , and not for the arguments to itself. The warning is still valid and needed for arguments with underscore () to itself.
This is a bug of cobra. I've sent out a PR to fix it. And bumped to the fixed version in .
Thanks for fixing this!

Discussion:
}, { "ImportPath": "github.com/spf13/cobra", <del> "Comment": "v0.0.1-32-g6644d46", "Rev": "6644d46b81fa1831979c4cded0106e774e0ef0ab" </del> <ins> "Comment": "v0.0.1-34-gc439c4f", "Rev": "c439c4fa093711d42e1b01acb1235b52004753c1" </ins> }, { "ImportPath": "github.com/spf13/cobra/doc", <del> "Comment": "v0.0.1-32-g6644d46", "Rev": "6644d46b81fa1831979c4cded0106e774e0ef0ab" </del> <ins> "Comment": "v0.0.1-34-gc439c4f", "Rev": "c439c4fa093711d42e1b01acb1235b52004753c1" </ins> }, { "ImportPath": "github.com/spf13/jwalterweatherman",

}, { "ImportPath": "github.com/spf13/cobra", <del> "Rev": "6644d46b81fa1831979c4cded0106e774e0ef0ab" </del> <ins> "Rev": "c439c4fa093711d42e1b01acb1235b52004753c1" </ins> }, { "ImportPath": "github.com/spf13/pflag",

package main import ( <del> "io/ioutil" "os" </del> <ins> "io/ioutil" "os" </ins> <del> "github.com/GoogleCloudPlatform/kubernetes/pkg/kubectl/cmd" </del> <ins> "k8s.io/kubernetes/pkg/kubectl/cmd" "k8s.io/kubernetes/pkg/kubectl/cmd/util" </ins> ) func main() { <del> kubectl := cmd.NewFactory(nil).NewKubectlCommand(os.Stdin, ioutil.Discard, ioutil.Discard) kubectl.GenBashCompletionFile("out.sh") </del> <ins> kubectl := cmd.NewKubectlCommand(util.NewFactory(nil), os.Stdin, ioutil.Discard, ioutil.Discard) kubectl.GenBashCompletionFile("out.sh") </ins> } ```

s := args[0] args = args[1:] switch { <ins> case s == "--": // "--" terminates the flags break Loop </ins> case strings.HasPrefix(s, "--") && !strings.Contains(s, "=") && !hasNoOptDefVal(s[2:], flags): // If '--flag arg' then // delete arg from args.
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Cloud providers are using the command-line tool to retrieve status and format volume mounts. is missing from the hyperkube image resulting in missing volumes. Issues: What you expected to happen: Volume mounts on cloud providers are expected to be formatted and mounted. How to reproduce it (as minimally and precisely as possible): GCE and Openstack volume mounts are effected. Anything else we need to know?: Environment: Kubernetes version (use ): 1.9, 1.10+ Cloud provider or hardware configuration: GCE and Openstack OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
/cc
/sig storage

Discussion:
openssh-client  nfs-common  socat  <ins> udev  </ins> util-linux COPY cni-bin/bin /opt/cni/bin

REGISTRY?=staging-k8s.gcr.io IMAGE?=debian-hyperkube-base <del> TAG=0.9 </del> <ins> TAG=0.10 </ins> ARCH?=amd64 CACHEBUST?=1

docker_pull( name = "debian-hyperkube-base-amd64", <del> digest = "sha256:d83594ecd85345144584523e7fa5388467edf5d2dfa30d0a1bcbf184cddf4a7b", </del> <ins> digest = "sha256:cc782ed16599000ca4c85d47ec6264753747ae1e77520894dca84b104a7621e2", </ins> registry = "k8s.gcr.io", repository = "debian-hyperkube-base-amd64", <del> tag = "0.9",  # ignored, but kept here for documentation </del> <ins> tag = "0.10",  # ignored, but kept here for documentation </ins> ) docker_pull(

OUT_DIR?=_output HYPERKUBE_BIN?=$(OUT_DIR)/dockerized/bin/linux/$(ARCH)/hyperkube <del> BASEIMAGE=k8s.gcr.io/debian-hyperkube-base-$(ARCH):0.8 </del> <ins> BASEIMAGE=k8s.gcr.io/debian-hyperkube-base-$(ARCH):0.10 </ins> TEMP_DIR:=$(shell mktemp -d -t hyperkubeXXXXXX) all: build