jiebi/CodeConvo huggingface dataset:
Change:
[X] Test approval issue: [X] Test PR: 29 Sept 2022 [X] Two weeks soak end date: 14 Oct 2022 [X] Test promotion PR: According to this APIsnoop query, there are still two remaining ReplicationControllerScale endpoints which are untested for conformance. readCoreV1NamespacedReplicationControllerScalereplaceCoreV1NamespacedReplicationControllerScale Using a number of existing e2e test practices a new has been created for two ReplicationControllerScale endpoints. The e2e logs for this test are listed below. This query shows which scale endpoints are hit within a short period of running this e2e test If a test with these calls gets merged, test coverage will go up by 2 point This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance
/triage accepted
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
Pod or delete and replace it with a new Pod release: v1.13 file: test/e2e/apps/rc.go <ins> - testname: Replication Controller, get and update ReplicationController scale codename: '[sig-apps] ReplicationController should get and update a ReplicationController scale [Conformance]' description: A ReplicationController is created which MUST succeed. It MUST succeed when reading the ReplicationController scale. When updating the ReplicationController scale it MUST succeed and the field MUST equal the new value. release: v1.26 file: test/e2e/apps/rc.go </ins> - testname: Replication Controller, release pods codename: '[sig-apps] ReplicationController should release no longer matching pods [Conformance]'

}) }) <del> ginkgo.It("should get and update a ReplicationController scale", func() { </del> <ins> /* Release: v1.26 Testname: Replication Controller, get and update ReplicationController scale Description: A ReplicationController is created which MUST succeed. It MUST succeed when reading the ReplicationController scale. When updating the ReplicationController scale it MUST succeed and the field MUST equal the new value. */ framework.ConformanceIt("should get and update a ReplicationController scale", func() { </ins> rcClient := f.ClientSet.CoreV1().ReplicationControllers(ns) rcName := "e2e-rc-" + utilrand.String(5) initialRCReplicaCount := int32(1)
Change:
Our internal CI job that runs k8s unit tests with master golang. TestCreateVolume TestDeleteVolume Probably after the master golang GITCOMMIT= Change: https://go- No response No response /sig testing
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
^^
Updates: Observed that with the latest version of Go dev branch, the underlying type is no longer fmt.WrapError, but is rather errors.ErrorString when a nil error is using the verb is used. Both, the expected error and the returned error had a similar type until go 1.19 - , which now switched to when a error is wrapped with the verb. The changes are made in where the earlier used is now replaced with to check for error equality. The changes have been tested with both go 1.19 and go 1.20-devel and works as intended.

Discussion:
diskName, diskURI, requestGB, err := b.CreateVolume("testBlob", "testsa", "type", b.common.location, 10) expectedErr := fmt.Errorf("could not get storage key for storage account testsa: could not get storage key for "+ "storage account testsa: Retriable: false, RetryAfter: 0s, HTTPStatusCode: 500, RawError: %w", error(nil)) <del> assert.Equal(t, expectedErr, err) </del> <ins> assert.EqualError(t, err, expectedErr.Error()) </ins> assert.Empty(t, diskName) assert.Empty(t, diskURI) assert.Zero(t, requestGB)

diskURL := "https://foo.blob./vhds/bar.vhd" err := b.DeleteVolume(diskURL) expectedErr := fmt.Errorf("no key for storage account foo, err Retriable: false, RetryAfter: 0s, HTTPStatusCode: 500, RawError: %w", error(nil)) <del> assert.Equal(t, expectedErr, err) </del> <ins> assert.EqualError(t, err, expectedErr.Error()) </ins> err = b.DeleteVolume(diskURL) <del> assert.Equal(t, expectedErr, err) </del> <ins> assert.EqualError(t, err, expectedErr.Error()) </ins> mockSAClient.EXPECT().ListKeys(gomock.Any(), b.common.resourceGroup, "foo").Return(storage.AccountListKeysResult{ Keys: &[]storage.AccountKey{
Change:
[X] Test approval issue: [X] Test PR: 5 Oct 2022 [X] Two weeks soak end date: 19 Oct 2022 [X] Test promotion PR: According to this APIsnoop query, there are still three remaining LimitRange endpoints which are untested. replaceCoreV1NamespacedServiceAccount Using a number of existing e2e test practices a new has been created for one ServiceAccount endpoint. The e2e logs for this test are listed below. This query shows which ServiceAccount endpoints are hit within a short period of running this e2e test If a test with these calls gets merged, test coverage will go up by 1 point This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance
/triage accepted
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
ServiceAccount will be deleted and MUST find a deleted watch event. release: v1.19 file: test/e2e/auth/service_accounts.go <ins> - testname: ServiceAccount, update a ServiceAccount codename: '[sig-auth] ServiceAccounts should update a ServiceAccount [Conformance]' description: A ServiceAccount is created which MUST succeed. When updating the ServiceAccount it MUST succeed and the field MUST equal the new value. release: v1.26 file: test/e2e/auth/service_accounts.go </ins> - testname: Kubectl, guestbook application codename: '[sig-cli] Kubectl client Guestbook application should create and stop a working application  [Conformance]'

framework.Logf("Reconciled root ca configmap in namespace %q", f.Namespace.Name) }) <del> ginkgo.It("should update a ServiceAccount", func() { </del> <ins> /* Release: v1.26 Testname: ServiceAccount, update a ServiceAccount Description: A ServiceAccount is created which MUST succeed. When updating the ServiceAccount it MUST succeed and the field MUST equal the new value. */ framework.ConformanceIt("should update a ServiceAccount", func() { </ins> saClient := f.ClientSet.CoreV1().ServiceAccounts(f.Namespace.Name) saName := "e2e-sa-" + utilrand.String(5)
Change:
[X] Test approval issue: [X] Test PR: 15 Oct 2022 [X] Two weeks soak end date: 28 Oct 2022 [X] Test promotion PR: According to this APIsnoop query, there are still one remaining Namespace endpoint which is untested. replaceCoreV1NamespaceFinalize Note: The test also removes the fake finalize from before calling the finalize action on the test namespace a second time. This will allow the test framework to clean up all namespaces when the e2e finishes, else the test namespace will be stuck in the state. Using a number of existing e2e test practices a new has been created for one Namespace endpoint. The e2e logs for this test are listed below. This query shows that the Finalize endpoint is hit within a short period of running this e2e test If a test with these calls gets merged, test coverage will go up by 1 point This test is also created with the goal of conformance promotion. /sig testing /sig architecture /area conformance
/triage accepted
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
MUST cause pods created by that RC to be orphaned. release: v1.9 file: test/e2e/apimachinery/garbage_collector.go <ins> - testname: Namespace, apply finalizer to a namespace codename: '[sig-api-machinery] Namespaces [Serial] should apply a finalizer to a Namespace [Conformance]' description: Attempt to create a Namespace which MUST be succeed. Updating the namespace with a fake finalizer MUST succeed. The fake finalizer MUST be found. Removing the fake finalizer from the namespace MUST succeed and MUST NOT be found. release: v1.26 file: test/e2e/apimachinery/namespace.go </ins> - testname: Namespace, apply update to a namespace codename: '[sig-api-machinery] Namespaces [Serial] should apply an update to a Namespace [Conformance]'

framework.Logf("Namespace %q now has labels, %#v", ns, updatedNamespace.Labels) }) <del> ginkgo.It("should apply a finalizer to a Namespace", func() { </del> <ins> /* Release: v1.26 Testname: Namespace, apply finalizer to a namespace Description: Attempt to create a Namespace which MUST be succeed. Updating the namespace with a fake finalizer MUST succeed. The fake finalizer MUST be found. Removing the fake finalizer from the namespace MUST succeed and MUST NOT be found. */ framework.ConformanceIt("should apply a finalizer to a Namespace", func() { </ins> fakeFinalizer := v1.FinalizerName("e2e.example.com/fakeFinalizer") var updatedNamespace *v1.Namespace
Change:
kubelet panic with nil map when apiserver restart and kubelet is allocating scaler resources. ! kubelet should not panic. when kubelet is allocating scaler resource with pod starting, restart the api servers; No response <detailsv1.23.6 </details<detailsNone </details<details</details<details</details<details</details<details</details
/sig node
Can this be reproduced? Could you share some more information to reproduce it? After kubelet restart, does it happen again?
/triage needs-information can you please give more information on the set up and how it got to this state. Also if you can include , it will help diagnotics
/assign
fixes the crash by allocating prior to calling allocateRemainingFrom.
/triage accepted /priority important-longterm
/remove-triage needs-information
Are master and minion in the same node? Normally api-server desn't influnce kubelet. ! !

Discussion:
return false } <del> // Allocates from reusableDevices list first. if allocateRemainingFrom(reusableDevices) { return allocated, nil } </del> // Needs to allocate additional devices. if m.allocatedDevices[resource] == nil { m.allocatedDevices[resource] = sets.NewString() } <ins> // Allocates from reusableDevices list first. if allocateRemainingFrom(reusableDevices) { return allocated, nil } </ins> // Gets Devices in use. devicesInUse := m.allocatedDevices[resource] // Gets Available devices.
Change:
As per, , wire up for KCM
/sig instrumentation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
/sig instrumentation

Discussion:
"k8s.io/component-base/configz" "k8s.io/component-base/logs" logsapi "k8s.io/component-base/logs/api/v1" <ins> "k8s.io/component-base/metrics/features" </ins> controllersmetrics "k8s.io/component-base/metrics/prometheus/controllers" <ins> "k8s.io/component-base/metrics/prometheus/slis" </ins> "k8s.io/component-base/term" "k8s.io/component-base/version" "k8s.io/component-base/version/verflag"

func init() { utilruntime.Must(logsapi.AddFeatureGates(utilfeature.DefaultMutableFeatureGate)) <ins> utilruntime.Must(features.AddFeatureGates(utilfeature.DefaultMutableFeatureGate)) </ins> } const (

var unsecuredMux *mux.PathRecorderMux if c.SecureServing != nil { unsecuredMux = genericcontrollermanager.NewBaseHandler(&c.ComponentConfig.Generic.Debugging, healthzHandler) <ins> if utilfeature.DefaultFeatureGate.Enabled(features.ComponentSLIs) { slis.SLIMetricsWithReset{}.Install(unsecuredMux) } </ins> handler := genericcontrollermanager.BuildHandlerChain(unsecuredMux, &c.Authorization, &c.Authentication) // TODO: handle stoppedCh and listenerStoppedCh returned by c.SecureServing.Serve if _, _, err := c.SecureServing.Serve(handler, 0, stopCh); err != nil {
Change:
As per, , wire up metrics/slis for KCM
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
/sig instrumentation

Discussion:
"k8s.io/component-base/configz" "k8s.io/component-base/logs" logsapi "k8s.io/component-base/logs/api/v1" <ins> "k8s.io/component-base/metrics/features" </ins> "k8s.io/component-base/metrics/legacyregistry" <ins> "k8s.io/component-base/metrics/prometheus/slis" </ins> "k8s.io/component-base/term" "k8s.io/component-base/version" "k8s.io/component-base/version/verflag"

func init() { utilruntime.Must(logsapi.AddFeatureGates(utilfeature.DefaultMutableFeatureGate)) <ins> utilruntime.Must(features.AddFeatureGates(utilfeature.DefaultMutableFeatureGate)) </ins> } // Option configures a framework.Registry.

pathRecorderMux := mux.NewPathRecorderMux("kube-scheduler") healthz.InstallHandler(pathRecorderMux, checks...) installMetricHandler(pathRecorderMux, informers, isLeader) <ins> if utilfeature.DefaultFeatureGate.Enabled(features.ComponentSLIs) { slis.SLIMetricsWithReset{}.Install(pathRecorderMux) } </ins> if config.EnableProfiling { routes.Profiling{}.Install(pathRecorderMux) if config.EnableContentionProfiling {
Change:
pr:pull-kubernetes-integration ci-kubernetes-integration- TestDSCUpdatesPodLabelAfterDedupCurHistories Maybe since 9.30? <img width="1103" alt="image" src="https://user-" I didn't find err msg in test files. Instead I found: 12 other tests failed because of these days. Maybe it's because of bad network? Simple timeout? Some other failed links: Also, shows this is a flaky test. No response
/sig apps
I'm currently getting this error on a production machine. Ubuntu 22.04, fresh install from . using the most recent containerd as runtime. Here's my log: and my pod yaml:
The error on the test is can sig-apps PTAL to assess if this is a real bug, I've seen this flaking lately too cc
/edit [Flaky test] This is getting worse with the new tests yesterday /release-blocker
/retitle [Flaky test] /priority important-soon
cc
I have no idea about TestDSCUpdatesPodLabelAfterDedupCurHistories. I guess TestUpdateStatusDespitePodCreationFailure has a data race. Made for it.
we should investigate that too
/triage accepted /assign
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
still top of the integration flakes list -
this should be resolved before 1.26 test freeze
should fix it

Discussion:
t.Fatalf("Failed to update the pod label after new controllerrevision is created: %v", err) } <del> revs, err := clientset.AppsV1().ControllerRevisions(ds.Namespace).List(context.TODO(), metav1.ListOptions{}) if err != nil { t.Fatalf("Failed to list controllerrevision: %v", err) } if revs.Size() == 0 { t.Fatalf("No avaialable controllerrevision") } </del> <ins> err = wait.PollImmediate(1*time.Second, 10*time.Second, func() (bool, error) { revs, err := clientset.AppsV1().ControllerRevisions(ds.Namespace).List(context.TODO(), metav1.ListOptions{}) if err != nil { return false, fmt.Errorf("failed to list controllerrevision: %v", err) } if revs.Size() == 0 { return false, fmt.Errorf("no avaialable controllerrevision") } </ins> <del> for _, rev := range revs.Items { t.Logf("revision: %v;hash: %v", rev.Name, rev.ObjectMeta.Labels[apps.DefaultDaemonSetUniqueLabelKey]) for _, oref := range rev.OwnerReferences { if oref.Kind == "DaemonSet" && oref.UID == ds.UID { if rev.Name != newName { t.Fatalf("duplicate controllerrevision is not deleted") </del> <ins> for _, rev := range revs.Items { t.Logf("revision: %v;hash: %v", rev.Name, rev.ObjectMeta.Labels[apps.DefaultDaemonSetUniqueLabelKey]) for _, oref := range rev.OwnerReferences { if oref.Kind == "DaemonSet" && oref.UID == ds.UID { if rev.Name != newName { t.Logf("waiting for duplicate controllerrevision %v to be deleted", newName) return false, nil } </ins> } } } <ins> return true, nil }) if err != nil { t.Fatalf("Failed to check that duplicate controllerrevision is not deleted: %v", err) </ins> } }
Change:
If I configure the namespace to enforce PSS checks, the return message ends abruptly for : The resource manifest that can be used to reproduce:
/transfer kubernetes
/sig auth /cc
Thanks for the report, fix in
Thanks for the quick fix !

Discussion:
pluralize("type", "types", len(badTypes)), joinQuote(badTypes.List()), )) <del> if setUser { badData = append(badData, "user may not be set") } if setRole { badData = append(badData, "role may not be set") } </del> <ins> } if setUser { badData = append(badData, "user may not be set") } if setRole { badData = append(badData, "role may not be set") </ins> } return CheckResult{

expectReason: `seLinuxOptions`, expectDetail: `containers "d", "e", "f" set forbidden securityContext.seLinuxOptions: type "bar"; user may not be set; role may not be set`, }, <ins> { name: "bad type", pod: &corev1.Pod{Spec: corev1.PodSpec{ SecurityContext: &corev1.PodSecurityContext{ SELinuxOptions: &corev1.SELinuxOptions{ Type: "bad", }, }, }}, expectReason: `seLinuxOptions`, expectDetail: `pod set forbidden securityContext.seLinuxOptions: type "bad"`, }, { name: "bad user", pod: &corev1.Pod{Spec: corev1.PodSpec{ SecurityContext: &corev1.PodSecurityContext{ SELinuxOptions: &corev1.SELinuxOptions{ User: "bad", }, }, }}, expectReason: `seLinuxOptions`, expectDetail: `pod set forbidden securityContext.seLinuxOptions: user may not be set`, }, { name: "bad role", pod: &corev1.Pod{Spec: corev1.PodSpec{ SecurityContext: &corev1.PodSecurityContext{ SELinuxOptions: &corev1.SELinuxOptions{ Role: "bad", }, }, }}, expectReason: `seLinuxOptions`, expectDetail: `pod set forbidden securityContext.seLinuxOptions: role may not be set`, }, </ins> } for _, tc := range tests {
Change:
Add back-off restarting failed container name in the event message, like: When there are multiple containers in a pod, we use to show the event, it is not showing the failed container name, but it is useful and needed.
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig node
Maybe we can get the container information from upper, including State, Last State...
Yes, we can see more info on the upper part, but it is more straight-forward to see the container name in the event msg, especially when there are multiple containers in a pod.
I think it is a valuable feature.

Discussion:
key := getStableKey(pod, container) if backOff.IsInBackOffSince(key, ts) { if containerRef, err := kubecontainer.GenerateContainerRef(pod, container); err == nil { <del> m.recorder.Eventf(containerRef, v1.EventTypeWarning, events.BackOffStartContainer, "Back-off restarting failed container") </del> <ins> m.recorder.Eventf(containerRef, v1.EventTypeWarning, events.BackOffStartContainer, fmt.Sprintf("Back-off restarting failed container %s in pod %s", container.Name, format.Pod(pod))) </ins> } err := fmt.Errorf("back-off %s restarting failed container=%s pod=%s", backOff.Get(key), container.Name, format.Pod(pod)) klog.V(3).InfoS("Back-off restarting failed container", "err", err.Error())
Change:
Update the godoc on the encryption config API on how to specify group/resources to be encrypted ref: godoc has the details na No response_ na na <details</details<details</details<details</details<details</details
/sig auth /triage accepted
/assign Cool-Coder174
Thanks for volunteering for this LMK if you need any help with it.
Just for clarification, I just need to add documentation on how to configure encryption on groups/resources?
You can update godoc to mention that custom resources can now be to the list of to be encrypted as well and how to add the of the resource to the list. e.g. from this test
/assign /unassign Release v1.26 deadlines are here so we need to get this completed ASAP.
/milestone v1.26
I apologize for the slow actions. I know time and contributions are valuable. May I request a walk through. This is my first time ever contributing and I really want to learn. I have been reading some of the code base on my spare time.
this feature is on the harder side of things to get started with. Reading the blog post and the associated documentation is probably the best starting point:
& what is the status on this issue? 1.26 is coming up! cc
/milestone v1.27

Discussion:
// ResourceConfiguration stores per resource configuration. type ResourceConfiguration struct { <del> // resources is a list of kubernetes resources which have to be encrypted. </del> <ins> // resources is a list of kubernetes resources which have to be encrypted. The resource names are derived from `resource` or `resource.group` of the group/version/resource. // eg: pandas.awesome.bears.example is a custom resource with 'group': awesome.bears.example, 'resource': pandas) </ins> Resources []string // providers is a list of transformers to be used for reading and writing the resources to disk. // eg: aesgcm, aescbc, secretbox, identity.

// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object <del> // EncryptionConfiguration stores the complete configuration for encryption providers. </del> <ins> /* EncryptionConfiguration stores the complete configuration for encryption providers. example: kind: EncryptionConfiguration apiVersion: apiserver.config.k8s.io/v1 resources: - resources: - secrets - configmaps - pandas.awesome.bears.example providers: - aescbc: keys: - name: key1 secret: c2VjcmV0IGlzIHNlY3VyZQ== */ </ins> type EncryptionConfiguration struct { metav1.TypeMeta // resources is a list containing resources, and their corresponding encryption providers.

// ResourceConfiguration stores per resource configuration. type ResourceConfiguration struct { <del> // resources is a list of kubernetes resources which have to be encrypted. </del> <ins> // resources is a list of kubernetes resources which have to be encrypted. The resource names are derived from `resource` or `resource.group` of the group/version/resource. // eg: pandas.awesome.bears.example is a custom resource with 'group': awesome.bears.example, 'resource': pandas) </ins> Resources []string `json:"resources"` // providers is a list of transformers to be used for reading and writing the resources to disk. // eg: aesgcm, aescbc, secretbox, identity.