jiebi/CodeConvo huggingface dataset:
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: kubectl version --client=yes command is giving the following error message. Error message is repeated at the start and the end and also containing programming jargon Error: invalid argument "yes" for "--client" flag: strconv.ParseBool: parsing "yes": invalid syntax Examples: Print the client and server versions for the current context kubectl version Options: --client=false: Client version only (no server required). -o, --output='': One of 'yaml' or 'json'. --short=false: Print just the version number. Usage: kubectl version [flags] [options] Use "kubectl options" for a list of global command-line options (applies to all commands). invalid argument "yes" for "--client" flag: strconv.ParseBool: parsing "yes": invalid syntax What you expected to happen: The error message can be improved with one of the two variants invalid argument "yes" for "--client" flag Examples: Print the client and server versions for the current context kubectl version Options: --client=false: Client version only (no server required). -o, --output='': One of 'yaml' or 'json'. --short=false: Print just the version number. Usage: kubectl version [flags] [options] Use "kubectl options" for a list of global command-line options (applies to all commands). (or) Invalid argument "yes" for "--client" flag How to reproduce it (as minimally and precisely as possible): Run the command kubectl version --client=yes Anything else we need to know?: Environment: Kubernetes version (use ): 1.15 Cloud provider or hardware configuration: AWS OS (e.g: ): Amazon Linux Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:
/sig cli
Hi Thanks for posting this issue! It turns out that this duplicate output has been in kubectl, and all the other cli cmds, since . This should be fixed by , and hopefully we can cherry pick it back to at least .

Discussion:
func main() { command := newCommand() if err := command.Execute(); err != nil { <del> fmt.Fprintf(os.Stderr, "error: %vn", err) </del> os.Exit(1) } }
Change:
<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: ci-kubernetes-e2e-gce-cos-k8sstable1-serial. Which test(s) are failing: [sig-network] DNS configMap nameserver [IPv4] Forward PTR lookup should forward PTR records lookup to upstream nameserver [Slow][Serial]. Since when has it been failing: 06-20. Testgrid link: Reason for failure: Anything else we need to know: The test is failing on master branch and all stable releases. cc since it would also block all following releases.
/triage unresolved Comment when the issue is assessed and confirmed. I am a bot run by vllry. ‍
cc:
This test is looking up PTR record for 8.8.8.8 and gets "", but is actually expecting "google-public-dns-" When I run the dig command on a non-k8s environment, I see "" as well. $ dig +short -x 8.8.8.8 Both "" and "google-public-dns-" resolve to 8.8.8.8. So looks like this test is not an actual failure.
Could you help to file a PR and fix the test case?
I'm on vacation for the next 2 weeks, so won't be able to look at it before that. Tagging
/assign
We are seeing the same issue in master branch: testgrid: job: ci-kubernetes-e2e-gci-gce-serial (adding for context for others) this one issue references the v1.14 ci jobs in: /milestone v1.16
this is failing back to 1.12 /reopen /assign filing cherry picks of fix
Reopened this issue. <detailsIn response to : this is failing back to 1.12 /reopen /assign filing cherry picks of fix Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
15 14 13 12
only 1.12 is missing
If this issue has been triaged, please comment . If you aren't able to handle this issue, consider unassigning yourself and/or adding the label. I am a bot run by vllry. ‍
12 is closed for patches /close
Closing this issue. <detailsIn response to : 1.12 is closed for patches /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
} var ( <del> googleDNSHostname = "google-public-dns-a.google.com" </del> <ins> googleDNSHostname = "dns.google" </ins> // The ConfigMap update mechanism takes longer than the standard // wait.ForeverTestTimeout. moreForeverTestTimeout = 2 * 60 * time.Second
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Got the following error while trying to run : How to reproduce it (as minimally and precisely as possible): Ran this on a fresh install of ubuntu 19.04, Go 1.12.6, and bazel 0.26.1. Anything else we need to know?: Seems like the change might have been due to the update in vendored deps from ( ). Although this script is run in CI where it is working so may be some set of recommende pkg versions would help prevent this problem? Environment: Cloud provider or hardware configuration: OS (e.g: ): ubuntu 19.04 Kernel (e.g. ): 5.0.0-15-generic bazel: 0.26.1 Go: 1.12.6
Not sure who owns this... /sig testing
Seems like the errors are "warnings" and can be ignored? It seems that BUILD files are properly updated by update-bazel, And bazel builds do work properly... /cc
/sig release this is not a failure /retitle hack/update-bazel produces warnings there was some discussion on the original PR about filtering them out but nothing conclusive I'll file a PR to do that now.. /assign
aside: this is actually from :-) we're working around the lack of support because we only need it for this package and on all known systems we compile on so far it only needs the one link flag as previously specified in the cgo config.
filed
Glad to see it. The output message is so misleading that I have spent hours on this issue
sorry about that the output does say "error" but it's actually considered a non-fatal warning in the upstream code and doesn't cause the script (or build) to fail.
was merged before this discussion was resolved , so we kinda saw this coming. :/ Hopefully we can get the fix from in merged as quick as possible
/reopen we have a new a new occurrence with libipmctl
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
I have the same question. This output is a bit annoying.
We can update the script to handle this issue and suppress the warning. The previous PR is an example. On Thu, Apr 16, 2020, 12:14 AM <:
/assign

Discussion:
done # Run gazelle to update Go rules in BUILD files. <ins> # filter out known pkg-config error (see buildozer workaround below) # NOTE: the `|| exit "${PIPESTATUS[0]}"` is to ignore grep errors # while preserving the exit code of gazelle </ins> gazelle fix  -external=vendored  -mode=fix  -repo_root "${KUBE_ROOT}"  <del> "${KUBE_ROOT}" </del> <ins> "${KUBE_ROOT}"  2>&1 | grep -Ev "vendor/github.com/seccomp/libseccomp-golang/seccomp(_internal)?.go: pkg-config not supported: #cgo pkg-config: libseccomp" || (exit "${PIPESTATUS[0]}") </ins> # Run kazel to update the pkg-srcs and all-srcs rules as well as handle # Kubernetes code generators.
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: LoadBalancer is stuck on pending state when annotation azure-load-balancer-resource-group is set to empty string. The error would be: Though the error message introduces some confusion here, it's actually because the resourceGroup name is missing when cloud provider trying to list publicIPs: What you expected to happen: The service should be provisioned successfully. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): 1.12.8 Cloud provider or hardware configuration: Azure OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others: /sig azure /kind bug /priority critical-urgent
/assign

Discussion:
func (az *Cloud) getPublicIPAddressResourceGroup(service *v1.Service) string { if resourceGroup, found := service.Annotations[ServiceAnnotationLoadBalancerResourceGroup]; found { <del> return resourceGroup </del> <ins> resourceGroupName := strings.TrimSpace(resourceGroup) if len(resourceGroupName) > 0 { return resourceGroupName } </ins> } return az.ResourceGroup

} } <ins> func TestGetPublicIPAddressResourceGroup(t *testing.T) { az := getTestCloud() for i, c := range []struct { desc        string annotations map[string]string expected    string }{ { desc:     "no annotation", expected: "rg", }, { desc:        "annoation with empty string resource group", annotations: map[string]string{ServiceAnnotationLoadBalancerResourceGroup: ""}, expected:    "rg", }, { desc:        "annoation with non-empty resource group ", annotations: map[string]string{ServiceAnnotationLoadBalancerResourceGroup: "rg2"}, expected:    "rg2", }, } { t.Run(c.desc, func(t *testing.T) { s := &v1.Service{} s.Annotations = c.annotations real := az.getPublicIPAddressResourceGroup(s) assert.Equal(t, c.expected, real, "TestCase[%d]: %s", i, c.desc) }) } } </ins> func TestGetServiceTags(t *testing.T) { tests := []struct { desc     string
Change:
<!-- Please only use this template for submitting enhancement requests --What would you like to be : Consider use schedulerCache to replace fields in PluginFactoryArgs ref: /assign
/sig scheduling /priority backlog

Discussion:
client clientset.Interface // a means to list all known scheduled pods. scheduledPodLister corelisters.PodLister <del> // a means to list all known scheduled pods and pods assumed to have been scheduled. podLister algorithm.PodLister </del> // a means to list all nodes nodeLister corelisters.NodeLister // a means to list all PersistentVolumes

c := &configFactory{ client:                         args.Client, <del> podLister:                      schedulerCache, </del> podQueue:                       internalqueue.NewSchedulingQueue(stopEverything, framework), nodeLister:                     args.NodeInformer.Lister(), pVLister:                       args.PvInformer.Lister(),

func (c *configFactory) getPluginArgs() (*PluginFactoryArgs, error) { return &PluginFactoryArgs{ <del> PodLister:                      c.podLister, </del> <ins> PodLister:                      c.schedulerCache, </ins> ServiceLister:                  c.serviceLister, ControllerLister:               c.controllerLister, ReplicaSetLister:               c.replicaSetLister,
Change:
error in update vendor after running Here is how you can repro on current head: 1- ./hack/pin- 2- hack/update- the test for empty bash array is broken, since bash considers it as an unset var.
/assign /sig release
/lifecycle active

Discussion:
# disallow transitive dependencies on k8s.io/kubernetes loopback_deps=() kube::util::read-array loopback_deps < <(go list all 2>/dev/null | grep k8s.io/kubernetes/ || true) <del> if [[ -n "${loopback_deps[*]}" ]]; then </del> <ins> if [[ -n ${loopback_deps[*]:+"${loopback_deps[*]}"} ]]; then </ins> kube::log::error "Disallowed ${repo} -> k8s.io/kubernetes dependencies exist via the following imports: $(go mod why "${loopback_deps[@]}")" exit 1
Change:
is an experimental feature that lets Kubernetes control plane know about a pod being a critical pod by adding a specific annotation to the pod. This was in 1.5 when K8s didn't have pod priority. Pod priority allows us to mark pods as critical with our first-class API. As a result, this feature was deprecated in 1.13. We can now remove the feature from our code base. /sig scheduling /sig node
/assign
/reopen
Reopened this issue. <detailsIn response to : /reopen Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
metadata: name: l7-lb-controller namespace: kube-system <del> annotations: scheduler.alpha.kubernetes.io/critical-pod: '' </del> labels: k8s-app: gcp-lb-controller kubernetes.io/name: "GLBC"

}, Template: v1.PodTemplateSpec{ ObjectMeta: metav1.ObjectMeta{ <del> Annotations: map[string]string{ "scheduler.alpha.kubernetes.io/critical-pod": "", }, </del> Labels: labels, }, Spec: v1.PodSpec{ <ins> PriorityClassName: "system-node-critical", </ins> Tolerations: []v1.Toleration{ { Key:      "CriticalAddonsOnly",
Change:
What happened: When two or more images on a given node have the same size, their order inside the field set by the process is not deterministic. This problem has the side effect of continually triggering controllers which assume this list to be always equal on node updates unless images are or removed. What you expected to happen: The order of images should be stable even when two images have the same size, using the image ID as a second sort field would help this. How to reproduce it (as minimally and precisely as possible): Choose a node and run: Run a few times: It should be possible to see and images alternating on the output. Anything else we need to know?: Our particular use case make it really common for multiple images to have the same size on a given node. I came across this problem while debugging slow updates to DaemonSets and finding out that the kube-controller-manager was leaking memory until it eventually dies due to OOM: <img width="800" alt="Screen Shot 2019-06-30 at 20 27 22" src="https://user-"I was able to track this leak to a large number of watched elements in memory and by taking a look at the logs with increased verbosity I figured it was due to too many Node notifications being processed by the DaemonSet controller: <img width="800" alt="Screen Shot 2019-06-30 at 20 36 23" src="https://user-"It's possible that other controllers in the wild that watch nodes and only ignore the conditions timestamps on updates to face the same problem. I'll send a simple PR to fix this shortly. Environment: Kubernetes version (use ): But by taking a look at the code this problem also happens on master.
/sig node
Nice debugging here :)

Discussion:
type ByImageSize []kubecontainer.Image func (a ByImageSize) Less(i, j int) bool { <ins> if a[i].Size == a[j].Size { return a[i].ID > a[j].ID } </ins> return a[i].Size > a[j].Size } func (a ByImageSize) Len() int      { return len(a) }

RepoDigests: []string{"foo-rd31", "foo-rd32"}, Size:        3, }, <ins> { ID:          "4", RepoTags:    []string{"foo-tag41", "foo-tag42"}, RepoDigests: []string{"foo-rd41", "foo-rd42"}, Size:        3, }, </ins> } }

el     int }{ {[]kubecontainer.Image{}, 0}, <del> {buildByImageSize(), 3}, </del> <ins> {buildByImageSize(), 4}, </ins> {nil, 0}, }

// descending order {buildByImageSize(), 0, 2, false}, {buildByImageSize(), 1, 0, true}, <ins> {buildByImageSize(), 3, 2, true}, </ins> } for _, fooTest := range fooTests {
Change:
<!-- Please only use this template for submitting reports about failing tests in Kubernetes CI jobs --Which jobs are failing: pull-kubernetes-e2e-aks-engine-azure Which test(s) are failing: Since when has it been failing: Testgrid link: No Testgrid, but job history: Reason for failure: Anything else we need to know: ref:
/assign cc: /milestone v1.16 /priority important-soon
/sig azure
cc
Related with
Update: has been merged, but a new release with this change is not available yet. Pending on aks-engine's next release.
/sig cloud-provider
v1.16.0-alpha.1 is available in
Will submit a PR after testing this in our own prow first.

Discussion:
package glusterfs import ( <del> "math/rand" </del> "os" <ins> "path" </ins> "github.com/golang/glog" "k8s.io/kubernetes/pkg/api"

options = append(options, "ro") } <del> l := len(b.hosts.Subsets) </del> <ins> p := path.Join(b.glusterfs.plugin.host.GetPluginDir(glusterfsPluginName), b.glusterfs.volName) if err := os.MkdirAll(p, 0750); err != nil { return err } log := path.Join(p, "glusterfs.log") options = append(options, "log-file="+log) addr := make(map[string]struct{}) for _, s := range b.hosts.Subsets { for _, a := range s.Addresses { addr[a.IP] = struct{}{} } } </ins> // Avoid mount storm, pick a host randomly. <del> start := rand.Int() % l </del> // Iterate all hosts until mount succeeds. <del> for i := start; i < start+l; i++ { hostIP := b.hosts.Subsets[i%l].Addresses[0].IP </del> <ins> for hostIP := range addr { </ins> errs = b.mounter.Mount(hostIP+":"+b.path, dir, "glusterfs", options) if errs == nil { return nil
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: TestUnreservePlugin is flaky: What you expected to happen: Test to always pass. How to reproduce it (as minimally and precisely as possible): This is a flaky test, but the issue is that the unreserve plugin didn't get the change to execute before the test checked the unreserve call counter in the test. Assuming thread1 runs the scheduler, thread2 runs the tests, here is the sequence that caused this flake: thread2 creates a pod and blocks on a . thread1 tries to schedule the pod, executing the pre-bind plugin which denies the pod and . thread2 gets unblocked before thread1 gets to . Thread2 checks the counters, throwing an error since unreserve plugin call counter didn't get to be incremented. What we need is for the test to block until unreserve is called, not until we get a scheduling error. /sig scheduling
/help
This request has been marked as needing help from a contributor. Please ensure the request meets the requirements listed . If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /help </details
cc/

Discussion:
if forgetErr := sched.Cache().ForgetPod(assumedPod); forgetErr != nil { klog.Errorf("scheduler cache ForgetPod failed: %v", forgetErr) } <del> sched.recordSchedulingFailure(assumedPod, permitStatus.AsError(), reason, permitStatus.Message()) </del> // trigger un-reserve plugins to clean up state associated with the reserved Pod fwk.RunUnreservePlugins(pluginContext, assumedPod, scheduleResult.SuggestedHost) <ins> sched.recordSchedulingFailure(assumedPod, permitStatus.AsError(), reason, permitStatus.Message()) </ins> return }

if forgetErr := sched.Cache().ForgetPod(assumedPod); forgetErr != nil { klog.Errorf("scheduler cache ForgetPod failed: %v", forgetErr) } <del> sched.recordSchedulingFailure(assumedPod, prebindStatus.AsError(), reason, prebindStatus.Message()) </del> // trigger un-reserve plugins to clean up state associated with the reserved Pod fwk.RunUnreservePlugins(pluginContext, assumedPod, scheduleResult.SuggestedHost) <ins> sched.recordSchedulingFailure(assumedPod, prebindStatus.AsError(), reason, prebindStatus.Message()) </ins> return }
Change:
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via --What happened: Default scheduler crash if scheduler extender filter returns a not found node What you expected to happen: Default scheduler just should consider the not found node as not an candidate, instead of crash itself (panic). How to reproduce it (as minimally and precisely as possible): cluster only have 1 node: 0.0.0.1 scheduler extender (with nodeCacheCapable enabled) filter accidentally returns a candidate node: 0.0.0.2 scheduler recieved the candidate nodes: 0.0.0.2 from scheduler extender, but got below error: The is SuggestedHost: filteredNodes[0].Name: Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration: OS (e.g: ): Kernel (e.g. ): Install tools: Network plugin and version (if this is a network-related bug): Others:
/sig scheduling

Discussion:
} // Filter based on extender implemented predicate functions. The filtered list is <del> // expected to be a subset of the supplied list. failedNodesMap optionally contains // the list of failed nodes and failure reasons. </del> <ins> // expected to be a subset of the supplied list; otherwise the function returns an error. // failedNodesMap optionally contains the list of failed nodes and failure reasons. </ins> func (h *HTTPExtender) Filter( pod *v1.Pod, nodes []*v1.Node, nodeNameToInfo map[string]*schedulernodeinfo.NodeInfo,

} if h.nodeCacheCapable && result.NodeNames != nil { <del> nodeResult = make([]*v1.Node, 0, len(*result.NodeNames)) for i := range *result.NodeNames { nodeResult = append(nodeResult, nodeNameToInfo[(*result.NodeNames)[i]].Node()) </del> <ins> nodeResult = make([]*v1.Node, len(*result.NodeNames)) for i, nodeName := range *result.NodeNames { if node, ok := nodeNameToInfo[nodeName]; ok { nodeResult[i] = node.Node() } else { return nil, nil, fmt.Errorf( "extender %q claims a filtered node %q which is not found in nodeNameToInfo map", h.extenderURL, nodeName) } </ins> } } else if result.Nodes != nil { <del> nodeResult = make([]*v1.Node, 0, len(result.Nodes.Items)) </del> <ins> nodeResult = make([]*v1.Node, len(result.Nodes.Items)) </ins> for i := range result.Nodes.Items { <del> nodeResult = append(nodeResult, &result.Nodes.Items[i]) </del> <ins> nodeResult[i] = &result.Nodes.Items[i] </ins> } }

node, victims, nominatedPodsToClear, err := sched.config.Algorithm.Preempt(preemptor, sched.config.NodeLister, scheduleErr) if err != nil { <del> klog.Errorf("Error preempting victims to make room for %v/%v.", preemptor.Namespace, preemptor.Name) </del> <ins> klog.Errorf("Error preempting victims to make room for %v/%v: %v", preemptor.Namespace, preemptor.Name, err) </ins> return "", err } var nodeName = ""
Change:
What happened: There is a duplicate row in the Changelog for v1.12.7 How to reproduce it (as minimally and precisely as possible): the first and the fourth row are exactly the same. /sig docs

Discussion:
* Connections from Pods to Services with 0 endpoints will now ICMP reject immediately, rather than blackhole and timeout. ([#72534](https://github.com/kubernetes/kubernetes/pull/72534), [@thockin](https://github.com/thockin)) * Services of type=LoadBalancer which have no endpoints will now immediately ICMP reject connections, rather than time out. ([#74394](https://github.com/kubernetes/kubernetes/pull/74394), [@thockin](https://github.com/thockin)) * Ensure the backend pools are set correctly for Azure SLB with multiple backend pools (e.g. outbound rules) ([#76691](https://github.com/kubernetes/kubernetes/pull/76691), [@feiskyer](https://github.com/feiskyer)) <del> * Connections from Pods to Services with 0 endpoints will now ICMP reject immediately, rather than blackhole and timeout. ([#72534](https://github.com/kubernetes/kubernetes/pull/72534), [@thockin](https://github.com/thockin)) </del> * Services of type=LoadBalancer which have no endpoints will now immediately ICMP reject connections, rather than time out. ([#74394](https://github.com/kubernetes/kubernetes/pull/74394), [@thockin](https://github.com/thockin)) * fix race condition issue for smb mount on windows ([#75371](https://github.com/kubernetes/kubernetes/pull/75371), [@andyzhangx](https://github.com/andyzhangx)) * fix smb unmount issue on Windows ([#75087](https://github.com/kubernetes/kubernetes/pull/75087), [@andyzhangx](https://github.com/andyzhangx))