jiebi/CodeConvo huggingface dataset:
Change:
sig-release master-blocking build-masterci-kubernetes-build.Overall 2022-06-01 20:49 CEST, commit No response /sig release cc
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
I'm checking that
/assign
this pr should fix
it looks like it's still failing: https://k8s-
/reopen reopening as this is causing all our CI to run against stale artifacts at: v1.25.0-alpha.0.734+
Reopened this issue. <detailsIn response to : /reopen v1.25.0-alpha.0.734+ </details
my previous fix only fixed one side of the things, missing now job are green ! closing for now /close
Closing this issue. <detailsIn response to : my previous fix only fixed one side of the things, missing now job are green /close Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
thank you !

Discussion:
s.mux.Handle("/logs/", http.StripPrefix("/logs/", http.FileServer(http.Dir("/var/log/")))) s.mux.HandleFunc(s.prefix+"/", s.ServeREST) healthz.InstallHandler(s.mux) <del> s.mux.HandleFunc("/index.html", s.handleIndex) </del> <ins> s.mux.HandleFunc("/", s.handleIndex) </ins> // Handle both operations and operations/* with the same handler s.mux.HandleFunc(s.operationPrefix(), s.handleOperationRequest)

s.mux.HandleFunc(s.watchPrefix()+"/", s.handleWatch) <del> s.mux.HandleFunc("/", s.notFound) </del> s.mux.HandleFunc("/proxy/minion/", s.handleMinionReq) return s

} func (server *APIServer) handleIndex(w http.ResponseWriter, req *http.Request) { <ins> if req.URL.Path != "/" && req.URL.Path != "/index.html" { server.notFound(w, req) return } </ins> w.WriteHeader(http.StatusOK) // TODO: serve this out of a file? data := "<html><body>Welcome to Kubernetes</body></html>"
Change:
This page explains that the deleteFromPrimitiveList should delete the specified items, but the specified items are kept, and the other items are deleted. The specified items in the deleteFromPrimitiveList should be removed. The result should be instead: No response <details</details<details</details<details</details<details</details<details</details<details</details
/sig api-machinery
Related:
/assign Could you take a look Antoine please? Thanks! /triage accepted
Simplest way to reproduce: It doesn't work with any kubectl version from 1.18 to 1.23 that I've tested.
I tried the exact same object, changing the finalizers works like a charm.
cc Want to give this one a try? :-)
Sure, I'll take a look at it... /assign
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:
/remove-lifecycle stale
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:
/remove-lifecycle stale

Discussion:
return nil, err } <del> if fieldPatchStrategy == mergeDirective { </del> <ins> // Delete lists are handled the same way regardless of what the field's patch strategy is if fieldPatchStrategy == mergeDirective || isDeleteList { </ins> return mergeSlice(typedOriginal, typedPatch, schema, fieldPatchMergeKey, mergeOptions, isDeleteList) } else { return typedPatch, nil

`), }, }, <ins> { Description: "$deleteFromPrimitiveList should delete item from a list with merge patch strategy", StrategicMergePatchRawTestCaseData: StrategicMergePatchRawTestCaseData{ Original: []byte(` mergingIntList: - 1 - 2 - 3 `), TwoWay: []byte(` $deleteFromPrimitiveList/mergingIntList: - 2 `), Modified: []byte(` mergingIntList: - 1 - 3 `), }, }, { Description: "$deleteFromPrimitiveList should delete item from a list without merge patch strategy", StrategicMergePatchRawTestCaseData: StrategicMergePatchRawTestCaseData{ Original: []byte(` nonMergingIntList: - 1 - 2 - 3 `), TwoWay: []byte(` $deleteFromPrimitiveList/nonMergingIntList: - 2 `), Modified: []byte(` nonMergingIntList: - 1 - 3 `), }, }, </ins> } func TestCustomStrategicMergePatch(t *testing.T) {
Change:
The existing validating webhook PKI configurations fail on Kubernetes v1.24 due to Pod security webhook information example: Example API server error: Additionally: Date is not being interpolated in CA cert CN : "pod-security-webhook-ca-" CA Cert example information:
/transfer kubernetes /sig auth /kind bug
/help
This request has been marked as needing help from a contributor. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /help Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/triage accepted
Fixed in
Thank you

Discussion:
rm -fr pki mkdir -p pki openssl genrsa -out pki/ca.key 2048 <del> openssl req -new -x509 -days 3650 -key pki/ca.key -subj "/CN=pod-security-webhook-ca-$(date +%s)" -out pki/ca.crt </del> <ins> openssl req -sha256 -new -x509 -days 3650 -key pki/ca.key -subj "/CN=pod-security-webhook-ca-$(shell date +%s)" -out pki/ca.crt </ins> <del> openssl req -newkey rsa:2048 -nodes -keyout pki/tls.key -subj "/CN=webhook.pod-security-webhook.svc" -out pki/tls.csr </del> <ins> openssl req -sha256 -newkey rsa:2048 -nodes -keyout pki/tls.key -subj "/CN=webhook.pod-security-webhook.svc" -out pki/tls.csr </ins> echo "subjectAltName=DNS:webhook.pod-security-webhook.svc" > pki/extensions.txt echo "extendedKeyUsage=serverAuth" >> pki/extensions.txt <del> openssl x509 -req -extfile pki/extensions.txt -days 730 -in pki/tls.csr -CA pki/ca.crt -CAkey pki/ca.key -CAcreateserial -out pki/tls.crt </del> <ins> openssl x509 -sha256 -req -extfile pki/extensions.txt -days 730 -in pki/tls.csr -CA pki/ca.crt -CAkey pki/ca.key -CAcreateserial -out pki/tls.crt </ins> # Publishes the PodSecurity webhook Docker image to the configured registry. push:
Change:
The should not be used for file paths. For example, Dir is supposed to return all but the last element of the path. For the path. Instead of these functions, the ones in ` should be used instead. Example: /sig windows N/A N/A <details</details<details</details<details</details<details</details
/sig windows
/triage accepted /milestone v1.26
Hello . Bug Triage team here. I wanted to touch base to see if this ticket would be targeted for the 1.26 release.

Discussion:
import ( "errors" "os" <del> "path" </del> "path/filepath" "strings" "testing"

for _, item := range test.items { if strings.HasSuffix(item, "/") { item = strings.TrimRight(item, "/") <del> if err = os.Mkdir(path.Join(tmpDir, item), 0777); err != nil { </del> <ins> if err = os.Mkdir(filepath.Join(tmpDir, item), 0777); err != nil { </ins> t.Fatalf("error creating %s: %v", item, err) } } else { <del> f, err := os.Create(path.Join(tmpDir, item)) </del> <ins> f, err := os.Create(filepath.Join(tmpDir, item)) </ins> if err != nil { t.Fatalf("error creating %s: %v", item, err) }

"fmt" "io/fs" "os" <del> "path" </del> "path/filepath" "strings" "syscall"

} } <del> return path.Base(mountPath), nil </del> <ins> return filepath.Base(mountPath), nil </ins> } // DeviceOpened determines if the device is in use elsewhere
Change:
When running kubelet, if the Run function fails, the returned error has no output, and the cause of the error cannot be located. such as After the error is returned, there is no position output, so the user cannot know the cause of the error. But previous versions had log output Run the Run function, when there is an error exit, print the error log Misconfigured cgroupRoot No response <details</details<details</details<details</details<details</details<details</details<details</details
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
/sig node
/cc

Discussion:
import ( "os" <del> "github.com/spf13/cobra" </del> "k8s.io/component-base/cli" <del> cliflag "k8s.io/component-base/cli/flag" </del> _ "k8s.io/component-base/logs/json/register" // for JSON log format registration _ "k8s.io/component-base/metrics/prometheus/restclient" _ "k8s.io/component-base/metrics/prometheus/version" // for version metric registration

func main() { command := app.NewKubeletCommand() <del> // kubelet uses a config file and does its own special // parsing of flags and that config file. It initializes // logging after it is done with that. Therefore it does // not use cli.Run like other, simpler commands. code := run(command) </del> <ins> code := cli.Run(command) </ins> os.Exit(code) } <del> func run(command *cobra.Command) int { command.SetGlobalNormalizationFunc(cliflag.WordSepNormalizeFunc) return cli.Run(command) } </del>
Change:
When is set to a value other than the default value (/etc/kubernetes/pki/), and run on the working kubernetes controller node, the cert is not renewed as expected. This impacts the as well. or work as expected. Here is an example which show cert renew doesn't work, create a cert,and then renew the cert,check if the cert is renewed, It actually renewed the cert in the default path(/etc/kubernetes/pki/), The issue can be revealed by the test as well, NOTE This issue only exist with a working cluster since the code will fall back to use the cluster configuration when config file is not specified. And if the cluster cannot be connected with the , the will be honored, this is why the test can pass with the CI jobs. Check the log printed by this test pr: No response <details</details<detailslocal </details<details</details<details</details<details</details<details</details
/assign
/sig cluster-lifecycle
/area kubeadm
/triage accepted

Discussion:
"github.com/spf13/pflag" "k8s.io/apimachinery/pkg/util/duration" <ins> "k8s.io/klog/v2" </ins> kubeadmapi "k8s.io/kubernetes/cmd/kubeadm/app/apis/kubeadm" kubeadmscheme "k8s.io/kubernetes/cmd/kubeadm/app/apis/kubeadm/scheme"

internalcfg, err := configutil.FetchInitConfigurationFromCluster(client, nil, logPrefix, false, false) if err == nil { fmt.Println() // add empty line to separate the FetchInitConfigurationFromCluster output from the command output <ins> // certificate renewal or expiration checking doesn't depend on a running cluster, which means the CertificatesDir // could be set to a value other than the default value or the value fetched from the cluster. // cfg.CertificatesDir could be empty if the default value is set to empty (not true today). if len(cfg.CertificatesDir) != 0 { klog.V(1).Infof("Overriding the cluster certificate directory with the value from command line flag --%s: %s", options.CertificatesDir, cfg.CertificatesDir) internalcfg.ClusterConfiguration.CertificatesDir = cfg.CertificatesDir } </ins> return internalcfg, nil } fmt.Printf("[%s] Error reading configuration from the Cluster. Falling back to default configurationnn", logPrefix)
Change:
prints out some warning messsage: And the pod on that node is not removed eventually. all the pods could be removed at last. Have a crictl installed on the node with the config like this, And then run below command, No response <details</details<details</details<details</details<details</details<details</details<details</details
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig cluster-lifecycle /assign
The root cause is that when the debug mode is configured, will print out some debug message, e.g. DEBU[0000] get runtime connection DEBU[0000] ListPodSandboxRequest: &ListPodSandboxRequest{Filter:&PodSandboxFilter{Id:,State:nil,LabelSelector:map[string]string{},},} DEBU[0000] ListPodSandboxResponse: While our code interpret everything here as a Pod ID and try to rm them.
We cannot stop other to enable the debug mode for but we should ignore those debug message in our code.

Discussion:
// ListKubeContainers lists running k8s CRI pods func (runtime *CRIRuntime) ListKubeContainers() ([]string, error) { <del> out, err := runtime.crictl("pods", "-q").CombinedOutput() </del> <ins> // Disable debug mode regardless how the crictl is configured so that the debug info won't be // iterpreted to the Pod ID. args := []string{"-D=false", "pods", "-q"} out, err := runtime.crictl(args...).CombinedOutput() </ins> if err != nil { return nil, errors.Wrapf(err, "output: %s, error", string(out)) }
Change:
Hello, the SRC folks asked that I file this publicly: In the client-go repo, , function creates a private key and stores it into a file with mode : Typically keys are created with more restrictive modes to prevent other users or services on the system from being able to copy them before the user fixes the permissions. Of course, if a more restrictive umask is in place, this may not be a big deal, but it's an extremely fickle piece of the environment to rely upon for security. It's better to be explicit. Thanks
/kind bug Not sure if this is /sig api-machinery or /sig auth
is this related to us?
Hi IMO, mode make sense for the key file. I would like to work on this, waiting for Thanks!!
/triage accepted
/assign
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules: After 90d of inactivity, is applied After 30d of inactivity since was applied, is applied After 30d of inactivity since was applied, the issue is closed You can: Mark this issue or PR as fresh with Mark this issue or PR as rotten with Close this issue or PR with Offer to help out with [Issue Triage][1] Please send feedback to sig-contributor-experience at . /lifecycle stale [1]:
/remove-lifecycle stale
/lifecycle frozen /good-first-issue I think changing the code to use should be fine. Anyone is free to pick this up. Would be good to include a unit test.
This request has been marked as suitable for new contributors. Please ensure that the issue body includes answers to the following questions: Why are we solving this issue? To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points? Does this issue have zero to low barrier of entry? How can the assignee reach out to you for help? For more details on the requirements of such an issue, please see and ensure that they are met. If this request no longer meets these requirements, the label can be removed by commenting with the command. <detailsIn response to : /lifecycle frozen /good-first-issue Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/assign
Hello, this is my first ever open source contribution. I am trying to understand and get this fixed. Any suggestions would be helpful!
/assign
/assign

Discussion:
if err := os.WriteFile(certFixturePath, certBuffer.Bytes(), 0644); err != nil { return nil, nil, fmt.Errorf("failed to write cert fixture to %s: %v", certFixturePath, err) } <del> if err := os.WriteFile(keyFixturePath, keyBuffer.Bytes(), 0644); err != nil { </del> <ins> if err := os.WriteFile(keyFixturePath, keyBuffer.Bytes(), 0600); err != nil { </ins> return nil, nil, fmt.Errorf("failed to write key fixture to %s: %v", certFixturePath, err) } }
Change:
When upgrade cluster to kubernetes 1.20.15 on Azure platform, I still hit "instance not found" error when ensureHostInPool, and this leads to one of the backend pool members missing since then, users have to add the member back manually. Below is the error: The Detected change in list of current cluster nodes should be in size of 90, but actually it only has 89 nodes here. The symptom matches issue and the But the fix may be incomplete. I expected the "instance not found" error will not affect backend pool members management, and it's ignored somewhere in either or (1.20.15) By upgrading the cluster and trigger the VM recreation, and this may not be easy to reproduce, but it indeed happens several times in our environment <details20.15 </details<detailslegacy Azure cloud provider </details
Hi as you previously worked on the similar issue, could you please kindly help take a look? Thank you in advance!
/sig cloud-provider /area provider/azure /priority critical-urgent
20.x is not a supported version. Could you upgrade to latest supported version?
Hi thank you for reply! Do you mean that this could be already fixed in latest version? I'm not sure if my understanding is correct, but if the issue exists in 1.20.x, even latest version does not ignore this error in the specific place.
yes, please upgrade the version to 1.22 or above with out-of-tree cloud provider
Hi sorry, I don't mean AKS by Azure platform, in fact this is a VMware product built upon Azure, is it possible to port the fix to in-tree cloud provider? That would be great if it's doable, if not, or could you please help point out the fix, maybe we could rase a PR for the in-tree cloud provider. Thank you!
We're still on in-tree cloud provider even if it's upgraded to 1.22.
The error we saw is thrown in this code it appears in out-of-tree code, this still could lead to the issue.
/remove-priority critical-urgent please don't set priorities, those are meant to be used by the community members that triage the issue
Sorry, I copied from previous issue.
are you using VMSS, VMAS or standalone VM?
this is our config, sorry, how do I know which kind of it is?
primaryAvailabilitySetName means the cluster is using VMAS. Per the codes , the issue probably still exists. could you help for the fix? /assign
Thank you for confirming! That's what I'm worried about.
/triage accepted

Discussion:
lbStatus, err := az.getServiceLoadBalancerStatus(service, lb) if err != nil { klog.Errorf("getServiceLoadBalancerStatus(%s) failed: %v", serviceName, err) <del> return nil, err </del> <ins> if err != cloudprovider.InstanceNotFound { return nil, err } </ins> } var serviceIP *string

} klog.Errorf("error: az.EnsureHostInPool(%s), az.VMSet.GetPrimaryInterface.Get(%s, %s), err=%v", nodeName, vmName, vmSetName, err) <del> return "", "", "", nil, err </del> <ins> if err != cloudprovider.InstanceNotFound { return "", "", "", nil, err } </ins> } if nic.ProvisioningState != nil && *nic.ProvisioningState == nicFailedState {
Change:
Change the fallback consumption from to when pod metrics are missing on a scale down. Background from : The fallback value of 100% is supposed to be a safe overestimate of the desired value to dampen the magnitude of a potential scale down. However, if a metric target is set to more than 100% then this fallback typically becomes an underestimate that amplifies a potential scale down. Note that a metric target of over 100% is a valid HPA configuration. We could choose a fallback of instead. However, any safety margin would be arbitrary and I think it's better to opt for simplicity vs. precision in this corner case.
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the label and provide further guidance. The label can be by org members by writing in a comment. <detailsInstructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/sig autoscaling
/assign
/assign

Discussion:
if len(missingPods) > 0 { if usageRatio < 1.0 { <del> // on a scale-down, treat missing pods as using 100% of the resource request </del> <ins> // on a scale-down, treat missing pods as using 100% (all) of the resource request // or the utilization target for targets higher than 100% fallbackUtilization := int64(max(100, targetUtilization)) </ins> for podName := range missingPods { <del> metrics[podName] = metricsclient.PodMetric{Value: requests[podName]} </del> <ins> metrics[podName] = metricsclient.PodMetric{Value: requests[podName] * fallbackUtilization / 100} </ins> } } else if usageRatio > 1.0 { // on a scale-up, treat missing pods as using 0% of the resource request

if len(missingPods) > 0 { if usageRatio < 1.0 { <del> // on a scale-down, treat missing pods as using 100% of the resource request </del> <ins> // on a scale-down, treat missing pods as using exactly the target amount </ins> for podName := range missingPods { metrics[podName] = metricsclient.PodMetric{Value: targetUtilization} }

tc.runTest(t) } <ins> func TestReplicaCalcMissingMetricsScaleDownTargetOver100(t *testing.T) { tc := replicaCalcTestCase{ currentReplicas:  4, expectedReplicas: 2, podReadiness:     []v1.ConditionStatus{v1.ConditionFalse, v1.ConditionTrue, v1.ConditionTrue, v1.ConditionTrue}, resource: &resourceInfo{ name:     v1.ResourceCPU, requests: []resource.Quantity{resource.MustParse("1.0"), resource.MustParse("1.0"), resource.MustParse("2.0"), resource.MustParse("2.0")}, levels:   makePodMetricLevels(200, 100, 100), targetUtilization:   300, expectedUtilization: 6, expectedValue:       numContainersPerPod * 100, }, } tc.runTest(t) } </ins> func TestReplicaCalcDuringRollingUpdateWithMaxSurge(t *testing.T) { tc := replicaCalcTestCase{ currentReplicas:  2,