jiebi/CodeConvo huggingface dataset:
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --/kind bug Got two different failure scenarios: ://k8s- ://k8s- /cc Please reassign if the above is wrong. Thanks!
There are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals
Both these failures seems to be test infra issues IIUC. There are no failures in the GPU related logic.
/cc
Seems like it's fixed in
Yes, the PR GPU job had a flake with reusing a build which is a new feature that all e2e jobs will use soon. Hopefully it should be fixed now.
Once gets picked up things should be fixed. I'm still monitoring this. /assign
I have a PR out to revert using shared builds since rolling out an updated CI image will take a bit longer and the patch to kubetest needs to be rolled out.
/sig testing
This is fixed. /close

Discussion:
type testResult bool func init() { <del> // Turn off colors by default to make it easier to collect console output in Jenkins // Override colors off with --ginkgo.noColor=false in the command-line config.DefaultReporterConfig.NoColor = true </del> // Turn on verbose by default to get spec names config.DefaultReporterConfig.Verbose = true <ins> // Turn on EmitSpecProgress to get spec progress (especially on interrupt) config.GinkgoConfig.EmitSpecProgress = true </ins> // Randomize specs as well as suites config.GinkgoConfig.RandomizeAllSpecs = true }
Change:
The debian-based CVM image is going to be deprecated in September. We should: Change the default OS image for GCE cluster setup script. This means that all the GCE CI builds will use the new default OS image. Add deprecation warning to the cluster setup script if CVM is specified. Maintain the node e2e test coverage for CVM for 1.8. /cc
Issues go stale after 90d of inactivity. Mark the issue as fresh with . Stale issues rot after an additional 30d of inactivity and eventually close. Prevent issues from auto-closing with an comment. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle stale
Stale issues rot after 30d of inactivity. Mark the issue as fresh with . Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with . Send feedback to sig-testing, kubernetes/test-infra and/or . /lifecycle rotten /remove-lifecycle stale
The CVM tests were turned off a while ago.

Discussion:
# Also please update corresponding image for node e2e at: # https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/jenkins/image-config.yaml CVM_VERSION=${CVM_VERSION:-container-vm-v20170627} <del> GCI_VERSION=${KUBE_GCI_VERSION:-cos-stable-60-9592-84-0} </del> <ins> GCI_VERSION=${KUBE_GCI_VERSION:-cos-stable-60-9592-90-0} </ins> MASTER_IMAGE=${KUBE_GCE_MASTER_IMAGE:-} MASTER_IMAGE_PROJECT=${KUBE_GCE_MASTER_PROJECT:-cos-cloud} NODE_IMAGE=${KUBE_GCE_NODE_IMAGE:-${GCI_VERSION}}

KUBE_DELETE_NETWORK=${KUBE_DELETE_NETWORK:-true} MASTER_OS_DISTRIBUTION=${KUBE_MASTER_OS_DISTRIBUTION:-${KUBE_OS_DISTRIBUTION:-gci}} <del> NODE_OS_DISTRIBUTION=${KUBE_NODE_OS_DISTRIBUTION:-${KUBE_OS_DISTRIBUTION:-debian}} </del> <ins> NODE_OS_DISTRIBUTION=${KUBE_NODE_OS_DISTRIBUTION:-${KUBE_OS_DISTRIBUTION:-gci}} </ins> if [[ "${MASTER_OS_DISTRIBUTION}" == "coreos" ]]; then MASTER_OS_DISTRIBUTION="container-linux" fi

fi # By default a cluster will be started with the master and nodes <del> # on Container-VM, the deprecated OS. Some tests assume container-VM, # and only when that is fixed can we use Container-Optimized OS # (cos, gci) as we do in config-default.sh. </del> <ins> # on Container-optimized OS (cos, previously known as gci). If # you are updating the os image versions, update this variable. </ins> # Also please update corresponding image for node e2e at: # https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/jenkins/image-config.yaml CVM_VERSION=${CVM_VERSION:-container-vm-v20170627} <del> GCI_VERSION=${KUBE_GCI_VERSION:-cos-stable-60-9592-84-0} </del> <ins> GCI_VERSION=${KUBE_GCI_VERSION:-cos-stable-60-9592-90-0} </ins> MASTER_IMAGE=${KUBE_GCE_MASTER_IMAGE:-} MASTER_IMAGE_PROJECT=${KUBE_GCE_MASTER_PROJECT:-cos-cloud} NODE_IMAGE=${KUBE_GCE_NODE_IMAGE:-${CVM_VERSION}}

MASTER_OS_DISTRIBUTION=${KUBE_MASTER_OS_DISTRIBUTION:-gci} NODE_OS_DISTRIBUTION=${KUBE_NODE_OS_DISTRIBUTION:-gci} <del> MASTER_IMAGE=${KUBE_GCE_MASTER_IMAGE:-cos-stable-60-9592-84-0} </del> <ins> MASTER_IMAGE=${KUBE_GCE_MASTER_IMAGE:-cos-stable-60-9592-90-0} </ins> MASTER_IMAGE_PROJECT=${KUBE_GCE_MASTER_PROJECT:-cos-cloud} NETWORK=${KUBE_GCE_NETWORK:-e2e}
Change:
Just saw this while running kube master locally: Yet to investigate more closely and check which PR could have introduced this. cc
/sig node
any way to repro?
I think I can fix this error.
what is the bug?
I think when call nc.taintManager has not been inited
duplicate of , fixed by
I found does not have related fix.
It fixes the issue systemically by not starting the informers until all controllers have finished setting up
Ok by more carefully read, I see.
fixed by

Discussion:
} if nc.runTaintManager { <ins> nc.taintManager = scheduler.NewNoExecuteTaintManager(kubeClient) </ins> nodeInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{ AddFunc: util.CreateAddNodeHandler(func(node *v1.Node) error { nc.taintManager.NodeUpdated(nil, node)

return nil }), }) <del> nc.taintManager = scheduler.NewNoExecuteTaintManager(kubeClient) </del> } nc.nodeLister = nodeInformer.Lister()
Change:
says "Before persisting the object to storage, clear disabled alpha fields". There is that actually implements it but there are some discussions about it. This issues is a reminder that introduced by needs to be cleared too when the discussion in settles down. /assign
There are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals
/sig api-machinery
kind/cleanup priority/important-soon
[MILESTONENOTIFIER] Milestone Labels Complete Issue label settings: sig/api-machinery: Issue will be escalated to these SIGs if needed. priority/important-soon: Escalate to the issue owners and SIG owner; move out of milestone after several unsuccessful escalation attempts. kind/bug: Fixes a bug discovered during the current release. <detailsAdditional instructions available <a href=""here</a</details

Discussion:
} } } <ins> for i := range podSpec.Containers { DropDisabledVolumeMountsAlphaFields(podSpec.Containers[i].VolumeMounts) } for i := range podSpec.InitContainers { DropDisabledVolumeMountsAlphaFields(podSpec.InitContainers[i].VolumeMounts) } } // DropDisabledVolumeMountsAlphaFields removes disabled fields from []VolumeMount. // This should be called from PrepareForCreate/PrepareForUpdate for all resources containing a VolumeMount func DropDisabledVolumeMountsAlphaFields(volumeMounts []api.VolumeMount) { if !utilfeature.DefaultFeatureGate.Enabled(features.MountPropagation) { for i := range volumeMounts { volumeMounts[i].MountPropagation = nil } } </ins> }

], deps = [ "//pkg/api:go_default_library", <ins> "//pkg/api/pod:go_default_library", </ins> "//pkg/apis/settings:go_default_library", "//pkg/apis/settings/validation:go_default_library", "//vendor/k8s.io/apimachinery/pkg/apis/meta/internalversion:go_default_library",

genericapirequest "k8s.io/apiserver/pkg/endpoints/request" "k8s.io/apiserver/pkg/storage/names" "k8s.io/kubernetes/pkg/api" <ins> "k8s.io/kubernetes/pkg/api/pod" </ins> "k8s.io/kubernetes/pkg/apis/settings" "k8s.io/kubernetes/pkg/apis/settings/validation" )

func (podPresetStrategy) PrepareForCreate(ctx genericapirequest.Context, obj runtime.Object) { pip := obj.(*settings.PodPreset) pip.Generation = 1 <ins> pod.DropDisabledVolumeMountsAlphaFields(pip.Spec.VolumeMounts) </ins> } // PrepareForUpdate clears fields that are not allowed to be set by end users on update.

newPodPreset := obj.(*settings.PodPreset) oldPodPreset := old.(*settings.PodPreset) <ins> pod.DropDisabledVolumeMountsAlphaFields(oldPodPreset.Spec.VolumeMounts) pod.DropDisabledVolumeMountsAlphaFields(newPodPreset.Spec.VolumeMounts) </ins> // Update is not allowed newPodPreset.Spec = oldPodPreset.Spec }
Change:
We are working migrating ipv4 to ipv6, we should support ipv6 for IPVS. We should do the following things: remove ipv4 constraints of Node IPs() remove ipv4 in pkg/util/ipvs() use ipv6 conntrack tools use ipv6 iptables tools <!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind feature /sig network /assign /cc
/area ipv6
FYI: I've just posted a PR (PR ) to fix the way that kube-proxy was calling conntrack without the required "-f ipv6" CLI flag whenever conntrack was being executed for a service that's using IPv6 addresses. There were a couple of lines in that needed to be changed. I don't think I can add UT coverage for those lines until more support for IPv6 addresses is to Cc
ACK! I will take care of , please feel free to ping me when you want my hand :)
Sounds good, is all yours. :) Likewise, let me know if I can help.
Sure, mate.

Discussion:
"-A", string(kubeServicesChain), "-m", "comment", "--comment", fmt.Sprintf(`"%s cluster IP"`, svcNameString), "-m", protocol, "-p", protocol, <del> "-d", fmt.Sprintf("%s/32", svcInfo.clusterIP.String()), </del> <ins> "-d", utilproxy.ToCIDR(svcInfo.clusterIP), </ins> "--dport", strconv.Itoa(svcInfo.port), ) if proxier.masqueradeAll {

"-A", string(kubeServicesChain), "-m", "comment", "--comment", fmt.Sprintf(`"%s loadbalancer IP"`, svcNameString), "-m", string(svcInfo.protocol), "-p", string(svcInfo.protocol), <del> "-d", fmt.Sprintf("%s/32", ingress.IP), </del> <ins> "-d", utilproxy.ToCIDR(net.ParseIP(ingress.IP)), </ins> "--dport", fmt.Sprintf("%d", svcInfo.port), )

// loadbalancer's backend hosts. In this case, request will not hit the loadbalancer but loop back directly. // Need to add the following rule to allow request on host. if allowFromNode { <del> writeLine(proxier.natRules, append(args, "-s", fmt.Sprintf("%s/32", ingress.IP), "-j", "ACCEPT")...) </del> <ins> writeLine(proxier.natRules, append(args, "-s", utilproxy.ToCIDR(net.ParseIP(ingress.IP)), "-j", "ACCEPT")...) </ins> } // If the packet was able to reach the end of firewall chain, then it did not get DNATed.
Change:
Is this a BUG REPORT or FEATURE REQUEST?: /kind bug What happened: Not all variants of api servers store the TLS cert files at /var/run/kubernetes. After the commit was merged back in Feb, some variants such as kube-aggregator stores them at '', but the hard-coded help message still says it will save the keys and certs generated into /var/run/kubernetes. What you expected to happen: Either we refactor the code so the help message prints an accurate location, or we change the help message to make it always true. How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: No. Environment: Kubernetes version (use ): at least 1.7 and above Cloud provider or hardware configuration**: N/A OS (e.g. from /etc/os-release): N/A Kernel (e.g. ): N/A Install tools: N/A Others: N/A
/sig api-machinery
pls help confirm.
We should make the messages accurate.
/assign
GitHub didn't allow me to assign the following users: jennybuckley. Note that only can be assigned. <detailsIn response to : /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
/cc

Discussion:
"File containing the default x509 Certificate for HTTPS. (CA cert, if any, concatenated "+ "after server cert). If HTTPS serving is enabled, and --tls-cert-file and "+ "--tls-private-key-file are not provided, a self-signed certificate and key "+ <del> "are generated for the public address and saved to /var/run/kubernetes.") </del> <ins> "are generated for the public address and saved to the directory specified by --cert-dir.") </ins> fs.StringVar(&s.ServerCert.CertKey.KeyFile, "tls-private-key-file", s.ServerCert.CertKey.KeyFile, "File containing the default x509 private key matching --tls-cert-file.")
Change:
The environment variable GCEALPHAFEATURES is not set correctly in the test custer.
[MILESTONENOTIFIER] Milestone Labels Complete Issue label settings: sig/network: Issue will be escalated to these SIGs if needed. priority/critical-urgent: Never automatically move out of a release milestone; continually escalate to contributor and SIG through all available channels. kind/bug: Fixes a bug discovered during the current release. <detailsAdditional instructions available <a href=""here</a</details

Discussion:
PROVIDER_VARS="${PROVIDER_VARS:-} ENABLE_IP_ALIASES" fi <ins> # Enable GCE Alpha features. if [[ -n "${GCE_ALPHA_FEATURES:-}" ]]; then PROVIDER_VARS="${PROVIDER_VARS:-} GCE_ALPHA_FEATURES" fi </ins> # Admission Controllers to invoke prior to persisting objects in cluster # If we included ResourceQuota, we should keep it at the end of the list to prevent incrementing quota usage prematurely. ADMISSION_CONTROL=Initializers,NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,Priority,ResourceQuota

PROVIDER_VARS="${PROVIDER_VARS:-} ENABLE_IP_ALIASES" fi <ins> # Enable GCE Alpha features. if [[ -n "${GCE_ALPHA_FEATURES:-}" ]]; then PROVIDER_VARS="${PROVIDER_VARS:-} GCE_ALPHA_FEATURES" fi </ins> # If we included ResourceQuota, we should keep it at the end of the list to prevent incrementing quota usage prematurely. ADMISSION_CONTROL="${KUBE_ADMISSION_CONTROL:-Initializers,NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,PodPreset,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,Priority,ResourceQuota}"
Change:
Forked from Since m60, COS set 4000 pids limit for docker.service. However, currently all containerd-shims are also inside the cgroup, and they are per-container. Each containerd-shim has more than 10 threads based on the node size: It's not hard to hit the limit, say 100 3-container pods may hit the limit. We may want to: 1) Either patch kubernetes to change the limit to higher value; 2) Or patch COS directly, since this may be a regression for other COS user, too. /cc
There are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals
[MILESTONENOTIFIER] Milestone Labels Complete Issue label settings: sig/node: Issue will be escalated to these SIGs if needed. priority/important-soon: Escalate to the issue owners and SIG owner; move out of milestone after several unsuccessful escalation attempts. kind/bug: Fixes a bug discovered during the current release. <detailsAdditional instructions available <a href=""here</a</details
cc/ I guess this is the cause for some docker failures you observed.

Discussion:
# If using a network plugin, extend the docker configuration to always remove # the network checkpoint to avoid corrupt checkpoints. # (https://github.com/docker/docker/issues/18283). <del> echo "Extend the default docker.service configuration" </del> <ins> echo "Extend the docker.service configuration to remove the network checkpiont" </ins> mkdir -p /etc/systemd/system/docker.service.d cat <<EOF >/etc/systemd/system/docker.service.d/01network.conf [Service] ExecStartPre=/bin/sh -x -c "rm -rf /var/lib/docker/network" EOF <ins> fi </ins> <del> systemctl daemon-reload </del> <ins> # Ensure TasksMax is sufficient for docker. # (https://github.com/kubernetes/kubernetes/issues/51977) echo "Extend the docker.service configuration to set a higher pids limit" mkdir -p /etc/systemd/system/docker.service.d cat <<EOF >/etc/systemd/system/docker.service.d/02tasksmax.conf [Service] TasksMax=infinity EOF </ins> <del> # If using a network plugin, we need to explicitly restart docker daemon, because # kubelet will not do it. </del> <ins> systemctl daemon-reload </ins> echo "Docker command line is updated. Restart docker to pick it up" systemctl restart docker <del> fi </del> } # This function assembles the kubelet systemd service file and starts it
Change:
https://k8s- https://k8s- cc: /kind bug /priority failing-test
Fix in progress in

Discussion:
glog.V(5).Infof("Statfs_t of %v: %+v", path, buf) if buf.Type == linuxTmpfsMagic { return mediumMemory, !notMnt, nil <del> } else if buf.Type == linuxHugetlbfsMagic { </del> <ins> } else if int64(buf.Type) == linuxHugetlbfsMagic { </ins> return mediumHugepages, !notMnt, nil } return mediumUnknown, !notMnt, nil
Change:
/kind bug What happened: Volumes used by pod are not getting mounted after rebooting a node. Effects Flexvolume/FC/ISCSI volume types. Pod goes into running state using local file system path. What you expected to happen Volume should be mounted and pod should not go into running state if the volume fails to attach. How to reproduce it (as minimally and precisely as possible): Create a RS with Flexvolume/FC/ISCSI. Reboot the node. Volume would not be mounted after reboot. Anything else we need to know?: Kubelet on a process restart avoids remounting the volume. The same code path is used on a node reboot and it avoids remounting the volume. GCE, AWS etc seems to be working by chance as the SPEC reconstruction fails when a volume is not mounted on reboot. Environment: Kubernetes version (use ): 1.6.9 Cloud provider or hardware configuration**: Baremetal OS (e.g. from /etc/os-release): Centos 7.2 Kernel (e.g. ): 3.10.0-327.el7.x86_64
There are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals
/sig storage
/cc

Discussion:
uniqueVolumeName = volumehelper.GetUniqueVolumeNameForNonAttachableVolume(volume.podName, plugin, volumeSpec) } <ins> if attachablePlugin != nil { if isNotMount, mountCheckErr := rc.mounter.IsLikelyNotMountPoint(volume.mountPath); mountCheckErr != nil { return nil, fmt.Errorf("Could not check whether the volume %q (spec.Name: %q) pod %q (UID: %q) is mounted with: %v", uniqueVolumeName, volumeSpec.Name(), volume.podName, pod.UID, mountCheckErr) } else if isNotMount { return nil, fmt.Errorf("Volume: %q is not mounted", uniqueVolumeName) } } </ins> volumeMounter, newMounterErr := plugin.NewMounter( volumeSpec, pod,

glog.Errorf("Could not mark device is mounted to actual state of world: %v", err) continue } <ins> glog.Infof("Volume: %v is mounted", volume.volumeName) </ins> } _, err = rc.desiredStateOfWorld.AddPodToVolume(volume.podName, volume.pod, volume.volumeSpec,
Change:
<!-- This form is for bug reports and feature requests ONLY! If you're looking for help check and the . --Is this a BUG REPORT or FEATURE REQUEST?: /kind feature What happened: Currently, we flush ipvs services by deleting them one by one. That's because there was no flush API in libnetwork. Now, libnetwork supports flush API, I think it's time to rsync. What you expected to happen: How to reproduce it (as minimally and precisely as possible): Anything else we need to know?: Environment: Kubernetes version (use ): Cloud provider or hardware configuration**: OS (e.g. from /etc/os-release): Kernel (e.g. ): Install tools: Others:
There are no sig labels on this issue. Please by: a sig: e.g., to notify the contributor experience sig, OR the label manually: e.g., to apply the label Note: Method 1 will trigger an email to the group. You can find the group list and label list . The in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals
/sig network
/area kube-proxy
/assign

Discussion:
}, { "ImportPath": "github.com/docker/libnetwork/ipvs", <del> "Comment": "v0.8.0-dev.2-908-gd5c82231", "Rev": "d5c822319097cc01cc9bd5ffedd74c7ce7c894f2" </del> <ins> "Rev": "ba46b928444931e6865d8618dc03622cac79aa6f" </ins> }, { "ImportPath": "github.com/docker/libtrust",

// Flush is part of Interface.  Currently we delete IPVS services one by one func (runner *runner) Flush() error { <del> vss, err := runner.GetVirtualServers() if err != nil { return err } for _, vs := range vss { err := runner.DeleteVirtualServer(vs) // TODO: aggregate errors? if err != nil { return err } } return nil </del> <ins> return runner.ipvsHandle.Flush() </ins> } // AddRealServer is part of Interface.

return i.doCmd(s, nil, ipvsCmdDelService) } <ins> // Flush deletes all existing services in the passed // handle. func (i *Handle) Flush() error { _, err := i.doCmdWithoutAttr(ipvsCmdFlush) return err } </ins> // NewDestination creates a new real server in the passed ipvs // service which should already be existing in the passed handle. func (i *Handle) NewDestination(s *Service, d *Destination) error {

return res, nil } <ins> // doCmdWithoutAttr a simple wrapper of netlink socket execute command func (i *Handle) doCmdWithoutAttr(cmd uint8) ([][]byte, error) { req := newIPVSRequest(cmd) req.Seq = atomic.AddUint32(&i.seq, 1) return execute(i.sock, req, 0) } </ins> func assembleDestination(attrs []syscall.NetlinkRouteAttr) (*Destination, error) { var d Destination
Change:
The pod evaluator used by the resource quota controller made direct calls to an unsafe pod conversion function which mutates the pod argument. With multiple resource quota controller workers, concurrent processing of the same pod from a shared informer can result in a panic when the conversion code attempts to write to a map field in the pod. Observed in this and discovered through analyzing core dumps from the controller manager. The bug is only present in <=1.7: the conversion code in 1.8 no longer mutates the input. In my branch, I a small unit test to which reliably reproduces the panic: /kind bug
Fixed by

Discussion:
} func toInternalPodOrError(obj runtime.Object) (*api.Pod, error) { <del> pod := &api.Pod{} </del> switch t := obj.(type) { case *v1.Pod: <del> if err := v1.Convert_v1_Pod_To_api_Pod(t, pod, nil); err != nil { </del> <ins> converted, err := api.Scheme.ConvertToVersion(obj, api.SchemeGroupVersion) if err != nil { </ins> return nil, err } <ins> if pod, ok := converted.(*api.Pod); ok { return pod, nil } else { return nil, fmt.Errorf("expect *api.Pod, got %v", converted) } </ins> case *api.Pod: <del> pod = t </del> <ins> return t, nil </ins> default: return nil, fmt.Errorf("expect *api.Pod or *v1.Pod, got %v", t) } <del> return pod, nil </del> } // podMatchesScopeFunc is a function that knows how to evaluate if a pod matches a scope