Change:
Godoc says that Time should be empty on mangedFields entry created by "Apply" operation, but kubernetes populates time on apply. Godoc consistent with kubernetes behaviour Godoc: Kubernetes: No response <details</details<details</details<details</details<details</details<details</details<details</details
/wg api-expression /sig api-machinery
/cc
/cc /triage accepted
Yeah, good catch. The comment matches the behavior from alpha, which we changed later on. Thanks for letting us now :-) I think we could do a better job describing how this value is changed now.

Discussion:
}, "time": { "$ref": "#/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.Time", <del> "description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'" </del> <ins> "description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over." </ins> } }, "type": "object"

}, "time": { "$ref": "#/components/schemas/io.k8s.apimachinery.pkg.apis.meta.v1.Time", <del> "description": "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'" </del> <ins> "description": "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over." </ins> } }, "type": "object"

// set because it cannot be automatically converted. optional string apiVersion = 3; <del> // Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply' </del> <ins> // Time is the timestamp of when the ManagedFields entry was added. The // timestamp will also be updated if a field is added, the manager // changes any of the owned fields value or removes a field. The // timestamp does not update when a field is removed from the entry // because another manager took it over. </ins> // +optional optional Time time = 4;

// APIVersion field. It is necessary to track the version of a field // set because it cannot be automatically converted. APIVersion string `json:"apiVersion,omitempty" protobuf:"bytes,3,opt,name=apiVersion"` <del> // Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply' </del> <ins> // Time is the timestamp of when the ManagedFields entry was added. The // timestamp will also be updated if a field is added, the manager // changes any of the owned fields value or removes a field. The // timestamp does not update when a field is removed from the entry // because another manager took it over. </ins> // +optional Time *Time `json:"time,omitempty" protobuf:"bytes,4,opt,name=time"`

"manager":     "Manager is an identifier of the workflow managing these fields.", "operation":   "Operation is the type of operation which lead to this ManagedFieldsEntry being created. The only valid values for this field are 'Apply' and 'Update'.", "apiVersion":  "APIVersion defines the version of this resource that this field set applies to. The format is "group/version" just like the top-level APIVersion field. It is necessary to track the version of a field set because it cannot be automatically converted.", <del> "time":        "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'", </del> <ins> "time":        "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over.", </ins> "fieldsType":  "FieldsType is the discriminator for the different fields format and version. There is currently only one possible value: "FieldsV1"", "fieldsV1":    "FieldsV1 holds the first JSON version format as described in the "FieldsV1" type.", "subresource": "Subresource is the name of the subresource used to update that object, or empty string if the object was updated through the main resource. The value of this field is used to distinguish between managers, even if they share the same name. For example, a status update will be distinct from a regular update using the same manager name. Note that the APIVersion field is not related to the Subresource field and it always corresponds to the version of the main resource.",

}, "time": { SchemaProps: spec.SchemaProps{ <del> Description: "Time is timestamp of when these fields were set. It should always be empty if Operation is 'Apply'", </del> <ins> Description: "Time is the timestamp of when the ManagedFields entry was added. The timestamp will also be updated if a field is added, the manager changes any of the owned fields value or removes a field. The timestamp does not update when a field is removed from the entry because another manager took it over.", </ins> Ref:         ref("k8s.io/apimachinery/pkg/apis/meta/v1.Time"), }, },