Change:
This comes from We've a feature gate, . However, we try to name feature gates after the positive thing they add, even if it's on by default, or even if we're setting if false because the positive thing is being dropped (rare, but it happens). Typically we don't start feature gate names with , as it makes the docs jar: Example quote 1: To temporarily revert to the legacy behavior, enable the feature gate. vs Example quote 2: You can enable the feature gate if you run code that relies on the previous behavior. You should plan to migrate. and because disabling things isn't really a feature. Some examples of gates you can or once could disable by turning them off_ include: - - - So, I recommend a rename of the gate before the v1.31 release. /sig auth architecture
FYI
Example gate names: (off by default) (off by default) (on by default) (on by default) (on by default) from (off by default, deprecated)
/milestone v1.31
You must be a member of the GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility. <detailsIn response to : /milestone v1.31 Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details
Another possibility: , deprecated, off by default
Hello there! I am new to kubernetes and I want to contribute in it. Is it something that I can contribute to?
This issue is not a good issue for a first-time contributor to work on.
I'm a fan of , deprecated, off by default
hoping one of you are doing the PR? :) /milestone v1.31

Discussion:
// owner: @micahhausler // Deprecated: v1.31 // <del> // Disable Node Admission plugin validation of CSRs for kubelet signers where CN=system:node:$nodeName. </del> <ins> // Setting AllowInsecureKubeletCertificateSigningRequests to true disables node admission validation of CSRs // for kubelet signers where CN=system:node:$nodeName. </ins> // Remove in v1.33 <del> DisableKubeletCSRAdmissionValidation featuregate.Feature = "DisableKubeletCSRAdmissionValidation" </del> <ins> AllowInsecureKubeletCertificateSigningRequests featuregate.Feature = "AllowInsecureKubeletCertificateSigningRequests" </ins> // owner: @HirazawaUi // kep: http://kep.k8s.io/4004

// ... HPAScaleToZero: {Default: false, PreRelease: featuregate.Alpha}, <del> DisableKubeletCSRAdmissionValidation: {Default: false, PreRelease: featuregate.Deprecated}, // remove in 1.33 </del> <ins> AllowInsecureKubeletCertificateSigningRequests: {Default: false, PreRelease: featuregate.Deprecated}, // remove in 1.33 </ins> StorageNamespaceIndex: {Default: true, PreRelease: featuregate.Beta},

podsGetter     corev1lister.PodLister nodesGetter    corev1lister.NodeLister <del> expansionRecoveryEnabled              bool dynamicResourceAllocationEnabled      bool kubeletCSRAdmissionValidationDisabled bool </del> <ins> expansionRecoveryEnabled                       bool dynamicResourceAllocationEnabled               bool allowInsecureKubeletCertificateSigningRequests bool </ins> } var (

func (p *Plugin) InspectFeatureGates(featureGates featuregate.FeatureGate) { p.expansionRecoveryEnabled = featureGates.Enabled(features.RecoverVolumeExpansionFailure) p.dynamicResourceAllocationEnabled = featureGates.Enabled(features.DynamicResourceAllocation) <del> p.kubeletCSRAdmissionValidationDisabled = featureGates.Enabled(features.DisableKubeletCSRAdmissionValidation) </del> <ins> p.allowInsecureKubeletCertificateSigningRequests = featureGates.Enabled(features.AllowInsecureKubeletCertificateSigningRequests) </ins> } // SetExternalKubeInformerFactory registers an informer factory into Plugin

return p.admitResourceSlice(nodeName, a) case csrResource: <del> if p.kubeletCSRAdmissionValidationDisabled { </del> <ins> if p.allowInsecureKubeletCertificateSigningRequests { </ins> return nil } return p.admitCSR(nodeName, a)

features:   feature.DefaultFeatureGate, setupFunc: func(t *testing.T) { t.Helper() <del> featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, features.DisableKubeletCSRAdmissionValidation, true) </del> <ins> featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, features.AllowInsecureKubeletCertificateSigningRequests, true) </ins> }, }, {