Change:
What happened: These tests are errantly listed as (ref: ) but aren't actually run as part of Conformance. They need to be moved to test/e2e/common to be included. To my eyes they may meet the criteria for conformance. There's definitely nothing about them that is node specific. They should be running as part of our regular CI, and they should probably be running as presubmits. Porting them to test/e2e/common would cause this to happen. /kind cleanup /sig node /area test /assign
GitHub didn't allow me to assign the following users: mkurylec. Note that only and repo collaborators can be assigned. For more information please see <detailsIn response to : What happened: These tests are errantly listed as (ref: ) but aren't actually run as part of Conformance. They need to be moved to test/e2e/common to be included. /sig node /area test /assign Instructions for interacting with me using PR comments are available . If you have questions or suggestions related to my behavior, please file an issue against the repository. </details

Discussion:
"expansion.go", "host_path.go", "init_container.go", <ins> "kubelet.go", </ins> "kubelet_etc_hosts.go", "lifecycle_hook.go", "networking.go",

<ins> /* Copyright 2016 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package common import ( "bytes" "fmt" "strings" "time" "k8s.io/api/core/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/util/uuid" "k8s.io/kubernetes/test/e2e/framework" . "github.com/onsi/ginkgo" . "github.com/onsi/gomega" ) var _ = framework.KubeDescribe("Kubelet", func() { f := framework.NewDefaultFramework("kubelet-test") var podClient *framework.PodClient BeforeEach(func() { podClient = f.PodClient() }) Context("when scheduling a busybox command in a pod", func() { podName := "busybox-scheduling-" + string(uuid.NewUUID()) /* Release : v1.9 Testname: Kubelet, log output, default Description: By default the stdout and stderr from the process being executed in a pod MUST be sent to the pod's logs. */ It("should print the output to logs [NodeConformance]", func() { podClient.CreateSync(&v1.Pod{ ObjectMeta: metav1.ObjectMeta{ Name: podName, }, Spec: v1.PodSpec{ // Don't restart the Pod since it is expected to exit RestartPolicy: v1.RestartPolicyNever, Containers: []v1.Container{ { Image:   framework.BusyBoxImage, Name:    podName, Command: []string{"sh", "-c", "echo 'Hello World' ; sleep 240"}, }, }, }, }) Eventually(func() string { sinceTime := metav1.NewTime(time.Now().Add(time.Duration(-1 * time.Hour))) rc, err := podClient.GetLogs(podName, &v1.PodLogOptions{SinceTime: &sinceTime}).Stream() if err != nil { return "" } defer rc.Close() buf := new(bytes.Buffer) buf.ReadFrom(rc) return buf.String() }, time.Minute, time.Second*4).Should(Equal("Hello Worldn")) }) }) Context("when scheduling a busybox command that always fails in a pod", func() { var podName string BeforeEach(func() { podName = "bin-false" + string(uuid.NewUUID()) podClient.Create(&v1.Pod{ ObjectMeta: metav1.ObjectMeta{ Name: podName, }, Spec: v1.PodSpec{ // Don't restart the Pod since it is expected to exit RestartPolicy: v1.RestartPolicyNever, Containers: []v1.Container{ { Image:   framework.BusyBoxImage, Name:    podName, Command: []string{"/bin/false"}, }, }, }, }) }) It("should have an terminated reason [NodeConformance]", func() { Eventually(func() error { podData, err := podClient.Get(podName, metav1.GetOptions{}) if err != nil { return err } if len(podData.Status.ContainerStatuses) != 1 { return fmt.Errorf("expected only one container in the pod %q", podName) } contTerminatedState := podData.Status.ContainerStatuses[0].State.Terminated if contTerminatedState == nil { return fmt.Errorf("expected state to be terminated. Got pod status: %+v", podData.Status) } if contTerminatedState.ExitCode == 0 || contTerminatedState.Reason == "" { return fmt.Errorf("expected non-zero exitCode and non-empty terminated state reason. Got exitCode: %+v and terminated state reason: %+v", contTerminatedState.ExitCode, contTerminatedState.Reason) } return nil }, time.Minute, time.Second*4).Should(BeNil()) }) It("should be possible to delete [NodeConformance]", func() { err := podClient.Delete(podName, &metav1.DeleteOptions{}) Expect(err).To(BeNil(), fmt.Sprintf("Error deleting Pod %v", err)) }) }) Context("when scheduling a busybox Pod with hostAliases", func() { podName := "busybox-host-aliases" + string(uuid.NewUUID()) It("should write entries to /etc/hosts [NodeConformance]", func() { podClient.CreateSync(&v1.Pod{ ObjectMeta: metav1.ObjectMeta{ Name: podName, }, Spec: v1.PodSpec{ // Don't restart the Pod since it is expected to exit RestartPolicy: v1.RestartPolicyNever, Containers: []v1.Container{ { Image:   framework.BusyBoxImage, Name:    podName, Command: []string{"/bin/sh", "-c", "cat /etc/hosts; sleep 6000"}, }, }, HostAliases: []v1.HostAlias{ { IP:        "123.45.67.89", Hostnames: []string{"foo", "bar"}, }, }, }, }) Eventually(func() error { rc, err := podClient.GetLogs(podName, &v1.PodLogOptions{}).Stream() defer rc.Close() if err != nil { return err } buf := new(bytes.Buffer) buf.ReadFrom(rc) hostsFileContent := buf.String() if !strings.Contains(hostsFileContent, "123.45.67.89tfoo") || !strings.Contains(hostsFileContent, "123.45.67.89tbar") { return fmt.Errorf("expected hosts file to contain entries from HostAliases. Got:n%+v", hostsFileContent) } return nil }, time.Minute, time.Second*4).Should(BeNil()) }) }) Context("when scheduling a read only busybox container", func() { podName := "busybox-readonly-fs" + string(uuid.NewUUID()) It("should not write to root filesystem [NodeConformance]", func() { isReadOnly := true podClient.CreateSync(&v1.Pod{ ObjectMeta: metav1.ObjectMeta{ Name: podName, }, Spec: v1.PodSpec{ // Don't restart the Pod since it is expected to exit RestartPolicy: v1.RestartPolicyNever, Containers: []v1.Container{ { Image:   framework.BusyBoxImage, Name:    podName, Command: []string{"/bin/sh", "-c", "echo test > /file; sleep 240"}, SecurityContext: &v1.SecurityContext{ ReadOnlyRootFilesystem: &isReadOnly, }, }, }, }, }) Eventually(func() string { rc, err := podClient.GetLogs(podName, &v1.PodLogOptions{}).Stream() if err != nil { return "" } defer rc.Close() buf := new(bytes.Buffer) buf.ReadFrom(rc) return buf.String() }, time.Minute, time.Second*4).Should(Equal("/bin/sh: can't create /file: Read-only file systemn")) }) }) }) </ins>

"gke_environment_test.go", "hugepages_test.go", "image_id_test.go", <del> "kubelet_test.go", </del> "log_path_test.go", "mirror_pod_test.go", "node_container_manager_test.go",

<del> /* Copyright 2016 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package e2e_node import ( "bytes" "fmt" "strings" "time" "k8s.io/api/core/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/util/uuid" "k8s.io/kubernetes/test/e2e/framework" . "github.com/onsi/ginkgo" . "github.com/onsi/gomega" ) var _ = framework.KubeDescribe("Kubelet", func() { f := framework.NewDefaultFramework("kubelet-test") var podClient *framework.PodClient BeforeEach(func() { podClient = f.PodClient() }) Context("when scheduling a busybox command in a pod", func() { podName := "busybox-scheduling-" + string(uuid.NewUUID()) /* Release : v1.9 Testname: Kubelet, log output, default Description: By default the stdout and stderr from the process being executed in a pod MUST be sent to the pod's logs. */ It("it should print the output to logs [NodeConformance]", func() { podClient.CreateSync(&v1.Pod{ ObjectMeta: metav1.ObjectMeta{ Name: podName, }, Spec: v1.PodSpec{ // Don't restart the Pod since it is expected to exit RestartPolicy: v1.RestartPolicyNever, Containers: []v1.Container{ { Image:   busyboxImage, Name:    podName, Command: []string{"sh", "-c", "echo 'Hello World' ; sleep 240"}, }, }, }, }) Eventually(func() string { sinceTime := metav1.NewTime(time.Now().Add(time.Duration(-1 * time.Hour))) rc, err := podClient.GetLogs(podName, &v1.PodLogOptions{SinceTime: &sinceTime}).Stream() if err != nil { return "" } defer rc.Close() buf := new(bytes.Buffer) buf.ReadFrom(rc) return buf.String() }, time.Minute, time.Second*4).Should(Equal("Hello Worldn")) }) }) Context("when scheduling a busybox command that always fails in a pod", func() { var podName string BeforeEach(func() { podName = "bin-false" + string(uuid.NewUUID()) podClient.Create(&v1.Pod{ ObjectMeta: metav1.ObjectMeta{ Name: podName, }, Spec: v1.PodSpec{ // Don't restart the Pod since it is expected to exit RestartPolicy: v1.RestartPolicyNever, Containers: []v1.Container{ { Image:   busyboxImage, Name:    podName, Command: []string{"/bin/false"}, }, }, }, }) }) It("should have an error terminated reason [NodeConformance]", func() { Eventually(func() error { podData, err := podClient.Get(podName, metav1.GetOptions{}) if err != nil { return err } if len(podData.Status.ContainerStatuses) != 1 { return fmt.Errorf("expected only one container in the pod %q", podName) } contTerminatedState := podData.Status.ContainerStatuses[0].State.Terminated if contTerminatedState == nil { return fmt.Errorf("expected state to be terminated. Got pod status: %+v", podData.Status) } if contTerminatedState.Reason != "Error" { return fmt.Errorf("expected terminated state reason to be error. Got %+v", contTerminatedState) } return nil }, time.Minute, time.Second*4).Should(BeNil()) }) It("should be possible to delete [NodeConformance]", func() { err := podClient.Delete(podName, &metav1.DeleteOptions{}) Expect(err).To(BeNil(), fmt.Sprintf("Error deleting Pod %v", err)) }) }) Context("when scheduling a busybox Pod with hostAliases", func() { podName := "busybox-host-aliases" + string(uuid.NewUUID()) It("it should write entries to /etc/hosts [NodeConformance]", func() { podClient.CreateSync(&v1.Pod{ ObjectMeta: metav1.ObjectMeta{ Name: podName, }, Spec: v1.PodSpec{ // Don't restart the Pod since it is expected to exit RestartPolicy: v1.RestartPolicyNever, Containers: []v1.Container{ { Image:   busyboxImage, Name:    podName, Command: []string{"/bin/sh", "-c", "cat /etc/hosts; sleep 6000"}, }, }, HostAliases: []v1.HostAlias{ { IP:        "123.45.67.89", Hostnames: []string{"foo", "bar"}, }, }, }, }) Eventually(func() error { rc, err := podClient.GetLogs(podName, &v1.PodLogOptions{}).Stream() defer rc.Close() if err != nil { return err } buf := new(bytes.Buffer) buf.ReadFrom(rc) hostsFileContent := buf.String() if !strings.Contains(hostsFileContent, "123.45.67.89tfoo") || !strings.Contains(hostsFileContent, "123.45.67.89tbar") { return fmt.Errorf("expected hosts file to contain entries from HostAliases. Got:n%+v", hostsFileContent) } return nil }, time.Minute, time.Second*4).Should(BeNil()) }) }) Context("when scheduling a read only busybox container", func() { podName := "busybox-readonly-fs" + string(uuid.NewUUID()) /* Release : v1.9 Testname: Kubelet, Pod with read only root file system Description: Create a Pod with security context set with ReadOnlyRootFileSystem set to true. The Pod then tries to write to the /file on the root, write operation to the root filesystem MUST fail as expected. */ It("it should not write to root filesystem [NodeConformance]", func() { isReadOnly := true podClient.CreateSync(&v1.Pod{ ObjectMeta: metav1.ObjectMeta{ Name: podName, }, Spec: v1.PodSpec{ // Don't restart the Pod since it is expected to exit RestartPolicy: v1.RestartPolicyNever, Containers: []v1.Container{ { Image:   busyboxImage, Name:    podName, Command: []string{"/bin/sh", "-c", "echo test > /file; sleep 240"}, SecurityContext: &v1.SecurityContext{ ReadOnlyRootFilesystem: &isReadOnly, }, }, }, }, }) Eventually(func() string { rc, err := podClient.GetLogs(podName, &v1.PodLogOptions{}).Stream() if err != nil { return "" } defer rc.Close() buf := new(bytes.Buffer) buf.ReadFrom(rc) return buf.String() }, time.Minute, time.Second*4).Should(Equal("/bin/sh: can't create /file: Read-only file systemn")) }) }) }) </del>