jiebi/CodeConvo huggingface dataset:
Change:
Forgot to make PR. This is the "good" one, should be abandoned...
Nope -- I think it is still TBD - we've asked / strongly suggested 114 in the IANA section, but I think it would feel presumptive to state that it is... W
I believe this should be changed to 114, or IANA-TBD.
Yikes, good catch. I changed it to TBD, and also added a sentence to the Abstract noting that it has changed from 160 to TBD (it seemed important enough). Thank you! W
NAME have changed or will change? I can't see this in the current version(s) of the draft here.
I swear I'd done this, and event sent a PR, but I cannot find it.... so, just made a new one...
I had created the branch, and made the edits, but apparently forgot to make the PR.... and then, because I couldn't find it, I made a new branch, change and PR (), and then realized the original was better, so I removed PR and created ... Oy vey, W
Done, had forgotten to close...
Should the TBDs be 114? Either that, or the list of changes should be TBD as well?

Discussion:
authenticating to, and interacting with the captive portal is out of scope of this document. <ins> RFC7710 used DHCP code point 160.  Due to a conflict, this document specifies TBD. </ins> [ This document is being collaborated on in Github at: https://github.com/capport-wg/7710bis.  The most recent version of the document, open issues, etc should all be available here.  The

1. In many environments, users need to connect to a captive-portal <del> server and agree to an Acceptable Use Policy (AUP) and / or provide billing information before they can access the Internet.  It is anticipated that the IETF will work on a more fully featured protocol at some point, to ease interaction with Captive Portals.  Regardless of how that protocol operates, it is expected that this document will provide needed functionality because the client will need to know when it is behind a captive portal and how to contact it. </del> <ins> device and agree to an Acceptable Use Policy (AUP) and / or provide billing information before they can access the Internet.  Regardless of how that mechanism operates, this document provides functionality to allow the client to know when it is behind a captive portal and how to contact it. </ins> In order to present users with the payment or AUP pages, presently a captive-portal enforcement device has to intercept the user's

The format of the IPv4 Captive-Portal DHCP option is shown below. <del> Code: The Captive-Portal DHCPv4 Option (160) (one octet) </del> <ins> Code: The Captive-Portal DHCPv4 Option (TBD) (one octet) </ins> Len: The length, in octets of the URI.

be less likely to disable useful security safeguards like DNSSEC validation, VPNs, etc.  In addition, because the system knows that it is behind a captive portal, it can know not to send cookies, <del> credentials, etc.  By provisioning a URI using which is protected with TLS, the captive portal operator can attempt to reassure the user that the captive portal is not malicious. </del> <ins> credentials, etc.  By handing out a URI which is protected with TLS, the captive portal operator can attempt to reassure the user that the captive portal is not malicious. </ins>
Change:
— Section 1.1 — Please use the new BCP 14 boilerplate from RFC 8174.

Discussion:
1.1. The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", <del> "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in RFC2119. </del> <ins> "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in BCP 14 RFC2119 RFC8174 when, and only when, they appear in all capitals, as shown here. </ins> 2.
Change:
""" — Section 3 — Specifically, URIs learned via any of the options in Section 2 should take precedence over any URI learned via some other mechanism Given the MUST that comes before this, I think the word “should” ought to be removed, to avoid any confusion. """ Actually, this text is left over from the brief period of time when there was an HTTP redirect Link-Relation header. That option was removed, and I think the 2nd paragraph can be deleted. The 1st and 3rd paragraphs can probably be reworked into two much tighter paragraphs.

Discussion:
3. A device may learn about Captive Portal API URIs through more than <del> one of (or indeed all of) the above options.  It is a network configuration error if the learned URIs are not all identical. However, if the URIs learned are not in fact all identical the captive device MUST prioritize URIs learned from network provisioning or configuration mechanisms before all other URIs.  Specifically, URIs learned via any of the options in option should take precedence over any URI learned via some other mechanism, such as a redirect. </del> <ins> one of (or indeed all of) the above options.  Implementations can select their own precedence order (e.g., prefer one of the IPv6 options before the DHCPv4 option, or vice versa, et cetera). </ins> If the URIs learned via more than one option described in option are not all identical, this condition should be logged for the device <del> owner or administrator.  Implementations can select their own precedence order. </del> <ins> owner or administrator; it is a network configuration error if the learned URIs are not all identical. </ins> 4.
Change:
Additionally: Update DHCPv6 reference from RFC 3315 to RFC 8415. Include reference to DHCPv6 option format text. Include reference to DHCPv4 option format text in RFC 2132. The DHCPv4 and v6 diagrams are not harmonized in this change. Each option format has sever documents using the style currently depicted. Issue:
""" — Sections 2.1 and 2.2 — Why aren’t the diagrams for the two in the same format? And neither explicitly says what the length of the “len” field is. In the v4 version, one has to guess that it’s the same size as the “code” field, 1 byte. In the v6 version, one can look at the diagram. I suggest making the diagrams the same format (calibrated with bit/byte markings) and explicitly specifying in the text the size of the “len” field. """ I rather suspect this goes back to whichever source documents from which the option format text was copied. Nevertheless, harmonizing them seems reasonable.
Additionally: we should restate the 255 byte limit from DHCPv4 in each option's description.

Discussion:
request. In order to support multiple "classes" of clients (e.g.  IPv4 only, <del> IPv6 only with DHCPv6 (RFC3315), and IPv6 only with RA) the captive </del> <ins> IPv6 only with DHCPv6 (RFC8415), and IPv6 only with RA) the captive </ins> network can provision the client with the URI via multiple methods (IPv4 DHCP, IPv6 DHCP, and IPv6 RA).  The captive portal operator SHOULD ensure that the URIs provisioned by each method are equivalent to reduce the chance of operational problems.  The maximum length of the URI that can be carried in IPv4 DHCP is 255 bytes, so URIs longer <del> than 255 bytes should not be provisioned via IPv6 DHCP or IPv6 RA either. </del> <ins> than 255 bytes should not be provisioned via IPv6 DHCP nor IPv6 RA options. </ins> In all variants of this option, the URI MUST be that of the captive portal API endpoint, conforming to the recommendations for such URIs

Code: The Captive-Portal DHCPv4 Option (TBD) (one octet) <del> Len: The length, in octets of the URI. </del> <ins> Len: The length (one octet), in octets of the URI. </ins> URI: The URI for the captive portal API endpoint to which the user should connect (encoded following the rules in RFC3986). <ins> See RFC2132, Section 2 for more on the format of IPv4 DHCP options. </ins> Note that the URI parameter is not null terminated. 2.2.

option-code: The Captive-Portal DHCPv6Option (103) (two octets) <del> option-len: The length, in octets of the URI. </del> <ins> option-len: The unsigned 16-bit length, in octets, of the URI. </ins> URI: The URI for the captive portal API endpoint to which the user should connect (encoded following the rules in RFC3986). See RFC7227, Section 5.7 for more examples of DHCP Options with URIs. <ins> See RFC8415, Section 21.1 for more on the format of IPv6 DHCP options. </ins> Note that the URI parameter is not null terminated.
Change:
""" It looks like the two consecutive paragraphs that both begin with “A captive portal” have some duplication with regard to the absence of “Accept” headers; please check that and adjust if you agree that some information can be merged or removed. """ Indeed, these paragraphs seem to be saying almost the exact same thing. I think the 2nd paragraph can be removed, once it's clear whether/how to move its SHOULD to the 1st paragraph.
A bunch of unrelated changes :)

Discussion:
portal API endpoint, conforming to the recommendations for such URIs [draft-ietf-capport-api]. <del> A captive portal server MAY redirect requests that do not have an Accept header field (RFC7231 Section 5.3) containing a field item whose content-type is "application/capport+json" to the URL conveyed in the "user-portal-url" API key.  When performing such content negotiation (RFC7231 Section 3.4), implementors of captive portals need to keep in mind that such responses might be cached, and therefore SHOULD include an appropriate Vary header field (RFC7231 Section 7.1.4) or mark them explicitly uncacheable (for example, using Cache-Control: no-store RFC7234 Section 5.2.2.3). </del> A captive portal MAY do content negotiation (RFC7231 section 3.4) and attempt to redirect clients querying without an explicit indication of support for the captive portal API content type (i.e. without application/capport+json listed explicitly anywhere within an Accept header vis.  RFC7231 section 5.3).  In so doing, the captive portal SHOULD redirect the client to the value associated with the "user- <del> portal-url" API key. </del> <ins> portal-url" API key.  When performing such content negotiation (RFC7231 Section 3.4), implementors of captive portals need to keep in mind that such responses might be cached, and therefore SHOULD include an appropriate Vary header field (RFC7231 Section 7.1.4) or mark them explicitly uncacheable (for example, using Cache-Control: no-store RFC7234 Section 5.2.2.3). </ins> The URI SHOULD NOT contain an IP address literal.
Change:
Approved -- discussed on phone...
""" The URI SHOULD NOT contain an IP address literal. Why not, and how does it maintain interoperability to have this as SHOULD NOT, rather than MUST NOT? """
My recollection (possibly faulty), is that we could have made this a MUST NOT in large part because we want the URI to be identical across IPv4 and IPv6 -based options, but that going from SHOULD NOT to MUST NOT could be over-prescriptive. Is my recollection correct, and would such a move be over-prescriptive?
That is right. It is also somewhat more challenging to get a valid certificate for an IP address than a domain name.

Discussion:
mark them explicitly uncacheable (for example, using Cache-Control: no-store RFC7234 Section 5.2.2.3). <del> The URI SHOULD NOT contain an IP address literal. </del> <ins> The URI SHOULD NOT contain an IP address literal.  Exceptions to this might include networks with only one operational IP address family where DNS is either not available or not fully functional until the captive portal has been satisfied. </ins> Networks with no captive portals MAY explicitly indicate this condition by using this option with the IANA-assigned URI for this
Change:
Additionally, clarify recommended URI limit of 255 in each of DHCPv6 and IPv6 RA option description text.
Approved (text crafted on phone). The duplication of the warning length is intentional....
""" — Sections 2.1 and 2.2 — Why aren’t the diagrams for the two in the same format? And neither explicitly says what the length of the “len” field is. In the v4 version, one has to guess that it’s the same size as the “code” field, 1 byte. In the v6 version, one can look at the diagram. I suggest making the diagrams the same format (calibrated with bit/byte markings) and explicitly specifying in the text the size of the “len” field. """ I rather suspect this goes back to whichever source documents from which the option format text was copied. Nevertheless, harmonizing them seems reasonable.
Additionally: we should restate the 255 byte limit from DHCPv4 in each option's description.

Discussion:
Note that the URI parameter is not null terminated. <ins> The maximum length of the URI that can be carried in IPv4 DHCP is 255 bytes, so URIs longer than 255 bytes should not be provisioned via IPv6 DHCP options. </ins> 2.3. This section describes the Captive-Portal Router Advertisement

Note that the URI parameter is not guaranteed to be null terminated. <ins> The maximum length of the URI that can be carried in IPv4 DHCP is 255 bytes, so URIs longer than 255 bytes should not be provisioned via IPv6 RA options. </ins> 3. A device may learn about Captive Portal API URIs through more than
Change:
""" — Section 5 — Purely a judgment thing here, so do what you hink is best: it seems to me that the Security Considerations in 7710 rather buried the lede. The bottom line is that by removing the MitM interception, this mechanism improves security by making the portal and its actions visible, rather than hidden, and that vulnerabilities that exist here also existed before and are now lessened. I would say something like that up front, in a new first paragraph, and then continue with the existing text as is. But, again, as you judge best; this is just a comment. """

Discussion:
5. <ins> By removing or reducing the need for captive portals to perform MITM hijacking, this mechanism improves security by making the portal and its actions visible, rather than hidden, and reduces the likelihood that users will disable useful security safeguards like DNSSEC validation, VPNs, etc.  In addition, because the system knows that it is behind a captive portal, it can know not to send cookies, credentials, etc.  By handing out a URI which is protected with TLS, the captive portal operator can attempt to reassure the user that the captive portal is not malicious. </ins> An attacker with the ability to inject DHCP messages or RAs could include an option from this document to force users to contact an address of his choosing.  As an attacker with this capability could

expectations of being hijacked - this may improve security by making users more reluctant to accept TLS hijacking, which can be performed from beyond the network associated with the captive portal. <del> By simplifying the interaction with the captive portal systems, and doing away with the need for interception, we think that users will be less likely to disable useful security safeguards like DNSSEC validation, VPNs, etc.  In addition, because the system knows that it is behind a captive portal, it can know not to send cookies, credentials, etc.  By handing out a URI which is protected with TLS, the captive portal operator can attempt to reassure the user that the captive portal is not malicious. </del>
Change:
Thread: URL
Perhaps a reference to URL as well as the security considerations sections of 2131, 4861, 4862, and 8415.
The new paragraph is good. The other sentence is a little hard to understand and risks opening questions that we probably don't want opened. Reviewer: Rifaat Shekh-Yusef Review result: Has Issues Since the use of IP address literal is not forbidden by this document, what if an attacker with the ability to inject DHCP messages or RAs uses this option to force the user to contact an IP address of his choosing? In this case, the use of TLS and presenting the identity in the certificate might not be of much help. I think this case should be discussed in the security consideration section.

Discussion:
the captive portal operator can attempt to reassure the user that the captive portal is not malicious. <ins> Each of the options described in this document is presented to a node using the same protocols used to provision other information critical to the node's successful configuration on a network.  The security considerations applicable to each of these provisioning mechanisms also apply when the node is attempting to learn the information conveyed in these options.  In the absence of security measures like RA Guard (RFC6105, RFC7113) or DHCP Shield RFC7610, an attacker could inject, modify, or block DHCP messages or RAs. </ins> An attacker with the ability to inject DHCP messages or RAs could include an option from this document to force users to contact an address of his choosing.  As an attacker with this capability could <del> simply list himself as the default gateway (and so intercept all the victim's traffic); this does not provide them with significantly more capabilities, but because this document removes the need for </del> <ins> simply list themselves as the default gateway (and so intercept all the victim's traffic); this does not provide them with significantly more capabilities, but because this document removes the need for </ins> interception, the attacker may have an easier time performing the <del> attack.  As the operating systems and application that make use of </del> <ins> attack. However, as the operating systems and application that make use of </ins> this information know that they are connecting to a captive-portal device (as opposed to intercepted connections) they can render the page in a sandboxed environment and take other precautions, such as
Change:
Looking at this now it's really not clear what I was thinking before. Fortunately, IANA folks are on top things. =)
""" First, Section 4.1 states that "This document registers a new entry under the IETF URN Sub-namespace defined in [RFC3553]" however, the registry at URL defined by RFC 3553 is actually the IETF URN Sub-namespace for Registered Protocol Parameter Identifiers registry. In addition, neither registry's columns match the columns named in the registration. IANA Question --> The authors provide the following registration information in Section 4.1 of the draft: Registry name: Captive Portal Unrestricted Identifier URN: urn:ietf:params:capport:unrestricted Specification: RFC TBD (this document) Repository: RFC TBD (this document) Index value: Only one value is defined (see URN above). No hierarchy is defined and therefore no sub-namespace registrations are possible. The IETF URN Sub-namespaces registry records the following information: Sub-namespace Reference IANA Registry Reference And the IETF URN Sub-namespace for Registered Protocol Parameter Identifiers provide the following information: Registered Parameter Identifier Reference IANA Registry Reference Is the registration information in Section 4.1 of the draft for a different registry; or, is the information provided different from the requirements for the IETF URN Sub-namespace for Registered Protocol Parameter Identifiers registry? """
Per Barry: """ The way we'd normally do this sort of registration is to register "capport" in the "IETF URN Sub-namespace for Registered Protocol Parameter Identifiers" registry, and create a new registry (probably with Expert Review or Specification Required, but it also could be FCFS) for "Captive Portal URN Labels" or some name like that, and that registry would have "unrestricted" in it, resulting in the full URN we want. The "Captive Portal URN Labels" registry would be the IANA Registry Reference for the first registration. """ I propose we go for the Fully Monty registration.
Given recent discussion that capport:unrestricted may be fine on its own I will close this (again) for now.

Discussion:
4.1. This document registers a new entry under the IETF URN Sub-namespace <del> defined in RFC3553: </del> <ins> for Registered Protocol Parameter Identifiers defined in RFC3553: </ins> <del> Captive Portal Unrestricted Identifier urn:ietf:params:capport:unrestricted </del> <ins> capport:unrestricted </ins> RFC TBD (this document) <del> RFC TBD (this document) </del> <ins> https://www.iana.org/assignments/params/params.xml#params-1 </ins> <del> Only one value is defined (see URN above).  No hierarchy is defined and therefore no sub-namespace registrations are possible. </del> <ins> Only one value is defined (see URN above).  No hierarchy is defined and therefore no sub-namespace registrations are possible. </ins> 4.2.
Change:
Ben suggested: "I was just thinking that if we have a whole sentence about how "you're going to have to do the old thing anyway, though", someone might read that and say "well, if I have to keep doing the old thing, why should I bother with this new thing". So, appending a "; nonetheless, the mechanism provided by this document provides a more reliable and performant way to do so, and is therefore the preferred mechanism for captive-portal detection" or similar is what I had in mind."
Will do, and just submit ('ain't nobody got time for nit PRs :-P)
Maybe de-hyphenate captive-portal

Discussion:
Captive-Portal Identification in DHCP / RA <del> draft-ietf-capport-rfc7710bis-09 </del> <ins> draft-ietf-capport-rfc7710bis-10 </ins> Abstract

information faster and more reliably.  Note that, for the foreseeable future, captive portals will still need to implement interception techniques to serve legacy clients, and clients will need to perform <del> probing to detect captive portals. </del> <ins> probing to detect captive portals"; nonetheless, the mechanism provided by this document provides a more reliable and performant way to do so, and is therefore the preferred mechanism for captive-portal detection. </ins> Clients that support the Captive Portal DHCP option SHOULD include the option in the Parameter Request List in DHCPREQUEST messages.
Change:
Fixes issue
Aaaaannd fixed the merge conflicts again. NAME NAME please take a look!
In our interop testing, all of the implementations of portals require that the DHCP option is in the request list in order for it to be sent. We should be explicit that this is what SHOULD be done in the document (clients SHOULD request).

Discussion:
techniques to serve legacy clients, and clients will need to perform probing to detect captive portals. <ins> Clients that support the Captive Portal DHCP option SHOULD include the option in the Parameter Request List in DHCPREQUEST messages. DHCP servers MAY send the Captive Portal option without any explicit request. </ins> In order to support multiple "classes" of clients (e.g.  IPv4 only, IPv6 only with DHCPv6 (RFC3315), IPv6 only with RA) the captive portal can provide the URI via multiple methods (IPv4 DHCP, IPv6