Change:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --<!-- Add a link to the coding challenge with the problem. -- The final instructions for this step say: "Then, give the placeholder text describing an example answer." Since the instructions mention "placeholder" I think it is safe to assume that some people will think they should use the attribute on the to fulfill this requirement. But the code check test checks the of the : So using the attribute will result in the following hint: "You should give the placeholder text describing an example answer." Which does not make it clear that the example answer should be embedded in the instead of using the attribute. Based on the current instructions I think most users will assume that the attribute should be used to complete this step and the test should be updated accordingly. <!-- Please complete the following information. --- Device: Desktop OS: Linux/Fedora 34 Browser: Firefox Version: 95.0.2
On
I was going to fix this issue by updating the test in step 38 to check the placeholder attribute on the textarea but then I realized that if we make this change then the HTML in each step after 38 would also need to be updated to use the placeholder attribute as well. So the question is, do we want to use the placeholder attribute and update all of the remaining steps or do we want to reword the instructions in step 38 to make it clear that you should embed the question text in the textarea and not use the placeholder attribute?
That's a good question. The placeholder text matches wording from referring to the attribute. That would make me think, the intention is to use the attribute.
Agreed, this should probably be updated to use the placeholder attribute. Looks like I've got a lot of updates to include in the PR.
Thank you, for opening this. When I wrote this, I vaguely remember reading a resource mentioning using the attribute on was not the recommended approach. However, as I cannot find that, I agree using the attribute in this case seems like the better option. Yes, this will require a rewrite for all subsequent lessons. However, this usually is a simple Find and Replace.
Perfect. I'll submit a PR for this in just a bit.

Discussion:
assert.isNotNaN(Number(cols)); ``` <del> You should give the `textarea` placeholder text describing an example answer. </del> <ins> You should give the `textarea` a `placeholder` attribute with text describing an example answer. </ins> ```js <del> assert.notEmpty(document.querySelectorAll('div.answer')?.[1]?.querySelector('textarea')?.textContent); </del> <ins> assert.notEmpty(document.querySelectorAll('div.answer')?.[1]?.querySelector('textarea')?.getAttribute('placeholder')); </ins> ``` # --seed--

<label>Do you have any questions:</label> </div> <div class="answer"> <del> <textarea rows="5" cols="24"> Who is flexbox... </textarea> </del> <ins> <textarea rows="5" cols="24" placeholder="Who is flexbox..."></textarea> </ins> </div> --fcc-editable-region-- </div>

<label for="css-questions">Do you have any questions:</label> </div> <div class="answer"> <del> <textarea id="css-questions" name="css-questions" rows="5" cols="24"> Who is flexbox... </textarea> </del> <ins> <textarea id="css-questions" name="css-questions" rows="5" cols="24" placeholder="Who is flexbox..."></textarea> </ins> </div> </div> </section>

<label for="css-question">Do you have any questions:</label> </div> <div class="answer"> <del> <textarea id="css-question" name="css-question" rows="5" cols="24"> Who is flexbox... </textarea> </del> <ins> <textarea id="css-question" name="css-question" rows="5" cols="24" placeholder="Who is flexbox..."></textarea> </ins> </div> </div> </section>