jiebi/CodeConvo huggingface dataset:
Change:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Describe your problem and how to reproduce it: This was discussed on the forum and it was suggested I submit it to GitHub. The instructions of this challenge introduce the use of a “generic name” (optional) so I used “monospace” in the generic name. font-family: FAMILYNAME, GENERICNAME; . I would then get the error: " You should only use an h2 selector to change your font", which I was doing. It turns out any use of a generic name won't be accepted. Please update question to say "don't use generic for now" or update possible answer to allow for a generic insert. Add a Link to the page with the problem: Tell us about your browser and operating system: Browser Name: Chrome Browser Version:.. Operating System: Win 10 If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box): See link above for insight.
. I would support modifying the test to allow for a fallback value as shown in the challenge description. Before opening this up for contribution, though, I'd like some additional feedback to see if there is support for this change.
Thank you, for taking the time to bring this up. Importantly, the instructions do not mention anything about the generic font. In fact, they are quite clear about what is expected. In my opinion, there is no issue here. Also, I do not see this confusion popping up on the forum. Perhaps the point of discussion should be: Is it best-practice to use the generic/fall-back? If so, then we should consider rewriting the instructions, along with the tests. Something to keep in mind: The lesson is about importing a setting the font-family (the next lesson covers this)
I do agree that I haven't seen much confusion for this lesson popping up on the forum. The lesson does ask the camper to set the font-family of the element to - but the next lesson covers the "font degradation" fall-back value. Maybe it would be best to take this note (and the one below it) and move it to the next lesson? !
Yes, I was thinking the same. It is just, this is the type of information I would expect when first encountering a new property.
I'm not sure I would move it to the next lesson - there's already an example there. What about changing the last three paragraphs to this: If you both want to move it to the next lesson, I'm fine with it - but it seems like generic fonts are described there pretty good.

Discussion:
```js assert( <del> /s*[^.]h2s*{s*font-family:s*(['"]?)Lobster1s*(;s*}|})/gi.test( </del> <ins> /s*[^.]h2s*{s*font-familys*:s*('|"|)Lobster1s*(,s*('|"|)[a-z -]+3s*)?(;s*}|})/gi.test( </ins> code ) );
Change:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Describe your problem and how to reproduce it: The test statement should return doesn’t make sense, since 2008 is after 1977. Add a Link to the page with the problem: Tell us about your browser and operating system: Browser Name: Firefox Browser Version: 81.0.2 Operating System: Linux Mint
there seems to be just an issue in the test text: There is just to make so that the two functions, the one executed and the one written match. I will mark for first timers this is the file:

Discussion:
testString: assert(typeof findXmasSunday === 'function'); - text: <code>findXmasSunday(2000, 2100)</code> should return an array. testString: assert(typeof findXmasSunday(2000, 2100) === 'object'); <del> - text: <code>findXmasSunday(2008, 2121)</code> should return <code>[1977, 1983, 1988, 1994, 2005, 2011, 2016]</code> </del> <ins> - text: <code>findXmasSunday(1970, 2017)</code> should return <code>[1977, 1983, 1988, 1994, 2005, 2011, 2016]</code> </ins> testString: assert.deepEqual(findXmasSunday(1970, 2017), firstSolution); - text: <code>findXmasSunday(2008, 2121)</code> should return <code>[2011, 2016, 2022, 2033, 2039, 2044, 2050, 2061, 2067, 2072, 2078, 2089, 2095, 2101, 2107, 2112, 2118]</code> testString: assert.deepEqual(findXmasSunday(2008, 2121), secondSolution);
Change:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Describe your problem and how to reproduce it: The sample output in the sidebar has the date . The date should read . Source: and many other websites. Add a Link to the page with the problem: Tell us about your browser and operating system: Browser Name: Firefox Browser Version: 82 Operating System: Linux Mint
Looks like a fix would entail editing the challenge - the tests themselves appear to be accurate. I will open this up to first timers. thanks for the catch!

Discussion:
Return an array with the current date in the formats: <ul> <li>2007-11-23</li> <del> <li>Sunday, November 23, 2007</li> </del> <ins> <li>Friday, November 23, 2007</li> </ins> </ul> <del> Example output: <code>['2007-11-23', 'Sunday, November 23, 2007']</code> </del> <ins> Example output: <code>['2007-11-23', 'Friday, November 23, 2007']</code> </ins> </section> ## Instructions
Change:
So, I tried submitting the following code: When I ran it through the tests, all but the last one passed. Then I in what I was supposed to do without removing the inline styles: This one passed all the tests! I know we were supposed to put stuff in the style tag, but I discovered this issue because I didn't want to do so much typing. There doesn't seem to be some check in the last test that looks at inline styles, unlike the rest. Can you look into it?
Hello there, Thank you, for taking the time to open this issue. This is expected behaviour. Recently, the test for the element was changed, because the usual method of testing did not work on some browsers (Safari, if I recall). So, unless we find a better method to test all of the elements, I would not advise any of the tests being changed. However, perhaps we could change the instructions to be explicit about requiring campers to not use inline-styles. I will leave this open for others to weigh in on.
I think this is about the only thing we can currently do.
I am good with adding a note there. Something like this: That whole thing could probably be shortened to something like this maybe: I'm fine with it either way.
I like second shortened suggestion.
Any idea why it’s only the h6 that doesn’t work? I’ve made a PR with the above but wonder if removing the h6 altogether from this challenge might be slightly more elegant in lieu of not having a different way to test?

Discussion:
## Instructions <section id='instructions'> <del> <ul><li>Set the <code>font-size</code> of the <code>h1</code> tag to 68px.</li><li>Set the <code>font-size</code> of the <code>h2</code> tag to 52px.</li><li>Set the <code>font-size</code> of the <code>h3</code> tag to 40px.</li><li>Set the <code>font-size</code> of the <code>h4</code> tag to 32px.</li><li>Set the <code>font-size</code> of the <code>h5</code> tag to 21px.</li><li>Set the <code>font-size</code> of the <code>h6</code> tag to 14px.</li></ul> </del> <ins> <p>In the <code>style</code> tags, set the <code>font-size</code> of the:</p> <ul> <li><code>h1</code> tag to 68px.</li> <li><code>h2</code> tag to 52px.</li> <li><code>h3</code> tag to 40px.</li> <li><code>h4</code> tag to 32px.</li> <li><code>h5</code> tag to 21px.</li> <li><code>h6</code> tag to 14px.</li> </ul> </ins> </section> ## Tests
Change:
Also, if you traverse from a right-to-left language (Arabic, Chinese), then go to English, the text remains right-to-left: ! Originally posted by in
Are translations available ?. Because If I go to the page click on translation and select a language , then the language remains as english , just the LTR or RTL thing changes. <img width="960" alt="issue" src="https://user-"
Not for many of the languages yet. They still need to be translated by contributors.

Discussion:
// Used from https://github.com/ckoliber/docsify-rtl/blob/master/build/docsify-rtl.js, // Currently this is a hack because can't use the plugin as is. <del> if (vm.route.path.search('Arabic') !== -1) { </del> <ins> if (vm.route.path.search('Arabic') !== -1 || vm.route.path.search('Hebrew') !== -1) { </ins> for (var counter = 0, elements = document.getElementsByClassName("markdown-section"); counter < elements.length; counter++) { var item = elements[counter]; item.dir = "rtl"; } }; <ins> if (vm.route.path.search('Arabic') === -1 && vm.route.path.search('Hebrew') === -1) { for (var counter = 0, elements = document.getElementsByClassName("markdown-section"); counter < elements.length; counter++) { var item = elements[counter]; item.dir = "ltr"; } }; </ins> return ( markdown + 'n----n' +
Change:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Describe your problem and how to reproduce it: The challenge "Testing Object for Properties" passes with wrong code: Add a Link to the page with the problem: users find the old solutions, paste that in the editor, and then add a new property to the object... My proposal is to add a few more tests - even obscured if needed, to avoid these kind of solutions passing
I created a PR to deal with this issue.

Discussion:
testString: 'assert(checkObj({city: "Seattle"}, "city") === "Seattle");' - text: '<code>checkObj({city: "Seattle"}, "district")</code> should return <code>"Not Found"</code>.' testString: 'assert(checkObj({city: "Seattle"}, "district") === "Not Found");' <ins> - text: '<code>checkObj({pet: "kitten", bed: "sleigh"}, "gift")</code> should return <code>"Not Found"</code>.' testString: 'assert(checkObj({pet: "kitten", bed: "sleigh"}, "gift") === "Not Found");' </ins> ``` </section>
Change:
To Reproduce Steps to reproduce the behavior: to /learn or /settings with the theme set to dark off internet connection and wait Actual behavior The offline warning message shows up, but the text is quite hard to read. Screenshots <img width="1680" alt="Screen Shot 2020-11-09 at 12 22 16 AM" src="https://user-"
WCAG does say the contrast is only 1.41:
The notification background is hardcoded and the font color is being handled based on theme. We have let bootstrap handle the styling for the notifications since they handle the font color and the background and look well on both themes. So doing the followings should do the trick. Add as a class here: and remove the from here:
I think the best way is to implement luma-corrected calculations. The first obvious implication of going with a luma-corrected approach is that the notification background color needs to switch to an RBG declaration for the backgrounds, calculate the luma from whatever method we choose, and use it on the foreground color declaration, which can (and will) still be HSL color. I am saying this because this would allow the font color to switch based on the contrast of the notification background contrast from to and vice versa.
can I work on this? I might need help. please guide me.
that is a cool trick. Thanks for sharing the link. Since are planning to move off of bootstrap, we should consider luma-corrected calculations in how we implement our dark/light themes during the rewrite process. Meanwhile, I think we could move forward with making the simple change that resolves this issue. sure. Make sure you read this:

Discussion:
} return showWarning ? ( <del> <div className='offline-warning'> </del> <ins> <div className='offline-warning alert-info'> </ins> You appear to be offline, your progress may not be being saved. </div> ) : null;

display: flex; justify-content: center; align-items: center; <del> background: lightblue; </del> }
Change:
Describe your problem and how to reproduce it: There is a bad link on the page. The link to 'help by answering coding questions' takes you to which says "Oops! That page doesn’t exist or is private." Add a Link to the page with the problem: Recommended fix, suggestions (how would you update it?): I tried looking around the forum for the page that that used to link to but I am not sure. I would say it could just go to the home page. If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box): <img width="1679" alt="Screen Shot 2020-11-20 at 8 48 48 AM" src="https://user-"<img width="1679" alt="Screen Shot 2020-11-20 at 8 49 35 AM" src="https://user-"
Nice catch! This link broke when we restructured our subforum categories, I believe. The link is located in this file: , and could be updated to redirect to the base forum URL I think.
When I click on the link from , it loads the forum in he Project Feedback category. There is not error. We did not change that category on the forum. It is still the same. Any thoughts?
I get the Project Feedback category off the second link ("Give feedback on coding projects"), but on the "Help by answering coding questions" I'm getting a 404.
I agree with adding a link to for . I have opened this issue up for .

Discussion:
## Here are some quick and fun ways you can help the community. <del> - <span class='cover-icon'><i class="fas fa-question-circle"></i></span> [Help by answering coding questions](https://forum.freecodecamp.org/c/help?max_posts=1) on our community forum. </del> <ins> - <span class='cover-icon'><i class="fas fa-question-circle"></i></span> [Help by answering coding questions](https://forum.freecodecamp.org) on our community forum. </ins> - <span class='cover-icon'><i class="fas fa-comments"></i></span> [Give feedback on coding projects](https://forum.freecodecamp.org/c/project-feedback?max_posts=1) built by campers. - <span class='cover-icon'><i class="fas fa-language"></i></span> [Help us translate](https://translate.freecodecamp.org) these Contributing Guidelines. - <span class='cover-icon'><i class="fab fa-github"></i></span> [Contribute to our open source codebase](/index?id=our-open-source-codebase) on GitHub.
Change:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Describe your problem and how to reproduce it: This challenge is not aceepting the regex which is valid and matches all the conditions except one condition because it is checking whether 2 is used in the regex or if is used along with or . So, it does not accept the above regex. Add a Link to the page with the problem: Tell us about your browser and operating system: Browser Name: Firefox Browser Version: 83.0 (64-bit) Operating System: macOS 11.0.1 Big Sur If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):
Thank you, for taking the time to raise this issue. I can confirm the issue. I suggest the test in question be removed: javascript assert( (/ (/(s)(?=.*(1|2))/g) ); ` There should be no need for it, as the test conditions satisfy the requirements of the instructions. I am opening this to first timers only
I'm fine with removing that test.
I've went ahead and changed this one to start familiarizing myself with the code and hopefully keep contributing. Please tell me if there's any problem.

Discussion:
assert(reRegex.source.match(/1|2/g).length >= 2); ``` <del> Your regex should have two spaces separating the three numbers. ```js assert( reRegex.source.match(/ |s/g).length === 2 || reRegex.source.match(/(s)(?=.*(1|2))/g) ); ``` </del> Your regex should match `"42 42 42"`. ```js
Change:
This is a dumb problem and I am new to GitHub so please forgive me for any weirdness. Basically, on this page, we see this explanation: This signals to JavaScript that the following quote is not the end of the string, but should instead appear inside the string. So if you were to print this to the console, you would get: Alan said, "Peter is learning JavaScript". and we are asked to make this string: I am a "double quoted" string inside "double quotes". However, I think that the period should be inside the quotations, grammatically. Like "double quotes." Thank you.
Thank you for your bug report, but I think this is in the realm of bike shedding
I do agree with that this is indeed a small typo but I also agree with that it is indeed a grammatical prob. Since this typo got noticed, I'd say let's fix it.
While I think it is fine to correct the typo, I think the tests should be loose enough to accommodate the period inside or outside the last double quote. The point of the challenge is escaping double quotes, so we do not want to get caught up in forcing the user to keep the period inside or outside the quotes. The reason I say this is the new curriculum is going in this direction. We are going to be lenient in the tests when it makes sense to. In my opinion, this is one of those cases.
Sure. Let's keep the tests lenient and fix the typo.
Is this still a first-timers issue now, since the contributor must also modify the test to accommodate both versions of the string?
Ooops. Forgot to update that. Thanks for the catch!
Thank you for your reply. I agree the grammar shouldn’t matter in the challenge. The problem was that when I tried to submit the answer with the “proper grammar,” it told me my answer was wrong, and I had to change it to the “improper” way. I’m an English teacher rather than a programmer, so completing the challenge with the improper grammar hurt my soul a little bit, haha.
Hey , I just made a PR () that fixes the grammar issue and it looks quite simple as there's no need to change the tests. So, let's open this up for , what do you say?
Just to add this: I do not see this as a bug/typo, because I mostly use British-styled English. So, the only reason we might change this is if we are trying to have uniformity about using only American-styled English within the curriculum.
both versions should be allowed, dot inside and dot outside. Your PR just changes wich version is allowed
I didn't knew that it differed in these two styles. If that is the case I'm in favour of closing this issue as it is proper English eitherway. The tests and the sentence in the test question isn't changed in my PR as it is correct. I only changed the example sentence in the PR. (Apologies for the trouble and misunderstanding )
the change discussed here about making both solutions work is not wanted anymore?
Re-opening.

Discussion:
Variable myStr should contain the string: `I am a "double quoted" string inside "double quotes".` ```js <del> assert(myStr === 'I am a "double quoted" string inside "double quotes".'); </del> <ins> assert(/I am a "double quoted" string inside "double quotes(."|".)$/.test(myStr)); </ins> ``` # --seed--
Change:
If I click on a link to a certificate from my settings page, it opens in the same tab. If I click on one from the timeline on my portfolio, it opens in a new tab. We could probably make this consistent. I believe I made the timeline links open in a new tab because there's no nav on the cert pages, so the only way to get back to the site is with the browsers back button. I believe I have also heard an argument that they should open in the same tab so I'm not sure what the better way to go is.
sir.. i would like to solve this i contribute??
please go ahead . No assignment is necessary as described in our . The first comprehensive PR will be considered for review.
So should it open in a new tab or in the same tab? what should happen?
same question as shold happen??
I will double check with the dev team and get back to you.
My vote was to open them in a new tab - like I said, there's no nav on the certs so you have to use the browsers back button to get back to the website.
I agree
I was told, "If the user donates on the certificate, the redux store will not be updated on the other tab and would need a refresh". So, I think that for now, we should open them in the current tab - unless someone has a better solution to that.
Could you clarify this? If the user donates on the certificate opened on a new tab, the redux store will not be opened on the original (settings) tab? This does not sound much like a problem. In fact, I would have said that is expected behaviour, from past experience.
So If a user donates on their certificate the store on that tab gets updated (isDonating: true). When the user goes back to the previous tab to work on the challenges, she will see the donation modal. (unless refresh). Solutions: 1) keep a navigation on the certs and keep them in the same tab 2) open certs in new tab but sync state across tabs, Might find this one helpful.
What is the chosen path to solve this issue? Or am I missing something?
We have not come to an agreement regarding the way to move forward yet. The options are listed . Once we reach an agreement, we should make the experience consistent across the app.

Discussion:
<Col className='certifications' sm={10} smPush={1}> <Link className='btn btn-lg btn-primary btn-block' <del> external={true} </del> to={`/certification/${username}/${cert.certSlug}`} > View {cert.title}

{certPath ? ( <Link className='timeline-cert-link' <del> external={true} to={`certification/${username}/${certPath}`} </del> <ins> to={`/certification/${username}/${certPath}`} </ins> > {challengeTitle} <CertificationIcon />
Change:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Describe your problem and how to reproduce it: using the code in this file: the challenge is passable by uncommenting lines 56-59 if (curr === null) { (curr, "curr") return null } The wording of the test is "Trying to remove an element that does not exist should return null." yet the assertions only test for removing a node that does not exist in an empty tree. What about removing nodes that do not exist in a tree that has nodes? ` Add a Link to the page with the problem: My pull request: Tell us about your browser and operating system: Browser Name: Browser Version: Operating System: If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):
To summarize the issue: Test checks only if trying to remove non-existing element from empty tree will return null. It doesn't check if the same happens for removing non-existing element from non-empty tree. This can lead to implementation, which doesn't handle the second case at all (and even as in example above can end up with error), and still pass challenge.

Discussion:
); ``` <ins> Trying to remove an element from an empty tree should return `null`. ```js assert( (function () { var test = false; if (typeof BinarySearchTree !== 'undefined') { test = new BinarySearchTree(); } else { return false; } if (typeof test.remove !== 'function') { return false; } return test.remove(100) == null; })() ); ``` </ins> Trying to remove an element that does not exist should return `null`. ```js

if (typeof test.remove !== 'function') { return false; } <ins> test.add(15); test.add(30); </ins> return test.remove(100) == null; })() );
Change:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Describe your problem and how to reproduce it: Load challenge. Observe that there are two instances of "{/ Change code below this line /}". The second should be {/ Change code above this line /} Could lead to confusion with users unsure if there's more to do in the challenge after adding the correct code to the challenge. Add a Link to the page with the problem: Tell us about your browser and operating system: Browser Name: Chrome Browser Version: 87.0.4280.88 Operating System: MacOS If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box): <img width="481" alt="Screen Shot 2020-12-12 at 10 26 49 PM" src="https://user-"

Discussion:
<div> {/* Change code below this line */} <h1>Active Users: </h1> <del> {/* Change code below this line */} </del> <ins> {/* Change code above this line */} </ins> </div> ); }